blob: b4a148d69e172dca85f69c4148e0e89e36efe6fe [file] [log] [blame]
timothy@apple.combffde042008-09-24 02:07:39 +000012008-09-23 Timothy Hatcher <timothy@apple.com>
2
timothy@apple.com1d5227a2008-09-24 02:08:01 +00003 Remove the previous Inspector search code to make room for the new stuff.
4
5 https://bugs.webkit.org/show_bug.cgi?id=21005
6
7 Reviewed by Oliver Hunt.
8
9 * page/inspector/inspector.css:
10 * page/inspector/inspector.html:
11 * page/inspector/inspector.js:
12 (WebInspector.get/set showingSearchResults): Removed.
13 (WebInspector.searchResultsKeyDown): Removed.
14 (WebInspector.searchResultsResizerDragStart): Removed.
15 (WebInspector.searchResultsResizerDragEnd): Removed.
16 (WebInspector.searchResultsResizerDrag): Removed.
17 (WebInspector.performSearch): Removed searching parts.
18
192008-09-23 Timothy Hatcher <timothy@apple.com>
20
timothy@apple.com5e915b722008-09-24 02:07:56 +000021 Use the Array.remove helper function in more places.
22
23 https://bugs.webkit.org/show_bug.cgi?id=21037
24
25 Reviewed by Kevin McCullough.
26
27 * page/inspector/ResourceCategory.js:
28 (WebInspector.ResourceCategory.prototype.removeResource): Use Array.remove.
29 * page/inspector/ResourcesPanel.js:
30 (WebInspector.ResourcesPanel.prototype.removeResource): Ditto.
31 * page/inspector/inspector.js:
32 (WebInspector.removeResource): Ditto.
33
342008-09-23 Timothy Hatcher <timothy@apple.com>
35
timothy@apple.com3e116f12008-09-24 02:07:50 +000036 Fixes a bug where inspecting a node after reloading the page
37 would not reveal the node in the DOM tree. The TreeOutline
38 was not being told to forget decendants of a removed child.
39 So old TreeElements would be found that are not in the tree.
40
41 https://bugs.webkit.org/show_bug.cgi?id=21036
42
43 Reviewed by Kevin McCullough.
44
45 * page/inspector/treeoutline.js:
46 (TreeOutline._removeChildAtIndex): Call _forgetChildrenRecursive
47 in addition to _forgetTreeElement.
48 (TreeOutline._removeChildren): Call _forgetChildrenRecursive
49 in addition to _forgetTreeElement.
50 (TreeOutline._rememberTreeElement): Use Array.indexOf to quickly
51 search for known elements.
52 (TreeOutline._forgetTreeElement): Use Array.remove to remove elements.
53 (TreeOutline._forgetChildrenRecursive): Recursively traverse the
54 descendants and call _forgetTreeElement.
55 * page/inspector/utilities.js:
56 (Array.prototype.remove): Speed up this function by using Array.indexOf
57 when onlyFirst is true.
58
592008-09-23 Timothy Hatcher <timothy@apple.com>
60
timothy@apple.com2e9f2ff2008-09-24 02:07:45 +000061 Fixes a bug where inspecting some short text nodes does
62 not reveal them in the Elements panel DOM tree.
63
64 https://bugs.webkit.org/show_bug.cgi?id=21035
65
66 Reviewed by Oliver Hunt.
67
68 * page/inspector/ElementsTreeOutline.js:
69 (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
70 The revealAndSelectNode() method might find a different element
71 if there is inlined text, and the select() call would change the
72 focusedDOMNode and reenter this setter. So to avoid calling
73 focusedNodeChanged() twice, first check if _focusedDOMNode is
74 the same node as the one passed in.
75 (WebInspector.ElementsTreeOutline.prototype.update): Remove use of
76 this.treeOutline, since this is the TreeOutline.
77 (WebInspector.ElementsTreeOutline.prototype.findTreeElement): Added.
78 Provides default functions for isAncestor, getParet and equal.
79 Calls the base protoype's findTreeElement. If that returns null
80 and the node is a text node, try finding it's parent.
81 (WebInspector.ElementsTreeOutline.prototype.revealNode): Removed.
82 Renamed to revealAndSelectNode.
83 (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
84 Selects and reveals the node passed in. Use the simple findTreeElement.
85 (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
86 Remove use of this.treeOutline, since this is the TreeOutline.
87
882008-09-23 Timothy Hatcher <timothy@apple.com>
89
timothy@apple.combffde042008-09-24 02:07:39 +000090 Fixes an exception that happened when removing a Resource
91 from the ResourcesPanel.
92
93 https://bugs.webkit.org/show_bug.cgi?id=21034
94
95 Reviewed by Kevin McCullough.
96
97 * page/inspector/ResourcesPanel.js:
98 (WebInspctor.ResourcesPanel.prototype.removeResource):
99 Remove the graphElement.
100
kmccullough@apple.com70d32f22008-09-24 01:18:31 +00001012008-09-23 Kevin McCullough <kmccullough@apple.com>
102
103 Fixed "Time" to "Tim"
104
105 * ChangeLog:
106
zimmermann@webkit.org718a2232008-09-24 01:00:42 +00001072008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
108
109 Reviewed by Oliver.
110
111 Move mapInstanceToElement/removeInstanceMapping/instancesForElement
112 from SVGDocumentExtensions to SVGElement. It's more useful to store
113 the list of SVGElementInstances per SVGElement, instead of using
114 a document-wide hash for this purpose.
115
116 * svg/SVGAnimateMotionElement.cpp:
117 (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
118 * svg/SVGAnimateTransformElement.cpp:
119 (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
120 * svg/SVGAnimationElement.cpp:
121 (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
122 * svg/SVGDocumentExtensions.cpp:
123 (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
124 * svg/SVGDocumentExtensions.h:
125 * svg/SVGElement.cpp:
126 (WebCore::SVGElement::mapInstanceToElement):
127 (WebCore::SVGElement::removeInstanceMapping):
128 (WebCore::SVGElement::instancesForElement):
129 * svg/SVGElement.h:
130 * svg/SVGElementInstance.cpp:
131 (WebCore::SVGElementInstance::SVGElementInstance):
132 (WebCore::SVGElementInstance::~SVGElementInstance):
133 (WebCore::SVGElementInstance::updateAllInstancesOfElement):
134 * svg/SVGElementInstance.h:
135 * svg/SVGStyledElement.cpp:
136 (WebCore::SVGStyledElement::svgAttributeChanged):
137 (WebCore::SVGStyledElement::childrenChanged):
138 * svg/SVGStyledElement.h:
139
kevino@webkit.org706ea432008-09-24 00:53:56 +00001402008-09-23 Kevin Ollivier <kevino@theolliviers.com>
141
142 wx build fix.
143
144 * WebCoreSources.bkl:
145
zimmermann@webkit.org97c71082008-09-24 00:23:28 +00001462008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
147
148 Rubber stamped by Sam.
149
150 Move code from EventTarget to EventTargetNode.
151
152 I refactored most parts to live in EventTarget, a year ago,
153 though the implementation of EventTargetSVGElementInstance is
154 done in another way, that obsoletes this.
155
156 * dom/Document.cpp:
157 (WebCore::Document::addListenerTypeIfNeeded):
158 * dom/Document.h:
159 * dom/EventTarget.cpp:
160 * dom/EventTarget.h:
161 (WebCore::allowEventDispatch):
162 * dom/EventTargetNode.cpp:
163 (WebCore::EventTargetNode::insertedIntoDocument):
164 (WebCore::EventTargetNode::removedFromDocument):
165 (WebCore::EventTargetNode::willMoveToNewOwnerDocument):
166 (WebCore::EventTargetNode::didMoveToNewOwnerDocument):
167 (WebCore::EventTargetNode::addEventListener):
168 (WebCore::EventTargetNode::removeEventListener):
169 (WebCore::EventTargetNode::removeAllEventListeners):
170 (WebCore::EventTargetNode::handleLocalEvents):
171 (WebCore::setCurrentEventTargetRespectingSVGTargetRules):
172 (WebCore::EventTargetNode::dispatchEvent):
173 (WebCore::EventTargetNode::dispatchGenericEvent):
174 (WebCore::EventTargetNode::dispatchWindowEvent):
175 (WebCore::EventTargetNode::removeEventListenerForType):
176 * dom/EventTargetNode.h:
177 * svg/EventTargetSVGElementInstance.cpp:
178 (WebCore::EventTargetSVGElementInstance::dispatchEvent):
179 * svg/SVGElement.cpp:
180 (WebCore::SVGElement::sendSVGLoadEventIfPossible):
181 * svg/SVGElement.h:
182 (WebCore::SVGElement::supplementalTransform):
183
hyatt@apple.com7c9fc6f2008-09-24 00:14:42 +00001842008-09-23 Dave Hyatt <hyatt@apple.com>
185
186 Fix for bug 21012. The Aqua scrollbar was returning the wrong track rect on Windows Aqua theme. Make
187 sure to not accidentally fall into the vertical scrollbar case for horizontal scrollbars. :)
188
189 Reviewed by Sam Weinig
190
191 * platform/mac/ScrollbarThemeMac.mm:
192 (WebCore::ScrollbarThemeMac::trackRect):
193 * platform/win/ScrollbarThemeSafari.cpp:
194 (WebCore::ScrollbarTheme::nativeTheme):
195 (WebCore::ScrollbarThemeSafari::trackRect):
196
bdakin@apple.comaab5d692008-09-24 00:09:33 +00001972008-09-23 Beth Dakin <bdakin@apple.com>
198
199 Reviewed by Sam Weinig.
200
201 Fix for https://bugs.webkit.org/show_bug.cgi?id=21041 "Add Contact"
202 link at gmail does not support AXPress action
203 and corresponding: <rdar://problem/6216178>
204
205 I fixed this bug by making AccessibilityObject::anchorElement
206 support ARIA links.
207
208 * page/AccessibilityImageMapLink.cpp:
209 (WebCore::AccessibilityImageMapLink::anchorElement):
210 * page/AccessibilityImageMapLink.h:
211 * page/AccessibilityObject.cpp:
212 (WebCore::AccessibilityObject::anchorElement):
213 * page/AccessibilityObject.h:
214 (WebCore::AccessibilityObject::isNativeAnchor):
215 * page/AccessibilityRenderObject.cpp:
216 (WebCore::AccessibilityRenderObject::isNativeAnchor):
217 (WebCore::AccessibilityRenderObject::anchorElement):
218 (WebCore::AccessibilityRenderObject::internalLinkElement):
219 (WebCore::AccessibilityRenderObject::url):
220 * page/AccessibilityRenderObject.h:
221 * page/mac/AccessibilityObjectWrapper.mm:
222 (AXLinkElementForNode):
223
kmccullough@apple.com58f6b182008-09-24 00:05:34 +00002242008-09-23 Kevin McCullough <kmccullough@apple.com>
225
kmccullough@apple.com70d32f22008-09-24 01:18:31 +0000226 Reviewed by Tim and Oliver.
kmccullough@apple.com58f6b182008-09-24 00:05:34 +0000227
228 Bug 20949: Catch repeated messages in Inspector Controller to limit
229 memory usage
230 - Store the repeat count in the Console Message object, in the
231 Inspector Controller and JS ConsoleMessage object.
232
233 * page/InspectorController.cpp:
234 (WebCore::ConsoleMessage::ConsoleMessage):
235 (WebCore::ConsoleMessage::operator==):
236 (WebCore::InspectorController::InspectorController):
237 (WebCore::InspectorController::addConsoleMessage):
238 (WebCore::InspectorController::addScriptConsoleMessage):
239 * page/InspectorController.h:
240 * page/inspector/Console.js:
241 * page/inspector/Resource.js:
242 * page/inspector/ResourcesPanel.js:
243 * page/inspector/SourceFrame.js:
244
zimmermann@webkit.org29d22032008-09-23 23:44:20 +00002452008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
246
247 Reviewed by Eric.
248
249 Working on proper EventTarget support for SVGElementInstance.
250
251 Add new EventTargetSVGElementInstance class, and it's corresponding JS wrapper.
252 Finally JSEventTargetBase, is actually used for another class than JSEventTargetnode.
253
254 Remove EventTarget inheritance from SVGElementInstance, and the manual "TreeShared"
255 implementation. Let it use TreeShared directly.
256
257 It's not activated so far (SVGUseElement still creating SVGElementInstance objects).
258 The transition to EventTargetSVGElementInstance will be done in a few individual patches.
259
260 * GNUmakefile.am:
261 * WebCore.pro:
262 * WebCore.vcproj/WebCore.vcproj:
263 * WebCore.xcodeproj/project.pbxproj:
264 * bindings/js/JSEventTargetBase.cpp:
265 (WebCore::retrieveEventTargetAndCorrespondingNode):
266 (WebCore::toJS):
267 * bindings/js/JSEventTargetBase.h:
268 * bindings/js/JSEventTargetSVGElementInstance.cpp: Added.
269 (WebCore::):
270 (WebCore::JSEventTargetSVGElementInstance::JSEventTargetSVGElementInstance):
271 (WebCore::JSEventTargetSVGElementInstance::createPrototype):
272 (WebCore::JSEventTargetSVGElementInstance::setListener):
273 (WebCore::JSEventTargetSVGElementInstance::getListener):
274 (WebCore::toEventTargetSVGElementInstance):
275 * bindings/js/JSEventTargetSVGElementInstance.h: Added.
276 (WebCore::JSEventTargetSVGElementInstance::prototypeClassName):
277 (WebCore::JSEventTargetSVGElementInstance::getOwnPropertySlot):
278 (WebCore::JSEventTargetSVGElementInstance::getValueProperty):
279 (WebCore::JSEventTargetSVGElementInstance::put):
280 (WebCore::JSEventTargetSVGElementInstance::putValueProperty):
281 * bindings/js/JSSVGElementInstanceCustom.cpp: Added.
282 (WebCore::toJS):
283 * bindings/objc/DOM.mm:
284 (+[DOMNode _wrapEventTarget:WebCore::]):
285 (-[DOMSVGElementInstance _initWithSVGElementInstance:WebCore::]):
286 (+[DOMSVGElementInstance _wrapSVGElementInstance:WebCore::]):
287 (+[DOMSVGElementInstance _wrapEventTarget:WebCore::]):
288 (-[DOMSVGElementInstance WebCore::]):
289 (-[DOMSVGElementInstance addEventListener:listener:useCapture:]):
290 (-[DOMSVGElementInstance addEventListener:::]):
291 (-[DOMSVGElementInstance removeEventListener:listener:useCapture:]):
292 (-[DOMSVGElementInstance removeEventListener:::]):
293 (-[DOMSVGElementInstance dispatchEvent:]):
294 * bindings/objc/DOMEvents.h:
295 * bindings/scripts/CodeGeneratorJS.pm:
296 * bindings/scripts/CodeGeneratorObjC.pm:
297 * svg/EventTargetSVGElementInstance.cpp: Added.
298 (WebCore::EventTargetSVGElementInstance::EventTargetSVGElementInstance):
299 (WebCore::EventTargetSVGElementInstance::~EventTargetSVGElementInstance):
300 (WebCore::EventTargetSVGElementInstance::addEventListener):
301 (WebCore::EventTargetSVGElementInstance::removeEventListener):
302 (WebCore::EventTargetSVGElementInstance::dispatchEvent):
303 * svg/EventTargetSVGElementInstance.h: Added.
304 (WebCore::EventTargetSVGElementInstance::isEventTargetSVGElementInstance):
305 (WebCore::EventTargetSVGElementInstance::toNode):
306 (WebCore::EventTargetSVGElementInstance::toSVGElementInstance):
307 (WebCore::EventTargetSVGElementInstance::refEventTarget):
308 (WebCore::EventTargetSVGElementInstance::derefEventTarget):
309 (WebCore::EventTargetSVGElementInstanceCast):
310 * svg/SVGElement.cpp:
311 (WebCore::SVGElement::dispatchEvent):
312 * svg/SVGElementInstance.cpp:
313 (WebCore::SVGElementInstance::SVGElementInstance):
314 (WebCore::SVGElementInstance::~SVGElementInstance):
315 * svg/SVGElementInstance.h:
316 (WebCore::SVGElementInstance::isEventTargetSVGElementInstance):
317 * svg/SVGElementInstance.idl:
318
mitz@apple.come47c5af2008-09-23 21:47:54 +00003192008-09-23 Dan Bernstein <mitz@apple.com>
320
321 Reviewed by Dave Hyatt.
322
323 - https://bugs.webkit.org/show_bug.cgi?id=21040
324 Pass NULL instead of the identity matrix to CTFontCreateWithGraphicsFont()
325
326 * platform/graphics/mac/SimpleFontDataMac.mm:
327 (WebCore::SimpleFontData::getCTFont):
328
hyatt@apple.com6e6bd8e2008-09-23 21:43:37 +00003292008-09-23 David Hyatt <hyatt@apple.com>
330
331 https://bugs.webkit.org/show_bug.cgi?id=21039
332
333 Teach the viewless Mac scrollbar how to avoid NSWindow's resizer.
334
335 Reviewed by Sam Weinig
336
337 * platform/ScrollView.h:
338 * platform/Scrollbar.cpp:
339 (WebCore::Scrollbar::setFrameGeometry):
340 * platform/Scrollbar.h:
341 * platform/Widget.cpp:
342 (WebCore::Widget::convertFromContainingWindow):
343 * platform/Widget.h:
344 * platform/mac/ScrollViewMac.mm:
345 (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
346 (WebCore::ScrollView::ScrollView):
347 (WebCore::ScrollView::~ScrollView):
348 (WebCore::ScrollView::windowResizerRect):
349 (WebCore::ScrollView::resizerOverlapsContent):
350 (WebCore::ScrollView::adjustOverlappingScrollbarCount):
351 (WebCore::ScrollView::setParent):
352 * platform/mac/WidgetMac.mm:
353 (WebCore::Widget::convertFromContainingWindow):
354
jmalonzo@webkit.orge5598ad2008-09-23 21:33:21 +00003552008-09-23 Dirk Schulze <vbs85@gmx.de>
356
357 Reviewed by Darin Adler. Landed by Jan Alonzo.
358
359 Added support for getImageData() and putImageData()
360 to Cairo.
361
362 [CAIRO] needs getImageData and putImageData support
363 https://bugs.webkit.org/show_bug.cgi?id=20838
364
365 * platform/graphics/cairo/ImageBufferCairo.cpp:
366 (WebCore::ImageBuffer::ImageBuffer):
367 (WebCore::ImageBuffer::getImageData):
368 (WebCore::ImageBuffer::putImageData):
369
jmalonzo@webkit.orgfb939412008-09-23 21:07:50 +00003702008-09-23 Marco Barisione <marco.barisione@collabora.co.uk>
371
372 Reviewed by Holger Freyther.
373
374 http://bugs.webkit.org/show_bug.cgi?id=18987
375 [GTK] Implement SharedBuffer::createWithContentsOfFile and
376 KURL::fileSystemPath
377
378 * GNUmakefile.am: Add KURLGtk.cpp and SharedBufferGtk.cpp.
379 * platform/gtk/KURLGtk.cpp: Added.
380 (WebCore::KURL::fileSystemPath): Implemented.
381 * platform/gtk/SharedBufferGtk.cpp: Added.
382 (WebCore::SharedBuffer::createWithContentsOfFile): Implemented.
383 * platform/gtk/TemporaryLinkStubs.cpp: Remove the old stubs.
384
ap@webkit.org198304c2008-09-23 16:34:41 +00003852008-09-23 Alexey Proskuryakov <ap@webkit.org>
386
ap@webkit.orgccfa60a2008-09-23 20:39:22 +0000387 Reviewed by Oliver Hunt, okayed by Darin Adler.
388
389 <rdar://problem/5575547> REGRESSION: ATOK has no phrase boundary on Safari/Mail.app
390
391 * rendering/InlineTextBox.cpp:
392 (WebCore::InlineTextBox::paintCompositionUnderline): Add 2 pixel spacing between clauses.
393
3942008-09-23 Alexey Proskuryakov <ap@webkit.org>
395
ap@webkit.org198304c2008-09-23 16:34:41 +0000396 Reviewed by Darin Adler.
397
398 https://bugs.webkit.org/show_bug.cgi?id=21023
399 Don't use TEC for encodings supported by ICU
400
401 * platform/text/mac/mac-encodings.txt: Removed x-mac-centraleurroman, x-mac-cyrillic,
402 x-mac-greek, and x-mac-turkish.
403
404 * platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
405 Register aliases for these encodings that are not registered automatically; updated comments.
406
mjs@apple.coma6dc93d2008-09-23 07:46:55 +00004072008-09-23 Maciej Stachowiak <mjs@apple.com>
408
409 Reviewed by Darin.
410
411 - speed up instanceof some more
412 https://bugs.webkit.org/show_bug.cgi?id=20818
413
414 ~2% speedup on EarleyBoyer
415
416 (WebCore updates.)
417
418 * bindings/js/JSQuarantinedObjectWrapper.h:
419 (WebCore::JSQuarantinedObjectWrapper::createStructureID):
420
oliver@apple.combc10aae2008-09-23 07:40:49 +00004212008-09-22 Darin Adler <darin@apple.com>
422
423 Reviewed by Oliver Hunt.
424
425 - fix https://bugs.webkit.org/show_bug.cgi?id=21008
426 getting pixels by index from CanvasPixelArray is unnecessarily slow
427
428 * GNUmakefile.am: Added JSCanvasPixelArrayCustom.h.
429 * WebCore.vcproj/WebCore.vcproj: Ditto.
430 * WebCore.xcodeproj/project.pbxproj: Ditto.
431
432 * bindings/js/JSCanvasPixelArrayCustom.cpp: Removed indexGetter and
433 indexSetter. These are now both inlined, so in the header.
434 * bindings/js/JSCanvasPixelArrayCustom.h: Added. The getByIndex
435 function is what's used for HasCustomIndexGetter. Also moved the
436 indexSetter function here.
437
438 * bindings/scripts/CodeGeneratorJS.pm: Changed HasCustomIndexGetter
439 to use a getByIndex member function rather than an indexGetter static
440 member function in a property slot. This lets us avoid the property
441 slot mechanism's rule where it turns numeric property names into
442 strings in the identifier table, which is good because that's slow.
443 Also added a new property CustomHeader that allows IDL files to
444 introduce headers to be included -- useful when we have functions
445 that we want to inline into the binding.
446
447 * html/CanvasPixelArray.idl: Added CustomHeader attribute.
448
eric@webkit.org924a2d32008-09-23 07:04:11 +00004492008-09-23 Eric Seidel <eric@webkit.org>
450
451 No review, build fix only.
eric@webkit.org8d2a21a2008-09-23 07:23:14 +0000452
453 Another blind stab in the dark.
454
455 * svg/graphics/cg/SVGResourceClipperCg.cpp: Add missing header.
456
4572008-09-23 Eric Seidel <eric@webkit.org>
458
459 No review, build fix only.
eric@webkit.org924a2d32008-09-23 07:04:11 +0000460
461 Third time's the charm, eh? My local build is sadly still not done...
462
463 * platform/graphics/AffineTransform.cpp: remove extra &
464 * platform/graphics/AffineTransform.h: remove extra &
465
eric@webkit.orgf394f462008-09-23 06:38:10 +00004662008-09-22 Eric Seidel <eric@webkit.org>
467
468 No review, build fix only.
469
eric@webkit.orgf9212312008-09-23 06:47:51 +0000470 * platform/graphics/AffineTransform.cpp: remove extra ;
471
4722008-09-22 Eric Seidel <eric@webkit.org>
473
474 No review, build fix only.
475
eric@webkit.orgf394f462008-09-23 06:38:10 +0000476 Speculative fix for the build while I wait for my compile to finish.
477
478 * platform/graphics/AffineTransform.cpp:
479
eric@webkit.org10583212008-09-23 06:05:59 +00004802008-09-22 Dirk Schulze <vbs85@gmx.de>
481
482 Reviewed by eseidel. Landed by eseidel.
483
484 Moved makeMapBetweenRects from SVG/CG to AffineTransform
485 Make SVGResourceClipper::applyClip more cross-platform
486
487 * platform/graphics/AffineTransform.cpp:
488 * platform/graphics/AffineTransform.h:
489 * svg/graphics/cg/CgSupport.cpp:
490 * svg/graphics/cg/CgSupport.h:
491 * svg/graphics/cg/SVGPaintServerGradientCg.cpp:
492 (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
493 * svg/graphics/cg/SVGResourceClipperCg.cpp:
494 (WebCore::SVGResourceClipper::applyClip):
495
alp@webkit.orgfaa63e42008-09-23 03:08:57 +00004962008-09-22 Alp Toker <alp@nuanti.com>
497
498 Reviewed by David Hyatt.
499
500 https://bugs.webkit.org/show_bug.cgi?id=16331
501 [Gtk] no focus when button/checkbox/radiobutton clicked, only when tabbed
502
503 Obey GTK+ focusing conventions for controls and anchor elements.
504
505 It could be interesting to push these decisions up to Settings or
506 ChromeClient some day but this gets things working.
507
508 Right and middle click events still need some work to match GTK+
509 conventions.
510
511 * html/HTMLAnchorElement.cpp:
512 (WebCore::HTMLAnchorElement::isMouseFocusable):
513 * html/HTMLFormControlElement.cpp:
514 (WebCore::HTMLFormControlElement::isMouseFocusable):
515 * page/EventHandler.cpp:
516 (WebCore::EventHandler::sendContextMenuEvent):
517
darin@apple.com4a266462008-09-23 01:24:31 +00005182008-09-22 Darin Adler <darin@apple.com>
519
520 * page/mac/FrameMac.mm:
521 (WebCore::Frame::baseWritingDirectionForSelectionStart): Fix indentation.
522
weinig@apple.comb6a39b72008-09-23 01:19:56 +00005232008-09-22 Sam Weinig <sam@webkit.org>
524
525 Reviewed by Dan Bernstein.
526
527 Patch for https://bugs.webkit.org/show_bug.cgi?id=21013
528 Match Firefox in how we hide HTMLInputElement.selectionStart, selectionEnd
529 and setSelectionRange. This also allows us to remove the legacy JSHTMLInputElementBase
530 class!
531
532 - selectionStart, selectionEnd and setSelectionRange now are visible in iteration of
533 non-selectable input types, but return undefined when accessed.
534
535 * DerivedSources.make:
536 * GNUmakefile.am:
537 * WebCore.pro:
538 * WebCore.vcproj/WebCore.vcproj:
539 * WebCore.xcodeproj/project.pbxproj:
540 * WebCoreSources.bkl:
541 * bindings/js/JSHTMLInputElementBase.cpp: Removed.
542 * bindings/js/JSHTMLInputElementBase.h: Removed.
543 * bindings/js/JSHTMLInputElementCustom.cpp: Added.
544 (WebCore::JSHTMLInputElement::customGetOwnPropertySlot):
545 (WebCore::JSHTMLInputElement::selectionStart):
546 (WebCore::JSHTMLInputElement::selectionEnd):
547 * bindings/js/JSHTMLInputElementCustom.h: Added.
548 * html/HTMLInputElement.idl:
549
mitz@apple.com895c54c2008-09-23 00:48:17 +00005502008-09-22 Dan Bernstein <mitz@apple.com>
551
552 Reviewed by Sam Weinig.
553
554 - fix <rdar://problem/5699571> Mail: Unable to change writing direction to LTR in an empty message
555
556 Not testable in DumpRenderTree or in Safari
557
558 * page/mac/FrameMac.mm:
559 (WebCore::Frame::baseWritingDirectionForSelectionStart): Account for the
560 case that the selection start node is a block.
561
hyatt@apple.com78083552008-09-22 22:17:40 +00005622008-09-22 David Hyatt <hyatt@apple.com>
563
564 https://bugs.webkit.org/show_bug.cgi?id=21007
565
566 Make sure that the scrollbar gets sent a release event on platforms that call handleMouseDoubleClickEvent.
567
568 Reviewed by Sam Weinig
569
570 * page/EventHandler.cpp:
571 (WebCore::EventHandler::handleMouseDoubleClickEvent):
572
eric@webkit.orgb57170b2008-09-22 21:44:28 +00005732008-09-22 Eric Seidel <eric@webkit.org>
574
575 No review, rollback only.
576
577 Roll out Peter's change (per his request)
578 http://trac.webkit.org/changeset/36069
579 https://bugs.webkit.org/show_bug.cgi?id=19663
580 This change has been the source of numerous regressions
581 (several of which were latent bugs revealed by this change,
582 others were bugs in this change)
583
584 * platform/graphics/BitmapImage.cpp:
585 (WebCore::BitmapImage::BitmapImage):
586 (WebCore::BitmapImage::startAnimation):
587 (WebCore::BitmapImage::advanceAnimation):
588 * platform/graphics/BitmapImage.h:
589 * platform/graphics/cairo/ImageCairo.cpp:
590 (WebCore::BitmapImage::draw):
591 * platform/graphics/cg/ImageCG.cpp:
592 (WebCore::BitmapImage::draw):
593 * platform/graphics/qt/ImageQt.cpp:
594 (WebCore::BitmapImage::draw):
595 * platform/graphics/wx/ImageWx.cpp:
596 (WebCore::BitmapImage::draw):
597
mitz@apple.comdc318202008-09-22 21:32:14 +00005982008-09-22 Dan Bernstein <mitz@apple.com>
599
600 Reviewed by Sam Weinig.
601
602 - fix <rdar://problem/5158514> Switch the complex text code path to Core Text
603
604 Tests: platform/mac-snowleopard/fast/text/myanmar-shaping.html
605 platform/mac-snowleopard/fast/text/thai-combining-mark-positioning.html
606
607 * config.h: Use Core Text if not building for Leopard or Tiger.
608
hyatt@apple.com143e97c2008-09-22 21:03:02 +00006092008-09-22 David Hyatt <hyatt@apple.com>
610
611 https://bugs.webkit.org/show_bug.cgi?id=21006
612
613 Add code that paints an NSView-less scroller using HIThemeDrawTrack. This scrollbar is still not
614 switched on. There are still a few more refinements to make to the rendering and behavior.
615
616 Reviewed by Darin Adler
617
618 * platform/ScrollbarThemeComposite.cpp:
619 (WebCore::ScrollbarThemeComposite::paint):
620 * platform/ScrollbarThemeComposite.h:
621 (WebCore::ScrollbarThemeComposite::paintTrack):
622 (WebCore::ScrollbarThemeComposite::paintButton):
623 (WebCore::ScrollbarThemeComposite::paintThumb):
624 * platform/mac/ScrollbarThemeMac.h:
625 * platform/mac/ScrollbarThemeMac.mm:
626 (WebCore::ScrollbarThemeMac::backButtonRect):
627 (WebCore::ScrollbarThemeMac::forwardButtonRect):
628 (WebCore::scrollbarPartToHIPressedState):
629 (WebCore::ScrollbarThemeMac::paint):
630 * platform/mac/WidgetMac.mm:
631 (WebCore::Widget::invalidateRect):
632
simon.fraser@apple.com0f83a512008-09-22 20:19:53 +00006332008-09-22 Chris Marrin <cmarrin@apple.com>
634
635 Reviewed by Sam Weinig
636
637 transition end event when -webkit-transition-property: all puts wrong
638 propertyName in event
639 https://bugs.webkit.org/show_bug.cgi?id=20903
640
641 * page/animation/ImplicitAnimation.cpp:
642 (WebCore::ImplicitAnimation::sendTransitionEvent):
643
cfleizach@apple.com70013042008-09-22 18:30:36 +00006442008-09-22 Chris Fleizach <cfleizach@apple.com>
645
646 Reviewed by Darin Adler.
647
cfleizach@apple.comdebb8722008-09-22 18:47:16 +0000648 <rdar://problem/6230234> AXTable should probably not be exposed in there's only one cell
649
650 Test: accessibility/table-one-cell.html
651
652 * page/AccessibilityTable.cpp:
653 (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
654
6552008-09-22 Chris Fleizach <cfleizach@apple.com>
656
657 Reviewed by Darin Adler.
658
cfleizach@apple.com70013042008-09-22 18:30:36 +0000659 <rdar://problem/6167779> Setting AXSelectedTextRange for TextAreas in a WebView behaves incorrectly
660
661 Test: accessibility/textarea-selected-text-range.html
662
663 * page/AccessibilityRenderObject.cpp:
664 (WebCore::AccessibilityRenderObject::setSelectedTextRange):
665
hyatt@apple.com4139b152008-09-22 18:21:37 +00006662008-09-22 David Hyatt <hyatt@apple.com>
667
668 Clean up some parent relationships in the back end stylesheet code. Make sure parentStyleSheet
669 properly walks up nested rule blocks to reach the parent sheet instead of giving up at the immediate
670 parent. Also fix the doc() method so that it is properly set when the parent of the sheet is an import
671 rule.
672
673 Reviewed by Sam Weinig
674
675 Added fast/css/nested-rule-parent-sheet.html
676
677 * css/CSSImportRule.cpp:
678 (WebCore::CSSImportRule::insertedIntoParent):
679 * css/CSSRule.cpp:
680 (WebCore::CSSRule::parentStyleSheet):
681 (WebCore::CSSRule::parentRule):
682 * css/CSSStyleSheet.cpp:
683 (WebCore::CSSStyleSheet::CSSStyleSheet):
684 * css/CSSStyleSheet.h:
685
mitz@apple.comd409a262008-09-22 18:17:57 +00006862008-09-22 Dan Bernstein <mitz@apple.com>
687
688 Reviewed by Sam Weinig.
689
690 - fix https://bugs.webkit.org/show_bug.cgi?id=21002
691 Make the ATSUI code path respect spacingDisabled()
692
693 Fixes svg/text/text-spacing-01-b.svg in run-webkit-tests --complex-text
694
695 * platform/graphics/mac/FontMacATSUI.mm:
696 (WebCore::overrideLayoutOperation):
697
mjs@apple.com221b4752008-09-22 15:03:52 +00006982008-09-22 Maciej Stachowiak <mjs@apple.com>
699
700 Reviewed by Cameron Zwarich.
701
702 - speed up instanceof operator by replacing implementsHasInstance method with a TypeInfo flag
703
704 Partial work towards <https://bugs.webkit.org/show_bug.cgi?id=20818>
705
706 2.2% speedup on EarleyBoyer benchmark.
707
708 * bindings/js/JSQuarantinedObjectWrapper.cpp:
709 * bindings/js/JSQuarantinedObjectWrapper.h:
710 (WebCore::JSQuarantinedObjectWrapper::createStructureID):
711 * bindings/scripts/CodeGeneratorJS.pm:
712
aroben@apple.comd5cbddc2008-09-22 14:31:08 +00007132008-09-22 Adam Roben <aroben@apple.com>
714
715 Windows build fix
716
717 * WebCore.vcproj/WebCore.vcproj: Add a missing </File> tag.
718
mjs@apple.coma173abd2008-09-22 13:59:06 +00007192008-09-22 Maciej Stachowiak <mjs@apple.com>
720
721 Reviewed by Dave Hyatt.
722
723 Based on initial work by Darin Adler.
724
725 - replace masqueradesAsUndefined virtual method with a flag in TypeInfo
726 - use this to JIT inline code for eq_null and neq_null
727 https://bugs.webkit.org/show_bug.cgi?id=20823
728
729 * WebCore.xcodeproj/project.pbxproj:
730 * WebCore.vcproj/WebCore.vcproj:
731 * bindings/js/JSCSSStyleDeclarationCustom.cpp:
732 (WebCore::JSCSSStyleDeclaration::nameGetter):
733 * bindings/js/JSHTMLAllCollection.cpp: Added.
734 (WebCore::):
735 * bindings/js/JSHTMLAllCollection.h:
736 (WebCore::JSHTMLAllCollection::createStructureID):
737 (WebCore::JSHTMLAllCollection::toBoolean):
738
vestbo@webkit.orgab848362008-09-22 13:27:06 +00007392008-09-22 Tor Arne Vestbø <tavestbo@trolltech.com>
740
741 Reviewed by Simon.
742
743 Fix the QtWebKit build
744
745 * bridge/qt/qt_instance.cpp:
746 (JSC::Bindings::QtRuntimeObjectImp::construct):
747 * bridge/qt/qt_runtime.cpp:
748
alp@webkit.orgcc9b0812008-09-22 08:53:06 +00007492008-09-22 Alp Toker <alp@nuanti.com>
750
751 Suggested by David Hyatt.
752
753 Build fix: ScrollView::update() is still used by Document.cpp on !MAC
754 so make it public.
755
756 * platform/ScrollView.h:
757
hyatt@apple.com7cb18562008-09-22 07:57:52 +00007582008-09-22 David Hyatt <hyatt@apple.com>
759
hyatt@apple.combac66582008-09-22 08:36:44 +0000760 Fix a regression in Windows scrollbar painting. (Also fix the same
761 bug in my new viewless Mac scrollbar painting code). The track rect
762 was being improperly inflated when painting resulting in the scrollbar
763 being too tall and painting in the border of overflow sections.
764
765 Reviewed by Oliver Hunt
766
767 * platform/mac/ScrollbarThemeMac.mm:
768 (WebCore::ScrollbarThemeMac::trackRect):
769 * platform/win/ScrollbarThemeSafari.cpp:
770 (WebCore::ScrollbarThemeSafari::trackRect):
771
7722008-09-22 David Hyatt <hyatt@apple.com>
773
hyatt@apple.com7cb18562008-09-22 07:57:52 +0000774 Fix a hit testing bug where events are mistakenly passed to subframes
775 if the mouse is over the border or padding area of the frame. Add
776 a boolean flag, isOverWidget(), to hit test results so that EventHandler
777 can check it to tell if the mouse is really over the content box of a
778 RenderWidget and not just in the border/padding area.
779
780 This is not testable, since the old code properly recovered when it detected
781 that the mouse was outside the bounds of the view, but this prevents
782 the extra passdown from even occurring (and is basically a nice cleanup).
783
784 Reviewed by Oliver Hunt
785
786 * page/EventHandler.cpp:
787 (WebCore::EventHandler::handleMousePressEvent):
788 (WebCore::EventHandler::hitTestResultAtPoint):
789 (WebCore::subframeForHitTestResult):
790 (WebCore::EventHandler::handleMouseDoubleClickEvent):
791 (WebCore::EventHandler::handleMouseMoveEvent):
792 (WebCore::EventHandler::handleMouseReleaseEvent):
793 (WebCore::EventHandler::handleWheelEvent):
794 * page/MouseEventWithHitTestResults.h:
795 (WebCore::MouseEventWithHitTestResults::isOverWidget):
796 * rendering/HitTestResult.cpp:
797 (WebCore::HitTestResult::HitTestResult):
798 (WebCore::HitTestResult::operator=):
799 * rendering/HitTestResult.h:
800 (WebCore::HitTestResult::isOverWidget):
801 (WebCore::HitTestResult::setIsOverWidget):
802 * rendering/RenderWidget.cpp:
803 (WebCore::RenderWidget::nodeAtPoint):
804 * rendering/RenderWidget.h:
805
hyatt@apple.comb2bf5272008-09-22 05:54:40 +00008062008-09-21 David Hyatt <hyatt@apple.com>
807
808 Rename FrameView's repaintRectangle method to repaintContentRectangle. Make
809 both it and ScrollView's updateContents method be off-limits to everyone in
810 WebCore except for RenderView.
811
812 Make repaintViewRectangle the only possible method for WebCore code to do
813 an invalidation. This ensures that all invalidates triggered by WebCore
814 cross-platform code that cross ownerElement() boundaries are transform-aware.
815
816 Make sure that iframes/frames contained inside objects that have transforms
817 or reflections are not allowed to blit (this was already true for transparency).
818
819 It is not possible to make a test for any of this, since iframe scrolling
820 still doesn't work on Mac (since the invalidates are not being done
821 through WebCore's cross-platform invalidation code but are instead going
822 through NSScrollView's setNeedsDisplay still).
823
824 Reviewed by Oliver Hunt
825
826 * editing/SelectionController.cpp:
827 (WebCore::SelectionController::recomputeCaretRect):
828 (WebCore::SelectionController::invalidateCaretRect):
829 (WebCore::SelectionController::focusedOrActiveStateChanged):
830 * page/FrameView.cpp:
831 (WebCore::FrameView::repaintContentRectangle):
832 (WebCore::FrameView::endDeferredRepaints):
833 * page/FrameView.h:
834 * platform/ScrollView.h:
835 * rendering/RenderBox.cpp:
836 (WebCore::RenderBox::paintFillLayerExtended):
837 * rendering/RenderLayer.cpp:
838 (WebCore::RenderLayer::enclosingPositionedAncestor):
839 (WebCore::RenderLayer::requiresSlowRepaints):
840 * rendering/RenderLayer.h:
841 (WebCore::RenderLayer::hasTransform):
842 * rendering/RenderView.cpp:
843 (WebCore::RenderView::paintBoxDecorations):
844 (WebCore::RenderView::repaintViewRectangle):
845 (WebCore::RenderView::setSelection):
846
mjs@apple.com52b67602008-09-22 03:15:52 +00008472008-09-21 Maciej Stachowiak <mjs@apple.com>
848
849 Reviewed by Darin.
850
851 - introduce a TypeInfo class, for holding per-type (in the C++ class sense) date in StructureID
852 https://bugs.webkit.org/show_bug.cgi?id=20981
853
854 * bindings/js/JSAudioConstructor.cpp:
855 (WebCore::JSAudioConstructor::JSAudioConstructor):
856 * bindings/js/JSCSSStyleDeclarationCustom.cpp:
857 (WebCore::JSCSSStyleDeclaration::nameGetter):
858 * bindings/js/JSDOMBinding.cpp:
859 (WebCore::createDOMStructure):
860 * bindings/js/JSDOMBinding.h:
861 (WebCore::getDOMStructure):
862 * bindings/js/JSDOMWindowShell.cpp:
863 (WebCore::JSDOMWindowShell::JSDOMWindowShell):
864 (WebCore::JSDOMWindowShell::setWindow):
865 * bindings/js/JSEventTargetNode.cpp:
866 (WebCore::JSEventTargetNode::createPrototype):
867 * bindings/js/JSHTMLOptionElementConstructor.cpp:
868 (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
869 * bindings/js/JSImageConstructor.cpp:
870 (WebCore::JSImageConstructor::JSImageConstructor):
871 * bindings/js/JSXMLHttpRequestConstructor.cpp:
872 (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
873 * bindings/js/JSXSLTProcessorConstructor.cpp:
874 (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
875 * bindings/scripts/CodeGeneratorJS.pm:
876
darin@apple.comad89d662008-09-22 02:12:57 +00008772008-09-21 Darin Adler <darin@apple.com>
878
879 Reviewed by Maciej Stachowiak.
880
881 - fix problem Maciej noticed where every JSNamedNodesCollection
882 gets its own StructureID
883
884 * bindings/js/JSNamedNodesCollection.cpp:
885 (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Use
886 getDOMStructure to get the structure.
887 * bindings/js/JSNamedNodesCollection.h:
888 (WebCore::JSNamedNodesCollection::createPrototype): Return the
889 object prototype.
890
hyatt@apple.com1f2ad1e2008-09-22 00:33:19 +00008912008-09-20 David Hyatt <hyatt@apple.com>
892
893 Make sure transformed scrollbars in overflow sections position
894 properly. This patch mimics the same behavior that works for
895 iframes, namely making sure that the same code that dynamically
896 adjusts iframe widget positions at paint time for fixed positioning
897 and transforms also applies to scrollbars. (This is as simple as passing
898 in the current translation factor at paint time rather than crawling
899 up the layer tree to compute a "false" absolute position.)
900
901 An existing transform test covers this (although only a pixel result
902 reveals the correct rendering).
903
904 Reviewed by Darin Adler
905
906 * rendering/RenderLayer.cpp:
907 (WebCore::RenderLayer::updateLayerPositions):
908 (WebCore::RenderLayer::positionOverflowControls):
909 (WebCore::RenderLayer::paintOverflowControls):
910 (WebCore::RenderLayer::paintLayer):
911 * rendering/RenderLayer.h:
912
sfalken@apple.comd0274692008-09-22 00:08:30 +00009132008-09-21 Steve Falkenburg <sfalken@apple.com>
914
sfalken@apple.com4fe10f92008-09-22 00:12:28 +0000915 Removed unnecessary nested timer check.
916
917 Rubber-stamped by Dan Bernstein.
918
919 * platform/win/SharedTimerWin.cpp:
920 (WebCore::TimerWindowWndProc):
921
9222008-09-21 Steve Falkenburg <sfalken@apple.com>
923
sfalken@apple.comd0274692008-09-22 00:08:30 +0000924 Improve timer resolution on WinXP.
925 https://bugs.webkit.org/show_bug.cgi?id=20979
926
927 Removed last-chance timer. It should not be necessary.
928 Change timeEndPeriod timer to fire in 300ms instead of 20ms. Calling timeBeginPeriod/timeEndPeriod too often throws off accuracy.
929 Remove Vista checks. We now run the same code on both XP and Vista.
930
931 Call through to JSC::getCurrentUTCTimeWithMicroseconds from WebCore::currentTime.
932 The code previously called GetSystemTimeAsFileTime, which is always low-resolution on XP, even within timeBeginPeriod(1).
933
934 Reviewed by Maciej Stachowiak.
935
936 * platform/win/SharedTimerWin.cpp:
937 (WebCore::):
938 (WebCore::TimerWindowWndProc):
939 (WebCore::setSharedTimerFireTime):
940 * platform/win/SystemTimeWin.cpp:
941 (WebCore::currentTime):
942
eric@webkit.org3e96c482008-09-21 07:59:58 +00009432008-09-21 Dirk Schulze <vbs85@gmx.de>
944
945 Reviewed by eseidel. Landed by eseidel.
946
eric@webkit.orgc3431282008-09-21 10:37:37 +0000947 All platforms use the DashArray in the GraphicsContext.
948
949 * svg/graphics/SVGPaintServer.h:
950 * svg/graphics/cairo/SVGPaintServerGradientCairo.cpp:
951 (WebCore::SVGPaintServerGradient::setup):
952 * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
953 (WebCore::SVGPaintServerPattern::setup):
954 * svg/graphics/cairo/SVGPaintServerSolidCairo.cpp:
955 (WebCore::SVGPaintServerSolid::setup):
956 * svg/graphics/qt/SVGPaintServerGradientQt.cpp:
957 (WebCore::SVGPaintServerGradient::setup):
958 * svg/graphics/qt/SVGPaintServerQt.cpp:
959 * svg/graphics/qt/SVGPaintServerSolidQt.cpp:
960 (WebCore::SVGPaintServerSolid::setup):
961
9622008-09-21 Dirk Schulze <vbs85@gmx.de>
963
964 Reviewed by eseidel. Landed by eseidel.
965
eric@webkit.org3e96c482008-09-21 07:59:58 +0000966 Moved DashArray to GraphicsContext.
967
968 * GNUmakefile.am:
969 * WebCore.vcproj/WebCore.vcproj:
970 * WebCore.xcodeproj/project.pbxproj:
971 * platform/graphics/DashArray.h: Added.
972 * platform/graphics/GraphicsContext.h:
973 * platform/graphics/cairo/GraphicsContextCairo.cpp:
974 (WebCore::GraphicsContext::setLineDash):
975 * platform/graphics/cg/GraphicsContextCG.cpp:
976 (WebCore::GraphicsContext::setLineDash):
977 * platform/graphics/qt/GraphicsContextQt.cpp:
978 (WebCore::GraphicsContext::setLineDash):
979 * svg/graphics/SVGPaintServer.cpp:
980 (WebCore::applyStrokeStyleToContext):
981 * svg/graphics/SVGPaintServer.h:
982 * svg/graphics/cg/CgSupport.cpp:
983 * svg/graphics/cg/CgSupport.h:
984
mitz@apple.com9138eca2008-09-21 07:16:29 +00009852008-09-21 Dan Bernstein <mitz@apple.com>
986
987 Reviewed by Mark Rowe.
988
989 - fix linker warnings
990
991 * WebCore.base.exp:
992
darin@apple.comb1491772008-09-21 06:34:40 +00009932008-09-20 Darin Adler <darin@apple.com>
994
darin@apple.comc3215132008-09-21 06:50:35 +0000995 - another try at fixing Qt
996
997 * bridge/qt/qt_runtime.cpp: "using namespce WebCore"
998
9992008-09-20 Darin Adler <darin@apple.com>
1000
darin@apple.comb1491772008-09-21 06:34:40 +00001001 - blind attempt to fix Qt build
1002
1003 * bridge/qt/qt_runtime.cpp:
1004 (JSC::Bindings::convertQVariantToValue): Use regExpStructure instead
1005 of regExpPrototype to make a RegExpObject. There should really be
1006 some sort of public helper function for this. Same thing for
1007 DateInstance and dateStructure. For JSObject, use constructEmptyObject.
1008 (JSC::Bindings::):
1009 (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod): Use getDOMStructure.
1010 It is not correct to do this inside the constructor because it could
1011 cause a garbage collect while the QtRuntimeMethod object is half-
1012 allocated, which could lead to a crash; note that RuntimeMethod,
1013 QtRuntimeObjectImp, and RuntimeObjectImp have the same bug.
1014 * bridge/qt/qt_runtime.h: Add s_info and createPrototype.
1015
collinj@webkit.org8e01a432008-09-21 06:26:54 +000010162008-09-20 Collin Jackson <collinj@webkit.org>
1017
1018 Prefetch DNS for hyperlinks that the user mouses over.
1019
1020 https://bugs.webkit.org/show_bug.cgi?id=20931
1021
1022 Reviewed by Sam Weinig.
1023
1024 * page/Chrome.cpp:
1025 (WebCore::Chrome::mouseDidMoveOverElement):
1026
darin@apple.com8281d832008-09-21 02:29:12 +000010272008-09-20 Darin Adler <darin@apple.com>
1028
1029 Reviewed by Maciej Stachowiak.
1030
1031 - finish https://bugs.webkit.org/show_bug.cgi?id=20858
1032 make each distinct C++ class get a distinct JSC::Structure
1033
1034 * bindings/js/JSCSSStyleDeclarationCustom.cpp:
1035 (WebCore::JSCSSStyleDeclaration::nameGetter): Pass in a structure
1036 ID. Note that this makes a new structure every time -- we could
1037 optimize this slightly be caching and reusing a single one.
1038
1039 * bridge/runtime_method.cpp:
1040 (JSC::RuntimeMethod::RuntimeMethod): Create a unique structure using
1041 getDOMStructure.
1042 * bridge/runtime_method.h:
1043 (JSC::RuntimeMethod::createPrototype): Added createPrototype so
1044 getDOMStructure will work.
1045
1046 * bindings/js/JSDOMWindowShell.cpp:
1047 (WebCore::JSDOMWindowShell::JSDOMWindowShell): Initialize m_window to
1048 0; needed in case garbage collection happens while creating the
1049 JSDOMWindow.
1050
mitz@apple.com9b3ac792008-09-21 00:42:30 +000010512008-09-20 Dan Bernstein <mitz@apple.com>
1052
mitz@apple.comf674f4f2008-09-21 00:49:49 +00001053 Reviewed by Eric Seidel.
1054
1055 - fix https://bugs.webkit.org/show_bug.cgi?id=20950
mitz@apple.comc3dfbac2008-09-21 00:52:41 +00001056 <rdar://problem/6234059> Reproducible assertion failure running svg/custom/acid3-test-77.html multiple times under guard malloc
mitz@apple.comf674f4f2008-09-21 00:49:49 +00001057
1058 * svg/SVGTextContentElement.cpp:
1059 (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): Changed to
1060 not include the first character in the extraCharsAvailable count.
1061
kevino@webkit.org2bc0d822008-09-20 22:31:24 +000010622008-09-20 Kevin Ollivier <kevino@theolliviers.com>
1063
kevino@webkit.orge66435f2008-09-20 23:39:25 +00001064 Reviewed by Dan Bernstein.
1065
1066 Fix memory leak.
kevino@webkit.org6f86cbb2008-09-20 23:56:57 +00001067
1068 https://bugs.webkit.org/show_bug.cgi?id=20505
kevino@webkit.orge66435f2008-09-20 23:39:25 +00001069
1070 * platform/wx/wxcode/mac/carbon/fontprops.cpp:
1071 (GetTextExtent):
1072
10732008-09-20 Kevin Ollivier <kevino@theolliviers.com>
1074
kevino@webkit.org2bc0d822008-09-20 22:31:24 +00001075 wx build fixes. Added/removed build sources, and nativeWindow->platformWidget updates.
1076
1077 * WebCoreSources.bkl:
1078 * platform/ScrollView.h:
1079 * platform/wx/PopupMenuWx.cpp:
1080 (WebCore::PopupMenu::show):
1081 * platform/wx/RenderThemeWx.cpp:
1082 (WebCore::RenderThemeWx::paintButton):
1083 (WebCore::RenderThemeWx::paintTextField):
1084 (WebCore::RenderThemeWx::paintMenuList):
1085 (WebCore::RenderThemeWx::paintMenuListButton):
1086 * platform/wx/ScrollViewWx.cpp:
1087 (WebCore::ScrollView::setPlatformWidget):
1088 (WebCore::ScrollView::updateContents):
1089 (WebCore::ScrollView::update):
1090 (WebCore::ScrollView::visibleWidth):
1091 (WebCore::ScrollView::visibleHeight):
1092 (WebCore::ScrollView::scrollBy):
1093 (WebCore::ScrollView::resizeContents):
1094 (WebCore::ScrollView::contentsWidth):
1095 (WebCore::ScrollView::contentsHeight):
1096 (WebCore::ScrollView::isScrollViewScrollbar):
1097 (WebCore::ScrollView::adjustScrollbars):
1098 (WebCore::ScrollView::inWindow):
1099 (WebCore::ScrollView::removeChild):
1100 * platform/wx/WidgetWx.cpp:
1101 * plugins/wx/PluginViewWx.cpp:
1102 (WebCore::PluginView::setParentVisible):
1103 (WebCore::PluginView::updatePluginWidget):
1104
timothy@apple.comb697f272008-09-20 22:21:59 +000011052008-09-20 Timothy Hatcher <timothy@apple.com>
1106
1107 Fix the new Node Search button image to not be blurry.
1108
1109 * page/inspector/Images/nodeSearchButtons.png:
1110
pewtermoose@webkit.org4cc99202008-09-20 21:30:43 +000011112008-09-20 Matt Lilek <webkit@mattlilek.com>
1112
1113 Reviewed by Tim Hatcher.
1114
pewtermoose@webkit.orge1fc4462008-09-20 21:53:43 +00001115 Cut down some of the inspector javascript -> InspectorController glue code
1116 with two new macros. Also rearrange the exposed function list to be grouped
1117 by implementation and to all explicitly use the WebCore namespace.
1118
1119 * page/InspectorController.cpp:
1120 (WebCore::InspectorController::windowScriptObjectAvailable):
1121
11222008-09-20 Matt Lilek <webkit@mattlilek.com>
1123
1124 Reviewed by Tim Hatcher.
1125
pewtermoose@webkit.org4cc99202008-09-20 21:30:43 +00001126 Fix regression from my previous patch where the breadcrumbs bar was not displayed.
1127
1128 * page/inspector/inspector.css:
1129
zimmermann@webkit.org953b7442008-09-20 20:19:45 +000011302008-09-20 Nikolas Zimmermann <zimmermann@kde.org>
1131
1132 Reviewed by Eric.
1133
1134 Refactor HTMLImageLoader/SVGImageLoader code.
1135 Move html/HTMLImageLoader.* to loader/ImageLoader.*
1136
1137 Let HTMLImageLoader & SVGImageLoader inherit from the new base class.
1138 SVGImageLoader used to inherit from HTMLImageLoader which is awkward.
1139
1140 * GNUmakefile.am:
1141 * WebCore.pro:
1142 * WebCore.vcproj/WebCore.vcproj:
1143 * WebCore.xcodeproj/project.pbxproj:
1144 * WebCoreSources.bkl:
1145 * dom/Document.cpp:
1146 (WebCore::Document::dispatchImageLoadEventSoon):
1147 (WebCore::Document::removeImage):
1148 (WebCore::Document::dispatchImageLoadEventsNow):
1149 * dom/Document.h:
1150 * html/HTMLImageLoader.cpp:
1151 (WebCore::HTMLImageLoader::HTMLImageLoader):
1152 (WebCore::HTMLImageLoader::~HTMLImageLoader):
1153 (WebCore::HTMLImageLoader::sourceURI):
1154 (WebCore::HTMLImageLoader::notifyFinished):
1155 * html/HTMLImageLoader.h:
1156 * loader/DocLoader.h:
1157 * loader/ImageLoader.cpp: Copied from html/HTMLImageLoader.cpp.
1158 (WebCore::ImageLoader::ImageLoader):
1159 (WebCore::ImageLoader::~ImageLoader):
1160 (WebCore::ImageLoader::setImage):
1161 (WebCore::ImageLoader::setLoadingImage):
1162 (WebCore::ImageLoader::updateFromElement):
1163 (WebCore::ImageLoader::notifyFinished):
1164 * loader/ImageLoader.h: Copied from html/HTMLImageLoader.h.
1165 * svg/SVGImageElement.cpp:
1166 (WebCore::SVGImageElement::attach):
1167 (WebCore::SVGImageElement::insertedIntoDocument):
1168 (WebCore::SVGImageElement::imageSourceAttributeName):
1169 * svg/SVGImageElement.h:
1170 * svg/SVGImageLoader.cpp:
1171 (WebCore::SVGImageLoader::SVGImageLoader):
1172 (WebCore::SVGImageLoader::dispatchLoadEvent):
1173 (WebCore::SVGImageLoader::sourceURI):
1174 * svg/SVGImageLoader.h:
1175
zecke@webkit.orgf3834492008-09-20 14:23:55 +000011762008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
1177
zecke@webkit.org7a15a532008-09-20 14:24:27 +00001178 Build fix.
1179
zecke@webkit.orga832cca2008-09-20 14:24:45 +00001180 [qtwebkit] ScrollBar build fix after r36684.
1181 BackButtonPart was split into Start and End Part
1182 ForwardButtonPart was split into Start and End Part
1183
zecke@webkit.orga832cca2008-09-20 14:24:45 +00001184 * platform/qt/ScrollbarThemeQt.cpp:
1185 (WebCore::scPart):
1186 (WebCore::scrollbarPart):
1187 (WebCore::styleOptionSlider):
1188
11892008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
1190
1191 Build fix.
1192
zecke@webkit.org7a15a532008-09-20 14:24:27 +00001193 [qtwebkit] Make qt_instance.cpp compile.
1194 Revision of 36675 introduced getDOMStructure to give unique
1195 structure id's to C++ classes. Catch up. RuntimeObjectImp assigns
1196 the the StructureID inside the c'tor, do the same in QtRuntimeObjectImp
1197
1198 * bridge/qt/qt_instance.cpp:
1199 (JSC::Bindings::QtInstance::getRuntimeObject):
1200
12012008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
1202
zecke@webkit.orgf3834492008-09-20 14:23:55 +00001203 Reviewed by Nikolas Zimmermann.
1204
zecke@webkit.org95ff1412008-09-20 14:24:10 +00001205 [svg] Change SVGLocatable to deal with a plain SVGElement
1206 There is no requirement in the code that we have to have a
1207 SVGStyledElement. Remove that artificial limitation and compile
1208 with SVGElement.
1209
1210 * svg/SVGLocatable.cpp:
1211 * svg/SVGLocatable.h:
1212
12132008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
1214
1215 Reviewed by Nikolas Zimmermann.
1216
zecke@webkit.orgf3834492008-09-20 14:23:55 +00001217 [svg] Use OwnPtr for the SVGExtensions to avoid custom lifetime
1218 management.
1219
1220 * dom/Document.cpp:
1221 (WebCore::Document::~Document):
1222 (WebCore::Document::svgExtensions):
1223 (WebCore::Document::accessSVGExtensions):
1224 * dom/Document.h:
1225
hyatt@apple.com02bbc2c2008-09-20 04:50:21 +000012262008-09-19 David Hyatt <hyatt@apple.com>
1227
hyatt@apple.com1fe09172008-09-20 05:09:44 +00001228 Fix for crash in updateTransitions. Make sure to test for a style
1229 being null when comparing two RenderStyles.
1230
1231 Reviewed by Oliver Hunt
1232
1233 * page/animation/AnimationBase.cpp:
1234 (WebCore::PropertyWrapperGetter::equals):
1235
12362008-09-19 David Hyatt <hyatt@apple.com>
1237
hyatt@apple.com02bbc2c2008-09-20 04:50:21 +00001238 https://bugs.webkit.org/show_bug.cgi?id=20954
1239
1240 Roll out r36628 since it has caused horrible regressions with
1241 animated GIF CPU usage.
1242
1243 * platform/graphics/BitmapImage.cpp:
1244 (WebCore::BitmapImage::cacheFrame):
1245 (WebCore::BitmapImage::startAnimation):
1246 * platform/graphics/BitmapImage.h:
1247 (WebCore::FrameData::FrameData):
1248 * platform/graphics/cairo/ImageCairo.cpp:
1249 (WebCore::FrameData::clear):
1250 * platform/graphics/cg/ImageCG.cpp:
1251 (WebCore::FrameData::clear):
1252 * platform/graphics/qt/ImageQt.cpp:
1253 (WebCore::FrameData::clear):
1254 * platform/graphics/wx/ImageWx.cpp:
1255 (WebCore::FrameData::clear):
1256
alp@webkit.orgd1e860e2008-09-20 03:43:42 +000012572008-09-20 Alp Toker <alp@nuanti.com>
1258
1259 Reviewed by Timothy Hatcher.
1260
1261 https://bugs.webkit.org/show_bug.cgi?id=20913
1262 Avoid redudant includes
1263
1264 Document.h is included excessively such that a modification to Document.h (or
1265 any of the header it includes itself) triggers a rebuild of many files
1266 including the whole of SVG and a lot of the JS bindings.
1267
1268 Some of these includes can be avoided by only including Document.h where
1269 necessary.
1270
1271 * bindings/js/JSAttrCustom.cpp:
1272 * bindings/js/JSElementCustom.cpp:
1273 * bindings/js/JSEventTargetBase.cpp:
1274 * bindings/js/JSEventTargetBase.h:
1275 * bindings/js/JSEventTargetNode.cpp:
1276 * bindings/js/JSHTMLFrameElementCustom.cpp:
1277 * bindings/js/JSHTMLIFrameElementCustom.cpp:
1278 * bindings/scripts/CodeGeneratorJS.pm:
1279 * css/CSSCursorImageValue.cpp:
1280 * css/SVGCSSStyleSelector.cpp:
1281 * dom/make_names.pl:
1282 * svg/SVGAnimateElement.h:
1283 * svg/SVGAnimatedProperty.h:
1284 (WebCore::::baseValue):
1285 (WebCore::::setBaseValue):
1286 (WebCore::::startAnimation):
1287 (WebCore::::stopAnimation):
1288 * svg/SVGElement.cpp:
1289 (WebCore::SVGElement::accessDocumentSVGExtensions):
1290 * svg/SVGElement.h:
1291 * svg/SVGElementInstance.cpp:
1292 * svg/SVGFitToViewBox.cpp:
1293 * svg/SVGFontElement.cpp:
1294 * svg/SVGFontFaceElement.cpp:
1295 * svg/SVGLinearGradientElement.cpp:
1296 * svg/SVGMPathElement.cpp:
1297 * svg/SVGViewSpec.cpp:
1298
zimmermann@webkit.org50e33c72008-09-20 03:33:43 +000012992008-09-19 Nikolas Zimmermann <zimmermann@kde.org>
1300
1301 Reviewed by Antti & Eric.
1302
1303 Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
1304
1305 Finish HTMLScriptElement / SVGScriptElement unification.
1306 SVG <script> support is complete now, full SVGLoad event
1307 respecting the influence of the externalResourcesRequired attribute
1308 as well as SVGError event support. All other features shared with HTML.
1309
1310 Tests: fast/dom/HTMLScriptElement/script-reexecution.html
1311 svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg
1312 svg/dom/SVGScriptElement/script-load-and-error-events.svg
1313 svg/dom/SVGScriptElement/script-reexecution.svg
1314 svg/dom/SVGScriptElement/script-set-href.svg
1315
1316 * dom/ScriptElement.cpp:
1317 (WebCore::ScriptElementData::ScriptElementData):
1318 (WebCore::ScriptElementData::requestScript):
1319 * dom/ScriptElement.h:
1320 (WebCore::ScriptElementData::haveFiredLoadEvent):
1321 (WebCore::ScriptElementData::setHaveFiredLoadEvent):
1322 * dom/XMLTokenizer.cpp:
1323 (WebCore::XMLTokenizer::notifyFinished):
1324 * html/HTMLScriptElement.cpp:
1325 (WebCore::HTMLScriptElement::dispatchLoadEvent):
1326 * svg/SVGScriptElement.cpp:
1327 (WebCore::SVGScriptElement::setCreatedByParser):
1328 (WebCore::SVGScriptElement::parseMappedAttribute):
1329 (WebCore::SVGScriptElement::svgAttributeChanged):
1330 (WebCore::SVGScriptElement::insertedIntoDocument):
1331 (WebCore::SVGScriptElement::removedFromDocument):
1332 (WebCore::SVGScriptElement::childrenChanged):
1333 (WebCore::SVGScriptElement::isURLAttribute):
1334 (WebCore::SVGScriptElement::finishParsingChildren):
1335 (WebCore::SVGScriptElement::type):
1336 (WebCore::SVGScriptElement::setType):
1337 (WebCore::SVGScriptElement::haveLoadedRequiredResources):
1338 (WebCore::SVGScriptElement::dispatchLoadEvent):
1339 (WebCore::SVGScriptElement::dispatchErrorEvent):
1340 * svg/SVGScriptElement.h:
1341
mitz@apple.comc7b24ea2008-09-20 03:23:22 +000013422008-09-19 Dan Bernstein <mitz@apple.com>
1343
1344 Reviewed by John Sullivan.
1345
1346 - fix https://bugs.webkit.org/show_bug.cgi?id=20951
1347 Typo in Position::getInlineBoxAndOffset()
1348 and add an assertion
1349
1350 Without the fix, the newly-added assertion fails in platform/mac/editing/input/caret-primary-bidi.html
1351
1352 * dom/Position.cpp:
1353 (WebCore::Position::getInlineBoxAndOffset):
1354 * rendering/InlineTextBox.cpp:
1355 (WebCore::InlineTextBox::positionForOffset):
1356
hyatt@apple.comd48dbf32008-09-20 03:21:14 +000013572008-09-19 David Hyatt <hyatt@apple.com>
1358
1359 Add support for hit testing of all five possible scrollbar button placements.
1360
1361 Reviewed by Sam Weinig
1362
1363 * platform/ScrollbarThemeComposite.cpp:
1364 (WebCore::ScrollbarThemeComposite::paint):
1365 * platform/mac/ScrollbarThemeMac.mm:
1366 (WebCore::):
1367 (WebCore::ScrollbarThemeMac::backButtonRect):
1368 (WebCore::ScrollbarThemeMac::forwardButtonRect):
1369 (WebCore::ScrollbarThemeMac::trackRect):
1370 (WebCore::ScrollbarThemeMac::paintButton):
1371
darin@apple.com1c4cd8f2008-09-20 01:05:35 +000013722008-09-19 Darin Adler <darin@apple.com>
1373
1374 - try to fix Qt build
1375
1376 * bridge/qt/qt_instance.cpp:
1377 (JSC::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): Add structure argument.
1378 (JSC::Bindings::QtInstance::getRuntimeObject): Ditto.
1379 * bridge/runtime_object.cpp:
1380 (JSC::RuntimeObjectImp::RuntimeObjectImp): Add an overload just for Qt.
1381 * bridge/runtime_object.h: Ditto.
1382
dino@apple.com7c236592008-09-20 00:53:49 +000013832008-09-19 Chris Marrin <cmarrin@apple.com>
1384
1385 Reviewed by Dave Hyatt.
1386
1387 Transition starts running when it shouldn't
1388 https://bugs.webkit.org/show_bug.cgi?id=20892
1389
1390 When there is a transition and an animation on the
1391 same element, make sure the animation wins.
1392
1393 The fix is to save the unanimated style when an animation is started.
1394 Then, when starting a transition, check to see if there is a current
1395 animation on the same prop. If so, use the unanimated style as the
1396 fromStyle rather than the current style.
1397
1398 Test: animations/transition-and-animation-1.html
1399
1400 * page/animation/CompositeAnimation.cpp:
1401 (WebCore::CompositeAnimation::updateTransitions):
1402 (WebCore::CompositeAnimation::updateKeyframeAnimations):
1403 (WebCore::CompositeAnimation::animate):
1404 (WebCore::CompositeAnimation::getAnimationForProperty):
1405 * page/animation/CompositeAnimation.h:
1406 * page/animation/ImplicitAnimation.cpp:
1407 (WebCore::ImplicitAnimation::reset):
1408 * page/animation/ImplicitAnimation.h:
1409 * page/animation/KeyframeAnimation.cpp:
1410 (WebCore::KeyframeAnimation::hasAnimationForProperty):
1411 * page/animation/KeyframeAnimation.h:
1412 (WebCore::KeyframeAnimation::KeyframeAnimation):
1413 (WebCore::KeyframeAnimation::unanimatedStyle):
1414
hyatt@apple.comea254e22008-09-20 00:42:36 +000014152008-09-19 David Hyatt <hyatt@apple.com>
1416
1417 Add support for painting/hit testing of four possible scrollbar buttons.
1418 The Windows themes simply ignore the two parts that they will never
1419 show. The Mac theme also ignores the other two buttons for now.
1420
1421 The cross-platform base for all three themes, ScrollbarThemeComposite,
1422 has all the proper support though.
1423
1424 Reviewed by Sam Weinig
1425
1426 * platform/ScrollbarThemeComposite.cpp:
1427 (WebCore::ScrollbarThemeComposite::hitTest):
1428 (WebCore::ScrollbarThemeComposite::invalidatePart):
1429 * platform/ScrollbarThemeComposite.h:
1430 * platform/mac/ScrollbarThemeMac.h:
1431 * platform/mac/ScrollbarThemeMac.mm:
1432 (WebCore::ScrollbarThemeMac::backButtonRect):
1433 (WebCore::ScrollbarThemeMac::forwardButtonRect):
1434 (WebCore::ScrollbarThemeMac::paintButton):
1435 * platform/win/ScrollbarThemeSafari.cpp:
1436 (WebCore::ScrollbarThemeSafari::backButtonRect):
1437 (WebCore::ScrollbarThemeSafari::forwardButtonRect):
1438 (WebCore::ScrollbarThemeSafari::paintButton):
1439 * platform/win/ScrollbarThemeSafari.h:
1440 * platform/win/ScrollbarThemeWin.cpp:
1441 (WebCore::ScrollbarThemeWin::backButtonRect):
1442 (WebCore::ScrollbarThemeWin::forwardButtonRect):
1443 (WebCore::ScrollbarThemeWin::paintButton):
1444 * platform/win/ScrollbarThemeWin.h:
1445
pewtermoose@webkit.org0e3da6e2008-09-20 00:11:32 +000014462008-09-19 Matt Lilek <webkit@mattlilek.com>
1447
1448 Reviewed by Tim Hatcher.
1449
1450 Bug 17772: Inspector should support point-and-click to select a node to inspect
1451 https://bugs.webkit.org/show_bug.cgi?id=17772
1452 <rdar://problem/5792395>
1453
1454 * English.lproj/localizedStrings.js:
1455 * page/Chrome.cpp:
1456 (WebCore::Chrome::mouseDidMoveOverElement):
1457 * page/EventHandler.cpp:
1458 (WebCore::EventHandler::handleMousePressEvent):
1459 * page/InspectorController.cpp:
1460 (WebCore::toggleNodeSearch):
1461 (WebCore::searchingForNode):
1462 (WebCore::InspectorController::InspectorController):
1463 (WebCore::InspectorController::toggleSearchForNodeInPage):
1464 (WebCore::InspectorController::mouseDidMoveOverElement):
1465 (WebCore::InspectorController::handleMousePressOnNode):
1466 (WebCore::InspectorController::windowScriptObjectAvailable):
1467 * page/InspectorController.h:
1468 (WebCore::InspectorController::searchingForNodeInPage):
1469 * page/inspector/ElementsPanel.js:
1470 * page/inspector/Images/nodeSearchButtons.png: Added.
1471 * page/inspector/inspector.css:
1472
hyatt@apple.com57b2d522008-09-19 23:39:26 +000014732008-09-19 David Hyatt <hyatt@apple.com>
1474
1475 Add new scrollbar parts to be able to represent back and forward buttons
1476 at either end of the scrollbar. The current scrollbar still just draws
1477 a single button at either end, but the parts now exist.
1478
1479 Reviewed by Sam Weinig
1480
1481 * platform/ScrollTypes.h:
1482 (WebCore::):
1483 * platform/Scrollbar.cpp:
1484 (WebCore::Scrollbar::autoscrollTimerFired):
1485 (WebCore::Scrollbar::pressedPartScrollDirection):
1486 (WebCore::Scrollbar::pressedPartScrollGranularity):
1487 (WebCore::Scrollbar::handleMouseMoveEvent):
1488 * platform/ScrollbarTheme.h:
1489 (WebCore::ScrollbarTheme::buttonsPlacement):
1490 (WebCore::ScrollbarTheme::invalidateParts):
1491 * platform/ScrollbarThemeComposite.cpp:
1492 (WebCore::ScrollbarThemeComposite::paint):
1493 (WebCore::ScrollbarThemeComposite::hitTest):
1494 (WebCore::ScrollbarThemeComposite::invalidatePart):
1495 * platform/ScrollbarThemeComposite.h:
1496
bdakin@apple.com5b0a3b22008-09-19 23:02:03 +000014972008-09-19 Beth Dakin <bdakin@apple.com>
1498
1499 Reviewed by Dave Hyatt.
1500
1501 Fix for <rdar://problem/6231308> crash in AutoTableLayout
1502
1503 The code assumes later on that a TableSection's grid's row vector
1504 will never be empty. So make 1 the minimum number of columns.
1505
1506 * rendering/RenderTableSection.cpp:
1507 (WebCore::RenderTableSection::ensureRows):
1508
hyatt@apple.comaf711ec2008-09-19 22:55:56 +000015092008-09-19 David Hyatt <hyatt@apple.com>
1510
1511 Add a new ScrollbarButtonsPlacement type for specifying where
1512 the button arrows are in a scrollbar.
1513
1514 Read in the placement settings for Mac. Nothing is done with the
1515 setting yet.
1516
1517 Add a new buttonsPlacement() method to ScrollbarTheme composite
1518 so that the arrow settings can be obtained.
1519
1520 Reviewed by Sam Weinig
1521
1522 * platform/ScrollTypes.h:
1523 (WebCore::):
1524 * platform/ScrollbarThemeComposite.h:
1525 (WebCore::ScrollbarThemeComposite::buttonsPlacement):
1526 * platform/mac/ScrollbarThemeMac.mm:
1527 (WebCore::updateArrowPlacement):
1528 (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
1529
sfalken@apple.com64602042008-09-19 22:47:45 +000015302008-09-19 Steve Falkenburg <sfalken@apple.com>
1531
1532 Roll out r36626. It is causing variance in SunSpider numbers on XP.
1533
1534 Rubber stamped by Mark Rowe.
1535
1536 * platform/win/SharedTimerWin.cpp:
1537 (WebCore::isRunningOnVistaOrLater):
1538 (WebCore::setSharedTimerFireTime):
1539
kmccullough@apple.comd203b242008-09-19 21:56:14 +000015402008-09-19 Kevin McCullough <kmccullough@apple.com>
1541
1542 Reviewed by Tim.
1543
1544 https://bugs.webkit.org/show_bug.cgi?id=20942
1545 Bug 20942: Repeated messages in resources don't collapse
1546 - Now repeated messages in a resource's view are collapsed and a message
1547 says how many were repeated.
1548
1549 * English.lproj/localizedStrings.js:
1550 * manual-tests/inspector/multiple-console-messages.html:
1551 * page/inspector/Console.js: Send all the messages to the resource's
1552 view before possibly returning early if the message is a repeat.
1553 * page/inspector/SourceFrame.js: Add the text about the message being
1554 repeated, if it is, and increment it when necessary.
1555
cfleizach@apple.com0abaacc2008-09-19 21:39:21 +000015562008-09-19 Chris Fleizach <cfleizach@apple.com>
1557
1558 Removed unnecessary #if
1559
1560 * page/mac/AccessibilityObjectWrapper.mm:
1561
hyatt@apple.comc9967ce92008-09-19 21:20:59 +000015622008-09-19 David Hyatt <hyatt@apple.com>
1563
hyatt@apple.comf658e502008-09-19 22:12:07 +00001564 Read in prefs for the scroll delay repeat values for buttons. Also
1565 honor the option-click pref for jumping to the thumb when clicking in
1566 the track.
1567
1568 Reviewed by Sam Weinig
1569
1570 * platform/mac/ScrollbarThemeMac.h:
1571 * platform/mac/ScrollbarThemeMac.mm:
1572 (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
1573 (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay):
1574 (WebCore::ScrollbarThemeMac::autoscrollTimerDelay):
1575 (WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
1576
15772008-09-19 David Hyatt <hyatt@apple.com>
1578
hyatt@apple.comc9967ce92008-09-19 21:20:59 +00001579 Move ScrollbarThemeMac.cpp to ScrollbarThemeMac.mm so it can use Obj-C.
1580 Set the initial button repeat delay to 0.5 for Mac.
1581
1582 Reviewed by Sam Weinig
1583
1584 * WebCore.xcodeproj/project.pbxproj:
1585 * platform/mac/ScrollbarThemeMac.cpp: Removed.
1586 * platform/mac/ScrollbarThemeMac.h:
1587 (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay):
1588 * platform/mac/ScrollbarThemeMac.mm: Copied from platform/mac/ScrollbarThemeMac.cpp.
1589
darin@apple.com39a180f2008-09-19 21:15:14 +000015902008-09-19 Darin Adler <darin@apple.com>
1591
1592 Reviewed by Sam Weinig.
1593
1594 - part 2 of https://bugs.webkit.org/show_bug.cgi?id=20858
1595 make each distinct C++ class get a distinct JSC::Structure
1596
1597 + Fixed all cases where we were using a shared structure for multiple
1598 C++ classes in WebCore. This still has to be done in JavaScriptCore.
1599
1600 + Got rid of cacheGlobalObject.
1601
1602 + Improved use of PassRefPtr in bindings code.
1603
1604 + Removed a couple cases where we were potentially allocating prototypes
1605 inside a JSObject's construction process -- this can lead to trouble if
1606 we do a garbage collection while an object is only partly constructed.
1607
1608 * bindings/js/JSAudioConstructor.cpp:
1609 (WebCore::JSAudioConstructor::JSAudioConstructor): Create a structure explicitly
1610 so we don't implicitly share the structure with other objects that use the object
1611 prototype.
1612
1613 * bindings/js/JSDOMBinding.cpp:
1614 (WebCore::getCachedDOMConstructor): Added. To be used for constructors so we
1615 don't need cacheGlobalObject any more.
1616 (WebCore::cacheDOMConstructor): Ditto.
1617
1618 * bindings/js/JSDOMBinding.h: Removed DOMObject constructor that takes a prototype.
1619 Added functions and a function template for getting cached DOM constructors.
1620 Removed cacheGlobalObject function template.
1621
1622 * bindings/js/JSDOMWindowBase.cpp:
1623 (WebCore::JSDOMWindowBase::JSDOMWindowBase): Take a PassRefPtr<DOMWindow> since
1624 we're taking ownership.
1625 * bindings/js/JSDOMWindowBase.h: Changed constructor to take PassRefPtr, since
1626 we're taking ownership. Added constructor map.
1627 * bindings/js/JSDOMWindowCustom.cpp:
1628 (WebCore::JSDOMWindow::mark): Mark the constructors in the map.
1629
1630 * bindings/js/JSDOMWindowShell.cpp:
1631 (WebCore::JSDOMWindowShell::JSDOMWindowShell): Take a PassRefPtr<DOMWindow> since
1632 we're taking ownership. Use the new setWindow function to create the JSDOMWindow;
1633 this is now done in only that one place.
1634 (WebCore::JSDOMWindowShell::setWindow): Added. Creates the JSDOMWindow based on
1635 the passed-in DOMWindow. Code was moved here and changed to allocate unique
1636 structures for both the window prototype and the window.
1637 * bindings/js/JSDOMWindowShell.h: Ditto.
1638
1639 * bindings/js/JSEventTargetBase.h: Changed class template argument so it doesn't
1640 have the same name (JSEventTarget) as an actual class. Removed unhelpful use of
1641 private/friend in JSEventTargetBase. Removed comments referring to defunct
1642 macros. Changed JSEventTargetBasePrototype to get the prototype with the new
1643 rather than its own copy of cacheGlobalObject (I missed this during pass 1).
1644 Changed JSEventTargetBasePrototype so it doesn't have so many template arguments.
1645
1646 * bindings/js/JSEventTargetNode.cpp: Added s_info; needed for the new scheme
1647 for caching structures and prototypes.
1648 (WebCore::JSEventTargetNode::JSEventTargetNode): Use PassRefPtr.
1649 (WebCore::JSEventTargetNode::createPrototype): Added.
1650 * bindings/js/JSEventTargetNode.h: Updated for above changes.
1651
1652 * bindings/js/JSHTMLAllCollection.h:
1653 (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Use PassRefPtr.
1654 * bindings/js/JSHTMLCollectionCustom.cpp:
1655 (WebCore::getNamedItems): Pass ExecState instead of prototype.
1656 * bindings/js/JSHTMLFormElementCustom.cpp:
1657 (WebCore::JSHTMLFormElement::nameGetter): Ditto.
1658 * bindings/js/JSHTMLInputElementBase.cpp:
1659 (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Use PassRefPtr.
1660 * bindings/js/JSHTMLInputElementBase.h: Ditto.
1661 * bindings/js/JSHTMLOptionElementConstructor.cpp:
1662 (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
1663 Create a unique structure instead of sharing.
1664 * bindings/js/JSImageConstructor.cpp:
1665 (WebCore::JSImageConstructor::JSImageConstructor): Ditto.
1666
1667 * bindings/js/JSInspectedObjectWrapper.cpp:
1668 (WebCore::JSInspectedObjectWrapper::wrap): Removed overload that takes
1669 a prototype rather than a structure. Made the use of inheritorID() here
1670 explicit.
1671 * bindings/js/JSInspectedObjectWrapper.h: Ditto.
1672 * bindings/js/JSInspectorCallbackWrapper.cpp:
1673 (WebCore::JSInspectorCallbackWrapper::wrap): Ditto.
1674 * bindings/js/JSInspectorCallbackWrapper.h: Ditto.
1675
1676 * bindings/js/JSNamedNodesCollection.cpp:
1677 (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Changed to
1678 take an ExecState argument instead of a prototype. Create a unique
1679 StructureID instead of sharing.
1680 * bindings/js/JSNamedNodesCollection.h: Ditto.
1681
1682 * bindings/js/JSQuarantinedObjectWrapper.cpp: Removed overloaded
1683 constructor that takes a prototype instead of a structure.
1684 * bindings/js/JSQuarantinedObjectWrapper.h: Ditto.
1685
1686 * bindings/js/JSRGBColor.cpp:
1687 (WebCore::JSRGBColor::JSRGBColor): Take ExecState instead of a
1688 prototype; create a unique structure.
1689 (WebCore::getJSRGBColor): Ditto.
1690 * bindings/js/JSRGBColor.h: Ditto.
1691
1692 * bindings/js/JSSQLResultSetRowListCustom.cpp:
1693 (WebCore::JSSQLResultSetRowList::item): Use constructEmptyObject instead
1694 of explicit coding the idiom for making a new object.
1695
1696 * bindings/js/JSXMLHttpRequestConstructor.cpp:
1697 (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
1698 Create a unique structure instead of the shared one.
1699 * bindings/js/JSXSLTProcessorConstructor.cpp:
1700 (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
1701 Ditto.
1702
1703 * bindings/js/ScriptController.cpp:
1704 (WebCore::ScriptController::clearWindowShell): Let the window shell's
1705 setWindow function create the JSDOMWindow instead of doing it here.
1706
1707 * bindings/scripts/CodeGeneratorJS.pm: Changed to use PassRefPtr for
1708 the structure and the wrapped object when creating wrappers.
1709 Simplified some of the special cases for DOMWindow so they are
1710 different only in ways the need to be. Eliminated the
1711 JSDOMWindow::createPrototype and JSDOMWindowPrototype::self
1712 functions. Moved responsibility for creating the structure and
1713 parent prototype out of the prototype constructor into the
1714 createPrototype function. Removed the unused "DoNotCache" flag for
1715 objects other than DOMWindow. Use getDOMConstructor instead of
1716 cacheGlobalObject for constructors. Make each constructor have
1717 a unique structure ID.
1718
1719 * bridge/objc/objc_runtime.h: Added createPrototype and changed the
1720 name of the info member to s_info so we can use the standard DOM
1721 binding macros to handl the prototype.
1722 * bridge/objc/objc_runtime.mm: Fixed namespacing a bit.
1723 (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
1724 Create a unique structure using getDOMStructure.
1725
1726 * bridge/runtime_array.cpp: Fixed namespacing a bit.
1727 (JSC::RuntimeArray::RuntimeArray): Create a unique structure using
1728 getDOMStructure.
1729 * bridge/runtime_array.h: Added createPrototype so getDOMStructure
1730 will work.
1731
1732 * bridge/runtime_object.cpp:
1733 (JSC::RuntimeObjectImp::RuntimeObjectImp): Create a unique structure using
1734 getDOMStructure.
1735 * bridge/runtime_object.h: Added createPrototype so getDOMStructure
1736 will work.
1737
1738 * history/CachedPage.cpp:
1739 (WebCore::CachedPage::restore): Let the window shell's
1740 setWindow function create the JSDOMWindow instead of doing it here.
1741
1742 * page/DOMWindow.idl: Removed DoNotCache, which is no longer used.
1743
mitz@apple.comd6b74252008-09-19 21:02:55 +000017442008-09-19 Dan Bernstein <mitz@apple.com>
1745
1746 Reviewed by Dave Hyatt.
1747
1748 This optimization was suggested by Daniel Fenwick
1749
1750 - speed up measuring text on the Core Text code path by not specifying a paragraph writing direction
1751
1752 Specifying LTR paragraph directionality when measuring runs of RTL text
mitz@apple.com308acec2008-09-19 21:10:48 +00001753 resulted in typically two CTRuns being generated for every run instead
mitz@apple.comd6b74252008-09-19 21:02:55 +00001754 of one, due to the leading space being reordered to the left.
1755
1756 * platform/graphics/SimpleFontData.h: Removed the ltr parameter to
1757 getCFStringAttributes() and changed m_CFStringAttributes from an array
1758 to a single value.
1759 * platform/graphics/mac/CoreTextController.cpp:
1760 (WebCore::CoreTextController::CoreTextController): Added a
1761 mayUseNaturalWritingDirection parameter.
1762 (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Changed
1763 to force the bidi embedding level whenever
1764 m_mayUseNaturalWritingDirectrion is false. Since this is now a common
1765 case, made the typesetter options dictionaries static.
1766 * platform/graphics/mac/CoreTextController.h:
1767 * platform/graphics/mac/FontMacCoreText.cpp:
1768 (WebCore::Font::selectionRectForComplexText): Renamed a local variable.
1769 (WebCore::Font::floatWidthForComplexText): Changed to allow the
1770 CoreTextController to not set the writing direction.
1771 * platform/graphics/mac/SimpleFontDataMac.mm:
1772 (WebCore::SimpleFontData::getCFStringAttributes): Removed the ltr
1773 parameter and the paragraph style attribute.
1774
hyatt@apple.com2d7bdf72008-09-19 20:54:33 +000017752008-09-19 David Hyatt <hyatt@apple.com>
1776
1777 Reviewed by Sam Weinig
1778
1779 https://bugs.webkit.org/show_bug.cgi?id=20941
1780
1781 Incorrect height calculation for replaced element inside nested
1782 positioned elements (where the inner has a percentage height and
1783 the outer implicitly has a fixed height because of explicit top/bottom
1784 values).
1785
1786 Added fast/block/positioning/replaced-inside-top-bottom.html
1787
1788 * rendering/RenderBox.cpp:
1789 (WebCore::RenderBox::availableHeightUsing):
1790
cfleizach@apple.com37bd8d72008-09-19 20:48:57 +000017912008-09-19 Chris Fleizach <cfleizach@apple.com>
1792
1793 Fix Tiger bustage
1794
1795 * page/mac/AccessibilityObjectWrapper.mm:
1796
cfleizach@apple.com63b88ab2008-09-19 20:24:48 +000017972008-09-18 Chris Fleizach <cfleizach@apple.com>
1798
1799 Reviewed by Darin Adler.
1800
1801 <rdar://problem/6211041> Expose legend tag in accessibility
1802
1803 Exposes the legend tag as the titleUIElement of a fieldset
1804
1805 Test: accessibility/legend.html
1806
1807 * page/AccessibilityObject.h:
1808 (WebCore::AccessibilityObject::isFieldset):
1809 * page/AccessibilityRenderObject.cpp:
1810 (WebCore::AccessibilityRenderObject::isFieldset):
1811 (WebCore::AccessibilityRenderObject::titleUIElement):
1812 * page/AccessibilityRenderObject.h:
1813 * rendering/RenderFieldset.h:
1814
cfleizach@apple.comcff26212008-09-19 20:04:13 +000018152008-09-19 Chris Fleizach <cfleizach@apple.com>
1816
1817 Reviewed by Darin Adler.
1818
1819 <rdar://problem/6213171> WebKit should use new array-centric methods for AX performance
1820
1821 Implement a few AX API methods that will be called by AppKit, which will
1822 speed up access to accessibility objects
1823
1824 * page/mac/AccessibilityObjectWrapper.mm:
1825 (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
1826 (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
1827 (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
1828
zecke@webkit.org7594eb62008-09-19 11:06:55 +000018292008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
1830
1831 Reviewed by Simon Hausmann.
1832
zecke@webkit.org3df68032008-09-19 11:43:27 +00001833 [qtwebkit] Set the m_should* flags to their proper value on entry
1834 With plugins it was possible that we finished a job twice. This was
1835 some kind of reentrancy in QNetworkReplyHandler::sendQueuedItems. By
1836 setting the flag to (m_loadMode == LoadDeferred) they will always have
1837 the right value and we will not send responses twice.
1838
1839 * platform/network/qt/QNetworkReplyHandler.cpp:
1840
18412008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
1842
1843 Reviewed by Simon Hausmann.
1844
zecke@webkit.org7594eb62008-09-19 11:06:55 +00001845 [qtwebkit] Pass test 70 of acid3. Handle text decoding errors
1846 Handle text decoding errors before instructing the parser to parse. We
1847 have converted the text to QString and all encoding errors are gone and
1848 the parser will not be able to detect them. So handle them before parsing.
1849
1850 * dom/XMLTokenizerQt.cpp:
1851 (WebCore::XMLTokenizer::doWrite):
1852
darin@apple.comc9aea832008-09-19 06:49:35 +000018532008-09-18 Darin Adler <darin@apple.com>
1854
1855 Reviewed by Maciej Stachowiak.
1856
1857 - part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858
1858 make each distinct C++ class get a distinct JSC::Structure
1859
1860 * bindings/js/JSCSSStyleDeclarationCustom.cpp:
1861 (WebCore::JSCSSStyleDeclaration::customPut): Use setDOMException
1862 instead of DOMExceptionTranslator.
1863
1864 * bindings/js/JSDOMBinding.cpp:
1865 (WebCore::getCachedDOMObjectWrapper): Updated function name.
1866 (WebCore::cacheDOMObjectWrapper): Ditto.
1867 (WebCore::forgetDOMObject): Ditto.
1868 (WebCore::getCachedDOMNodeWrapper): Ditto.
1869 (WebCore::forgetDOMNode): Ditto.
1870 (WebCore::cacheDOMNodeWrapper): Ditto.
1871 (WebCore::forgetAllDOMNodesForDocument): Ditto.
1872 (WebCore::markDOMNodesForDocument): Ditto.
1873 (WebCore::updateDOMNodeDocument): Ditto.
1874 (WebCore::getCachedDOMStructure): Added.
1875 (WebCore::createDOMStructure): Ditto.
1876
1877 * bindings/js/JSDOMBinding.h: Get rid of the ScriptInterpreter
1878 class and replace the static member functions with non-member
1879 functions. Added many other functions for getting at structures,
1880 prototypes, wrappers, and creating them. Also moved the
1881 cacheGlobalObject function here from JavaScriptCore; eventually
1882 I'll remove that once I get rid of the remaining callers. Also
1883 removed the DOMExceptionTranslator class.
1884
1885 * bindings/js/JSDOMWindowBase.h: Added JSDOMStructureMap type,
1886 and put one of those maps in each window.
1887
1888 * bindings/js/JSDOMWindowCustom.cpp:
1889 (WebCore::markDOMObjectWrapper): Updated for function name change.
1890 (WebCore::JSDOMWindow::mark): Added code to mark all the structures
1891 in the structure map.
1892
1893 * bindings/js/JSEventTargetNode.cpp:
1894 (WebCore::JSEventTargetNode::JSEventTargetNode): Changed to take
1895 a structure instead of a prototype.
1896 * bindings/js/JSEventTargetNode.h: Ditto.
1897 * bindings/js/JSHTMLAllCollection.h:
1898 (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Ditto.
1899
1900 * bindings/js/JSHTMLInputElementBase.cpp:
1901 (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Removed
1902 use of the JSC_IMPLEMENT_PROTOTYPE macro, and changed to take a
1903 structure instead of a prototype.
1904 * bindings/js/JSHTMLInputElementBase.h: Removed use of the
1905 JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro, and changed constructor
1906 to take a structure instead of a prototype. Created a dummy prototype
1907 class that causes the HTMLInputElement prototype to have the
1908 HTMLElement prototype.
1909
1910 * bindings/scripts/CodeGeneratorJS.pm: Change constructors to take
1911 structures instead of prototypes. Changed the prototype self function
1912 to use the getDOMPrototype function -- later we can eliminate it and
1913 have callers invoke getDOMPrototype directly instead. Updated other
1914 functions that have name changes. Added code to generate the
1915 createPrototype member function. Changed use of cacheGlobalObject to
1916 get it from the WebCore namespace instead of the JSC namespace.
1917 Changed cacheDOMObject calls to use getDOMObjectWrapper instead.
1918
1919 * dom/Document.cpp:
1920 (WebCore::Document::~Document): Updated for name change and also
1921 removed unnecessary JSLock use -- there's no need to lock around this.
1922 * dom/Node.cpp:
1923 (WebCore::Node::setDocument): Ditto.
1924
1925 * dom/make_names.pl: Changed to use CREATE_DOM_NODE_WRAPPER macro
1926 instead of calling new directly.
1927
1928 * bindings/js/JSCSSRuleCustom.cpp:
1929 (WebCore::toJS): Updated for function name changes and used the
1930 CREATE_DOM_OBJECT_WRAPPER macro.
1931 * bindings/js/JSCSSValueCustom.cpp:
1932 (WebCore::toJS): Ditto.
1933 * bindings/js/JSCanvasPixelArrayCustom.cpp:
1934 (WebCore::toJS): Ditto.
1935 * bindings/js/JSDocumentCustom.cpp:
1936 (WebCore::JSDocument::mark): Ditto.
1937 (WebCore::toJS): Ditto.
1938 * bindings/js/JSElementCustom.cpp:
1939 (WebCore::toJSNewlyCreated): Ditto.
1940 * bindings/js/JSEventCustom.cpp:
1941 (WebCore::toJS): Ditto.
1942 * bindings/js/JSEventTargetBase.cpp:
1943 (WebCore::jsEventTargetDispatchEvent): Use setDOMException instead
1944 of DOMExceptionTranslator.
1945 (WebCore::toJS): Updated for function name changes and used the
1946 CREATE_DOM_OBJECT_WRAPPER macro.
1947 * bindings/js/JSHTMLCollectionCustom.cpp:
1948 (WebCore::toJS): Ditto.
1949 * bindings/js/JSNodeCustom.cpp:
1950 (WebCore::JSNode::mark): Ditto.
1951 (WebCore::createWrapper): Ditto.
1952 (WebCore::toJS): Ditto.
1953 * bindings/js/JSSVGPathSegCustom.cpp:
1954 (WebCore::toJS): Ditto.
1955 * bindings/js/JSStyleSheetCustom.cpp:
1956 (WebCore::toJS): Ditto.
1957 (WebCore::JSStyleSheet::mark): Ditto.
1958 * bindings/js/JSTextCustom.cpp:
1959 (WebCore::toJSNewlyCreated): Ditto.
1960 * bindings/js/JSXMLHttpRequestConstructor.cpp:
1961 (WebCore::constructXMLHttpRequest): Ditto.
1962 * bindings/js/JSXMLHttpRequestCustom.cpp:
1963 (WebCore::JSXMLHttpRequest::mark): Ditto.
1964 * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
1965 (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
1966 * bindings/js/JSXSLTProcessorConstructor.cpp:
1967 (WebCore::constructXSLTProcessor): Ditto.
1968 * bindings/js/ScriptController.cpp:
1969 (WebCore::ScriptController::finishedWithEvent): Ditto.
1970 * xml/XMLHttpRequest.cpp:
1971 (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto.
1972 (WebCore::XMLHttpRequest::dropProtection): Ditto.
1973
hyatt@apple.com083539d2008-09-19 06:30:16 +000019742008-09-18 David Hyatt <hyatt@apple.com>
1975
1976 This patch gets a viewless scrollbar working on Mac. It is turned off
1977 by default. Hit testing works. For now the scrollbar just paints ugly
1978 debug rects in the place of the buttons, track and thumb. It does match
1979 Aqua metrics though.
1980
1981 Reviewed by Sam Weinig
1982
1983 * WebCore.xcodeproj/project.pbxproj:
1984 * page/mac/EventHandlerMac.mm:
1985 (WebCore::EventHandler::passMousePressEventToScrollbar):
1986 * platform/ScrollbarThemeComposite.cpp:
1987 (WebCore::ScrollbarThemeComposite::paint):
1988 (WebCore::ScrollbarThemeComposite::trackPosition):
1989 * platform/ScrollbarThemeComposite.h:
1990 * platform/mac/ScrollViewMac.mm:
1991 (WebCore::ScrollView::addChild):
1992 * platform/mac/ScrollbarThemeMac.cpp:
1993 (WebCore::):
1994 (WebCore::ScrollbarThemeMac::hasButtons):
1995 (WebCore::ScrollbarThemeMac::hasThumb):
1996 (WebCore::buttonRepaintRect):
1997 (WebCore::ScrollbarThemeMac::backButtonRect):
1998 (WebCore::ScrollbarThemeMac::forwardButtonRect):
1999 (WebCore::trackRepaintRect):
2000 (WebCore::ScrollbarThemeMac::trackRect):
2001 (WebCore::ScrollbarThemeMac::minimumThumbLength):
2002 (WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
2003 (WebCore::ScrollbarThemeMac::paintTrack):
2004 (WebCore::ScrollbarThemeMac::paintButton):
2005 (WebCore::ScrollbarThemeMac::paintThumb):
2006 * platform/mac/ScrollbarThemeMac.h:
2007 (WebCore::ScrollbarThemeMac::supportsControlTints):
2008 * platform/qt/ScrollbarThemeQt.cpp:
2009 (WebCore::ScrollbarThemeQt::trackPosition):
2010
collinj@webkit.org51261aa2008-09-19 06:13:22 +000020112008-09-18 Collin Jackson <collinj@webkit.org>
2012
2013 Build fix; added missing header file to GNUmakefile.am
2014
2015 * GNUmakefile.am:
2016
weinig@apple.com39aecbe2008-09-19 04:56:21 +000020172008-09-18 Sam Weinig <sam@webkit.org>
2018
2019 Reviewed by David "the Hair" Hyatt.
2020
2021 Move DataRef, SVGRenderStyle and SVGRenderStyleDefs in render/style.
2022
2023 * GNUmakefile.am:
2024 * WebCore.pro:
2025 * WebCore.vcproj/WebCore.vcproj:
2026 * WebCore.xcodeproj/project.pbxproj:
2027 * rendering/DataRef.h: Removed.
2028 * rendering/SVGRenderStyle.cpp: Removed.
2029 * rendering/SVGRenderStyle.h: Removed.
2030 * rendering/SVGRenderStyleDefs.cpp: Removed.
2031 * rendering/SVGRenderStyleDefs.h: Removed.
2032 * rendering/style/DataRef.h: Copied from rendering/DataRef.h.
2033 * rendering/style/SVGRenderStyle.cpp: Copied from rendering/SVGRenderStyle.cpp.
2034 * rendering/style/SVGRenderStyle.h: Copied from rendering/SVGRenderStyle.h.
2035 * rendering/style/SVGRenderStyleDefs.cpp: Copied from rendering/SVGRenderStyleDefs.cpp.
2036 * rendering/style/SVGRenderStyleDefs.h: Copied from rendering/SVGRenderStyleDefs.h.
2037
mrowe@apple.coma5206592008-09-19 04:47:58 +000020382008-09-18 Mark Rowe <mrowe@apple.com>
2039
2040 Reviewed by Dan Bernstein.
2041
2042 Add a means of clearing a FrameTree's name.
2043
2044 * WebCore.base.exp:
2045 * page/FrameTree.cpp:
2046 (WebCore::FrameTree::clearName):
2047 * page/FrameTree.h:
2048
hyatt@apple.com6eeef382008-09-19 04:30:53 +000020492008-09-18 David Hyatt <hyatt@apple.com>
2050
2051 Eliminate addToSuperview from Widget, since it was only called
2052 by ScrollViewMac's addChild method. Just shift the original body
2053 of addToSuperView into addChild.
2054
2055 Reviewed by Sam Weinig
2056
2057 * platform/Widget.h:
2058 * platform/mac/ScrollViewMac.mm:
2059 (WebCore::ScrollView::addChild):
2060 * platform/mac/WidgetMac.mm:
2061
collinj@webkit.org9c672f62008-09-19 04:15:14 +000020622008-09-18 Collin Jackson <collinj@webkit.org>
2063
2064 Reviewed by Antti Koivisto and Mark Rowe.
2065
2066 Test: http/tests/misc/dns-prefetch-control.html
2067
2068 https://bugs.webkit.org/show_bug.cgi?id=20690
2069
2070 Invoke WebCore::prefetchDNS() on host names that appear in
2071 in the href of hyperlinks and <link rel="dns-prefetch">. This
2072 can be used to implement DNS prefetching.
2073
2074 * WebCore.vcproj/WebCore.vcproj:
2075 * WebCore.xcodeproj/project.pbxproj:
2076 * dom/Document.cpp:
2077 (WebCore::Document::Document):
2078 (WebCore::Document::processHttpEquiv):
2079 (WebCore::Document::setSecurityOrigin):
2080 (WebCore::Document::initDNSPrefetch):
2081 (WebCore::Document::parseDNSPrefetchControlHeader):
2082 * dom/Document.h:
2083 (WebCore::Document::isDNSPrefetchEnabled):
2084 * html/HTMLAnchorElement.cpp:
2085 (WebCore::HTMLAnchorElement::parseMappedAttribute):
2086 * html/HTMLLinkElement.cpp:
2087 (WebCore::HTMLLinkElement::HTMLLinkElement):
2088 (WebCore::HTMLLinkElement::parseMappedAttribute):
2089 (WebCore::HTMLLinkElement::tokenizeRelAttribute):
2090 (WebCore::HTMLLinkElement::process):
2091 * html/HTMLLinkElement.h:
2092 * html/PreloadScanner.cpp:
2093 (WebCore::PreloadScanner::processAttribute):
2094 * loader/FrameLoader.cpp:
2095 (WebCore::FrameLoader::begin):
2096 * platform/gtk/TemporaryLinkStubs.cpp:
2097 (WebCore::prefetchDNS):
2098 * platform/network/DNS.h: Added.
2099 * platform/network/cf/DNSCFNet.cpp: Added.
2100 (WebCore::prefetchDNS):
2101 * platform/qt/TemporaryLinkStubs.cpp:
2102 (WebCore::prefetchDNS):
2103 * platform/wx/TemporaryLinkStubs.cpp:
2104 (WebCore::prefetchDNS):
2105
hyatt@apple.comc5b931a2008-09-19 00:39:51 +000021062008-09-18 David Hyatt <hyatt@apple.com>
2107
hyatt@apple.comcf31c162008-09-19 04:01:56 +00002108 Eliminate the convertToScreenCoordinate method on Widget, since
2109 ScrollView has redundant methods that already do the same thing.
2110
2111 Reviewed by Sam Weinig
2112
2113 * editing/mac/SelectionControllerMac.mm:
2114 (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
2115 * platform/Widget.h:
2116 * platform/mac/WidgetMac.mm:
2117 (WebCore::Widget::containingWindow):
2118
21192008-09-18 David Hyatt <hyatt@apple.com>
2120
hyatt@apple.com179629b3c2008-09-19 03:16:26 +00002121 Move to only one constructor for Widgets. Rename data to m_data and make
2122 it have an #ifdef only for platforms that have platform-specific data (Mac
2123 and Gtk).
2124
2125 Reviewed by Sam Weinig
2126
2127 * WebCore.base.exp:
2128 * platform/Widget.cpp:
2129 (WebCore::Widget::init):
2130 * platform/Widget.h:
2131 * platform/gtk/WidgetGtk.cpp:
2132 (WebCore::Widget::Widget):
2133 (WebCore::Widget::~Widget):
2134 (WebCore::Widget::cursor):
2135 (WebCore::Widget::setCursor):
2136 * platform/mac/WidgetMac.mm:
2137 (WebCore::Widget::Widget):
2138 (WebCore::Widget::~Widget):
2139 (WebCore::Widget::addToSuperview):
2140 (WebCore::Widget::removeFromSuperview):
2141 (WebCore::Widget::beforeMouseDown):
2142 (WebCore::Widget::afterMouseDown):
2143 * platform/qt/WidgetQt.cpp:
2144 (WebCore::Widget::Widget):
2145 * platform/win/WidgetWin.cpp:
2146 (WebCore::Widget::Widget):
2147 * platform/wx/WidgetWx.cpp:
2148 (WebCore::Widget::Widget):
2149
21502008-09-18 David Hyatt <hyatt@apple.com>
2151
hyatt@apple.com470d7e72008-09-19 03:01:08 +00002152 Move Qt's isNPAPIPlugin boolean from Widget down to PluginView, since there
2153 was no reason for it to be on Widget. This change eliminates Qt ifdefs
2154 from Widget.
2155
2156 Reviewed by Sam Weinig
2157
2158 * bindings/js/ScriptControllerQt.cpp:
2159 (WebCore::ScriptController::createScriptInstanceForWidget):
2160 * platform/qt/WidgetQt.cpp:
2161 (WebCore::WidgetPrivate::WidgetPrivate):
2162 (WebCore::WidgetPrivate::~WidgetPrivate):
2163 (WebCore::Widget::Widget):
2164 (WebCore::Widget::~Widget):
2165 * plugins/PluginView.cpp:
2166 (WebCore::PluginView::PluginView):
2167 * plugins/PluginView.h:
2168 (WebCore::PluginView::isNPAPIPlugin):
2169 (WebCore::PluginView::setIsNPAPIPlugin):
2170
21712008-09-18 David Hyatt <hyatt@apple.com>
2172
hyatt@apple.com557408b2008-09-19 02:36:08 +00002173 Make geometryChanged() cross-platform on Widget. GTK and WIN platform
2174 ifdefs are now gone from Widget!
2175
2176 Reviewed by Sam Weinig
2177
2178 * platform/Widget.h:
2179 (WebCore::Widget::geometryChanged):
2180 * platform/gtk/WidgetGtk.cpp:
2181 * platform/qt/WidgetQt.cpp:
2182
21832008-09-18 David Hyatt <hyatt@apple.com>
2184
hyatt@apple.com17e57432008-09-19 02:29:27 +00002185 Consolidate convertTo/FromContainingWindow methods so that all platforms
2186 but Mac share the same code.
2187
2188 Move convertSelfToChild and convertChildToSelf to ScrollView, since
2189 Widget should know nothing about children. Make the methods cross-platform
2190 on ScrollView.
2191
2192 Reviewed by Sam Weinig
2193
2194 * platform/ScrollView.h:
2195 (WebCore::ScrollView::convertChildToSelf):
2196 (WebCore::ScrollView::convertSelfToChild):
2197 * platform/Widget.cpp:
2198 (WebCore::Widget::convertToContainingWindow):
2199 (WebCore::Widget::convertFromContainingWindow):
2200 * platform/Widget.h:
2201 (WebCore::Widget::geometryChanged):
2202 * platform/gtk/ScrollViewGtk.cpp:
2203 (WebCore::ScrollView::isScrollViewScrollbar):
2204 * platform/gtk/WidgetGtk.cpp:
2205 * platform/mac/ScrollViewMac.mm:
2206 (WebCore::ScrollView::isScrollViewScrollbar):
2207 * platform/mac/WidgetMac.mm:
2208 * platform/qt/ScrollViewQt.cpp:
2209 (WebCore::ScrollView::isScrollViewScrollbar):
2210 * platform/qt/WidgetQt.cpp:
2211 * platform/win/ScrollViewWin.cpp:
2212 (WebCore::ScrollView::isScrollViewScrollbar):
2213 * platform/win/WidgetWin.cpp:
2214
22152008-09-18 David Hyatt <hyatt@apple.com>
2216
hyatt@apple.comc5b931a2008-09-19 00:39:51 +00002217 Make the conversion methods that go to and from some containingWindow
2218 cross-platform. Implement them on Mac.
2219
2220 Reviewed by Sam Weinig
2221
2222 * platform/Widget.h:
2223 (WebCore::Widget::setContainingWindow):
2224 * platform/mac/WidgetMac.mm:
2225 (WebCore::Widget::convertFromContainingWindow):
2226 (WebCore::Widget::convertToContainingWindow):
2227
weinig@apple.comd1ea02d2008-09-19 00:28:05 +000022282008-09-18 Sam Weinig <sam@webkit.org>
2229
2230 Rubber-stamped by David "Yeah-yeah" Hyatt.
2231
2232 Cleanup RenderStyle.
2233
2234 * WebCore.xcodeproj/project.pbxproj:
2235 * rendering/style/CounterContent.h:
2236 * rendering/style/RenderStyle.cpp:
2237 * rendering/style/RenderStyle.h:
2238
dino@apple.comef93f532008-09-19 00:01:07 +000022392008-09-18 Chris Marrin <cmarrin@apple.com>
2240
2241 Reviewed by Sam Weinig
2242
2243 Fixed https://bugs.webkit.org/show_bug.cgi?id=20908
2244 Now TransformOperations and AnimationList no longer
2245 inherit from Vector<> but rather have API to access.
2246
2247 * css/CSSComputedStyleDeclaration.cpp:
2248 (WebCore::computedTransform):
2249 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2250 * css/CSSStyleSelector.cpp:
2251 (WebCore::CSSStyleSelector::createTransformOperations):
2252 * page/animation/AnimationBase.cpp:
2253 (WebCore::blendFunc):
2254 * page/animation/CompositeAnimation.cpp:
2255 (WebCore::CompositeAnimation::updateTransitions):
2256 (WebCore::CompositeAnimation::updateKeyframeAnimations):
2257 (WebCore::CompositeAnimation::animate):
2258 * page/animation/ImplicitAnimation.cpp:
2259 (WebCore::ImplicitAnimation::validateTransformFunctionList):
2260 * page/animation/KeyframeAnimation.cpp:
2261 (WebCore::KeyframeAnimation::validateTransformFunctionList):
2262 * rendering/RenderLayer.cpp:
2263 (WebCore::RenderLayer::updateReflectionStyle):
2264 * rendering/style/AnimationList.cpp:
2265 (WebCore::AnimationList::operator==):
2266 * rendering/style/AnimationList.h:
2267 (WebCore::AnimationList::operator!=):
2268 (WebCore::AnimationList::size):
2269 (WebCore::AnimationList::isEmpty):
2270 (WebCore::AnimationList::resize):
2271 (WebCore::AnimationList::remove):
2272 (WebCore::AnimationList::append):
2273 (WebCore::AnimationList::animation):
2274 * rendering/style/RenderStyle.cpp:
2275 (WebCore::StyleRareNonInheritedData::updateKeyframes):
2276 (WebCore::RenderStyle::applyTransform):
2277 (WebCore::RenderStyle::adjustAnimations):
2278 (WebCore::RenderStyle::adjustTransitions):
2279 (WebCore::RenderStyle::transitionForProperty):
2280 * rendering/style/RenderStyle.h:
2281 (WebCore::RenderStyle::hasTransform):
2282 * rendering/style/TransformOperations.cpp:
2283 (WebCore::TransformOperations::TransformOperations):
2284 (WebCore::TransformOperations::operator==):
2285 * rendering/style/TransformOperations.h:
2286 (WebCore::TransformOperations::apply):
2287 (WebCore::TransformOperations::operations):
2288
zecke@webkit.org20690ef2008-09-18 23:28:34 +000022892008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
2290
zecke@webkit.org30db7422008-09-19 01:00:18 +00002291 Build fix.
2292
2293 [qt] Build fixes after the Widget/ScrollView cleanup
2294 topLevel() is now root()
2295
2296
2297 * platform/qt/ScrollViewQt.cpp:
2298 (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
2299 (WebCore::ScrollView::addChild):
2300 (WebCore::ScrollView::removeChild):
2301
23022008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
2303
zecke@webkit.org20690ef2008-09-18 23:28:34 +00002304 Reviewed by Mark Rowe.
2305
2306 https://bugs.webkit.org/show_bug.cgi?id=20437
2307
2308 XMLTokenizer.cpp used to contain two different implementations. One was using
2309 libxml2 and the other was using the Qt XML StreamReader. Clean up the code by
2310 separating the two implementations from each other.
2311 Common code and some small bits are kept inside the XMLTokenizer.cpp, the Qt code
2312 was moved to XMLTokenizerQt.cpp and the Libxml2 based code was moved to
2313 XMLTokenizerLibxml2.cpp. There should be no functional changes.
2314
2315 Attempt to add XMLTokenizerLibxml2.cpp to every buildsystem so the build continues
2316 to work.
2317
2318 * GNUmakefile.am:
2319 * WebCore.pro:
2320 * WebCore.vcproj/WebCore.vcproj:
2321 * WebCore.xcodeproj/project.pbxproj:
2322 * WebCoreSources.bkl:
2323 * dom/XMLTokenizer.cpp:
2324 (WebCore::isScriptElement):
2325 (WebCore::castToScriptElement):
2326 (WebCore::XMLTokenizer::setCurrentNode):
2327 (WebCore::XMLTokenizer::write):
2328 (WebCore::XMLTokenizer::eventuallyMarkAsParserCreated):
2329 (WebCore::XMLTokenizer::enterText):
2330 (WebCore::toString):
2331 (WebCore::XMLTokenizer::exitText):
2332 (WebCore::XMLTokenizer::end):
2333 (WebCore::XMLTokenizer::insertErrorMessageBlock):
2334 * dom/XMLTokenizer.h:
2335 (WebCore::XMLTokenizer::wellFormed):
2336 * dom/XMLTokenizerLibxml2.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
2337 (WebCore::createMemoryParser):
2338 (WebCore::XMLTokenizer::XMLTokenizer):
2339 (WebCore::XMLTokenizer::~XMLTokenizer):
2340 (WebCore::XMLTokenizer::doWrite):
2341 (WebCore::ignorableWhitespaceHandler):
2342 (WebCore::XMLTokenizer::initializeParserContext):
2343 (WebCore::XMLTokenizer::doEnd):
2344 (WebCore::XMLTokenizer::lineNumber):
2345 (WebCore::XMLTokenizer::columnNumber):
2346 (WebCore::XMLTokenizer::stopParsing):
2347 (WebCore::XMLTokenizer::resumeParsing):
2348 (WebCore::parseXMLDocumentFragment):
2349 (WebCore::attributesStartElementNsHandler):
2350 (WebCore::parseAttributes):
2351 * dom/XMLTokenizerQt.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
2352 (WebCore::EntityResolver::resolveUndeclaredEntity):
2353 (WebCore::XMLTokenizer::XMLTokenizer):
2354 (WebCore::XMLTokenizer::~XMLTokenizer):
2355 (WebCore::XMLTokenizer::doWrite):
2356 (WebCore::XMLTokenizer::initializeParserContext):
2357 (WebCore::XMLTokenizer::doEnd):
2358 (WebCore::XMLTokenizer::lineNumber):
2359 (WebCore::XMLTokenizer::columnNumber):
2360 (WebCore::XMLTokenizer::stopParsing):
2361 (WebCore::XMLTokenizer::resumeParsing):
2362 (WebCore::parseXMLDocumentFragment):
2363 (WebCore::attributesStartElementNsHandler):
2364 (WebCore::parseAttributes):
2365 (WebCore::):
2366
bdakin@apple.com4c244902008-09-18 23:08:35 +000023672008-09-18 Beth Dakin <bdakin@apple.com>
2368
2369 Reviewed by Geoff Garen.
2370
2371 Build fix for non-Mac builds.
2372
2373 * css/CSSPrimitiveValue.cpp:
2374 (WebCore::CSSPrimitiveValue::cssText):
2375
eric@webkit.org4ac94e62008-09-18 23:07:55 +000023762008-09-18 Peter Kasting <pkasting@google.com>
2377
2378 Reviewed by hyatt. Landed by eseidel.
2379
2380 https://bugs.webkit.org/show_bug.cgi?id=20745
2381 Animated GIFs do not animate properly with (at least) CG.
2382
2383 * WebCore\platform\graphics\BitmapImage.cpp:
2384 * WebCore\platform\graphics\BitmapImage.h:
2385 * WebCore\platform\graphics\cairo\ImageCairo.cpp:
2386 * WebCore\platform\graphics\cg\ImageCG.cpp:
2387 * WebCore\platform\graphics\qt\ImageQt.cpp:
2388 * WebCore\platform\graphics\wx\ImageWx.cpp:
2389
cfleizach@apple.com2a72d8f2008-09-18 22:54:37 +000023902008-09-18 Chris Fleizach <cfleizach@apple.com>
2391
2392 Reviewed by Beth Dakin
2393
2394 <rdar://problem/6224222> AX: should not expose a <table> as an AXTable if ARIA
2395 role specifies otherwise
2396
2397 If a <table> isn't an AXTable, the rows and cells should default to AccessibilityRenderObject
2398
2399 Test: accessibility/table-with-aria-role.html
2400
2401 * page/AccessibilityTable.cpp:
2402 (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
2403 (WebCore::AccessibilityTable::addChildren):
2404 (WebCore::AccessibilityTable::roleValue):
2405 (WebCore::AccessibilityTable::accessibilityIsIgnored):
2406 (WebCore::AccessibilityTable::title):
2407 * page/AccessibilityTableCell.cpp:
2408 (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
2409 (WebCore::AccessibilityTableCell::isTableCell):
2410 (WebCore::AccessibilityTableCell::roleValue):
2411 * page/AccessibilityTableCell.h:
2412 * page/AccessibilityTableRow.cpp:
2413 (WebCore::AccessibilityTableRow::roleValue):
2414 (WebCore::AccessibilityTableRow::isTableRow):
2415 (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
2416 * page/AccessibilityTableRow.h:
2417
sfalken@apple.coma96c5d32008-09-18 22:29:34 +000024182008-09-18 Steve Falkenburg <sfalken@apple.com>
2419
2420 Use higher-resolution timers on all variants of Windows.
2421
2422 Reviewed by Darin Adler.
2423
2424 * platform/win/SharedTimerWin.cpp:
2425 (WebCore::setSharedTimerFireTime):
2426
2427
hyatt@apple.comb7d49b62008-09-18 22:21:25 +000024282008-09-18 David Hyatt <hyatt@apple.com>
2429
2430 Make containingWindow() and setContainingWindow() cross-platform.
2431 Add a root() function cross-platform so Qt doesn't have to
2432 define its own.
2433
2434 Reviewed by Darin Adler
2435
2436 * platform/Widget.cpp:
2437 (WebCore::Widget::root):
2438 * platform/Widget.h:
2439 (WebCore::Widget::setContainingWindow):
2440 * platform/gtk/WidgetGtk.cpp:
2441 (WebCore::Widget::Widget):
2442 (WebCore::Widget::containingWindow):
2443 * platform/mac/ScrollViewMac.mm:
2444 (WebCore::ScrollView::addChild):
2445 (WebCore::ScrollView::removeChild):
2446 * platform/mac/WidgetMac.mm:
2447 (WebCore::Widget::containingWindow):
2448 * platform/qt/WidgetQt.cpp:
2449 (WebCore::Widget::invalidateRect):
2450 (WebCore::Widget::containingWindow):
2451 * platform/win/WidgetWin.cpp:
2452 (WebCore::Widget::Widget):
2453 (WebCore::Widget::~Widget):
2454 (WebCore::Widget::containingWindow):
2455
bdakin@apple.comfa1ce162008-09-18 22:18:01 +000024562008-09-18 Beth Dakin <bdakin@apple.com>
2457
2458 Reviewed by Dave Hyatt.
2459
2460 Fix for https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon
2461 parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
2462 dashboard-region=
2463 and corresponding: <rdar://problem/6174100>
2464
2465 This patch makes CSSParserValue::createCSSValue handle unknown
2466 identifiers.
2467
2468 * css/CSSParserValues.cpp:
2469 (WebCore::CSSParserValue::createCSSValue): If we have an identifier
2470 with no id (an unknown identifier) create a CSSPrimitiveValue of
2471 type CSS_PARSER_IDENTIFIER
2472 * css/CSSPrimitiveValue.cpp:
2473 (WebCore::CSSPrimitiveValue::cssText):
2474 (WebCore::CSSPrimitiveValue::parserValue):
2475 * css/CSSPrimitiveValue.h:
2476 (WebCore::CSSPrimitiveValue::):
2477
weinig@apple.comfce49be2008-09-18 21:46:14 +000024782008-09-18 Sam Weinig <sam@webkit.org>
2479
2480 Rubber-stamped by David "I'd prefer not" Hyatt.
2481
2482 More the remaining class out of RenderStyle.h/cpp
2483
2484 * GNUmakefile.am:
2485 * WebCore.pro:
2486 * WebCore.vcproj/WebCore.vcproj:
2487 * WebCore.xcodeproj/project.pbxproj:
2488 * WebCoreSources.bkl:
2489 * rendering/style/CursorData.h: Copied from rendering/style/RenderStyle.h.
2490 (WebCore::CursorData::CursorData):
2491 (WebCore::CursorData::operator==):
2492 (WebCore::CursorData::operator!=):
2493 * rendering/style/CursorList.h: Copied from rendering/style/RenderStyle.h.
2494 (WebCore::CursorList::operator[]):
2495 (WebCore::CursorList::CursorList):
2496 * rendering/style/RenderStyle.cpp:
2497 * rendering/style/RenderStyle.h:
2498 (WebCore::RenderStyle::deref):
2499 (WebCore::RenderStyle::hasOneRef):
2500 (WebCore::RenderStyle::InheritedFlags::operator!=):
2501 (WebCore::RenderStyle::NonInheritedFlags::operator!=):
2502 (WebCore::RenderStyle::hasBackground):
2503 (WebCore::RenderStyle::outlineWidth):
2504 (WebCore::RenderStyle::autoWrap):
2505 (WebCore::RenderStyle::preserveNewline):
2506 (WebCore::RenderStyle::collapseWhiteSpace):
2507 (WebCore::RenderStyle::isCollapsibleWhiteSpace):
2508 (WebCore::RenderStyle::breakOnlyAfterWhiteSpace):
2509 (WebCore::RenderStyle::breakWords):
2510 (WebCore::RenderStyle::outlineOffset):
2511 (WebCore::RenderStyle::setLeft):
2512 (WebCore::RenderStyle::setRight):
2513 (WebCore::RenderStyle::setTop):
2514 (WebCore::RenderStyle::setBottom):
2515 (WebCore::RenderStyle::setDashboardRegion):
2516 (WebCore::RenderStyle::setBackgroundColor):
2517 (WebCore::RenderStyle::setBorderImage):
2518 (WebCore::RenderStyle::setBorderRadius):
2519 (WebCore::RenderStyle::setFontDescription):
2520 (WebCore::RenderStyle::adjustBackgroundLayers):
2521 (WebCore::RenderStyle::adjustMaskLayers):
2522 (WebCore::RenderStyle::deleteBindingURIs):
2523 (WebCore::RenderStyle::inheritBindingURIs):
2524 (WebCore::RenderStyle::isDisplayReplacedType):
2525 (WebCore::RenderStyle::isDisplayInlineType):
2526 (WebCore::RenderStyle::isOriginalDisplayInlineType):
2527 * rendering/style/StyleInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
2528 * rendering/style/StyleInheritedData.h: Copied from rendering/style/RenderStyle.h.
2529 (WebCore::StyleInheritedData::operator!=):
2530 * rendering/style/StyleRareInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
2531 * rendering/style/StyleRareInheritedData.h: Copied from rendering/style/RenderStyle.h.
2532 (WebCore::StyleRareInheritedData::operator!=):
2533 * rendering/style/StyleRareNonInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
2534 * rendering/style/StyleRareNonInheritedData.h: Copied from rendering/style/RenderStyle.h.
2535 * rendering/style/StyleReflection.h: Copied from rendering/style/RenderStyle.h.
2536
hyatt@apple.com643534d2008-09-18 20:09:41 +000025372008-09-18 David Hyatt <hyatt@apple.com>
2538
hyatt@apple.comd23089a2008-09-18 20:24:16 +00002539 Move the concept of suppression invalidation on Widgets to Scrollbar
2540 instead. Since this is only used by Scrollbars, there is no need for
2541 it to be on Widget.
2542
2543 Reviewed by Sam Weinig
2544
2545 * platform/Scrollbar.cpp:
2546 (WebCore::Scrollbar::Scrollbar):
2547 (WebCore::Scrollbar::invalidateRect):
2548 * platform/Scrollbar.h:
2549 (WebCore::Scrollbar::suppressInvalidation):
2550 (WebCore::Scrollbar::setSuppressInvalidation):
2551 * platform/Widget.h:
2552 * platform/gtk/WidgetGtk.cpp:
2553 (WebCore::Widget::Widget):
2554 (WebCore::Widget::invalidateRect):
2555 * platform/qt/WidgetQt.cpp:
2556 (WebCore::WidgetPrivate::WidgetPrivate):
2557 (WebCore::Widget::invalidateRect):
2558 * platform/win/WidgetWin.cpp:
2559 (WebCore::Widget::Widget):
2560 (WebCore::Widget::invalidateRect):
2561
25622008-09-18 David Hyatt <hyatt@apple.com>
2563
hyatt@apple.com643534d2008-09-18 20:09:41 +00002564 Make invalidate() on Widget non-virtual and make it just call
2565 invalidateRect() on the boundsGeometry() of the Widget.
2566
2567 Reviewed by Dan Bernstein
2568
2569 * platform/Widget.h:
2570 (WebCore::Widget::boundsGeometry):
2571 (WebCore::Widget::invalidate):
2572 * platform/gtk/WidgetGtk.cpp:
2573 * platform/mac/WidgetMac.mm:
2574 * platform/qt/WidgetQt.cpp:
2575 * platform/win/WidgetWin.cpp:
2576 * platform/wx/WidgetWx.cpp:
2577
weinig@apple.comcaf2df42008-09-18 19:40:24 +000025782008-09-18 Sam Weinig <sam@webkit.org>
2579
2580 Rubber-stamped in exile by David Hyatt.
2581
2582 Split Animation, AnimationList, BindingURI, ContentData, CounterContent,
2583 KeyframeList, ShadowData, StyleFlexibleBoxData and TimingFunction out of
2584 RenderStyle.h/cpp
2585
2586 * GNUmakefile.am:
2587 * WebCore.pro:
2588 * WebCore.vcproj/WebCore.vcproj:
2589 * WebCore.xcodeproj/project.pbxproj:
2590 * WebCoreSources.bkl:
2591 * css/CSSStyleSelector.cpp:
2592 * css/CSSStyleSelector.h:
2593 * page/animation/CompositeAnimation.cpp:
2594 * page/animation/KeyframeAnimation.cpp:
2595 * page/animation/KeyframeAnimation.h:
2596 * rendering/RenderCounter.h:
2597 * rendering/style/Animation.cpp: Copied from rendering/style/RenderStyle.cpp.
2598 (WebCore::Animation::~Animation):
2599 (WebCore::Animation::animationsMatch):
2600 (WebCore::Animation::keyframeList):
2601 (WebCore::Animation::setAnimationKeyframe):
2602 * rendering/style/Animation.h: Copied from rendering/style/RenderStyle.h.
2603 * rendering/style/AnimationList.cpp: Copied from rendering/style/RenderStyle.cpp.
2604 * rendering/style/AnimationList.h: Copied from rendering/style/RenderStyle.h.
2605 * rendering/style/BindingURI.cpp: Copied from rendering/style/RenderStyle.cpp.
2606 * rendering/style/BindingURI.h: Copied from rendering/style/RenderStyle.h.
2607 (WebCore::BindingURI::operator!=):
2608 * rendering/style/ContentData.cpp: Copied from rendering/style/RenderStyle.cpp.
2609 * rendering/style/ContentData.h: Copied from rendering/style/RenderStyle.h.
2610 (WebCore::ContentData::ContentData):
2611 (WebCore::ContentData::~ContentData):
2612 * rendering/style/CounterContent.h: Copied from rendering/style/RenderStyle.h.
2613 (WebCore::CounterContent::CounterContent):
2614 * rendering/style/CounterDirectives.cpp: Copied from rendering/style/RenderStyle.cpp.
2615 * rendering/style/CounterDirectives.h: Copied from rendering/style/RenderStyle.h.
2616 (WebCore::CounterDirectives::CounterDirectives):
2617 * rendering/style/KeyframeList.cpp: Copied from rendering/style/RenderStyle.cpp.
2618 (WebCore::KeyframeList::insert):
2619 * rendering/style/KeyframeList.h: Copied from rendering/style/RenderStyle.h.
2620 (WebCore::KeyframeValue::KeyframeValue):
2621 (WebCore::KeyframeList::create):
2622 (WebCore::KeyframeList::KeyframeList):
2623 * rendering/style/RenderStyle.cpp:
2624 * rendering/style/RenderStyle.h:
2625 * rendering/style/ShadowData.cpp: Copied from rendering/style/RenderStyle.cpp.
2626 * rendering/style/ShadowData.h: Copied from rendering/style/RenderStyle.h.
2627 (WebCore::ShadowData::ShadowData):
2628 (WebCore::ShadowData::~ShadowData):
2629 (WebCore::ShadowData::operator!=):
2630 * rendering/style/StyleFlexibleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
2631 * rendering/style/StyleFlexibleBoxData.h: Copied from rendering/style/RenderStyle.h.
2632 (WebCore::StyleFlexibleBoxData::operator!=):
2633 * rendering/style/TimingFunction.h: Copied from rendering/style/RenderStyle.h.
2634 (WebCore::TimingFunction::TimingFunction):
2635 (WebCore::TimingFunction::operator==):
2636
adele@apple.com5b2b5da2008-09-18 18:49:44 +000026372008-09-18 Adele Peterson <adele@apple.com>
2638
2639 Reviewed by Dan Bernstein.
2640
2641 Fix RenderStyle leaks.
2642
2643 * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
2644
kmccullough@apple.comd4089752008-09-18 17:21:49 +000026452008-09-18 Kevin McCullough <kmccullough@apple.com>
2646
kmccullough@apple.com76c708f2008-09-18 18:03:23 +00002647 Accidentally checked in code.
2648
2649 * html/HTMLElementFactory.cpp:
2650 (WebCore::frameConstructor):
2651 (WebCore::iframeConstructor):
2652
26532008-09-18 Kevin McCullough <kmccullough@apple.com>
2654
kmccullough@apple.comd4089752008-09-18 17:21:49 +00002655 Reviewed by Tim.
2656
2657 <rdar://problem/5722310> gracefully handle too many console messages
2658 (20904)
2659 - Keep track of the most previous message and then compare it to the
2660 subsequent messages as they come in. If there are multiple of the same
2661 message create a count that indicates the current number.
2662
2663 * manual-tests/inspector/multiple-console-messages.html: Added.
2664 * page/inspector/Console.js:
2665 * page/inspector/inspector.css:
2666
alp@webkit.org18a1fbc2008-09-18 11:50:26 +000026672008-09-18 Jonathon Jongsma <jonathon@quotidian.org>
2668
2669 Reviewed by Alp Toker
2670
2671 https://bugs.webkit.org/show_bug.cgi?id=20830
2672 [GTK] Don't use deprecated pango API
2673
2674 Replace deprecated pango functions with non-deprecated ones for newer
2675 versions of pango
2676
2677 * platform/graphics/gtk/FontGtk.cpp:
2678 (WebCore::getDefaultPangoLayout):
2679 * platform/graphics/gtk/FontPlatformDataPango.cpp:
2680 (WebCore::FontPlatformData::FontPlatformData):
2681
alp@webkit.org2154ef22008-09-18 08:10:49 +000026822008-09-18 Alp Toker <alp@nuanti.com>
2683
2684 Build fix for r36587. Add new sources (and sort the lists).
2685
2686 * GNUmakefile.am:
2687
weinig@apple.com3a98b2a2008-09-18 05:51:35 +000026882008-09-17 Sam Weinig <sam@webkit.org>
2689
2690 Fix Windows build.
2691
2692 * WebCore.vcproj/WebCore.vcproj:
2693
hyatt@apple.comb3699722008-09-18 05:10:03 +000026942008-09-17 David Hyatt <hyatt@apple.com>
2695
2696 Switch back to having frameGeometry be virtual in order to keep Mac
2697 the way it used to be.
2698
2699 Reviewed by Sam Weinig
2700
2701 * WebCore.base.exp:
2702 * platform/Widget.cpp:
2703 (WebCore::Widget::setParent):
2704 * platform/Widget.h:
2705 * platform/gtk/WidgetGtk.cpp:
2706 (WebCore::Widget::frameGeometry):
2707 (WebCore::Widget::setFrameGeometry):
2708 * platform/mac/WidgetMac.mm:
2709 (WebCore::Widget::frameGeometry):
2710 (WebCore::Widget::setFrameGeometry):
2711 * platform/qt/WidgetQt.cpp:
2712 (WebCore::Widget::frameGeometry):
2713 (WebCore::Widget::setFrameGeometry):
2714 * platform/win/WidgetWin.cpp:
2715 (WebCore::Widget::frameGeometry):
2716 (WebCore::Widget::setFrameGeometry):
2717 * platform/wx/WidgetWx.cpp:
2718 (WebCore::Widget::frameGeometry):
2719 (WebCore::Widget::setFrameGeometry):
2720 * plugins/PluginView.cpp:
2721 (WebCore::PluginView::setFrameGeometry):
2722 (WebCore::PluginView::geometryChanged):
2723 * plugins/PluginView.h:
2724 * plugins/gtk/PluginViewGtk.cpp:
2725 (WebCore::PluginView::updatePluginWidget):
2726 * plugins/qt/PluginViewQt.cpp:
2727 (WebCore::PluginView::updatePluginWidget):
2728 * plugins/win/PluginViewWin.cpp:
2729 (WebCore::PluginView::updatePluginWidget):
2730
weinig@apple.com00f4d5c2008-09-18 03:23:08 +000027312008-09-17 Sam Weinig <sam@webkit.org>
2732
weinig@apple.com4fd54cd2008-09-18 05:03:21 +00002733 Reviewed by Mark Rowe.
2734
2735 Fix assertion in DOMWindow::adjustWindowRect where we were passing
2736 in garbage values and were getting lucky that they were a not Nan.
2737
2738 * bindings/js/JSDOMWindowBase.cpp:
2739 (WebCore::windowProtoFuncOpen):
2740
27412008-09-17 Sam Weinig <sam@webkit.org>
2742
weinig@apple.com95b14762008-09-18 04:28:40 +00002743 Fix gtk build.
2744
2745 * rendering/style/MatrixTransformOperation.cpp:
2746
27472008-09-17 Sam Weinig <sam@webkit.org>
2748
weinig@apple.com00f4d5c2008-09-18 03:23:08 +00002749 Rubber-stamped with love by David Hyatt.
2750
2751 Split IdentityTransformOperation, MatrixTransformOperation, RotateTransformOperation,
2752 ScaleTransformOperation, SkewTransformOperation, StyleTransformData, TransformOperation,
2753 TransformOperations and TranslateTransformOperation out of RenderStyle.h/cpp
2754
2755 * GNUmakefile.am:
2756 * WebCore.pro:
2757 * WebCore.vcproj/WebCore.vcproj:
2758 * WebCore.xcodeproj/project.pbxproj:
2759 * WebCoreSources.bkl:
2760 * css/CSSStyleSelector.cpp:
2761 * page/animation/AnimationBase.cpp:
2762 (WebCore::solveEpsilon):
2763 * rendering/RenderLayer.cpp:
2764 * rendering/style/IdentityTransformOperation.h: Copied from rendering/style/RenderStyle.h.
2765 * rendering/style/MatrixTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
2766 * rendering/style/MatrixTransformOperation.h: Copied from rendering/style/RenderStyle.h.
2767 (WebCore::MatrixTransformOperation::MatrixTransformOperation):
2768 * rendering/style/RenderStyle.cpp:
2769 * rendering/style/RenderStyle.h:
2770 * rendering/style/RotateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
2771 * rendering/style/RotateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
2772 (WebCore::RotateTransformOperation::RotateTransformOperation):
2773 * rendering/style/ScaleTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
2774 * rendering/style/ScaleTransformOperation.h: Copied from rendering/style/RenderStyle.h.
2775 (WebCore::ScaleTransformOperation::ScaleTransformOperation):
2776 * rendering/style/SkewTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
2777 * rendering/style/SkewTransformOperation.h: Copied from rendering/style/RenderStyle.h.
2778 (WebCore::SkewTransformOperation::SkewTransformOperation):
2779 * rendering/style/StyleTransformData.cpp: Copied from rendering/style/RenderStyle.cpp.
2780 * rendering/style/StyleTransformData.h: Copied from rendering/style/RenderStyle.h.
2781 (WebCore::StyleTransformData::operator!=):
2782 * rendering/style/TransformOperation.h: Copied from rendering/style/RenderStyle.h.
2783 (WebCore::TransformOperation::):
2784 * rendering/style/TransformOperations.cpp: Copied from rendering/style/RenderStyle.cpp.
2785 (WebCore::TransformOperations::TransformOperations):
2786 * rendering/style/TransformOperations.h: Copied from rendering/style/RenderStyle.h.
2787 (WebCore::TransformOperations::operator!=):
2788 * rendering/style/TranslateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
2789 * rendering/style/TranslateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
2790 (WebCore::TranslateTransformOperation::TranslateTransformOperation):
2791
mrowe@apple.comdbfa8852008-09-18 02:59:20 +000027922008-09-17 Mark Rowe <mrowe@apple.com>
2793
2794 Build fix.
2795
2796 * rendering/style/StyleDashboardRegion.h: PlatformString.h rather than String.h.
2797
hyatt@apple.com76057b42008-09-18 02:48:46 +000027982008-09-17 David Hyatt <hyatt@apple.com>
2799
2800 (1) Inline a bunch of methods for accessing frame geometry.
2801 (2) Make sure frameGeometry() works even when you have no underlying
2802 native widget.
2803 (3) Cache a frame geometry rect cross-platform (even for widgets that
2804 have underlying native widgets.
2805 (4) PluginView's updateWindow call is now a virtual function on Widget.
2806
2807 Reviewed by Sam Weinig
2808
2809 * ChangeLog:
2810 * WebCore.base.exp:
2811 * platform/Widget.cpp:
2812 (WebCore::Widget::setFrameGeometry):
2813 * platform/Widget.h:
2814 (WebCore::Widget::x):
2815 (WebCore::Widget::y):
2816 (WebCore::Widget::width):
2817 (WebCore::Widget::height):
2818 (WebCore::Widget::size):
2819 (WebCore::Widget::pos):
2820 (WebCore::Widget::frameGeometry):
2821 (WebCore::Widget::resize):
2822 (WebCore::Widget::move):
2823 (WebCore::Widget::isFrameView):
2824 (WebCore::Widget::windowClipRect):
2825 * platform/mac/WidgetMac.mm:
2826 (WebCore::Widget::~Widget):
2827 (WebCore::Widget::updatePlatformWidgetFrameGeometry):
2828 * platform/win/WidgetWin.cpp:
2829 (WebCore::Widget::updatePlatformWidgetFrameGeometry):
2830 * plugins/PluginView.cpp:
2831 (WebCore::PluginView::setFrameGeometry):
2832 (WebCore::PluginView::geometryChanged):
2833 * plugins/PluginView.h:
2834 * plugins/gtk/PluginViewGtk.cpp:
2835 (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
2836 * plugins/qt/PluginViewQt.cpp:
2837 (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
2838 * plugins/win/PluginViewWin.cpp:
2839 (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
2840 * plugins/wx/PluginViewWx.cpp:
2841
weinig@apple.coma812a3ce2008-09-18 01:46:26 +000028422008-09-17 Sam Weinig <sam@webkit.org>
2843
weinig@apple.comb4b66742008-09-18 02:47:55 +00002844 Reviewed by David "Waterman" Hyatt.
2845
2846 Fix a leak of NSViews in WidgetMac.mm.
2847
2848 * platform/mac/WidgetMac.mm:
2849 (WebCore::Widget::~Widget):
2850
28512008-09-17 Sam Weinig <sam@webkit.org>
2852
weinig@apple.coma812a3ce2008-09-18 01:46:26 +00002853 Rubber-stamped by David Waterman Hyatt.
2854
2855 Split FillLayer, StyleBackgroundData, StyleBoxData, StyleDashboardRegion, StyleMarqueeData
2856 StyleMultiColData and StyleVisualData out of RenderStyle.h/cpp
2857
2858 * GNUmakefile.am:
2859 * WebCore.pro:
2860 * WebCore.vcproj/WebCore.vcproj:
2861 * WebCore.xcodeproj/project.pbxproj:
2862 * WebCoreSources.bkl:
2863 * rendering/style/FillLayer.cpp: Copied from rendering/style/RenderStyle.cpp.
2864 * rendering/style/FillLayer.h: Copied from rendering/style/RenderStyle.h.
2865 (WebCore::FillLayer::operator!=):
2866 (WebCore::FillLayer::hasImage):
2867 (WebCore::FillLayer::hasFixedImage):
2868 * rendering/style/RenderStyle.cpp:
2869 * rendering/style/RenderStyle.h:
2870 * rendering/style/StyleBackgroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
2871 (WebCore::StyleBackgroundData::StyleBackgroundData):
2872 * rendering/style/StyleBackgroundData.h: Copied from rendering/style/RenderStyle.h.
2873 (WebCore::StyleBackgroundData::~StyleBackgroundData):
2874 (WebCore::StyleBackgroundData::operator!=):
2875 * rendering/style/StyleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
2876 * rendering/style/StyleBoxData.h: Copied from rendering/style/RenderStyle.h.
2877 (WebCore::StyleBoxData::operator!=):
2878 * rendering/style/StyleDashboardRegion.h: Copied from rendering/style/RenderStyle.h.
2879 (WebCore::StyleDashboardRegion::operator!=):
2880 * rendering/style/StyleMarqueeData.cpp: Copied from rendering/style/RenderStyle.cpp.
2881 * rendering/style/StyleMarqueeData.h: Copied from rendering/style/RenderStyle.h.
2882 (WebCore::StyleMarqueeData::operator!=):
2883 * rendering/style/StyleMultiColData.cpp: Copied from rendering/style/RenderStyle.cpp.
2884 * rendering/style/StyleMultiColData.h: Copied from rendering/style/RenderStyle.h.
2885 (WebCore::StyleMultiColData::operator!=):
2886 (WebCore::StyleMultiColData::ruleWidth):
2887 * rendering/style/StyleVisualData.cpp: Copied from rendering/style/RenderStyle.cpp.
2888 * rendering/style/StyleVisualData.h: Copied from rendering/style/RenderStyle.h.
2889 (WebCore::StyleVisualData::operator==):
2890
hyatt@apple.comb4f28b32008-09-18 00:39:36 +000028912008-09-17 David Hyatt <hyatt@apple.com>
2892
hyatt@apple.com3f19eac2008-09-18 00:56:04 +00002893 Remove WidgetClient from Widget.
2894
2895 Reviewed by Sam Weinig
2896
2897 * WebCore.xcodeproj/project.pbxproj:
2898 * platform/Widget.h:
2899 (WebCore::Widget::setClient):
2900 (WebCore::Widget::client):
2901 * platform/WidgetClient.h: Removed.
2902 * platform/gtk/WidgetGtk.cpp:
2903 * platform/mac/WidgetMac.mm:
2904 (WebCore::Widget::Widget):
2905 (WebCore::Widget::show):
2906 (WebCore::Widget::hide):
2907 * platform/qt/WidgetQt.cpp:
2908 (WebCore::WidgetPrivate::WidgetPrivate):
2909 * platform/win/WidgetWin.cpp:
2910 (WebCore::Widget::Widget):
2911 * platform/wx/WidgetWx.cpp:
2912 (WebCore::Widget::Widget):
2913
29142008-09-17 David Hyatt <hyatt@apple.com>
2915
hyatt@apple.comb4f28b32008-09-18 00:39:36 +00002916 Remove isEnabled/setEnabled from Widget. The concept of being enabled now
2917 only applies to Scrollbars so the method has been moved there and made
2918 cross-platform. Scrollbar subclasses that have a corresponding native
2919 widget can subclass setEnabled to change the enabled state of the native
2920 widget.
2921
2922 Reviewed by Sam Weinig & Darin Adler
2923
2924 * WebCore.base.exp:
2925 * platform/Scrollbar.cpp:
2926 (WebCore::Scrollbar::Scrollbar):
2927 * platform/Scrollbar.h:
2928 (WebCore::Scrollbar::enabled):
2929 (WebCore::Scrollbar::setEnabled):
2930 * platform/Widget.h:
2931 * platform/gtk/ScrollbarGtk.cpp:
2932 (ScrollbarGtk::setEnabled):
2933 * platform/gtk/ScrollbarGtk.h:
2934 * platform/gtk/WidgetGtk.cpp:
2935 * platform/mac/ScrollbarMac.h:
2936 * platform/mac/ScrollbarMac.mm:
2937 (WebCore::ScrollbarMac::scrollbarHit):
2938 (WebCore::ScrollbarMac::setEnabled):
2939 * platform/mac/WidgetMac.mm:
2940 * platform/qt/WidgetQt.cpp:
2941 (WebCore::WidgetPrivate::WidgetPrivate):
2942 * platform/win/WidgetWin.cpp:
2943 (WebCore::Widget::Widget):
2944 * platform/wx/WidgetWx.cpp:
2945
weinig@apple.com1ea40602008-09-17 23:56:27 +000029462008-09-17 Sam Weinig <sam@webkit.org>
2947
2948 Rubber-stamped by David Hyatt.
2949
2950 Split all RenderStyle enums into their own file.
2951
2952 * GNUmakefile.am:
2953 * WebCore.vcproj/WebCore.vcproj:
2954 * WebCore.xcodeproj/project.pbxproj:
2955 * rendering/style/BorderValue.h:
2956 * rendering/style/CollapsedBorderValue.h:
2957 * rendering/style/RenderStyle.h:
2958 * rendering/style/RenderStyleConstants.h: Copied from rendering/style/RenderStyle.h.
2959 (WebCore::):
2960 * rendering/style/StyleCachedImage.h:
2961 * rendering/style/StyleGeneratedImage.h:
2962 * rendering/style/StyleImage.h:
2963
sfalken@apple.combf270912008-09-17 23:53:17 +000029642008-09-17 Steve Falkenburg <sfalken@apple.com>
2965
2966 Add back isFrameView check to fix failed assertion during scroll bar teardown.
2967
2968 Reviewed by Dave Hyatt.
2969
2970 * platform/Scrollbar.cpp:
2971 (WebCore::Scrollbar::setParent):
2972
beidson@apple.com4398e482008-09-17 23:30:00 +000029732008-09-17 Brady Eidson <beidson@apple.com>
2974
2975 Reviewed by Mac build fix
2976
2977 * WebCore.xcodeproj/project.pbxproj: Send appropriate headers to WebKit
2978
sfalken@apple.com85cc1392008-09-17 23:28:13 +000029792008-09-17 Steve Falkenburg <sfalken@apple.com>
2980
2981 Fix build.
2982
2983 * platform/win/ScrollViewWin.cpp:
2984 (WebCore::ScrollView::setParentVisible):
2985 * plugins/win/PluginViewWin.cpp:
2986 (WebCore::PluginView::init):
2987
zecke@webkit.org2ba9a4e2008-09-17 23:25:10 +000029882008-09-17 Holger Hans Peter Freyther <zecke@selfish.org>
2989
2990 Reviewed by Simon.
2991
2992 [QtWebKit] Implement error handling in TextCodecQt::decode
2993 Use the QTextCodec parsing state to set the sawError out variable. This
2994 is needed to pass Test 70 of acid3. The test case for this bug is
2995 fast/encoding/invalid-xml.html that is now partially passed. To pass
2996 it completely the Qt text codecs need to be adjusted to have proper
2997 error handling.
2998
2999 * platform/text/qt/TextCodecQt.cpp:
3000 (WebCore::TextCodecQt::decode):
3001
weinig@apple.comf6f0f112008-09-17 23:03:16 +000030022008-09-17 Sam Weinig <sam@webkit.org>
3003
3004 Rubber-stamped by Dave Hyatt.
3005
3006 Split BorderData, BorderValue, CollapsedBorderValue, OutlineValue and StyleSurroundData
3007 out of RenderStyle.h/cpp
3008
3009 * GNUmakefile.am:
3010 * WebCore.pro:
3011 * WebCore.vcproj/WebCore.vcproj:
3012 * WebCore.xcodeproj/project.pbxproj:
3013 * WebCoreSources.bkl:
3014 * rendering/style/BorderData.h: Copied from rendering/style/RenderStyle.h.
3015 (WebCore::BorderData::hasBorderRadius):
3016 (WebCore::BorderData::borderLeftWidth):
3017 (WebCore::BorderData::borderRightWidth):
3018 (WebCore::BorderData::borderTopWidth):
3019 (WebCore::BorderData::borderBottomWidth):
3020 (WebCore::BorderData::operator!=):
3021 * rendering/style/BorderValue.h: Copied from rendering/style/RenderStyle.h.
3022 (WebCore::):
3023 (WebCore::BorderValue::BorderValue):
3024 (WebCore::BorderValue::nonZero):
3025 (WebCore::BorderValue::isTransparent):
3026 (WebCore::BorderValue::isVisible):
3027 * rendering/style/CollapsedBorderValue.h: Copied from rendering/style/RenderStyle.h.
3028 (WebCore::):
3029 (WebCore::CollapsedBorderValue::CollapsedBorderValue):
3030 (WebCore::CollapsedBorderValue::operator==):
3031 * rendering/style/OutlineValue.h: Copied from rendering/style/RenderStyle.h.
3032 (WebCore::OutlineValue::OutlineValue):
3033 * rendering/style/RenderStyle.cpp:
3034 * rendering/style/RenderStyle.h:
3035 * rendering/style/StyleSurroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
3036 * rendering/style/StyleSurroundData.h: Copied from rendering/style/RenderStyle.h.
3037 (WebCore::StyleSurroundData::operator!=):
3038
bdakin@apple.com06b97182008-09-17 23:00:29 +000030392008-09-17 Beth Dakin <bdakin@apple.com>
3040
3041 Reviewed by Darin Adler.
3042
3043 This is a better fix for: Invalid CSS code crashes Safari
3044 https://bugs.webkit.org/show_bug.cgi?id=20512
3045
3046 The spec indicates that the only valid input for a counter is a
3047 number or an identifier. So that is exactly what we allow.
3048
3049 * css/CSSParser.cpp:
3050 (WebCore::CSSParser::parseCounterContent):
3051
alp@webkit.org97ba9222008-09-17 22:16:26 +000030522008-09-17 Alp Toker <alp@nuanti.com>
3053
3054 GTK+ build fix. Adapt to use PlatformWidget functions.
3055
3056 * platform/gtk/ScrollViewGtk.cpp:
3057 (WebCore::ScrollViewScrollbar::geometryChanged):
3058 (WebCore::ScrollView::addChild):
3059 (WebCore::ScrollView::removeChild):
3060 * platform/gtk/ScrollbarGtk.cpp:
3061 (ScrollbarGtk::ScrollbarGtk):
3062 (ScrollbarGtk::~ScrollbarGtk):
3063 (ScrollbarGtk::geometryChanged):
3064
weinig@apple.com930ed392008-09-17 22:00:45 +000030652008-09-17 Sam Weinig <sam@webkit.org>
3066
3067 Reviewed by Adele Peterson.
3068
3069 Patch for <rdar://problem/6133884>
3070 Calling window.resizeTo() on a subframe shouldn't change the window size
3071
3072 Test: fast/dom/Window/window-resize-and-move-sub-frame.html
3073
3074 * page/DOMWindow.cpp:
3075 (WebCore::DOMWindow::moveBy):
3076 (WebCore::DOMWindow::moveTo):
3077 (WebCore::DOMWindow::resizeBy):
3078 (WebCore::DOMWindow::resizeTo):
3079
bdakin@apple.com8f952d82008-09-17 21:35:02 +000030802008-09-17 Beth Dakin <bdakin@apple.com>
3081
3082 Reviewed by Adam Roben.
3083
3084 Fix for https://bugs.webkit.org/show_bug.cgi?id=20512 Invalid CSS
3085 code crashes Safari
3086 and corresponding: <rdar://problem/6173832>
3087
3088 Reading through the spec, it seems like a function is not valid
3089 input for a counter. So this patch checks for that and bails in the
3090 case of invalid input.
3091
3092 * css/CSSParser.cpp:
3093 (WebCore::CSSParser::parseCounterContent):
3094
antti@apple.comb37d4052008-09-17 21:14:13 +000030952008-09-17 Greg Bolsinga <bolsinga@apple.com>
3096
3097 Reviewed by Antti Koivisto.
3098
3099 Fix <rdar://problem/6227089>
3100 Crash in WebCore::Frame::setNeedsReapplyStyles()
3101
3102 View is null checked elsewhere too.
3103
3104 * page/Frame.cpp:
3105 (WebCore::Frame::setNeedsReapplyStyles):
3106
hyatt@apple.com8e340252008-09-17 20:59:45 +000031072008-09-17 David Hyatt <hyatt@apple.com>
3108
3109 Make the notion of having a native widget backing a Widget cross-platform.
3110 The PlatformWidget abstraction (which already existed) is used for this.
3111 Windows = HWND
3112 Qt = QWidget
3113 Mac = NSView
3114 wx = wxWindow
3115 Gtk = GtkWidget
3116
3117 There are new cross-platform methods that replace all of the unique
3118 platform-specific methods.
3119 platformWidget()
3120 setPlatformWidget()
3121
3122 For plugins, on every platform except Qt on Windows, the plugin's native
3123 widget is now stored in the Widget base class. Since Qt on Windows uses
3124 HWNDs for plugins instead of QWidget, it is the only platform to keep the
3125 m_window variable in PluginView.
3126
3127 Reviewed by Sam Weinig
3128
3129 * WebCore.base.exp:
3130 * bindings/js/ScriptControllerMac.mm:
3131 (WebCore::ScriptController::createScriptInstanceForWidget):
3132 * page/mac/AccessibilityObjectWrapper.mm:
3133 (-[AccessibilityObjectWrapper attachmentView]):
3134 (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
3135 * page/mac/EventHandlerMac.mm:
3136 (WebCore::EventHandler::passMouseDownEventToWidget):
3137 (WebCore::EventHandler::mouseDownViewIfStillGood):
3138 (WebCore::EventHandler::passWheelEventToWidget):
3139 (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
3140 * platform/Widget.cpp:
3141 (WebCore::Widget::init):
3142 (WebCore::Widget::setParent):
3143 (WebCore::Widget::releasePlatformWidget):
3144 (WebCore::Widget::retainPlatformWidget):
3145 * platform/Widget.h:
3146 (WebCore::Widget::platformWidget):
3147 (WebCore::Widget::setPlatformWidget):
3148 * platform/gtk/WidgetGtk.cpp:
3149 (WebCore::Widget::Widget):
3150 (WebCore::Widget::setFocus):
3151 (WebCore::gdkDrawable):
3152 (WebCore::Widget::setCursor):
3153 (WebCore::Widget::show):
3154 (WebCore::Widget::hide):
3155 (WebCore::Widget::setEnabled):
3156 (WebCore::Widget::isEnabled):
3157 (WebCore::Widget::paint):
3158 * platform/mac/PlatformScreenMac.mm:
3159 (WebCore::screenRect):
3160 (WebCore::screenAvailableRect):
3161 * platform/mac/ScrollViewMac.mm:
3162 (WebCore::ScrollView::scrollView):
3163 (WebCore::ScrollView::update):
3164 (WebCore::ScrollView::inWindow):
3165 * platform/mac/ScrollbarMac.mm:
3166 (WebCore::ScrollbarMac::ScrollbarMac):
3167 (WebCore::ScrollbarMac::~ScrollbarMac):
3168 (WebCore::ScrollbarMac::updateThumbPosition):
3169 (WebCore::ScrollbarMac::updateThumbProportion):
3170 (WebCore::ScrollbarMac::scrollbarHit):
3171 * platform/mac/WidgetMac.mm:
3172 (WebCore::Widget::Widget):
3173 (WebCore::Widget::setEnabled):
3174 (WebCore::Widget::isEnabled):
3175 (WebCore::Widget::setFocus):
3176 (WebCore::Widget::getOuterView):
3177 (WebCore::Widget::paint):
3178 (WebCore::Widget::invalidate):
3179 (WebCore::Widget::invalidateRect):
3180 (WebCore::Widget::setIsSelected):
3181 (WebCore::Widget::releasePlatformWidget):
3182 (WebCore::Widget::retainPlatformWidget):
3183 * platform/qt/WidgetQt.cpp:
3184 (WebCore::WidgetPrivate::WidgetPrivate):
3185 (WebCore::Widget::Widget):
3186 (WebCore::Widget::setFrameGeometry):
3187 (WebCore::Widget::show):
3188 (WebCore::Widget::hide):
3189 (WebCore::Widget::isEnabled):
3190 (WebCore::Widget::setEnabled):
3191 (WebCore::Widget::invalidateRect):
3192 (WebCore::Widget::containingWindow):
3193 * platform/win/WidgetWin.cpp:
3194 (WebCore::Widget::Widget):
3195 * platform/wx/WidgetWx.cpp:
3196 (WebCore::Widget::Widget):
3197 (WebCore::Widget::frameGeometry):
3198 (WebCore::Widget::setFocus):
3199 (WebCore::Widget::setCursor):
3200 (WebCore::Widget::show):
3201 (WebCore::Widget::hide):
3202 (WebCore::Widget::setFrameGeometry):
3203 (WebCore::Widget::setEnabled):
3204 (WebCore::Widget::isEnabled):
3205 (WebCore::Widget::invalidate):
3206 (WebCore::Widget::invalidateRect):
3207 (WebCore::Widget::paint):
3208 * plugins/PluginView.cpp:
3209 (WebCore::PluginView::PluginView):
3210 * plugins/PluginView.h:
3211 (WebCore::PluginView::platformPluginWidget):
3212 * plugins/gtk/PluginViewGtk.cpp:
3213 (WebCore::PluginView::updateWindow):
3214 (WebCore::PluginView::setFocus):
3215 (WebCore::PluginView::show):
3216 (WebCore::PluginView::hide):
3217 (WebCore::PluginView::setParent):
3218 (WebCore::PluginView::setNPWindowRect):
3219 (WebCore::PluginView::setParentVisible):
3220 (WebCore::PluginView::getValue):
3221 (WebCore::PluginView::forceRedraw):
3222 (WebCore::PluginView::init):
3223 * plugins/qt/PluginViewQt.cpp:
3224 (WebCore::PluginView::updateWindow):
3225 (WebCore::PluginView::setFocus):
3226 (WebCore::PluginView::show):
3227 (WebCore::PluginView::hide):
3228 (WebCore::PluginView::setParent):
3229 (WebCore::PluginView::setNPWindowRect):
3230 (WebCore::PluginView::setParentVisible):
3231 (WebCore::PluginView::getValue):
3232 (WebCore::PluginView::~PluginView):
3233 (WebCore::PluginView::init):
3234 * plugins/win/PluginViewWin.cpp:
3235 (WebCore::PluginView::updateWindow):
3236 (WebCore::PluginView::setFocus):
3237 (WebCore::PluginView::show):
3238 (WebCore::PluginView::hide):
3239 (WebCore::PluginView::paint):
3240 (WebCore::PluginView::setParent):
3241 (WebCore::PluginView::setParentVisible):
3242 (WebCore::PluginView::setNPWindowRect):
3243 (WebCore::PluginView::stop):
3244 (WebCore::PluginView::invalidateRect):
3245 (WebCore::PluginView::forceRedraw):
3246 (WebCore::PluginView::~PluginView):
3247 (WebCore::PluginView::init):
3248
weinig@apple.comf713d132008-09-17 20:16:48 +000032492008-09-17 Sam Weinig <sam@webkit.org>
3250
3251 Fix assert.
3252
3253 * platform/Widget.cpp:
3254 (WebCore::Widget::setParent):
3255
hyatt@apple.comd9242e32008-09-17 18:46:31 +000032562008-09-17 David Hyatt <hyatt@apple.com>
3257
3258 Beginnings of Widget refactoring (in order to make the mixing of
3259 widgets with and without corresponding native widgets more cross-platform).
3260
3261 This first patch makes the concept of a parent ScrollView cross-platform.
3262
3263 Note the similarity of the show/hide methods on the three PluginViews. This
3264 will be refactored better in a later patch so that they can all share
3265 a base class Widget show/hide method. For now the changes were made
3266 simply to be able to bring WidgetWin's setParent method up into Widget.
3267
3268 Reviewed by Sam Weinig
3269
3270 * WebCore.base.exp:
3271 * platform/ScrollView.h:
3272 * platform/Widget.cpp:
3273 (WebCore::Widget::init):
3274 (WebCore::Widget::setParent):
3275 * platform/Widget.h:
3276 (WebCore::Widget::isSelfVisible):
3277 (WebCore::Widget::isParentVisible):
3278 (WebCore::Widget::isVisible):
3279 (WebCore::Widget::setParentVisible):
3280 (WebCore::Widget::isPluginView):
3281 (WebCore::Widget::parent):
3282 (WebCore::Widget::handleEvent):
3283 (WebCore::Widget::geometryChanged):
3284 * platform/gtk/WidgetGtk.cpp:
3285 (WebCore::Widget::Widget):
3286 * platform/mac/ScrollViewMac.mm:
3287 (WebCore::ScrollView::addChild):
3288 (WebCore::ScrollView::removeChild):
3289 * platform/mac/ScrollbarMac.mm:
3290 (WebCore::ScrollbarMac::~ScrollbarMac):
3291 * platform/mac/WidgetMac.mm:
3292 (WebCore::Widget::Widget):
3293 (WebCore::Widget::~Widget):
3294 * platform/qt/WidgetQt.cpp:
3295 (WebCore::WidgetPrivate::WidgetPrivate):
3296 (WebCore::Widget::Widget):
3297 (WebCore::Widget::topLevel):
3298 * platform/win/ScrollViewWin.cpp:
3299 (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
3300 (WebCore::ScrollView::setAncestorVisible):
3301 (WebCore::ScrollView::show):
3302 (WebCore::ScrollView::hide):
3303 * platform/win/WidgetWin.cpp:
3304 (WebCore::Widget::Widget):
3305 (WebCore::Widget::setParent):
3306 * platform/wx/WidgetWx.cpp:
3307 (WebCore::Widget::Widget):
3308 * plugins/PluginView.cpp:
3309 (WebCore::PluginView::PluginView):
3310 * plugins/PluginView.h:
3311 * plugins/gtk/PluginViewGtk.cpp:
3312 (WebCore::PluginView::show):
3313 (WebCore::PluginView::hide):
3314 (WebCore::PluginView::setParentVisible):
3315 * plugins/qt/PluginViewQt.cpp:
3316 (WebCore::PluginView::show):
3317 (WebCore::PluginView::hide):
3318 (WebCore::PluginView::setParentVisible):
3319 * plugins/win/PluginViewWin.cpp:
3320 (WebCore::PluginView::show):
3321 (WebCore::PluginView::hide):
3322 (WebCore::PluginView::setParentVisible):
3323
ap@webkit.org18da1a32008-09-17 16:50:22 +000033242008-09-17 Alexey Proskuryakov <ap@webkit.org>
3325
3326 Reviewed by Adam Roben.
3327
3328 <rdar://problem/6219577> Spew in console at launch about encoding mappings when running with ICU 4.0
3329
3330 * platform/text/TextCodecICU.cpp:
3331 (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated for new encoding names.
3332
vestbo@webkit.orge48e6362008-09-17 13:29:42 +000033332008-09-17 Tor Arne Vestbø <tavestbo@trolltech.com>
3334
3335 Fix the QtWebKit/Mac build
3336
3337 * platform/qt/ScrollViewQt.cpp: add include
3338
ap@webkit.org18da1a32008-09-17 16:50:22 +000033392008-09-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com0f37fb52008-09-17 08:17:26 +00003340
3341 Add a #define to control whether or not to use an NSScroller on Mac.
3342 This ifdef will allow the new NSView-less NSScroller on Mac to be
3343 developed side by side with the current one.
3344
3345 The new scroller paints a debug red if turned on (although due to
3346 Widget issues you won't see anything paint yet).
3347
3348 Reviewed by olliej
3349
3350 * platform/Scrollbar.cpp:
3351 * platform/Scrollbar.h:
3352 * platform/mac/ScrollbarMac.h:
3353 * platform/mac/ScrollbarMac.mm:
3354 * platform/mac/ScrollbarThemeMac.cpp:
3355 (WebCore::ScrollbarThemeMac::paint):
3356 * platform/mac/ScrollbarThemeMac.h:
3357
alp@webkit.orgf06bac02008-09-17 04:30:12 +000033582008-09-16 Marco Barisione <marco.barisione@collabora.co.uk>
3359
3360 Reviewed by Alp Toker.
3361
3362 http://bugs.webkit.org/show_bug.cgi?id=20854
3363 [GTK] Windows can be not realized in ScrollView::update
3364
3365 Do not call gdk_window_invalidate_rect on a non-realized GtkWidget.
3366
3367 * platform/gtk/ScrollViewGtk.cpp:
3368 (WebCore::ScrollView::update):
3369
alp@webkit.org226f72a2008-09-17 04:22:02 +000033702008-09-16 Alp Toker <alp@nuanti.com>
3371
3372 Suggested by Dave Hyatt.
3373
3374 Build fix and cleanup. Rename ScrollBar to Scrollbar.
3375
3376 * GNUmakefile.am:
3377 * WebCore.pro:
3378 * WebCore.vcproj/WebCore.vcproj:
3379 * WebCore.xcodeproj/project.pbxproj:
3380 * WebCoreSources.bkl:
3381 * editing/EditorCommand.cpp:
3382 * page/EventHandler.cpp:
3383 * page/gtk/EventHandlerGtk.cpp:
3384 * page/mac/EventHandlerMac.mm:
3385 * page/mac/FrameMac.mm:
3386 * page/qt/EventHandlerQt.cpp:
3387 * page/wx/EventHandlerWx.cpp:
3388 * platform/PopupMenu.h:
3389 * platform/ScrollBar.cpp: Removed.
3390 * platform/ScrollBar.h: Removed.
3391 * platform/Scrollbar.cpp: Copied from WebCore/platform/ScrollBar.cpp.
3392 * platform/Scrollbar.h: Copied from WebCore/platform/ScrollBar.h.
3393 * platform/gtk/ScrollbarGtk.cpp:
3394 (ScrollbarGtk::ScrollbarGtk):
3395 * platform/gtk/ScrollbarGtk.h:
3396 * platform/mac/ScrollbarMac.h:
3397 * platform/qt/ScrollViewQt.cpp:
3398 * platform/qt/ScrollbarQt.cpp:
3399 * platform/qt/ScrollbarThemeQt.cpp:
3400 * platform/win/PlatformScrollBar.h:
3401 * platform/win/PopupMenuWin.cpp:
3402 * platform/win/ScrollViewWin.cpp:
3403 * platform/win/ScrollbarThemeWin.cpp:
3404 * platform/wx/ScrollViewWx.cpp:
3405 * platform/wx/TemporaryLinkStubs.cpp:
3406 * rendering/HitTestResult.cpp:
3407 * rendering/RenderLayer.cpp:
3408 * rendering/RenderTextControl.cpp:
3409
hyatt@apple.com7597c172008-09-17 02:15:08 +000034102008-09-16 David Hyatt <hyatt@apple.com>
3411
hyatt@apple.comfde412d2008-09-17 03:49:48 +00003412 Fix Qt build bustage by making moveThumb a member of Scrollbar so that
3413 it can be called from ScrollbarQt.
3414
3415 * platform/ScrollBar.cpp:
3416 (WebCore::Scrollbar::moveThumb):
3417 (WebCore::Scrollbar::handleMouseMoveEvent):
3418 (WebCore::Scrollbar::handleMousePressEvent):
3419 * platform/ScrollBar.h:
3420 * platform/qt/ScrollViewQt.cpp:
3421 * platform/qt/ScrollbarQt.cpp:
3422 (WebCore::Scrollbar::handleContextMenuEvent):
3423
34242008-09-16 David Hyatt <hyatt@apple.com>
3425
hyatt@apple.com4e3b8602008-09-17 03:17:11 +00003426 Eliminate PlatformScrollbar. Mac and Gtk now have subclasses for their
3427 native-widget scrollbars (ScrollbarMac and ScrollbarGtk). Other platforms
3428 now just use Scrollbar.
3429
3430 Reviewed by Sam Weinig
3431
3432 * GNUmakefile.am:
3433 * WebCore.pro:
3434 * WebCore.vcproj/WebCore.vcproj:
3435 * WebCore.xcodeproj/project.pbxproj:
3436 * page/mac/FrameMac.mm:
3437 * platform/PopupMenu.h:
3438 (WebCore::PopupMenu::scrollbar):
3439 * platform/ScrollBar.cpp:
3440 (WebCore::createNativeScrollbar):
3441 * platform/ScrollBar.h:
3442 * platform/gtk/PlatformScrollBar.h: Removed.
3443 * platform/gtk/PlatformScrollBarGtk.cpp: Removed.
3444 * platform/gtk/ScrollbarGtk.cpp: Copied from platform/gtk/PlatformScrollBarGtk.cpp.
3445 (gtkScrollEventCallback):
3446 (ScrollbarGtk::ScrollbarGtk):
3447 (ScrollbarGtk::~ScrollbarGtk):
3448 (ScrollbarGtk::updateThumbPosition):
3449 (ScrollbarGtk::updateThumbProportion):
3450 (ScrollbarGtk::setFrameGeometry):
3451 (ScrollbarGtk::geometryChanged):
3452 (ScrollbarGtk::gtkValueChanged):
3453 * platform/gtk/ScrollbarGtk.h: Copied from platform/gtk/PlatformScrollBar.h.
3454 * platform/mac/PlatformScrollBar.h: Removed.
3455 * platform/mac/PlatformScrollBarMac.mm: Removed.
3456 * platform/mac/ScrollbarMac.h: Copied from platform/mac/PlatformScrollBar.h.
3457 * platform/mac/ScrollbarMac.mm: Copied from platform/mac/PlatformScrollBarMac.mm.
3458 (-[WebCoreScrollBar initWithScrollbarMac:]):
3459 (-[WebCoreScrollBar detachScrollbarMac]):
3460 (WebCore::Scrollbar::createNativeScrollbar):
3461 (WebCore::ScrollbarMac::ScrollbarMac):
3462 (WebCore::ScrollbarMac::~ScrollbarMac):
3463 (WebCore::ScrollbarMac::updateThumbPosition):
3464 (WebCore::ScrollbarMac::updateThumbProportion):
3465 (WebCore::ScrollbarMac::scrollbarHit):
3466 * platform/qt/PlatformScrollBar.h: Removed.
3467 * platform/qt/PlatformScrollBarQt.cpp: Removed.
3468 * platform/qt/ScrollbarQt.cpp: Copied from platform/qt/PlatformScrollBarQt.cpp.
3469 (WebCore::Scrollbar::handleContextMenuEvent):
3470 * rendering/HitTestResult.cpp:
3471 * rendering/RenderLayer.cpp:
3472 (WebCore::RenderLayer::createScrollbar):
3473 (WebCore::RenderLayer::destroyScrollbar):
3474 * rendering/RenderLayer.h:
3475 * rendering/RenderListBox.cpp:
3476 (WebCore::RenderListBox::~RenderListBox):
3477 (WebCore::RenderListBox::updateFromElement):
3478 (WebCore::RenderListBox::isPointInOverflowControl):
3479 * rendering/RenderObject.h:
3480 * rendering/RenderTextControl.cpp:
3481
34822008-09-16 David Hyatt <hyatt@apple.com>
3483
hyatt@apple.com7597c172008-09-17 02:15:08 +00003484 Make the scrollbar resizer-dodging logic cross-platform in the
3485 Scrollbar class.
3486
3487 Reviewed by Sam Weinig
3488
3489 * platform/ScrollBar.cpp:
3490 (WebCore::Scrollbar::setFrameGeometry):
3491 (WebCore::Scrollbar::setParent):
3492 (WebCore::Scrollbar::windowClipRect):
3493 * platform/ScrollBar.h:
3494 * platform/ScrollView.h:
3495 (WebCore::ScrollView::windowResizerRect):
3496 (WebCore::ScrollView::resizerOverlapsContent):
3497 (WebCore::ScrollView::adjustOverlappingScrollbarCount):
3498 * platform/Widget.h:
3499 (WebCore::Widget::setParent):
3500 * platform/mac/WidgetMac.mm:
3501 (WebCore::Widget::convertToContainingWindow):
3502 * platform/win/PlatformScrollBar.h:
3503 * platform/win/PlatformScrollBarWin.cpp:
3504
mitz@apple.com6d925202008-09-16 17:34:10 +000035052008-09-16 Dan Bernstein <mitz@apple.com>
3506
mitz@apple.comd9462a52008-09-16 17:40:20 +00003507 Reviewed by Darin Adler.
3508
3509 - fix https://bugs.webkit.org/show_bug.cgi?id=15129
3510 <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
3511
3512 Covered by fast/repaint/4776765.html
3513
3514 * rendering/RenderBlock.cpp:
3515 (WebCore::RenderBlock::layoutBlock): Avoid repainting this object if it
3516 did not have layout in the beginning.
3517 (WebCore::RenderBlock::layoutBlockChildren): If a child did not have
3518 layout in the beginning, repaint it in its new position, to compensate
3519 for the above (regardless of whether it "moved").
3520 * rendering/RenderObject.cpp:
3521 (WebCore::RenderObject::checkForRepaintDuringLayout): Added a comment
3522 about generalizing this fix in the future.
3523
35242008-09-16 Dan Bernstein <mitz@apple.com>
3525
mitz@apple.com6d925202008-09-16 17:34:10 +00003526 Reviewed by Dave Hyatt.
3527
3528 - fix https://bugs.webkit.org/show_bug.cgi?id=15384
3529 Div does not notice when grandparent changes height
3530
3531 Test: fast/block/basic/quirk-percent-height-grandchild.html
3532
3533 - fix https://bugs.webkit.org/show_bug.cgi?id=20714
3534 Resizing Gmail inbox vertically results in whitespace at the bottom of the window
3535
3536 Test: fast/replaced/percent-height-in-anonymous-block.html
3537
3538 Added a two-way mapping between boxes with percentage heights and
3539 their non-parent ancestors up to the one the height is computed relative
3540 to. In quirks mode (the first bug), this can be any number of containing
3541 block with auto height. In strict mode (the second bug) this can be
3542 the containing block of an anonymous block containing a replaced
3543 element.
3544
3545 * rendering/RenderBlock.cpp:
3546 (WebCore::RenderBlock::~RenderBlock): Added code to remove the all the
3547 mapping to/from this block to percentage-height descendants.
3548 (WebCore::RenderBlock::layoutBlockChildren): Added code to mark
3549 percentage-height descendants (and their containing block ancestry chain
3550 up to this block) for layout. This ensures that those descendants whose
3551 height depends on the height of this block (or an ancestor) are updated.
3552 (WebCore::RenderBlock::addPercentHeightDescendant): Added. Establishes
3553 a two-way mapping between this block and the given box.
3554 (WebCore::RenderBlock::removePercentHeightDescendant): Added. Removes
3555 all the mapping to/from this box.
3556 * rendering/RenderBlock.h:
3557 * rendering/RenderBox.cpp:
3558 (WebCore::RenderBox::setStyle): Added calls to
3559 removePercentHeightDescendant() when style changes and the box
3560 previously had a percentage height. An exception is when the style
3561 change does not require layout, in which case the box still has
3562 a percentage height and the mappings are valid. In all other cases,
3563 any required mappings will be (re-)established during layout.
3564 (WebCore::RenderBox::destroy): Added a call to
3565 removePercentHeightDescendant.
3566 (WebCore::RenderBox::calcPercentageHeight): Added code that, in quirks
3567 mode, if a higher-than-parent containing block is affecting the box's
3568 height, creates a mapping between the box and that block.
3569 (WebCore::RenderBox::calcReplacedHeightUsing): Changed to skip over
3570 anonymous containing blocks, if any, and when that happens, use
3571 addPercentHeightDescendant() to ensure that the non-anonymous block
3572 is aware of the dependent percent-height box.
3573
alp@webkit.org1dbd9a92008-09-16 16:59:18 +000035742008-09-16 Dirk Schulze <vbs85@gmx.de>
3575
3576 Reviewed by Oliver Hunt and Alp Toker.
3577
3578 Implemented toDataURL in Cairo. Only PNG support
3579 at the moment.
3580
3581 Qt, Cairo and wx require toDataURL implementations
3582 https://bugs.webkit.org/show_bug.cgi?id=17719
3583
3584 * platform/MIMETypeRegistry.cpp:
3585 (WebCore::initializeSupportedImageMIMETypesForEncoding):
3586 * platform/graphics/cairo/ImageBufferCairo.cpp:
3587 (WebCore::ImageBuffer::ImageBuffer):
3588 (WebCore::writeFunction):
3589 (WebCore::ImageBuffer::toDataURL):
3590
vestbo@webkit.org8963b3c2008-09-16 16:45:20 +000035912008-09-16 Tor Arne Vestbø <tavestbo@trolltech.com>
3592
3593 Reviewed by Simon.
3594
3595 Hide unused media element controls in the QtWebKit port
3596
3597 * platform/qt/html4-adjustments-qt.css
3598
hausmann@webkit.orgcd7a1292008-09-16 14:19:16 +000035992008-09-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
3600
3601 Reviewed by Simon.
3602
3603 Fix compilation of the Qt scrollbar code.
3604
3605 * platform/qt/PlatformScrollBarQt.cpp:
3606 (WebCore::scPart):
3607 (WebCore::styleOptionSlider):
3608 (WebCore::thumbLength):
3609 (WebCore::pixelPosToRangeValue):
3610 (WebCore::PlatformScrollbar::handleContextMenuEvent):
3611
treat@webkit.orga35f6b62008-09-16 14:15:29 +000036122008-09-16 Adam Treat <treat@kde.org>
3613
3614 Reviewed by Anders Carlsson.
3615
3616 Prevent accesses off of the end of the buffer introduced in r36450
3617 and when checking for descriptions of mime. Also, coding style fix.
3618
3619 * plugins/qt/PluginPackageQt.cpp:
3620 (WebCore::PluginPackage::fetchInfo):
3621
rwlbuis@webkit.org8f675dd2008-09-16 11:12:52 +000036222008-09-15 Rob Buis <buis@kde.org>
3623
3624 Reviewed by Eric.
3625
3626 https://bugs.webkit.org/show_bug.cgi?id=20634
3627 SVG transform attribute is ignored by <use> in <clipPath>
3628
3629 Transform the paths with the local transform when part
3630 of a clip path.
3631
3632 Test: svg/custom/use-clipped-transform.svg
3633
3634 * svg/SVGClipPathElement.cpp:
3635 (WebCore::SVGClipPathElement::canvasResource):
3636 * svg/SVGStyledTransformableElement.cpp:
3637 (WebCore::SVGStyledTransformableElement::toClipPath):
3638 * svg/SVGStyledTransformableElement.h:
3639
hyatt@apple.com1cd4bcc2008-09-16 06:53:34 +000036402008-09-15 Dave Hyatt <hyatt@apple.com>
3641
3642 Convert Qt over to its ScrollbarTheme. Add cross-platform support for jumping the thumb location directly
3643 to a pressed location on the track (this is done with the middle mouse on Qt and with Shift-Click on Windows).
3644
3645 Reviewed by Sam Weinig
3646
3647 * platform/ScrollBar.cpp:
3648 (WebCore::thumbUnderMouse):
3649 (WebCore::Scrollbar::autoscrollPressedPart):
3650 (WebCore::Scrollbar::startTimerIfNeeded):
3651 (WebCore::moveThumb):
3652 (WebCore::Scrollbar::handleMouseMoveEvent):
3653 (WebCore::Scrollbar::handleMousePressEvent):
3654 * platform/ScrollBar.h:
3655 (WebCore::Scrollbar::pressedPos):
3656 (WebCore::Scrollbar::pixelStep):
3657 (WebCore::Scrollbar::setPressedPos):
3658 * platform/ScrollbarTheme.h:
3659 (WebCore::ScrollbarTheme::thumbPosition):
3660 (WebCore::ScrollbarTheme::thumbLength):
3661 (WebCore::ScrollbarTheme::trackPosition):
3662 (WebCore::ScrollbarTheme::trackLength):
3663 * platform/ScrollbarThemeComposite.cpp:
3664 (WebCore::ScrollbarThemeComposite::trackPosition):
3665 * platform/ScrollbarThemeComposite.h:
3666 * platform/qt/PlatformScrollBarQt.cpp:
3667 (WebCore::PlatformScrollbar::PlatformScrollbar):
3668 (WebCore::):
3669 * platform/qt/ScrollbarThemeQt.cpp:
3670 (WebCore::styleOptionSlider):
3671 (WebCore::ScrollbarThemeQt::hitTest):
3672 (WebCore::ScrollbarThemeQt::shouldCenterOnThumb):
3673 (WebCore::ScrollbarThemeQt::invalidatePart):
3674 (WebCore::ScrollbarThemeQt::thumbPosition):
3675 (WebCore::):
3676 * platform/qt/ScrollbarThemeQt.h:
3677 * platform/win/ScrollbarThemeSafari.cpp:
3678 (WebCore::ScrollbarThemeSafari::shouldCenterOnThumb):
3679 * platform/win/ScrollbarThemeSafari.h:
3680 * platform/win/ScrollbarThemeWin.cpp:
3681 (WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
3682 * platform/win/ScrollbarThemeWin.h:
3683
dsmith@webkit.orgb3107b532008-09-16 06:14:22 +000036842008-09-15 David Smith <catfish.man@gmail.com>
3685
3686 Reviewed by Sam Weinig.
3687
3688 https://bugs.webkit.org/show_bug.cgi?id=20180
3689
3690 Cache the result of parsing the an+b expression in :nth-child(an+b). Roughly a 2x speedup for :nth-child on SlickSpeed.
3691
3692 * GNUmakefile.am: Add CSSNthSelector
3693 * WebCore.pro: Add CSSNthSelector
3694 * WebCore.vcproj/WebCore.vcproj: Add CSSNthSelector
3695 * WebCore.xcodeproj/project.pbxproj: Add CSSNthSelector
3696 * css/CSSGrammar.y: Create CSSNthSelectors instead of CSSSelectors for :nth-*
3697 * css/CSSNthSelector.cpp: Added.
3698 (WebCore::CSSNthSelector::parseNth): Moved from CSSStyleSelector and modified to cache
3699 (WebCore::CSSNthSelector::matchNth): Moved from CSSStyleSelector and modified to use the cache
3700 * css/CSSNthSelector.h: Added.
3701 (WebCore::CSSNthSelector::CSSNthSelector):
3702 (WebCore::CSSNthSelector::~CSSNthSelector):
3703 * css/CSSParser.cpp:
3704 (WebCore::CSSParser::createFloatingNthSelector):
3705 * css/CSSParser.h:
3706 * css/CSSSelector.h: Use the free bit here to store a flag for CSSNthSelector
3707 (WebCore::CSSSelector::CSSSelector):
3708 * css/CSSStyleSelector.cpp:
3709 (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Take advantage of knowing that all :nth-* selectors are CSSNthSelectors
3710
pewtermoose@webkit.orgfb4d3fb2008-09-16 02:46:39 +000037112008-09-15 Matt Lilek <webkit@mattlilek.com>
3712
3713 Reviewed by Tim Hatcher.
3714
3715 Clean up some inspector JS callbacks to remove an extra return.
3716
3717 * page/InspectorController.cpp:
3718 (WebCore::hideDOMNodeHighlight):
3719 (WebCore::loaded):
3720 (WebCore::unloading):
3721 (WebCore::attach):
3722 (WebCore::detach):
3723 (WebCore::startDebuggingAndReloadInspectedPage):
3724 (WebCore::stopDebugging):
3725 (WebCore::debuggerAttached):
3726 (WebCore::pauseOnExceptions):
3727 (WebCore::pauseInDebugger):
3728 (WebCore::resumeDebugger):
3729 (WebCore::stepOverStatementInDebugger):
3730 (WebCore::stepIntoStatementInDebugger):
3731 (WebCore::stepOutOfFunctionInDebugger):
3732 (WebCore::isWindowVisible):
3733 (WebCore::closeWindow):
3734
hyatt@apple.com8e809932008-09-16 02:29:09 +000037352008-09-15 Dave Hyatt <hyatt@apple.com>
3736
3737 Completely switch Windows scrollbars over to ScrollbarTheme. The Aqua windows scrollbar and native scrollbar
3738 now share most of their code.
3739
3740 Also removing mini size scrollbar support, since it would have crashed Windows had it ever been used, and it
3741 also is never used in our code anyway.
3742
3743 Reviewed by Sam Weinig
3744
3745 * WebCore.vcproj/WebCore.vcproj:
3746 * platform/ScrollTypes.h:
3747 (WebCore::):
3748 * platform/ScrollbarThemeComposite.cpp:
3749 (WebCore::ScrollbarThemeComposite::splitTrack):
3750 (WebCore::ScrollbarThemeComposite::thumbLength):
3751 (WebCore::ScrollbarThemeComposite::minimumThumbLength):
3752 * platform/ScrollbarThemeComposite.h:
3753 * platform/mac/PlatformScrollBarMac.mm:
3754 (NSControlSizeForScrollBarControlSize):
3755 * platform/win/PlatformScrollBar.h:
3756 * platform/win/PlatformScrollBarSafari.cpp: Removed.
3757 * platform/win/PlatformScrollBarWin.cpp:
3758 (WebCore::PlatformScrollbar::PlatformScrollbar):
3759 * platform/win/ScrollbarThemeSafari.cpp:
3760 (WebCore::ScrollbarTheme::nativeTheme):
3761 (WebCore::):
3762 (WebCore::scrollbarControlStateFromThemeState):
3763 (WebCore::ScrollbarThemeSafari::hasButtons):
3764 (WebCore::ScrollbarThemeSafari::hasThumb):
3765 (WebCore::buttonRepaintRect):
3766 (WebCore::ScrollbarThemeSafari::backButtonRect):
3767 (WebCore::ScrollbarThemeSafari::forwardButtonRect):
3768 (WebCore::trackRepaintRect):
3769 (WebCore::ScrollbarThemeSafari::trackRect):
3770 (WebCore::ScrollbarThemeSafari::minimumThumbLength):
3771 (WebCore::ScrollbarThemeSafari::paintTrack):
3772 (WebCore::ScrollbarThemeSafari::paintButton):
3773 (WebCore::ScrollbarThemeSafari::paintThumb):
3774 * platform/win/ScrollbarThemeSafari.h:
3775 * platform/win/ScrollbarThemeWin.cpp:
3776 * platform/win/ScrollbarThemeWin.h:
3777
cfleizach@apple.com0ce07032008-09-16 00:17:58 +000037782008-09-15 Chris Fleizach <cfleizach@apple.com>
3779
3780 Reviewed by Darin Adler, Beth Dakin
3781
3782 <rdar://problem/4003789> Expose lists as AXList
3783 <rdar://problem/5707399> VO: Definition lists not announced in Safari
3784
3785 Lists are now exposed through AX. On the mac (in SnowLeopard) they use two new subroles
3786 AXContentList for <ul>, <ol> and AXDefinitionList for <dl>
3787 Inside the definition list, each <dt> "term" has an accessibility description ("term"),
3788 as does each <dd> tag ("definition")
3789
3790 Test: accessibility/lists.html
3791
3792 * GNUmakefile.am:
3793 * WebCore.pro:
3794 * WebCore.vcproj/WebCore.vcproj:
3795 * WebCore.xcodeproj/project.pbxproj:
3796 * WebCoreSources.bkl:
3797 * page/AXObjectCache.cpp:
3798 * page/AccessibilityList.cpp: Added.
3799 * page/AccessibilityList.h: Added.
3800 * page/AccessibilityObject.h:
3801 * page/AccessibilityRenderObject.cpp:
3802 * page/AccessibilityTable.cpp:
3803 * page/mac/AccessibilityObjectWrapper.mm:
3804 * page/mac/WebCoreViewFactory.h:
3805 * platform/LocalizedStrings.h:
3806 * platform/mac/LocalizedStringsMac.mm:
3807 * platform/qt/Localizations.cpp:
3808
zimmermann@webkit.org8cc8ad02008-09-16 00:01:11 +000038092008-09-15 Nikolas Zimmermann <zimmermann@kde.org>
3810
3811 Reviewed by Eric.
3812
3813 Fixes: https://bugs.webkit.org/show_bug.cgi?id=20865
3814 Prepare HTMLScriptElement & SVGScriptElement unification, and unification of event handling.
3815
3816 Several renames:
3817 dispatchHTMLEvent -> dispatchEventForType
3818 setHTMLEventListener -> setEventListenerForType
3819 getHTMLEventListener -> eventListenerForType
3820 removeHTMLEventListener -> removeEventListenerForType
3821 isHTMLEventListener -> isAttachedToEventTargetNode
3822 ...
3823
3824 Similar renames for the dispatch/get/set/*Window*Event functions.
3825 Kill JSSVGLazyEventListener and merge with JSLazyEventListener.
3826
3827 Most important change: Rename setHTMLEventListener to setEventListenerForTypeAndAttribute,
3828 as there exists a generic createEventListener() method now, taking care of JSLazyEventListener creation.
3829
3830 setHTMLEventListener() used createHTMLEventListener() before and was HTML specific.
3831 SVG is able to use the code as well now. This affects most files in html/.
3832
3833 No functional changes.
3834
3835 * GNUmakefile.am:
3836 * WebCore.pro:
3837 * WebCore.vcproj/WebCore.vcproj:
3838 * WebCore.xcodeproj/project.pbxproj:
3839 * bindings/js/JSDOMWindowBase.cpp:
3840 (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
3841 (WebCore::JSDOMWindowBase::setListener):
3842 (WebCore::JSDOMWindowBase::getListener):
3843 (WebCore::JSDOMWindowBase::findJSEventListener):
3844 (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
3845 (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
3846 (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
3847 (WebCore::JSDOMWindowBase::jsEventListenersAttachedToEventTargetNodes):
3848 (WebCore::JSDOMWindowBase::jsUnprotectedEventListenersAttachedToEventTargetNodes):
3849 * bindings/js/JSDOMWindowBase.h:
3850 * bindings/js/JSEventListener.cpp:
3851 (WebCore::JSAbstractEventListener::handleEvent):
3852 (WebCore::JSAbstractEventListener::isAttachedToEventTargetNode):
3853 (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
3854 (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
3855 (WebCore::JSEventListener::JSEventListener):
3856 (WebCore::JSEventListener::~JSEventListener):
3857 (WebCore::JSLazyEventListener::JSLazyEventListener):
3858 (WebCore::eventParameterName):
3859 (WebCore::JSLazyEventListener::parseCode):
3860 (WebCore::getNodeEventListener):
3861 * bindings/js/JSEventListener.h:
3862 (WebCore::JSAbstractEventListener::JSAbstractEventListener):
3863 (WebCore::JSUnprotectedEventListener::create):
3864 (WebCore::JSEventListener::create):
3865 (WebCore::JSLazyEventListener::):
3866 (WebCore::JSLazyEventListener::create):
3867 * bindings/js/JSEventTargetNode.cpp:
3868 (WebCore::JSEventTargetNode::setListener):
3869 (WebCore::JSEventTargetNode::getListener):
3870 * bindings/js/JSSVGLazyEventListener.cpp: Removed.
3871 * bindings/js/JSSVGLazyEventListener.h: Removed.
3872 * bindings/js/ScriptController.cpp:
3873 (WebCore::ScriptController::createHTMLEventHandler):
3874 (WebCore::ScriptController::createSVGEventHandler):
3875 * dom/Document.cpp:
3876 (WebCore::Document::setFocusedNode):
3877 (WebCore::Document::handleWindowEvent):
3878 (WebCore::Document::setWindowEventListenerForType):
3879 (WebCore::Document::windowEventListenerForType):
3880 (WebCore::Document::removeWindowEventListenerForType):
3881 (WebCore::Document::addWindowEventListener):
3882 (WebCore::Document::hasWindowEventListener):
3883 (WebCore::Document::removePendingFrameBeforeUnloadEventCount):
3884 (WebCore::Document::createEventListener):
3885 (WebCore::Document::setWindowEventListenerForTypeAndAttribute):
3886 * dom/Document.h:
3887 * dom/EventListener.h:
3888 (WebCore::EventListener::isAttachedToEventTargetNode):
3889 * dom/EventTargetNode.cpp:
3890 (WebCore::EventTargetNode::dispatchFocusEvent):
3891 (WebCore::EventTargetNode::dispatchBlurEvent):
3892 (WebCore::EventTargetNode::dispatchEventForType):
3893 (WebCore::EventTargetNode::removeEventListenerForType):
3894 (WebCore::EventTargetNode::setEventListenerForType):
3895 (WebCore::EventTargetNode::setEventListenerForTypeAndAttribute):
3896 (WebCore::EventTargetNode::eventListenerForType):
3897 * dom/EventTargetNode.h:
3898 * dom/XMLTokenizer.cpp:
3899 (WebCore::XMLTokenizer::notifyFinished):
3900 * editing/ReplaceSelectionCommand.cpp:
3901 (WebCore::ReplacementFragment::ReplacementFragment):
3902 * html/HTMLBodyElement.cpp:
3903 (WebCore::HTMLBodyElement::parseMappedAttribute):
3904 * html/HTMLButtonElement.cpp:
3905 (WebCore::HTMLButtonElement::parseMappedAttribute):
3906 * html/HTMLElement.cpp:
3907 (WebCore::HTMLElement::parseMappedAttribute):
3908 (WebCore::HTMLElement::checkDTD):
3909 * html/HTMLElement.h:
3910 * html/HTMLFormControlElement.cpp:
3911 (WebCore::HTMLFormControlElement::onChange):
3912 * html/HTMLFormElement.cpp:
3913 (WebCore::HTMLFormElement::prepareSubmit):
3914 (WebCore::HTMLFormElement::reset):
3915 (WebCore::HTMLFormElement::parseMappedAttribute):
3916 * html/HTMLFrameElementBase.cpp:
3917 (WebCore::HTMLFrameElementBase::parseMappedAttribute):
3918 * html/HTMLFrameSetElement.cpp:
3919 (WebCore::HTMLFrameSetElement::parseMappedAttribute):
3920 * html/HTMLImageElement.cpp:
3921 (WebCore::HTMLImageElement::parseMappedAttribute):
3922 * html/HTMLImageLoader.cpp:
3923 (WebCore::HTMLImageLoader::dispatchLoadEvent):
3924 * html/HTMLInputElement.cpp:
3925 (WebCore::HTMLInputElement::parseMappedAttribute):
3926 (WebCore::HTMLInputElement::setValueFromRenderer):
3927 (WebCore::HTMLInputElement::onSearch):
3928 * html/HTMLMediaElement.cpp:
3929 (WebCore::HTMLMediaElement::asyncEventTimerFired):
3930 (WebCore::HTMLMediaElement::load):
3931 (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
3932 (WebCore::HTMLMediaElement::setReadyState):
3933 (WebCore::HTMLMediaElement::seek):
3934 (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
3935 (WebCore::HTMLMediaElement::willSaveToCache):
3936 * html/HTMLObjectElement.cpp:
3937 (WebCore::HTMLObjectElement::parseMappedAttribute):
3938 * html/HTMLScriptElement.cpp:
3939 (WebCore::HTMLScriptElement::parseMappedAttribute):
3940 (WebCore::HTMLScriptElement::dispatchLoadEvent):
3941 (WebCore::HTMLScriptElement::dispatchErrorEvent):
3942 * html/HTMLSelectElement.cpp:
3943 (WebCore::HTMLSelectElement::parseMappedAttribute):
3944 * html/HTMLTextAreaElement.cpp:
3945 (WebCore::HTMLTextAreaElement::parseMappedAttribute):
3946 * html/HTMLTokenizer.cpp:
3947 (WebCore::HTMLTokenizer::notifyFinished):
3948 * page/AccessibilityRenderObject.cpp:
3949 (WebCore::AccessibilityRenderObject::mouseButtonListener):
3950 * page/EventHandler.cpp:
3951 (WebCore::EventHandler::canMouseDownStartSelect):
3952 (WebCore::EventHandler::canMouseDragExtendSelect):
3953 * page/Frame.cpp:
3954 (WebCore::Frame::sendScrollEvent):
3955 * page/Page.cpp:
3956 (WebCore::networkStateChanged):
3957 * rendering/RenderListBox.cpp:
3958 (WebCore::RenderListBox::valueChanged):
3959 * rendering/RenderTextControl.cpp:
3960 (WebCore::RenderTextControl::selectionChanged):
3961 * svg/SVGDocumentExtensions.cpp:
3962 * svg/SVGDocumentExtensions.h:
3963 * svg/SVGElement.cpp:
3964 (WebCore::SVGElement::parseMappedAttribute):
3965 (WebCore::SVGElement::finishParsingChildren):
3966 * svg/SVGElement.h:
3967 * svg/SVGSVGElement.cpp:
3968 (WebCore::SVGSVGElement::parseMappedAttribute):
3969 * svg/SVGSVGElement.h:
3970
hyatt@apple.com63739ce2008-09-15 23:44:10 +000039712008-09-15 Dave Hyatt <hyatt@apple.com>
3972
3973 Convert PlatformScrollbarWin to use ScrollbarTheme for hit testing. PlatformScrollbarQt/Gtk still
3974 need to be converted.
3975
3976 Reviewed by Sam Weinig
3977
3978 * platform/ScrollBar.cpp:
3979 (WebCore::Scrollbar::Scrollbar):
3980 (WebCore::Scrollbar::updateThumbPosition):
3981 (WebCore::Scrollbar::updateThumbProportion):
3982 (WebCore::Scrollbar::autoscrollPressedPart):
3983 (WebCore::Scrollbar::startTimerIfNeeded):
3984 * platform/ScrollBar.h:
3985 * platform/ScrollbarTheme.h:
3986 (WebCore::ScrollbarTheme::invalidateParts):
3987 * platform/ScrollbarThemeComposite.cpp:
3988 (WebCore::ScrollbarThemeComposite::hitTest):
3989 (WebCore::ScrollbarThemeComposite::invalidatePart):
3990 (WebCore::ScrollbarThemeComposite::thumbPosition):
3991 (WebCore::ScrollbarThemeComposite::thumbLength):
3992 (WebCore::ScrollbarThemeComposite::trackLength):
3993 * platform/ScrollbarThemeComposite.h:
3994 * platform/win/PlatformScrollBarSafari.cpp:
3995 (WebCore::PlatformScrollbar::PlatformScrollbar):
3996 * platform/win/PlatformScrollBarWin.cpp:
3997 (WebCore::PlatformScrollbar::PlatformScrollbar):
3998
dsmith@webkit.orgaa780ed2008-09-15 23:08:07 +000039992008-09-15 David Smith <catfish.man@gmail.com>
4000
4001 "Just do it"'d by Mark Rowe
4002
4003 https://bugs.webkit.org/show_bug.cgi?id=20856
4004 Add missing license header
4005
4006 * dom/NodeRenderStyle.h:
4007
dino@apple.combf52b682008-09-15 21:31:43 +000040082008-09-15 Dean Jackson <dino@apple.com>
4009
4010 Reviewed by Tim Hatcher.
4011
dino@apple.com3db0b8f2008-09-15 21:52:23 +00004012 Add default constructor for ShadowData
4013 https://bugs.webkit.org/show_bug.cgi?id=20757
4014
4015 Test: transitions/shadow.html
4016
4017 * rendering/style/RenderStyle.h:
4018
40192008-09-15 Dean Jackson <dino@apple.com>
4020
4021 Reviewed by Tim Hatcher.
4022
dino@apple.com03abdce2008-09-15 21:40:52 +00004023 RenderStyle should update keyframes.
4024 http://bugs.webkit.org/show_bug.cgi?id=20756
4025
4026 * rendering/style/RenderStyle.cpp:
4027 (WebCore::StyleRareNonInheritedData::updateKeyframes):
4028
40292008-09-15 Dean Jackson <dino@apple.com>
4030
4031 Reviewed by Tim Hatcher.
4032
dino@apple.combf52b682008-09-15 21:31:43 +00004033 Unnecessary ASSERT in ImplicitAnimation destructor.
4034 https://bugs.webkit.org/show_bug.cgi?id=20817
4035
4036 * page/animation/ImplicitAnimation.cpp:
4037 (WebCore::ImplicitAnimation::~ImplicitAnimation):
4038
treat@webkit.org7e5abc22008-09-15 20:53:49 +000040392008-09-15 Adam Treat <treat@kde.org>
4040
4041 Reviewed by Simon.
4042
4043 Fix plugin extension info. It was returning the mimetype where the
4044 extension was given.
4045
4046 * plugins/qt/PluginPackageQt.cpp:
4047 (WebCore::PluginPackage::fetchInfo):
4048
dino@apple.comecc18dc2008-09-15 20:40:28 +000040492008-09-15 Dean Jackson <dino@apple.com>
4050
4051 Reviewed by Tim Hatcher
4052
4053 Coding style violation!!!! Cleanup AnimationBase.cpp
4054
4055 * page/animation/AnimationBase.cpp:
4056 (WebCore::blendFunc):
4057
hyatt@apple.comf4a9d932008-09-15 20:03:25 +000040582008-09-15 David Hyatt <hyatt@apple.com>
4059
4060 Move all hit testing code for scrollbars into the base class. Refactor
4061 it to accommodate all platform-specific behaviors using virtual ScrollbarTheme
4062 functions.
4063
4064 No platform is using this code yet. Although it has been moved and compiles
4065 (even on Mac), it is not being used on any platform.
4066
4067 Reviewed by Sam Weinig
4068
4069 * platform/ScrollBar.cpp:
4070 (WebCore::Scrollbar::autoscrollPressedPart):
4071 (WebCore::Scrollbar::startTimerIfNeeded):
4072 (WebCore::Scrollbar::handleMouseMoveEvent):
4073 (WebCore::Scrollbar::handleMouseOutEvent):
4074 (WebCore::Scrollbar::handleMouseReleaseEvent):
4075 (WebCore::Scrollbar::handleMousePressEvent):
4076 * platform/ScrollBar.h:
4077 (WebCore::Scrollbar::handleContextMenuEvent):
4078 * platform/ScrollbarTheme.h:
4079 (WebCore::ScrollbarTheme::hitTest):
4080 (WebCore::ScrollbarTheme::invalidateOnMouseEnterExit):
4081 (WebCore::ScrollbarTheme::invalidatePart):
4082 (WebCore::ScrollbarTheme::shouldCenterOnThumb):
4083 (WebCore::ScrollbarTheme::centerOnThumb):
4084 (WebCore::ScrollbarTheme::thumbPosition):
4085 (WebCore::ScrollbarTheme::thumbLength):
4086 (WebCore::ScrollbarTheme::trackLength):
4087 (WebCore::ScrollbarTheme::initialAutoscrollTimerDelay):
4088 (WebCore::ScrollbarTheme::autoscrollTimerDelay):
4089 * platform/Widget.h:
4090 (WebCore::Widget::parent):
4091 * platform/mac/PlatformScrollBar.h:
4092 (WebCore::PlatformScrollbar::handleMouseMoveEvent):
4093 (WebCore::PlatformScrollbar::handleMouseOutEvent):
4094 (WebCore::PlatformScrollbar::handleMousePressEvent):
4095 (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
4096 * platform/mac/WidgetMac.mm:
4097 (WebCore::Widget::convertFromContainingWindow):
4098 * platform/win/ScrollbarThemeWin.cpp:
4099 (WebCore::ScrollbarThemeWin::invalidateOnMouseEnterExit):
4100 * platform/win/ScrollbarThemeWin.h:
4101
mitz@apple.comd17dc392008-09-15 18:48:20 +000041022008-09-15 Dan Bernstein <mitz@apple.com>
4103
4104 Reviewed by Sam Weinig.
4105
4106 - fix <rdar://problem/5842247> Single long breakable word takes O(n^2) to lay out
4107
4108 Cache the next breakable position for text nodes in InlineIterator.
4109
4110 * rendering/bidi.cpp:
4111 (WebCore::InlineIterator::InlineIterator):
4112 (WebCore::InlineIterator::increment):
4113 (WebCore::RenderBlock::findNextLineBreak):
4114
simon.fraser@apple.comda604642008-09-15 17:10:48 +000041152008-09-15 Simon Fraser <simon.fraser@apple.com>
4116
4117 Reviewed by Dan Bernstein
4118
4119 Fix assertion and integral pixel issue when creating subimages.
4120 https://bugs.webkit.org/show_bug.cgi?id=20786
4121
4122 * platform/graphics/cg/ImageCG.cpp:
4123 (WebCore::BitmapImage::draw):
4124
vestbo@webkit.orge7eda302008-09-15 12:43:37 +000041252008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
4126
4127 Reviewed by Simon.
4128
4129 Implment seek() and clean up and improve debugging output
4130
4131 * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
4132 (debugMediaObject):
4133 (WebCore::MediaPlayerPrivate::seek):
4134 (WebCore::MediaPlayerPrivate::setVolume):
4135 (WebCore::MediaPlayerPrivate::setMuted):
4136 (WebCore::MediaPlayerPrivate::updateStates):
4137 (WebCore::MediaPlayerPrivate::naturalSize):
4138 (WebCore::MediaPlayerPrivate::paint):
4139 (WebCore::MediaPlayerPrivate::stateChanged):
4140 (WebCore::MediaPlayerPrivate::tick):
4141
vestbo@webkit.orgaba01e62008-09-15 11:40:22 +000041422008-09-15 Holger Hans Peter Freyther <zecke@selfish.org>
4143
4144 Reviewed by Simon.
4145
4146 Remove bogus Q_ASSERTs from the MediaPlayer Phonon implementation
4147
4148 m_mediaObject, m_audioOutput, m_videoWidget get created in the
4149 c'tor and will only be deleted in the c'tor. The Q_ASSERTs would
4150 only check if we use the MediaPlayerPrivate after it has been deleted.
4151
4152 Acked-by: Tor Arne Vestbø <tavestbo@trolltech.com>
4153
4154 * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
4155 (WebCore::MediaPlayerPrivate::play):
4156 (WebCore::MediaPlayerPrivate::setVolume):
4157 (WebCore::MediaPlayerPrivate::updateStates):
4158
andersca@apple.com18d62682008-09-15 11:35:22 +000041592008-09-15 Anders Carlsson <andersca@apple.com>
4160
4161 Reviewed by Maciej.
4162
4163 <rdar://problem/6163988>
4164 https://bugs.webkit.org/show_bug.cgi?id=20457
4165 Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
4166
4167 Check the width and height and throw an exception if any of them are 0.
4168
4169 * html/CanvasRenderingContext2D.cpp:
4170 (WebCore::CanvasRenderingContext2D::createPattern):
4171
vestbo@webkit.org3a27e182008-09-15 11:28:59 +000041722008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
4173
4174 Reviewed by Simon.
4175
4176 Render media element controls with antialiasing enabled
4177
4178 * platform/qt/RenderThemeQt.cpp:
4179 (WebCore::RenderThemeQt::paintMediaMuteButton):
4180 (WebCore::RenderThemeQt::paintMediaPlayButton):
4181 (WebCore::RenderThemeQt::paintMediaSliderTrack):
4182 (WebCore::RenderThemeQt::paintMediaSliderThumb):
4183
vestbo@webkit.org17e4bfc2008-09-15 11:27:25 +000041842008-09-15 Ariya Hidayat <ariya.hidayat@trolltech.com>
4185
4186 Reviewed by Simon.
4187
4188 Upon non fatal error, switch to the pause state (so that playback can continue)
4189
4190 * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
4191 (WebCore::MediaPlayerPrivate::updateStates):
4192
vestbo@webkit.org12a59572008-09-15 11:16:13 +000041932008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
4194
4195 Reviewed by Simon.
4196
vestbo@webkit.org1d1f05e2008-09-15 11:22:05 +00004197 Don't set WTF_USE_JSC in WebCore.pro now that it's set in config.h
4198
4199 * WebCore.pro:
4200
42012008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
4202
4203 Reviewed by Simon.
4204
vestbo@webkit.org12a59572008-09-15 11:16:13 +00004205 Make QtInstance::create() private and fix caching
4206
4207 * bindings/js/ScriptControllerQt.cpp:
4208 (WebCore::ScriptController::createScriptInstanceForWidget):
4209 * bridge/qt/qt_instance.cpp:
4210 (JSC::Bindings::QtInstance::getQtInstance):
4211 (JSC::Bindings::QtInstance::getRuntimeObject):
4212 * bridge/qt/qt_instance.h:
4213 (JSC::Bindings::QtInstance::create):
4214 * bridge/qt/qt_runtime.cpp:
4215 (JSC::Bindings::convertQVariantToValue):
4216 (JSC::Bindings::QtConnectionObject::execute):
4217
dsmith@webkit.orgaba15862008-09-15 08:45:35 +000042182008-09-15 David Smith <catfish.man@gmail.com>
4219
4220 Reviewed by Dave Hyatt.
4221
4222 https://bugs.webkit.org/show_bug.cgi?id=20180
4223
4224 >2x speedup on querySelector[All] with :nth-child by removing the collectRulesOnly argument on SelectorChecker.
4225 With collectRulesOnly set to true (the default) an optimization is turned off, and no callers were intentionally leaving it true.
4226 querySelector[All] assumed that the default was probably the right way to go, and so ended up being slow.
4227
4228 * css/CSSStyleSelector.cpp:
4229 (WebCore::CSSStyleSelector::CSSStyleSelector):
4230 (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
4231 * css/CSSStyleSelector.h:
4232
hyatt@apple.com065494e2008-09-15 06:33:40 +000042332008-09-14 Dave Hyatt <hyatt@apple.com>
4234
4235 Refactor PlatformScrollbarWin's painting so that it is now done by ScrollbarThemeWin. PlatformScrollbarSafari
4236 is still painting itself (a subsequent patch will move its painting into ScrollbarThemeSafari).
4237
4238 Reviewed by Sam Weinig
4239
4240 * platform/ScrollBar.h:
4241 (WebCore::Scrollbar::client):
4242 (WebCore::Scrollbar::currentPos):
4243 (WebCore::Scrollbar::totalSize):
4244 * platform/ScrollbarTheme.h:
4245 * platform/ScrollbarThemeComposite.cpp:
4246 (WebCore::pageForScrollView):
4247 (WebCore::ScrollbarThemeComposite::paint):
4248 * platform/ScrollbarThemeComposite.h:
4249 (WebCore::ScrollbarThemeComposite::trackIsSinglePiece):
4250 * platform/win/PlatformScrollBar.h:
4251 * platform/win/PlatformScrollBarSafari.cpp:
4252 * platform/win/PlatformScrollBarWin.cpp:
4253 * platform/win/ScrollbarThemeSafari.h:
4254 (WebCore::ScrollbarThemeSafari::hasButtons):
4255 (WebCore::ScrollbarThemeSafari::hasThumb):
4256 (WebCore::ScrollbarThemeSafari::backButtonRect):
4257 (WebCore::ScrollbarThemeSafari::forwardButtonRect):
4258 (WebCore::ScrollbarThemeSafari::trackRect):
4259 (WebCore::ScrollbarThemeSafari::splitTrack):
4260 (WebCore::ScrollbarThemeSafari::paintTrack):
4261 (WebCore::ScrollbarThemeSafari::paintButton):
4262 (WebCore::ScrollbarThemeSafari::paintThumb):
4263 * platform/win/ScrollbarThemeWin.cpp:
4264 (WebCore::isRunningOnVistaOrLater):
4265 (WebCore::checkAndInitScrollbarTheme):
4266 (WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
4267 (WebCore::ScrollbarThemeWin::themeChanged):
4268 (WebCore::ScrollbarThemeWin::hasThumb):
4269 (WebCore::ScrollbarThemeWin::backButtonRect):
4270 (WebCore::ScrollbarThemeWin::forwardButtonRect):
4271 (WebCore::ScrollbarThemeWin::trackRect):
4272 (WebCore::ScrollbarThemeWin::splitTrack):
4273 (WebCore::ScrollbarThemeWin::paintTrack):
4274 (WebCore::ScrollbarThemeWin::paintButton):
4275 (WebCore::gripperRect):
4276 (WebCore::paintGripper):
4277 (WebCore::ScrollbarThemeWin::paintThumb):
4278 (WebCore::ScrollbarThemeWin::thumbPosition):
4279 (WebCore::ScrollbarThemeWin::thumbLength):
4280 (WebCore::ScrollbarThemeWin::trackLength):
4281 * platform/win/ScrollbarThemeWin.h:
4282 (WebCore::ScrollbarThemeWin::hasButtons):
4283 (WebCore::ScrollbarThemeWin::trackIsSinglePiece):
4284
timothy@apple.comd91172c2008-09-15 05:38:00 +000042852008-09-14 Anthony Ricaud <rik24d@gmail.com>
4286
4287 Moving all resource graphs under the same container for future scalable feature.
4288 This is a speedup on resize but maybe a loss on changing the sorting function.
4289
4290 https://bugs.webkit.org/show_bug.cgi?id=20555
4291
4292 Reviewed by Timothy Hatcher.
4293
4294 * page/inspector/ResourcesPanel.js: Added a container for all resource graphs.
4295 Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
4296 * page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.
4297
ap@webkit.orga14074b2008-09-15 04:52:44 +000042982008-09-14 Alexey Proskuryakov <ap@webkit.org>
4299
4300 Reviewed by Maciej Stachowiak.
4301
4302 https://bugs.webkit.org/show_bug.cgi?id=20738
4303 compareBoundaryPoints gives incorrect results
4304
4305 Test: fast/dom/Range/compareBoundaryPoints-2.html
4306
4307 * dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END
4308 and END_TO_START.
4309 * page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.
4310
mjs@apple.com285bdcf2008-09-15 02:55:16 +000043112008-09-14 Maciej Stachowiak <mjs@apple.com>
4312
4313 Unreviewed build fix.
4314
mjs@apple.comcbb31e52008-09-15 03:10:35 +00004315 Trying again.
4316
4317 * bindings/js/JSQuarantinedObjectWrapper.cpp:
4318 (WebCore::JSQuarantinedObjectWrapper::hasInstance):
4319
43202008-09-14 Maciej Stachowiak <mjs@apple.com>
4321
4322 Unreviewed build fix.
4323
mjs@apple.com285bdcf2008-09-15 02:55:16 +00004324 Blind attempt to fix build. Correct parameters for hasInstance.
4325
4326 * bindings/js/JSQuarantinedObjectWrapper.cpp:
4327 (WebCore::JSQuarantinedObjectWrapper::hasInstance):
4328 * bindings/js/JSQuarantinedObjectWrapper.h:
4329
mitz@apple.come85f7362008-09-15 02:23:24 +000043302008-09-14 Dan Bernstein <mitz@apple.com>
4331
4332 Rubber-stamped by Sam Weinig.
4333
4334 - revert <http://trac.webkit.org/changeset/36382> because it exposed
4335 <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes
4336 on Tiger.
4337
4338 * platform/graphics/mac/FontCacheMac.mm:
4339 (WebCore::FontCache::getFontDataForCharacters):
4340 (WebCore::FontCache::getLastResortFallbackFont):
4341
hyatt@apple.comf18feec2008-09-15 00:56:11 +000043422008-09-14 Dave Hyatt <hyatt@apple.com>
4343
4344 Add a new ScrollbarThemeComposite base class that is shared by ScrollbarThemeSafari and
4345 ScrollbarThemeWin. Any scrollbar that wants to render by ScrollbarPart can subclass from this
4346 theme.
4347
4348 Reviewed by Sam Weinig
4349
4350 * WebCore.vcproj/WebCore.vcproj:
4351 * platform/win/ScrollbarThemeSafari.h:
4352 * platform/win/ScrollbarThemeWin.h:
4353
alp@webkit.orgd694e942008-09-15 00:20:15 +000043542008-09-14 Alp Toker <alp@nuanti.com>
4355
4356 https://bugs.webkit.org/show_bug.cgi?id=20320
4357 [GTK] A white rectangle is visible behind widgets with rounded corners
4358
4359 Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
4360 style exempt).
4361
4362 Requested by Michael Monreal.
4363
4364 * platform/gtk/RenderThemeGtk.cpp:
4365 (WebCore::RenderThemeGtk::RenderThemeGtk):
4366 * platform/gtk/gtk2drawing.c:
4367 (moz_gtk_set_widget_name):
4368 (ensure_window_widget):
4369 (setup_widget_prototype):
4370 (ensure_button_arrow_widget):
4371 (moz_gtk_get_combo_box_inner_button):
4372 (moz_gtk_get_combo_box_button_inner_widgets):
4373 (ensure_combo_box_widgets):
4374 (moz_gtk_get_combo_box_entry_inner_widgets):
4375 (moz_gtk_get_combo_box_entry_arrow):
4376 (ensure_combo_box_entry_widgets):
4377 (ensure_toolbar_widget):
4378 (ensure_tooltip_widget):
4379 (ensure_menu_bar_widget):
4380 (ensure_menu_bar_item_widget):
4381 (ensure_menu_popup_widget):
4382 (ensure_menu_item_widget):
4383 (ensure_image_menu_item_widget):
4384 (ensure_menu_separator_widget):
4385 (ensure_check_menu_item_widget):
4386 (ensure_tree_header_cell_widget):
4387 (ensure_scrolled_window_widget):
4388 (moz_gtk_button_paint):
4389 (moz_gtk_init):
4390 (moz_gtk_button_get_inner_border):
4391 (moz_gtk_toggle_paint):
4392 (calculate_button_inner_rect):
4393 (calculate_arrow_rect):
4394 (moz_gtk_scrollbar_button_paint):
4395 (moz_gtk_scrollbar_thumb_paint):
4396 (moz_gtk_caret_paint):
4397 (moz_gtk_entry_paint):
4398 (moz_gtk_treeview_paint):
4399 (moz_gtk_tree_header_cell_paint):
4400 (moz_gtk_combo_box_paint):
4401 (moz_gtk_downarrow_paint):
4402 (moz_gtk_combo_box_entry_button_paint):
4403 (moz_gtk_toolbar_paint):
4404 (moz_gtk_tab_scroll_arrow_paint):
4405 (moz_gtk_menu_bar_paint):
4406 (moz_gtk_menu_item_paint):
4407 (moz_gtk_get_widget_border):
4408 (moz_gtk_get_combo_box_entry_button_size):
4409 (moz_gtk_get_tab_scroll_arrow_size):
4410 (moz_gtk_get_downarrow_size):
4411 (moz_gtk_images_in_menus):
4412 (moz_gtk_widget_paint):
4413 (moz_gtk_shutdown):
4414 * platform/gtk/gtkdrawing.h:
4415
hyatt@apple.com3ab48302008-09-14 23:55:16 +000044162008-09-14 David Hyatt <hyatt@apple.com>
4417
4418 Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
4419 painting. Mac and Gtk themes don't do anything and just let the
4420 underlying widget paint. Qt now uses the theme to paint. wx doesn't
4421 do anything yet.
4422
4423 Reviewed by Sam Weinig
4424
4425 * platform/ScrollBar.cpp:
4426 (WebCore::Scrollbar::paint):
4427 * platform/ScrollBar.h:
4428 (WebCore::Scrollbar::value):
4429 (WebCore::Scrollbar::visibleSize):
4430 (WebCore::Scrollbar::maximum):
4431 (WebCore::Scrollbar::lineStep):
4432 (WebCore::Scrollbar::pageStep):
4433 (WebCore::Scrollbar::pixelStep):
4434 (WebCore::Scrollbar::pressedPart):
4435 (WebCore::Scrollbar::hoveredPart):
4436 (WebCore::Scrollbar::theme):
4437 * platform/ScrollbarTheme.h:
4438 (WebCore::ScrollbarTheme::paint):
4439 (WebCore::ScrollbarTheme::scrollbarThickness):
4440 (WebCore::ScrollbarTheme::supportsControlTints):
4441 (WebCore::ScrollbarTheme::themeChanged):
4442 * platform/gtk/PlatformScrollBar.h:
4443 * platform/gtk/PlatformScrollBarGtk.cpp:
4444 * platform/mac/PlatformScrollBar.h:
4445 * platform/mac/PlatformScrollBarMac.mm:
4446 * platform/qt/PlatformScrollBar.h:
4447 * platform/qt/PlatformScrollBarQt.cpp:
4448 * platform/qt/ScrollbarThemeQt.cpp:
4449 (WebCore::styleOptionSlider):
4450 * platform/qt/ScrollbarThemeQt.h:
4451 (WebCore::ScrollbarThemeQt::paint):
4452 * platform/win/PlatformScrollBarSafari.cpp:
4453 (WebCore::PlatformScrollbar::paint):
4454 * platform/win/ScrollbarThemeSafari.h:
4455 (WebCore::ScrollbarThemeSafari::supportsControlTints):
4456 * platform/wx/PlatformScrollBar.h:
4457 * platform/wx/TemporaryLinkStubs.cpp:
4458 (PlatformScrollbar::~PlatformScrollbar):
4459
weinig@apple.comcb93e262008-09-14 21:36:11 +000044602008-09-14 Sam Weinig <sam@webkit.org>
4461
weinig@apple.com6ef2b872008-09-14 22:15:28 +00004462 Qt build fix.
4463
4464 * platform/qt/PlatformScrollBarQt.cpp:
4465
44662008-09-14 Sam Weinig <sam@webkit.org>
4467
weinig@apple.com064861a2008-09-14 22:12:49 +00004468 Reviewed by Mark Rowe.
4469
4470 Remove extraneous semicolons.
4471
4472 * bindings/scripts/CodeGeneratorObjC.pm:
4473 * html/HTMLLinkElement.cpp:
4474 (WebCore::HTMLLinkElement::tokenizeRelAttribute):
4475 * html/HTMLScriptElement.cpp:
4476 (WebCore::HTMLScriptElement::charsetAttributeValue):
4477 (WebCore::HTMLScriptElement::typeAttributeValue):
4478 * platform/graphics/qt/GradientQt.cpp:
4479 (WebCore::Gradient::platformGradient):
4480 * platform/qt/ScrollViewQt.cpp:
4481 (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
4482 * platform/win/ScrollViewWin.cpp:
4483 (WebCore::ScrollView::updateScrollbars):
4484 * rendering/RenderBlock.cpp:
4485 (WebCore::RenderBlock::paintEllipsisBoxes):
4486 * svg/SVGPathSegList.cpp:
4487 (WebCore::SVGPathSegList::toPathData):
4488
44892008-09-14 Sam Weinig <sam@webkit.org>
4490
weinig@apple.comcb93e262008-09-14 21:36:11 +00004491 Qt build fix.
4492
weinig@apple.com31311a62008-09-14 22:00:15 +00004493 * platform/qt/ScrollViewQt.cpp:
4494 (WebCore::ScrollView::updateScrollbars):
4495
44962008-09-14 Sam Weinig <sam@webkit.org>
4497
4498 Qt build fix.
4499
weinig@apple.comcb93e262008-09-14 21:36:11 +00004500 * platform/qt/PlatformScrollBarQt.cpp:
4501 (WebCore::PlatformScrollbar::PlatformScrollbar):
4502 (WebCore::PlatformScrollbar::paint):
4503
jmalonzo@webkit.org65e836c2008-09-14 01:57:13 +000045042008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>
4505
4506 Gtk build fix, not reviewed.
4507
4508 * platform/gtk/PlatformScrollBarGtk.cpp:
4509 (PlatformScrollbar::PlatformScrollbar):
4510 * platform/gtk/ScrollViewGtk.cpp:
4511 (WebCore::ScrollView::updateScrollbars):
4512
hyatt@apple.comd62f5bf2008-09-14 00:32:19 +000045132008-09-13 Dave Hyatt <hyatt@apple.com>
4514
hyatt@apple.com21ab7c62008-09-14 01:26:22 +00004515 Remove scrollbar's setRect method. Clients can now just call setFrameGeometry (the corresponding Widget) method
4516 to set the dimensions of a scrollbar.
4517
4518 Reviewed by Sam Weinig
4519
4520 * platform/ScrollBar.h:
4521 * platform/gtk/PlatformScrollBar.h:
4522 * platform/gtk/PlatformScrollBarGtk.cpp:
4523 (PlatformScrollbar::setFrameGeometry):
4524 * platform/gtk/ScrollViewGtk.cpp:
4525 (WebCore::ScrollView::updateScrollbars):
4526 * platform/mac/PlatformScrollBarMac.mm:
4527 * platform/qt/PlatformScrollBarQt.cpp:
4528 * platform/qt/ScrollViewQt.cpp:
4529 (WebCore::ScrollView::updateScrollbars):
4530 * platform/win/PlatformScrollBar.h:
4531 * platform/win/PlatformScrollBarSafari.cpp:
4532 (WebCore::PlatformScrollbar::PlatformScrollbar):
4533 (WebCore::PlatformScrollbar::setFrameGeometry):
4534 * platform/win/PlatformScrollBarWin.cpp:
4535 (WebCore::PlatformScrollbar::PlatformScrollbar):
4536 (WebCore::PlatformScrollbar::setFrameGeometry):
4537 * platform/win/PopupMenuWin.cpp:
4538 (WebCore::PopupWndProc):
4539 * platform/win/ScrollViewWin.cpp:
4540 (WebCore::ScrollView::updateScrollbars):
4541 * platform/wx/PlatformScrollBar.h:
4542 * platform/wx/TemporaryLinkStubs.cpp:
4543 (PlatformScrollbar::updateThumbProportion):
4544 * rendering/RenderLayer.cpp:
4545 (WebCore::RenderLayer::positionOverflowControls):
4546 * rendering/RenderListBox.cpp:
4547 (WebCore::RenderListBox::paintScrollbar):
4548
45492008-09-13 Dave Hyatt <hyatt@apple.com>
4550
hyatt@apple.comed9485a2008-09-14 01:06:57 +00004551 Remove setEnabled() from all Scrollbar classes that were just using their Widget base class methods.
4552
4553 Reviewed by Sam Weinig
4554
4555 * platform/ScrollBar.h:
4556 * platform/gtk/PlatformScrollBar.h:
4557 * platform/gtk/PlatformScrollBarGtk.cpp:
4558 * platform/mac/PlatformScrollBar.h:
4559 * platform/mac/PlatformScrollBarMac.mm:
4560 * platform/win/PlatformScrollBar.h:
4561 * platform/win/PlatformScrollBarSafari.cpp:
4562 * platform/win/PlatformScrollBarWin.cpp:
4563 * platform/wx/PlatformScrollBar.h:
4564 * platform/wx/TemporaryLinkStubs.cpp:
4565 (PlatformScrollbar::~PlatformScrollbar):
4566
45672008-09-13 Dave Hyatt <hyatt@apple.com>
4568
hyatt@apple.com64d98032008-09-14 00:58:29 +00004569 Remove width()/height() from Scrollbar now that it derives from Widget. Remove width()/height() from
4570 all PlatformScrollbar subclasses that just called the Widget base class versions of those methods.
4571
4572 Reviewed by Sam Weinig
4573
4574 * platform/ScrollBar.h:
4575 * platform/gtk/PlatformScrollBar.h:
4576 * platform/gtk/PlatformScrollBarGtk.cpp:
4577 * platform/mac/PlatformScrollBar.h:
4578 * platform/mac/PlatformScrollBarMac.mm:
4579 * platform/win/PlatformScrollBarSafari.cpp:
4580 * platform/win/PlatformScrollBarWin.cpp:
4581 * platform/wx/PlatformScrollBar.h:
4582 * platform/wx/TemporaryLinkStubs.cpp:
4583 (PlatformScrollbar::~PlatformScrollbar):
4584
45852008-09-13 Dave Hyatt <hyatt@apple.com>
4586
hyatt@apple.comd62f5bf2008-09-14 00:32:19 +00004587 Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar.
4588
4589 Reviewed by Sam Weinig
4590
4591 * platform/ScrollBar.cpp:
4592 (WebCore::Scrollbar::~Scrollbar):
4593 * platform/ScrollBar.h:
4594 * platform/qt/PlatformScrollBarQt.cpp:
4595 (WebCore::PlatformScrollbar::~PlatformScrollbar):
4596 * platform/win/PlatformScrollBarSafari.cpp:
4597 (WebCore::PlatformScrollbar::~PlatformScrollbar):
4598 * platform/win/PlatformScrollBarWin.cpp:
4599 (WebCore::PlatformScrollbar::~PlatformScrollbar):
4600
hyatt@apple.coma3c52492008-09-13 23:57:08 +000046012008-09-13 David Hyatt <hyatt@apple.com>
4602
4603 Move maximum() from Qt's PlatformScrollbar to be a cross-platform
4604 function on Scrollbar. Fixes Qt build bustage.
4605
4606 Reviewed by Sam Weinig
4607
4608 * platform/ScrollBar.h:
4609 (WebCore::Scrollbar::orientation):
4610 (WebCore::Scrollbar::value):
4611 (WebCore::Scrollbar::maximum):
4612 * platform/qt/PlatformScrollBar.h:
4613
mitz@apple.comb3d22882008-09-13 23:06:59 +000046142008-09-13 Dan Bernstein <mitz@apple.com>
4615
4616 Reviewed by Sam Weinig.
4617
4618 - use the LastResort font for missing glyphs instead of showing the
4619 primary font's missing glyph
4620
4621 Test: platform/mac/fast/text/last-resort-font.html
4622
4623 * platform/graphics/mac/FontCacheMac.mm:
4624 (WebCore::FontCache::getFontDataForCharacters): Changed to return the
4625 last resort font if a substitute font cannot be found.
4626 (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated
4627 comment (the user's preferred standard font is included in the search
4628 thanks to code in FontCache::getFontData()) and changed to return the
4629 LastResort font.
4630
hyatt@apple.com0c378c72008-09-13 22:59:05 +000046312008-09-13 Dave Hyatt <hyatt@apple.com>
4632
4633 This patch adds ScrollbarTheme to the build. ScrollbarTheme is similar to RenderTheme (but for
4634 scrollbars only). For now ScrollbarTheme just handles returning the size of scrollbars. Subsequent
4635 patches will move rendering and hit testing functionality into this class.
4636
4637 Implemented ScrollbarTheme subclasses for four ports (Mac, Win, Gtk, Qt). The wxWidgets port does not
4638 implement scrollbars yet, so I added a temporary link stub to keep things compiling on wx.
4639
4640 Reviewed by Sam Weinig
4641
4642 * GNUmakefile.am:
4643 * WebCore.pro:
4644 * WebCore.vcproj/WebCore.vcproj:
4645 * platform/ScrollBar.cpp:
4646 (WebCore::Scrollbar::Scrollbar):
4647 * platform/ScrollBar.h:
4648 * platform/ScrollbarTheme.h: Added.
4649 (WebCore::ScrollbarTheme::~ScrollbarTheme):
4650 (WebCore::ScrollbarTheme::scrollbarThickness):
4651 (WebCore::ScrollbarTheme::themeChanged):
4652 * platform/gtk/ScrollbarThemeGtk.cpp: Added.
4653 (WebCore::ScrollbarTheme::nativeTheme):
4654 (WebCore::ScrollbarThemeGtk::~ScrollbarThemeGtk):
4655 (WebCore::ScrollbarThemeGtk::scrollbarThickness):
4656 * platform/gtk/ScrollbarThemeGtk.h: Added.
4657 * platform/mac/PlatformScrollBar.h:
4658 * platform/mac/ScrollbarThemeMac.cpp: Added.
4659 (WebCore::ScrollbarTheme::nativeTheme):
4660 (WebCore::):
4661 (WebCore::ScrollbarThemeMac::~ScrollbarThemeMac):
4662 (WebCore::ScrollbarThemeMac::scrollbarThickness):
4663 * platform/mac/ScrollbarThemeMac.h: Added.
4664 * platform/qt/PlatformScrollBarQt.cpp:
4665 * platform/qt/ScrollbarThemeQt.cpp: Added.
4666 (WebCore::ScrollbarTheme::nativeTheme):
4667 (WebCore::ScrollbarThemeQt::~ScrollbarThemeQt):
4668 (WebCore::ScrollbarThemeQt::scrollbarThickness):
4669 * platform/qt/ScrollbarThemeQt.h: Added.
4670 * platform/win/PlatformScrollBar.h:
4671 * platform/win/PlatformScrollBarSafari.cpp:
4672 * platform/win/PlatformScrollBarWin.cpp:
4673 * platform/win/PopupMenuWin.cpp:
4674 (WebCore::PopupMenu::calculatePositionAndSize):
4675 * platform/win/ScrollViewWin.cpp:
4676 (WebCore::ScrollView::updateScrollbars):
4677 (WebCore::ScrollView::themeChanged):
4678 * platform/win/ScrollbarThemeSafari.cpp: Added.
4679 (WebCore::ScrollbarTheme::nativeTheme):
4680 (WebCore::):
4681 (WebCore::ScrollbarThemeSafari::~ScrollbarThemeSafari):
4682 (WebCore::ScrollbarThemeSafari::scrollbarThickness):
4683 * platform/win/ScrollbarThemeSafari.h: Added.
4684 * platform/win/ScrollbarThemeWin.cpp: Added.
4685 (WebCore::ScrollbarTheme::nativeTheme):
4686 (WebCore::ScrollbarThemeWin::~ScrollbarThemeWin):
4687 (WebCore::ScrollbarThemeWin::scrollbarThickness):
4688 (WebCore::ScrollbarThemeWin::themeChanged):
4689 * platform/win/ScrollbarThemeWin.h: Added.
4690 * platform/wx/TemporaryLinkStubs.cpp:
4691 (ScrollbarTheme::nativeTheme):
4692 * rendering/RenderLayer.cpp:
4693 (WebCore::scrollCornerRect):
4694 * rendering/RenderTextControl.cpp:
4695 (WebCore::RenderTextControl::calcHeight):
4696 (WebCore::RenderTextControl::calcPrefWidths):
4697
cfleizach@apple.comd26c2762008-09-13 21:05:18 +000046982008-09-13 Chris Fleizach <cfleizach@apple.com>
4699
4700 Reviewed by Timothy Hatcher.
4701
4702 <rdar://problem/5060439> Web elements should have an AXTopLevelUIElement
4703
4704 * page/mac/AccessibilityObjectWrapper.mm:
4705 (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
4706
mitz@apple.com6307c9f2008-09-13 20:27:37 +000047072008-09-13 Dan Bernstein <mitz@apple.com>
4708
4709 Reviewed by Timothy Hatcher.
4710
4711 - fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache
4712
4713 No regression test because the back/forward cache is disabled in DumpRenderTree
4714
4715 * rendering/RenderContainer.cpp:
4716 (WebCore::RenderContainer::invalidateCounters): Bail out if the document
4717 is being destroyed.
4718
kevino@webkit.org1e178ee2008-09-13 18:48:39 +000047192008-09-13 Kevin Ollivier <kevino@theolliviers.com>
4720
4721 wx build fixes for new methods recently introduced.
4722
4723 * platform/graphics/wx/AffineTransformWx.cpp:
4724 (WebCore::AffineTransform::AffineTransform):
4725 (WebCore::AffineTransform::setMatrix):
4726 (WebCore::AffineTransform::setA):
4727 (WebCore::AffineTransform::setB):
4728 (WebCore::AffineTransform::setC):
4729 (WebCore::AffineTransform::setD):
4730 (WebCore::AffineTransform::setE):
4731 (WebCore::AffineTransform::setF):
4732 * platform/wx/LocalizedStringsWx.cpp:
4733 (WebCore::AXDefinitionListTermText):
4734 (WebCore::AXDefinitionListDefinitionText):
4735
hyatt@apple.com30ed5442008-09-13 18:39:58 +000047362008-09-12 Dave Hyatt <hyatt@apple.com>
4737
4738 Move the member variables of PlatformScrollbar up into Scrollbar. Move autoscroll timer handling
4739 up into scrollbar. Make sure a bunch of cross-platform code now just uses "Scrollbar" instead of
4740 "PlatformScrollbar."
4741
4742 Reviewed by Sam Weinig
4743
4744 * WebCore.vcproj/WebCore.vcproj:
4745 * editing/EditorCommand.cpp:
4746 * page/EventHandler.cpp:
4747 (WebCore::EventHandler::selectCursor):
4748 (WebCore::EventHandler::handleMousePressEvent):
4749 (WebCore::EventHandler::handleMouseMoveEvent):
4750 * page/EventHandler.h:
4751 * page/MouseEventWithHitTestResults.cpp:
4752 (WebCore::MouseEventWithHitTestResults::scrollbar):
4753 * page/MouseEventWithHitTestResults.h:
4754 * page/gtk/EventHandlerGtk.cpp:
4755 (WebCore::EventHandler::passMousePressEventToScrollbar):
4756 * page/mac/EventHandlerMac.mm:
4757 (WebCore::EventHandler::passMousePressEventToScrollbar):
4758 * page/qt/EventHandlerQt.cpp:
4759 (WebCore::EventHandler::passMousePressEventToScrollbar):
4760 * page/win/EventHandlerWin.cpp:
4761 (WebCore::EventHandler::passMousePressEventToScrollbar):
4762 * page/wx/EventHandlerWx.cpp:
4763 (WebCore::EventHandler::passMousePressEventToScrollbar):
4764 * platform/PopupMenu.h:
4765 * platform/ScrollBar.cpp:
4766 (WebCore::Scrollbar::Scrollbar):
4767 (WebCore::Scrollbar::autoscrollTimerFired):
4768 (WebCore::Scrollbar::autoscrollPressedPart):
4769 (WebCore::Scrollbar::startTimerIfNeeded):
4770 (WebCore::Scrollbar::stopTimerIfNeeded):
4771 (WebCore::Scrollbar::pressedPartScrollDirection):
4772 (WebCore::Scrollbar::pressedPartScrollGranularity):
4773 * platform/ScrollBar.h:
4774 (WebCore::Scrollbar::handleMousePressEvent):
4775 (WebCore::Scrollbar::invalidatePart):
4776 (WebCore::Scrollbar::thumbUnderMouse):
4777 * platform/ScrollView.h:
4778 * platform/ScrollbarClient.h: Added.
4779 (WebCore::ScrollbarClient::~ScrollbarClient):
4780 * platform/gtk/ScrollViewGtk.cpp:
4781 (WebCore::ScrollView::scrollbarUnderMouse):
4782 * platform/qt/PlatformScrollBar.h:
4783 * platform/qt/PlatformScrollBarQt.cpp:
4784 (WebCore::PlatformScrollbar::PlatformScrollbar):
4785 (WebCore::scrollbarPart):
4786 (WebCore::PlatformScrollbar::handleMouseMoveEvent):
4787 (WebCore::PlatformScrollbar::handleMouseOutEvent):
4788 (WebCore::PlatformScrollbar::handleMousePressEvent):
4789 (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
4790 * platform/qt/ScrollViewQt.cpp:
4791 (WebCore::ScrollView::scrollbarUnderMouse):
4792 (WebCore::ScrollView::wheelEvent):
4793 * platform/win/PlatformScrollBar.h:
4794 * platform/win/PlatformScrollBarSafari.cpp:
4795 (WebCore::PlatformScrollbar::PlatformScrollbar):
4796 * platform/win/PlatformScrollBarWin.cpp:
4797 (WebCore::PlatformScrollbar::PlatformScrollbar):
4798 * platform/win/ScrollViewWin.cpp:
4799 (WebCore::ScrollView::scrollbarUnderMouse):
4800 * rendering/HitTestResult.cpp:
4801 (WebCore::HitTestResult::setScrollbar):
4802 * rendering/HitTestResult.h:
4803 (WebCore::HitTestResult::scrollbar):
4804 * rendering/RenderLayer.cpp:
4805 (WebCore::RenderLayer::hitTestOverflowControls):
4806 * rendering/RenderLayer.h:
4807 * rendering/RenderListBox.h:
4808
sfalken@apple.comb4e407e2008-09-13 02:59:00 +000048092008-09-12 Steve Falkenburg <sfalken@apple.com>
4810
4811 Fix Mac build.
4812
4813 * css/CSSStyleSelector.cpp:
4814 (WebCore::getTransformOperationType):
4815
dino@apple.comf937dc62008-09-13 00:45:39 +000048162008-09-12 Chris Marrin <cmarrin@apple.com>
4817
4818 Reviewed by Dave Hyatt.
4819
4820 Make transform animation behavior match spec
4821 https://bugs.webkit.org/show_bug.cgi?id=20770
4822
4823 Tests: transitions/transform-op-list-match.html
4824 transitions/transform-op-list-no-match.html
4825
4826 * css/CSSStyleSelector.cpp:
4827 * css/CSSStyleSelector.h:
4828 * page/animation/AnimationBase.cpp:
4829 * page/animation/AnimationBase.h:
4830 * page/animation/ImplicitAnimation.cpp:
4831 * page/animation/ImplicitAnimation.h:
4832 * page/animation/KeyframeAnimation.cpp:
4833 * page/animation/KeyframeAnimation.h:
4834 * rendering/RenderLayer.cpp:
4835 * rendering/style/RenderStyle.cpp:
4836 * rendering/style/RenderStyle.h:
4837
timothy@apple.comab374dd2008-09-12 22:43:38 +000048382008-09-12 Ojan Vafai <ojan@chromium.org>
4839
4840 Properly escape contents of links added to the inspector.
4841 For now, just build the link with the DOM and get the
4842 outerHTML. Eventually, we probably just want to do
4843 this entirely with the DOM.
4844
4845 Reviewed by Timothy Hatcher.
4846
4847 https://bugs.webkit.org/show_bug.cgi?id=20684
4848
4849 * manual-tests/inspector/escape-links.html: Added.
4850 * page/inspector/StylesSidebarPane.js:
4851 * page/inspector/inspector.js:
4852 * page/inspector/utilities.js:
4853
adele@apple.com87fb3c72008-09-12 22:14:13 +000048542008-09-12 Adele Peterson <adele@apple.com>
4855
4856 Reviewed by John Sullivan and Kevin McCullough.
4857
4858 Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames
4859
4860 * page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
4861 Hit testing again on the main frame will only work if we aren't already on the main frame. If we are already on the main frame, that will
4862 cause infinite recursion. This change checks that we're not already on the main frame before hit testing again.
4863
kmccullough@apple.combdba2e32008-09-12 22:08:56 +000048642008-09-12 Kevin McCullough <kmccullough@apple.com>
4865
4866 RS by Tim .
4867
4868 Re-introducing the code since it was not the cause of the crash.
4869 See r36343.
4870
4871 * rendering/RenderObject.cpp:
4872 (WebCore::RenderObject::canBeProgramaticallyScrolled):
4873 * rendering/RenderObject.h:
4874
dino@apple.comf712ed02008-09-12 21:54:57 +000048752008-09-12 Chris Marrin <cmarrin@apple.com>
4876
4877 Reviewed by Dave Hyatt.
4878
4879 When changing one animation in a list, don't reset other animations
4880 https://bugs.webkit.org/show_bug.cgi?id=20675
4881
4882 Test: animations/change-one-anim.html
4883
4884 * page/animation/AnimationBase.cpp:
4885 (WebCore::AnimationBase::getNumProperties):
4886 * page/animation/AnimationBase.h:
4887 * page/animation/AnimationController.cpp:
4888 * page/animation/CompositeAnimation.cpp:
4889 (WebCore::CompositeAnimation::updateKeyframeAnimations):
4890 * page/animation/CompositeAnimation.h:
4891 * page/animation/ImplicitAnimation.cpp:
4892 * page/animation/KeyframeAnimation.cpp:
4893 * page/animation/KeyframeAnimation.h:
4894 (WebCore::KeyframeAnimation::setIndex):
4895
beidson@apple.com521e2b52008-09-12 18:40:03 +000048962008-09-12 Brady Eidson <beidson@apple.com>
4897
4898 Reviewed by Mitz Pettel
4899
4900 Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html
4901
4902 * loader/DocumentLoader.cpp:
4903 (WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior.
4904 Subresources can never be created from nil data, but there is always a MainResource, whether
4905 or not there's any data. So in the case where the main resource has no data, fake it for the
4906 sake of creating the ArchiveResource.
4907
hyatt@apple.com818ffe92008-09-12 18:37:23 +000049082008-09-12 Dave Hyatt <hyatt@apple.com>
4909
4910 Preparation for major scrollbar rearchitecture. Eliminate the concept of non-widget based
4911 scrollbars (which we never supported anyway). Make Scrollbar derive from Widget directly.
4912 Remove all the isWidget and hasPlatformScrollbars guards.
4913
4914 Reviewed by Tim Hatcher
4915
4916 * platform/ScrollBar.h:
4917 * platform/gtk/PlatformScrollBar.h:
4918 * platform/mac/PlatformScrollBar.h:
4919 * platform/qt/PlatformScrollBar.h:
4920 * platform/win/PlatformScrollBar.h:
4921 * platform/win/ScrollViewWin.cpp:
4922 (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
4923 (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
4924 * platform/wx/PlatformScrollBar.h:
4925 * rendering/RenderLayer.cpp:
4926 (WebCore::RenderLayer::horizontalScrollbarWidget):
4927 (WebCore::RenderLayer::verticalScrollbarWidget):
4928 (WebCore::RenderLayer::createScrollbar):
4929 (WebCore::RenderLayer::destroyScrollbar):
4930 * rendering/RenderListBox.cpp:
4931 (WebCore::RenderListBox::~RenderListBox):
4932 (WebCore::RenderListBox::updateFromElement):
4933 (WebCore::RenderListBox::isPointInOverflowControl):
4934
mitz@apple.com0bef1302008-09-12 18:22:07 +000049352008-09-12 Dan Bernstein <mitz@apple.com>
4936
4937 Reviewed by Sam Weinig.
4938
4939 - https://bugs.webkit.org/show_bug.cgi?id=20793 clean up page/animation
4940
4941 * page/animation/AnimationController.cpp:
4942 * page/animation/AnimationController.h:
4943 * page/animation/CompositeAnimation.cpp:
4944 * page/animation/CompositeAnimation.h:
4945 * page/animation/ImplicitAnimation.cpp:
4946 * page/animation/ImplicitAnimation.h:
4947 * page/animation/KeyframeAnimation.cpp:
4948 * page/animation/KeyframeAnimation.h:
4949
timothy@apple.com43203432008-09-12 04:44:40 +000049502008-09-11 Timothy Hatcher <timothy@apple.com>
4951
4952 Add a renderedImage method to DOMNode to get an image
4953 of the rendering for the node and it's descendants.
4954
4955 <rdar://problem/5849349> Would like API to create
4956 an image for a DOM node
4957
4958 Reviewed by Oliver Hunt.
4959
4960 * bindings/objc/DOM.mm:
4961 (-[DOMNode renderedImage]): Call Frame::nodeImage.
4962 * bindings/objc/DOMPrivate.h:
4963 * page/Frame.h:
4964 * page/mac/FrameMac.mm:
4965 (WebCore::Frame::nodeImage):
4966
dino@apple.com9300a0b2008-09-12 00:36:31 +000049672008-09-08 Chris Marrin <cmarrin@apple.com>
4968
4969 Reviewed by Dave Hyatt
4970
4971 Need to support comma separated list of key times in keyframes selectors
4972 https://bugs.webkit.org/show_bug.cgi?id=20680
4973
4974 Test: animations/keyframes-comma-separated.html
4975
4976 * css/CSSGrammar.y:
4977 * css/CSSParser.cpp:
4978 (WebCore::CSSParser::createKeyframeRule):
4979 * css/CSSParser.h:
4980 * css/CSSStyleSelector.cpp:
4981 (WebCore::CSSStyleSelector::addKeyframeStyle):
4982 * css/WebKitCSSKeyframeRule.cpp:
4983 (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
4984 (WebCore::WebKitCSSKeyframeRule::cssText):
4985 (WebCore::WebKitCSSKeyframeRule::parseKeyString):
4986 * css/WebKitCSSKeyframeRule.h:
4987 (WebCore::WebKitCSSKeyframeRule::keyText):
4988 (WebCore::WebKitCSSKeyframeRule::setKeyText):
4989 (WebCore::WebKitCSSKeyframeRule::getKeys):
4990 * css/WebKitCSSKeyframesRule.cpp:
4991 (WebCore::WebKitCSSKeyframesRule::append):
4992 (WebCore::WebKitCSSKeyframesRule::insertRule):
4993 (WebCore::WebKitCSSKeyframesRule::deleteRule):
4994 (WebCore::WebKitCSSKeyframesRule::findRule):
4995 (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
4996 * css/WebKitCSSKeyframesRule.h:
4997 * page/animation/AnimationBase.cpp:
4998 (WebCore::AnimationBase::blendProperties):
4999
kmccullough@apple.com0f9f23a2008-09-11 22:57:09 +000050002008-09-11 Kevin McCullough <kmccullough@apple.com>
5001
5002 RS by Tim.
5003
5004 Reverting because this caused a crash.
5005
5006 * rendering/RenderObject.cpp:
5007 (WebCore::RenderObject::canBeProgramaticallyScrolled):
5008 (WebCore::RenderObject::hasScrollableView):
5009 * rendering/RenderObject.h:
5010
dino@apple.com19853b32008-09-11 21:59:08 +000050112008-09-11 Dean Jackson <dino@apple.com>
5012
5013 Reviewed by Dan Bernstein.
5014
5015 Fix assertion on transition property "none"
5016 https://bugs.webkit.org/show_bug.cgi?id=20751
5017
5018 Test: transitions/transition-end-event-set-none.html
5019
5020 * page/animation/CompositeAnimation.cpp:
5021 (WebCore::CompositeAnimation::updateTransitions):
5022
dsmith@webkit.orge6ea48f2008-09-11 21:41:33 +000050232008-09-11 David Smith <catfish.man@gmail.com>
5024
dsmith@webkit.org08103d92008-09-11 21:54:30 +00005025 Rubber-stamped by mitzpettel.
5026
5027 Remove an accidentally added extra file.
5028
5029 * WebCore: Removed.
5030
50312008-09-11 David Smith <catfish.man@gmail.com>
5032
dsmith@webkit.orge6ea48f2008-09-11 21:41:33 +00005033 Reviewed by Darin
5034
5035 https://bugs.webkit.org/show_bug.cgi?id=20180
5036
5037 This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.
5038
5039 * WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
5040 * css/CSSStyleSelector.cpp: include NodeRenderStyle.h
5041 * dom/Element.cpp: include NodeRenderStyle.h
5042 * dom/Node.cpp: Remove the definition of renderStyle()
5043 (WebCore::Node::nonRendererRenderStyle):
5044 * dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
5045 * dom/NodeRenderStyle.h: Added.
5046 (WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
5047 * html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
5048 * html/HTMLOptGroupElement.h:
5049 (WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
5050 * html/HTMLOptionElement.cpp: include NodeRenderStyle.h
5051 * html/HTMLOptionElement.h:
5052 (WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
5053 * rendering/RenderListBox.cpp: include NodeRenderStyle.h
5054 * rendering/RenderMenuList.cpp: include NodeRenderStyle.h
5055 * svg/SVGUseElement.cpp: include NodeRenderStyle.h
5056
kmccullough@apple.com38d3b0f2008-09-11 17:39:12 +000050572008-09-11 Kevin McCullough <kmccullough@apple.com>
5058
5059 Reviewed by Adele and Tim.
5060
5061 <rdar://problem/6100597> REGRESSION: clicking on search results in Web
5062 Inspector does not scroll to the line of the results (20167)
5063 - This was put in by Max to fix auto scrolling but is not correct for
5064 the whole web: rdar://problem/6213098
5065
5066 * rendering/RenderObject.cpp:
5067 (WebCore::RenderObject::canBeProgramaticallyScrolled):
5068 * rendering/RenderObject.h:
5069
cfleizach@apple.com6a3b1452008-09-11 16:24:09 +000050702008-09-11 Chris Fleizach <cfleizach@apple.com>
5071
5072 Reviewed by Beth Dakin
5073
5074 <rdar://problem/6210511> AX: if a frame has a title, that should be reported as the AXWebArea's title
5075
5076 Test: accessibility/frame-with-title.html
5077
5078 * page/AccessibilityRenderObject.cpp:
5079 (WebCore::AccessibilityRenderObject::accessibilityDescription):
5080
hausmann@webkit.orge8f8ffd2008-09-11 07:34:42 +000050812008-09-11 Dirk Schulze <vbs85@gmx.de>
5082
5083 Reviewed by Simon.
5084
hausmann@webkit.orgea57c432008-09-11 08:03:07 +00005085 Fixed stroke() and strokeRect() to support gradients
5086 and patterns on Qt.
5087
5088 [Qt] Canvas stroke don't work for gradients and patterns
5089 [https://bugs.webkit.org/show_bug.cgi?id=20749]
5090
5091 * platform/graphics/qt/GraphicsContextQt.cpp:
5092 (WebCore::GraphicsContext::strokePath):
5093 (WebCore::GraphicsContext::strokeRect):
5094
50952008-09-11 Dirk Schulze <vbs85@gmx.de>
5096
5097 Reviewed by Simon.
5098
hausmann@webkit.orgc11e3b72008-09-11 07:37:42 +00005099 https://bugs.webkit.org/show_bug.cgi?id=20729
5100
5101 Fixed canvas gradients for Qt
5102
5103 [Qt] Canvas gradients don't work as expected
5104 [https://bugs.webkit.org/show_bug.cgi?id=20729]
5105
5106 * platform/graphics/qt/GradientQt.cpp:
5107 (WebCore::Gradient::platformGradient):
5108
51092008-09-11 Dirk Schulze <vbs85@gmx.de>
5110
5111 Reviewed by Simon.
5112
hausmann@webkit.orge8f8ffd2008-09-11 07:34:42 +00005113 https://bugs.webkit.org/show_bug.cgi?id=20568
5114
5115 Add support for patterns to Qt.
5116
5117 * platform/graphics/qt/PatternQt.cpp:
5118 (WebCore::Pattern::createPlatformPattern):
5119
mitz@apple.com442c5892008-09-10 18:21:14 +000051202008-09-10 Dan Bernstein <mitz@apple.com>
5121
5122 Reviewed by Sam Weinig.
5123
5124 - clean up AnimationBase
5125
5126 * page/animation/AnimationBase.cpp:
5127 * page/animation/AnimationBase.h:
5128 * page/animation/CompositeAnimation.cpp:
5129 * page/animation/ImplicitAnimation.cpp:
5130 * page/animation/ImplicitAnimation.h:
5131 * page/animation/KeyframeAnimation.cpp:
5132 * page/animation/KeyframeAnimation.h:
5133
ap@webkit.orgbaf12872008-09-10 16:42:10 +000051342008-09-10 Alexey Proskuryakov <ap@webkit.org>
5135
5136 Reviewed by Darin Adler.
5137
5138 https://bugs.webkit.org/show_bug.cgi?id=20741
5139 REGRESSION: ISO-8859-8-I encoding is registered incorrectly
5140
5141 Turns out that there were no real behavior changes for 8859-8, as it was only a debug-only
5142 check to ignore this specific registration that was failing. Yet, I decided to add a bunch of
5143 tests for ISO-8859-8 encoding aliases, as we handle them in a quite complicated manner.
5144
5145 I also found and fixed a potential crasher for non-Mac ports.
5146
5147 Tests: fast/encoding/hebrew/8859-8-e.html
5148 fast/encoding/hebrew/8859-8-i.html
5149 fast/encoding/hebrew/8859-8.html
5150 fast/encoding/hebrew/csISO88598I.html
5151 fast/encoding/hebrew/hebrew.html
5152 fast/encoding/hebrew/iso-ir-138.html
5153 fast/encoding/hebrew/logical.html
5154
5155 * platform/text/TextEncodingRegistry.cpp: (WebCore::checkExistingName): Check for iso-8859-8
5156 (case-insensitively, because different versions of ICU report this MIME name in different
5157 case).
5158
5159 * platform/text/TextCodecICU.cpp:
5160 (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated some comments.
5161 (WebCore::TextCodecICU::registerExtendedCodecs): Try both MIME and IANA names here, too.
5162 There are four names in ICU that only have MIME names (x-mac-* ones), so we could end up
5163 with an encoding map entry, but no codec for these. This was not an issue on the Mac, as
5164 we also support these via TEC (which we should stop doing), but on Windows, this would
5165 likely crash.
5166
hyatt@apple.com0197e6b2008-09-10 05:29:46 +000051672008-09-09 Dave Hyatt <hyatt@apple.com
5168
5169 Resurrect PlatformScrollbarWin.
5170
5171 Reviewed by Adam Roben
5172
5173 * WebCore.vcproj/WebCore.vcproj:
5174 * platform/win/PlatformScrollBarWin.cpp:
5175 (WebCore::isRunningOnVistaOrLater):
5176 (WebCore::checkAndInitScrollbarTheme):
5177 (WebCore::PlatformScrollbar::PlatformScrollbar):
5178 (WebCore::PlatformScrollbar::invalidateTrack):
5179 (WebCore::PlatformScrollbar::invalidatePart):
5180 (WebCore::PlatformScrollbar::paint):
5181 (WebCore::PlatformScrollbar::hasButtons):
5182 (WebCore::PlatformScrollbar::hasThumb):
5183 (WebCore::PlatformScrollbar::backButtonRect):
5184 (WebCore::PlatformScrollbar::forwardButtonRect):
5185 (WebCore::PlatformScrollbar::trackRect):
5186 (WebCore::PlatformScrollbar::gripperRect):
5187 (WebCore::PlatformScrollbar::thumbLength):
5188 (WebCore::PlatformScrollbar::paintButton):
5189 (WebCore::PlatformScrollbar::paintTrack):
5190 (WebCore::PlatformScrollbar::paintThumb):
5191 (WebCore::PlatformScrollbar::paintGripper):
5192 (WebCore::PlatformScrollbar::hitTest):
5193 (WebCore::PlatformScrollbar::handleMouseMoveEvent):
5194 (WebCore::PlatformScrollbar::handleMouseOutEvent):
5195 (WebCore::PlatformScrollbar::themeChanged):
5196
cwzwarich@webkit.org8a334572008-09-10 03:22:04 +000051972008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
5198
5199 Reviewed by Maciej Stachowiak.
5200
5201 Bug 20759: Remove MacroAssembler
5202 <https://bugs.webkit.org/show_bug.cgi?id=20759>
5203
5204 Make the necessary changes to ForwardingHeaders to remove
5205 MacroAssembler.
5206
5207 * ForwardingHeaders/masm/IA32MacroAsm.h: Removed.
5208 * ForwardingHeaders/masm/MacroAssembler.h: Removed.
5209 * ForwardingHeaders/masm/X86Assembler.h: Added.
5210
alp@webkit.org509e3d42008-09-10 01:26:20 +000052112008-09-09 Alp Toker <alp@nuanti.com>
5212
5213 Reviewed by Dave Hyatt.
5214
5215 https://bugs.webkit.org/show_bug.cgi?id=16792
5216 [GTK] Fails to render Japanese/Chinese text with simple path
5217
5218 https://bugs.webkit.org/show_bug.cgi?id=16942
5219 [GTK] Oddities in font selection and fall back
5220
5221 https://bugs.webkit.org/show_bug.cgi?id=16862
5222 [GTK] Custom fonts hard-coded to use grayscale antialiasing and no hinting
5223
5224 GTK+ font fixes and enhancements.
5225
5226 Implement font fallback for the simple FontConfig-based text path and
5227 improve the Pango-based complex text path to make use of requested
5228 font properties and available font selection.
5229
5230 Add text shadow support to the complex path.
5231
5232 * platform/graphics/gtk/FontCacheGtk.cpp:
5233 (WebCore::FontCache::getFontDataForCharacters):
5234 (WebCore::FontCache::getSimilarFontPlatformData):
5235 * platform/graphics/gtk/FontGtk.cpp:
5236 (WebCore::setPangoAttributes):
5237 (WebCore::Font::drawComplexText):
5238 (WebCore::getDefaultPangoLayout):
5239 (WebCore::Font::floatWidthForComplexText):
5240 (WebCore::Font::offsetForPositionForComplexText):
5241 (WebCore::Font::selectionRectForComplexText):
5242 * platform/graphics/gtk/FontPlatformData.h:
5243 (WebCore::FontPlatformData::FontPlatformData):
5244 (WebCore::FontPlatformData::hash):
5245 * platform/graphics/gtk/FontPlatformDataGtk.cpp:
5246 (WebCore::FontPlatformData::FontPlatformData):
5247 * platform/graphics/gtk/SimpleFontDataGtk.cpp:
5248 (WebCore::SimpleFontData::platformDestroy):
5249
hyatt@apple.com33f37f62008-09-09 23:51:46 +000052502008-09-09 Dave Hyatt <hyatt@apple.com>
5251
5252 Make the Windows classic case work again. Overlap in slider constants and other constants broke
5253 the push state for buttons and checkboxes. Make sure to check the RenderObject's appearance
5254 value to make sure it's really a slider thumb to resolve this conflict.
5255
5256 Reviewed by Adam Roben
5257
5258 * rendering/RenderThemeWin.cpp:
5259 (WebCore::drawControl):
5260
dino@apple.com442d0652008-09-09 23:36:56 +000052612008-09-05 Chris Marrin <cmarrin@apple.com>
5262
5263 Reviewed by Sam Weinig.
5264
5265 Need to handle the case when 0% or 100% keyframe is omitted
5266 https://bugs.webkit.org/show_bug.cgi?id=20679
5267
5268 Tests: animations/keyframes-from-missing.html
5269 animations/keyframes-to-missing.html
5270
5271 * css/CSSStyleSelector.cpp:
5272 (WebCore::CSSStyleSelector::addKeyframeStyle):
5273
hyatt@apple.com419d0ad2008-09-09 23:11:14 +000052742008-09-09 Dave Hyatt <hyatt@apple.com>
5275
5276 Resurrect Safari's original RenderThemeWin and bring it up to date with ToT. Having a current
5277 RenderThemeWin that does not have any Skia dependencies should provide a good basis for a potential
5278 merge of Google Chrome's RenderThemeWin (to help us see where the Skia stuff can be cut and to see
5279 what changes have been made as compared with the old RenderThemeWin).
5280
5281 Fix CSS2 system fonts to properly set both the rendering mode (so that they properly pick up GDI vs. CG
5282 text rendering modes) and the printer font setting (so that OS X system fonts properly pick up screen
5283 vs. printer advancement rounding).
5284
5285 Reviewed by Adam/Sam
5286
5287 * css/CSSStyleSelector.cpp:
5288 (WebCore::CSSStyleSelector::applyProperty):
5289 * platform/graphics/Icon.h:
5290 (WebCore::Icon::create):
5291 * rendering/RenderThemeWin.cpp:
5292 (WebCore::RenderThemeWin::RenderThemeWin):
5293 (WebCore::RenderThemeWin::~RenderThemeWin):
5294 (WebCore::RenderThemeWin::buttonTheme):
5295 (WebCore::RenderThemeWin::textFieldTheme):
5296 (WebCore::RenderThemeWin::menuListTheme):
5297 (WebCore::RenderThemeWin::sliderTheme):
5298 (WebCore::RenderThemeWin::close):
5299 (WebCore::RenderThemeWin::themeChanged):
5300 (WebCore::RenderThemeWin::supportsHover):
5301 (WebCore::fillFontDescription):
5302 (WebCore::RenderThemeWin::systemFont):
5303 (WebCore::RenderThemeWin::supportsFocus):
5304 (WebCore::RenderThemeWin::determineClassicState):
5305 (WebCore::RenderThemeWin::determineState):
5306 (WebCore::RenderThemeWin::determineSliderThumbState):
5307 (WebCore::RenderThemeWin::getClassicThemeData):
5308 (WebCore::RenderThemeWin::getThemeData):
5309 (WebCore::drawControl):
5310 (WebCore::RenderThemeWin::paintButton):
5311 (WebCore::RenderThemeWin::paintTextField):
5312 (WebCore::RenderThemeWin::paintMenuList):
5313 (WebCore::RenderThemeWin::adjustMenuListStyle):
5314 (WebCore::RenderThemeWin::adjustMenuListButtonStyle):
5315 (WebCore::RenderThemeWin::paintMenuListButton):
5316 (WebCore::RenderThemeWin::paintSliderTrack):
5317 (WebCore::RenderThemeWin::paintSliderThumb):
5318 (WebCore::RenderThemeWin::adjustSliderThumbSize):
5319 (WebCore::RenderThemeWin::paintSearchField):
5320 (WebCore::RenderThemeWin::adjustSearchFieldStyle):
5321 (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
5322 (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
5323 (WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
5324 (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
5325 (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
5326 (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
5327 (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
5328 * rendering/RenderThemeWin.h:
5329 (WebCore::ThemeData::ThemeData):
5330 (WebCore::RenderThemeWin::paintSearchFieldDecoration):
5331 (WebCore::RenderThemeWin::adjustButtonStyle):
5332 (WebCore::RenderThemeWin::adjustTextFieldStyle):
5333 (WebCore::RenderThemeWin::adjustTextAreaStyle):
5334
dino@apple.comd511ce52008-09-09 19:50:25 +000053352008-09-09 Dean Jackson <dino@apple.com>
5336
5337 Reviewed by Sam Weinig.
5338
5339 Document::createEvent missing cases for animation and
5340 transition events.
5341 https://bugs.webkit.org/show_bug.cgi?id=20734
5342
5343 Test: transitions/transition-end-event-create.html
5344 Test: animations/animation-events-create.html
5345
5346 * dom/Document.cpp:
5347 (WebCore::Document::createEvent):
5348 - add the two cases
5349
mitz@apple.com1da7b882008-09-09 18:12:06 +000053502008-09-09 Dan Bernstein <mitz@apple.com>
5351
mitz@apple.com54921562008-09-09 18:48:34 +00005352 - Tiger build fix
5353
5354 * WebCore.Tiger.exp:
5355 * WebCore.base.exp:
5356 * platform/mac/WebCoreSystemInterface.h:
5357 * platform/mac/WebCoreSystemInterface.mm:
5358
53592008-09-09 Dan Bernstein <mitz@apple.com>
5360
mitz@apple.com1da7b882008-09-09 18:12:06 +00005361 Reviewed by Darin Adler.
5362
5363 - WebCore part of <rdar://problem/6206244> Use alternate character-to-glyph interface on Leopard
5364
5365 * WebCore.Tiger.exp:
5366 * WebCore.base.exp:
5367 * platform/graphics/SimpleFontData.h:
5368 * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
5369 (WebCore::GlyphPage::fill):
5370 * platform/graphics/mac/SimpleFontDataMac.mm:
5371 (WebCore::initFontData):
5372 (WebCore::SimpleFontData::platformInit):
5373 (WebCore::SimpleFontData::platformDestroy):
5374 * platform/mac/WebCoreSystemInterface.h:
5375 * platform/mac/WebCoreSystemInterface.mm:
5376
kmccullough@apple.com5ba965b2008-09-09 16:40:31 +000053772008-09-09 Kevin McCullough <kmccullough@apple.com>
5378
5379 Reviewed by Tim.
5380
5381 <rdar://problem/6198545> REGRESSION: Inspector debugger barfs on
5382 breakpoints inside eval.
5383
5384 * page/inspector/inspector.js:
5385
hausmann@webkit.orgdab0e872008-09-09 14:17:21 +000053862008-09-09 Joerg Bornemann <joerg.bornemann@trolltech.com>
5387
5388 Reviewed by Simon.
5389
5390 Fix compilation of the Qt port with disabled plugins on Windows
5391
5392 * WebCore.pro:
5393 * plugins/PluginView.cpp:
5394 (WebCore::PluginView::PluginView):
5395 * plugins/PluginView.h:
5396
ap@webkit.org2ba74d32008-09-09 08:11:01 +000053972008-09-09 Jungshik Shin <jungshik.shin@gmail.com>
5398
5399 Reviewed by Alexey Proskuryakov.
5400
5401 Try MIME charset names before trying IANA names
5402 ( https://bugs.webkit.org/show_bug.cgi?id=17537 )
5403
5404 With this change, shorter and more widely used names (preferred MIME
5405 names) are returned by document.charset, document.characterSet,
5406 document.inputEncoding rather than IANA names. This helps
5407 fixing bug 18085 in addition to web developers who are more familiar
5408 with MIME names. For instance, EUC-JP, ISO-8859-X and US-ASCII will be
5409 returned instead of Extended_UNIX_Code_Packed_Format_for_Japanese,
5410 ISO-8859-X:19xx, and ANSI_X3.4-1968. It also replaces IBM8xx with cp8xx.
5411 Note that cp/IBM 8xx are extremly rare in today's web. Even if they're
5412 used, the former is still recognized as aliases to the latter so that
5413 there's very little, if any, to worry about.
5414
5415 * platform/text/TextCodecICU.cpp:
5416 (WebCore::TextCodecICU::registerExtendedEncodingNames):
5417
weinig@apple.com22294302008-09-09 06:55:39 +000054182008-09-08 Sam Weinig <sam@webkit.org>
5419
5420 Reviewed by Maciej Stachowiak and Oliver Hunt.
5421
5422 Add forwarding headers.
5423
5424 * ForwardingHeaders/wtf/HashFunctions.h: Added.
5425
dino@apple.comd9962af2008-09-09 01:02:00 +000054262008-09-05 Dean Jackson <dino@apple.com>
5427
5428 Reviewed by Dan Bernstein.
5429
5430 Update grammar so that we can add a keyframe rule via the DOM.
5431 https://bugs.webkit.org/show_bug.cgi?id=20613
5432
5433 * css/CSSGrammar.y:
5434 * css/tokenizer.flex:
5435
antti@apple.com4b17a932008-09-09 00:40:45 +000054362008-09-08 Antti Koivisto <antti@apple.com>
5437
5438 Reviewed by Dan Bernstein.
5439
5440 Allow <br> for simple UA stylesheet. Editing code generates them. It does not
5441 actually show up in any of the default stylesheets.
5442
5443 * css/CSSStyleSelector.cpp:
5444 (WebCore::elementCanUseSimpleDefaultStyle):
5445
mitz@apple.com66fa91a2008-09-09 00:35:22 +000054462008-09-08 Dimitri Glazkov <dglazkov@google.com>
5447
5448 Reviewed by Dan Bernstein.
5449
5450 - fix https://bugs.webkit.org/show_bug.cgi?id=20237
5451 Zero width and space characters are displayed incorrectly if not contained in a fallback font
5452
5453 Adds an extra check for Object Replacement Character (U+FFFC) to address
5454 the issue with fast/text/zero-width-characters.html test when run
5455 with Windows system default fonts.
5456
5457 * platform/graphics/Font.h:
5458 (WebCore::Font::treatAsZeroWidthSpace):
5459
dino@apple.comf0a4b212008-09-08 22:51:49 +000054602008-09-08 Dean Jackson <dino@apple.com>
5461
5462 Reviewed by Sam Weinig.
5463
5464 Code style issue I forgot to fix from previous commit.
5465
5466 * platform/graphics/AffineTransform.cpp:
5467 (WebCore::AffineTransform::blend):
5468
dino@apple.com26625122008-09-08 22:46:41 +000054692008-09-08 Chris Marrin <cmarrin@apple.com>
5470
5471 Reviewed by Sam Weinig
5472
5473 - Animation of -webkit-transform matrix() function should not do linear interpolation
5474 https://bugs.webkit.org/show_bug.cgi?id=20667
5475
5476 Test: animations/matrix-anim.html
5477
5478 * ChangeLog:
5479 * platform/graphics/AffineTransform.cpp:
5480 (WebCore::affineTransformDecompose):
5481 (WebCore::affineTransformCompose):
5482 (WebCore::AffineTransform::blend):
5483 * platform/graphics/AffineTransform.h:
5484 * rendering/style/RenderStyle.cpp:
5485 (WebCore::MatrixTransformOperation::blend):
5486
ap@webkit.org243a9752008-09-08 16:21:16 +000054872008-09-08 Alexey Proskuryakov <ap@webkit.org>
5488
5489 Reviewed by Darin Adler.
5490
5491 https://bugs.webkit.org/show_bug.cgi?id=20668
5492 multipart/form-data does not always include Content-type for submitted files
5493
5494 Cannot be tested with DRT or manual tests.
5495
5496 * platform/MIMETypeRegistry.cpp:
5497 (WebCore::initializeSupportedNonImageMimeTypes): Fix spacing.
5498 (WebCore::MIMETypeRegistry::getMIMETypeForPath): Default to application/octet-stream for
5499 unknown extensions, not just missing ones.
5500
hausmann@webkit.orgaf796ea2008-09-08 13:00:19 +000055012008-09-08 Simon Hausmann <hausmann@webkit.org>
5502
5503 Build fix for the Qt/Windows build, define USE_JSC to
5504 enable the WebCore::String -> JSC::UString operator that
5505 MSVC insists on seeing
5506
5507 * WebCore.pro:
5508
andersca@apple.com3ac4f552008-09-08 11:39:34 +000055092008-09-08 Anders Carlsson <andersca@apple.com>
5510
5511 Reviewed by Maciej.
5512
5513 <rdar://problem/5850387> Showing bookmarks reloads Google Reader instead.
5514
5515 In some cases, timeouts scheduled by a page in the onunload handler could fire even when the
5516 page had been unloaded and replaced by a non-HTML representation based view (such as the bookmarks view).
5517
5518 Fix this by clearing timeouts for pages that aren't cached when the provisional load is committed.
5519
5520 * bindings/js/JSDOMWindowBase.h:
5521 * loader/FrameLoader.cpp:
5522 (WebCore::FrameLoader::commitProvisionalLoad):
5523
antti@apple.com57b3a102008-09-08 07:01:36 +000055242008-09-07 Antti Koivisto <antti@apple.com>
5525
5526 Reviewed by Dave Hyatt.
5527
5528 Don't leak the simple stylesheet.
5529 Also call RenderTheme::adjustDefaultStyleSheet() in right place.
5530
5531 * css/CSSStyleSelector.cpp:
5532 (WebCore::loadFullDefaultStyle):
5533 (WebCore::loadSimpleDefaultStyle):
5534 (WebCore::CSSStyleSelector::styleForElement):
5535
cwzwarich@webkit.org3f782f62008-09-08 01:28:33 +000055362008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
5537
cwzwarich@webkit.org951b1452008-09-08 04:25:32 +00005538 Reviewed by Oliver Hunt.
5539
5540 Bug 20711: Change KJS prefix on preprocessor macros to JSC
5541 <https://bugs.webkit.org/show_bug.cgi?id=20711>
5542
5543 * bindings/js/JSEventTargetBase.h:
5544 * bindings/js/JSHTMLInputElementBase.cpp:
5545 * bindings/js/JSHTMLInputElementBase.h:
5546 * bindings/scripts/CodeGeneratorJS.pm:
5547
55482008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
5549
cwzwarich@webkit.org3f782f62008-09-08 01:28:33 +00005550 Reviewed by Maciej Stachowiak.
5551
5552 Bug 20704: Replace the KJS namespace
5553 <https://bugs.webkit.org/show_bug.cgi?id=20704>
5554
5555 Rename the KJS namespace to JSC. There are still some uses of KJS in the
5556 names of JNI functions, and I will check if these are safe to change
5557 as well.
5558
5559 * WebCore.base.exp:
5560 * bindings/js/GCController.cpp:
5561 * bindings/js/JSAttrCustom.cpp:
5562 * bindings/js/JSAudioConstructor.cpp:
5563 * bindings/js/JSAudioConstructor.h:
5564 (WebCore::JSAudioConstructor::classInfo):
5565 * bindings/js/JSCSSRuleCustom.cpp:
5566 * bindings/js/JSCSSStyleDeclarationCustom.cpp:
5567 * bindings/js/JSCSSValueCustom.cpp:
5568 * bindings/js/JSCanvasPixelArrayCustom.cpp:
5569 * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
5570 * bindings/js/JSClipboardCustom.cpp:
5571 * bindings/js/JSConsoleCustom.cpp:
5572 * bindings/js/JSCustomSQLStatementCallback.cpp:
5573 (WebCore::JSCustomSQLStatementCallback::handleEvent):
5574 * bindings/js/JSCustomSQLStatementCallback.h:
5575 (WebCore::JSCustomSQLStatementCallback::create):
5576 * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
5577 (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
5578 * bindings/js/JSCustomSQLStatementErrorCallback.h:
5579 (WebCore::JSCustomSQLStatementErrorCallback::create):
5580 * bindings/js/JSCustomSQLTransactionCallback.cpp:
5581 (WebCore::JSCustomSQLTransactionCallback::handleEvent):
5582 * bindings/js/JSCustomSQLTransactionCallback.h:
5583 (WebCore::JSCustomSQLTransactionCallback::create):
5584 * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
5585 (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
5586 * bindings/js/JSCustomSQLTransactionErrorCallback.h:
5587 (WebCore::JSCustomSQLTransactionErrorCallback::create):
5588 * bindings/js/JSCustomVoidCallback.cpp:
5589 (WebCore::JSCustomVoidCallback::handleEvent):
5590 * bindings/js/JSCustomVoidCallback.h:
5591 (WebCore::JSCustomVoidCallback::create):
5592 * bindings/js/JSCustomXPathNSResolver.cpp:
5593 (WebCore::JSCustomXPathNSResolver::create):
5594 * bindings/js/JSCustomXPathNSResolver.h:
5595 * bindings/js/JSDOMApplicationCacheCustom.cpp:
5596 (WebCore::JSDOMApplicationCache::dispatchEvent):
5597 * bindings/js/JSDOMBinding.cpp:
5598 (WebCore::jsOwnedStringOrNull):
5599 * bindings/js/JSDOMBinding.h:
5600 (WebCore::DOMObject::DOMObject):
5601 (WebCore::cacheDOMObject):
5602 (WebCore::cacheSVGDOMObject):
5603 (WebCore::DOMExceptionTranslator::DOMExceptionTranslator):
5604 (WebCore::toJS):
5605 * bindings/js/JSDOMWindowBase.cpp:
5606 * bindings/js/JSDOMWindowBase.h:
5607 (WebCore::JSDOMWindowBase::classInfo):
5608 (WebCore::JSDOMWindowBase::d):
5609 * bindings/js/JSDOMWindowCustom.cpp:
5610 (WebCore::JSDOMWindow::getPropertyAttributes):
5611 * bindings/js/JSDOMWindowCustom.h:
5612 (WebCore::asJSDOMWindow):
5613 (WebCore::JSDOMWindow::customGetOwnPropertySlot):
5614 (WebCore::JSDOMWindow::customPut):
5615 (WebCore::JSDOMWindowBase::allowsAccessFrom):
5616 (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
5617 * bindings/js/JSDOMWindowShell.cpp:
5618 (WebCore::JSDOMWindowShell::getPropertyAttributes):
5619 * bindings/js/JSDOMWindowShell.h:
5620 (WebCore::JSDOMWindowShell::classInfo):
5621 * bindings/js/JSDatabaseCustom.cpp:
5622 * bindings/js/JSDocumentCustom.cpp:
5623 * bindings/js/JSDocumentFragmentCustom.cpp:
5624 * bindings/js/JSElementCustom.cpp:
5625 * bindings/js/JSEventCustom.cpp:
5626 * bindings/js/JSEventListener.cpp:
5627 * bindings/js/JSEventListener.h:
5628 (WebCore::JSUnprotectedEventListener::create):
5629 (WebCore::JSEventListener::create):
5630 * bindings/js/JSEventTargetBase.cpp:
5631 * bindings/js/JSEventTargetBase.h:
5632 (WebCore::JSEventTargetBase::getValueProperty):
5633 (WebCore::JSEventTargetBase::putValueProperty):
5634 (WebCore::JSEventTargetBase::getOwnPropertySlot):
5635 (WebCore::JSEventTargetBase::put):
5636 (WebCore::JSEventTargetPrototype::JSEventTargetPrototype):
5637 (WebCore::JSEventTargetPrototype::self):
5638 (WebCore::JSEventTargetPrototype::getOwnPropertySlot):
5639 (WebCore::JSEventTargetPrototype::classInfo):
5640 * bindings/js/JSEventTargetNode.cpp:
5641 * bindings/js/JSEventTargetNode.h:
5642 (WebCore::JSEventTargetNode::getOwnPropertySlot):
5643 (WebCore::JSEventTargetNode::getValueProperty):
5644 (WebCore::JSEventTargetNode::put):
5645 (WebCore::JSEventTargetNode::putValueProperty):
5646 * bindings/js/JSHTMLAllCollection.h:
5647 (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
5648 (WebCore::JSHTMLAllCollection::toBoolean):
5649 * bindings/js/JSHTMLAppletElementCustom.cpp:
5650 * bindings/js/JSHTMLCollectionCustom.cpp:
5651 * bindings/js/JSHTMLDocumentCustom.cpp:
5652 * bindings/js/JSHTMLElementCustom.cpp:
5653 * bindings/js/JSHTMLEmbedElementCustom.cpp:
5654 * bindings/js/JSHTMLFormElementCustom.cpp:
5655 * bindings/js/JSHTMLFrameElementCustom.cpp:
5656 * bindings/js/JSHTMLFrameSetElementCustom.cpp:
5657 * bindings/js/JSHTMLIFrameElementCustom.cpp:
5658 * bindings/js/JSHTMLInputElementBase.cpp:
5659 (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
5660 (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
5661 * bindings/js/JSHTMLInputElementBase.h:
5662 (WebCore::JSHTMLInputElementBase::classInfo):
5663 * bindings/js/JSHTMLObjectElementCustom.cpp:
5664 * bindings/js/JSHTMLOptionElementConstructor.cpp:
5665 * bindings/js/JSHTMLOptionElementConstructor.h:
5666 (WebCore::JSHTMLOptionElementConstructor::classInfo):
5667 * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
5668 * bindings/js/JSHTMLSelectElementCustom.cpp:
5669 (WebCore::selectIndexSetter):
5670 (WebCore::JSHTMLSelectElement::indexSetter):
5671 * bindings/js/JSHTMLSelectElementCustom.h:
5672 * bindings/js/JSHistoryCustom.cpp:
5673 * bindings/js/JSImageConstructor.cpp:
5674 * bindings/js/JSImageConstructor.h:
5675 (WebCore::JSImageConstructor::classInfo):
5676 * bindings/js/JSInspectedObjectWrapper.cpp:
5677 * bindings/js/JSInspectedObjectWrapper.h:
5678 (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
5679 (WebCore::JSInspectedObjectWrapper::classInfo):
5680 * bindings/js/JSInspectorCallbackWrapper.cpp:
5681 * bindings/js/JSInspectorCallbackWrapper.h:
5682 (WebCore::JSInspectorCallbackWrapper::classInfo):
5683 (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
5684 * bindings/js/JSJavaScriptCallFrameCustom.cpp:
5685 * bindings/js/JSLocationCustom.cpp:
5686 * bindings/js/JSMimeTypeArrayCustom.cpp:
5687 * bindings/js/JSNSResolver.cpp:
5688 * bindings/js/JSNSResolver.h:
5689 (WebCore::JSNSResolver::create):
5690 * bindings/js/JSNamedNodeMapCustom.cpp:
5691 * bindings/js/JSNamedNodesCollection.cpp:
5692 (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
5693 * bindings/js/JSNamedNodesCollection.h:
5694 (WebCore::JSNamedNodesCollection::classInfo):
5695 * bindings/js/JSNavigatorCustom.cpp:
5696 * bindings/js/JSNodeCustom.cpp:
5697 * bindings/js/JSNodeFilterCondition.cpp:
5698 (WebCore::JSNodeFilterCondition::acceptNode):
5699 * bindings/js/JSNodeFilterCondition.h:
5700 (WebCore::JSNodeFilterCondition::create):
5701 * bindings/js/JSNodeFilterCustom.cpp:
5702 * bindings/js/JSNodeIteratorCustom.cpp:
5703 * bindings/js/JSNodeListCustom.cpp:
5704 * bindings/js/JSPluginArrayCustom.cpp:
5705 * bindings/js/JSPluginCustom.cpp:
5706 * bindings/js/JSPluginElementFunctions.cpp:
5707 (WebCore::getRuntimeObject):
5708 * bindings/js/JSPluginElementFunctions.h:
5709 * bindings/js/JSQuarantinedObjectWrapper.cpp:
5710 (WebCore::JSQuarantinedObjectWrapper::construct):
5711 (WebCore::JSQuarantinedObjectWrapper::call):
5712 * bindings/js/JSQuarantinedObjectWrapper.h:
5713 (WebCore::JSQuarantinedObjectWrapper::unwrappedObject):
5714 (WebCore::JSQuarantinedObjectWrapper::unwrappedGlobalObject):
5715 (WebCore::JSQuarantinedObjectWrapper::className):
5716 * bindings/js/JSRGBColor.cpp:
5717 * bindings/js/JSRGBColor.h:
5718 (WebCore::JSRGBColor::classInfo):
5719 * bindings/js/JSSQLResultSetRowListCustom.cpp:
5720 * bindings/js/JSSQLTransactionCustom.cpp:
5721 * bindings/js/JSSVGLazyEventListener.cpp:
5722 * bindings/js/JSSVGLazyEventListener.h:
5723 * bindings/js/JSSVGLengthCustom.cpp:
5724 * bindings/js/JSSVGMatrixCustom.cpp:
5725 (WebCore::JSSVGMatrix::inverse):
5726 (WebCore::JSSVGMatrix::rotateFromVector):
5727 * bindings/js/JSSVGPathSegCustom.cpp:
5728 * bindings/js/JSSVGPathSegListCustom.cpp:
5729 (WebCore::JSSVGPathSegList::initialize):
5730 (WebCore::JSSVGPathSegList::getItem):
5731 (WebCore::JSSVGPathSegList::insertItemBefore):
5732 (WebCore::JSSVGPathSegList::replaceItem):
5733 (WebCore::JSSVGPathSegList::removeItem):
5734 (WebCore::JSSVGPathSegList::appendItem):
5735 * bindings/js/JSSVGPointListCustom.cpp:
5736 * bindings/js/JSSVGTransformListCustom.cpp:
5737 * bindings/js/JSStorageCustom.cpp:
5738 * bindings/js/JSStyleSheetCustom.cpp:
5739 * bindings/js/JSStyleSheetListCustom.cpp:
5740 * bindings/js/JSTextCustom.cpp:
5741 * bindings/js/JSTreeWalkerCustom.cpp:
5742 * bindings/js/JSXMLHttpRequestConstructor.cpp:
5743 * bindings/js/JSXMLHttpRequestConstructor.h:
5744 (WebCore::JSXMLHttpRequestConstructor::classInfo):
5745 * bindings/js/JSXMLHttpRequestCustom.cpp:
5746 * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
5747 * bindings/js/JSXSLTProcessorConstructor.cpp:
5748 * bindings/js/JSXSLTProcessorConstructor.h:
5749 (WebCore::JSXSLTProcessorConstructor::classInfo):
5750 * bindings/js/JSXSLTProcessorCustom.cpp:
5751 * bindings/js/ScheduledAction.cpp:
5752 * bindings/js/ScheduledAction.h:
5753 * bindings/js/ScriptController.cpp:
5754 (WebCore::ScriptController::attachDebugger):
5755 (WebCore::ScriptController::windowScriptNPObject):
5756 * bindings/js/ScriptController.h:
5757 * bindings/js/ScriptControllerGtk.cpp:
5758 (WebCore::ScriptController::createScriptInstanceForWidget):
5759 * bindings/js/ScriptControllerMac.mm:
5760 (WebCore::ScriptController::createScriptInstanceForWidget):
5761 (WebCore::ScriptController::windowScriptObject):
5762 (WebCore::ScriptController::clearPlatformScriptObjects):
5763 (WebCore::updateRenderingForBindings):
5764 (WebCore::ScriptController::initJavaJSBindings):
5765 * bindings/js/ScriptControllerQt.cpp:
5766 (WebCore::ScriptController::createScriptInstanceForWidget):
5767 * bindings/js/ScriptControllerWin.cpp:
5768 (WebCore::ScriptController::createScriptInstanceForWidget):
5769 * bindings/js/ScriptControllerWx.cpp:
5770 (WebCore::ScriptController::createScriptInstanceForWidget):
5771 * bindings/js/StringSourceProvider.h:
5772 (WebCore::StringSourceProvider::getRange):
5773 * bindings/objc/DOM.mm:
5774 (-[DOMNode JSC::Bindings::]):
5775 * bindings/objc/DOMInternal.h:
5776 * bindings/objc/DOMInternal.mm:
5777 (-[WebScriptObject _initializeScriptDOMNodeImp]):
5778 * bindings/objc/DOMUtility.mm:
5779 (JSC::createDOMWrapper):
5780 (WebCore::createDOMWrapper):
5781 * bindings/objc/WebScriptObject.mm:
5782 (WebCore::createJSWrapper):
5783 (-[WebScriptObject _initWithJSObject:JSC::originRootObject:JSC::Bindings::rootObject:JSC::Bindings::]):
5784 * bindings/objc/WebScriptObjectPrivate.h:
5785 * bindings/scripts/CodeGeneratorJS.pm:
5786 * bridge/NP_jsobject.cpp:
5787 * bridge/NP_jsobject.h:
5788 * bridge/c/c_class.cpp:
5789 * bridge/c/c_class.h:
5790 * bridge/c/c_instance.cpp:
5791 * bridge/c/c_instance.h:
5792 * bridge/c/c_runtime.cpp:
5793 * bridge/c/c_runtime.h:
5794 * bridge/c/c_utility.cpp:
5795 * bridge/c/c_utility.h:
5796 * bridge/jni/jni_class.cpp:
5797 * bridge/jni/jni_class.h:
5798 * bridge/jni/jni_instance.cpp:
5799 * bridge/jni/jni_instance.h:
5800 * bridge/jni/jni_jsobject.h:
5801 * bridge/jni/jni_jsobject.mm:
5802 (JavaJSObject::call):
5803 (JavaJSObject::convertJObjectToValue):
5804 * bridge/jni/jni_objc.mm:
5805 (JSC::Bindings::dispatchJNICall):
5806 * bridge/jni/jni_runtime.cpp:
5807 * bridge/jni/jni_runtime.h:
5808 * bridge/jni/jni_utility.cpp:
5809 * bridge/jni/jni_utility.h:
5810 * bridge/npruntime.cpp:
5811 (_NPN_GetStringIdentifier):
5812 * bridge/objc/WebScriptObject.h:
5813 * bridge/objc/objc_class.h:
5814 * bridge/objc/objc_class.mm:
5815 * bridge/objc/objc_instance.h:
5816 * bridge/objc/objc_instance.mm:
5817 * bridge/objc/objc_runtime.h:
5818 * bridge/objc/objc_runtime.mm:
5819 * bridge/objc/objc_utility.h:
5820 * bridge/objc/objc_utility.mm:
5821 * bridge/qt/qt_class.cpp:
5822 * bridge/qt/qt_class.h:
5823 * bridge/qt/qt_instance.cpp:
5824 * bridge/qt/qt_instance.h:
5825 * bridge/qt/qt_runtime.cpp:
5826 (JSC::Bindings::convertQVariantToValue):
5827 (JSC::Bindings::):
5828 * bridge/qt/qt_runtime.h:
5829 * bridge/runtime.cpp:
5830 * bridge/runtime.h:
5831 * bridge/runtime_array.cpp:
5832 * bridge/runtime_array.h:
5833 * bridge/runtime_method.cpp:
5834 * bridge/runtime_method.h:
5835 * bridge/runtime_object.cpp:
5836 * bridge/runtime_object.h:
5837 * bridge/runtime_root.cpp:
5838 (JSC::Bindings::RootObject::invalidate):
5839 (JSC::Bindings::RootObject::gcProtect):
5840 (JSC::Bindings::RootObject::gcUnprotect):
5841 * bridge/runtime_root.h:
5842 * bridge/testbindings.cpp:
5843 * bridge/testbindings.mm:
5844 * bridge/testqtbindings.cpp:
5845 * dom/Document.cpp:
5846 (WebCore::Document::~Document):
5847 * dom/NSResolver.h:
5848 * dom/Node.cpp:
5849 (WebCore::Node::setDocument):
5850 (WebCore::ResolveNamespaceFunctor::ResolveNamespaceFunctor):
5851 (WebCore::resolveNamespacesForSelector):
5852 (WebCore::Node::querySelector):
5853 (WebCore::Node::querySelectorAll):
5854 * dom/Node.h:
5855 * dom/NodeFilter.cpp:
5856 * dom/NodeFilter.h:
5857 * dom/NodeFilterCondition.cpp:
5858 * dom/NodeFilterCondition.h:
5859 * dom/NodeIterator.cpp:
5860 * dom/NodeIterator.h:
5861 * dom/Traversal.cpp:
5862 * dom/Traversal.h:
5863 * dom/TreeWalker.cpp:
5864 * dom/TreeWalker.h:
5865 * dom/make_names.pl:
5866 * history/CachedPage.cpp:
5867 * history/CachedPage.h:
5868 * html/HTMLPlugInElement.cpp:
5869 (WebCore::HTMLPlugInElement::getInstance):
5870 * html/HTMLPlugInElement.h:
5871 * loader/FrameLoader.cpp:
5872 * loader/FrameLoader.h:
5873 * loader/icon/IconDatabase.cpp:
5874 (WebCore::iconDatabase):
5875 * page/Console.cpp:
5876 * page/Console.h:
5877 * page/InspectorController.cpp:
5878 (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
5879 (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
5880 (WebCore::InspectorResource::setXMLHttpRequestProperties):
5881 (WebCore::InspectorResource::sourceString):
5882 (WebCore::getResourceDocumentNode):
5883 (WebCore::search):
5884 (WebCore::InspectorController::focusNode):
5885 (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
5886 (WebCore::InspectorController::addDatabaseScriptResource):
5887 (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
5888 * page/InspectorController.h:
5889 (WebCore::InspectorController::profiles):
5890 * page/JavaScriptCallFrame.cpp:
5891 (WebCore::JavaScriptCallFrame::scopeChain):
5892 * page/JavaScriptCallFrame.h:
5893 (WebCore::JavaScriptCallFrame::create):
5894 (WebCore::JavaScriptCallFrame::update):
5895 * page/JavaScriptDebugListener.h:
5896 * page/JavaScriptDebugServer.cpp:
5897 (WebCore::dispatchDidParseSource):
5898 * page/JavaScriptDebugServer.h:
5899 * page/JavaScriptProfile.cpp:
5900 * page/JavaScriptProfile.h:
5901 * page/JavaScriptProfileNode.cpp:
5902 (WebCore::getTotalTime):
5903 (WebCore::getSelfTime):
5904 (WebCore::getTotalPercent):
5905 (WebCore::getSelfPercent):
5906 (WebCore::getNumberOfCalls):
5907 (WebCore::getChildren):
5908 (WebCore::getVisible):
5909 * page/JavaScriptProfileNode.h:
5910 * page/Page.cpp:
5911 (WebCore::Page::setDebuggerForAllPages):
5912 (WebCore::Page::setDebugger):
5913 * page/Page.h:
5914 (WebCore::Page::debugger):
5915 * page/mac/FrameMac.mm:
5916 * platform/KURL.h:
5917 (WebCore::KURL::operator JSC::UString):
5918 * platform/text/AtomicString.cpp:
5919 (WebCore::AtomicString::add):
5920 (WebCore::AtomicString::find):
5921 * platform/text/AtomicString.h:
5922 (WebCore::AtomicString::AtomicString):
5923 * platform/text/PlatformString.h:
5924 * platform/text/String.cpp:
5925 (WebCore::charactersToDouble):
5926 * platform/win/BString.cpp:
5927 * platform/win/BString.h:
5928 * plugins/MimeTypeArray.h:
5929 * plugins/Plugin.h:
5930 * plugins/PluginArray.h:
5931 * plugins/PluginView.cpp:
5932 (WebCore::PluginView::start):
5933 (WebCore::PluginView::performRequest):
5934 (WebCore::PluginView::bindingInstance):
5935 * plugins/PluginView.h:
5936 * plugins/gtk/PluginViewGtk.cpp:
5937 (WebCore::PluginView::paint):
5938 (WebCore::PluginView::handleKeyboardEvent):
5939 (WebCore::PluginView::handleMouseEvent):
5940 (WebCore::PluginView::setNPWindowRect):
5941 (WebCore::PluginView::stop):
5942 (WebCore::PluginView::init):
5943 * plugins/qt/PluginViewQt.cpp:
5944 (WebCore::PluginView::setNPWindowRect):
5945 (WebCore::PluginView::stop):
5946 (WebCore::PluginView::init):
5947 * plugins/win/PluginViewWin.cpp:
5948 (WebCore::PluginView::dispatchNPEvent):
5949 (WebCore::PluginView::handleKeyboardEvent):
5950 (WebCore::PluginView::handleMouseEvent):
5951 (WebCore::PluginView::setNPWindowRect):
5952 (WebCore::PluginView::stop):
5953 * storage/Database.cpp:
5954 (WebCore::Database::Database):
5955 * xml/XMLHttpRequest.cpp:
5956 (WebCore::XMLHttpRequest::responseText):
5957 (WebCore::XMLHttpRequest::loadRequestAsynchronously):
5958 (WebCore::XMLHttpRequest::clearResponse):
5959 (WebCore::XMLHttpRequest::dropProtection):
5960 (WebCore::XMLHttpRequest::didFinishLoading):
5961 (WebCore::XMLHttpRequest::didReceiveData):
5962 * xml/XMLHttpRequest.h:
5963
abarth@webkit.orge17b6052008-09-08 00:03:30 +000059642008-09-07 Adam Barth <abarth@webkit.org>
5965
5966 Reviewed by Sam Weinig.
5967
5968 Adopt opener restriction on frame navigation.
5969 https://bugs.webkit.org/show_bug.cgi?id=20642
5970
5971 This restriction helps prevent an attacker from navigating top-level
5972 windows that were created by another web site.
5973
5974 Tests: http/tests/security/frameNavigation/not-opener.html
5975 http/tests/security/frameNavigation/opener.html
5976
5977 * loader/FrameLoader.cpp:
5978 (WebCore::canAccessAncestor):
5979 (WebCore::FrameLoader::shouldAllowNavigation):
5980
mitz@apple.com83469af2008-09-07 22:29:56 +000059812008-09-07 Dan Bernstein <mitz@apple.com>
5982
mitz@apple.com08ff58c2008-09-07 23:19:11 +00005983 Reviewed by Maciej Stachowiak.
5984
5985 - use the correct sign for vertical offsets of combining marks
5986
5987 * platform/graphics/win/UniscribeController.cpp:
5988 (WebCore::UniscribeController::shapeAndPlaceItem):
5989
59902008-09-07 Dan Bernstein <mitz@apple.com>
5991
mitz@apple.com83469af2008-09-07 22:29:56 +00005992 Reviewed by Dave Hyatt.
5993
mitz@apple.com78685b22008-09-07 22:30:29 +00005994 - add the combining mark offsets in two places where I forgot them
5995
5996 * platform/graphics/win/FontCGWin.cpp:
5997 (WebCore::Font::drawGlyphs):
5998
59992008-09-07 Dan Bernstein <mitz@apple.com>
6000
6001 Reviewed by Dave Hyatt.
6002
mitz@apple.com83469af2008-09-07 22:29:56 +00006003 - correct glyph advances in complex text using web fonts rendered with
6004 Core Graphics
6005
6006 * platform/graphics/win/FontCustomPlatformData.cpp:
6007 (WebCore::FontCustomPlatformData::fontPlatformData):
6008
timothy@apple.com968ebc92008-09-07 16:48:41 +000060092008-09-07 Keishi Hattori <casey.hattori@gmail.com>
6010
6011 Adds console.dirxml support to the Web Inspector.
6012
6013 https://bugs.webkit.org/show_bug.cgi?id=19156
6014
6015 Reviewed by Timothy Hatcher.
6016
6017 * WebCore.vcproj/WebCore.vcproj: Added ElementsTreeOutline.js.
6018 * bindings/js/JSConsoleCustom.cpp:
6019 (WebCore::JSConsole::dirxml):
6020 * page/Console.cpp:
6021 (WebCore::Console::dirxml): Adds a ConsoleMessage with NodeMessageLevel.
6022 * page/Console.h:
6023 (WebCore::): Added NodeMessageLevel.
6024 * page/Console.idl: Added console.dirxml.
6025 * page/inspector/Console.js: A NodeMessage creates a ElementsTreeOutline.
6026 * page/inspector/ElementsPanel.js: Modified to use ElementsTreeOutline. The ElementsTreeOutline
6027 in the ElementsPanel has includeRootDOMNode and selectEnabled set to true.
6028 * page/inspector/ElementsTreeOutline.js: Added.
6029 (WebInspector.ElementsTreeOutline): A subclass of TreeOutline for displaying a DOM node tree.
6030 (WebInspector.ElementsTreeElement): A subclass of TreeElement for ElementsTreeOutline.
6031 * page/inspector/WebKit.qrc: Added ElementsTreeOutline.js.
6032 * page/inspector/inspector.css:
6033 * page/inspector/inspector.html: Added ElementsTreeOutline.js.
6034 * page/inspector/inspector.js: Moved hover related methods to WebInspector.
6035 (WebInspector.altKeyDown):
6036 (WebInspector.forceHoverHighlight):
6037 (WebInspector.hoveredDOMNode):
6038 (WebInspector._updateHoverHighlightSoon):
6039 (WebInspector._updateHoverHighlight):
6040 (WebInspector.documentKeyDown): Updates WebInspector.altKeyDown
6041 (WebInspector.documentKeyUp): Updates WebInspector.altKeyDown
6042 * page/inspector/utilities.js: Added getDocumentForNode, parentNodeOrFrameElement,
6043 isAncestorIncludingParentFrames.
6044
mrowe@apple.com61ba5f52008-09-07 06:08:56 +000060452008-09-06 Mark Rowe <mrowe@apple.com>
6046
6047 Qt build fix.
6048
6049 * bridge/qt/qt_runtime.cpp:
6050 (KJS::Bindings::convertQVariantToValue):
6051
mrowe@apple.comf88a4632008-09-07 05:44:58 +00006052=== End merge of squirrelfish-extreme ===
6053
60542008-09-05 Oliver Hunt <oliver@apple.com>
6055
6056 Start bringing up SFX on windows.
6057
6058 Reviewed by Mark Rowe and Sam Weinig
6059
6060 Start doing the work to bring up SFX on windows. Initially
6061 just working on WREC, as it does not make any calls so reduces
6062 the amount of code that needs to be corrected.
6063
6064 Add forwarding headers
6065
6066 * ChangeLog:
6067 * ForwardingHeaders/masm/MacroAssembler.h: Added.
6068 * WebCore.vcproj/WebCore.vcproj:
6069
60702008-08-27 Mark Rowe <mrowe@apple.com>
6071
6072 Reviewed by Oliver Hunt.
6073
6074 Fix the build of the full WebKit stack.
6075
6076 Add forwarding headers.
6077
6078 * ForwardingHeaders/masm/IA32MacroAsm.h: Added.
6079 * ForwardingHeaders/wrec/WREC.h: Added.
6080
6081=== Start merge of squirrelfish-extreme ===
6082
antti@apple.com13c24932008-09-07 03:54:21 +000060832008-09-06 Antti Koivisto <antti@apple.com>
6084
6085 Reviewed by Dave Hyatt.
6086
6087 <rdar://problem/6187043>
6088 Don't parse full HTML user agent style sheet unless it is actually needed
6089 <rdar://problem/6131889>
6090 WebView is significantly more expensive to create recently
6091
6092 Parsing the html4.css takes significant amount of time and memory (~50kb) on application
6093 startup. Some clients may never use most of the rules.
6094
6095 With this patch we use simplified UA stylesheet until we hit something it can't handle.
6096 This avoids full stylesheet parsing on application startup (due to empty document construction)
6097 and also makes it possible for clients with very simple demands (divs and spans only) never to load
6098 the full style.
6099
6100 It also delays view source style parsing until it is used.
6101
6102 * css/CSSStyleSelector.cpp:
6103 (WebCore::elementCanUseSimpleDefaultStyle):
6104 (WebCore::CSSStyleSelector::CSSStyleSelector):
6105 (WebCore::loadFullDefaultStyle):
6106 (WebCore::loadSimpleDefaultStyle):
6107 (WebCore::loadViewSourceStyle):
6108 (WebCore::CSSStyleSelector::matchUARules):
6109 (WebCore::CSSStyleSelector::styleForElement):
6110
kevino@webkit.orgd15b50f2008-09-07 03:46:50 +000061112008-09-06 Kevin Ollivier <kevino@theolliviers.com>
6112
6113 wx build fix.
6114
6115 * WebCoreSources.bkl:
6116
antti@apple.come953f862008-09-06 23:27:09 +000061172008-09-06 Antti Koivisto <antti@apple.com>
6118
antti@apple.com00dfa532008-09-06 23:32:26 +00006119 Reverting r35953 which was causing problems on Windows which relies on
6120 WebCore timers in nested event loops. r36132 did alternative fix.
6121
6122 * page/Chrome.cpp:
6123 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
6124 (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
6125
61262008-09-06 Antti Koivisto <antti@apple.com>
6127
antti@apple.come953f862008-09-06 23:27:09 +00006128 Reviewed by Dan Bernstein.
6129
6130 Fix <rdar://problem/6201644>
6131 https://bugs.webkit.org/show_bug.cgi?id=20493
6132 Crash after OK in dialog box and reloading page in secure mode
6133
6134 Limited loader only fix since the general timer fix is causing problems on Windows.
6135
6136 * loader/loader.cpp:
6137 (WebCore::Loader::servePendingRequests):
6138 (WebCore::Loader::Host::Host):
6139 (WebCore::Loader::Host::didFinishLoading):
6140 (WebCore::Loader::Host::didFail):
6141 (WebCore::Loader::Host::didReceiveData):
6142 * loader/loader.h:
6143 (WebCore::Loader::Host::processingResource):
6144
mitz@apple.com046bf642008-09-06 08:31:02 +000061452008-09-06 Dan Bernstein <mitz@apple.com>
6146
6147 Reviewed by Dave Hyatt.
6148
mitz@apple.comc0b050b2008-09-06 22:39:34 +00006149 The initial Core Text adoption prototype was made by Daniel Fenwick.
6150
6151 - <rdar://problem/5158514> Add a Core Text-based complex text code path
6152
6153 Currently the Core Text code path is not used in any configuration.
6154
6155 * WebCore.xcodeproj/project.pbxproj: Added files.
6156 * config.h: Defined WTF_USE_ATSUI and WTF_USE_CORE_TEXT.
6157 * platform/graphics/Font.cpp:
6158 (WebCore::WidthIterator::advance): Moved the spacingDisabled() test out
6159 of the loop.
6160 * platform/graphics/GlyphBuffer.h:
6161 (WebCore::GlyphBuffer::add): Added this version that takes an advance.
6162 * platform/graphics/SimpleFontData.h: Added ATSUI and CORE_TEXT #ifdefs.
6163 Added getCTFont() and getCFStringAttributes() and corresponding data
6164 members for Core Text.
6165 * platform/graphics/mac/CoreTextController.cpp: Added.
6166 (WebCore::roundCGFloat): Helper function.
6167 (WebCore::ceilCGFloat): Helper function.
6168 (WebCore::CoreTextController::CoreTextRun::CoreTextRun):
6169 (WebCore::CoreTextController::CoreTextController):
6170 (WebCore::CoreTextController::offsetForPosition):
6171 (WebCore::CoreTextController::collectCoreTextRuns): Added. Segments the
6172 run into subruns as necessary such that each subrun can be rendered with
6173 a single font. Also separates out soft hyphens and replaces them with
6174 real hyphens, because Core Text does not emit a glyph for soft hyphens.
6175 Then calls collectCoreTextRunsForCharacters() on each subrun.
6176 (WebCore::CoreTextController::advance):
6177 (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Creates
6178 a CTLine from the given subrun and collects its CoreTextRuns.
6179 (WebCore::CoreTextController::adjustGlyphsAndAdvances): Applies the
6180 rounding hacks, letter- and word-spacing and glyph substitutions and
6181 stores the resulting adjusted glyphs and advances.
6182 * platform/graphics/mac/CoreTextController.h: Copied from WebCore/platform/graphics/win/UniscribeController.h.
6183 (WebCore::CoreTextController::totalWidth):
6184 (WebCore::CoreTextController::finalRoundingWidth):
6185 (WebCore::CoreTextController::CoreTextRun::ctRun):
6186 (WebCore::CoreTextController::CoreTextRun::glyphCount):
6187 (WebCore::CoreTextController::CoreTextRun::fontData):
6188 (WebCore::CoreTextController::CoreTextRun::characters):
6189 (WebCore::CoreTextController::CoreTextRun::stringLocation):
6190 (WebCore::CoreTextController::CoreTextRun::stringLength):
6191 (WebCore::CoreTextController::CoreTextRun::indexAt):
6192 * platform/graphics/mac/FontMac.mm: Moved the ATSUI-specific parts to
6193 FontMacATSUI.mm.
6194 * platform/graphics/mac/FontMacATSUI.mm: Copied from WebCore/platform/graphics/mac/FontMac.mm.
6195 (WebCore::disableLigatures): Changed to call
6196 FontPlatformData::allowsLigatures().
6197 (WebCore::overrideLayoutOperation): Changed to call
6198 FontPlatformData::roundsGlyphAdvances().
6199 * platform/graphics/mac/FontMacCoreText.cpp: Copied from WebCore/platform/graphics/win/FontWin.cpp.
6200 (WebCore::Font::selectionRectForComplexText): Changed to use
6201 totalWidth() instead of advancing to the end and using runWidthSoFar().
6202 (WebCore::Font::drawComplexText):
6203 (WebCore::Font::floatWidthForComplexText): Ditto.
6204 (WebCore::Font::offsetForPositionForComplexText):
6205 * platform/graphics/mac/FontPlatformData.h:
6206 * platform/graphics/mac/FontPlatformDataMac.mm:
6207 (WebCore::FontPlatformData::setFont):
6208 (WebCore::FontPlatformData::roundsGlyphAdvances): Added. Checks the
6209 AppKit rendering mode.
6210 (WebCore::FontPlatformData::allowsLigatures): Added. Implements the
6211 heuristic that allows ligatures in fonts that do not have a glyph for
6212 'a', based on the assumption that such fonts are only used in complex
6213 text.
6214 * platform/graphics/mac/SimpleFontDataMac.mm:
6215 (WebCore::SimpleFontData::platformInit):
6216 (WebCore::SimpleFontData::platformDestroy):
6217 (WebCore::SimpleFontData::getCTFont): Added.
6218 (WebCore::SimpleFontData::getCFStringAttributes): Added. Caches and
6219 returns an attributes dictionary.
6220 * platform/text/mac/ShapeArabic.c: Added ATSUI #ifdefs.
6221 * platform/text/mac/ShapeArabic.h: Ditto.
6222
62232008-09-06 Dan Bernstein <mitz@apple.com>
6224
6225 Reviewed by Dave Hyatt.
6226
mitz@apple.com046bf642008-09-06 08:31:02 +00006227 - make combining mark offsets work in CG text on Windows
6228
6229 * platform/graphics/win/FontCGWin.cpp:
6230 (WebCore::Font::drawGlyphs): The old code tried to translate the text
6231 matrix, but failed for two reasons: it did not actually change the
6232 matrix, and even if it did, CGContextSetTextPosition overwrites the
6233 translation values in the text matrix. Instead, just added the
6234 translation to the anchor point.
6235
alp@webkit.org369cdca2008-09-06 04:08:30 +000062362008-09-05 Gustavo Noronha Silva <gns@gnome.org>
6237
6238 Reviewed by Alp Toker.
6239
6240 https://bugs.webkit.org/show_bug.cgi?id=18346
6241 [GTK] Remove build warnings
6242
6243 Applied some casts, and removed an unused typedef to make the
6244 compiler happy, printing less warnings when building.
6245
6246 * page/gtk/AccessibilityObjectWrapperAtk.cpp:
6247 * platform/graphics/gtk/SimpleFontDataPango.cpp:
6248 (WebCore::SimpleFontData::containsCharacters):
6249 * platform/graphics/gtk/VideoSinkGStreamer.cpp:
6250 (webkit_video_sink_set_caps):
6251 * platform/network/soup/ResourceHandleSoup.cpp:
6252
eric@webkit.org3cb292c2008-09-05 22:17:56 +000062532008-09-05 Eric Seidel <eric@webkit.org>
6254
eric@webkit.org5ac37902008-09-06 00:21:58 +00006255 Reviewed by Adam Roben.
6256
6257 Build fix for WebKitWin and Chromium
6258
6259 * platform/FileSystem.h:
6260
62612008-09-05 Eric Seidel <eric@webkit.org>
6262
eric@webkit.org3cb292c2008-09-05 22:17:56 +00006263 Reviewed by Darin Adler.
6264
6265 Try to make Chromium compile with ToT:
6266 - Wrap a few places which depend on KJS:: in #if USE(JSC)
6267 - Include some windows forward declarations
6268
6269 * dom/Node.h:
6270 * page/Console.h:
6271 * page/animation/CompositeAnimation.h:
6272 * platform/FileSystem.h:
6273 * platform/graphics/Image.h:
6274 * platform/text/AtomicString.h:
6275 * platform/text/String.cpp:
6276 * rendering/style/RenderStyle.h:
6277
hyatt@apple.comff85d5e2008-09-05 21:52:08 +000062782008-09-05 Dave Hyatt <hyatt@apple.com>
6279
6280 Add support for runtime switchability of the Aqua look and the native look on Windows.
6281 Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set.
6282
6283 Reviewed by Adam Roben
6284
6285 * WebCore.vcproj/WebCore.vcproj:
6286 * page/Settings.cpp:
6287 (WebCore::Settings::setShouldPaintNativeControls):
6288 * page/Settings.h:
6289 (WebCore::Settings::shouldPaintNativeControls):
6290 * rendering/RenderThemeSafari.cpp:
6291 (WebCore::theme):
6292 * rendering/RenderThemeWin.cpp:
6293
antti@apple.combced97f2008-09-05 18:52:05 +000062942008-09-05 Antti Koivisto <antti@apple.com>
6295
6296 Qt build fix.
6297
6298 * svg/SVGFEImageElement.cpp:
6299 (WebCore::SVGFEImageElement::build):
6300
aroben@apple.comca0c3362008-09-05 15:33:28 +000063012008-09-05 Dirk Schulze <vbs85@gmx.de>
6302
6303 Gtk build fix
6304
6305 * GNUmakefile.am:
6306
antti@apple.com72e4a842008-09-05 09:28:11 +000063072008-09-05 Antti Koivisto <antti@apple.com>
6308
antti@apple.com49e46662008-09-05 10:36:59 +00006309 Another build fix.
6310
6311 * svg/SVGFEImageElement.cpp:
6312 (WebCore::SVGFEImageElement::notifyFinished):
6313
63142008-09-05 Antti Koivisto <antti@apple.com>
6315
antti@apple.comfeec2582008-09-05 10:03:39 +00006316 Build fixes.
6317
6318 * WebCore.xcodeproj/project.pbxproj:
6319 * svg/graphics/filters/SVGFEImage.cpp:
6320 (WebCore::FEImage::cachedImage):
6321
63222008-09-05 Antti Koivisto <antti@apple.com>
6323
darin@apple.com07c80c62008-09-05 18:15:43 +00006324 Reviewed by Darin Adler.
antti@apple.com72e4a842008-09-05 09:28:11 +00006325
6326 Most of the implementation for https://bugs.webkit.org/show_bug.cgi?id=17998
6327 When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation"
6328
6329 Implement HTTP 1.1 "Specific end-to-end revalidation" for WebCore memory cache. This patch does
6330 not yet enable it for the biggest use case, reloading. However it is good for general browsing as
6331 well. Doing this in WebCore level as opposed to relying on disk cache has big benefit that
6332 we avoid re-decoding resources, especially images.
6333
6334 To be exact the enabled case is not actually the "Specific end-to-end revalidation" since it does not include
6335 CacheControl: max-age=0 header. That would be added in reload case.
6336
6337 The approach for revalidation is to kick the original resource out from the memory cache
6338 and create a new CachedResource that represents the revalidation request. In case
6339 we get 304 back for the request we put the original resource back to the cache, update
6340 its expiration date and switch the clients registered to revalidation resource to be
6341 clients of the original resource.
6342
6343 All heap allocated CachedImage pointers now use CachedResourceHandle<CachedImage> (and so on) instead.
6344 This allows updating the handles to point to the original resource when the revalidation succeeds. It
6345 also acts as refcounting smart pointer.
6346
6347 * WebCore.pro:
6348 * WebCore.vcproj/WebCore.vcproj:
6349 * WebCore.xcodeproj/project.pbxproj:
6350 * css/CSSFontFaceSource.h:
6351 * css/CSSImportRule.h:
6352 * dom/Clipboard.h:
6353 (WebCore::Clipboard::dragImage):
6354 * dom/ProcessingInstruction.h:
6355 * dom/ScriptElement.h:
6356 * dom/XMLTokenizer.cpp:
6357 (WebCore::XMLTokenizer::isWaitingForScripts):
6358 * dom/XMLTokenizer.h:
6359 * html/HTMLImageLoader.cpp:
6360 (WebCore::HTMLImageLoader::setImage):
6361 (WebCore::HTMLImageLoader::updateFromElement):
6362 (WebCore::HTMLImageLoader::notifyFinished):
6363 * html/HTMLImageLoader.h:
6364 (WebCore::HTMLImageLoader::image):
6365 * html/HTMLLinkElement.h:
6366 * html/HTMLTokenizer.cpp:
6367 (WebCore::HTMLTokenizer::reset):
6368 (WebCore::HTMLTokenizer::scriptHandler):
6369 (WebCore::HTMLTokenizer::notifyFinished):
6370 * html/HTMLTokenizer.h:
6371 * loader/Cache.cpp:
6372 (WebCore::Cache::revalidateResource):
6373 (WebCore::Cache::revalidationSucceeded):
6374 (WebCore::Cache::revalidationFailed):
6375 * loader/Cache.h:
6376 * loader/CachedResource.cpp:
6377 (WebCore::CachedResource::CachedResource):
6378 (WebCore::CachedResource::~CachedResource):
6379 (WebCore::CachedResource::isExpired):
6380 (WebCore::CachedResource::setResponse):
6381 (WebCore::CachedResource::deleteIfPossible):
6382 (WebCore::CachedResource::setResourceToRevalidate):
6383 (WebCore::CachedResource::clearResourceToRevalidate):
6384 (WebCore::CachedResource::switchClientsToRevalidatedResource):
6385 (WebCore::CachedResource::canUseCacheValidator):
6386 (WebCore::CachedResource::mustRevalidate):
6387 * loader/CachedResource.h:
6388 (WebCore::CachedResource::canDelete):
6389 (WebCore::CachedResource::registerHandle):
6390 (WebCore::CachedResource::unregisterHandle):
6391 (WebCore::CachedResource::isCacheValidator):
6392 (WebCore::CachedResource::resourceToRevalidate):
6393 (WebCore::CachedResource::setExpirationDate):
6394 * loader/CachedResourceHandle.cpp: Added.
6395 (WebCore::CachedResourceHandleBase::setResource):
6396 * loader/CachedResourceHandle.h: Added.
6397 (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
6398 (WebCore::CachedResourceHandleBase::get):
6399 (WebCore::CachedResourceHandleBase::operator!):
6400 (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
6401 (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
6402 (WebCore::CachedResourceHandleBase::operator=):
6403 (WebCore::CachedResourceHandle::CachedResourceHandle):
6404 (WebCore::CachedResourceHandle::get):
6405 (WebCore::CachedResourceHandle::operator->):
6406 (WebCore::CachedResourceHandle::operator=):
6407 (WebCore::CachedResourceHandle::operator==):
6408 (WebCore::CachedResourceHandle::operator!=):
6409 (WebCore::operator==):
6410 (WebCore::operator!=):
6411 * loader/DocLoader.cpp:
6412 (WebCore::DocLoader::checkForReload):
6413 * loader/UserStyleSheetLoader.h:
6414 * loader/loader.cpp:
6415 (WebCore::Loader::Host::servePendingRequests):
6416 (WebCore::Loader::Host::didFinishLoading):
6417 (WebCore::Loader::Host::didFail):
6418 (WebCore::Loader::Host::didReceiveResponse):
6419 (WebCore::Loader::Host::didReceiveData):
6420 * page/EventHandler.cpp:
6421 (WebCore::EventHandler::selectCursor):
6422 * rendering/RenderImage.cpp:
6423 (WebCore::RenderImage::setCachedImage):
6424 (WebCore::RenderImage::imageChanged):
6425 * rendering/RenderImage.h:
6426 (WebCore::RenderImage::cachedImage):
6427 (WebCore::RenderImage::imagePtr):
6428 * rendering/style/RenderStyle.h:
6429 * rendering/style/StyleCachedImage.h:
6430 (WebCore::StyleCachedImage::data):
6431 (WebCore::StyleCachedImage::cachedImage):
6432 * svg/SVGFEImageElement.h:
6433 * svg/graphics/filters/SVGFEImage.h:
6434 * xml/XSLImportRule.h:
6435
beidson@apple.comab60d982008-09-05 04:58:12 +000064362008-09-04 Brady Eidson <beidson@apple.com>
6437
6438 Reviewed by Mitz
6439
6440 <rdar://problem/6180236> - Safari times out connections after 1 or 2 minutes
6441
6442 A 60-second default timeout was added in http://trac.webkit.org/changeset/17144 in an attempt
6443 to model default NSURLRequest behavior in a cross-platform manner.
6444
6445 Sadly by always enforcing this 60 second timeout, WebCore was stomping over the wishes of any Webkit
6446 client that wished to enforce a much larger default timeout using NSURLRequest API.
6447
6448 Additionally, upon reviewing what all other browsers do, it seems apparent that "no limit" is desirable
6449 behavior on the web and this restores previous Safari/WebKit behavior.
6450
6451 It would be easy to write a layout test for this, but to be effective it would have
6452 to run for at least 61 seconds, which seems insane until will can parallelize run-webkit-tests
6453
6454 * manual-tests/timeout-test.html: Added.
6455 * manual-tests/timeout-test.php: Added.
6456
6457 * platform/network/ResourceRequestBase.h:
6458 (WebCore::ResourceRequestBase::ResourceRequestBase): Rename the constant to "unspecifiedTimeoutInterval"
6459 and make it UINT_MAX so platforms that do set it have an effective "no timeout." (Windows, for example)
6460 * platform/network/mac/ResourceRequestMac.mm:
6461 (WebCore::ResourceRequest::doUpdatePlatformRequest): If the timeout for this request is
6462 "unspecifiedTimeoutInterval", then don't bother setting the timeout using NSURLRequest API, allowing
6463 WebKit applications to enforce their own default timeout.
6464
mitz@apple.com20268542008-09-05 04:26:32 +000064652008-09-04 Dan Bernstein <mitz@apple.com>
6466
6467 Reviewed by Beth Dakin.
6468
6469 - fix <rdar://problem/6198514> Changing a button's opacity triggers relayout
6470
6471 Test: fast/repaint/button-spurious-layout-hint.html
6472
6473 * rendering/RenderButton.cpp:
6474 (WebCore::RenderButton::setStyle): Reset the inner block's style box
6475 flex to 0 to avoid getting a spurious layout hint.
6476
kevino@webkit.org3e8c4072008-09-04 23:53:04 +000064772008-09-04 Kevin Ollivier <kevino@theolliviers.com>
6478
6479 wx build fixes.
6480
6481 * WebCoreSources.bkl:
6482 * bindings/js/ScriptControllerWx.cpp: Added.
6483 (WebCore::ScriptController::createScriptInstanceForWidget):
6484 * page/wx/AccessibilityObjectWx.cpp: Added.
6485 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
6486 * platform/graphics/wx/GraphicsContextWx.cpp:
6487 * webcore-base.bkl:
6488 * webcore-wx.bkl:
6489
mitz@apple.com95a87502008-09-04 23:27:19 +000064902008-09-04 Dan Bernstein <mitz@apple.com>
6491
6492 Reviewed by Mark Rowe.
6493
6494 - roll out r36050 because it made svg/custom/invalid-fill-hex.svg fail,
6495 and fixing https://bugs.webkit.org/show_bug.cgi?id=15360 appears to
6496 require a different approach
6497
6498 * css/CSSGrammar.y:
6499
mrowe@apple.com12b7c2d2008-09-04 21:00:02 +000065002008-09-04 Mark Rowe <mrowe@apple.com>
6501
mrowe@apple.com5bc4ea82008-09-04 21:44:28 +00006502 Reviewed by Eric Seidel.
6503
6504 Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
6505 Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
6506
6507 * Configurations/WebCore.xcconfig: Remove ENABLE_DASHBOARD_SUPPORT from FEATURE_DEFINES.
6508 * DerivedSources.make: Revert to checking for ENABLE_DASHBOARD_SUPPORT rather than looking
6509 for ENABLE_DASHBOARD_SUPPORT in FEATURE_DEFINES.
6510
65112008-09-04 Mark Rowe <mrowe@apple.com>
6512
mrowe@apple.com12b7c2d2008-09-04 21:00:02 +00006513 Mac build fix.
6514
6515 * config.h: Only check the value of HAVE_CONFIG_H if it is defined.
6516
eric@webkit.org0716a542008-09-04 20:44:12 +000065172008-09-04 Eric Seidel <eric@webkit.org>
6518
6519 Build fix only, no review.
6520
6521 * dom/XMLTokenizer.cpp: Fix the Chromium merge build by adding a missing header (the Mac files must include it somewhere).
6522
jmalonzo@webkit.org6afc5d42008-09-04 20:26:16 +000065232008-09-04 Marco Barisione <marco.barisione@collabora.co.uk>
6524
6525 Reviewed by Eric Seidel.
6526
6527 http://bugs.webkit.org/show_bug.cgi?id=20380
6528 [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h
6529
6530 * config.h: Include the configuration header generated by autotools if
6531 available.
6532
mitz@apple.com9d7e4262008-09-04 18:15:25 +000065332008-09-04 Dan Bernstein <mitz@apple.com>
6534
6535 Rubber-stamped by Dave Hyatt.
6536
6537 - rename CachedResource::allReferencesRemoved() to allClientsRemoved()
6538
6539 * loader/CachedFont.cpp:
6540 (WebCore::CachedFont::allClientsRemoved):
6541 * loader/CachedFont.h:
6542 * loader/CachedImage.cpp:
6543 (WebCore::CachedImage::allClientsRemoved):
6544 * loader/CachedImage.h:
6545 * loader/CachedResource.cpp:
6546 (WebCore::CachedResource::removeClient):
6547 * loader/CachedResource.h:
6548 (WebCore::CachedResource::allClientsRemoved):
6549
aroben@apple.com0da404d2008-09-04 16:09:33 +000065502008-09-04 Adam Roben <aroben@apple.com>
6551
aroben@apple.comdd3861a2008-09-04 16:09:53 +00006552 Windows build fix after r36071
6553
6554 We were getting these errors:
6555
6556 error C2356: initialization segment must not change during translation
6557 unit
6558
6559 This was happening because multiple files #included by
6560 DerivedSources.cpp were themselves #including StaticConstructors.h. I
6561 fixed the error by adding header guards to StaticConstructors.h so its
6562 contents will only be included once.
6563
6564 But it's also not a good idea for StaticConstructors.h to end up in
6565 DerivedSources.cpp, since it ends up "polluting" all the source files
6566 we have in there. So I removed all the files that include
6567 StaticConstructors.h and added some preprocessor directives to
6568 DerivedSources.cpp to catch this error in the future.
6569
6570 * DerivedSources.cpp: Removed the *Names.cpp files, which include
6571 StaticConstructors.h, and added some preprocessor directives to make
6572 sure we don't end up accidentally including StaticConstructors.h in
6573 the future.
6574 * WebCore.vcproj/WebCore.vcproj: Added the *Names.cpp files.
6575 * platform/StaticConstructors.h: Added header guards.
6576
65772008-09-04 Adam Roben <aroben@apple.com>
6578
aroben@apple.com0da404d2008-09-04 16:09:33 +00006579 Windows build fix
6580
6581 * platform/graphics/win/FontPlatformData.h: Added a missing #include
6582 of PassRefPtr.h, and corrected the capitalization of RefCounted.h.
6583 * platform/text/PlatformString.h: Added a missing #include of
6584 PassRefPtr.h.
6585
vestbo@webkit.orgc0aeddf2008-09-04 11:44:17 +000065862008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
6587
6588 Reviewed by Simon.
6589
vestbo@webkit.orgb82da912008-09-04 14:24:58 +00006590 Fix the QtWebKit build to match changes in r36016
6591
6592 * WebCore.pro:
6593 * bridge/qt/qt_instance.cpp:
6594 (KJS::Bindings::QtInstance::getRuntimeObject):
6595 * bridge/qt/qt_runtime.cpp:
6596 (KJS::Bindings::convertQVariantToValue):
6597 (KJS::Bindings::QtConnectionObject::execute):
6598
65992008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
6600
6601 Reviewed by Simon.
6602
vestbo@webkit.orgc0aeddf2008-09-04 11:44:17 +00006603 Re-enable support for user stylesheets in QtWebKit
6604
6605 QtWebKit now follows the FRAME_LOADS_USER_STYLESHEET
6606 code path, which allows us to keep API support for
6607 loading user style sheets from remote URLs.
6608
6609 As part of the change UserStyleSheetLoader.cpp/h was
6610 moved from WebCore/loader/mac to WebCore/loader.
6611
6612 * WebCore.pro:
6613 * WebCore.xcodeproj/project.pbxproj:
6614 * dom/Document.h:
6615 * loader/UserStyleSheetLoader.cpp: Renamed from WebCore/loader/mac/UserStyleSheetLoader.cpp.
6616 (UserStyleSheetLoader::UserStyleSheetLoader):
6617 (UserStyleSheetLoader::~UserStyleSheetLoader):
6618 * loader/UserStyleSheetLoader.h: Renamed from WebCore/loader/mac/UserStyleSheetLoader.h.
6619 * page/qt/FrameQt.cpp:
6620 (WebCore::Frame::setUserStyleSheetLocation):
6621 (WebCore::Frame::setUserStyleSheet):
6622
alp@webkit.org539ff852008-09-04 09:14:42 +000066232008-09-04 Alp Toker <alp@nuanti.com>
6624
6625 Reviewed by Eric.
6626
6627 Remove left-over QT and CAIRO platform checks.
6628
6629 * html/CanvasRenderingContext2D.cpp:
6630
eric@webkit.orgbc0aab82008-09-04 08:39:51 +000066312008-09-04 Eric Seidel <eric@webkit.org>
6632
6633 Reviewed by Mark Rowe.
6634
mitz@apple.com9388d252008-09-04 08:58:58 +00006635 Fix leak of TextMetrics due to over-ref as see on buildbot.
eric@webkit.orgbc0aab82008-09-04 08:39:51 +00006636
6637 * html/TextMetrics.h: use adoptRef since RefCounted starts @ refcount 1 instead of 0 now.
6638
mitz@apple.com89557c52008-09-04 07:26:53 +000066392008-09-04 Dan Bernstein <mitz@apple.com>
6640
6641 Reviewed by Dave Hyatt.
6642
6643 - fix https://bugs.webkit.org/show_bug.cgi?id=19717
6644 <rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist
6645
6646 * rendering/RenderBlock.cpp:
6647 (WebCore::RenderBlock::layoutOnlyPositionedObjects): In the
6648 positioned movement only case, call
6649 tryLayoutDoingPositionedMovementOnly() and fall back on doing a full
6650 layout if that fails.
6651 (WebCore::RenderBlock::layoutPositionedObjects): Ditto.
6652 * rendering/RenderBox.h:
6653 (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): Renamed
6654 layoutDoingPositionedMovementOnly to this, and made this function
6655 check if the width changed. If it did, return, leaving the object
6656 dirty. The caller can then call layout(). The width can change even
6657 in the "positioned movement only" case if the object is shrink-to-fit
6658 and the available width constraint is met. (This was the case in the
6659 bug).
6660 * rendering/RenderObject.h:
6661 (WebCore::RenderObject::tryLayoutDoingPositionedMovementOnly):
6662 Renamed layoutDoingPositionedMovementOnly() to this.
6663
eric@webkit.org8883b4a2008-09-04 06:31:37 +000066642008-09-03 Eric Seidel <eric@webkit.org>
6665
6666 No review, build fix only.
6667
6668 Attempt to fix the Qt build.
6669
6670 * WebCore.pro: add page/animation to include path
6671
mrowe@apple.comaa4bb8d2008-09-04 03:20:30 +000066722008-09-03 Mark Rowe <mrowe@apple.com>
6673
6674 Mac build fix. Correctly detect whether dashboard support is enabled.
6675
6676 * DerivedSources.make:
6677
eric@webkit.org3eefe672008-09-04 01:32:26 +000066782008-09-03 Eric Seidel <eric@webkit.org>
6679
6680 Reviewed by Sam.
6681
eric@webkit.org5e069092008-09-04 01:32:51 +00006682 Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)
6683
6684 * Configurations/WebCore.xcconfig: add missing ENABLE_*
6685 * config.h: add rules for V8_BINDINGS
6686
66872008-09-03 Eric Seidel <eric@webkit.org>
6688
6689 Reviewed by Sam.
6690
eric@webkit.org3eefe672008-09-04 01:32:26 +00006691 https://bugs.webkit.org/show_bug.cgi?id=20620
6692
6693 Add #if USE(JSC) around KJS dependencies
6694 Remove !USE(JAVASCRIPTCORE_BINDINGS) support for 3 reasons:
6695 1. Most platforms have it on anyway
6696 2. V8 is going to want to share some of that code
6697 3. Those platforms which want it off, should have a separate file instead of an #ifdef in our .cpp
6698
6699 * bindings/js/JSPluginElementFunctions.cpp: remove !USE(JAVASCRIPTCORE_BINDINGS) support
6700 * config.h: change JAVASCRIPTCORE_BINDINGS to JSC and add USE(V8)
6701 * html/HTMLAppletElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
6702 * html/HTMLAppletElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
6703 * html/HTMLEmbedElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
6704 * html/HTMLEmbedElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
6705 * html/HTMLObjectElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
6706 * html/HTMLObjectElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
6707 * html/HTMLPlugInElement.cpp: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
6708 * html/HTMLPlugInElement.h: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
6709 * platform/text/AtomicString.cpp: add USE(JSC)
6710 * platform/text/AtomicString.h: add USE(JSC)
6711 * platform/text/PlatformString.h: add USE(JSC)
6712 * platform/text/String.cpp: add USE(JSC)
6713 * platform/text/StringImpl.cpp: add USE(JSC)
6714 * platform/text/StringImpl.h: add USE(JSC)
6715
mrowe@apple.comfbe724c2008-09-03 23:46:54 +000067162008-09-03 Dean McNamee <deanm@chromium.org>
6717
6718 Reviewed by Darin Adler.
6719
6720 Fix https://bugs.webkit.org/show_bug.cgi?id=20511
6721 Bug 20511: Remove static initializers on Windows
6722
6723 Avoid static initializers on Windows by forcing Visual C++ to put
6724 all static initializers in a code segment that is never executed.
6725
6726 * config.h:
6727 * css/MediaFeatureNames.cpp:
6728 * dom/EventNames.cpp:
6729 * dom/QualifiedName.cpp:
6730 * dom/make_names.pl:
6731 * platform/StaticConstructors.h:
6732 * platform/text/AtomicString.cpp:
6733
mrowe@apple.com3aa63182008-09-03 23:40:49 +000067342008-09-03 Dirk Schulze <vbs85@gmx.de>
6735
6736 Reviewed by Dave Hyatt.
6737
6738 Make FontCairo draw TextStroke and TextFill separately.
6739
6740 [CAIRO] draw TextFill and TextStroke separately.
6741 [https://bugs.webkit.org/show_bug.cgi?id=20631]
6742
6743 * platform/graphics/cairo/FontCairo.cpp:
6744 (WebCore::Font::drawGlyphs):
6745
eric@webkit.org4ac94e62008-09-18 23:07:55 +000067462008-09-03 Peter Kasting <pkasting@google.com>
mrowe@apple.comdcd72b72008-09-03 23:34:40 +00006747
6748 Reviewed by Dave Hyatt.
6749
6750 https://bugs.webkit.org/show_bug.cgi?id=19663
6751 Account for paint and timer lag when animating images. Also pretend
6752 that images whose animations were paused (by becoming invisible)
6753 continued to animate, by "catching up" to the correct frame when they're
6754 shown again.
6755
6756 * platform/graphics/BitmapImage.cpp:
6757 (WebCore::BitmapImage::BitmapImage):
6758 (WebCore::BitmapImage::startAnimation):
6759 (WebCore::BitmapImage::advanceAnimation):
6760 (WebCore::BitmapImage::internalAdvanceAnimation):
6761 (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
6762 * platform/graphics/BitmapImage.h:
6763 * platform/graphics/cairo/ImageCairo.cpp:
6764 (WebCore::BitmapImage::draw):
6765 * platform/graphics/cg/ImageCG.cpp:
6766 (WebCore::BitmapImage::draw):
6767 * platform/graphics/qt/ImageQt.cpp:
6768 (WebCore::BitmapImage::draw):
6769 * platform/graphics/wx/ImageWx.cpp:
6770 (WebCore::BitmapImage::draw):
6771
kmccullough@apple.comb0f4c622008-09-03 21:53:17 +000067722008-09-03 Kevin McCullough <kmccullough@apple.com>
6773
6774 Reviewed by Tim.
6775
6776 Remove the rest of the "zombie" code from the profiler.
6777 - There is no longer a need for the ProfilerClient callback mechanism.
6778
6779 * page/Console.cpp:
6780 (WebCore::Console::Console):
6781 (WebCore::Console::profile):
6782 (WebCore::Console::profileEnd): Move the variables from the header to
6783 here since we don't have to wait for a callback to use them.
6784 * page/Console.h:
6785 * page/InspectorController.cpp:
6786 (WebCore::InspectorController::startUserInitiatedProfiling):
6787 (WebCore::InspectorController::stopUserInitiatedProfiling):
6788 * page/InspectorController.h:
6789
adachan@apple.com38c66182008-09-03 21:43:44 +000067902008-09-03 Ada Chan <adachan@apple.com>
6791
6792 Windows build fix.
6793
6794 * WebCore.vcproj/WebCore.vcproj: Added JSWebKitCSSKeyframeRule.cpp and JSWebKitCSSKeyframesRule.cpp to the project.
6795
dino@apple.com5c917622008-09-03 21:15:53 +000067962008-09-01 Dean Jackson <dino@apple.com>
6797
6798 Reviewed by Dave Hyatt.
6799
6800 https://bugs.webkit.org/show_bug.cgi?id=20594
6801 Add DOM interfaces for WebKitCSSKeyframeRule
6802 and WebKitCSSKeyframesRule.
6803
6804 TEST: LayoutTests/css3/keyframes-rule.html
6805
6806 * css/WebKitCSSKeyframeRule.idl: Added
6807 * css/WebKitCSSKeyframesRule.idl: Added
6808
6809 * bindings/js/JSCSSRuleCustom.cpp:
6810 (WebCore::toJS):
6811 Add return of new JS Keyframe rules
6812 * bindings/objc/DOMInternal.h:
6813 Include new internal header
6814
6815 * DerivedSources.make:
6816 * GNUmakefile.am:
6817 * WebCore.pro:
6818 * WebCore.vcproj/WebCore.vcproj:
6819 * WebCore.xcodeproj/project.pbxproj:
6820 * WebCoreSources.bkl:
6821 Build configs for new files
6822
aroben@apple.com1f51bfa2008-09-03 20:30:59 +000068232008-09-03 Adam Roben <aroben@apple.com>
6824
6825 Windows build fix
6826
6827 * DerivedSources.cpp: Add JSTextMetrics.cpp to fix the build.
6828 * WebCore.vcproj/WebCore.vcproj: Add JSTextMetrics.h for
6829 convenience/consistency.
6830
adele@apple.com27713582008-09-03 20:13:41 +000068312008-09-03 Adele Peterson <adele@apple.com>
6832
6833 Build fix.
6834
6835 * WebCore.vcproj/WebCore.vcproj:
6836
hyatt@apple.com4b38ed82008-09-03 18:32:05 +000068372008-09-03 David Hyatt <hyatt@apple.com>
6838
6839 Fix for bug 18203, right floats should be allowed to overflow past the left border edge.
6840
6841 Reviewed by Darin (ages ago)
6842
6843 Added fast/block/float/clamped-right-float.html
6844
6845 * rendering/RenderBlock.cpp:
6846 (WebCore::RenderBlock::positionNewFloats):
6847
hyatt@apple.comafe62052008-09-03 18:13:39 +000068482008-09-02 David Hyatt <hyatt@apple.com>
6849
6850 Add support for canvas text drawing APIs.
6851
6852 Reviewed by olliej
6853
6854 Tests added as fast/canvas/canvas-text-*.html
6855
6856 * DerivedSources.make:
6857 * WebCore.xcodeproj/project.pbxproj:
6858 * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
6859 (WebCore::JSCanvasRenderingContext2D::fillText):
6860 (WebCore::JSCanvasRenderingContext2D::strokeText):
6861 * css/CSSStyleSelector.cpp:
6862 (WebCore::CSSStyleSelector::initForStyleResolve):
6863 (WebCore::CSSStyleSelector::applyPropertyToStyle):
6864 * css/CSSStyleSelector.h:
6865 * html/CanvasRenderingContext2D.cpp:
6866 (WebCore::CanvasRenderingContext2D::State::State):
6867 (WebCore::CanvasRenderingContext2D::font):
6868 (WebCore::CanvasRenderingContext2D::setFont):
6869 (WebCore::CanvasRenderingContext2D::textAlign):
6870 (WebCore::CanvasRenderingContext2D::setTextAlign):
6871 (WebCore::CanvasRenderingContext2D::textBaseline):
6872 (WebCore::CanvasRenderingContext2D::setTextBaseline):
6873 (WebCore::CanvasRenderingContext2D::fillText):
6874 (WebCore::CanvasRenderingContext2D::strokeText):
6875 (WebCore::CanvasRenderingContext2D::measureText):
6876 (WebCore::CanvasRenderingContext2D::drawTextInternal):
6877 (WebCore::CanvasRenderingContext2D::accessFont):
6878 * html/CanvasRenderingContext2D.h:
6879 * html/CanvasRenderingContext2D.idl:
6880 * html/TextMetrics.h: Added.
6881 (WebCore::TextMetrics::create):
6882 (WebCore::TextMetrics::width):
6883 (WebCore::TextMetrics::setWidth):
6884 (WebCore::TextMetrics::TextMetrics):
6885 * html/TextMetrics.idl: Added.
6886 * platform/graphics/Font.cpp:
6887 (WebCore::Font::lineGap):
6888 * platform/graphics/Font.h:
6889 * platform/graphics/GraphicsContext.cpp:
6890 (WebCore::GraphicsContext::drawBidiText):
6891 * platform/graphics/GraphicsContext.h:
6892 * platform/graphics/GraphicsTypes.cpp:
6893 (WebCore::textAlignName):
6894 (WebCore::parseTextAlign):
6895 (WebCore::textBaselineName):
6896 (WebCore::parseTextBaseline):
6897 * platform/graphics/GraphicsTypes.h:
6898 (WebCore::):
6899
sullivan@apple.combc066af2008-09-03 17:37:24 +000069002008-09-03 John Sullivan <sullivan@apple.com>
6901
6902 Fixed <rdar://problem/6193022> <rdar://problem/6193022> Crash occurs at WebCore::AnimationBase::propertiesEqual () after certain steps
6903
6904 Fixed by Darin, reviewed by me
6905
6906 * page/animation/AnimationBase.cpp:
6907 (WebCore::AnimationBase::propertiesEqual):
6908 added ensurePropertyMap() to this static function
6909 (WebCore::AnimationBase::getPropertyAtIndex):
6910 ditto
6911 (WebCore::AnimationBase::getNumProperties):
6912 ditto
6913
kmccullough@apple.com70168ee2008-09-03 17:35:42 +000069142008-09-03 Kevin McCullough <kmccullough@apple.com>
6915
6916 Reviewed by Darin and Tim.
6917
6918 Remove most of the "zombie" mode from the profiler. Next we will need
6919 to remove the client callback mechanism in profiles.
6920 - These changes are a result of changes to JSCore.
6921
6922 * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html:
6923 * page/Console.cpp:
6924 (WebCore::retrieveLastCaller):
6925 (WebCore::Console::profileEnd):
6926 * page/InspectorController.cpp:
6927 (WebCore::InspectorController::stopUserInitiatedProfiling):
6928
adele@apple.com643616b2008-09-03 16:57:58 +000069292008-09-03 Adele Peterson <adele@apple.com>
6930
6931 Reviewed by Darin Adler.
6932
6933 Test: fast/forms/search-display-none-cancel-button.html
6934
6935 Allow display:none to work on a search field's cancel button. Prepare for adding more style-ability for the results button too.
6936
6937 * css/html4.css: Set display:inline-block for these buttons. Now they can be overridden by a web author.
6938
6939 * rendering/RenderTextControl.cpp:
6940 (WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers.
6941 (WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly. This is now done in html4.css.
6942 (WebCore::RenderTextControl::createCancelButtonStyle): ditto.
6943 (WebCore::RenderTextControl::createSubtreeIfNeeded):
6944 Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class.
6945 (WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers.
6946 (WebCore::RenderTextControl::subtreeHasChanged): ditto.
6947 (WebCore::RenderTextControl::calcHeight): ditto.
6948 (WebCore::RenderTextControl::nodeAtPoint): ditto.
6949 (WebCore::RenderTextControl::layout): ditto.
6950 (WebCore::RenderTextControl::calcPrefWidths): ditto.
6951 (WebCore::RenderTextControl::clientPaddingLeft): ditto.
6952 (WebCore::RenderTextControl::clientPaddingRight): ditto.
6953
6954 * rendering/TextControlInnerElements.cpp:
6955 (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp.
6956 (WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto.
6957 (WebCore::TextControlInnerElement::attachInnerElement): Added.
6958 This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element.
6959 (WebCore::TextControlInnerTextElement::createRenderer): Added. Creates a RenderTextControlInnerBlock.
6960 * rendering/TextControlInnerElements.h:
6961
ap@webkit.orgacd84142008-09-03 08:08:19 +000069622008-08-28 Alexey Proskuryakov <ap@webkit.org>
6963
6964 Reviewed by Maciej.
6965
6966 Elminate SQLiteAuthorizer class.
6967
6968 * WebCore.xcodeproj/project.pbxproj:
6969 * WebCore.vcproj/WebCore.vcproj:
6970 * GNUmakefile.am
6971 Removed SQLiteAuthorizer.h.
6972
6973 * platform/sql/SQLiteAuthorizer.cpp:
6974 * platform/sql/SQLiteAuthorizer.h: Removed.
6975 * platform/sql/SQLiteDatabase.cpp:
6976 (WebCore::SQLiteDatabase::authorizerFunction):
6977 (WebCore::SQLiteDatabase::setAuthorizer):
6978 * platform/sql/SQLiteDatabase.h:
6979 * storage/DatabaseAuthorizer.h:
6980 (WebCore::DatabaseAuthorizer::create):
6981 (WebCore::DatabaseAuthorizer::createView):
6982 (WebCore::DatabaseAuthorizer::createTempView):
6983 (WebCore::DatabaseAuthorizer::dropView):
6984 (WebCore::DatabaseAuthorizer::dropTempView):
6985 (WebCore::DatabaseAuthorizer::allowSelect):
6986 (WebCore::DatabaseAuthorizer::allowReindex):
6987 Merge SQLiteAuthorizer and DatabaseAuthorizer, as keeping them separate serves no purpose.
6988
mrowe@apple.com2ecd4862008-09-03 07:05:48 +000069892008-09-03 Dirk Schulze <vbs85@gmx.de>
6990
6991 Reviewed by Mark Rowe.
6992
6993 WebKitGtk build fix.
6994
6995 * GNUmakefile.am:
6996 * page/animation/AnimationController.h:
6997
mrowe@apple.come344ad02008-09-03 06:59:03 +000069982008-09-02 Robert Blaut <webkit@blaut.biz>
6999
7000 Reviewed by Geoff Garen.
7001
7002 Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913>
7003 Misplaced elements should not close DL lists.
7004
7005 Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html
7006
7007 * html/HTMLParser.cpp:
7008 (WebCore::HTMLParser::handleError):
7009
mrowe@apple.com7a909462008-09-03 06:51:31 +000070102008-09-02 Glenn Wilson <wilsong@gmail.com>
7011
7012 Reviewed by Darin Adler.
7013
7014 Fix for <https://bugs.webkit.org/show_bug.cgi?id=15360>
7015 Bug 15360: color:#{predefined colorName} is treated as colorName in Safari
7016
7017 We would inappropriately interpret and apply an invalid CSS "color" property
7018 when the value is a predefined color preceded by a '#' symbol. For example,
7019 style="color:#gray;" would apply the color gray when it should not.
7020
7021 In the bison template, "hexcolor" was defined as both "HEX maybe_space" OR "IDENT maybe_space".
7022 This caused identifiers not fitting the appropriate hex format but preceded by a '#' to be
7023 interpreted as a valid color (CSSPrimitiveValue::CSS_PARSER_HEXCOLOR), when it was really just
7024 an ignorable token.
7025
7026 To correct this, "IDENT maybe_space" was removed from "hexcolor" and added under "term" as
7027 '#' IDENT maybe_space, which is then processed as a CSSPrimitiveValue::CSS_STRING instead of
7028 CSSPrimitiveValue::CSS_PARSER_HEXCOLOR.
7029
7030 Test: css1/color_and_background/invalid_color.html
7031
7032 * css/CSSGrammar.y:
7033
mrowe@apple.comda9a1442008-09-03 06:22:12 +000070342008-09-02 Mihnea Ovidenie <mihnea@adobe.com>
7035
7036 Reviewed by Darin Adler.
7037
7038 Fix for https://bugs.webkit.org/show_bug.cgi?id=19964
7039 Bug 19964: Divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image
7040
7041 Add a check to RenderBox::repaintLayerRectsForImage to make sure the current layer image can be rendered.
7042
7043 Test: css3/khtml-background-size-0x0-bmp.html
7044
7045 * rendering/RenderBox.cpp:
7046 (WebCore::RenderBox::repaintLayerRectsForImage):
7047
mrowe@apple.com6625ae52008-09-03 06:12:30 +000070482008-09-02 Glenn Wilson <wilsong@gmail.com>
7049
7050 Reviewed by Eric Seidel.
7051
7052 Fix https://bugs.webkit.org/show_bug.cgi?id=20397
7053 Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash
7054
7055 The function checkForOrphanedUnits() would change the length of a list whose size was
7056 was already determined before the call to checkForOrphanedUnits was made. Later in
7057 the caller, the old size was being used for boundary management.
7058
7059 This has been fixed by moving the call to checkForOrphanedUnits() earlier in the
7060 calling function, before the size of the list is determined.
7061
7062 Test: fast/css/orphaned_units_crash.html
7063
7064 * css/CSSParser.cpp:
7065 (WebCore::CSSParser::parseValue): Moved call to checkForOrphanedUnits() earlier in the function.
7066
mrowe@apple.com170bd522008-09-03 05:49:51 +000070672008-09-02 Dirk Schulze <vbs85@gmx.de>
7068
7069 Reviewed by Darin Adler.
7070
mrowe@apple.comeb877a52008-09-03 06:01:15 +00007071 Fallback on invalid fill or stroke styles in Canvas was
7072 transparent black. Changed it to last valid style.
7073
7074 Canvas fillStyle() and strokeStyle() needs fallback
7075 https://bugs.webkit.org/show_bug.cgi?id=20474
7076
7077 Tests: fast/canvas/canvas-invalid-fillstyle.html
7078 fast/canvas/canvas-invalid-strokestyle.html
7079
7080 * html/CanvasStyle.cpp:
7081 (WebCore::CanvasStyle::applyStrokeColor):
7082 (WebCore::CanvasStyle::applyFillColor):
7083
70842008-09-02 Dirk Schulze <vbs85@gmx.de>
7085
7086 Reviewed by Darin Adler.
7087
mrowe@apple.com170bd522008-09-03 05:49:51 +00007088 Fix https://bugs.webkit.org/show_bug.cgi?id=20468
7089 Updated drawImage() in canvas to match the current specification.
7090
7091 Test: fast/canvas/drawImage-with-negative-source-destination.html
7092
7093 * html/CanvasRenderingContext2D.cpp:
7094 (WebCore::normalizeRect):
7095 (WebCore::CanvasRenderingContext2D::drawImage):
7096
mrowe@apple.com96916d12008-09-03 05:41:44 +000070972008-08-26 Mark Rowe <mrowe@apple.com>
7098
7099 Reviewed by Darin Adler.
7100
7101 <rdar://problem/5768210> Switch back to the system version of SQLite
7102
7103 Use the system version of SQLite when it is new enough to provide the functionality
7104 that WebCore requires.
7105
7106 * Configurations/Base.xcconfig:
7107 * Configurations/DebugRelease.xcconfig:
7108 * Configurations/WebCore.xcconfig:
7109
mitz@apple.comce268c12008-09-03 02:59:00 +000071102008-09-02 Dan Bernstein <mitz@apple.com>
7111
7112 - build fix
7113
7114 * page/animation/AnimationBase.h:
7115
dino@apple.com7e49a7a2008-09-03 01:32:14 +000071162008-09-02 Chris Marrin <cmarrin@apple.com>
7117
7118 Reviewed by Dave Hyatt.
7119
7120 AnimationController.cpp should be split into separate files
7121 https://bugs.webkit.org/show_bug.cgi?id=20604
7122
7123 Note: All makefiles, except WebCore.xcodeproj have been changed without testing, upon
7124 recommendation of Dave Hyatt.
7125
7126 * GNUmakefile.am:
7127 * WebCore.pro:
7128 * WebCore.vcproj/WebCore.vcproj:
7129 * WebCore.xcodeproj/project.pbxproj:
7130 * WebCoreSources.bkl:
7131 Build files.
7132
7133 * page/AnimationController.cpp: Removed.
7134 * page/AnimationController.h: Removed.
7135 * page/animation: Added.
7136 * page/animation/AnimationBase.cpp: Added.
7137 * page/animation/AnimationBase.h: Added.
7138 * page/animation/AnimationController.cpp: Copied from WebCore/page/AnimationController.cpp.
7139 * page/animation/AnimationController.h: Copied from WebCore/page/AnimationController.h.
7140 * page/animation/CompositeAnimation.cpp: Added.
7141 * page/animation/CompositeAnimation.h: Added.
7142 * page/animation/ImplicitAnimation.cpp: Added.
7143 * page/animation/ImplicitAnimation.h: Added.
7144 * page/animation/KeyframeAnimation.cpp: Added.
7145 * page/animation/KeyframeAnimation.h: Added.
7146
mitz@apple.comcb917a22008-09-03 00:57:37 +000071472008-09-02 Dan Bernstein <mitz@apple.com>
7148
7149 - release build fix
7150
7151 * platform/graphics/cg/GraphicsContextCG.cpp:
7152 (WebCore::calculateDrawingMode):
7153
timothy@apple.comf3aa7342008-09-02 21:30:26 +000071542008-09-02 Timothy Hatcher <timothy@apple.com>
7155
timothy@apple.comc33ff3c2008-09-02 21:35:02 +00007156 Make console functions log the correct resource URL and
7157 line number for where the call originated.
7158
7159 https://bugs.webkit.org/show_bug.cgi?id=17234
7160 <rdar://problem/5732837>
7161
7162 Reviewed by Kevin McCullough.
7163
7164 Test: manual-tests/inspector/console-call-line-numbers.html
7165
7166 * bindings/js/JSConsoleCustom.cpp:
7167 (WebCore::JSConsole::count): Call the impl.
7168 (WebCore::JSConsole::timeEnd): Ditto.
7169 * manual-tests/inspector/console-call-line-numbers.html: Added.
7170 * manual-tests/inspector/resources/script-console-calls.js: Added.
7171 * page/Console.cpp:
7172 (WebCore::retrieveLastCaller): Helper to get the URL and line.
7173 (WebCore::Console::error): Call retrieveLastCaller to get the URL and
7174 line number to pass to addMessageToConsole.
7175 (WebCore::Console::info): Ditto.
7176 (WebCore::Console::log): Ditto.
7177 (WebCore::Console::assertCondition): Ditto.
7178 (WebCore::Console::count): Ditto.
7179 (WebCore::Console::timeEnd): Ditto.
7180 (WebCore::Console::warn): Ditto.
7181 * page/Console.h:
7182 * page/Console.idl: Make count and timeEnd custom.
7183
71842008-09-02 Timothy Hatcher <timothy@apple.com>
7185
timothy@apple.comf3aa7342008-09-02 21:30:26 +00007186 Removed IDL files from WebCore's framework resources.
7187
7188 * WebCore.xcodeproj/project.pbxproj:
7189
mitz@apple.comfb6ad392008-09-02 20:39:29 +000071902008-09-02 Dan Bernstein <mitz@apple.com>
7191
7192 Reviewed by Dave Hyatt.
7193
7194 - <rdar://problem/5681647> pages at http://www.stendmarsofa.com/ are so slow to calculate style it seems like a hang
7195
7196 * html/HTMLParser.cpp:
7197 (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added a
7198 cap on the number of consecutive identical residual style tags to
7199 reopen.
7200 (WebCore::HTMLParser::popBlock): Ditto.
7201
ap@webkit.org879328b2008-09-02 16:16:06 +000072022008-09-02 Alexey Proskuryakov <ap@webkit.org>
7203
7204 Reviewed by Adam Roben.
7205
7206 A little database quota management cleanup.
7207
7208 * storage/OriginQuotaManager.cpp:
7209 (WebCore::OriginQuotaManager::OriginQuotaManager):
7210 (WebCore::OriginQuotaManager::lock):
7211 (WebCore::OriginQuotaManager::unlock):
7212 (WebCore::OriginQuotaManager::trackOrigin):
7213 (WebCore::OriginQuotaManager::tracksOrigin):
7214 (WebCore::OriginQuotaManager::addDatabase):
7215 (WebCore::OriginQuotaManager::removeDatabase):
7216 (WebCore::OriginQuotaManager::removeOrigin):
7217 (WebCore::OriginQuotaManager::markDatabase):
7218 (WebCore::OriginQuotaManager::diskUsage):
7219 * storage/OriginQuotaManager.h:
7220 Changed to assert that a lock is taken more directly and reliably. Removed comments about
7221 main/background threads, as this is likely to stop being true with synchronous Database calls
7222 being made on worker threads.
7223
7224 * storage/OriginUsageRecord.cpp:
7225 (WebCore::OriginUsageRecord::OriginUsageRecord):
7226 (WebCore::OriginUsageRecord::addDatabase):
7227 (WebCore::OriginUsageRecord::removeDatabase):
7228 (WebCore::OriginUsageRecord::markDatabase):
7229 (WebCore::OriginUsageRecord::diskUsage):
7230 * storage/OriginUsageRecord.h:
7231 (WebCore::OriginUsageRecord::DatabaseEntry::DatabaseEntry):
7232 Don't use a magic value for unknown. It is totally unnecessary for DatabaseEntry, and
7233 can be replaced with a single boolean for OriginUsageRecord.
7234 Added assertions for string parameters being unshared.
7235
7236
abarth@webkit.orgaea97a02008-09-02 04:26:15 +000072372008-09-01 Adam Barth <abarth@webkit.org>
7238
7239 Reviewed by Sam Weinig.
7240
7241 https://bugs.webkit.org/show_bug.cgi?id=19760
7242
7243 Make granting LoadLocalResources conditional on a policy.
7244
7245 * WebCore.base.exp:
7246 * dom/Document.cpp:
7247 (WebCore::Document::initSecurityContext):
7248 * loader/FrameLoader.cpp:
7249 (WebCore::FrameLoader::setLocalLoadPolicy):
7250 (WebCore::FrameLoader::restrictAccessToLocal):
7251 * loader/FrameLoader.h:
7252 (WebCore::FrameLoader::):
7253 * platform/SecurityOrigin.cpp:
7254 (WebCore::SecurityOrigin::grantLoadLocalResources):
7255 * platform/SecurityOrigin.h:
7256
dino@apple.com6e2db502008-09-01 23:05:28 +000072572008-09-01 Dean Jackson <dino@apple.com>
7258
dino@apple.com59ca9f52008-09-01 23:34:13 +00007259 Reviewed by Sam Weinig.
7260
7261 https://bugs.webkit.org/show_bug.cgi?id=20571
7262 Make sure Window object can assign Animation/Transition event
7263 listeners via attributes.
7264
7265 Also added a bunch of transition event tests, although
7266 only transition-end-event-window is directly relevant to this patch.
7267
7268 (WebCore::JSDOMWindowBase::put):
7269
7270 Tests: transitions/transition-end-event-all-properties.html
7271 transitions/transition-end-event-attributes.html
7272 transitions/transition-end-event-container.html
7273 transitions/transition-end-event-left.html
7274 transitions/transition-end-event-multiple-01.html
7275 transitions/transition-end-event-multiple-02.html
7276 transitions/transition-end-event-multiple-03.html
7277 transitions/transition-end-event-multiple-04.html
7278 transitions/transition-end-event-nested.html
7279 transitions/transition-end-event-transform.html
7280 transitions/transition-end-event-window.html
7281
72822008-09-01 Dean Jackson <dino@apple.com>
7283
dino@apple.com6e2db502008-09-01 23:05:28 +00007284 Reviewed by Sam Weinig
7285
7286 Code styling cleanup.
7287
7288 * bindings/js/JSDOMWindowBase.cpp:
7289 (WebCore::JSDOMWindowBase::getValueProperty):
7290 (WebCore::JSDOMWindowBase::put):
7291
weinig@apple.com3412bb42008-09-01 21:22:54 +000072922008-09-01 Geoffrey Garen <ggaren@apple.com>
7293
7294 Reviewed by Darin Adler.
7295
7296 First cut at inline caching for access to vanilla JavaScript properties.
7297
7298 Updated for JavaScriptCore changes. Mostly mechanical addition of StructureIDs
7299 to WebCore classes, and PutPropertySlot& arguments to put functions.
7300
7301 (WebCore::JSCSSStyleDeclaration::customPut): Be sure to play nice with
7302 inline caching for global properties, so global assignment can be optimized.
7303
7304 * ForwardingHeaders/kjs/StructureID.h: Added.
7305 * bindings/js/JSDOMBinding.h:
7306 (WebCore::DOMObject::DOMObject):
7307 * bindings/js/JSDOMWindowBase.cpp:
7308 (WebCore::JSDOMWindowBase::put):
7309 * bindings/js/JSDOMWindowBase.h:
7310 * bindings/js/JSDOMWindowCustom.h:
7311 (WebCore::JSDOMWindow::customPut):
7312 * bindings/js/JSDOMWindowShell.cpp:
7313 (WebCore::JSDOMWindowShell::JSDOMWindowShell):
7314 (WebCore::JSDOMWindowShell::put):
7315 * bindings/js/JSDOMWindowShell.h:
7316 * bindings/js/JSEventTargetBase.h:
7317 (WebCore::JSEventTargetBase::put):
7318 * bindings/js/JSEventTargetNode.h:
7319 (WebCore::JSEventTargetNode::put):
7320 * bindings/js/JSHTMLAppletElementCustom.cpp:
7321 (WebCore::JSHTMLAppletElement::customPut):
7322 * bindings/js/JSHTMLEmbedElementCustom.cpp:
7323 (WebCore::JSHTMLEmbedElement::customPut):
7324 * bindings/js/JSHTMLInputElementBase.cpp:
7325 (WebCore::JSHTMLInputElementBase::put):
7326 * bindings/js/JSHTMLInputElementBase.h:
7327 * bindings/js/JSHTMLObjectElementCustom.cpp:
7328 (WebCore::JSHTMLObjectElement::customPut):
7329 * bindings/js/JSHistoryCustom.cpp:
7330 (WebCore::JSHistory::customPut):
7331 * bindings/js/JSInspectedObjectWrapper.cpp:
7332 (WebCore::JSInspectedObjectWrapper::wrap):
7333 (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
7334 * bindings/js/JSInspectedObjectWrapper.h:
7335 * bindings/js/JSInspectorCallbackWrapper.cpp:
7336 (WebCore::JSInspectorCallbackWrapper::wrap):
7337 (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
7338 * bindings/js/JSInspectorCallbackWrapper.h:
7339 * bindings/js/JSLocationCustom.cpp:
7340 (WebCore::JSLocation::customPut):
7341 * bindings/js/JSPluginElementFunctions.cpp:
7342 (WebCore::runtimeObjectCustomPut):
7343 * bindings/js/JSPluginElementFunctions.h:
7344 * bindings/js/JSQuarantinedObjectWrapper.cpp:
7345 (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
7346 (WebCore::JSQuarantinedObjectWrapper::put):
7347 * bindings/js/JSQuarantinedObjectWrapper.h:
7348 * bindings/js/JSStorageCustom.cpp:
7349 (WebCore::JSStorage::customPut):
7350 * bindings/objc/WebScriptObject.mm:
7351 (-[WebScriptObject setValue:forKey:]):
7352 * bindings/scripts/CodeGeneratorJS.pm:
7353 * bridge/NP_jsobject.cpp:
7354 (_NPN_SetProperty):
7355 * bridge/jni/jni_jsobject.mm:
7356 (JavaJSObject::setMember):
7357 * bridge/objc/objc_class.mm:
7358 (KJS::Bindings::ObjcClass::fallbackObject):
7359 * bridge/objc/objc_runtime.h:
7360 * bridge/objc/objc_runtime.mm:
7361 (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
7362 (ObjcFallbackObjectImp::put):
7363 * bridge/runtime.cpp:
7364 (KJS::Bindings::Instance::createRuntimeObject):
7365 * bridge/runtime_array.cpp:
7366 (RuntimeArray::put):
7367 * bridge/runtime_array.h:
7368 * bridge/runtime_object.cpp:
7369 (RuntimeObjectImp::RuntimeObjectImp):
7370 (RuntimeObjectImp::put):
7371 * bridge/runtime_object.h:
7372
jmalonzo@webkit.org1f770ba2008-09-01 12:43:34 +000073732008-09-01 Dirk Schulze <vbs85@gmx.de>
7374
7375 Reviewed by Eric Seidel.
7376
jmalonzo@webkit.org37f07882008-09-01 12:43:48 +00007377 Fixed border-radius for Cairo.
7378
7379 * platform/graphics/cairo/GraphicsContextCairo.cpp:
7380 (WebCore::GraphicsContext::strokeArc):
7381
73822008-09-01 Dirk Schulze <vbs85@gmx.de>
7383
7384 Reviewed by Eric Seidel.
7385
jmalonzo@webkit.org1f770ba2008-09-01 12:43:34 +00007386 Added canvas's globalAlpha to cairo.
7387
7388 * platform/graphics/GraphicsContext.h:
7389 * platform/graphics/cairo/GraphicsContextCairo.cpp:
7390 (WebCore::GraphicsContext::fillPath):
7391 (WebCore::GraphicsContext::strokePath):
7392 (WebCore::GraphicsContext::setAlpha):
7393 (WebCore::GraphicsContext::getAlpha):
7394 * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
7395 (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
7396 * platform/graphics/cairo/ImageCairo.cpp:
7397 (WebCore::BitmapImage::draw):
7398
hausmann@webkit.orgecd099d2008-08-31 13:13:28 +000073992008-08-31 Simon Hausmann <hausmann@webkit.org>
7400
7401 Unreviewed Qt build fix.
7402
7403 * WebCore.pro: Add TextControlInnerElements.cpp to SOURCES instead of
7404 the .h file
7405
darin@apple.come7945852008-08-31 06:58:07 +000074062008-08-30 Darin Adler <darin@apple.com>
7407
7408 Reviewed by Maciej.
7409
7410 - adopt some new JavaScriptCore functions where appropriate
7411
7412 * bindings/js/JSDOMWindowBase.cpp:
7413 (WebCore::windowProtoFuncAToB): Adopted jsEmptyString.
7414 (WebCore::windowProtoFuncBToA): Ditto.
7415 * bindings/js/JSEventListener.cpp:
7416 (WebCore::JSLazyEventListener::eventParameterName): Adopted
7417 jsNontrivialString.
7418 * bindings/js/JSSVGLazyEventListener.cpp:
7419 (WebCore::JSSVGLazyEventListener::eventParameterName): Ditto.
7420
beidson@apple.com21c821f2008-08-30 00:26:01 +000074212008-08-29 Brady Eidson <beidson@apple.com>
7422
beidson@apple.come1bd6032008-08-30 00:30:11 +00007423 Reviewed by Anders' rubberstamp
7424
7425 Style cleanup to match MediaTokenizer::writeRawData()
7426
7427 * loader/PluginDocument.cpp:
7428 (WebCore::PluginTokenizer::writeRawData):
7429
74302008-08-29 Brady Eidson <beidson@apple.com>
7431
beidson@apple.com21c821f2008-08-30 00:26:01 +00007432 Reviewed by Anders
7433
7434 Fix regression I introducted in 35946
7435 Already covered by media/video-click-dlbclick-standalone.html
7436
7437 * loader/MediaDocument.cpp:
7438 (WebCore::MediaTokenizer::createDocumentStructure): Don't cancel the load here - too early!
7439 (WebCore::MediaTokenizer::writeRawData): Call finish() here so onload() can be called. Also add
7440 an ASSERT signifying that this method should only be called once, to more closely follow the
7441 PluginDocument case.
7442
bdakin@apple.com7ee298c2008-08-30 00:00:30 +000074432008-08-29 Beth Dakin <bdakin@apple.com>
7444
7445 Reviewed by Sam Weinig.
7446
7447 Fix for <rdar://problem/6181588>
7448
7449 This patch makes hit testing take into account the new concept of a
7450 disconnected frame, in which some of the content may not be
7451 visible. The current hit testing mechanism starts at a target frame
7452 and drills down for a HitTestResult. In some cases, drilling down
7453 will find a non-visible result. When this happens, we need to try
7454 again, starting at a higher level -- namely, starting at the main
7455 frame.
7456
7457 * editing/Editor.cpp:
7458 (WebCore::Editor::insideVisibleArea): New function that tests if a
7459 point is inside the visible area for a disconnected frame.
7460 * editing/Editor.h:
7461 * page/EventHandler.cpp:
7462 (WebCore::EventHandler::hitTestResultAtPoint):
7463
adele@apple.comfb903062008-08-29 22:30:18 +000074642008-08-29 Adele Peterson <adele@apple.com>
7465
7466 Reviewed by Adam Roben.
7467
7468 Rename HTMLTextFieldInnerElement.h/.cpp to TextControlInnerElements.h/.cpp
7469
7470 * GNUmakefile.am:
7471 * WebCore.pro:
7472 * WebCore.vcproj/WebCore.vcproj:
7473 * WebCore.xcodeproj/project.pbxproj:
7474 * WebCoreSources.bkl:
7475 * html/HTMLTextFieldInnerElement.cpp: Removed.
7476 * html/HTMLTextFieldInnerElement.h: Removed.
7477 * rendering/RenderTextControl.cpp:
7478 (WebCore::RenderTextControl::createSubtreeIfNeeded):
7479 * rendering/RenderTextControl.h:
7480 * rendering/TextControlInnerElements.cpp: Copied from html/HTMLTextFieldInnerElement.cpp.
7481 (WebCore::TextControlInnerElement::TextControlInnerElement):
7482 (WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
7483 (WebCore::TextControlInnerTextElement::defaultEventHandler):
7484 (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
7485 (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
7486 (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
7487 (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
7488 * rendering/TextControlInnerElements.h: Copied from html/HTMLTextFieldInnerElement.h.
7489
eric@webkit.org298c65b2008-08-29 21:39:32 +000074902008-08-29 Eric Seidel <eric@webkit.org>
7491
eric@webkit.org77837ce2008-08-29 21:40:07 +00007492 Rubber-stamped by aroben.
7493
7494 Add GraphicsContext.h include to GraphcisContextPrivate.h
7495
7496 GraphicsContextPrivate uses StrokeStyle which is defined
7497 in GraphicsContext.h but it doesn't include that header.
7498 CoreGraphics build doesn't fail here due to the order
7499 it happens to include files.
7500
7501 * platform/graphics/GraphicsContextPrivate.h:
7502
75032008-08-29 Eric Seidel <eric@webkit.org>
7504
eric@webkit.org298c65b2008-08-29 21:39:32 +00007505 Reviewed by hyatt.
7506
7507 Fix GeneratedImage to respect Image's refcounting
7508 Fixing potential crashers (future if not current)
7509 https://bugs.webkit.org/show_bug.cgi?id=20567
7510
7511 I don't know if it's possible to make the current code
7512 crash, thus I've not made a test.
7513
7514 * css/CSSGradientValue.cpp:
7515 (WebCore::CSSGradientValue::image):
7516 * css/CSSImageGeneratorValue.cpp:
7517 (WebCore::CSSImageGeneratorValue::removeClient):
7518 (WebCore::CSSImageGeneratorValue::getImage):
7519 * css/CSSImageGeneratorValue.h:
7520 * platform/graphics/GeneratedImage.h:
7521 (WebCore::GeneratedImage::GeneratedImage):
7522 * rendering/style/RenderStyle.cpp:
7523 (WebCore::RenderStyle::setContent):
7524 * rendering/style/RenderStyle.h:
7525
eric.carlson@apple.comddeafd42008-08-29 20:07:19 +000075262008-08-29 Eric Carlson <eric.carlson@apple.com>
7527
7528 Reviewed by Adele.
7529
eric.carlson@apple.com850c77c2008-08-29 20:24:50 +00007530 Fix for <rdar://problem/6093767>
7531 https://bugs.webkit.org/show_bug.cgi?id=20526
7532
7533 Don't allow video to render until unsupported track types have been disabled.
7534
7535 * platform/graphics/win/QTMovieWin.cpp:
7536 (QTMovieWinPrivate::task):
7537 (QTMovieWinPrivate::drawingComplete):
7538 (QTMovieWinPrivate::clearGWorld):
7539
75402008-08-29 Eric Carlson <eric.carlson@apple.com>
7541
7542 Reviewed by Adele.
7543
eric.carlson@apple.comddeafd42008-08-29 20:07:19 +00007544 Fix for https://bugs.webkit.org/show_bug.cgi?id=20525
7545 <rdar://problem/6169301>
7546
7547 Return the size of the movie data instead of 1000.
7548
7549 Test: media/progress-event-total.html
7550
7551 * platform/graphics/win/QTMovieWin.cpp:
7552 (QTMovieWin::dataSize):
7553
hausmann@webkit.org0367b582008-08-29 15:56:02 +000075542008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
7555
hausmann@webkit.orgfe7f2ac2008-08-29 15:57:44 +00007556 Reviewed by Eric Seidel.
7557
7558 [janitor/qt] Start replacing port specific getters with the generic native getter
7559 To get the native presentation of an image we currently have platform
7560 specific #ifdef's and a generic getter using NativeImagePtr. This patch
7561 extends this to the ImageBuffer and updates the Qt platform to get rid
7562 of the special #ifdefs.
7563
7564 https://bugs.webkit.org/attachment.cgi?id=22861
7565
7566 * platform/graphics/BitmapImage.h:
7567 * platform/graphics/Image.h:
7568 * platform/graphics/qt/ImageQt.cpp:
7569 * platform/graphics/qt/StillImageQt.cpp:
7570 * platform/graphics/qt/StillImageQt.h:
7571 * platform/qt/ClipboardQt.cpp:
7572 (WebCore::ClipboardQt::createDragImage):
7573 (WebCore::ClipboardQt::declareAndWriteDragImage):
7574 * platform/qt/CursorQt.cpp:
7575 * platform/qt/PasteboardQt.cpp:
7576 (WebCore::Pasteboard::writeImage):
7577
75782008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
7579
hausmann@webkit.org0367b582008-08-29 15:56:02 +00007580 Reviewed by Simon.
7581
hausmann@webkit.orgb99266e2008-08-29 15:56:59 +00007582 [svg/qt] Stop crashing... when no RenderPath/RenderObject is given...
7583
7584 * svg/graphics/qt/SVGPaintServerQt.cpp:
7585 (WebCore::SVGPaintServer::renderPath):
7586 * svg/graphics/qt/SVGPaintServerSolidQt.cpp:
7587 (WebCore::SVGPaintServerSolid::setup):
7588
75892008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
7590
7591 Reviewed by Simon.
7592
hausmann@webkit.org0367b582008-08-29 15:56:02 +00007593 [network/qt] Implement defering of loading ResourceHandle's
7594 This is needed otherwise we end in an ASSERT in the MainResourceLoader. The
7595 implementation is simply not forwarding anything to the
7596 ResourceHandleClient until we are allowed to. This might lead to a deadlock
7597 in Qt as we do not empty the QNetworkReply input buffer and wait until we
7598 are allowed to read. If that happens we are forced to buffer the data
7599 within QNetworkReplyHandler, for now this is not done.
7600
7601 Manual test:
7602 - Open http://acid3.acidtests.org
7603 - Wait for the test to complete
7604 - Click on the Reference Rendering link
7605 - Be fast and see the results of acid3
7606 => assert
7607
7608 * platform/network/qt/QNetworkReplyHandler.cpp:
7609 (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
7610 (WebCore::QNetworkReplyHandler::setLoadMode):
7611 (WebCore::QNetworkReplyHandler::finish):
7612 (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
7613 (WebCore::QNetworkReplyHandler::forwardData):
7614 (WebCore::QNetworkReplyHandler::start):
7615 (WebCore::QNetworkReplyHandler::resetState):
7616 (WebCore::QNetworkReplyHandler::sendQueuedItems):
7617 * platform/network/qt/QNetworkReplyHandler.h:
7618 (WebCore::QNetworkReplyHandler::):
7619 * platform/network/qt/ResourceHandleQt.cpp:
7620 (WebCore::ResourceHandle::start):
7621 (WebCore::ResourceHandle::loadResourceSynchronously):
7622 (WebCore::ResourceHandle::setDefersLoading):
7623
hausmann@webkit.org2f2621f2008-08-29 10:21:38 +000076242008-08-29 Simon Hausmann <hausmann@webkit.org>
7625
hausmann@webkit.orgf5864402008-08-29 12:35:59 +00007626 Reviewed by Holger.
7627
7628 Don't crash when drawing patterns with the HTML canvas. Patterns
7629 remain unimplemented but at least they don't crash anymore. This is
7630 done by changing the PlatformPatternPtr to be a brush for the Qt
7631 platform.
7632
7633 * platform/graphics/Pattern.h:
7634 * platform/graphics/qt/GraphicsContextQt.cpp:
7635 (WebCore::GraphicsContext::fillPath):
7636 (WebCore::GraphicsContext::strokePath):
7637 (WebCore::GraphicsContext::fillRect):
7638 * platform/graphics/qt/PatternQt.cpp:
7639 (WebCore::Pattern::createPlatformPattern):
7640
76412008-08-29 Simon Hausmann <hausmann@webkit.org>
7642
hausmann@webkit.org2f2621f2008-08-29 10:21:38 +00007643 Fix the Qt build, fontSelector() is not used by the Qt port yet
7644 and we just return 0 in Font::fontSelector().
7645
7646 * platform/graphics/Font.h:
7647
alp@webkit.org97d8c102008-08-29 05:09:39 +000076482008-08-28 Alp Toker <alp@nuanti.com>
7649
7650 GTK+ dist/build fix. List newly added header files.
7651
7652 * GNUmakefile.am:
7653
simon.fraser@apple.com8f30d022008-08-28 23:04:18 +000076542008-08-28 Simon Fraser <simon.fraser@apple.com>
7655
7656 Reviewed by Dave Hyatt
7657
7658 Various WebKitCSSTransformValue-related fixes
7659 https://bugs.webkit.org/show_bug.cgi?id=20562
7660
7661 Test: css3/transform-value-types.html
7662
7663 * bindings/js/JSCSSValueCustom.cpp:
7664 (WebCore::toJS):
7665 * css/CSSValue.h:
7666 * css/WebKitCSSTransformValue.cpp:
7667 (WebCore::WebKitCSSTransformValue::cssText):
7668 * css/WebKitCSSTransformValue.h:
7669 (WebCore::WebKitCSSTransformValue::):
7670 * css/WebKitCSSTransformValue.idl:
7671
mitz@apple.comd7222352008-08-28 22:53:31 +000076722008-08-28 Dan Bernstein <mitz@apple.com>
7673
7674 Reviewed by Steve Falkenburg.
7675
7676 - do not let the "last chance" WM_TIMER trigger WebCore timers when they should be deferred
7677
7678 * platform/win/SharedTimerWin.cpp:
7679 (WebCore::TimerWindowWndProc):
7680
hyatt@apple.com7d335232008-08-28 21:38:45 +000076812008-08-28 David Hyatt <hyatt@apple.com>
7682
7683 RenderStyle cleanup.
7684
7685 Break out StyleImage, StyleGeneratedImage, StyleCachedImage and NinePieceImage into separate files.
7686
7687 Reviewed by Adam
7688
7689 * css/CSSImageGeneratorValue.cpp:
7690 * css/CSSImageValue.cpp:
7691 * css/CSSStyleSelector.cpp:
7692 * rendering/RenderImageGeneratedContent.cpp:
7693 * rendering/style/NinePieceImage.cpp: Added.
7694 * rendering/style/NinePieceImage.h: Added.
7695 * rendering/style/RenderStyle.cpp:
7696 (WebCore::FillLayer::operator==):
7697 (WebCore::FillLayer::containsImage):
7698 (WebCore::StyleInheritedData::operator==):
7699 (WebCore::RenderStyle::contentDataEquivalent):
7700 * rendering/style/RenderStyle.h:
7701 * rendering/style/StyleCachedImage.cpp: Added.
7702 * rendering/style/StyleCachedImage.h: Added.
7703 * rendering/style/StyleGeneratedImage.cpp: Added.
7704 * rendering/style/StyleGeneratedImage.h: Added.
7705 * rendering/style/StyleImage.h: Added.
7706
simon.fraser@apple.com28bad1a2008-08-28 21:29:21 +000077072008-08-28 Simon Fraser <simon.fraser@apple.com>
7708
7709 Reviewed by Dave Hyatt
7710
7711 Make all the 'isFoo()' methods on CSSValue const,
7712 and fix the subclasses.
7713
7714 https://bugs.webkit.org/show_bug.cgi?id=20561
7715
7716 * css/CSSTimingFunctionValue.h:
7717 * css/CSSValue.h:
7718 (WebCore::CSSValue::isFontValue):
7719 (WebCore::CSSValue::isImageGeneratorValue):
7720 (WebCore::CSSValue::isImageValue):
7721 (WebCore::CSSValue::isImplicitInitialValue):
7722 * css/CSSValueList.h:
7723 * css/FontValue.h:
7724
hyatt@apple.com550a95c2008-08-28 19:53:56 +000077252008-08-28 David Hyatt <hyatt@apple.com>
7726
hyatt@apple.comcb3eb812008-08-28 20:08:03 +00007727 The great RenderStyle cleanup begins!
7728
7729 Move LengthBox and LengthSize out of RenderStyle and into Length.
7730
7731 Reviewed by Adam
7732
7733 * rendering/Length.h:
7734 (WebCore::):
7735 (WebCore::Length::Length):
7736 (WebCore::Length::operator==):
7737 (WebCore::Length::operator!=):
7738 (WebCore::Length::value):
7739 (WebCore::Length::rawValue):
7740 (WebCore::Length::percent):
7741 (WebCore::Length::type):
7742 (WebCore::Length::quirk):
7743 (WebCore::Length::setValue):
7744 (WebCore::Length::setRawValue):
7745 (WebCore::Length::calcValue):
7746 (WebCore::Length::calcMinValue):
7747 (WebCore::Length::calcFloatValue):
7748 (WebCore::Length::isUndefined):
7749 (WebCore::Length::isZero):
7750 (WebCore::Length::isPositive):
7751 (WebCore::Length::isNegative):
7752 (WebCore::Length::isAuto):
7753 (WebCore::Length::isRelative):
7754 (WebCore::Length::isPercent):
7755 (WebCore::Length::isFixed):
7756 (WebCore::Length::isStatic):
7757 (WebCore::Length::isIntrinsicOrAuto):
7758 (WebCore::Length::blend):
7759 (WebCore::LengthBox::LengthBox):
7760 (WebCore::LengthBox::operator=):
7761 (WebCore::LengthBox::operator==):
7762 (WebCore::LengthBox::operator!=):
7763 (WebCore::LengthBox::nonZero):
7764 (WebCore::LengthSize::LengthSize):
7765 * rendering/style/RenderStyle.h:
7766
77672008-08-28 David Hyatt <hyatt@apple.com>
7768
hyatt@apple.com550a95c2008-08-28 19:53:56 +00007769 Reviewed by Darin
7770
7771 https://bugs.webkit.org/show_bug.cgi?id=18091
7772
7773 font-size should be animatable using -webkit-transition.
7774
7775 * page/AnimationController.cpp:
7776 (WebCore::AnimationControllerPrivate::ensurePropertyMap):
7777 * rendering/style/RenderStyle.h:
7778 (WebCore::RenderStyle::setFontSize):
7779
mitz@apple.com30923ad2008-08-28 17:45:47 +000077802008-08-28 Brad Garcia <bgarcia@google.com>
7781
7782 Reviewed by Dan Bernstein.
7783
7784 https://bugs.webkit.org/show_bug.cgi?id=20549
7785 Correctly determine when cursor is over a resizable border within
7786 a nested frameset.
7787
7788 * rendering/RenderFrameSet.cpp:
7789 (WebCore::RenderFrameSet::canResizeRow):
7790 (WebCore::RenderFrameSet::canResizeColumn):
7791
simon.fraser@apple.comae77c412008-08-28 17:30:07 +000077922008-08-28 Simon Fraser <simon.fraser@apple.com>
7793
7794 Reviewed by Eric Seidel
7795
7796 Add RuleTypes to CSSRule.idl for keyframes and keyframe rules.
7797 https://bugs.webkit.org/show_bug.cgi?id=20552
7798
7799 Test: animations/animation-css-rule-types.html
7800
7801 * css/CSSRule.idl:
7802
andersca@apple.com12399c32008-08-28 17:26:46 +000078032008-08-28 Anders Carlsson <andersca@apple.com>
7804
7805 Reviewed by Kevin and Darin.
7806
7807 <rdar://problem/6182541>
7808 https://bugs.webkit.org/show_bug.cgi?id=20202
7809 Missing http status line from the http headers.
7810
7811 Add a status line to the header string.
7812
7813 * plugins/PluginStream.cpp:
7814 (WebCore::PluginStream::startStream):
7815
zecke@webkit.orgf1daa422008-08-28 15:56:01 +000078162008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
7817
7818 Rubber-stamped by Darin Adler.
7819
7820 https://bugs.webkit.org/show_bug.cgi?id=17261
7821
7822 Make it possible to theme the default Url icon and enable this for
7823 the Qt port. To have a minimal usage of #ifdef in the code the setting
7824 of the icon was moved to a new method which comes in two flavors.
7825
7826 * loader/icon/IconDatabase.cpp:
7827 (WebCore::loadDefaultIconRecord): Load or set the default icon
7828 (WebCore::IconDatabase::defaultIcon):
7829
zecke@webkit.org1887dc82008-08-28 15:03:21 +000078302008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
7831
7832 Unreviewed compile fix
7833
7834 * platform/graphics/qt/GraphicsContextQt.cpp: Remove redefinitions
7835
aroben@apple.comfacf5032008-08-28 13:34:01 +000078362008-08-28 Adam Roben <aroben@apple.com>
7837
7838 Windows (and others?) build fix
7839
7840 * page/Chrome.cpp: Added a missing #include.
7841 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Fixed typo.
7842
eric@webkit.org22794fd2008-08-28 12:04:40 +000078432008-08-27 Eric Seidel <eric@webkit.org>
7844
7845 Reviewed by Oliver Hunt.
7846
eric@webkit.org5f874e92008-08-28 12:04:55 +00007847 Qt and Cairo support from krit (and blind stab @ wx compile support)
7848 https://bugs.webkit.org/show_bug.cgi?id=20373
7849
7850 * platform/graphics/cairo/GraphicsContextCairo.cpp:
7851 (WebCore::GraphicsContext::fillPath):
7852 (WebCore::GraphicsContext::strokePath):
7853 (WebCore::GraphicsContext::drawPath):
7854 (WebCore::GraphicsContext::fillRect):
7855 (WebCore::GraphicsContext::setPlatformFillColor):
7856 (WebCore::GraphicsContext::setPlatformStrokeColor):
7857 (WebCore::GraphicsContext::setPlatformStrokeStyle):
7858 (WebCore::GraphicsContext::strokeRect):
7859 (WebCore::GraphicsContext::setImageInterpolationQuality):
7860 (WebCore::GraphicsContext::imageInterpolationQuality):
7861 (WebCore::GraphicsContext::setPlatformFillPattern):
7862 (WebCore::GraphicsContext::setPlatformStrokePattern):
7863 (WebCore::GraphicsContext::setPlatformFillGradient):
7864 (WebCore::GraphicsContext::setPlatformStrokeGradient):
7865 * platform/graphics/qt/GraphicsContextQt.cpp:
7866 (WebCore::GraphicsContext::fillPath):
7867 (WebCore::GraphicsContext::strokePath):
7868 (WebCore::GraphicsContext::fillRect):
7869 (WebCore::GraphicsContext::strokeRect):
7870 (WebCore::GraphicsContext::clipToImageBuffer):
7871 (WebCore::GraphicsContext::setPlatformFillPattern):
7872 (WebCore::GraphicsContext::setPlatformStrokePattern):
7873 (WebCore::GraphicsContext::setPlatformFillGradient):
7874 (WebCore::GraphicsContext::setPlatformStrokeGradient):
7875 (WebCore::GraphicsContext::setImageInterpolationQuality):
7876 (WebCore::GraphicsContext::imageInterpolationQuality):
7877 * platform/graphics/wx/GraphicsContextWx.cpp:
7878 (WebCore::GraphicsContext::clipToImageBuffer):
7879 (WebCore::GraphicsContext::setImageInterpolationQuality):
7880 (WebCore::GraphicsContext::imageInterpolationQuality):
7881 (WebCore::GraphicsContext::fillPath):
7882 (WebCore::GraphicsContext::strokePath):
7883 (WebCore::GraphicsContext::drawPath):
7884 (WebCore::GraphicsContext::fillRect):
7885 (WebCore::GraphicsContext::setPlatformFillPattern):
7886 (WebCore::GraphicsContext::setPlatformStrokePattern):
7887 (WebCore::GraphicsContext::setPlatformFillGradient):
7888
78892008-08-27 Eric Seidel <eric@webkit.org>
7890
7891 Reviewed by Oliver Hunt.
7892
eric@webkit.org22794fd2008-08-28 12:04:40 +00007893 Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it.
7894 https://bugs.webkit.org/show_bug.cgi?id=20373
7895
7896 Changed pattern() to canvasPattern() on CanvasStyle to match canvasGradient()
7897
7898 Made Generator (aka Gradient) RefCounted so that GraphicsContext didn't
7899 have to store large Gradient objects in the GraphicsContextState
7900
7901 Made Pattern RefCounted for the same reason.
7902
7903 Many updates to GraphicsContext to support easier drawing with
7904 Patterns and Gradients.
7905
7906 * WebCore.xcodeproj/project.pbxproj: Add pre-existing GraphicsContextPrivate.h
7907 * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
7908 (WebCore::toJS):
7909 * css/CSSGradientValue.cpp:
7910 (WebCore::CSSGradientValue::createGradient):
7911 * css/CSSGradientValue.h:
7912 * html/CanvasGradient.cpp:
7913 (WebCore::CanvasGradient::CanvasGradient):
7914 * html/CanvasGradient.h:
7915 (WebCore::CanvasGradient::gradient):
7916 (WebCore::CanvasGradient::addColorStop):
7917 (WebCore::CanvasGradient::getColor):
7918 * html/CanvasPattern.cpp:
7919 * html/CanvasPattern.h:
7920 (WebCore::CanvasPattern::pattern):
7921 (WebCore::CanvasPattern::originClean):
7922 * html/CanvasRenderingContext2D.cpp:
7923 (WebCore::CanvasRenderingContext2D::State::State):
7924 (WebCore::CanvasRenderingContext2D::setStrokeStyle):
7925 (WebCore::CanvasRenderingContext2D::setFillStyle):
7926 (WebCore::CanvasRenderingContext2D::fill):
7927 (WebCore::CanvasRenderingContext2D::stroke):
7928 (WebCore::CanvasRenderingContext2D::fillRect):
7929 (WebCore::CanvasRenderingContext2D::strokeRect):
7930 * html/CanvasRenderingContext2D.h:
7931 * html/CanvasStyle.cpp:
7932 (WebCore::CanvasStyle::applyStrokeColor):
7933 (WebCore::CanvasStyle::applyFillColor):
7934 * html/CanvasStyle.h:
7935 * platform/graphics/GeneratedImage.h:
7936 (WebCore::GeneratedImage::GeneratedImage):
7937 * platform/graphics/Generator.h:
7938 * platform/graphics/Gradient.h:
7939 (WebCore::Gradient::create):
7940 * platform/graphics/GraphicsContext.cpp:
7941 (WebCore::GraphicsContext::fillRule):
7942 (WebCore::GraphicsContext::setFillRule):
7943 (WebCore::GraphicsContext::setStrokePattern):
7944 (WebCore::GraphicsContext::setFillPattern):
7945 (WebCore::GraphicsContext::setStrokeGradient):
7946 (WebCore::GraphicsContext::setFillGradient):
7947 * platform/graphics/GraphicsContext.h:
7948 * platform/graphics/GraphicsContextPrivate.h:
7949 (WebCore::):
7950 (WebCore::GraphicsContextState::GraphicsContextState):
7951 * platform/graphics/GraphicsTypes.h:
7952 * platform/graphics/Path.h:
7953 * platform/graphics/Pattern.h:
7954 (WebCore::Pattern::create):
7955 (WebCore::Pattern::tileImage):
7956 * platform/graphics/cg/GraphicsContextCG.cpp:
7957 (WebCore::GraphicsContext::drawRect):
7958 (WebCore::GraphicsContext::drawEllipse):
7959 (WebCore::GraphicsContext::drawConvexPolygon):
7960 (WebCore::calculateDrawingMode):
7961 (WebCore::GraphicsContext::drawPath):
7962 (WebCore::fillPathWithFillRule):
7963 (WebCore::GraphicsContext::fillPath):
7964 (WebCore::GraphicsContext::strokePath):
7965 (WebCore::GraphicsContext::fillRect):
7966 (WebCore::GraphicsContext::fillRoundedRect):
7967 (WebCore::GraphicsContext::setPlatformStrokePattern):
7968 (WebCore::GraphicsContext::setPlatformFillPattern):
7969 (WebCore::GraphicsContext::setPlatformStrokeGradient):
7970 (WebCore::GraphicsContext::setPlatformFillGradient):
7971
eric@webkit.org70b099f2008-08-28 11:42:26 +000079722008-08-20 Eric Seidel <eric@webkit.org>
7973
7974 Reviewed by Darin and Alexey.
7975
7976 Close a leak of PausedTimeouts if the JavaScriptDebugServer was destroyed
7977 with timeouts paused.
7978 https://bugs.webkit.org/show_bug.cgi?id=20469
7979
7980 I attempted to clean up the memory management of PausedTimeouts, I'm not
7981 sure the solution I came up with is "cleaner", but it's in some ways
7982 "safer", since it no longer uses raw pointers and manual new/delete.
7983
7984 This also now prevents CachedPage from needlessly creating Window
7985 objects when caching pages which didn't already have one. :)
7986
7987 I also made Chrome.cpp no longer depend on the JavaScript bindings
7988 (aka JSDOMWindowBase.h), since there was no real reason for it to.
7989
7990 * bindings/js/JSDOMWindowBase.cpp:
7991 (WebCore::JSDOMWindowBase::pauseTimeouts):
7992 (WebCore::JSDOMWindowBase::resumeTimeouts):
7993 * bindings/js/JSDOMWindowBase.h:
7994 * bindings/js/ScriptController.cpp:
7995 (WebCore::ScriptController::pauseTimeouts):
7996 (WebCore::ScriptController::resumeTimeouts):
7997 * bindings/js/ScriptController.h:
7998 * history/CachedPage.cpp:
7999 (WebCore::CachedPage::CachedPage):
8000 (WebCore::CachedPage::restore):
8001 * page/Chrome.cpp:
8002 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
8003 (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
8004 * page/JavaScriptDebugServer.cpp:
8005 (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
8006 (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
8007
zecke@webkit.org7d0df9e2008-08-28 03:36:31 +000080082008-08-27 Holger Hans Peter Freyther <zecke@selfish.org>
8009
8010 Unreviewed compile fix
8011
8012 Add the stub for the Qt port.
8013
8014 * WebCore.pro:
8015 * page/qt/AccessibilityObjectQt.cpp: Added.
8016 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
8017
zecke@webkit.orged5c2fe2008-08-28 02:15:20 +000080182008-08-27 Alp Toker <alp@nuanti.com>
8019
8020 Reviewed by Eric.
8021
8022 https://bugs.webkit.org/show_bug.cgi?id=20551
zecke@webkit.org81540882008-08-28 02:18:20 +00008023 [GTK] search popup crash
8024
8025 * platform/gtk/SearchPopupMenuGtk.cpp:
8026 (WebCore::SearchPopupMenu::enabled):
8027 Fix a search popup crasher by disabling the history popup since we
8028 don't support this feature yet in the GTK+ port.
8029
80302008-08-27 Alp Toker <alp@nuanti.com>
8031
8032 Reviewed by Eric.
8033
8034 https://bugs.webkit.org/show_bug.cgi?id=20551
zecke@webkit.orged5c2fe2008-08-28 02:15:20 +00008035 [GTK] curl crashers
8036
8037 * platform/network/curl/ResourceHandleManager.cpp:
8038 (WebCore::ResourceHandleManager::startScheduledJobs):
8039 Remove the resource handle from the pending list before starting the
8040 job, not afterwards. Fixes crashers in the test suite.
8041
8042 Test: fast/dom/clientWidthAfterDocumentIsRemoved.html
8043 Test: fast/encoding/char-encoding.html
8044
eric@webkit.org712cb892008-08-28 00:26:15 +000080452008-08-27 Dirk Schulze <vbs85@gmx.de>
8046
8047 Reviewed by eseidel.
8048
8049 Fix canvas drawImage to support composite operations.
8050 Composite had no effect on canvas elements like these:
8051 http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html
8052
8053 [CAIRO] Canvas composite don't work on canvas-elements.
8054 https://bugs.webkit.org/show_bug.cgi?id=20548
8055
8056 * html/CanvasRenderingContext2D.cpp:
8057 (WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call
8058
eric@webkit.org75c83a02008-08-28 00:04:59 +000080592008-08-27 Mario Bensi <mbensi@pleyo.com>
8060
8061 Reviewed by Eric Seidel.
8062
8063 Fix the data content of an image with a base64.
8064
8065 * platform/network/curl/ResourceHandleManager.cpp:
8066 (WebCore::parseDataUrl): Remove the String and use only the data
8067 Vector because the data.latin1().data() convert the data content and
8068 the image test ( https://bugs.webkit.org/attachment.cgi?id=21726 ) is
8069 not drawn correctly.
8070
antti@apple.comf66a86b2008-08-27 23:59:50 +000080712008-08-27 Antti Koivisto <antti@apple.com>
8072
8073 Reviewed by Eric Seidel.
8074
8075 Crash after OK in dialog box and reloading page in secure mode
8076 https://bugs.webkit.org/show_bug.cgi?id=20493
8077
8078 The new run loop spawned by a modal dialog causes a timer in the loader to run
8079 synchronously inside didFinishLoading() deleting "this" object.
8080
8081 Defer all WebCore timers when a modal dialog is up. They are not
8082 safe to execute.
8083
8084 * page/Chrome.cpp:
8085 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
8086 (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
8087
simon.fraser@apple.com7dbde252008-08-27 23:16:36 +000080882008-08-27 Chris Marrin <cmarrin@apple.com>
8089
8090 Reviewed by Dave Hyatt
8091
8092 Memory leaks when animating transforms
8093 https://bugs.webkit.org/show_bug.cgi?id=20532
8094
8095 * rendering/style/RenderStyle.cpp:
8096 (WebCore::ScaleTransformOperation::blend):
8097 (WebCore::RotateTransformOperation::blend):
8098 (WebCore::SkewTransformOperation::blend):
8099 (WebCore::TranslateTransformOperation::blend):
8100 (WebCore::MatrixTransformOperation::blend):
8101 * rendering/style/RenderStyle.h:
8102
timothy@apple.com79cb13a2008-08-27 22:03:24 +000081032008-08-27 Timothy Hatcher <timothy@apple.com>
8104
8105 Add support for support for -webkit-appearance: default-button on the Mac platform.
8106
8107 <rdar://problem/6173530>
8108
8109 Reviewed by Dave Hyatt.
8110
8111 * WebCore.base.exp: Export new symbols.
8112 * platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation.
8113 * platform/mac/WebCoreSystemInterface.mm: Ditto.
8114 * rendering/RenderButton.cpp:
8115 (WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN).
8116 (WebCore::RenderButton::setStyle): Ditto.
8117 * rendering/RenderButton.h: Ditto.
8118 * rendering/RenderThemeMac.mm:
8119 (WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance.
8120 (WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return
8121 key if the button is default, otherwise reset the key equivalent.
8122 (WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell:
8123 on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore
8124 the window's previous default button cell when finished.
8125
hyatt@apple.comf0ec84d2008-08-27 21:18:15 +000081262008-08-26 David Hyatt <hyatt@apple.com>
8127
8128 First cut at making form controls on OS X respect full page zoom. There are lots of bugs.
8129
8130 Reviewed by weinig
8131
8132 Added fast/forms/zoomed-controls.html
8133
8134 * css/CSSStyleSelector.cpp:
8135 (WebCore::addIntrinsicMargins):
8136 * rendering/RenderSlider.cpp:
8137 (WebCore::RenderSlider::calcPrefWidths):
8138 * rendering/RenderThemeMac.h:
8139 * rendering/RenderThemeMac.mm:
8140 (WebCore::RenderThemeMac::adjustRepaintRect):
8141 (WebCore::RenderThemeMac::inflateRect):
8142 (WebCore::RenderThemeMac::baselinePosition):
8143 (WebCore::RenderThemeMac::setControlSize):
8144 (WebCore::RenderThemeMac::sizeForFont):
8145 (WebCore::RenderThemeMac::sizeForSystemFont):
8146 (WebCore::RenderThemeMac::setFontFromControlSize):
8147 (WebCore::RenderThemeMac::paintCheckbox):
8148 (WebCore::RenderThemeMac::setCheckboxCellState):
8149 (WebCore::RenderThemeMac::paintRadio):
8150 (WebCore::RenderThemeMac::setRadioCellState):
8151 (WebCore::RenderThemeMac::setButtonPaddingFromControlSize):
8152 (WebCore::RenderThemeMac::adjustButtonStyle):
8153 (WebCore::RenderThemeMac::setButtonCellState):
8154 (WebCore::RenderThemeMac::paintButton):
8155 (WebCore::RenderThemeMac::paintMenuList):
8156 (WebCore::RenderThemeMac::paintMenuListButton):
8157 (WebCore::RenderThemeMac::popupInternalPaddingLeft):
8158 (WebCore::RenderThemeMac::popupInternalPaddingRight):
8159 (WebCore::RenderThemeMac::popupInternalPaddingTop):
8160 (WebCore::RenderThemeMac::popupInternalPaddingBottom):
8161 (WebCore::RenderThemeMac::setPopupButtonCellState):
8162 (WebCore::RenderThemeMac::paintSliderTrack):
8163 (WebCore::RenderThemeMac::paintSliderThumb):
8164 (WebCore::RenderThemeMac::adjustSliderThumbSize):
8165 (WebCore::RenderThemeMac::paintSearchField):
8166 (WebCore::RenderThemeMac::adjustSearchFieldStyle):
8167 (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
8168 (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
8169
beidson@apple.comd0793872008-08-27 19:59:55 +000081702008-08-27 Brady Eidson <beidson@apple.com>
8171
8172 Reviewed by Anders
8173
8174 <rdar://problem/6134133> - Crash when loading large movie as a standalone document
8175
8176 We hand off these loads to Quicktime which manages and spools the data itself, but we also continued
8177 to load and buffer the data for the movie in WebCore. With large media files, this results in blowing
8178 away the virtual address space and a crash.
8179
8180 * loader/EmptyClients.h:
8181 (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
8182 * loader/FrameLoaderClient.h: Added client method to get platform specific error for
8183 "plugin will handle load"
8184
8185 * loader/MediaDocument.cpp:
8186 (WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data,
8187 and cancel the WebCore-managed load
8188 (WebCore::MediaTokenizer::writeRawData):
8189 (WebCore::MediaTokenizer::finish):
8190
simon.fraser@apple.come74d6712008-08-27 18:19:55 +000081912008-08-26 Simon Fraser <simon.fraser@apple.com>
8192
8193 Reviewed by Eric Seidel
8194
8195 Linear timing functions should have control points 0, 0, 1, 1.
8196 https://bugs.webkit.org/show_bug.cgi?id=20535
8197
8198 * css/CSSStyleSelector.cpp:
8199 (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
8200 * rendering/style/RenderStyle.h:
8201
aroben@apple.com8cfb6c62008-08-27 14:52:17 +000082022008-08-27 Adam Roben <aroben@apple.com>
8203
8204 Windows build fix
8205
8206 * WebCore.vcproj/WebCore.vcproj: Fix file extension.
8207
mrowe@apple.com37686d42008-09-04 00:10:39 +000082082008-08-26 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com33a556b2008-08-26 22:29:14 +00008209
cfleizach@apple.comc6ebe3d2008-08-26 22:43:22 +00008210 Reviewed by Beth Dakin.
8211
cfleizach@apple.com2a505f42008-08-26 22:56:03 +00008212 <rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown
8213
8214 Added platform-specific accessibilityIgnoreAttachment, which allows the platform
8215 to determine if an attachment is ignored through accessibility. Added equivalent
8216 methods in Gtk, Win and Mac
8217
8218 Test: accessibility/plugin.html
8219
8220 * GNUmakefile.am:
8221 * WebCore.vcproj/WebCore.vcproj:
8222 * WebCore.xcodeproj/project.pbxproj:
8223 * page/AccessibilityObject.h:
8224 * page/AccessibilityRenderObject.cpp:
8225 (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
8226 * page/gtk/AccessibilityObjectAtk.cpp: Added.
8227 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
8228 * page/mac/AccessibilityObjectMac.mm: Added.
8229 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
8230 * page/mac/AccessibilityObjectWrapper.h:
8231 * page/win/AccessibilityObjectWin.cpp: Added.
8232 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
8233
mrowe@apple.com37686d42008-09-04 00:10:39 +000082342008-08-26 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com2a505f42008-08-26 22:56:03 +00008235
8236 Reviewed by Beth Dakin.
8237
cfleizach@apple.comc6ebe3d2008-08-26 22:43:22 +00008238 <rdar://problem/5817770> can't bring up contextual menu for embedded objects in WebText
8239
8240 * page/mac/AccessibilityObjectWrapper.mm:
8241 (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
8242 (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
8243
mrowe@apple.com37686d42008-09-04 00:10:39 +000082442008-08-26 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.comc6ebe3d2008-08-26 22:43:22 +00008245
cfleizach@apple.com33a556b2008-08-26 22:29:14 +00008246 Reviewed by Darin Adler.
8247
8248 <rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns
8249
8250 Tests: accessibility/table-notbody.html
8251
8252 * page/AccessibilityTable.cpp:
8253 (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
8254
weinig@apple.com33705852008-08-26 19:51:28 +000082552008-08-26 Sam Weinig <sam@webkit.org>
8256
weinig@apple.comf6f553a2008-08-26 21:21:26 +00008257 Reviewed by Beth Dakin.
8258
8259 Fix typo.
8260
8261 * dom/DOMCoreException.h:
8262
82632008-08-26 Sam Weinig <sam@webkit.org>
8264
weinig@apple.com0f34f002008-08-26 19:56:54 +00008265 Reviewed by Oliver Hunt.
8266
8267 Fix https://bugs.webkit.org/show_bug.cgi?id=20479
8268 <rdar://problem/6167660>
8269 Take image redirects into account when tainting the canvas.
8270
8271 Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html
8272
8273 * html/CanvasRenderingContext2D.cpp:
8274 (WebCore::CanvasRenderingContext2D::drawImage):
8275 (WebCore::CanvasRenderingContext2D::drawImageFromRect):
8276
82772008-08-26 Sam Weinig <sam@webkit.org>
8278
weinig@apple.com33705852008-08-26 19:51:28 +00008279 Reviewed by Darin Adler.
8280
8281 Change canvas tainting logic to ask the image if it contains
8282 any resources outside of its own origin. Since there is no
8283 way to determine if SVG images contain any resources outside its
8284 origin, we always assume it does.
8285
8286 * html/CanvasRenderingContext2D.cpp:
8287 (WebCore::CanvasRenderingContext2D::drawImage):
8288 (WebCore::CanvasRenderingContext2D::drawImageFromRect):
8289 * platform/graphics/BitmapImage.h:
8290 (WebCore::BitmapImage::hasSingleSecurityOrigin):
8291 * platform/graphics/GeneratedImage.h:
8292 (WebCore::GeneratedImage::hasSingleSecurityOrigin):
8293 * platform/graphics/Image.h:
8294 (WebCore::Image::hasSingleSecurityOrigin):
8295 * platform/graphics/cg/PDFDocumentImage.h:
8296 (WebCore::PDFDocumentImage::hasSingleSecurityOrigin):
8297 * svg/graphics/SVGImage.h:
8298
britto@apple.com616ef6d2008-08-26 17:51:03 +000082992008-08-26 Maxime Britto <britto@apple.com>
8300
8301 Reviewed by Adele.
8302
8303 <rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com)
8304 This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area.
8305 This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls.
8306
8307 * page/EventHandler.cpp:
8308 (WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning
8309 * page/EventHandler.h:
8310 * rendering/RenderLayer.cpp:
8311 (WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta
8312 (WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so.
8313 * rendering/RenderLayer.h:
8314 * rendering/RenderObject.cpp:
8315 (WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled
8316 (WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method
8317 (WebCore::RenderObject::panScroll): No need to check for the layer anymore too.
8318
jchaffraix@webkit.orge6915392008-08-26 10:27:33 +000083192008-08-25 Julien Chaffraix <jchaffraix@webkit.org>
8320
darin@apple.com07c80c62008-09-05 18:15:43 +00008321 Reviewed by Darin Adler.
jchaffraix@webkit.orge6915392008-08-26 10:27:33 +00008322
8323 Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it
8324 https://bugs.webkit.org/show_bug.cgi?id=20247
8325
8326 <rdar://problem/6118218>
8327
8328 Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive
8329 check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute
8330 (case insensitive for HTML elements).
8331
8332 Test: fast/dom/Element/getAttribute-check-case-sensitivity.html
8333
8334 * dom/Element.cpp:
8335 (WebCore::Element::getAttribute):
8336 * dom/NamedAttrMap.cpp:
8337 (WebCore::NamedAttrMap::getNamedItem):
8338 (WebCore::NamedAttrMap::getAttributeItem):
8339 * dom/NamedAttrMap.h:
8340
weinig@apple.comb4ce06e2008-08-26 01:52:51 +000083412008-08-25 Sam Weinig <sam@webkit.org>
8342
weinig@apple.com8d3ea722008-08-26 04:19:07 +00008343 Reviewed by Oliver Hunt.
8344
8345 Fix for https://bugs.webkit.org/show_bug.cgi?id=20514
8346 <rdar://problem/6174096>
8347 Treat SVG images as dirty when drawing to a canvas.
8348
8349 Test: http/tests/security/canvas-remote-read-svg-image.html
8350
8351 * html/CanvasRenderingContext2D.cpp:
8352 (WebCore::CanvasRenderingContext2D::drawImage):
8353 (WebCore::CanvasRenderingContext2D::drawImageFromRect):
8354 * platform/graphics/Image.h:
8355 (WebCore::Image::isSVGImage):
8356 * svg/graphics/SVGImage.h:
8357 (WebCore::SVGImage::isSVGImage):
8358
83592008-08-25 Sam Weinig <sam@webkit.org>
8360
weinig@apple.comb4ce06e2008-08-26 01:52:51 +00008361 Reviewed by Mark Rowe.
8362
8363 Fix https://bugs.webkit.org/show_bug.cgi?id=20377
8364 Leak in XMLHttpRequest.
8365
8366 * xml/XMLHttpRequest.cpp:
8367 (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
8368
beidson@apple.com46421212008-08-25 21:48:56 +000083692008-08-25 Brady Eidson <beidson@apple.com>
8370
8371 Reviewed by Anders
8372
8373 Speculative fix for <rdar://problem/6173217>
8374
8375 Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
8376 Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
8377 the first null check invalid.
8378
8379 * loader/FrameLoader.cpp:
8380 (WebCore::FrameLoader::stopAllLoaders):
8381
8382
kmccullough@apple.com7b85fbb2008-08-25 21:28:40 +000083832008-08-25 Kevin McCullough <kmccullough@apple.com>
8384
8385 Reviewed by Tim.
8386
8387 <rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
8388 there is no profile, can cause crash
8389
8390 * page/inspector/ProfilesPanel.js:
8391
dino@apple.com1baeea62008-08-25 21:06:21 +000083922008-08-25 Dean Jackson <dino@apple.com>
8393
8394 Reviewed by Dave Hyatt
8395
8396 Make sure 'inherit' is handled by transition property.
8397 https://bugs.webkit.org/show_bug.cgi?id=20513
8398
8399 Test: transitions/inherit.html
8400 Test: transitions/inherit-other-props.html
8401
8402 * css/CSSStyleSelector.cpp:
8403 fix macro to check existence of list before getting size
8404
andersca@apple.com2866b8302008-08-25 20:56:21 +000084052008-08-25 Anders Carlsson <andersca@apple.com>
8406
8407 Reviewed by Mark.
8408
8409 <rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.
8410
8411 Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume
8412 (safely) that any class that needs finalization on the main thread will also need to be deallocated
8413 on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
8414 calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.
8415
8416 * platform/mac/WebCoreObjCExtras.c:
8417 (WebCoreObjCFinalizeOnMainThread):
8418
antti@apple.com60381cb2008-08-25 20:41:11 +000084192008-08-25 Antti Koivisto <antti@apple.com>
8420
8421 Reviewed by Dan Bernstein.
8422
8423 Rename CachedResource::referenced() to CachedResource::hasClients() to
8424 match previous ref() -> addClient() rename.
8425
8426 * loader/Cache.cpp:
8427 (WebCore::Cache::pruneLiveResources):
8428 (WebCore::Cache::pruneDeadResources):
8429 (WebCore::Cache::remove):
8430 (WebCore::Cache::getStatistics):
8431 (WebCore::Cache::dumpLRULists):
8432 * loader/CachedResource.cpp:
8433 (WebCore::CachedResource::addClient):
8434 (WebCore::CachedResource::removeClient):
8435 (WebCore::CachedResource::setDecodedSize):
8436 (WebCore::CachedResource::setEncodedSize):
8437 * loader/CachedResource.h:
8438 (WebCore::CachedResource::hasClients):
8439 (WebCore::CachedResource::canDelete):
8440
timothy@apple.com7d809242008-08-25 18:33:05 +000084412008-08-25 Anthony Ricaud <rik24d@gmail.com>
8442
8443 Add a missing Inspector localized string for "other".
8444
8445 https://bugs.webkit.org/show_bug.cgi?id=20509
8446
8447 Reviewed by Tim Hatcher.
8448
8449 * English.lproj/localizedStrings.js:
8450
kmccullough@apple.com560f5fe2008-08-25 18:18:01 +000084512008-08-22 Kevin McCullough <kmccullough@apple.com>
8452
8453 Reviewed by Geoff, Mark and Tim.
8454
8455 <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
8456 in the console said what file and line number they came from
8457 - Lay the foundation for getting line numbers and other data from the
8458 JavaScript engine.
8459
8460 * ForwardingHeaders/VM: Added.
8461 * ForwardingHeaders/VM/Machine.h: Added.
8462 * page/Console.cpp: Gather the line number and file information when
8463 profileEnd has been called, but don't use it until didFinishProfiling is
8464 called. We won't need to wait once we remove the profiler "zombie" mode
8465 which this patch helps pave the foundation for.
8466 (WebCore::Console::Console):
8467 (WebCore::Console::profileEnd):
8468 (WebCore::Console::finishedProfiling):
8469 * page/Console.h:
8470 * page/InspectorController.cpp: Modify calls to
8471 addProfileMessageToConsole to satisfy the new arguments it takes.
8472 (WebCore::InspectorController::finishedProfiling):
8473 (WebCore::InspectorController::addProfile):
8474 (WebCore::InspectorController::addProfileMessageToConsole):
8475 (WebCore::InspectorController::finishedProfiling):
8476 * page/InspectorController.h:
8477
hausmann@webkit.orgf305df42008-08-25 10:06:53 +000084782008-08-25 Holger Hans Peter Freyther <zecke@selfish.org>
8479
8480 Reviewed by Simon.
8481
8482 [inspector] Update the WebKit.qrc Qt resources file
8483 Catchup with the changes in the directory.
8484
8485 * page/inspector/WebKit.qrc:
8486
hausmann@webkit.org5f13af32008-08-25 07:10:22 +000084872008-08-25 Dirk Schulze <vbs85@gmx.de>
8488
8489 Reviewed by Simon.
8490
8491 Transformed the radian to degree, to get rotate()
8492 in canvas work as expected.
8493
8494 [Qt] Canvas.rotate() doesn't work
8495 https://bugs.webkit.org/show_bug.cgi?id=20496
8496
8497 * platform/graphics/qt/GraphicsContextQt.cpp:
8498 (WebCore::GraphicsContext::rotate):
8499
sfalken@apple.com9d442862008-08-25 05:43:33 +000085002008-08-24 Steve Falkenburg <sfalken@apple.com>
8501
8502 Add a "last chance" WM_TIMER to the Windows shared timer.
8503
8504 The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
8505 Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
8506 timers if a timer with an earlier expiration is already pending. This results in no timers
8507 firing from that point on.
8508
8509 We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
8510 buggy window message hook.
8511
8512 This timer will start when the first WM_TIMER is scheduled, and will
8513 fire every 5 seconds thereafter, causing any lost timers to be fired.
8514
8515 Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
8516 and prevents the WebFrame leak.
8517
8518 Reviewed by Darin Adler, Geoff Garen.
8519
8520 * platform/win/SharedTimerWin.cpp:
8521 (WebCore::):
8522 (WebCore::TimerWindowWndProc):
8523 (WebCore::setSharedTimerFireTime):
8524
mitz@apple.com771fb752008-08-25 03:22:44 +000085252008-08-24 Dan Bernstein <mitz@apple.com>
8526
8527 Reviewed by Darin Adler.
8528
8529 - fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
8530
8531 Test: fast/css/font-property-priority.html
8532
8533 * css/CSSParser.cpp:
8534 (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag
8535 to the font-property-parsing functions.
8536 (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and
8537 changed to use it rather than the m_important member.
8538 (WebCore::CSSParser::parseFontVariant): Ditto.
8539 (WebCore::CSSParser::parseFontWeight): Ditto.
8540 * css/CSSParser.h:
8541
timothy@apple.com4cea2632008-08-24 22:28:44 +000085422008-08-24 Timothy Hatcher <timothy@apple.com>
8543
8544 Fixes a bug where the Inspector's UI would not animate or
8545 fully function because JavaScript timeouts, intervals and
8546 CSS animation timers where not firing while paused at a
8547 a breakpoint in the inspected page.
8548
8549 https://bugs.webkit.org/show_bug.cgi?id=20042
8550
8551 Reviewed by Darin Adler.
8552
8553 Test: manual-tests/inspector/forzen-ui-while-paused.html
8554
8555 * page/JavaScriptDebugServer.cpp:
8556 (WebCore::JavaScriptDebugServer::pauseIfNeeded):
8557 Add a call to TimerBase::fireTimersInNestedEventLoop before
8558 spinning the EventLoop.
8559
rwlbuis@webkit.org8a772442008-08-24 18:07:32 +000085602008-08-24 Rob Buis <buis@kde.org>
8561
8562 Reviewed by Sam Weinig.
8563
8564 https://bugs.webkit.org/show_bug.cgi?id=20324
8565 A change in SVG Glyph wont show up
8566
8567 Invalidate the glyph cache when the d attribute is set.
8568
8569 Test: svg/custom/glyph-setting-d-attribute.svg
8570
8571 * svg/SVGGlyphElement.cpp:
8572 (WebCore::SVGGlyphElement::invalidateGlyphCache):
8573 (WebCore::SVGGlyphElement::parseMappedAttribute):
8574 (WebCore::SVGGlyphElement::insertedIntoDocument):
8575 (WebCore::SVGGlyphElement::removedFromDocument):
8576 * svg/SVGGlyphElement.h:
8577
mitz@apple.com5b2c3cc2008-08-24 09:18:39 +000085782008-08-24 Dan Bernstein <mitz@apple.com>
8579
8580 Reviewed by Sam Weinig.
8581
8582 - fix https://bugs.webkit.org/show_bug.cgi?id=13864
8583 <rdar://problem/5451470> REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths()
8584
8585 * rendering/RenderText.cpp:
8586 (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to
8587 beginWS and endWS before the early return to ensure that they are
8588 initialized in that case.
8589
cwzwarich@webkit.org53ddf172008-08-23 08:16:54 +000085902008-08-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
8591
8592 Rubber-stamped by Mark Rowe.
8593
8594 Remove modelines.
8595
8596 * WebCore.pro:
8597 * bridge/testbindings.cpp:
8598 * dom/DocPtr.h:
8599 * loader/SubstituteData.h:
8600 * page/Chrome.cpp:
8601 * page/Chrome.h:
8602 * page/ChromeClient.h:
8603 * page/Frame.h:
8604 * page/FrameLoadRequest.h:
8605 * page/FrameTree.cpp:
8606 * page/FrameTree.h:
8607 * page/Page.h:
8608 * page/mac/ChromeMac.mm:
8609 * platform/network/HTTPHeaderMap.h:
8610 * platform/network/ResourceErrorBase.cpp:
8611 * platform/network/ResourceErrorBase.h:
8612 * platform/network/ResourceHandleInternal.h:
8613 * platform/network/ResourceRequestBase.cpp:
8614 * platform/network/ResourceRequestBase.h:
8615 * platform/network/ResourceResponseBase.cpp:
8616 * platform/network/ResourceResponseBase.h:
8617 * platform/network/cf/ResourceError.h:
8618 * platform/network/cf/ResourceRequest.h:
8619 * platform/network/cf/ResourceRequestCFNet.h:
8620 * platform/network/cf/ResourceResponse.h:
8621 * platform/network/cf/ResourceResponseCFNet.h:
8622 * platform/network/curl/ResourceError.h:
8623 * platform/network/curl/ResourceRequest.h:
8624 * platform/network/curl/ResourceResponse.h:
8625 * platform/network/mac/ResourceError.h:
8626 * platform/network/mac/ResourceErrorMac.mm:
8627 * platform/network/mac/ResourceRequest.h:
8628 * platform/network/mac/ResourceRequestMac.mm:
8629 * platform/network/mac/ResourceResponse.h:
8630 * platform/network/mac/ResourceResponseMac.mm:
8631 * platform/network/qt/ResourceError.h:
8632 * platform/network/qt/ResourceRequest.h:
8633 * platform/network/qt/ResourceResponse.h:
8634 * platform/network/soup/CookieJarSoup.cpp:
8635 * platform/network/soup/ResourceError.h:
8636 * platform/network/soup/ResourceRequest.h:
8637 * platform/network/soup/ResourceResponse.h:
8638
mitz@apple.com57a2f482008-08-23 07:16:41 +000086392008-08-23 Dan Bernstein <mitz@apple.com>
8640
8641 Reviewed by Dave Hyatt.
8642
8643 - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
8644
8645 Test: fast/table/vertical-align-baseline.html
8646
8647 * rendering/RenderTable.cpp:
8648 (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
8649 baseline of the first table row, if there is one, -1 otherwise.
8650 * rendering/RenderTable.h:
8651 * rendering/RenderTableCell.cpp:
8652 (WebCore::RenderTableCell::baselinePosition): Changed to follow the
8653 CSS2.1 definition of the baseline of a table cell.
8654 * rendering/RenderTableSection.cpp:
8655 (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
8656 the baseline of the first row in the section.
8657 * rendering/RenderTableSection.h:
8658
jhoneycutt@apple.com88af18d2008-08-22 23:44:32 +000086592008-08-18 Jon Honeycutt <jhoneycutt@apple.com>
8660
8661 Add SPI to make a Windows WebView transparent.
8662
8663 Reviewed by Dan Bernstein.
8664
8665 * platform/graphics/GraphicsContext.h: Add a parameter, hasAlpha, that
8666 determines whether the created context has an alpha channel.
8667 * platform/graphics/win/GraphicsContextCGWin.cpp:
8668 (WebCore::CGContextWithHDC):
8669
timothy@apple.comb63d1172008-08-22 18:39:42 +000086702008-08-22 Timothy Hatcher <timothy@apple.com>
8671
timothy@apple.com964022d2008-08-22 20:35:20 +00008672 Rolls out r35834 because it caused a regression in the Inspector's
8673 Console where some expressions always threw a syntax error.
8674
8675 https://bugs.webkit.org/show_bug.cgi?id=20487
8676
8677 * page/inspector/Console.js:
8678 (Console.prototype._evalInInspectedWindow): Removes parenthesis
8679 around the expression.
8680
86812008-08-22 Timothy Hatcher <timothy@apple.com>
8682
timothy@apple.com056d4782008-08-22 18:39:52 +00008683 Makes getStyleProperty return a value for the overflow property
8684 when overflow-x and overflow-y are equal.
8685
8686 https://bugs.webkit.org/show_bug.cgi?id=20485
8687
8688 Reviewed by Dan Bernstein.
8689
8690 Test: fast/css/overflow-property.html
8691
8692 * css/CSSMutableStyleDeclaration.cpp:
8693 (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
8694
86952008-08-22 Timothy Hatcher <timothy@apple.com>
8696
timothy@apple.comb63d1172008-08-22 18:39:42 +00008697 Fixes a bug where while editing in the Inspector the
8698 sidebar scroll position would jump to the top.
8699
8700 https://bugs.webkit.org/show_bug.cgi?id=20484
8701
8702 Reviewed by Darin Adler.
8703
8704 * page/inspector/treeoutline.js:
8705 (TreeOutline._removeChildren): Remove the offsetTop call that
8706 was forcing a layout, since layout causes scroll positions
8707 to be clamped to the new scrollHeight/Width. Layout will happen
8708 normally when needed.
8709
kevino@webkit.org8271c842008-08-22 16:25:52 +000087102008-08-22 Kevin Ollivier <kevino@theolliviers.com>
8711
8712 wx build fix. Add AccessibilityTable sources.
8713
8714 * WebCoreSources.bkl:
8715
mitz@apple.com9befc872008-08-22 06:29:33 +000087162008-08-21 Dan Bernstein <mitz@apple.com>
8717
8718 Reviewed by Jon Honeycutt and Alexey Proskuryakov.
8719
8720 - fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
8721
8722 Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
8723
8724 * platform/graphics/mac/SimpleFontDataMac.mm:
8725 (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
8726 ascent and 100% to its reported descent.
8727
mrowe@apple.comac9b6a52008-08-22 02:07:54 +000087282008-08-21 Kalle Vahlman <kalle.vahlman@movial.com>
8729
8730 Reviewed by Darin Adler.
8731
mrowe@apple.com22eaa172008-08-22 02:10:15 +00008732 https://bugs.webkit.org/show_bug.cgi?id=20267
mrowe@apple.comac9b6a52008-08-22 02:07:54 +00008733 [GTK] Crash on some pages due to a plugin
8734
8735 Fix handling of badly formatted and empty plugin mime descriptions
8736
8737 * plugins/gtk/PluginPackageGtk.cpp:
8738 (WebCore::PluginPackage::fetchInfo):
8739
mrowe@apple.com798b3432008-08-22 02:07:48 +000087402008-08-21 Kevin Watters <kevinwatters@gmail.com>
8741
8742 Reviewed by Darin Adler.
8743
8744 Follow other ports (and IE) in ImageSourceWx.cpp never to return an
8745 animated GIF frame duration of less than 50ms.
8746
8747 * platform/graphics/wx/ImageSourceWx.cpp:
8748 (WebCore::ImageSource::frameDurationAtIndex):
8749
britto@apple.com8ed72772008-08-22 00:39:39 +000087502008-08-21 Maxime Britto <britto@apple.com>
8751
8752 Reviewed by Kevin McCullough.
8753
8754 Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
8755 https://bugs.webkit.org/show_bug.cgi?id=20451
8756
8757 rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
8758 When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
8759 This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.
8760
8761 * page/EventHandler.cpp:
8762 (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.
8763
8764 (WebCore::EventHandler::handleMousePressEvent): ditto
8765
timothy@apple.com5d492192008-08-21 23:54:01 +000087662008-08-21 Anthony Ricaud <rik24d@gmail.com>
8767
8768 Small optimization for when the dividers in the Inspector's
8769 Resources panel are updated.
8770
8771 Reviewed by Tim Hatcher.
8772
8773 * page/inspector/ResourcesPanel.js:
8774 (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
8775 Combind a for loop and clone the divider element.
8776
dino@apple.comaa75e4c2008-08-21 23:35:23 +000087772008-08-21 Chris Marrin <cmarrin@apple.com>
8778
8779 Allow 0 (without units) for Time eg. duration
8780 Fix for https://bugs.webkit.org/show_bug.cgi?id=20467
8781
8782 Reviewed by Dave Hyatt.
8783
8784 Test: css1/units/zero-duration-without-units.html
8785
8786 * css/CSSParser.cpp:
8787 (WebCore::CSSParser::validUnit):
8788
timothy@apple.com29c12d02008-08-21 20:12:47 +000087892008-08-21 Timothy Hatcher <timothy@apple.com>
8790
timothy@apple.comca11cd82008-08-21 20:13:12 +00008791 Make deleting all text while editing a DOM attribute in
8792 the Inspector delete the attribute. This also fixes
8793 an exception that would happen before.
8794
8795 https://bugs.webkit.org/show_bug.cgi?id=20472
8796
8797 Reviewed by Kevin McCullough.
8798
8799 * page/inspector/ElementsPanel.js:
8800 (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted):
8801 Don't check for hasAttributes on the parseElement, continuing
8802 through the function will correctly remove the attribute.
8803 If the parseElement is null, call _editingCancelled not
8804 editingCancelled, this fixes an exception.
8805
88062008-08-21 Timothy Hatcher <timothy@apple.com>
8807
timothy@apple.comde831cf2008-08-21 20:12:59 +00008808 Update the Inspector's Metrics pane when editing in
8809 the Styles pane. This makes sure the metrics shown
8810 always match what the Styles pane shows.
8811
8812 https://bugs.webkit.org/show_bug.cgi?id=20470
8813
8814 Reviewed by Kevin McCullough.
8815
8816 * page/inspector/ElementsPanel.js:
8817 (WebInspector.ElementsPanel): Add event listeners for
8818 the "style edited" and "style property toggled" events,
8819 so the Metrics pane is updated.
8820 (WebInspector.ElementsPanel.prototype._stylesPaneEdited):
8821 Update the Metrics pane.
8822 * page/inspector/StylesSidebarPane.js:
8823 (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
8824 Dispatch the "style property toggled" event.
8825 (WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
8826 Dispatch the "style edited" event when the CSS text is restored.
8827 (WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
8828 Dispatch the "style edited" event.
8829
88302008-08-21 Timothy Hatcher <timothy@apple.com>
8831
timothy@apple.com29c12d02008-08-21 20:12:47 +00008832 Make the Inspector's Metrics sidebar pane editable.
8833
8834 https://bugs.webkit.org/show_bug.cgi?id=17218
8835 rdar://problem/5732818
8836
8837 Reviewed by Kevin McCullough.
8838
8839 * page/inspector/ElementsPanel.js:
8840 (WebInspector.ElementsPanel): Add an event listener for
8841 the "metrics edited" event, so the Styles pane is updated.
8842 * page/inspector/MetricsSidebarPane.js:
8843 (WebInspector.MetricsSidebarPane.prototype.update): Remember the node
8844 so future updates work. Add a double click event listener for the
8845 metric values to start editing.
8846 (WebInspector.MetricsSidebarPane.prototype.startEditing):
8847 Call WebInspector.startEditing with some context.
8848 (WebInspector.MetricsSidebarPane.prototype.editingCancelled):
8849 (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
8850 Set the user input on the elements inline style. Fire the
8851 "metrics edited" event.
8852
sfalken@apple.com7e6e5392008-08-21 18:42:44 +000088532008-08-21 Steve Falkenburg <sfalken@apple.com>
8854
8855 Fix a race condition in Windows timer code.
8856 Timer function could end up being called with a 0 timer, leading to a Windows exception.
8857
8858 Don't post a timer message if one is already pending.
8859
8860 Reviewed by Ada Chan.
8861
8862 * platform/win/SharedTimerWin.cpp:
8863 (WebCore::TimerWindowWndProc):
8864 (WebCore::clearTimer):
8865 (WebCore::queueTimerProc):
8866 (WebCore::setSharedTimerFireTime):
8867
timothy@apple.com8d15bcf2008-08-21 16:33:17 +000088682008-08-21 Anthony Ricaud <rik24d@gmail.com>
8869
timothy@apple.com493212c72008-08-21 16:36:06 +00008870 After trying to add the expression, try again with quotes for
8871 easier edition.
8872
8873 https://bugs.webkit.org/show_bug.cgi?id=20466
8874
8875 Reviewed by Tim Hatcher.
8876
8877 * page/inspector/ObjectPropertiesSection.js: Added an
8878 evaluateExpression function.
8879
88802008-08-21 Anthony Ricaud <rik24d@gmail.com>
8881
timothy@apple.com8d15bcf2008-08-21 16:33:17 +00008882 Perform Inspector searches on search event to clear results when
8883 clicking the cross to empty it. Delete the lastQuery when the field
8884 is emptied in order to perform the search if exactly the same query
8885 is entered next.
8886
8887 https://bugs.webkit.org/show_bug.cgi?id=20462
8888
8889 Reviewed by Tim Hatcher.
8890
8891 * page/inspector/inspector.js:
8892
jmalonzo@webkit.orgdd470402008-08-21 11:22:51 +000088932008-08-21 Marco Barisione <marco.barisione@collabora.co.uk>
8894
8895 Reviewed by Mark Rowe.
8896
8897 http://bugs.webkit.org/show_bug.cgi?id=19656
8898 [SOUP] The gio code should call didFail() instead of
8899 didFinishLoading() in case of error
8900
8901 In case of error call didFail() instead of didReceiveResponse() and
8902 didFinishLoading().
8903
8904 * platform/network/soup/ResourceHandleSoup.cpp:
8905 (WebCore::networkErrorForFile):
8906 (WebCore::readCallback):
8907 (WebCore::openCallback):
8908 (WebCore::queryInfoCallback):
8909
mrowe@apple.com72a95b12008-08-21 04:01:51 +000089102008-08-20 Mark Rowe <mrowe@apple.com>
8911
mrowe@apple.com4e593f42008-08-21 06:52:42 +00008912 Reviewed by Jon Honeycutt.
8913
8914 Fix build failure.
8915
8916 * bridge/c/c_instance.cpp:
8917 (KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
8918 as that is what NPEnumerationFunctionPtr is declared as accepting.
8919
89202008-08-20 Mark Rowe <mrowe@apple.com>
8921
mrowe@apple.com72a95b12008-08-21 04:01:51 +00008922 Reviewed by Dan Bernstein.
8923
8924 Build fix. Handle kCGInterpolationMedium in switch statements if it is available.
8925
8926 * platform/graphics/GraphicsContext.h:
8927 (WebCore::):
8928 * platform/graphics/cg/GraphicsContextCG.cpp:
8929 (WebCore::GraphicsContext::setImageInterpolationQuality):
8930 (WebCore::GraphicsContext::imageInterpolationQuality):
8931
mitz@apple.comaa938792008-08-21 00:33:29 +000089322008-08-20 Dan Bernstein <mitz@apple.com>
8933
8934 Rubber-stamped by John Sullivan.
8935
8936 - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and
8937 rename related methods and variables accordingly.
8938
8939 * WebCore.base.exp:
8940 * page/FrameView.cpp:
8941 (WebCore::FrameViewPrivate::FrameViewPrivate):
8942 (WebCore::FrameView::shouldUpdateWhileOffscreen):
8943 (WebCore::FrameView::setShouldUpdateWhileOffscreen):
8944 * page/FrameView.h:
8945 * platform/ScrollView.h:
8946 * platform/mac/ScrollViewMac.mm:
8947 (WebCore::ScrollView::updateContents):
8948
beidson@apple.com2ace6b12008-08-21 00:13:12 +000089492008-08-20 Brady Eidson <beidson@apple.com>
8950
8951 Reviewed by Mitzpettel
8952
8953 <rdar://problem/6163636> - Many images broken in Mail
8954
8955 This can be traced back to the preload scanner. With that change, CachedResources are created a lot
8956 sooner than before and confuse the WebArchive machinery.
8957
8958 When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
8959 such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
8960 machinery and nothing is known about where the data will eventually come from.
8961
8962 * loader/DocumentLoader.cpp:
8963 (WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is
8964 CachedResource::PreloadReferenced.
8965
zecke@webkit.orga8fa0e12008-08-20 22:50:39 +000089662008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>
8967
8968 Unreviewed compile fix
8969
8970 Catch up with the JSValue::type elimination.
8971
8972 * bridge/qt/qt_instance.cpp:
8973 (KJS::Bindings::QtRuntimeObjectImp::construct):
8974 (KJS::Bindings::QtInstance::defaultValue):
8975 * bridge/qt/qt_runtime.cpp:
8976 (KJS::Bindings::QtRuntimeConnectionMethod::call):
8977
mrowe@apple.com2d74ec92008-08-20 22:15:53 +000089782008-08-20 Chris Teague <chris.teague@gmail.com>
8979
8980 Reviewed by Mark Rowe.
8981
8982 Fix https://bugs.webkit.org/show_bug.cgi?id=20449
8983 Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined
8984
8985 * ChangeLog:
8986 * loader/FrameLoader.cpp:
8987 (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
8988
simon.fraser@apple.combe1d24c2008-08-20 21:57:22 +000089892008-08-20 Simon Fraser <simon.fraser@apple.com>
8990
8991 Reviewed by Dave Hyatt
8992
8993 getComputedStyle() for webkitTransform should return a transform
8994 that does not have the transform origin baked into it.
8995 https://bugs.webkit.org/show_bug.cgi?id=20464
8996
8997 Test: fast/css/getComputedStyle-transform.html
8998
8999 * css/CSSComputedStyleDeclaration.cpp:
9000 (WebCore::computedTransform):
9001 * rendering/style/RenderStyle.cpp:
9002 (WebCore::RenderStyle::applyTransform):
9003 * rendering/style/RenderStyle.h:
9004
andersca@apple.com021ce772008-08-20 21:04:12 +000090052008-08-20 Josh Aas <joshmoz@gmail.com>
9006
9007 Reviewed and landed by Anders.
9008
9009 <rdar://problem/6163636>
9010 rename NPCocoaEvent's "event" struct to "data" (20446)
9011
9012 * bridge/npapi.h:
9013 (_NPCocoaEvent::):
9014
bdakin@apple.com699d13d2008-08-20 20:46:28 +000090152008-08-20 Beth Dakin <bdakin@apple.com>
9016
darin@apple.com07c80c62008-09-05 18:15:43 +00009017 Reviewed by Darin Adler.
bdakin@apple.com699d13d2008-08-20 20:46:28 +00009018
9019 Fix for <rdar://problem/6145626>
9020 This patch fixes a number of remaining problems getting
9021 disconnected frames to work correctly with markAllMatchesForText()
9022 and findString(). Details inline.
9023
9024 This was a static helper function in Frame, but this patch requires
9025 the same functionality in Editor, so I just added it as a function
9026 on Node.
9027 * dom/Node.cpp:
9028 (WebCore::Node::isInShadowTree):
9029 * dom/Node.h:
9030
9031 * editing/Editor.cpp:
9032 (WebCore::Editor::insideVisibleArea): Returns false if
9033 excludeFromTextSearch() is true.
9034
9035 In a normal (non-disconnected) frame, findString returns a range of
9036 the document node if the text is not found in the frame. I changed
9037 firstVisibleRange and lastVisibleRange to match that behavior when
9038 the text is not found
9039 (WebCore::Editor::firstVisibleRange):
9040 (WebCore::Editor::lastVisibleRange):
9041
9042 Here are the bulk of the changes in the patch. A lot of text was
9043 not being found in disconnected frames because I failed to account
9044 for all of the possible problems associated with shadow trees. That
9045 is fixed here.
9046 (WebCore::Editor::nextVisibleRange):
9047 * editing/Editor.h:
9048
9049 excludeFromTextSearch() is new. It allows a WebKit client to mark a
9050 frame as not-text-searchable through SPI.
9051 * WebCore.base.exp:
9052 * page/Frame.cpp:
9053 (WebCore::Frame::excludeFromTextSearch):
9054 (WebCore::Frame::setExcludeFromTextSearch):
9055 (WebCore::FramePrivate::FramePrivate):
9056 * page/Frame.h:
9057 * page/FramePrivate.h:
9058
9059 (WebCore::Frame::findString):
9060 (WebCore::Frame::markAllMatchesForText): I kept running into an
9061 assertion failure in paining code because of the forced paint on
9062 empty visible rects.
9063
timothy@apple.com301befc2008-08-20 19:10:54 +000090642008-08-20 Timothy Hatcher <timothy@apple.com>
9065
9066 Adds a positon box to the Inspector's Metrics sidebar
9067 pane. When an element is not statically positioned, there
9068 is now a position box that show top, right, bottom and
9069 left computed values.
9070
9071 Reviewed by Kevin McCullough.
9072
9073 * English.lproj/localizedStrings.js: Updated the strings.
9074 * page/inspector/MetricsSidebarPane.js:
9075 (WebInspector.MetricsSidebarPane.prototype.update):
9076 Renamed the boxPartValue function to createBoxPartElement
9077 and made it create the entire element. Made it understand
9078 how to get position style properties. Don't use the figure dash
9079 when 0px is used for positions, since the 0 is meaningful there.
9080 Instead use the figure dash when a position is auto.
9081 * page/inspector/inspector.css: Added a new rule for position.
9082
mrowe@apple.com37686d42008-09-04 00:10:39 +000090832008-08-20 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com2a5ecc02008-08-20 18:34:56 +00009084
9085 Reviewed by Beth Dakin
9086
9087 Qt build fix
9088
9089 * WebCore.pro:
9090
mitz@apple.comedaa9042008-08-20 18:28:07 +000090912008-08-20 Dan Bernstein <mitz@apple.com>
9092
9093 Reviewed by Anders Carlsson.
9094
9095 - avoid using a deprecated NSScroller method on Leopard
9096
9097 * platform/mac/PlatformScrollBarMac.mm:
9098 (WebCore::PlatformScrollbar::updateThumbPosition):
9099 (WebCore::PlatformScrollbar::updateThumbProportion):
9100
jmalonzo@webkit.org6e0a3082008-08-20 11:40:31 +000091012008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
9102
9103 Reviewed by Oliver Hunt.
9104
9105 Gtk build fix
9106
9107 * GNUmakefile.am:
9108 * page/AccessibilityTable.cpp: Change nil to 0
9109 (WebCore::AccessibilityTable::cellForColumnAndRow):
9110
ap@webkit.org01aff702008-08-20 07:23:06 +000091112008-08-19 Alexey Proskuryakov <ap@webkit.org>
9112
9113 Reviewed by Geoff Garen.
9114
9115 Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
9116
9117 * ForwardingHeaders/kjs/JSLock.h: Added.
9118 * WebCore.vcproj/WebCore.vcproj:
9119 * bindings/js/GCController.cpp:
9120 (WebCore::collect):
9121 (WebCore::GCController::gcTimerFired):
9122 (WebCore::GCController::garbageCollectNow):
9123 * bindings/js/JSCustomSQLStatementCallback.cpp:
9124 (WebCore::JSCustomSQLStatementCallback::handleEvent):
9125 * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
9126 (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
9127 * bindings/js/JSCustomSQLTransactionCallback.cpp:
9128 (WebCore::JSCustomSQLTransactionCallback::handleEvent):
9129 * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
9130 (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
9131 * bindings/js/JSCustomVoidCallback.cpp:
9132 (WebCore::JSCustomVoidCallback::handleEvent):
9133 * bindings/js/JSCustomXPathNSResolver.cpp:
9134 (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
9135 * bindings/js/JSDOMWindowBase.cpp:
9136 (WebCore::DOMWindowTimer::~DOMWindowTimer):
9137 (WebCore::JSDOMWindowBase::clear):
9138 (WebCore::JSDOMWindowBase::timerFired):
9139 * bindings/js/JSEventCustom.cpp:
9140 (WebCore::toJS):
9141 * bindings/js/JSEventListener.cpp:
9142 (WebCore::JSAbstractEventListener::handleEvent):
9143 * bindings/js/JSNSResolver.cpp:
9144 (WebCore::JSNSResolver::lookupNamespaceURI):
9145 * bindings/js/JSNodeFilterCondition.cpp:
9146 (WebCore::JSNodeFilterCondition::acceptNode):
9147 * bindings/js/ScheduledAction.cpp:
9148 (WebCore::ScheduledAction::execute):
9149 * bindings/js/ScriptController.cpp:
9150 (WebCore::ScriptController::evaluate):
9151 (WebCore::ScriptController::clearWindowShell):
9152 (WebCore::ScriptController::createHTMLEventHandler):
9153 (WebCore::ScriptController::createSVGEventHandler):
9154 (WebCore::ScriptController::initScript):
9155 (WebCore::ScriptController::updateDocument):
9156 (WebCore::ScriptController::bindingRootObject):
9157 (WebCore::ScriptController::windowScriptNPObject):
9158 (WebCore::ScriptController::createScriptObjectForPluginElement):
9159 (WebCore::ScriptController::clearScriptObjects):
9160 * bindings/js/ScriptControllerMac.mm:
9161 (WebCore::ScriptController::windowScriptObject):
9162 * bindings/objc/WebScriptObject.mm:
9163 (_didExecute):
9164 (-[WebScriptObject callWebScriptMethod:withArguments:]):
9165 (-[WebScriptObject evaluateWebScript:]):
9166 (-[WebScriptObject setValue:forKey:]):
9167 (-[WebScriptObject valueForKey:]):
9168 (-[WebScriptObject removeWebScriptKey:]):
9169 (-[WebScriptObject stringRepresentation]):
9170 (-[WebScriptObject webScriptValueAtIndex:]):
9171 (-[WebScriptObject setWebScriptValueAtIndex:value:]):
9172 (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
9173 * bridge/NP_jsobject.cpp:
9174 (_NPN_InvokeDefault):
9175 (_NPN_Invoke):
9176 (_NPN_Evaluate):
9177 (_NPN_GetProperty):
9178 (_NPN_SetProperty):
9179 (_NPN_RemoveProperty):
9180 (_NPN_HasProperty):
9181 (_NPN_HasMethod):
9182 (_NPN_Enumerate):
9183 * bridge/c/c_class.cpp:
9184 (KJS::Bindings::CClass::~CClass):
9185 (KJS::Bindings::CClass::methodsNamed):
9186 (KJS::Bindings::CClass::fieldNamed):
9187 * bridge/c/c_instance.cpp:
9188 (KJS::Bindings::CInstance::invokeMethod):
9189 (KJS::Bindings::CInstance::invokeDefaultMethod):
9190 (KJS::Bindings::CInstance::getPropertyNames):
9191 * bridge/c/c_runtime.cpp:
9192 (KJS::Bindings::CField::valueFromInstance):
9193 (KJS::Bindings::CField::setValueToInstance):
9194 * bridge/c/c_utility.cpp:
9195 (KJS::Bindings::convertValueToNPVariant):
9196 (KJS::Bindings::convertNPVariantToValue):
9197 * bridge/jni/jni_class.cpp:
9198 (JavaClass::JavaClass):
9199 (JavaClass::~JavaClass):
9200 * bridge/jni/jni_instance.cpp:
9201 (JavaInstance::stringValue):
9202 * bridge/jni/jni_jsobject.mm:
9203 (JavaJSObject::call):
9204 (JavaJSObject::eval):
9205 (JavaJSObject::getMember):
9206 (JavaJSObject::setMember):
9207 (JavaJSObject::removeMember):
9208 (JavaJSObject::getSlot):
9209 (JavaJSObject::setSlot):
9210 (JavaJSObject::toString):
9211 (JavaJSObject::convertValueToJObject):
9212 (JavaJSObject::convertJObjectToValue):
9213 * bridge/jni/jni_objc.mm:
9214 (KJS::Bindings::dispatchJNICall):
9215 * bridge/jni/jni_runtime.cpp:
9216 (appendClassName):
9217 (JavaMethod::signature):
9218 * bridge/jni/jni_runtime.h:
9219 (KJS::Bindings::JavaString::JavaString):
9220 (KJS::Bindings::JavaString::_commonInit):
9221 (KJS::Bindings::JavaString::~JavaString):
9222 (KJS::Bindings::JavaString::UTF8String):
9223 * bridge/jni/jni_utility.cpp:
9224 (KJS::Bindings::convertValueToJValue):
9225 * bridge/npruntime.cpp:
9226 (_NPN_GetStringIdentifier):
9227 * bridge/objc/objc_instance.mm:
9228 (ObjcInstance::moveGlobalExceptionToExecState):
9229 (ObjcInstance::invokeMethod):
9230 (ObjcInstance::invokeDefaultMethod):
9231 (ObjcInstance::setValueOfUndefinedField):
9232 (ObjcInstance::getValueOfUndefinedField):
9233 * bridge/objc/objc_runtime.mm:
9234 (ObjcField::valueFromInstance):
9235 (ObjcField::setValueToInstance):
9236 * bridge/objc/objc_utility.mm:
9237 (KJS::Bindings::convertValueToObjcValue):
9238 (KJS::Bindings::convertNSStringToString):
9239 (KJS::Bindings::convertObjcValueToValue):
9240 * bridge/qt/qt_instance.cpp:
9241 (KJS::Bindings::QtRuntimeObjectImp::removeFromCache):
9242 (KJS::Bindings::QtInstance::~QtInstance):
9243 (KJS::Bindings::QtInstance::getQtInstance):
9244 (KJS::Bindings::QtInstance::getRuntimeObject):
9245 * bridge/qt/qt_runtime.cpp:
9246 (KJS::Bindings::convertValueToQVariant):
9247 (KJS::Bindings::convertQVariantToValue):
9248 (KJS::Bindings::QtRuntimeMetaMethod::call):
9249 (KJS::Bindings::QtRuntimeConnectionMethod::call):
9250 (KJS::Bindings::QtConnectionObject::QtConnectionObject):
9251 (KJS::Bindings::QtConnectionObject::execute):
9252 * bridge/runtime.cpp:
9253 (KJS::Bindings::Instance::createRuntimeObject):
9254 * bridge/testbindings.cpp:
9255 (main):
9256 * bridge/testbindings.mm:
9257 (main):
9258 * bridge/testqtbindings.cpp:
9259 (main):
9260 * dom/Document.cpp:
9261 (WebCore::Document::~Document):
9262 * dom/Node.cpp:
9263 (WebCore::Node::setDocument):
9264 * history/CachedPage.cpp:
9265 (WebCore::CachedPage::CachedPage):
9266 (WebCore::CachedPage::restore):
9267 (WebCore::CachedPage::clear):
9268 * loader/FrameLoader.cpp:
9269 (WebCore::getString):
9270 * page/InspectorController.cpp:
9271 (WebCore::ConsoleMessage::ConsoleMessage):
9272 (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
9273 (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
9274 (WebCore::getResourceDocumentNode):
9275 (WebCore::search):
9276 (WebCore::inspectedWindow):
9277 (WebCore::wrapCallback):
9278 (WebCore::currentCallFrame):
9279 (WebCore::profiles):
9280 (WebCore::InspectorController::focusNode):
9281 (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
9282 (WebCore::InspectorController::addDatabaseScriptResource):
9283 (WebCore::InspectorController::addScriptProfile):
9284 * page/JavaScriptCallFrame.cpp:
9285 (WebCore::JavaScriptCallFrame::evaluate):
9286 * page/JavaScriptProfileNode.cpp:
9287 (WebCore::getTotalTime):
9288 (WebCore::getSelfTime):
9289 (WebCore::getTotalPercent):
9290 (WebCore::getSelfPercent):
9291 (WebCore::getNumberOfCalls):
9292 (WebCore::getChildren):
9293 (WebCore::getVisible):
9294 * page/Page.cpp:
9295 * page/mac/FrameMac.mm:
9296 * plugins/PluginView.cpp:
9297 (WebCore::PluginView::start):
9298 (WebCore::getString):
9299 (WebCore::PluginView::performRequest):
9300 (WebCore::PluginView::bindingInstance):
9301 * plugins/gtk/PluginViewGtk.cpp:
9302 (WebCore::PluginView::paint):
9303 (WebCore::PluginView::handleKeyboardEvent):
9304 (WebCore::PluginView::handleMouseEvent):
9305 (WebCore::PluginView::setNPWindowRect):
9306 (WebCore::PluginView::stop):
9307 (WebCore::PluginView::init):
9308 * plugins/qt/PluginViewQt.cpp:
9309 (WebCore::PluginView::setNPWindowRect):
9310 (WebCore::PluginView::stop):
9311 (WebCore::PluginView::init):
9312 * plugins/win/PluginViewWin.cpp:
9313 (WebCore::PluginView::dispatchNPEvent):
9314 (WebCore::PluginView::handleKeyboardEvent):
9315 (WebCore::PluginView::handleMouseEvent):
9316 (WebCore::PluginView::setNPWindowRect):
9317 (WebCore::PluginView::stop):
9318 * xml/XMLHttpRequest.cpp:
9319 (WebCore::XMLHttpRequest::clearResponse):
9320 (WebCore::XMLHttpRequest::didFinishLoading):
9321 (WebCore::XMLHttpRequest::didReceiveData):
9322
eric@webkit.orgbac93762008-08-19 23:33:07 +000093232008-08-19 Eric Seidel <eric@webkit.org>
9324
9325 Reviewed by Geoff Garen.
9326
9327 Add the beginnings of Skia graphics support to WebCore
9328 as I try to begin the long process of un-forking the changes
9329 needed to WebCore to make Andriod's WebCore build.
9330
9331 I'll follow this up with actual *Skia.cpp files in a separate patch.
9332
9333 * platform/graphics/AffineTransform.h:
9334 * platform/graphics/FloatPoint.h:
9335 * platform/graphics/FloatRect.h:
9336 * platform/graphics/Gradient.h:
9337 * platform/graphics/GraphicsContext.h:
9338 * platform/graphics/Image.h:
9339 * platform/graphics/ImageBuffer.h:
9340 * platform/graphics/ImageSource.h:
9341 * platform/graphics/IntPoint.h:
9342 * platform/graphics/IntRect.h:
9343 * platform/graphics/Path.h:
9344 * platform/graphics/Pattern.h:
9345 * svg/graphics/SVGPaintServerPattern.h:
9346 * svg/graphics/SVGPaintServerSolid.h:
9347
sfalken@apple.com3f69b332008-08-19 22:34:37 +000093482008-08-19 Steve Falkenburg <sfalken@apple.com>
9349
sfalken@apple.com45d22802008-08-19 22:46:31 +00009350 Fix Windows build more.
9351
9352 * WebCore.vcproj/WebCore.vcproj:
9353
93542008-08-19 Steve Falkenburg <sfalken@apple.com>
9355
sfalken@apple.com3f69b332008-08-19 22:34:37 +00009356 Fix Windows build.
9357
9358 * page/AccessibilityRenderObject.cpp:
9359 (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
9360
mrowe@apple.com37686d42008-09-04 00:10:39 +000093612008-08-19 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com7c7b5f32008-08-19 22:05:37 +00009362
9363 Reviewed by Beth Dakin.
9364
9365 <rdar://problem/4003764> Expose tables as AXTables
9366
9367 Tests: accessibility/table-attributes.html
9368 accessibility/table-cell-spans.html
9369 accessibility/table-cells.html
9370 accessibility/table-detection.html
9371 accessibility/table-sections.html
9372 accessibility/table-with-rules.html
9373
9374 * WebCore.xcodeproj/project.pbxproj:
9375 * page/AXObjectCache.cpp:
9376 (WebCore::AXObjectCache::get):
9377 * page/AccessibilityObject.h:
9378 (WebCore::):
9379 (WebCore::AccessibilityObject::isDataTable):
9380 (WebCore::AccessibilityObject::isTableRow):
9381 (WebCore::AccessibilityObject::isTableColumn):
9382 (WebCore::AccessibilityObject::isTableCell):
9383 * page/AccessibilityRenderObject.cpp:
9384 (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
9385 * page/AccessibilityTable.cpp: Added.
9386 (WebCore::AccessibilityTable::AccessibilityTable):
9387 (WebCore::AccessibilityTable::~AccessibilityTable):
9388 (WebCore::AccessibilityTable::create):
9389 (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
9390 (WebCore::AccessibilityTable::clearChildren):
9391 (WebCore::AccessibilityTable::addChildren):
9392 (WebCore::AccessibilityTable::headerContainer):
9393 (WebCore::AccessibilityTable::columns):
9394 (WebCore::AccessibilityTable::rows):
9395 (WebCore::AccessibilityTable::rowHeaders):
9396 (WebCore::AccessibilityTable::columnHeaders):
9397 (WebCore::AccessibilityTable::cells):
9398 (WebCore::AccessibilityTable::columnCount):
9399 (WebCore::AccessibilityTable::rowCount):
9400 (WebCore::AccessibilityTable::cellForColumnAndRow):
9401 (WebCore::AccessibilityTable::roleValue):
9402 (WebCore::AccessibilityTable::accessibilityIsIgnored):
9403 (WebCore::AccessibilityTable::title):
9404 (WebCore::AccessibilityTable::isDataTable):
9405 * page/AccessibilityTable.h: Added.
9406 * page/AccessibilityTableCell.cpp: Added.
9407 (WebCore::AccessibilityTableCell::AccessibilityTableCell):
9408 (WebCore::AccessibilityTableCell::~AccessibilityTableCell):
9409 (WebCore::AccessibilityTableCell::create):
9410 (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
9411 (WebCore::AccessibilityTableCell::rowIndexRange):
9412 (WebCore::AccessibilityTableCell::columnIndexRange):
9413 * page/AccessibilityTableCell.h: Added.
9414 (WebCore::AccessibilityTableCell::isTableCell):
9415 (WebCore::AccessibilityTableCell::roleValue):
9416 * page/AccessibilityTableColumn.cpp: Added.
9417 (WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
9418 (WebCore::AccessibilityTableColumn::~AccessibilityTableColumn):
9419 (WebCore::AccessibilityTableColumn::create):
9420 (WebCore::AccessibilityTableColumn::setParentTable):
9421 (WebCore::AccessibilityTableColumn::elementRect):
9422 (WebCore::AccessibilityTableColumn::size):
9423 (WebCore::AccessibilityTableColumn::children):
9424 (WebCore::AccessibilityTableColumn::headerObject):
9425 (WebCore::AccessibilityTableColumn::headerObjectForSection):
9426 (WebCore::AccessibilityTableColumn::addChildren):
9427 * page/AccessibilityTableColumn.h: Added.
9428 (WebCore::AccessibilityTableColumn::parentObject):
9429 (WebCore::AccessibilityTableColumn::roleValue):
9430 (WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
9431 (WebCore::AccessibilityTableColumn::isTableColumn):
9432 (WebCore::AccessibilityTableColumn::setColumnIndex):
9433 (WebCore::AccessibilityTableColumn::columnIndex):
9434 * page/AccessibilityTableHeaderContainer.cpp: Added.
9435 (WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
9436 (WebCore::AccessibilityTableHeaderContainer::~AccessibilityTableHeaderContainer):
9437 (WebCore::AccessibilityTableHeaderContainer::create):
9438 (WebCore::AccessibilityTableHeaderContainer::children):
9439 (WebCore::AccessibilityTableHeaderContainer::elementRect):
9440 (WebCore::AccessibilityTableHeaderContainer::size):
9441 (WebCore::AccessibilityTableHeaderContainer::addChildren):
9442 * page/AccessibilityTableHeaderContainer.h: Added.
9443 (WebCore::AccessibilityTableHeaderContainer::roleValue):
9444 (WebCore::AccessibilityTableHeaderContainer::setParentTable):
9445 (WebCore::AccessibilityTableHeaderContainer::parentObject):
9446 (WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
9447 * page/AccessibilityTableRow.cpp: Added.
9448 (WebCore::AccessibilityTableRow::AccessibilityTableRow):
9449 (WebCore::AccessibilityTableRow::~AccessibilityTableRow):
9450 (WebCore::AccessibilityTableRow::create):
9451 (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
9452 (WebCore::AccessibilityTableRow::headerObject):
9453 * page/AccessibilityTableRow.h: Added.
9454 (WebCore::AccessibilityTableRow::isTableRow):
9455 (WebCore::AccessibilityTableRow::roleValue):
9456 (WebCore::AccessibilityTableRow::setRowIndex):
9457 (WebCore::AccessibilityTableRow::rowIndex):
9458 * page/mac/AccessibilityObjectWrapper.mm:
9459 (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
9460 (RoleEntry::):
9461 (-[AccessibilityObjectWrapper roleDescription]):
9462 (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
9463 (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
9464 (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
9465
sfalken@apple.comb83d4692008-08-19 18:39:44 +000094662008-08-19 Steve Falkenburg <sfalken@apple.com>
9467
9468 Build fix.
9469 Add buildfailed support to stop builds early (preventing inaccurate error messages).
9470 Add missing post-build rule to Release.
9471
9472 * WebCore.vcproj/QTMovieWin.vcproj:
9473
timothy@apple.comda3aa632008-08-19 18:33:02 +000094742008-08-19 Keishi Hattori <casey.hattori@gmail.com>
9475
timothy@apple.com7d08c322008-08-19 18:33:27 +00009476 Added support for console.count in the inspector.
9477
9478 Reviewed by Geoff Garen.
9479
9480 * page/Console.cpp:
9481 (WebCore::Console::count):
9482 * page/Console.h:
9483 * page/Console.idl: Added console.count.
9484 * page/InspectorController.cpp:
9485 (WebCore::InspectorController::didCommitLoad): Clears m_counts.
9486 (WebCore::InspectorController::count): Updates the count number
9487 sing "title@source:line" as the identifier, and adds a
9488 message to the console.
9489 * page/InspectorController.h: Added m_counts.
9490
94912008-08-19 Keishi Hattori <casey.hattori@gmail.com>
9492
timothy@apple.comda3aa632008-08-19 18:33:02 +00009493 Clear console.time timers when changing page.
9494
9495 Reviewed by Geoff Garen.
9496
9497 * page/InspectorController.cpp:
9498 (WebCore::InspectorController::didCommitLoad):
9499
adele@apple.com1f2d7e02008-08-19 17:55:58 +000095002008-08-19 Eric Carlson <eric.carlson@apple.com>
9501
9502 Reviewed by Adele.
9503
9504 Fix for <rdar://problem/6154695> Full-page movies flicker while playing
9505 https://bugs.webkit.org/show_bug.cgi?id=20404
9506
9507 Ignore setVisible() when visibility doesn't change.
9508
9509 * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
9510 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
9511 (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
9512 (WebCore::MediaPlayerPrivate::setVisible):
9513
timothy@apple.com9d9821a2008-08-19 17:00:26 +000095142008-08-19 Timothy Hatcher <timothy@apple.com>
9515
timothy@apple.come058a792008-08-19 17:01:12 +00009516 Fixes a bug in the Profile view where switching sort order, then
9517 switching from heavy to tree mode would show the tree in the
9518 previous sort order.
9519
9520 https://bugs.webkit.org/show_bug.cgi?id=20441
9521
9522 Reviewed by Kevin McCullough.
9523
9524 * page/inspector/ProfileView.js:
9525 (WebInspector.ProfileView.prototype._changeView): Call _sortProfile
9526 on the next profile before assigning it to this.profile.
9527 (WebInspector.ProfileView.prototype._sortData): Call _sortProfile.
9528 (WebInspector.ProfileView.prototype._sortProfile): Moves from
9529 _sortData and takes a profile argument. If the profile passed in
9530 matches the this.profile, then call refresh.
9531
95322008-08-18 Timothy Hatcher <timothy@apple.com>
9533
timothy@apple.come525e402008-08-19 17:01:00 +00009534 Changed the default sort order now that heavy view is the default.
9535 Also fixes a bug where the heavy profile was not sorted at first.
9536
9537 https://bugs.webkit.org/show_bug.cgi?id=20440
9538
9539 Reviewed by Kevin McCullough.
9540
9541 * page/inspector/ProfileView.js:
9542 (WebInspector.ProfileView): Changed the default sort column. Also assign
9543 heavyProfile to profile, so the sortSelfTimeDescending call happens
9544 on the heavy profile before assigning to this.profile.
9545
95462008-08-18 Timothy Hatcher <timothy@apple.com>
9547
timothy@apple.comc9287f32008-08-19 17:00:36 +00009548 Add support for editing DOM properties and scope variables by double
9549 clicking a property to enter edit mode.
9550
9551 https://bugs.webkit.org/show_bug.cgi?id=20415
9552
9553 Reviewed by Kevin McCullough.
9554
9555 * page/inspector/ObjectPropertiesSection.js:
9556 (WebInspector.ObjectPropertiesSection): Set editable to true by default.
9557 (WebInspector.ObjectPropertiesSection.prototype.onpopulate):
9558 Factored out code into update, and calls update.
9559 (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate.
9560 Call removeChildren since this method can be called multiple times now.
9561 (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title
9562 gets made later in onattach.
9563 (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early
9564 if shouldRefreshChildren is true. Call removeChildren since this method can be
9565 called multiple times now.
9566 (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing.
9567 (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update.
9568 (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for
9569 this element (code moved from the constructor.)
9570 (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all
9571 sibling property elements.
9572 (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call
9573 WebInspector.startEditing after rememebring some context.
9574 (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft
9575 for the list element, since it might have scrolled during editing.
9576 (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded
9577 then restore the state from the context. Then call update to restore the title.
9578 (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled
9579 if the user input and the previous input are the same. Call editingEnded, then call applyExpression
9580 to commit the user input.
9581 (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression
9582 and stores the result on the object for the property name of this element. If the expression is
9583 empty, delete the property and remove the tree element.
9584 * page/inspector/ScopeChainSidebarPane.js:
9585 (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused
9586 property on each ObjectPropertiesSection.
9587 (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach
9588 since it is now implemented.
9589 * page/inspector/ScriptsPanel.js:
9590 (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument
9591 that defaults to true if omitted. It specifies whether to call update on the scope chain.
9592 * page/inspector/inspector.css: New styles.
9593 * page/inspector/treeoutline.js:
9594 (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren
9595 change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
9596
95972008-08-18 Timothy Hatcher <timothy@apple.com>
9598
timothy@apple.com9d9821a2008-08-19 17:00:26 +00009599 Surround the expression to be evaluated in parenthesis so the
9600 result of the eval is the result of the whole expression not
9601 the last potential sub-expression. So evaluating {x: 123}
9602 will show the Object not 123.
9603
9604 https://bugs.webkit.org/show_bug.cgi?id=20428
9605
9606 Reviewed by Kevin McCullough.
9607
9608 * page/inspector/Console.js:
9609 (Console.prototype._evalInInspectedWindow): Add parenthesis
9610 around the expression. And add couple comments.
9611
kmccullough@apple.come8ac2f32008-08-19 16:38:06 +000096122008-08-19 Kevin McCullough <kmccullough@apple.com>
9613
9614 Reviewed by Geoff.
9615
9616 -Implement a page() function to extract a common code pattern.
9617
9618 * WebCore.xcodeproj/project.pbxproj:
9619 * page/Console.cpp:
9620 (WebCore::Console::addMessage):
9621 (WebCore::Console::error):
9622 (WebCore::Console::info):
9623 (WebCore::Console::log):
9624 (WebCore::Console::dir):
9625 (WebCore::Console::assertCondition):
9626 (WebCore::Console::time):
9627 (WebCore::Console::timeEnd):
9628 (WebCore::Console::group):
9629 (WebCore::Console::groupEnd):
9630 (WebCore::Console::finishedProfiling):
9631 (WebCore::Console::warn):
9632 (WebCore::Console::framePage):
9633 * page/Console.h:
9634
darin@apple.com349e1eb2008-08-19 04:39:04 +000096352008-08-12 Darin Adler <darin@apple.com>
9636
9637 Reviewed by Geoff.
9638
9639 - eliminate JSValue::type()
9640
9641 * bridge/c/c_instance.cpp:
9642 (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType
9643 argument instead of JSType argument. Removed unneeded code to handle
9644 boolean, since that's never passed.
9645 * bridge/c/c_instance.h: Ditto.
9646
9647 * bridge/c/c_utility.cpp:
9648 (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions
9649 instead of JSValue::type(). Removed unneeded code to handle
9650 "unspecified".
9651
9652 * bridge/jni/jni_instance.cpp:
9653 (JavaInstance::defaultValue): Take PreferredPrimitiveType argument
9654 instead of JSType argument. Removed unneeded code to handle boolean.
9655 * bridge/jni/jni_instance.h: Ditto.
9656
9657 * bridge/jni/jni_jsobject.mm:
9658 (JavaJSObject::convertValueToJObject): Use JSValue::is functions
9659 instead of JSValue::type().
9660
9661 * bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument
9662 instead of JSType argument. Removed unused argument.
9663 * bridge/objc/objc_instance.mm:
9664 (ObjcInstance::getValueOfUndefinedField): Removed unused argument.
9665 (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument
9666 instead of JSType argument. Removed unneeded code to handle boolean
9667 and another dead code path for unknown types.
9668
9669 * bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument
9670 instead of JSType argument. Removed override of type() that caused
9671 the fallback object to return "UndefinedType" when there is no
9672 invokeUndefinedMethodFromWebScript:withArguments: method defined.
9673 That didn't accomplish much, since most checks for undefined don't
9674 ever call type().
9675 * bridge/objc/objc_runtime.mm:
9676 (ObjcFallbackObjectImp::defaultValue): Ditto.
9677
9678 * bridge/qt/qt_instance.cpp:
9679 (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType
9680 argument instead of JSType argument. Removed unneeded code to handle
9681 boolean.
9682 * bridge/qt/qt_instance.h: Ditto.
9683
9684 * bridge/runtime.h:
9685 (KJS::Bindings::Instance::getValueOfUndefinedField): Removed
9686 unsed argument.
9687 * bridge/runtime_object.cpp:
9688 (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType
9689 argument instead of JSType argument.
9690 * bridge/runtime_object.h: Ditto.
9691
britto@apple.comaf7f8382008-08-19 00:42:13 +000096922008-08-18 Maxime Britto <britto@apple.com>
9693
9694 Reviewed by Adele.
9695
9696 <rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
9697 Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
9698 We shouldn't be able to create another window while we are in pan scrolling.
9699 Other browsers behaviors :
9700 FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
9701 IE7 : Keys are not disabled but stops immediately the panning.
9702 This patch matches FF3 behavior by disabling every key but the esc key.
9703
9704 * page/EventHandler.cpp:
9705 (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped.
9706 (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
9707
mitz@apple.com12404d82008-08-19 00:20:38 +000097082008-08-18 Dan Bernstein <mitz@apple.com>
9709
9710 Reviewed by Dave Hyatt.
9711
9712 - fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
9713
9714 Test: fast/replaced/max-width-percent.html
9715
9716 Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
9717 When false, max-width is not factored into the
9718 calculation.
9719 Changed RenderReplaced and subclasses' calcPrefWidths() to call
9720 calcReplacedWidth(false) and then apply max-width only if it has a
9721 fixed, positive value.
9722
9723 * rendering/RenderBox.cpp:
9724 (WebCore::RenderBox::calcReplacedWidth):
9725 * rendering/RenderBox.h:
9726 * rendering/RenderImage.cpp:
9727 (WebCore::RenderImage::calcReplacedWidth):
9728 (WebCore::RenderImage::calcPrefWidths):
9729 * rendering/RenderImage.h:
9730 * rendering/RenderReplaced.cpp:
9731 (WebCore::RenderReplaced::calcPrefWidths):
9732 * rendering/RenderSVGRoot.cpp:
9733 (WebCore::RenderSVGRoot::calcPrefWidths):
9734 * rendering/RenderVideo.cpp:
9735 (WebCore::RenderVideo::calcReplacedWidth):
9736 (WebCore::RenderVideo::calcPrefWidths):
9737 * rendering/RenderVideo.h:
9738
mrowe@apple.comced88732008-08-18 22:47:28 +000097392008-08-18 Daniel Macks <dmacks@netspace.org>
9740
9741 Reviewed by Mark Rowe.
9742
9743 https://bugs.webkit.org/show_bug.cgi?id=20410
9744 More portable/self-documenting replacement for SIZE_MAX.
9745
9746 * platform/network/curl/FormDataStreamCurl.cpp:
9747 (WebCore::FormDataStream::read):
9748
97492008-08-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com6040db32008-08-18 22:11:10 +00009750
9751 Reviewed by Dave Hyatt
9752
9753 Need to make sure we have an Animation in the AnimationList
9754 before setting the initial value.
9755 https://bugs.webkit.org/show_bug.cgi?id=20408
9756
9757 Test: fast/css/transition_shorthand_parsing.html
9758
9759 * css/CSSStyleSelector.cpp:
9760
kmccullough@apple.com64cb2fd2008-08-18 19:55:35 +000097612008-08-18 Kevin McCullough <kmccullough@apple.com>
9762
kmccullough@apple.com707bd362008-08-18 20:21:57 +00009763 Reviewed by Tim.
9764
9765 <rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
9766 is another profile.
9767
9768 * page/inspector/ProfilesPanel.js:
9769
97702008-08-18 Kevin McCullough <kmccullough@apple.com>
9771
kmccullough@apple.com64cb2fd2008-08-18 19:55:35 +00009772 Reviewed by Geoff.
9773
9774 <rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
9775 all console messages
9776
9777 * page/inspector/Console.js:
9778
jmalonzo@webkit.org5d1e0482008-08-18 11:20:11 +000097792008-08-18 Dirk Schulze <vbs85@gmx.de>
9780
9781 Reviewed by Eric Seidel.
9782
9783 Fixed Canvas for Cairo. Stroke and fill colors didn't work after
9784 the canvas clean up.
9785
9786 https://bugs.webkit.org/show_bug.cgi?id=20405
9787
9788 * html/CanvasRenderingContext2D.cpp:
9789 (WebCore::CanvasRenderingContext2D::fill):
9790 (WebCore::CanvasRenderingContext2D::stroke):
9791 (WebCore::CanvasRenderingContext2D::fillRect):
9792
timothy@apple.comc5e1f8d2008-08-18 03:21:46 +000097932008-08-17 Timothy Hatcher <timothy@apple.com>
9794
9795 Complete in scope variables in the Console when paused.
9796
9797 https://bugs.webkit.org/show_bug.cgi?id=19115
9798
9799 Reviewed by Geoffrey Garen.
9800
9801 * page/inspector/Console.js:
9802 (WebInspector.Console.prototype.completions): If the expressionString
9803 is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame
9804 to get an object that declares all the in scope variables. That way
9805 "top level" expressions are completed.
9806 * page/inspector/ScriptsPanel.js:
9807 (WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame):
9808 Return an object that has all the variables that are in scope for the
9809 selected call frame. The value of each property is just true.
9810 The return object is useful for quick lookups or auto completion.
9811
cwzwarich@webkit.orgac715282008-08-17 21:34:46 +000098122008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
9813
9814 Not reviewed.
9815
9816 Speculative Qt build fix.
9817
9818 * bridge/qt/qt_runtime.cpp:
9819 (KJS::Bindings::convertValueToQVariant):
9820 (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
9821
ggaren@apple.comfea43532008-08-17 20:23:49 +000098222008-08-17 Geoffrey Garen <ggaren@apple.com>
9823
9824 Reviewed by Cameron Zwarich.
ggaren@apple.com6e53d0a2008-08-17 20:28:37 +00009825
9826 Updated project files to XCode 3.1.
9827
9828 * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
9829
98302008-08-17 Geoffrey Garen <ggaren@apple.com>
9831
9832 Reviewed by Cameron Zwarich.
ggaren@apple.comfea43532008-08-17 20:23:49 +00009833
9834 Made room for a free word in JSCell.
9835
9836 Changed JSDOMWindowBase to store its auxiliary data in a subclass of
9837 JSGlobalData, so the two could share a pointer.
9838
9839 Added a bunch of ASSERTs, to help catch over-sized objects.
9840
mrowe@apple.com13570292008-08-16 06:48:10 +000098412008-08-15 Mark Rowe <mrowe@apple.com>
9842
mitz@apple.comb96c1b92008-08-17 03:28:52 +00009843 Reviewed by Dan Bernstein.
9844
9845 Disable dead code stripping in debug builds.
9846
9847 * Configurations/Base.xcconfig:
9848 * WebCore.xcodeproj/project.pbxproj:
9849
98502008-08-15 Mark Rowe <mrowe@apple.com>
9851
mrowe@apple.com13570292008-08-16 06:48:10 +00009852 Rubber-stamped by Geoff Garen.
9853
9854 <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
9855
9856 * Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared
9857 between the Debug configuration and debug Production variant.
9858 * WebCore.xcodeproj/project.pbxproj: Enable the debug variant.
9859
antti@apple.coma05e8b02008-08-15 22:58:06 +000098602008-08-15 Antti Koivisto <antti@apple.com>
9861
9862 Reviewed by Anders.
9863
9864 Don't start preloading body resources before the head is complete. This prevents
9865 body preloads from slowing down initial display when there is limited amount
9866 of bandwidth available.
9867
9868 Works by queuing up found body preloads to DocLoader and only issuing them
9869 after document has rendering.
9870
9871 With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
9872 without affecting complete load time.
9873
9874 * html/PreloadScanner.cpp:
9875 (WebCore::PreloadScanner::PreloadScanner):
9876 (WebCore::PreloadScanner::scanningBody):
9877 (WebCore::PreloadScanner::emitTag):
9878 (WebCore::PreloadScanner::emitCSSRule):
9879 * html/PreloadScanner.h:
9880 * loader/DocLoader.cpp:
9881 (WebCore::DocLoader::preload):
9882 (WebCore::DocLoader::checkForPendingPreloads):
9883 (WebCore::DocLoader::requestPreload):
9884 * loader/DocLoader.h:
9885 * loader/loader.cpp:
9886 (WebCore::Loader::Host::didFinishLoading):
9887 (WebCore::Loader::Host::didFail):
9888
adachan@apple.com94ac38d2008-08-15 21:08:40 +000098892008-08-15 Ada Chan <adachan@apple.com>
9890
9891 Use item's computed style if the render style is 0 before falling back to the <select>'s style.
9892 This way style set on an <hr> within a <select> will be honored.
9893
9894 Reviewed by Dave Hyatt and Dan Bernstein.
9895
9896 * rendering/RenderMenuList.cpp:
9897 (WebCore::RenderMenuList::itemStyle):
9898
antti@apple.com9f7911472008-08-15 20:48:06 +000098992008-08-15 Antti Koivisto <antti@apple.com>
9900
9901 Reviewed by Oliver.
9902
9903 Some loader performance tweaks:
9904 - Make stylesheets highest priority instead of scripts. We block script execution on stylesheets.
9905 Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue
9906 to not delay rendering.
9907 - Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup
9908 can take long time when latency is high so it is good to get started early.
9909 - When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the
9910 load queues. Issue remaining loads to the network layer.
9911
9912 * loader/loader.cpp:
9913 (WebCore::Loader::determinePriority):
9914 (WebCore::Loader::load):
9915 (WebCore::Loader::Host::servePendingRequests):
9916 * loader/loader.h:
9917
timothy@apple.com2d974c32008-08-15 18:35:39 +000099182008-08-15 Timothy Hatcher <timothy@apple.com>
9919
9920 Detach the script debugger when the Web Inspector's window closes.
9921 This has always been the intended design, but never fully implemented.
9922
9923 https://bugs.webkit.org/show_bug.cgi?id=20402
9924
9925 Reviewed by Adam Roben.
9926
9927 * page/InspectorController.cpp:
9928 (WebCore::InspectorController::setWindowVisible): Call stopDebugging()
9929 if the window is no longer visible.
9930
hausmann@webkit.orgbb4b9142008-08-15 18:11:34 +000099312008-08-15 HÃ¥vard Wall <hwall@trolltech.com>
9932
9933 Reviewed by Simon.
9934
hausmann@webkit.org58144a72008-08-15 18:12:08 +00009935 Fixes: compile with QT_NO_CONTEXTMENU
9936
9937 * platform/qt/PlatformMouseEventQt.cpp:
9938 (WebCore::PlatformMouseEvent::PlatformMouseEvent):
9939 * platform/qt/PlatformScrollBarQt.cpp:
9940 (WebCore::PlatformScrollbar::handleMouseMoveEvent):
9941 (WebCore::PlatformScrollbar::handleContextMenuEvent):
9942
99432008-08-15 HÃ¥vard Wall <hwall@trolltech.com>
9944
9945 Reviewed by Simon.
9946
hausmann@webkit.orgbb4b9142008-08-15 18:11:34 +00009947 Fixes: compile with QT_NO_WHEELEVENT
9948
9949 * platform/qt/WheelEventQt.cpp:
9950 (WebCore::PlatformWheelEvent::PlatformWheelEvent):
9951
timothy@apple.com4889e612008-08-15 17:06:14 +000099522008-08-15 Keishi Hattori <casey.hattori@gmail.com>
9953
timothy@apple.comd64639c2008-08-15 17:48:36 +00009954 Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector
9955
9956 https://bugs.webkit.org/show_bug.cgi?id=20210
9957
9958 Reviewed by Tim Hatcher.
9959
9960 * page/Console.cpp:
9961 (WebCore::Console::group):
9962 (WebCore::Console::groupEnd):
9963 * page/Console.h:
9964 (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
9965 * page/InspectorController.cpp:
9966 (WebCore::InspectorController::startGroup): Increments group level by
9967 one and adds console message with StartGroupMessaageLevel.
9968 (WebCore::InspectorController::endGroup): Decrements group level by one
9969 and adds console message with EndGroupMessaageLevel.
9970 * page/InspectorController.h:
9971 * page/inspector/Console.js:
9972 (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup
9973 if the message is StartGroupMessaageLevel.
9974 (WebInspector.ConsoleMessage.prototype.toMessageElement):
9975 (WebInspector.ConsoleGroup.prototype.addMessage):
9976 * page/inspector/inspector.js:
9977
99782008-08-15 Keishi Hattori <casey.hattori@gmail.com>
9979
timothy@apple.com7310b6a2008-08-15 17:35:22 +00009980 Adds support for console.dir to the Inspector
9981
9982 https://bugs.webkit.org/show_bug.cgi?id=19155
9983
9984 Reviewed by Tim Hatcher.
9985
9986 * bindings/js/JSConsoleCustom.cpp:
9987 (WebCore::JSConsole::dir):
9988 * page/Console.cpp:
9989 (WebCore::Console::dir):
9990 * page/Console.h: Added ObjectMessageLevel.
9991 * page/Console.idl: Added console.dir.
9992 * page/inspector/Console.js:
9993 (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an
9994 ObjectPropertiesSection if the MessageLevel is Object.
9995 * page/inspector/ObjectPropertiesSection.js: "in" operator can't be
9996 used on primitive data types.
9997 * page/inspector/inspector.css:
9998
99992008-08-15 Keishi Hattori <casey.hattori@gmail.com>
10000
timothy@apple.com4889e612008-08-15 17:06:14 +000010001 Adds support for clear() in the Inspector console.
10002
10003 https://bugs.webkit.org/show_bug.cgi?id=19873
10004
10005 Reviewed by Tim Hatcher.
10006
10007 * page/inspector/Console.js:
10008
timothy@apple.com12c5b5d2008-08-15 17:02:44 +0000100092008-08-15 Anthony Ricaud <rik24d@gmail.com>
10010
10011 Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
10012
10013 Platform distinction and modifier key matching adjusted
10014 by Daniel Jalkut <jalkut@red-sweater.com>
10015
10016 Bug 16313: text search (find) keybindings should work in the Web Inspector
10017 https://bugs.webkit.org/show_bug.cgi?id=16313
10018
10019 Reviewed by Tim Hatcher.
10020
10021 * page/inspector/inspector.js: Added a case for the F key
10022
timothy@apple.coma5ba4392008-08-15 16:50:26 +0000100232008-08-15 Keishi Hattori <casey.hattori@gmail.com>
10024
10025 Fix for error when the string doesn't contain a webkit-profile link.
10026
10027 https://bugs.webkit.org/show_bug.cgi?id=20399
10028
10029 Reviewed by Tim Hatcher.
10030
10031 * page/inspector/inspector.js:
10032
timothy@apple.com895b2652008-08-15 16:33:27 +0000100332008-08-15 Timothy Hatcher <timothy@apple.com>
10034
10035 Fixes two bugs where JavaScript could be executed from the page
10036 while the debugger is paused.
10037
10038 The first issue was JSLazyEventListener not checking the paused
10039 state before parsing the code.
10040
10041 The second issue was with the PageGroup version of
10042 JavaScriptDebugServer::setJavaScriptPaused always passing false
10043 to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
10044 and not the paused argument.
10045
10046 https://bugs.webkit.org/show_bug.cgi?id=20284
10047
10048 Reviewed by Adam Roben.
10049
10050 * bindings/js/JSEventListener.cpp:
10051 (WebCore::JSLazyEventListener::parseCode): Check the paused
10052 state of the ScriptController. Return early if paused.
10053 * manual-tests/inspector/debugger-execution-while-paused.html: Added.
10054 * page/JavaScriptDebugServer.cpp:
10055 (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
10056 Pass the paused argument to the Page version of setJavaScriptPaused.
10057
ap@webkit.orgbe495d32008-08-15 07:43:48 +0000100582008-08-15 Alexey Proskuryakov <ap@webkit.org>
10059
10060 Reviewed by Geoff Garen.
10061
10062 JSStringRef is created context-free, but can get linked to one via an identifier table,
10063 breaking an implicit API contract.
10064
10065 * page/InspectorController.cpp:
10066 (WebCore::jsStringRef):
10067 (WebCore::InspectorController::didParseSource):
10068 (WebCore::InspectorController::failedToParseSource):
10069 * page/JavaScriptProfile.cpp:
10070 (WebCore::getTitleCallback):
10071 Updated for JavaScriptCore changes.
10072
kevino@webkit.org8fe09ff2008-08-15 05:10:57 +0000100732008-08-14 Kevin Ollivier <kevino@theolliviers.com>
10074
10075 wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with
10076 an alternative that performs reasonably well. (GDI+ is too slow in many cases.)
10077
10078 * platform/graphics/AffineTransform.h:
10079
adele@apple.com2b2e2f82008-08-15 00:53:36 +0000100802008-08-14 Eric Carlson <eric.carlson@apple.com>
10081
10082 Reviewed by Adele.
10083
10084 Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
10085 <video> elements on Windows never becomes visible when a page is restored from the cache
10086
10087 Always pass "set" calls down to MediaPlayerPrivate instead of only when the
10088 value is different from the cached value. Let the implementation decide when
10089 to avoid work because nothing has changed.
10090
10091 * platform/graphics/MediaPlayer.cpp:
10092 (WebCore::MediaPlayer::setVolume):
10093 (WebCore::MediaPlayer::setRate):
10094 (WebCore::MediaPlayer::setRect):
10095 (WebCore::MediaPlayer::setVisible):
10096
timothy@apple.comda810f42008-08-14 23:57:14 +0000100972008-08-14 Keishi Hattori <casey.hattori@gmail.com>
10098
10099 Make Firebug command line API respect predefined variables.
10100
timothy@apple.com90751f02008-08-14 23:58:19 +000010101 https://bugs.webkit.org/show_bug.cgi?id=20385
10102
timothy@apple.comda810f42008-08-14 23:57:14 +000010103 Reviewed by Tim Hatcher.
10104
10105 * page/inspector/Console.js:
10106
weinig@apple.com4b51d002008-08-14 23:33:22 +0000101072008-08-14 Sam Weinig <sam@webkit.org>
10108
10109 Reviewed by Geoffrey Garen and Timothy Hatcher.
10110
10111 Allow programatically setting the HTMLTokenizers time delay and chunk size
10112 which are used for determining how aggressively we yield.
10113
10114 * WebCore.base.exp:
10115 * html/HTMLTokenizer.cpp:
10116 (WebCore::HTMLTokenizer::begin):
10117 (WebCore::HTMLTokenizer::continueProcessing):
10118 * html/HTMLTokenizer.h:
10119 * page/Page.cpp:
10120 (WebCore::Page::Page):
10121 (WebCore::Page::setCustomHTMLTokenizerTimeDelay):
10122 (WebCore::Page::setCustomHTMLTokenizerChunkSize):
10123 * page/Page.h:
10124 (WebCore::Page::hasCustomHTMLTokenizerTimeDelay):
10125 (WebCore::Page::customHTMLTokenizerTimeDelay):
10126 (WebCore::Page::hasCustomHTMLTokenizerChunkSize):
10127 (WebCore::Page::customHTMLTokenizerChunkSize):
10128
eric@webkit.org89613d22008-08-14 23:19:17 +0000101292008-08-14 Eric Seidel <eric@webkit.org>
10130
eric@webkit.org7e897c32008-08-14 23:20:00 +000010131 Reviewed by Beth.
10132
10133 Move us one step closer to cross-platform svg/graphics code
10134
10135 * WebCore.xcodeproj/project.pbxproj:
10136 * html/CanvasStyle.cpp:
10137 * platform/graphics/Color.cpp:
10138 (WebCore::colorWithOverrideAlpha):
10139 * platform/graphics/Color.h:
10140 * svg/graphics/cg/CgSupport.cpp:
10141 (WebCore::applyStrokeStyleToContext):
10142 (WebCore::strokeBoundingBox):
10143 * svg/graphics/cg/SVGPaintServerSolidCg.cpp:
10144 (WebCore::SVGPaintServerSolid::setup):
10145
101462008-08-14 Eric Seidel <eric@webkit.org>
10147
eric@webkit.org4f490652008-08-14 23:19:31 +000010148 Reviewed by Alexey.
10149
eric@webkit.org73fa9d12008-08-14 23:19:44 +000010150 Remove un-need includes from HTMLCanvas and use the
10151 Gradient platform abstraction in one place in CanvasStyle
10152
10153 * html/CanvasRenderingContext2D.cpp:
10154 (WebCore::CanvasRenderingContext2D::fillRect):
10155 * html/CanvasStyle.cpp:
10156 * html/HTMLCanvasElement.cpp:
10157
101582008-08-14 Eric Seidel <eric@webkit.org>
10159
10160 Reviewed by Alexey.
10161
eric@webkit.org4f490652008-08-14 23:19:31 +000010162 Clean up GlyphBuffer.h, removing more #ifdefs
10163
10164 * platform/graphics/GlyphBuffer.h:
10165 (WebCore::GlyphBuffer::glyphAt):
10166 (WebCore::GlyphBuffer::advanceAt):
10167 (WebCore::GlyphBuffer::add):
10168
101692008-08-14 Eric Seidel <eric@webkit.org>
10170
eric@webkit.org89613d22008-08-14 23:19:17 +000010171 Reviewed by Sam.
10172
10173 Clean up AffineTransform.h, removing #ifdefs
10174
10175 * platform/graphics/AffineTransform.h:
10176 * platform/graphics/cairo/AffineTransformCairo.cpp:
10177 * platform/graphics/cg/AffineTransformCG.cpp:
10178 * platform/graphics/qt/AffineTransformQt.cpp:
10179 * platform/graphics/wx/AffineTransformWx.cpp:
10180
mitz@apple.com551d6252008-08-14 23:08:09 +0000101812008-08-14 Dan Bernstein <mitz@apple.com>
10182
mitz@apple.com94c1a7d2008-08-14 23:12:34 +000010183 - fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
10184
10185 * platform/graphics/cairo/ImageSourceCairo.cpp:
10186 (WebCore::ImageSource::frameSizeAtIndex):
10187 * platform/graphics/qt/ImageSourceQt.cpp:
10188 (WebCore::ImageSource::frameSizeAtIndex):
10189 * platform/graphics/wx/ImageSourceWx.cpp:
10190 (WebCore::ImageSource::frameSizeAtIndex):
10191
101922008-08-14 Dan Bernstein <mitz@apple.com>
10193
mitz@apple.com551d6252008-08-14 23:08:09 +000010194 Reviewed by Brady Eidson.
10195
10196 - fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
10197
10198 * platform/graphics/BitmapImage.cpp:
10199 (WebCore::BitmapImage::BitmapImage): Added initialization of
10200 m_hasUniformFrameSize.
10201 (WebCore::BitmapImage::cacheFrame): Added code to get the size of the
10202 cached frame for use in decoded size computation and for setting
10203 m_hasUniformFrameSize.
10204 (WebCore::BitmapImage::currentFrameSize): Added.
10205 (WebCore::BitmapImage::dataChanged): Added code to reset
10206 m_hasUniformFrameSize.
10207 * platform/graphics/BitmapImage.h: Added currentFrameSize() and
10208 m_hasUniformFrameSize.
10209 * platform/graphics/ImageSource.h: Added frameSizeAtIndex().
10210 * platform/graphics/cg/ImageCG.cpp:
10211 (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This
10212 fixes the bug, which resulted from assuming that the frame being drawn
10213 was the same size as the first frame.
10214 * platform/graphics/cg/ImageSourceCG.cpp:
10215 (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and
10216 changed to get the size of the frame at the given index.
10217 (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
10218
simon.fraser@apple.com50954e52008-08-14 23:04:41 +0000102192008-08-13 Simon Fraser <simon.fraser@apple.com>
10220
10221 Reviewed by Eric Seidel
10222
10223 Fix @font-face inside @media rule crash.
10224 https://bugs.webkit.org/show_bug.cgi?id=20367
10225
10226 Test: fast/css/font-face-in-media-rule.html
10227
10228 * css/CSSStyleSelector.cpp:
10229 (WebCore::CSSRuleSet::addRulesFromSheet):
10230
kevino@webkit.org141c4602008-08-14 22:52:55 +0000102312008-08-14 Kevin Ollivier <kevino@theolliviers.com>
10232
10233 wx build fixes after recent changes to Canvas and Image classes.
10234
10235 * platform/graphics/Pattern.h:
10236 * platform/graphics/wx/GradientWx.cpp:
10237 (WebCore::Gradient::fill):
10238 * platform/graphics/wx/GraphicsContextWx.cpp:
10239 (WebCore::GraphicsContext::applyFillPattern):
10240 (WebCore::GraphicsContext::applyStrokePattern):
10241 * platform/graphics/wx/ImageBufferWx.cpp:
10242 (WebCore::ImageBuffer::image):
10243 * platform/graphics/wx/ImageWx.cpp:
10244 (WebCore::Image::loadPlatformResource):
10245
britto@apple.comd7008662008-08-14 19:26:02 +0000102462008-08-14 Maxime Britto <britto@apple.com>
10247
10248 Reviewed by Sam Weinig.
10249
10250 rdar://6102511
10251 When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
10252 IE and FF are both preventing the keyboard event to interact with the page while scrolling.
10253 Some differences exist between them concerning the kind of key which is pressed :
10254 IE7 : every key leads to a stop of the panning
10255 FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
10256 For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.
10257
10258 * page/EventHandler.cpp:
10259 (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
10260
christian@webkit.org0e20f322008-08-14 19:14:47 +0000102612008-08-14 Christian Dywan <christian@twotoasts.de>
10262
10263 Gtk+/ Cairo build fix, patch by Dirk Schulze.
10264
10265 * html/CanvasStyle.cpp:
10266 * platform/graphics/cairo/PatternCairo.cpp:
10267 (WebCore::Pattern::createPlatformPattern):
10268 * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
10269
kmccullough@apple.comd2b50f12008-08-14 18:11:20 +0000102702008-08-14 Kevin McCullough <kmccullough@apple.com>
10271
10272 Reviewed by Tim.
10273
10274 <rdar://problem/6115819> Notify of profile in console
10275
10276 * page/InspectorController.cpp:
10277 (WebCore::InspectorController::addProfile):
10278 (WebCore::InspectorController::addProfileMessageToConsole): Called by
10279 addProfile this is the function that adds a message to the console that
10280 a profile finished.
10281 * page/InspectorController.h:
10282 * page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match
10283 the console log to the profile in the web inspector.
10284 (WebCore::getUniqueIdCallback):
10285 (WebCore::ProfileClass):
10286 * page/inspector/ProfilesPanel.js: Created a map of all the profiles by
10287 Id to bring up the requested profile. Also select and reveal the
10288 profile in the profile panel. And created displayTitleForProfileLink()
10289 which formats a title taking into account if it's user initiated or if
10290 there are multiples. Lasty, I put the user initiated profile in a
10291 variable.
10292 * page/inspector/inspector.js: Make the profile title be a clickable
10293 link that will take the user to the identified profile. Also expose
10294 the count of user initiated profiles so they can be displayed in the
10295 console with the correct count.
10296
timothy@apple.comcd7f0f32008-08-14 17:41:05 +0000102972008-08-14 Timothy Hatcher <timothy@apple.com>
10298
10299 Avoid formating ConsoleMessages twice unless the message will be
10300 displayed in bubbles of a SourceFrame.
10301
10302 Reviewed by Kevin McCullough.
10303
10304 * page/inspector/Console.js:
10305 (WebInspector.ConsoleMessage): Only format the plain text message
10306 if the URL and line are valid and the level is error or warning.
10307 (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added.
10308 Helper to test for error or warning level.
10309 * page/inspector/SourceFrame.js:
10310 (WebInspector.SourceFrame.prototype.addMessage): Don't add the
10311 message if there is no message or valid line or if the msg
10312 isn't an error or warning.
10313
jmalonzo@webkit.orgb469bb72008-08-14 15:07:41 +0000103142008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
10315
10316 partial Gtk build fix, not reviewed
10317
10318 * platform/graphics/cairo/PatternCairo.cpp:
10319
weinig@apple.com45e83142008-08-14 04:49:30 +0000103202008-08-13 Sam Weinig <sam@webkit.org>
10321
10322 Reviewed by Anders Carlson.
10323
10324 Fix style issue.
10325
10326 * html/HTMLMediaElement.cpp:
10327 (WebCore::HTMLMediaElement::pickMedia):
10328
zimmermann@webkit.org9ae47e92008-08-14 02:22:35 +0000103292008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
10330
zimmermann@webkit.org7a2f53d2008-08-14 03:06:01 +000010331 Build fix for Cairo, not reviewed. (exposed by gtk build slave)
10332 Continue Erics build fixes, after the Image cleanup.
10333
10334 * platform/graphics/cairo/ImageBufferCairo.cpp:
10335 (WebCore::ImageBuffer::image):
10336
103372008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
10338
zimmermann@webkit.org1ef52132008-08-14 02:38:16 +000010339 Build fix for Qt, not reviewed.
10340 Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.
10341
10342 * dom/XMLTokenizer.cpp:
10343 (WebCore::eventuallyMarkAsParserCreated): Was erre
10344
103452008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
10346
zimmermann@webkit.org3e560562008-08-14 02:26:00 +000010347 Build fix, not reviewed.
10348 Add ScriptElement.cpp to Gtk build.
10349
10350 * GNUmakefile.am:
10351
103522008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
10353
zimmermann@webkit.org9ae47e92008-08-14 02:22:35 +000010354 Reviewed by Eric.
10355
10356 Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
10357
10358 Refactor HTMLScriptElement's code into a common base class: ScriptElement.
10359 SVGScriptElement will be converted to use ScriptElement in a follow-up patch.
10360
10361 This resolves code duplications and allows us to completly replace the old
10362 SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)
10363
10364 As ScriptElement, doesn't actually inherit from Element, we may want to rename
10365 it, though StyleElement uses the same naming convention, so I left it as is for now.
10366 Eventually we'll rename both files in future.
10367
10368 No functional changes yet, as SVGScriptElement doesn't yet use the new base class.
10369
10370 * WebCore.pro: Add new ScriptElement.cpp to build.
10371 * WebCore.vcproj/WebCore.vcproj: Ditto.
10372 * WebCore.xcodeproj/project.pbxproj: Ditto.
10373 * WebCoreSources.bkl: Dutto.
10374 * dom/ScriptElement.cpp: Added. 1:1 based on HTMLScriptElement
10375 (WebCore::ScriptElement::insertedIntoDocument):
10376 (WebCore::ScriptElement::removedFromDocument):
10377 (WebCore::ScriptElement::childrenChanged):
10378 (WebCore::ScriptElement::finishParsingChildren):
10379 (WebCore::ScriptElement::handleSourceAttribute):
10380 (WebCore::isSupportedJavaScriptLanguage):
10381 (WebCore::ScriptElementData::ScriptElementData):
10382 (WebCore::ScriptElementData::~ScriptElementData):
10383 (WebCore::ScriptElementData::requestScript):
10384 (WebCore::ScriptElementData::evaluateScript):
10385 (WebCore::ScriptElementData::stopLoadRequest):
10386 (WebCore::ScriptElementData::notifyFinished):
10387 (WebCore::ScriptElementData::ignoresLoadRequest):
10388 (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
10389 (WebCore::ScriptElementData::scriptCharset):
10390 (WebCore::ScriptElementData::scriptContent):
10391 * dom/ScriptElement.h: Added.
10392 (WebCore::ScriptElement::ScriptElement):
10393 (WebCore::ScriptElement::~ScriptElement):
10394 (WebCore::ScriptElementData::element):
10395 (WebCore::ScriptElementData::createdByParser):
10396 (WebCore::ScriptElementData::setCreatedByParser):
10397 * dom/XMLTokenizer.cpp:
10398 (WebCore::isScriptElement):
10399 (WebCore::castToScriptElement):
10400 (WebCore::eventuallyMarkAsParserCreated):
10401 (WebCore::XMLTokenizer::startElementNs):
10402 (WebCore::XMLTokenizer::endElementNs):
10403 (WebCore::createXHTMLParserErrorHeader):
10404 (WebCore::XMLTokenizer::insertErrorMessageBlock):
10405 * html/HTMLScriptElement.cpp: Refactored code, pushed most code down to ScriptElement.
10406 (WebCore::HTMLScriptElement::HTMLScriptElement):
10407 (WebCore::HTMLScriptElement::~HTMLScriptElement):
10408 (WebCore::HTMLScriptElement::isURLAttribute):
10409 (WebCore::HTMLScriptElement::setCreatedByParser):
10410 (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
10411 (WebCore::HTMLScriptElement::childrenChanged):
10412 (WebCore::HTMLScriptElement::parseMappedAttribute):
10413 (WebCore::HTMLScriptElement::finishParsingChildren):
10414 (WebCore::HTMLScriptElement::insertedIntoDocument):
10415 (WebCore::HTMLScriptElement::removedFromDocument):
10416 (WebCore::HTMLScriptElement::text):
10417 (WebCore::HTMLScriptElement::setText):
10418 (WebCore::HTMLScriptElement::setHtmlFor):
10419 (WebCore::HTMLScriptElement::setEvent):
10420 (WebCore::HTMLScriptElement::charset):
10421 (WebCore::HTMLScriptElement::src):
10422 (WebCore::HTMLScriptElement::type):
10423 (WebCore::HTMLScriptElement::scriptCharset):
10424 (WebCore::HTMLScriptElement::scriptContent):
10425 (WebCore::HTMLScriptElement::sourceAttributeValue):
10426 (WebCore::HTMLScriptElement::charsetAttributeValue):
10427 (WebCore::HTMLScriptElement::typeAttributeValue):
10428 (WebCore::HTMLScriptElement::languageAttributeValue):
10429 (WebCore::HTMLScriptElement::dispatchLoadEvent):
10430 (WebCore::HTMLScriptElement::dispatchErrorEvent):
10431 * html/HTMLScriptElement.h:
10432 * svg/SVGScriptElement.cpp: Inherit from ScriptElement, don't actually use it yet.
10433 * svg/SVGScriptElement.cpp:
10434 (WebCore::SVGScriptElement::SVGScriptElement):
10435 (WebCore::SVGScriptElement::scriptContent):
10436 (WebCore::SVGScriptElement::sourceAttributeValue):
10437 (WebCore::SVGScriptElement::charsetAttributeValue):
10438 (WebCore::SVGScriptElement::typeAttributeValue):
10439 (WebCore::SVGScriptElement::languageAttributeValue):
10440 (WebCore::SVGScriptElement::dispatchLoadEvent):
10441 (WebCore::SVGScriptElement::dispatchErrorEvent):
10442 * svg/SVGScriptElement.h:
10443 (WebCore::SVGScriptElement::setCreatedByParser):
10444
eric@webkit.org7811ef02008-08-14 00:28:51 +0000104452008-08-13 Eric Seidel <eric@webkit.org>
10446
eric@webkit.org3562c592008-08-14 02:17:29 +000010447 Attempt to fix the Gtk build, no review.
10448
10449 I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.
10450
10451 * platform/graphics/GraphicsContext.h:
10452 * platform/graphics/cairo/GraphicsContextCairo.cpp:
10453 * platform/graphics/qt/GradientQt.cpp:
10454 * platform/graphics/qt/GraphicsContextQt.cpp:
10455 * platform/gtk/RenderThemeGtk.cpp:
10456 (WebCore::paintMozWidget):
10457
104582008-08-13 Eric Seidel <eric@webkit.org>
10459
eric@webkit.org2ec42072008-08-14 02:03:09 +000010460 Yet another attempt to fix the Qt build, no review.
10461
10462 * platform/graphics/qt/GradientQt.cpp:
10463 * platform/graphics/qt/GraphicsContextQt.cpp:
10464 (WebCore::GraphicsContext::applyStrokePattern):
10465 (WebCore::GraphicsContext::applyFillPattern):
10466
104672008-08-13 Eric Seidel <eric@webkit.org>
10468
10469 Attempt to fix the Windows build, no review.
10470
10471 * platform/win/CursorWin.cpp:
10472 (WebCore::loadCursorByName):
10473 * platform/win/ScrollViewWin.cpp:
10474 (WebCore::ScrollView::paint):
10475
104762008-08-13 Eric Seidel <eric@webkit.org>
10477
eric@webkit.org508c0282008-08-14 01:29:34 +000010478 Attempt to fix the Windows build, no review.
10479
10480 * platform/win/CursorWin.cpp:
10481 (WebCore::loadCursorByName):
10482 * platform/win/ScrollViewWin.cpp:
10483 (WebCore::ScrollView::paint):
10484
104852008-08-13 Eric Seidel <eric@webkit.org>
10486
eric@webkit.org1bf70ab2008-08-14 01:24:15 +000010487 Attempt to fix the Qt build, no review.
10488
10489 * platform/graphics/qt/ImageBufferQt.cpp:
10490 (WebCore::ImageBuffer::image):
10491
104922008-08-13 Eric Seidel <eric@webkit.org>
10493
eric@webkit.orgf2d7c212008-08-14 01:21:34 +000010494 Attempt to fix the Windows build, no review.
10495
10496 * platform/graphics/win/ImageWin.cpp:
10497 (WebCore::Image::loadPlatformResource):
10498 * plugins/win/PluginViewWin.cpp:
10499 (WebCore::PluginView::paintMissingPluginIcon):
10500
105012008-08-13 Eric Seidel <eric@webkit.org>
10502
eric@webkit.orgac3f6662008-08-14 01:15:50 +000010503 Another attempt to fix the Qt build, no review.
10504
10505 * platform/graphics/qt/ImageQt.cpp:
10506 * platform/graphics/qt/StillImageQt.h:
10507
105082008-08-13 Eric Seidel <eric@webkit.org>
10509
eric@webkit.org31e0d812008-08-14 01:05:42 +000010510 No review, build fix only.
10511
10512 Fix mac build, due to change in new code since my patch was written.
10513
10514 * svg/graphics/cg/SVGResourceMaskerCg.mm:
10515 (WebCore::SVGResourceMasker::applyMask):
10516
105172008-08-13 Eric Seidel <eric@webkit.org>
10518
eric@webkit.orga20a0032008-08-14 00:42:54 +000010519 Build fix only, no review.
10520
10521 Attempt to fix the Qt build.
10522
eric@webkit.org923255c2008-08-14 00:59:20 +000010523 * platform/graphics/qt/ImageBufferQt.cpp:
10524 * platform/graphics/qt/StillImageQt.h:
10525 (WebCore::StillImage::create):
10526 (WebCore::StillImage::destroyDecodedData):
10527 (WebCore::StillImage::decodedSize):
10528
105292008-08-13 Eric Seidel <eric@webkit.org>
10530
10531 Build fix only, no review.
10532
10533 Attempt to fix the Qt build.
10534
eric@webkit.orga20a0032008-08-14 00:42:54 +000010535 * html/CanvasStyle.cpp:
10536 (WebCore::CanvasStyle::applyStrokeColor):
10537 (WebCore::CanvasStyle::applyFillColor):
10538
105392008-08-13 Eric Seidel <eric@webkit.org>
10540
eric@webkit.org4aca3be2008-08-14 00:30:04 +000010541 Reviewed by Sam.
10542
10543 Match HTML5 spec by throwing INVALID_STATE_ERR when
10544 createPattern is called and the HTMLImageElement is not
10545 yet done loading the image (!isComplete)
10546 https://bugs.webkit.org/show_bug.cgi?id=20351
10547
10548 Test: http/misc/canvas-pattern-from-incremental-image.html
10549
10550 * html/CanvasRenderingContext2D.cpp:
10551 (WebCore::CanvasRenderingContext2D::createPattern):
10552
105532008-08-13 Eric Seidel <eric@webkit.org>
10554
eric@webkit.org5b265602008-08-14 00:29:26 +000010555 Reviewed by Niko.
10556
eric@webkit.orgf0124f62008-08-14 00:29:50 +000010557 Split out a Pattern class from CanvasPattern
10558 and remove all the Pattern-related #ifdefs
10559 (This will break non-mac platforms! I will fix them.)
10560 https://bugs.webkit.org/show_bug.cgi?id=20351
10561
10562 * GNUmakefile.am:
10563 * WebCore.pro:
10564 * WebCore.vcproj/WebCore.vcproj:
10565 * WebCore.xcodeproj/project.pbxproj:
10566 * WebCoreSources.bkl:
10567 * html/CanvasPattern.cpp:
10568 (WebCore::CanvasPattern::parseRepetitionType):
10569 (WebCore::CanvasPattern::CanvasPattern):
10570 * html/CanvasPattern.h:
10571 (WebCore::CanvasPattern::create):
10572 (WebCore::CanvasPattern::pattern):
10573 (WebCore::CanvasPattern::originClean):
10574 * html/CanvasRenderingContext2D.cpp:
10575 (WebCore::CanvasRenderingContext2D::createPattern):
10576 (WebCore::CanvasRenderingContext2D::applyStrokePattern):
10577 (WebCore::CanvasRenderingContext2D::applyFillPattern):
10578 * html/CanvasRenderingContext2D.h:
10579 * html/HTMLCanvasElement.cpp:
10580 * html/HTMLCanvasElement.h:
10581 * loader/FrameLoader.cpp:
10582 (WebCore::FrameLoader::createHistoryItem):
10583 * platform/graphics/GraphicsContext.h:
10584 * platform/graphics/cairo/GraphicsContextCairo.cpp:
10585 (WebCore::GraphicsContext::applyStrokePattern):
10586 (WebCore::GraphicsContext::applyFillPattern):
10587 * platform/graphics/cg/GraphicsContextCG.cpp:
10588 (WebCore::GraphicsContext::clipToImageBuffer):
10589 (WebCore::GraphicsContext::applyStrokePattern):
10590 (WebCore::GraphicsContext::applyFillPattern):
10591
105922008-08-13 Eric Seidel <eric@webkit.org>
10593
10594 Reviewed by Niko.
10595
eric@webkit.org5b265602008-08-14 00:29:26 +000010596 Make Images RefCounted (and clean up callers)
10597 https://bugs.webkit.org/show_bug.cgi?id=20351
10598
10599 * editing/DeleteButtonController.cpp:
10600 (WebCore::DeleteButtonController::createDeletionUI):
10601 * loader/CachedImage.cpp:
10602 (WebCore::CachedImage::CachedImage):
10603 (WebCore::brokenImage):
10604 (WebCore::nullImage):
10605 (WebCore::CachedImage::image):
10606 (WebCore::CachedImage::notifyObservers):
10607 (WebCore::CachedImage::createImage):
10608 * loader/CachedImage.h:
10609 * loader/icon/IconRecord.cpp:
10610 (WebCore::IconRecord::setImageData):
10611 (WebCore::IconRecord::loadImageFromResource):
10612 * loader/icon/IconRecord.h:
10613 * platform/graphics/BitmapImage.h:
10614 (WebCore::BitmapImage::create):
10615 * platform/graphics/GeneratedImage.h:
10616 * platform/graphics/Gradient.cpp:
10617 * platform/graphics/Gradient.h:
10618 * platform/graphics/Image.cpp:
10619 (WebCore::Image::nullImage):
10620 * platform/graphics/Image.h:
10621 * platform/graphics/ImageBuffer.h:
10622 * platform/graphics/cairo/ImageBufferCairo.cpp:
10623 (WebCore::ImageBuffer::image):
10624 * platform/graphics/cg/ImageBufferCG.cpp:
10625 (WebCore::ImageBuffer::image):
10626 (WebCore::ImageBuffer::getImageData):
10627 (WebCore::ImageBuffer::putImageData):
10628 * platform/graphics/cg/PDFDocumentImage.h:
10629 (WebCore::PDFDocumentImage::create):
10630 (WebCore::PDFDocumentImage::destroyDecodedData):
10631 (WebCore::PDFDocumentImage::decodedSize):
10632 * platform/graphics/gtk/ImageGtk.cpp:
10633 (WebCore::Image::loadPlatformResource):
10634 * platform/graphics/mac/ImageMac.mm:
10635 (WebCore::Image::loadPlatformResource):
10636 * rendering/RenderImage.cpp:
10637 * rendering/RenderLayer.cpp:
10638 (WebCore::RenderLayer::paintOverflowControls):
10639 * svg/graphics/SVGImage.cpp:
10640 (WebCore::SVGImage::nativeImageForCurrentFrame):
10641 * svg/graphics/SVGImage.h:
10642 (WebCore::SVGImage::create):
10643 (WebCore::SVGImage::destroyDecodedData):
10644 (WebCore::SVGImage::decodedSize):
10645 (WebCore::SVGImage::frameAtIndex):
10646 * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
10647 (WebCore::SVGPaintServerPattern::setup):
10648 * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
10649 (WebCore::SVGResourceMasker::applyMask):
10650 * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
10651 (WebCore::patternCallback):
10652 * svg/graphics/cg/SVGResourceMaskerCg.mm:
10653 (WebCore::SVGResourceMasker::applyMask):
10654
106552008-08-13 Eric Seidel <eric@webkit.org>
10656
10657 Reviewed by Niko.
eric@webkit.org7811ef02008-08-14 00:28:51 +000010658
10659 Remove #ifdefs from CanvasStyle by using platform/Color.h
eric@webkit.org5b265602008-08-14 00:29:26 +000010660 https://bugs.webkit.org/show_bug.cgi?id=20351
eric@webkit.org7811ef02008-08-14 00:28:51 +000010661
10662 There are some down-sides to this commit.
10663 This commit limits us to 255 levels of grey for calls like:
10664 context.setStrokeStyle(.37, 1.0)
10665 previously CG might have used up to 32bits to store the grey level
10666 Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.
10667
10668 Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
10669 to RGBA32 (like all the rest of colors in WebCore), thus:
10670 context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
10671 context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32
10672
10673 If this is a problem for Dashboard, we can either roll out this commit
10674 or add a beefier Color abstraction, which can be used internally by GraphicsContext
10675 when keeping state, and then GraphicsContext can grow some additional set* routines
10676 for setting the a grey/float/whatever fill and stroke.
10677
10678 * html/CanvasRenderingContext2D.cpp:
10679 (WebCore::CanvasRenderingContext2D::setFillStyle):
10680 * html/CanvasStyle.cpp:
10681 (WebCore::CanvasStyle::CanvasStyle):
10682 (WebCore::colorWithOverrideAlpha):
10683 (WebCore::CanvasStyle::applyStrokeColor):
10684 (WebCore::CanvasStyle::applyFillColor):
10685 * html/CanvasStyle.h:
10686 * platform/graphics/Color.cpp:
10687 (WebCore::colorFloatToRGBAByte):
10688 (WebCore::makeRGBA32FromFloats):
10689 * platform/graphics/Color.h:
10690
adele@apple.com83e44822008-08-13 23:50:41 +0000106912008-08-13 Eric Carlson <eric.carlson@apple.com>
10692
10693 Reviewed by Adele Peterson.
10694
10695 Fix for <rdar://problem/6137931>
10696 https://bugs.webkit.org/show_bug.cgi?id=20360
10697 Remove all parameters from the MIME type before checking with the MIME type registry
10698
10699 Tests: media/video-source-type-params.html
10700
10701 * html/HTMLMediaElement.cpp:
10702 (WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';'
10703 to isSupportedMediaMIMEType()
10704
bdakin@apple.com7bc81bf2008-08-13 21:36:15 +0000107052008-08-13 Beth Dakin <bdakin@apple.com>
10706
10707 Reviewed by Sam Weinig.
10708
10709 Fix for <rdar://problem/6141345>
10710
10711 This patch refines findString and markAllMatchesForText functions'
10712 interactions with disconnected frames. They no longer rely on
10713 knowing where a range is relative to the visible region and work
10714 with disconnected frames that contain frames.
10715
10716 * editing/Editor.cpp:
10717 (WebCore::Editor::insideVisibleArea): Now returns a bool instead of
10718 the visiblity enum.
10719 (WebCore::Editor::firstVisibleRange): This now returns the very
10720 first visible range in the document. It's no longer dependent on
10721 searching forward.
10722 (WebCore::Editor::lastVisibleRange): This now returns the very last
10723 visible range in the document. It's no longer dependent on
10724 searching backwards.
10725 (WebCore::Editor::nextVisibleRange): This returns the next visible
10726 range in the appropriate direction from the current range.
10727 * editing/Editor.h:
10728 * page/Frame.cpp:
10729 (WebCore::Frame::findString):
10730 (WebCore::Frame::markAllMatchesForText):
10731
kevino@webkit.orgee5adc42008-08-13 20:07:16 +0000107322008-08-13 Kevin Ollivier <kevino@theolliviers.com>
10733
10734 wx build fix for case-sensitive platforms, like Linux.
10735
10736 * WebCoreSources.bkl:
10737
jmalonzo@webkit.org210145b2008-08-13 19:56:20 +0000107382008-08-13 Marco Barisione <marco.barisione@collabora.co.uk>
10739
10740 Reviewed by Holger Freyther.
10741
10742 http://bugs.webkit.org/show_bug.cgi?id=16881
10743 [GTK] PlatformScreenGtk is unimplemented
10744
10745 Original patch by Christian Dywan.
10746
10747 * platform/gtk/PlatformScreenGtk.cpp:
10748 (WebCore::screenDepth):
10749 (WebCore::screenDepthPerComponent):
10750 (WebCore::screenIsMonochrome):
10751 (WebCore::screenRect):
10752 (WebCore::screenAvailableRect):
10753
jmalonzo@webkit.orge4693932008-08-13 19:42:08 +0000107542008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org>
10755
10756 Reviewed by Holger Freyther.
10757
10758 http://bugs.webkit.org/show_bug.cgi?id=20318
10759 SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add
10760
10761 g_idle_add is the same as g_idle_add_full with a priority of
10762 G_PRIORITY_DEFAULT_IDLE, so we can safely use that.
10763
10764 * platform/gtk/SharedTimerGtk.cpp:
10765 (WebCore::setSharedTimerFireTime):
10766
timothy@apple.comf0426602008-08-13 18:11:01 +0000107672008-08-13 Timothy Hatcher <timothy@apple.com>
10768
10769 Changed the InspectorController so it can be notified when the
10770 attached state of the Inspector changes in WebKit.
10771
10772 Reviewed by Kevin McCullough.
10773
10774 * WebCore.base.exp: Updated the symbol for setWindowVisible.
10775 * page/InspectorController.cpp:
10776 (WebCore::InspectorController::setWindowVisible): Added an attached argument,
10777 that defaults to false.Call setAttachedWindow with the attached argument.
10778 (WebCore::InspectorController::setAttachedWindow): Call the script version
10779 of setAttachedWindow.
10780 * page/InspectorController.h:
10781 * page/inspector/inspector.js:
10782 (WebInspector.setAttachedWindow): Set the attached property.
10783
timothy@apple.com9ea832b2008-08-13 18:10:36 +0000107842008-08-12 Timothy Hatcher <timothy@apple.com>
10785
timothy@apple.com72c92ae2008-08-13 18:10:45 +000010786 Added a close button to the Inspector's toolbar when docked.
10787
10788 https://bugs.webkit.org/show_bug.cgi?id=14270
10789
10790 Reviewed by Kevin McCullough.
10791
10792 * page/InspectorController.cpp:
10793 (WebCore::closeWindow): Call InspectorController::closeWindow.
10794 (WebCore::InspectorController::windowScriptObjectAvailable):
10795 Added closeWindow to the script class.
10796 * page/InspectorController.h:
10797 * page/inspector/Images/closeButtons.png: Added.
10798 * page/inspector/inspector.css: Added and changed styles.
10799 * page/inspector/inspector.html: Added the close button.
10800 * page/inspector/inspector.js:
10801 (WebInspector.loaded): Added click event listener to the close button.
10802 (WebInspector.close): Call InspectorController.closeWindow.
10803
108042008-08-12 Timothy Hatcher <timothy@apple.com>
10805
timothy@apple.com9ea832b2008-08-13 18:10:36 +000010806 Make the docked Web Inspector resizable. This is the cross platform
10807 portion of the code. Each InspectorClient needs to implement the
10808 real resize code.
10809
10810 https://bugs.webkit.org/show_bug.cgi?id=14282
10811
10812 Reviewed by Kevin McCullough.
10813
10814 * loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
10815 * page/InspectorClient.h: Added setAttachedWindowHeight.
10816 * page/InspectorController.cpp:
10817 (WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight
10818 on the InspectorController.
10819 (WebCore::InspectorController::setAttachedWindowHeight): Call
10820 setAttachedWindowHeight on the client.
10821 (WebCore::InspectorController::windowScriptObjectAvailable):
10822 Added setAttachedWindowHeight to the script class.
10823 * page/InspectorController.h:
10824 * page/inspector/inspector.css: Make the cursor on the toolbar be
10825 row-resize when docked.
10826 * page/inspector/inspector.js:
10827 (WebInspector.loaded): Always add the toolbarDragStart event listener.
10828 (WebInspector.toolbarDragStart): Return early if we are not attached
10829 and not on Leopard. Call WebInspector.elementDragStart.
10830 (WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd.
10831 (WebInspector.toolbarDrag): When attached call setAttachedWindowHeight,
10832 otherwise call moveByUnrestricted.
10833
hausmann@webkit.orgd34f1d22008-08-13 13:43:34 +0000108342008-08-13 Simon Hausmann <hausmann@webkit.org>
10835
10836 Reviewed by Holger.
10837
10838 Initialize m_zoomsTextOnly in the Settings constructor.
10839
10840 * page/Settings.cpp:
10841 (WebCore::Settings::Settings):
10842
hausmann@webkit.org74586d62008-08-13 13:31:11 +0000108432008-08-13 Brad Hughes <bhughes@trolltech.com>
10844
10845 Reviewed by Simon.
10846
10847 Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux
10848
10849 The latest upgrade of the intel compiler allows us to compile all of
10850 Qt with optimizations enabled (yay!).
10851
10852 * WebCore.pro:
10853
hausmann@webkit.org690b7fc2008-08-13 13:24:56 +0000108542008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com>
10855
10856 Reviewed by Simon.
10857
10858 Fix QtWebKit not displaying content on 403 HTTP responses
10859
10860 Just like with 404 responses also display content with 403, as
10861 used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/
10862
10863 * platform/network/qt/QNetworkReplyHandler.cpp:
10864 (WebCore::QNetworkReplyHandler::finish):
10865
hausmann@webkit.org88c4dc92008-08-13 12:02:00 +0000108662008-08-13 Simon Hausmann <hausmann@webkit.org>
10867
hausmann@webkit.orgd2315e32008-08-13 13:16:15 +000010868 Reviewed by Holger.
10869
10870 Qt part of https://bugs.webkit.org/show_bug.cgi?id=18994
10871
10872 Make the formatting of String::format() locale independent through the use of QString::vsprintf.
10873
10874 * platform/text/String.cpp:
10875 (WebCore::String::format):
10876
108772008-08-13 Simon Hausmann <hausmann@webkit.org>
10878
hausmann@webkit.org88c4dc92008-08-13 12:02:00 +000010879 Reviewed by Lars.
10880
10881 Fix QWebFrame::setHtml() not setting the new contents immediately.
10882
10883 Added a setter to the DocumentLoader to toggle the deferred loading of the main
10884 resource when it comes from substitute data.
10885
10886 Disable deferred loading of the main resource when we have valid substitute data,
10887 as used by QWebFrame::setHtml.
10888
10889 * loader/DocumentLoader.h:
10890
mrowe@apple.com6aa36d12008-08-13 09:58:32 +0000108912008-08-13 Mark Rowe <mrowe@apple.com>
10892
10893 Speculative GTK build fix.
10894
10895 * GNUmakefile.am: Add dependency info for JSSVGElementWrapperFactory.cpp.
10896
hausmann@webkit.org298ce5f2008-08-13 09:11:23 +0000108972008-08-13 Thiago Macieira <tjmaciei@trolltech.com>
10898
10899 Reviewed by Simon.
10900
10901 Fix encoding of [ and ] in the host part of the URL
10902
10903 Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to
10904 add this workaround to the QUrl <> WebCore::KURL conversion operator so that it
10905 doesn't encode [ and ] when they are found in the host part. That is, the
10906 following URL:
10907 http://[::1]/
10908 is valid and should not be reencoded to:
10909 http://%5b::1%5d/
10910
10911 * platform/qt/KURLQt.cpp:
10912 (WebCore::KURL::operator QUrl):
10913
mitz@apple.come198b012008-08-12 21:49:07 +0000109142008-08-12 Mihnea Ovidenie <mihnea@adobe.com>
10915
10916 Fix for https://bugs.webkit.org/show_bug.cgi?id=19891
10917 Broken HTML object elements cause de-reference of pointer to freed memory.
10918 If we fail to load an image for an object tag and we no longer believe the object tag points at
10919 an image, then clear m_imageLoader in the HTMLObjectElement so that we attempt to render the
10920 fall back content.
10921
10922 Reviewed by Dave Hyatt and Alexey Proskuryakov.
10923
10924 Test: http/tests/misc/object-image-error-with-onload.html
10925
10926 * html/HTMLObjectElement.cpp:
10927 (WebCore::HTMLObjectElement::renderFallbackContent):
10928 * page/Frame.cpp:
10929 (WebCore::Frame::Frame):
10930
zimmermann@webkit.org36a02512008-08-12 21:11:17 +0000109312008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
10932
10933 Reviewed by Dave.
10934
10935 Fixes: https://bugs.webkit.org/show_bug.cgi?id=19798
10936 Masks are translated, and the mask images are swapped on the y-axis.
10937
10938 Turned out that http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm
10939 is guilty. GraphicsContext::clipToImageBuffer() does some extra transformations that SVGResourcesMaskerCg does not want.
10940
10941 Long term goal is to remove the SVGResource*/SVGPaintServer* classes anyway, so it's okay to duplicate
10942 the "clip to image buffer" functionality, in the CG specific SVGResourceMaskerCg class - as it was before.
10943
10944 * svg/graphics/cg/SVGResourceMaskerCg.mm:
10945 (WebCore::SVGResourceMasker::applyMask): Changed back to use CG clipping again.
10946
mitz@apple.comf8a98692008-08-12 17:04:42 +0000109472008-08-12 Dan Bernstein <mitz@apple.com>
10948
mitz@apple.com1b7e844f2008-08-12 20:54:12 +000010949 - WebCore part of <rdar://problem/6121636>
10950 Make fast*alloc() abort() on failure and add "try" variants that
10951 return NULL on failure.
10952
10953 Reviewed by Darin Adler.
10954
10955 * platform/Arena.cpp:
10956 (WebCore::ArenaAllocate): Removed null checking of fastMalloc()'s
10957 result.
10958 * platform/graphics/cg/ImageBufferCG.cpp:
10959 (WebCore::ImageBuffer::create): Changed to use tryFastCalloc().
10960
109612008-08-12 Dan Bernstein <mitz@apple.com>
10962
mitz@apple.com1e09cd72008-08-12 18:27:58 +000010963 Reviewed by Darin Adler.
10964
10965 - fix https://bugs.webkit.org/show_bug.cgi?id=19348
10966 <rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works
10967
10968 Test: fast/frames/frameset-style-recalc.html
10969
10970 * html/HTMLFrameSetElement.cpp:
10971 (WebCore::HTMLFrameSetElement::recalcStyle): Changed to call the base
10972 class implementation after marking for layout.
10973
109742008-08-12 Dan Bernstein <mitz@apple.com>
10975
mitz@apple.comf8a98692008-08-12 17:04:42 +000010976 Reviewed by John Sullivan.
10977
10978 - move shouldUpdateWhenOffscreen from Settings to FrameView and rename it shouldUpdateWhileHidden
10979
10980 * WebCore.base.exp:
10981 * page/FrameView.cpp:
10982 (WebCore::FrameViewPrivate::FrameViewPrivate):
10983 (WebCore::FrameView::shouldUpdateWhileHidden):
10984 (WebCore::FrameView::setShouldUpdateWhileHidden):
10985 * page/FrameView.h:
10986 * page/Settings.cpp:
10987 * page/Settings.h:
10988
aroben@apple.comeeb8ebb2008-08-12 14:58:51 +0000109892008-08-12 Adam Roben <aroben@apple.com>
10990
10991 Windows build fix
10992
10993 * bindings/js/JSSVGPODTypeWrapper.h: Align
10994 JSSVGDynamicPODTypeWrapper's and JSSVGStaticPODTypeWrapperWithParent's
10995 members on 16-byte boundaries to avoid an alignment warning.
10996
zimmermann@webkit.orge1388112008-08-12 10:27:53 +0000109972008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
10998
10999 Reviewed by Oliver.
11000
zimmermann@webkit.org504f2552008-08-12 10:35:09 +000011001 Add new dynamice-update layout tests covering SVGMarkerElement.
11002 Fix bug: SVGMarkerElement's SVG DOM function calls don't update rendering.
11003 Fix orientAngle/orientType confusion: "auto" orient should always return "0" as angle.
11004
11005 Tests: svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
11006 svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr.html
11007 svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr.html
11008 svg/dynamic-updates/SVGMarkerElement-dom-orient-attr.html
11009 svg/dynamic-updates/SVGMarkerElement-dom-refX-attr.html
11010 svg/dynamic-updates/SVGMarkerElement-dom-refY-attr.html
11011 svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop.html
11012 svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop.html
11013 svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop.html
11014 svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop.html
11015 svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop.html
11016 svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop.html
11017 svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop.html
11018 svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call.html
11019 svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call.html
11020
11021 * svg/SVGMarkerElement.cpp:
11022 (WebCore::SVGMarkerElement::SVGMarkerElement):
11023 (WebCore::SVGMarkerElement::parseMappedAttribute):
11024 (WebCore::SVGMarkerElement::svgAttributeChanged):
11025 (WebCore::SVGMarkerElement::childrenChanged):
11026 (WebCore::SVGMarkerElement::setOrientToAuto):
11027 (WebCore::SVGMarkerElement::setOrientToAngle):
11028 (WebCore::SVGMarkerElement::canvasResource):
11029
110302008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
11031
11032 Reviewed by Oliver.
11033
zimmermann@webkit.orge1388112008-08-12 10:27:53 +000011034 Add new dynamic-update layout tests covering SVGImageElement.
11035 Fix bug: SVGImageElement doesn't react on 'preserveAspectRatio' changes.
11036
11037 Tests: svg/dynamic-updates/SVGImageElement-dom-height-attr.html
11038 svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr.html
11039 svg/dynamic-updates/SVGImageElement-dom-width-attr.html
11040 svg/dynamic-updates/SVGImageElement-dom-x-attr.html
11041 svg/dynamic-updates/SVGImageElement-dom-y-attr.html
11042 svg/dynamic-updates/SVGImageElement-svgdom-height-prop.html
11043 svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html
11044 svg/dynamic-updates/SVGImageElement-svgdom-width-prop.html
11045 svg/dynamic-updates/SVGImageElement-svgdom-x-prop.html
11046 svg/dynamic-updates/SVGImageElement-svgdom-y-prop.html
11047
11048 * svg/SVGImageElement.cpp:
11049 (WebCore::SVGImageElement::svgAttributeChanged):
11050
timothy@apple.com93114722008-08-12 04:20:25 +0000110512008-08-11 Anthony Ricaud <rik24d@gmail.com>
11052
timothy@apple.com2f2cde32008-08-12 04:28:16 +000011053 Changed Option/Alt-Up or Down in CSS editing when the value is
11054 near zero to jump to the next integer.
11055
11056 Reviewed by Tim Hatcher.
11057
11058 https://bugs.webkit.org/show_bug.cgi?id=20326
11059
11060 * page/inspector/StylesSidebarPane.js:
11061
110622008-08-11 Anthony Ricaud <rik24d@gmail.com>
11063
timothy@apple.com93114722008-08-12 04:20:25 +000011064 Changed the line highlight transition for an easier animation.
11065
11066 Reviewed by Tim Hatcher.
11067
11068 * page/inspector/SourceFrame.js:
11069
timothy@apple.com24a14852008-08-12 03:57:39 +0000110702008-08-11 Keishi Hattori <casey.hattori@gmail.com>
11071
11072 Added support for some Firebug Command Line APIs.
11073
11074 Reviewed by Tim Hatcher.
11075
11076 https://bugs.webkit.org/show_bug.cgi?id=19867
11077 https://bugs.webkit.org/show_bug.cgi?id=19868
11078 https://bugs.webkit.org/show_bug.cgi?id=19869
11079 https://bugs.webkit.org/show_bug.cgi?id=19875
11080 https://bugs.webkit.org/show_bug.cgi?id=19876
11081 https://bugs.webkit.org/show_bug.cgi?id=19880
11082
11083 * page/inspector/Console.js:
11084 (WebInspector.Console.prototype._evalInInspectedWindow):
11085 Create an object on the inspected window that holds the console
11086 command line API functions. This object is used in a with statement
11087 around the typed expression.
11088
zimmermann@webkit.org0350b6d2008-08-12 02:22:26 +0000110892008-08-11 Nikolas Zimmermann <zimmermann@kde.org>
11090
11091 Reviewed by Antti.
11092
11093 Fixes: http://bugs.webkit.org/show_bug.cgi?id=17736
11094
11095 JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties
11096 failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect)
11097
11098 Added tests: svg/custom/svg-modify-currentTranslate.html
11099 svg/custom/tearoffs-with-tearoffs.html
11100 svg/custom/immutable-properties.html
11101
11102 Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html
11103
11104 * bindings/js/JSSVGPODTypeWrapper.h:
11105 (WebCore::JSSVGDynamicPODTypeWrapper::commitChange):
11106 (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::create):
11107 (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::commitChange):
11108 (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::JSSVGStaticPODTypeWrapperWithPODTypeParent):
11109 (WebCore::JSSVGStaticPODTypeWrapperWithParent::create):
11110 (WebCore::JSSVGStaticPODTypeWrapperWithParent::operator PODType):
11111 (WebCore::JSSVGStaticPODTypeWrapperWithParent::commitChange):
11112 (WebCore::JSSVGStaticPODTypeWrapperWithParent::JSSVGStaticPODTypeWrapperWithParent):
11113 * bindings/scripts/CodeGenerator.pm:
11114 * bindings/scripts/CodeGeneratorJS.pm:
11115 * svg/SVGSVGElement.idl: Add [Immutable] markers to SVG POD attributes, that contain POD types with writable attributes.
11116 * svg/SVGZoomEvent.idl: SVG specification explicitely demands these attributes to be readonly, even its content.
11117
beidson@apple.com0e772f72008-08-12 00:34:46 +0000111182008-08-11 Brady Eidson <beidson@apple.com>
11119
11120 Reviewed by John and Anders
11121
11122 Fix for <rdar://problem/6141797>
11123
11124 When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource
11125 would never have nil data.
11126
11127 When they were pushed down into WebCore, that guarantee was lost, subtly changing a few
11128 semantics with some WebKit applications.
11129
11130 The guarantee was a good one and should be restored.
11131
11132 Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already
11133 creates an empty data object in the case of null data for its own purposes.
11134
11135 * loader/SubstituteResource.h:
11136 (WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null. This
11137 well help any future subclassers not make this mistake.
11138
11139 * loader/archive/ArchiveResource.cpp:
11140 (WebCore::ArchiveResource::create): Return 0 if the data is null.
11141
simon.fraser@apple.come0d44792008-08-11 22:44:06 +0000111422008-08-11 Simon Fraser <simon.fraser@apple.com>
11143
11144 Reviewed by Dave Hyatt
11145
11146 https://bugs.webkit.org/show_bug.cgi?id=20328
11147 Fix a problem when an 'all' transition transition with more than
11148 one property changing is interrupted, and did some AnimationController
11149 cleanup.
11150
11151 Test: transitions/interrupted-all-transition.html
11152
11153 * page/AnimationController.cpp:
11154 (WebCore::ImplicitAnimation::ImplicitAnimation):
11155 (WebCore::AnimationControllerPrivate::blendProperties):
11156 (WebCore::CompositeAnimation::updateTransitions):
11157 (WebCore::CompositeAnimation::cleanupFinishedAnimations):
11158 (WebCore::CompositeAnimation::setTransitionStartTime):
11159 (WebCore::CompositeAnimation::overrideImplicitAnimations):
11160 (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
11161 (WebCore::ImplicitAnimation::animate):
11162 (WebCore::ImplicitAnimation::onAnimationEnd):
11163 (WebCore::ImplicitAnimation::sendTransitionEvent):
11164 (WebCore::ImplicitAnimation::affectsProperty):
11165 (WebCore::KeyframeAnimation::endAnimation):
11166 (WebCore::KeyframeAnimation::onAnimationEnd):
11167
kmccullough@apple.com4a967c12008-08-11 20:45:19 +0000111682008-08-11 Kevin McCullough <kmccullough@apple.com>
11169
11170 Reviewed by Tim.
11171
11172 - Because console messages have group levels now, newly created messages
11173 that do not specify the level lose their message since the number of
11174 arguments is wrong.
11175
11176 * page/inspector/Console.js:
11177 * page/inspector/Resource.js:
11178
alp@webkit.orgeeb55142008-08-11 19:52:14 +0000111792008-08-11 Alp Toker <alp@nuanti.com>
11180
11181 Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take
11182 the opportunity to sort the sources lists.
11183
11184 * GNUmakefile.am:
11185
timothy@apple.com9fe09f82008-08-11 18:48:37 +0000111862008-08-11 Timothy Hatcher <timothy@apple.com>
11187
11188 Speed up the the JavaScript syntax highlighter by generating
11189 the finders only once per script instead of per line.
11190
11191 https://bugs.webkit.org/show_bug.cgi?id=20346
11192
11193 Reviewed by Adam Roben.
11194
11195 * page/inspector/SourceFrame.js:
11196 (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
11197 Removed, factored into syntaxHighlightJavascript as an inline function.
11198 (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript):
11199 Pulled in the _syntaxHighlightJavascriptLine so it will create a closure.
11200 Generate the finders before iterating the lines.
11201
aroben@apple.com957d2d32008-08-11 18:31:37 +0000112022008-08-11 Adam Roben <aroben@apple.com>
11203
11204 Windows build fix
11205
11206 * WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and
11207 JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file,
11208 too.
11209
mitz@apple.com3f0060f2008-08-11 18:04:46 +0000112102008-08-11 Dan Bernstein <mitz@apple.com>
11211
11212 Reviewed by Darin Adler.
11213
11214 - fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
11215
11216 Test: fast/css/counters/invalidate-cached-counter-node.html
11217
11218 * rendering/RenderContainer.cpp:
11219 (WebCore::RenderContainer::invalidateCounters): Added. Invalidates all
11220 RenderCounters in :before and :after content.
11221 * rendering/RenderContainer.h:
11222 * rendering/RenderCounter.cpp:
11223 (WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this
11224 to match the RenderObject method.
11225 (WebCore::RenderCounter::invalidate): Added. Resets the cached
11226 CounterNode and invalidates the object's layout and preferred widths.
11227 (WebCore::destroyCounterNodeChildren): Added a call to
11228 invalidateCounters().
11229 * rendering/RenderCounter.h:
11230 * rendering/RenderObject.h:
11231 (WebCore::RenderObject::invalidateCounters):
11232
dino@apple.com2af8c3a2008-08-11 17:24:36 +0000112332008-08-11 Dean Jackson <dino@apple.com>
11234
11235 Implement CSS Animation and Transition Events
11236 https://bugs.webkit.org/show_bug.cgi?id=20337
11237
11238 Implement the events defined in the CSS Animations
11239 and Transitions specifications so code can react
11240 to animations and transitions.
11241
11242 Reviewed by Tim Hatcher and Dave Hyatt.
11243
11244 * DerivedSources.make:
11245 * GNUmakefile.am:
11246 * WebCore.pro:
11247 * WebCore.vcproj/WebCore.vcproj:
11248 * WebCore.xcodeproj/project.pbxproj:
11249 * WebCoreSources.bkl:
11250 Build configs for new files
11251
11252 * bindings/js/JSDOMWindowBase.cpp:
11253 * bindings/js/JSDOMWindowBase.h:
11254 * bindings/js/JSEventCustom.cpp:
11255 * dom/Document.h:
11256 * dom/Event.cpp:
11257 * dom/Event.h:
11258 * dom/EventTarget.cpp:
11259 * dom/EventTargetNode.cpp:
11260 * dom/EventTargetNode.h:
11261 * html/HTMLElement.cpp:
11262 * page/AnimationController.cpp:
11263 do all the new event stuff
11264
11265 * html/HTMLAttributeNames.in:
11266 the onwebkitanimation* and onwebkittransitionend attrs
11267
11268 * dom/WebKitAnimationEvent.cpp: Added.
11269 * dom/WebKitAnimationEvent.h: Added.
11270 * dom/WebKitAnimationEvent.idl: Added.
11271 * dom/WebKitTransitionEvent.cpp: Added.
11272 * dom/WebKitTransitionEvent.h: Added.
11273 * dom/WebKitTransitionEvent.idl: Added.
11274 New files for the events
11275
11276 * manual-tests/transition-events.html: Added.
11277 New testfile
11278
aroben@apple.com3eae8622008-08-11 17:21:23 +0000112792008-08-11 Adam Roben <aroben@apple.com>
11280
11281 Add a ForwardingHeader for wtf/NotFound.h
11282
11283 Rubberstamped by Darin Adler.
11284
11285 * ForwardingHeaders/wtf/NotFound.h: Added.
11286
timothy@apple.com2f5bdf02008-08-11 16:53:30 +0000112872008-08-11 Timothy Hatcher <timothy@apple.com>
11288
11289 Fixes a bug where error bubbles in JavaScript resources would
11290 be clobbered by the syntax highlighter.
11291
11292 https://bugs.webkit.org/show_bug.cgi?id=20345
11293
11294 Reviewed by Adam Roben.
11295
11296 * manual-tests/inspector/resources/script-error.js: Added.
11297 * manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added.
11298 * page/inspector/SourceFrame.js:
11299 (WebInspector.SourceFrame.prototype._addMessageToSource):
11300 Check the nodeType and not the nodeName, this is less fragile.
11301 (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
11302 Check if the lastChild is an error bubble, if so remove it before
11303 getting the line's textContent. Add the error bubble back at the end.
11304
mrowe@apple.com4ec50d02008-08-11 05:07:42 +000011305== Rolled over to ChangeLog-2008-08-10 ==