mrowe@apple.com | f88a463 | 2008-09-07 05:44:58 +0000 | [diff] [blame^] | 1 | === End merge of squirrelfish-extreme === |
| 2 | |
| 3 | 2008-09-05 Oliver Hunt <oliver@apple.com> |
| 4 | |
| 5 | Start bringing up SFX on windows. |
| 6 | |
| 7 | Reviewed by Mark Rowe and Sam Weinig |
| 8 | |
| 9 | Start doing the work to bring up SFX on windows. Initially |
| 10 | just working on WREC, as it does not make any calls so reduces |
| 11 | the amount of code that needs to be corrected. |
| 12 | |
| 13 | Add forwarding headers |
| 14 | |
| 15 | * ChangeLog: |
| 16 | * ForwardingHeaders/masm/MacroAssembler.h: Added. |
| 17 | * WebCore.vcproj/WebCore.vcproj: |
| 18 | |
| 19 | 2008-08-27 Mark Rowe <mrowe@apple.com> |
| 20 | |
| 21 | Reviewed by Oliver Hunt. |
| 22 | |
| 23 | Fix the build of the full WebKit stack. |
| 24 | |
| 25 | Add forwarding headers. |
| 26 | |
| 27 | * ForwardingHeaders/masm/IA32MacroAsm.h: Added. |
| 28 | * ForwardingHeaders/wrec/WREC.h: Added. |
| 29 | |
| 30 | === Start merge of squirrelfish-extreme === |
| 31 | |
antti@apple.com | 13c2493 | 2008-09-07 03:54:21 +0000 | [diff] [blame] | 32 | 2008-09-06 Antti Koivisto <antti@apple.com> |
| 33 | |
| 34 | Reviewed by Dave Hyatt. |
| 35 | |
| 36 | <rdar://problem/6187043> |
| 37 | Don't parse full HTML user agent style sheet unless it is actually needed |
| 38 | <rdar://problem/6131889> |
| 39 | WebView is significantly more expensive to create recently |
| 40 | |
| 41 | Parsing the html4.css takes significant amount of time and memory (~50kb) on application |
| 42 | startup. Some clients may never use most of the rules. |
| 43 | |
| 44 | With this patch we use simplified UA stylesheet until we hit something it can't handle. |
| 45 | This avoids full stylesheet parsing on application startup (due to empty document construction) |
| 46 | and also makes it possible for clients with very simple demands (divs and spans only) never to load |
| 47 | the full style. |
| 48 | |
| 49 | It also delays view source style parsing until it is used. |
| 50 | |
| 51 | * css/CSSStyleSelector.cpp: |
| 52 | (WebCore::elementCanUseSimpleDefaultStyle): |
| 53 | (WebCore::CSSStyleSelector::CSSStyleSelector): |
| 54 | (WebCore::loadFullDefaultStyle): |
| 55 | (WebCore::loadSimpleDefaultStyle): |
| 56 | (WebCore::loadViewSourceStyle): |
| 57 | (WebCore::CSSStyleSelector::matchUARules): |
| 58 | (WebCore::CSSStyleSelector::styleForElement): |
| 59 | |
kevino@webkit.org | d15b50f | 2008-09-07 03:46:50 +0000 | [diff] [blame] | 60 | 2008-09-06 Kevin Ollivier <kevino@theolliviers.com> |
| 61 | |
| 62 | wx build fix. |
| 63 | |
| 64 | * WebCoreSources.bkl: |
| 65 | |
antti@apple.com | e953f86 | 2008-09-06 23:27:09 +0000 | [diff] [blame] | 66 | 2008-09-06 Antti Koivisto <antti@apple.com> |
| 67 | |
antti@apple.com | 00dfa53 | 2008-09-06 23:32:26 +0000 | [diff] [blame] | 68 | Reverting r35953 which was causing problems on Windows which relies on |
| 69 | WebCore timers in nested event loops. r36132 did alternative fix. |
| 70 | |
| 71 | * page/Chrome.cpp: |
| 72 | (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): |
| 73 | (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): |
| 74 | |
| 75 | 2008-09-06 Antti Koivisto <antti@apple.com> |
| 76 | |
antti@apple.com | e953f86 | 2008-09-06 23:27:09 +0000 | [diff] [blame] | 77 | Reviewed by Dan Bernstein. |
| 78 | |
| 79 | Fix <rdar://problem/6201644> |
| 80 | https://bugs.webkit.org/show_bug.cgi?id=20493 |
| 81 | Crash after OK in dialog box and reloading page in secure mode |
| 82 | |
| 83 | Limited loader only fix since the general timer fix is causing problems on Windows. |
| 84 | |
| 85 | * loader/loader.cpp: |
| 86 | (WebCore::Loader::servePendingRequests): |
| 87 | (WebCore::Loader::Host::Host): |
| 88 | (WebCore::Loader::Host::didFinishLoading): |
| 89 | (WebCore::Loader::Host::didFail): |
| 90 | (WebCore::Loader::Host::didReceiveData): |
| 91 | * loader/loader.h: |
| 92 | (WebCore::Loader::Host::processingResource): |
| 93 | |
mitz@apple.com | 046bf64 | 2008-09-06 08:31:02 +0000 | [diff] [blame] | 94 | 2008-09-06 Dan Bernstein <mitz@apple.com> |
| 95 | |
| 96 | Reviewed by Dave Hyatt. |
| 97 | |
mitz@apple.com | c0b050b | 2008-09-06 22:39:34 +0000 | [diff] [blame] | 98 | The initial Core Text adoption prototype was made by Daniel Fenwick. |
| 99 | |
| 100 | - <rdar://problem/5158514> Add a Core Text-based complex text code path |
| 101 | |
| 102 | Currently the Core Text code path is not used in any configuration. |
| 103 | |
| 104 | * WebCore.xcodeproj/project.pbxproj: Added files. |
| 105 | * config.h: Defined WTF_USE_ATSUI and WTF_USE_CORE_TEXT. |
| 106 | * platform/graphics/Font.cpp: |
| 107 | (WebCore::WidthIterator::advance): Moved the spacingDisabled() test out |
| 108 | of the loop. |
| 109 | * platform/graphics/GlyphBuffer.h: |
| 110 | (WebCore::GlyphBuffer::add): Added this version that takes an advance. |
| 111 | * platform/graphics/SimpleFontData.h: Added ATSUI and CORE_TEXT #ifdefs. |
| 112 | Added getCTFont() and getCFStringAttributes() and corresponding data |
| 113 | members for Core Text. |
| 114 | * platform/graphics/mac/CoreTextController.cpp: Added. |
| 115 | (WebCore::roundCGFloat): Helper function. |
| 116 | (WebCore::ceilCGFloat): Helper function. |
| 117 | (WebCore::CoreTextController::CoreTextRun::CoreTextRun): |
| 118 | (WebCore::CoreTextController::CoreTextController): |
| 119 | (WebCore::CoreTextController::offsetForPosition): |
| 120 | (WebCore::CoreTextController::collectCoreTextRuns): Added. Segments the |
| 121 | run into subruns as necessary such that each subrun can be rendered with |
| 122 | a single font. Also separates out soft hyphens and replaces them with |
| 123 | real hyphens, because Core Text does not emit a glyph for soft hyphens. |
| 124 | Then calls collectCoreTextRunsForCharacters() on each subrun. |
| 125 | (WebCore::CoreTextController::advance): |
| 126 | (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Creates |
| 127 | a CTLine from the given subrun and collects its CoreTextRuns. |
| 128 | (WebCore::CoreTextController::adjustGlyphsAndAdvances): Applies the |
| 129 | rounding hacks, letter- and word-spacing and glyph substitutions and |
| 130 | stores the resulting adjusted glyphs and advances. |
| 131 | * platform/graphics/mac/CoreTextController.h: Copied from WebCore/platform/graphics/win/UniscribeController.h. |
| 132 | (WebCore::CoreTextController::totalWidth): |
| 133 | (WebCore::CoreTextController::finalRoundingWidth): |
| 134 | (WebCore::CoreTextController::CoreTextRun::ctRun): |
| 135 | (WebCore::CoreTextController::CoreTextRun::glyphCount): |
| 136 | (WebCore::CoreTextController::CoreTextRun::fontData): |
| 137 | (WebCore::CoreTextController::CoreTextRun::characters): |
| 138 | (WebCore::CoreTextController::CoreTextRun::stringLocation): |
| 139 | (WebCore::CoreTextController::CoreTextRun::stringLength): |
| 140 | (WebCore::CoreTextController::CoreTextRun::indexAt): |
| 141 | * platform/graphics/mac/FontMac.mm: Moved the ATSUI-specific parts to |
| 142 | FontMacATSUI.mm. |
| 143 | * platform/graphics/mac/FontMacATSUI.mm: Copied from WebCore/platform/graphics/mac/FontMac.mm. |
| 144 | (WebCore::disableLigatures): Changed to call |
| 145 | FontPlatformData::allowsLigatures(). |
| 146 | (WebCore::overrideLayoutOperation): Changed to call |
| 147 | FontPlatformData::roundsGlyphAdvances(). |
| 148 | * platform/graphics/mac/FontMacCoreText.cpp: Copied from WebCore/platform/graphics/win/FontWin.cpp. |
| 149 | (WebCore::Font::selectionRectForComplexText): Changed to use |
| 150 | totalWidth() instead of advancing to the end and using runWidthSoFar(). |
| 151 | (WebCore::Font::drawComplexText): |
| 152 | (WebCore::Font::floatWidthForComplexText): Ditto. |
| 153 | (WebCore::Font::offsetForPositionForComplexText): |
| 154 | * platform/graphics/mac/FontPlatformData.h: |
| 155 | * platform/graphics/mac/FontPlatformDataMac.mm: |
| 156 | (WebCore::FontPlatformData::setFont): |
| 157 | (WebCore::FontPlatformData::roundsGlyphAdvances): Added. Checks the |
| 158 | AppKit rendering mode. |
| 159 | (WebCore::FontPlatformData::allowsLigatures): Added. Implements the |
| 160 | heuristic that allows ligatures in fonts that do not have a glyph for |
| 161 | 'a', based on the assumption that such fonts are only used in complex |
| 162 | text. |
| 163 | * platform/graphics/mac/SimpleFontDataMac.mm: |
| 164 | (WebCore::SimpleFontData::platformInit): |
| 165 | (WebCore::SimpleFontData::platformDestroy): |
| 166 | (WebCore::SimpleFontData::getCTFont): Added. |
| 167 | (WebCore::SimpleFontData::getCFStringAttributes): Added. Caches and |
| 168 | returns an attributes dictionary. |
| 169 | * platform/text/mac/ShapeArabic.c: Added ATSUI #ifdefs. |
| 170 | * platform/text/mac/ShapeArabic.h: Ditto. |
| 171 | |
| 172 | 2008-09-06 Dan Bernstein <mitz@apple.com> |
| 173 | |
| 174 | Reviewed by Dave Hyatt. |
| 175 | |
mitz@apple.com | 046bf64 | 2008-09-06 08:31:02 +0000 | [diff] [blame] | 176 | - make combining mark offsets work in CG text on Windows |
| 177 | |
| 178 | * platform/graphics/win/FontCGWin.cpp: |
| 179 | (WebCore::Font::drawGlyphs): The old code tried to translate the text |
| 180 | matrix, but failed for two reasons: it did not actually change the |
| 181 | matrix, and even if it did, CGContextSetTextPosition overwrites the |
| 182 | translation values in the text matrix. Instead, just added the |
| 183 | translation to the anchor point. |
| 184 | |
alp@webkit.org | 369cdca | 2008-09-06 04:08:30 +0000 | [diff] [blame] | 185 | 2008-09-05 Gustavo Noronha Silva <gns@gnome.org> |
| 186 | |
| 187 | Reviewed by Alp Toker. |
| 188 | |
| 189 | https://bugs.webkit.org/show_bug.cgi?id=18346 |
| 190 | [GTK] Remove build warnings |
| 191 | |
| 192 | Applied some casts, and removed an unused typedef to make the |
| 193 | compiler happy, printing less warnings when building. |
| 194 | |
| 195 | * page/gtk/AccessibilityObjectWrapperAtk.cpp: |
| 196 | * platform/graphics/gtk/SimpleFontDataPango.cpp: |
| 197 | (WebCore::SimpleFontData::containsCharacters): |
| 198 | * platform/graphics/gtk/VideoSinkGStreamer.cpp: |
| 199 | (webkit_video_sink_set_caps): |
| 200 | * platform/network/soup/ResourceHandleSoup.cpp: |
| 201 | |
eric@webkit.org | 3cb292c | 2008-09-05 22:17:56 +0000 | [diff] [blame] | 202 | 2008-09-05 Eric Seidel <eric@webkit.org> |
| 203 | |
eric@webkit.org | 5ac3790 | 2008-09-06 00:21:58 +0000 | [diff] [blame] | 204 | Reviewed by Adam Roben. |
| 205 | |
| 206 | Build fix for WebKitWin and Chromium |
| 207 | |
| 208 | * platform/FileSystem.h: |
| 209 | |
| 210 | 2008-09-05 Eric Seidel <eric@webkit.org> |
| 211 | |
eric@webkit.org | 3cb292c | 2008-09-05 22:17:56 +0000 | [diff] [blame] | 212 | Reviewed by Darin Adler. |
| 213 | |
| 214 | Try to make Chromium compile with ToT: |
| 215 | - Wrap a few places which depend on KJS:: in #if USE(JSC) |
| 216 | - Include some windows forward declarations |
| 217 | |
| 218 | * dom/Node.h: |
| 219 | * page/Console.h: |
| 220 | * page/animation/CompositeAnimation.h: |
| 221 | * platform/FileSystem.h: |
| 222 | * platform/graphics/Image.h: |
| 223 | * platform/text/AtomicString.h: |
| 224 | * platform/text/String.cpp: |
| 225 | * rendering/style/RenderStyle.h: |
| 226 | |
hyatt@apple.com | ff85d5e | 2008-09-05 21:52:08 +0000 | [diff] [blame] | 227 | 2008-09-05 Dave Hyatt <hyatt@apple.com> |
| 228 | |
| 229 | Add support for runtime switchability of the Aqua look and the native look on Windows. |
| 230 | Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set. |
| 231 | |
| 232 | Reviewed by Adam Roben |
| 233 | |
| 234 | * WebCore.vcproj/WebCore.vcproj: |
| 235 | * page/Settings.cpp: |
| 236 | (WebCore::Settings::setShouldPaintNativeControls): |
| 237 | * page/Settings.h: |
| 238 | (WebCore::Settings::shouldPaintNativeControls): |
| 239 | * rendering/RenderThemeSafari.cpp: |
| 240 | (WebCore::theme): |
| 241 | * rendering/RenderThemeWin.cpp: |
| 242 | |
antti@apple.com | bced97f | 2008-09-05 18:52:05 +0000 | [diff] [blame] | 243 | 2008-09-05 Antti Koivisto <antti@apple.com> |
| 244 | |
| 245 | Qt build fix. |
| 246 | |
| 247 | * svg/SVGFEImageElement.cpp: |
| 248 | (WebCore::SVGFEImageElement::build): |
| 249 | |
aroben@apple.com | ca0c336 | 2008-09-05 15:33:28 +0000 | [diff] [blame] | 250 | 2008-09-05 Dirk Schulze <vbs85@gmx.de> |
| 251 | |
| 252 | Gtk build fix |
| 253 | |
| 254 | * GNUmakefile.am: |
| 255 | |
antti@apple.com | 72e4a84 | 2008-09-05 09:28:11 +0000 | [diff] [blame] | 256 | 2008-09-05 Antti Koivisto <antti@apple.com> |
| 257 | |
antti@apple.com | 49e4666 | 2008-09-05 10:36:59 +0000 | [diff] [blame] | 258 | Another build fix. |
| 259 | |
| 260 | * svg/SVGFEImageElement.cpp: |
| 261 | (WebCore::SVGFEImageElement::notifyFinished): |
| 262 | |
| 263 | 2008-09-05 Antti Koivisto <antti@apple.com> |
| 264 | |
antti@apple.com | feec258 | 2008-09-05 10:03:39 +0000 | [diff] [blame] | 265 | Build fixes. |
| 266 | |
| 267 | * WebCore.xcodeproj/project.pbxproj: |
| 268 | * svg/graphics/filters/SVGFEImage.cpp: |
| 269 | (WebCore::FEImage::cachedImage): |
| 270 | |
| 271 | 2008-09-05 Antti Koivisto <antti@apple.com> |
| 272 | |
darin@apple.com | 07c80c6 | 2008-09-05 18:15:43 +0000 | [diff] [blame] | 273 | Reviewed by Darin Adler. |
antti@apple.com | 72e4a84 | 2008-09-05 09:28:11 +0000 | [diff] [blame] | 274 | |
| 275 | Most of the implementation for https://bugs.webkit.org/show_bug.cgi?id=17998 |
| 276 | When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation" |
| 277 | |
| 278 | Implement HTTP 1.1 "Specific end-to-end revalidation" for WebCore memory cache. This patch does |
| 279 | not yet enable it for the biggest use case, reloading. However it is good for general browsing as |
| 280 | well. Doing this in WebCore level as opposed to relying on disk cache has big benefit that |
| 281 | we avoid re-decoding resources, especially images. |
| 282 | |
| 283 | To be exact the enabled case is not actually the "Specific end-to-end revalidation" since it does not include |
| 284 | CacheControl: max-age=0 header. That would be added in reload case. |
| 285 | |
| 286 | The approach for revalidation is to kick the original resource out from the memory cache |
| 287 | and create a new CachedResource that represents the revalidation request. In case |
| 288 | we get 304 back for the request we put the original resource back to the cache, update |
| 289 | its expiration date and switch the clients registered to revalidation resource to be |
| 290 | clients of the original resource. |
| 291 | |
| 292 | All heap allocated CachedImage pointers now use CachedResourceHandle<CachedImage> (and so on) instead. |
| 293 | This allows updating the handles to point to the original resource when the revalidation succeeds. It |
| 294 | also acts as refcounting smart pointer. |
| 295 | |
| 296 | * WebCore.pro: |
| 297 | * WebCore.vcproj/WebCore.vcproj: |
| 298 | * WebCore.xcodeproj/project.pbxproj: |
| 299 | * css/CSSFontFaceSource.h: |
| 300 | * css/CSSImportRule.h: |
| 301 | * dom/Clipboard.h: |
| 302 | (WebCore::Clipboard::dragImage): |
| 303 | * dom/ProcessingInstruction.h: |
| 304 | * dom/ScriptElement.h: |
| 305 | * dom/XMLTokenizer.cpp: |
| 306 | (WebCore::XMLTokenizer::isWaitingForScripts): |
| 307 | * dom/XMLTokenizer.h: |
| 308 | * html/HTMLImageLoader.cpp: |
| 309 | (WebCore::HTMLImageLoader::setImage): |
| 310 | (WebCore::HTMLImageLoader::updateFromElement): |
| 311 | (WebCore::HTMLImageLoader::notifyFinished): |
| 312 | * html/HTMLImageLoader.h: |
| 313 | (WebCore::HTMLImageLoader::image): |
| 314 | * html/HTMLLinkElement.h: |
| 315 | * html/HTMLTokenizer.cpp: |
| 316 | (WebCore::HTMLTokenizer::reset): |
| 317 | (WebCore::HTMLTokenizer::scriptHandler): |
| 318 | (WebCore::HTMLTokenizer::notifyFinished): |
| 319 | * html/HTMLTokenizer.h: |
| 320 | * loader/Cache.cpp: |
| 321 | (WebCore::Cache::revalidateResource): |
| 322 | (WebCore::Cache::revalidationSucceeded): |
| 323 | (WebCore::Cache::revalidationFailed): |
| 324 | * loader/Cache.h: |
| 325 | * loader/CachedResource.cpp: |
| 326 | (WebCore::CachedResource::CachedResource): |
| 327 | (WebCore::CachedResource::~CachedResource): |
| 328 | (WebCore::CachedResource::isExpired): |
| 329 | (WebCore::CachedResource::setResponse): |
| 330 | (WebCore::CachedResource::deleteIfPossible): |
| 331 | (WebCore::CachedResource::setResourceToRevalidate): |
| 332 | (WebCore::CachedResource::clearResourceToRevalidate): |
| 333 | (WebCore::CachedResource::switchClientsToRevalidatedResource): |
| 334 | (WebCore::CachedResource::canUseCacheValidator): |
| 335 | (WebCore::CachedResource::mustRevalidate): |
| 336 | * loader/CachedResource.h: |
| 337 | (WebCore::CachedResource::canDelete): |
| 338 | (WebCore::CachedResource::registerHandle): |
| 339 | (WebCore::CachedResource::unregisterHandle): |
| 340 | (WebCore::CachedResource::isCacheValidator): |
| 341 | (WebCore::CachedResource::resourceToRevalidate): |
| 342 | (WebCore::CachedResource::setExpirationDate): |
| 343 | * loader/CachedResourceHandle.cpp: Added. |
| 344 | (WebCore::CachedResourceHandleBase::setResource): |
| 345 | * loader/CachedResourceHandle.h: Added. |
| 346 | (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase): |
| 347 | (WebCore::CachedResourceHandleBase::get): |
| 348 | (WebCore::CachedResourceHandleBase::operator!): |
| 349 | (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType): |
| 350 | (WebCore::CachedResourceHandleBase::CachedResourceHandleBase): |
| 351 | (WebCore::CachedResourceHandleBase::operator=): |
| 352 | (WebCore::CachedResourceHandle::CachedResourceHandle): |
| 353 | (WebCore::CachedResourceHandle::get): |
| 354 | (WebCore::CachedResourceHandle::operator->): |
| 355 | (WebCore::CachedResourceHandle::operator=): |
| 356 | (WebCore::CachedResourceHandle::operator==): |
| 357 | (WebCore::CachedResourceHandle::operator!=): |
| 358 | (WebCore::operator==): |
| 359 | (WebCore::operator!=): |
| 360 | * loader/DocLoader.cpp: |
| 361 | (WebCore::DocLoader::checkForReload): |
| 362 | * loader/UserStyleSheetLoader.h: |
| 363 | * loader/loader.cpp: |
| 364 | (WebCore::Loader::Host::servePendingRequests): |
| 365 | (WebCore::Loader::Host::didFinishLoading): |
| 366 | (WebCore::Loader::Host::didFail): |
| 367 | (WebCore::Loader::Host::didReceiveResponse): |
| 368 | (WebCore::Loader::Host::didReceiveData): |
| 369 | * page/EventHandler.cpp: |
| 370 | (WebCore::EventHandler::selectCursor): |
| 371 | * rendering/RenderImage.cpp: |
| 372 | (WebCore::RenderImage::setCachedImage): |
| 373 | (WebCore::RenderImage::imageChanged): |
| 374 | * rendering/RenderImage.h: |
| 375 | (WebCore::RenderImage::cachedImage): |
| 376 | (WebCore::RenderImage::imagePtr): |
| 377 | * rendering/style/RenderStyle.h: |
| 378 | * rendering/style/StyleCachedImage.h: |
| 379 | (WebCore::StyleCachedImage::data): |
| 380 | (WebCore::StyleCachedImage::cachedImage): |
| 381 | * svg/SVGFEImageElement.h: |
| 382 | * svg/graphics/filters/SVGFEImage.h: |
| 383 | * xml/XSLImportRule.h: |
| 384 | |
beidson@apple.com | ab60d98 | 2008-09-05 04:58:12 +0000 | [diff] [blame] | 385 | 2008-09-04 Brady Eidson <beidson@apple.com> |
| 386 | |
| 387 | Reviewed by Mitz |
| 388 | |
| 389 | <rdar://problem/6180236> - Safari times out connections after 1 or 2 minutes |
| 390 | |
| 391 | A 60-second default timeout was added in http://trac.webkit.org/changeset/17144 in an attempt |
| 392 | to model default NSURLRequest behavior in a cross-platform manner. |
| 393 | |
| 394 | Sadly by always enforcing this 60 second timeout, WebCore was stomping over the wishes of any Webkit |
| 395 | client that wished to enforce a much larger default timeout using NSURLRequest API. |
| 396 | |
| 397 | Additionally, upon reviewing what all other browsers do, it seems apparent that "no limit" is desirable |
| 398 | behavior on the web and this restores previous Safari/WebKit behavior. |
| 399 | |
| 400 | It would be easy to write a layout test for this, but to be effective it would have |
| 401 | to run for at least 61 seconds, which seems insane until will can parallelize run-webkit-tests |
| 402 | |
| 403 | * manual-tests/timeout-test.html: Added. |
| 404 | * manual-tests/timeout-test.php: Added. |
| 405 | |
| 406 | * platform/network/ResourceRequestBase.h: |
| 407 | (WebCore::ResourceRequestBase::ResourceRequestBase): Rename the constant to "unspecifiedTimeoutInterval" |
| 408 | and make it UINT_MAX so platforms that do set it have an effective "no timeout." (Windows, for example) |
| 409 | * platform/network/mac/ResourceRequestMac.mm: |
| 410 | (WebCore::ResourceRequest::doUpdatePlatformRequest): If the timeout for this request is |
| 411 | "unspecifiedTimeoutInterval", then don't bother setting the timeout using NSURLRequest API, allowing |
| 412 | WebKit applications to enforce their own default timeout. |
| 413 | |
mitz@apple.com | 2026854 | 2008-09-05 04:26:32 +0000 | [diff] [blame] | 414 | 2008-09-04 Dan Bernstein <mitz@apple.com> |
| 415 | |
| 416 | Reviewed by Beth Dakin. |
| 417 | |
| 418 | - fix <rdar://problem/6198514> Changing a button's opacity triggers relayout |
| 419 | |
| 420 | Test: fast/repaint/button-spurious-layout-hint.html |
| 421 | |
| 422 | * rendering/RenderButton.cpp: |
| 423 | (WebCore::RenderButton::setStyle): Reset the inner block's style box |
| 424 | flex to 0 to avoid getting a spurious layout hint. |
| 425 | |
kevino@webkit.org | 3e8c407 | 2008-09-04 23:53:04 +0000 | [diff] [blame] | 426 | 2008-09-04 Kevin Ollivier <kevino@theolliviers.com> |
| 427 | |
| 428 | wx build fixes. |
| 429 | |
| 430 | * WebCoreSources.bkl: |
| 431 | * bindings/js/ScriptControllerWx.cpp: Added. |
| 432 | (WebCore::ScriptController::createScriptInstanceForWidget): |
| 433 | * page/wx/AccessibilityObjectWx.cpp: Added. |
| 434 | (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): |
| 435 | * platform/graphics/wx/GraphicsContextWx.cpp: |
| 436 | * webcore-base.bkl: |
| 437 | * webcore-wx.bkl: |
| 438 | |
mitz@apple.com | 95a8750 | 2008-09-04 23:27:19 +0000 | [diff] [blame] | 439 | 2008-09-04 Dan Bernstein <mitz@apple.com> |
| 440 | |
| 441 | Reviewed by Mark Rowe. |
| 442 | |
| 443 | - roll out r36050 because it made svg/custom/invalid-fill-hex.svg fail, |
| 444 | and fixing https://bugs.webkit.org/show_bug.cgi?id=15360 appears to |
| 445 | require a different approach |
| 446 | |
| 447 | * css/CSSGrammar.y: |
| 448 | |
mrowe@apple.com | 12b7c2d | 2008-09-04 21:00:02 +0000 | [diff] [blame] | 449 | 2008-09-04 Mark Rowe <mrowe@apple.com> |
| 450 | |
mrowe@apple.com | 5bc4ea8 | 2008-09-04 21:44:28 +0000 | [diff] [blame] | 451 | Reviewed by Eric Seidel. |
| 452 | |
| 453 | Fix https://bugs.webkit.org/show_bug.cgi?id=20639. |
| 454 | Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE |
| 455 | |
| 456 | * Configurations/WebCore.xcconfig: Remove ENABLE_DASHBOARD_SUPPORT from FEATURE_DEFINES. |
| 457 | * DerivedSources.make: Revert to checking for ENABLE_DASHBOARD_SUPPORT rather than looking |
| 458 | for ENABLE_DASHBOARD_SUPPORT in FEATURE_DEFINES. |
| 459 | |
| 460 | 2008-09-04 Mark Rowe <mrowe@apple.com> |
| 461 | |
mrowe@apple.com | 12b7c2d | 2008-09-04 21:00:02 +0000 | [diff] [blame] | 462 | Mac build fix. |
| 463 | |
| 464 | * config.h: Only check the value of HAVE_CONFIG_H if it is defined. |
| 465 | |
eric@webkit.org | 0716a54 | 2008-09-04 20:44:12 +0000 | [diff] [blame] | 466 | 2008-09-04 Eric Seidel <eric@webkit.org> |
| 467 | |
| 468 | Build fix only, no review. |
| 469 | |
| 470 | * dom/XMLTokenizer.cpp: Fix the Chromium merge build by adding a missing header (the Mac files must include it somewhere). |
| 471 | |
jmalonzo@webkit.org | 6afc5d4 | 2008-09-04 20:26:16 +0000 | [diff] [blame] | 472 | 2008-09-04 Marco Barisione <marco.barisione@collabora.co.uk> |
| 473 | |
| 474 | Reviewed by Eric Seidel. |
| 475 | |
| 476 | http://bugs.webkit.org/show_bug.cgi?id=20380 |
| 477 | [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h |
| 478 | |
| 479 | * config.h: Include the configuration header generated by autotools if |
| 480 | available. |
| 481 | |
mitz@apple.com | 9d7e426 | 2008-09-04 18:15:25 +0000 | [diff] [blame] | 482 | 2008-09-04 Dan Bernstein <mitz@apple.com> |
| 483 | |
| 484 | Rubber-stamped by Dave Hyatt. |
| 485 | |
| 486 | - rename CachedResource::allReferencesRemoved() to allClientsRemoved() |
| 487 | |
| 488 | * loader/CachedFont.cpp: |
| 489 | (WebCore::CachedFont::allClientsRemoved): |
| 490 | * loader/CachedFont.h: |
| 491 | * loader/CachedImage.cpp: |
| 492 | (WebCore::CachedImage::allClientsRemoved): |
| 493 | * loader/CachedImage.h: |
| 494 | * loader/CachedResource.cpp: |
| 495 | (WebCore::CachedResource::removeClient): |
| 496 | * loader/CachedResource.h: |
| 497 | (WebCore::CachedResource::allClientsRemoved): |
| 498 | |
aroben@apple.com | 0da404d | 2008-09-04 16:09:33 +0000 | [diff] [blame] | 499 | 2008-09-04 Adam Roben <aroben@apple.com> |
| 500 | |
aroben@apple.com | dd3861a | 2008-09-04 16:09:53 +0000 | [diff] [blame] | 501 | Windows build fix after r36071 |
| 502 | |
| 503 | We were getting these errors: |
| 504 | |
| 505 | error C2356: initialization segment must not change during translation |
| 506 | unit |
| 507 | |
| 508 | This was happening because multiple files #included by |
| 509 | DerivedSources.cpp were themselves #including StaticConstructors.h. I |
| 510 | fixed the error by adding header guards to StaticConstructors.h so its |
| 511 | contents will only be included once. |
| 512 | |
| 513 | But it's also not a good idea for StaticConstructors.h to end up in |
| 514 | DerivedSources.cpp, since it ends up "polluting" all the source files |
| 515 | we have in there. So I removed all the files that include |
| 516 | StaticConstructors.h and added some preprocessor directives to |
| 517 | DerivedSources.cpp to catch this error in the future. |
| 518 | |
| 519 | * DerivedSources.cpp: Removed the *Names.cpp files, which include |
| 520 | StaticConstructors.h, and added some preprocessor directives to make |
| 521 | sure we don't end up accidentally including StaticConstructors.h in |
| 522 | the future. |
| 523 | * WebCore.vcproj/WebCore.vcproj: Added the *Names.cpp files. |
| 524 | * platform/StaticConstructors.h: Added header guards. |
| 525 | |
| 526 | 2008-09-04 Adam Roben <aroben@apple.com> |
| 527 | |
aroben@apple.com | 0da404d | 2008-09-04 16:09:33 +0000 | [diff] [blame] | 528 | Windows build fix |
| 529 | |
| 530 | * platform/graphics/win/FontPlatformData.h: Added a missing #include |
| 531 | of PassRefPtr.h, and corrected the capitalization of RefCounted.h. |
| 532 | * platform/text/PlatformString.h: Added a missing #include of |
| 533 | PassRefPtr.h. |
| 534 | |
vestbo@webkit.org | c0aeddf | 2008-09-04 11:44:17 +0000 | [diff] [blame] | 535 | 2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com> |
| 536 | |
| 537 | Reviewed by Simon. |
| 538 | |
vestbo@webkit.org | b82da91 | 2008-09-04 14:24:58 +0000 | [diff] [blame] | 539 | Fix the QtWebKit build to match changes in r36016 |
| 540 | |
| 541 | * WebCore.pro: |
| 542 | * bridge/qt/qt_instance.cpp: |
| 543 | (KJS::Bindings::QtInstance::getRuntimeObject): |
| 544 | * bridge/qt/qt_runtime.cpp: |
| 545 | (KJS::Bindings::convertQVariantToValue): |
| 546 | (KJS::Bindings::QtConnectionObject::execute): |
| 547 | |
| 548 | 2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com> |
| 549 | |
| 550 | Reviewed by Simon. |
| 551 | |
vestbo@webkit.org | c0aeddf | 2008-09-04 11:44:17 +0000 | [diff] [blame] | 552 | Re-enable support for user stylesheets in QtWebKit |
| 553 | |
| 554 | QtWebKit now follows the FRAME_LOADS_USER_STYLESHEET |
| 555 | code path, which allows us to keep API support for |
| 556 | loading user style sheets from remote URLs. |
| 557 | |
| 558 | As part of the change UserStyleSheetLoader.cpp/h was |
| 559 | moved from WebCore/loader/mac to WebCore/loader. |
| 560 | |
| 561 | * WebCore.pro: |
| 562 | * WebCore.xcodeproj/project.pbxproj: |
| 563 | * dom/Document.h: |
| 564 | * loader/UserStyleSheetLoader.cpp: Renamed from WebCore/loader/mac/UserStyleSheetLoader.cpp. |
| 565 | (UserStyleSheetLoader::UserStyleSheetLoader): |
| 566 | (UserStyleSheetLoader::~UserStyleSheetLoader): |
| 567 | * loader/UserStyleSheetLoader.h: Renamed from WebCore/loader/mac/UserStyleSheetLoader.h. |
| 568 | * page/qt/FrameQt.cpp: |
| 569 | (WebCore::Frame::setUserStyleSheetLocation): |
| 570 | (WebCore::Frame::setUserStyleSheet): |
| 571 | |
alp@webkit.org | 539ff85 | 2008-09-04 09:14:42 +0000 | [diff] [blame] | 572 | 2008-09-04 Alp Toker <alp@nuanti.com> |
| 573 | |
| 574 | Reviewed by Eric. |
| 575 | |
| 576 | Remove left-over QT and CAIRO platform checks. |
| 577 | |
| 578 | * html/CanvasRenderingContext2D.cpp: |
| 579 | |
eric@webkit.org | bc0aab8 | 2008-09-04 08:39:51 +0000 | [diff] [blame] | 580 | 2008-09-04 Eric Seidel <eric@webkit.org> |
| 581 | |
| 582 | Reviewed by Mark Rowe. |
| 583 | |
mitz@apple.com | 9388d25 | 2008-09-04 08:58:58 +0000 | [diff] [blame] | 584 | Fix leak of TextMetrics due to over-ref as see on buildbot. |
eric@webkit.org | bc0aab8 | 2008-09-04 08:39:51 +0000 | [diff] [blame] | 585 | |
| 586 | * html/TextMetrics.h: use adoptRef since RefCounted starts @ refcount 1 instead of 0 now. |
| 587 | |
mitz@apple.com | 89557c5 | 2008-09-04 07:26:53 +0000 | [diff] [blame] | 588 | 2008-09-04 Dan Bernstein <mitz@apple.com> |
| 589 | |
| 590 | Reviewed by Dave Hyatt. |
| 591 | |
| 592 | - fix https://bugs.webkit.org/show_bug.cgi?id=19717 |
| 593 | <rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist |
| 594 | |
| 595 | * rendering/RenderBlock.cpp: |
| 596 | (WebCore::RenderBlock::layoutOnlyPositionedObjects): In the |
| 597 | positioned movement only case, call |
| 598 | tryLayoutDoingPositionedMovementOnly() and fall back on doing a full |
| 599 | layout if that fails. |
| 600 | (WebCore::RenderBlock::layoutPositionedObjects): Ditto. |
| 601 | * rendering/RenderBox.h: |
| 602 | (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): Renamed |
| 603 | layoutDoingPositionedMovementOnly to this, and made this function |
| 604 | check if the width changed. If it did, return, leaving the object |
| 605 | dirty. The caller can then call layout(). The width can change even |
| 606 | in the "positioned movement only" case if the object is shrink-to-fit |
| 607 | and the available width constraint is met. (This was the case in the |
| 608 | bug). |
| 609 | * rendering/RenderObject.h: |
| 610 | (WebCore::RenderObject::tryLayoutDoingPositionedMovementOnly): |
| 611 | Renamed layoutDoingPositionedMovementOnly() to this. |
| 612 | |
eric@webkit.org | 8883b4a | 2008-09-04 06:31:37 +0000 | [diff] [blame] | 613 | 2008-09-03 Eric Seidel <eric@webkit.org> |
| 614 | |
| 615 | No review, build fix only. |
| 616 | |
| 617 | Attempt to fix the Qt build. |
| 618 | |
| 619 | * WebCore.pro: add page/animation to include path |
| 620 | |
mrowe@apple.com | aa4bb8d | 2008-09-04 03:20:30 +0000 | [diff] [blame] | 621 | 2008-09-03 Mark Rowe <mrowe@apple.com> |
| 622 | |
| 623 | Mac build fix. Correctly detect whether dashboard support is enabled. |
| 624 | |
| 625 | * DerivedSources.make: |
| 626 | |
eric@webkit.org | 3eefe67 | 2008-09-04 01:32:26 +0000 | [diff] [blame] | 627 | 2008-09-03 Eric Seidel <eric@webkit.org> |
| 628 | |
| 629 | Reviewed by Sam. |
| 630 | |
eric@webkit.org | 5e06909 | 2008-09-04 01:32:51 +0000 | [diff] [blame] | 631 | Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS) |
| 632 | |
| 633 | * Configurations/WebCore.xcconfig: add missing ENABLE_* |
| 634 | * config.h: add rules for V8_BINDINGS |
| 635 | |
| 636 | 2008-09-03 Eric Seidel <eric@webkit.org> |
| 637 | |
| 638 | Reviewed by Sam. |
| 639 | |
eric@webkit.org | 3eefe67 | 2008-09-04 01:32:26 +0000 | [diff] [blame] | 640 | https://bugs.webkit.org/show_bug.cgi?id=20620 |
| 641 | |
| 642 | Add #if USE(JSC) around KJS dependencies |
| 643 | Remove !USE(JAVASCRIPTCORE_BINDINGS) support for 3 reasons: |
| 644 | 1. Most platforms have it on anyway |
| 645 | 2. V8 is going to want to share some of that code |
| 646 | 3. Those platforms which want it off, should have a separate file instead of an #ifdef in our .cpp |
| 647 | |
| 648 | * bindings/js/JSPluginElementFunctions.cpp: remove !USE(JAVASCRIPTCORE_BINDINGS) support |
| 649 | * config.h: change JAVASCRIPTCORE_BINDINGS to JSC and add USE(V8) |
| 650 | * html/HTMLAppletElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers |
| 651 | * html/HTMLAppletElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers |
| 652 | * html/HTMLEmbedElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers |
| 653 | * html/HTMLEmbedElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers |
| 654 | * html/HTMLObjectElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers |
| 655 | * html/HTMLObjectElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers |
| 656 | * html/HTMLPlugInElement.cpp: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed |
| 657 | * html/HTMLPlugInElement.h: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed |
| 658 | * platform/text/AtomicString.cpp: add USE(JSC) |
| 659 | * platform/text/AtomicString.h: add USE(JSC) |
| 660 | * platform/text/PlatformString.h: add USE(JSC) |
| 661 | * platform/text/String.cpp: add USE(JSC) |
| 662 | * platform/text/StringImpl.cpp: add USE(JSC) |
| 663 | * platform/text/StringImpl.h: add USE(JSC) |
| 664 | |
mrowe@apple.com | fbe724c | 2008-09-03 23:46:54 +0000 | [diff] [blame] | 665 | 2008-09-03 Dean McNamee <deanm@chromium.org> |
| 666 | |
| 667 | Reviewed by Darin Adler. |
| 668 | |
| 669 | Fix https://bugs.webkit.org/show_bug.cgi?id=20511 |
| 670 | Bug 20511: Remove static initializers on Windows |
| 671 | |
| 672 | Avoid static initializers on Windows by forcing Visual C++ to put |
| 673 | all static initializers in a code segment that is never executed. |
| 674 | |
| 675 | * config.h: |
| 676 | * css/MediaFeatureNames.cpp: |
| 677 | * dom/EventNames.cpp: |
| 678 | * dom/QualifiedName.cpp: |
| 679 | * dom/make_names.pl: |
| 680 | * platform/StaticConstructors.h: |
| 681 | * platform/text/AtomicString.cpp: |
| 682 | |
mrowe@apple.com | 3aa6318 | 2008-09-03 23:40:49 +0000 | [diff] [blame] | 683 | 2008-09-03 Dirk Schulze <vbs85@gmx.de> |
| 684 | |
| 685 | Reviewed by Dave Hyatt. |
| 686 | |
| 687 | Make FontCairo draw TextStroke and TextFill separately. |
| 688 | |
| 689 | [CAIRO] draw TextFill and TextStroke separately. |
| 690 | [https://bugs.webkit.org/show_bug.cgi?id=20631] |
| 691 | |
| 692 | * platform/graphics/cairo/FontCairo.cpp: |
| 693 | (WebCore::Font::drawGlyphs): |
| 694 | |
mrowe@apple.com | dcd72b7 | 2008-09-03 23:34:40 +0000 | [diff] [blame] | 695 | 2008-09-03 Peter Kasting <zerodpx@gmail.com> |
| 696 | |
| 697 | Reviewed by Dave Hyatt. |
| 698 | |
| 699 | https://bugs.webkit.org/show_bug.cgi?id=19663 |
| 700 | Account for paint and timer lag when animating images. Also pretend |
| 701 | that images whose animations were paused (by becoming invisible) |
| 702 | continued to animate, by "catching up" to the correct frame when they're |
| 703 | shown again. |
| 704 | |
| 705 | * platform/graphics/BitmapImage.cpp: |
| 706 | (WebCore::BitmapImage::BitmapImage): |
| 707 | (WebCore::BitmapImage::startAnimation): |
| 708 | (WebCore::BitmapImage::advanceAnimation): |
| 709 | (WebCore::BitmapImage::internalAdvanceAnimation): |
| 710 | (WebCore::BitmapImage::notifyObserverAndTrimDecodedData): |
| 711 | * platform/graphics/BitmapImage.h: |
| 712 | * platform/graphics/cairo/ImageCairo.cpp: |
| 713 | (WebCore::BitmapImage::draw): |
| 714 | * platform/graphics/cg/ImageCG.cpp: |
| 715 | (WebCore::BitmapImage::draw): |
| 716 | * platform/graphics/qt/ImageQt.cpp: |
| 717 | (WebCore::BitmapImage::draw): |
| 718 | * platform/graphics/wx/ImageWx.cpp: |
| 719 | (WebCore::BitmapImage::draw): |
| 720 | |
kmccullough@apple.com | b0f4c62 | 2008-09-03 21:53:17 +0000 | [diff] [blame] | 721 | 2008-09-03 Kevin McCullough <kmccullough@apple.com> |
| 722 | |
| 723 | Reviewed by Tim. |
| 724 | |
| 725 | Remove the rest of the "zombie" code from the profiler. |
| 726 | - There is no longer a need for the ProfilerClient callback mechanism. |
| 727 | |
| 728 | * page/Console.cpp: |
| 729 | (WebCore::Console::Console): |
| 730 | (WebCore::Console::profile): |
| 731 | (WebCore::Console::profileEnd): Move the variables from the header to |
| 732 | here since we don't have to wait for a callback to use them. |
| 733 | * page/Console.h: |
| 734 | * page/InspectorController.cpp: |
| 735 | (WebCore::InspectorController::startUserInitiatedProfiling): |
| 736 | (WebCore::InspectorController::stopUserInitiatedProfiling): |
| 737 | * page/InspectorController.h: |
| 738 | |
adachan@apple.com | 38c6618 | 2008-09-03 21:43:44 +0000 | [diff] [blame] | 739 | 2008-09-03 Ada Chan <adachan@apple.com> |
| 740 | |
| 741 | Windows build fix. |
| 742 | |
| 743 | * WebCore.vcproj/WebCore.vcproj: Added JSWebKitCSSKeyframeRule.cpp and JSWebKitCSSKeyframesRule.cpp to the project. |
| 744 | |
dino@apple.com | 5c91762 | 2008-09-03 21:15:53 +0000 | [diff] [blame] | 745 | 2008-09-01 Dean Jackson <dino@apple.com> |
| 746 | |
| 747 | Reviewed by Dave Hyatt. |
| 748 | |
| 749 | https://bugs.webkit.org/show_bug.cgi?id=20594 |
| 750 | Add DOM interfaces for WebKitCSSKeyframeRule |
| 751 | and WebKitCSSKeyframesRule. |
| 752 | |
| 753 | TEST: LayoutTests/css3/keyframes-rule.html |
| 754 | |
| 755 | * css/WebKitCSSKeyframeRule.idl: Added |
| 756 | * css/WebKitCSSKeyframesRule.idl: Added |
| 757 | |
| 758 | * bindings/js/JSCSSRuleCustom.cpp: |
| 759 | (WebCore::toJS): |
| 760 | Add return of new JS Keyframe rules |
| 761 | * bindings/objc/DOMInternal.h: |
| 762 | Include new internal header |
| 763 | |
| 764 | * DerivedSources.make: |
| 765 | * GNUmakefile.am: |
| 766 | * WebCore.pro: |
| 767 | * WebCore.vcproj/WebCore.vcproj: |
| 768 | * WebCore.xcodeproj/project.pbxproj: |
| 769 | * WebCoreSources.bkl: |
| 770 | Build configs for new files |
| 771 | |
aroben@apple.com | 1f51bfa | 2008-09-03 20:30:59 +0000 | [diff] [blame] | 772 | 2008-09-03 Adam Roben <aroben@apple.com> |
| 773 | |
| 774 | Windows build fix |
| 775 | |
| 776 | * DerivedSources.cpp: Add JSTextMetrics.cpp to fix the build. |
| 777 | * WebCore.vcproj/WebCore.vcproj: Add JSTextMetrics.h for |
| 778 | convenience/consistency. |
| 779 | |
adele@apple.com | 2771358 | 2008-09-03 20:13:41 +0000 | [diff] [blame] | 780 | 2008-09-03 Adele Peterson <adele@apple.com> |
| 781 | |
| 782 | Build fix. |
| 783 | |
| 784 | * WebCore.vcproj/WebCore.vcproj: |
| 785 | |
hyatt@apple.com | 4b38ed8 | 2008-09-03 18:32:05 +0000 | [diff] [blame] | 786 | 2008-09-03 David Hyatt <hyatt@apple.com> |
| 787 | |
| 788 | Fix for bug 18203, right floats should be allowed to overflow past the left border edge. |
| 789 | |
| 790 | Reviewed by Darin (ages ago) |
| 791 | |
| 792 | Added fast/block/float/clamped-right-float.html |
| 793 | |
| 794 | * rendering/RenderBlock.cpp: |
| 795 | (WebCore::RenderBlock::positionNewFloats): |
| 796 | |
hyatt@apple.com | afe6205 | 2008-09-03 18:13:39 +0000 | [diff] [blame] | 797 | 2008-09-02 David Hyatt <hyatt@apple.com> |
| 798 | |
| 799 | Add support for canvas text drawing APIs. |
| 800 | |
| 801 | Reviewed by olliej |
| 802 | |
| 803 | Tests added as fast/canvas/canvas-text-*.html |
| 804 | |
| 805 | * DerivedSources.make: |
| 806 | * WebCore.xcodeproj/project.pbxproj: |
| 807 | * bindings/js/JSCanvasRenderingContext2DCustom.cpp: |
| 808 | (WebCore::JSCanvasRenderingContext2D::fillText): |
| 809 | (WebCore::JSCanvasRenderingContext2D::strokeText): |
| 810 | * css/CSSStyleSelector.cpp: |
| 811 | (WebCore::CSSStyleSelector::initForStyleResolve): |
| 812 | (WebCore::CSSStyleSelector::applyPropertyToStyle): |
| 813 | * css/CSSStyleSelector.h: |
| 814 | * html/CanvasRenderingContext2D.cpp: |
| 815 | (WebCore::CanvasRenderingContext2D::State::State): |
| 816 | (WebCore::CanvasRenderingContext2D::font): |
| 817 | (WebCore::CanvasRenderingContext2D::setFont): |
| 818 | (WebCore::CanvasRenderingContext2D::textAlign): |
| 819 | (WebCore::CanvasRenderingContext2D::setTextAlign): |
| 820 | (WebCore::CanvasRenderingContext2D::textBaseline): |
| 821 | (WebCore::CanvasRenderingContext2D::setTextBaseline): |
| 822 | (WebCore::CanvasRenderingContext2D::fillText): |
| 823 | (WebCore::CanvasRenderingContext2D::strokeText): |
| 824 | (WebCore::CanvasRenderingContext2D::measureText): |
| 825 | (WebCore::CanvasRenderingContext2D::drawTextInternal): |
| 826 | (WebCore::CanvasRenderingContext2D::accessFont): |
| 827 | * html/CanvasRenderingContext2D.h: |
| 828 | * html/CanvasRenderingContext2D.idl: |
| 829 | * html/TextMetrics.h: Added. |
| 830 | (WebCore::TextMetrics::create): |
| 831 | (WebCore::TextMetrics::width): |
| 832 | (WebCore::TextMetrics::setWidth): |
| 833 | (WebCore::TextMetrics::TextMetrics): |
| 834 | * html/TextMetrics.idl: Added. |
| 835 | * platform/graphics/Font.cpp: |
| 836 | (WebCore::Font::lineGap): |
| 837 | * platform/graphics/Font.h: |
| 838 | * platform/graphics/GraphicsContext.cpp: |
| 839 | (WebCore::GraphicsContext::drawBidiText): |
| 840 | * platform/graphics/GraphicsContext.h: |
| 841 | * platform/graphics/GraphicsTypes.cpp: |
| 842 | (WebCore::textAlignName): |
| 843 | (WebCore::parseTextAlign): |
| 844 | (WebCore::textBaselineName): |
| 845 | (WebCore::parseTextBaseline): |
| 846 | * platform/graphics/GraphicsTypes.h: |
| 847 | (WebCore::): |
| 848 | |
sullivan@apple.com | bc066af | 2008-09-03 17:37:24 +0000 | [diff] [blame] | 849 | 2008-09-03 John Sullivan <sullivan@apple.com> |
| 850 | |
| 851 | Fixed <rdar://problem/6193022> <rdar://problem/6193022> Crash occurs at WebCore::AnimationBase::propertiesEqual () after certain steps |
| 852 | |
| 853 | Fixed by Darin, reviewed by me |
| 854 | |
| 855 | * page/animation/AnimationBase.cpp: |
| 856 | (WebCore::AnimationBase::propertiesEqual): |
| 857 | added ensurePropertyMap() to this static function |
| 858 | (WebCore::AnimationBase::getPropertyAtIndex): |
| 859 | ditto |
| 860 | (WebCore::AnimationBase::getNumProperties): |
| 861 | ditto |
| 862 | |
kmccullough@apple.com | 70168ee | 2008-09-03 17:35:42 +0000 | [diff] [blame] | 863 | 2008-09-03 Kevin McCullough <kmccullough@apple.com> |
| 864 | |
| 865 | Reviewed by Darin and Tim. |
| 866 | |
| 867 | Remove most of the "zombie" mode from the profiler. Next we will need |
| 868 | to remove the client callback mechanism in profiles. |
| 869 | - These changes are a result of changes to JSCore. |
| 870 | |
| 871 | * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html: |
| 872 | * page/Console.cpp: |
| 873 | (WebCore::retrieveLastCaller): |
| 874 | (WebCore::Console::profileEnd): |
| 875 | * page/InspectorController.cpp: |
| 876 | (WebCore::InspectorController::stopUserInitiatedProfiling): |
| 877 | |
adele@apple.com | 643616b | 2008-09-03 16:57:58 +0000 | [diff] [blame] | 878 | 2008-09-03 Adele Peterson <adele@apple.com> |
| 879 | |
| 880 | Reviewed by Darin Adler. |
| 881 | |
| 882 | Test: fast/forms/search-display-none-cancel-button.html |
| 883 | |
| 884 | Allow display:none to work on a search field's cancel button. Prepare for adding more style-ability for the results button too. |
| 885 | |
| 886 | * css/html4.css: Set display:inline-block for these buttons. Now they can be overridden by a web author. |
| 887 | |
| 888 | * rendering/RenderTextControl.cpp: |
| 889 | (WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers. |
| 890 | (WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly. This is now done in html4.css. |
| 891 | (WebCore::RenderTextControl::createCancelButtonStyle): ditto. |
| 892 | (WebCore::RenderTextControl::createSubtreeIfNeeded): |
| 893 | Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class. |
| 894 | (WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers. |
| 895 | (WebCore::RenderTextControl::subtreeHasChanged): ditto. |
| 896 | (WebCore::RenderTextControl::calcHeight): ditto. |
| 897 | (WebCore::RenderTextControl::nodeAtPoint): ditto. |
| 898 | (WebCore::RenderTextControl::layout): ditto. |
| 899 | (WebCore::RenderTextControl::calcPrefWidths): ditto. |
| 900 | (WebCore::RenderTextControl::clientPaddingLeft): ditto. |
| 901 | (WebCore::RenderTextControl::clientPaddingRight): ditto. |
| 902 | |
| 903 | * rendering/TextControlInnerElements.cpp: |
| 904 | (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp. |
| 905 | (WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto. |
| 906 | (WebCore::TextControlInnerElement::attachInnerElement): Added. |
| 907 | This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element. |
| 908 | (WebCore::TextControlInnerTextElement::createRenderer): Added. Creates a RenderTextControlInnerBlock. |
| 909 | * rendering/TextControlInnerElements.h: |
| 910 | |
ap@webkit.org | acd8414 | 2008-09-03 08:08:19 +0000 | [diff] [blame] | 911 | 2008-08-28 Alexey Proskuryakov <ap@webkit.org> |
| 912 | |
| 913 | Reviewed by Maciej. |
| 914 | |
| 915 | Elminate SQLiteAuthorizer class. |
| 916 | |
| 917 | * WebCore.xcodeproj/project.pbxproj: |
| 918 | * WebCore.vcproj/WebCore.vcproj: |
| 919 | * GNUmakefile.am |
| 920 | Removed SQLiteAuthorizer.h. |
| 921 | |
| 922 | * platform/sql/SQLiteAuthorizer.cpp: |
| 923 | * platform/sql/SQLiteAuthorizer.h: Removed. |
| 924 | * platform/sql/SQLiteDatabase.cpp: |
| 925 | (WebCore::SQLiteDatabase::authorizerFunction): |
| 926 | (WebCore::SQLiteDatabase::setAuthorizer): |
| 927 | * platform/sql/SQLiteDatabase.h: |
| 928 | * storage/DatabaseAuthorizer.h: |
| 929 | (WebCore::DatabaseAuthorizer::create): |
| 930 | (WebCore::DatabaseAuthorizer::createView): |
| 931 | (WebCore::DatabaseAuthorizer::createTempView): |
| 932 | (WebCore::DatabaseAuthorizer::dropView): |
| 933 | (WebCore::DatabaseAuthorizer::dropTempView): |
| 934 | (WebCore::DatabaseAuthorizer::allowSelect): |
| 935 | (WebCore::DatabaseAuthorizer::allowReindex): |
| 936 | Merge SQLiteAuthorizer and DatabaseAuthorizer, as keeping them separate serves no purpose. |
| 937 | |
mrowe@apple.com | 2ecd486 | 2008-09-03 07:05:48 +0000 | [diff] [blame] | 938 | 2008-09-03 Dirk Schulze <vbs85@gmx.de> |
| 939 | |
| 940 | Reviewed by Mark Rowe. |
| 941 | |
| 942 | WebKitGtk build fix. |
| 943 | |
| 944 | * GNUmakefile.am: |
| 945 | * page/animation/AnimationController.h: |
| 946 | |
mrowe@apple.com | e344ad0 | 2008-09-03 06:59:03 +0000 | [diff] [blame] | 947 | 2008-09-02 Robert Blaut <webkit@blaut.biz> |
| 948 | |
| 949 | Reviewed by Geoff Garen. |
| 950 | |
| 951 | Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913> |
| 952 | Misplaced elements should not close DL lists. |
| 953 | |
| 954 | Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html |
| 955 | |
| 956 | * html/HTMLParser.cpp: |
| 957 | (WebCore::HTMLParser::handleError): |
| 958 | |
mrowe@apple.com | 7a90946 | 2008-09-03 06:51:31 +0000 | [diff] [blame] | 959 | 2008-09-02 Glenn Wilson <wilsong@gmail.com> |
| 960 | |
| 961 | Reviewed by Darin Adler. |
| 962 | |
| 963 | Fix for <https://bugs.webkit.org/show_bug.cgi?id=15360> |
| 964 | Bug 15360: color:#{predefined colorName} is treated as colorName in Safari |
| 965 | |
| 966 | We would inappropriately interpret and apply an invalid CSS "color" property |
| 967 | when the value is a predefined color preceded by a '#' symbol. For example, |
| 968 | style="color:#gray;" would apply the color gray when it should not. |
| 969 | |
| 970 | In the bison template, "hexcolor" was defined as both "HEX maybe_space" OR "IDENT maybe_space". |
| 971 | This caused identifiers not fitting the appropriate hex format but preceded by a '#' to be |
| 972 | interpreted as a valid color (CSSPrimitiveValue::CSS_PARSER_HEXCOLOR), when it was really just |
| 973 | an ignorable token. |
| 974 | |
| 975 | To correct this, "IDENT maybe_space" was removed from "hexcolor" and added under "term" as |
| 976 | '#' IDENT maybe_space, which is then processed as a CSSPrimitiveValue::CSS_STRING instead of |
| 977 | CSSPrimitiveValue::CSS_PARSER_HEXCOLOR. |
| 978 | |
| 979 | Test: css1/color_and_background/invalid_color.html |
| 980 | |
| 981 | * css/CSSGrammar.y: |
| 982 | |
mrowe@apple.com | da9a144 | 2008-09-03 06:22:12 +0000 | [diff] [blame] | 983 | 2008-09-02 Mihnea Ovidenie <mihnea@adobe.com> |
| 984 | |
| 985 | Reviewed by Darin Adler. |
| 986 | |
| 987 | Fix for https://bugs.webkit.org/show_bug.cgi?id=19964 |
| 988 | Bug 19964: Divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image |
| 989 | |
| 990 | Add a check to RenderBox::repaintLayerRectsForImage to make sure the current layer image can be rendered. |
| 991 | |
| 992 | Test: css3/khtml-background-size-0x0-bmp.html |
| 993 | |
| 994 | * rendering/RenderBox.cpp: |
| 995 | (WebCore::RenderBox::repaintLayerRectsForImage): |
| 996 | |
mrowe@apple.com | 6625ae5 | 2008-09-03 06:12:30 +0000 | [diff] [blame] | 997 | 2008-09-02 Glenn Wilson <wilsong@gmail.com> |
| 998 | |
| 999 | Reviewed by Eric Seidel. |
| 1000 | |
| 1001 | Fix https://bugs.webkit.org/show_bug.cgi?id=20397 |
| 1002 | Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash |
| 1003 | |
| 1004 | The function checkForOrphanedUnits() would change the length of a list whose size was |
| 1005 | was already determined before the call to checkForOrphanedUnits was made. Later in |
| 1006 | the caller, the old size was being used for boundary management. |
| 1007 | |
| 1008 | This has been fixed by moving the call to checkForOrphanedUnits() earlier in the |
| 1009 | calling function, before the size of the list is determined. |
| 1010 | |
| 1011 | Test: fast/css/orphaned_units_crash.html |
| 1012 | |
| 1013 | * css/CSSParser.cpp: |
| 1014 | (WebCore::CSSParser::parseValue): Moved call to checkForOrphanedUnits() earlier in the function. |
| 1015 | |
mrowe@apple.com | 170bd52 | 2008-09-03 05:49:51 +0000 | [diff] [blame] | 1016 | 2008-09-02 Dirk Schulze <vbs85@gmx.de> |
| 1017 | |
| 1018 | Reviewed by Darin Adler. |
| 1019 | |
mrowe@apple.com | eb877a5 | 2008-09-03 06:01:15 +0000 | [diff] [blame] | 1020 | Fallback on invalid fill or stroke styles in Canvas was |
| 1021 | transparent black. Changed it to last valid style. |
| 1022 | |
| 1023 | Canvas fillStyle() and strokeStyle() needs fallback |
| 1024 | https://bugs.webkit.org/show_bug.cgi?id=20474 |
| 1025 | |
| 1026 | Tests: fast/canvas/canvas-invalid-fillstyle.html |
| 1027 | fast/canvas/canvas-invalid-strokestyle.html |
| 1028 | |
| 1029 | * html/CanvasStyle.cpp: |
| 1030 | (WebCore::CanvasStyle::applyStrokeColor): |
| 1031 | (WebCore::CanvasStyle::applyFillColor): |
| 1032 | |
| 1033 | 2008-09-02 Dirk Schulze <vbs85@gmx.de> |
| 1034 | |
| 1035 | Reviewed by Darin Adler. |
| 1036 | |
mrowe@apple.com | 170bd52 | 2008-09-03 05:49:51 +0000 | [diff] [blame] | 1037 | Fix https://bugs.webkit.org/show_bug.cgi?id=20468 |
| 1038 | Updated drawImage() in canvas to match the current specification. |
| 1039 | |
| 1040 | Test: fast/canvas/drawImage-with-negative-source-destination.html |
| 1041 | |
| 1042 | * html/CanvasRenderingContext2D.cpp: |
| 1043 | (WebCore::normalizeRect): |
| 1044 | (WebCore::CanvasRenderingContext2D::drawImage): |
| 1045 | |
mrowe@apple.com | 96916d1 | 2008-09-03 05:41:44 +0000 | [diff] [blame] | 1046 | 2008-08-26 Mark Rowe <mrowe@apple.com> |
| 1047 | |
| 1048 | Reviewed by Darin Adler. |
| 1049 | |
| 1050 | <rdar://problem/5768210> Switch back to the system version of SQLite |
| 1051 | |
| 1052 | Use the system version of SQLite when it is new enough to provide the functionality |
| 1053 | that WebCore requires. |
| 1054 | |
| 1055 | * Configurations/Base.xcconfig: |
| 1056 | * Configurations/DebugRelease.xcconfig: |
| 1057 | * Configurations/WebCore.xcconfig: |
| 1058 | |
mitz@apple.com | ce268c1 | 2008-09-03 02:59:00 +0000 | [diff] [blame] | 1059 | 2008-09-02 Dan Bernstein <mitz@apple.com> |
| 1060 | |
| 1061 | - build fix |
| 1062 | |
| 1063 | * page/animation/AnimationBase.h: |
| 1064 | |
dino@apple.com | 7e49a7a | 2008-09-03 01:32:14 +0000 | [diff] [blame] | 1065 | 2008-09-02 Chris Marrin <cmarrin@apple.com> |
| 1066 | |
| 1067 | Reviewed by Dave Hyatt. |
| 1068 | |
| 1069 | AnimationController.cpp should be split into separate files |
| 1070 | https://bugs.webkit.org/show_bug.cgi?id=20604 |
| 1071 | |
| 1072 | Note: All makefiles, except WebCore.xcodeproj have been changed without testing, upon |
| 1073 | recommendation of Dave Hyatt. |
| 1074 | |
| 1075 | * GNUmakefile.am: |
| 1076 | * WebCore.pro: |
| 1077 | * WebCore.vcproj/WebCore.vcproj: |
| 1078 | * WebCore.xcodeproj/project.pbxproj: |
| 1079 | * WebCoreSources.bkl: |
| 1080 | Build files. |
| 1081 | |
| 1082 | * page/AnimationController.cpp: Removed. |
| 1083 | * page/AnimationController.h: Removed. |
| 1084 | * page/animation: Added. |
| 1085 | * page/animation/AnimationBase.cpp: Added. |
| 1086 | * page/animation/AnimationBase.h: Added. |
| 1087 | * page/animation/AnimationController.cpp: Copied from WebCore/page/AnimationController.cpp. |
| 1088 | * page/animation/AnimationController.h: Copied from WebCore/page/AnimationController.h. |
| 1089 | * page/animation/CompositeAnimation.cpp: Added. |
| 1090 | * page/animation/CompositeAnimation.h: Added. |
| 1091 | * page/animation/ImplicitAnimation.cpp: Added. |
| 1092 | * page/animation/ImplicitAnimation.h: Added. |
| 1093 | * page/animation/KeyframeAnimation.cpp: Added. |
| 1094 | * page/animation/KeyframeAnimation.h: Added. |
| 1095 | |
mitz@apple.com | cb917a2 | 2008-09-03 00:57:37 +0000 | [diff] [blame] | 1096 | 2008-09-02 Dan Bernstein <mitz@apple.com> |
| 1097 | |
| 1098 | - release build fix |
| 1099 | |
| 1100 | * platform/graphics/cg/GraphicsContextCG.cpp: |
| 1101 | (WebCore::calculateDrawingMode): |
| 1102 | |
timothy@apple.com | f3aa734 | 2008-09-02 21:30:26 +0000 | [diff] [blame] | 1103 | 2008-09-02 Timothy Hatcher <timothy@apple.com> |
| 1104 | |
timothy@apple.com | c33ff3c | 2008-09-02 21:35:02 +0000 | [diff] [blame] | 1105 | Make console functions log the correct resource URL and |
| 1106 | line number for where the call originated. |
| 1107 | |
| 1108 | https://bugs.webkit.org/show_bug.cgi?id=17234 |
| 1109 | <rdar://problem/5732837> |
| 1110 | |
| 1111 | Reviewed by Kevin McCullough. |
| 1112 | |
| 1113 | Test: manual-tests/inspector/console-call-line-numbers.html |
| 1114 | |
| 1115 | * bindings/js/JSConsoleCustom.cpp: |
| 1116 | (WebCore::JSConsole::count): Call the impl. |
| 1117 | (WebCore::JSConsole::timeEnd): Ditto. |
| 1118 | * manual-tests/inspector/console-call-line-numbers.html: Added. |
| 1119 | * manual-tests/inspector/resources/script-console-calls.js: Added. |
| 1120 | * page/Console.cpp: |
| 1121 | (WebCore::retrieveLastCaller): Helper to get the URL and line. |
| 1122 | (WebCore::Console::error): Call retrieveLastCaller to get the URL and |
| 1123 | line number to pass to addMessageToConsole. |
| 1124 | (WebCore::Console::info): Ditto. |
| 1125 | (WebCore::Console::log): Ditto. |
| 1126 | (WebCore::Console::assertCondition): Ditto. |
| 1127 | (WebCore::Console::count): Ditto. |
| 1128 | (WebCore::Console::timeEnd): Ditto. |
| 1129 | (WebCore::Console::warn): Ditto. |
| 1130 | * page/Console.h: |
| 1131 | * page/Console.idl: Make count and timeEnd custom. |
| 1132 | |
| 1133 | 2008-09-02 Timothy Hatcher <timothy@apple.com> |
| 1134 | |
timothy@apple.com | f3aa734 | 2008-09-02 21:30:26 +0000 | [diff] [blame] | 1135 | Removed IDL files from WebCore's framework resources. |
| 1136 | |
| 1137 | * WebCore.xcodeproj/project.pbxproj: |
| 1138 | |
mitz@apple.com | fb6ad39 | 2008-09-02 20:39:29 +0000 | [diff] [blame] | 1139 | 2008-09-02 Dan Bernstein <mitz@apple.com> |
| 1140 | |
| 1141 | Reviewed by Dave Hyatt. |
| 1142 | |
| 1143 | - <rdar://problem/5681647> pages at http://www.stendmarsofa.com/ are so slow to calculate style it seems like a hang |
| 1144 | |
| 1145 | * html/HTMLParser.cpp: |
| 1146 | (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added a |
| 1147 | cap on the number of consecutive identical residual style tags to |
| 1148 | reopen. |
| 1149 | (WebCore::HTMLParser::popBlock): Ditto. |
| 1150 | |
ap@webkit.org | 879328b | 2008-09-02 16:16:06 +0000 | [diff] [blame] | 1151 | 2008-09-02 Alexey Proskuryakov <ap@webkit.org> |
| 1152 | |
| 1153 | Reviewed by Adam Roben. |
| 1154 | |
| 1155 | A little database quota management cleanup. |
| 1156 | |
| 1157 | * storage/OriginQuotaManager.cpp: |
| 1158 | (WebCore::OriginQuotaManager::OriginQuotaManager): |
| 1159 | (WebCore::OriginQuotaManager::lock): |
| 1160 | (WebCore::OriginQuotaManager::unlock): |
| 1161 | (WebCore::OriginQuotaManager::trackOrigin): |
| 1162 | (WebCore::OriginQuotaManager::tracksOrigin): |
| 1163 | (WebCore::OriginQuotaManager::addDatabase): |
| 1164 | (WebCore::OriginQuotaManager::removeDatabase): |
| 1165 | (WebCore::OriginQuotaManager::removeOrigin): |
| 1166 | (WebCore::OriginQuotaManager::markDatabase): |
| 1167 | (WebCore::OriginQuotaManager::diskUsage): |
| 1168 | * storage/OriginQuotaManager.h: |
| 1169 | Changed to assert that a lock is taken more directly and reliably. Removed comments about |
| 1170 | main/background threads, as this is likely to stop being true with synchronous Database calls |
| 1171 | being made on worker threads. |
| 1172 | |
| 1173 | * storage/OriginUsageRecord.cpp: |
| 1174 | (WebCore::OriginUsageRecord::OriginUsageRecord): |
| 1175 | (WebCore::OriginUsageRecord::addDatabase): |
| 1176 | (WebCore::OriginUsageRecord::removeDatabase): |
| 1177 | (WebCore::OriginUsageRecord::markDatabase): |
| 1178 | (WebCore::OriginUsageRecord::diskUsage): |
| 1179 | * storage/OriginUsageRecord.h: |
| 1180 | (WebCore::OriginUsageRecord::DatabaseEntry::DatabaseEntry): |
| 1181 | Don't use a magic value for unknown. It is totally unnecessary for DatabaseEntry, and |
| 1182 | can be replaced with a single boolean for OriginUsageRecord. |
| 1183 | Added assertions for string parameters being unshared. |
| 1184 | |
| 1185 | |
abarth@webkit.org | aea97a0 | 2008-09-02 04:26:15 +0000 | [diff] [blame] | 1186 | 2008-09-01 Adam Barth <abarth@webkit.org> |
| 1187 | |
| 1188 | Reviewed by Sam Weinig. |
| 1189 | |
| 1190 | https://bugs.webkit.org/show_bug.cgi?id=19760 |
| 1191 | |
| 1192 | Make granting LoadLocalResources conditional on a policy. |
| 1193 | |
| 1194 | * WebCore.base.exp: |
| 1195 | * dom/Document.cpp: |
| 1196 | (WebCore::Document::initSecurityContext): |
| 1197 | * loader/FrameLoader.cpp: |
| 1198 | (WebCore::FrameLoader::setLocalLoadPolicy): |
| 1199 | (WebCore::FrameLoader::restrictAccessToLocal): |
| 1200 | * loader/FrameLoader.h: |
| 1201 | (WebCore::FrameLoader::): |
| 1202 | * platform/SecurityOrigin.cpp: |
| 1203 | (WebCore::SecurityOrigin::grantLoadLocalResources): |
| 1204 | * platform/SecurityOrigin.h: |
| 1205 | |
dino@apple.com | 6e2db50 | 2008-09-01 23:05:28 +0000 | [diff] [blame] | 1206 | 2008-09-01 Dean Jackson <dino@apple.com> |
| 1207 | |
dino@apple.com | 59ca9f5 | 2008-09-01 23:34:13 +0000 | [diff] [blame] | 1208 | Reviewed by Sam Weinig. |
| 1209 | |
| 1210 | https://bugs.webkit.org/show_bug.cgi?id=20571 |
| 1211 | Make sure Window object can assign Animation/Transition event |
| 1212 | listeners via attributes. |
| 1213 | |
| 1214 | Also added a bunch of transition event tests, although |
| 1215 | only transition-end-event-window is directly relevant to this patch. |
| 1216 | |
| 1217 | (WebCore::JSDOMWindowBase::put): |
| 1218 | |
| 1219 | Tests: transitions/transition-end-event-all-properties.html |
| 1220 | transitions/transition-end-event-attributes.html |
| 1221 | transitions/transition-end-event-container.html |
| 1222 | transitions/transition-end-event-left.html |
| 1223 | transitions/transition-end-event-multiple-01.html |
| 1224 | transitions/transition-end-event-multiple-02.html |
| 1225 | transitions/transition-end-event-multiple-03.html |
| 1226 | transitions/transition-end-event-multiple-04.html |
| 1227 | transitions/transition-end-event-nested.html |
| 1228 | transitions/transition-end-event-transform.html |
| 1229 | transitions/transition-end-event-window.html |
| 1230 | |
| 1231 | 2008-09-01 Dean Jackson <dino@apple.com> |
| 1232 | |
dino@apple.com | 6e2db50 | 2008-09-01 23:05:28 +0000 | [diff] [blame] | 1233 | Reviewed by Sam Weinig |
| 1234 | |
| 1235 | Code styling cleanup. |
| 1236 | |
| 1237 | * bindings/js/JSDOMWindowBase.cpp: |
| 1238 | (WebCore::JSDOMWindowBase::getValueProperty): |
| 1239 | (WebCore::JSDOMWindowBase::put): |
| 1240 | |
weinig@apple.com | 3412bb4 | 2008-09-01 21:22:54 +0000 | [diff] [blame] | 1241 | 2008-09-01 Geoffrey Garen <ggaren@apple.com> |
| 1242 | |
| 1243 | Reviewed by Darin Adler. |
| 1244 | |
| 1245 | First cut at inline caching for access to vanilla JavaScript properties. |
| 1246 | |
| 1247 | Updated for JavaScriptCore changes. Mostly mechanical addition of StructureIDs |
| 1248 | to WebCore classes, and PutPropertySlot& arguments to put functions. |
| 1249 | |
| 1250 | (WebCore::JSCSSStyleDeclaration::customPut): Be sure to play nice with |
| 1251 | inline caching for global properties, so global assignment can be optimized. |
| 1252 | |
| 1253 | * ForwardingHeaders/kjs/StructureID.h: Added. |
| 1254 | * bindings/js/JSDOMBinding.h: |
| 1255 | (WebCore::DOMObject::DOMObject): |
| 1256 | * bindings/js/JSDOMWindowBase.cpp: |
| 1257 | (WebCore::JSDOMWindowBase::put): |
| 1258 | * bindings/js/JSDOMWindowBase.h: |
| 1259 | * bindings/js/JSDOMWindowCustom.h: |
| 1260 | (WebCore::JSDOMWindow::customPut): |
| 1261 | * bindings/js/JSDOMWindowShell.cpp: |
| 1262 | (WebCore::JSDOMWindowShell::JSDOMWindowShell): |
| 1263 | (WebCore::JSDOMWindowShell::put): |
| 1264 | * bindings/js/JSDOMWindowShell.h: |
| 1265 | * bindings/js/JSEventTargetBase.h: |
| 1266 | (WebCore::JSEventTargetBase::put): |
| 1267 | * bindings/js/JSEventTargetNode.h: |
| 1268 | (WebCore::JSEventTargetNode::put): |
| 1269 | * bindings/js/JSHTMLAppletElementCustom.cpp: |
| 1270 | (WebCore::JSHTMLAppletElement::customPut): |
| 1271 | * bindings/js/JSHTMLEmbedElementCustom.cpp: |
| 1272 | (WebCore::JSHTMLEmbedElement::customPut): |
| 1273 | * bindings/js/JSHTMLInputElementBase.cpp: |
| 1274 | (WebCore::JSHTMLInputElementBase::put): |
| 1275 | * bindings/js/JSHTMLInputElementBase.h: |
| 1276 | * bindings/js/JSHTMLObjectElementCustom.cpp: |
| 1277 | (WebCore::JSHTMLObjectElement::customPut): |
| 1278 | * bindings/js/JSHistoryCustom.cpp: |
| 1279 | (WebCore::JSHistory::customPut): |
| 1280 | * bindings/js/JSInspectedObjectWrapper.cpp: |
| 1281 | (WebCore::JSInspectedObjectWrapper::wrap): |
| 1282 | (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper): |
| 1283 | * bindings/js/JSInspectedObjectWrapper.h: |
| 1284 | * bindings/js/JSInspectorCallbackWrapper.cpp: |
| 1285 | (WebCore::JSInspectorCallbackWrapper::wrap): |
| 1286 | (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper): |
| 1287 | * bindings/js/JSInspectorCallbackWrapper.h: |
| 1288 | * bindings/js/JSLocationCustom.cpp: |
| 1289 | (WebCore::JSLocation::customPut): |
| 1290 | * bindings/js/JSPluginElementFunctions.cpp: |
| 1291 | (WebCore::runtimeObjectCustomPut): |
| 1292 | * bindings/js/JSPluginElementFunctions.h: |
| 1293 | * bindings/js/JSQuarantinedObjectWrapper.cpp: |
| 1294 | (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): |
| 1295 | (WebCore::JSQuarantinedObjectWrapper::put): |
| 1296 | * bindings/js/JSQuarantinedObjectWrapper.h: |
| 1297 | * bindings/js/JSStorageCustom.cpp: |
| 1298 | (WebCore::JSStorage::customPut): |
| 1299 | * bindings/objc/WebScriptObject.mm: |
| 1300 | (-[WebScriptObject setValue:forKey:]): |
| 1301 | * bindings/scripts/CodeGeneratorJS.pm: |
| 1302 | * bridge/NP_jsobject.cpp: |
| 1303 | (_NPN_SetProperty): |
| 1304 | * bridge/jni/jni_jsobject.mm: |
| 1305 | (JavaJSObject::setMember): |
| 1306 | * bridge/objc/objc_class.mm: |
| 1307 | (KJS::Bindings::ObjcClass::fallbackObject): |
| 1308 | * bridge/objc/objc_runtime.h: |
| 1309 | * bridge/objc/objc_runtime.mm: |
| 1310 | (ObjcFallbackObjectImp::ObjcFallbackObjectImp): |
| 1311 | (ObjcFallbackObjectImp::put): |
| 1312 | * bridge/runtime.cpp: |
| 1313 | (KJS::Bindings::Instance::createRuntimeObject): |
| 1314 | * bridge/runtime_array.cpp: |
| 1315 | (RuntimeArray::put): |
| 1316 | * bridge/runtime_array.h: |
| 1317 | * bridge/runtime_object.cpp: |
| 1318 | (RuntimeObjectImp::RuntimeObjectImp): |
| 1319 | (RuntimeObjectImp::put): |
| 1320 | * bridge/runtime_object.h: |
| 1321 | |
jmalonzo@webkit.org | 1f770ba | 2008-09-01 12:43:34 +0000 | [diff] [blame] | 1322 | 2008-09-01 Dirk Schulze <vbs85@gmx.de> |
| 1323 | |
| 1324 | Reviewed by Eric Seidel. |
| 1325 | |
jmalonzo@webkit.org | 37f0788 | 2008-09-01 12:43:48 +0000 | [diff] [blame] | 1326 | Fixed border-radius for Cairo. |
| 1327 | |
| 1328 | * platform/graphics/cairo/GraphicsContextCairo.cpp: |
| 1329 | (WebCore::GraphicsContext::strokeArc): |
| 1330 | |
| 1331 | 2008-09-01 Dirk Schulze <vbs85@gmx.de> |
| 1332 | |
| 1333 | Reviewed by Eric Seidel. |
| 1334 | |
jmalonzo@webkit.org | 1f770ba | 2008-09-01 12:43:34 +0000 | [diff] [blame] | 1335 | Added canvas's globalAlpha to cairo. |
| 1336 | |
| 1337 | * platform/graphics/GraphicsContext.h: |
| 1338 | * platform/graphics/cairo/GraphicsContextCairo.cpp: |
| 1339 | (WebCore::GraphicsContext::fillPath): |
| 1340 | (WebCore::GraphicsContext::strokePath): |
| 1341 | (WebCore::GraphicsContext::setAlpha): |
| 1342 | (WebCore::GraphicsContext::getAlpha): |
| 1343 | * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: |
| 1344 | (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): |
| 1345 | * platform/graphics/cairo/ImageCairo.cpp: |
| 1346 | (WebCore::BitmapImage::draw): |
| 1347 | |
hausmann@webkit.org | ecd099d | 2008-08-31 13:13:28 +0000 | [diff] [blame] | 1348 | 2008-08-31 Simon Hausmann <hausmann@webkit.org> |
| 1349 | |
| 1350 | Unreviewed Qt build fix. |
| 1351 | |
| 1352 | * WebCore.pro: Add TextControlInnerElements.cpp to SOURCES instead of |
| 1353 | the .h file |
| 1354 | |
darin@apple.com | e794585 | 2008-08-31 06:58:07 +0000 | [diff] [blame] | 1355 | 2008-08-30 Darin Adler <darin@apple.com> |
| 1356 | |
| 1357 | Reviewed by Maciej. |
| 1358 | |
| 1359 | - adopt some new JavaScriptCore functions where appropriate |
| 1360 | |
| 1361 | * bindings/js/JSDOMWindowBase.cpp: |
| 1362 | (WebCore::windowProtoFuncAToB): Adopted jsEmptyString. |
| 1363 | (WebCore::windowProtoFuncBToA): Ditto. |
| 1364 | * bindings/js/JSEventListener.cpp: |
| 1365 | (WebCore::JSLazyEventListener::eventParameterName): Adopted |
| 1366 | jsNontrivialString. |
| 1367 | * bindings/js/JSSVGLazyEventListener.cpp: |
| 1368 | (WebCore::JSSVGLazyEventListener::eventParameterName): Ditto. |
| 1369 | |
beidson@apple.com | 21c821f | 2008-08-30 00:26:01 +0000 | [diff] [blame] | 1370 | 2008-08-29 Brady Eidson <beidson@apple.com> |
| 1371 | |
beidson@apple.com | e1bd603 | 2008-08-30 00:30:11 +0000 | [diff] [blame] | 1372 | Reviewed by Anders' rubberstamp |
| 1373 | |
| 1374 | Style cleanup to match MediaTokenizer::writeRawData() |
| 1375 | |
| 1376 | * loader/PluginDocument.cpp: |
| 1377 | (WebCore::PluginTokenizer::writeRawData): |
| 1378 | |
| 1379 | 2008-08-29 Brady Eidson <beidson@apple.com> |
| 1380 | |
beidson@apple.com | 21c821f | 2008-08-30 00:26:01 +0000 | [diff] [blame] | 1381 | Reviewed by Anders |
| 1382 | |
| 1383 | Fix regression I introducted in 35946 |
| 1384 | Already covered by media/video-click-dlbclick-standalone.html |
| 1385 | |
| 1386 | * loader/MediaDocument.cpp: |
| 1387 | (WebCore::MediaTokenizer::createDocumentStructure): Don't cancel the load here - too early! |
| 1388 | (WebCore::MediaTokenizer::writeRawData): Call finish() here so onload() can be called. Also add |
| 1389 | an ASSERT signifying that this method should only be called once, to more closely follow the |
| 1390 | PluginDocument case. |
| 1391 | |
bdakin@apple.com | 7ee298c | 2008-08-30 00:00:30 +0000 | [diff] [blame] | 1392 | 2008-08-29 Beth Dakin <bdakin@apple.com> |
| 1393 | |
| 1394 | Reviewed by Sam Weinig. |
| 1395 | |
| 1396 | Fix for <rdar://problem/6181588> |
| 1397 | |
| 1398 | This patch makes hit testing take into account the new concept of a |
| 1399 | disconnected frame, in which some of the content may not be |
| 1400 | visible. The current hit testing mechanism starts at a target frame |
| 1401 | and drills down for a HitTestResult. In some cases, drilling down |
| 1402 | will find a non-visible result. When this happens, we need to try |
| 1403 | again, starting at a higher level -- namely, starting at the main |
| 1404 | frame. |
| 1405 | |
| 1406 | * editing/Editor.cpp: |
| 1407 | (WebCore::Editor::insideVisibleArea): New function that tests if a |
| 1408 | point is inside the visible area for a disconnected frame. |
| 1409 | * editing/Editor.h: |
| 1410 | * page/EventHandler.cpp: |
| 1411 | (WebCore::EventHandler::hitTestResultAtPoint): |
| 1412 | |
adele@apple.com | fb90306 | 2008-08-29 22:30:18 +0000 | [diff] [blame] | 1413 | 2008-08-29 Adele Peterson <adele@apple.com> |
| 1414 | |
| 1415 | Reviewed by Adam Roben. |
| 1416 | |
| 1417 | Rename HTMLTextFieldInnerElement.h/.cpp to TextControlInnerElements.h/.cpp |
| 1418 | |
| 1419 | * GNUmakefile.am: |
| 1420 | * WebCore.pro: |
| 1421 | * WebCore.vcproj/WebCore.vcproj: |
| 1422 | * WebCore.xcodeproj/project.pbxproj: |
| 1423 | * WebCoreSources.bkl: |
| 1424 | * html/HTMLTextFieldInnerElement.cpp: Removed. |
| 1425 | * html/HTMLTextFieldInnerElement.h: Removed. |
| 1426 | * rendering/RenderTextControl.cpp: |
| 1427 | (WebCore::RenderTextControl::createSubtreeIfNeeded): |
| 1428 | * rendering/RenderTextControl.h: |
| 1429 | * rendering/TextControlInnerElements.cpp: Copied from html/HTMLTextFieldInnerElement.cpp. |
| 1430 | (WebCore::TextControlInnerElement::TextControlInnerElement): |
| 1431 | (WebCore::TextControlInnerTextElement::TextControlInnerTextElement): |
| 1432 | (WebCore::TextControlInnerTextElement::defaultEventHandler): |
| 1433 | (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement): |
| 1434 | (WebCore::SearchFieldResultsButtonElement::defaultEventHandler): |
| 1435 | (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement): |
| 1436 | (WebCore::SearchFieldCancelButtonElement::defaultEventHandler): |
| 1437 | * rendering/TextControlInnerElements.h: Copied from html/HTMLTextFieldInnerElement.h. |
| 1438 | |
eric@webkit.org | 298c65b | 2008-08-29 21:39:32 +0000 | [diff] [blame] | 1439 | 2008-08-29 Eric Seidel <eric@webkit.org> |
| 1440 | |
eric@webkit.org | 77837ce | 2008-08-29 21:40:07 +0000 | [diff] [blame] | 1441 | Rubber-stamped by aroben. |
| 1442 | |
| 1443 | Add GraphicsContext.h include to GraphcisContextPrivate.h |
| 1444 | |
| 1445 | GraphicsContextPrivate uses StrokeStyle which is defined |
| 1446 | in GraphicsContext.h but it doesn't include that header. |
| 1447 | CoreGraphics build doesn't fail here due to the order |
| 1448 | it happens to include files. |
| 1449 | |
| 1450 | * platform/graphics/GraphicsContextPrivate.h: |
| 1451 | |
| 1452 | 2008-08-29 Eric Seidel <eric@webkit.org> |
| 1453 | |
eric@webkit.org | 298c65b | 2008-08-29 21:39:32 +0000 | [diff] [blame] | 1454 | Reviewed by hyatt. |
| 1455 | |
| 1456 | Fix GeneratedImage to respect Image's refcounting |
| 1457 | Fixing potential crashers (future if not current) |
| 1458 | https://bugs.webkit.org/show_bug.cgi?id=20567 |
| 1459 | |
| 1460 | I don't know if it's possible to make the current code |
| 1461 | crash, thus I've not made a test. |
| 1462 | |
| 1463 | * css/CSSGradientValue.cpp: |
| 1464 | (WebCore::CSSGradientValue::image): |
| 1465 | * css/CSSImageGeneratorValue.cpp: |
| 1466 | (WebCore::CSSImageGeneratorValue::removeClient): |
| 1467 | (WebCore::CSSImageGeneratorValue::getImage): |
| 1468 | * css/CSSImageGeneratorValue.h: |
| 1469 | * platform/graphics/GeneratedImage.h: |
| 1470 | (WebCore::GeneratedImage::GeneratedImage): |
| 1471 | * rendering/style/RenderStyle.cpp: |
| 1472 | (WebCore::RenderStyle::setContent): |
| 1473 | * rendering/style/RenderStyle.h: |
| 1474 | |
eric.carlson@apple.com | ddeafd4 | 2008-08-29 20:07:19 +0000 | [diff] [blame] | 1475 | 2008-08-29 Eric Carlson <eric.carlson@apple.com> |
| 1476 | |
| 1477 | Reviewed by Adele. |
| 1478 | |
eric.carlson@apple.com | 850c77c | 2008-08-29 20:24:50 +0000 | [diff] [blame] | 1479 | Fix for <rdar://problem/6093767> |
| 1480 | https://bugs.webkit.org/show_bug.cgi?id=20526 |
| 1481 | |
| 1482 | Don't allow video to render until unsupported track types have been disabled. |
| 1483 | |
| 1484 | * platform/graphics/win/QTMovieWin.cpp: |
| 1485 | (QTMovieWinPrivate::task): |
| 1486 | (QTMovieWinPrivate::drawingComplete): |
| 1487 | (QTMovieWinPrivate::clearGWorld): |
| 1488 | |
| 1489 | 2008-08-29 Eric Carlson <eric.carlson@apple.com> |
| 1490 | |
| 1491 | Reviewed by Adele. |
| 1492 | |
eric.carlson@apple.com | ddeafd4 | 2008-08-29 20:07:19 +0000 | [diff] [blame] | 1493 | Fix for https://bugs.webkit.org/show_bug.cgi?id=20525 |
| 1494 | <rdar://problem/6169301> |
| 1495 | |
| 1496 | Return the size of the movie data instead of 1000. |
| 1497 | |
| 1498 | Test: media/progress-event-total.html |
| 1499 | |
| 1500 | * platform/graphics/win/QTMovieWin.cpp: |
| 1501 | (QTMovieWin::dataSize): |
| 1502 | |
hausmann@webkit.org | 0367b58 | 2008-08-29 15:56:02 +0000 | [diff] [blame] | 1503 | 2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org> |
| 1504 | |
hausmann@webkit.org | fe7f2ac | 2008-08-29 15:57:44 +0000 | [diff] [blame] | 1505 | Reviewed by Eric Seidel. |
| 1506 | |
| 1507 | [janitor/qt] Start replacing port specific getters with the generic native getter |
| 1508 | To get the native presentation of an image we currently have platform |
| 1509 | specific #ifdef's and a generic getter using NativeImagePtr. This patch |
| 1510 | extends this to the ImageBuffer and updates the Qt platform to get rid |
| 1511 | of the special #ifdefs. |
| 1512 | |
| 1513 | https://bugs.webkit.org/attachment.cgi?id=22861 |
| 1514 | |
| 1515 | * platform/graphics/BitmapImage.h: |
| 1516 | * platform/graphics/Image.h: |
| 1517 | * platform/graphics/qt/ImageQt.cpp: |
| 1518 | * platform/graphics/qt/StillImageQt.cpp: |
| 1519 | * platform/graphics/qt/StillImageQt.h: |
| 1520 | * platform/qt/ClipboardQt.cpp: |
| 1521 | (WebCore::ClipboardQt::createDragImage): |
| 1522 | (WebCore::ClipboardQt::declareAndWriteDragImage): |
| 1523 | * platform/qt/CursorQt.cpp: |
| 1524 | * platform/qt/PasteboardQt.cpp: |
| 1525 | (WebCore::Pasteboard::writeImage): |
| 1526 | |
| 1527 | 2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org> |
| 1528 | |
hausmann@webkit.org | 0367b58 | 2008-08-29 15:56:02 +0000 | [diff] [blame] | 1529 | Reviewed by Simon. |
| 1530 | |
hausmann@webkit.org | b99266e | 2008-08-29 15:56:59 +0000 | [diff] [blame] | 1531 | [svg/qt] Stop crashing... when no RenderPath/RenderObject is given... |
| 1532 | |
| 1533 | * svg/graphics/qt/SVGPaintServerQt.cpp: |
| 1534 | (WebCore::SVGPaintServer::renderPath): |
| 1535 | * svg/graphics/qt/SVGPaintServerSolidQt.cpp: |
| 1536 | (WebCore::SVGPaintServerSolid::setup): |
| 1537 | |
| 1538 | 2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org> |
| 1539 | |
| 1540 | Reviewed by Simon. |
| 1541 | |
hausmann@webkit.org | 0367b58 | 2008-08-29 15:56:02 +0000 | [diff] [blame] | 1542 | [network/qt] Implement defering of loading ResourceHandle's |
| 1543 | This is needed otherwise we end in an ASSERT in the MainResourceLoader. The |
| 1544 | implementation is simply not forwarding anything to the |
| 1545 | ResourceHandleClient until we are allowed to. This might lead to a deadlock |
| 1546 | in Qt as we do not empty the QNetworkReply input buffer and wait until we |
| 1547 | are allowed to read. If that happens we are forced to buffer the data |
| 1548 | within QNetworkReplyHandler, for now this is not done. |
| 1549 | |
| 1550 | Manual test: |
| 1551 | - Open http://acid3.acidtests.org |
| 1552 | - Wait for the test to complete |
| 1553 | - Click on the Reference Rendering link |
| 1554 | - Be fast and see the results of acid3 |
| 1555 | => assert |
| 1556 | |
| 1557 | * platform/network/qt/QNetworkReplyHandler.cpp: |
| 1558 | (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): |
| 1559 | (WebCore::QNetworkReplyHandler::setLoadMode): |
| 1560 | (WebCore::QNetworkReplyHandler::finish): |
| 1561 | (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): |
| 1562 | (WebCore::QNetworkReplyHandler::forwardData): |
| 1563 | (WebCore::QNetworkReplyHandler::start): |
| 1564 | (WebCore::QNetworkReplyHandler::resetState): |
| 1565 | (WebCore::QNetworkReplyHandler::sendQueuedItems): |
| 1566 | * platform/network/qt/QNetworkReplyHandler.h: |
| 1567 | (WebCore::QNetworkReplyHandler::): |
| 1568 | * platform/network/qt/ResourceHandleQt.cpp: |
| 1569 | (WebCore::ResourceHandle::start): |
| 1570 | (WebCore::ResourceHandle::loadResourceSynchronously): |
| 1571 | (WebCore::ResourceHandle::setDefersLoading): |
| 1572 | |
hausmann@webkit.org | 2f2621f | 2008-08-29 10:21:38 +0000 | [diff] [blame] | 1573 | 2008-08-29 Simon Hausmann <hausmann@webkit.org> |
| 1574 | |
hausmann@webkit.org | f586440 | 2008-08-29 12:35:59 +0000 | [diff] [blame] | 1575 | Reviewed by Holger. |
| 1576 | |
| 1577 | Don't crash when drawing patterns with the HTML canvas. Patterns |
| 1578 | remain unimplemented but at least they don't crash anymore. This is |
| 1579 | done by changing the PlatformPatternPtr to be a brush for the Qt |
| 1580 | platform. |
| 1581 | |
| 1582 | * platform/graphics/Pattern.h: |
| 1583 | * platform/graphics/qt/GraphicsContextQt.cpp: |
| 1584 | (WebCore::GraphicsContext::fillPath): |
| 1585 | (WebCore::GraphicsContext::strokePath): |
| 1586 | (WebCore::GraphicsContext::fillRect): |
| 1587 | * platform/graphics/qt/PatternQt.cpp: |
| 1588 | (WebCore::Pattern::createPlatformPattern): |
| 1589 | |
| 1590 | 2008-08-29 Simon Hausmann <hausmann@webkit.org> |
| 1591 | |
hausmann@webkit.org | 2f2621f | 2008-08-29 10:21:38 +0000 | [diff] [blame] | 1592 | Fix the Qt build, fontSelector() is not used by the Qt port yet |
| 1593 | and we just return 0 in Font::fontSelector(). |
| 1594 | |
| 1595 | * platform/graphics/Font.h: |
| 1596 | |
alp@webkit.org | 97d8c10 | 2008-08-29 05:09:39 +0000 | [diff] [blame] | 1597 | 2008-08-28 Alp Toker <alp@nuanti.com> |
| 1598 | |
| 1599 | GTK+ dist/build fix. List newly added header files. |
| 1600 | |
| 1601 | * GNUmakefile.am: |
| 1602 | |
simon.fraser@apple.com | 8f30d02 | 2008-08-28 23:04:18 +0000 | [diff] [blame] | 1603 | 2008-08-28 Simon Fraser <simon.fraser@apple.com> |
| 1604 | |
| 1605 | Reviewed by Dave Hyatt |
| 1606 | |
| 1607 | Various WebKitCSSTransformValue-related fixes |
| 1608 | https://bugs.webkit.org/show_bug.cgi?id=20562 |
| 1609 | |
| 1610 | Test: css3/transform-value-types.html |
| 1611 | |
| 1612 | * bindings/js/JSCSSValueCustom.cpp: |
| 1613 | (WebCore::toJS): |
| 1614 | * css/CSSValue.h: |
| 1615 | * css/WebKitCSSTransformValue.cpp: |
| 1616 | (WebCore::WebKitCSSTransformValue::cssText): |
| 1617 | * css/WebKitCSSTransformValue.h: |
| 1618 | (WebCore::WebKitCSSTransformValue::): |
| 1619 | * css/WebKitCSSTransformValue.idl: |
| 1620 | |
mitz@apple.com | d722235 | 2008-08-28 22:53:31 +0000 | [diff] [blame] | 1621 | 2008-08-28 Dan Bernstein <mitz@apple.com> |
| 1622 | |
| 1623 | Reviewed by Steve Falkenburg. |
| 1624 | |
| 1625 | - do not let the "last chance" WM_TIMER trigger WebCore timers when they should be deferred |
| 1626 | |
| 1627 | * platform/win/SharedTimerWin.cpp: |
| 1628 | (WebCore::TimerWindowWndProc): |
| 1629 | |
hyatt@apple.com | 7d33523 | 2008-08-28 21:38:45 +0000 | [diff] [blame] | 1630 | 2008-08-28 David Hyatt <hyatt@apple.com> |
| 1631 | |
| 1632 | RenderStyle cleanup. |
| 1633 | |
| 1634 | Break out StyleImage, StyleGeneratedImage, StyleCachedImage and NinePieceImage into separate files. |
| 1635 | |
| 1636 | Reviewed by Adam |
| 1637 | |
| 1638 | * css/CSSImageGeneratorValue.cpp: |
| 1639 | * css/CSSImageValue.cpp: |
| 1640 | * css/CSSStyleSelector.cpp: |
| 1641 | * rendering/RenderImageGeneratedContent.cpp: |
| 1642 | * rendering/style/NinePieceImage.cpp: Added. |
| 1643 | * rendering/style/NinePieceImage.h: Added. |
| 1644 | * rendering/style/RenderStyle.cpp: |
| 1645 | (WebCore::FillLayer::operator==): |
| 1646 | (WebCore::FillLayer::containsImage): |
| 1647 | (WebCore::StyleInheritedData::operator==): |
| 1648 | (WebCore::RenderStyle::contentDataEquivalent): |
| 1649 | * rendering/style/RenderStyle.h: |
| 1650 | * rendering/style/StyleCachedImage.cpp: Added. |
| 1651 | * rendering/style/StyleCachedImage.h: Added. |
| 1652 | * rendering/style/StyleGeneratedImage.cpp: Added. |
| 1653 | * rendering/style/StyleGeneratedImage.h: Added. |
| 1654 | * rendering/style/StyleImage.h: Added. |
| 1655 | |
simon.fraser@apple.com | 28bad1a | 2008-08-28 21:29:21 +0000 | [diff] [blame] | 1656 | 2008-08-28 Simon Fraser <simon.fraser@apple.com> |
| 1657 | |
| 1658 | Reviewed by Dave Hyatt |
| 1659 | |
| 1660 | Make all the 'isFoo()' methods on CSSValue const, |
| 1661 | and fix the subclasses. |
| 1662 | |
| 1663 | https://bugs.webkit.org/show_bug.cgi?id=20561 |
| 1664 | |
| 1665 | * css/CSSTimingFunctionValue.h: |
| 1666 | * css/CSSValue.h: |
| 1667 | (WebCore::CSSValue::isFontValue): |
| 1668 | (WebCore::CSSValue::isImageGeneratorValue): |
| 1669 | (WebCore::CSSValue::isImageValue): |
| 1670 | (WebCore::CSSValue::isImplicitInitialValue): |
| 1671 | * css/CSSValueList.h: |
| 1672 | * css/FontValue.h: |
| 1673 | |
hyatt@apple.com | 550a95c | 2008-08-28 19:53:56 +0000 | [diff] [blame] | 1674 | 2008-08-28 David Hyatt <hyatt@apple.com> |
| 1675 | |
hyatt@apple.com | cb3eb81 | 2008-08-28 20:08:03 +0000 | [diff] [blame] | 1676 | The great RenderStyle cleanup begins! |
| 1677 | |
| 1678 | Move LengthBox and LengthSize out of RenderStyle and into Length. |
| 1679 | |
| 1680 | Reviewed by Adam |
| 1681 | |
| 1682 | * rendering/Length.h: |
| 1683 | (WebCore::): |
| 1684 | (WebCore::Length::Length): |
| 1685 | (WebCore::Length::operator==): |
| 1686 | (WebCore::Length::operator!=): |
| 1687 | (WebCore::Length::value): |
| 1688 | (WebCore::Length::rawValue): |
| 1689 | (WebCore::Length::percent): |
| 1690 | (WebCore::Length::type): |
| 1691 | (WebCore::Length::quirk): |
| 1692 | (WebCore::Length::setValue): |
| 1693 | (WebCore::Length::setRawValue): |
| 1694 | (WebCore::Length::calcValue): |
| 1695 | (WebCore::Length::calcMinValue): |
| 1696 | (WebCore::Length::calcFloatValue): |
| 1697 | (WebCore::Length::isUndefined): |
| 1698 | (WebCore::Length::isZero): |
| 1699 | (WebCore::Length::isPositive): |
| 1700 | (WebCore::Length::isNegative): |
| 1701 | (WebCore::Length::isAuto): |
| 1702 | (WebCore::Length::isRelative): |
| 1703 | (WebCore::Length::isPercent): |
| 1704 | (WebCore::Length::isFixed): |
| 1705 | (WebCore::Length::isStatic): |
| 1706 | (WebCore::Length::isIntrinsicOrAuto): |
| 1707 | (WebCore::Length::blend): |
| 1708 | (WebCore::LengthBox::LengthBox): |
| 1709 | (WebCore::LengthBox::operator=): |
| 1710 | (WebCore::LengthBox::operator==): |
| 1711 | (WebCore::LengthBox::operator!=): |
| 1712 | (WebCore::LengthBox::nonZero): |
| 1713 | (WebCore::LengthSize::LengthSize): |
| 1714 | * rendering/style/RenderStyle.h: |
| 1715 | |
| 1716 | 2008-08-28 David Hyatt <hyatt@apple.com> |
| 1717 | |
hyatt@apple.com | 550a95c | 2008-08-28 19:53:56 +0000 | [diff] [blame] | 1718 | Reviewed by Darin |
| 1719 | |
| 1720 | https://bugs.webkit.org/show_bug.cgi?id=18091 |
| 1721 | |
| 1722 | font-size should be animatable using -webkit-transition. |
| 1723 | |
| 1724 | * page/AnimationController.cpp: |
| 1725 | (WebCore::AnimationControllerPrivate::ensurePropertyMap): |
| 1726 | * rendering/style/RenderStyle.h: |
| 1727 | (WebCore::RenderStyle::setFontSize): |
| 1728 | |
mitz@apple.com | 30923ad | 2008-08-28 17:45:47 +0000 | [diff] [blame] | 1729 | 2008-08-28 Brad Garcia <bgarcia@google.com> |
| 1730 | |
| 1731 | Reviewed by Dan Bernstein. |
| 1732 | |
| 1733 | https://bugs.webkit.org/show_bug.cgi?id=20549 |
| 1734 | Correctly determine when cursor is over a resizable border within |
| 1735 | a nested frameset. |
| 1736 | |
| 1737 | * rendering/RenderFrameSet.cpp: |
| 1738 | (WebCore::RenderFrameSet::canResizeRow): |
| 1739 | (WebCore::RenderFrameSet::canResizeColumn): |
| 1740 | |
simon.fraser@apple.com | ae77c41 | 2008-08-28 17:30:07 +0000 | [diff] [blame] | 1741 | 2008-08-28 Simon Fraser <simon.fraser@apple.com> |
| 1742 | |
| 1743 | Reviewed by Eric Seidel |
| 1744 | |
| 1745 | Add RuleTypes to CSSRule.idl for keyframes and keyframe rules. |
| 1746 | https://bugs.webkit.org/show_bug.cgi?id=20552 |
| 1747 | |
| 1748 | Test: animations/animation-css-rule-types.html |
| 1749 | |
| 1750 | * css/CSSRule.idl: |
| 1751 | |
andersca@apple.com | 12399c3 | 2008-08-28 17:26:46 +0000 | [diff] [blame] | 1752 | 2008-08-28 Anders Carlsson <andersca@apple.com> |
| 1753 | |
| 1754 | Reviewed by Kevin and Darin. |
| 1755 | |
| 1756 | <rdar://problem/6182541> |
| 1757 | https://bugs.webkit.org/show_bug.cgi?id=20202 |
| 1758 | Missing http status line from the http headers. |
| 1759 | |
| 1760 | Add a status line to the header string. |
| 1761 | |
| 1762 | * plugins/PluginStream.cpp: |
| 1763 | (WebCore::PluginStream::startStream): |
| 1764 | |
zecke@webkit.org | f1daa42 | 2008-08-28 15:56:01 +0000 | [diff] [blame] | 1765 | 2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org> |
| 1766 | |
| 1767 | Rubber-stamped by Darin Adler. |
| 1768 | |
| 1769 | https://bugs.webkit.org/show_bug.cgi?id=17261 |
| 1770 | |
| 1771 | Make it possible to theme the default Url icon and enable this for |
| 1772 | the Qt port. To have a minimal usage of #ifdef in the code the setting |
| 1773 | of the icon was moved to a new method which comes in two flavors. |
| 1774 | |
| 1775 | * loader/icon/IconDatabase.cpp: |
| 1776 | (WebCore::loadDefaultIconRecord): Load or set the default icon |
| 1777 | (WebCore::IconDatabase::defaultIcon): |
| 1778 | |
zecke@webkit.org | 1887dc8 | 2008-08-28 15:03:21 +0000 | [diff] [blame] | 1779 | 2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org> |
| 1780 | |
| 1781 | Unreviewed compile fix |
| 1782 | |
| 1783 | * platform/graphics/qt/GraphicsContextQt.cpp: Remove redefinitions |
| 1784 | |
aroben@apple.com | facf503 | 2008-08-28 13:34:01 +0000 | [diff] [blame] | 1785 | 2008-08-28 Adam Roben <aroben@apple.com> |
| 1786 | |
| 1787 | Windows (and others?) build fix |
| 1788 | |
| 1789 | * page/Chrome.cpp: Added a missing #include. |
| 1790 | (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Fixed typo. |
| 1791 | |
eric@webkit.org | 22794fd | 2008-08-28 12:04:40 +0000 | [diff] [blame] | 1792 | 2008-08-27 Eric Seidel <eric@webkit.org> |
| 1793 | |
| 1794 | Reviewed by Oliver Hunt. |
| 1795 | |
eric@webkit.org | 5f874e9 | 2008-08-28 12:04:55 +0000 | [diff] [blame] | 1796 | Qt and Cairo support from krit (and blind stab @ wx compile support) |
| 1797 | https://bugs.webkit.org/show_bug.cgi?id=20373 |
| 1798 | |
| 1799 | * platform/graphics/cairo/GraphicsContextCairo.cpp: |
| 1800 | (WebCore::GraphicsContext::fillPath): |
| 1801 | (WebCore::GraphicsContext::strokePath): |
| 1802 | (WebCore::GraphicsContext::drawPath): |
| 1803 | (WebCore::GraphicsContext::fillRect): |
| 1804 | (WebCore::GraphicsContext::setPlatformFillColor): |
| 1805 | (WebCore::GraphicsContext::setPlatformStrokeColor): |
| 1806 | (WebCore::GraphicsContext::setPlatformStrokeStyle): |
| 1807 | (WebCore::GraphicsContext::strokeRect): |
| 1808 | (WebCore::GraphicsContext::setImageInterpolationQuality): |
| 1809 | (WebCore::GraphicsContext::imageInterpolationQuality): |
| 1810 | (WebCore::GraphicsContext::setPlatformFillPattern): |
| 1811 | (WebCore::GraphicsContext::setPlatformStrokePattern): |
| 1812 | (WebCore::GraphicsContext::setPlatformFillGradient): |
| 1813 | (WebCore::GraphicsContext::setPlatformStrokeGradient): |
| 1814 | * platform/graphics/qt/GraphicsContextQt.cpp: |
| 1815 | (WebCore::GraphicsContext::fillPath): |
| 1816 | (WebCore::GraphicsContext::strokePath): |
| 1817 | (WebCore::GraphicsContext::fillRect): |
| 1818 | (WebCore::GraphicsContext::strokeRect): |
| 1819 | (WebCore::GraphicsContext::clipToImageBuffer): |
| 1820 | (WebCore::GraphicsContext::setPlatformFillPattern): |
| 1821 | (WebCore::GraphicsContext::setPlatformStrokePattern): |
| 1822 | (WebCore::GraphicsContext::setPlatformFillGradient): |
| 1823 | (WebCore::GraphicsContext::setPlatformStrokeGradient): |
| 1824 | (WebCore::GraphicsContext::setImageInterpolationQuality): |
| 1825 | (WebCore::GraphicsContext::imageInterpolationQuality): |
| 1826 | * platform/graphics/wx/GraphicsContextWx.cpp: |
| 1827 | (WebCore::GraphicsContext::clipToImageBuffer): |
| 1828 | (WebCore::GraphicsContext::setImageInterpolationQuality): |
| 1829 | (WebCore::GraphicsContext::imageInterpolationQuality): |
| 1830 | (WebCore::GraphicsContext::fillPath): |
| 1831 | (WebCore::GraphicsContext::strokePath): |
| 1832 | (WebCore::GraphicsContext::drawPath): |
| 1833 | (WebCore::GraphicsContext::fillRect): |
| 1834 | (WebCore::GraphicsContext::setPlatformFillPattern): |
| 1835 | (WebCore::GraphicsContext::setPlatformStrokePattern): |
| 1836 | (WebCore::GraphicsContext::setPlatformFillGradient): |
| 1837 | |
| 1838 | 2008-08-27 Eric Seidel <eric@webkit.org> |
| 1839 | |
| 1840 | Reviewed by Oliver Hunt. |
| 1841 | |
eric@webkit.org | 22794fd | 2008-08-28 12:04:40 +0000 | [diff] [blame] | 1842 | Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it. |
| 1843 | https://bugs.webkit.org/show_bug.cgi?id=20373 |
| 1844 | |
| 1845 | Changed pattern() to canvasPattern() on CanvasStyle to match canvasGradient() |
| 1846 | |
| 1847 | Made Generator (aka Gradient) RefCounted so that GraphicsContext didn't |
| 1848 | have to store large Gradient objects in the GraphicsContextState |
| 1849 | |
| 1850 | Made Pattern RefCounted for the same reason. |
| 1851 | |
| 1852 | Many updates to GraphicsContext to support easier drawing with |
| 1853 | Patterns and Gradients. |
| 1854 | |
| 1855 | * WebCore.xcodeproj/project.pbxproj: Add pre-existing GraphicsContextPrivate.h |
| 1856 | * bindings/js/JSCanvasRenderingContext2DCustom.cpp: |
| 1857 | (WebCore::toJS): |
| 1858 | * css/CSSGradientValue.cpp: |
| 1859 | (WebCore::CSSGradientValue::createGradient): |
| 1860 | * css/CSSGradientValue.h: |
| 1861 | * html/CanvasGradient.cpp: |
| 1862 | (WebCore::CanvasGradient::CanvasGradient): |
| 1863 | * html/CanvasGradient.h: |
| 1864 | (WebCore::CanvasGradient::gradient): |
| 1865 | (WebCore::CanvasGradient::addColorStop): |
| 1866 | (WebCore::CanvasGradient::getColor): |
| 1867 | * html/CanvasPattern.cpp: |
| 1868 | * html/CanvasPattern.h: |
| 1869 | (WebCore::CanvasPattern::pattern): |
| 1870 | (WebCore::CanvasPattern::originClean): |
| 1871 | * html/CanvasRenderingContext2D.cpp: |
| 1872 | (WebCore::CanvasRenderingContext2D::State::State): |
| 1873 | (WebCore::CanvasRenderingContext2D::setStrokeStyle): |
| 1874 | (WebCore::CanvasRenderingContext2D::setFillStyle): |
| 1875 | (WebCore::CanvasRenderingContext2D::fill): |
| 1876 | (WebCore::CanvasRenderingContext2D::stroke): |
| 1877 | (WebCore::CanvasRenderingContext2D::fillRect): |
| 1878 | (WebCore::CanvasRenderingContext2D::strokeRect): |
| 1879 | * html/CanvasRenderingContext2D.h: |
| 1880 | * html/CanvasStyle.cpp: |
| 1881 | (WebCore::CanvasStyle::applyStrokeColor): |
| 1882 | (WebCore::CanvasStyle::applyFillColor): |
| 1883 | * html/CanvasStyle.h: |
| 1884 | * platform/graphics/GeneratedImage.h: |
| 1885 | (WebCore::GeneratedImage::GeneratedImage): |
| 1886 | * platform/graphics/Generator.h: |
| 1887 | * platform/graphics/Gradient.h: |
| 1888 | (WebCore::Gradient::create): |
| 1889 | * platform/graphics/GraphicsContext.cpp: |
| 1890 | (WebCore::GraphicsContext::fillRule): |
| 1891 | (WebCore::GraphicsContext::setFillRule): |
| 1892 | (WebCore::GraphicsContext::setStrokePattern): |
| 1893 | (WebCore::GraphicsContext::setFillPattern): |
| 1894 | (WebCore::GraphicsContext::setStrokeGradient): |
| 1895 | (WebCore::GraphicsContext::setFillGradient): |
| 1896 | * platform/graphics/GraphicsContext.h: |
| 1897 | * platform/graphics/GraphicsContextPrivate.h: |
| 1898 | (WebCore::): |
| 1899 | (WebCore::GraphicsContextState::GraphicsContextState): |
| 1900 | * platform/graphics/GraphicsTypes.h: |
| 1901 | * platform/graphics/Path.h: |
| 1902 | * platform/graphics/Pattern.h: |
| 1903 | (WebCore::Pattern::create): |
| 1904 | (WebCore::Pattern::tileImage): |
| 1905 | * platform/graphics/cg/GraphicsContextCG.cpp: |
| 1906 | (WebCore::GraphicsContext::drawRect): |
| 1907 | (WebCore::GraphicsContext::drawEllipse): |
| 1908 | (WebCore::GraphicsContext::drawConvexPolygon): |
| 1909 | (WebCore::calculateDrawingMode): |
| 1910 | (WebCore::GraphicsContext::drawPath): |
| 1911 | (WebCore::fillPathWithFillRule): |
| 1912 | (WebCore::GraphicsContext::fillPath): |
| 1913 | (WebCore::GraphicsContext::strokePath): |
| 1914 | (WebCore::GraphicsContext::fillRect): |
| 1915 | (WebCore::GraphicsContext::fillRoundedRect): |
| 1916 | (WebCore::GraphicsContext::setPlatformStrokePattern): |
| 1917 | (WebCore::GraphicsContext::setPlatformFillPattern): |
| 1918 | (WebCore::GraphicsContext::setPlatformStrokeGradient): |
| 1919 | (WebCore::GraphicsContext::setPlatformFillGradient): |
| 1920 | |
eric@webkit.org | 70b099f | 2008-08-28 11:42:26 +0000 | [diff] [blame] | 1921 | 2008-08-20 Eric Seidel <eric@webkit.org> |
| 1922 | |
| 1923 | Reviewed by Darin and Alexey. |
| 1924 | |
| 1925 | Close a leak of PausedTimeouts if the JavaScriptDebugServer was destroyed |
| 1926 | with timeouts paused. |
| 1927 | https://bugs.webkit.org/show_bug.cgi?id=20469 |
| 1928 | |
| 1929 | I attempted to clean up the memory management of PausedTimeouts, I'm not |
| 1930 | sure the solution I came up with is "cleaner", but it's in some ways |
| 1931 | "safer", since it no longer uses raw pointers and manual new/delete. |
| 1932 | |
| 1933 | This also now prevents CachedPage from needlessly creating Window |
| 1934 | objects when caching pages which didn't already have one. :) |
| 1935 | |
| 1936 | I also made Chrome.cpp no longer depend on the JavaScript bindings |
| 1937 | (aka JSDOMWindowBase.h), since there was no real reason for it to. |
| 1938 | |
| 1939 | * bindings/js/JSDOMWindowBase.cpp: |
| 1940 | (WebCore::JSDOMWindowBase::pauseTimeouts): |
| 1941 | (WebCore::JSDOMWindowBase::resumeTimeouts): |
| 1942 | * bindings/js/JSDOMWindowBase.h: |
| 1943 | * bindings/js/ScriptController.cpp: |
| 1944 | (WebCore::ScriptController::pauseTimeouts): |
| 1945 | (WebCore::ScriptController::resumeTimeouts): |
| 1946 | * bindings/js/ScriptController.h: |
| 1947 | * history/CachedPage.cpp: |
| 1948 | (WebCore::CachedPage::CachedPage): |
| 1949 | (WebCore::CachedPage::restore): |
| 1950 | * page/Chrome.cpp: |
| 1951 | (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): |
| 1952 | (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): |
| 1953 | * page/JavaScriptDebugServer.cpp: |
| 1954 | (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer): |
| 1955 | (WebCore::JavaScriptDebugServer::setJavaScriptPaused): |
| 1956 | |
zecke@webkit.org | 7d0df9e | 2008-08-28 03:36:31 +0000 | [diff] [blame] | 1957 | 2008-08-27 Holger Hans Peter Freyther <zecke@selfish.org> |
| 1958 | |
| 1959 | Unreviewed compile fix |
| 1960 | |
| 1961 | Add the stub for the Qt port. |
| 1962 | |
| 1963 | * WebCore.pro: |
| 1964 | * page/qt/AccessibilityObjectQt.cpp: Added. |
| 1965 | (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): |
| 1966 | |
zecke@webkit.org | ed5c2fe | 2008-08-28 02:15:20 +0000 | [diff] [blame] | 1967 | 2008-08-27 Alp Toker <alp@nuanti.com> |
| 1968 | |
| 1969 | Reviewed by Eric. |
| 1970 | |
| 1971 | https://bugs.webkit.org/show_bug.cgi?id=20551 |
zecke@webkit.org | 8154088 | 2008-08-28 02:18:20 +0000 | [diff] [blame] | 1972 | [GTK] search popup crash |
| 1973 | |
| 1974 | * platform/gtk/SearchPopupMenuGtk.cpp: |
| 1975 | (WebCore::SearchPopupMenu::enabled): |
| 1976 | Fix a search popup crasher by disabling the history popup since we |
| 1977 | don't support this feature yet in the GTK+ port. |
| 1978 | |
| 1979 | 2008-08-27 Alp Toker <alp@nuanti.com> |
| 1980 | |
| 1981 | Reviewed by Eric. |
| 1982 | |
| 1983 | https://bugs.webkit.org/show_bug.cgi?id=20551 |
zecke@webkit.org | ed5c2fe | 2008-08-28 02:15:20 +0000 | [diff] [blame] | 1984 | [GTK] curl crashers |
| 1985 | |
| 1986 | * platform/network/curl/ResourceHandleManager.cpp: |
| 1987 | (WebCore::ResourceHandleManager::startScheduledJobs): |
| 1988 | Remove the resource handle from the pending list before starting the |
| 1989 | job, not afterwards. Fixes crashers in the test suite. |
| 1990 | |
| 1991 | Test: fast/dom/clientWidthAfterDocumentIsRemoved.html |
| 1992 | Test: fast/encoding/char-encoding.html |
| 1993 | |
eric@webkit.org | 712cb89 | 2008-08-28 00:26:15 +0000 | [diff] [blame] | 1994 | 2008-08-27 Dirk Schulze <vbs85@gmx.de> |
| 1995 | |
| 1996 | Reviewed by eseidel. |
| 1997 | |
| 1998 | Fix canvas drawImage to support composite operations. |
| 1999 | Composite had no effect on canvas elements like these: |
| 2000 | http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html |
| 2001 | |
| 2002 | [CAIRO] Canvas composite don't work on canvas-elements. |
| 2003 | https://bugs.webkit.org/show_bug.cgi?id=20548 |
| 2004 | |
| 2005 | * html/CanvasRenderingContext2D.cpp: |
| 2006 | (WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call |
| 2007 | |
eric@webkit.org | 75c83a0 | 2008-08-28 00:04:59 +0000 | [diff] [blame] | 2008 | 2008-08-27 Mario Bensi <mbensi@pleyo.com> |
| 2009 | |
| 2010 | Reviewed by Eric Seidel. |
| 2011 | |
| 2012 | Fix the data content of an image with a base64. |
| 2013 | |
| 2014 | * platform/network/curl/ResourceHandleManager.cpp: |
| 2015 | (WebCore::parseDataUrl): Remove the String and use only the data |
| 2016 | Vector because the data.latin1().data() convert the data content and |
| 2017 | the image test ( https://bugs.webkit.org/attachment.cgi?id=21726 ) is |
| 2018 | not drawn correctly. |
| 2019 | |
antti@apple.com | f66a86b | 2008-08-27 23:59:50 +0000 | [diff] [blame] | 2020 | 2008-08-27 Antti Koivisto <antti@apple.com> |
| 2021 | |
| 2022 | Reviewed by Eric Seidel. |
| 2023 | |
| 2024 | Crash after OK in dialog box and reloading page in secure mode |
| 2025 | https://bugs.webkit.org/show_bug.cgi?id=20493 |
| 2026 | |
| 2027 | The new run loop spawned by a modal dialog causes a timer in the loader to run |
| 2028 | synchronously inside didFinishLoading() deleting "this" object. |
| 2029 | |
| 2030 | Defer all WebCore timers when a modal dialog is up. They are not |
| 2031 | safe to execute. |
| 2032 | |
| 2033 | * page/Chrome.cpp: |
| 2034 | (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): |
| 2035 | (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): |
| 2036 | |
simon.fraser@apple.com | 7dbde25 | 2008-08-27 23:16:36 +0000 | [diff] [blame] | 2037 | 2008-08-27 Chris Marrin <cmarrin@apple.com> |
| 2038 | |
| 2039 | Reviewed by Dave Hyatt |
| 2040 | |
| 2041 | Memory leaks when animating transforms |
| 2042 | https://bugs.webkit.org/show_bug.cgi?id=20532 |
| 2043 | |
| 2044 | * rendering/style/RenderStyle.cpp: |
| 2045 | (WebCore::ScaleTransformOperation::blend): |
| 2046 | (WebCore::RotateTransformOperation::blend): |
| 2047 | (WebCore::SkewTransformOperation::blend): |
| 2048 | (WebCore::TranslateTransformOperation::blend): |
| 2049 | (WebCore::MatrixTransformOperation::blend): |
| 2050 | * rendering/style/RenderStyle.h: |
| 2051 | |
timothy@apple.com | 79cb13a | 2008-08-27 22:03:24 +0000 | [diff] [blame] | 2052 | 2008-08-27 Timothy Hatcher <timothy@apple.com> |
| 2053 | |
| 2054 | Add support for support for -webkit-appearance: default-button on the Mac platform. |
| 2055 | |
| 2056 | <rdar://problem/6173530> |
| 2057 | |
| 2058 | Reviewed by Dave Hyatt. |
| 2059 | |
| 2060 | * WebCore.base.exp: Export new symbols. |
| 2061 | * platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation. |
| 2062 | * platform/mac/WebCoreSystemInterface.mm: Ditto. |
| 2063 | * rendering/RenderButton.cpp: |
| 2064 | (WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN). |
| 2065 | (WebCore::RenderButton::setStyle): Ditto. |
| 2066 | * rendering/RenderButton.h: Ditto. |
| 2067 | * rendering/RenderThemeMac.mm: |
| 2068 | (WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance. |
| 2069 | (WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return |
| 2070 | key if the button is default, otherwise reset the key equivalent. |
| 2071 | (WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell: |
| 2072 | on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore |
| 2073 | the window's previous default button cell when finished. |
| 2074 | |
hyatt@apple.com | f0ec84d | 2008-08-27 21:18:15 +0000 | [diff] [blame] | 2075 | 2008-08-26 David Hyatt <hyatt@apple.com> |
| 2076 | |
| 2077 | First cut at making form controls on OS X respect full page zoom. There are lots of bugs. |
| 2078 | |
| 2079 | Reviewed by weinig |
| 2080 | |
| 2081 | Added fast/forms/zoomed-controls.html |
| 2082 | |
| 2083 | * css/CSSStyleSelector.cpp: |
| 2084 | (WebCore::addIntrinsicMargins): |
| 2085 | * rendering/RenderSlider.cpp: |
| 2086 | (WebCore::RenderSlider::calcPrefWidths): |
| 2087 | * rendering/RenderThemeMac.h: |
| 2088 | * rendering/RenderThemeMac.mm: |
| 2089 | (WebCore::RenderThemeMac::adjustRepaintRect): |
| 2090 | (WebCore::RenderThemeMac::inflateRect): |
| 2091 | (WebCore::RenderThemeMac::baselinePosition): |
| 2092 | (WebCore::RenderThemeMac::setControlSize): |
| 2093 | (WebCore::RenderThemeMac::sizeForFont): |
| 2094 | (WebCore::RenderThemeMac::sizeForSystemFont): |
| 2095 | (WebCore::RenderThemeMac::setFontFromControlSize): |
| 2096 | (WebCore::RenderThemeMac::paintCheckbox): |
| 2097 | (WebCore::RenderThemeMac::setCheckboxCellState): |
| 2098 | (WebCore::RenderThemeMac::paintRadio): |
| 2099 | (WebCore::RenderThemeMac::setRadioCellState): |
| 2100 | (WebCore::RenderThemeMac::setButtonPaddingFromControlSize): |
| 2101 | (WebCore::RenderThemeMac::adjustButtonStyle): |
| 2102 | (WebCore::RenderThemeMac::setButtonCellState): |
| 2103 | (WebCore::RenderThemeMac::paintButton): |
| 2104 | (WebCore::RenderThemeMac::paintMenuList): |
| 2105 | (WebCore::RenderThemeMac::paintMenuListButton): |
| 2106 | (WebCore::RenderThemeMac::popupInternalPaddingLeft): |
| 2107 | (WebCore::RenderThemeMac::popupInternalPaddingRight): |
| 2108 | (WebCore::RenderThemeMac::popupInternalPaddingTop): |
| 2109 | (WebCore::RenderThemeMac::popupInternalPaddingBottom): |
| 2110 | (WebCore::RenderThemeMac::setPopupButtonCellState): |
| 2111 | (WebCore::RenderThemeMac::paintSliderTrack): |
| 2112 | (WebCore::RenderThemeMac::paintSliderThumb): |
| 2113 | (WebCore::RenderThemeMac::adjustSliderThumbSize): |
| 2114 | (WebCore::RenderThemeMac::paintSearchField): |
| 2115 | (WebCore::RenderThemeMac::adjustSearchFieldStyle): |
| 2116 | (WebCore::RenderThemeMac::paintSearchFieldCancelButton): |
| 2117 | (WebCore::RenderThemeMac::paintSearchFieldResultsButton): |
| 2118 | |
beidson@apple.com | d079387 | 2008-08-27 19:59:55 +0000 | [diff] [blame] | 2119 | 2008-08-27 Brady Eidson <beidson@apple.com> |
| 2120 | |
| 2121 | Reviewed by Anders |
| 2122 | |
| 2123 | <rdar://problem/6134133> - Crash when loading large movie as a standalone document |
| 2124 | |
| 2125 | We hand off these loads to Quicktime which manages and spools the data itself, but we also continued |
| 2126 | to load and buffer the data for the movie in WebCore. With large media files, this results in blowing |
| 2127 | away the virtual address space and a crash. |
| 2128 | |
| 2129 | * loader/EmptyClients.h: |
| 2130 | (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError): |
| 2131 | * loader/FrameLoaderClient.h: Added client method to get platform specific error for |
| 2132 | "plugin will handle load" |
| 2133 | |
| 2134 | * loader/MediaDocument.cpp: |
| 2135 | (WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data, |
| 2136 | and cancel the WebCore-managed load |
| 2137 | (WebCore::MediaTokenizer::writeRawData): |
| 2138 | (WebCore::MediaTokenizer::finish): |
| 2139 | |
simon.fraser@apple.com | e74d671 | 2008-08-27 18:19:55 +0000 | [diff] [blame] | 2140 | 2008-08-26 Simon Fraser <simon.fraser@apple.com> |
| 2141 | |
| 2142 | Reviewed by Eric Seidel |
| 2143 | |
| 2144 | Linear timing functions should have control points 0, 0, 1, 1. |
| 2145 | https://bugs.webkit.org/show_bug.cgi?id=20535 |
| 2146 | |
| 2147 | * css/CSSStyleSelector.cpp: |
| 2148 | (WebCore::CSSStyleSelector::mapAnimationTimingFunction): |
| 2149 | * rendering/style/RenderStyle.h: |
| 2150 | |
aroben@apple.com | 8cfb6c6 | 2008-08-27 14:52:17 +0000 | [diff] [blame] | 2151 | 2008-08-27 Adam Roben <aroben@apple.com> |
| 2152 | |
| 2153 | Windows build fix |
| 2154 | |
| 2155 | * WebCore.vcproj/WebCore.vcproj: Fix file extension. |
| 2156 | |
mrowe@apple.com | 37686d4 | 2008-09-04 00:10:39 +0000 | [diff] [blame] | 2157 | 2008-08-26 Chris Fleizach <cfleizach@apple.com> |
cfleizach@apple.com | 33a556b | 2008-08-26 22:29:14 +0000 | [diff] [blame] | 2158 | |
cfleizach@apple.com | c6ebe3d | 2008-08-26 22:43:22 +0000 | [diff] [blame] | 2159 | Reviewed by Beth Dakin. |
| 2160 | |
cfleizach@apple.com | 2a505f4 | 2008-08-26 22:56:03 +0000 | [diff] [blame] | 2161 | <rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown |
| 2162 | |
| 2163 | Added platform-specific accessibilityIgnoreAttachment, which allows the platform |
| 2164 | to determine if an attachment is ignored through accessibility. Added equivalent |
| 2165 | methods in Gtk, Win and Mac |
| 2166 | |
| 2167 | Test: accessibility/plugin.html |
| 2168 | |
| 2169 | * GNUmakefile.am: |
| 2170 | * WebCore.vcproj/WebCore.vcproj: |
| 2171 | * WebCore.xcodeproj/project.pbxproj: |
| 2172 | * page/AccessibilityObject.h: |
| 2173 | * page/AccessibilityRenderObject.cpp: |
| 2174 | (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): |
| 2175 | * page/gtk/AccessibilityObjectAtk.cpp: Added. |
| 2176 | (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): |
| 2177 | * page/mac/AccessibilityObjectMac.mm: Added. |
| 2178 | (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): |
| 2179 | * page/mac/AccessibilityObjectWrapper.h: |
| 2180 | * page/win/AccessibilityObjectWin.cpp: Added. |
| 2181 | (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): |
| 2182 | |
mrowe@apple.com | 37686d4 | 2008-09-04 00:10:39 +0000 | [diff] [blame] | 2183 | 2008-08-26 Chris Fleizach <cfleizach@apple.com> |
cfleizach@apple.com | 2a505f4 | 2008-08-26 22:56:03 +0000 | [diff] [blame] | 2184 | |
| 2185 | Reviewed by Beth Dakin. |
| 2186 | |
cfleizach@apple.com | c6ebe3d | 2008-08-26 22:43:22 +0000 | [diff] [blame] | 2187 | <rdar://problem/5817770> can't bring up contextual menu for embedded objects in WebText |
| 2188 | |
| 2189 | * page/mac/AccessibilityObjectWrapper.mm: |
| 2190 | (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]): |
| 2191 | (-[AccessibilityObjectWrapper accessibilityShowContextMenu]): |
| 2192 | |
mrowe@apple.com | 37686d4 | 2008-09-04 00:10:39 +0000 | [diff] [blame] | 2193 | 2008-08-26 Chris Fleizach <cfleizach@apple.com> |
cfleizach@apple.com | c6ebe3d | 2008-08-26 22:43:22 +0000 | [diff] [blame] | 2194 | |
cfleizach@apple.com | 33a556b | 2008-08-26 22:29:14 +0000 | [diff] [blame] | 2195 | Reviewed by Darin Adler. |
| 2196 | |
| 2197 | <rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns |
| 2198 | |
| 2199 | Tests: accessibility/table-notbody.html |
| 2200 | |
| 2201 | * page/AccessibilityTable.cpp: |
| 2202 | (WebCore::AccessibilityTable::isTableExposableThroughAccessibility): |
| 2203 | |
weinig@apple.com | 3370585 | 2008-08-26 19:51:28 +0000 | [diff] [blame] | 2204 | 2008-08-26 Sam Weinig <sam@webkit.org> |
| 2205 | |
weinig@apple.com | f6f553a | 2008-08-26 21:21:26 +0000 | [diff] [blame] | 2206 | Reviewed by Beth Dakin. |
| 2207 | |
| 2208 | Fix typo. |
| 2209 | |
| 2210 | * dom/DOMCoreException.h: |
| 2211 | |
| 2212 | 2008-08-26 Sam Weinig <sam@webkit.org> |
| 2213 | |
weinig@apple.com | 0f34f00 | 2008-08-26 19:56:54 +0000 | [diff] [blame] | 2214 | Reviewed by Oliver Hunt. |
| 2215 | |
| 2216 | Fix https://bugs.webkit.org/show_bug.cgi?id=20479 |
| 2217 | <rdar://problem/6167660> |
| 2218 | Take image redirects into account when tainting the canvas. |
| 2219 | |
| 2220 | Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html |
| 2221 | |
| 2222 | * html/CanvasRenderingContext2D.cpp: |
| 2223 | (WebCore::CanvasRenderingContext2D::drawImage): |
| 2224 | (WebCore::CanvasRenderingContext2D::drawImageFromRect): |
| 2225 | |
| 2226 | 2008-08-26 Sam Weinig <sam@webkit.org> |
| 2227 | |
weinig@apple.com | 3370585 | 2008-08-26 19:51:28 +0000 | [diff] [blame] | 2228 | Reviewed by Darin Adler. |
| 2229 | |
| 2230 | Change canvas tainting logic to ask the image if it contains |
| 2231 | any resources outside of its own origin. Since there is no |
| 2232 | way to determine if SVG images contain any resources outside its |
| 2233 | origin, we always assume it does. |
| 2234 | |
| 2235 | * html/CanvasRenderingContext2D.cpp: |
| 2236 | (WebCore::CanvasRenderingContext2D::drawImage): |
| 2237 | (WebCore::CanvasRenderingContext2D::drawImageFromRect): |
| 2238 | * platform/graphics/BitmapImage.h: |
| 2239 | (WebCore::BitmapImage::hasSingleSecurityOrigin): |
| 2240 | * platform/graphics/GeneratedImage.h: |
| 2241 | (WebCore::GeneratedImage::hasSingleSecurityOrigin): |
| 2242 | * platform/graphics/Image.h: |
| 2243 | (WebCore::Image::hasSingleSecurityOrigin): |
| 2244 | * platform/graphics/cg/PDFDocumentImage.h: |
| 2245 | (WebCore::PDFDocumentImage::hasSingleSecurityOrigin): |
| 2246 | * svg/graphics/SVGImage.h: |
| 2247 | |
britto@apple.com | 616ef6d | 2008-08-26 17:51:03 +0000 | [diff] [blame] | 2248 | 2008-08-26 Maxime Britto <britto@apple.com> |
| 2249 | |
| 2250 | Reviewed by Adele. |
| 2251 | |
| 2252 | <rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com) |
| 2253 | This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area. |
| 2254 | This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls. |
| 2255 | |
| 2256 | * page/EventHandler.cpp: |
| 2257 | (WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning |
| 2258 | * page/EventHandler.h: |
| 2259 | * rendering/RenderLayer.cpp: |
| 2260 | (WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta |
| 2261 | (WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so. |
| 2262 | * rendering/RenderLayer.h: |
| 2263 | * rendering/RenderObject.cpp: |
| 2264 | (WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled |
| 2265 | (WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method |
| 2266 | (WebCore::RenderObject::panScroll): No need to check for the layer anymore too. |
| 2267 | |
jchaffraix@webkit.org | e691539 | 2008-08-26 10:27:33 +0000 | [diff] [blame] | 2268 | 2008-08-25 Julien Chaffraix <jchaffraix@webkit.org> |
| 2269 | |
darin@apple.com | 07c80c6 | 2008-09-05 18:15:43 +0000 | [diff] [blame] | 2270 | Reviewed by Darin Adler. |
jchaffraix@webkit.org | e691539 | 2008-08-26 10:27:33 +0000 | [diff] [blame] | 2271 | |
| 2272 | Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it |
| 2273 | https://bugs.webkit.org/show_bug.cgi?id=20247 |
| 2274 | |
| 2275 | <rdar://problem/6118218> |
| 2276 | |
| 2277 | Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive |
| 2278 | check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute |
| 2279 | (case insensitive for HTML elements). |
| 2280 | |
| 2281 | Test: fast/dom/Element/getAttribute-check-case-sensitivity.html |
| 2282 | |
| 2283 | * dom/Element.cpp: |
| 2284 | (WebCore::Element::getAttribute): |
| 2285 | * dom/NamedAttrMap.cpp: |
| 2286 | (WebCore::NamedAttrMap::getNamedItem): |
| 2287 | (WebCore::NamedAttrMap::getAttributeItem): |
| 2288 | * dom/NamedAttrMap.h: |
| 2289 | |
weinig@apple.com | b4ce06e | 2008-08-26 01:52:51 +0000 | [diff] [blame] | 2290 | 2008-08-25 Sam Weinig <sam@webkit.org> |
| 2291 | |
weinig@apple.com | 8d3ea72 | 2008-08-26 04:19:07 +0000 | [diff] [blame] | 2292 | Reviewed by Oliver Hunt. |
| 2293 | |
| 2294 | Fix for https://bugs.webkit.org/show_bug.cgi?id=20514 |
| 2295 | <rdar://problem/6174096> |
| 2296 | Treat SVG images as dirty when drawing to a canvas. |
| 2297 | |
| 2298 | Test: http/tests/security/canvas-remote-read-svg-image.html |
| 2299 | |
| 2300 | * html/CanvasRenderingContext2D.cpp: |
| 2301 | (WebCore::CanvasRenderingContext2D::drawImage): |
| 2302 | (WebCore::CanvasRenderingContext2D::drawImageFromRect): |
| 2303 | * platform/graphics/Image.h: |
| 2304 | (WebCore::Image::isSVGImage): |
| 2305 | * svg/graphics/SVGImage.h: |
| 2306 | (WebCore::SVGImage::isSVGImage): |
| 2307 | |
| 2308 | 2008-08-25 Sam Weinig <sam@webkit.org> |
| 2309 | |
weinig@apple.com | b4ce06e | 2008-08-26 01:52:51 +0000 | [diff] [blame] | 2310 | Reviewed by Mark Rowe. |
| 2311 | |
| 2312 | Fix https://bugs.webkit.org/show_bug.cgi?id=20377 |
| 2313 | Leak in XMLHttpRequest. |
| 2314 | |
| 2315 | * xml/XMLHttpRequest.cpp: |
| 2316 | (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): |
| 2317 | |
beidson@apple.com | 4642121 | 2008-08-25 21:48:56 +0000 | [diff] [blame] | 2318 | 2008-08-25 Brady Eidson <beidson@apple.com> |
| 2319 | |
| 2320 | Reviewed by Anders |
| 2321 | |
| 2322 | Speculative fix for <rdar://problem/6173217> |
| 2323 | |
| 2324 | Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code. |
| 2325 | Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering |
| 2326 | the first null check invalid. |
| 2327 | |
| 2328 | * loader/FrameLoader.cpp: |
| 2329 | (WebCore::FrameLoader::stopAllLoaders): |
| 2330 | |
| 2331 | |
kmccullough@apple.com | 7b85fbb | 2008-08-25 21:28:40 +0000 | [diff] [blame] | 2332 | 2008-08-25 Kevin McCullough <kmccullough@apple.com> |
| 2333 | |
| 2334 | Reviewed by Tim. |
| 2335 | |
| 2336 | <rdar://problem/6157711> Heavy/Tree view selector is not grayed out if |
| 2337 | there is no profile, can cause crash |
| 2338 | |
| 2339 | * page/inspector/ProfilesPanel.js: |
| 2340 | |
dino@apple.com | 1baeea6 | 2008-08-25 21:06:21 +0000 | [diff] [blame] | 2341 | 2008-08-25 Dean Jackson <dino@apple.com> |
| 2342 | |
| 2343 | Reviewed by Dave Hyatt |
| 2344 | |
| 2345 | Make sure 'inherit' is handled by transition property. |
| 2346 | https://bugs.webkit.org/show_bug.cgi?id=20513 |
| 2347 | |
| 2348 | Test: transitions/inherit.html |
| 2349 | Test: transitions/inherit-other-props.html |
| 2350 | |
| 2351 | * css/CSSStyleSelector.cpp: |
| 2352 | fix macro to check existence of list before getting size |
| 2353 | |
andersca@apple.com | 2866b830 | 2008-08-25 20:56:21 +0000 | [diff] [blame] | 2354 | 2008-08-25 Anders Carlsson <andersca@apple.com> |
| 2355 | |
| 2356 | Reviewed by Mark. |
| 2357 | |
| 2358 | <rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37. |
| 2359 | |
| 2360 | Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume |
| 2361 | (safely) that any class that needs finalization on the main thread will also need to be deallocated |
| 2362 | on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of |
| 2363 | calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer. |
| 2364 | |
| 2365 | * platform/mac/WebCoreObjCExtras.c: |
| 2366 | (WebCoreObjCFinalizeOnMainThread): |
| 2367 | |
antti@apple.com | 60381cb | 2008-08-25 20:41:11 +0000 | [diff] [blame] | 2368 | 2008-08-25 Antti Koivisto <antti@apple.com> |
| 2369 | |
| 2370 | Reviewed by Dan Bernstein. |
| 2371 | |
| 2372 | Rename CachedResource::referenced() to CachedResource::hasClients() to |
| 2373 | match previous ref() -> addClient() rename. |
| 2374 | |
| 2375 | * loader/Cache.cpp: |
| 2376 | (WebCore::Cache::pruneLiveResources): |
| 2377 | (WebCore::Cache::pruneDeadResources): |
| 2378 | (WebCore::Cache::remove): |
| 2379 | (WebCore::Cache::getStatistics): |
| 2380 | (WebCore::Cache::dumpLRULists): |
| 2381 | * loader/CachedResource.cpp: |
| 2382 | (WebCore::CachedResource::addClient): |
| 2383 | (WebCore::CachedResource::removeClient): |
| 2384 | (WebCore::CachedResource::setDecodedSize): |
| 2385 | (WebCore::CachedResource::setEncodedSize): |
| 2386 | * loader/CachedResource.h: |
| 2387 | (WebCore::CachedResource::hasClients): |
| 2388 | (WebCore::CachedResource::canDelete): |
| 2389 | |
timothy@apple.com | 7d80924 | 2008-08-25 18:33:05 +0000 | [diff] [blame] | 2390 | 2008-08-25 Anthony Ricaud <rik24d@gmail.com> |
| 2391 | |
| 2392 | Add a missing Inspector localized string for "other". |
| 2393 | |
| 2394 | https://bugs.webkit.org/show_bug.cgi?id=20509 |
| 2395 | |
| 2396 | Reviewed by Tim Hatcher. |
| 2397 | |
| 2398 | * English.lproj/localizedStrings.js: |
| 2399 | |
kmccullough@apple.com | 560f5fe | 2008-08-25 18:18:01 +0000 | [diff] [blame] | 2400 | 2008-08-22 Kevin McCullough <kmccullough@apple.com> |
| 2401 | |
| 2402 | Reviewed by Geoff, Mark and Tim. |
| 2403 | |
| 2404 | <rdar://problem/6150623> JSProfiler: It would be nice if the profiles |
| 2405 | in the console said what file and line number they came from |
| 2406 | - Lay the foundation for getting line numbers and other data from the |
| 2407 | JavaScript engine. |
| 2408 | |
| 2409 | * ForwardingHeaders/VM: Added. |
| 2410 | * ForwardingHeaders/VM/Machine.h: Added. |
| 2411 | * page/Console.cpp: Gather the line number and file information when |
| 2412 | profileEnd has been called, but don't use it until didFinishProfiling is |
| 2413 | called. We won't need to wait once we remove the profiler "zombie" mode |
| 2414 | which this patch helps pave the foundation for. |
| 2415 | (WebCore::Console::Console): |
| 2416 | (WebCore::Console::profileEnd): |
| 2417 | (WebCore::Console::finishedProfiling): |
| 2418 | * page/Console.h: |
| 2419 | * page/InspectorController.cpp: Modify calls to |
| 2420 | addProfileMessageToConsole to satisfy the new arguments it takes. |
| 2421 | (WebCore::InspectorController::finishedProfiling): |
| 2422 | (WebCore::InspectorController::addProfile): |
| 2423 | (WebCore::InspectorController::addProfileMessageToConsole): |
| 2424 | (WebCore::InspectorController::finishedProfiling): |
| 2425 | * page/InspectorController.h: |
| 2426 | |
hausmann@webkit.org | f305df4 | 2008-08-25 10:06:53 +0000 | [diff] [blame] | 2427 | 2008-08-25 Holger Hans Peter Freyther <zecke@selfish.org> |
| 2428 | |
| 2429 | Reviewed by Simon. |
| 2430 | |
| 2431 | [inspector] Update the WebKit.qrc Qt resources file |
| 2432 | Catchup with the changes in the directory. |
| 2433 | |
| 2434 | * page/inspector/WebKit.qrc: |
| 2435 | |
hausmann@webkit.org | 5f13af3 | 2008-08-25 07:10:22 +0000 | [diff] [blame] | 2436 | 2008-08-25 Dirk Schulze <vbs85@gmx.de> |
| 2437 | |
| 2438 | Reviewed by Simon. |
| 2439 | |
| 2440 | Transformed the radian to degree, to get rotate() |
| 2441 | in canvas work as expected. |
| 2442 | |
| 2443 | [Qt] Canvas.rotate() doesn't work |
| 2444 | https://bugs.webkit.org/show_bug.cgi?id=20496 |
| 2445 | |
| 2446 | * platform/graphics/qt/GraphicsContextQt.cpp: |
| 2447 | (WebCore::GraphicsContext::rotate): |
| 2448 | |
sfalken@apple.com | 9d44286 | 2008-08-25 05:43:33 +0000 | [diff] [blame] | 2449 | 2008-08-24 Steve Falkenburg <sfalken@apple.com> |
| 2450 | |
| 2451 | Add a "last chance" WM_TIMER to the Windows shared timer. |
| 2452 | |
| 2453 | The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers. |
| 2454 | Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule |
| 2455 | timers if a timer with an earlier expiration is already pending. This results in no timers |
| 2456 | firing from that point on. |
| 2457 | |
| 2458 | We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a |
| 2459 | buggy window message hook. |
| 2460 | |
| 2461 | This timer will start when the first WM_TIMER is scheduled, and will |
| 2462 | fire every 5 seconds thereafter, causing any lost timers to be fired. |
| 2463 | |
| 2464 | Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling |
| 2465 | and prevents the WebFrame leak. |
| 2466 | |
| 2467 | Reviewed by Darin Adler, Geoff Garen. |
| 2468 | |
| 2469 | * platform/win/SharedTimerWin.cpp: |
| 2470 | (WebCore::): |
| 2471 | (WebCore::TimerWindowWndProc): |
| 2472 | (WebCore::setSharedTimerFireTime): |
| 2473 | |
mitz@apple.com | 771fb75 | 2008-08-25 03:22:44 +0000 | [diff] [blame] | 2474 | 2008-08-24 Dan Bernstein <mitz@apple.com> |
| 2475 | |
| 2476 | Reviewed by Darin Adler. |
| 2477 | |
| 2478 | - fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold |
| 2479 | |
| 2480 | Test: fast/css/font-property-priority.html |
| 2481 | |
| 2482 | * css/CSSParser.cpp: |
| 2483 | (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag |
| 2484 | to the font-property-parsing functions. |
| 2485 | (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and |
| 2486 | changed to use it rather than the m_important member. |
| 2487 | (WebCore::CSSParser::parseFontVariant): Ditto. |
| 2488 | (WebCore::CSSParser::parseFontWeight): Ditto. |
| 2489 | * css/CSSParser.h: |
| 2490 | |
timothy@apple.com | 4cea263 | 2008-08-24 22:28:44 +0000 | [diff] [blame] | 2491 | 2008-08-24 Timothy Hatcher <timothy@apple.com> |
| 2492 | |
| 2493 | Fixes a bug where the Inspector's UI would not animate or |
| 2494 | fully function because JavaScript timeouts, intervals and |
| 2495 | CSS animation timers where not firing while paused at a |
| 2496 | a breakpoint in the inspected page. |
| 2497 | |
| 2498 | https://bugs.webkit.org/show_bug.cgi?id=20042 |
| 2499 | |
| 2500 | Reviewed by Darin Adler. |
| 2501 | |
| 2502 | Test: manual-tests/inspector/forzen-ui-while-paused.html |
| 2503 | |
| 2504 | * page/JavaScriptDebugServer.cpp: |
| 2505 | (WebCore::JavaScriptDebugServer::pauseIfNeeded): |
| 2506 | Add a call to TimerBase::fireTimersInNestedEventLoop before |
| 2507 | spinning the EventLoop. |
| 2508 | |
rwlbuis@webkit.org | 8a77244 | 2008-08-24 18:07:32 +0000 | [diff] [blame] | 2509 | 2008-08-24 Rob Buis <buis@kde.org> |
| 2510 | |
| 2511 | Reviewed by Sam Weinig. |
| 2512 | |
| 2513 | https://bugs.webkit.org/show_bug.cgi?id=20324 |
| 2514 | A change in SVG Glyph wont show up |
| 2515 | |
| 2516 | Invalidate the glyph cache when the d attribute is set. |
| 2517 | |
| 2518 | Test: svg/custom/glyph-setting-d-attribute.svg |
| 2519 | |
| 2520 | * svg/SVGGlyphElement.cpp: |
| 2521 | (WebCore::SVGGlyphElement::invalidateGlyphCache): |
| 2522 | (WebCore::SVGGlyphElement::parseMappedAttribute): |
| 2523 | (WebCore::SVGGlyphElement::insertedIntoDocument): |
| 2524 | (WebCore::SVGGlyphElement::removedFromDocument): |
| 2525 | * svg/SVGGlyphElement.h: |
| 2526 | |
mitz@apple.com | 5b2c3cc | 2008-08-24 09:18:39 +0000 | [diff] [blame] | 2527 | 2008-08-24 Dan Bernstein <mitz@apple.com> |
| 2528 | |
| 2529 | Reviewed by Sam Weinig. |
| 2530 | |
| 2531 | - fix https://bugs.webkit.org/show_bug.cgi?id=13864 |
| 2532 | <rdar://problem/5451470> REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths() |
| 2533 | |
| 2534 | * rendering/RenderText.cpp: |
| 2535 | (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to |
| 2536 | beginWS and endWS before the early return to ensure that they are |
| 2537 | initialized in that case. |
| 2538 | |
cwzwarich@webkit.org | 53ddf17 | 2008-08-23 08:16:54 +0000 | [diff] [blame] | 2539 | 2008-08-23 Cameron Zwarich <cwzwarich@uwaterloo.ca> |
| 2540 | |
| 2541 | Rubber-stamped by Mark Rowe. |
| 2542 | |
| 2543 | Remove modelines. |
| 2544 | |
| 2545 | * WebCore.pro: |
| 2546 | * bridge/testbindings.cpp: |
| 2547 | * dom/DocPtr.h: |
| 2548 | * loader/SubstituteData.h: |
| 2549 | * page/Chrome.cpp: |
| 2550 | * page/Chrome.h: |
| 2551 | * page/ChromeClient.h: |
| 2552 | * page/Frame.h: |
| 2553 | * page/FrameLoadRequest.h: |
| 2554 | * page/FrameTree.cpp: |
| 2555 | * page/FrameTree.h: |
| 2556 | * page/Page.h: |
| 2557 | * page/mac/ChromeMac.mm: |
| 2558 | * platform/network/HTTPHeaderMap.h: |
| 2559 | * platform/network/ResourceErrorBase.cpp: |
| 2560 | * platform/network/ResourceErrorBase.h: |
| 2561 | * platform/network/ResourceHandleInternal.h: |
| 2562 | * platform/network/ResourceRequestBase.cpp: |
| 2563 | * platform/network/ResourceRequestBase.h: |
| 2564 | * platform/network/ResourceResponseBase.cpp: |
| 2565 | * platform/network/ResourceResponseBase.h: |
| 2566 | * platform/network/cf/ResourceError.h: |
| 2567 | * platform/network/cf/ResourceRequest.h: |
| 2568 | * platform/network/cf/ResourceRequestCFNet.h: |
| 2569 | * platform/network/cf/ResourceResponse.h: |
| 2570 | * platform/network/cf/ResourceResponseCFNet.h: |
| 2571 | * platform/network/curl/ResourceError.h: |
| 2572 | * platform/network/curl/ResourceRequest.h: |
| 2573 | * platform/network/curl/ResourceResponse.h: |
| 2574 | * platform/network/mac/ResourceError.h: |
| 2575 | * platform/network/mac/ResourceErrorMac.mm: |
| 2576 | * platform/network/mac/ResourceRequest.h: |
| 2577 | * platform/network/mac/ResourceRequestMac.mm: |
| 2578 | * platform/network/mac/ResourceResponse.h: |
| 2579 | * platform/network/mac/ResourceResponseMac.mm: |
| 2580 | * platform/network/qt/ResourceError.h: |
| 2581 | * platform/network/qt/ResourceRequest.h: |
| 2582 | * platform/network/qt/ResourceResponse.h: |
| 2583 | * platform/network/soup/CookieJarSoup.cpp: |
| 2584 | * platform/network/soup/ResourceError.h: |
| 2585 | * platform/network/soup/ResourceRequest.h: |
| 2586 | * platform/network/soup/ResourceResponse.h: |
| 2587 | |
mitz@apple.com | 57a2f48 | 2008-08-23 07:16:41 +0000 | [diff] [blame] | 2588 | 2008-08-23 Dan Bernstein <mitz@apple.com> |
| 2589 | |
| 2590 | Reviewed by Dave Hyatt. |
| 2591 | |
| 2592 | - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline |
| 2593 | |
| 2594 | Test: fast/table/vertical-align-baseline.html |
| 2595 | |
| 2596 | * rendering/RenderTable.cpp: |
| 2597 | (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the |
| 2598 | baseline of the first table row, if there is one, -1 otherwise. |
| 2599 | * rendering/RenderTable.h: |
| 2600 | * rendering/RenderTableCell.cpp: |
| 2601 | (WebCore::RenderTableCell::baselinePosition): Changed to follow the |
| 2602 | CSS2.1 definition of the baseline of a table cell. |
| 2603 | * rendering/RenderTableSection.cpp: |
| 2604 | (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns |
| 2605 | the baseline of the first row in the section. |
| 2606 | * rendering/RenderTableSection.h: |
| 2607 | |
jhoneycutt@apple.com | 88af18d | 2008-08-22 23:44:32 +0000 | [diff] [blame] | 2608 | 2008-08-18 Jon Honeycutt <jhoneycutt@apple.com> |
| 2609 | |
| 2610 | Add SPI to make a Windows WebView transparent. |
| 2611 | |
| 2612 | Reviewed by Dan Bernstein. |
| 2613 | |
| 2614 | * platform/graphics/GraphicsContext.h: Add a parameter, hasAlpha, that |
| 2615 | determines whether the created context has an alpha channel. |
| 2616 | * platform/graphics/win/GraphicsContextCGWin.cpp: |
| 2617 | (WebCore::CGContextWithHDC): |
| 2618 | |
timothy@apple.com | b63d117 | 2008-08-22 18:39:42 +0000 | [diff] [blame] | 2619 | 2008-08-22 Timothy Hatcher <timothy@apple.com> |
| 2620 | |
timothy@apple.com | 964022d | 2008-08-22 20:35:20 +0000 | [diff] [blame] | 2621 | Rolls out r35834 because it caused a regression in the Inspector's |
| 2622 | Console where some expressions always threw a syntax error. |
| 2623 | |
| 2624 | https://bugs.webkit.org/show_bug.cgi?id=20487 |
| 2625 | |
| 2626 | * page/inspector/Console.js: |
| 2627 | (Console.prototype._evalInInspectedWindow): Removes parenthesis |
| 2628 | around the expression. |
| 2629 | |
| 2630 | 2008-08-22 Timothy Hatcher <timothy@apple.com> |
| 2631 | |
timothy@apple.com | 056d478 | 2008-08-22 18:39:52 +0000 | [diff] [blame] | 2632 | Makes getStyleProperty return a value for the overflow property |
| 2633 | when overflow-x and overflow-y are equal. |
| 2634 | |
| 2635 | https://bugs.webkit.org/show_bug.cgi?id=20485 |
| 2636 | |
| 2637 | Reviewed by Dan Bernstein. |
| 2638 | |
| 2639 | Test: fast/css/overflow-property.html |
| 2640 | |
| 2641 | * css/CSSMutableStyleDeclaration.cpp: |
| 2642 | (WebCore::CSSMutableStyleDeclaration::getPropertyValue): |
| 2643 | |
| 2644 | 2008-08-22 Timothy Hatcher <timothy@apple.com> |
| 2645 | |
timothy@apple.com | b63d117 | 2008-08-22 18:39:42 +0000 | [diff] [blame] | 2646 | Fixes a bug where while editing in the Inspector the |
| 2647 | sidebar scroll position would jump to the top. |
| 2648 | |
| 2649 | https://bugs.webkit.org/show_bug.cgi?id=20484 |
| 2650 | |
| 2651 | Reviewed by Darin Adler. |
| 2652 | |
| 2653 | * page/inspector/treeoutline.js: |
| 2654 | (TreeOutline._removeChildren): Remove the offsetTop call that |
| 2655 | was forcing a layout, since layout causes scroll positions |
| 2656 | to be clamped to the new scrollHeight/Width. Layout will happen |
| 2657 | normally when needed. |
| 2658 | |
kevino@webkit.org | 8271c84 | 2008-08-22 16:25:52 +0000 | [diff] [blame] | 2659 | 2008-08-22 Kevin Ollivier <kevino@theolliviers.com> |
| 2660 | |
| 2661 | wx build fix. Add AccessibilityTable sources. |
| 2662 | |
| 2663 | * WebCoreSources.bkl: |
| 2664 | |
mitz@apple.com | 9befc87 | 2008-08-22 06:29:33 +0000 | [diff] [blame] | 2665 | 2008-08-21 Dan Bernstein <mitz@apple.com> |
| 2666 | |
| 2667 | Reviewed by Jon Honeycutt and Alexey Proskuryakov. |
| 2668 | |
| 2669 | - fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics |
| 2670 | |
| 2671 | Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html |
| 2672 | |
| 2673 | * platform/graphics/mac/SimpleFontDataMac.mm: |
| 2674 | (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported |
| 2675 | ascent and 100% to its reported descent. |
| 2676 | |
mrowe@apple.com | ac9b6a5 | 2008-08-22 02:07:54 +0000 | [diff] [blame] | 2677 | 2008-08-21 Kalle Vahlman <kalle.vahlman@movial.com> |
| 2678 | |
| 2679 | Reviewed by Darin Adler. |
| 2680 | |
mrowe@apple.com | 22eaa17 | 2008-08-22 02:10:15 +0000 | [diff] [blame] | 2681 | https://bugs.webkit.org/show_bug.cgi?id=20267 |
mrowe@apple.com | ac9b6a5 | 2008-08-22 02:07:54 +0000 | [diff] [blame] | 2682 | [GTK] Crash on some pages due to a plugin |
| 2683 | |
| 2684 | Fix handling of badly formatted and empty plugin mime descriptions |
| 2685 | |
| 2686 | * plugins/gtk/PluginPackageGtk.cpp: |
| 2687 | (WebCore::PluginPackage::fetchInfo): |
| 2688 | |
mrowe@apple.com | 798b343 | 2008-08-22 02:07:48 +0000 | [diff] [blame] | 2689 | 2008-08-21 Kevin Watters <kevinwatters@gmail.com> |
| 2690 | |
| 2691 | Reviewed by Darin Adler. |
| 2692 | |
| 2693 | Follow other ports (and IE) in ImageSourceWx.cpp never to return an |
| 2694 | animated GIF frame duration of less than 50ms. |
| 2695 | |
| 2696 | * platform/graphics/wx/ImageSourceWx.cpp: |
| 2697 | (WebCore::ImageSource::frameDurationAtIndex): |
| 2698 | |
britto@apple.com | 8ed7277 | 2008-08-22 00:39:39 +0000 | [diff] [blame] | 2699 | 2008-08-21 Maxime Britto <britto@apple.com> |
| 2700 | |
| 2701 | Reviewed by Kevin McCullough. |
| 2702 | |
| 2703 | Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html |
| 2704 | https://bugs.webkit.org/show_bug.cgi?id=20451 |
| 2705 | |
| 2706 | rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451) |
| 2707 | When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe. |
| 2708 | This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't. |
| 2709 | |
| 2710 | * page/EventHandler.cpp: |
| 2711 | (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists. |
| 2712 | |
| 2713 | (WebCore::EventHandler::handleMousePressEvent): ditto |
| 2714 | |
timothy@apple.com | 5d49219 | 2008-08-21 23:54:01 +0000 | [diff] [blame] | 2715 | 2008-08-21 Anthony Ricaud <rik24d@gmail.com> |
| 2716 | |
| 2717 | Small optimization for when the dividers in the Inspector's |
| 2718 | Resources panel are updated. |
| 2719 | |
| 2720 | Reviewed by Tim Hatcher. |
| 2721 | |
| 2722 | * page/inspector/ResourcesPanel.js: |
| 2723 | (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): |
| 2724 | Combind a for loop and clone the divider element. |
| 2725 | |
dino@apple.com | aa75e4c | 2008-08-21 23:35:23 +0000 | [diff] [blame] | 2726 | 2008-08-21 Chris Marrin <cmarrin@apple.com> |
| 2727 | |
| 2728 | Allow 0 (without units) for Time eg. duration |
| 2729 | Fix for https://bugs.webkit.org/show_bug.cgi?id=20467 |
| 2730 | |
| 2731 | Reviewed by Dave Hyatt. |
| 2732 | |
| 2733 | Test: css1/units/zero-duration-without-units.html |
| 2734 | |
| 2735 | * css/CSSParser.cpp: |
| 2736 | (WebCore::CSSParser::validUnit): |
| 2737 | |
timothy@apple.com | 29c12d0 | 2008-08-21 20:12:47 +0000 | [diff] [blame] | 2738 | 2008-08-21 Timothy Hatcher <timothy@apple.com> |
| 2739 | |
timothy@apple.com | ca11cd8 | 2008-08-21 20:13:12 +0000 | [diff] [blame] | 2740 | Make deleting all text while editing a DOM attribute in |
| 2741 | the Inspector delete the attribute. This also fixes |
| 2742 | an exception that would happen before. |
| 2743 | |
| 2744 | https://bugs.webkit.org/show_bug.cgi?id=20472 |
| 2745 | |
| 2746 | Reviewed by Kevin McCullough. |
| 2747 | |
| 2748 | * page/inspector/ElementsPanel.js: |
| 2749 | (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted): |
| 2750 | Don't check for hasAttributes on the parseElement, continuing |
| 2751 | through the function will correctly remove the attribute. |
| 2752 | If the parseElement is null, call _editingCancelled not |
| 2753 | editingCancelled, this fixes an exception. |
| 2754 | |
| 2755 | 2008-08-21 Timothy Hatcher <timothy@apple.com> |
| 2756 | |
timothy@apple.com | de831cf | 2008-08-21 20:12:59 +0000 | [diff] [blame] | 2757 | Update the Inspector's Metrics pane when editing in |
| 2758 | the Styles pane. This makes sure the metrics shown |
| 2759 | always match what the Styles pane shows. |
| 2760 | |
| 2761 | https://bugs.webkit.org/show_bug.cgi?id=20470 |
| 2762 | |
| 2763 | Reviewed by Kevin McCullough. |
| 2764 | |
| 2765 | * page/inspector/ElementsPanel.js: |
| 2766 | (WebInspector.ElementsPanel): Add event listeners for |
| 2767 | the "style edited" and "style property toggled" events, |
| 2768 | so the Metrics pane is updated. |
| 2769 | (WebInspector.ElementsPanel.prototype._stylesPaneEdited): |
| 2770 | Update the Metrics pane. |
| 2771 | * page/inspector/StylesSidebarPane.js: |
| 2772 | (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled): |
| 2773 | Dispatch the "style property toggled" event. |
| 2774 | (WebInspector.StylePropertyTreeElement.prototype.editingCancelled): |
| 2775 | Dispatch the "style edited" event when the CSS text is restored. |
| 2776 | (WebInspector.StylePropertyTreeElement.prototype.applyStyleText): |
| 2777 | Dispatch the "style edited" event. |
| 2778 | |
| 2779 | 2008-08-21 Timothy Hatcher <timothy@apple.com> |
| 2780 | |
timothy@apple.com | 29c12d0 | 2008-08-21 20:12:47 +0000 | [diff] [blame] | 2781 | Make the Inspector's Metrics sidebar pane editable. |
| 2782 | |
| 2783 | https://bugs.webkit.org/show_bug.cgi?id=17218 |
| 2784 | rdar://problem/5732818 |
| 2785 | |
| 2786 | Reviewed by Kevin McCullough. |
| 2787 | |
| 2788 | * page/inspector/ElementsPanel.js: |
| 2789 | (WebInspector.ElementsPanel): Add an event listener for |
| 2790 | the "metrics edited" event, so the Styles pane is updated. |
| 2791 | * page/inspector/MetricsSidebarPane.js: |
| 2792 | (WebInspector.MetricsSidebarPane.prototype.update): Remember the node |
| 2793 | so future updates work. Add a double click event listener for the |
| 2794 | metric values to start editing. |
| 2795 | (WebInspector.MetricsSidebarPane.prototype.startEditing): |
| 2796 | Call WebInspector.startEditing with some context. |
| 2797 | (WebInspector.MetricsSidebarPane.prototype.editingCancelled): |
| 2798 | (WebInspector.MetricsSidebarPane.prototype.editingCommitted): |
| 2799 | Set the user input on the elements inline style. Fire the |
| 2800 | "metrics edited" event. |
| 2801 | |
sfalken@apple.com | 7e6e539 | 2008-08-21 18:42:44 +0000 | [diff] [blame] | 2802 | 2008-08-21 Steve Falkenburg <sfalken@apple.com> |
| 2803 | |
| 2804 | Fix a race condition in Windows timer code. |
| 2805 | Timer function could end up being called with a 0 timer, leading to a Windows exception. |
| 2806 | |
| 2807 | Don't post a timer message if one is already pending. |
| 2808 | |
| 2809 | Reviewed by Ada Chan. |
| 2810 | |
| 2811 | * platform/win/SharedTimerWin.cpp: |
| 2812 | (WebCore::TimerWindowWndProc): |
| 2813 | (WebCore::clearTimer): |
| 2814 | (WebCore::queueTimerProc): |
| 2815 | (WebCore::setSharedTimerFireTime): |
| 2816 | |
timothy@apple.com | 8d15bcf | 2008-08-21 16:33:17 +0000 | [diff] [blame] | 2817 | 2008-08-21 Anthony Ricaud <rik24d@gmail.com> |
| 2818 | |
timothy@apple.com | 493212c7 | 2008-08-21 16:36:06 +0000 | [diff] [blame] | 2819 | After trying to add the expression, try again with quotes for |
| 2820 | easier edition. |
| 2821 | |
| 2822 | https://bugs.webkit.org/show_bug.cgi?id=20466 |
| 2823 | |
| 2824 | Reviewed by Tim Hatcher. |
| 2825 | |
| 2826 | * page/inspector/ObjectPropertiesSection.js: Added an |
| 2827 | evaluateExpression function. |
| 2828 | |
| 2829 | 2008-08-21 Anthony Ricaud <rik24d@gmail.com> |
| 2830 | |
timothy@apple.com | 8d15bcf | 2008-08-21 16:33:17 +0000 | [diff] [blame] | 2831 | Perform Inspector searches on search event to clear results when |
| 2832 | clicking the cross to empty it. Delete the lastQuery when the field |
| 2833 | is emptied in order to perform the search if exactly the same query |
| 2834 | is entered next. |
| 2835 | |
| 2836 | https://bugs.webkit.org/show_bug.cgi?id=20462 |
| 2837 | |
| 2838 | Reviewed by Tim Hatcher. |
| 2839 | |
| 2840 | * page/inspector/inspector.js: |
| 2841 | |
jmalonzo@webkit.org | dd47040 | 2008-08-21 11:22:51 +0000 | [diff] [blame] | 2842 | 2008-08-21 Marco Barisione <marco.barisione@collabora.co.uk> |
| 2843 | |
| 2844 | Reviewed by Mark Rowe. |
| 2845 | |
| 2846 | http://bugs.webkit.org/show_bug.cgi?id=19656 |
| 2847 | [SOUP] The gio code should call didFail() instead of |
| 2848 | didFinishLoading() in case of error |
| 2849 | |
| 2850 | In case of error call didFail() instead of didReceiveResponse() and |
| 2851 | didFinishLoading(). |
| 2852 | |
| 2853 | * platform/network/soup/ResourceHandleSoup.cpp: |
| 2854 | (WebCore::networkErrorForFile): |
| 2855 | (WebCore::readCallback): |
| 2856 | (WebCore::openCallback): |
| 2857 | (WebCore::queryInfoCallback): |
| 2858 | |
mrowe@apple.com | 72a95b1 | 2008-08-21 04:01:51 +0000 | [diff] [blame] | 2859 | 2008-08-20 Mark Rowe <mrowe@apple.com> |
| 2860 | |
mrowe@apple.com | 4e593f4 | 2008-08-21 06:52:42 +0000 | [diff] [blame] | 2861 | Reviewed by Jon Honeycutt. |
| 2862 | |
| 2863 | Fix build failure. |
| 2864 | |
| 2865 | * bridge/c/c_instance.cpp: |
| 2866 | (KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned |
| 2867 | as that is what NPEnumerationFunctionPtr is declared as accepting. |
| 2868 | |
| 2869 | 2008-08-20 Mark Rowe <mrowe@apple.com> |
| 2870 | |
mrowe@apple.com | 72a95b1 | 2008-08-21 04:01:51 +0000 | [diff] [blame] | 2871 | Reviewed by Dan Bernstein. |
| 2872 | |
| 2873 | Build fix. Handle kCGInterpolationMedium in switch statements if it is available. |
| 2874 | |
| 2875 | * platform/graphics/GraphicsContext.h: |
| 2876 | (WebCore::): |
| 2877 | * platform/graphics/cg/GraphicsContextCG.cpp: |
| 2878 | (WebCore::GraphicsContext::setImageInterpolationQuality): |
| 2879 | (WebCore::GraphicsContext::imageInterpolationQuality): |
| 2880 | |
mitz@apple.com | aa93879 | 2008-08-21 00:33:29 +0000 | [diff] [blame] | 2881 | 2008-08-20 Dan Bernstein <mitz@apple.com> |
| 2882 | |
| 2883 | Rubber-stamped by John Sullivan. |
| 2884 | |
| 2885 | - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and |
| 2886 | rename related methods and variables accordingly. |
| 2887 | |
| 2888 | * WebCore.base.exp: |
| 2889 | * page/FrameView.cpp: |
| 2890 | (WebCore::FrameViewPrivate::FrameViewPrivate): |
| 2891 | (WebCore::FrameView::shouldUpdateWhileOffscreen): |
| 2892 | (WebCore::FrameView::setShouldUpdateWhileOffscreen): |
| 2893 | * page/FrameView.h: |
| 2894 | * platform/ScrollView.h: |
| 2895 | * platform/mac/ScrollViewMac.mm: |
| 2896 | (WebCore::ScrollView::updateContents): |
| 2897 | |
beidson@apple.com | 2ace6b1 | 2008-08-21 00:13:12 +0000 | [diff] [blame] | 2898 | 2008-08-20 Brady Eidson <beidson@apple.com> |
| 2899 | |
| 2900 | Reviewed by Mitzpettel |
| 2901 | |
| 2902 | <rdar://problem/6163636> - Many images broken in Mail |
| 2903 | |
| 2904 | This can be traced back to the preload scanner. With that change, CachedResources are created a lot |
| 2905 | sooner than before and confuse the WebArchive machinery. |
| 2906 | |
| 2907 | When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore |
| 2908 | such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate |
| 2909 | machinery and nothing is known about where the data will eventually come from. |
| 2910 | |
| 2911 | * loader/DocumentLoader.cpp: |
| 2912 | (WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is |
| 2913 | CachedResource::PreloadReferenced. |
| 2914 | |
zecke@webkit.org | a8fa0e1 | 2008-08-20 22:50:39 +0000 | [diff] [blame] | 2915 | 2008-08-20 Holger Hans Peter Freyther <zecke@selfish.org> |
| 2916 | |
| 2917 | Unreviewed compile fix |
| 2918 | |
| 2919 | Catch up with the JSValue::type elimination. |
| 2920 | |
| 2921 | * bridge/qt/qt_instance.cpp: |
| 2922 | (KJS::Bindings::QtRuntimeObjectImp::construct): |
| 2923 | (KJS::Bindings::QtInstance::defaultValue): |
| 2924 | * bridge/qt/qt_runtime.cpp: |
| 2925 | (KJS::Bindings::QtRuntimeConnectionMethod::call): |
| 2926 | |
mrowe@apple.com | 2d74ec9 | 2008-08-20 22:15:53 +0000 | [diff] [blame] | 2927 | 2008-08-20 Chris Teague <chris.teague@gmail.com> |
| 2928 | |
| 2929 | Reviewed by Mark Rowe. |
| 2930 | |
| 2931 | Fix https://bugs.webkit.org/show_bug.cgi?id=20449 |
| 2932 | Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined |
| 2933 | |
| 2934 | * ChangeLog: |
| 2935 | * loader/FrameLoader.cpp: |
| 2936 | (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady): |
| 2937 | |
simon.fraser@apple.com | be1d24c | 2008-08-20 21:57:22 +0000 | [diff] [blame] | 2938 | 2008-08-20 Simon Fraser <simon.fraser@apple.com> |
| 2939 | |
| 2940 | Reviewed by Dave Hyatt |
| 2941 | |
| 2942 | getComputedStyle() for webkitTransform should return a transform |
| 2943 | that does not have the transform origin baked into it. |
| 2944 | https://bugs.webkit.org/show_bug.cgi?id=20464 |
| 2945 | |
| 2946 | Test: fast/css/getComputedStyle-transform.html |
| 2947 | |
| 2948 | * css/CSSComputedStyleDeclaration.cpp: |
| 2949 | (WebCore::computedTransform): |
| 2950 | * rendering/style/RenderStyle.cpp: |
| 2951 | (WebCore::RenderStyle::applyTransform): |
| 2952 | * rendering/style/RenderStyle.h: |
| 2953 | |
andersca@apple.com | 021ce77 | 2008-08-20 21:04:12 +0000 | [diff] [blame] | 2954 | 2008-08-20 Josh Aas <joshmoz@gmail.com> |
| 2955 | |
| 2956 | Reviewed and landed by Anders. |
| 2957 | |
| 2958 | <rdar://problem/6163636> |
| 2959 | rename NPCocoaEvent's "event" struct to "data" (20446) |
| 2960 | |
| 2961 | * bridge/npapi.h: |
| 2962 | (_NPCocoaEvent::): |
| 2963 | |
bdakin@apple.com | 699d13d | 2008-08-20 20:46:28 +0000 | [diff] [blame] | 2964 | 2008-08-20 Beth Dakin <bdakin@apple.com> |
| 2965 | |
darin@apple.com | 07c80c6 | 2008-09-05 18:15:43 +0000 | [diff] [blame] | 2966 | Reviewed by Darin Adler. |
bdakin@apple.com | 699d13d | 2008-08-20 20:46:28 +0000 | [diff] [blame] | 2967 | |
| 2968 | Fix for <rdar://problem/6145626> |
| 2969 | This patch fixes a number of remaining problems getting |
| 2970 | disconnected frames to work correctly with markAllMatchesForText() |
| 2971 | and findString(). Details inline. |
| 2972 | |
| 2973 | This was a static helper function in Frame, but this patch requires |
| 2974 | the same functionality in Editor, so I just added it as a function |
| 2975 | on Node. |
| 2976 | * dom/Node.cpp: |
| 2977 | (WebCore::Node::isInShadowTree): |
| 2978 | * dom/Node.h: |
| 2979 | |
| 2980 | * editing/Editor.cpp: |
| 2981 | (WebCore::Editor::insideVisibleArea): Returns false if |
| 2982 | excludeFromTextSearch() is true. |
| 2983 | |
| 2984 | In a normal (non-disconnected) frame, findString returns a range of |
| 2985 | the document node if the text is not found in the frame. I changed |
| 2986 | firstVisibleRange and lastVisibleRange to match that behavior when |
| 2987 | the text is not found |
| 2988 | (WebCore::Editor::firstVisibleRange): |
| 2989 | (WebCore::Editor::lastVisibleRange): |
| 2990 | |
| 2991 | Here are the bulk of the changes in the patch. A lot of text was |
| 2992 | not being found in disconnected frames because I failed to account |
| 2993 | for all of the possible problems associated with shadow trees. That |
| 2994 | is fixed here. |
| 2995 | (WebCore::Editor::nextVisibleRange): |
| 2996 | * editing/Editor.h: |
| 2997 | |
| 2998 | excludeFromTextSearch() is new. It allows a WebKit client to mark a |
| 2999 | frame as not-text-searchable through SPI. |
| 3000 | * WebCore.base.exp: |
| 3001 | * page/Frame.cpp: |
| 3002 | (WebCore::Frame::excludeFromTextSearch): |
| 3003 | (WebCore::Frame::setExcludeFromTextSearch): |
| 3004 | (WebCore::FramePrivate::FramePrivate): |
| 3005 | * page/Frame.h: |
| 3006 | * page/FramePrivate.h: |
| 3007 | |
| 3008 | (WebCore::Frame::findString): |
| 3009 | (WebCore::Frame::markAllMatchesForText): I kept running into an |
| 3010 | assertion failure in paining code because of the forced paint on |
| 3011 | empty visible rects. |
| 3012 | |
timothy@apple.com | 301befc | 2008-08-20 19:10:54 +0000 | [diff] [blame] | 3013 | 2008-08-20 Timothy Hatcher <timothy@apple.com> |
| 3014 | |
| 3015 | Adds a positon box to the Inspector's Metrics sidebar |
| 3016 | pane. When an element is not statically positioned, there |
| 3017 | is now a position box that show top, right, bottom and |
| 3018 | left computed values. |
| 3019 | |
| 3020 | Reviewed by Kevin McCullough. |
| 3021 | |
| 3022 | * English.lproj/localizedStrings.js: Updated the strings. |
| 3023 | * page/inspector/MetricsSidebarPane.js: |
| 3024 | (WebInspector.MetricsSidebarPane.prototype.update): |
| 3025 | Renamed the boxPartValue function to createBoxPartElement |
| 3026 | and made it create the entire element. Made it understand |
| 3027 | how to get position style properties. Don't use the figure dash |
| 3028 | when 0px is used for positions, since the 0 is meaningful there. |
| 3029 | Instead use the figure dash when a position is auto. |
| 3030 | * page/inspector/inspector.css: Added a new rule for position. |
| 3031 | |
mrowe@apple.com | 37686d4 | 2008-09-04 00:10:39 +0000 | [diff] [blame] | 3032 | 2008-08-20 Chris Fleizach <cfleizach@apple.com> |
cfleizach@apple.com | 2a5ecc0 | 2008-08-20 18:34:56 +0000 | [diff] [blame] | 3033 | |
| 3034 | Reviewed by Beth Dakin |
| 3035 | |
| 3036 | Qt build fix |
| 3037 | |
| 3038 | * WebCore.pro: |
| 3039 | |
mitz@apple.com | edaa904 | 2008-08-20 18:28:07 +0000 | [diff] [blame] | 3040 | 2008-08-20 Dan Bernstein <mitz@apple.com> |
| 3041 | |
| 3042 | Reviewed by Anders Carlsson. |
| 3043 | |
| 3044 | - avoid using a deprecated NSScroller method on Leopard |
| 3045 | |
| 3046 | * platform/mac/PlatformScrollBarMac.mm: |
| 3047 | (WebCore::PlatformScrollbar::updateThumbPosition): |
| 3048 | (WebCore::PlatformScrollbar::updateThumbProportion): |
| 3049 | |
jmalonzo@webkit.org | 6e0a308 | 2008-08-20 11:40:31 +0000 | [diff] [blame] | 3050 | 2008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org> |
| 3051 | |
| 3052 | Reviewed by Oliver Hunt. |
| 3053 | |
| 3054 | Gtk build fix |
| 3055 | |
| 3056 | * GNUmakefile.am: |
| 3057 | * page/AccessibilityTable.cpp: Change nil to 0 |
| 3058 | (WebCore::AccessibilityTable::cellForColumnAndRow): |
| 3059 | |
ap@webkit.org | 01aff70 | 2008-08-20 07:23:06 +0000 | [diff] [blame] | 3060 | 2008-08-19 Alexey Proskuryakov <ap@webkit.org> |
| 3061 | |
| 3062 | Reviewed by Geoff Garen. |
| 3063 | |
| 3064 | Bring back shared JSGlobalData and implicit locking, because too many clients rely on it. |
| 3065 | |
| 3066 | * ForwardingHeaders/kjs/JSLock.h: Added. |
| 3067 | * WebCore.vcproj/WebCore.vcproj: |
| 3068 | * bindings/js/GCController.cpp: |
| 3069 | (WebCore::collect): |
| 3070 | (WebCore::GCController::gcTimerFired): |
| 3071 | (WebCore::GCController::garbageCollectNow): |
| 3072 | * bindings/js/JSCustomSQLStatementCallback.cpp: |
| 3073 | (WebCore::JSCustomSQLStatementCallback::handleEvent): |
| 3074 | * bindings/js/JSCustomSQLStatementErrorCallback.cpp: |
| 3075 | (WebCore::JSCustomSQLStatementErrorCallback::handleEvent): |
| 3076 | * bindings/js/JSCustomSQLTransactionCallback.cpp: |
| 3077 | (WebCore::JSCustomSQLTransactionCallback::handleEvent): |
| 3078 | * bindings/js/JSCustomSQLTransactionErrorCallback.cpp: |
| 3079 | (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent): |
| 3080 | * bindings/js/JSCustomVoidCallback.cpp: |
| 3081 | (WebCore::JSCustomVoidCallback::handleEvent): |
| 3082 | * bindings/js/JSCustomXPathNSResolver.cpp: |
| 3083 | (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI): |
| 3084 | * bindings/js/JSDOMWindowBase.cpp: |
| 3085 | (WebCore::DOMWindowTimer::~DOMWindowTimer): |
| 3086 | (WebCore::JSDOMWindowBase::clear): |
| 3087 | (WebCore::JSDOMWindowBase::timerFired): |
| 3088 | * bindings/js/JSEventCustom.cpp: |
| 3089 | (WebCore::toJS): |
| 3090 | * bindings/js/JSEventListener.cpp: |
| 3091 | (WebCore::JSAbstractEventListener::handleEvent): |
| 3092 | * bindings/js/JSNSResolver.cpp: |
| 3093 | (WebCore::JSNSResolver::lookupNamespaceURI): |
| 3094 | * bindings/js/JSNodeFilterCondition.cpp: |
| 3095 | (WebCore::JSNodeFilterCondition::acceptNode): |
| 3096 | * bindings/js/ScheduledAction.cpp: |
| 3097 | (WebCore::ScheduledAction::execute): |
| 3098 | * bindings/js/ScriptController.cpp: |
| 3099 | (WebCore::ScriptController::evaluate): |
| 3100 | (WebCore::ScriptController::clearWindowShell): |
| 3101 | (WebCore::ScriptController::createHTMLEventHandler): |
| 3102 | (WebCore::ScriptController::createSVGEventHandler): |
| 3103 | (WebCore::ScriptController::initScript): |
| 3104 | (WebCore::ScriptController::updateDocument): |
| 3105 | (WebCore::ScriptController::bindingRootObject): |
| 3106 | (WebCore::ScriptController::windowScriptNPObject): |
| 3107 | (WebCore::ScriptController::createScriptObjectForPluginElement): |
| 3108 | (WebCore::ScriptController::clearScriptObjects): |
| 3109 | * bindings/js/ScriptControllerMac.mm: |
| 3110 | (WebCore::ScriptController::windowScriptObject): |
| 3111 | * bindings/objc/WebScriptObject.mm: |
| 3112 | (_didExecute): |
| 3113 | (-[WebScriptObject callWebScriptMethod:withArguments:]): |
| 3114 | (-[WebScriptObject evaluateWebScript:]): |
| 3115 | (-[WebScriptObject setValue:forKey:]): |
| 3116 | (-[WebScriptObject valueForKey:]): |
| 3117 | (-[WebScriptObject removeWebScriptKey:]): |
| 3118 | (-[WebScriptObject stringRepresentation]): |
| 3119 | (-[WebScriptObject webScriptValueAtIndex:]): |
| 3120 | (-[WebScriptObject setWebScriptValueAtIndex:value:]): |
| 3121 | (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]): |
| 3122 | * bridge/NP_jsobject.cpp: |
| 3123 | (_NPN_InvokeDefault): |
| 3124 | (_NPN_Invoke): |
| 3125 | (_NPN_Evaluate): |
| 3126 | (_NPN_GetProperty): |
| 3127 | (_NPN_SetProperty): |
| 3128 | (_NPN_RemoveProperty): |
| 3129 | (_NPN_HasProperty): |
| 3130 | (_NPN_HasMethod): |
| 3131 | (_NPN_Enumerate): |
| 3132 | * bridge/c/c_class.cpp: |
| 3133 | (KJS::Bindings::CClass::~CClass): |
| 3134 | (KJS::Bindings::CClass::methodsNamed): |
| 3135 | (KJS::Bindings::CClass::fieldNamed): |
| 3136 | * bridge/c/c_instance.cpp: |
| 3137 | (KJS::Bindings::CInstance::invokeMethod): |
| 3138 | (KJS::Bindings::CInstance::invokeDefaultMethod): |
| 3139 | (KJS::Bindings::CInstance::getPropertyNames): |
| 3140 | * bridge/c/c_runtime.cpp: |
| 3141 | (KJS::Bindings::CField::valueFromInstance): |
| 3142 | (KJS::Bindings::CField::setValueToInstance): |
| 3143 | * bridge/c/c_utility.cpp: |
| 3144 | (KJS::Bindings::convertValueToNPVariant): |
| 3145 | (KJS::Bindings::convertNPVariantToValue): |
| 3146 | * bridge/jni/jni_class.cpp: |
| 3147 | (JavaClass::JavaClass): |
| 3148 | (JavaClass::~JavaClass): |
| 3149 | * bridge/jni/jni_instance.cpp: |
| 3150 | (JavaInstance::stringValue): |
| 3151 | * bridge/jni/jni_jsobject.mm: |
| 3152 | (JavaJSObject::call): |
| 3153 | (JavaJSObject::eval): |
| 3154 | (JavaJSObject::getMember): |
| 3155 | (JavaJSObject::setMember): |
| 3156 | (JavaJSObject::removeMember): |
| 3157 | (JavaJSObject::getSlot): |
| 3158 | (JavaJSObject::setSlot): |
| 3159 | (JavaJSObject::toString): |
| 3160 | (JavaJSObject::convertValueToJObject): |
| 3161 | (JavaJSObject::convertJObjectToValue): |
| 3162 | * bridge/jni/jni_objc.mm: |
| 3163 | (KJS::Bindings::dispatchJNICall): |
| 3164 | * bridge/jni/jni_runtime.cpp: |
| 3165 | (appendClassName): |
| 3166 | (JavaMethod::signature): |
| 3167 | * bridge/jni/jni_runtime.h: |
| 3168 | (KJS::Bindings::JavaString::JavaString): |
| 3169 | (KJS::Bindings::JavaString::_commonInit): |
| 3170 | (KJS::Bindings::JavaString::~JavaString): |
| 3171 | (KJS::Bindings::JavaString::UTF8String): |
| 3172 | * bridge/jni/jni_utility.cpp: |
| 3173 | (KJS::Bindings::convertValueToJValue): |
| 3174 | * bridge/npruntime.cpp: |
| 3175 | (_NPN_GetStringIdentifier): |
| 3176 | * bridge/objc/objc_instance.mm: |
| 3177 | (ObjcInstance::moveGlobalExceptionToExecState): |
| 3178 | (ObjcInstance::invokeMethod): |
| 3179 | (ObjcInstance::invokeDefaultMethod): |
| 3180 | (ObjcInstance::setValueOfUndefinedField): |
| 3181 | (ObjcInstance::getValueOfUndefinedField): |
| 3182 | * bridge/objc/objc_runtime.mm: |
| 3183 | (ObjcField::valueFromInstance): |
| 3184 | (ObjcField::setValueToInstance): |
| 3185 | * bridge/objc/objc_utility.mm: |
| 3186 | (KJS::Bindings::convertValueToObjcValue): |
| 3187 | (KJS::Bindings::convertNSStringToString): |
| 3188 | (KJS::Bindings::convertObjcValueToValue): |
| 3189 | * bridge/qt/qt_instance.cpp: |
| 3190 | (KJS::Bindings::QtRuntimeObjectImp::removeFromCache): |
| 3191 | (KJS::Bindings::QtInstance::~QtInstance): |
| 3192 | (KJS::Bindings::QtInstance::getQtInstance): |
| 3193 | (KJS::Bindings::QtInstance::getRuntimeObject): |
| 3194 | * bridge/qt/qt_runtime.cpp: |
| 3195 | (KJS::Bindings::convertValueToQVariant): |
| 3196 | (KJS::Bindings::convertQVariantToValue): |
| 3197 | (KJS::Bindings::QtRuntimeMetaMethod::call): |
| 3198 | (KJS::Bindings::QtRuntimeConnectionMethod::call): |
| 3199 | (KJS::Bindings::QtConnectionObject::QtConnectionObject): |
| 3200 | (KJS::Bindings::QtConnectionObject::execute): |
| 3201 | * bridge/runtime.cpp: |
| 3202 | (KJS::Bindings::Instance::createRuntimeObject): |
| 3203 | * bridge/testbindings.cpp: |
| 3204 | (main): |
| 3205 | * bridge/testbindings.mm: |
| 3206 | (main): |
| 3207 | * bridge/testqtbindings.cpp: |
| 3208 | (main): |
| 3209 | * dom/Document.cpp: |
| 3210 | (WebCore::Document::~Document): |
| 3211 | * dom/Node.cpp: |
| 3212 | (WebCore::Node::setDocument): |
| 3213 | * history/CachedPage.cpp: |
| 3214 | (WebCore::CachedPage::CachedPage): |
| 3215 | (WebCore::CachedPage::restore): |
| 3216 | (WebCore::CachedPage::clear): |
| 3217 | * loader/FrameLoader.cpp: |
| 3218 | (WebCore::getString): |
| 3219 | * page/InspectorController.cpp: |
| 3220 | (WebCore::ConsoleMessage::ConsoleMessage): |
| 3221 | (WebCore::XMLHttpRequestResource::XMLHttpRequestResource): |
| 3222 | (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource): |
| 3223 | (WebCore::getResourceDocumentNode): |
| 3224 | (WebCore::search): |
| 3225 | (WebCore::inspectedWindow): |
| 3226 | (WebCore::wrapCallback): |
| 3227 | (WebCore::currentCallFrame): |
| 3228 | (WebCore::profiles): |
| 3229 | (WebCore::InspectorController::focusNode): |
| 3230 | (WebCore::InspectorController::inspectedWindowScriptObjectCleared): |
| 3231 | (WebCore::InspectorController::addDatabaseScriptResource): |
| 3232 | (WebCore::InspectorController::addScriptProfile): |
| 3233 | * page/JavaScriptCallFrame.cpp: |
| 3234 | (WebCore::JavaScriptCallFrame::evaluate): |
| 3235 | * page/JavaScriptProfileNode.cpp: |
| 3236 | (WebCore::getTotalTime): |
| 3237 | (WebCore::getSelfTime): |
| 3238 | (WebCore::getTotalPercent): |
| 3239 | (WebCore::getSelfPercent): |
| 3240 | (WebCore::getNumberOfCalls): |
| 3241 | (WebCore::getChildren): |
| 3242 | (WebCore::getVisible): |
| 3243 | * page/Page.cpp: |
| 3244 | * page/mac/FrameMac.mm: |
| 3245 | * plugins/PluginView.cpp: |
| 3246 | (WebCore::PluginView::start): |
| 3247 | (WebCore::getString): |
| 3248 | (WebCore::PluginView::performRequest): |
| 3249 | (WebCore::PluginView::bindingInstance): |
| 3250 | * plugins/gtk/PluginViewGtk.cpp: |
| 3251 | (WebCore::PluginView::paint): |
| 3252 | (WebCore::PluginView::handleKeyboardEvent): |
| 3253 | (WebCore::PluginView::handleMouseEvent): |
| 3254 | (WebCore::PluginView::setNPWindowRect): |
| 3255 | (WebCore::PluginView::stop): |
| 3256 | (WebCore::PluginView::init): |
| 3257 | * plugins/qt/PluginViewQt.cpp: |
| 3258 | (WebCore::PluginView::setNPWindowRect): |
| 3259 | (WebCore::PluginView::stop): |
| 3260 | (WebCore::PluginView::init): |
| 3261 | * plugins/win/PluginViewWin.cpp: |
| 3262 | (WebCore::PluginView::dispatchNPEvent): |
| 3263 | (WebCore::PluginView::handleKeyboardEvent): |
| 3264 | (WebCore::PluginView::handleMouseEvent): |
| 3265 | (WebCore::PluginView::setNPWindowRect): |
| 3266 | (WebCore::PluginView::stop): |
| 3267 | * xml/XMLHttpRequest.cpp: |
| 3268 | (WebCore::XMLHttpRequest::clearResponse): |
| 3269 | (WebCore::XMLHttpRequest::didFinishLoading): |
| 3270 | (WebCore::XMLHttpRequest::didReceiveData): |
| 3271 | |
eric@webkit.org | bac9376 | 2008-08-19 23:33:07 +0000 | [diff] [blame] | 3272 | 2008-08-19 Eric Seidel <eric@webkit.org> |
| 3273 | |
| 3274 | Reviewed by Geoff Garen. |
| 3275 | |
| 3276 | Add the beginnings of Skia graphics support to WebCore |
| 3277 | as I try to begin the long process of un-forking the changes |
| 3278 | needed to WebCore to make Andriod's WebCore build. |
| 3279 | |
| 3280 | I'll follow this up with actual *Skia.cpp files in a separate patch. |
| 3281 | |
| 3282 | * platform/graphics/AffineTransform.h: |
| 3283 | * platform/graphics/FloatPoint.h: |
| 3284 | * platform/graphics/FloatRect.h: |
| 3285 | * platform/graphics/Gradient.h: |
| 3286 | * platform/graphics/GraphicsContext.h: |
| 3287 | * platform/graphics/Image.h: |
| 3288 | * platform/graphics/ImageBuffer.h: |
| 3289 | * platform/graphics/ImageSource.h: |
| 3290 | * platform/graphics/IntPoint.h: |
| 3291 | * platform/graphics/IntRect.h: |
| 3292 | * platform/graphics/Path.h: |
| 3293 | * platform/graphics/Pattern.h: |
| 3294 | * svg/graphics/SVGPaintServerPattern.h: |
| 3295 | * svg/graphics/SVGPaintServerSolid.h: |
| 3296 | |
sfalken@apple.com | 3f69b33 | 2008-08-19 22:34:37 +0000 | [diff] [blame] | 3297 | 2008-08-19 Steve Falkenburg <sfalken@apple.com> |
| 3298 | |
sfalken@apple.com | 45d2280 | 2008-08-19 22:46:31 +0000 | [diff] [blame] | 3299 | Fix Windows build more. |
| 3300 | |
| 3301 | * WebCore.vcproj/WebCore.vcproj: |
| 3302 | |
| 3303 | 2008-08-19 Steve Falkenburg <sfalken@apple.com> |
| 3304 | |
sfalken@apple.com | 3f69b33 | 2008-08-19 22:34:37 +0000 | [diff] [blame] | 3305 | Fix Windows build. |
| 3306 | |
| 3307 | * page/AccessibilityRenderObject.cpp: |
| 3308 | (WebCore::AccessibilityRenderObject::canSetFocusAttribute): |
| 3309 | |
mrowe@apple.com | 37686d4 | 2008-09-04 00:10:39 +0000 | [diff] [blame] | 3310 | 2008-08-19 Chris Fleizach <cfleizach@apple.com> |
cfleizach@apple.com | 7c7b5f3 | 2008-08-19 22:05:37 +0000 | [diff] [blame] | 3311 | |
| 3312 | Reviewed by Beth Dakin. |
| 3313 | |
| 3314 | <rdar://problem/4003764> Expose tables as AXTables |
| 3315 | |
| 3316 | Tests: accessibility/table-attributes.html |
| 3317 | accessibility/table-cell-spans.html |
| 3318 | accessibility/table-cells.html |
| 3319 | accessibility/table-detection.html |
| 3320 | accessibility/table-sections.html |
| 3321 | accessibility/table-with-rules.html |
| 3322 | |
| 3323 | * WebCore.xcodeproj/project.pbxproj: |
| 3324 | * page/AXObjectCache.cpp: |
| 3325 | (WebCore::AXObjectCache::get): |
| 3326 | * page/AccessibilityObject.h: |
| 3327 | (WebCore::): |
| 3328 | (WebCore::AccessibilityObject::isDataTable): |
| 3329 | (WebCore::AccessibilityObject::isTableRow): |
| 3330 | (WebCore::AccessibilityObject::isTableColumn): |
| 3331 | (WebCore::AccessibilityObject::isTableCell): |
| 3332 | * page/AccessibilityRenderObject.cpp: |
| 3333 | (WebCore::AccessibilityRenderObject::canSetFocusAttribute): |
| 3334 | * page/AccessibilityTable.cpp: Added. |
| 3335 | (WebCore::AccessibilityTable::AccessibilityTable): |
| 3336 | (WebCore::AccessibilityTable::~AccessibilityTable): |
| 3337 | (WebCore::AccessibilityTable::create): |
| 3338 | (WebCore::AccessibilityTable::isTableExposableThroughAccessibility): |
| 3339 | (WebCore::AccessibilityTable::clearChildren): |
| 3340 | (WebCore::AccessibilityTable::addChildren): |
| 3341 | (WebCore::AccessibilityTable::headerContainer): |
| 3342 | (WebCore::AccessibilityTable::columns): |
| 3343 | (WebCore::AccessibilityTable::rows): |
| 3344 | (WebCore::AccessibilityTable::rowHeaders): |
| 3345 | (WebCore::AccessibilityTable::columnHeaders): |
| 3346 | (WebCore::AccessibilityTable::cells): |
| 3347 | (WebCore::AccessibilityTable::columnCount): |
| 3348 | (WebCore::AccessibilityTable::rowCount): |
| 3349 | (WebCore::AccessibilityTable::cellForColumnAndRow): |
| 3350 | (WebCore::AccessibilityTable::roleValue): |
| 3351 | (WebCore::AccessibilityTable::accessibilityIsIgnored): |
| 3352 | (WebCore::AccessibilityTable::title): |
| 3353 | (WebCore::AccessibilityTable::isDataTable): |
| 3354 | * page/AccessibilityTable.h: Added. |
| 3355 | * page/AccessibilityTableCell.cpp: Added. |
| 3356 | (WebCore::AccessibilityTableCell::AccessibilityTableCell): |
| 3357 | (WebCore::AccessibilityTableCell::~AccessibilityTableCell): |
| 3358 | (WebCore::AccessibilityTableCell::create): |
| 3359 | (WebCore::AccessibilityTableCell::accessibilityIsIgnored): |
| 3360 | (WebCore::AccessibilityTableCell::rowIndexRange): |
| 3361 | (WebCore::AccessibilityTableCell::columnIndexRange): |
| 3362 | * page/AccessibilityTableCell.h: Added. |
| 3363 | (WebCore::AccessibilityTableCell::isTableCell): |
| 3364 | (WebCore::AccessibilityTableCell::roleValue): |
| 3365 | * page/AccessibilityTableColumn.cpp: Added. |
| 3366 | (WebCore::AccessibilityTableColumn::AccessibilityTableColumn): |
| 3367 | (WebCore::AccessibilityTableColumn::~AccessibilityTableColumn): |
| 3368 | (WebCore::AccessibilityTableColumn::create): |
| 3369 | (WebCore::AccessibilityTableColumn::setParentTable): |
| 3370 | (WebCore::AccessibilityTableColumn::elementRect): |
| 3371 | (WebCore::AccessibilityTableColumn::size): |
| 3372 | (WebCore::AccessibilityTableColumn::children): |
| 3373 | (WebCore::AccessibilityTableColumn::headerObject): |
| 3374 | (WebCore::AccessibilityTableColumn::headerObjectForSection): |
| 3375 | (WebCore::AccessibilityTableColumn::addChildren): |
| 3376 | * page/AccessibilityTableColumn.h: Added. |
| 3377 | (WebCore::AccessibilityTableColumn::parentObject): |
| 3378 | (WebCore::AccessibilityTableColumn::roleValue): |
| 3379 | (WebCore::AccessibilityTableColumn::accessibilityIsIgnored): |
| 3380 | (WebCore::AccessibilityTableColumn::isTableColumn): |
| 3381 | (WebCore::AccessibilityTableColumn::setColumnIndex): |
| 3382 | (WebCore::AccessibilityTableColumn::columnIndex): |
| 3383 | * page/AccessibilityTableHeaderContainer.cpp: Added. |
| 3384 | (WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer): |
| 3385 | (WebCore::AccessibilityTableHeaderContainer::~AccessibilityTableHeaderContainer): |
| 3386 | (WebCore::AccessibilityTableHeaderContainer::create): |
| 3387 | (WebCore::AccessibilityTableHeaderContainer::children): |
| 3388 | (WebCore::AccessibilityTableHeaderContainer::elementRect): |
| 3389 | (WebCore::AccessibilityTableHeaderContainer::size): |
| 3390 | (WebCore::AccessibilityTableHeaderContainer::addChildren): |
| 3391 | * page/AccessibilityTableHeaderContainer.h: Added. |
| 3392 | (WebCore::AccessibilityTableHeaderContainer::roleValue): |
| 3393 | (WebCore::AccessibilityTableHeaderContainer::setParentTable): |
| 3394 | (WebCore::AccessibilityTableHeaderContainer::parentObject): |
| 3395 | (WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored): |
| 3396 | * page/AccessibilityTableRow.cpp: Added. |
| 3397 | (WebCore::AccessibilityTableRow::AccessibilityTableRow): |
| 3398 | (WebCore::AccessibilityTableRow::~AccessibilityTableRow): |
| 3399 | (WebCore::AccessibilityTableRow::create): |
| 3400 | (WebCore::AccessibilityTableRow::accessibilityIsIgnored): |
| 3401 | (WebCore::AccessibilityTableRow::headerObject): |
| 3402 | * page/AccessibilityTableRow.h: Added. |
| 3403 | (WebCore::AccessibilityTableRow::isTableRow): |
| 3404 | (WebCore::AccessibilityTableRow::roleValue): |
| 3405 | (WebCore::AccessibilityTableRow::setRowIndex): |
| 3406 | (WebCore::AccessibilityTableRow::rowIndex): |
| 3407 | * page/mac/AccessibilityObjectWrapper.mm: |
| 3408 | (-[AccessibilityObjectWrapper accessibilityAttributeNames]): |
| 3409 | (RoleEntry::): |
| 3410 | (-[AccessibilityObjectWrapper roleDescription]): |
| 3411 | (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): |
| 3412 | (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]): |
| 3413 | (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): |
| 3414 | |
sfalken@apple.com | b83d469 | 2008-08-19 18:39:44 +0000 | [diff] [blame] | 3415 | 2008-08-19 Steve Falkenburg <sfalken@apple.com> |
| 3416 | |
| 3417 | Build fix. |
| 3418 | Add buildfailed support to stop builds early (preventing inaccurate error messages). |
| 3419 | Add missing post-build rule to Release. |
| 3420 | |
| 3421 | * WebCore.vcproj/QTMovieWin.vcproj: |
| 3422 | |
timothy@apple.com | da3aa63 | 2008-08-19 18:33:02 +0000 | [diff] [blame] | 3423 | 2008-08-19 Keishi Hattori <casey.hattori@gmail.com> |
| 3424 | |
timothy@apple.com | 7d08c32 | 2008-08-19 18:33:27 +0000 | [diff] [blame] | 3425 | Added support for console.count in the inspector. |
| 3426 | |
| 3427 | Reviewed by Geoff Garen. |
| 3428 | |
| 3429 | * page/Console.cpp: |
| 3430 | (WebCore::Console::count): |
| 3431 | * page/Console.h: |
| 3432 | * page/Console.idl: Added console.count. |
| 3433 | * page/InspectorController.cpp: |
| 3434 | (WebCore::InspectorController::didCommitLoad): Clears m_counts. |
| 3435 | (WebCore::InspectorController::count): Updates the count number |
| 3436 | sing "title@source:line" as the identifier, and adds a |
| 3437 | message to the console. |
| 3438 | * page/InspectorController.h: Added m_counts. |
| 3439 | |
| 3440 | 2008-08-19 Keishi Hattori <casey.hattori@gmail.com> |
| 3441 | |
timothy@apple.com | da3aa63 | 2008-08-19 18:33:02 +0000 | [diff] [blame] | 3442 | Clear console.time timers when changing page. |
| 3443 | |
| 3444 | Reviewed by Geoff Garen. |
| 3445 | |
| 3446 | * page/InspectorController.cpp: |
| 3447 | (WebCore::InspectorController::didCommitLoad): |
| 3448 | |
adele@apple.com | 1f2d7e0 | 2008-08-19 17:55:58 +0000 | [diff] [blame] | 3449 | 2008-08-19 Eric Carlson <eric.carlson@apple.com> |
| 3450 | |
| 3451 | Reviewed by Adele. |
| 3452 | |
| 3453 | Fix for <rdar://problem/6154695> Full-page movies flicker while playing |
| 3454 | https://bugs.webkit.org/show_bug.cgi?id=20404 |
| 3455 | |
| 3456 | Ignore setVisible() when visibility doesn't change. |
| 3457 | |
| 3458 | * platform/graphics/mac/MediaPlayerPrivateQTKit.h: |
| 3459 | * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: |
| 3460 | (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): |
| 3461 | (WebCore::MediaPlayerPrivate::setVisible): |
| 3462 | |
timothy@apple.com | 9d9821a | 2008-08-19 17:00:26 +0000 | [diff] [blame] | 3463 | 2008-08-19 Timothy Hatcher <timothy@apple.com> |
| 3464 | |
timothy@apple.com | e058a79 | 2008-08-19 17:01:12 +0000 | [diff] [blame] | 3465 | Fixes a bug in the Profile view where switching sort order, then |
| 3466 | switching from heavy to tree mode would show the tree in the |
| 3467 | previous sort order. |
| 3468 | |
| 3469 | https://bugs.webkit.org/show_bug.cgi?id=20441 |
| 3470 | |
| 3471 | Reviewed by Kevin McCullough. |
| 3472 | |
| 3473 | * page/inspector/ProfileView.js: |
| 3474 | (WebInspector.ProfileView.prototype._changeView): Call _sortProfile |
| 3475 | on the next profile before assigning it to this.profile. |
| 3476 | (WebInspector.ProfileView.prototype._sortData): Call _sortProfile. |
| 3477 | (WebInspector.ProfileView.prototype._sortProfile): Moves from |
| 3478 | _sortData and takes a profile argument. If the profile passed in |
| 3479 | matches the this.profile, then call refresh. |
| 3480 | |
| 3481 | 2008-08-18 Timothy Hatcher <timothy@apple.com> |
| 3482 | |
timothy@apple.com | e525e40 | 2008-08-19 17:01:00 +0000 | [diff] [blame] | 3483 | Changed the default sort order now that heavy view is the default. |
| 3484 | Also fixes a bug where the heavy profile was not sorted at first. |
| 3485 | |
| 3486 | https://bugs.webkit.org/show_bug.cgi?id=20440 |
| 3487 | |
| 3488 | Reviewed by Kevin McCullough. |
| 3489 | |
| 3490 | * page/inspector/ProfileView.js: |
| 3491 | (WebInspector.ProfileView): Changed the default sort column. Also assign |
| 3492 | heavyProfile to profile, so the sortSelfTimeDescending call happens |
| 3493 | on the heavy profile before assigning to this.profile. |
| 3494 | |
| 3495 | 2008-08-18 Timothy Hatcher <timothy@apple.com> |
| 3496 | |
timothy@apple.com | c9287f3 | 2008-08-19 17:00:36 +0000 | [diff] [blame] | 3497 | Add support for editing DOM properties and scope variables by double |
| 3498 | clicking a property to enter edit mode. |
| 3499 | |
| 3500 | https://bugs.webkit.org/show_bug.cgi?id=20415 |
| 3501 | |
| 3502 | Reviewed by Kevin McCullough. |
| 3503 | |
| 3504 | * page/inspector/ObjectPropertiesSection.js: |
| 3505 | (WebInspector.ObjectPropertiesSection): Set editable to true by default. |
| 3506 | (WebInspector.ObjectPropertiesSection.prototype.onpopulate): |
| 3507 | Factored out code into update, and calls update. |
| 3508 | (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate. |
| 3509 | Call removeChildren since this method can be called multiple times now. |
| 3510 | (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title |
| 3511 | gets made later in onattach. |
| 3512 | (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early |
| 3513 | if shouldRefreshChildren is true. Call removeChildren since this method can be |
| 3514 | called multiple times now. |
| 3515 | (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing. |
| 3516 | (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update. |
| 3517 | (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for |
| 3518 | this element (code moved from the constructor.) |
| 3519 | (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all |
| 3520 | sibling property elements. |
| 3521 | (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call |
| 3522 | WebInspector.startEditing after rememebring some context. |
| 3523 | (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft |
| 3524 | for the list element, since it might have scrolled during editing. |
| 3525 | (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded |
| 3526 | then restore the state from the context. Then call update to restore the title. |
| 3527 | (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled |
| 3528 | if the user input and the previous input are the same. Call editingEnded, then call applyExpression |
| 3529 | to commit the user input. |
| 3530 | (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression |
| 3531 | and stores the result on the object for the property name of this element. If the expression is |
| 3532 | empty, delete the property and remove the tree element. |
| 3533 | * page/inspector/ScopeChainSidebarPane.js: |
| 3534 | (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused |
| 3535 | property on each ObjectPropertiesSection. |
| 3536 | (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach |
| 3537 | since it is now implemented. |
| 3538 | * page/inspector/ScriptsPanel.js: |
| 3539 | (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument |
| 3540 | that defaults to true if omitted. It specifies whether to call update on the scope chain. |
| 3541 | * page/inspector/inspector.css: New styles. |
| 3542 | * page/inspector/treeoutline.js: |
| 3543 | (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren |
| 3544 | change. The nextSibling would exist but have a _listItemNode that didn't match the new parent. |
| 3545 | |
| 3546 | 2008-08-18 Timothy Hatcher <timothy@apple.com> |
| 3547 | |
timothy@apple.com | 9d9821a | 2008-08-19 17:00:26 +0000 | [diff] [blame] | 3548 | Surround the expression to be evaluated in parenthesis so the |
| 3549 | result of the eval is the result of the whole expression not |
| 3550 | the last potential sub-expression. So evaluating {x: 123} |
| 3551 | will show the Object not 123. |
| 3552 | |
| 3553 | https://bugs.webkit.org/show_bug.cgi?id=20428 |
| 3554 | |
| 3555 | Reviewed by Kevin McCullough. |
| 3556 | |
| 3557 | * page/inspector/Console.js: |
| 3558 | (Console.prototype._evalInInspectedWindow): Add parenthesis |
| 3559 | around the expression. And add couple comments. |
| 3560 | |
kmccullough@apple.com | e8ac2f3 | 2008-08-19 16:38:06 +0000 | [diff] [blame] | 3561 | 2008-08-19 Kevin McCullough <kmccullough@apple.com> |
| 3562 | |
| 3563 | Reviewed by Geoff. |
| 3564 | |
| 3565 | -Implement a page() function to extract a common code pattern. |
| 3566 | |
| 3567 | * WebCore.xcodeproj/project.pbxproj: |
| 3568 | * page/Console.cpp: |
| 3569 | (WebCore::Console::addMessage): |
| 3570 | (WebCore::Console::error): |
| 3571 | (WebCore::Console::info): |
| 3572 | (WebCore::Console::log): |
| 3573 | (WebCore::Console::dir): |
| 3574 | (WebCore::Console::assertCondition): |
| 3575 | (WebCore::Console::time): |
| 3576 | (WebCore::Console::timeEnd): |
| 3577 | (WebCore::Console::group): |
| 3578 | (WebCore::Console::groupEnd): |
| 3579 | (WebCore::Console::finishedProfiling): |
| 3580 | (WebCore::Console::warn): |
| 3581 | (WebCore::Console::framePage): |
| 3582 | * page/Console.h: |
| 3583 | |
darin@apple.com | 349e1eb | 2008-08-19 04:39:04 +0000 | [diff] [blame] | 3584 | 2008-08-12 Darin Adler <darin@apple.com> |
| 3585 | |
| 3586 | Reviewed by Geoff. |
| 3587 | |
| 3588 | - eliminate JSValue::type() |
| 3589 | |
| 3590 | * bridge/c/c_instance.cpp: |
| 3591 | (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType |
| 3592 | argument instead of JSType argument. Removed unneeded code to handle |
| 3593 | boolean, since that's never passed. |
| 3594 | * bridge/c/c_instance.h: Ditto. |
| 3595 | |
| 3596 | * bridge/c/c_utility.cpp: |
| 3597 | (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions |
| 3598 | instead of JSValue::type(). Removed unneeded code to handle |
| 3599 | "unspecified". |
| 3600 | |
| 3601 | * bridge/jni/jni_instance.cpp: |
| 3602 | (JavaInstance::defaultValue): Take PreferredPrimitiveType argument |
| 3603 | instead of JSType argument. Removed unneeded code to handle boolean. |
| 3604 | * bridge/jni/jni_instance.h: Ditto. |
| 3605 | |
| 3606 | * bridge/jni/jni_jsobject.mm: |
| 3607 | (JavaJSObject::convertValueToJObject): Use JSValue::is functions |
| 3608 | instead of JSValue::type(). |
| 3609 | |
| 3610 | * bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument |
| 3611 | instead of JSType argument. Removed unused argument. |
| 3612 | * bridge/objc/objc_instance.mm: |
| 3613 | (ObjcInstance::getValueOfUndefinedField): Removed unused argument. |
| 3614 | (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument |
| 3615 | instead of JSType argument. Removed unneeded code to handle boolean |
| 3616 | and another dead code path for unknown types. |
| 3617 | |
| 3618 | * bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument |
| 3619 | instead of JSType argument. Removed override of type() that caused |
| 3620 | the fallback object to return "UndefinedType" when there is no |
| 3621 | invokeUndefinedMethodFromWebScript:withArguments: method defined. |
| 3622 | That didn't accomplish much, since most checks for undefined don't |
| 3623 | ever call type(). |
| 3624 | * bridge/objc/objc_runtime.mm: |
| 3625 | (ObjcFallbackObjectImp::defaultValue): Ditto. |
| 3626 | |
| 3627 | * bridge/qt/qt_instance.cpp: |
| 3628 | (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType |
| 3629 | argument instead of JSType argument. Removed unneeded code to handle |
| 3630 | boolean. |
| 3631 | * bridge/qt/qt_instance.h: Ditto. |
| 3632 | |
| 3633 | * bridge/runtime.h: |
| 3634 | (KJS::Bindings::Instance::getValueOfUndefinedField): Removed |
| 3635 | unsed argument. |
| 3636 | * bridge/runtime_object.cpp: |
| 3637 | (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType |
| 3638 | argument instead of JSType argument. |
| 3639 | * bridge/runtime_object.h: Ditto. |
| 3640 | |
britto@apple.com | af7f838 | 2008-08-19 00:42:13 +0000 | [diff] [blame] | 3641 | 2008-08-18 Maxime Britto <britto@apple.com> |
| 3642 | |
| 3643 | Reviewed by Adele. |
| 3644 | |
| 3645 | <rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window |
| 3646 | Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning). |
| 3647 | We shouldn't be able to create another window while we are in pan scrolling. |
| 3648 | Other browsers behaviors : |
| 3649 | FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode |
| 3650 | IE7 : Keys are not disabled but stops immediately the panning. |
| 3651 | This patch matches FF3 behavior by disabling every key but the esc key. |
| 3652 | |
| 3653 | * page/EventHandler.cpp: |
| 3654 | (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped. |
| 3655 | (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early. |
| 3656 | |
mitz@apple.com | 12404d8 | 2008-08-19 00:20:38 +0000 | [diff] [blame] | 3657 | 2008-08-18 Dan Bernstein <mitz@apple.com> |
| 3658 | |
| 3659 | Reviewed by Dave Hyatt. |
| 3660 | |
| 3661 | - fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received |
| 3662 | |
| 3663 | Test: fast/replaced/max-width-percent.html |
| 3664 | |
| 3665 | Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth(). |
| 3666 | When false, max-width is not factored into the |
| 3667 | calculation. |
| 3668 | Changed RenderReplaced and subclasses' calcPrefWidths() to call |
| 3669 | calcReplacedWidth(false) and then apply max-width only if it has a |
| 3670 | fixed, positive value. |
| 3671 | |
| 3672 | * rendering/RenderBox.cpp: |
| 3673 | (WebCore::RenderBox::calcReplacedWidth): |
| 3674 | * rendering/RenderBox.h: |
| 3675 | * rendering/RenderImage.cpp: |
| 3676 | (WebCore::RenderImage::calcReplacedWidth): |
| 3677 | (WebCore::RenderImage::calcPrefWidths): |
| 3678 | * rendering/RenderImage.h: |
| 3679 | * rendering/RenderReplaced.cpp: |
| 3680 | (WebCore::RenderReplaced::calcPrefWidths): |
| 3681 | * rendering/RenderSVGRoot.cpp: |
| 3682 | (WebCore::RenderSVGRoot::calcPrefWidths): |
| 3683 | * rendering/RenderVideo.cpp: |
| 3684 | (WebCore::RenderVideo::calcReplacedWidth): |
| 3685 | (WebCore::RenderVideo::calcPrefWidths): |
| 3686 | * rendering/RenderVideo.h: |
| 3687 | |
mrowe@apple.com | ced8873 | 2008-08-18 22:47:28 +0000 | [diff] [blame] | 3688 | 2008-08-18 Daniel Macks <dmacks@netspace.org> |
| 3689 | |
| 3690 | Reviewed by Mark Rowe. |
| 3691 | |
| 3692 | https://bugs.webkit.org/show_bug.cgi?id=20410 |
| 3693 | More portable/self-documenting replacement for SIZE_MAX. |
| 3694 | |
| 3695 | * platform/network/curl/FormDataStreamCurl.cpp: |
| 3696 | (WebCore::FormDataStream::read): |
| 3697 | |
| 3698 | 2008-08-18 Simon Fraser <simon.fraser@apple.com> |
simon.fraser@apple.com | 6040db3 | 2008-08-18 22:11:10 +0000 | [diff] [blame] | 3699 | |
| 3700 | Reviewed by Dave Hyatt |
| 3701 | |
| 3702 | Need to make sure we have an Animation in the AnimationList |
| 3703 | before setting the initial value. |
| 3704 | https://bugs.webkit.org/show_bug.cgi?id=20408 |
| 3705 | |
| 3706 | Test: fast/css/transition_shorthand_parsing.html |
| 3707 | |
| 3708 | * css/CSSStyleSelector.cpp: |
| 3709 | |
kmccullough@apple.com | 64cb2fd | 2008-08-18 19:55:35 +0000 | [diff] [blame] | 3710 | 2008-08-18 Kevin McCullough <kmccullough@apple.com> |
| 3711 | |
kmccullough@apple.com | 707bd36 | 2008-08-18 20:21:57 +0000 | [diff] [blame] | 3712 | Reviewed by Tim. |
| 3713 | |
| 3714 | <rdar://problem/6150593> JSProfiler: Empty profiles disappear when there |
| 3715 | is another profile. |
| 3716 | |
| 3717 | * page/inspector/ProfilesPanel.js: |
| 3718 | |
| 3719 | 2008-08-18 Kevin McCullough <kmccullough@apple.com> |
| 3720 | |
kmccullough@apple.com | 64cb2fd | 2008-08-18 19:55:35 +0000 | [diff] [blame] | 3721 | Reviewed by Geoff. |
| 3722 | |
| 3723 | <rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears |
| 3724 | all console messages |
| 3725 | |
| 3726 | * page/inspector/Console.js: |
| 3727 | |
jmalonzo@webkit.org | 5d1e048 | 2008-08-18 11:20:11 +0000 | [diff] [blame] | 3728 | 2008-08-18 Dirk Schulze <vbs85@gmx.de> |
| 3729 | |
| 3730 | Reviewed by Eric Seidel. |
| 3731 | |
| 3732 | Fixed Canvas for Cairo. Stroke and fill colors didn't work after |
| 3733 | the canvas clean up. |
| 3734 | |
| 3735 | https://bugs.webkit.org/show_bug.cgi?id=20405 |
| 3736 | |
| 3737 | * html/CanvasRenderingContext2D.cpp: |
| 3738 | (WebCore::CanvasRenderingContext2D::fill): |
| 3739 | (WebCore::CanvasRenderingContext2D::stroke): |
| 3740 | (WebCore::CanvasRenderingContext2D::fillRect): |
| 3741 | |
timothy@apple.com | c5e1f8d | 2008-08-18 03:21:46 +0000 | [diff] [blame] | 3742 | 2008-08-17 Timothy Hatcher <timothy@apple.com> |
| 3743 | |
| 3744 | Complete in scope variables in the Console when paused. |
| 3745 | |
| 3746 | https://bugs.webkit.org/show_bug.cgi?id=19115 |
| 3747 | |
| 3748 | Reviewed by Geoffrey Garen. |
| 3749 | |
| 3750 | * page/inspector/Console.js: |
| 3751 | (WebInspector.Console.prototype.completions): If the expressionString |
| 3752 | is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame |
| 3753 | to get an object that declares all the in scope variables. That way |
| 3754 | "top level" expressions are completed. |
| 3755 | * page/inspector/ScriptsPanel.js: |
| 3756 | (WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame): |
| 3757 | Return an object that has all the variables that are in scope for the |
| 3758 | selected call frame. The value of each property is just true. |
| 3759 | The return object is useful for quick lookups or auto completion. |
| 3760 | |
cwzwarich@webkit.org | ac71528 | 2008-08-17 21:34:46 +0000 | [diff] [blame] | 3761 | 2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca> |
| 3762 | |
| 3763 | Not reviewed. |
| 3764 | |
| 3765 | Speculative Qt build fix. |
| 3766 | |
| 3767 | * bridge/qt/qt_runtime.cpp: |
| 3768 | (KJS::Bindings::convertValueToQVariant): |
| 3769 | (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod): |
| 3770 | |
ggaren@apple.com | fea4353 | 2008-08-17 20:23:49 +0000 | [diff] [blame] | 3771 | 2008-08-17 Geoffrey Garen <ggaren@apple.com> |
| 3772 | |
| 3773 | Reviewed by Cameron Zwarich. |
ggaren@apple.com | 6e53d0a | 2008-08-17 20:28:37 +0000 | [diff] [blame] | 3774 | |
| 3775 | Updated project files to XCode 3.1. |
| 3776 | |
| 3777 | * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: |
| 3778 | |
| 3779 | 2008-08-17 Geoffrey Garen <ggaren@apple.com> |
| 3780 | |
| 3781 | Reviewed by Cameron Zwarich. |
ggaren@apple.com | fea4353 | 2008-08-17 20:23:49 +0000 | [diff] [blame] | 3782 | |
| 3783 | Made room for a free word in JSCell. |
| 3784 | |
| 3785 | Changed JSDOMWindowBase to store its auxiliary data in a subclass of |
| 3786 | JSGlobalData, so the two could share a pointer. |
| 3787 | |
| 3788 | Added a bunch of ASSERTs, to help catch over-sized objects. |
| 3789 | |
mrowe@apple.com | 1357029 | 2008-08-16 06:48:10 +0000 | [diff] [blame] | 3790 | 2008-08-15 Mark Rowe <mrowe@apple.com> |
| 3791 | |
mitz@apple.com | b96c1b9 | 2008-08-17 03:28:52 +0000 | [diff] [blame] | 3792 | Reviewed by Dan Bernstein. |
| 3793 | |
| 3794 | Disable dead code stripping in debug builds. |
| 3795 | |
| 3796 | * Configurations/Base.xcconfig: |
| 3797 | * WebCore.xcodeproj/project.pbxproj: |
| 3798 | |
| 3799 | 2008-08-15 Mark Rowe <mrowe@apple.com> |
| 3800 | |
mrowe@apple.com | 1357029 | 2008-08-16 06:48:10 +0000 | [diff] [blame] | 3801 | Rubber-stamped by Geoff Garen. |
| 3802 | |
| 3803 | <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework |
| 3804 | |
| 3805 | * Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared |
| 3806 | between the Debug configuration and debug Production variant. |
| 3807 | * WebCore.xcodeproj/project.pbxproj: Enable the debug variant. |
| 3808 | |
antti@apple.com | a05e8b0 | 2008-08-15 22:58:06 +0000 | [diff] [blame] | 3809 | 2008-08-15 Antti Koivisto <antti@apple.com> |
| 3810 | |
| 3811 | Reviewed by Anders. |
| 3812 | |
| 3813 | Don't start preloading body resources before the head is complete. This prevents |
| 3814 | body preloads from slowing down initial display when there is limited amount |
| 3815 | of bandwidth available. |
| 3816 | |
| 3817 | Works by queuing up found body preloads to DocLoader and only issuing them |
| 3818 | after document has rendering. |
| 3819 | |
| 3820 | With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s |
| 3821 | without affecting complete load time. |
| 3822 | |
| 3823 | * html/PreloadScanner.cpp: |
| 3824 | (WebCore::PreloadScanner::PreloadScanner): |
| 3825 | (WebCore::PreloadScanner::scanningBody): |
| 3826 | (WebCore::PreloadScanner::emitTag): |
| 3827 | (WebCore::PreloadScanner::emitCSSRule): |
| 3828 | * html/PreloadScanner.h: |
| 3829 | * loader/DocLoader.cpp: |
| 3830 | (WebCore::DocLoader::preload): |
| 3831 | (WebCore::DocLoader::checkForPendingPreloads): |
| 3832 | (WebCore::DocLoader::requestPreload): |
| 3833 | * loader/DocLoader.h: |
| 3834 | * loader/loader.cpp: |
| 3835 | (WebCore::Loader::Host::didFinishLoading): |
| 3836 | (WebCore::Loader::Host::didFail): |
| 3837 | |
adachan@apple.com | 94ac38d | 2008-08-15 21:08:40 +0000 | [diff] [blame] | 3838 | 2008-08-15 Ada Chan <adachan@apple.com> |
| 3839 | |
| 3840 | Use item's computed style if the render style is 0 before falling back to the <select>'s style. |
| 3841 | This way style set on an <hr> within a <select> will be honored. |
| 3842 | |
| 3843 | Reviewed by Dave Hyatt and Dan Bernstein. |
| 3844 | |
| 3845 | * rendering/RenderMenuList.cpp: |
| 3846 | (WebCore::RenderMenuList::itemStyle): |
| 3847 | |
antti@apple.com | 9f791147 | 2008-08-15 20:48:06 +0000 | [diff] [blame] | 3848 | 2008-08-15 Antti Koivisto <antti@apple.com> |
| 3849 | |
| 3850 | Reviewed by Oliver. |
| 3851 | |
| 3852 | Some loader performance tweaks: |
| 3853 | - Make stylesheets highest priority instead of scripts. We block script execution on stylesheets. |
| 3854 | Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue |
| 3855 | to not delay rendering. |
| 3856 | - Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup |
| 3857 | can take long time when latency is high so it is good to get started early. |
| 3858 | - When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the |
| 3859 | load queues. Issue remaining loads to the network layer. |
| 3860 | |
| 3861 | * loader/loader.cpp: |
| 3862 | (WebCore::Loader::determinePriority): |
| 3863 | (WebCore::Loader::load): |
| 3864 | (WebCore::Loader::Host::servePendingRequests): |
| 3865 | * loader/loader.h: |
| 3866 | |
timothy@apple.com | 2d974c3 | 2008-08-15 18:35:39 +0000 | [diff] [blame] | 3867 | 2008-08-15 Timothy Hatcher <timothy@apple.com> |
| 3868 | |
| 3869 | Detach the script debugger when the Web Inspector's window closes. |
| 3870 | This has always been the intended design, but never fully implemented. |
| 3871 | |
| 3872 | https://bugs.webkit.org/show_bug.cgi?id=20402 |
| 3873 | |
| 3874 | Reviewed by Adam Roben. |
| 3875 | |
| 3876 | * page/InspectorController.cpp: |
| 3877 | (WebCore::InspectorController::setWindowVisible): Call stopDebugging() |
| 3878 | if the window is no longer visible. |
| 3879 | |
hausmann@webkit.org | bb4b914 | 2008-08-15 18:11:34 +0000 | [diff] [blame] | 3880 | 2008-08-15 HÃ¥vard Wall <hwall@trolltech.com> |
| 3881 | |
| 3882 | Reviewed by Simon. |
| 3883 | |
hausmann@webkit.org | 58144a7 | 2008-08-15 18:12:08 +0000 | [diff] [blame] | 3884 | Fixes: compile with QT_NO_CONTEXTMENU |
| 3885 | |
| 3886 | * platform/qt/PlatformMouseEventQt.cpp: |
| 3887 | (WebCore::PlatformMouseEvent::PlatformMouseEvent): |
| 3888 | * platform/qt/PlatformScrollBarQt.cpp: |
| 3889 | (WebCore::PlatformScrollbar::handleMouseMoveEvent): |
| 3890 | (WebCore::PlatformScrollbar::handleContextMenuEvent): |
| 3891 | |
| 3892 | 2008-08-15 HÃ¥vard Wall <hwall@trolltech.com> |
| 3893 | |
| 3894 | Reviewed by Simon. |
| 3895 | |
hausmann@webkit.org | bb4b914 | 2008-08-15 18:11:34 +0000 | [diff] [blame] | 3896 | Fixes: compile with QT_NO_WHEELEVENT |
| 3897 | |
| 3898 | * platform/qt/WheelEventQt.cpp: |
| 3899 | (WebCore::PlatformWheelEvent::PlatformWheelEvent): |
| 3900 | |
timothy@apple.com | 4889e61 | 2008-08-15 17:06:14 +0000 | [diff] [blame] | 3901 | 2008-08-15 Keishi Hattori <casey.hattori@gmail.com> |
| 3902 | |
timothy@apple.com | d64639c | 2008-08-15 17:48:36 +0000 | [diff] [blame] | 3903 | Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector |
| 3904 | |
| 3905 | https://bugs.webkit.org/show_bug.cgi?id=20210 |
| 3906 | |
| 3907 | Reviewed by Tim Hatcher. |
| 3908 | |
| 3909 | * page/Console.cpp: |
| 3910 | (WebCore::Console::group): |
| 3911 | (WebCore::Console::groupEnd): |
| 3912 | * page/Console.h: |
| 3913 | (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel. |
| 3914 | * page/InspectorController.cpp: |
| 3915 | (WebCore::InspectorController::startGroup): Increments group level by |
| 3916 | one and adds console message with StartGroupMessaageLevel. |
| 3917 | (WebCore::InspectorController::endGroup): Decrements group level by one |
| 3918 | and adds console message with EndGroupMessaageLevel. |
| 3919 | * page/InspectorController.h: |
| 3920 | * page/inspector/Console.js: |
| 3921 | (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup |
| 3922 | if the message is StartGroupMessaageLevel. |
| 3923 | (WebInspector.ConsoleMessage.prototype.toMessageElement): |
| 3924 | (WebInspector.ConsoleGroup.prototype.addMessage): |
| 3925 | * page/inspector/inspector.js: |
| 3926 | |
| 3927 | 2008-08-15 Keishi Hattori <casey.hattori@gmail.com> |
| 3928 | |
timothy@apple.com | 7310b6a | 2008-08-15 17:35:22 +0000 | [diff] [blame] | 3929 | Adds support for console.dir to the Inspector |
| 3930 | |
| 3931 | https://bugs.webkit.org/show_bug.cgi?id=19155 |
| 3932 | |
| 3933 | Reviewed by Tim Hatcher. |
| 3934 | |
| 3935 | * bindings/js/JSConsoleCustom.cpp: |
| 3936 | (WebCore::JSConsole::dir): |
| 3937 | * page/Console.cpp: |
| 3938 | (WebCore::Console::dir): |
| 3939 | * page/Console.h: Added ObjectMessageLevel. |
| 3940 | * page/Console.idl: Added console.dir. |
| 3941 | * page/inspector/Console.js: |
| 3942 | (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an |
| 3943 | ObjectPropertiesSection if the MessageLevel is Object. |
| 3944 | * page/inspector/ObjectPropertiesSection.js: "in" operator can't be |
| 3945 | used on primitive data types. |
| 3946 | * page/inspector/inspector.css: |
| 3947 | |
| 3948 | 2008-08-15 Keishi Hattori <casey.hattori@gmail.com> |
| 3949 | |
timothy@apple.com | 4889e61 | 2008-08-15 17:06:14 +0000 | [diff] [blame] | 3950 | Adds support for clear() in the Inspector console. |
| 3951 | |
| 3952 | https://bugs.webkit.org/show_bug.cgi?id=19873 |
| 3953 | |
| 3954 | Reviewed by Tim Hatcher. |
| 3955 | |
| 3956 | * page/inspector/Console.js: |
| 3957 | |
timothy@apple.com | 12c5b5d | 2008-08-15 17:02:44 +0000 | [diff] [blame] | 3958 | 2008-08-15 Anthony Ricaud <rik24d@gmail.com> |
| 3959 | |
| 3960 | Cmd-F on Mac or Ctrl-F on other platforms now focus the search field. |
| 3961 | |
| 3962 | Platform distinction and modifier key matching adjusted |
| 3963 | by Daniel Jalkut <jalkut@red-sweater.com> |
| 3964 | |
| 3965 | Bug 16313: text search (find) keybindings should work in the Web Inspector |
| 3966 | https://bugs.webkit.org/show_bug.cgi?id=16313 |
| 3967 | |
| 3968 | Reviewed by Tim Hatcher. |
| 3969 | |
| 3970 | * page/inspector/inspector.js: Added a case for the F key |
| 3971 | |
timothy@apple.com | a5ba439 | 2008-08-15 16:50:26 +0000 | [diff] [blame] | 3972 | 2008-08-15 Keishi Hattori <casey.hattori@gmail.com> |
| 3973 | |
| 3974 | Fix for error when the string doesn't contain a webkit-profile link. |
| 3975 | |
| 3976 | https://bugs.webkit.org/show_bug.cgi?id=20399 |
| 3977 | |
| 3978 | Reviewed by Tim Hatcher. |
| 3979 | |
| 3980 | * page/inspector/inspector.js: |
| 3981 | |
timothy@apple.com | 895b265 | 2008-08-15 16:33:27 +0000 | [diff] [blame] | 3982 | 2008-08-15 Timothy Hatcher <timothy@apple.com> |
| 3983 | |
| 3984 | Fixes two bugs where JavaScript could be executed from the page |
| 3985 | while the debugger is paused. |
| 3986 | |
| 3987 | The first issue was JSLazyEventListener not checking the paused |
| 3988 | state before parsing the code. |
| 3989 | |
| 3990 | The second issue was with the PageGroup version of |
| 3991 | JavaScriptDebugServer::setJavaScriptPaused always passing false |
| 3992 | to the Page version of JavaScriptDebugServer::setJavaScriptPaused, |
| 3993 | and not the paused argument. |
| 3994 | |
| 3995 | https://bugs.webkit.org/show_bug.cgi?id=20284 |
| 3996 | |
| 3997 | Reviewed by Adam Roben. |
| 3998 | |
| 3999 | * bindings/js/JSEventListener.cpp: |
| 4000 | (WebCore::JSLazyEventListener::parseCode): Check the paused |
| 4001 | state of the ScriptController. Return early if paused. |
| 4002 | * manual-tests/inspector/debugger-execution-while-paused.html: Added. |
| 4003 | * page/JavaScriptDebugServer.cpp: |
| 4004 | (WebCore::JavaScriptDebugServer::setJavaScriptPaused): |
| 4005 | Pass the paused argument to the Page version of setJavaScriptPaused. |
| 4006 | |
ap@webkit.org | be495d3 | 2008-08-15 07:43:48 +0000 | [diff] [blame] | 4007 | 2008-08-15 Alexey Proskuryakov <ap@webkit.org> |
| 4008 | |
| 4009 | Reviewed by Geoff Garen. |
| 4010 | |
| 4011 | JSStringRef is created context-free, but can get linked to one via an identifier table, |
| 4012 | breaking an implicit API contract. |
| 4013 | |
| 4014 | * page/InspectorController.cpp: |
| 4015 | (WebCore::jsStringRef): |
| 4016 | (WebCore::InspectorController::didParseSource): |
| 4017 | (WebCore::InspectorController::failedToParseSource): |
| 4018 | * page/JavaScriptProfile.cpp: |
| 4019 | (WebCore::getTitleCallback): |
| 4020 | Updated for JavaScriptCore changes. |
| 4021 | |
kevino@webkit.org | 8fe09ff | 2008-08-15 05:10:57 +0000 | [diff] [blame] | 4022 | 2008-08-14 Kevin Ollivier <kevino@theolliviers.com> |
| 4023 | |
| 4024 | wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with |
| 4025 | an alternative that performs reasonably well. (GDI+ is too slow in many cases.) |
| 4026 | |
| 4027 | * platform/graphics/AffineTransform.h: |
| 4028 | |
adele@apple.com | 2b2e2f8 | 2008-08-15 00:53:36 +0000 | [diff] [blame] | 4029 | 2008-08-14 Eric Carlson <eric.carlson@apple.com> |
| 4030 | |
| 4031 | Reviewed by Adele. |
| 4032 | |
| 4033 | Fix for https://bugs.webkit.org/show_bug.cgi?id=20388 |
| 4034 | <video> elements on Windows never becomes visible when a page is restored from the cache |
| 4035 | |
| 4036 | Always pass "set" calls down to MediaPlayerPrivate instead of only when the |
| 4037 | value is different from the cached value. Let the implementation decide when |
| 4038 | to avoid work because nothing has changed. |
| 4039 | |
| 4040 | * platform/graphics/MediaPlayer.cpp: |
| 4041 | (WebCore::MediaPlayer::setVolume): |
| 4042 | (WebCore::MediaPlayer::setRate): |
| 4043 | (WebCore::MediaPlayer::setRect): |
| 4044 | (WebCore::MediaPlayer::setVisible): |
| 4045 | |
timothy@apple.com | da810f4 | 2008-08-14 23:57:14 +0000 | [diff] [blame] | 4046 | 2008-08-14 Keishi Hattori <casey.hattori@gmail.com> |
| 4047 | |
| 4048 | Make Firebug command line API respect predefined variables. |
| 4049 | |
timothy@apple.com | 90751f0 | 2008-08-14 23:58:19 +0000 | [diff] [blame] | 4050 | https://bugs.webkit.org/show_bug.cgi?id=20385 |
| 4051 | |
timothy@apple.com | da810f4 | 2008-08-14 23:57:14 +0000 | [diff] [blame] | 4052 | Reviewed by Tim Hatcher. |
| 4053 | |
| 4054 | * page/inspector/Console.js: |
| 4055 | |
weinig@apple.com | 4b51d00 | 2008-08-14 23:33:22 +0000 | [diff] [blame] | 4056 | 2008-08-14 Sam Weinig <sam@webkit.org> |
| 4057 | |
| 4058 | Reviewed by Geoffrey Garen and Timothy Hatcher. |
| 4059 | |
| 4060 | Allow programatically setting the HTMLTokenizers time delay and chunk size |
| 4061 | which are used for determining how aggressively we yield. |
| 4062 | |
| 4063 | * WebCore.base.exp: |
| 4064 | * html/HTMLTokenizer.cpp: |
| 4065 | (WebCore::HTMLTokenizer::begin): |
| 4066 | (WebCore::HTMLTokenizer::continueProcessing): |
| 4067 | * html/HTMLTokenizer.h: |
| 4068 | * page/Page.cpp: |
| 4069 | (WebCore::Page::Page): |
| 4070 | (WebCore::Page::setCustomHTMLTokenizerTimeDelay): |
| 4071 | (WebCore::Page::setCustomHTMLTokenizerChunkSize): |
| 4072 | * page/Page.h: |
| 4073 | (WebCore::Page::hasCustomHTMLTokenizerTimeDelay): |
| 4074 | (WebCore::Page::customHTMLTokenizerTimeDelay): |
| 4075 | (WebCore::Page::hasCustomHTMLTokenizerChunkSize): |
| 4076 | (WebCore::Page::customHTMLTokenizerChunkSize): |
| 4077 | |
eric@webkit.org | 89613d2 | 2008-08-14 23:19:17 +0000 | [diff] [blame] | 4078 | 2008-08-14 Eric Seidel <eric@webkit.org> |
| 4079 | |
eric@webkit.org | 7e897c3 | 2008-08-14 23:20:00 +0000 | [diff] [blame] | 4080 | Reviewed by Beth. |
| 4081 | |
| 4082 | Move us one step closer to cross-platform svg/graphics code |
| 4083 | |
| 4084 | * WebCore.xcodeproj/project.pbxproj: |
| 4085 | * html/CanvasStyle.cpp: |
| 4086 | * platform/graphics/Color.cpp: |
| 4087 | (WebCore::colorWithOverrideAlpha): |
| 4088 | * platform/graphics/Color.h: |
| 4089 | * svg/graphics/cg/CgSupport.cpp: |
| 4090 | (WebCore::applyStrokeStyleToContext): |
| 4091 | (WebCore::strokeBoundingBox): |
| 4092 | * svg/graphics/cg/SVGPaintServerSolidCg.cpp: |
| 4093 | (WebCore::SVGPaintServerSolid::setup): |
| 4094 | |
| 4095 | 2008-08-14 Eric Seidel <eric@webkit.org> |
| 4096 | |
eric@webkit.org | 4f49065 | 2008-08-14 23:19:31 +0000 | [diff] [blame] | 4097 | Reviewed by Alexey. |
| 4098 | |
eric@webkit.org | 73fa9d1 | 2008-08-14 23:19:44 +0000 | [diff] [blame] | 4099 | Remove un-need includes from HTMLCanvas and use the |
| 4100 | Gradient platform abstraction in one place in CanvasStyle |
| 4101 | |
| 4102 | * html/CanvasRenderingContext2D.cpp: |
| 4103 | (WebCore::CanvasRenderingContext2D::fillRect): |
| 4104 | * html/CanvasStyle.cpp: |
| 4105 | * html/HTMLCanvasElement.cpp: |
| 4106 | |
| 4107 | 2008-08-14 Eric Seidel <eric@webkit.org> |
| 4108 | |
| 4109 | Reviewed by Alexey. |
| 4110 | |
eric@webkit.org | 4f49065 | 2008-08-14 23:19:31 +0000 | [diff] [blame] | 4111 | Clean up GlyphBuffer.h, removing more #ifdefs |
| 4112 | |
| 4113 | * platform/graphics/GlyphBuffer.h: |
| 4114 | (WebCore::GlyphBuffer::glyphAt): |
| 4115 | (WebCore::GlyphBuffer::advanceAt): |
| 4116 | (WebCore::GlyphBuffer::add): |
| 4117 | |
| 4118 | 2008-08-14 Eric Seidel <eric@webkit.org> |
| 4119 | |
eric@webkit.org | 89613d2 | 2008-08-14 23:19:17 +0000 | [diff] [blame] | 4120 | Reviewed by Sam. |
| 4121 | |
| 4122 | Clean up AffineTransform.h, removing #ifdefs |
| 4123 | |
| 4124 | * platform/graphics/AffineTransform.h: |
| 4125 | * platform/graphics/cairo/AffineTransformCairo.cpp: |
| 4126 | * platform/graphics/cg/AffineTransformCG.cpp: |
| 4127 | * platform/graphics/qt/AffineTransformQt.cpp: |
| 4128 | * platform/graphics/wx/AffineTransformWx.cpp: |
| 4129 | |
mitz@apple.com | 551d625 | 2008-08-14 23:08:09 +0000 | [diff] [blame] | 4130 | 2008-08-14 Dan Bernstein <mitz@apple.com> |
| 4131 | |
mitz@apple.com | 94c1a7d | 2008-08-14 23:12:34 +0000 | [diff] [blame] | 4132 | - fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size(). |
| 4133 | |
| 4134 | * platform/graphics/cairo/ImageSourceCairo.cpp: |
| 4135 | (WebCore::ImageSource::frameSizeAtIndex): |
| 4136 | * platform/graphics/qt/ImageSourceQt.cpp: |
| 4137 | (WebCore::ImageSource::frameSizeAtIndex): |
| 4138 | * platform/graphics/wx/ImageSourceWx.cpp: |
| 4139 | (WebCore::ImageSource::frameSizeAtIndex): |
| 4140 | |
| 4141 | 2008-08-14 Dan Bernstein <mitz@apple.com> |
| 4142 | |
mitz@apple.com | 551d625 | 2008-08-14 23:08:09 +0000 | [diff] [blame] | 4143 | Reviewed by Brady Eidson. |
| 4144 | |
| 4145 | - fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped |
| 4146 | |
| 4147 | * platform/graphics/BitmapImage.cpp: |
| 4148 | (WebCore::BitmapImage::BitmapImage): Added initialization of |
| 4149 | m_hasUniformFrameSize. |
| 4150 | (WebCore::BitmapImage::cacheFrame): Added code to get the size of the |
| 4151 | cached frame for use in decoded size computation and for setting |
| 4152 | m_hasUniformFrameSize. |
| 4153 | (WebCore::BitmapImage::currentFrameSize): Added. |
| 4154 | (WebCore::BitmapImage::dataChanged): Added code to reset |
| 4155 | m_hasUniformFrameSize. |
| 4156 | * platform/graphics/BitmapImage.h: Added currentFrameSize() and |
| 4157 | m_hasUniformFrameSize. |
| 4158 | * platform/graphics/ImageSource.h: Added frameSizeAtIndex(). |
| 4159 | * platform/graphics/cg/ImageCG.cpp: |
| 4160 | (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This |
| 4161 | fixes the bug, which resulted from assuming that the frame being drawn |
| 4162 | was the same size as the first frame. |
| 4163 | * platform/graphics/cg/ImageSourceCG.cpp: |
| 4164 | (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and |
| 4165 | changed to get the size of the frame at the given index. |
| 4166 | (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0). |
| 4167 | |
simon.fraser@apple.com | 50954e5 | 2008-08-14 23:04:41 +0000 | [diff] [blame] | 4168 | 2008-08-13 Simon Fraser <simon.fraser@apple.com> |
| 4169 | |
| 4170 | Reviewed by Eric Seidel |
| 4171 | |
| 4172 | Fix @font-face inside @media rule crash. |
| 4173 | https://bugs.webkit.org/show_bug.cgi?id=20367 |
| 4174 | |
| 4175 | Test: fast/css/font-face-in-media-rule.html |
| 4176 | |
| 4177 | * css/CSSStyleSelector.cpp: |
| 4178 | (WebCore::CSSRuleSet::addRulesFromSheet): |
| 4179 | |
kevino@webkit.org | 141c460 | 2008-08-14 22:52:55 +0000 | [diff] [blame] | 4180 | 2008-08-14 Kevin Ollivier <kevino@theolliviers.com> |
| 4181 | |
| 4182 | wx build fixes after recent changes to Canvas and Image classes. |
| 4183 | |
| 4184 | * platform/graphics/Pattern.h: |
| 4185 | * platform/graphics/wx/GradientWx.cpp: |
| 4186 | (WebCore::Gradient::fill): |
| 4187 | * platform/graphics/wx/GraphicsContextWx.cpp: |
| 4188 | (WebCore::GraphicsContext::applyFillPattern): |
| 4189 | (WebCore::GraphicsContext::applyStrokePattern): |
| 4190 | * platform/graphics/wx/ImageBufferWx.cpp: |
| 4191 | (WebCore::ImageBuffer::image): |
| 4192 | * platform/graphics/wx/ImageWx.cpp: |
| 4193 | (WebCore::Image::loadPlatformResource): |
| 4194 | |
britto@apple.com | d700866 | 2008-08-14 19:26:02 +0000 | [diff] [blame] | 4195 | 2008-08-14 Maxime Britto <britto@apple.com> |
| 4196 | |
| 4197 | Reviewed by Sam Weinig. |
| 4198 | |
| 4199 | rdar://6102511 |
| 4200 | When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored |
| 4201 | IE and FF are both preventing the keyboard event to interact with the page while scrolling. |
| 4202 | Some differences exist between them concerning the kind of key which is pressed : |
| 4203 | IE7 : every key leads to a stop of the panning |
| 4204 | FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive. |
| 4205 | For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too. |
| 4206 | |
| 4207 | * page/EventHandler.cpp: |
| 4208 | (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event. |
| 4209 | |
christian@webkit.org | 0e20f32 | 2008-08-14 19:14:47 +0000 | [diff] [blame] | 4210 | 2008-08-14 Christian Dywan <christian@twotoasts.de> |
| 4211 | |
| 4212 | Gtk+/ Cairo build fix, patch by Dirk Schulze. |
| 4213 | |
| 4214 | * html/CanvasStyle.cpp: |
| 4215 | * platform/graphics/cairo/PatternCairo.cpp: |
| 4216 | (WebCore::Pattern::createPlatformPattern): |
| 4217 | * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: |
| 4218 | |
kmccullough@apple.com | d2b50f1 | 2008-08-14 18:11:20 +0000 | [diff] [blame] | 4219 | 2008-08-14 Kevin McCullough <kmccullough@apple.com> |
| 4220 | |
| 4221 | Reviewed by Tim. |
| 4222 | |
| 4223 | <rdar://problem/6115819> Notify of profile in console |
| 4224 | |
| 4225 | * page/InspectorController.cpp: |
| 4226 | (WebCore::InspectorController::addProfile): |
| 4227 | (WebCore::InspectorController::addProfileMessageToConsole): Called by |
| 4228 | addProfile this is the function that adds a message to the console that |
| 4229 | a profile finished. |
| 4230 | * page/InspectorController.h: |
| 4231 | * page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match |
| 4232 | the console log to the profile in the web inspector. |
| 4233 | (WebCore::getUniqueIdCallback): |
| 4234 | (WebCore::ProfileClass): |
| 4235 | * page/inspector/ProfilesPanel.js: Created a map of all the profiles by |
| 4236 | Id to bring up the requested profile. Also select and reveal the |
| 4237 | profile in the profile panel. And created displayTitleForProfileLink() |
| 4238 | which formats a title taking into account if it's user initiated or if |
| 4239 | there are multiples. Lasty, I put the user initiated profile in a |
| 4240 | variable. |
| 4241 | * page/inspector/inspector.js: Make the profile title be a clickable |
| 4242 | link that will take the user to the identified profile. Also expose |
| 4243 | the count of user initiated profiles so they can be displayed in the |
| 4244 | console with the correct count. |
| 4245 | |
timothy@apple.com | cd7f0f3 | 2008-08-14 17:41:05 +0000 | [diff] [blame] | 4246 | 2008-08-14 Timothy Hatcher <timothy@apple.com> |
| 4247 | |
| 4248 | Avoid formating ConsoleMessages twice unless the message will be |
| 4249 | displayed in bubbles of a SourceFrame. |
| 4250 | |
| 4251 | Reviewed by Kevin McCullough. |
| 4252 | |
| 4253 | * page/inspector/Console.js: |
| 4254 | (WebInspector.ConsoleMessage): Only format the plain text message |
| 4255 | if the URL and line are valid and the level is error or warning. |
| 4256 | (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added. |
| 4257 | Helper to test for error or warning level. |
| 4258 | * page/inspector/SourceFrame.js: |
| 4259 | (WebInspector.SourceFrame.prototype.addMessage): Don't add the |
| 4260 | message if there is no message or valid line or if the msg |
| 4261 | isn't an error or warning. |
| 4262 | |
jmalonzo@webkit.org | b469bb7 | 2008-08-14 15:07:41 +0000 | [diff] [blame] | 4263 | 2008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org> |
| 4264 | |
| 4265 | partial Gtk build fix, not reviewed |
| 4266 | |
| 4267 | * platform/graphics/cairo/PatternCairo.cpp: |
| 4268 | |
weinig@apple.com | 45e8314 | 2008-08-14 04:49:30 +0000 | [diff] [blame] | 4269 | 2008-08-13 Sam Weinig <sam@webkit.org> |
| 4270 | |
| 4271 | Reviewed by Anders Carlson. |
| 4272 | |
| 4273 | Fix style issue. |
| 4274 | |
| 4275 | * html/HTMLMediaElement.cpp: |
| 4276 | (WebCore::HTMLMediaElement::pickMedia): |
| 4277 | |
zimmermann@webkit.org | 9ae47e9 | 2008-08-14 02:22:35 +0000 | [diff] [blame] | 4278 | 2008-08-13 Nikolas Zimmermann <zimmermann@kde.org> |
| 4279 | |
zimmermann@webkit.org | 7a2f53d | 2008-08-14 03:06:01 +0000 | [diff] [blame] | 4280 | Build fix for Cairo, not reviewed. (exposed by gtk build slave) |
| 4281 | Continue Erics build fixes, after the Image cleanup. |
| 4282 | |
| 4283 | * platform/graphics/cairo/ImageBufferCairo.cpp: |
| 4284 | (WebCore::ImageBuffer::image): |
| 4285 | |
| 4286 | 2008-08-13 Nikolas Zimmermann <zimmermann@kde.org> |
| 4287 | |
zimmermann@webkit.org | 1ef5213 | 2008-08-14 02:38:16 +0000 | [diff] [blame] | 4288 | Build fix for Qt, not reviewed. |
| 4289 | Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM. |
| 4290 | |
| 4291 | * dom/XMLTokenizer.cpp: |
| 4292 | (WebCore::eventuallyMarkAsParserCreated): Was erre |
| 4293 | |
| 4294 | 2008-08-13 Nikolas Zimmermann <zimmermann@kde.org> |
| 4295 | |
zimmermann@webkit.org | 3e56056 | 2008-08-14 02:26:00 +0000 | [diff] [blame] | 4296 | Build fix, not reviewed. |
| 4297 | Add ScriptElement.cpp to Gtk build. |
| 4298 | |
| 4299 | * GNUmakefile.am: |
| 4300 | |
| 4301 | 2008-08-13 Nikolas Zimmermann <zimmermann@kde.org> |
| 4302 | |
zimmermann@webkit.org | 9ae47e9 | 2008-08-14 02:22:35 +0000 | [diff] [blame] | 4303 | Reviewed by Eric. |
| 4304 | |
| 4305 | Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372 |
| 4306 | |
| 4307 | Refactor HTMLScriptElement's code into a common base class: ScriptElement. |
| 4308 | SVGScriptElement will be converted to use ScriptElement in a follow-up patch. |
| 4309 | |
| 4310 | This resolves code duplications and allows us to completly replace the old |
| 4311 | SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..) |
| 4312 | |
| 4313 | As ScriptElement, doesn't actually inherit from Element, we may want to rename |
| 4314 | it, though StyleElement uses the same naming convention, so I left it as is for now. |
| 4315 | Eventually we'll rename both files in future. |
| 4316 | |
| 4317 | No functional changes yet, as SVGScriptElement doesn't yet use the new base class. |
| 4318 | |
| 4319 | * WebCore.pro: Add new ScriptElement.cpp to build. |
| 4320 | * WebCore.vcproj/WebCore.vcproj: Ditto. |
| 4321 | * WebCore.xcodeproj/project.pbxproj: Ditto. |
| 4322 | * WebCoreSources.bkl: Dutto. |
| 4323 | * dom/ScriptElement.cpp: Added. 1:1 based on HTMLScriptElement |
| 4324 | (WebCore::ScriptElement::insertedIntoDocument): |
| 4325 | (WebCore::ScriptElement::removedFromDocument): |
| 4326 | (WebCore::ScriptElement::childrenChanged): |
| 4327 | (WebCore::ScriptElement::finishParsingChildren): |
| 4328 | (WebCore::ScriptElement::handleSourceAttribute): |
| 4329 | (WebCore::isSupportedJavaScriptLanguage): |
| 4330 | (WebCore::ScriptElementData::ScriptElementData): |
| 4331 | (WebCore::ScriptElementData::~ScriptElementData): |
| 4332 | (WebCore::ScriptElementData::requestScript): |
| 4333 | (WebCore::ScriptElementData::evaluateScript): |
| 4334 | (WebCore::ScriptElementData::stopLoadRequest): |
| 4335 | (WebCore::ScriptElementData::notifyFinished): |
| 4336 | (WebCore::ScriptElementData::ignoresLoadRequest): |
| 4337 | (WebCore::ScriptElementData::shouldExecuteAsJavaScript): |
| 4338 | (WebCore::ScriptElementData::scriptCharset): |
| 4339 | (WebCore::ScriptElementData::scriptContent): |
| 4340 | * dom/ScriptElement.h: Added. |
| 4341 | (WebCore::ScriptElement::ScriptElement): |
| 4342 | (WebCore::ScriptElement::~ScriptElement): |
| 4343 | (WebCore::ScriptElementData::element): |
| 4344 | (WebCore::ScriptElementData::createdByParser): |
| 4345 | (WebCore::ScriptElementData::setCreatedByParser): |
| 4346 | * dom/XMLTokenizer.cpp: |
| 4347 | (WebCore::isScriptElement): |
| 4348 | (WebCore::castToScriptElement): |
| 4349 | (WebCore::eventuallyMarkAsParserCreated): |
| 4350 | (WebCore::XMLTokenizer::startElementNs): |
| 4351 | (WebCore::XMLTokenizer::endElementNs): |
| 4352 | (WebCore::createXHTMLParserErrorHeader): |
| 4353 | (WebCore::XMLTokenizer::insertErrorMessageBlock): |
| 4354 | * html/HTMLScriptElement.cpp: Refactored code, pushed most code down to ScriptElement. |
| 4355 | (WebCore::HTMLScriptElement::HTMLScriptElement): |
| 4356 | (WebCore::HTMLScriptElement::~HTMLScriptElement): |
| 4357 | (WebCore::HTMLScriptElement::isURLAttribute): |
| 4358 | (WebCore::HTMLScriptElement::setCreatedByParser): |
| 4359 | (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): |
| 4360 | (WebCore::HTMLScriptElement::childrenChanged): |
| 4361 | (WebCore::HTMLScriptElement::parseMappedAttribute): |
| 4362 | (WebCore::HTMLScriptElement::finishParsingChildren): |
| 4363 | (WebCore::HTMLScriptElement::insertedIntoDocument): |
| 4364 | (WebCore::HTMLScriptElement::removedFromDocument): |
| 4365 | (WebCore::HTMLScriptElement::text): |
| 4366 | (WebCore::HTMLScriptElement::setText): |
| 4367 | (WebCore::HTMLScriptElement::setHtmlFor): |
| 4368 | (WebCore::HTMLScriptElement::setEvent): |
| 4369 | (WebCore::HTMLScriptElement::charset): |
| 4370 | (WebCore::HTMLScriptElement::src): |
| 4371 | (WebCore::HTMLScriptElement::type): |
| 4372 | (WebCore::HTMLScriptElement::scriptCharset): |
| 4373 | (WebCore::HTMLScriptElement::scriptContent): |
| 4374 | (WebCore::HTMLScriptElement::sourceAttributeValue): |
| 4375 | (WebCore::HTMLScriptElement::charsetAttributeValue): |
| 4376 | (WebCore::HTMLScriptElement::typeAttributeValue): |
| 4377 | (WebCore::HTMLScriptElement::languageAttributeValue): |
| 4378 | (WebCore::HTMLScriptElement::dispatchLoadEvent): |
| 4379 | (WebCore::HTMLScriptElement::dispatchErrorEvent): |
| 4380 | * html/HTMLScriptElement.h: |
| 4381 | * svg/SVGScriptElement.cpp: Inherit from ScriptElement, don't actually use it yet. |
| 4382 | * svg/SVGScriptElement.cpp: |
| 4383 | (WebCore::SVGScriptElement::SVGScriptElement): |
| 4384 | (WebCore::SVGScriptElement::scriptContent): |
| 4385 | (WebCore::SVGScriptElement::sourceAttributeValue): |
| 4386 | (WebCore::SVGScriptElement::charsetAttributeValue): |
| 4387 | (WebCore::SVGScriptElement::typeAttributeValue): |
| 4388 | (WebCore::SVGScriptElement::languageAttributeValue): |
| 4389 | (WebCore::SVGScriptElement::dispatchLoadEvent): |
| 4390 | (WebCore::SVGScriptElement::dispatchErrorEvent): |
| 4391 | * svg/SVGScriptElement.h: |
| 4392 | (WebCore::SVGScriptElement::setCreatedByParser): |
| 4393 | |
eric@webkit.org | 7811ef0 | 2008-08-14 00:28:51 +0000 | [diff] [blame] | 4394 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4395 | |
eric@webkit.org | 3562c59 | 2008-08-14 02:17:29 +0000 | [diff] [blame] | 4396 | Attempt to fix the Gtk build, no review. |
| 4397 | |
| 4398 | I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process. |
| 4399 | |
| 4400 | * platform/graphics/GraphicsContext.h: |
| 4401 | * platform/graphics/cairo/GraphicsContextCairo.cpp: |
| 4402 | * platform/graphics/qt/GradientQt.cpp: |
| 4403 | * platform/graphics/qt/GraphicsContextQt.cpp: |
| 4404 | * platform/gtk/RenderThemeGtk.cpp: |
| 4405 | (WebCore::paintMozWidget): |
| 4406 | |
| 4407 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4408 | |
eric@webkit.org | 2ec4207 | 2008-08-14 02:03:09 +0000 | [diff] [blame] | 4409 | Yet another attempt to fix the Qt build, no review. |
| 4410 | |
| 4411 | * platform/graphics/qt/GradientQt.cpp: |
| 4412 | * platform/graphics/qt/GraphicsContextQt.cpp: |
| 4413 | (WebCore::GraphicsContext::applyStrokePattern): |
| 4414 | (WebCore::GraphicsContext::applyFillPattern): |
| 4415 | |
| 4416 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4417 | |
| 4418 | Attempt to fix the Windows build, no review. |
| 4419 | |
| 4420 | * platform/win/CursorWin.cpp: |
| 4421 | (WebCore::loadCursorByName): |
| 4422 | * platform/win/ScrollViewWin.cpp: |
| 4423 | (WebCore::ScrollView::paint): |
| 4424 | |
| 4425 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4426 | |
eric@webkit.org | 508c028 | 2008-08-14 01:29:34 +0000 | [diff] [blame] | 4427 | Attempt to fix the Windows build, no review. |
| 4428 | |
| 4429 | * platform/win/CursorWin.cpp: |
| 4430 | (WebCore::loadCursorByName): |
| 4431 | * platform/win/ScrollViewWin.cpp: |
| 4432 | (WebCore::ScrollView::paint): |
| 4433 | |
| 4434 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4435 | |
eric@webkit.org | 1bf70ab | 2008-08-14 01:24:15 +0000 | [diff] [blame] | 4436 | Attempt to fix the Qt build, no review. |
| 4437 | |
| 4438 | * platform/graphics/qt/ImageBufferQt.cpp: |
| 4439 | (WebCore::ImageBuffer::image): |
| 4440 | |
| 4441 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4442 | |
eric@webkit.org | f2d7c21 | 2008-08-14 01:21:34 +0000 | [diff] [blame] | 4443 | Attempt to fix the Windows build, no review. |
| 4444 | |
| 4445 | * platform/graphics/win/ImageWin.cpp: |
| 4446 | (WebCore::Image::loadPlatformResource): |
| 4447 | * plugins/win/PluginViewWin.cpp: |
| 4448 | (WebCore::PluginView::paintMissingPluginIcon): |
| 4449 | |
| 4450 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4451 | |
eric@webkit.org | ac3f666 | 2008-08-14 01:15:50 +0000 | [diff] [blame] | 4452 | Another attempt to fix the Qt build, no review. |
| 4453 | |
| 4454 | * platform/graphics/qt/ImageQt.cpp: |
| 4455 | * platform/graphics/qt/StillImageQt.h: |
| 4456 | |
| 4457 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4458 | |
eric@webkit.org | 31e0d81 | 2008-08-14 01:05:42 +0000 | [diff] [blame] | 4459 | No review, build fix only. |
| 4460 | |
| 4461 | Fix mac build, due to change in new code since my patch was written. |
| 4462 | |
| 4463 | * svg/graphics/cg/SVGResourceMaskerCg.mm: |
| 4464 | (WebCore::SVGResourceMasker::applyMask): |
| 4465 | |
| 4466 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4467 | |
eric@webkit.org | a20a003 | 2008-08-14 00:42:54 +0000 | [diff] [blame] | 4468 | Build fix only, no review. |
| 4469 | |
| 4470 | Attempt to fix the Qt build. |
| 4471 | |
eric@webkit.org | 923255c | 2008-08-14 00:59:20 +0000 | [diff] [blame] | 4472 | * platform/graphics/qt/ImageBufferQt.cpp: |
| 4473 | * platform/graphics/qt/StillImageQt.h: |
| 4474 | (WebCore::StillImage::create): |
| 4475 | (WebCore::StillImage::destroyDecodedData): |
| 4476 | (WebCore::StillImage::decodedSize): |
| 4477 | |
| 4478 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4479 | |
| 4480 | Build fix only, no review. |
| 4481 | |
| 4482 | Attempt to fix the Qt build. |
| 4483 | |
eric@webkit.org | a20a003 | 2008-08-14 00:42:54 +0000 | [diff] [blame] | 4484 | * html/CanvasStyle.cpp: |
| 4485 | (WebCore::CanvasStyle::applyStrokeColor): |
| 4486 | (WebCore::CanvasStyle::applyFillColor): |
| 4487 | |
| 4488 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4489 | |
eric@webkit.org | 4aca3be | 2008-08-14 00:30:04 +0000 | [diff] [blame] | 4490 | Reviewed by Sam. |
| 4491 | |
| 4492 | Match HTML5 spec by throwing INVALID_STATE_ERR when |
| 4493 | createPattern is called and the HTMLImageElement is not |
| 4494 | yet done loading the image (!isComplete) |
| 4495 | https://bugs.webkit.org/show_bug.cgi?id=20351 |
| 4496 | |
| 4497 | Test: http/misc/canvas-pattern-from-incremental-image.html |
| 4498 | |
| 4499 | * html/CanvasRenderingContext2D.cpp: |
| 4500 | (WebCore::CanvasRenderingContext2D::createPattern): |
| 4501 | |
| 4502 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4503 | |
eric@webkit.org | 5b26560 | 2008-08-14 00:29:26 +0000 | [diff] [blame] | 4504 | Reviewed by Niko. |
| 4505 | |
eric@webkit.org | f0124f6 | 2008-08-14 00:29:50 +0000 | [diff] [blame] | 4506 | Split out a Pattern class from CanvasPattern |
| 4507 | and remove all the Pattern-related #ifdefs |
| 4508 | (This will break non-mac platforms! I will fix them.) |
| 4509 | https://bugs.webkit.org/show_bug.cgi?id=20351 |
| 4510 | |
| 4511 | * GNUmakefile.am: |
| 4512 | * WebCore.pro: |
| 4513 | * WebCore.vcproj/WebCore.vcproj: |
| 4514 | * WebCore.xcodeproj/project.pbxproj: |
| 4515 | * WebCoreSources.bkl: |
| 4516 | * html/CanvasPattern.cpp: |
| 4517 | (WebCore::CanvasPattern::parseRepetitionType): |
| 4518 | (WebCore::CanvasPattern::CanvasPattern): |
| 4519 | * html/CanvasPattern.h: |
| 4520 | (WebCore::CanvasPattern::create): |
| 4521 | (WebCore::CanvasPattern::pattern): |
| 4522 | (WebCore::CanvasPattern::originClean): |
| 4523 | * html/CanvasRenderingContext2D.cpp: |
| 4524 | (WebCore::CanvasRenderingContext2D::createPattern): |
| 4525 | (WebCore::CanvasRenderingContext2D::applyStrokePattern): |
| 4526 | (WebCore::CanvasRenderingContext2D::applyFillPattern): |
| 4527 | * html/CanvasRenderingContext2D.h: |
| 4528 | * html/HTMLCanvasElement.cpp: |
| 4529 | * html/HTMLCanvasElement.h: |
| 4530 | * loader/FrameLoader.cpp: |
| 4531 | (WebCore::FrameLoader::createHistoryItem): |
| 4532 | * platform/graphics/GraphicsContext.h: |
| 4533 | * platform/graphics/cairo/GraphicsContextCairo.cpp: |
| 4534 | (WebCore::GraphicsContext::applyStrokePattern): |
| 4535 | (WebCore::GraphicsContext::applyFillPattern): |
| 4536 | * platform/graphics/cg/GraphicsContextCG.cpp: |
| 4537 | (WebCore::GraphicsContext::clipToImageBuffer): |
| 4538 | (WebCore::GraphicsContext::applyStrokePattern): |
| 4539 | (WebCore::GraphicsContext::applyFillPattern): |
| 4540 | |
| 4541 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4542 | |
| 4543 | Reviewed by Niko. |
| 4544 | |
eric@webkit.org | 5b26560 | 2008-08-14 00:29:26 +0000 | [diff] [blame] | 4545 | Make Images RefCounted (and clean up callers) |
| 4546 | https://bugs.webkit.org/show_bug.cgi?id=20351 |
| 4547 | |
| 4548 | * editing/DeleteButtonController.cpp: |
| 4549 | (WebCore::DeleteButtonController::createDeletionUI): |
| 4550 | * loader/CachedImage.cpp: |
| 4551 | (WebCore::CachedImage::CachedImage): |
| 4552 | (WebCore::brokenImage): |
| 4553 | (WebCore::nullImage): |
| 4554 | (WebCore::CachedImage::image): |
| 4555 | (WebCore::CachedImage::notifyObservers): |
| 4556 | (WebCore::CachedImage::createImage): |
| 4557 | * loader/CachedImage.h: |
| 4558 | * loader/icon/IconRecord.cpp: |
| 4559 | (WebCore::IconRecord::setImageData): |
| 4560 | (WebCore::IconRecord::loadImageFromResource): |
| 4561 | * loader/icon/IconRecord.h: |
| 4562 | * platform/graphics/BitmapImage.h: |
| 4563 | (WebCore::BitmapImage::create): |
| 4564 | * platform/graphics/GeneratedImage.h: |
| 4565 | * platform/graphics/Gradient.cpp: |
| 4566 | * platform/graphics/Gradient.h: |
| 4567 | * platform/graphics/Image.cpp: |
| 4568 | (WebCore::Image::nullImage): |
| 4569 | * platform/graphics/Image.h: |
| 4570 | * platform/graphics/ImageBuffer.h: |
| 4571 | * platform/graphics/cairo/ImageBufferCairo.cpp: |
| 4572 | (WebCore::ImageBuffer::image): |
| 4573 | * platform/graphics/cg/ImageBufferCG.cpp: |
| 4574 | (WebCore::ImageBuffer::image): |
| 4575 | (WebCore::ImageBuffer::getImageData): |
| 4576 | (WebCore::ImageBuffer::putImageData): |
| 4577 | * platform/graphics/cg/PDFDocumentImage.h: |
| 4578 | (WebCore::PDFDocumentImage::create): |
| 4579 | (WebCore::PDFDocumentImage::destroyDecodedData): |
| 4580 | (WebCore::PDFDocumentImage::decodedSize): |
| 4581 | * platform/graphics/gtk/ImageGtk.cpp: |
| 4582 | (WebCore::Image::loadPlatformResource): |
| 4583 | * platform/graphics/mac/ImageMac.mm: |
| 4584 | (WebCore::Image::loadPlatformResource): |
| 4585 | * rendering/RenderImage.cpp: |
| 4586 | * rendering/RenderLayer.cpp: |
| 4587 | (WebCore::RenderLayer::paintOverflowControls): |
| 4588 | * svg/graphics/SVGImage.cpp: |
| 4589 | (WebCore::SVGImage::nativeImageForCurrentFrame): |
| 4590 | * svg/graphics/SVGImage.h: |
| 4591 | (WebCore::SVGImage::create): |
| 4592 | (WebCore::SVGImage::destroyDecodedData): |
| 4593 | (WebCore::SVGImage::decodedSize): |
| 4594 | (WebCore::SVGImage::frameAtIndex): |
| 4595 | * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: |
| 4596 | (WebCore::SVGPaintServerPattern::setup): |
| 4597 | * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: |
| 4598 | (WebCore::SVGResourceMasker::applyMask): |
| 4599 | * svg/graphics/cg/SVGPaintServerPatternCg.cpp: |
| 4600 | (WebCore::patternCallback): |
| 4601 | * svg/graphics/cg/SVGResourceMaskerCg.mm: |
| 4602 | (WebCore::SVGResourceMasker::applyMask): |
| 4603 | |
| 4604 | 2008-08-13 Eric Seidel <eric@webkit.org> |
| 4605 | |
| 4606 | Reviewed by Niko. |
eric@webkit.org | 7811ef0 | 2008-08-14 00:28:51 +0000 | [diff] [blame] | 4607 | |
| 4608 | Remove #ifdefs from CanvasStyle by using platform/Color.h |
eric@webkit.org | 5b26560 | 2008-08-14 00:29:26 +0000 | [diff] [blame] | 4609 | https://bugs.webkit.org/show_bug.cgi?id=20351 |
eric@webkit.org | 7811ef0 | 2008-08-14 00:28:51 +0000 | [diff] [blame] | 4610 | |
| 4611 | There are some down-sides to this commit. |
| 4612 | This commit limits us to 255 levels of grey for calls like: |
| 4613 | context.setStrokeStyle(.37, 1.0) |
| 4614 | previously CG might have used up to 32bits to store the grey level |
| 4615 | Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice. |
| 4616 | |
| 4617 | Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited |
| 4618 | to RGBA32 (like all the rest of colors in WebCore), thus: |
| 4619 | context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as: |
| 4620 | context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32 |
| 4621 | |
| 4622 | If this is a problem for Dashboard, we can either roll out this commit |
| 4623 | or add a beefier Color abstraction, which can be used internally by GraphicsContext |
| 4624 | when keeping state, and then GraphicsContext can grow some additional set* routines |
| 4625 | for setting the a grey/float/whatever fill and stroke. |
| 4626 | |
| 4627 | * html/CanvasRenderingContext2D.cpp: |
| 4628 | (WebCore::CanvasRenderingContext2D::setFillStyle): |
| 4629 | * html/CanvasStyle.cpp: |
| 4630 | (WebCore::CanvasStyle::CanvasStyle): |
| 4631 | (WebCore::colorWithOverrideAlpha): |
| 4632 | (WebCore::CanvasStyle::applyStrokeColor): |
| 4633 | (WebCore::CanvasStyle::applyFillColor): |
| 4634 | * html/CanvasStyle.h: |
| 4635 | * platform/graphics/Color.cpp: |
| 4636 | (WebCore::colorFloatToRGBAByte): |
| 4637 | (WebCore::makeRGBA32FromFloats): |
| 4638 | * platform/graphics/Color.h: |
| 4639 | |
adele@apple.com | 83e4482 | 2008-08-13 23:50:41 +0000 | [diff] [blame] | 4640 | 2008-08-13 Eric Carlson <eric.carlson@apple.com> |
| 4641 | |
| 4642 | Reviewed by Adele Peterson. |
| 4643 | |
| 4644 | Fix for <rdar://problem/6137931> |
| 4645 | https://bugs.webkit.org/show_bug.cgi?id=20360 |
| 4646 | Remove all parameters from the MIME type before checking with the MIME type registry |
| 4647 | |
| 4648 | Tests: media/video-source-type-params.html |
| 4649 | |
| 4650 | * html/HTMLMediaElement.cpp: |
| 4651 | (WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';' |
| 4652 | to isSupportedMediaMIMEType() |
| 4653 | |
bdakin@apple.com | 7bc81bf | 2008-08-13 21:36:15 +0000 | [diff] [blame] | 4654 | 2008-08-13 Beth Dakin <bdakin@apple.com> |
| 4655 | |
| 4656 | Reviewed by Sam Weinig. |
| 4657 | |
| 4658 | Fix for <rdar://problem/6141345> |
| 4659 | |
| 4660 | This patch refines findString and markAllMatchesForText functions' |
| 4661 | interactions with disconnected frames. They no longer rely on |
| 4662 | knowing where a range is relative to the visible region and work |
| 4663 | with disconnected frames that contain frames. |
| 4664 | |
| 4665 | * editing/Editor.cpp: |
| 4666 | (WebCore::Editor::insideVisibleArea): Now returns a bool instead of |
| 4667 | the visiblity enum. |
| 4668 | (WebCore::Editor::firstVisibleRange): This now returns the very |
| 4669 | first visible range in the document. It's no longer dependent on |
| 4670 | searching forward. |
| 4671 | (WebCore::Editor::lastVisibleRange): This now returns the very last |
| 4672 | visible range in the document. It's no longer dependent on |
| 4673 | searching backwards. |
| 4674 | (WebCore::Editor::nextVisibleRange): This returns the next visible |
| 4675 | range in the appropriate direction from the current range. |
| 4676 | * editing/Editor.h: |
| 4677 | * page/Frame.cpp: |
| 4678 | (WebCore::Frame::findString): |
| 4679 | (WebCore::Frame::markAllMatchesForText): |
| 4680 | |
kevino@webkit.org | ee5adc4 | 2008-08-13 20:07:16 +0000 | [diff] [blame] | 4681 | 2008-08-13 Kevin Ollivier <kevino@theolliviers.com> |
| 4682 | |
| 4683 | wx build fix for case-sensitive platforms, like Linux. |
| 4684 | |
| 4685 | * WebCoreSources.bkl: |
| 4686 | |
jmalonzo@webkit.org | 210145b | 2008-08-13 19:56:20 +0000 | [diff] [blame] | 4687 | 2008-08-13 Marco Barisione <marco.barisione@collabora.co.uk> |
| 4688 | |
| 4689 | Reviewed by Holger Freyther. |
| 4690 | |
| 4691 | http://bugs.webkit.org/show_bug.cgi?id=16881 |
| 4692 | [GTK] PlatformScreenGtk is unimplemented |
| 4693 | |
| 4694 | Original patch by Christian Dywan. |
| 4695 | |
| 4696 | * platform/gtk/PlatformScreenGtk.cpp: |
| 4697 | (WebCore::screenDepth): |
| 4698 | (WebCore::screenDepthPerComponent): |
| 4699 | (WebCore::screenIsMonochrome): |
| 4700 | (WebCore::screenRect): |
| 4701 | (WebCore::screenAvailableRect): |
| 4702 | |
jmalonzo@webkit.org | e469393 | 2008-08-13 19:42:08 +0000 | [diff] [blame] | 4703 | 2008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org> |
| 4704 | |
| 4705 | Reviewed by Holger Freyther. |
| 4706 | |
| 4707 | http://bugs.webkit.org/show_bug.cgi?id=20318 |
| 4708 | SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add |
| 4709 | |
| 4710 | g_idle_add is the same as g_idle_add_full with a priority of |
| 4711 | G_PRIORITY_DEFAULT_IDLE, so we can safely use that. |
| 4712 | |
| 4713 | * platform/gtk/SharedTimerGtk.cpp: |
| 4714 | (WebCore::setSharedTimerFireTime): |
| 4715 | |
timothy@apple.com | f042660 | 2008-08-13 18:11:01 +0000 | [diff] [blame] | 4716 | 2008-08-13 Timothy Hatcher <timothy@apple.com> |
| 4717 | |
| 4718 | Changed the InspectorController so it can be notified when the |
| 4719 | attached state of the Inspector changes in WebKit. |
| 4720 | |
| 4721 | Reviewed by Kevin McCullough. |
| 4722 | |
| 4723 | * WebCore.base.exp: Updated the symbol for setWindowVisible. |
| 4724 | * page/InspectorController.cpp: |
| 4725 | (WebCore::InspectorController::setWindowVisible): Added an attached argument, |
| 4726 | that defaults to false.Call setAttachedWindow with the attached argument. |
| 4727 | (WebCore::InspectorController::setAttachedWindow): Call the script version |
| 4728 | of setAttachedWindow. |
| 4729 | * page/InspectorController.h: |
| 4730 | * page/inspector/inspector.js: |
| 4731 | (WebInspector.setAttachedWindow): Set the attached property. |
| 4732 | |
timothy@apple.com | 9ea832b | 2008-08-13 18:10:36 +0000 | [diff] [blame] | 4733 | 2008-08-12 Timothy Hatcher <timothy@apple.com> |
| 4734 | |
timothy@apple.com | 72c92ae | 2008-08-13 18:10:45 +0000 | [diff] [blame] | 4735 | Added a close button to the Inspector's toolbar when docked. |
| 4736 | |
| 4737 | https://bugs.webkit.org/show_bug.cgi?id=14270 |
| 4738 | |
| 4739 | Reviewed by Kevin McCullough. |
| 4740 | |
| 4741 | * page/InspectorController.cpp: |
| 4742 | (WebCore::closeWindow): Call InspectorController::closeWindow. |
| 4743 | (WebCore::InspectorController::windowScriptObjectAvailable): |
| 4744 | Added closeWindow to the script class. |
| 4745 | * page/InspectorController.h: |
| 4746 | * page/inspector/Images/closeButtons.png: Added. |
| 4747 | * page/inspector/inspector.css: Added and changed styles. |
| 4748 | * page/inspector/inspector.html: Added the close button. |
| 4749 | * page/inspector/inspector.js: |
| 4750 | (WebInspector.loaded): Added click event listener to the close button. |
| 4751 | (WebInspector.close): Call InspectorController.closeWindow. |
| 4752 | |
| 4753 | 2008-08-12 Timothy Hatcher <timothy@apple.com> |
| 4754 | |
timothy@apple.com | 9ea832b | 2008-08-13 18:10:36 +0000 | [diff] [blame] | 4755 | Make the docked Web Inspector resizable. This is the cross platform |
| 4756 | portion of the code. Each InspectorClient needs to implement the |
| 4757 | real resize code. |
| 4758 | |
| 4759 | https://bugs.webkit.org/show_bug.cgi?id=14282 |
| 4760 | |
| 4761 | Reviewed by Kevin McCullough. |
| 4762 | |
| 4763 | * loader/EmptyClients.h: Added an empty setAttachedWindowHeight. |
| 4764 | * page/InspectorClient.h: Added setAttachedWindowHeight. |
| 4765 | * page/InspectorController.cpp: |
| 4766 | (WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight |
| 4767 | on the InspectorController. |
| 4768 | (WebCore::InspectorController::setAttachedWindowHeight): Call |
| 4769 | setAttachedWindowHeight on the client. |
| 4770 | (WebCore::InspectorController::windowScriptObjectAvailable): |
| 4771 | Added setAttachedWindowHeight to the script class. |
| 4772 | * page/InspectorController.h: |
| 4773 | * page/inspector/inspector.css: Make the cursor on the toolbar be |
| 4774 | row-resize when docked. |
| 4775 | * page/inspector/inspector.js: |
| 4776 | (WebInspector.loaded): Always add the toolbarDragStart event listener. |
| 4777 | (WebInspector.toolbarDragStart): Return early if we are not attached |
| 4778 | and not on Leopard. Call WebInspector.elementDragStart. |
| 4779 | (WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd. |
| 4780 | (WebInspector.toolbarDrag): When attached call setAttachedWindowHeight, |
| 4781 | otherwise call moveByUnrestricted. |
| 4782 | |
hausmann@webkit.org | d34f1d2 | 2008-08-13 13:43:34 +0000 | [diff] [blame] | 4783 | 2008-08-13 Simon Hausmann <hausmann@webkit.org> |
| 4784 | |
| 4785 | Reviewed by Holger. |
| 4786 | |
| 4787 | Initialize m_zoomsTextOnly in the Settings constructor. |
| 4788 | |
| 4789 | * page/Settings.cpp: |
| 4790 | (WebCore::Settings::Settings): |
| 4791 | |
hausmann@webkit.org | 74586d6 | 2008-08-13 13:31:11 +0000 | [diff] [blame] | 4792 | 2008-08-13 Brad Hughes <bhughes@trolltech.com> |
| 4793 | |
| 4794 | Reviewed by Simon. |
| 4795 | |
| 4796 | Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux |
| 4797 | |
| 4798 | The latest upgrade of the intel compiler allows us to compile all of |
| 4799 | Qt with optimizations enabled (yay!). |
| 4800 | |
| 4801 | * WebCore.pro: |
| 4802 | |
hausmann@webkit.org | 690b7fc | 2008-08-13 13:24:56 +0000 | [diff] [blame] | 4803 | 2008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com> |
| 4804 | |
| 4805 | Reviewed by Simon. |
| 4806 | |
| 4807 | Fix QtWebKit not displaying content on 403 HTTP responses |
| 4808 | |
| 4809 | Just like with 404 responses also display content with 403, as |
| 4810 | used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/ |
| 4811 | |
| 4812 | * platform/network/qt/QNetworkReplyHandler.cpp: |
| 4813 | (WebCore::QNetworkReplyHandler::finish): |
| 4814 | |
hausmann@webkit.org | 88c4dc9 | 2008-08-13 12:02:00 +0000 | [diff] [blame] | 4815 | 2008-08-13 Simon Hausmann <hausmann@webkit.org> |
| 4816 | |
hausmann@webkit.org | d2315e3 | 2008-08-13 13:16:15 +0000 | [diff] [blame] | 4817 | Reviewed by Holger. |
| 4818 | |
| 4819 | Qt part of https://bugs.webkit.org/show_bug.cgi?id=18994 |
| 4820 | |
| 4821 | Make the formatting of String::format() locale independent through the use of QString::vsprintf. |
| 4822 | |
| 4823 | * platform/text/String.cpp: |
| 4824 | (WebCore::String::format): |
| 4825 | |
| 4826 | 2008-08-13 Simon Hausmann <hausmann@webkit.org> |
| 4827 | |
hausmann@webkit.org | 88c4dc9 | 2008-08-13 12:02:00 +0000 | [diff] [blame] | 4828 | Reviewed by Lars. |
| 4829 | |
| 4830 | Fix QWebFrame::setHtml() not setting the new contents immediately. |
| 4831 | |
| 4832 | Added a setter to the DocumentLoader to toggle the deferred loading of the main |
| 4833 | resource when it comes from substitute data. |
| 4834 | |
| 4835 | Disable deferred loading of the main resource when we have valid substitute data, |
| 4836 | as used by QWebFrame::setHtml. |
| 4837 | |
| 4838 | * loader/DocumentLoader.h: |
| 4839 | |
mrowe@apple.com | 6aa36d1 | 2008-08-13 09:58:32 +0000 | [diff] [blame] | 4840 | 2008-08-13 Mark Rowe <mrowe@apple.com> |
| 4841 | |
| 4842 | Speculative GTK build fix. |
| 4843 | |
| 4844 | * GNUmakefile.am: Add dependency info for JSSVGElementWrapperFactory.cpp. |
| 4845 | |
hausmann@webkit.org | 298ce5f | 2008-08-13 09:11:23 +0000 | [diff] [blame] | 4846 | 2008-08-13 Thiago Macieira <tjmaciei@trolltech.com> |
| 4847 | |
| 4848 | Reviewed by Simon. |
| 4849 | |
| 4850 | Fix encoding of [ and ] in the host part of the URL |
| 4851 | |
| 4852 | Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to |
| 4853 | add this workaround to the QUrl <> WebCore::KURL conversion operator so that it |
| 4854 | doesn't encode [ and ] when they are found in the host part. That is, the |
| 4855 | following URL: |
| 4856 | http://[::1]/ |
| 4857 | is valid and should not be reencoded to: |
| 4858 | http://%5b::1%5d/ |
| 4859 | |
| 4860 | * platform/qt/KURLQt.cpp: |
| 4861 | (WebCore::KURL::operator QUrl): |
| 4862 | |
mitz@apple.com | e198b01 | 2008-08-12 21:49:07 +0000 | [diff] [blame] | 4863 | 2008-08-12 Mihnea Ovidenie <mihnea@adobe.com> |
| 4864 | |
| 4865 | Fix for https://bugs.webkit.org/show_bug.cgi?id=19891 |
| 4866 | Broken HTML object elements cause de-reference of pointer to freed memory. |
| 4867 | If we fail to load an image for an object tag and we no longer believe the object tag points at |
| 4868 | an image, then clear m_imageLoader in the HTMLObjectElement so that we attempt to render the |
| 4869 | fall back content. |
| 4870 | |
| 4871 | Reviewed by Dave Hyatt and Alexey Proskuryakov. |
| 4872 | |
| 4873 | Test: http/tests/misc/object-image-error-with-onload.html |
| 4874 | |
| 4875 | * html/HTMLObjectElement.cpp: |
| 4876 | (WebCore::HTMLObjectElement::renderFallbackContent): |
| 4877 | * page/Frame.cpp: |
| 4878 | (WebCore::Frame::Frame): |
| 4879 | |
zimmermann@webkit.org | 36a0251 | 2008-08-12 21:11:17 +0000 | [diff] [blame] | 4880 | 2008-08-12 Nikolas Zimmermann <zimmermann@kde.org> |
| 4881 | |
| 4882 | Reviewed by Dave. |
| 4883 | |
| 4884 | Fixes: https://bugs.webkit.org/show_bug.cgi?id=19798 |
| 4885 | Masks are translated, and the mask images are swapped on the y-axis. |
| 4886 | |
| 4887 | Turned out that http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm |
| 4888 | is guilty. GraphicsContext::clipToImageBuffer() does some extra transformations that SVGResourcesMaskerCg does not want. |
| 4889 | |
| 4890 | Long term goal is to remove the SVGResource*/SVGPaintServer* classes anyway, so it's okay to duplicate |
| 4891 | the "clip to image buffer" functionality, in the CG specific SVGResourceMaskerCg class - as it was before. |
| 4892 | |
| 4893 | * svg/graphics/cg/SVGResourceMaskerCg.mm: |
| 4894 | (WebCore::SVGResourceMasker::applyMask): Changed back to use CG clipping again. |
| 4895 | |
mitz@apple.com | f8a9869 | 2008-08-12 17:04:42 +0000 | [diff] [blame] | 4896 | 2008-08-12 Dan Bernstein <mitz@apple.com> |
| 4897 | |
mitz@apple.com | 1b7e844f | 2008-08-12 20:54:12 +0000 | [diff] [blame] | 4898 | - WebCore part of <rdar://problem/6121636> |
| 4899 | Make fast*alloc() abort() on failure and add "try" variants that |
| 4900 | return NULL on failure. |
| 4901 | |
| 4902 | Reviewed by Darin Adler. |
| 4903 | |
| 4904 | * platform/Arena.cpp: |
| 4905 | (WebCore::ArenaAllocate): Removed null checking of fastMalloc()'s |
| 4906 | result. |
| 4907 | * platform/graphics/cg/ImageBufferCG.cpp: |
| 4908 | (WebCore::ImageBuffer::create): Changed to use tryFastCalloc(). |
| 4909 | |
| 4910 | 2008-08-12 Dan Bernstein <mitz@apple.com> |
| 4911 | |
mitz@apple.com | 1e09cd7 | 2008-08-12 18:27:58 +0000 | [diff] [blame] | 4912 | Reviewed by Darin Adler. |
| 4913 | |
| 4914 | - fix https://bugs.webkit.org/show_bug.cgi?id=19348 |
| 4915 | <rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works |
| 4916 | |
| 4917 | Test: fast/frames/frameset-style-recalc.html |
| 4918 | |
| 4919 | * html/HTMLFrameSetElement.cpp: |
| 4920 | (WebCore::HTMLFrameSetElement::recalcStyle): Changed to call the base |
| 4921 | class implementation after marking for layout. |
| 4922 | |
| 4923 | 2008-08-12 Dan Bernstein <mitz@apple.com> |
| 4924 | |
mitz@apple.com | f8a9869 | 2008-08-12 17:04:42 +0000 | [diff] [blame] | 4925 | Reviewed by John Sullivan. |
| 4926 | |
| 4927 | - move shouldUpdateWhenOffscreen from Settings to FrameView and rename it shouldUpdateWhileHidden |
| 4928 | |
| 4929 | * WebCore.base.exp: |
| 4930 | * page/FrameView.cpp: |
| 4931 | (WebCore::FrameViewPrivate::FrameViewPrivate): |
| 4932 | (WebCore::FrameView::shouldUpdateWhileHidden): |
| 4933 | (WebCore::FrameView::setShouldUpdateWhileHidden): |
| 4934 | * page/FrameView.h: |
| 4935 | * page/Settings.cpp: |
| 4936 | * page/Settings.h: |
| 4937 | |
aroben@apple.com | eeb8ebb | 2008-08-12 14:58:51 +0000 | [diff] [blame] | 4938 | 2008-08-12 Adam Roben <aroben@apple.com> |
| 4939 | |
| 4940 | Windows build fix |
| 4941 | |
| 4942 | * bindings/js/JSSVGPODTypeWrapper.h: Align |
| 4943 | JSSVGDynamicPODTypeWrapper's and JSSVGStaticPODTypeWrapperWithParent's |
| 4944 | members on 16-byte boundaries to avoid an alignment warning. |
| 4945 | |
zimmermann@webkit.org | e138811 | 2008-08-12 10:27:53 +0000 | [diff] [blame] | 4946 | 2008-08-12 Nikolas Zimmermann <zimmermann@kde.org> |
| 4947 | |
| 4948 | Reviewed by Oliver. |
| 4949 | |
zimmermann@webkit.org | 504f255 | 2008-08-12 10:35:09 +0000 | [diff] [blame] | 4950 | Add new dynamice-update layout tests covering SVGMarkerElement. |
| 4951 | Fix bug: SVGMarkerElement's SVG DOM function calls don't update rendering. |
| 4952 | Fix orientAngle/orientType confusion: "auto" orient should always return "0" as angle. |
| 4953 | |
| 4954 | Tests: svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html |
| 4955 | svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr.html |
| 4956 | svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr.html |
| 4957 | svg/dynamic-updates/SVGMarkerElement-dom-orient-attr.html |
| 4958 | svg/dynamic-updates/SVGMarkerElement-dom-refX-attr.html |
| 4959 | svg/dynamic-updates/SVGMarkerElement-dom-refY-attr.html |
| 4960 | svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop.html |
| 4961 | svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop.html |
| 4962 | svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop.html |
| 4963 | svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop.html |
| 4964 | svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop.html |
| 4965 | svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop.html |
| 4966 | svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop.html |
| 4967 | svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call.html |
| 4968 | svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call.html |
| 4969 | |
| 4970 | * svg/SVGMarkerElement.cpp: |
| 4971 | (WebCore::SVGMarkerElement::SVGMarkerElement): |
| 4972 | (WebCore::SVGMarkerElement::parseMappedAttribute): |
| 4973 | (WebCore::SVGMarkerElement::svgAttributeChanged): |
| 4974 | (WebCore::SVGMarkerElement::childrenChanged): |
| 4975 | (WebCore::SVGMarkerElement::setOrientToAuto): |
| 4976 | (WebCore::SVGMarkerElement::setOrientToAngle): |
| 4977 | (WebCore::SVGMarkerElement::canvasResource): |
| 4978 | |
| 4979 | 2008-08-12 Nikolas Zimmermann <zimmermann@kde.org> |
| 4980 | |
| 4981 | Reviewed by Oliver. |
| 4982 | |
zimmermann@webkit.org | e138811 | 2008-08-12 10:27:53 +0000 | [diff] [blame] | 4983 | Add new dynamic-update layout tests covering SVGImageElement. |
| 4984 | Fix bug: SVGImageElement doesn't react on 'preserveAspectRatio' changes. |
| 4985 | |
| 4986 | Tests: svg/dynamic-updates/SVGImageElement-dom-height-attr.html |
| 4987 | svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr.html |
| 4988 | svg/dynamic-updates/SVGImageElement-dom-width-attr.html |
| 4989 | svg/dynamic-updates/SVGImageElement-dom-x-attr.html |
| 4990 | svg/dynamic-updates/SVGImageElement-dom-y-attr.html |
| 4991 | svg/dynamic-updates/SVGImageElement-svgdom-height-prop.html |
| 4992 | svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html |
| 4993 | svg/dynamic-updates/SVGImageElement-svgdom-width-prop.html |
| 4994 | svg/dynamic-updates/SVGImageElement-svgdom-x-prop.html |
| 4995 | svg/dynamic-updates/SVGImageElement-svgdom-y-prop.html |
| 4996 | |
| 4997 | * svg/SVGImageElement.cpp: |
| 4998 | (WebCore::SVGImageElement::svgAttributeChanged): |
| 4999 | |
timothy@apple.com | 9311472 | 2008-08-12 04:20:25 +0000 | [diff] [blame] | 5000 | 2008-08-11 Anthony Ricaud <rik24d@gmail.com> |
| 5001 | |
timothy@apple.com | 2f2cde3 | 2008-08-12 04:28:16 +0000 | [diff] [blame] | 5002 | Changed Option/Alt-Up or Down in CSS editing when the value is |
| 5003 | near zero to jump to the next integer. |
| 5004 | |
| 5005 | Reviewed by Tim Hatcher. |
| 5006 | |
| 5007 | https://bugs.webkit.org/show_bug.cgi?id=20326 |
| 5008 | |
| 5009 | * page/inspector/StylesSidebarPane.js: |
| 5010 | |
| 5011 | 2008-08-11 Anthony Ricaud <rik24d@gmail.com> |
| 5012 | |
timothy@apple.com | 9311472 | 2008-08-12 04:20:25 +0000 | [diff] [blame] | 5013 | Changed the line highlight transition for an easier animation. |
| 5014 | |
| 5015 | Reviewed by Tim Hatcher. |
| 5016 | |
| 5017 | * page/inspector/SourceFrame.js: |
| 5018 | |
timothy@apple.com | 24a1485 | 2008-08-12 03:57:39 +0000 | [diff] [blame] | 5019 | 2008-08-11 Keishi Hattori <casey.hattori@gmail.com> |
| 5020 | |
| 5021 | Added support for some Firebug Command Line APIs. |
| 5022 | |
| 5023 | Reviewed by Tim Hatcher. |
| 5024 | |
| 5025 | https://bugs.webkit.org/show_bug.cgi?id=19867 |
| 5026 | https://bugs.webkit.org/show_bug.cgi?id=19868 |
| 5027 | https://bugs.webkit.org/show_bug.cgi?id=19869 |
| 5028 | https://bugs.webkit.org/show_bug.cgi?id=19875 |
| 5029 | https://bugs.webkit.org/show_bug.cgi?id=19876 |
| 5030 | https://bugs.webkit.org/show_bug.cgi?id=19880 |
| 5031 | |
| 5032 | * page/inspector/Console.js: |
| 5033 | (WebInspector.Console.prototype._evalInInspectedWindow): |
| 5034 | Create an object on the inspected window that holds the console |
| 5035 | command line API functions. This object is used in a with statement |
| 5036 | around the typed expression. |
| 5037 | |
zimmermann@webkit.org | 0350b6d | 2008-08-12 02:22:26 +0000 | [diff] [blame] | 5038 | 2008-08-11 Nikolas Zimmermann <zimmermann@kde.org> |
| 5039 | |
| 5040 | Reviewed by Antti. |
| 5041 | |
| 5042 | Fixes: http://bugs.webkit.org/show_bug.cgi?id=17736 |
| 5043 | |
| 5044 | JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties |
| 5045 | failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect) |
| 5046 | |
| 5047 | Added tests: svg/custom/svg-modify-currentTranslate.html |
| 5048 | svg/custom/tearoffs-with-tearoffs.html |
| 5049 | svg/custom/immutable-properties.html |
| 5050 | |
| 5051 | Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html |
| 5052 | |
| 5053 | * bindings/js/JSSVGPODTypeWrapper.h: |
| 5054 | (WebCore::JSSVGDynamicPODTypeWrapper::commitChange): |
| 5055 | (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::create): |
| 5056 | (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::commitChange): |
| 5057 | (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::JSSVGStaticPODTypeWrapperWithPODTypeParent): |
| 5058 | (WebCore::JSSVGStaticPODTypeWrapperWithParent::create): |
| 5059 | (WebCore::JSSVGStaticPODTypeWrapperWithParent::operator PODType): |
| 5060 | (WebCore::JSSVGStaticPODTypeWrapperWithParent::commitChange): |
| 5061 | (WebCore::JSSVGStaticPODTypeWrapperWithParent::JSSVGStaticPODTypeWrapperWithParent): |
| 5062 | * bindings/scripts/CodeGenerator.pm: |
| 5063 | * bindings/scripts/CodeGeneratorJS.pm: |
| 5064 | * svg/SVGSVGElement.idl: Add [Immutable] markers to SVG POD attributes, that contain POD types with writable attributes. |
| 5065 | * svg/SVGZoomEvent.idl: SVG specification explicitely demands these attributes to be readonly, even its content. |
| 5066 | |
beidson@apple.com | 0e772f7 | 2008-08-12 00:34:46 +0000 | [diff] [blame] | 5067 | 2008-08-11 Brady Eidson <beidson@apple.com> |
| 5068 | |
| 5069 | Reviewed by John and Anders |
| 5070 | |
| 5071 | Fix for <rdar://problem/6141797> |
| 5072 | |
| 5073 | When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource |
| 5074 | would never have nil data. |
| 5075 | |
| 5076 | When they were pushed down into WebCore, that guarantee was lost, subtly changing a few |
| 5077 | semantics with some WebKit applications. |
| 5078 | |
| 5079 | The guarantee was a good one and should be restored. |
| 5080 | |
| 5081 | Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already |
| 5082 | creates an empty data object in the case of null data for its own purposes. |
| 5083 | |
| 5084 | * loader/SubstituteResource.h: |
| 5085 | (WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null. This |
| 5086 | well help any future subclassers not make this mistake. |
| 5087 | |
| 5088 | * loader/archive/ArchiveResource.cpp: |
| 5089 | (WebCore::ArchiveResource::create): Return 0 if the data is null. |
| 5090 | |
simon.fraser@apple.com | e0d4479 | 2008-08-11 22:44:06 +0000 | [diff] [blame] | 5091 | 2008-08-11 Simon Fraser <simon.fraser@apple.com> |
| 5092 | |
| 5093 | Reviewed by Dave Hyatt |
| 5094 | |
| 5095 | https://bugs.webkit.org/show_bug.cgi?id=20328 |
| 5096 | Fix a problem when an 'all' transition transition with more than |
| 5097 | one property changing is interrupted, and did some AnimationController |
| 5098 | cleanup. |
| 5099 | |
| 5100 | Test: transitions/interrupted-all-transition.html |
| 5101 | |
| 5102 | * page/AnimationController.cpp: |
| 5103 | (WebCore::ImplicitAnimation::ImplicitAnimation): |
| 5104 | (WebCore::AnimationControllerPrivate::blendProperties): |
| 5105 | (WebCore::CompositeAnimation::updateTransitions): |
| 5106 | (WebCore::CompositeAnimation::cleanupFinishedAnimations): |
| 5107 | (WebCore::CompositeAnimation::setTransitionStartTime): |
| 5108 | (WebCore::CompositeAnimation::overrideImplicitAnimations): |
| 5109 | (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations): |
| 5110 | (WebCore::ImplicitAnimation::animate): |
| 5111 | (WebCore::ImplicitAnimation::onAnimationEnd): |
| 5112 | (WebCore::ImplicitAnimation::sendTransitionEvent): |
| 5113 | (WebCore::ImplicitAnimation::affectsProperty): |
| 5114 | (WebCore::KeyframeAnimation::endAnimation): |
| 5115 | (WebCore::KeyframeAnimation::onAnimationEnd): |
| 5116 | |
kmccullough@apple.com | 4a967c1 | 2008-08-11 20:45:19 +0000 | [diff] [blame] | 5117 | 2008-08-11 Kevin McCullough <kmccullough@apple.com> |
| 5118 | |
| 5119 | Reviewed by Tim. |
| 5120 | |
| 5121 | - Because console messages have group levels now, newly created messages |
| 5122 | that do not specify the level lose their message since the number of |
| 5123 | arguments is wrong. |
| 5124 | |
| 5125 | * page/inspector/Console.js: |
| 5126 | * page/inspector/Resource.js: |
| 5127 | |
alp@webkit.org | eeb5514 | 2008-08-11 19:52:14 +0000 | [diff] [blame] | 5128 | 2008-08-11 Alp Toker <alp@nuanti.com> |
| 5129 | |
| 5130 | Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take |
| 5131 | the opportunity to sort the sources lists. |
| 5132 | |
| 5133 | * GNUmakefile.am: |
| 5134 | |
timothy@apple.com | 9fe09f8 | 2008-08-11 18:48:37 +0000 | [diff] [blame] | 5135 | 2008-08-11 Timothy Hatcher <timothy@apple.com> |
| 5136 | |
| 5137 | Speed up the the JavaScript syntax highlighter by generating |
| 5138 | the finders only once per script instead of per line. |
| 5139 | |
| 5140 | https://bugs.webkit.org/show_bug.cgi?id=20346 |
| 5141 | |
| 5142 | Reviewed by Adam Roben. |
| 5143 | |
| 5144 | * page/inspector/SourceFrame.js: |
| 5145 | (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): |
| 5146 | Removed, factored into syntaxHighlightJavascript as an inline function. |
| 5147 | (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): |
| 5148 | Pulled in the _syntaxHighlightJavascriptLine so it will create a closure. |
| 5149 | Generate the finders before iterating the lines. |
| 5150 | |
aroben@apple.com | 957d2d3 | 2008-08-11 18:31:37 +0000 | [diff] [blame] | 5151 | 2008-08-11 Adam Roben <aroben@apple.com> |
| 5152 | |
| 5153 | Windows build fix |
| 5154 | |
| 5155 | * WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and |
| 5156 | JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file, |
| 5157 | too. |
| 5158 | |
mitz@apple.com | 3f0060f | 2008-08-11 18:04:46 +0000 | [diff] [blame] | 5159 | 2008-08-11 Dan Bernstein <mitz@apple.com> |
| 5160 | |
| 5161 | Reviewed by Darin Adler. |
| 5162 | |
| 5163 | - fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc |
| 5164 | |
| 5165 | Test: fast/css/counters/invalidate-cached-counter-node.html |
| 5166 | |
| 5167 | * rendering/RenderContainer.cpp: |
| 5168 | (WebCore::RenderContainer::invalidateCounters): Added. Invalidates all |
| 5169 | RenderCounters in :before and :after content. |
| 5170 | * rendering/RenderContainer.h: |
| 5171 | * rendering/RenderCounter.cpp: |
| 5172 | (WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this |
| 5173 | to match the RenderObject method. |
| 5174 | (WebCore::RenderCounter::invalidate): Added. Resets the cached |
| 5175 | CounterNode and invalidates the object's layout and preferred widths. |
| 5176 | (WebCore::destroyCounterNodeChildren): Added a call to |
| 5177 | invalidateCounters(). |
| 5178 | * rendering/RenderCounter.h: |
| 5179 | * rendering/RenderObject.h: |
| 5180 | (WebCore::RenderObject::invalidateCounters): |
| 5181 | |
dino@apple.com | 2af8c3a | 2008-08-11 17:24:36 +0000 | [diff] [blame] | 5182 | 2008-08-11 Dean Jackson <dino@apple.com> |
| 5183 | |
| 5184 | Implement CSS Animation and Transition Events |
| 5185 | https://bugs.webkit.org/show_bug.cgi?id=20337 |
| 5186 | |
| 5187 | Implement the events defined in the CSS Animations |
| 5188 | and Transitions specifications so code can react |
| 5189 | to animations and transitions. |
| 5190 | |
| 5191 | Reviewed by Tim Hatcher and Dave Hyatt. |
| 5192 | |
| 5193 | * DerivedSources.make: |
| 5194 | * GNUmakefile.am: |
| 5195 | * WebCore.pro: |
| 5196 | * WebCore.vcproj/WebCore.vcproj: |
| 5197 | * WebCore.xcodeproj/project.pbxproj: |
| 5198 | * WebCoreSources.bkl: |
| 5199 | Build configs for new files |
| 5200 | |
| 5201 | * bindings/js/JSDOMWindowBase.cpp: |
| 5202 | * bindings/js/JSDOMWindowBase.h: |
| 5203 | * bindings/js/JSEventCustom.cpp: |
| 5204 | * dom/Document.h: |
| 5205 | * dom/Event.cpp: |
| 5206 | * dom/Event.h: |
| 5207 | * dom/EventTarget.cpp: |
| 5208 | * dom/EventTargetNode.cpp: |
| 5209 | * dom/EventTargetNode.h: |
| 5210 | * html/HTMLElement.cpp: |
| 5211 | * page/AnimationController.cpp: |
| 5212 | do all the new event stuff |
| 5213 | |
| 5214 | * html/HTMLAttributeNames.in: |
| 5215 | the onwebkitanimation* and onwebkittransitionend attrs |
| 5216 | |
| 5217 | * dom/WebKitAnimationEvent.cpp: Added. |
| 5218 | * dom/WebKitAnimationEvent.h: Added. |
| 5219 | * dom/WebKitAnimationEvent.idl: Added. |
| 5220 | * dom/WebKitTransitionEvent.cpp: Added. |
| 5221 | * dom/WebKitTransitionEvent.h: Added. |
| 5222 | * dom/WebKitTransitionEvent.idl: Added. |
| 5223 | New files for the events |
| 5224 | |
| 5225 | * manual-tests/transition-events.html: Added. |
| 5226 | New testfile |
| 5227 | |
aroben@apple.com | 3eae862 | 2008-08-11 17:21:23 +0000 | [diff] [blame] | 5228 | 2008-08-11 Adam Roben <aroben@apple.com> |
| 5229 | |
| 5230 | Add a ForwardingHeader for wtf/NotFound.h |
| 5231 | |
| 5232 | Rubberstamped by Darin Adler. |
| 5233 | |
| 5234 | * ForwardingHeaders/wtf/NotFound.h: Added. |
| 5235 | |
timothy@apple.com | 2f5bdf0 | 2008-08-11 16:53:30 +0000 | [diff] [blame] | 5236 | 2008-08-11 Timothy Hatcher <timothy@apple.com> |
| 5237 | |
| 5238 | Fixes a bug where error bubbles in JavaScript resources would |
| 5239 | be clobbered by the syntax highlighter. |
| 5240 | |
| 5241 | https://bugs.webkit.org/show_bug.cgi?id=20345 |
| 5242 | |
| 5243 | Reviewed by Adam Roben. |
| 5244 | |
| 5245 | * manual-tests/inspector/resources/script-error.js: Added. |
| 5246 | * manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added. |
| 5247 | * page/inspector/SourceFrame.js: |
| 5248 | (WebInspector.SourceFrame.prototype._addMessageToSource): |
| 5249 | Check the nodeType and not the nodeName, this is less fragile. |
| 5250 | (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): |
| 5251 | Check if the lastChild is an error bubble, if so remove it before |
| 5252 | getting the line's textContent. Add the error bubble back at the end. |
| 5253 | |
mrowe@apple.com | 4ec50d0 | 2008-08-11 05:07:42 +0000 | [diff] [blame] | 5254 | == Rolled over to ChangeLog-2008-08-10 == |