commit fa1ce1657725f0311c7272180c3cf6dcc7a84b41
author bdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Sep 18 22:18:01 2008 +0000
committer bdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Sep 18 22:18:01 2008 +0000
tree 348cd7528f26365a91f753ff03aca8e694ed2a3e
parent fce49be81a7a677b555b411a5465b2d49a279342

WebCore:

2008-09-18  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon 
        parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
        dashboard-region=
        and corresponding: <rdar://problem/6174100>

        This patch makes CSSParserValue::createCSSValue handle unknown 
        identifiers.

        * css/CSSParserValues.cpp:
        (WebCore::CSSParserValue::createCSSValue): If we have an identifier 
        with no id (an unknown identifier) create a CSSPrimitiveValue of 
        type CSS_PARSER_IDENTIFIER
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cssText):
        (WebCore::CSSPrimitiveValue::parserValue):
        * css/CSSPrimitiveValue.h:
        (WebCore::CSSPrimitiveValue::):

LayoutTests:

2008-09-18  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Test for https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon 
        parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
        dashboard-region=
        and corresponding: <rdar://problem/6174100>

        * fast/css/variables/invalid-identifier-expected.txt: Added.
        * fast/css/variables/invalid-identifier.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 980cc60..a8ddecb 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,25 @@
+2008-09-18  Beth Dakin  <bdakin@apple.com>
+
+        Reviewed by Dave Hyatt.
+
+        Fix for https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon 
+        parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
+        dashboard-region=
+        and corresponding: <rdar://problem/6174100>
+
+        This patch makes CSSParserValue::createCSSValue handle unknown 
+        identifiers.
+
+        * css/CSSParserValues.cpp:
+        (WebCore::CSSParserValue::createCSSValue): If we have an identifier 
+        with no id (an unknown identifier) create a CSSPrimitiveValue of 
+        type CSS_PARSER_IDENTIFIER
+        * css/CSSPrimitiveValue.cpp:
+        (WebCore::CSSPrimitiveValue::cssText):
+        (WebCore::CSSPrimitiveValue::parserValue):
+        * css/CSSPrimitiveValue.h:
+        (WebCore::CSSPrimitiveValue::):
+
 2008-09-18  Sam Weinig  <sam@webkit.org>
 
         Rubber-stamped by David "I'd prefer not" Hyatt.