blob: ec4db3b5c633bbabf9611ff95e92420e4b577fed [file] [log] [blame]
hyatt@apple.comc5b931a2008-09-19 00:39:51 +000012008-09-18 David Hyatt <hyatt@apple.com>
2
hyatt@apple.com470d7e72008-09-19 03:01:08 +00003 Move Qt's isNPAPIPlugin boolean from Widget down to PluginView, since there
4 was no reason for it to be on Widget. This change eliminates Qt ifdefs
5 from Widget.
6
7 Reviewed by Sam Weinig
8
9 * bindings/js/ScriptControllerQt.cpp:
10 (WebCore::ScriptController::createScriptInstanceForWidget):
11 * platform/qt/WidgetQt.cpp:
12 (WebCore::WidgetPrivate::WidgetPrivate):
13 (WebCore::WidgetPrivate::~WidgetPrivate):
14 (WebCore::Widget::Widget):
15 (WebCore::Widget::~Widget):
16 * plugins/PluginView.cpp:
17 (WebCore::PluginView::PluginView):
18 * plugins/PluginView.h:
19 (WebCore::PluginView::isNPAPIPlugin):
20 (WebCore::PluginView::setIsNPAPIPlugin):
21
222008-09-18 David Hyatt <hyatt@apple.com>
23
hyatt@apple.com557408b2008-09-19 02:36:08 +000024 Make geometryChanged() cross-platform on Widget. GTK and WIN platform
25 ifdefs are now gone from Widget!
26
27 Reviewed by Sam Weinig
28
29 * platform/Widget.h:
30 (WebCore::Widget::geometryChanged):
31 * platform/gtk/WidgetGtk.cpp:
32 * platform/qt/WidgetQt.cpp:
33
342008-09-18 David Hyatt <hyatt@apple.com>
35
hyatt@apple.com17e57432008-09-19 02:29:27 +000036 Consolidate convertTo/FromContainingWindow methods so that all platforms
37 but Mac share the same code.
38
39 Move convertSelfToChild and convertChildToSelf to ScrollView, since
40 Widget should know nothing about children. Make the methods cross-platform
41 on ScrollView.
42
43 Reviewed by Sam Weinig
44
45 * platform/ScrollView.h:
46 (WebCore::ScrollView::convertChildToSelf):
47 (WebCore::ScrollView::convertSelfToChild):
48 * platform/Widget.cpp:
49 (WebCore::Widget::convertToContainingWindow):
50 (WebCore::Widget::convertFromContainingWindow):
51 * platform/Widget.h:
52 (WebCore::Widget::geometryChanged):
53 * platform/gtk/ScrollViewGtk.cpp:
54 (WebCore::ScrollView::isScrollViewScrollbar):
55 * platform/gtk/WidgetGtk.cpp:
56 * platform/mac/ScrollViewMac.mm:
57 (WebCore::ScrollView::isScrollViewScrollbar):
58 * platform/mac/WidgetMac.mm:
59 * platform/qt/ScrollViewQt.cpp:
60 (WebCore::ScrollView::isScrollViewScrollbar):
61 * platform/qt/WidgetQt.cpp:
62 * platform/win/ScrollViewWin.cpp:
63 (WebCore::ScrollView::isScrollViewScrollbar):
64 * platform/win/WidgetWin.cpp:
65
662008-09-18 David Hyatt <hyatt@apple.com>
67
hyatt@apple.comc5b931a2008-09-19 00:39:51 +000068 Make the conversion methods that go to and from some containingWindow
69 cross-platform. Implement them on Mac.
70
71 Reviewed by Sam Weinig
72
73 * platform/Widget.h:
74 (WebCore::Widget::setContainingWindow):
75 * platform/mac/WidgetMac.mm:
76 (WebCore::Widget::convertFromContainingWindow):
77 (WebCore::Widget::convertToContainingWindow):
78
weinig@apple.comd1ea02d2008-09-19 00:28:05 +0000792008-09-18 Sam Weinig <sam@webkit.org>
80
81 Rubber-stamped by David "Yeah-yeah" Hyatt.
82
83 Cleanup RenderStyle.
84
85 * WebCore.xcodeproj/project.pbxproj:
86 * rendering/style/CounterContent.h:
87 * rendering/style/RenderStyle.cpp:
88 * rendering/style/RenderStyle.h:
89
dino@apple.comef93f532008-09-19 00:01:07 +0000902008-09-18 Chris Marrin <cmarrin@apple.com>
91
92 Reviewed by Sam Weinig
93
94 Fixed https://bugs.webkit.org/show_bug.cgi?id=20908
95 Now TransformOperations and AnimationList no longer
96 inherit from Vector<> but rather have API to access.
97
98 * css/CSSComputedStyleDeclaration.cpp:
99 (WebCore::computedTransform):
100 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
101 * css/CSSStyleSelector.cpp:
102 (WebCore::CSSStyleSelector::createTransformOperations):
103 * page/animation/AnimationBase.cpp:
104 (WebCore::blendFunc):
105 * page/animation/CompositeAnimation.cpp:
106 (WebCore::CompositeAnimation::updateTransitions):
107 (WebCore::CompositeAnimation::updateKeyframeAnimations):
108 (WebCore::CompositeAnimation::animate):
109 * page/animation/ImplicitAnimation.cpp:
110 (WebCore::ImplicitAnimation::validateTransformFunctionList):
111 * page/animation/KeyframeAnimation.cpp:
112 (WebCore::KeyframeAnimation::validateTransformFunctionList):
113 * rendering/RenderLayer.cpp:
114 (WebCore::RenderLayer::updateReflectionStyle):
115 * rendering/style/AnimationList.cpp:
116 (WebCore::AnimationList::operator==):
117 * rendering/style/AnimationList.h:
118 (WebCore::AnimationList::operator!=):
119 (WebCore::AnimationList::size):
120 (WebCore::AnimationList::isEmpty):
121 (WebCore::AnimationList::resize):
122 (WebCore::AnimationList::remove):
123 (WebCore::AnimationList::append):
124 (WebCore::AnimationList::animation):
125 * rendering/style/RenderStyle.cpp:
126 (WebCore::StyleRareNonInheritedData::updateKeyframes):
127 (WebCore::RenderStyle::applyTransform):
128 (WebCore::RenderStyle::adjustAnimations):
129 (WebCore::RenderStyle::adjustTransitions):
130 (WebCore::RenderStyle::transitionForProperty):
131 * rendering/style/RenderStyle.h:
132 (WebCore::RenderStyle::hasTransform):
133 * rendering/style/TransformOperations.cpp:
134 (WebCore::TransformOperations::TransformOperations):
135 (WebCore::TransformOperations::operator==):
136 * rendering/style/TransformOperations.h:
137 (WebCore::TransformOperations::apply):
138 (WebCore::TransformOperations::operations):
139
zecke@webkit.org20690ef2008-09-18 23:28:34 +00001402008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
141
zecke@webkit.org30db7422008-09-19 01:00:18 +0000142 Build fix.
143
144 [qt] Build fixes after the Widget/ScrollView cleanup
145 topLevel() is now root()
146
147
148 * platform/qt/ScrollViewQt.cpp:
149 (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
150 (WebCore::ScrollView::addChild):
151 (WebCore::ScrollView::removeChild):
152
1532008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
154
zecke@webkit.org20690ef2008-09-18 23:28:34 +0000155 Reviewed by Mark Rowe.
156
157 https://bugs.webkit.org/show_bug.cgi?id=20437
158
159 XMLTokenizer.cpp used to contain two different implementations. One was using
160 libxml2 and the other was using the Qt XML StreamReader. Clean up the code by
161 separating the two implementations from each other.
162 Common code and some small bits are kept inside the XMLTokenizer.cpp, the Qt code
163 was moved to XMLTokenizerQt.cpp and the Libxml2 based code was moved to
164 XMLTokenizerLibxml2.cpp. There should be no functional changes.
165
166 Attempt to add XMLTokenizerLibxml2.cpp to every buildsystem so the build continues
167 to work.
168
169 * GNUmakefile.am:
170 * WebCore.pro:
171 * WebCore.vcproj/WebCore.vcproj:
172 * WebCore.xcodeproj/project.pbxproj:
173 * WebCoreSources.bkl:
174 * dom/XMLTokenizer.cpp:
175 (WebCore::isScriptElement):
176 (WebCore::castToScriptElement):
177 (WebCore::XMLTokenizer::setCurrentNode):
178 (WebCore::XMLTokenizer::write):
179 (WebCore::XMLTokenizer::eventuallyMarkAsParserCreated):
180 (WebCore::XMLTokenizer::enterText):
181 (WebCore::toString):
182 (WebCore::XMLTokenizer::exitText):
183 (WebCore::XMLTokenizer::end):
184 (WebCore::XMLTokenizer::insertErrorMessageBlock):
185 * dom/XMLTokenizer.h:
186 (WebCore::XMLTokenizer::wellFormed):
187 * dom/XMLTokenizerLibxml2.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
188 (WebCore::createMemoryParser):
189 (WebCore::XMLTokenizer::XMLTokenizer):
190 (WebCore::XMLTokenizer::~XMLTokenizer):
191 (WebCore::XMLTokenizer::doWrite):
192 (WebCore::ignorableWhitespaceHandler):
193 (WebCore::XMLTokenizer::initializeParserContext):
194 (WebCore::XMLTokenizer::doEnd):
195 (WebCore::XMLTokenizer::lineNumber):
196 (WebCore::XMLTokenizer::columnNumber):
197 (WebCore::XMLTokenizer::stopParsing):
198 (WebCore::XMLTokenizer::resumeParsing):
199 (WebCore::parseXMLDocumentFragment):
200 (WebCore::attributesStartElementNsHandler):
201 (WebCore::parseAttributes):
202 * dom/XMLTokenizerQt.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
203 (WebCore::EntityResolver::resolveUndeclaredEntity):
204 (WebCore::XMLTokenizer::XMLTokenizer):
205 (WebCore::XMLTokenizer::~XMLTokenizer):
206 (WebCore::XMLTokenizer::doWrite):
207 (WebCore::XMLTokenizer::initializeParserContext):
208 (WebCore::XMLTokenizer::doEnd):
209 (WebCore::XMLTokenizer::lineNumber):
210 (WebCore::XMLTokenizer::columnNumber):
211 (WebCore::XMLTokenizer::stopParsing):
212 (WebCore::XMLTokenizer::resumeParsing):
213 (WebCore::parseXMLDocumentFragment):
214 (WebCore::attributesStartElementNsHandler):
215 (WebCore::parseAttributes):
216 (WebCore::):
217
bdakin@apple.com4c244902008-09-18 23:08:35 +00002182008-09-18 Beth Dakin <bdakin@apple.com>
219
220 Reviewed by Geoff Garen.
221
222 Build fix for non-Mac builds.
223
224 * css/CSSPrimitiveValue.cpp:
225 (WebCore::CSSPrimitiveValue::cssText):
226
eric@webkit.org4ac94e62008-09-18 23:07:55 +00002272008-09-18 Peter Kasting <pkasting@google.com>
228
229 Reviewed by hyatt. Landed by eseidel.
230
231 https://bugs.webkit.org/show_bug.cgi?id=20745
232 Animated GIFs do not animate properly with (at least) CG.
233
234 * WebCore\platform\graphics\BitmapImage.cpp:
235 * WebCore\platform\graphics\BitmapImage.h:
236 * WebCore\platform\graphics\cairo\ImageCairo.cpp:
237 * WebCore\platform\graphics\cg\ImageCG.cpp:
238 * WebCore\platform\graphics\qt\ImageQt.cpp:
239 * WebCore\platform\graphics\wx\ImageWx.cpp:
240
cfleizach@apple.com2a72d8f2008-09-18 22:54:37 +00002412008-09-18 Chris Fleizach <cfleizach@apple.com>
242
243 Reviewed by Beth Dakin
244
245 <rdar://problem/6224222> AX: should not expose a <table> as an AXTable if ARIA
246 role specifies otherwise
247
248 If a <table> isn't an AXTable, the rows and cells should default to AccessibilityRenderObject
249
250 Test: accessibility/table-with-aria-role.html
251
252 * page/AccessibilityTable.cpp:
253 (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
254 (WebCore::AccessibilityTable::addChildren):
255 (WebCore::AccessibilityTable::roleValue):
256 (WebCore::AccessibilityTable::accessibilityIsIgnored):
257 (WebCore::AccessibilityTable::title):
258 * page/AccessibilityTableCell.cpp:
259 (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
260 (WebCore::AccessibilityTableCell::isTableCell):
261 (WebCore::AccessibilityTableCell::roleValue):
262 * page/AccessibilityTableCell.h:
263 * page/AccessibilityTableRow.cpp:
264 (WebCore::AccessibilityTableRow::roleValue):
265 (WebCore::AccessibilityTableRow::isTableRow):
266 (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
267 * page/AccessibilityTableRow.h:
268
sfalken@apple.coma96c5d32008-09-18 22:29:34 +00002692008-09-18 Steve Falkenburg <sfalken@apple.com>
270
271 Use higher-resolution timers on all variants of Windows.
272
273 Reviewed by Darin Adler.
274
275 * platform/win/SharedTimerWin.cpp:
276 (WebCore::setSharedTimerFireTime):
277
278
hyatt@apple.comb7d49b62008-09-18 22:21:25 +00002792008-09-18 David Hyatt <hyatt@apple.com>
280
281 Make containingWindow() and setContainingWindow() cross-platform.
282 Add a root() function cross-platform so Qt doesn't have to
283 define its own.
284
285 Reviewed by Darin Adler
286
287 * platform/Widget.cpp:
288 (WebCore::Widget::root):
289 * platform/Widget.h:
290 (WebCore::Widget::setContainingWindow):
291 * platform/gtk/WidgetGtk.cpp:
292 (WebCore::Widget::Widget):
293 (WebCore::Widget::containingWindow):
294 * platform/mac/ScrollViewMac.mm:
295 (WebCore::ScrollView::addChild):
296 (WebCore::ScrollView::removeChild):
297 * platform/mac/WidgetMac.mm:
298 (WebCore::Widget::containingWindow):
299 * platform/qt/WidgetQt.cpp:
300 (WebCore::Widget::invalidateRect):
301 (WebCore::Widget::containingWindow):
302 * platform/win/WidgetWin.cpp:
303 (WebCore::Widget::Widget):
304 (WebCore::Widget::~Widget):
305 (WebCore::Widget::containingWindow):
306
bdakin@apple.comfa1ce162008-09-18 22:18:01 +00003072008-09-18 Beth Dakin <bdakin@apple.com>
308
309 Reviewed by Dave Hyatt.
310
311 Fix for https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon
312 parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
313 dashboard-region=
314 and corresponding: <rdar://problem/6174100>
315
316 This patch makes CSSParserValue::createCSSValue handle unknown
317 identifiers.
318
319 * css/CSSParserValues.cpp:
320 (WebCore::CSSParserValue::createCSSValue): If we have an identifier
321 with no id (an unknown identifier) create a CSSPrimitiveValue of
322 type CSS_PARSER_IDENTIFIER
323 * css/CSSPrimitiveValue.cpp:
324 (WebCore::CSSPrimitiveValue::cssText):
325 (WebCore::CSSPrimitiveValue::parserValue):
326 * css/CSSPrimitiveValue.h:
327 (WebCore::CSSPrimitiveValue::):
328
weinig@apple.comfce49be2008-09-18 21:46:14 +00003292008-09-18 Sam Weinig <sam@webkit.org>
330
331 Rubber-stamped by David "I'd prefer not" Hyatt.
332
333 More the remaining class out of RenderStyle.h/cpp
334
335 * GNUmakefile.am:
336 * WebCore.pro:
337 * WebCore.vcproj/WebCore.vcproj:
338 * WebCore.xcodeproj/project.pbxproj:
339 * WebCoreSources.bkl:
340 * rendering/style/CursorData.h: Copied from rendering/style/RenderStyle.h.
341 (WebCore::CursorData::CursorData):
342 (WebCore::CursorData::operator==):
343 (WebCore::CursorData::operator!=):
344 * rendering/style/CursorList.h: Copied from rendering/style/RenderStyle.h.
345 (WebCore::CursorList::operator[]):
346 (WebCore::CursorList::CursorList):
347 * rendering/style/RenderStyle.cpp:
348 * rendering/style/RenderStyle.h:
349 (WebCore::RenderStyle::deref):
350 (WebCore::RenderStyle::hasOneRef):
351 (WebCore::RenderStyle::InheritedFlags::operator!=):
352 (WebCore::RenderStyle::NonInheritedFlags::operator!=):
353 (WebCore::RenderStyle::hasBackground):
354 (WebCore::RenderStyle::outlineWidth):
355 (WebCore::RenderStyle::autoWrap):
356 (WebCore::RenderStyle::preserveNewline):
357 (WebCore::RenderStyle::collapseWhiteSpace):
358 (WebCore::RenderStyle::isCollapsibleWhiteSpace):
359 (WebCore::RenderStyle::breakOnlyAfterWhiteSpace):
360 (WebCore::RenderStyle::breakWords):
361 (WebCore::RenderStyle::outlineOffset):
362 (WebCore::RenderStyle::setLeft):
363 (WebCore::RenderStyle::setRight):
364 (WebCore::RenderStyle::setTop):
365 (WebCore::RenderStyle::setBottom):
366 (WebCore::RenderStyle::setDashboardRegion):
367 (WebCore::RenderStyle::setBackgroundColor):
368 (WebCore::RenderStyle::setBorderImage):
369 (WebCore::RenderStyle::setBorderRadius):
370 (WebCore::RenderStyle::setFontDescription):
371 (WebCore::RenderStyle::adjustBackgroundLayers):
372 (WebCore::RenderStyle::adjustMaskLayers):
373 (WebCore::RenderStyle::deleteBindingURIs):
374 (WebCore::RenderStyle::inheritBindingURIs):
375 (WebCore::RenderStyle::isDisplayReplacedType):
376 (WebCore::RenderStyle::isDisplayInlineType):
377 (WebCore::RenderStyle::isOriginalDisplayInlineType):
378 * rendering/style/StyleInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
379 * rendering/style/StyleInheritedData.h: Copied from rendering/style/RenderStyle.h.
380 (WebCore::StyleInheritedData::operator!=):
381 * rendering/style/StyleRareInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
382 * rendering/style/StyleRareInheritedData.h: Copied from rendering/style/RenderStyle.h.
383 (WebCore::StyleRareInheritedData::operator!=):
384 * rendering/style/StyleRareNonInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
385 * rendering/style/StyleRareNonInheritedData.h: Copied from rendering/style/RenderStyle.h.
386 * rendering/style/StyleReflection.h: Copied from rendering/style/RenderStyle.h.
387
hyatt@apple.com643534d2008-09-18 20:09:41 +00003882008-09-18 David Hyatt <hyatt@apple.com>
389
hyatt@apple.comd23089a2008-09-18 20:24:16 +0000390 Move the concept of suppression invalidation on Widgets to Scrollbar
391 instead. Since this is only used by Scrollbars, there is no need for
392 it to be on Widget.
393
394 Reviewed by Sam Weinig
395
396 * platform/Scrollbar.cpp:
397 (WebCore::Scrollbar::Scrollbar):
398 (WebCore::Scrollbar::invalidateRect):
399 * platform/Scrollbar.h:
400 (WebCore::Scrollbar::suppressInvalidation):
401 (WebCore::Scrollbar::setSuppressInvalidation):
402 * platform/Widget.h:
403 * platform/gtk/WidgetGtk.cpp:
404 (WebCore::Widget::Widget):
405 (WebCore::Widget::invalidateRect):
406 * platform/qt/WidgetQt.cpp:
407 (WebCore::WidgetPrivate::WidgetPrivate):
408 (WebCore::Widget::invalidateRect):
409 * platform/win/WidgetWin.cpp:
410 (WebCore::Widget::Widget):
411 (WebCore::Widget::invalidateRect):
412
4132008-09-18 David Hyatt <hyatt@apple.com>
414
hyatt@apple.com643534d2008-09-18 20:09:41 +0000415 Make invalidate() on Widget non-virtual and make it just call
416 invalidateRect() on the boundsGeometry() of the Widget.
417
418 Reviewed by Dan Bernstein
419
420 * platform/Widget.h:
421 (WebCore::Widget::boundsGeometry):
422 (WebCore::Widget::invalidate):
423 * platform/gtk/WidgetGtk.cpp:
424 * platform/mac/WidgetMac.mm:
425 * platform/qt/WidgetQt.cpp:
426 * platform/win/WidgetWin.cpp:
427 * platform/wx/WidgetWx.cpp:
428
weinig@apple.comcaf2df42008-09-18 19:40:24 +00004292008-09-18 Sam Weinig <sam@webkit.org>
430
431 Rubber-stamped in exile by David Hyatt.
432
433 Split Animation, AnimationList, BindingURI, ContentData, CounterContent,
434 KeyframeList, ShadowData, StyleFlexibleBoxData and TimingFunction out of
435 RenderStyle.h/cpp
436
437 * GNUmakefile.am:
438 * WebCore.pro:
439 * WebCore.vcproj/WebCore.vcproj:
440 * WebCore.xcodeproj/project.pbxproj:
441 * WebCoreSources.bkl:
442 * css/CSSStyleSelector.cpp:
443 * css/CSSStyleSelector.h:
444 * page/animation/CompositeAnimation.cpp:
445 * page/animation/KeyframeAnimation.cpp:
446 * page/animation/KeyframeAnimation.h:
447 * rendering/RenderCounter.h:
448 * rendering/style/Animation.cpp: Copied from rendering/style/RenderStyle.cpp.
449 (WebCore::Animation::~Animation):
450 (WebCore::Animation::animationsMatch):
451 (WebCore::Animation::keyframeList):
452 (WebCore::Animation::setAnimationKeyframe):
453 * rendering/style/Animation.h: Copied from rendering/style/RenderStyle.h.
454 * rendering/style/AnimationList.cpp: Copied from rendering/style/RenderStyle.cpp.
455 * rendering/style/AnimationList.h: Copied from rendering/style/RenderStyle.h.
456 * rendering/style/BindingURI.cpp: Copied from rendering/style/RenderStyle.cpp.
457 * rendering/style/BindingURI.h: Copied from rendering/style/RenderStyle.h.
458 (WebCore::BindingURI::operator!=):
459 * rendering/style/ContentData.cpp: Copied from rendering/style/RenderStyle.cpp.
460 * rendering/style/ContentData.h: Copied from rendering/style/RenderStyle.h.
461 (WebCore::ContentData::ContentData):
462 (WebCore::ContentData::~ContentData):
463 * rendering/style/CounterContent.h: Copied from rendering/style/RenderStyle.h.
464 (WebCore::CounterContent::CounterContent):
465 * rendering/style/CounterDirectives.cpp: Copied from rendering/style/RenderStyle.cpp.
466 * rendering/style/CounterDirectives.h: Copied from rendering/style/RenderStyle.h.
467 (WebCore::CounterDirectives::CounterDirectives):
468 * rendering/style/KeyframeList.cpp: Copied from rendering/style/RenderStyle.cpp.
469 (WebCore::KeyframeList::insert):
470 * rendering/style/KeyframeList.h: Copied from rendering/style/RenderStyle.h.
471 (WebCore::KeyframeValue::KeyframeValue):
472 (WebCore::KeyframeList::create):
473 (WebCore::KeyframeList::KeyframeList):
474 * rendering/style/RenderStyle.cpp:
475 * rendering/style/RenderStyle.h:
476 * rendering/style/ShadowData.cpp: Copied from rendering/style/RenderStyle.cpp.
477 * rendering/style/ShadowData.h: Copied from rendering/style/RenderStyle.h.
478 (WebCore::ShadowData::ShadowData):
479 (WebCore::ShadowData::~ShadowData):
480 (WebCore::ShadowData::operator!=):
481 * rendering/style/StyleFlexibleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
482 * rendering/style/StyleFlexibleBoxData.h: Copied from rendering/style/RenderStyle.h.
483 (WebCore::StyleFlexibleBoxData::operator!=):
484 * rendering/style/TimingFunction.h: Copied from rendering/style/RenderStyle.h.
485 (WebCore::TimingFunction::TimingFunction):
486 (WebCore::TimingFunction::operator==):
487
adele@apple.com5b2b5da2008-09-18 18:49:44 +00004882008-09-18 Adele Peterson <adele@apple.com>
489
490 Reviewed by Dan Bernstein.
491
492 Fix RenderStyle leaks.
493
494 * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
495
kmccullough@apple.comd4089752008-09-18 17:21:49 +00004962008-09-18 Kevin McCullough <kmccullough@apple.com>
497
kmccullough@apple.com76c708f2008-09-18 18:03:23 +0000498 Accidentally checked in code.
499
500 * html/HTMLElementFactory.cpp:
501 (WebCore::frameConstructor):
502 (WebCore::iframeConstructor):
503
5042008-09-18 Kevin McCullough <kmccullough@apple.com>
505
kmccullough@apple.comd4089752008-09-18 17:21:49 +0000506 Reviewed by Tim.
507
508 <rdar://problem/5722310> gracefully handle too many console messages
509 (20904)
510 - Keep track of the most previous message and then compare it to the
511 subsequent messages as they come in. If there are multiple of the same
512 message create a count that indicates the current number.
513
514 * manual-tests/inspector/multiple-console-messages.html: Added.
515 * page/inspector/Console.js:
516 * page/inspector/inspector.css:
517
alp@webkit.org18a1fbc2008-09-18 11:50:26 +00005182008-09-18 Jonathon Jongsma <jonathon@quotidian.org>
519
520 Reviewed by Alp Toker
521
522 https://bugs.webkit.org/show_bug.cgi?id=20830
523 [GTK] Don't use deprecated pango API
524
525 Replace deprecated pango functions with non-deprecated ones for newer
526 versions of pango
527
528 * platform/graphics/gtk/FontGtk.cpp:
529 (WebCore::getDefaultPangoLayout):
530 * platform/graphics/gtk/FontPlatformDataPango.cpp:
531 (WebCore::FontPlatformData::FontPlatformData):
532
alp@webkit.org2154ef22008-09-18 08:10:49 +00005332008-09-18 Alp Toker <alp@nuanti.com>
534
535 Build fix for r36587. Add new sources (and sort the lists).
536
537 * GNUmakefile.am:
538
weinig@apple.com3a98b2a2008-09-18 05:51:35 +00005392008-09-17 Sam Weinig <sam@webkit.org>
540
541 Fix Windows build.
542
543 * WebCore.vcproj/WebCore.vcproj:
544
hyatt@apple.comb3699722008-09-18 05:10:03 +00005452008-09-17 David Hyatt <hyatt@apple.com>
546
547 Switch back to having frameGeometry be virtual in order to keep Mac
548 the way it used to be.
549
550 Reviewed by Sam Weinig
551
552 * WebCore.base.exp:
553 * platform/Widget.cpp:
554 (WebCore::Widget::setParent):
555 * platform/Widget.h:
556 * platform/gtk/WidgetGtk.cpp:
557 (WebCore::Widget::frameGeometry):
558 (WebCore::Widget::setFrameGeometry):
559 * platform/mac/WidgetMac.mm:
560 (WebCore::Widget::frameGeometry):
561 (WebCore::Widget::setFrameGeometry):
562 * platform/qt/WidgetQt.cpp:
563 (WebCore::Widget::frameGeometry):
564 (WebCore::Widget::setFrameGeometry):
565 * platform/win/WidgetWin.cpp:
566 (WebCore::Widget::frameGeometry):
567 (WebCore::Widget::setFrameGeometry):
568 * platform/wx/WidgetWx.cpp:
569 (WebCore::Widget::frameGeometry):
570 (WebCore::Widget::setFrameGeometry):
571 * plugins/PluginView.cpp:
572 (WebCore::PluginView::setFrameGeometry):
573 (WebCore::PluginView::geometryChanged):
574 * plugins/PluginView.h:
575 * plugins/gtk/PluginViewGtk.cpp:
576 (WebCore::PluginView::updatePluginWidget):
577 * plugins/qt/PluginViewQt.cpp:
578 (WebCore::PluginView::updatePluginWidget):
579 * plugins/win/PluginViewWin.cpp:
580 (WebCore::PluginView::updatePluginWidget):
581
weinig@apple.com00f4d5c2008-09-18 03:23:08 +00005822008-09-17 Sam Weinig <sam@webkit.org>
583
weinig@apple.com4fd54cd2008-09-18 05:03:21 +0000584 Reviewed by Mark Rowe.
585
586 Fix assertion in DOMWindow::adjustWindowRect where we were passing
587 in garbage values and were getting lucky that they were a not Nan.
588
589 * bindings/js/JSDOMWindowBase.cpp:
590 (WebCore::windowProtoFuncOpen):
591
5922008-09-17 Sam Weinig <sam@webkit.org>
593
weinig@apple.com95b14762008-09-18 04:28:40 +0000594 Fix gtk build.
595
596 * rendering/style/MatrixTransformOperation.cpp:
597
5982008-09-17 Sam Weinig <sam@webkit.org>
599
weinig@apple.com00f4d5c2008-09-18 03:23:08 +0000600 Rubber-stamped with love by David Hyatt.
601
602 Split IdentityTransformOperation, MatrixTransformOperation, RotateTransformOperation,
603 ScaleTransformOperation, SkewTransformOperation, StyleTransformData, TransformOperation,
604 TransformOperations and TranslateTransformOperation out of RenderStyle.h/cpp
605
606 * GNUmakefile.am:
607 * WebCore.pro:
608 * WebCore.vcproj/WebCore.vcproj:
609 * WebCore.xcodeproj/project.pbxproj:
610 * WebCoreSources.bkl:
611 * css/CSSStyleSelector.cpp:
612 * page/animation/AnimationBase.cpp:
613 (WebCore::solveEpsilon):
614 * rendering/RenderLayer.cpp:
615 * rendering/style/IdentityTransformOperation.h: Copied from rendering/style/RenderStyle.h.
616 * rendering/style/MatrixTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
617 * rendering/style/MatrixTransformOperation.h: Copied from rendering/style/RenderStyle.h.
618 (WebCore::MatrixTransformOperation::MatrixTransformOperation):
619 * rendering/style/RenderStyle.cpp:
620 * rendering/style/RenderStyle.h:
621 * rendering/style/RotateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
622 * rendering/style/RotateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
623 (WebCore::RotateTransformOperation::RotateTransformOperation):
624 * rendering/style/ScaleTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
625 * rendering/style/ScaleTransformOperation.h: Copied from rendering/style/RenderStyle.h.
626 (WebCore::ScaleTransformOperation::ScaleTransformOperation):
627 * rendering/style/SkewTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
628 * rendering/style/SkewTransformOperation.h: Copied from rendering/style/RenderStyle.h.
629 (WebCore::SkewTransformOperation::SkewTransformOperation):
630 * rendering/style/StyleTransformData.cpp: Copied from rendering/style/RenderStyle.cpp.
631 * rendering/style/StyleTransformData.h: Copied from rendering/style/RenderStyle.h.
632 (WebCore::StyleTransformData::operator!=):
633 * rendering/style/TransformOperation.h: Copied from rendering/style/RenderStyle.h.
634 (WebCore::TransformOperation::):
635 * rendering/style/TransformOperations.cpp: Copied from rendering/style/RenderStyle.cpp.
636 (WebCore::TransformOperations::TransformOperations):
637 * rendering/style/TransformOperations.h: Copied from rendering/style/RenderStyle.h.
638 (WebCore::TransformOperations::operator!=):
639 * rendering/style/TranslateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
640 * rendering/style/TranslateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
641 (WebCore::TranslateTransformOperation::TranslateTransformOperation):
642
mrowe@apple.comdbfa8852008-09-18 02:59:20 +00006432008-09-17 Mark Rowe <mrowe@apple.com>
644
645 Build fix.
646
647 * rendering/style/StyleDashboardRegion.h: PlatformString.h rather than String.h.
648
hyatt@apple.com76057b42008-09-18 02:48:46 +00006492008-09-17 David Hyatt <hyatt@apple.com>
650
651 (1) Inline a bunch of methods for accessing frame geometry.
652 (2) Make sure frameGeometry() works even when you have no underlying
653 native widget.
654 (3) Cache a frame geometry rect cross-platform (even for widgets that
655 have underlying native widgets.
656 (4) PluginView's updateWindow call is now a virtual function on Widget.
657
658 Reviewed by Sam Weinig
659
660 * ChangeLog:
661 * WebCore.base.exp:
662 * platform/Widget.cpp:
663 (WebCore::Widget::setFrameGeometry):
664 * platform/Widget.h:
665 (WebCore::Widget::x):
666 (WebCore::Widget::y):
667 (WebCore::Widget::width):
668 (WebCore::Widget::height):
669 (WebCore::Widget::size):
670 (WebCore::Widget::pos):
671 (WebCore::Widget::frameGeometry):
672 (WebCore::Widget::resize):
673 (WebCore::Widget::move):
674 (WebCore::Widget::isFrameView):
675 (WebCore::Widget::windowClipRect):
676 * platform/mac/WidgetMac.mm:
677 (WebCore::Widget::~Widget):
678 (WebCore::Widget::updatePlatformWidgetFrameGeometry):
679 * platform/win/WidgetWin.cpp:
680 (WebCore::Widget::updatePlatformWidgetFrameGeometry):
681 * plugins/PluginView.cpp:
682 (WebCore::PluginView::setFrameGeometry):
683 (WebCore::PluginView::geometryChanged):
684 * plugins/PluginView.h:
685 * plugins/gtk/PluginViewGtk.cpp:
686 (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
687 * plugins/qt/PluginViewQt.cpp:
688 (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
689 * plugins/win/PluginViewWin.cpp:
690 (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
691 * plugins/wx/PluginViewWx.cpp:
692
weinig@apple.coma812a3ce2008-09-18 01:46:26 +00006932008-09-17 Sam Weinig <sam@webkit.org>
694
weinig@apple.comb4b66742008-09-18 02:47:55 +0000695 Reviewed by David "Waterman" Hyatt.
696
697 Fix a leak of NSViews in WidgetMac.mm.
698
699 * platform/mac/WidgetMac.mm:
700 (WebCore::Widget::~Widget):
701
7022008-09-17 Sam Weinig <sam@webkit.org>
703
weinig@apple.coma812a3ce2008-09-18 01:46:26 +0000704 Rubber-stamped by David Waterman Hyatt.
705
706 Split FillLayer, StyleBackgroundData, StyleBoxData, StyleDashboardRegion, StyleMarqueeData
707 StyleMultiColData and StyleVisualData out of RenderStyle.h/cpp
708
709 * GNUmakefile.am:
710 * WebCore.pro:
711 * WebCore.vcproj/WebCore.vcproj:
712 * WebCore.xcodeproj/project.pbxproj:
713 * WebCoreSources.bkl:
714 * rendering/style/FillLayer.cpp: Copied from rendering/style/RenderStyle.cpp.
715 * rendering/style/FillLayer.h: Copied from rendering/style/RenderStyle.h.
716 (WebCore::FillLayer::operator!=):
717 (WebCore::FillLayer::hasImage):
718 (WebCore::FillLayer::hasFixedImage):
719 * rendering/style/RenderStyle.cpp:
720 * rendering/style/RenderStyle.h:
721 * rendering/style/StyleBackgroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
722 (WebCore::StyleBackgroundData::StyleBackgroundData):
723 * rendering/style/StyleBackgroundData.h: Copied from rendering/style/RenderStyle.h.
724 (WebCore::StyleBackgroundData::~StyleBackgroundData):
725 (WebCore::StyleBackgroundData::operator!=):
726 * rendering/style/StyleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
727 * rendering/style/StyleBoxData.h: Copied from rendering/style/RenderStyle.h.
728 (WebCore::StyleBoxData::operator!=):
729 * rendering/style/StyleDashboardRegion.h: Copied from rendering/style/RenderStyle.h.
730 (WebCore::StyleDashboardRegion::operator!=):
731 * rendering/style/StyleMarqueeData.cpp: Copied from rendering/style/RenderStyle.cpp.
732 * rendering/style/StyleMarqueeData.h: Copied from rendering/style/RenderStyle.h.
733 (WebCore::StyleMarqueeData::operator!=):
734 * rendering/style/StyleMultiColData.cpp: Copied from rendering/style/RenderStyle.cpp.
735 * rendering/style/StyleMultiColData.h: Copied from rendering/style/RenderStyle.h.
736 (WebCore::StyleMultiColData::operator!=):
737 (WebCore::StyleMultiColData::ruleWidth):
738 * rendering/style/StyleVisualData.cpp: Copied from rendering/style/RenderStyle.cpp.
739 * rendering/style/StyleVisualData.h: Copied from rendering/style/RenderStyle.h.
740 (WebCore::StyleVisualData::operator==):
741
hyatt@apple.comb4f28b32008-09-18 00:39:36 +00007422008-09-17 David Hyatt <hyatt@apple.com>
743
hyatt@apple.com3f19eac2008-09-18 00:56:04 +0000744 Remove WidgetClient from Widget.
745
746 Reviewed by Sam Weinig
747
748 * WebCore.xcodeproj/project.pbxproj:
749 * platform/Widget.h:
750 (WebCore::Widget::setClient):
751 (WebCore::Widget::client):
752 * platform/WidgetClient.h: Removed.
753 * platform/gtk/WidgetGtk.cpp:
754 * platform/mac/WidgetMac.mm:
755 (WebCore::Widget::Widget):
756 (WebCore::Widget::show):
757 (WebCore::Widget::hide):
758 * platform/qt/WidgetQt.cpp:
759 (WebCore::WidgetPrivate::WidgetPrivate):
760 * platform/win/WidgetWin.cpp:
761 (WebCore::Widget::Widget):
762 * platform/wx/WidgetWx.cpp:
763 (WebCore::Widget::Widget):
764
7652008-09-17 David Hyatt <hyatt@apple.com>
766
hyatt@apple.comb4f28b32008-09-18 00:39:36 +0000767 Remove isEnabled/setEnabled from Widget. The concept of being enabled now
768 only applies to Scrollbars so the method has been moved there and made
769 cross-platform. Scrollbar subclasses that have a corresponding native
770 widget can subclass setEnabled to change the enabled state of the native
771 widget.
772
773 Reviewed by Sam Weinig & Darin Adler
774
775 * WebCore.base.exp:
776 * platform/Scrollbar.cpp:
777 (WebCore::Scrollbar::Scrollbar):
778 * platform/Scrollbar.h:
779 (WebCore::Scrollbar::enabled):
780 (WebCore::Scrollbar::setEnabled):
781 * platform/Widget.h:
782 * platform/gtk/ScrollbarGtk.cpp:
783 (ScrollbarGtk::setEnabled):
784 * platform/gtk/ScrollbarGtk.h:
785 * platform/gtk/WidgetGtk.cpp:
786 * platform/mac/ScrollbarMac.h:
787 * platform/mac/ScrollbarMac.mm:
788 (WebCore::ScrollbarMac::scrollbarHit):
789 (WebCore::ScrollbarMac::setEnabled):
790 * platform/mac/WidgetMac.mm:
791 * platform/qt/WidgetQt.cpp:
792 (WebCore::WidgetPrivate::WidgetPrivate):
793 * platform/win/WidgetWin.cpp:
794 (WebCore::Widget::Widget):
795 * platform/wx/WidgetWx.cpp:
796
weinig@apple.com1ea40602008-09-17 23:56:27 +00007972008-09-17 Sam Weinig <sam@webkit.org>
798
799 Rubber-stamped by David Hyatt.
800
801 Split all RenderStyle enums into their own file.
802
803 * GNUmakefile.am:
804 * WebCore.vcproj/WebCore.vcproj:
805 * WebCore.xcodeproj/project.pbxproj:
806 * rendering/style/BorderValue.h:
807 * rendering/style/CollapsedBorderValue.h:
808 * rendering/style/RenderStyle.h:
809 * rendering/style/RenderStyleConstants.h: Copied from rendering/style/RenderStyle.h.
810 (WebCore::):
811 * rendering/style/StyleCachedImage.h:
812 * rendering/style/StyleGeneratedImage.h:
813 * rendering/style/StyleImage.h:
814
sfalken@apple.combf270912008-09-17 23:53:17 +00008152008-09-17 Steve Falkenburg <sfalken@apple.com>
816
817 Add back isFrameView check to fix failed assertion during scroll bar teardown.
818
819 Reviewed by Dave Hyatt.
820
821 * platform/Scrollbar.cpp:
822 (WebCore::Scrollbar::setParent):
823
beidson@apple.com4398e482008-09-17 23:30:00 +00008242008-09-17 Brady Eidson <beidson@apple.com>
825
826 Reviewed by Mac build fix
827
828 * WebCore.xcodeproj/project.pbxproj: Send appropriate headers to WebKit
829
sfalken@apple.com85cc1392008-09-17 23:28:13 +00008302008-09-17 Steve Falkenburg <sfalken@apple.com>
831
832 Fix build.
833
834 * platform/win/ScrollViewWin.cpp:
835 (WebCore::ScrollView::setParentVisible):
836 * plugins/win/PluginViewWin.cpp:
837 (WebCore::PluginView::init):
838
zecke@webkit.org2ba9a4e2008-09-17 23:25:10 +00008392008-09-17 Holger Hans Peter Freyther <zecke@selfish.org>
840
841 Reviewed by Simon.
842
843 [QtWebKit] Implement error handling in TextCodecQt::decode
844 Use the QTextCodec parsing state to set the sawError out variable. This
845 is needed to pass Test 70 of acid3. The test case for this bug is
846 fast/encoding/invalid-xml.html that is now partially passed. To pass
847 it completely the Qt text codecs need to be adjusted to have proper
848 error handling.
849
850 * platform/text/qt/TextCodecQt.cpp:
851 (WebCore::TextCodecQt::decode):
852
weinig@apple.comf6f0f112008-09-17 23:03:16 +00008532008-09-17 Sam Weinig <sam@webkit.org>
854
855 Rubber-stamped by Dave Hyatt.
856
857 Split BorderData, BorderValue, CollapsedBorderValue, OutlineValue and StyleSurroundData
858 out of RenderStyle.h/cpp
859
860 * GNUmakefile.am:
861 * WebCore.pro:
862 * WebCore.vcproj/WebCore.vcproj:
863 * WebCore.xcodeproj/project.pbxproj:
864 * WebCoreSources.bkl:
865 * rendering/style/BorderData.h: Copied from rendering/style/RenderStyle.h.
866 (WebCore::BorderData::hasBorderRadius):
867 (WebCore::BorderData::borderLeftWidth):
868 (WebCore::BorderData::borderRightWidth):
869 (WebCore::BorderData::borderTopWidth):
870 (WebCore::BorderData::borderBottomWidth):
871 (WebCore::BorderData::operator!=):
872 * rendering/style/BorderValue.h: Copied from rendering/style/RenderStyle.h.
873 (WebCore::):
874 (WebCore::BorderValue::BorderValue):
875 (WebCore::BorderValue::nonZero):
876 (WebCore::BorderValue::isTransparent):
877 (WebCore::BorderValue::isVisible):
878 * rendering/style/CollapsedBorderValue.h: Copied from rendering/style/RenderStyle.h.
879 (WebCore::):
880 (WebCore::CollapsedBorderValue::CollapsedBorderValue):
881 (WebCore::CollapsedBorderValue::operator==):
882 * rendering/style/OutlineValue.h: Copied from rendering/style/RenderStyle.h.
883 (WebCore::OutlineValue::OutlineValue):
884 * rendering/style/RenderStyle.cpp:
885 * rendering/style/RenderStyle.h:
886 * rendering/style/StyleSurroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
887 * rendering/style/StyleSurroundData.h: Copied from rendering/style/RenderStyle.h.
888 (WebCore::StyleSurroundData::operator!=):
889
bdakin@apple.com06b97182008-09-17 23:00:29 +00008902008-09-17 Beth Dakin <bdakin@apple.com>
891
892 Reviewed by Darin Adler.
893
894 This is a better fix for: Invalid CSS code crashes Safari
895 https://bugs.webkit.org/show_bug.cgi?id=20512
896
897 The spec indicates that the only valid input for a counter is a
898 number or an identifier. So that is exactly what we allow.
899
900 * css/CSSParser.cpp:
901 (WebCore::CSSParser::parseCounterContent):
902
alp@webkit.org97ba9222008-09-17 22:16:26 +00009032008-09-17 Alp Toker <alp@nuanti.com>
904
905 GTK+ build fix. Adapt to use PlatformWidget functions.
906
907 * platform/gtk/ScrollViewGtk.cpp:
908 (WebCore::ScrollViewScrollbar::geometryChanged):
909 (WebCore::ScrollView::addChild):
910 (WebCore::ScrollView::removeChild):
911 * platform/gtk/ScrollbarGtk.cpp:
912 (ScrollbarGtk::ScrollbarGtk):
913 (ScrollbarGtk::~ScrollbarGtk):
914 (ScrollbarGtk::geometryChanged):
915
weinig@apple.com930ed392008-09-17 22:00:45 +00009162008-09-17 Sam Weinig <sam@webkit.org>
917
918 Reviewed by Adele Peterson.
919
920 Patch for <rdar://problem/6133884>
921 Calling window.resizeTo() on a subframe shouldn't change the window size
922
923 Test: fast/dom/Window/window-resize-and-move-sub-frame.html
924
925 * page/DOMWindow.cpp:
926 (WebCore::DOMWindow::moveBy):
927 (WebCore::DOMWindow::moveTo):
928 (WebCore::DOMWindow::resizeBy):
929 (WebCore::DOMWindow::resizeTo):
930
bdakin@apple.com8f952d82008-09-17 21:35:02 +00009312008-09-17 Beth Dakin <bdakin@apple.com>
932
933 Reviewed by Adam Roben.
934
935 Fix for https://bugs.webkit.org/show_bug.cgi?id=20512 Invalid CSS
936 code crashes Safari
937 and corresponding: <rdar://problem/6173832>
938
939 Reading through the spec, it seems like a function is not valid
940 input for a counter. So this patch checks for that and bails in the
941 case of invalid input.
942
943 * css/CSSParser.cpp:
944 (WebCore::CSSParser::parseCounterContent):
945
antti@apple.comb37d4052008-09-17 21:14:13 +00009462008-09-17 Greg Bolsinga <bolsinga@apple.com>
947
948 Reviewed by Antti Koivisto.
949
950 Fix <rdar://problem/6227089>
951 Crash in WebCore::Frame::setNeedsReapplyStyles()
952
953 View is null checked elsewhere too.
954
955 * page/Frame.cpp:
956 (WebCore::Frame::setNeedsReapplyStyles):
957
hyatt@apple.com8e340252008-09-17 20:59:45 +00009582008-09-17 David Hyatt <hyatt@apple.com>
959
960 Make the notion of having a native widget backing a Widget cross-platform.
961 The PlatformWidget abstraction (which already existed) is used for this.
962 Windows = HWND
963 Qt = QWidget
964 Mac = NSView
965 wx = wxWindow
966 Gtk = GtkWidget
967
968 There are new cross-platform methods that replace all of the unique
969 platform-specific methods.
970 platformWidget()
971 setPlatformWidget()
972
973 For plugins, on every platform except Qt on Windows, the plugin's native
974 widget is now stored in the Widget base class. Since Qt on Windows uses
975 HWNDs for plugins instead of QWidget, it is the only platform to keep the
976 m_window variable in PluginView.
977
978 Reviewed by Sam Weinig
979
980 * WebCore.base.exp:
981 * bindings/js/ScriptControllerMac.mm:
982 (WebCore::ScriptController::createScriptInstanceForWidget):
983 * page/mac/AccessibilityObjectWrapper.mm:
984 (-[AccessibilityObjectWrapper attachmentView]):
985 (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
986 * page/mac/EventHandlerMac.mm:
987 (WebCore::EventHandler::passMouseDownEventToWidget):
988 (WebCore::EventHandler::mouseDownViewIfStillGood):
989 (WebCore::EventHandler::passWheelEventToWidget):
990 (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
991 * platform/Widget.cpp:
992 (WebCore::Widget::init):
993 (WebCore::Widget::setParent):
994 (WebCore::Widget::releasePlatformWidget):
995 (WebCore::Widget::retainPlatformWidget):
996 * platform/Widget.h:
997 (WebCore::Widget::platformWidget):
998 (WebCore::Widget::setPlatformWidget):
999 * platform/gtk/WidgetGtk.cpp:
1000 (WebCore::Widget::Widget):
1001 (WebCore::Widget::setFocus):
1002 (WebCore::gdkDrawable):
1003 (WebCore::Widget::setCursor):
1004 (WebCore::Widget::show):
1005 (WebCore::Widget::hide):
1006 (WebCore::Widget::setEnabled):
1007 (WebCore::Widget::isEnabled):
1008 (WebCore::Widget::paint):
1009 * platform/mac/PlatformScreenMac.mm:
1010 (WebCore::screenRect):
1011 (WebCore::screenAvailableRect):
1012 * platform/mac/ScrollViewMac.mm:
1013 (WebCore::ScrollView::scrollView):
1014 (WebCore::ScrollView::update):
1015 (WebCore::ScrollView::inWindow):
1016 * platform/mac/ScrollbarMac.mm:
1017 (WebCore::ScrollbarMac::ScrollbarMac):
1018 (WebCore::ScrollbarMac::~ScrollbarMac):
1019 (WebCore::ScrollbarMac::updateThumbPosition):
1020 (WebCore::ScrollbarMac::updateThumbProportion):
1021 (WebCore::ScrollbarMac::scrollbarHit):
1022 * platform/mac/WidgetMac.mm:
1023 (WebCore::Widget::Widget):
1024 (WebCore::Widget::setEnabled):
1025 (WebCore::Widget::isEnabled):
1026 (WebCore::Widget::setFocus):
1027 (WebCore::Widget::getOuterView):
1028 (WebCore::Widget::paint):
1029 (WebCore::Widget::invalidate):
1030 (WebCore::Widget::invalidateRect):
1031 (WebCore::Widget::setIsSelected):
1032 (WebCore::Widget::releasePlatformWidget):
1033 (WebCore::Widget::retainPlatformWidget):
1034 * platform/qt/WidgetQt.cpp:
1035 (WebCore::WidgetPrivate::WidgetPrivate):
1036 (WebCore::Widget::Widget):
1037 (WebCore::Widget::setFrameGeometry):
1038 (WebCore::Widget::show):
1039 (WebCore::Widget::hide):
1040 (WebCore::Widget::isEnabled):
1041 (WebCore::Widget::setEnabled):
1042 (WebCore::Widget::invalidateRect):
1043 (WebCore::Widget::containingWindow):
1044 * platform/win/WidgetWin.cpp:
1045 (WebCore::Widget::Widget):
1046 * platform/wx/WidgetWx.cpp:
1047 (WebCore::Widget::Widget):
1048 (WebCore::Widget::frameGeometry):
1049 (WebCore::Widget::setFocus):
1050 (WebCore::Widget::setCursor):
1051 (WebCore::Widget::show):
1052 (WebCore::Widget::hide):
1053 (WebCore::Widget::setFrameGeometry):
1054 (WebCore::Widget::setEnabled):
1055 (WebCore::Widget::isEnabled):
1056 (WebCore::Widget::invalidate):
1057 (WebCore::Widget::invalidateRect):
1058 (WebCore::Widget::paint):
1059 * plugins/PluginView.cpp:
1060 (WebCore::PluginView::PluginView):
1061 * plugins/PluginView.h:
1062 (WebCore::PluginView::platformPluginWidget):
1063 * plugins/gtk/PluginViewGtk.cpp:
1064 (WebCore::PluginView::updateWindow):
1065 (WebCore::PluginView::setFocus):
1066 (WebCore::PluginView::show):
1067 (WebCore::PluginView::hide):
1068 (WebCore::PluginView::setParent):
1069 (WebCore::PluginView::setNPWindowRect):
1070 (WebCore::PluginView::setParentVisible):
1071 (WebCore::PluginView::getValue):
1072 (WebCore::PluginView::forceRedraw):
1073 (WebCore::PluginView::init):
1074 * plugins/qt/PluginViewQt.cpp:
1075 (WebCore::PluginView::updateWindow):
1076 (WebCore::PluginView::setFocus):
1077 (WebCore::PluginView::show):
1078 (WebCore::PluginView::hide):
1079 (WebCore::PluginView::setParent):
1080 (WebCore::PluginView::setNPWindowRect):
1081 (WebCore::PluginView::setParentVisible):
1082 (WebCore::PluginView::getValue):
1083 (WebCore::PluginView::~PluginView):
1084 (WebCore::PluginView::init):
1085 * plugins/win/PluginViewWin.cpp:
1086 (WebCore::PluginView::updateWindow):
1087 (WebCore::PluginView::setFocus):
1088 (WebCore::PluginView::show):
1089 (WebCore::PluginView::hide):
1090 (WebCore::PluginView::paint):
1091 (WebCore::PluginView::setParent):
1092 (WebCore::PluginView::setParentVisible):
1093 (WebCore::PluginView::setNPWindowRect):
1094 (WebCore::PluginView::stop):
1095 (WebCore::PluginView::invalidateRect):
1096 (WebCore::PluginView::forceRedraw):
1097 (WebCore::PluginView::~PluginView):
1098 (WebCore::PluginView::init):
1099
weinig@apple.comf713d132008-09-17 20:16:48 +000011002008-09-17 Sam Weinig <sam@webkit.org>
1101
1102 Fix assert.
1103
1104 * platform/Widget.cpp:
1105 (WebCore::Widget::setParent):
1106
hyatt@apple.comd9242e32008-09-17 18:46:31 +000011072008-09-17 David Hyatt <hyatt@apple.com>
1108
1109 Beginnings of Widget refactoring (in order to make the mixing of
1110 widgets with and without corresponding native widgets more cross-platform).
1111
1112 This first patch makes the concept of a parent ScrollView cross-platform.
1113
1114 Note the similarity of the show/hide methods on the three PluginViews. This
1115 will be refactored better in a later patch so that they can all share
1116 a base class Widget show/hide method. For now the changes were made
1117 simply to be able to bring WidgetWin's setParent method up into Widget.
1118
1119 Reviewed by Sam Weinig
1120
1121 * WebCore.base.exp:
1122 * platform/ScrollView.h:
1123 * platform/Widget.cpp:
1124 (WebCore::Widget::init):
1125 (WebCore::Widget::setParent):
1126 * platform/Widget.h:
1127 (WebCore::Widget::isSelfVisible):
1128 (WebCore::Widget::isParentVisible):
1129 (WebCore::Widget::isVisible):
1130 (WebCore::Widget::setParentVisible):
1131 (WebCore::Widget::isPluginView):
1132 (WebCore::Widget::parent):
1133 (WebCore::Widget::handleEvent):
1134 (WebCore::Widget::geometryChanged):
1135 * platform/gtk/WidgetGtk.cpp:
1136 (WebCore::Widget::Widget):
1137 * platform/mac/ScrollViewMac.mm:
1138 (WebCore::ScrollView::addChild):
1139 (WebCore::ScrollView::removeChild):
1140 * platform/mac/ScrollbarMac.mm:
1141 (WebCore::ScrollbarMac::~ScrollbarMac):
1142 * platform/mac/WidgetMac.mm:
1143 (WebCore::Widget::Widget):
1144 (WebCore::Widget::~Widget):
1145 * platform/qt/WidgetQt.cpp:
1146 (WebCore::WidgetPrivate::WidgetPrivate):
1147 (WebCore::Widget::Widget):
1148 (WebCore::Widget::topLevel):
1149 * platform/win/ScrollViewWin.cpp:
1150 (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
1151 (WebCore::ScrollView::setAncestorVisible):
1152 (WebCore::ScrollView::show):
1153 (WebCore::ScrollView::hide):
1154 * platform/win/WidgetWin.cpp:
1155 (WebCore::Widget::Widget):
1156 (WebCore::Widget::setParent):
1157 * platform/wx/WidgetWx.cpp:
1158 (WebCore::Widget::Widget):
1159 * plugins/PluginView.cpp:
1160 (WebCore::PluginView::PluginView):
1161 * plugins/PluginView.h:
1162 * plugins/gtk/PluginViewGtk.cpp:
1163 (WebCore::PluginView::show):
1164 (WebCore::PluginView::hide):
1165 (WebCore::PluginView::setParentVisible):
1166 * plugins/qt/PluginViewQt.cpp:
1167 (WebCore::PluginView::show):
1168 (WebCore::PluginView::hide):
1169 (WebCore::PluginView::setParentVisible):
1170 * plugins/win/PluginViewWin.cpp:
1171 (WebCore::PluginView::show):
1172 (WebCore::PluginView::hide):
1173 (WebCore::PluginView::setParentVisible):
1174
ap@webkit.org18da1a32008-09-17 16:50:22 +000011752008-09-17 Alexey Proskuryakov <ap@webkit.org>
1176
1177 Reviewed by Adam Roben.
1178
1179 <rdar://problem/6219577> Spew in console at launch about encoding mappings when running with ICU 4.0
1180
1181 * platform/text/TextCodecICU.cpp:
1182 (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated for new encoding names.
1183
vestbo@webkit.orge48e6362008-09-17 13:29:42 +000011842008-09-17 Tor Arne Vestbø <tavestbo@trolltech.com>
1185
1186 Fix the QtWebKit/Mac build
1187
1188 * platform/qt/ScrollViewQt.cpp: add include
1189
ap@webkit.org18da1a32008-09-17 16:50:22 +000011902008-09-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com0f37fb52008-09-17 08:17:26 +00001191
1192 Add a #define to control whether or not to use an NSScroller on Mac.
1193 This ifdef will allow the new NSView-less NSScroller on Mac to be
1194 developed side by side with the current one.
1195
1196 The new scroller paints a debug red if turned on (although due to
1197 Widget issues you won't see anything paint yet).
1198
1199 Reviewed by olliej
1200
1201 * platform/Scrollbar.cpp:
1202 * platform/Scrollbar.h:
1203 * platform/mac/ScrollbarMac.h:
1204 * platform/mac/ScrollbarMac.mm:
1205 * platform/mac/ScrollbarThemeMac.cpp:
1206 (WebCore::ScrollbarThemeMac::paint):
1207 * platform/mac/ScrollbarThemeMac.h:
1208
alp@webkit.orgf06bac02008-09-17 04:30:12 +000012092008-09-16 Marco Barisione <marco.barisione@collabora.co.uk>
1210
1211 Reviewed by Alp Toker.
1212
1213 http://bugs.webkit.org/show_bug.cgi?id=20854
1214 [GTK] Windows can be not realized in ScrollView::update
1215
1216 Do not call gdk_window_invalidate_rect on a non-realized GtkWidget.
1217
1218 * platform/gtk/ScrollViewGtk.cpp:
1219 (WebCore::ScrollView::update):
1220
alp@webkit.org226f72a2008-09-17 04:22:02 +000012212008-09-16 Alp Toker <alp@nuanti.com>
1222
1223 Suggested by Dave Hyatt.
1224
1225 Build fix and cleanup. Rename ScrollBar to Scrollbar.
1226
1227 * GNUmakefile.am:
1228 * WebCore.pro:
1229 * WebCore.vcproj/WebCore.vcproj:
1230 * WebCore.xcodeproj/project.pbxproj:
1231 * WebCoreSources.bkl:
1232 * editing/EditorCommand.cpp:
1233 * page/EventHandler.cpp:
1234 * page/gtk/EventHandlerGtk.cpp:
1235 * page/mac/EventHandlerMac.mm:
1236 * page/mac/FrameMac.mm:
1237 * page/qt/EventHandlerQt.cpp:
1238 * page/wx/EventHandlerWx.cpp:
1239 * platform/PopupMenu.h:
1240 * platform/ScrollBar.cpp: Removed.
1241 * platform/ScrollBar.h: Removed.
1242 * platform/Scrollbar.cpp: Copied from WebCore/platform/ScrollBar.cpp.
1243 * platform/Scrollbar.h: Copied from WebCore/platform/ScrollBar.h.
1244 * platform/gtk/ScrollbarGtk.cpp:
1245 (ScrollbarGtk::ScrollbarGtk):
1246 * platform/gtk/ScrollbarGtk.h:
1247 * platform/mac/ScrollbarMac.h:
1248 * platform/qt/ScrollViewQt.cpp:
1249 * platform/qt/ScrollbarQt.cpp:
1250 * platform/qt/ScrollbarThemeQt.cpp:
1251 * platform/win/PlatformScrollBar.h:
1252 * platform/win/PopupMenuWin.cpp:
1253 * platform/win/ScrollViewWin.cpp:
1254 * platform/win/ScrollbarThemeWin.cpp:
1255 * platform/wx/ScrollViewWx.cpp:
1256 * platform/wx/TemporaryLinkStubs.cpp:
1257 * rendering/HitTestResult.cpp:
1258 * rendering/RenderLayer.cpp:
1259 * rendering/RenderTextControl.cpp:
1260
hyatt@apple.com7597c172008-09-17 02:15:08 +000012612008-09-16 David Hyatt <hyatt@apple.com>
1262
hyatt@apple.comfde412d2008-09-17 03:49:48 +00001263 Fix Qt build bustage by making moveThumb a member of Scrollbar so that
1264 it can be called from ScrollbarQt.
1265
1266 * platform/ScrollBar.cpp:
1267 (WebCore::Scrollbar::moveThumb):
1268 (WebCore::Scrollbar::handleMouseMoveEvent):
1269 (WebCore::Scrollbar::handleMousePressEvent):
1270 * platform/ScrollBar.h:
1271 * platform/qt/ScrollViewQt.cpp:
1272 * platform/qt/ScrollbarQt.cpp:
1273 (WebCore::Scrollbar::handleContextMenuEvent):
1274
12752008-09-16 David Hyatt <hyatt@apple.com>
1276
hyatt@apple.com4e3b8602008-09-17 03:17:11 +00001277 Eliminate PlatformScrollbar. Mac and Gtk now have subclasses for their
1278 native-widget scrollbars (ScrollbarMac and ScrollbarGtk). Other platforms
1279 now just use Scrollbar.
1280
1281 Reviewed by Sam Weinig
1282
1283 * GNUmakefile.am:
1284 * WebCore.pro:
1285 * WebCore.vcproj/WebCore.vcproj:
1286 * WebCore.xcodeproj/project.pbxproj:
1287 * page/mac/FrameMac.mm:
1288 * platform/PopupMenu.h:
1289 (WebCore::PopupMenu::scrollbar):
1290 * platform/ScrollBar.cpp:
1291 (WebCore::createNativeScrollbar):
1292 * platform/ScrollBar.h:
1293 * platform/gtk/PlatformScrollBar.h: Removed.
1294 * platform/gtk/PlatformScrollBarGtk.cpp: Removed.
1295 * platform/gtk/ScrollbarGtk.cpp: Copied from platform/gtk/PlatformScrollBarGtk.cpp.
1296 (gtkScrollEventCallback):
1297 (ScrollbarGtk::ScrollbarGtk):
1298 (ScrollbarGtk::~ScrollbarGtk):
1299 (ScrollbarGtk::updateThumbPosition):
1300 (ScrollbarGtk::updateThumbProportion):
1301 (ScrollbarGtk::setFrameGeometry):
1302 (ScrollbarGtk::geometryChanged):
1303 (ScrollbarGtk::gtkValueChanged):
1304 * platform/gtk/ScrollbarGtk.h: Copied from platform/gtk/PlatformScrollBar.h.
1305 * platform/mac/PlatformScrollBar.h: Removed.
1306 * platform/mac/PlatformScrollBarMac.mm: Removed.
1307 * platform/mac/ScrollbarMac.h: Copied from platform/mac/PlatformScrollBar.h.
1308 * platform/mac/ScrollbarMac.mm: Copied from platform/mac/PlatformScrollBarMac.mm.
1309 (-[WebCoreScrollBar initWithScrollbarMac:]):
1310 (-[WebCoreScrollBar detachScrollbarMac]):
1311 (WebCore::Scrollbar::createNativeScrollbar):
1312 (WebCore::ScrollbarMac::ScrollbarMac):
1313 (WebCore::ScrollbarMac::~ScrollbarMac):
1314 (WebCore::ScrollbarMac::updateThumbPosition):
1315 (WebCore::ScrollbarMac::updateThumbProportion):
1316 (WebCore::ScrollbarMac::scrollbarHit):
1317 * platform/qt/PlatformScrollBar.h: Removed.
1318 * platform/qt/PlatformScrollBarQt.cpp: Removed.
1319 * platform/qt/ScrollbarQt.cpp: Copied from platform/qt/PlatformScrollBarQt.cpp.
1320 (WebCore::Scrollbar::handleContextMenuEvent):
1321 * rendering/HitTestResult.cpp:
1322 * rendering/RenderLayer.cpp:
1323 (WebCore::RenderLayer::createScrollbar):
1324 (WebCore::RenderLayer::destroyScrollbar):
1325 * rendering/RenderLayer.h:
1326 * rendering/RenderListBox.cpp:
1327 (WebCore::RenderListBox::~RenderListBox):
1328 (WebCore::RenderListBox::updateFromElement):
1329 (WebCore::RenderListBox::isPointInOverflowControl):
1330 * rendering/RenderObject.h:
1331 * rendering/RenderTextControl.cpp:
1332
13332008-09-16 David Hyatt <hyatt@apple.com>
1334
hyatt@apple.com7597c172008-09-17 02:15:08 +00001335 Make the scrollbar resizer-dodging logic cross-platform in the
1336 Scrollbar class.
1337
1338 Reviewed by Sam Weinig
1339
1340 * platform/ScrollBar.cpp:
1341 (WebCore::Scrollbar::setFrameGeometry):
1342 (WebCore::Scrollbar::setParent):
1343 (WebCore::Scrollbar::windowClipRect):
1344 * platform/ScrollBar.h:
1345 * platform/ScrollView.h:
1346 (WebCore::ScrollView::windowResizerRect):
1347 (WebCore::ScrollView::resizerOverlapsContent):
1348 (WebCore::ScrollView::adjustOverlappingScrollbarCount):
1349 * platform/Widget.h:
1350 (WebCore::Widget::setParent):
1351 * platform/mac/WidgetMac.mm:
1352 (WebCore::Widget::convertToContainingWindow):
1353 * platform/win/PlatformScrollBar.h:
1354 * platform/win/PlatformScrollBarWin.cpp:
1355
mitz@apple.com6d925202008-09-16 17:34:10 +000013562008-09-16 Dan Bernstein <mitz@apple.com>
1357
mitz@apple.comd9462a52008-09-16 17:40:20 +00001358 Reviewed by Darin Adler.
1359
1360 - fix https://bugs.webkit.org/show_bug.cgi?id=15129
1361 <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
1362
1363 Covered by fast/repaint/4776765.html
1364
1365 * rendering/RenderBlock.cpp:
1366 (WebCore::RenderBlock::layoutBlock): Avoid repainting this object if it
1367 did not have layout in the beginning.
1368 (WebCore::RenderBlock::layoutBlockChildren): If a child did not have
1369 layout in the beginning, repaint it in its new position, to compensate
1370 for the above (regardless of whether it "moved").
1371 * rendering/RenderObject.cpp:
1372 (WebCore::RenderObject::checkForRepaintDuringLayout): Added a comment
1373 about generalizing this fix in the future.
1374
13752008-09-16 Dan Bernstein <mitz@apple.com>
1376
mitz@apple.com6d925202008-09-16 17:34:10 +00001377 Reviewed by Dave Hyatt.
1378
1379 - fix https://bugs.webkit.org/show_bug.cgi?id=15384
1380 Div does not notice when grandparent changes height
1381
1382 Test: fast/block/basic/quirk-percent-height-grandchild.html
1383
1384 - fix https://bugs.webkit.org/show_bug.cgi?id=20714
1385 Resizing Gmail inbox vertically results in whitespace at the bottom of the window
1386
1387 Test: fast/replaced/percent-height-in-anonymous-block.html
1388
1389 Added a two-way mapping between boxes with percentage heights and
1390 their non-parent ancestors up to the one the height is computed relative
1391 to. In quirks mode (the first bug), this can be any number of containing
1392 block with auto height. In strict mode (the second bug) this can be
1393 the containing block of an anonymous block containing a replaced
1394 element.
1395
1396 * rendering/RenderBlock.cpp:
1397 (WebCore::RenderBlock::~RenderBlock): Added code to remove the all the
1398 mapping to/from this block to percentage-height descendants.
1399 (WebCore::RenderBlock::layoutBlockChildren): Added code to mark
1400 percentage-height descendants (and their containing block ancestry chain
1401 up to this block) for layout. This ensures that those descendants whose
1402 height depends on the height of this block (or an ancestor) are updated.
1403 (WebCore::RenderBlock::addPercentHeightDescendant): Added. Establishes
1404 a two-way mapping between this block and the given box.
1405 (WebCore::RenderBlock::removePercentHeightDescendant): Added. Removes
1406 all the mapping to/from this box.
1407 * rendering/RenderBlock.h:
1408 * rendering/RenderBox.cpp:
1409 (WebCore::RenderBox::setStyle): Added calls to
1410 removePercentHeightDescendant() when style changes and the box
1411 previously had a percentage height. An exception is when the style
1412 change does not require layout, in which case the box still has
1413 a percentage height and the mappings are valid. In all other cases,
1414 any required mappings will be (re-)established during layout.
1415 (WebCore::RenderBox::destroy): Added a call to
1416 removePercentHeightDescendant.
1417 (WebCore::RenderBox::calcPercentageHeight): Added code that, in quirks
1418 mode, if a higher-than-parent containing block is affecting the box's
1419 height, creates a mapping between the box and that block.
1420 (WebCore::RenderBox::calcReplacedHeightUsing): Changed to skip over
1421 anonymous containing blocks, if any, and when that happens, use
1422 addPercentHeightDescendant() to ensure that the non-anonymous block
1423 is aware of the dependent percent-height box.
1424
alp@webkit.org1dbd9a92008-09-16 16:59:18 +000014252008-09-16 Dirk Schulze <vbs85@gmx.de>
1426
1427 Reviewed by Oliver Hunt and Alp Toker.
1428
1429 Implemented toDataURL in Cairo. Only PNG support
1430 at the moment.
1431
1432 Qt, Cairo and wx require toDataURL implementations
1433 https://bugs.webkit.org/show_bug.cgi?id=17719
1434
1435 * platform/MIMETypeRegistry.cpp:
1436 (WebCore::initializeSupportedImageMIMETypesForEncoding):
1437 * platform/graphics/cairo/ImageBufferCairo.cpp:
1438 (WebCore::ImageBuffer::ImageBuffer):
1439 (WebCore::writeFunction):
1440 (WebCore::ImageBuffer::toDataURL):
1441
vestbo@webkit.org8963b3c2008-09-16 16:45:20 +000014422008-09-16 Tor Arne Vestbø <tavestbo@trolltech.com>
1443
1444 Reviewed by Simon.
1445
1446 Hide unused media element controls in the QtWebKit port
1447
1448 * platform/qt/html4-adjustments-qt.css
1449
hausmann@webkit.orgcd7a1292008-09-16 14:19:16 +000014502008-09-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
1451
1452 Reviewed by Simon.
1453
1454 Fix compilation of the Qt scrollbar code.
1455
1456 * platform/qt/PlatformScrollBarQt.cpp:
1457 (WebCore::scPart):
1458 (WebCore::styleOptionSlider):
1459 (WebCore::thumbLength):
1460 (WebCore::pixelPosToRangeValue):
1461 (WebCore::PlatformScrollbar::handleContextMenuEvent):
1462
treat@webkit.orga35f6b62008-09-16 14:15:29 +000014632008-09-16 Adam Treat <treat@kde.org>
1464
1465 Reviewed by Anders Carlsson.
1466
1467 Prevent accesses off of the end of the buffer introduced in r36450
1468 and when checking for descriptions of mime. Also, coding style fix.
1469
1470 * plugins/qt/PluginPackageQt.cpp:
1471 (WebCore::PluginPackage::fetchInfo):
1472
rwlbuis@webkit.org8f675dd2008-09-16 11:12:52 +000014732008-09-15 Rob Buis <buis@kde.org>
1474
1475 Reviewed by Eric.
1476
1477 https://bugs.webkit.org/show_bug.cgi?id=20634
1478 SVG transform attribute is ignored by <use> in <clipPath>
1479
1480 Transform the paths with the local transform when part
1481 of a clip path.
1482
1483 Test: svg/custom/use-clipped-transform.svg
1484
1485 * svg/SVGClipPathElement.cpp:
1486 (WebCore::SVGClipPathElement::canvasResource):
1487 * svg/SVGStyledTransformableElement.cpp:
1488 (WebCore::SVGStyledTransformableElement::toClipPath):
1489 * svg/SVGStyledTransformableElement.h:
1490
hyatt@apple.com1cd4bcc2008-09-16 06:53:34 +000014912008-09-15 Dave Hyatt <hyatt@apple.com>
1492
1493 Convert Qt over to its ScrollbarTheme. Add cross-platform support for jumping the thumb location directly
1494 to a pressed location on the track (this is done with the middle mouse on Qt and with Shift-Click on Windows).
1495
1496 Reviewed by Sam Weinig
1497
1498 * platform/ScrollBar.cpp:
1499 (WebCore::thumbUnderMouse):
1500 (WebCore::Scrollbar::autoscrollPressedPart):
1501 (WebCore::Scrollbar::startTimerIfNeeded):
1502 (WebCore::moveThumb):
1503 (WebCore::Scrollbar::handleMouseMoveEvent):
1504 (WebCore::Scrollbar::handleMousePressEvent):
1505 * platform/ScrollBar.h:
1506 (WebCore::Scrollbar::pressedPos):
1507 (WebCore::Scrollbar::pixelStep):
1508 (WebCore::Scrollbar::setPressedPos):
1509 * platform/ScrollbarTheme.h:
1510 (WebCore::ScrollbarTheme::thumbPosition):
1511 (WebCore::ScrollbarTheme::thumbLength):
1512 (WebCore::ScrollbarTheme::trackPosition):
1513 (WebCore::ScrollbarTheme::trackLength):
1514 * platform/ScrollbarThemeComposite.cpp:
1515 (WebCore::ScrollbarThemeComposite::trackPosition):
1516 * platform/ScrollbarThemeComposite.h:
1517 * platform/qt/PlatformScrollBarQt.cpp:
1518 (WebCore::PlatformScrollbar::PlatformScrollbar):
1519 (WebCore::):
1520 * platform/qt/ScrollbarThemeQt.cpp:
1521 (WebCore::styleOptionSlider):
1522 (WebCore::ScrollbarThemeQt::hitTest):
1523 (WebCore::ScrollbarThemeQt::shouldCenterOnThumb):
1524 (WebCore::ScrollbarThemeQt::invalidatePart):
1525 (WebCore::ScrollbarThemeQt::thumbPosition):
1526 (WebCore::):
1527 * platform/qt/ScrollbarThemeQt.h:
1528 * platform/win/ScrollbarThemeSafari.cpp:
1529 (WebCore::ScrollbarThemeSafari::shouldCenterOnThumb):
1530 * platform/win/ScrollbarThemeSafari.h:
1531 * platform/win/ScrollbarThemeWin.cpp:
1532 (WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
1533 * platform/win/ScrollbarThemeWin.h:
1534
dsmith@webkit.orgb3107b532008-09-16 06:14:22 +000015352008-09-15 David Smith <catfish.man@gmail.com>
1536
1537 Reviewed by Sam Weinig.
1538
1539 https://bugs.webkit.org/show_bug.cgi?id=20180
1540
1541 Cache the result of parsing the an+b expression in :nth-child(an+b). Roughly a 2x speedup for :nth-child on SlickSpeed.
1542
1543 * GNUmakefile.am: Add CSSNthSelector
1544 * WebCore.pro: Add CSSNthSelector
1545 * WebCore.vcproj/WebCore.vcproj: Add CSSNthSelector
1546 * WebCore.xcodeproj/project.pbxproj: Add CSSNthSelector
1547 * css/CSSGrammar.y: Create CSSNthSelectors instead of CSSSelectors for :nth-*
1548 * css/CSSNthSelector.cpp: Added.
1549 (WebCore::CSSNthSelector::parseNth): Moved from CSSStyleSelector and modified to cache
1550 (WebCore::CSSNthSelector::matchNth): Moved from CSSStyleSelector and modified to use the cache
1551 * css/CSSNthSelector.h: Added.
1552 (WebCore::CSSNthSelector::CSSNthSelector):
1553 (WebCore::CSSNthSelector::~CSSNthSelector):
1554 * css/CSSParser.cpp:
1555 (WebCore::CSSParser::createFloatingNthSelector):
1556 * css/CSSParser.h:
1557 * css/CSSSelector.h: Use the free bit here to store a flag for CSSNthSelector
1558 (WebCore::CSSSelector::CSSSelector):
1559 * css/CSSStyleSelector.cpp:
1560 (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Take advantage of knowing that all :nth-* selectors are CSSNthSelectors
1561
pewtermoose@webkit.orgfb4d3fb2008-09-16 02:46:39 +000015622008-09-15 Matt Lilek <webkit@mattlilek.com>
1563
1564 Reviewed by Tim Hatcher.
1565
1566 Clean up some inspector JS callbacks to remove an extra return.
1567
1568 * page/InspectorController.cpp:
1569 (WebCore::hideDOMNodeHighlight):
1570 (WebCore::loaded):
1571 (WebCore::unloading):
1572 (WebCore::attach):
1573 (WebCore::detach):
1574 (WebCore::startDebuggingAndReloadInspectedPage):
1575 (WebCore::stopDebugging):
1576 (WebCore::debuggerAttached):
1577 (WebCore::pauseOnExceptions):
1578 (WebCore::pauseInDebugger):
1579 (WebCore::resumeDebugger):
1580 (WebCore::stepOverStatementInDebugger):
1581 (WebCore::stepIntoStatementInDebugger):
1582 (WebCore::stepOutOfFunctionInDebugger):
1583 (WebCore::isWindowVisible):
1584 (WebCore::closeWindow):
1585
hyatt@apple.com8e809932008-09-16 02:29:09 +000015862008-09-15 Dave Hyatt <hyatt@apple.com>
1587
1588 Completely switch Windows scrollbars over to ScrollbarTheme. The Aqua windows scrollbar and native scrollbar
1589 now share most of their code.
1590
1591 Also removing mini size scrollbar support, since it would have crashed Windows had it ever been used, and it
1592 also is never used in our code anyway.
1593
1594 Reviewed by Sam Weinig
1595
1596 * WebCore.vcproj/WebCore.vcproj:
1597 * platform/ScrollTypes.h:
1598 (WebCore::):
1599 * platform/ScrollbarThemeComposite.cpp:
1600 (WebCore::ScrollbarThemeComposite::splitTrack):
1601 (WebCore::ScrollbarThemeComposite::thumbLength):
1602 (WebCore::ScrollbarThemeComposite::minimumThumbLength):
1603 * platform/ScrollbarThemeComposite.h:
1604 * platform/mac/PlatformScrollBarMac.mm:
1605 (NSControlSizeForScrollBarControlSize):
1606 * platform/win/PlatformScrollBar.h:
1607 * platform/win/PlatformScrollBarSafari.cpp: Removed.
1608 * platform/win/PlatformScrollBarWin.cpp:
1609 (WebCore::PlatformScrollbar::PlatformScrollbar):
1610 * platform/win/ScrollbarThemeSafari.cpp:
1611 (WebCore::ScrollbarTheme::nativeTheme):
1612 (WebCore::):
1613 (WebCore::scrollbarControlStateFromThemeState):
1614 (WebCore::ScrollbarThemeSafari::hasButtons):
1615 (WebCore::ScrollbarThemeSafari::hasThumb):
1616 (WebCore::buttonRepaintRect):
1617 (WebCore::ScrollbarThemeSafari::backButtonRect):
1618 (WebCore::ScrollbarThemeSafari::forwardButtonRect):
1619 (WebCore::trackRepaintRect):
1620 (WebCore::ScrollbarThemeSafari::trackRect):
1621 (WebCore::ScrollbarThemeSafari::minimumThumbLength):
1622 (WebCore::ScrollbarThemeSafari::paintTrack):
1623 (WebCore::ScrollbarThemeSafari::paintButton):
1624 (WebCore::ScrollbarThemeSafari::paintThumb):
1625 * platform/win/ScrollbarThemeSafari.h:
1626 * platform/win/ScrollbarThemeWin.cpp:
1627 * platform/win/ScrollbarThemeWin.h:
1628
cfleizach@apple.com0ce07032008-09-16 00:17:58 +000016292008-09-15 Chris Fleizach <cfleizach@apple.com>
1630
1631 Reviewed by Darin Adler, Beth Dakin
1632
1633 <rdar://problem/4003789> Expose lists as AXList
1634 <rdar://problem/5707399> VO: Definition lists not announced in Safari
1635
1636 Lists are now exposed through AX. On the mac (in SnowLeopard) they use two new subroles
1637 AXContentList for <ul>, <ol> and AXDefinitionList for <dl>
1638 Inside the definition list, each <dt> "term" has an accessibility description ("term"),
1639 as does each <dd> tag ("definition")
1640
1641 Test: accessibility/lists.html
1642
1643 * GNUmakefile.am:
1644 * WebCore.pro:
1645 * WebCore.vcproj/WebCore.vcproj:
1646 * WebCore.xcodeproj/project.pbxproj:
1647 * WebCoreSources.bkl:
1648 * page/AXObjectCache.cpp:
1649 * page/AccessibilityList.cpp: Added.
1650 * page/AccessibilityList.h: Added.
1651 * page/AccessibilityObject.h:
1652 * page/AccessibilityRenderObject.cpp:
1653 * page/AccessibilityTable.cpp:
1654 * page/mac/AccessibilityObjectWrapper.mm:
1655 * page/mac/WebCoreViewFactory.h:
1656 * platform/LocalizedStrings.h:
1657 * platform/mac/LocalizedStringsMac.mm:
1658 * platform/qt/Localizations.cpp:
1659
zimmermann@webkit.org8cc8ad02008-09-16 00:01:11 +000016602008-09-15 Nikolas Zimmermann <zimmermann@kde.org>
1661
1662 Reviewed by Eric.
1663
1664 Fixes: https://bugs.webkit.org/show_bug.cgi?id=20865
1665 Prepare HTMLScriptElement & SVGScriptElement unification, and unification of event handling.
1666
1667 Several renames:
1668 dispatchHTMLEvent -> dispatchEventForType
1669 setHTMLEventListener -> setEventListenerForType
1670 getHTMLEventListener -> eventListenerForType
1671 removeHTMLEventListener -> removeEventListenerForType
1672 isHTMLEventListener -> isAttachedToEventTargetNode
1673 ...
1674
1675 Similar renames for the dispatch/get/set/*Window*Event functions.
1676 Kill JSSVGLazyEventListener and merge with JSLazyEventListener.
1677
1678 Most important change: Rename setHTMLEventListener to setEventListenerForTypeAndAttribute,
1679 as there exists a generic createEventListener() method now, taking care of JSLazyEventListener creation.
1680
1681 setHTMLEventListener() used createHTMLEventListener() before and was HTML specific.
1682 SVG is able to use the code as well now. This affects most files in html/.
1683
1684 No functional changes.
1685
1686 * GNUmakefile.am:
1687 * WebCore.pro:
1688 * WebCore.vcproj/WebCore.vcproj:
1689 * WebCore.xcodeproj/project.pbxproj:
1690 * bindings/js/JSDOMWindowBase.cpp:
1691 (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
1692 (WebCore::JSDOMWindowBase::setListener):
1693 (WebCore::JSDOMWindowBase::getListener):
1694 (WebCore::JSDOMWindowBase::findJSEventListener):
1695 (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
1696 (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
1697 (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
1698 (WebCore::JSDOMWindowBase::jsEventListenersAttachedToEventTargetNodes):
1699 (WebCore::JSDOMWindowBase::jsUnprotectedEventListenersAttachedToEventTargetNodes):
1700 * bindings/js/JSDOMWindowBase.h:
1701 * bindings/js/JSEventListener.cpp:
1702 (WebCore::JSAbstractEventListener::handleEvent):
1703 (WebCore::JSAbstractEventListener::isAttachedToEventTargetNode):
1704 (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
1705 (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
1706 (WebCore::JSEventListener::JSEventListener):
1707 (WebCore::JSEventListener::~JSEventListener):
1708 (WebCore::JSLazyEventListener::JSLazyEventListener):
1709 (WebCore::eventParameterName):
1710 (WebCore::JSLazyEventListener::parseCode):
1711 (WebCore::getNodeEventListener):
1712 * bindings/js/JSEventListener.h:
1713 (WebCore::JSAbstractEventListener::JSAbstractEventListener):
1714 (WebCore::JSUnprotectedEventListener::create):
1715 (WebCore::JSEventListener::create):
1716 (WebCore::JSLazyEventListener::):
1717 (WebCore::JSLazyEventListener::create):
1718 * bindings/js/JSEventTargetNode.cpp:
1719 (WebCore::JSEventTargetNode::setListener):
1720 (WebCore::JSEventTargetNode::getListener):
1721 * bindings/js/JSSVGLazyEventListener.cpp: Removed.
1722 * bindings/js/JSSVGLazyEventListener.h: Removed.
1723 * bindings/js/ScriptController.cpp:
1724 (WebCore::ScriptController::createHTMLEventHandler):
1725 (WebCore::ScriptController::createSVGEventHandler):
1726 * dom/Document.cpp:
1727 (WebCore::Document::setFocusedNode):
1728 (WebCore::Document::handleWindowEvent):
1729 (WebCore::Document::setWindowEventListenerForType):
1730 (WebCore::Document::windowEventListenerForType):
1731 (WebCore::Document::removeWindowEventListenerForType):
1732 (WebCore::Document::addWindowEventListener):
1733 (WebCore::Document::hasWindowEventListener):
1734 (WebCore::Document::removePendingFrameBeforeUnloadEventCount):
1735 (WebCore::Document::createEventListener):
1736 (WebCore::Document::setWindowEventListenerForTypeAndAttribute):
1737 * dom/Document.h:
1738 * dom/EventListener.h:
1739 (WebCore::EventListener::isAttachedToEventTargetNode):
1740 * dom/EventTargetNode.cpp:
1741 (WebCore::EventTargetNode::dispatchFocusEvent):
1742 (WebCore::EventTargetNode::dispatchBlurEvent):
1743 (WebCore::EventTargetNode::dispatchEventForType):
1744 (WebCore::EventTargetNode::removeEventListenerForType):
1745 (WebCore::EventTargetNode::setEventListenerForType):
1746 (WebCore::EventTargetNode::setEventListenerForTypeAndAttribute):
1747 (WebCore::EventTargetNode::eventListenerForType):
1748 * dom/EventTargetNode.h:
1749 * dom/XMLTokenizer.cpp:
1750 (WebCore::XMLTokenizer::notifyFinished):
1751 * editing/ReplaceSelectionCommand.cpp:
1752 (WebCore::ReplacementFragment::ReplacementFragment):
1753 * html/HTMLBodyElement.cpp:
1754 (WebCore::HTMLBodyElement::parseMappedAttribute):
1755 * html/HTMLButtonElement.cpp:
1756 (WebCore::HTMLButtonElement::parseMappedAttribute):
1757 * html/HTMLElement.cpp:
1758 (WebCore::HTMLElement::parseMappedAttribute):
1759 (WebCore::HTMLElement::checkDTD):
1760 * html/HTMLElement.h:
1761 * html/HTMLFormControlElement.cpp:
1762 (WebCore::HTMLFormControlElement::onChange):
1763 * html/HTMLFormElement.cpp:
1764 (WebCore::HTMLFormElement::prepareSubmit):
1765 (WebCore::HTMLFormElement::reset):
1766 (WebCore::HTMLFormElement::parseMappedAttribute):
1767 * html/HTMLFrameElementBase.cpp:
1768 (WebCore::HTMLFrameElementBase::parseMappedAttribute):
1769 * html/HTMLFrameSetElement.cpp:
1770 (WebCore::HTMLFrameSetElement::parseMappedAttribute):
1771 * html/HTMLImageElement.cpp:
1772 (WebCore::HTMLImageElement::parseMappedAttribute):
1773 * html/HTMLImageLoader.cpp:
1774 (WebCore::HTMLImageLoader::dispatchLoadEvent):
1775 * html/HTMLInputElement.cpp:
1776 (WebCore::HTMLInputElement::parseMappedAttribute):
1777 (WebCore::HTMLInputElement::setValueFromRenderer):
1778 (WebCore::HTMLInputElement::onSearch):
1779 * html/HTMLMediaElement.cpp:
1780 (WebCore::HTMLMediaElement::asyncEventTimerFired):
1781 (WebCore::HTMLMediaElement::load):
1782 (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
1783 (WebCore::HTMLMediaElement::setReadyState):
1784 (WebCore::HTMLMediaElement::seek):
1785 (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
1786 (WebCore::HTMLMediaElement::willSaveToCache):
1787 * html/HTMLObjectElement.cpp:
1788 (WebCore::HTMLObjectElement::parseMappedAttribute):
1789 * html/HTMLScriptElement.cpp:
1790 (WebCore::HTMLScriptElement::parseMappedAttribute):
1791 (WebCore::HTMLScriptElement::dispatchLoadEvent):
1792 (WebCore::HTMLScriptElement::dispatchErrorEvent):
1793 * html/HTMLSelectElement.cpp:
1794 (WebCore::HTMLSelectElement::parseMappedAttribute):
1795 * html/HTMLTextAreaElement.cpp:
1796 (WebCore::HTMLTextAreaElement::parseMappedAttribute):
1797 * html/HTMLTokenizer.cpp:
1798 (WebCore::HTMLTokenizer::notifyFinished):
1799 * page/AccessibilityRenderObject.cpp:
1800 (WebCore::AccessibilityRenderObject::mouseButtonListener):
1801 * page/EventHandler.cpp:
1802 (WebCore::EventHandler::canMouseDownStartSelect):
1803 (WebCore::EventHandler::canMouseDragExtendSelect):
1804 * page/Frame.cpp:
1805 (WebCore::Frame::sendScrollEvent):
1806 * page/Page.cpp:
1807 (WebCore::networkStateChanged):
1808 * rendering/RenderListBox.cpp:
1809 (WebCore::RenderListBox::valueChanged):
1810 * rendering/RenderTextControl.cpp:
1811 (WebCore::RenderTextControl::selectionChanged):
1812 * svg/SVGDocumentExtensions.cpp:
1813 * svg/SVGDocumentExtensions.h:
1814 * svg/SVGElement.cpp:
1815 (WebCore::SVGElement::parseMappedAttribute):
1816 (WebCore::SVGElement::finishParsingChildren):
1817 * svg/SVGElement.h:
1818 * svg/SVGSVGElement.cpp:
1819 (WebCore::SVGSVGElement::parseMappedAttribute):
1820 * svg/SVGSVGElement.h:
1821
hyatt@apple.com63739ce2008-09-15 23:44:10 +000018222008-09-15 Dave Hyatt <hyatt@apple.com>
1823
1824 Convert PlatformScrollbarWin to use ScrollbarTheme for hit testing. PlatformScrollbarQt/Gtk still
1825 need to be converted.
1826
1827 Reviewed by Sam Weinig
1828
1829 * platform/ScrollBar.cpp:
1830 (WebCore::Scrollbar::Scrollbar):
1831 (WebCore::Scrollbar::updateThumbPosition):
1832 (WebCore::Scrollbar::updateThumbProportion):
1833 (WebCore::Scrollbar::autoscrollPressedPart):
1834 (WebCore::Scrollbar::startTimerIfNeeded):
1835 * platform/ScrollBar.h:
1836 * platform/ScrollbarTheme.h:
1837 (WebCore::ScrollbarTheme::invalidateParts):
1838 * platform/ScrollbarThemeComposite.cpp:
1839 (WebCore::ScrollbarThemeComposite::hitTest):
1840 (WebCore::ScrollbarThemeComposite::invalidatePart):
1841 (WebCore::ScrollbarThemeComposite::thumbPosition):
1842 (WebCore::ScrollbarThemeComposite::thumbLength):
1843 (WebCore::ScrollbarThemeComposite::trackLength):
1844 * platform/ScrollbarThemeComposite.h:
1845 * platform/win/PlatformScrollBarSafari.cpp:
1846 (WebCore::PlatformScrollbar::PlatformScrollbar):
1847 * platform/win/PlatformScrollBarWin.cpp:
1848 (WebCore::PlatformScrollbar::PlatformScrollbar):
1849
dsmith@webkit.orgaa780ed2008-09-15 23:08:07 +000018502008-09-15 David Smith <catfish.man@gmail.com>
1851
1852 "Just do it"'d by Mark Rowe
1853
1854 https://bugs.webkit.org/show_bug.cgi?id=20856
1855 Add missing license header
1856
1857 * dom/NodeRenderStyle.h:
1858
dino@apple.combf52b682008-09-15 21:31:43 +000018592008-09-15 Dean Jackson <dino@apple.com>
1860
1861 Reviewed by Tim Hatcher.
1862
dino@apple.com3db0b8f2008-09-15 21:52:23 +00001863 Add default constructor for ShadowData
1864 https://bugs.webkit.org/show_bug.cgi?id=20757
1865
1866 Test: transitions/shadow.html
1867
1868 * rendering/style/RenderStyle.h:
1869
18702008-09-15 Dean Jackson <dino@apple.com>
1871
1872 Reviewed by Tim Hatcher.
1873
dino@apple.com03abdce2008-09-15 21:40:52 +00001874 RenderStyle should update keyframes.
1875 http://bugs.webkit.org/show_bug.cgi?id=20756
1876
1877 * rendering/style/RenderStyle.cpp:
1878 (WebCore::StyleRareNonInheritedData::updateKeyframes):
1879
18802008-09-15 Dean Jackson <dino@apple.com>
1881
1882 Reviewed by Tim Hatcher.
1883
dino@apple.combf52b682008-09-15 21:31:43 +00001884 Unnecessary ASSERT in ImplicitAnimation destructor.
1885 https://bugs.webkit.org/show_bug.cgi?id=20817
1886
1887 * page/animation/ImplicitAnimation.cpp:
1888 (WebCore::ImplicitAnimation::~ImplicitAnimation):
1889
treat@webkit.org7e5abc22008-09-15 20:53:49 +000018902008-09-15 Adam Treat <treat@kde.org>
1891
1892 Reviewed by Simon.
1893
1894 Fix plugin extension info. It was returning the mimetype where the
1895 extension was given.
1896
1897 * plugins/qt/PluginPackageQt.cpp:
1898 (WebCore::PluginPackage::fetchInfo):
1899
dino@apple.comecc18dc2008-09-15 20:40:28 +000019002008-09-15 Dean Jackson <dino@apple.com>
1901
1902 Reviewed by Tim Hatcher
1903
1904 Coding style violation!!!! Cleanup AnimationBase.cpp
1905
1906 * page/animation/AnimationBase.cpp:
1907 (WebCore::blendFunc):
1908
hyatt@apple.comf4a9d932008-09-15 20:03:25 +000019092008-09-15 David Hyatt <hyatt@apple.com>
1910
1911 Move all hit testing code for scrollbars into the base class. Refactor
1912 it to accommodate all platform-specific behaviors using virtual ScrollbarTheme
1913 functions.
1914
1915 No platform is using this code yet. Although it has been moved and compiles
1916 (even on Mac), it is not being used on any platform.
1917
1918 Reviewed by Sam Weinig
1919
1920 * platform/ScrollBar.cpp:
1921 (WebCore::Scrollbar::autoscrollPressedPart):
1922 (WebCore::Scrollbar::startTimerIfNeeded):
1923 (WebCore::Scrollbar::handleMouseMoveEvent):
1924 (WebCore::Scrollbar::handleMouseOutEvent):
1925 (WebCore::Scrollbar::handleMouseReleaseEvent):
1926 (WebCore::Scrollbar::handleMousePressEvent):
1927 * platform/ScrollBar.h:
1928 (WebCore::Scrollbar::handleContextMenuEvent):
1929 * platform/ScrollbarTheme.h:
1930 (WebCore::ScrollbarTheme::hitTest):
1931 (WebCore::ScrollbarTheme::invalidateOnMouseEnterExit):
1932 (WebCore::ScrollbarTheme::invalidatePart):
1933 (WebCore::ScrollbarTheme::shouldCenterOnThumb):
1934 (WebCore::ScrollbarTheme::centerOnThumb):
1935 (WebCore::ScrollbarTheme::thumbPosition):
1936 (WebCore::ScrollbarTheme::thumbLength):
1937 (WebCore::ScrollbarTheme::trackLength):
1938 (WebCore::ScrollbarTheme::initialAutoscrollTimerDelay):
1939 (WebCore::ScrollbarTheme::autoscrollTimerDelay):
1940 * platform/Widget.h:
1941 (WebCore::Widget::parent):
1942 * platform/mac/PlatformScrollBar.h:
1943 (WebCore::PlatformScrollbar::handleMouseMoveEvent):
1944 (WebCore::PlatformScrollbar::handleMouseOutEvent):
1945 (WebCore::PlatformScrollbar::handleMousePressEvent):
1946 (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
1947 * platform/mac/WidgetMac.mm:
1948 (WebCore::Widget::convertFromContainingWindow):
1949 * platform/win/ScrollbarThemeWin.cpp:
1950 (WebCore::ScrollbarThemeWin::invalidateOnMouseEnterExit):
1951 * platform/win/ScrollbarThemeWin.h:
1952
mitz@apple.comd17dc392008-09-15 18:48:20 +000019532008-09-15 Dan Bernstein <mitz@apple.com>
1954
1955 Reviewed by Sam Weinig.
1956
1957 - fix <rdar://problem/5842247> Single long breakable word takes O(n^2) to lay out
1958
1959 Cache the next breakable position for text nodes in InlineIterator.
1960
1961 * rendering/bidi.cpp:
1962 (WebCore::InlineIterator::InlineIterator):
1963 (WebCore::InlineIterator::increment):
1964 (WebCore::RenderBlock::findNextLineBreak):
1965
simon.fraser@apple.comda604642008-09-15 17:10:48 +000019662008-09-15 Simon Fraser <simon.fraser@apple.com>
1967
1968 Reviewed by Dan Bernstein
1969
1970 Fix assertion and integral pixel issue when creating subimages.
1971 https://bugs.webkit.org/show_bug.cgi?id=20786
1972
1973 * platform/graphics/cg/ImageCG.cpp:
1974 (WebCore::BitmapImage::draw):
1975
vestbo@webkit.orge7eda302008-09-15 12:43:37 +000019762008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
1977
1978 Reviewed by Simon.
1979
1980 Implment seek() and clean up and improve debugging output
1981
1982 * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
1983 (debugMediaObject):
1984 (WebCore::MediaPlayerPrivate::seek):
1985 (WebCore::MediaPlayerPrivate::setVolume):
1986 (WebCore::MediaPlayerPrivate::setMuted):
1987 (WebCore::MediaPlayerPrivate::updateStates):
1988 (WebCore::MediaPlayerPrivate::naturalSize):
1989 (WebCore::MediaPlayerPrivate::paint):
1990 (WebCore::MediaPlayerPrivate::stateChanged):
1991 (WebCore::MediaPlayerPrivate::tick):
1992
vestbo@webkit.orgaba01e62008-09-15 11:40:22 +000019932008-09-15 Holger Hans Peter Freyther <zecke@selfish.org>
1994
1995 Reviewed by Simon.
1996
1997 Remove bogus Q_ASSERTs from the MediaPlayer Phonon implementation
1998
1999 m_mediaObject, m_audioOutput, m_videoWidget get created in the
2000 c'tor and will only be deleted in the c'tor. The Q_ASSERTs would
2001 only check if we use the MediaPlayerPrivate after it has been deleted.
2002
2003 Acked-by: Tor Arne Vestbø <tavestbo@trolltech.com>
2004
2005 * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
2006 (WebCore::MediaPlayerPrivate::play):
2007 (WebCore::MediaPlayerPrivate::setVolume):
2008 (WebCore::MediaPlayerPrivate::updateStates):
2009
andersca@apple.com18d62682008-09-15 11:35:22 +000020102008-09-15 Anders Carlsson <andersca@apple.com>
2011
2012 Reviewed by Maciej.
2013
2014 <rdar://problem/6163988>
2015 https://bugs.webkit.org/show_bug.cgi?id=20457
2016 Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
2017
2018 Check the width and height and throw an exception if any of them are 0.
2019
2020 * html/CanvasRenderingContext2D.cpp:
2021 (WebCore::CanvasRenderingContext2D::createPattern):
2022
vestbo@webkit.org3a27e182008-09-15 11:28:59 +000020232008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
2024
2025 Reviewed by Simon.
2026
2027 Render media element controls with antialiasing enabled
2028
2029 * platform/qt/RenderThemeQt.cpp:
2030 (WebCore::RenderThemeQt::paintMediaMuteButton):
2031 (WebCore::RenderThemeQt::paintMediaPlayButton):
2032 (WebCore::RenderThemeQt::paintMediaSliderTrack):
2033 (WebCore::RenderThemeQt::paintMediaSliderThumb):
2034
vestbo@webkit.org17e4bfc2008-09-15 11:27:25 +000020352008-09-15 Ariya Hidayat <ariya.hidayat@trolltech.com>
2036
2037 Reviewed by Simon.
2038
2039 Upon non fatal error, switch to the pause state (so that playback can continue)
2040
2041 * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
2042 (WebCore::MediaPlayerPrivate::updateStates):
2043
vestbo@webkit.org12a59572008-09-15 11:16:13 +000020442008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
2045
2046 Reviewed by Simon.
2047
vestbo@webkit.org1d1f05e2008-09-15 11:22:05 +00002048 Don't set WTF_USE_JSC in WebCore.pro now that it's set in config.h
2049
2050 * WebCore.pro:
2051
20522008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
2053
2054 Reviewed by Simon.
2055
vestbo@webkit.org12a59572008-09-15 11:16:13 +00002056 Make QtInstance::create() private and fix caching
2057
2058 * bindings/js/ScriptControllerQt.cpp:
2059 (WebCore::ScriptController::createScriptInstanceForWidget):
2060 * bridge/qt/qt_instance.cpp:
2061 (JSC::Bindings::QtInstance::getQtInstance):
2062 (JSC::Bindings::QtInstance::getRuntimeObject):
2063 * bridge/qt/qt_instance.h:
2064 (JSC::Bindings::QtInstance::create):
2065 * bridge/qt/qt_runtime.cpp:
2066 (JSC::Bindings::convertQVariantToValue):
2067 (JSC::Bindings::QtConnectionObject::execute):
2068
dsmith@webkit.orgaba15862008-09-15 08:45:35 +000020692008-09-15 David Smith <catfish.man@gmail.com>
2070
2071 Reviewed by Dave Hyatt.
2072
2073 https://bugs.webkit.org/show_bug.cgi?id=20180
2074
2075 >2x speedup on querySelector[All] with :nth-child by removing the collectRulesOnly argument on SelectorChecker.
2076 With collectRulesOnly set to true (the default) an optimization is turned off, and no callers were intentionally leaving it true.
2077 querySelector[All] assumed that the default was probably the right way to go, and so ended up being slow.
2078
2079 * css/CSSStyleSelector.cpp:
2080 (WebCore::CSSStyleSelector::CSSStyleSelector):
2081 (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
2082 * css/CSSStyleSelector.h:
2083
hyatt@apple.com065494e2008-09-15 06:33:40 +000020842008-09-14 Dave Hyatt <hyatt@apple.com>
2085
2086 Refactor PlatformScrollbarWin's painting so that it is now done by ScrollbarThemeWin. PlatformScrollbarSafari
2087 is still painting itself (a subsequent patch will move its painting into ScrollbarThemeSafari).
2088
2089 Reviewed by Sam Weinig
2090
2091 * platform/ScrollBar.h:
2092 (WebCore::Scrollbar::client):
2093 (WebCore::Scrollbar::currentPos):
2094 (WebCore::Scrollbar::totalSize):
2095 * platform/ScrollbarTheme.h:
2096 * platform/ScrollbarThemeComposite.cpp:
2097 (WebCore::pageForScrollView):
2098 (WebCore::ScrollbarThemeComposite::paint):
2099 * platform/ScrollbarThemeComposite.h:
2100 (WebCore::ScrollbarThemeComposite::trackIsSinglePiece):
2101 * platform/win/PlatformScrollBar.h:
2102 * platform/win/PlatformScrollBarSafari.cpp:
2103 * platform/win/PlatformScrollBarWin.cpp:
2104 * platform/win/ScrollbarThemeSafari.h:
2105 (WebCore::ScrollbarThemeSafari::hasButtons):
2106 (WebCore::ScrollbarThemeSafari::hasThumb):
2107 (WebCore::ScrollbarThemeSafari::backButtonRect):
2108 (WebCore::ScrollbarThemeSafari::forwardButtonRect):
2109 (WebCore::ScrollbarThemeSafari::trackRect):
2110 (WebCore::ScrollbarThemeSafari::splitTrack):
2111 (WebCore::ScrollbarThemeSafari::paintTrack):
2112 (WebCore::ScrollbarThemeSafari::paintButton):
2113 (WebCore::ScrollbarThemeSafari::paintThumb):
2114 * platform/win/ScrollbarThemeWin.cpp:
2115 (WebCore::isRunningOnVistaOrLater):
2116 (WebCore::checkAndInitScrollbarTheme):
2117 (WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
2118 (WebCore::ScrollbarThemeWin::themeChanged):
2119 (WebCore::ScrollbarThemeWin::hasThumb):
2120 (WebCore::ScrollbarThemeWin::backButtonRect):
2121 (WebCore::ScrollbarThemeWin::forwardButtonRect):
2122 (WebCore::ScrollbarThemeWin::trackRect):
2123 (WebCore::ScrollbarThemeWin::splitTrack):
2124 (WebCore::ScrollbarThemeWin::paintTrack):
2125 (WebCore::ScrollbarThemeWin::paintButton):
2126 (WebCore::gripperRect):
2127 (WebCore::paintGripper):
2128 (WebCore::ScrollbarThemeWin::paintThumb):
2129 (WebCore::ScrollbarThemeWin::thumbPosition):
2130 (WebCore::ScrollbarThemeWin::thumbLength):
2131 (WebCore::ScrollbarThemeWin::trackLength):
2132 * platform/win/ScrollbarThemeWin.h:
2133 (WebCore::ScrollbarThemeWin::hasButtons):
2134 (WebCore::ScrollbarThemeWin::trackIsSinglePiece):
2135
timothy@apple.comd91172c2008-09-15 05:38:00 +000021362008-09-14 Anthony Ricaud <rik24d@gmail.com>
2137
2138 Moving all resource graphs under the same container for future scalable feature.
2139 This is a speedup on resize but maybe a loss on changing the sorting function.
2140
2141 https://bugs.webkit.org/show_bug.cgi?id=20555
2142
2143 Reviewed by Timothy Hatcher.
2144
2145 * page/inspector/ResourcesPanel.js: Added a container for all resource graphs.
2146 Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
2147 * page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.
2148
ap@webkit.orga14074b2008-09-15 04:52:44 +000021492008-09-14 Alexey Proskuryakov <ap@webkit.org>
2150
2151 Reviewed by Maciej Stachowiak.
2152
2153 https://bugs.webkit.org/show_bug.cgi?id=20738
2154 compareBoundaryPoints gives incorrect results
2155
2156 Test: fast/dom/Range/compareBoundaryPoints-2.html
2157
2158 * dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END
2159 and END_TO_START.
2160 * page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.
2161
mjs@apple.com285bdcf2008-09-15 02:55:16 +000021622008-09-14 Maciej Stachowiak <mjs@apple.com>
2163
2164 Unreviewed build fix.
2165
mjs@apple.comcbb31e52008-09-15 03:10:35 +00002166 Trying again.
2167
2168 * bindings/js/JSQuarantinedObjectWrapper.cpp:
2169 (WebCore::JSQuarantinedObjectWrapper::hasInstance):
2170
21712008-09-14 Maciej Stachowiak <mjs@apple.com>
2172
2173 Unreviewed build fix.
2174
mjs@apple.com285bdcf2008-09-15 02:55:16 +00002175 Blind attempt to fix build. Correct parameters for hasInstance.
2176
2177 * bindings/js/JSQuarantinedObjectWrapper.cpp:
2178 (WebCore::JSQuarantinedObjectWrapper::hasInstance):
2179 * bindings/js/JSQuarantinedObjectWrapper.h:
2180
mitz@apple.come85f7362008-09-15 02:23:24 +000021812008-09-14 Dan Bernstein <mitz@apple.com>
2182
2183 Rubber-stamped by Sam Weinig.
2184
2185 - revert <http://trac.webkit.org/changeset/36382> because it exposed
2186 <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes
2187 on Tiger.
2188
2189 * platform/graphics/mac/FontCacheMac.mm:
2190 (WebCore::FontCache::getFontDataForCharacters):
2191 (WebCore::FontCache::getLastResortFallbackFont):
2192
hyatt@apple.comf18feec2008-09-15 00:56:11 +000021932008-09-14 Dave Hyatt <hyatt@apple.com>
2194
2195 Add a new ScrollbarThemeComposite base class that is shared by ScrollbarThemeSafari and
2196 ScrollbarThemeWin. Any scrollbar that wants to render by ScrollbarPart can subclass from this
2197 theme.
2198
2199 Reviewed by Sam Weinig
2200
2201 * WebCore.vcproj/WebCore.vcproj:
2202 * platform/win/ScrollbarThemeSafari.h:
2203 * platform/win/ScrollbarThemeWin.h:
2204
alp@webkit.orgd694e942008-09-15 00:20:15 +000022052008-09-14 Alp Toker <alp@nuanti.com>
2206
2207 https://bugs.webkit.org/show_bug.cgi?id=20320
2208 [GTK] A white rectangle is visible behind widgets with rounded corners
2209
2210 Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
2211 style exempt).
2212
2213 Requested by Michael Monreal.
2214
2215 * platform/gtk/RenderThemeGtk.cpp:
2216 (WebCore::RenderThemeGtk::RenderThemeGtk):
2217 * platform/gtk/gtk2drawing.c:
2218 (moz_gtk_set_widget_name):
2219 (ensure_window_widget):
2220 (setup_widget_prototype):
2221 (ensure_button_arrow_widget):
2222 (moz_gtk_get_combo_box_inner_button):
2223 (moz_gtk_get_combo_box_button_inner_widgets):
2224 (ensure_combo_box_widgets):
2225 (moz_gtk_get_combo_box_entry_inner_widgets):
2226 (moz_gtk_get_combo_box_entry_arrow):
2227 (ensure_combo_box_entry_widgets):
2228 (ensure_toolbar_widget):
2229 (ensure_tooltip_widget):
2230 (ensure_menu_bar_widget):
2231 (ensure_menu_bar_item_widget):
2232 (ensure_menu_popup_widget):
2233 (ensure_menu_item_widget):
2234 (ensure_image_menu_item_widget):
2235 (ensure_menu_separator_widget):
2236 (ensure_check_menu_item_widget):
2237 (ensure_tree_header_cell_widget):
2238 (ensure_scrolled_window_widget):
2239 (moz_gtk_button_paint):
2240 (moz_gtk_init):
2241 (moz_gtk_button_get_inner_border):
2242 (moz_gtk_toggle_paint):
2243 (calculate_button_inner_rect):
2244 (calculate_arrow_rect):
2245 (moz_gtk_scrollbar_button_paint):
2246 (moz_gtk_scrollbar_thumb_paint):
2247 (moz_gtk_caret_paint):
2248 (moz_gtk_entry_paint):
2249 (moz_gtk_treeview_paint):
2250 (moz_gtk_tree_header_cell_paint):
2251 (moz_gtk_combo_box_paint):
2252 (moz_gtk_downarrow_paint):
2253 (moz_gtk_combo_box_entry_button_paint):
2254 (moz_gtk_toolbar_paint):
2255 (moz_gtk_tab_scroll_arrow_paint):
2256 (moz_gtk_menu_bar_paint):
2257 (moz_gtk_menu_item_paint):
2258 (moz_gtk_get_widget_border):
2259 (moz_gtk_get_combo_box_entry_button_size):
2260 (moz_gtk_get_tab_scroll_arrow_size):
2261 (moz_gtk_get_downarrow_size):
2262 (moz_gtk_images_in_menus):
2263 (moz_gtk_widget_paint):
2264 (moz_gtk_shutdown):
2265 * platform/gtk/gtkdrawing.h:
2266
hyatt@apple.com3ab48302008-09-14 23:55:16 +000022672008-09-14 David Hyatt <hyatt@apple.com>
2268
2269 Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
2270 painting. Mac and Gtk themes don't do anything and just let the
2271 underlying widget paint. Qt now uses the theme to paint. wx doesn't
2272 do anything yet.
2273
2274 Reviewed by Sam Weinig
2275
2276 * platform/ScrollBar.cpp:
2277 (WebCore::Scrollbar::paint):
2278 * platform/ScrollBar.h:
2279 (WebCore::Scrollbar::value):
2280 (WebCore::Scrollbar::visibleSize):
2281 (WebCore::Scrollbar::maximum):
2282 (WebCore::Scrollbar::lineStep):
2283 (WebCore::Scrollbar::pageStep):
2284 (WebCore::Scrollbar::pixelStep):
2285 (WebCore::Scrollbar::pressedPart):
2286 (WebCore::Scrollbar::hoveredPart):
2287 (WebCore::Scrollbar::theme):
2288 * platform/ScrollbarTheme.h:
2289 (WebCore::ScrollbarTheme::paint):
2290 (WebCore::ScrollbarTheme::scrollbarThickness):
2291 (WebCore::ScrollbarTheme::supportsControlTints):
2292 (WebCore::ScrollbarTheme::themeChanged):
2293 * platform/gtk/PlatformScrollBar.h:
2294 * platform/gtk/PlatformScrollBarGtk.cpp:
2295 * platform/mac/PlatformScrollBar.h:
2296 * platform/mac/PlatformScrollBarMac.mm:
2297 * platform/qt/PlatformScrollBar.h:
2298 * platform/qt/PlatformScrollBarQt.cpp:
2299 * platform/qt/ScrollbarThemeQt.cpp:
2300 (WebCore::styleOptionSlider):
2301 * platform/qt/ScrollbarThemeQt.h:
2302 (WebCore::ScrollbarThemeQt::paint):
2303 * platform/win/PlatformScrollBarSafari.cpp:
2304 (WebCore::PlatformScrollbar::paint):
2305 * platform/win/ScrollbarThemeSafari.h:
2306 (WebCore::ScrollbarThemeSafari::supportsControlTints):
2307 * platform/wx/PlatformScrollBar.h:
2308 * platform/wx/TemporaryLinkStubs.cpp:
2309 (PlatformScrollbar::~PlatformScrollbar):
2310
weinig@apple.comcb93e262008-09-14 21:36:11 +000023112008-09-14 Sam Weinig <sam@webkit.org>
2312
weinig@apple.com6ef2b872008-09-14 22:15:28 +00002313 Qt build fix.
2314
2315 * platform/qt/PlatformScrollBarQt.cpp:
2316
23172008-09-14 Sam Weinig <sam@webkit.org>
2318
weinig@apple.com064861a2008-09-14 22:12:49 +00002319 Reviewed by Mark Rowe.
2320
2321 Remove extraneous semicolons.
2322
2323 * bindings/scripts/CodeGeneratorObjC.pm:
2324 * html/HTMLLinkElement.cpp:
2325 (WebCore::HTMLLinkElement::tokenizeRelAttribute):
2326 * html/HTMLScriptElement.cpp:
2327 (WebCore::HTMLScriptElement::charsetAttributeValue):
2328 (WebCore::HTMLScriptElement::typeAttributeValue):
2329 * platform/graphics/qt/GradientQt.cpp:
2330 (WebCore::Gradient::platformGradient):
2331 * platform/qt/ScrollViewQt.cpp:
2332 (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
2333 * platform/win/ScrollViewWin.cpp:
2334 (WebCore::ScrollView::updateScrollbars):
2335 * rendering/RenderBlock.cpp:
2336 (WebCore::RenderBlock::paintEllipsisBoxes):
2337 * svg/SVGPathSegList.cpp:
2338 (WebCore::SVGPathSegList::toPathData):
2339
23402008-09-14 Sam Weinig <sam@webkit.org>
2341
weinig@apple.comcb93e262008-09-14 21:36:11 +00002342 Qt build fix.
2343
weinig@apple.com31311a62008-09-14 22:00:15 +00002344 * platform/qt/ScrollViewQt.cpp:
2345 (WebCore::ScrollView::updateScrollbars):
2346
23472008-09-14 Sam Weinig <sam@webkit.org>
2348
2349 Qt build fix.
2350
weinig@apple.comcb93e262008-09-14 21:36:11 +00002351 * platform/qt/PlatformScrollBarQt.cpp:
2352 (WebCore::PlatformScrollbar::PlatformScrollbar):
2353 (WebCore::PlatformScrollbar::paint):
2354
jmalonzo@webkit.org65e836c2008-09-14 01:57:13 +000023552008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>
2356
2357 Gtk build fix, not reviewed.
2358
2359 * platform/gtk/PlatformScrollBarGtk.cpp:
2360 (PlatformScrollbar::PlatformScrollbar):
2361 * platform/gtk/ScrollViewGtk.cpp:
2362 (WebCore::ScrollView::updateScrollbars):
2363
hyatt@apple.comd62f5bf2008-09-14 00:32:19 +000023642008-09-13 Dave Hyatt <hyatt@apple.com>
2365
hyatt@apple.com21ab7c62008-09-14 01:26:22 +00002366 Remove scrollbar's setRect method. Clients can now just call setFrameGeometry (the corresponding Widget) method
2367 to set the dimensions of a scrollbar.
2368
2369 Reviewed by Sam Weinig
2370
2371 * platform/ScrollBar.h:
2372 * platform/gtk/PlatformScrollBar.h:
2373 * platform/gtk/PlatformScrollBarGtk.cpp:
2374 (PlatformScrollbar::setFrameGeometry):
2375 * platform/gtk/ScrollViewGtk.cpp:
2376 (WebCore::ScrollView::updateScrollbars):
2377 * platform/mac/PlatformScrollBarMac.mm:
2378 * platform/qt/PlatformScrollBarQt.cpp:
2379 * platform/qt/ScrollViewQt.cpp:
2380 (WebCore::ScrollView::updateScrollbars):
2381 * platform/win/PlatformScrollBar.h:
2382 * platform/win/PlatformScrollBarSafari.cpp:
2383 (WebCore::PlatformScrollbar::PlatformScrollbar):
2384 (WebCore::PlatformScrollbar::setFrameGeometry):
2385 * platform/win/PlatformScrollBarWin.cpp:
2386 (WebCore::PlatformScrollbar::PlatformScrollbar):
2387 (WebCore::PlatformScrollbar::setFrameGeometry):
2388 * platform/win/PopupMenuWin.cpp:
2389 (WebCore::PopupWndProc):
2390 * platform/win/ScrollViewWin.cpp:
2391 (WebCore::ScrollView::updateScrollbars):
2392 * platform/wx/PlatformScrollBar.h:
2393 * platform/wx/TemporaryLinkStubs.cpp:
2394 (PlatformScrollbar::updateThumbProportion):
2395 * rendering/RenderLayer.cpp:
2396 (WebCore::RenderLayer::positionOverflowControls):
2397 * rendering/RenderListBox.cpp:
2398 (WebCore::RenderListBox::paintScrollbar):
2399
24002008-09-13 Dave Hyatt <hyatt@apple.com>
2401
hyatt@apple.comed9485a2008-09-14 01:06:57 +00002402 Remove setEnabled() from all Scrollbar classes that were just using their Widget base class methods.
2403
2404 Reviewed by Sam Weinig
2405
2406 * platform/ScrollBar.h:
2407 * platform/gtk/PlatformScrollBar.h:
2408 * platform/gtk/PlatformScrollBarGtk.cpp:
2409 * platform/mac/PlatformScrollBar.h:
2410 * platform/mac/PlatformScrollBarMac.mm:
2411 * platform/win/PlatformScrollBar.h:
2412 * platform/win/PlatformScrollBarSafari.cpp:
2413 * platform/win/PlatformScrollBarWin.cpp:
2414 * platform/wx/PlatformScrollBar.h:
2415 * platform/wx/TemporaryLinkStubs.cpp:
2416 (PlatformScrollbar::~PlatformScrollbar):
2417
24182008-09-13 Dave Hyatt <hyatt@apple.com>
2419
hyatt@apple.com64d98032008-09-14 00:58:29 +00002420 Remove width()/height() from Scrollbar now that it derives from Widget. Remove width()/height() from
2421 all PlatformScrollbar subclasses that just called the Widget base class versions of those methods.
2422
2423 Reviewed by Sam Weinig
2424
2425 * platform/ScrollBar.h:
2426 * platform/gtk/PlatformScrollBar.h:
2427 * platform/gtk/PlatformScrollBarGtk.cpp:
2428 * platform/mac/PlatformScrollBar.h:
2429 * platform/mac/PlatformScrollBarMac.mm:
2430 * platform/win/PlatformScrollBarSafari.cpp:
2431 * platform/win/PlatformScrollBarWin.cpp:
2432 * platform/wx/PlatformScrollBar.h:
2433 * platform/wx/TemporaryLinkStubs.cpp:
2434 (PlatformScrollbar::~PlatformScrollbar):
2435
24362008-09-13 Dave Hyatt <hyatt@apple.com>
2437
hyatt@apple.comd62f5bf2008-09-14 00:32:19 +00002438 Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar.
2439
2440 Reviewed by Sam Weinig
2441
2442 * platform/ScrollBar.cpp:
2443 (WebCore::Scrollbar::~Scrollbar):
2444 * platform/ScrollBar.h:
2445 * platform/qt/PlatformScrollBarQt.cpp:
2446 (WebCore::PlatformScrollbar::~PlatformScrollbar):
2447 * platform/win/PlatformScrollBarSafari.cpp:
2448 (WebCore::PlatformScrollbar::~PlatformScrollbar):
2449 * platform/win/PlatformScrollBarWin.cpp:
2450 (WebCore::PlatformScrollbar::~PlatformScrollbar):
2451
hyatt@apple.coma3c52492008-09-13 23:57:08 +000024522008-09-13 David Hyatt <hyatt@apple.com>
2453
2454 Move maximum() from Qt's PlatformScrollbar to be a cross-platform
2455 function on Scrollbar. Fixes Qt build bustage.
2456
2457 Reviewed by Sam Weinig
2458
2459 * platform/ScrollBar.h:
2460 (WebCore::Scrollbar::orientation):
2461 (WebCore::Scrollbar::value):
2462 (WebCore::Scrollbar::maximum):
2463 * platform/qt/PlatformScrollBar.h:
2464
mitz@apple.comb3d22882008-09-13 23:06:59 +000024652008-09-13 Dan Bernstein <mitz@apple.com>
2466
2467 Reviewed by Sam Weinig.
2468
2469 - use the LastResort font for missing glyphs instead of showing the
2470 primary font's missing glyph
2471
2472 Test: platform/mac/fast/text/last-resort-font.html
2473
2474 * platform/graphics/mac/FontCacheMac.mm:
2475 (WebCore::FontCache::getFontDataForCharacters): Changed to return the
2476 last resort font if a substitute font cannot be found.
2477 (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated
2478 comment (the user's preferred standard font is included in the search
2479 thanks to code in FontCache::getFontData()) and changed to return the
2480 LastResort font.
2481
hyatt@apple.com0c378c72008-09-13 22:59:05 +000024822008-09-13 Dave Hyatt <hyatt@apple.com>
2483
2484 This patch adds ScrollbarTheme to the build. ScrollbarTheme is similar to RenderTheme (but for
2485 scrollbars only). For now ScrollbarTheme just handles returning the size of scrollbars. Subsequent
2486 patches will move rendering and hit testing functionality into this class.
2487
2488 Implemented ScrollbarTheme subclasses for four ports (Mac, Win, Gtk, Qt). The wxWidgets port does not
2489 implement scrollbars yet, so I added a temporary link stub to keep things compiling on wx.
2490
2491 Reviewed by Sam Weinig
2492
2493 * GNUmakefile.am:
2494 * WebCore.pro:
2495 * WebCore.vcproj/WebCore.vcproj:
2496 * platform/ScrollBar.cpp:
2497 (WebCore::Scrollbar::Scrollbar):
2498 * platform/ScrollBar.h:
2499 * platform/ScrollbarTheme.h: Added.
2500 (WebCore::ScrollbarTheme::~ScrollbarTheme):
2501 (WebCore::ScrollbarTheme::scrollbarThickness):
2502 (WebCore::ScrollbarTheme::themeChanged):
2503 * platform/gtk/ScrollbarThemeGtk.cpp: Added.
2504 (WebCore::ScrollbarTheme::nativeTheme):
2505 (WebCore::ScrollbarThemeGtk::~ScrollbarThemeGtk):
2506 (WebCore::ScrollbarThemeGtk::scrollbarThickness):
2507 * platform/gtk/ScrollbarThemeGtk.h: Added.
2508 * platform/mac/PlatformScrollBar.h:
2509 * platform/mac/ScrollbarThemeMac.cpp: Added.
2510 (WebCore::ScrollbarTheme::nativeTheme):
2511 (WebCore::):
2512 (WebCore::ScrollbarThemeMac::~ScrollbarThemeMac):
2513 (WebCore::ScrollbarThemeMac::scrollbarThickness):
2514 * platform/mac/ScrollbarThemeMac.h: Added.
2515 * platform/qt/PlatformScrollBarQt.cpp:
2516 * platform/qt/ScrollbarThemeQt.cpp: Added.
2517 (WebCore::ScrollbarTheme::nativeTheme):
2518 (WebCore::ScrollbarThemeQt::~ScrollbarThemeQt):
2519 (WebCore::ScrollbarThemeQt::scrollbarThickness):
2520 * platform/qt/ScrollbarThemeQt.h: Added.
2521 * platform/win/PlatformScrollBar.h:
2522 * platform/win/PlatformScrollBarSafari.cpp:
2523 * platform/win/PlatformScrollBarWin.cpp:
2524 * platform/win/PopupMenuWin.cpp:
2525 (WebCore::PopupMenu::calculatePositionAndSize):
2526 * platform/win/ScrollViewWin.cpp:
2527 (WebCore::ScrollView::updateScrollbars):
2528 (WebCore::ScrollView::themeChanged):
2529 * platform/win/ScrollbarThemeSafari.cpp: Added.
2530 (WebCore::ScrollbarTheme::nativeTheme):
2531 (WebCore::):
2532 (WebCore::ScrollbarThemeSafari::~ScrollbarThemeSafari):
2533 (WebCore::ScrollbarThemeSafari::scrollbarThickness):
2534 * platform/win/ScrollbarThemeSafari.h: Added.
2535 * platform/win/ScrollbarThemeWin.cpp: Added.
2536 (WebCore::ScrollbarTheme::nativeTheme):
2537 (WebCore::ScrollbarThemeWin::~ScrollbarThemeWin):
2538 (WebCore::ScrollbarThemeWin::scrollbarThickness):
2539 (WebCore::ScrollbarThemeWin::themeChanged):
2540 * platform/win/ScrollbarThemeWin.h: Added.
2541 * platform/wx/TemporaryLinkStubs.cpp:
2542 (ScrollbarTheme::nativeTheme):
2543 * rendering/RenderLayer.cpp:
2544 (WebCore::scrollCornerRect):
2545 * rendering/RenderTextControl.cpp:
2546 (WebCore::RenderTextControl::calcHeight):
2547 (WebCore::RenderTextControl::calcPrefWidths):
2548
cfleizach@apple.comd26c2762008-09-13 21:05:18 +000025492008-09-13 Chris Fleizach <cfleizach@apple.com>
2550
2551 Reviewed by Timothy Hatcher.
2552
2553 <rdar://problem/5060439> Web elements should have an AXTopLevelUIElement
2554
2555 * page/mac/AccessibilityObjectWrapper.mm:
2556 (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
2557
mitz@apple.com6307c9f2008-09-13 20:27:37 +000025582008-09-13 Dan Bernstein <mitz@apple.com>
2559
2560 Reviewed by Timothy Hatcher.
2561
2562 - fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache
2563
2564 No regression test because the back/forward cache is disabled in DumpRenderTree
2565
2566 * rendering/RenderContainer.cpp:
2567 (WebCore::RenderContainer::invalidateCounters): Bail out if the document
2568 is being destroyed.
2569
kevino@webkit.org1e178ee2008-09-13 18:48:39 +000025702008-09-13 Kevin Ollivier <kevino@theolliviers.com>
2571
2572 wx build fixes for new methods recently introduced.
2573
2574 * platform/graphics/wx/AffineTransformWx.cpp:
2575 (WebCore::AffineTransform::AffineTransform):
2576 (WebCore::AffineTransform::setMatrix):
2577 (WebCore::AffineTransform::setA):
2578 (WebCore::AffineTransform::setB):
2579 (WebCore::AffineTransform::setC):
2580 (WebCore::AffineTransform::setD):
2581 (WebCore::AffineTransform::setE):
2582 (WebCore::AffineTransform::setF):
2583 * platform/wx/LocalizedStringsWx.cpp:
2584 (WebCore::AXDefinitionListTermText):
2585 (WebCore::AXDefinitionListDefinitionText):
2586
hyatt@apple.com30ed5442008-09-13 18:39:58 +000025872008-09-12 Dave Hyatt <hyatt@apple.com>
2588
2589 Move the member variables of PlatformScrollbar up into Scrollbar. Move autoscroll timer handling
2590 up into scrollbar. Make sure a bunch of cross-platform code now just uses "Scrollbar" instead of
2591 "PlatformScrollbar."
2592
2593 Reviewed by Sam Weinig
2594
2595 * WebCore.vcproj/WebCore.vcproj:
2596 * editing/EditorCommand.cpp:
2597 * page/EventHandler.cpp:
2598 (WebCore::EventHandler::selectCursor):
2599 (WebCore::EventHandler::handleMousePressEvent):
2600 (WebCore::EventHandler::handleMouseMoveEvent):
2601 * page/EventHandler.h:
2602 * page/MouseEventWithHitTestResults.cpp:
2603 (WebCore::MouseEventWithHitTestResults::scrollbar):
2604 * page/MouseEventWithHitTestResults.h:
2605 * page/gtk/EventHandlerGtk.cpp:
2606 (WebCore::EventHandler::passMousePressEventToScrollbar):
2607 * page/mac/EventHandlerMac.mm:
2608 (WebCore::EventHandler::passMousePressEventToScrollbar):
2609 * page/qt/EventHandlerQt.cpp:
2610 (WebCore::EventHandler::passMousePressEventToScrollbar):
2611 * page/win/EventHandlerWin.cpp:
2612 (WebCore::EventHandler::passMousePressEventToScrollbar):
2613 * page/wx/EventHandlerWx.cpp:
2614 (WebCore::EventHandler::passMousePressEventToScrollbar):
2615 * platform/PopupMenu.h:
2616 * platform/ScrollBar.cpp:
2617 (WebCore::Scrollbar::Scrollbar):
2618 (WebCore::Scrollbar::autoscrollTimerFired):
2619 (WebCore::Scrollbar::autoscrollPressedPart):
2620 (WebCore::Scrollbar::startTimerIfNeeded):
2621 (WebCore::Scrollbar::stopTimerIfNeeded):
2622 (WebCore::Scrollbar::pressedPartScrollDirection):
2623 (WebCore::Scrollbar::pressedPartScrollGranularity):
2624 * platform/ScrollBar.h:
2625 (WebCore::Scrollbar::handleMousePressEvent):
2626 (WebCore::Scrollbar::invalidatePart):
2627 (WebCore::Scrollbar::thumbUnderMouse):
2628 * platform/ScrollView.h:
2629 * platform/ScrollbarClient.h: Added.
2630 (WebCore::ScrollbarClient::~ScrollbarClient):
2631 * platform/gtk/ScrollViewGtk.cpp:
2632 (WebCore::ScrollView::scrollbarUnderMouse):
2633 * platform/qt/PlatformScrollBar.h:
2634 * platform/qt/PlatformScrollBarQt.cpp:
2635 (WebCore::PlatformScrollbar::PlatformScrollbar):
2636 (WebCore::scrollbarPart):
2637 (WebCore::PlatformScrollbar::handleMouseMoveEvent):
2638 (WebCore::PlatformScrollbar::handleMouseOutEvent):
2639 (WebCore::PlatformScrollbar::handleMousePressEvent):
2640 (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
2641 * platform/qt/ScrollViewQt.cpp:
2642 (WebCore::ScrollView::scrollbarUnderMouse):
2643 (WebCore::ScrollView::wheelEvent):
2644 * platform/win/PlatformScrollBar.h:
2645 * platform/win/PlatformScrollBarSafari.cpp:
2646 (WebCore::PlatformScrollbar::PlatformScrollbar):
2647 * platform/win/PlatformScrollBarWin.cpp:
2648 (WebCore::PlatformScrollbar::PlatformScrollbar):
2649 * platform/win/ScrollViewWin.cpp:
2650 (WebCore::ScrollView::scrollbarUnderMouse):
2651 * rendering/HitTestResult.cpp:
2652 (WebCore::HitTestResult::setScrollbar):
2653 * rendering/HitTestResult.h:
2654 (WebCore::HitTestResult::scrollbar):
2655 * rendering/RenderLayer.cpp:
2656 (WebCore::RenderLayer::hitTestOverflowControls):
2657 * rendering/RenderLayer.h:
2658 * rendering/RenderListBox.h:
2659
sfalken@apple.comb4e407e2008-09-13 02:59:00 +000026602008-09-12 Steve Falkenburg <sfalken@apple.com>
2661
2662 Fix Mac build.
2663
2664 * css/CSSStyleSelector.cpp:
2665 (WebCore::getTransformOperationType):
2666
dino@apple.comf937dc62008-09-13 00:45:39 +000026672008-09-12 Chris Marrin <cmarrin@apple.com>
2668
2669 Reviewed by Dave Hyatt.
2670
2671 Make transform animation behavior match spec
2672 https://bugs.webkit.org/show_bug.cgi?id=20770
2673
2674 Tests: transitions/transform-op-list-match.html
2675 transitions/transform-op-list-no-match.html
2676
2677 * css/CSSStyleSelector.cpp:
2678 * css/CSSStyleSelector.h:
2679 * page/animation/AnimationBase.cpp:
2680 * page/animation/AnimationBase.h:
2681 * page/animation/ImplicitAnimation.cpp:
2682 * page/animation/ImplicitAnimation.h:
2683 * page/animation/KeyframeAnimation.cpp:
2684 * page/animation/KeyframeAnimation.h:
2685 * rendering/RenderLayer.cpp:
2686 * rendering/style/RenderStyle.cpp:
2687 * rendering/style/RenderStyle.h:
2688
timothy@apple.comab374dd2008-09-12 22:43:38 +000026892008-09-12 Ojan Vafai <ojan@chromium.org>
2690
2691 Properly escape contents of links added to the inspector.
2692 For now, just build the link with the DOM and get the
2693 outerHTML. Eventually, we probably just want to do
2694 this entirely with the DOM.
2695
2696 Reviewed by Timothy Hatcher.
2697
2698 https://bugs.webkit.org/show_bug.cgi?id=20684
2699
2700 * manual-tests/inspector/escape-links.html: Added.
2701 * page/inspector/StylesSidebarPane.js:
2702 * page/inspector/inspector.js:
2703 * page/inspector/utilities.js:
2704
adele@apple.com87fb3c72008-09-12 22:14:13 +000027052008-09-12 Adele Peterson <adele@apple.com>
2706
2707 Reviewed by John Sullivan and Kevin McCullough.
2708
2709 Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames
2710
2711 * page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
2712 Hit testing again on the main frame will only work if we aren't already on the main frame. If we are already on the main frame, that will
2713 cause infinite recursion. This change checks that we're not already on the main frame before hit testing again.
2714
kmccullough@apple.combdba2e32008-09-12 22:08:56 +000027152008-09-12 Kevin McCullough <kmccullough@apple.com>
2716
2717 RS by Tim .
2718
2719 Re-introducing the code since it was not the cause of the crash.
2720 See r36343.
2721
2722 * rendering/RenderObject.cpp:
2723 (WebCore::RenderObject::canBeProgramaticallyScrolled):
2724 * rendering/RenderObject.h:
2725
dino@apple.comf712ed02008-09-12 21:54:57 +000027262008-09-12 Chris Marrin <cmarrin@apple.com>
2727
2728 Reviewed by Dave Hyatt.
2729
2730 When changing one animation in a list, don't reset other animations
2731 https://bugs.webkit.org/show_bug.cgi?id=20675
2732
2733 Test: animations/change-one-anim.html
2734
2735 * page/animation/AnimationBase.cpp:
2736 (WebCore::AnimationBase::getNumProperties):
2737 * page/animation/AnimationBase.h:
2738 * page/animation/AnimationController.cpp:
2739 * page/animation/CompositeAnimation.cpp:
2740 (WebCore::CompositeAnimation::updateKeyframeAnimations):
2741 * page/animation/CompositeAnimation.h:
2742 * page/animation/ImplicitAnimation.cpp:
2743 * page/animation/KeyframeAnimation.cpp:
2744 * page/animation/KeyframeAnimation.h:
2745 (WebCore::KeyframeAnimation::setIndex):
2746
beidson@apple.com521e2b52008-09-12 18:40:03 +000027472008-09-12 Brady Eidson <beidson@apple.com>
2748
2749 Reviewed by Mitz Pettel
2750
2751 Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html
2752
2753 * loader/DocumentLoader.cpp:
2754 (WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior.
2755 Subresources can never be created from nil data, but there is always a MainResource, whether
2756 or not there's any data. So in the case where the main resource has no data, fake it for the
2757 sake of creating the ArchiveResource.
2758
hyatt@apple.com818ffe92008-09-12 18:37:23 +000027592008-09-12 Dave Hyatt <hyatt@apple.com>
2760
2761 Preparation for major scrollbar rearchitecture. Eliminate the concept of non-widget based
2762 scrollbars (which we never supported anyway). Make Scrollbar derive from Widget directly.
2763 Remove all the isWidget and hasPlatformScrollbars guards.
2764
2765 Reviewed by Tim Hatcher
2766
2767 * platform/ScrollBar.h:
2768 * platform/gtk/PlatformScrollBar.h:
2769 * platform/mac/PlatformScrollBar.h:
2770 * platform/qt/PlatformScrollBar.h:
2771 * platform/win/PlatformScrollBar.h:
2772 * platform/win/ScrollViewWin.cpp:
2773 (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
2774 (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
2775 * platform/wx/PlatformScrollBar.h:
2776 * rendering/RenderLayer.cpp:
2777 (WebCore::RenderLayer::horizontalScrollbarWidget):
2778 (WebCore::RenderLayer::verticalScrollbarWidget):
2779 (WebCore::RenderLayer::createScrollbar):
2780 (WebCore::RenderLayer::destroyScrollbar):
2781 * rendering/RenderListBox.cpp:
2782 (WebCore::RenderListBox::~RenderListBox):
2783 (WebCore::RenderListBox::updateFromElement):
2784 (WebCore::RenderListBox::isPointInOverflowControl):
2785
mitz@apple.com0bef1302008-09-12 18:22:07 +000027862008-09-12 Dan Bernstein <mitz@apple.com>
2787
2788 Reviewed by Sam Weinig.
2789
2790 - https://bugs.webkit.org/show_bug.cgi?id=20793 clean up page/animation
2791
2792 * page/animation/AnimationController.cpp:
2793 * page/animation/AnimationController.h:
2794 * page/animation/CompositeAnimation.cpp:
2795 * page/animation/CompositeAnimation.h:
2796 * page/animation/ImplicitAnimation.cpp:
2797 * page/animation/ImplicitAnimation.h:
2798 * page/animation/KeyframeAnimation.cpp:
2799 * page/animation/KeyframeAnimation.h:
2800
timothy@apple.com43203432008-09-12 04:44:40 +000028012008-09-11 Timothy Hatcher <timothy@apple.com>
2802
2803 Add a renderedImage method to DOMNode to get an image
2804 of the rendering for the node and it's descendants.
2805
2806 <rdar://problem/5849349> Would like API to create
2807 an image for a DOM node
2808
2809 Reviewed by Oliver Hunt.
2810
2811 * bindings/objc/DOM.mm:
2812 (-[DOMNode renderedImage]): Call Frame::nodeImage.
2813 * bindings/objc/DOMPrivate.h:
2814 * page/Frame.h:
2815 * page/mac/FrameMac.mm:
2816 (WebCore::Frame::nodeImage):
2817
dino@apple.com9300a0b2008-09-12 00:36:31 +000028182008-09-08 Chris Marrin <cmarrin@apple.com>
2819
2820 Reviewed by Dave Hyatt
2821
2822 Need to support comma separated list of key times in keyframes selectors
2823 https://bugs.webkit.org/show_bug.cgi?id=20680
2824
2825 Test: animations/keyframes-comma-separated.html
2826
2827 * css/CSSGrammar.y:
2828 * css/CSSParser.cpp:
2829 (WebCore::CSSParser::createKeyframeRule):
2830 * css/CSSParser.h:
2831 * css/CSSStyleSelector.cpp:
2832 (WebCore::CSSStyleSelector::addKeyframeStyle):
2833 * css/WebKitCSSKeyframeRule.cpp:
2834 (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
2835 (WebCore::WebKitCSSKeyframeRule::cssText):
2836 (WebCore::WebKitCSSKeyframeRule::parseKeyString):
2837 * css/WebKitCSSKeyframeRule.h:
2838 (WebCore::WebKitCSSKeyframeRule::keyText):
2839 (WebCore::WebKitCSSKeyframeRule::setKeyText):
2840 (WebCore::WebKitCSSKeyframeRule::getKeys):
2841 * css/WebKitCSSKeyframesRule.cpp:
2842 (WebCore::WebKitCSSKeyframesRule::append):
2843 (WebCore::WebKitCSSKeyframesRule::insertRule):
2844 (WebCore::WebKitCSSKeyframesRule::deleteRule):
2845 (WebCore::WebKitCSSKeyframesRule::findRule):
2846 (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
2847 * css/WebKitCSSKeyframesRule.h:
2848 * page/animation/AnimationBase.cpp:
2849 (WebCore::AnimationBase::blendProperties):
2850
kmccullough@apple.com0f9f23a2008-09-11 22:57:09 +000028512008-09-11 Kevin McCullough <kmccullough@apple.com>
2852
2853 RS by Tim.
2854
2855 Reverting because this caused a crash.
2856
2857 * rendering/RenderObject.cpp:
2858 (WebCore::RenderObject::canBeProgramaticallyScrolled):
2859 (WebCore::RenderObject::hasScrollableView):
2860 * rendering/RenderObject.h:
2861
dino@apple.com19853b32008-09-11 21:59:08 +000028622008-09-11 Dean Jackson <dino@apple.com>
2863
2864 Reviewed by Dan Bernstein.
2865
2866 Fix assertion on transition property "none"
2867 https://bugs.webkit.org/show_bug.cgi?id=20751
2868
2869 Test: transitions/transition-end-event-set-none.html
2870
2871 * page/animation/CompositeAnimation.cpp:
2872 (WebCore::CompositeAnimation::updateTransitions):
2873
dsmith@webkit.orge6ea48f2008-09-11 21:41:33 +000028742008-09-11 David Smith <catfish.man@gmail.com>
2875
dsmith@webkit.org08103d92008-09-11 21:54:30 +00002876 Rubber-stamped by mitzpettel.
2877
2878 Remove an accidentally added extra file.
2879
2880 * WebCore: Removed.
2881
28822008-09-11 David Smith <catfish.man@gmail.com>
2883
dsmith@webkit.orge6ea48f2008-09-11 21:41:33 +00002884 Reviewed by Darin
2885
2886 https://bugs.webkit.org/show_bug.cgi?id=20180
2887
2888 This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.
2889
2890 * WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
2891 * css/CSSStyleSelector.cpp: include NodeRenderStyle.h
2892 * dom/Element.cpp: include NodeRenderStyle.h
2893 * dom/Node.cpp: Remove the definition of renderStyle()
2894 (WebCore::Node::nonRendererRenderStyle):
2895 * dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
2896 * dom/NodeRenderStyle.h: Added.
2897 (WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
2898 * html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
2899 * html/HTMLOptGroupElement.h:
2900 (WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
2901 * html/HTMLOptionElement.cpp: include NodeRenderStyle.h
2902 * html/HTMLOptionElement.h:
2903 (WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
2904 * rendering/RenderListBox.cpp: include NodeRenderStyle.h
2905 * rendering/RenderMenuList.cpp: include NodeRenderStyle.h
2906 * svg/SVGUseElement.cpp: include NodeRenderStyle.h
2907
kmccullough@apple.com38d3b0f2008-09-11 17:39:12 +000029082008-09-11 Kevin McCullough <kmccullough@apple.com>
2909
2910 Reviewed by Adele and Tim.
2911
2912 <rdar://problem/6100597> REGRESSION: clicking on search results in Web
2913 Inspector does not scroll to the line of the results (20167)
2914 - This was put in by Max to fix auto scrolling but is not correct for
2915 the whole web: rdar://problem/6213098
2916
2917 * rendering/RenderObject.cpp:
2918 (WebCore::RenderObject::canBeProgramaticallyScrolled):
2919 * rendering/RenderObject.h:
2920
cfleizach@apple.com6a3b1452008-09-11 16:24:09 +000029212008-09-11 Chris Fleizach <cfleizach@apple.com>
2922
2923 Reviewed by Beth Dakin
2924
2925 <rdar://problem/6210511> AX: if a frame has a title, that should be reported as the AXWebArea's title
2926
2927 Test: accessibility/frame-with-title.html
2928
2929 * page/AccessibilityRenderObject.cpp:
2930 (WebCore::AccessibilityRenderObject::accessibilityDescription):
2931
hausmann@webkit.orge8f8ffd2008-09-11 07:34:42 +000029322008-09-11 Dirk Schulze <vbs85@gmx.de>
2933
2934 Reviewed by Simon.
2935
hausmann@webkit.orgea57c432008-09-11 08:03:07 +00002936 Fixed stroke() and strokeRect() to support gradients
2937 and patterns on Qt.
2938
2939 [Qt] Canvas stroke don't work for gradients and patterns
2940 [https://bugs.webkit.org/show_bug.cgi?id=20749]
2941
2942 * platform/graphics/qt/GraphicsContextQt.cpp:
2943 (WebCore::GraphicsContext::strokePath):
2944 (WebCore::GraphicsContext::strokeRect):
2945
29462008-09-11 Dirk Schulze <vbs85@gmx.de>
2947
2948 Reviewed by Simon.
2949
hausmann@webkit.orgc11e3b72008-09-11 07:37:42 +00002950 https://bugs.webkit.org/show_bug.cgi?id=20729
2951
2952 Fixed canvas gradients for Qt
2953
2954 [Qt] Canvas gradients don't work as expected
2955 [https://bugs.webkit.org/show_bug.cgi?id=20729]
2956
2957 * platform/graphics/qt/GradientQt.cpp:
2958 (WebCore::Gradient::platformGradient):
2959
29602008-09-11 Dirk Schulze <vbs85@gmx.de>
2961
2962 Reviewed by Simon.
2963
hausmann@webkit.orge8f8ffd2008-09-11 07:34:42 +00002964 https://bugs.webkit.org/show_bug.cgi?id=20568
2965
2966 Add support for patterns to Qt.
2967
2968 * platform/graphics/qt/PatternQt.cpp:
2969 (WebCore::Pattern::createPlatformPattern):
2970
mitz@apple.com442c5892008-09-10 18:21:14 +000029712008-09-10 Dan Bernstein <mitz@apple.com>
2972
2973 Reviewed by Sam Weinig.
2974
2975 - clean up AnimationBase
2976
2977 * page/animation/AnimationBase.cpp:
2978 * page/animation/AnimationBase.h:
2979 * page/animation/CompositeAnimation.cpp:
2980 * page/animation/ImplicitAnimation.cpp:
2981 * page/animation/ImplicitAnimation.h:
2982 * page/animation/KeyframeAnimation.cpp:
2983 * page/animation/KeyframeAnimation.h:
2984
ap@webkit.orgbaf12872008-09-10 16:42:10 +000029852008-09-10 Alexey Proskuryakov <ap@webkit.org>
2986
2987 Reviewed by Darin Adler.
2988
2989 https://bugs.webkit.org/show_bug.cgi?id=20741
2990 REGRESSION: ISO-8859-8-I encoding is registered incorrectly
2991
2992 Turns out that there were no real behavior changes for 8859-8, as it was only a debug-only
2993 check to ignore this specific registration that was failing. Yet, I decided to add a bunch of
2994 tests for ISO-8859-8 encoding aliases, as we handle them in a quite complicated manner.
2995
2996 I also found and fixed a potential crasher for non-Mac ports.
2997
2998 Tests: fast/encoding/hebrew/8859-8-e.html
2999 fast/encoding/hebrew/8859-8-i.html
3000 fast/encoding/hebrew/8859-8.html
3001 fast/encoding/hebrew/csISO88598I.html
3002 fast/encoding/hebrew/hebrew.html
3003 fast/encoding/hebrew/iso-ir-138.html
3004 fast/encoding/hebrew/logical.html
3005
3006 * platform/text/TextEncodingRegistry.cpp: (WebCore::checkExistingName): Check for iso-8859-8
3007 (case-insensitively, because different versions of ICU report this MIME name in different
3008 case).
3009
3010 * platform/text/TextCodecICU.cpp:
3011 (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated some comments.
3012 (WebCore::TextCodecICU::registerExtendedCodecs): Try both MIME and IANA names here, too.
3013 There are four names in ICU that only have MIME names (x-mac-* ones), so we could end up
3014 with an encoding map entry, but no codec for these. This was not an issue on the Mac, as
3015 we also support these via TEC (which we should stop doing), but on Windows, this would
3016 likely crash.
3017
hyatt@apple.com0197e6b2008-09-10 05:29:46 +000030182008-09-09 Dave Hyatt <hyatt@apple.com
3019
3020 Resurrect PlatformScrollbarWin.
3021
3022 Reviewed by Adam Roben
3023
3024 * WebCore.vcproj/WebCore.vcproj:
3025 * platform/win/PlatformScrollBarWin.cpp:
3026 (WebCore::isRunningOnVistaOrLater):
3027 (WebCore::checkAndInitScrollbarTheme):
3028 (WebCore::PlatformScrollbar::PlatformScrollbar):
3029 (WebCore::PlatformScrollbar::invalidateTrack):
3030 (WebCore::PlatformScrollbar::invalidatePart):
3031 (WebCore::PlatformScrollbar::paint):
3032 (WebCore::PlatformScrollbar::hasButtons):
3033 (WebCore::PlatformScrollbar::hasThumb):
3034 (WebCore::PlatformScrollbar::backButtonRect):
3035 (WebCore::PlatformScrollbar::forwardButtonRect):
3036 (WebCore::PlatformScrollbar::trackRect):
3037 (WebCore::PlatformScrollbar::gripperRect):
3038 (WebCore::PlatformScrollbar::thumbLength):
3039 (WebCore::PlatformScrollbar::paintButton):
3040 (WebCore::PlatformScrollbar::paintTrack):
3041 (WebCore::PlatformScrollbar::paintThumb):
3042 (WebCore::PlatformScrollbar::paintGripper):
3043 (WebCore::PlatformScrollbar::hitTest):
3044 (WebCore::PlatformScrollbar::handleMouseMoveEvent):
3045 (WebCore::PlatformScrollbar::handleMouseOutEvent):
3046 (WebCore::PlatformScrollbar::themeChanged):
3047
cwzwarich@webkit.org8a334572008-09-10 03:22:04 +000030482008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
3049
3050 Reviewed by Maciej Stachowiak.
3051
3052 Bug 20759: Remove MacroAssembler
3053 <https://bugs.webkit.org/show_bug.cgi?id=20759>
3054
3055 Make the necessary changes to ForwardingHeaders to remove
3056 MacroAssembler.
3057
3058 * ForwardingHeaders/masm/IA32MacroAsm.h: Removed.
3059 * ForwardingHeaders/masm/MacroAssembler.h: Removed.
3060 * ForwardingHeaders/masm/X86Assembler.h: Added.
3061
alp@webkit.org509e3d42008-09-10 01:26:20 +000030622008-09-09 Alp Toker <alp@nuanti.com>
3063
3064 Reviewed by Dave Hyatt.
3065
3066 https://bugs.webkit.org/show_bug.cgi?id=16792
3067 [GTK] Fails to render Japanese/Chinese text with simple path
3068
3069 https://bugs.webkit.org/show_bug.cgi?id=16942
3070 [GTK] Oddities in font selection and fall back
3071
3072 https://bugs.webkit.org/show_bug.cgi?id=16862
3073 [GTK] Custom fonts hard-coded to use grayscale antialiasing and no hinting
3074
3075 GTK+ font fixes and enhancements.
3076
3077 Implement font fallback for the simple FontConfig-based text path and
3078 improve the Pango-based complex text path to make use of requested
3079 font properties and available font selection.
3080
3081 Add text shadow support to the complex path.
3082
3083 * platform/graphics/gtk/FontCacheGtk.cpp:
3084 (WebCore::FontCache::getFontDataForCharacters):
3085 (WebCore::FontCache::getSimilarFontPlatformData):
3086 * platform/graphics/gtk/FontGtk.cpp:
3087 (WebCore::setPangoAttributes):
3088 (WebCore::Font::drawComplexText):
3089 (WebCore::getDefaultPangoLayout):
3090 (WebCore::Font::floatWidthForComplexText):
3091 (WebCore::Font::offsetForPositionForComplexText):
3092 (WebCore::Font::selectionRectForComplexText):
3093 * platform/graphics/gtk/FontPlatformData.h:
3094 (WebCore::FontPlatformData::FontPlatformData):
3095 (WebCore::FontPlatformData::hash):
3096 * platform/graphics/gtk/FontPlatformDataGtk.cpp:
3097 (WebCore::FontPlatformData::FontPlatformData):
3098 * platform/graphics/gtk/SimpleFontDataGtk.cpp:
3099 (WebCore::SimpleFontData::platformDestroy):
3100
hyatt@apple.com33f37f62008-09-09 23:51:46 +000031012008-09-09 Dave Hyatt <hyatt@apple.com>
3102
3103 Make the Windows classic case work again. Overlap in slider constants and other constants broke
3104 the push state for buttons and checkboxes. Make sure to check the RenderObject's appearance
3105 value to make sure it's really a slider thumb to resolve this conflict.
3106
3107 Reviewed by Adam Roben
3108
3109 * rendering/RenderThemeWin.cpp:
3110 (WebCore::drawControl):
3111
dino@apple.com442d0652008-09-09 23:36:56 +000031122008-09-05 Chris Marrin <cmarrin@apple.com>
3113
3114 Reviewed by Sam Weinig.
3115
3116 Need to handle the case when 0% or 100% keyframe is omitted
3117 https://bugs.webkit.org/show_bug.cgi?id=20679
3118
3119 Tests: animations/keyframes-from-missing.html
3120 animations/keyframes-to-missing.html
3121
3122 * css/CSSStyleSelector.cpp:
3123 (WebCore::CSSStyleSelector::addKeyframeStyle):
3124
hyatt@apple.com419d0ad2008-09-09 23:11:14 +000031252008-09-09 Dave Hyatt <hyatt@apple.com>
3126
3127 Resurrect Safari's original RenderThemeWin and bring it up to date with ToT. Having a current
3128 RenderThemeWin that does not have any Skia dependencies should provide a good basis for a potential
3129 merge of Google Chrome's RenderThemeWin (to help us see where the Skia stuff can be cut and to see
3130 what changes have been made as compared with the old RenderThemeWin).
3131
3132 Fix CSS2 system fonts to properly set both the rendering mode (so that they properly pick up GDI vs. CG
3133 text rendering modes) and the printer font setting (so that OS X system fonts properly pick up screen
3134 vs. printer advancement rounding).
3135
3136 Reviewed by Adam/Sam
3137
3138 * css/CSSStyleSelector.cpp:
3139 (WebCore::CSSStyleSelector::applyProperty):
3140 * platform/graphics/Icon.h:
3141 (WebCore::Icon::create):
3142 * rendering/RenderThemeWin.cpp:
3143 (WebCore::RenderThemeWin::RenderThemeWin):
3144 (WebCore::RenderThemeWin::~RenderThemeWin):
3145 (WebCore::RenderThemeWin::buttonTheme):
3146 (WebCore::RenderThemeWin::textFieldTheme):
3147 (WebCore::RenderThemeWin::menuListTheme):
3148 (WebCore::RenderThemeWin::sliderTheme):
3149 (WebCore::RenderThemeWin::close):
3150 (WebCore::RenderThemeWin::themeChanged):
3151 (WebCore::RenderThemeWin::supportsHover):
3152 (WebCore::fillFontDescription):
3153 (WebCore::RenderThemeWin::systemFont):
3154 (WebCore::RenderThemeWin::supportsFocus):
3155 (WebCore::RenderThemeWin::determineClassicState):
3156 (WebCore::RenderThemeWin::determineState):
3157 (WebCore::RenderThemeWin::determineSliderThumbState):
3158 (WebCore::RenderThemeWin::getClassicThemeData):
3159 (WebCore::RenderThemeWin::getThemeData):
3160 (WebCore::drawControl):
3161 (WebCore::RenderThemeWin::paintButton):
3162 (WebCore::RenderThemeWin::paintTextField):
3163 (WebCore::RenderThemeWin::paintMenuList):
3164 (WebCore::RenderThemeWin::adjustMenuListStyle):
3165 (WebCore::RenderThemeWin::adjustMenuListButtonStyle):
3166 (WebCore::RenderThemeWin::paintMenuListButton):
3167 (WebCore::RenderThemeWin::paintSliderTrack):
3168 (WebCore::RenderThemeWin::paintSliderThumb):
3169 (WebCore::RenderThemeWin::adjustSliderThumbSize):
3170 (WebCore::RenderThemeWin::paintSearchField):
3171 (WebCore::RenderThemeWin::adjustSearchFieldStyle):
3172 (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
3173 (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
3174 (WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
3175 (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
3176 (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
3177 (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
3178 (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
3179 * rendering/RenderThemeWin.h:
3180 (WebCore::ThemeData::ThemeData):
3181 (WebCore::RenderThemeWin::paintSearchFieldDecoration):
3182 (WebCore::RenderThemeWin::adjustButtonStyle):
3183 (WebCore::RenderThemeWin::adjustTextFieldStyle):
3184 (WebCore::RenderThemeWin::adjustTextAreaStyle):
3185
dino@apple.comd511ce52008-09-09 19:50:25 +000031862008-09-09 Dean Jackson <dino@apple.com>
3187
3188 Reviewed by Sam Weinig.
3189
3190 Document::createEvent missing cases for animation and
3191 transition events.
3192 https://bugs.webkit.org/show_bug.cgi?id=20734
3193
3194 Test: transitions/transition-end-event-create.html
3195 Test: animations/animation-events-create.html
3196
3197 * dom/Document.cpp:
3198 (WebCore::Document::createEvent):
3199 - add the two cases
3200
mitz@apple.com1da7b882008-09-09 18:12:06 +000032012008-09-09 Dan Bernstein <mitz@apple.com>
3202
mitz@apple.com54921562008-09-09 18:48:34 +00003203 - Tiger build fix
3204
3205 * WebCore.Tiger.exp:
3206 * WebCore.base.exp:
3207 * platform/mac/WebCoreSystemInterface.h:
3208 * platform/mac/WebCoreSystemInterface.mm:
3209
32102008-09-09 Dan Bernstein <mitz@apple.com>
3211
mitz@apple.com1da7b882008-09-09 18:12:06 +00003212 Reviewed by Darin Adler.
3213
3214 - WebCore part of <rdar://problem/6206244> Use alternate character-to-glyph interface on Leopard
3215
3216 * WebCore.Tiger.exp:
3217 * WebCore.base.exp:
3218 * platform/graphics/SimpleFontData.h:
3219 * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
3220 (WebCore::GlyphPage::fill):
3221 * platform/graphics/mac/SimpleFontDataMac.mm:
3222 (WebCore::initFontData):
3223 (WebCore::SimpleFontData::platformInit):
3224 (WebCore::SimpleFontData::platformDestroy):
3225 * platform/mac/WebCoreSystemInterface.h:
3226 * platform/mac/WebCoreSystemInterface.mm:
3227
kmccullough@apple.com5ba965b2008-09-09 16:40:31 +000032282008-09-09 Kevin McCullough <kmccullough@apple.com>
3229
3230 Reviewed by Tim.
3231
3232 <rdar://problem/6198545> REGRESSION: Inspector debugger barfs on
3233 breakpoints inside eval.
3234
3235 * page/inspector/inspector.js:
3236
hausmann@webkit.orgdab0e872008-09-09 14:17:21 +000032372008-09-09 Joerg Bornemann <joerg.bornemann@trolltech.com>
3238
3239 Reviewed by Simon.
3240
3241 Fix compilation of the Qt port with disabled plugins on Windows
3242
3243 * WebCore.pro:
3244 * plugins/PluginView.cpp:
3245 (WebCore::PluginView::PluginView):
3246 * plugins/PluginView.h:
3247
ap@webkit.org2ba74d32008-09-09 08:11:01 +000032482008-09-09 Jungshik Shin <jungshik.shin@gmail.com>
3249
3250 Reviewed by Alexey Proskuryakov.
3251
3252 Try MIME charset names before trying IANA names
3253 ( https://bugs.webkit.org/show_bug.cgi?id=17537 )
3254
3255 With this change, shorter and more widely used names (preferred MIME
3256 names) are returned by document.charset, document.characterSet,
3257 document.inputEncoding rather than IANA names. This helps
3258 fixing bug 18085 in addition to web developers who are more familiar
3259 with MIME names. For instance, EUC-JP, ISO-8859-X and US-ASCII will be
3260 returned instead of Extended_UNIX_Code_Packed_Format_for_Japanese,
3261 ISO-8859-X:19xx, and ANSI_X3.4-1968. It also replaces IBM8xx with cp8xx.
3262 Note that cp/IBM 8xx are extremly rare in today's web. Even if they're
3263 used, the former is still recognized as aliases to the latter so that
3264 there's very little, if any, to worry about.
3265
3266 * platform/text/TextCodecICU.cpp:
3267 (WebCore::TextCodecICU::registerExtendedEncodingNames):
3268
weinig@apple.com22294302008-09-09 06:55:39 +000032692008-09-08 Sam Weinig <sam@webkit.org>
3270
3271 Reviewed by Maciej Stachowiak and Oliver Hunt.
3272
3273 Add forwarding headers.
3274
3275 * ForwardingHeaders/wtf/HashFunctions.h: Added.
3276
dino@apple.comd9962af2008-09-09 01:02:00 +000032772008-09-05 Dean Jackson <dino@apple.com>
3278
3279 Reviewed by Dan Bernstein.
3280
3281 Update grammar so that we can add a keyframe rule via the DOM.
3282 https://bugs.webkit.org/show_bug.cgi?id=20613
3283
3284 * css/CSSGrammar.y:
3285 * css/tokenizer.flex:
3286
antti@apple.com4b17a932008-09-09 00:40:45 +000032872008-09-08 Antti Koivisto <antti@apple.com>
3288
3289 Reviewed by Dan Bernstein.
3290
3291 Allow <br> for simple UA stylesheet. Editing code generates them. It does not
3292 actually show up in any of the default stylesheets.
3293
3294 * css/CSSStyleSelector.cpp:
3295 (WebCore::elementCanUseSimpleDefaultStyle):
3296
mitz@apple.com66fa91a2008-09-09 00:35:22 +000032972008-09-08 Dimitri Glazkov <dglazkov@google.com>
3298
3299 Reviewed by Dan Bernstein.
3300
3301 - fix https://bugs.webkit.org/show_bug.cgi?id=20237
3302 Zero width and space characters are displayed incorrectly if not contained in a fallback font
3303
3304 Adds an extra check for Object Replacement Character (U+FFFC) to address
3305 the issue with fast/text/zero-width-characters.html test when run
3306 with Windows system default fonts.
3307
3308 * platform/graphics/Font.h:
3309 (WebCore::Font::treatAsZeroWidthSpace):
3310
dino@apple.comf0a4b212008-09-08 22:51:49 +000033112008-09-08 Dean Jackson <dino@apple.com>
3312
3313 Reviewed by Sam Weinig.
3314
3315 Code style issue I forgot to fix from previous commit.
3316
3317 * platform/graphics/AffineTransform.cpp:
3318 (WebCore::AffineTransform::blend):
3319
dino@apple.com26625122008-09-08 22:46:41 +000033202008-09-08 Chris Marrin <cmarrin@apple.com>
3321
3322 Reviewed by Sam Weinig
3323
3324 - Animation of -webkit-transform matrix() function should not do linear interpolation
3325 https://bugs.webkit.org/show_bug.cgi?id=20667
3326
3327 Test: animations/matrix-anim.html
3328
3329 * ChangeLog:
3330 * platform/graphics/AffineTransform.cpp:
3331 (WebCore::affineTransformDecompose):
3332 (WebCore::affineTransformCompose):
3333 (WebCore::AffineTransform::blend):
3334 * platform/graphics/AffineTransform.h:
3335 * rendering/style/RenderStyle.cpp:
3336 (WebCore::MatrixTransformOperation::blend):
3337
ap@webkit.org243a9752008-09-08 16:21:16 +000033382008-09-08 Alexey Proskuryakov <ap@webkit.org>
3339
3340 Reviewed by Darin Adler.
3341
3342 https://bugs.webkit.org/show_bug.cgi?id=20668
3343 multipart/form-data does not always include Content-type for submitted files
3344
3345 Cannot be tested with DRT or manual tests.
3346
3347 * platform/MIMETypeRegistry.cpp:
3348 (WebCore::initializeSupportedNonImageMimeTypes): Fix spacing.
3349 (WebCore::MIMETypeRegistry::getMIMETypeForPath): Default to application/octet-stream for
3350 unknown extensions, not just missing ones.
3351
hausmann@webkit.orgaf796ea2008-09-08 13:00:19 +000033522008-09-08 Simon Hausmann <hausmann@webkit.org>
3353
3354 Build fix for the Qt/Windows build, define USE_JSC to
3355 enable the WebCore::String -> JSC::UString operator that
3356 MSVC insists on seeing
3357
3358 * WebCore.pro:
3359
andersca@apple.com3ac4f552008-09-08 11:39:34 +000033602008-09-08 Anders Carlsson <andersca@apple.com>
3361
3362 Reviewed by Maciej.
3363
3364 <rdar://problem/5850387> Showing bookmarks reloads Google Reader instead.
3365
3366 In some cases, timeouts scheduled by a page in the onunload handler could fire even when the
3367 page had been unloaded and replaced by a non-HTML representation based view (such as the bookmarks view).
3368
3369 Fix this by clearing timeouts for pages that aren't cached when the provisional load is committed.
3370
3371 * bindings/js/JSDOMWindowBase.h:
3372 * loader/FrameLoader.cpp:
3373 (WebCore::FrameLoader::commitProvisionalLoad):
3374
antti@apple.com57b3a102008-09-08 07:01:36 +000033752008-09-07 Antti Koivisto <antti@apple.com>
3376
3377 Reviewed by Dave Hyatt.
3378
3379 Don't leak the simple stylesheet.
3380 Also call RenderTheme::adjustDefaultStyleSheet() in right place.
3381
3382 * css/CSSStyleSelector.cpp:
3383 (WebCore::loadFullDefaultStyle):
3384 (WebCore::loadSimpleDefaultStyle):
3385 (WebCore::CSSStyleSelector::styleForElement):
3386
cwzwarich@webkit.org3f782f62008-09-08 01:28:33 +000033872008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
3388
cwzwarich@webkit.org951b1452008-09-08 04:25:32 +00003389 Reviewed by Oliver Hunt.
3390
3391 Bug 20711: Change KJS prefix on preprocessor macros to JSC
3392 <https://bugs.webkit.org/show_bug.cgi?id=20711>
3393
3394 * bindings/js/JSEventTargetBase.h:
3395 * bindings/js/JSHTMLInputElementBase.cpp:
3396 * bindings/js/JSHTMLInputElementBase.h:
3397 * bindings/scripts/CodeGeneratorJS.pm:
3398
33992008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
3400
cwzwarich@webkit.org3f782f62008-09-08 01:28:33 +00003401 Reviewed by Maciej Stachowiak.
3402
3403 Bug 20704: Replace the KJS namespace
3404 <https://bugs.webkit.org/show_bug.cgi?id=20704>
3405
3406 Rename the KJS namespace to JSC. There are still some uses of KJS in the
3407 names of JNI functions, and I will check if these are safe to change
3408 as well.
3409
3410 * WebCore.base.exp:
3411 * bindings/js/GCController.cpp:
3412 * bindings/js/JSAttrCustom.cpp:
3413 * bindings/js/JSAudioConstructor.cpp:
3414 * bindings/js/JSAudioConstructor.h:
3415 (WebCore::JSAudioConstructor::classInfo):
3416 * bindings/js/JSCSSRuleCustom.cpp:
3417 * bindings/js/JSCSSStyleDeclarationCustom.cpp:
3418 * bindings/js/JSCSSValueCustom.cpp:
3419 * bindings/js/JSCanvasPixelArrayCustom.cpp:
3420 * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3421 * bindings/js/JSClipboardCustom.cpp:
3422 * bindings/js/JSConsoleCustom.cpp:
3423 * bindings/js/JSCustomSQLStatementCallback.cpp:
3424 (WebCore::JSCustomSQLStatementCallback::handleEvent):
3425 * bindings/js/JSCustomSQLStatementCallback.h:
3426 (WebCore::JSCustomSQLStatementCallback::create):
3427 * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
3428 (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
3429 * bindings/js/JSCustomSQLStatementErrorCallback.h:
3430 (WebCore::JSCustomSQLStatementErrorCallback::create):
3431 * bindings/js/JSCustomSQLTransactionCallback.cpp:
3432 (WebCore::JSCustomSQLTransactionCallback::handleEvent):
3433 * bindings/js/JSCustomSQLTransactionCallback.h:
3434 (WebCore::JSCustomSQLTransactionCallback::create):
3435 * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
3436 (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
3437 * bindings/js/JSCustomSQLTransactionErrorCallback.h:
3438 (WebCore::JSCustomSQLTransactionErrorCallback::create):
3439 * bindings/js/JSCustomVoidCallback.cpp:
3440 (WebCore::JSCustomVoidCallback::handleEvent):
3441 * bindings/js/JSCustomVoidCallback.h:
3442 (WebCore::JSCustomVoidCallback::create):
3443 * bindings/js/JSCustomXPathNSResolver.cpp:
3444 (WebCore::JSCustomXPathNSResolver::create):
3445 * bindings/js/JSCustomXPathNSResolver.h:
3446 * bindings/js/JSDOMApplicationCacheCustom.cpp:
3447 (WebCore::JSDOMApplicationCache::dispatchEvent):
3448 * bindings/js/JSDOMBinding.cpp:
3449 (WebCore::jsOwnedStringOrNull):
3450 * bindings/js/JSDOMBinding.h:
3451 (WebCore::DOMObject::DOMObject):
3452 (WebCore::cacheDOMObject):
3453 (WebCore::cacheSVGDOMObject):
3454 (WebCore::DOMExceptionTranslator::DOMExceptionTranslator):
3455 (WebCore::toJS):
3456 * bindings/js/JSDOMWindowBase.cpp:
3457 * bindings/js/JSDOMWindowBase.h:
3458 (WebCore::JSDOMWindowBase::classInfo):
3459 (WebCore::JSDOMWindowBase::d):
3460 * bindings/js/JSDOMWindowCustom.cpp:
3461 (WebCore::JSDOMWindow::getPropertyAttributes):
3462 * bindings/js/JSDOMWindowCustom.h:
3463 (WebCore::asJSDOMWindow):
3464 (WebCore::JSDOMWindow::customGetOwnPropertySlot):
3465 (WebCore::JSDOMWindow::customPut):
3466 (WebCore::JSDOMWindowBase::allowsAccessFrom):
3467 (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
3468 * bindings/js/JSDOMWindowShell.cpp:
3469 (WebCore::JSDOMWindowShell::getPropertyAttributes):
3470 * bindings/js/JSDOMWindowShell.h:
3471 (WebCore::JSDOMWindowShell::classInfo):
3472 * bindings/js/JSDatabaseCustom.cpp:
3473 * bindings/js/JSDocumentCustom.cpp:
3474 * bindings/js/JSDocumentFragmentCustom.cpp:
3475 * bindings/js/JSElementCustom.cpp:
3476 * bindings/js/JSEventCustom.cpp:
3477 * bindings/js/JSEventListener.cpp:
3478 * bindings/js/JSEventListener.h:
3479 (WebCore::JSUnprotectedEventListener::create):
3480 (WebCore::JSEventListener::create):
3481 * bindings/js/JSEventTargetBase.cpp:
3482 * bindings/js/JSEventTargetBase.h:
3483 (WebCore::JSEventTargetBase::getValueProperty):
3484 (WebCore::JSEventTargetBase::putValueProperty):
3485 (WebCore::JSEventTargetBase::getOwnPropertySlot):
3486 (WebCore::JSEventTargetBase::put):
3487 (WebCore::JSEventTargetPrototype::JSEventTargetPrototype):
3488 (WebCore::JSEventTargetPrototype::self):
3489 (WebCore::JSEventTargetPrototype::getOwnPropertySlot):
3490 (WebCore::JSEventTargetPrototype::classInfo):
3491 * bindings/js/JSEventTargetNode.cpp:
3492 * bindings/js/JSEventTargetNode.h:
3493 (WebCore::JSEventTargetNode::getOwnPropertySlot):
3494 (WebCore::JSEventTargetNode::getValueProperty):
3495 (WebCore::JSEventTargetNode::put):
3496 (WebCore::JSEventTargetNode::putValueProperty):
3497 * bindings/js/JSHTMLAllCollection.h:
3498 (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
3499 (WebCore::JSHTMLAllCollection::toBoolean):
3500 * bindings/js/JSHTMLAppletElementCustom.cpp:
3501 * bindings/js/JSHTMLCollectionCustom.cpp:
3502 * bindings/js/JSHTMLDocumentCustom.cpp:
3503 * bindings/js/JSHTMLElementCustom.cpp:
3504 * bindings/js/JSHTMLEmbedElementCustom.cpp:
3505 * bindings/js/JSHTMLFormElementCustom.cpp:
3506 * bindings/js/JSHTMLFrameElementCustom.cpp:
3507 * bindings/js/JSHTMLFrameSetElementCustom.cpp:
3508 * bindings/js/JSHTMLIFrameElementCustom.cpp:
3509 * bindings/js/JSHTMLInputElementBase.cpp:
3510 (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
3511 (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
3512 * bindings/js/JSHTMLInputElementBase.h:
3513 (WebCore::JSHTMLInputElementBase::classInfo):
3514 * bindings/js/JSHTMLObjectElementCustom.cpp:
3515 * bindings/js/JSHTMLOptionElementConstructor.cpp:
3516 * bindings/js/JSHTMLOptionElementConstructor.h:
3517 (WebCore::JSHTMLOptionElementConstructor::classInfo):
3518 * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
3519 * bindings/js/JSHTMLSelectElementCustom.cpp:
3520 (WebCore::selectIndexSetter):
3521 (WebCore::JSHTMLSelectElement::indexSetter):
3522 * bindings/js/JSHTMLSelectElementCustom.h:
3523 * bindings/js/JSHistoryCustom.cpp:
3524 * bindings/js/JSImageConstructor.cpp:
3525 * bindings/js/JSImageConstructor.h:
3526 (WebCore::JSImageConstructor::classInfo):
3527 * bindings/js/JSInspectedObjectWrapper.cpp:
3528 * bindings/js/JSInspectedObjectWrapper.h:
3529 (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
3530 (WebCore::JSInspectedObjectWrapper::classInfo):
3531 * bindings/js/JSInspectorCallbackWrapper.cpp:
3532 * bindings/js/JSInspectorCallbackWrapper.h:
3533 (WebCore::JSInspectorCallbackWrapper::classInfo):
3534 (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
3535 * bindings/js/JSJavaScriptCallFrameCustom.cpp:
3536 * bindings/js/JSLocationCustom.cpp:
3537 * bindings/js/JSMimeTypeArrayCustom.cpp:
3538 * bindings/js/JSNSResolver.cpp:
3539 * bindings/js/JSNSResolver.h:
3540 (WebCore::JSNSResolver::create):
3541 * bindings/js/JSNamedNodeMapCustom.cpp:
3542 * bindings/js/JSNamedNodesCollection.cpp:
3543 (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
3544 * bindings/js/JSNamedNodesCollection.h:
3545 (WebCore::JSNamedNodesCollection::classInfo):
3546 * bindings/js/JSNavigatorCustom.cpp:
3547 * bindings/js/JSNodeCustom.cpp:
3548 * bindings/js/JSNodeFilterCondition.cpp:
3549 (WebCore::JSNodeFilterCondition::acceptNode):
3550 * bindings/js/JSNodeFilterCondition.h:
3551 (WebCore::JSNodeFilterCondition::create):
3552 * bindings/js/JSNodeFilterCustom.cpp:
3553 * bindings/js/JSNodeIteratorCustom.cpp:
3554 * bindings/js/JSNodeListCustom.cpp:
3555 * bindings/js/JSPluginArrayCustom.cpp:
3556 * bindings/js/JSPluginCustom.cpp:
3557 * bindings/js/JSPluginElementFunctions.cpp:
3558 (WebCore::getRuntimeObject):
3559 * bindings/js/JSPluginElementFunctions.h:
3560 * bindings/js/JSQuarantinedObjectWrapper.cpp:
3561 (WebCore::JSQuarantinedObjectWrapper::construct):
3562 (WebCore::JSQuarantinedObjectWrapper::call):
3563 * bindings/js/JSQuarantinedObjectWrapper.h:
3564 (WebCore::JSQuarantinedObjectWrapper::unwrappedObject):
3565 (WebCore::JSQuarantinedObjectWrapper::unwrappedGlobalObject):
3566 (WebCore::JSQuarantinedObjectWrapper::className):
3567 * bindings/js/JSRGBColor.cpp:
3568 * bindings/js/JSRGBColor.h:
3569 (WebCore::JSRGBColor::classInfo):
3570 * bindings/js/JSSQLResultSetRowListCustom.cpp:
3571 * bindings/js/JSSQLTransactionCustom.cpp:
3572 * bindings/js/JSSVGLazyEventListener.cpp:
3573 * bindings/js/JSSVGLazyEventListener.h:
3574 * bindings/js/JSSVGLengthCustom.cpp:
3575 * bindings/js/JSSVGMatrixCustom.cpp:
3576 (WebCore::JSSVGMatrix::inverse):
3577 (WebCore::JSSVGMatrix::rotateFromVector):
3578 * bindings/js/JSSVGPathSegCustom.cpp:
3579 * bindings/js/JSSVGPathSegListCustom.cpp:
3580 (WebCore::JSSVGPathSegList::initialize):
3581 (WebCore::JSSVGPathSegList::getItem):
3582 (WebCore::JSSVGPathSegList::insertItemBefore):
3583 (WebCore::JSSVGPathSegList::replaceItem):
3584 (WebCore::JSSVGPathSegList::removeItem):
3585 (WebCore::JSSVGPathSegList::appendItem):
3586 * bindings/js/JSSVGPointListCustom.cpp:
3587 * bindings/js/JSSVGTransformListCustom.cpp:
3588 * bindings/js/JSStorageCustom.cpp:
3589 * bindings/js/JSStyleSheetCustom.cpp:
3590 * bindings/js/JSStyleSheetListCustom.cpp:
3591 * bindings/js/JSTextCustom.cpp:
3592 * bindings/js/JSTreeWalkerCustom.cpp:
3593 * bindings/js/JSXMLHttpRequestConstructor.cpp:
3594 * bindings/js/JSXMLHttpRequestConstructor.h:
3595 (WebCore::JSXMLHttpRequestConstructor::classInfo):
3596 * bindings/js/JSXMLHttpRequestCustom.cpp:
3597 * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
3598 * bindings/js/JSXSLTProcessorConstructor.cpp:
3599 * bindings/js/JSXSLTProcessorConstructor.h:
3600 (WebCore::JSXSLTProcessorConstructor::classInfo):
3601 * bindings/js/JSXSLTProcessorCustom.cpp:
3602 * bindings/js/ScheduledAction.cpp:
3603 * bindings/js/ScheduledAction.h:
3604 * bindings/js/ScriptController.cpp:
3605 (WebCore::ScriptController::attachDebugger):
3606 (WebCore::ScriptController::windowScriptNPObject):
3607 * bindings/js/ScriptController.h:
3608 * bindings/js/ScriptControllerGtk.cpp:
3609 (WebCore::ScriptController::createScriptInstanceForWidget):
3610 * bindings/js/ScriptControllerMac.mm:
3611 (WebCore::ScriptController::createScriptInstanceForWidget):
3612 (WebCore::ScriptController::windowScriptObject):
3613 (WebCore::ScriptController::clearPlatformScriptObjects):
3614 (WebCore::updateRenderingForBindings):
3615 (WebCore::ScriptController::initJavaJSBindings):
3616 * bindings/js/ScriptControllerQt.cpp:
3617 (WebCore::ScriptController::createScriptInstanceForWidget):
3618 * bindings/js/ScriptControllerWin.cpp:
3619 (WebCore::ScriptController::createScriptInstanceForWidget):
3620 * bindings/js/ScriptControllerWx.cpp:
3621 (WebCore::ScriptController::createScriptInstanceForWidget):
3622 * bindings/js/StringSourceProvider.h:
3623 (WebCore::StringSourceProvider::getRange):
3624 * bindings/objc/DOM.mm:
3625 (-[DOMNode JSC::Bindings::]):
3626 * bindings/objc/DOMInternal.h:
3627 * bindings/objc/DOMInternal.mm:
3628 (-[WebScriptObject _initializeScriptDOMNodeImp]):
3629 * bindings/objc/DOMUtility.mm:
3630 (JSC::createDOMWrapper):
3631 (WebCore::createDOMWrapper):
3632 * bindings/objc/WebScriptObject.mm:
3633 (WebCore::createJSWrapper):
3634 (-[WebScriptObject _initWithJSObject:JSC::originRootObject:JSC::Bindings::rootObject:JSC::Bindings::]):
3635 * bindings/objc/WebScriptObjectPrivate.h:
3636 * bindings/scripts/CodeGeneratorJS.pm:
3637 * bridge/NP_jsobject.cpp:
3638 * bridge/NP_jsobject.h:
3639 * bridge/c/c_class.cpp:
3640 * bridge/c/c_class.h:
3641 * bridge/c/c_instance.cpp:
3642 * bridge/c/c_instance.h:
3643 * bridge/c/c_runtime.cpp:
3644 * bridge/c/c_runtime.h:
3645 * bridge/c/c_utility.cpp:
3646 * bridge/c/c_utility.h:
3647 * bridge/jni/jni_class.cpp:
3648 * bridge/jni/jni_class.h:
3649 * bridge/jni/jni_instance.cpp:
3650 * bridge/jni/jni_instance.h:
3651 * bridge/jni/jni_jsobject.h:
3652 * bridge/jni/jni_jsobject.mm:
3653 (JavaJSObject::call):
3654 (JavaJSObject::convertJObjectToValue):
3655 * bridge/jni/jni_objc.mm:
3656 (JSC::Bindings::dispatchJNICall):
3657 * bridge/jni/jni_runtime.cpp:
3658 * bridge/jni/jni_runtime.h:
3659 * bridge/jni/jni_utility.cpp:
3660 * bridge/jni/jni_utility.h:
3661 * bridge/npruntime.cpp:
3662 (_NPN_GetStringIdentifier):
3663 * bridge/objc/WebScriptObject.h:
3664 * bridge/objc/objc_class.h:
3665 * bridge/objc/objc_class.mm:
3666 * bridge/objc/objc_instance.h:
3667 * bridge/objc/objc_instance.mm:
3668 * bridge/objc/objc_runtime.h:
3669 * bridge/objc/objc_runtime.mm:
3670 * bridge/objc/objc_utility.h:
3671 * bridge/objc/objc_utility.mm:
3672 * bridge/qt/qt_class.cpp:
3673 * bridge/qt/qt_class.h:
3674 * bridge/qt/qt_instance.cpp:
3675 * bridge/qt/qt_instance.h:
3676 * bridge/qt/qt_runtime.cpp:
3677 (JSC::Bindings::convertQVariantToValue):
3678 (JSC::Bindings::):
3679 * bridge/qt/qt_runtime.h:
3680 * bridge/runtime.cpp:
3681 * bridge/runtime.h:
3682 * bridge/runtime_array.cpp:
3683 * bridge/runtime_array.h:
3684 * bridge/runtime_method.cpp:
3685 * bridge/runtime_method.h:
3686 * bridge/runtime_object.cpp:
3687 * bridge/runtime_object.h:
3688 * bridge/runtime_root.cpp:
3689 (JSC::Bindings::RootObject::invalidate):
3690 (JSC::Bindings::RootObject::gcProtect):
3691 (JSC::Bindings::RootObject::gcUnprotect):
3692 * bridge/runtime_root.h:
3693 * bridge/testbindings.cpp:
3694 * bridge/testbindings.mm:
3695 * bridge/testqtbindings.cpp:
3696 * dom/Document.cpp:
3697 (WebCore::Document::~Document):
3698 * dom/NSResolver.h:
3699 * dom/Node.cpp:
3700 (WebCore::Node::setDocument):
3701 (WebCore::ResolveNamespaceFunctor::ResolveNamespaceFunctor):
3702 (WebCore::resolveNamespacesForSelector):
3703 (WebCore::Node::querySelector):
3704 (WebCore::Node::querySelectorAll):
3705 * dom/Node.h:
3706 * dom/NodeFilter.cpp:
3707 * dom/NodeFilter.h:
3708 * dom/NodeFilterCondition.cpp:
3709 * dom/NodeFilterCondition.h:
3710 * dom/NodeIterator.cpp:
3711 * dom/NodeIterator.h:
3712 * dom/Traversal.cpp:
3713 * dom/Traversal.h:
3714 * dom/TreeWalker.cpp:
3715 * dom/TreeWalker.h:
3716 * dom/make_names.pl:
3717 * history/CachedPage.cpp:
3718 * history/CachedPage.h:
3719 * html/HTMLPlugInElement.cpp:
3720 (WebCore::HTMLPlugInElement::getInstance):
3721 * html/HTMLPlugInElement.h:
3722 * loader/FrameLoader.cpp:
3723 * loader/FrameLoader.h:
3724 * loader/icon/IconDatabase.cpp:
3725 (WebCore::iconDatabase):
3726 * page/Console.cpp:
3727 * page/Console.h:
3728 * page/InspectorController.cpp:
3729 (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
3730 (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
3731 (WebCore::InspectorResource::setXMLHttpRequestProperties):
3732 (WebCore::InspectorResource::sourceString):
3733 (WebCore::getResourceDocumentNode):
3734 (WebCore::search):
3735 (WebCore::InspectorController::focusNode):
3736 (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
3737 (WebCore::InspectorController::addDatabaseScriptResource):
3738 (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
3739 * page/InspectorController.h:
3740 (WebCore::InspectorController::profiles):
3741 * page/JavaScriptCallFrame.cpp:
3742 (WebCore::JavaScriptCallFrame::scopeChain):
3743 * page/JavaScriptCallFrame.h:
3744 (WebCore::JavaScriptCallFrame::create):
3745 (WebCore::JavaScriptCallFrame::update):
3746 * page/JavaScriptDebugListener.h:
3747 * page/JavaScriptDebugServer.cpp:
3748 (WebCore::dispatchDidParseSource):
3749 * page/JavaScriptDebugServer.h:
3750 * page/JavaScriptProfile.cpp:
3751 * page/JavaScriptProfile.h:
3752 * page/JavaScriptProfileNode.cpp:
3753 (WebCore::getTotalTime):
3754 (WebCore::getSelfTime):
3755 (WebCore::getTotalPercent):
3756 (WebCore::getSelfPercent):
3757 (WebCore::getNumberOfCalls):
3758 (WebCore::getChildren):
3759 (WebCore::getVisible):
3760 * page/JavaScriptProfileNode.h:
3761 * page/Page.cpp:
3762 (WebCore::Page::setDebuggerForAllPages):
3763 (WebCore::Page::setDebugger):
3764 * page/Page.h:
3765 (WebCore::Page::debugger):
3766 * page/mac/FrameMac.mm:
3767 * platform/KURL.h:
3768 (WebCore::KURL::operator JSC::UString):
3769 * platform/text/AtomicString.cpp:
3770 (WebCore::AtomicString::add):
3771 (WebCore::AtomicString::find):
3772 * platform/text/AtomicString.h:
3773 (WebCore::AtomicString::AtomicString):
3774 * platform/text/PlatformString.h:
3775 * platform/text/String.cpp:
3776 (WebCore::charactersToDouble):
3777 * platform/win/BString.cpp:
3778 * platform/win/BString.h:
3779 * plugins/MimeTypeArray.h:
3780 * plugins/Plugin.h:
3781 * plugins/PluginArray.h:
3782 * plugins/PluginView.cpp:
3783 (WebCore::PluginView::start):
3784 (WebCore::PluginView::performRequest):
3785 (WebCore::PluginView::bindingInstance):
3786 * plugins/PluginView.h:
3787 * plugins/gtk/PluginViewGtk.cpp:
3788 (WebCore::PluginView::paint):
3789 (WebCore::PluginView::handleKeyboardEvent):
3790 (WebCore::PluginView::handleMouseEvent):
3791 (WebCore::PluginView::setNPWindowRect):
3792 (WebCore::PluginView::stop):
3793 (WebCore::PluginView::init):
3794 * plugins/qt/PluginViewQt.cpp:
3795 (WebCore::PluginView::setNPWindowRect):
3796 (WebCore::PluginView::stop):
3797 (WebCore::PluginView::init):
3798 * plugins/win/PluginViewWin.cpp:
3799 (WebCore::PluginView::dispatchNPEvent):
3800 (WebCore::PluginView::handleKeyboardEvent):
3801 (WebCore::PluginView::handleMouseEvent):
3802 (WebCore::PluginView::setNPWindowRect):
3803 (WebCore::PluginView::stop):
3804 * storage/Database.cpp:
3805 (WebCore::Database::Database):
3806 * xml/XMLHttpRequest.cpp:
3807 (WebCore::XMLHttpRequest::responseText):
3808 (WebCore::XMLHttpRequest::loadRequestAsynchronously):
3809 (WebCore::XMLHttpRequest::clearResponse):
3810 (WebCore::XMLHttpRequest::dropProtection):
3811 (WebCore::XMLHttpRequest::didFinishLoading):
3812 (WebCore::XMLHttpRequest::didReceiveData):
3813 * xml/XMLHttpRequest.h:
3814
abarth@webkit.orge17b6052008-09-08 00:03:30 +000038152008-09-07 Adam Barth <abarth@webkit.org>
3816
3817 Reviewed by Sam Weinig.
3818
3819 Adopt opener restriction on frame navigation.
3820 https://bugs.webkit.org/show_bug.cgi?id=20642
3821
3822 This restriction helps prevent an attacker from navigating top-level
3823 windows that were created by another web site.
3824
3825 Tests: http/tests/security/frameNavigation/not-opener.html
3826 http/tests/security/frameNavigation/opener.html
3827
3828 * loader/FrameLoader.cpp:
3829 (WebCore::canAccessAncestor):
3830 (WebCore::FrameLoader::shouldAllowNavigation):
3831
mitz@apple.com83469af2008-09-07 22:29:56 +000038322008-09-07 Dan Bernstein <mitz@apple.com>
3833
mitz@apple.com08ff58c2008-09-07 23:19:11 +00003834 Reviewed by Maciej Stachowiak.
3835
3836 - use the correct sign for vertical offsets of combining marks
3837
3838 * platform/graphics/win/UniscribeController.cpp:
3839 (WebCore::UniscribeController::shapeAndPlaceItem):
3840
38412008-09-07 Dan Bernstein <mitz@apple.com>
3842
mitz@apple.com83469af2008-09-07 22:29:56 +00003843 Reviewed by Dave Hyatt.
3844
mitz@apple.com78685b22008-09-07 22:30:29 +00003845 - add the combining mark offsets in two places where I forgot them
3846
3847 * platform/graphics/win/FontCGWin.cpp:
3848 (WebCore::Font::drawGlyphs):
3849
38502008-09-07 Dan Bernstein <mitz@apple.com>
3851
3852 Reviewed by Dave Hyatt.
3853
mitz@apple.com83469af2008-09-07 22:29:56 +00003854 - correct glyph advances in complex text using web fonts rendered with
3855 Core Graphics
3856
3857 * platform/graphics/win/FontCustomPlatformData.cpp:
3858 (WebCore::FontCustomPlatformData::fontPlatformData):
3859
timothy@apple.com968ebc92008-09-07 16:48:41 +000038602008-09-07 Keishi Hattori <casey.hattori@gmail.com>
3861
3862 Adds console.dirxml support to the Web Inspector.
3863
3864 https://bugs.webkit.org/show_bug.cgi?id=19156
3865
3866 Reviewed by Timothy Hatcher.
3867
3868 * WebCore.vcproj/WebCore.vcproj: Added ElementsTreeOutline.js.
3869 * bindings/js/JSConsoleCustom.cpp:
3870 (WebCore::JSConsole::dirxml):
3871 * page/Console.cpp:
3872 (WebCore::Console::dirxml): Adds a ConsoleMessage with NodeMessageLevel.
3873 * page/Console.h:
3874 (WebCore::): Added NodeMessageLevel.
3875 * page/Console.idl: Added console.dirxml.
3876 * page/inspector/Console.js: A NodeMessage creates a ElementsTreeOutline.
3877 * page/inspector/ElementsPanel.js: Modified to use ElementsTreeOutline. The ElementsTreeOutline
3878 in the ElementsPanel has includeRootDOMNode and selectEnabled set to true.
3879 * page/inspector/ElementsTreeOutline.js: Added.
3880 (WebInspector.ElementsTreeOutline): A subclass of TreeOutline for displaying a DOM node tree.
3881 (WebInspector.ElementsTreeElement): A subclass of TreeElement for ElementsTreeOutline.
3882 * page/inspector/WebKit.qrc: Added ElementsTreeOutline.js.
3883 * page/inspector/inspector.css:
3884 * page/inspector/inspector.html: Added ElementsTreeOutline.js.
3885 * page/inspector/inspector.js: Moved hover related methods to WebInspector.
3886 (WebInspector.altKeyDown):
3887 (WebInspector.forceHoverHighlight):
3888 (WebInspector.hoveredDOMNode):
3889 (WebInspector._updateHoverHighlightSoon):
3890 (WebInspector._updateHoverHighlight):
3891 (WebInspector.documentKeyDown): Updates WebInspector.altKeyDown
3892 (WebInspector.documentKeyUp): Updates WebInspector.altKeyDown
3893 * page/inspector/utilities.js: Added getDocumentForNode, parentNodeOrFrameElement,
3894 isAncestorIncludingParentFrames.
3895
mrowe@apple.com61ba5f52008-09-07 06:08:56 +000038962008-09-06 Mark Rowe <mrowe@apple.com>
3897
3898 Qt build fix.
3899
3900 * bridge/qt/qt_runtime.cpp:
3901 (KJS::Bindings::convertQVariantToValue):
3902
mrowe@apple.comf88a4632008-09-07 05:44:58 +00003903=== End merge of squirrelfish-extreme ===
3904
39052008-09-05 Oliver Hunt <oliver@apple.com>
3906
3907 Start bringing up SFX on windows.
3908
3909 Reviewed by Mark Rowe and Sam Weinig
3910
3911 Start doing the work to bring up SFX on windows. Initially
3912 just working on WREC, as it does not make any calls so reduces
3913 the amount of code that needs to be corrected.
3914
3915 Add forwarding headers
3916
3917 * ChangeLog:
3918 * ForwardingHeaders/masm/MacroAssembler.h: Added.
3919 * WebCore.vcproj/WebCore.vcproj:
3920
39212008-08-27 Mark Rowe <mrowe@apple.com>
3922
3923 Reviewed by Oliver Hunt.
3924
3925 Fix the build of the full WebKit stack.
3926
3927 Add forwarding headers.
3928
3929 * ForwardingHeaders/masm/IA32MacroAsm.h: Added.
3930 * ForwardingHeaders/wrec/WREC.h: Added.
3931
3932=== Start merge of squirrelfish-extreme ===
3933
antti@apple.com13c24932008-09-07 03:54:21 +000039342008-09-06 Antti Koivisto <antti@apple.com>
3935
3936 Reviewed by Dave Hyatt.
3937
3938 <rdar://problem/6187043>
3939 Don't parse full HTML user agent style sheet unless it is actually needed
3940 <rdar://problem/6131889>
3941 WebView is significantly more expensive to create recently
3942
3943 Parsing the html4.css takes significant amount of time and memory (~50kb) on application
3944 startup. Some clients may never use most of the rules.
3945
3946 With this patch we use simplified UA stylesheet until we hit something it can't handle.
3947 This avoids full stylesheet parsing on application startup (due to empty document construction)
3948 and also makes it possible for clients with very simple demands (divs and spans only) never to load
3949 the full style.
3950
3951 It also delays view source style parsing until it is used.
3952
3953 * css/CSSStyleSelector.cpp:
3954 (WebCore::elementCanUseSimpleDefaultStyle):
3955 (WebCore::CSSStyleSelector::CSSStyleSelector):
3956 (WebCore::loadFullDefaultStyle):
3957 (WebCore::loadSimpleDefaultStyle):
3958 (WebCore::loadViewSourceStyle):
3959 (WebCore::CSSStyleSelector::matchUARules):
3960 (WebCore::CSSStyleSelector::styleForElement):
3961
kevino@webkit.orgd15b50f2008-09-07 03:46:50 +000039622008-09-06 Kevin Ollivier <kevino@theolliviers.com>
3963
3964 wx build fix.
3965
3966 * WebCoreSources.bkl:
3967
antti@apple.come953f862008-09-06 23:27:09 +000039682008-09-06 Antti Koivisto <antti@apple.com>
3969
antti@apple.com00dfa532008-09-06 23:32:26 +00003970 Reverting r35953 which was causing problems on Windows which relies on
3971 WebCore timers in nested event loops. r36132 did alternative fix.
3972
3973 * page/Chrome.cpp:
3974 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
3975 (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
3976
39772008-09-06 Antti Koivisto <antti@apple.com>
3978
antti@apple.come953f862008-09-06 23:27:09 +00003979 Reviewed by Dan Bernstein.
3980
3981 Fix <rdar://problem/6201644>
3982 https://bugs.webkit.org/show_bug.cgi?id=20493
3983 Crash after OK in dialog box and reloading page in secure mode
3984
3985 Limited loader only fix since the general timer fix is causing problems on Windows.
3986
3987 * loader/loader.cpp:
3988 (WebCore::Loader::servePendingRequests):
3989 (WebCore::Loader::Host::Host):
3990 (WebCore::Loader::Host::didFinishLoading):
3991 (WebCore::Loader::Host::didFail):
3992 (WebCore::Loader::Host::didReceiveData):
3993 * loader/loader.h:
3994 (WebCore::Loader::Host::processingResource):
3995
mitz@apple.com046bf642008-09-06 08:31:02 +000039962008-09-06 Dan Bernstein <mitz@apple.com>
3997
3998 Reviewed by Dave Hyatt.
3999
mitz@apple.comc0b050b2008-09-06 22:39:34 +00004000 The initial Core Text adoption prototype was made by Daniel Fenwick.
4001
4002 - <rdar://problem/5158514> Add a Core Text-based complex text code path
4003
4004 Currently the Core Text code path is not used in any configuration.
4005
4006 * WebCore.xcodeproj/project.pbxproj: Added files.
4007 * config.h: Defined WTF_USE_ATSUI and WTF_USE_CORE_TEXT.
4008 * platform/graphics/Font.cpp:
4009 (WebCore::WidthIterator::advance): Moved the spacingDisabled() test out
4010 of the loop.
4011 * platform/graphics/GlyphBuffer.h:
4012 (WebCore::GlyphBuffer::add): Added this version that takes an advance.
4013 * platform/graphics/SimpleFontData.h: Added ATSUI and CORE_TEXT #ifdefs.
4014 Added getCTFont() and getCFStringAttributes() and corresponding data
4015 members for Core Text.
4016 * platform/graphics/mac/CoreTextController.cpp: Added.
4017 (WebCore::roundCGFloat): Helper function.
4018 (WebCore::ceilCGFloat): Helper function.
4019 (WebCore::CoreTextController::CoreTextRun::CoreTextRun):
4020 (WebCore::CoreTextController::CoreTextController):
4021 (WebCore::CoreTextController::offsetForPosition):
4022 (WebCore::CoreTextController::collectCoreTextRuns): Added. Segments the
4023 run into subruns as necessary such that each subrun can be rendered with
4024 a single font. Also separates out soft hyphens and replaces them with
4025 real hyphens, because Core Text does not emit a glyph for soft hyphens.
4026 Then calls collectCoreTextRunsForCharacters() on each subrun.
4027 (WebCore::CoreTextController::advance):
4028 (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Creates
4029 a CTLine from the given subrun and collects its CoreTextRuns.
4030 (WebCore::CoreTextController::adjustGlyphsAndAdvances): Applies the
4031 rounding hacks, letter- and word-spacing and glyph substitutions and
4032 stores the resulting adjusted glyphs and advances.
4033 * platform/graphics/mac/CoreTextController.h: Copied from WebCore/platform/graphics/win/UniscribeController.h.
4034 (WebCore::CoreTextController::totalWidth):
4035 (WebCore::CoreTextController::finalRoundingWidth):
4036 (WebCore::CoreTextController::CoreTextRun::ctRun):
4037 (WebCore::CoreTextController::CoreTextRun::glyphCount):
4038 (WebCore::CoreTextController::CoreTextRun::fontData):
4039 (WebCore::CoreTextController::CoreTextRun::characters):
4040 (WebCore::CoreTextController::CoreTextRun::stringLocation):
4041 (WebCore::CoreTextController::CoreTextRun::stringLength):
4042 (WebCore::CoreTextController::CoreTextRun::indexAt):
4043 * platform/graphics/mac/FontMac.mm: Moved the ATSUI-specific parts to
4044 FontMacATSUI.mm.
4045 * platform/graphics/mac/FontMacATSUI.mm: Copied from WebCore/platform/graphics/mac/FontMac.mm.
4046 (WebCore::disableLigatures): Changed to call
4047 FontPlatformData::allowsLigatures().
4048 (WebCore::overrideLayoutOperation): Changed to call
4049 FontPlatformData::roundsGlyphAdvances().
4050 * platform/graphics/mac/FontMacCoreText.cpp: Copied from WebCore/platform/graphics/win/FontWin.cpp.
4051 (WebCore::Font::selectionRectForComplexText): Changed to use
4052 totalWidth() instead of advancing to the end and using runWidthSoFar().
4053 (WebCore::Font::drawComplexText):
4054 (WebCore::Font::floatWidthForComplexText): Ditto.
4055 (WebCore::Font::offsetForPositionForComplexText):
4056 * platform/graphics/mac/FontPlatformData.h:
4057 * platform/graphics/mac/FontPlatformDataMac.mm:
4058 (WebCore::FontPlatformData::setFont):
4059 (WebCore::FontPlatformData::roundsGlyphAdvances): Added. Checks the
4060 AppKit rendering mode.
4061 (WebCore::FontPlatformData::allowsLigatures): Added. Implements the
4062 heuristic that allows ligatures in fonts that do not have a glyph for
4063 'a', based on the assumption that such fonts are only used in complex
4064 text.
4065 * platform/graphics/mac/SimpleFontDataMac.mm:
4066 (WebCore::SimpleFontData::platformInit):
4067 (WebCore::SimpleFontData::platformDestroy):
4068 (WebCore::SimpleFontData::getCTFont): Added.
4069 (WebCore::SimpleFontData::getCFStringAttributes): Added. Caches and
4070 returns an attributes dictionary.
4071 * platform/text/mac/ShapeArabic.c: Added ATSUI #ifdefs.
4072 * platform/text/mac/ShapeArabic.h: Ditto.
4073
40742008-09-06 Dan Bernstein <mitz@apple.com>
4075
4076 Reviewed by Dave Hyatt.
4077
mitz@apple.com046bf642008-09-06 08:31:02 +00004078 - make combining mark offsets work in CG text on Windows
4079
4080 * platform/graphics/win/FontCGWin.cpp:
4081 (WebCore::Font::drawGlyphs): The old code tried to translate the text
4082 matrix, but failed for two reasons: it did not actually change the
4083 matrix, and even if it did, CGContextSetTextPosition overwrites the
4084 translation values in the text matrix. Instead, just added the
4085 translation to the anchor point.
4086
alp@webkit.org369cdca2008-09-06 04:08:30 +000040872008-09-05 Gustavo Noronha Silva <gns@gnome.org>
4088
4089 Reviewed by Alp Toker.
4090
4091 https://bugs.webkit.org/show_bug.cgi?id=18346
4092 [GTK] Remove build warnings
4093
4094 Applied some casts, and removed an unused typedef to make the
4095 compiler happy, printing less warnings when building.
4096
4097 * page/gtk/AccessibilityObjectWrapperAtk.cpp:
4098 * platform/graphics/gtk/SimpleFontDataPango.cpp:
4099 (WebCore::SimpleFontData::containsCharacters):
4100 * platform/graphics/gtk/VideoSinkGStreamer.cpp:
4101 (webkit_video_sink_set_caps):
4102 * platform/network/soup/ResourceHandleSoup.cpp:
4103
eric@webkit.org3cb292c2008-09-05 22:17:56 +000041042008-09-05 Eric Seidel <eric@webkit.org>
4105
eric@webkit.org5ac37902008-09-06 00:21:58 +00004106 Reviewed by Adam Roben.
4107
4108 Build fix for WebKitWin and Chromium
4109
4110 * platform/FileSystem.h:
4111
41122008-09-05 Eric Seidel <eric@webkit.org>
4113
eric@webkit.org3cb292c2008-09-05 22:17:56 +00004114 Reviewed by Darin Adler.
4115
4116 Try to make Chromium compile with ToT:
4117 - Wrap a few places which depend on KJS:: in #if USE(JSC)
4118 - Include some windows forward declarations
4119
4120 * dom/Node.h:
4121 * page/Console.h:
4122 * page/animation/CompositeAnimation.h:
4123 * platform/FileSystem.h:
4124 * platform/graphics/Image.h:
4125 * platform/text/AtomicString.h:
4126 * platform/text/String.cpp:
4127 * rendering/style/RenderStyle.h:
4128
hyatt@apple.comff85d5e2008-09-05 21:52:08 +000041292008-09-05 Dave Hyatt <hyatt@apple.com>
4130
4131 Add support for runtime switchability of the Aqua look and the native look on Windows.
4132 Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set.
4133
4134 Reviewed by Adam Roben
4135
4136 * WebCore.vcproj/WebCore.vcproj:
4137 * page/Settings.cpp:
4138 (WebCore::Settings::setShouldPaintNativeControls):
4139 * page/Settings.h:
4140 (WebCore::Settings::shouldPaintNativeControls):
4141 * rendering/RenderThemeSafari.cpp:
4142 (WebCore::theme):
4143 * rendering/RenderThemeWin.cpp:
4144
antti@apple.combced97f2008-09-05 18:52:05 +000041452008-09-05 Antti Koivisto <antti@apple.com>
4146
4147 Qt build fix.
4148
4149 * svg/SVGFEImageElement.cpp:
4150 (WebCore::SVGFEImageElement::build):
4151
aroben@apple.comca0c3362008-09-05 15:33:28 +000041522008-09-05 Dirk Schulze <vbs85@gmx.de>
4153
4154 Gtk build fix
4155
4156 * GNUmakefile.am:
4157
antti@apple.com72e4a842008-09-05 09:28:11 +000041582008-09-05 Antti Koivisto <antti@apple.com>
4159
antti@apple.com49e46662008-09-05 10:36:59 +00004160 Another build fix.
4161
4162 * svg/SVGFEImageElement.cpp:
4163 (WebCore::SVGFEImageElement::notifyFinished):
4164
41652008-09-05 Antti Koivisto <antti@apple.com>
4166
antti@apple.comfeec2582008-09-05 10:03:39 +00004167 Build fixes.
4168
4169 * WebCore.xcodeproj/project.pbxproj:
4170 * svg/graphics/filters/SVGFEImage.cpp:
4171 (WebCore::FEImage::cachedImage):
4172
41732008-09-05 Antti Koivisto <antti@apple.com>
4174
darin@apple.com07c80c62008-09-05 18:15:43 +00004175 Reviewed by Darin Adler.
antti@apple.com72e4a842008-09-05 09:28:11 +00004176
4177 Most of the implementation for https://bugs.webkit.org/show_bug.cgi?id=17998
4178 When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation"
4179
4180 Implement HTTP 1.1 "Specific end-to-end revalidation" for WebCore memory cache. This patch does
4181 not yet enable it for the biggest use case, reloading. However it is good for general browsing as
4182 well. Doing this in WebCore level as opposed to relying on disk cache has big benefit that
4183 we avoid re-decoding resources, especially images.
4184
4185 To be exact the enabled case is not actually the "Specific end-to-end revalidation" since it does not include
4186 CacheControl: max-age=0 header. That would be added in reload case.
4187
4188 The approach for revalidation is to kick the original resource out from the memory cache
4189 and create a new CachedResource that represents the revalidation request. In case
4190 we get 304 back for the request we put the original resource back to the cache, update
4191 its expiration date and switch the clients registered to revalidation resource to be
4192 clients of the original resource.
4193
4194 All heap allocated CachedImage pointers now use CachedResourceHandle<CachedImage> (and so on) instead.
4195 This allows updating the handles to point to the original resource when the revalidation succeeds. It
4196 also acts as refcounting smart pointer.
4197
4198 * WebCore.pro:
4199 * WebCore.vcproj/WebCore.vcproj:
4200 * WebCore.xcodeproj/project.pbxproj:
4201 * css/CSSFontFaceSource.h:
4202 * css/CSSImportRule.h:
4203 * dom/Clipboard.h:
4204 (WebCore::Clipboard::dragImage):
4205 * dom/ProcessingInstruction.h:
4206 * dom/ScriptElement.h:
4207 * dom/XMLTokenizer.cpp:
4208 (WebCore::XMLTokenizer::isWaitingForScripts):
4209 * dom/XMLTokenizer.h:
4210 * html/HTMLImageLoader.cpp:
4211 (WebCore::HTMLImageLoader::setImage):
4212 (WebCore::HTMLImageLoader::updateFromElement):
4213 (WebCore::HTMLImageLoader::notifyFinished):
4214 * html/HTMLImageLoader.h:
4215 (WebCore::HTMLImageLoader::image):
4216 * html/HTMLLinkElement.h:
4217 * html/HTMLTokenizer.cpp:
4218 (WebCore::HTMLTokenizer::reset):
4219 (WebCore::HTMLTokenizer::scriptHandler):
4220 (WebCore::HTMLTokenizer::notifyFinished):
4221 * html/HTMLTokenizer.h:
4222 * loader/Cache.cpp:
4223 (WebCore::Cache::revalidateResource):
4224 (WebCore::Cache::revalidationSucceeded):
4225 (WebCore::Cache::revalidationFailed):
4226 * loader/Cache.h:
4227 * loader/CachedResource.cpp:
4228 (WebCore::CachedResource::CachedResource):
4229 (WebCore::CachedResource::~CachedResource):
4230 (WebCore::CachedResource::isExpired):
4231 (WebCore::CachedResource::setResponse):
4232 (WebCore::CachedResource::deleteIfPossible):
4233 (WebCore::CachedResource::setResourceToRevalidate):
4234 (WebCore::CachedResource::clearResourceToRevalidate):
4235 (WebCore::CachedResource::switchClientsToRevalidatedResource):
4236 (WebCore::CachedResource::canUseCacheValidator):
4237 (WebCore::CachedResource::mustRevalidate):
4238 * loader/CachedResource.h:
4239 (WebCore::CachedResource::canDelete):
4240 (WebCore::CachedResource::registerHandle):
4241 (WebCore::CachedResource::unregisterHandle):
4242 (WebCore::CachedResource::isCacheValidator):
4243 (WebCore::CachedResource::resourceToRevalidate):
4244 (WebCore::CachedResource::setExpirationDate):
4245 * loader/CachedResourceHandle.cpp: Added.
4246 (WebCore::CachedResourceHandleBase::setResource):
4247 * loader/CachedResourceHandle.h: Added.
4248 (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
4249 (WebCore::CachedResourceHandleBase::get):
4250 (WebCore::CachedResourceHandleBase::operator!):
4251 (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
4252 (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
4253 (WebCore::CachedResourceHandleBase::operator=):
4254 (WebCore::CachedResourceHandle::CachedResourceHandle):
4255 (WebCore::CachedResourceHandle::get):
4256 (WebCore::CachedResourceHandle::operator->):
4257 (WebCore::CachedResourceHandle::operator=):
4258 (WebCore::CachedResourceHandle::operator==):
4259 (WebCore::CachedResourceHandle::operator!=):
4260 (WebCore::operator==):
4261 (WebCore::operator!=):
4262 * loader/DocLoader.cpp:
4263 (WebCore::DocLoader::checkForReload):
4264 * loader/UserStyleSheetLoader.h:
4265 * loader/loader.cpp:
4266 (WebCore::Loader::Host::servePendingRequests):
4267 (WebCore::Loader::Host::didFinishLoading):
4268 (WebCore::Loader::Host::didFail):
4269 (WebCore::Loader::Host::didReceiveResponse):
4270 (WebCore::Loader::Host::didReceiveData):
4271 * page/EventHandler.cpp:
4272 (WebCore::EventHandler::selectCursor):
4273 * rendering/RenderImage.cpp:
4274 (WebCore::RenderImage::setCachedImage):
4275 (WebCore::RenderImage::imageChanged):
4276 * rendering/RenderImage.h:
4277 (WebCore::RenderImage::cachedImage):
4278 (WebCore::RenderImage::imagePtr):
4279 * rendering/style/RenderStyle.h:
4280 * rendering/style/StyleCachedImage.h:
4281 (WebCore::StyleCachedImage::data):
4282 (WebCore::StyleCachedImage::cachedImage):
4283 * svg/SVGFEImageElement.h:
4284 * svg/graphics/filters/SVGFEImage.h:
4285 * xml/XSLImportRule.h:
4286
beidson@apple.comab60d982008-09-05 04:58:12 +000042872008-09-04 Brady Eidson <beidson@apple.com>
4288
4289 Reviewed by Mitz
4290
4291 <rdar://problem/6180236> - Safari times out connections after 1 or 2 minutes
4292
4293 A 60-second default timeout was added in http://trac.webkit.org/changeset/17144 in an attempt
4294 to model default NSURLRequest behavior in a cross-platform manner.
4295
4296 Sadly by always enforcing this 60 second timeout, WebCore was stomping over the wishes of any Webkit
4297 client that wished to enforce a much larger default timeout using NSURLRequest API.
4298
4299 Additionally, upon reviewing what all other browsers do, it seems apparent that "no limit" is desirable
4300 behavior on the web and this restores previous Safari/WebKit behavior.
4301
4302 It would be easy to write a layout test for this, but to be effective it would have
4303 to run for at least 61 seconds, which seems insane until will can parallelize run-webkit-tests
4304
4305 * manual-tests/timeout-test.html: Added.
4306 * manual-tests/timeout-test.php: Added.
4307
4308 * platform/network/ResourceRequestBase.h:
4309 (WebCore::ResourceRequestBase::ResourceRequestBase): Rename the constant to "unspecifiedTimeoutInterval"
4310 and make it UINT_MAX so platforms that do set it have an effective "no timeout." (Windows, for example)
4311 * platform/network/mac/ResourceRequestMac.mm:
4312 (WebCore::ResourceRequest::doUpdatePlatformRequest): If the timeout for this request is
4313 "unspecifiedTimeoutInterval", then don't bother setting the timeout using NSURLRequest API, allowing
4314 WebKit applications to enforce their own default timeout.
4315
mitz@apple.com20268542008-09-05 04:26:32 +000043162008-09-04 Dan Bernstein <mitz@apple.com>
4317
4318 Reviewed by Beth Dakin.
4319
4320 - fix <rdar://problem/6198514> Changing a button's opacity triggers relayout
4321
4322 Test: fast/repaint/button-spurious-layout-hint.html
4323
4324 * rendering/RenderButton.cpp:
4325 (WebCore::RenderButton::setStyle): Reset the inner block's style box
4326 flex to 0 to avoid getting a spurious layout hint.
4327
kevino@webkit.org3e8c4072008-09-04 23:53:04 +000043282008-09-04 Kevin Ollivier <kevino@theolliviers.com>
4329
4330 wx build fixes.
4331
4332 * WebCoreSources.bkl:
4333 * bindings/js/ScriptControllerWx.cpp: Added.
4334 (WebCore::ScriptController::createScriptInstanceForWidget):
4335 * page/wx/AccessibilityObjectWx.cpp: Added.
4336 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
4337 * platform/graphics/wx/GraphicsContextWx.cpp:
4338 * webcore-base.bkl:
4339 * webcore-wx.bkl:
4340
mitz@apple.com95a87502008-09-04 23:27:19 +000043412008-09-04 Dan Bernstein <mitz@apple.com>
4342
4343 Reviewed by Mark Rowe.
4344
4345 - roll out r36050 because it made svg/custom/invalid-fill-hex.svg fail,
4346 and fixing https://bugs.webkit.org/show_bug.cgi?id=15360 appears to
4347 require a different approach
4348
4349 * css/CSSGrammar.y:
4350
mrowe@apple.com12b7c2d2008-09-04 21:00:02 +000043512008-09-04 Mark Rowe <mrowe@apple.com>
4352
mrowe@apple.com5bc4ea82008-09-04 21:44:28 +00004353 Reviewed by Eric Seidel.
4354
4355 Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
4356 Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
4357
4358 * Configurations/WebCore.xcconfig: Remove ENABLE_DASHBOARD_SUPPORT from FEATURE_DEFINES.
4359 * DerivedSources.make: Revert to checking for ENABLE_DASHBOARD_SUPPORT rather than looking
4360 for ENABLE_DASHBOARD_SUPPORT in FEATURE_DEFINES.
4361
43622008-09-04 Mark Rowe <mrowe@apple.com>
4363
mrowe@apple.com12b7c2d2008-09-04 21:00:02 +00004364 Mac build fix.
4365
4366 * config.h: Only check the value of HAVE_CONFIG_H if it is defined.
4367
eric@webkit.org0716a542008-09-04 20:44:12 +000043682008-09-04 Eric Seidel <eric@webkit.org>
4369
4370 Build fix only, no review.
4371
4372 * dom/XMLTokenizer.cpp: Fix the Chromium merge build by adding a missing header (the Mac files must include it somewhere).
4373
jmalonzo@webkit.org6afc5d42008-09-04 20:26:16 +000043742008-09-04 Marco Barisione <marco.barisione@collabora.co.uk>
4375
4376 Reviewed by Eric Seidel.
4377
4378 http://bugs.webkit.org/show_bug.cgi?id=20380
4379 [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h
4380
4381 * config.h: Include the configuration header generated by autotools if
4382 available.
4383
mitz@apple.com9d7e4262008-09-04 18:15:25 +000043842008-09-04 Dan Bernstein <mitz@apple.com>
4385
4386 Rubber-stamped by Dave Hyatt.
4387
4388 - rename CachedResource::allReferencesRemoved() to allClientsRemoved()
4389
4390 * loader/CachedFont.cpp:
4391 (WebCore::CachedFont::allClientsRemoved):
4392 * loader/CachedFont.h:
4393 * loader/CachedImage.cpp:
4394 (WebCore::CachedImage::allClientsRemoved):
4395 * loader/CachedImage.h:
4396 * loader/CachedResource.cpp:
4397 (WebCore::CachedResource::removeClient):
4398 * loader/CachedResource.h:
4399 (WebCore::CachedResource::allClientsRemoved):
4400
aroben@apple.com0da404d2008-09-04 16:09:33 +000044012008-09-04 Adam Roben <aroben@apple.com>
4402
aroben@apple.comdd3861a2008-09-04 16:09:53 +00004403 Windows build fix after r36071
4404
4405 We were getting these errors:
4406
4407 error C2356: initialization segment must not change during translation
4408 unit
4409
4410 This was happening because multiple files #included by
4411 DerivedSources.cpp were themselves #including StaticConstructors.h. I
4412 fixed the error by adding header guards to StaticConstructors.h so its
4413 contents will only be included once.
4414
4415 But it's also not a good idea for StaticConstructors.h to end up in
4416 DerivedSources.cpp, since it ends up "polluting" all the source files
4417 we have in there. So I removed all the files that include
4418 StaticConstructors.h and added some preprocessor directives to
4419 DerivedSources.cpp to catch this error in the future.
4420
4421 * DerivedSources.cpp: Removed the *Names.cpp files, which include
4422 StaticConstructors.h, and added some preprocessor directives to make
4423 sure we don't end up accidentally including StaticConstructors.h in
4424 the future.
4425 * WebCore.vcproj/WebCore.vcproj: Added the *Names.cpp files.
4426 * platform/StaticConstructors.h: Added header guards.
4427
44282008-09-04 Adam Roben <aroben@apple.com>
4429
aroben@apple.com0da404d2008-09-04 16:09:33 +00004430 Windows build fix
4431
4432 * platform/graphics/win/FontPlatformData.h: Added a missing #include
4433 of PassRefPtr.h, and corrected the capitalization of RefCounted.h.
4434 * platform/text/PlatformString.h: Added a missing #include of
4435 PassRefPtr.h.
4436
vestbo@webkit.orgc0aeddf2008-09-04 11:44:17 +000044372008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
4438
4439 Reviewed by Simon.
4440
vestbo@webkit.orgb82da912008-09-04 14:24:58 +00004441 Fix the QtWebKit build to match changes in r36016
4442
4443 * WebCore.pro:
4444 * bridge/qt/qt_instance.cpp:
4445 (KJS::Bindings::QtInstance::getRuntimeObject):
4446 * bridge/qt/qt_runtime.cpp:
4447 (KJS::Bindings::convertQVariantToValue):
4448 (KJS::Bindings::QtConnectionObject::execute):
4449
44502008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
4451
4452 Reviewed by Simon.
4453
vestbo@webkit.orgc0aeddf2008-09-04 11:44:17 +00004454 Re-enable support for user stylesheets in QtWebKit
4455
4456 QtWebKit now follows the FRAME_LOADS_USER_STYLESHEET
4457 code path, which allows us to keep API support for
4458 loading user style sheets from remote URLs.
4459
4460 As part of the change UserStyleSheetLoader.cpp/h was
4461 moved from WebCore/loader/mac to WebCore/loader.
4462
4463 * WebCore.pro:
4464 * WebCore.xcodeproj/project.pbxproj:
4465 * dom/Document.h:
4466 * loader/UserStyleSheetLoader.cpp: Renamed from WebCore/loader/mac/UserStyleSheetLoader.cpp.
4467 (UserStyleSheetLoader::UserStyleSheetLoader):
4468 (UserStyleSheetLoader::~UserStyleSheetLoader):
4469 * loader/UserStyleSheetLoader.h: Renamed from WebCore/loader/mac/UserStyleSheetLoader.h.
4470 * page/qt/FrameQt.cpp:
4471 (WebCore::Frame::setUserStyleSheetLocation):
4472 (WebCore::Frame::setUserStyleSheet):
4473
alp@webkit.org539ff852008-09-04 09:14:42 +000044742008-09-04 Alp Toker <alp@nuanti.com>
4475
4476 Reviewed by Eric.
4477
4478 Remove left-over QT and CAIRO platform checks.
4479
4480 * html/CanvasRenderingContext2D.cpp:
4481
eric@webkit.orgbc0aab82008-09-04 08:39:51 +000044822008-09-04 Eric Seidel <eric@webkit.org>
4483
4484 Reviewed by Mark Rowe.
4485
mitz@apple.com9388d252008-09-04 08:58:58 +00004486 Fix leak of TextMetrics due to over-ref as see on buildbot.
eric@webkit.orgbc0aab82008-09-04 08:39:51 +00004487
4488 * html/TextMetrics.h: use adoptRef since RefCounted starts @ refcount 1 instead of 0 now.
4489
mitz@apple.com89557c52008-09-04 07:26:53 +000044902008-09-04 Dan Bernstein <mitz@apple.com>
4491
4492 Reviewed by Dave Hyatt.
4493
4494 - fix https://bugs.webkit.org/show_bug.cgi?id=19717
4495 <rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist
4496
4497 * rendering/RenderBlock.cpp:
4498 (WebCore::RenderBlock::layoutOnlyPositionedObjects): In the
4499 positioned movement only case, call
4500 tryLayoutDoingPositionedMovementOnly() and fall back on doing a full
4501 layout if that fails.
4502 (WebCore::RenderBlock::layoutPositionedObjects): Ditto.
4503 * rendering/RenderBox.h:
4504 (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): Renamed
4505 layoutDoingPositionedMovementOnly to this, and made this function
4506 check if the width changed. If it did, return, leaving the object
4507 dirty. The caller can then call layout(). The width can change even
4508 in the "positioned movement only" case if the object is shrink-to-fit
4509 and the available width constraint is met. (This was the case in the
4510 bug).
4511 * rendering/RenderObject.h:
4512 (WebCore::RenderObject::tryLayoutDoingPositionedMovementOnly):
4513 Renamed layoutDoingPositionedMovementOnly() to this.
4514
eric@webkit.org8883b4a2008-09-04 06:31:37 +000045152008-09-03 Eric Seidel <eric@webkit.org>
4516
4517 No review, build fix only.
4518
4519 Attempt to fix the Qt build.
4520
4521 * WebCore.pro: add page/animation to include path
4522
mrowe@apple.comaa4bb8d2008-09-04 03:20:30 +000045232008-09-03 Mark Rowe <mrowe@apple.com>
4524
4525 Mac build fix. Correctly detect whether dashboard support is enabled.
4526
4527 * DerivedSources.make:
4528
eric@webkit.org3eefe672008-09-04 01:32:26 +000045292008-09-03 Eric Seidel <eric@webkit.org>
4530
4531 Reviewed by Sam.
4532
eric@webkit.org5e069092008-09-04 01:32:51 +00004533 Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)
4534
4535 * Configurations/WebCore.xcconfig: add missing ENABLE_*
4536 * config.h: add rules for V8_BINDINGS
4537
45382008-09-03 Eric Seidel <eric@webkit.org>
4539
4540 Reviewed by Sam.
4541
eric@webkit.org3eefe672008-09-04 01:32:26 +00004542 https://bugs.webkit.org/show_bug.cgi?id=20620
4543
4544 Add #if USE(JSC) around KJS dependencies
4545 Remove !USE(JAVASCRIPTCORE_BINDINGS) support for 3 reasons:
4546 1. Most platforms have it on anyway
4547 2. V8 is going to want to share some of that code
4548 3. Those platforms which want it off, should have a separate file instead of an #ifdef in our .cpp
4549
4550 * bindings/js/JSPluginElementFunctions.cpp: remove !USE(JAVASCRIPTCORE_BINDINGS) support
4551 * config.h: change JAVASCRIPTCORE_BINDINGS to JSC and add USE(V8)
4552 * html/HTMLAppletElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
4553 * html/HTMLAppletElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
4554 * html/HTMLEmbedElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
4555 * html/HTMLEmbedElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
4556 * html/HTMLObjectElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
4557 * html/HTMLObjectElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
4558 * html/HTMLPlugInElement.cpp: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
4559 * html/HTMLPlugInElement.h: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
4560 * platform/text/AtomicString.cpp: add USE(JSC)
4561 * platform/text/AtomicString.h: add USE(JSC)
4562 * platform/text/PlatformString.h: add USE(JSC)
4563 * platform/text/String.cpp: add USE(JSC)
4564 * platform/text/StringImpl.cpp: add USE(JSC)
4565 * platform/text/StringImpl.h: add USE(JSC)
4566
mrowe@apple.comfbe724c2008-09-03 23:46:54 +000045672008-09-03 Dean McNamee <deanm@chromium.org>
4568
4569 Reviewed by Darin Adler.
4570
4571 Fix https://bugs.webkit.org/show_bug.cgi?id=20511
4572 Bug 20511: Remove static initializers on Windows
4573
4574 Avoid static initializers on Windows by forcing Visual C++ to put
4575 all static initializers in a code segment that is never executed.
4576
4577 * config.h:
4578 * css/MediaFeatureNames.cpp:
4579 * dom/EventNames.cpp:
4580 * dom/QualifiedName.cpp:
4581 * dom/make_names.pl:
4582 * platform/StaticConstructors.h:
4583 * platform/text/AtomicString.cpp:
4584
mrowe@apple.com3aa63182008-09-03 23:40:49 +000045852008-09-03 Dirk Schulze <vbs85@gmx.de>
4586
4587 Reviewed by Dave Hyatt.
4588
4589 Make FontCairo draw TextStroke and TextFill separately.
4590
4591 [CAIRO] draw TextFill and TextStroke separately.
4592 [https://bugs.webkit.org/show_bug.cgi?id=20631]
4593
4594 * platform/graphics/cairo/FontCairo.cpp:
4595 (WebCore::Font::drawGlyphs):
4596
eric@webkit.org4ac94e62008-09-18 23:07:55 +000045972008-09-03 Peter Kasting <pkasting@google.com>
mrowe@apple.comdcd72b72008-09-03 23:34:40 +00004598
4599 Reviewed by Dave Hyatt.
4600
4601 https://bugs.webkit.org/show_bug.cgi?id=19663
4602 Account for paint and timer lag when animating images. Also pretend
4603 that images whose animations were paused (by becoming invisible)
4604 continued to animate, by "catching up" to the correct frame when they're
4605 shown again.
4606
4607 * platform/graphics/BitmapImage.cpp:
4608 (WebCore::BitmapImage::BitmapImage):
4609 (WebCore::BitmapImage::startAnimation):
4610 (WebCore::BitmapImage::advanceAnimation):
4611 (WebCore::BitmapImage::internalAdvanceAnimation):
4612 (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
4613 * platform/graphics/BitmapImage.h:
4614 * platform/graphics/cairo/ImageCairo.cpp:
4615 (WebCore::BitmapImage::draw):
4616 * platform/graphics/cg/ImageCG.cpp:
4617 (WebCore::BitmapImage::draw):
4618 * platform/graphics/qt/ImageQt.cpp:
4619 (WebCore::BitmapImage::draw):
4620 * platform/graphics/wx/ImageWx.cpp:
4621 (WebCore::BitmapImage::draw):
4622
kmccullough@apple.comb0f4c622008-09-03 21:53:17 +000046232008-09-03 Kevin McCullough <kmccullough@apple.com>
4624
4625 Reviewed by Tim.
4626
4627 Remove the rest of the "zombie" code from the profiler.
4628 - There is no longer a need for the ProfilerClient callback mechanism.
4629
4630 * page/Console.cpp:
4631 (WebCore::Console::Console):
4632 (WebCore::Console::profile):
4633 (WebCore::Console::profileEnd): Move the variables from the header to
4634 here since we don't have to wait for a callback to use them.
4635 * page/Console.h:
4636 * page/InspectorController.cpp:
4637 (WebCore::InspectorController::startUserInitiatedProfiling):
4638 (WebCore::InspectorController::stopUserInitiatedProfiling):
4639 * page/InspectorController.h:
4640
adachan@apple.com38c66182008-09-03 21:43:44 +000046412008-09-03 Ada Chan <adachan@apple.com>
4642
4643 Windows build fix.
4644
4645 * WebCore.vcproj/WebCore.vcproj: Added JSWebKitCSSKeyframeRule.cpp and JSWebKitCSSKeyframesRule.cpp to the project.
4646
dino@apple.com5c917622008-09-03 21:15:53 +000046472008-09-01 Dean Jackson <dino@apple.com>
4648
4649 Reviewed by Dave Hyatt.
4650
4651 https://bugs.webkit.org/show_bug.cgi?id=20594
4652 Add DOM interfaces for WebKitCSSKeyframeRule
4653 and WebKitCSSKeyframesRule.
4654
4655 TEST: LayoutTests/css3/keyframes-rule.html
4656
4657 * css/WebKitCSSKeyframeRule.idl: Added
4658 * css/WebKitCSSKeyframesRule.idl: Added
4659
4660 * bindings/js/JSCSSRuleCustom.cpp:
4661 (WebCore::toJS):
4662 Add return of new JS Keyframe rules
4663 * bindings/objc/DOMInternal.h:
4664 Include new internal header
4665
4666 * DerivedSources.make:
4667 * GNUmakefile.am:
4668 * WebCore.pro:
4669 * WebCore.vcproj/WebCore.vcproj:
4670 * WebCore.xcodeproj/project.pbxproj:
4671 * WebCoreSources.bkl:
4672 Build configs for new files
4673
aroben@apple.com1f51bfa2008-09-03 20:30:59 +000046742008-09-03 Adam Roben <aroben@apple.com>
4675
4676 Windows build fix
4677
4678 * DerivedSources.cpp: Add JSTextMetrics.cpp to fix the build.
4679 * WebCore.vcproj/WebCore.vcproj: Add JSTextMetrics.h for
4680 convenience/consistency.
4681
adele@apple.com27713582008-09-03 20:13:41 +000046822008-09-03 Adele Peterson <adele@apple.com>
4683
4684 Build fix.
4685
4686 * WebCore.vcproj/WebCore.vcproj:
4687
hyatt@apple.com4b38ed82008-09-03 18:32:05 +000046882008-09-03 David Hyatt <hyatt@apple.com>
4689
4690 Fix for bug 18203, right floats should be allowed to overflow past the left border edge.
4691
4692 Reviewed by Darin (ages ago)
4693
4694 Added fast/block/float/clamped-right-float.html
4695
4696 * rendering/RenderBlock.cpp:
4697 (WebCore::RenderBlock::positionNewFloats):
4698
hyatt@apple.comafe62052008-09-03 18:13:39 +000046992008-09-02 David Hyatt <hyatt@apple.com>
4700
4701 Add support for canvas text drawing APIs.
4702
4703 Reviewed by olliej
4704
4705 Tests added as fast/canvas/canvas-text-*.html
4706
4707 * DerivedSources.make:
4708 * WebCore.xcodeproj/project.pbxproj:
4709 * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
4710 (WebCore::JSCanvasRenderingContext2D::fillText):
4711 (WebCore::JSCanvasRenderingContext2D::strokeText):
4712 * css/CSSStyleSelector.cpp:
4713 (WebCore::CSSStyleSelector::initForStyleResolve):
4714 (WebCore::CSSStyleSelector::applyPropertyToStyle):
4715 * css/CSSStyleSelector.h:
4716 * html/CanvasRenderingContext2D.cpp:
4717 (WebCore::CanvasRenderingContext2D::State::State):
4718 (WebCore::CanvasRenderingContext2D::font):
4719 (WebCore::CanvasRenderingContext2D::setFont):
4720 (WebCore::CanvasRenderingContext2D::textAlign):
4721 (WebCore::CanvasRenderingContext2D::setTextAlign):
4722 (WebCore::CanvasRenderingContext2D::textBaseline):
4723 (WebCore::CanvasRenderingContext2D::setTextBaseline):
4724 (WebCore::CanvasRenderingContext2D::fillText):
4725 (WebCore::CanvasRenderingContext2D::strokeText):
4726 (WebCore::CanvasRenderingContext2D::measureText):
4727 (WebCore::CanvasRenderingContext2D::drawTextInternal):
4728 (WebCore::CanvasRenderingContext2D::accessFont):
4729 * html/CanvasRenderingContext2D.h:
4730 * html/CanvasRenderingContext2D.idl:
4731 * html/TextMetrics.h: Added.
4732 (WebCore::TextMetrics::create):
4733 (WebCore::TextMetrics::width):
4734 (WebCore::TextMetrics::setWidth):
4735 (WebCore::TextMetrics::TextMetrics):
4736 * html/TextMetrics.idl: Added.
4737 * platform/graphics/Font.cpp:
4738 (WebCore::Font::lineGap):
4739 * platform/graphics/Font.h:
4740 * platform/graphics/GraphicsContext.cpp:
4741 (WebCore::GraphicsContext::drawBidiText):
4742 * platform/graphics/GraphicsContext.h:
4743 * platform/graphics/GraphicsTypes.cpp:
4744 (WebCore::textAlignName):
4745 (WebCore::parseTextAlign):
4746 (WebCore::textBaselineName):
4747 (WebCore::parseTextBaseline):
4748 * platform/graphics/GraphicsTypes.h:
4749 (WebCore::):
4750
sullivan@apple.combc066af2008-09-03 17:37:24 +000047512008-09-03 John Sullivan <sullivan@apple.com>
4752
4753 Fixed <rdar://problem/6193022> <rdar://problem/6193022> Crash occurs at WebCore::AnimationBase::propertiesEqual () after certain steps
4754
4755 Fixed by Darin, reviewed by me
4756
4757 * page/animation/AnimationBase.cpp:
4758 (WebCore::AnimationBase::propertiesEqual):
4759 added ensurePropertyMap() to this static function
4760 (WebCore::AnimationBase::getPropertyAtIndex):
4761 ditto
4762 (WebCore::AnimationBase::getNumProperties):
4763 ditto
4764
kmccullough@apple.com70168ee2008-09-03 17:35:42 +000047652008-09-03 Kevin McCullough <kmccullough@apple.com>
4766
4767 Reviewed by Darin and Tim.
4768
4769 Remove most of the "zombie" mode from the profiler. Next we will need
4770 to remove the client callback mechanism in profiles.
4771 - These changes are a result of changes to JSCore.
4772
4773 * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html:
4774 * page/Console.cpp:
4775 (WebCore::retrieveLastCaller):
4776 (WebCore::Console::profileEnd):
4777 * page/InspectorController.cpp:
4778 (WebCore::InspectorController::stopUserInitiatedProfiling):
4779
adele@apple.com643616b2008-09-03 16:57:58 +000047802008-09-03 Adele Peterson <adele@apple.com>
4781
4782 Reviewed by Darin Adler.
4783
4784 Test: fast/forms/search-display-none-cancel-button.html
4785
4786 Allow display:none to work on a search field's cancel button. Prepare for adding more style-ability for the results button too.
4787
4788 * css/html4.css: Set display:inline-block for these buttons. Now they can be overridden by a web author.
4789
4790 * rendering/RenderTextControl.cpp:
4791 (WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers.
4792 (WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly. This is now done in html4.css.
4793 (WebCore::RenderTextControl::createCancelButtonStyle): ditto.
4794 (WebCore::RenderTextControl::createSubtreeIfNeeded):
4795 Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class.
4796 (WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers.
4797 (WebCore::RenderTextControl::subtreeHasChanged): ditto.
4798 (WebCore::RenderTextControl::calcHeight): ditto.
4799 (WebCore::RenderTextControl::nodeAtPoint): ditto.
4800 (WebCore::RenderTextControl::layout): ditto.
4801 (WebCore::RenderTextControl::calcPrefWidths): ditto.
4802 (WebCore::RenderTextControl::clientPaddingLeft): ditto.
4803 (WebCore::RenderTextControl::clientPaddingRight): ditto.
4804
4805 * rendering/TextControlInnerElements.cpp:
4806 (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp.
4807 (WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto.
4808 (WebCore::TextControlInnerElement::attachInnerElement): Added.
4809 This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element.
4810 (WebCore::TextControlInnerTextElement::createRenderer): Added. Creates a RenderTextControlInnerBlock.
4811 * rendering/TextControlInnerElements.h:
4812
ap@webkit.orgacd84142008-09-03 08:08:19 +000048132008-08-28 Alexey Proskuryakov <ap@webkit.org>
4814
4815 Reviewed by Maciej.
4816
4817 Elminate SQLiteAuthorizer class.
4818
4819 * WebCore.xcodeproj/project.pbxproj:
4820 * WebCore.vcproj/WebCore.vcproj:
4821 * GNUmakefile.am
4822 Removed SQLiteAuthorizer.h.
4823
4824 * platform/sql/SQLiteAuthorizer.cpp:
4825 * platform/sql/SQLiteAuthorizer.h: Removed.
4826 * platform/sql/SQLiteDatabase.cpp:
4827 (WebCore::SQLiteDatabase::authorizerFunction):
4828 (WebCore::SQLiteDatabase::setAuthorizer):
4829 * platform/sql/SQLiteDatabase.h:
4830 * storage/DatabaseAuthorizer.h:
4831 (WebCore::DatabaseAuthorizer::create):
4832 (WebCore::DatabaseAuthorizer::createView):
4833 (WebCore::DatabaseAuthorizer::createTempView):
4834 (WebCore::DatabaseAuthorizer::dropView):
4835 (WebCore::DatabaseAuthorizer::dropTempView):
4836 (WebCore::DatabaseAuthorizer::allowSelect):
4837 (WebCore::DatabaseAuthorizer::allowReindex):
4838 Merge SQLiteAuthorizer and DatabaseAuthorizer, as keeping them separate serves no purpose.
4839
mrowe@apple.com2ecd4862008-09-03 07:05:48 +000048402008-09-03 Dirk Schulze <vbs85@gmx.de>
4841
4842 Reviewed by Mark Rowe.
4843
4844 WebKitGtk build fix.
4845
4846 * GNUmakefile.am:
4847 * page/animation/AnimationController.h:
4848
mrowe@apple.come344ad02008-09-03 06:59:03 +000048492008-09-02 Robert Blaut <webkit@blaut.biz>
4850
4851 Reviewed by Geoff Garen.
4852
4853 Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913>
4854 Misplaced elements should not close DL lists.
4855
4856 Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html
4857
4858 * html/HTMLParser.cpp:
4859 (WebCore::HTMLParser::handleError):
4860
mrowe@apple.com7a909462008-09-03 06:51:31 +000048612008-09-02 Glenn Wilson <wilsong@gmail.com>
4862
4863 Reviewed by Darin Adler.
4864
4865 Fix for <https://bugs.webkit.org/show_bug.cgi?id=15360>
4866 Bug 15360: color:#{predefined colorName} is treated as colorName in Safari
4867
4868 We would inappropriately interpret and apply an invalid CSS "color" property
4869 when the value is a predefined color preceded by a '#' symbol. For example,
4870 style="color:#gray;" would apply the color gray when it should not.
4871
4872 In the bison template, "hexcolor" was defined as both "HEX maybe_space" OR "IDENT maybe_space".
4873 This caused identifiers not fitting the appropriate hex format but preceded by a '#' to be
4874 interpreted as a valid color (CSSPrimitiveValue::CSS_PARSER_HEXCOLOR), when it was really just
4875 an ignorable token.
4876
4877 To correct this, "IDENT maybe_space" was removed from "hexcolor" and added under "term" as
4878 '#' IDENT maybe_space, which is then processed as a CSSPrimitiveValue::CSS_STRING instead of
4879 CSSPrimitiveValue::CSS_PARSER_HEXCOLOR.
4880
4881 Test: css1/color_and_background/invalid_color.html
4882
4883 * css/CSSGrammar.y:
4884
mrowe@apple.comda9a1442008-09-03 06:22:12 +000048852008-09-02 Mihnea Ovidenie <mihnea@adobe.com>
4886
4887 Reviewed by Darin Adler.
4888
4889 Fix for https://bugs.webkit.org/show_bug.cgi?id=19964
4890 Bug 19964: Divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image
4891
4892 Add a check to RenderBox::repaintLayerRectsForImage to make sure the current layer image can be rendered.
4893
4894 Test: css3/khtml-background-size-0x0-bmp.html
4895
4896 * rendering/RenderBox.cpp:
4897 (WebCore::RenderBox::repaintLayerRectsForImage):
4898
mrowe@apple.com6625ae52008-09-03 06:12:30 +000048992008-09-02 Glenn Wilson <wilsong@gmail.com>
4900
4901 Reviewed by Eric Seidel.
4902
4903 Fix https://bugs.webkit.org/show_bug.cgi?id=20397
4904 Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash
4905
4906 The function checkForOrphanedUnits() would change the length of a list whose size was
4907 was already determined before the call to checkForOrphanedUnits was made. Later in
4908 the caller, the old size was being used for boundary management.
4909
4910 This has been fixed by moving the call to checkForOrphanedUnits() earlier in the
4911 calling function, before the size of the list is determined.
4912
4913 Test: fast/css/orphaned_units_crash.html
4914
4915 * css/CSSParser.cpp:
4916 (WebCore::CSSParser::parseValue): Moved call to checkForOrphanedUnits() earlier in the function.
4917
mrowe@apple.com170bd522008-09-03 05:49:51 +000049182008-09-02 Dirk Schulze <vbs85@gmx.de>
4919
4920 Reviewed by Darin Adler.
4921
mrowe@apple.comeb877a52008-09-03 06:01:15 +00004922 Fallback on invalid fill or stroke styles in Canvas was
4923 transparent black. Changed it to last valid style.
4924
4925 Canvas fillStyle() and strokeStyle() needs fallback
4926 https://bugs.webkit.org/show_bug.cgi?id=20474
4927
4928 Tests: fast/canvas/canvas-invalid-fillstyle.html
4929 fast/canvas/canvas-invalid-strokestyle.html
4930
4931 * html/CanvasStyle.cpp:
4932 (WebCore::CanvasStyle::applyStrokeColor):
4933 (WebCore::CanvasStyle::applyFillColor):
4934
49352008-09-02 Dirk Schulze <vbs85@gmx.de>
4936
4937 Reviewed by Darin Adler.
4938
mrowe@apple.com170bd522008-09-03 05:49:51 +00004939 Fix https://bugs.webkit.org/show_bug.cgi?id=20468
4940 Updated drawImage() in canvas to match the current specification.
4941
4942 Test: fast/canvas/drawImage-with-negative-source-destination.html
4943
4944 * html/CanvasRenderingContext2D.cpp:
4945 (WebCore::normalizeRect):
4946 (WebCore::CanvasRenderingContext2D::drawImage):
4947
mrowe@apple.com96916d12008-09-03 05:41:44 +000049482008-08-26 Mark Rowe <mrowe@apple.com>
4949
4950 Reviewed by Darin Adler.
4951
4952 <rdar://problem/5768210> Switch back to the system version of SQLite
4953
4954 Use the system version of SQLite when it is new enough to provide the functionality
4955 that WebCore requires.
4956
4957 * Configurations/Base.xcconfig:
4958 * Configurations/DebugRelease.xcconfig:
4959 * Configurations/WebCore.xcconfig:
4960
mitz@apple.comce268c12008-09-03 02:59:00 +000049612008-09-02 Dan Bernstein <mitz@apple.com>
4962
4963 - build fix
4964
4965 * page/animation/AnimationBase.h:
4966
dino@apple.com7e49a7a2008-09-03 01:32:14 +000049672008-09-02 Chris Marrin <cmarrin@apple.com>
4968
4969 Reviewed by Dave Hyatt.
4970
4971 AnimationController.cpp should be split into separate files
4972 https://bugs.webkit.org/show_bug.cgi?id=20604
4973
4974 Note: All makefiles, except WebCore.xcodeproj have been changed without testing, upon
4975 recommendation of Dave Hyatt.
4976
4977 * GNUmakefile.am:
4978 * WebCore.pro:
4979 * WebCore.vcproj/WebCore.vcproj:
4980 * WebCore.xcodeproj/project.pbxproj:
4981 * WebCoreSources.bkl:
4982 Build files.
4983
4984 * page/AnimationController.cpp: Removed.
4985 * page/AnimationController.h: Removed.
4986 * page/animation: Added.
4987 * page/animation/AnimationBase.cpp: Added.
4988 * page/animation/AnimationBase.h: Added.
4989 * page/animation/AnimationController.cpp: Copied from WebCore/page/AnimationController.cpp.
4990 * page/animation/AnimationController.h: Copied from WebCore/page/AnimationController.h.
4991 * page/animation/CompositeAnimation.cpp: Added.
4992 * page/animation/CompositeAnimation.h: Added.
4993 * page/animation/ImplicitAnimation.cpp: Added.
4994 * page/animation/ImplicitAnimation.h: Added.
4995 * page/animation/KeyframeAnimation.cpp: Added.
4996 * page/animation/KeyframeAnimation.h: Added.
4997
mitz@apple.comcb917a22008-09-03 00:57:37 +000049982008-09-02 Dan Bernstein <mitz@apple.com>
4999
5000 - release build fix
5001
5002 * platform/graphics/cg/GraphicsContextCG.cpp:
5003 (WebCore::calculateDrawingMode):
5004
timothy@apple.comf3aa7342008-09-02 21:30:26 +000050052008-09-02 Timothy Hatcher <timothy@apple.com>
5006
timothy@apple.comc33ff3c2008-09-02 21:35:02 +00005007 Make console functions log the correct resource URL and
5008 line number for where the call originated.
5009
5010 https://bugs.webkit.org/show_bug.cgi?id=17234
5011 <rdar://problem/5732837>
5012
5013 Reviewed by Kevin McCullough.
5014
5015 Test: manual-tests/inspector/console-call-line-numbers.html
5016
5017 * bindings/js/JSConsoleCustom.cpp:
5018 (WebCore::JSConsole::count): Call the impl.
5019 (WebCore::JSConsole::timeEnd): Ditto.
5020 * manual-tests/inspector/console-call-line-numbers.html: Added.
5021 * manual-tests/inspector/resources/script-console-calls.js: Added.
5022 * page/Console.cpp:
5023 (WebCore::retrieveLastCaller): Helper to get the URL and line.
5024 (WebCore::Console::error): Call retrieveLastCaller to get the URL and
5025 line number to pass to addMessageToConsole.
5026 (WebCore::Console::info): Ditto.
5027 (WebCore::Console::log): Ditto.
5028 (WebCore::Console::assertCondition): Ditto.
5029 (WebCore::Console::count): Ditto.
5030 (WebCore::Console::timeEnd): Ditto.
5031 (WebCore::Console::warn): Ditto.
5032 * page/Console.h:
5033 * page/Console.idl: Make count and timeEnd custom.
5034
50352008-09-02 Timothy Hatcher <timothy@apple.com>
5036
timothy@apple.comf3aa7342008-09-02 21:30:26 +00005037 Removed IDL files from WebCore's framework resources.
5038
5039 * WebCore.xcodeproj/project.pbxproj:
5040
mitz@apple.comfb6ad392008-09-02 20:39:29 +000050412008-09-02 Dan Bernstein <mitz@apple.com>
5042
5043 Reviewed by Dave Hyatt.
5044
5045 - <rdar://problem/5681647> pages at http://www.stendmarsofa.com/ are so slow to calculate style it seems like a hang
5046
5047 * html/HTMLParser.cpp:
5048 (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added a
5049 cap on the number of consecutive identical residual style tags to
5050 reopen.
5051 (WebCore::HTMLParser::popBlock): Ditto.
5052
ap@webkit.org879328b2008-09-02 16:16:06 +000050532008-09-02 Alexey Proskuryakov <ap@webkit.org>
5054
5055 Reviewed by Adam Roben.
5056
5057 A little database quota management cleanup.
5058
5059 * storage/OriginQuotaManager.cpp:
5060 (WebCore::OriginQuotaManager::OriginQuotaManager):
5061 (WebCore::OriginQuotaManager::lock):
5062 (WebCore::OriginQuotaManager::unlock):
5063 (WebCore::OriginQuotaManager::trackOrigin):
5064 (WebCore::OriginQuotaManager::tracksOrigin):
5065 (WebCore::OriginQuotaManager::addDatabase):
5066 (WebCore::OriginQuotaManager::removeDatabase):
5067 (WebCore::OriginQuotaManager::removeOrigin):
5068 (WebCore::OriginQuotaManager::markDatabase):
5069 (WebCore::OriginQuotaManager::diskUsage):
5070 * storage/OriginQuotaManager.h:
5071 Changed to assert that a lock is taken more directly and reliably. Removed comments about
5072 main/background threads, as this is likely to stop being true with synchronous Database calls
5073 being made on worker threads.
5074
5075 * storage/OriginUsageRecord.cpp:
5076 (WebCore::OriginUsageRecord::OriginUsageRecord):
5077 (WebCore::OriginUsageRecord::addDatabase):
5078 (WebCore::OriginUsageRecord::removeDatabase):
5079 (WebCore::OriginUsageRecord::markDatabase):
5080 (WebCore::OriginUsageRecord::diskUsage):
5081 * storage/OriginUsageRecord.h:
5082 (WebCore::OriginUsageRecord::DatabaseEntry::DatabaseEntry):
5083 Don't use a magic value for unknown. It is totally unnecessary for DatabaseEntry, and
5084 can be replaced with a single boolean for OriginUsageRecord.
5085 Added assertions for string parameters being unshared.
5086
5087
abarth@webkit.orgaea97a02008-09-02 04:26:15 +000050882008-09-01 Adam Barth <abarth@webkit.org>
5089
5090 Reviewed by Sam Weinig.
5091
5092 https://bugs.webkit.org/show_bug.cgi?id=19760
5093
5094 Make granting LoadLocalResources conditional on a policy.
5095
5096 * WebCore.base.exp:
5097 * dom/Document.cpp:
5098 (WebCore::Document::initSecurityContext):
5099 * loader/FrameLoader.cpp:
5100 (WebCore::FrameLoader::setLocalLoadPolicy):
5101 (WebCore::FrameLoader::restrictAccessToLocal):
5102 * loader/FrameLoader.h:
5103 (WebCore::FrameLoader::):
5104 * platform/SecurityOrigin.cpp:
5105 (WebCore::SecurityOrigin::grantLoadLocalResources):
5106 * platform/SecurityOrigin.h:
5107
dino@apple.com6e2db502008-09-01 23:05:28 +000051082008-09-01 Dean Jackson <dino@apple.com>
5109
dino@apple.com59ca9f52008-09-01 23:34:13 +00005110 Reviewed by Sam Weinig.
5111
5112 https://bugs.webkit.org/show_bug.cgi?id=20571
5113 Make sure Window object can assign Animation/Transition event
5114 listeners via attributes.
5115
5116 Also added a bunch of transition event tests, although
5117 only transition-end-event-window is directly relevant to this patch.
5118
5119 (WebCore::JSDOMWindowBase::put):
5120
5121 Tests: transitions/transition-end-event-all-properties.html
5122 transitions/transition-end-event-attributes.html
5123 transitions/transition-end-event-container.html
5124 transitions/transition-end-event-left.html
5125 transitions/transition-end-event-multiple-01.html
5126 transitions/transition-end-event-multiple-02.html
5127 transitions/transition-end-event-multiple-03.html
5128 transitions/transition-end-event-multiple-04.html
5129 transitions/transition-end-event-nested.html
5130 transitions/transition-end-event-transform.html
5131 transitions/transition-end-event-window.html
5132
51332008-09-01 Dean Jackson <dino@apple.com>
5134
dino@apple.com6e2db502008-09-01 23:05:28 +00005135 Reviewed by Sam Weinig
5136
5137 Code styling cleanup.
5138
5139 * bindings/js/JSDOMWindowBase.cpp:
5140 (WebCore::JSDOMWindowBase::getValueProperty):
5141 (WebCore::JSDOMWindowBase::put):
5142
weinig@apple.com3412bb42008-09-01 21:22:54 +000051432008-09-01 Geoffrey Garen <ggaren@apple.com>
5144
5145 Reviewed by Darin Adler.
5146
5147 First cut at inline caching for access to vanilla JavaScript properties.
5148
5149 Updated for JavaScriptCore changes. Mostly mechanical addition of StructureIDs
5150 to WebCore classes, and PutPropertySlot& arguments to put functions.
5151
5152 (WebCore::JSCSSStyleDeclaration::customPut): Be sure to play nice with
5153 inline caching for global properties, so global assignment can be optimized.
5154
5155 * ForwardingHeaders/kjs/StructureID.h: Added.
5156 * bindings/js/JSDOMBinding.h:
5157 (WebCore::DOMObject::DOMObject):
5158 * bindings/js/JSDOMWindowBase.cpp:
5159 (WebCore::JSDOMWindowBase::put):
5160 * bindings/js/JSDOMWindowBase.h:
5161 * bindings/js/JSDOMWindowCustom.h:
5162 (WebCore::JSDOMWindow::customPut):
5163 * bindings/js/JSDOMWindowShell.cpp:
5164 (WebCore::JSDOMWindowShell::JSDOMWindowShell):
5165 (WebCore::JSDOMWindowShell::put):
5166 * bindings/js/JSDOMWindowShell.h:
5167 * bindings/js/JSEventTargetBase.h:
5168 (WebCore::JSEventTargetBase::put):
5169 * bindings/js/JSEventTargetNode.h:
5170 (WebCore::JSEventTargetNode::put):
5171 * bindings/js/JSHTMLAppletElementCustom.cpp:
5172 (WebCore::JSHTMLAppletElement::customPut):
5173 * bindings/js/JSHTMLEmbedElementCustom.cpp:
5174 (WebCore::JSHTMLEmbedElement::customPut):
5175 * bindings/js/JSHTMLInputElementBase.cpp:
5176 (WebCore::JSHTMLInputElementBase::put):
5177 * bindings/js/JSHTMLInputElementBase.h:
5178 * bindings/js/JSHTMLObjectElementCustom.cpp:
5179 (WebCore::JSHTMLObjectElement::customPut):
5180 * bindings/js/JSHistoryCustom.cpp:
5181 (WebCore::JSHistory::customPut):
5182 * bindings/js/JSInspectedObjectWrapper.cpp:
5183 (WebCore::JSInspectedObjectWrapper::wrap):
5184 (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
5185 * bindings/js/JSInspectedObjectWrapper.h:
5186 * bindings/js/JSInspectorCallbackWrapper.cpp:
5187 (WebCore::JSInspectorCallbackWrapper::wrap):
5188 (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
5189 * bindings/js/JSInspectorCallbackWrapper.h:
5190 * bindings/js/JSLocationCustom.cpp:
5191 (WebCore::JSLocation::customPut):
5192 * bindings/js/JSPluginElementFunctions.cpp:
5193 (WebCore::runtimeObjectCustomPut):
5194 * bindings/js/JSPluginElementFunctions.h:
5195 * bindings/js/JSQuarantinedObjectWrapper.cpp:
5196 (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
5197 (WebCore::JSQuarantinedObjectWrapper::put):
5198 * bindings/js/JSQuarantinedObjectWrapper.h:
5199 * bindings/js/JSStorageCustom.cpp:
5200 (WebCore::JSStorage::customPut):
5201 * bindings/objc/WebScriptObject.mm:
5202 (-[WebScriptObject setValue:forKey:]):
5203 * bindings/scripts/CodeGeneratorJS.pm:
5204 * bridge/NP_jsobject.cpp:
5205 (_NPN_SetProperty):
5206 * bridge/jni/jni_jsobject.mm:
5207 (JavaJSObject::setMember):
5208 * bridge/objc/objc_class.mm:
5209 (KJS::Bindings::ObjcClass::fallbackObject):
5210 * bridge/objc/objc_runtime.h:
5211 * bridge/objc/objc_runtime.mm:
5212 (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
5213 (ObjcFallbackObjectImp::put):
5214 * bridge/runtime.cpp:
5215 (KJS::Bindings::Instance::createRuntimeObject):
5216 * bridge/runtime_array.cpp:
5217 (RuntimeArray::put):
5218 * bridge/runtime_array.h:
5219 * bridge/runtime_object.cpp:
5220 (RuntimeObjectImp::RuntimeObjectImp):
5221 (RuntimeObjectImp::put):
5222 * bridge/runtime_object.h:
5223
jmalonzo@webkit.org1f770ba2008-09-01 12:43:34 +000052242008-09-01 Dirk Schulze <vbs85@gmx.de>
5225
5226 Reviewed by Eric Seidel.
5227
jmalonzo@webkit.org37f07882008-09-01 12:43:48 +00005228 Fixed border-radius for Cairo.
5229
5230 * platform/graphics/cairo/GraphicsContextCairo.cpp:
5231 (WebCore::GraphicsContext::strokeArc):
5232
52332008-09-01 Dirk Schulze <vbs85@gmx.de>
5234
5235 Reviewed by Eric Seidel.
5236
jmalonzo@webkit.org1f770ba2008-09-01 12:43:34 +00005237 Added canvas's globalAlpha to cairo.
5238
5239 * platform/graphics/GraphicsContext.h:
5240 * platform/graphics/cairo/GraphicsContextCairo.cpp:
5241 (WebCore::GraphicsContext::fillPath):
5242 (WebCore::GraphicsContext::strokePath):
5243 (WebCore::GraphicsContext::setAlpha):
5244 (WebCore::GraphicsContext::getAlpha):
5245 * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
5246 (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
5247 * platform/graphics/cairo/ImageCairo.cpp:
5248 (WebCore::BitmapImage::draw):
5249
hausmann@webkit.orgecd099d2008-08-31 13:13:28 +000052502008-08-31 Simon Hausmann <hausmann@webkit.org>
5251
5252 Unreviewed Qt build fix.
5253
5254 * WebCore.pro: Add TextControlInnerElements.cpp to SOURCES instead of
5255 the .h file
5256
darin@apple.come7945852008-08-31 06:58:07 +000052572008-08-30 Darin Adler <darin@apple.com>
5258
5259 Reviewed by Maciej.
5260
5261 - adopt some new JavaScriptCore functions where appropriate
5262
5263 * bindings/js/JSDOMWindowBase.cpp:
5264 (WebCore::windowProtoFuncAToB): Adopted jsEmptyString.
5265 (WebCore::windowProtoFuncBToA): Ditto.
5266 * bindings/js/JSEventListener.cpp:
5267 (WebCore::JSLazyEventListener::eventParameterName): Adopted
5268 jsNontrivialString.
5269 * bindings/js/JSSVGLazyEventListener.cpp:
5270 (WebCore::JSSVGLazyEventListener::eventParameterName): Ditto.
5271
beidson@apple.com21c821f2008-08-30 00:26:01 +000052722008-08-29 Brady Eidson <beidson@apple.com>
5273
beidson@apple.come1bd6032008-08-30 00:30:11 +00005274 Reviewed by Anders' rubberstamp
5275
5276 Style cleanup to match MediaTokenizer::writeRawData()
5277
5278 * loader/PluginDocument.cpp:
5279 (WebCore::PluginTokenizer::writeRawData):
5280
52812008-08-29 Brady Eidson <beidson@apple.com>
5282
beidson@apple.com21c821f2008-08-30 00:26:01 +00005283 Reviewed by Anders
5284
5285 Fix regression I introducted in 35946
5286 Already covered by media/video-click-dlbclick-standalone.html
5287
5288 * loader/MediaDocument.cpp:
5289 (WebCore::MediaTokenizer::createDocumentStructure): Don't cancel the load here - too early!
5290 (WebCore::MediaTokenizer::writeRawData): Call finish() here so onload() can be called. Also add
5291 an ASSERT signifying that this method should only be called once, to more closely follow the
5292 PluginDocument case.
5293
bdakin@apple.com7ee298c2008-08-30 00:00:30 +000052942008-08-29 Beth Dakin <bdakin@apple.com>
5295
5296 Reviewed by Sam Weinig.
5297
5298 Fix for <rdar://problem/6181588>
5299
5300 This patch makes hit testing take into account the new concept of a
5301 disconnected frame, in which some of the content may not be
5302 visible. The current hit testing mechanism starts at a target frame
5303 and drills down for a HitTestResult. In some cases, drilling down
5304 will find a non-visible result. When this happens, we need to try
5305 again, starting at a higher level -- namely, starting at the main
5306 frame.
5307
5308 * editing/Editor.cpp:
5309 (WebCore::Editor::insideVisibleArea): New function that tests if a
5310 point is inside the visible area for a disconnected frame.
5311 * editing/Editor.h:
5312 * page/EventHandler.cpp:
5313 (WebCore::EventHandler::hitTestResultAtPoint):
5314
adele@apple.comfb903062008-08-29 22:30:18 +000053152008-08-29 Adele Peterson <adele@apple.com>
5316
5317 Reviewed by Adam Roben.
5318
5319 Rename HTMLTextFieldInnerElement.h/.cpp to TextControlInnerElements.h/.cpp
5320
5321 * GNUmakefile.am:
5322 * WebCore.pro:
5323 * WebCore.vcproj/WebCore.vcproj:
5324 * WebCore.xcodeproj/project.pbxproj:
5325 * WebCoreSources.bkl:
5326 * html/HTMLTextFieldInnerElement.cpp: Removed.
5327 * html/HTMLTextFieldInnerElement.h: Removed.
5328 * rendering/RenderTextControl.cpp:
5329 (WebCore::RenderTextControl::createSubtreeIfNeeded):
5330 * rendering/RenderTextControl.h:
5331 * rendering/TextControlInnerElements.cpp: Copied from html/HTMLTextFieldInnerElement.cpp.
5332 (WebCore::TextControlInnerElement::TextControlInnerElement):
5333 (WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
5334 (WebCore::TextControlInnerTextElement::defaultEventHandler):
5335 (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
5336 (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
5337 (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
5338 (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
5339 * rendering/TextControlInnerElements.h: Copied from html/HTMLTextFieldInnerElement.h.
5340
eric@webkit.org298c65b2008-08-29 21:39:32 +000053412008-08-29 Eric Seidel <eric@webkit.org>
5342
eric@webkit.org77837ce2008-08-29 21:40:07 +00005343 Rubber-stamped by aroben.
5344
5345 Add GraphicsContext.h include to GraphcisContextPrivate.h
5346
5347 GraphicsContextPrivate uses StrokeStyle which is defined
5348 in GraphicsContext.h but it doesn't include that header.
5349 CoreGraphics build doesn't fail here due to the order
5350 it happens to include files.
5351
5352 * platform/graphics/GraphicsContextPrivate.h:
5353
53542008-08-29 Eric Seidel <eric@webkit.org>
5355
eric@webkit.org298c65b2008-08-29 21:39:32 +00005356 Reviewed by hyatt.
5357
5358 Fix GeneratedImage to respect Image's refcounting
5359 Fixing potential crashers (future if not current)
5360 https://bugs.webkit.org/show_bug.cgi?id=20567
5361
5362 I don't know if it's possible to make the current code
5363 crash, thus I've not made a test.
5364
5365 * css/CSSGradientValue.cpp:
5366 (WebCore::CSSGradientValue::image):
5367 * css/CSSImageGeneratorValue.cpp:
5368 (WebCore::CSSImageGeneratorValue::removeClient):
5369 (WebCore::CSSImageGeneratorValue::getImage):
5370 * css/CSSImageGeneratorValue.h:
5371 * platform/graphics/GeneratedImage.h:
5372 (WebCore::GeneratedImage::GeneratedImage):
5373 * rendering/style/RenderStyle.cpp:
5374 (WebCore::RenderStyle::setContent):
5375 * rendering/style/RenderStyle.h:
5376
eric.carlson@apple.comddeafd42008-08-29 20:07:19 +000053772008-08-29 Eric Carlson <eric.carlson@apple.com>
5378
5379 Reviewed by Adele.
5380
eric.carlson@apple.com850c77c2008-08-29 20:24:50 +00005381 Fix for <rdar://problem/6093767>
5382 https://bugs.webkit.org/show_bug.cgi?id=20526
5383
5384 Don't allow video to render until unsupported track types have been disabled.
5385
5386 * platform/graphics/win/QTMovieWin.cpp:
5387 (QTMovieWinPrivate::task):
5388 (QTMovieWinPrivate::drawingComplete):
5389 (QTMovieWinPrivate::clearGWorld):
5390
53912008-08-29 Eric Carlson <eric.carlson@apple.com>
5392
5393 Reviewed by Adele.
5394
eric.carlson@apple.comddeafd42008-08-29 20:07:19 +00005395 Fix for https://bugs.webkit.org/show_bug.cgi?id=20525
5396 <rdar://problem/6169301>
5397
5398 Return the size of the movie data instead of 1000.
5399
5400 Test: media/progress-event-total.html
5401
5402 * platform/graphics/win/QTMovieWin.cpp:
5403 (QTMovieWin::dataSize):
5404
hausmann@webkit.org0367b582008-08-29 15:56:02 +000054052008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
5406
hausmann@webkit.orgfe7f2ac2008-08-29 15:57:44 +00005407 Reviewed by Eric Seidel.
5408
5409 [janitor/qt] Start replacing port specific getters with the generic native getter
5410 To get the native presentation of an image we currently have platform
5411 specific #ifdef's and a generic getter using NativeImagePtr. This patch
5412 extends this to the ImageBuffer and updates the Qt platform to get rid
5413 of the special #ifdefs.
5414
5415 https://bugs.webkit.org/attachment.cgi?id=22861
5416
5417 * platform/graphics/BitmapImage.h:
5418 * platform/graphics/Image.h:
5419 * platform/graphics/qt/ImageQt.cpp:
5420 * platform/graphics/qt/StillImageQt.cpp:
5421 * platform/graphics/qt/StillImageQt.h:
5422 * platform/qt/ClipboardQt.cpp:
5423 (WebCore::ClipboardQt::createDragImage):
5424 (WebCore::ClipboardQt::declareAndWriteDragImage):
5425 * platform/qt/CursorQt.cpp:
5426 * platform/qt/PasteboardQt.cpp:
5427 (WebCore::Pasteboard::writeImage):
5428
54292008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
5430
hausmann@webkit.org0367b582008-08-29 15:56:02 +00005431 Reviewed by Simon.
5432
hausmann@webkit.orgb99266e2008-08-29 15:56:59 +00005433 [svg/qt] Stop crashing... when no RenderPath/RenderObject is given...
5434
5435 * svg/graphics/qt/SVGPaintServerQt.cpp:
5436 (WebCore::SVGPaintServer::renderPath):
5437 * svg/graphics/qt/SVGPaintServerSolidQt.cpp:
5438 (WebCore::SVGPaintServerSolid::setup):
5439
54402008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
5441
5442 Reviewed by Simon.
5443
hausmann@webkit.org0367b582008-08-29 15:56:02 +00005444 [network/qt] Implement defering of loading ResourceHandle's
5445 This is needed otherwise we end in an ASSERT in the MainResourceLoader. The
5446 implementation is simply not forwarding anything to the
5447 ResourceHandleClient until we are allowed to. This might lead to a deadlock
5448 in Qt as we do not empty the QNetworkReply input buffer and wait until we
5449 are allowed to read. If that happens we are forced to buffer the data
5450 within QNetworkReplyHandler, for now this is not done.
5451
5452 Manual test:
5453 - Open http://acid3.acidtests.org
5454 - Wait for the test to complete
5455 - Click on the Reference Rendering link
5456 - Be fast and see the results of acid3
5457 => assert
5458
5459 * platform/network/qt/QNetworkReplyHandler.cpp:
5460 (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
5461 (WebCore::QNetworkReplyHandler::setLoadMode):
5462 (WebCore::QNetworkReplyHandler::finish):
5463 (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
5464 (WebCore::QNetworkReplyHandler::forwardData):
5465 (WebCore::QNetworkReplyHandler::start):
5466 (WebCore::QNetworkReplyHandler::resetState):
5467 (WebCore::QNetworkReplyHandler::sendQueuedItems):
5468 * platform/network/qt/QNetworkReplyHandler.h:
5469 (WebCore::QNetworkReplyHandler::):
5470 * platform/network/qt/ResourceHandleQt.cpp:
5471 (WebCore::ResourceHandle::start):
5472 (WebCore::ResourceHandle::loadResourceSynchronously):
5473 (WebCore::ResourceHandle::setDefersLoading):
5474
hausmann@webkit.org2f2621f2008-08-29 10:21:38 +000054752008-08-29 Simon Hausmann <hausmann@webkit.org>
5476
hausmann@webkit.orgf5864402008-08-29 12:35:59 +00005477 Reviewed by Holger.
5478
5479 Don't crash when drawing patterns with the HTML canvas. Patterns
5480 remain unimplemented but at least they don't crash anymore. This is
5481 done by changing the PlatformPatternPtr to be a brush for the Qt
5482 platform.
5483
5484 * platform/graphics/Pattern.h:
5485 * platform/graphics/qt/GraphicsContextQt.cpp:
5486 (WebCore::GraphicsContext::fillPath):
5487 (WebCore::GraphicsContext::strokePath):
5488 (WebCore::GraphicsContext::fillRect):
5489 * platform/graphics/qt/PatternQt.cpp:
5490 (WebCore::Pattern::createPlatformPattern):
5491
54922008-08-29 Simon Hausmann <hausmann@webkit.org>
5493
hausmann@webkit.org2f2621f2008-08-29 10:21:38 +00005494 Fix the Qt build, fontSelector() is not used by the Qt port yet
5495 and we just return 0 in Font::fontSelector().
5496
5497 * platform/graphics/Font.h:
5498
alp@webkit.org97d8c102008-08-29 05:09:39 +000054992008-08-28 Alp Toker <alp@nuanti.com>
5500
5501 GTK+ dist/build fix. List newly added header files.
5502
5503 * GNUmakefile.am:
5504
simon.fraser@apple.com8f30d022008-08-28 23:04:18 +000055052008-08-28 Simon Fraser <simon.fraser@apple.com>
5506
5507 Reviewed by Dave Hyatt
5508
5509 Various WebKitCSSTransformValue-related fixes
5510 https://bugs.webkit.org/show_bug.cgi?id=20562
5511
5512 Test: css3/transform-value-types.html
5513
5514 * bindings/js/JSCSSValueCustom.cpp:
5515 (WebCore::toJS):
5516 * css/CSSValue.h:
5517 * css/WebKitCSSTransformValue.cpp:
5518 (WebCore::WebKitCSSTransformValue::cssText):
5519 * css/WebKitCSSTransformValue.h:
5520 (WebCore::WebKitCSSTransformValue::):
5521 * css/WebKitCSSTransformValue.idl:
5522
mitz@apple.comd7222352008-08-28 22:53:31 +000055232008-08-28 Dan Bernstein <mitz@apple.com>
5524
5525 Reviewed by Steve Falkenburg.
5526
5527 - do not let the "last chance" WM_TIMER trigger WebCore timers when they should be deferred
5528
5529 * platform/win/SharedTimerWin.cpp:
5530 (WebCore::TimerWindowWndProc):
5531
hyatt@apple.com7d335232008-08-28 21:38:45 +000055322008-08-28 David Hyatt <hyatt@apple.com>
5533
5534 RenderStyle cleanup.
5535
5536 Break out StyleImage, StyleGeneratedImage, StyleCachedImage and NinePieceImage into separate files.
5537
5538 Reviewed by Adam
5539
5540 * css/CSSImageGeneratorValue.cpp:
5541 * css/CSSImageValue.cpp:
5542 * css/CSSStyleSelector.cpp:
5543 * rendering/RenderImageGeneratedContent.cpp:
5544 * rendering/style/NinePieceImage.cpp: Added.
5545 * rendering/style/NinePieceImage.h: Added.
5546 * rendering/style/RenderStyle.cpp:
5547 (WebCore::FillLayer::operator==):
5548 (WebCore::FillLayer::containsImage):
5549 (WebCore::StyleInheritedData::operator==):
5550 (WebCore::RenderStyle::contentDataEquivalent):
5551 * rendering/style/RenderStyle.h:
5552 * rendering/style/StyleCachedImage.cpp: Added.
5553 * rendering/style/StyleCachedImage.h: Added.
5554 * rendering/style/StyleGeneratedImage.cpp: Added.
5555 * rendering/style/StyleGeneratedImage.h: Added.
5556 * rendering/style/StyleImage.h: Added.
5557
simon.fraser@apple.com28bad1a2008-08-28 21:29:21 +000055582008-08-28 Simon Fraser <simon.fraser@apple.com>
5559
5560 Reviewed by Dave Hyatt
5561
5562 Make all the 'isFoo()' methods on CSSValue const,
5563 and fix the subclasses.
5564
5565 https://bugs.webkit.org/show_bug.cgi?id=20561
5566
5567 * css/CSSTimingFunctionValue.h:
5568 * css/CSSValue.h:
5569 (WebCore::CSSValue::isFontValue):
5570 (WebCore::CSSValue::isImageGeneratorValue):
5571 (WebCore::CSSValue::isImageValue):
5572 (WebCore::CSSValue::isImplicitInitialValue):
5573 * css/CSSValueList.h:
5574 * css/FontValue.h:
5575
hyatt@apple.com550a95c2008-08-28 19:53:56 +000055762008-08-28 David Hyatt <hyatt@apple.com>
5577
hyatt@apple.comcb3eb812008-08-28 20:08:03 +00005578 The great RenderStyle cleanup begins!
5579
5580 Move LengthBox and LengthSize out of RenderStyle and into Length.
5581
5582 Reviewed by Adam
5583
5584 * rendering/Length.h:
5585 (WebCore::):
5586 (WebCore::Length::Length):
5587 (WebCore::Length::operator==):
5588 (WebCore::Length::operator!=):
5589 (WebCore::Length::value):
5590 (WebCore::Length::rawValue):
5591 (WebCore::Length::percent):
5592 (WebCore::Length::type):
5593 (WebCore::Length::quirk):
5594 (WebCore::Length::setValue):
5595 (WebCore::Length::setRawValue):
5596 (WebCore::Length::calcValue):
5597 (WebCore::Length::calcMinValue):
5598 (WebCore::Length::calcFloatValue):
5599 (WebCore::Length::isUndefined):
5600 (WebCore::Length::isZero):
5601 (WebCore::Length::isPositive):
5602 (WebCore::Length::isNegative):
5603 (WebCore::Length::isAuto):
5604 (WebCore::Length::isRelative):
5605 (WebCore::Length::isPercent):
5606 (WebCore::Length::isFixed):
5607 (WebCore::Length::isStatic):
5608 (WebCore::Length::isIntrinsicOrAuto):
5609 (WebCore::Length::blend):
5610 (WebCore::LengthBox::LengthBox):
5611 (WebCore::LengthBox::operator=):
5612 (WebCore::LengthBox::operator==):
5613 (WebCore::LengthBox::operator!=):
5614 (WebCore::LengthBox::nonZero):
5615 (WebCore::LengthSize::LengthSize):
5616 * rendering/style/RenderStyle.h:
5617
56182008-08-28 David Hyatt <hyatt@apple.com>
5619
hyatt@apple.com550a95c2008-08-28 19:53:56 +00005620 Reviewed by Darin
5621
5622 https://bugs.webkit.org/show_bug.cgi?id=18091
5623
5624 font-size should be animatable using -webkit-transition.
5625
5626 * page/AnimationController.cpp:
5627 (WebCore::AnimationControllerPrivate::ensurePropertyMap):
5628 * rendering/style/RenderStyle.h:
5629 (WebCore::RenderStyle::setFontSize):
5630
mitz@apple.com30923ad2008-08-28 17:45:47 +000056312008-08-28 Brad Garcia <bgarcia@google.com>
5632
5633 Reviewed by Dan Bernstein.
5634
5635 https://bugs.webkit.org/show_bug.cgi?id=20549
5636 Correctly determine when cursor is over a resizable border within
5637 a nested frameset.
5638
5639 * rendering/RenderFrameSet.cpp:
5640 (WebCore::RenderFrameSet::canResizeRow):
5641 (WebCore::RenderFrameSet::canResizeColumn):
5642
simon.fraser@apple.comae77c412008-08-28 17:30:07 +000056432008-08-28 Simon Fraser <simon.fraser@apple.com>
5644
5645 Reviewed by Eric Seidel
5646
5647 Add RuleTypes to CSSRule.idl for keyframes and keyframe rules.
5648 https://bugs.webkit.org/show_bug.cgi?id=20552
5649
5650 Test: animations/animation-css-rule-types.html
5651
5652 * css/CSSRule.idl:
5653
andersca@apple.com12399c32008-08-28 17:26:46 +000056542008-08-28 Anders Carlsson <andersca@apple.com>
5655
5656 Reviewed by Kevin and Darin.
5657
5658 <rdar://problem/6182541>
5659 https://bugs.webkit.org/show_bug.cgi?id=20202
5660 Missing http status line from the http headers.
5661
5662 Add a status line to the header string.
5663
5664 * plugins/PluginStream.cpp:
5665 (WebCore::PluginStream::startStream):
5666
zecke@webkit.orgf1daa422008-08-28 15:56:01 +000056672008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
5668
5669 Rubber-stamped by Darin Adler.
5670
5671 https://bugs.webkit.org/show_bug.cgi?id=17261
5672
5673 Make it possible to theme the default Url icon and enable this for
5674 the Qt port. To have a minimal usage of #ifdef in the code the setting
5675 of the icon was moved to a new method which comes in two flavors.
5676
5677 * loader/icon/IconDatabase.cpp:
5678 (WebCore::loadDefaultIconRecord): Load or set the default icon
5679 (WebCore::IconDatabase::defaultIcon):
5680
zecke@webkit.org1887dc82008-08-28 15:03:21 +000056812008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
5682
5683 Unreviewed compile fix
5684
5685 * platform/graphics/qt/GraphicsContextQt.cpp: Remove redefinitions
5686
aroben@apple.comfacf5032008-08-28 13:34:01 +000056872008-08-28 Adam Roben <aroben@apple.com>
5688
5689 Windows (and others?) build fix
5690
5691 * page/Chrome.cpp: Added a missing #include.
5692 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Fixed typo.
5693
eric@webkit.org22794fd2008-08-28 12:04:40 +000056942008-08-27 Eric Seidel <eric@webkit.org>
5695
5696 Reviewed by Oliver Hunt.
5697
eric@webkit.org5f874e92008-08-28 12:04:55 +00005698 Qt and Cairo support from krit (and blind stab @ wx compile support)
5699 https://bugs.webkit.org/show_bug.cgi?id=20373
5700
5701 * platform/graphics/cairo/GraphicsContextCairo.cpp:
5702 (WebCore::GraphicsContext::fillPath):
5703 (WebCore::GraphicsContext::strokePath):
5704 (WebCore::GraphicsContext::drawPath):
5705 (WebCore::GraphicsContext::fillRect):
5706 (WebCore::GraphicsContext::setPlatformFillColor):
5707 (WebCore::GraphicsContext::setPlatformStrokeColor):
5708 (WebCore::GraphicsContext::setPlatformStrokeStyle):
5709 (WebCore::GraphicsContext::strokeRect):
5710 (WebCore::GraphicsContext::setImageInterpolationQuality):
5711 (WebCore::GraphicsContext::imageInterpolationQuality):
5712 (WebCore::GraphicsContext::setPlatformFillPattern):
5713 (WebCore::GraphicsContext::setPlatformStrokePattern):
5714 (WebCore::GraphicsContext::setPlatformFillGradient):
5715 (WebCore::GraphicsContext::setPlatformStrokeGradient):
5716 * platform/graphics/qt/GraphicsContextQt.cpp:
5717 (WebCore::GraphicsContext::fillPath):
5718 (WebCore::GraphicsContext::strokePath):
5719 (WebCore::GraphicsContext::fillRect):
5720 (WebCore::GraphicsContext::strokeRect):
5721 (WebCore::GraphicsContext::clipToImageBuffer):
5722 (WebCore::GraphicsContext::setPlatformFillPattern):
5723 (WebCore::GraphicsContext::setPlatformStrokePattern):
5724 (WebCore::GraphicsContext::setPlatformFillGradient):
5725 (WebCore::GraphicsContext::setPlatformStrokeGradient):
5726 (WebCore::GraphicsContext::setImageInterpolationQuality):
5727 (WebCore::GraphicsContext::imageInterpolationQuality):
5728 * platform/graphics/wx/GraphicsContextWx.cpp:
5729 (WebCore::GraphicsContext::clipToImageBuffer):
5730 (WebCore::GraphicsContext::setImageInterpolationQuality):
5731 (WebCore::GraphicsContext::imageInterpolationQuality):
5732 (WebCore::GraphicsContext::fillPath):
5733 (WebCore::GraphicsContext::strokePath):
5734 (WebCore::GraphicsContext::drawPath):
5735 (WebCore::GraphicsContext::fillRect):
5736 (WebCore::GraphicsContext::setPlatformFillPattern):
5737 (WebCore::GraphicsContext::setPlatformStrokePattern):
5738 (WebCore::GraphicsContext::setPlatformFillGradient):
5739
57402008-08-27 Eric Seidel <eric@webkit.org>
5741
5742 Reviewed by Oliver Hunt.
5743
eric@webkit.org22794fd2008-08-28 12:04:40 +00005744 Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it.
5745 https://bugs.webkit.org/show_bug.cgi?id=20373
5746
5747 Changed pattern() to canvasPattern() on CanvasStyle to match canvasGradient()
5748
5749 Made Generator (aka Gradient) RefCounted so that GraphicsContext didn't
5750 have to store large Gradient objects in the GraphicsContextState
5751
5752 Made Pattern RefCounted for the same reason.
5753
5754 Many updates to GraphicsContext to support easier drawing with
5755 Patterns and Gradients.
5756
5757 * WebCore.xcodeproj/project.pbxproj: Add pre-existing GraphicsContextPrivate.h
5758 * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
5759 (WebCore::toJS):
5760 * css/CSSGradientValue.cpp:
5761 (WebCore::CSSGradientValue::createGradient):
5762 * css/CSSGradientValue.h:
5763 * html/CanvasGradient.cpp:
5764 (WebCore::CanvasGradient::CanvasGradient):
5765 * html/CanvasGradient.h:
5766 (WebCore::CanvasGradient::gradient):
5767 (WebCore::CanvasGradient::addColorStop):
5768 (WebCore::CanvasGradient::getColor):
5769 * html/CanvasPattern.cpp:
5770 * html/CanvasPattern.h:
5771 (WebCore::CanvasPattern::pattern):
5772 (WebCore::CanvasPattern::originClean):
5773 * html/CanvasRenderingContext2D.cpp:
5774 (WebCore::CanvasRenderingContext2D::State::State):
5775 (WebCore::CanvasRenderingContext2D::setStrokeStyle):
5776 (WebCore::CanvasRenderingContext2D::setFillStyle):
5777 (WebCore::CanvasRenderingContext2D::fill):
5778 (WebCore::CanvasRenderingContext2D::stroke):
5779 (WebCore::CanvasRenderingContext2D::fillRect):
5780 (WebCore::CanvasRenderingContext2D::strokeRect):
5781 * html/CanvasRenderingContext2D.h:
5782 * html/CanvasStyle.cpp:
5783 (WebCore::CanvasStyle::applyStrokeColor):
5784 (WebCore::CanvasStyle::applyFillColor):
5785 * html/CanvasStyle.h:
5786 * platform/graphics/GeneratedImage.h:
5787 (WebCore::GeneratedImage::GeneratedImage):
5788 * platform/graphics/Generator.h:
5789 * platform/graphics/Gradient.h:
5790 (WebCore::Gradient::create):
5791 * platform/graphics/GraphicsContext.cpp:
5792 (WebCore::GraphicsContext::fillRule):
5793 (WebCore::GraphicsContext::setFillRule):
5794 (WebCore::GraphicsContext::setStrokePattern):
5795 (WebCore::GraphicsContext::setFillPattern):
5796 (WebCore::GraphicsContext::setStrokeGradient):
5797 (WebCore::GraphicsContext::setFillGradient):
5798 * platform/graphics/GraphicsContext.h:
5799 * platform/graphics/GraphicsContextPrivate.h:
5800 (WebCore::):
5801 (WebCore::GraphicsContextState::GraphicsContextState):
5802 * platform/graphics/GraphicsTypes.h:
5803 * platform/graphics/Path.h:
5804 * platform/graphics/Pattern.h:
5805 (WebCore::Pattern::create):
5806 (WebCore::Pattern::tileImage):
5807 * platform/graphics/cg/GraphicsContextCG.cpp:
5808 (WebCore::GraphicsContext::drawRect):
5809 (WebCore::GraphicsContext::drawEllipse):
5810 (WebCore::GraphicsContext::drawConvexPolygon):
5811 (WebCore::calculateDrawingMode):
5812 (WebCore::GraphicsContext::drawPath):
5813 (WebCore::fillPathWithFillRule):
5814 (WebCore::GraphicsContext::fillPath):
5815 (WebCore::GraphicsContext::strokePath):
5816 (WebCore::GraphicsContext::fillRect):
5817 (WebCore::GraphicsContext::fillRoundedRect):
5818 (WebCore::GraphicsContext::setPlatformStrokePattern):
5819 (WebCore::GraphicsContext::setPlatformFillPattern):
5820 (WebCore::GraphicsContext::setPlatformStrokeGradient):
5821 (WebCore::GraphicsContext::setPlatformFillGradient):
5822
eric@webkit.org70b099f2008-08-28 11:42:26 +000058232008-08-20 Eric Seidel <eric@webkit.org>
5824
5825 Reviewed by Darin and Alexey.
5826
5827 Close a leak of PausedTimeouts if the JavaScriptDebugServer was destroyed
5828 with timeouts paused.
5829 https://bugs.webkit.org/show_bug.cgi?id=20469
5830
5831 I attempted to clean up the memory management of PausedTimeouts, I'm not
5832 sure the solution I came up with is "cleaner", but it's in some ways
5833 "safer", since it no longer uses raw pointers and manual new/delete.
5834
5835 This also now prevents CachedPage from needlessly creating Window
5836 objects when caching pages which didn't already have one. :)
5837
5838 I also made Chrome.cpp no longer depend on the JavaScript bindings
5839 (aka JSDOMWindowBase.h), since there was no real reason for it to.
5840
5841 * bindings/js/JSDOMWindowBase.cpp:
5842 (WebCore::JSDOMWindowBase::pauseTimeouts):
5843 (WebCore::JSDOMWindowBase::resumeTimeouts):
5844 * bindings/js/JSDOMWindowBase.h:
5845 * bindings/js/ScriptController.cpp:
5846 (WebCore::ScriptController::pauseTimeouts):
5847 (WebCore::ScriptController::resumeTimeouts):
5848 * bindings/js/ScriptController.h:
5849 * history/CachedPage.cpp:
5850 (WebCore::CachedPage::CachedPage):
5851 (WebCore::CachedPage::restore):
5852 * page/Chrome.cpp:
5853 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
5854 (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
5855 * page/JavaScriptDebugServer.cpp:
5856 (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
5857 (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
5858
zecke@webkit.org7d0df9e2008-08-28 03:36:31 +000058592008-08-27 Holger Hans Peter Freyther <zecke@selfish.org>
5860
5861 Unreviewed compile fix
5862
5863 Add the stub for the Qt port.
5864
5865 * WebCore.pro:
5866 * page/qt/AccessibilityObjectQt.cpp: Added.
5867 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
5868
zecke@webkit.orged5c2fe2008-08-28 02:15:20 +000058692008-08-27 Alp Toker <alp@nuanti.com>
5870
5871 Reviewed by Eric.
5872
5873 https://bugs.webkit.org/show_bug.cgi?id=20551
zecke@webkit.org81540882008-08-28 02:18:20 +00005874 [GTK] search popup crash
5875
5876 * platform/gtk/SearchPopupMenuGtk.cpp:
5877 (WebCore::SearchPopupMenu::enabled):
5878 Fix a search popup crasher by disabling the history popup since we
5879 don't support this feature yet in the GTK+ port.
5880
58812008-08-27 Alp Toker <alp@nuanti.com>
5882
5883 Reviewed by Eric.
5884
5885 https://bugs.webkit.org/show_bug.cgi?id=20551
zecke@webkit.orged5c2fe2008-08-28 02:15:20 +00005886 [GTK] curl crashers
5887
5888 * platform/network/curl/ResourceHandleManager.cpp:
5889 (WebCore::ResourceHandleManager::startScheduledJobs):
5890 Remove the resource handle from the pending list before starting the
5891 job, not afterwards. Fixes crashers in the test suite.
5892
5893 Test: fast/dom/clientWidthAfterDocumentIsRemoved.html
5894 Test: fast/encoding/char-encoding.html
5895
eric@webkit.org712cb892008-08-28 00:26:15 +000058962008-08-27 Dirk Schulze <vbs85@gmx.de>
5897
5898 Reviewed by eseidel.
5899
5900 Fix canvas drawImage to support composite operations.
5901 Composite had no effect on canvas elements like these:
5902 http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html
5903
5904 [CAIRO] Canvas composite don't work on canvas-elements.
5905 https://bugs.webkit.org/show_bug.cgi?id=20548
5906
5907 * html/CanvasRenderingContext2D.cpp:
5908 (WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call
5909
eric@webkit.org75c83a02008-08-28 00:04:59 +000059102008-08-27 Mario Bensi <mbensi@pleyo.com>
5911
5912 Reviewed by Eric Seidel.
5913
5914 Fix the data content of an image with a base64.
5915
5916 * platform/network/curl/ResourceHandleManager.cpp:
5917 (WebCore::parseDataUrl): Remove the String and use only the data
5918 Vector because the data.latin1().data() convert the data content and
5919 the image test ( https://bugs.webkit.org/attachment.cgi?id=21726 ) is
5920 not drawn correctly.
5921
antti@apple.comf66a86b2008-08-27 23:59:50 +000059222008-08-27 Antti Koivisto <antti@apple.com>
5923
5924 Reviewed by Eric Seidel.
5925
5926 Crash after OK in dialog box and reloading page in secure mode
5927 https://bugs.webkit.org/show_bug.cgi?id=20493
5928
5929 The new run loop spawned by a modal dialog causes a timer in the loader to run
5930 synchronously inside didFinishLoading() deleting "this" object.
5931
5932 Defer all WebCore timers when a modal dialog is up. They are not
5933 safe to execute.
5934
5935 * page/Chrome.cpp:
5936 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
5937 (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
5938
simon.fraser@apple.com7dbde252008-08-27 23:16:36 +000059392008-08-27 Chris Marrin <cmarrin@apple.com>
5940
5941 Reviewed by Dave Hyatt
5942
5943 Memory leaks when animating transforms
5944 https://bugs.webkit.org/show_bug.cgi?id=20532
5945
5946 * rendering/style/RenderStyle.cpp:
5947 (WebCore::ScaleTransformOperation::blend):
5948 (WebCore::RotateTransformOperation::blend):
5949 (WebCore::SkewTransformOperation::blend):
5950 (WebCore::TranslateTransformOperation::blend):
5951 (WebCore::MatrixTransformOperation::blend):
5952 * rendering/style/RenderStyle.h:
5953
timothy@apple.com79cb13a2008-08-27 22:03:24 +000059542008-08-27 Timothy Hatcher <timothy@apple.com>
5955
5956 Add support for support for -webkit-appearance: default-button on the Mac platform.
5957
5958 <rdar://problem/6173530>
5959
5960 Reviewed by Dave Hyatt.
5961
5962 * WebCore.base.exp: Export new symbols.
5963 * platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation.
5964 * platform/mac/WebCoreSystemInterface.mm: Ditto.
5965 * rendering/RenderButton.cpp:
5966 (WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN).
5967 (WebCore::RenderButton::setStyle): Ditto.
5968 * rendering/RenderButton.h: Ditto.
5969 * rendering/RenderThemeMac.mm:
5970 (WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance.
5971 (WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return
5972 key if the button is default, otherwise reset the key equivalent.
5973 (WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell:
5974 on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore
5975 the window's previous default button cell when finished.
5976
hyatt@apple.comf0ec84d2008-08-27 21:18:15 +000059772008-08-26 David Hyatt <hyatt@apple.com>
5978
5979 First cut at making form controls on OS X respect full page zoom. There are lots of bugs.
5980
5981 Reviewed by weinig
5982
5983 Added fast/forms/zoomed-controls.html
5984
5985 * css/CSSStyleSelector.cpp:
5986 (WebCore::addIntrinsicMargins):
5987 * rendering/RenderSlider.cpp:
5988 (WebCore::RenderSlider::calcPrefWidths):
5989 * rendering/RenderThemeMac.h:
5990 * rendering/RenderThemeMac.mm:
5991 (WebCore::RenderThemeMac::adjustRepaintRect):
5992 (WebCore::RenderThemeMac::inflateRect):
5993 (WebCore::RenderThemeMac::baselinePosition):
5994 (WebCore::RenderThemeMac::setControlSize):
5995 (WebCore::RenderThemeMac::sizeForFont):
5996 (WebCore::RenderThemeMac::sizeForSystemFont):
5997 (WebCore::RenderThemeMac::setFontFromControlSize):
5998 (WebCore::RenderThemeMac::paintCheckbox):
5999 (WebCore::RenderThemeMac::setCheckboxCellState):
6000 (WebCore::RenderThemeMac::paintRadio):
6001 (WebCore::RenderThemeMac::setRadioCellState):
6002 (WebCore::RenderThemeMac::setButtonPaddingFromControlSize):
6003 (WebCore::RenderThemeMac::adjustButtonStyle):
6004 (WebCore::RenderThemeMac::setButtonCellState):
6005 (WebCore::RenderThemeMac::paintButton):
6006 (WebCore::RenderThemeMac::paintMenuList):
6007 (WebCore::RenderThemeMac::paintMenuListButton):
6008 (WebCore::RenderThemeMac::popupInternalPaddingLeft):
6009 (WebCore::RenderThemeMac::popupInternalPaddingRight):
6010 (WebCore::RenderThemeMac::popupInternalPaddingTop):
6011 (WebCore::RenderThemeMac::popupInternalPaddingBottom):
6012 (WebCore::RenderThemeMac::setPopupButtonCellState):
6013 (WebCore::RenderThemeMac::paintSliderTrack):
6014 (WebCore::RenderThemeMac::paintSliderThumb):
6015 (WebCore::RenderThemeMac::adjustSliderThumbSize):
6016 (WebCore::RenderThemeMac::paintSearchField):
6017 (WebCore::RenderThemeMac::adjustSearchFieldStyle):
6018 (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
6019 (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
6020
beidson@apple.comd0793872008-08-27 19:59:55 +000060212008-08-27 Brady Eidson <beidson@apple.com>
6022
6023 Reviewed by Anders
6024
6025 <rdar://problem/6134133> - Crash when loading large movie as a standalone document
6026
6027 We hand off these loads to Quicktime which manages and spools the data itself, but we also continued
6028 to load and buffer the data for the movie in WebCore. With large media files, this results in blowing
6029 away the virtual address space and a crash.
6030
6031 * loader/EmptyClients.h:
6032 (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
6033 * loader/FrameLoaderClient.h: Added client method to get platform specific error for
6034 "plugin will handle load"
6035
6036 * loader/MediaDocument.cpp:
6037 (WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data,
6038 and cancel the WebCore-managed load
6039 (WebCore::MediaTokenizer::writeRawData):
6040 (WebCore::MediaTokenizer::finish):
6041
simon.fraser@apple.come74d6712008-08-27 18:19:55 +000060422008-08-26 Simon Fraser <simon.fraser@apple.com>
6043
6044 Reviewed by Eric Seidel
6045
6046 Linear timing functions should have control points 0, 0, 1, 1.
6047 https://bugs.webkit.org/show_bug.cgi?id=20535
6048
6049 * css/CSSStyleSelector.cpp:
6050 (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
6051 * rendering/style/RenderStyle.h:
6052
aroben@apple.com8cfb6c62008-08-27 14:52:17 +000060532008-08-27 Adam Roben <aroben@apple.com>
6054
6055 Windows build fix
6056
6057 * WebCore.vcproj/WebCore.vcproj: Fix file extension.
6058
mrowe@apple.com37686d42008-09-04 00:10:39 +000060592008-08-26 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com33a556b2008-08-26 22:29:14 +00006060
cfleizach@apple.comc6ebe3d2008-08-26 22:43:22 +00006061 Reviewed by Beth Dakin.
6062
cfleizach@apple.com2a505f42008-08-26 22:56:03 +00006063 <rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown
6064
6065 Added platform-specific accessibilityIgnoreAttachment, which allows the platform
6066 to determine if an attachment is ignored through accessibility. Added equivalent
6067 methods in Gtk, Win and Mac
6068
6069 Test: accessibility/plugin.html
6070
6071 * GNUmakefile.am:
6072 * WebCore.vcproj/WebCore.vcproj:
6073 * WebCore.xcodeproj/project.pbxproj:
6074 * page/AccessibilityObject.h:
6075 * page/AccessibilityRenderObject.cpp:
6076 (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
6077 * page/gtk/AccessibilityObjectAtk.cpp: Added.
6078 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
6079 * page/mac/AccessibilityObjectMac.mm: Added.
6080 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
6081 * page/mac/AccessibilityObjectWrapper.h:
6082 * page/win/AccessibilityObjectWin.cpp: Added.
6083 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
6084
mrowe@apple.com37686d42008-09-04 00:10:39 +000060852008-08-26 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com2a505f42008-08-26 22:56:03 +00006086
6087 Reviewed by Beth Dakin.
6088
cfleizach@apple.comc6ebe3d2008-08-26 22:43:22 +00006089 <rdar://problem/5817770> can't bring up contextual menu for embedded objects in WebText
6090
6091 * page/mac/AccessibilityObjectWrapper.mm:
6092 (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
6093 (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
6094
mrowe@apple.com37686d42008-09-04 00:10:39 +000060952008-08-26 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.comc6ebe3d2008-08-26 22:43:22 +00006096
cfleizach@apple.com33a556b2008-08-26 22:29:14 +00006097 Reviewed by Darin Adler.
6098
6099 <rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns
6100
6101 Tests: accessibility/table-notbody.html
6102
6103 * page/AccessibilityTable.cpp:
6104 (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
6105
weinig@apple.com33705852008-08-26 19:51:28 +000061062008-08-26 Sam Weinig <sam@webkit.org>
6107
weinig@apple.comf6f553a2008-08-26 21:21:26 +00006108 Reviewed by Beth Dakin.
6109
6110 Fix typo.
6111
6112 * dom/DOMCoreException.h:
6113
61142008-08-26 Sam Weinig <sam@webkit.org>
6115
weinig@apple.com0f34f002008-08-26 19:56:54 +00006116 Reviewed by Oliver Hunt.
6117
6118 Fix https://bugs.webkit.org/show_bug.cgi?id=20479
6119 <rdar://problem/6167660>
6120 Take image redirects into account when tainting the canvas.
6121
6122 Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html
6123
6124 * html/CanvasRenderingContext2D.cpp:
6125 (WebCore::CanvasRenderingContext2D::drawImage):
6126 (WebCore::CanvasRenderingContext2D::drawImageFromRect):
6127
61282008-08-26 Sam Weinig <sam@webkit.org>
6129
weinig@apple.com33705852008-08-26 19:51:28 +00006130 Reviewed by Darin Adler.
6131
6132 Change canvas tainting logic to ask the image if it contains
6133 any resources outside of its own origin. Since there is no
6134 way to determine if SVG images contain any resources outside its
6135 origin, we always assume it does.
6136
6137 * html/CanvasRenderingContext2D.cpp:
6138 (WebCore::CanvasRenderingContext2D::drawImage):
6139 (WebCore::CanvasRenderingContext2D::drawImageFromRect):
6140 * platform/graphics/BitmapImage.h:
6141 (WebCore::BitmapImage::hasSingleSecurityOrigin):
6142 * platform/graphics/GeneratedImage.h:
6143 (WebCore::GeneratedImage::hasSingleSecurityOrigin):
6144 * platform/graphics/Image.h:
6145 (WebCore::Image::hasSingleSecurityOrigin):
6146 * platform/graphics/cg/PDFDocumentImage.h:
6147 (WebCore::PDFDocumentImage::hasSingleSecurityOrigin):
6148 * svg/graphics/SVGImage.h:
6149
britto@apple.com616ef6d2008-08-26 17:51:03 +000061502008-08-26 Maxime Britto <britto@apple.com>
6151
6152 Reviewed by Adele.
6153
6154 <rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com)
6155 This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area.
6156 This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls.
6157
6158 * page/EventHandler.cpp:
6159 (WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning
6160 * page/EventHandler.h:
6161 * rendering/RenderLayer.cpp:
6162 (WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta
6163 (WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so.
6164 * rendering/RenderLayer.h:
6165 * rendering/RenderObject.cpp:
6166 (WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled
6167 (WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method
6168 (WebCore::RenderObject::panScroll): No need to check for the layer anymore too.
6169
jchaffraix@webkit.orge6915392008-08-26 10:27:33 +000061702008-08-25 Julien Chaffraix <jchaffraix@webkit.org>
6171
darin@apple.com07c80c62008-09-05 18:15:43 +00006172 Reviewed by Darin Adler.
jchaffraix@webkit.orge6915392008-08-26 10:27:33 +00006173
6174 Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it
6175 https://bugs.webkit.org/show_bug.cgi?id=20247
6176
6177 <rdar://problem/6118218>
6178
6179 Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive
6180 check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute
6181 (case insensitive for HTML elements).
6182
6183 Test: fast/dom/Element/getAttribute-check-case-sensitivity.html
6184
6185 * dom/Element.cpp:
6186 (WebCore::Element::getAttribute):
6187 * dom/NamedAttrMap.cpp:
6188 (WebCore::NamedAttrMap::getNamedItem):
6189 (WebCore::NamedAttrMap::getAttributeItem):
6190 * dom/NamedAttrMap.h:
6191
weinig@apple.comb4ce06e2008-08-26 01:52:51 +000061922008-08-25 Sam Weinig <sam@webkit.org>
6193
weinig@apple.com8d3ea722008-08-26 04:19:07 +00006194 Reviewed by Oliver Hunt.
6195
6196 Fix for https://bugs.webkit.org/show_bug.cgi?id=20514
6197 <rdar://problem/6174096>
6198 Treat SVG images as dirty when drawing to a canvas.
6199
6200 Test: http/tests/security/canvas-remote-read-svg-image.html
6201
6202 * html/CanvasRenderingContext2D.cpp:
6203 (WebCore::CanvasRenderingContext2D::drawImage):
6204 (WebCore::CanvasRenderingContext2D::drawImageFromRect):
6205 * platform/graphics/Image.h:
6206 (WebCore::Image::isSVGImage):
6207 * svg/graphics/SVGImage.h:
6208 (WebCore::SVGImage::isSVGImage):
6209
62102008-08-25 Sam Weinig <sam@webkit.org>
6211
weinig@apple.comb4ce06e2008-08-26 01:52:51 +00006212 Reviewed by Mark Rowe.
6213
6214 Fix https://bugs.webkit.org/show_bug.cgi?id=20377
6215 Leak in XMLHttpRequest.
6216
6217 * xml/XMLHttpRequest.cpp:
6218 (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
6219
beidson@apple.com46421212008-08-25 21:48:56 +000062202008-08-25 Brady Eidson <beidson@apple.com>
6221
6222 Reviewed by Anders
6223
6224 Speculative fix for <rdar://problem/6173217>
6225
6226 Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
6227 Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
6228 the first null check invalid.
6229
6230 * loader/FrameLoader.cpp:
6231 (WebCore::FrameLoader::stopAllLoaders):
6232
6233
kmccullough@apple.com7b85fbb2008-08-25 21:28:40 +000062342008-08-25 Kevin McCullough <kmccullough@apple.com>
6235
6236 Reviewed by Tim.
6237
6238 <rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
6239 there is no profile, can cause crash
6240
6241 * page/inspector/ProfilesPanel.js:
6242
dino@apple.com1baeea62008-08-25 21:06:21 +000062432008-08-25 Dean Jackson <dino@apple.com>
6244
6245 Reviewed by Dave Hyatt
6246
6247 Make sure 'inherit' is handled by transition property.
6248 https://bugs.webkit.org/show_bug.cgi?id=20513
6249
6250 Test: transitions/inherit.html
6251 Test: transitions/inherit-other-props.html
6252
6253 * css/CSSStyleSelector.cpp:
6254 fix macro to check existence of list before getting size
6255
andersca@apple.com2866b8302008-08-25 20:56:21 +000062562008-08-25 Anders Carlsson <andersca@apple.com>
6257
6258 Reviewed by Mark.
6259
6260 <rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.
6261
6262 Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume
6263 (safely) that any class that needs finalization on the main thread will also need to be deallocated
6264 on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
6265 calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.
6266
6267 * platform/mac/WebCoreObjCExtras.c:
6268 (WebCoreObjCFinalizeOnMainThread):
6269
antti@apple.com60381cb2008-08-25 20:41:11 +000062702008-08-25 Antti Koivisto <antti@apple.com>
6271
6272 Reviewed by Dan Bernstein.
6273
6274 Rename CachedResource::referenced() to CachedResource::hasClients() to
6275 match previous ref() -> addClient() rename.
6276
6277 * loader/Cache.cpp:
6278 (WebCore::Cache::pruneLiveResources):
6279 (WebCore::Cache::pruneDeadResources):
6280 (WebCore::Cache::remove):
6281 (WebCore::Cache::getStatistics):
6282 (WebCore::Cache::dumpLRULists):
6283 * loader/CachedResource.cpp:
6284 (WebCore::CachedResource::addClient):
6285 (WebCore::CachedResource::removeClient):
6286 (WebCore::CachedResource::setDecodedSize):
6287 (WebCore::CachedResource::setEncodedSize):
6288 * loader/CachedResource.h:
6289 (WebCore::CachedResource::hasClients):
6290 (WebCore::CachedResource::canDelete):
6291
timothy@apple.com7d809242008-08-25 18:33:05 +000062922008-08-25 Anthony Ricaud <rik24d@gmail.com>
6293
6294 Add a missing Inspector localized string for "other".
6295
6296 https://bugs.webkit.org/show_bug.cgi?id=20509
6297
6298 Reviewed by Tim Hatcher.
6299
6300 * English.lproj/localizedStrings.js:
6301
kmccullough@apple.com560f5fe2008-08-25 18:18:01 +000063022008-08-22 Kevin McCullough <kmccullough@apple.com>
6303
6304 Reviewed by Geoff, Mark and Tim.
6305
6306 <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
6307 in the console said what file and line number they came from
6308 - Lay the foundation for getting line numbers and other data from the
6309 JavaScript engine.
6310
6311 * ForwardingHeaders/VM: Added.
6312 * ForwardingHeaders/VM/Machine.h: Added.
6313 * page/Console.cpp: Gather the line number and file information when
6314 profileEnd has been called, but don't use it until didFinishProfiling is
6315 called. We won't need to wait once we remove the profiler "zombie" mode
6316 which this patch helps pave the foundation for.
6317 (WebCore::Console::Console):
6318 (WebCore::Console::profileEnd):
6319 (WebCore::Console::finishedProfiling):
6320 * page/Console.h:
6321 * page/InspectorController.cpp: Modify calls to
6322 addProfileMessageToConsole to satisfy the new arguments it takes.
6323 (WebCore::InspectorController::finishedProfiling):
6324 (WebCore::InspectorController::addProfile):
6325 (WebCore::InspectorController::addProfileMessageToConsole):
6326 (WebCore::InspectorController::finishedProfiling):
6327 * page/InspectorController.h:
6328
hausmann@webkit.orgf305df42008-08-25 10:06:53 +000063292008-08-25 Holger Hans Peter Freyther <zecke@selfish.org>
6330
6331 Reviewed by Simon.
6332
6333 [inspector] Update the WebKit.qrc Qt resources file
6334 Catchup with the changes in the directory.
6335
6336 * page/inspector/WebKit.qrc:
6337
hausmann@webkit.org5f13af32008-08-25 07:10:22 +000063382008-08-25 Dirk Schulze <vbs85@gmx.de>
6339
6340 Reviewed by Simon.
6341
6342 Transformed the radian to degree, to get rotate()
6343 in canvas work as expected.
6344
6345 [Qt] Canvas.rotate() doesn't work
6346 https://bugs.webkit.org/show_bug.cgi?id=20496
6347
6348 * platform/graphics/qt/GraphicsContextQt.cpp:
6349 (WebCore::GraphicsContext::rotate):
6350
sfalken@apple.com9d442862008-08-25 05:43:33 +000063512008-08-24 Steve Falkenburg <sfalken@apple.com>
6352
6353 Add a "last chance" WM_TIMER to the Windows shared timer.
6354
6355 The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
6356 Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
6357 timers if a timer with an earlier expiration is already pending. This results in no timers
6358 firing from that point on.
6359
6360 We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
6361 buggy window message hook.
6362
6363 This timer will start when the first WM_TIMER is scheduled, and will
6364 fire every 5 seconds thereafter, causing any lost timers to be fired.
6365
6366 Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
6367 and prevents the WebFrame leak.
6368
6369 Reviewed by Darin Adler, Geoff Garen.
6370
6371 * platform/win/SharedTimerWin.cpp:
6372 (WebCore::):
6373 (WebCore::TimerWindowWndProc):
6374 (WebCore::setSharedTimerFireTime):
6375
mitz@apple.com771fb752008-08-25 03:22:44 +000063762008-08-24 Dan Bernstein <mitz@apple.com>
6377
6378 Reviewed by Darin Adler.
6379
6380 - fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
6381
6382 Test: fast/css/font-property-priority.html
6383
6384 * css/CSSParser.cpp:
6385 (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag
6386 to the font-property-parsing functions.
6387 (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and
6388 changed to use it rather than the m_important member.
6389 (WebCore::CSSParser::parseFontVariant): Ditto.
6390 (WebCore::CSSParser::parseFontWeight): Ditto.
6391 * css/CSSParser.h:
6392
timothy@apple.com4cea2632008-08-24 22:28:44 +000063932008-08-24 Timothy Hatcher <timothy@apple.com>
6394
6395 Fixes a bug where the Inspector's UI would not animate or
6396 fully function because JavaScript timeouts, intervals and
6397 CSS animation timers where not firing while paused at a
6398 a breakpoint in the inspected page.
6399
6400 https://bugs.webkit.org/show_bug.cgi?id=20042
6401
6402 Reviewed by Darin Adler.
6403
6404 Test: manual-tests/inspector/forzen-ui-while-paused.html
6405
6406 * page/JavaScriptDebugServer.cpp:
6407 (WebCore::JavaScriptDebugServer::pauseIfNeeded):
6408 Add a call to TimerBase::fireTimersInNestedEventLoop before
6409 spinning the EventLoop.
6410
rwlbuis@webkit.org8a772442008-08-24 18:07:32 +000064112008-08-24 Rob Buis <buis@kde.org>
6412
6413 Reviewed by Sam Weinig.
6414
6415 https://bugs.webkit.org/show_bug.cgi?id=20324
6416 A change in SVG Glyph wont show up
6417
6418 Invalidate the glyph cache when the d attribute is set.
6419
6420 Test: svg/custom/glyph-setting-d-attribute.svg
6421
6422 * svg/SVGGlyphElement.cpp:
6423 (WebCore::SVGGlyphElement::invalidateGlyphCache):
6424 (WebCore::SVGGlyphElement::parseMappedAttribute):
6425 (WebCore::SVGGlyphElement::insertedIntoDocument):
6426 (WebCore::SVGGlyphElement::removedFromDocument):
6427 * svg/SVGGlyphElement.h:
6428
mitz@apple.com5b2c3cc2008-08-24 09:18:39 +000064292008-08-24 Dan Bernstein <mitz@apple.com>
6430
6431 Reviewed by Sam Weinig.
6432
6433 - fix https://bugs.webkit.org/show_bug.cgi?id=13864
6434 <rdar://problem/5451470> REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths()
6435
6436 * rendering/RenderText.cpp:
6437 (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to
6438 beginWS and endWS before the early return to ensure that they are
6439 initialized in that case.
6440
cwzwarich@webkit.org53ddf172008-08-23 08:16:54 +000064412008-08-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
6442
6443 Rubber-stamped by Mark Rowe.
6444
6445 Remove modelines.
6446
6447 * WebCore.pro:
6448 * bridge/testbindings.cpp:
6449 * dom/DocPtr.h:
6450 * loader/SubstituteData.h:
6451 * page/Chrome.cpp:
6452 * page/Chrome.h:
6453 * page/ChromeClient.h:
6454 * page/Frame.h:
6455 * page/FrameLoadRequest.h:
6456 * page/FrameTree.cpp:
6457 * page/FrameTree.h:
6458 * page/Page.h:
6459 * page/mac/ChromeMac.mm:
6460 * platform/network/HTTPHeaderMap.h:
6461 * platform/network/ResourceErrorBase.cpp:
6462 * platform/network/ResourceErrorBase.h:
6463 * platform/network/ResourceHandleInternal.h:
6464 * platform/network/ResourceRequestBase.cpp:
6465 * platform/network/ResourceRequestBase.h:
6466 * platform/network/ResourceResponseBase.cpp:
6467 * platform/network/ResourceResponseBase.h:
6468 * platform/network/cf/ResourceError.h:
6469 * platform/network/cf/ResourceRequest.h:
6470 * platform/network/cf/ResourceRequestCFNet.h:
6471 * platform/network/cf/ResourceResponse.h:
6472 * platform/network/cf/ResourceResponseCFNet.h:
6473 * platform/network/curl/ResourceError.h:
6474 * platform/network/curl/ResourceRequest.h:
6475 * platform/network/curl/ResourceResponse.h:
6476 * platform/network/mac/ResourceError.h:
6477 * platform/network/mac/ResourceErrorMac.mm:
6478 * platform/network/mac/ResourceRequest.h:
6479 * platform/network/mac/ResourceRequestMac.mm:
6480 * platform/network/mac/ResourceResponse.h:
6481 * platform/network/mac/ResourceResponseMac.mm:
6482 * platform/network/qt/ResourceError.h:
6483 * platform/network/qt/ResourceRequest.h:
6484 * platform/network/qt/ResourceResponse.h:
6485 * platform/network/soup/CookieJarSoup.cpp:
6486 * platform/network/soup/ResourceError.h:
6487 * platform/network/soup/ResourceRequest.h:
6488 * platform/network/soup/ResourceResponse.h:
6489
mitz@apple.com57a2f482008-08-23 07:16:41 +000064902008-08-23 Dan Bernstein <mitz@apple.com>
6491
6492 Reviewed by Dave Hyatt.
6493
6494 - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
6495
6496 Test: fast/table/vertical-align-baseline.html
6497
6498 * rendering/RenderTable.cpp:
6499 (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
6500 baseline of the first table row, if there is one, -1 otherwise.
6501 * rendering/RenderTable.h:
6502 * rendering/RenderTableCell.cpp:
6503 (WebCore::RenderTableCell::baselinePosition): Changed to follow the
6504 CSS2.1 definition of the baseline of a table cell.
6505 * rendering/RenderTableSection.cpp:
6506 (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
6507 the baseline of the first row in the section.
6508 * rendering/RenderTableSection.h:
6509
jhoneycutt@apple.com88af18d2008-08-22 23:44:32 +000065102008-08-18 Jon Honeycutt <jhoneycutt@apple.com>
6511
6512 Add SPI to make a Windows WebView transparent.
6513
6514 Reviewed by Dan Bernstein.
6515
6516 * platform/graphics/GraphicsContext.h: Add a parameter, hasAlpha, that
6517 determines whether the created context has an alpha channel.
6518 * platform/graphics/win/GraphicsContextCGWin.cpp:
6519 (WebCore::CGContextWithHDC):
6520
timothy@apple.comb63d1172008-08-22 18:39:42 +000065212008-08-22 Timothy Hatcher <timothy@apple.com>
6522
timothy@apple.com964022d2008-08-22 20:35:20 +00006523 Rolls out r35834 because it caused a regression in the Inspector's
6524 Console where some expressions always threw a syntax error.
6525
6526 https://bugs.webkit.org/show_bug.cgi?id=20487
6527
6528 * page/inspector/Console.js:
6529 (Console.prototype._evalInInspectedWindow): Removes parenthesis
6530 around the expression.
6531
65322008-08-22 Timothy Hatcher <timothy@apple.com>
6533
timothy@apple.com056d4782008-08-22 18:39:52 +00006534 Makes getStyleProperty return a value for the overflow property
6535 when overflow-x and overflow-y are equal.
6536
6537 https://bugs.webkit.org/show_bug.cgi?id=20485
6538
6539 Reviewed by Dan Bernstein.
6540
6541 Test: fast/css/overflow-property.html
6542
6543 * css/CSSMutableStyleDeclaration.cpp:
6544 (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
6545
65462008-08-22 Timothy Hatcher <timothy@apple.com>
6547
timothy@apple.comb63d1172008-08-22 18:39:42 +00006548 Fixes a bug where while editing in the Inspector the
6549 sidebar scroll position would jump to the top.
6550
6551 https://bugs.webkit.org/show_bug.cgi?id=20484
6552
6553 Reviewed by Darin Adler.
6554
6555 * page/inspector/treeoutline.js:
6556 (TreeOutline._removeChildren): Remove the offsetTop call that
6557 was forcing a layout, since layout causes scroll positions
6558 to be clamped to the new scrollHeight/Width. Layout will happen
6559 normally when needed.
6560
kevino@webkit.org8271c842008-08-22 16:25:52 +000065612008-08-22 Kevin Ollivier <kevino@theolliviers.com>
6562
6563 wx build fix. Add AccessibilityTable sources.
6564
6565 * WebCoreSources.bkl:
6566
mitz@apple.com9befc872008-08-22 06:29:33 +000065672008-08-21 Dan Bernstein <mitz@apple.com>
6568
6569 Reviewed by Jon Honeycutt and Alexey Proskuryakov.
6570
6571 - fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
6572
6573 Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
6574
6575 * platform/graphics/mac/SimpleFontDataMac.mm:
6576 (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
6577 ascent and 100% to its reported descent.
6578
mrowe@apple.comac9b6a52008-08-22 02:07:54 +000065792008-08-21 Kalle Vahlman <kalle.vahlman@movial.com>
6580
6581 Reviewed by Darin Adler.
6582
mrowe@apple.com22eaa172008-08-22 02:10:15 +00006583 https://bugs.webkit.org/show_bug.cgi?id=20267
mrowe@apple.comac9b6a52008-08-22 02:07:54 +00006584 [GTK] Crash on some pages due to a plugin
6585
6586 Fix handling of badly formatted and empty plugin mime descriptions
6587
6588 * plugins/gtk/PluginPackageGtk.cpp:
6589 (WebCore::PluginPackage::fetchInfo):
6590
mrowe@apple.com798b3432008-08-22 02:07:48 +000065912008-08-21 Kevin Watters <kevinwatters@gmail.com>
6592
6593 Reviewed by Darin Adler.
6594
6595 Follow other ports (and IE) in ImageSourceWx.cpp never to return an
6596 animated GIF frame duration of less than 50ms.
6597
6598 * platform/graphics/wx/ImageSourceWx.cpp:
6599 (WebCore::ImageSource::frameDurationAtIndex):
6600
britto@apple.com8ed72772008-08-22 00:39:39 +000066012008-08-21 Maxime Britto <britto@apple.com>
6602
6603 Reviewed by Kevin McCullough.
6604
6605 Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
6606 https://bugs.webkit.org/show_bug.cgi?id=20451
6607
6608 rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
6609 When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
6610 This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.
6611
6612 * page/EventHandler.cpp:
6613 (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.
6614
6615 (WebCore::EventHandler::handleMousePressEvent): ditto
6616
timothy@apple.com5d492192008-08-21 23:54:01 +000066172008-08-21 Anthony Ricaud <rik24d@gmail.com>
6618
6619 Small optimization for when the dividers in the Inspector's
6620 Resources panel are updated.
6621
6622 Reviewed by Tim Hatcher.
6623
6624 * page/inspector/ResourcesPanel.js:
6625 (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
6626 Combind a for loop and clone the divider element.
6627
dino@apple.comaa75e4c2008-08-21 23:35:23 +000066282008-08-21 Chris Marrin <cmarrin@apple.com>
6629
6630 Allow 0 (without units) for Time eg. duration
6631 Fix for https://bugs.webkit.org/show_bug.cgi?id=20467
6632
6633 Reviewed by Dave Hyatt.
6634
6635 Test: css1/units/zero-duration-without-units.html
6636
6637 * css/CSSParser.cpp:
6638 (WebCore::CSSParser::validUnit):
6639
timothy@apple.com29c12d02008-08-21 20:12:47 +000066402008-08-21 Timothy Hatcher <timothy@apple.com>
6641
timothy@apple.comca11cd82008-08-21 20:13:12 +00006642 Make deleting all text while editing a DOM attribute in
6643 the Inspector delete the attribute. This also fixes
6644 an exception that would happen before.
6645
6646 https://bugs.webkit.org/show_bug.cgi?id=20472
6647
6648 Reviewed by Kevin McCullough.
6649
6650 * page/inspector/ElementsPanel.js:
6651 (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted):
6652 Don't check for hasAttributes on the parseElement, continuing
6653 through the function will correctly remove the attribute.
6654 If the parseElement is null, call _editingCancelled not
6655 editingCancelled, this fixes an exception.
6656
66572008-08-21 Timothy Hatcher <timothy@apple.com>
6658
timothy@apple.comde831cf2008-08-21 20:12:59 +00006659 Update the Inspector's Metrics pane when editing in
6660 the Styles pane. This makes sure the metrics shown
6661 always match what the Styles pane shows.
6662
6663 https://bugs.webkit.org/show_bug.cgi?id=20470
6664
6665 Reviewed by Kevin McCullough.
6666
6667 * page/inspector/ElementsPanel.js:
6668 (WebInspector.ElementsPanel): Add event listeners for
6669 the "style edited" and "style property toggled" events,
6670 so the Metrics pane is updated.
6671 (WebInspector.ElementsPanel.prototype._stylesPaneEdited):
6672 Update the Metrics pane.
6673 * page/inspector/StylesSidebarPane.js:
6674 (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
6675 Dispatch the "style property toggled" event.
6676 (WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
6677 Dispatch the "style edited" event when the CSS text is restored.
6678 (WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
6679 Dispatch the "style edited" event.
6680
66812008-08-21 Timothy Hatcher <timothy@apple.com>
6682
timothy@apple.com29c12d02008-08-21 20:12:47 +00006683 Make the Inspector's Metrics sidebar pane editable.
6684
6685 https://bugs.webkit.org/show_bug.cgi?id=17218
6686 rdar://problem/5732818
6687
6688 Reviewed by Kevin McCullough.
6689
6690 * page/inspector/ElementsPanel.js:
6691 (WebInspector.ElementsPanel): Add an event listener for
6692 the "metrics edited" event, so the Styles pane is updated.
6693 * page/inspector/MetricsSidebarPane.js:
6694 (WebInspector.MetricsSidebarPane.prototype.update): Remember the node
6695 so future updates work. Add a double click event listener for the
6696 metric values to start editing.
6697 (WebInspector.MetricsSidebarPane.prototype.startEditing):
6698 Call WebInspector.startEditing with some context.
6699 (WebInspector.MetricsSidebarPane.prototype.editingCancelled):
6700 (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
6701 Set the user input on the elements inline style. Fire the
6702 "metrics edited" event.
6703
sfalken@apple.com7e6e5392008-08-21 18:42:44 +000067042008-08-21 Steve Falkenburg <sfalken@apple.com>
6705
6706 Fix a race condition in Windows timer code.
6707 Timer function could end up being called with a 0 timer, leading to a Windows exception.
6708
6709 Don't post a timer message if one is already pending.
6710
6711 Reviewed by Ada Chan.
6712
6713 * platform/win/SharedTimerWin.cpp:
6714 (WebCore::TimerWindowWndProc):
6715 (WebCore::clearTimer):
6716 (WebCore::queueTimerProc):
6717 (WebCore::setSharedTimerFireTime):
6718
timothy@apple.com8d15bcf2008-08-21 16:33:17 +000067192008-08-21 Anthony Ricaud <rik24d@gmail.com>
6720
timothy@apple.com493212c72008-08-21 16:36:06 +00006721 After trying to add the expression, try again with quotes for
6722 easier edition.
6723
6724 https://bugs.webkit.org/show_bug.cgi?id=20466
6725
6726 Reviewed by Tim Hatcher.
6727
6728 * page/inspector/ObjectPropertiesSection.js: Added an
6729 evaluateExpression function.
6730
67312008-08-21 Anthony Ricaud <rik24d@gmail.com>
6732
timothy@apple.com8d15bcf2008-08-21 16:33:17 +00006733 Perform Inspector searches on search event to clear results when
6734 clicking the cross to empty it. Delete the lastQuery when the field
6735 is emptied in order to perform the search if exactly the same query
6736 is entered next.
6737
6738 https://bugs.webkit.org/show_bug.cgi?id=20462
6739
6740 Reviewed by Tim Hatcher.
6741
6742 * page/inspector/inspector.js:
6743
jmalonzo@webkit.orgdd470402008-08-21 11:22:51 +000067442008-08-21 Marco Barisione <marco.barisione@collabora.co.uk>
6745
6746 Reviewed by Mark Rowe.
6747
6748 http://bugs.webkit.org/show_bug.cgi?id=19656
6749 [SOUP] The gio code should call didFail() instead of
6750 didFinishLoading() in case of error
6751
6752 In case of error call didFail() instead of didReceiveResponse() and
6753 didFinishLoading().
6754
6755 * platform/network/soup/ResourceHandleSoup.cpp:
6756 (WebCore::networkErrorForFile):
6757 (WebCore::readCallback):
6758 (WebCore::openCallback):
6759 (WebCore::queryInfoCallback):
6760
mrowe@apple.com72a95b12008-08-21 04:01:51 +000067612008-08-20 Mark Rowe <mrowe@apple.com>
6762
mrowe@apple.com4e593f42008-08-21 06:52:42 +00006763 Reviewed by Jon Honeycutt.
6764
6765 Fix build failure.
6766
6767 * bridge/c/c_instance.cpp:
6768 (KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
6769 as that is what NPEnumerationFunctionPtr is declared as accepting.
6770
67712008-08-20 Mark Rowe <mrowe@apple.com>
6772
mrowe@apple.com72a95b12008-08-21 04:01:51 +00006773 Reviewed by Dan Bernstein.
6774
6775 Build fix. Handle kCGInterpolationMedium in switch statements if it is available.
6776
6777 * platform/graphics/GraphicsContext.h:
6778 (WebCore::):
6779 * platform/graphics/cg/GraphicsContextCG.cpp:
6780 (WebCore::GraphicsContext::setImageInterpolationQuality):
6781 (WebCore::GraphicsContext::imageInterpolationQuality):
6782
mitz@apple.comaa938792008-08-21 00:33:29 +000067832008-08-20 Dan Bernstein <mitz@apple.com>
6784
6785 Rubber-stamped by John Sullivan.
6786
6787 - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and
6788 rename related methods and variables accordingly.
6789
6790 * WebCore.base.exp:
6791 * page/FrameView.cpp:
6792 (WebCore::FrameViewPrivate::FrameViewPrivate):
6793 (WebCore::FrameView::shouldUpdateWhileOffscreen):
6794 (WebCore::FrameView::setShouldUpdateWhileOffscreen):
6795 * page/FrameView.h:
6796 * platform/ScrollView.h:
6797 * platform/mac/ScrollViewMac.mm:
6798 (WebCore::ScrollView::updateContents):
6799
beidson@apple.com2ace6b12008-08-21 00:13:12 +000068002008-08-20 Brady Eidson <beidson@apple.com>
6801
6802 Reviewed by Mitzpettel
6803
6804 <rdar://problem/6163636> - Many images broken in Mail
6805
6806 This can be traced back to the preload scanner. With that change, CachedResources are created a lot
6807 sooner than before and confuse the WebArchive machinery.
6808
6809 When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
6810 such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
6811 machinery and nothing is known about where the data will eventually come from.
6812
6813 * loader/DocumentLoader.cpp:
6814 (WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is
6815 CachedResource::PreloadReferenced.
6816
zecke@webkit.orga8fa0e12008-08-20 22:50:39 +000068172008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>
6818
6819 Unreviewed compile fix
6820
6821 Catch up with the JSValue::type elimination.
6822
6823 * bridge/qt/qt_instance.cpp:
6824 (KJS::Bindings::QtRuntimeObjectImp::construct):
6825 (KJS::Bindings::QtInstance::defaultValue):
6826 * bridge/qt/qt_runtime.cpp:
6827 (KJS::Bindings::QtRuntimeConnectionMethod::call):
6828
mrowe@apple.com2d74ec92008-08-20 22:15:53 +000068292008-08-20 Chris Teague <chris.teague@gmail.com>
6830
6831 Reviewed by Mark Rowe.
6832
6833 Fix https://bugs.webkit.org/show_bug.cgi?id=20449
6834 Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined
6835
6836 * ChangeLog:
6837 * loader/FrameLoader.cpp:
6838 (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
6839
simon.fraser@apple.combe1d24c2008-08-20 21:57:22 +000068402008-08-20 Simon Fraser <simon.fraser@apple.com>
6841
6842 Reviewed by Dave Hyatt
6843
6844 getComputedStyle() for webkitTransform should return a transform
6845 that does not have the transform origin baked into it.
6846 https://bugs.webkit.org/show_bug.cgi?id=20464
6847
6848 Test: fast/css/getComputedStyle-transform.html
6849
6850 * css/CSSComputedStyleDeclaration.cpp:
6851 (WebCore::computedTransform):
6852 * rendering/style/RenderStyle.cpp:
6853 (WebCore::RenderStyle::applyTransform):
6854 * rendering/style/RenderStyle.h:
6855
andersca@apple.com021ce772008-08-20 21:04:12 +000068562008-08-20 Josh Aas <joshmoz@gmail.com>
6857
6858 Reviewed and landed by Anders.
6859
6860 <rdar://problem/6163636>
6861 rename NPCocoaEvent's "event" struct to "data" (20446)
6862
6863 * bridge/npapi.h:
6864 (_NPCocoaEvent::):
6865
bdakin@apple.com699d13d2008-08-20 20:46:28 +000068662008-08-20 Beth Dakin <bdakin@apple.com>
6867
darin@apple.com07c80c62008-09-05 18:15:43 +00006868 Reviewed by Darin Adler.
bdakin@apple.com699d13d2008-08-20 20:46:28 +00006869
6870 Fix for <rdar://problem/6145626>
6871 This patch fixes a number of remaining problems getting
6872 disconnected frames to work correctly with markAllMatchesForText()
6873 and findString(). Details inline.
6874
6875 This was a static helper function in Frame, but this patch requires
6876 the same functionality in Editor, so I just added it as a function
6877 on Node.
6878 * dom/Node.cpp:
6879 (WebCore::Node::isInShadowTree):
6880 * dom/Node.h:
6881
6882 * editing/Editor.cpp:
6883 (WebCore::Editor::insideVisibleArea): Returns false if
6884 excludeFromTextSearch() is true.
6885
6886 In a normal (non-disconnected) frame, findString returns a range of
6887 the document node if the text is not found in the frame. I changed
6888 firstVisibleRange and lastVisibleRange to match that behavior when
6889 the text is not found
6890 (WebCore::Editor::firstVisibleRange):
6891 (WebCore::Editor::lastVisibleRange):
6892
6893 Here are the bulk of the changes in the patch. A lot of text was
6894 not being found in disconnected frames because I failed to account
6895 for all of the possible problems associated with shadow trees. That
6896 is fixed here.
6897 (WebCore::Editor::nextVisibleRange):
6898 * editing/Editor.h:
6899
6900 excludeFromTextSearch() is new. It allows a WebKit client to mark a
6901 frame as not-text-searchable through SPI.
6902 * WebCore.base.exp:
6903 * page/Frame.cpp:
6904 (WebCore::Frame::excludeFromTextSearch):
6905 (WebCore::Frame::setExcludeFromTextSearch):
6906 (WebCore::FramePrivate::FramePrivate):
6907 * page/Frame.h:
6908 * page/FramePrivate.h:
6909
6910 (WebCore::Frame::findString):
6911 (WebCore::Frame::markAllMatchesForText): I kept running into an
6912 assertion failure in paining code because of the forced paint on
6913 empty visible rects.
6914
timothy@apple.com301befc2008-08-20 19:10:54 +000069152008-08-20 Timothy Hatcher <timothy@apple.com>
6916
6917 Adds a positon box to the Inspector's Metrics sidebar
6918 pane. When an element is not statically positioned, there
6919 is now a position box that show top, right, bottom and
6920 left computed values.
6921
6922 Reviewed by Kevin McCullough.
6923
6924 * English.lproj/localizedStrings.js: Updated the strings.
6925 * page/inspector/MetricsSidebarPane.js:
6926 (WebInspector.MetricsSidebarPane.prototype.update):
6927 Renamed the boxPartValue function to createBoxPartElement
6928 and made it create the entire element. Made it understand
6929 how to get position style properties. Don't use the figure dash
6930 when 0px is used for positions, since the 0 is meaningful there.
6931 Instead use the figure dash when a position is auto.
6932 * page/inspector/inspector.css: Added a new rule for position.
6933
mrowe@apple.com37686d42008-09-04 00:10:39 +000069342008-08-20 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com2a5ecc02008-08-20 18:34:56 +00006935
6936 Reviewed by Beth Dakin
6937
6938 Qt build fix
6939
6940 * WebCore.pro:
6941
mitz@apple.comedaa9042008-08-20 18:28:07 +000069422008-08-20 Dan Bernstein <mitz@apple.com>
6943
6944 Reviewed by Anders Carlsson.
6945
6946 - avoid using a deprecated NSScroller method on Leopard
6947
6948 * platform/mac/PlatformScrollBarMac.mm:
6949 (WebCore::PlatformScrollbar::updateThumbPosition):
6950 (WebCore::PlatformScrollbar::updateThumbProportion):
6951
jmalonzo@webkit.org6e0a3082008-08-20 11:40:31 +000069522008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
6953
6954 Reviewed by Oliver Hunt.
6955
6956 Gtk build fix
6957
6958 * GNUmakefile.am:
6959 * page/AccessibilityTable.cpp: Change nil to 0
6960 (WebCore::AccessibilityTable::cellForColumnAndRow):
6961
ap@webkit.org01aff702008-08-20 07:23:06 +000069622008-08-19 Alexey Proskuryakov <ap@webkit.org>
6963
6964 Reviewed by Geoff Garen.
6965
6966 Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
6967
6968 * ForwardingHeaders/kjs/JSLock.h: Added.
6969 * WebCore.vcproj/WebCore.vcproj:
6970 * bindings/js/GCController.cpp:
6971 (WebCore::collect):
6972 (WebCore::GCController::gcTimerFired):
6973 (WebCore::GCController::garbageCollectNow):
6974 * bindings/js/JSCustomSQLStatementCallback.cpp:
6975 (WebCore::JSCustomSQLStatementCallback::handleEvent):
6976 * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
6977 (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
6978 * bindings/js/JSCustomSQLTransactionCallback.cpp:
6979 (WebCore::JSCustomSQLTransactionCallback::handleEvent):
6980 * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
6981 (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
6982 * bindings/js/JSCustomVoidCallback.cpp:
6983 (WebCore::JSCustomVoidCallback::handleEvent):
6984 * bindings/js/JSCustomXPathNSResolver.cpp:
6985 (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
6986 * bindings/js/JSDOMWindowBase.cpp:
6987 (WebCore::DOMWindowTimer::~DOMWindowTimer):
6988 (WebCore::JSDOMWindowBase::clear):
6989 (WebCore::JSDOMWindowBase::timerFired):
6990 * bindings/js/JSEventCustom.cpp:
6991 (WebCore::toJS):
6992 * bindings/js/JSEventListener.cpp:
6993 (WebCore::JSAbstractEventListener::handleEvent):
6994 * bindings/js/JSNSResolver.cpp:
6995 (WebCore::JSNSResolver::lookupNamespaceURI):
6996 * bindings/js/JSNodeFilterCondition.cpp:
6997 (WebCore::JSNodeFilterCondition::acceptNode):
6998 * bindings/js/ScheduledAction.cpp:
6999 (WebCore::ScheduledAction::execute):
7000 * bindings/js/ScriptController.cpp:
7001 (WebCore::ScriptController::evaluate):
7002 (WebCore::ScriptController::clearWindowShell):
7003 (WebCore::ScriptController::createHTMLEventHandler):
7004 (WebCore::ScriptController::createSVGEventHandler):
7005 (WebCore::ScriptController::initScript):
7006 (WebCore::ScriptController::updateDocument):
7007 (WebCore::ScriptController::bindingRootObject):
7008 (WebCore::ScriptController::windowScriptNPObject):
7009 (WebCore::ScriptController::createScriptObjectForPluginElement):
7010 (WebCore::ScriptController::clearScriptObjects):
7011 * bindings/js/ScriptControllerMac.mm:
7012 (WebCore::ScriptController::windowScriptObject):
7013 * bindings/objc/WebScriptObject.mm:
7014 (_didExecute):
7015 (-[WebScriptObject callWebScriptMethod:withArguments:]):
7016 (-[WebScriptObject evaluateWebScript:]):
7017 (-[WebScriptObject setValue:forKey:]):
7018 (-[WebScriptObject valueForKey:]):
7019 (-[WebScriptObject removeWebScriptKey:]):
7020 (-[WebScriptObject stringRepresentation]):
7021 (-[WebScriptObject webScriptValueAtIndex:]):
7022 (-[WebScriptObject setWebScriptValueAtIndex:value:]):
7023 (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
7024 * bridge/NP_jsobject.cpp:
7025 (_NPN_InvokeDefault):
7026 (_NPN_Invoke):
7027 (_NPN_Evaluate):
7028 (_NPN_GetProperty):
7029 (_NPN_SetProperty):
7030 (_NPN_RemoveProperty):
7031 (_NPN_HasProperty):
7032 (_NPN_HasMethod):
7033 (_NPN_Enumerate):
7034 * bridge/c/c_class.cpp:
7035 (KJS::Bindings::CClass::~CClass):
7036 (KJS::Bindings::CClass::methodsNamed):
7037 (KJS::Bindings::CClass::fieldNamed):
7038 * bridge/c/c_instance.cpp:
7039 (KJS::Bindings::CInstance::invokeMethod):
7040 (KJS::Bindings::CInstance::invokeDefaultMethod):
7041 (KJS::Bindings::CInstance::getPropertyNames):
7042 * bridge/c/c_runtime.cpp:
7043 (KJS::Bindings::CField::valueFromInstance):
7044 (KJS::Bindings::CField::setValueToInstance):
7045 * bridge/c/c_utility.cpp:
7046 (KJS::Bindings::convertValueToNPVariant):
7047 (KJS::Bindings::convertNPVariantToValue):
7048 * bridge/jni/jni_class.cpp:
7049 (JavaClass::JavaClass):
7050 (JavaClass::~JavaClass):
7051 * bridge/jni/jni_instance.cpp:
7052 (JavaInstance::stringValue):
7053 * bridge/jni/jni_jsobject.mm:
7054 (JavaJSObject::call):
7055 (JavaJSObject::eval):
7056 (JavaJSObject::getMember):
7057 (JavaJSObject::setMember):
7058 (JavaJSObject::removeMember):
7059 (JavaJSObject::getSlot):
7060 (JavaJSObject::setSlot):
7061 (JavaJSObject::toString):
7062 (JavaJSObject::convertValueToJObject):
7063 (JavaJSObject::convertJObjectToValue):
7064 * bridge/jni/jni_objc.mm:
7065 (KJS::Bindings::dispatchJNICall):
7066 * bridge/jni/jni_runtime.cpp:
7067 (appendClassName):
7068 (JavaMethod::signature):
7069 * bridge/jni/jni_runtime.h:
7070 (KJS::Bindings::JavaString::JavaString):
7071 (KJS::Bindings::JavaString::_commonInit):
7072 (KJS::Bindings::JavaString::~JavaString):
7073 (KJS::Bindings::JavaString::UTF8String):
7074 * bridge/jni/jni_utility.cpp:
7075 (KJS::Bindings::convertValueToJValue):
7076 * bridge/npruntime.cpp:
7077 (_NPN_GetStringIdentifier):
7078 * bridge/objc/objc_instance.mm:
7079 (ObjcInstance::moveGlobalExceptionToExecState):
7080 (ObjcInstance::invokeMethod):
7081 (ObjcInstance::invokeDefaultMethod):
7082 (ObjcInstance::setValueOfUndefinedField):
7083 (ObjcInstance::getValueOfUndefinedField):
7084 * bridge/objc/objc_runtime.mm:
7085 (ObjcField::valueFromInstance):
7086 (ObjcField::setValueToInstance):
7087 * bridge/objc/objc_utility.mm:
7088 (KJS::Bindings::convertValueToObjcValue):
7089 (KJS::Bindings::convertNSStringToString):
7090 (KJS::Bindings::convertObjcValueToValue):
7091 * bridge/qt/qt_instance.cpp:
7092 (KJS::Bindings::QtRuntimeObjectImp::removeFromCache):
7093 (KJS::Bindings::QtInstance::~QtInstance):
7094 (KJS::Bindings::QtInstance::getQtInstance):
7095 (KJS::Bindings::QtInstance::getRuntimeObject):
7096 * bridge/qt/qt_runtime.cpp:
7097 (KJS::Bindings::convertValueToQVariant):
7098 (KJS::Bindings::convertQVariantToValue):
7099 (KJS::Bindings::QtRuntimeMetaMethod::call):
7100 (KJS::Bindings::QtRuntimeConnectionMethod::call):
7101 (KJS::Bindings::QtConnectionObject::QtConnectionObject):
7102 (KJS::Bindings::QtConnectionObject::execute):
7103 * bridge/runtime.cpp:
7104 (KJS::Bindings::Instance::createRuntimeObject):
7105 * bridge/testbindings.cpp:
7106 (main):
7107 * bridge/testbindings.mm:
7108 (main):
7109 * bridge/testqtbindings.cpp:
7110 (main):
7111 * dom/Document.cpp:
7112 (WebCore::Document::~Document):
7113 * dom/Node.cpp:
7114 (WebCore::Node::setDocument):
7115 * history/CachedPage.cpp:
7116 (WebCore::CachedPage::CachedPage):
7117 (WebCore::CachedPage::restore):
7118 (WebCore::CachedPage::clear):
7119 * loader/FrameLoader.cpp:
7120 (WebCore::getString):
7121 * page/InspectorController.cpp:
7122 (WebCore::ConsoleMessage::ConsoleMessage):
7123 (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
7124 (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
7125 (WebCore::getResourceDocumentNode):
7126 (WebCore::search):
7127 (WebCore::inspectedWindow):
7128 (WebCore::wrapCallback):
7129 (WebCore::currentCallFrame):
7130 (WebCore::profiles):
7131 (WebCore::InspectorController::focusNode):
7132 (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
7133 (WebCore::InspectorController::addDatabaseScriptResource):
7134 (WebCore::InspectorController::addScriptProfile):
7135 * page/JavaScriptCallFrame.cpp:
7136 (WebCore::JavaScriptCallFrame::evaluate):
7137 * page/JavaScriptProfileNode.cpp:
7138 (WebCore::getTotalTime):
7139 (WebCore::getSelfTime):
7140 (WebCore::getTotalPercent):
7141 (WebCore::getSelfPercent):
7142 (WebCore::getNumberOfCalls):
7143 (WebCore::getChildren):
7144 (WebCore::getVisible):
7145 * page/Page.cpp:
7146 * page/mac/FrameMac.mm:
7147 * plugins/PluginView.cpp:
7148 (WebCore::PluginView::start):
7149 (WebCore::getString):
7150 (WebCore::PluginView::performRequest):
7151 (WebCore::PluginView::bindingInstance):
7152 * plugins/gtk/PluginViewGtk.cpp:
7153 (WebCore::PluginView::paint):
7154 (WebCore::PluginView::handleKeyboardEvent):
7155 (WebCore::PluginView::handleMouseEvent):
7156 (WebCore::PluginView::setNPWindowRect):
7157 (WebCore::PluginView::stop):
7158 (WebCore::PluginView::init):
7159 * plugins/qt/PluginViewQt.cpp:
7160 (WebCore::PluginView::setNPWindowRect):
7161 (WebCore::PluginView::stop):
7162 (WebCore::PluginView::init):
7163 * plugins/win/PluginViewWin.cpp:
7164 (WebCore::PluginView::dispatchNPEvent):
7165 (WebCore::PluginView::handleKeyboardEvent):
7166 (WebCore::PluginView::handleMouseEvent):
7167 (WebCore::PluginView::setNPWindowRect):
7168 (WebCore::PluginView::stop):
7169 * xml/XMLHttpRequest.cpp:
7170 (WebCore::XMLHttpRequest::clearResponse):
7171 (WebCore::XMLHttpRequest::didFinishLoading):
7172 (WebCore::XMLHttpRequest::didReceiveData):
7173
eric@webkit.orgbac93762008-08-19 23:33:07 +000071742008-08-19 Eric Seidel <eric@webkit.org>
7175
7176 Reviewed by Geoff Garen.
7177
7178 Add the beginnings of Skia graphics support to WebCore
7179 as I try to begin the long process of un-forking the changes
7180 needed to WebCore to make Andriod's WebCore build.
7181
7182 I'll follow this up with actual *Skia.cpp files in a separate patch.
7183
7184 * platform/graphics/AffineTransform.h:
7185 * platform/graphics/FloatPoint.h:
7186 * platform/graphics/FloatRect.h:
7187 * platform/graphics/Gradient.h:
7188 * platform/graphics/GraphicsContext.h:
7189 * platform/graphics/Image.h:
7190 * platform/graphics/ImageBuffer.h:
7191 * platform/graphics/ImageSource.h:
7192 * platform/graphics/IntPoint.h:
7193 * platform/graphics/IntRect.h:
7194 * platform/graphics/Path.h:
7195 * platform/graphics/Pattern.h:
7196 * svg/graphics/SVGPaintServerPattern.h:
7197 * svg/graphics/SVGPaintServerSolid.h:
7198
sfalken@apple.com3f69b332008-08-19 22:34:37 +000071992008-08-19 Steve Falkenburg <sfalken@apple.com>
7200
sfalken@apple.com45d22802008-08-19 22:46:31 +00007201 Fix Windows build more.
7202
7203 * WebCore.vcproj/WebCore.vcproj:
7204
72052008-08-19 Steve Falkenburg <sfalken@apple.com>
7206
sfalken@apple.com3f69b332008-08-19 22:34:37 +00007207 Fix Windows build.
7208
7209 * page/AccessibilityRenderObject.cpp:
7210 (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
7211
mrowe@apple.com37686d42008-09-04 00:10:39 +000072122008-08-19 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com7c7b5f32008-08-19 22:05:37 +00007213
7214 Reviewed by Beth Dakin.
7215
7216 <rdar://problem/4003764> Expose tables as AXTables
7217
7218 Tests: accessibility/table-attributes.html
7219 accessibility/table-cell-spans.html
7220 accessibility/table-cells.html
7221 accessibility/table-detection.html
7222 accessibility/table-sections.html
7223 accessibility/table-with-rules.html
7224
7225 * WebCore.xcodeproj/project.pbxproj:
7226 * page/AXObjectCache.cpp:
7227 (WebCore::AXObjectCache::get):
7228 * page/AccessibilityObject.h:
7229 (WebCore::):
7230 (WebCore::AccessibilityObject::isDataTable):
7231 (WebCore::AccessibilityObject::isTableRow):
7232 (WebCore::AccessibilityObject::isTableColumn):
7233 (WebCore::AccessibilityObject::isTableCell):
7234 * page/AccessibilityRenderObject.cpp:
7235 (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
7236 * page/AccessibilityTable.cpp: Added.
7237 (WebCore::AccessibilityTable::AccessibilityTable):
7238 (WebCore::AccessibilityTable::~AccessibilityTable):
7239 (WebCore::AccessibilityTable::create):
7240 (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
7241 (WebCore::AccessibilityTable::clearChildren):
7242 (WebCore::AccessibilityTable::addChildren):
7243 (WebCore::AccessibilityTable::headerContainer):
7244 (WebCore::AccessibilityTable::columns):
7245 (WebCore::AccessibilityTable::rows):
7246 (WebCore::AccessibilityTable::rowHeaders):
7247 (WebCore::AccessibilityTable::columnHeaders):
7248 (WebCore::AccessibilityTable::cells):
7249 (WebCore::AccessibilityTable::columnCount):
7250 (WebCore::AccessibilityTable::rowCount):
7251 (WebCore::AccessibilityTable::cellForColumnAndRow):
7252 (WebCore::AccessibilityTable::roleValue):
7253 (WebCore::AccessibilityTable::accessibilityIsIgnored):
7254 (WebCore::AccessibilityTable::title):
7255 (WebCore::AccessibilityTable::isDataTable):
7256 * page/AccessibilityTable.h: Added.
7257 * page/AccessibilityTableCell.cpp: Added.
7258 (WebCore::AccessibilityTableCell::AccessibilityTableCell):
7259 (WebCore::AccessibilityTableCell::~AccessibilityTableCell):
7260 (WebCore::AccessibilityTableCell::create):
7261 (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
7262 (WebCore::AccessibilityTableCell::rowIndexRange):
7263 (WebCore::AccessibilityTableCell::columnIndexRange):
7264 * page/AccessibilityTableCell.h: Added.
7265 (WebCore::AccessibilityTableCell::isTableCell):
7266 (WebCore::AccessibilityTableCell::roleValue):
7267 * page/AccessibilityTableColumn.cpp: Added.
7268 (WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
7269 (WebCore::AccessibilityTableColumn::~AccessibilityTableColumn):
7270 (WebCore::AccessibilityTableColumn::create):
7271 (WebCore::AccessibilityTableColumn::setParentTable):
7272 (WebCore::AccessibilityTableColumn::elementRect):
7273 (WebCore::AccessibilityTableColumn::size):
7274 (WebCore::AccessibilityTableColumn::children):
7275 (WebCore::AccessibilityTableColumn::headerObject):
7276 (WebCore::AccessibilityTableColumn::headerObjectForSection):
7277 (WebCore::AccessibilityTableColumn::addChildren):
7278 * page/AccessibilityTableColumn.h: Added.
7279 (WebCore::AccessibilityTableColumn::parentObject):
7280 (WebCore::AccessibilityTableColumn::roleValue):
7281 (WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
7282 (WebCore::AccessibilityTableColumn::isTableColumn):
7283 (WebCore::AccessibilityTableColumn::setColumnIndex):
7284 (WebCore::AccessibilityTableColumn::columnIndex):
7285 * page/AccessibilityTableHeaderContainer.cpp: Added.
7286 (WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
7287 (WebCore::AccessibilityTableHeaderContainer::~AccessibilityTableHeaderContainer):
7288 (WebCore::AccessibilityTableHeaderContainer::create):
7289 (WebCore::AccessibilityTableHeaderContainer::children):
7290 (WebCore::AccessibilityTableHeaderContainer::elementRect):
7291 (WebCore::AccessibilityTableHeaderContainer::size):
7292 (WebCore::AccessibilityTableHeaderContainer::addChildren):
7293 * page/AccessibilityTableHeaderContainer.h: Added.
7294 (WebCore::AccessibilityTableHeaderContainer::roleValue):
7295 (WebCore::AccessibilityTableHeaderContainer::setParentTable):
7296 (WebCore::AccessibilityTableHeaderContainer::parentObject):
7297 (WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
7298 * page/AccessibilityTableRow.cpp: Added.
7299 (WebCore::AccessibilityTableRow::AccessibilityTableRow):
7300 (WebCore::AccessibilityTableRow::~AccessibilityTableRow):
7301 (WebCore::AccessibilityTableRow::create):
7302 (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
7303 (WebCore::AccessibilityTableRow::headerObject):
7304 * page/AccessibilityTableRow.h: Added.
7305 (WebCore::AccessibilityTableRow::isTableRow):
7306 (WebCore::AccessibilityTableRow::roleValue):
7307 (WebCore::AccessibilityTableRow::setRowIndex):
7308 (WebCore::AccessibilityTableRow::rowIndex):
7309 * page/mac/AccessibilityObjectWrapper.mm:
7310 (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
7311 (RoleEntry::):
7312 (-[AccessibilityObjectWrapper roleDescription]):
7313 (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
7314 (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
7315 (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
7316
sfalken@apple.comb83d4692008-08-19 18:39:44 +000073172008-08-19 Steve Falkenburg <sfalken@apple.com>
7318
7319 Build fix.
7320 Add buildfailed support to stop builds early (preventing inaccurate error messages).
7321 Add missing post-build rule to Release.
7322
7323 * WebCore.vcproj/QTMovieWin.vcproj:
7324
timothy@apple.comda3aa632008-08-19 18:33:02 +000073252008-08-19 Keishi Hattori <casey.hattori@gmail.com>
7326
timothy@apple.com7d08c322008-08-19 18:33:27 +00007327 Added support for console.count in the inspector.
7328
7329 Reviewed by Geoff Garen.
7330
7331 * page/Console.cpp:
7332 (WebCore::Console::count):
7333 * page/Console.h:
7334 * page/Console.idl: Added console.count.
7335 * page/InspectorController.cpp:
7336 (WebCore::InspectorController::didCommitLoad): Clears m_counts.
7337 (WebCore::InspectorController::count): Updates the count number
7338 sing "title@source:line" as the identifier, and adds a
7339 message to the console.
7340 * page/InspectorController.h: Added m_counts.
7341
73422008-08-19 Keishi Hattori <casey.hattori@gmail.com>
7343
timothy@apple.comda3aa632008-08-19 18:33:02 +00007344 Clear console.time timers when changing page.
7345
7346 Reviewed by Geoff Garen.
7347
7348 * page/InspectorController.cpp:
7349 (WebCore::InspectorController::didCommitLoad):
7350
adele@apple.com1f2d7e02008-08-19 17:55:58 +000073512008-08-19 Eric Carlson <eric.carlson@apple.com>
7352
7353 Reviewed by Adele.
7354
7355 Fix for <rdar://problem/6154695> Full-page movies flicker while playing
7356 https://bugs.webkit.org/show_bug.cgi?id=20404
7357
7358 Ignore setVisible() when visibility doesn't change.
7359
7360 * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
7361 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
7362 (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
7363 (WebCore::MediaPlayerPrivate::setVisible):
7364
timothy@apple.com9d9821a2008-08-19 17:00:26 +000073652008-08-19 Timothy Hatcher <timothy@apple.com>
7366
timothy@apple.come058a792008-08-19 17:01:12 +00007367 Fixes a bug in the Profile view where switching sort order, then
7368 switching from heavy to tree mode would show the tree in the
7369 previous sort order.
7370
7371 https://bugs.webkit.org/show_bug.cgi?id=20441
7372
7373 Reviewed by Kevin McCullough.
7374
7375 * page/inspector/ProfileView.js:
7376 (WebInspector.ProfileView.prototype._changeView): Call _sortProfile
7377 on the next profile before assigning it to this.profile.
7378 (WebInspector.ProfileView.prototype._sortData): Call _sortProfile.
7379 (WebInspector.ProfileView.prototype._sortProfile): Moves from
7380 _sortData and takes a profile argument. If the profile passed in
7381 matches the this.profile, then call refresh.
7382
73832008-08-18 Timothy Hatcher <timothy@apple.com>
7384
timothy@apple.come525e402008-08-19 17:01:00 +00007385 Changed the default sort order now that heavy view is the default.
7386 Also fixes a bug where the heavy profile was not sorted at first.
7387
7388 https://bugs.webkit.org/show_bug.cgi?id=20440
7389
7390 Reviewed by Kevin McCullough.
7391
7392 * page/inspector/ProfileView.js:
7393 (WebInspector.ProfileView): Changed the default sort column. Also assign
7394 heavyProfile to profile, so the sortSelfTimeDescending call happens
7395 on the heavy profile before assigning to this.profile.
7396
73972008-08-18 Timothy Hatcher <timothy@apple.com>
7398
timothy@apple.comc9287f32008-08-19 17:00:36 +00007399 Add support for editing DOM properties and scope variables by double
7400 clicking a property to enter edit mode.
7401
7402 https://bugs.webkit.org/show_bug.cgi?id=20415
7403
7404 Reviewed by Kevin McCullough.
7405
7406 * page/inspector/ObjectPropertiesSection.js:
7407 (WebInspector.ObjectPropertiesSection): Set editable to true by default.
7408 (WebInspector.ObjectPropertiesSection.prototype.onpopulate):
7409 Factored out code into update, and calls update.
7410 (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate.
7411 Call removeChildren since this method can be called multiple times now.
7412 (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title
7413 gets made later in onattach.
7414 (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early
7415 if shouldRefreshChildren is true. Call removeChildren since this method can be
7416 called multiple times now.
7417 (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing.
7418 (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update.
7419 (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for
7420 this element (code moved from the constructor.)
7421 (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all
7422 sibling property elements.
7423 (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call
7424 WebInspector.startEditing after rememebring some context.
7425 (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft
7426 for the list element, since it might have scrolled during editing.
7427 (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded
7428 then restore the state from the context. Then call update to restore the title.
7429 (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled
7430 if the user input and the previous input are the same. Call editingEnded, then call applyExpression
7431 to commit the user input.
7432 (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression
7433 and stores the result on the object for the property name of this element. If the expression is
7434 empty, delete the property and remove the tree element.
7435 * page/inspector/ScopeChainSidebarPane.js:
7436 (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused
7437 property on each ObjectPropertiesSection.
7438 (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach
7439 since it is now implemented.
7440 * page/inspector/ScriptsPanel.js:
7441 (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument
7442 that defaults to true if omitted. It specifies whether to call update on the scope chain.
7443 * page/inspector/inspector.css: New styles.
7444 * page/inspector/treeoutline.js:
7445 (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren
7446 change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
7447
74482008-08-18 Timothy Hatcher <timothy@apple.com>
7449
timothy@apple.com9d9821a2008-08-19 17:00:26 +00007450 Surround the expression to be evaluated in parenthesis so the
7451 result of the eval is the result of the whole expression not
7452 the last potential sub-expression. So evaluating {x: 123}
7453 will show the Object not 123.
7454
7455 https://bugs.webkit.org/show_bug.cgi?id=20428
7456
7457 Reviewed by Kevin McCullough.
7458
7459 * page/inspector/Console.js:
7460 (Console.prototype._evalInInspectedWindow): Add parenthesis
7461 around the expression. And add couple comments.
7462
kmccullough@apple.come8ac2f32008-08-19 16:38:06 +000074632008-08-19 Kevin McCullough <kmccullough@apple.com>
7464
7465 Reviewed by Geoff.
7466
7467 -Implement a page() function to extract a common code pattern.
7468
7469 * WebCore.xcodeproj/project.pbxproj:
7470 * page/Console.cpp:
7471 (WebCore::Console::addMessage):
7472 (WebCore::Console::error):
7473 (WebCore::Console::info):
7474 (WebCore::Console::log):
7475 (WebCore::Console::dir):
7476 (WebCore::Console::assertCondition):
7477 (WebCore::Console::time):
7478 (WebCore::Console::timeEnd):
7479 (WebCore::Console::group):
7480 (WebCore::Console::groupEnd):
7481 (WebCore::Console::finishedProfiling):
7482 (WebCore::Console::warn):
7483 (WebCore::Console::framePage):
7484 * page/Console.h:
7485
darin@apple.com349e1eb2008-08-19 04:39:04 +000074862008-08-12 Darin Adler <darin@apple.com>
7487
7488 Reviewed by Geoff.
7489
7490 - eliminate JSValue::type()
7491
7492 * bridge/c/c_instance.cpp:
7493 (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType
7494 argument instead of JSType argument. Removed unneeded code to handle
7495 boolean, since that's never passed.
7496 * bridge/c/c_instance.h: Ditto.
7497
7498 * bridge/c/c_utility.cpp:
7499 (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions
7500 instead of JSValue::type(). Removed unneeded code to handle
7501 "unspecified".
7502
7503 * bridge/jni/jni_instance.cpp:
7504 (JavaInstance::defaultValue): Take PreferredPrimitiveType argument
7505 instead of JSType argument. Removed unneeded code to handle boolean.
7506 * bridge/jni/jni_instance.h: Ditto.
7507
7508 * bridge/jni/jni_jsobject.mm:
7509 (JavaJSObject::convertValueToJObject): Use JSValue::is functions
7510 instead of JSValue::type().
7511
7512 * bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument
7513 instead of JSType argument. Removed unused argument.
7514 * bridge/objc/objc_instance.mm:
7515 (ObjcInstance::getValueOfUndefinedField): Removed unused argument.
7516 (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument
7517 instead of JSType argument. Removed unneeded code to handle boolean
7518 and another dead code path for unknown types.
7519
7520 * bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument
7521 instead of JSType argument. Removed override of type() that caused
7522 the fallback object to return "UndefinedType" when there is no
7523 invokeUndefinedMethodFromWebScript:withArguments: method defined.
7524 That didn't accomplish much, since most checks for undefined don't
7525 ever call type().
7526 * bridge/objc/objc_runtime.mm:
7527 (ObjcFallbackObjectImp::defaultValue): Ditto.
7528
7529 * bridge/qt/qt_instance.cpp:
7530 (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType
7531 argument instead of JSType argument. Removed unneeded code to handle
7532 boolean.
7533 * bridge/qt/qt_instance.h: Ditto.
7534
7535 * bridge/runtime.h:
7536 (KJS::Bindings::Instance::getValueOfUndefinedField): Removed
7537 unsed argument.
7538 * bridge/runtime_object.cpp:
7539 (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType
7540 argument instead of JSType argument.
7541 * bridge/runtime_object.h: Ditto.
7542
britto@apple.comaf7f8382008-08-19 00:42:13 +000075432008-08-18 Maxime Britto <britto@apple.com>
7544
7545 Reviewed by Adele.
7546
7547 <rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
7548 Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
7549 We shouldn't be able to create another window while we are in pan scrolling.
7550 Other browsers behaviors :
7551 FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
7552 IE7 : Keys are not disabled but stops immediately the panning.
7553 This patch matches FF3 behavior by disabling every key but the esc key.
7554
7555 * page/EventHandler.cpp:
7556 (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped.
7557 (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
7558
mitz@apple.com12404d82008-08-19 00:20:38 +000075592008-08-18 Dan Bernstein <mitz@apple.com>
7560
7561 Reviewed by Dave Hyatt.
7562
7563 - fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
7564
7565 Test: fast/replaced/max-width-percent.html
7566
7567 Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
7568 When false, max-width is not factored into the
7569 calculation.
7570 Changed RenderReplaced and subclasses' calcPrefWidths() to call
7571 calcReplacedWidth(false) and then apply max-width only if it has a
7572 fixed, positive value.
7573
7574 * rendering/RenderBox.cpp:
7575 (WebCore::RenderBox::calcReplacedWidth):
7576 * rendering/RenderBox.h:
7577 * rendering/RenderImage.cpp:
7578 (WebCore::RenderImage::calcReplacedWidth):
7579 (WebCore::RenderImage::calcPrefWidths):
7580 * rendering/RenderImage.h:
7581 * rendering/RenderReplaced.cpp:
7582 (WebCore::RenderReplaced::calcPrefWidths):
7583 * rendering/RenderSVGRoot.cpp:
7584 (WebCore::RenderSVGRoot::calcPrefWidths):
7585 * rendering/RenderVideo.cpp:
7586 (WebCore::RenderVideo::calcReplacedWidth):
7587 (WebCore::RenderVideo::calcPrefWidths):
7588 * rendering/RenderVideo.h:
7589
mrowe@apple.comced88732008-08-18 22:47:28 +000075902008-08-18 Daniel Macks <dmacks@netspace.org>
7591
7592 Reviewed by Mark Rowe.
7593
7594 https://bugs.webkit.org/show_bug.cgi?id=20410
7595 More portable/self-documenting replacement for SIZE_MAX.
7596
7597 * platform/network/curl/FormDataStreamCurl.cpp:
7598 (WebCore::FormDataStream::read):
7599
76002008-08-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com6040db32008-08-18 22:11:10 +00007601
7602 Reviewed by Dave Hyatt
7603
7604 Need to make sure we have an Animation in the AnimationList
7605 before setting the initial value.
7606 https://bugs.webkit.org/show_bug.cgi?id=20408
7607
7608 Test: fast/css/transition_shorthand_parsing.html
7609
7610 * css/CSSStyleSelector.cpp:
7611
kmccullough@apple.com64cb2fd2008-08-18 19:55:35 +000076122008-08-18 Kevin McCullough <kmccullough@apple.com>
7613
kmccullough@apple.com707bd362008-08-18 20:21:57 +00007614 Reviewed by Tim.
7615
7616 <rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
7617 is another profile.
7618
7619 * page/inspector/ProfilesPanel.js:
7620
76212008-08-18 Kevin McCullough <kmccullough@apple.com>
7622
kmccullough@apple.com64cb2fd2008-08-18 19:55:35 +00007623 Reviewed by Geoff.
7624
7625 <rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
7626 all console messages
7627
7628 * page/inspector/Console.js:
7629
jmalonzo@webkit.org5d1e0482008-08-18 11:20:11 +000076302008-08-18 Dirk Schulze <vbs85@gmx.de>
7631
7632 Reviewed by Eric Seidel.
7633
7634 Fixed Canvas for Cairo. Stroke and fill colors didn't work after
7635 the canvas clean up.
7636
7637 https://bugs.webkit.org/show_bug.cgi?id=20405
7638
7639 * html/CanvasRenderingContext2D.cpp:
7640 (WebCore::CanvasRenderingContext2D::fill):
7641 (WebCore::CanvasRenderingContext2D::stroke):
7642 (WebCore::CanvasRenderingContext2D::fillRect):
7643
timothy@apple.comc5e1f8d2008-08-18 03:21:46 +000076442008-08-17 Timothy Hatcher <timothy@apple.com>
7645
7646 Complete in scope variables in the Console when paused.
7647
7648 https://bugs.webkit.org/show_bug.cgi?id=19115
7649
7650 Reviewed by Geoffrey Garen.
7651
7652 * page/inspector/Console.js:
7653 (WebInspector.Console.prototype.completions): If the expressionString
7654 is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame
7655 to get an object that declares all the in scope variables. That way
7656 "top level" expressions are completed.
7657 * page/inspector/ScriptsPanel.js:
7658 (WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame):
7659 Return an object that has all the variables that are in scope for the
7660 selected call frame. The value of each property is just true.
7661 The return object is useful for quick lookups or auto completion.
7662
cwzwarich@webkit.orgac715282008-08-17 21:34:46 +000076632008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
7664
7665 Not reviewed.
7666
7667 Speculative Qt build fix.
7668
7669 * bridge/qt/qt_runtime.cpp:
7670 (KJS::Bindings::convertValueToQVariant):
7671 (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
7672
ggaren@apple.comfea43532008-08-17 20:23:49 +000076732008-08-17 Geoffrey Garen <ggaren@apple.com>
7674
7675 Reviewed by Cameron Zwarich.
ggaren@apple.com6e53d0a2008-08-17 20:28:37 +00007676
7677 Updated project files to XCode 3.1.
7678
7679 * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
7680
76812008-08-17 Geoffrey Garen <ggaren@apple.com>
7682
7683 Reviewed by Cameron Zwarich.
ggaren@apple.comfea43532008-08-17 20:23:49 +00007684
7685 Made room for a free word in JSCell.
7686
7687 Changed JSDOMWindowBase to store its auxiliary data in a subclass of
7688 JSGlobalData, so the two could share a pointer.
7689
7690 Added a bunch of ASSERTs, to help catch over-sized objects.
7691
mrowe@apple.com13570292008-08-16 06:48:10 +000076922008-08-15 Mark Rowe <mrowe@apple.com>
7693
mitz@apple.comb96c1b92008-08-17 03:28:52 +00007694 Reviewed by Dan Bernstein.
7695
7696 Disable dead code stripping in debug builds.
7697
7698 * Configurations/Base.xcconfig:
7699 * WebCore.xcodeproj/project.pbxproj:
7700
77012008-08-15 Mark Rowe <mrowe@apple.com>
7702
mrowe@apple.com13570292008-08-16 06:48:10 +00007703 Rubber-stamped by Geoff Garen.
7704
7705 <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
7706
7707 * Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared
7708 between the Debug configuration and debug Production variant.
7709 * WebCore.xcodeproj/project.pbxproj: Enable the debug variant.
7710
antti@apple.coma05e8b02008-08-15 22:58:06 +000077112008-08-15 Antti Koivisto <antti@apple.com>
7712
7713 Reviewed by Anders.
7714
7715 Don't start preloading body resources before the head is complete. This prevents
7716 body preloads from slowing down initial display when there is limited amount
7717 of bandwidth available.
7718
7719 Works by queuing up found body preloads to DocLoader and only issuing them
7720 after document has rendering.
7721
7722 With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
7723 without affecting complete load time.
7724
7725 * html/PreloadScanner.cpp:
7726 (WebCore::PreloadScanner::PreloadScanner):
7727 (WebCore::PreloadScanner::scanningBody):
7728 (WebCore::PreloadScanner::emitTag):
7729 (WebCore::PreloadScanner::emitCSSRule):
7730 * html/PreloadScanner.h:
7731 * loader/DocLoader.cpp:
7732 (WebCore::DocLoader::preload):
7733 (WebCore::DocLoader::checkForPendingPreloads):
7734 (WebCore::DocLoader::requestPreload):
7735 * loader/DocLoader.h:
7736 * loader/loader.cpp:
7737 (WebCore::Loader::Host::didFinishLoading):
7738 (WebCore::Loader::Host::didFail):
7739
adachan@apple.com94ac38d2008-08-15 21:08:40 +000077402008-08-15 Ada Chan <adachan@apple.com>
7741
7742 Use item's computed style if the render style is 0 before falling back to the <select>'s style.
7743 This way style set on an <hr> within a <select> will be honored.
7744
7745 Reviewed by Dave Hyatt and Dan Bernstein.
7746
7747 * rendering/RenderMenuList.cpp:
7748 (WebCore::RenderMenuList::itemStyle):
7749
antti@apple.com9f7911472008-08-15 20:48:06 +000077502008-08-15 Antti Koivisto <antti@apple.com>
7751
7752 Reviewed by Oliver.
7753
7754 Some loader performance tweaks:
7755 - Make stylesheets highest priority instead of scripts. We block script execution on stylesheets.
7756 Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue
7757 to not delay rendering.
7758 - Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup
7759 can take long time when latency is high so it is good to get started early.
7760 - When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the
7761 load queues. Issue remaining loads to the network layer.
7762
7763 * loader/loader.cpp:
7764 (WebCore::Loader::determinePriority):
7765 (WebCore::Loader::load):
7766 (WebCore::Loader::Host::servePendingRequests):
7767 * loader/loader.h:
7768
timothy@apple.com2d974c32008-08-15 18:35:39 +000077692008-08-15 Timothy Hatcher <timothy@apple.com>
7770
7771 Detach the script debugger when the Web Inspector's window closes.
7772 This has always been the intended design, but never fully implemented.
7773
7774 https://bugs.webkit.org/show_bug.cgi?id=20402
7775
7776 Reviewed by Adam Roben.
7777
7778 * page/InspectorController.cpp:
7779 (WebCore::InspectorController::setWindowVisible): Call stopDebugging()
7780 if the window is no longer visible.
7781
hausmann@webkit.orgbb4b9142008-08-15 18:11:34 +000077822008-08-15 HÃ¥vard Wall <hwall@trolltech.com>
7783
7784 Reviewed by Simon.
7785
hausmann@webkit.org58144a72008-08-15 18:12:08 +00007786 Fixes: compile with QT_NO_CONTEXTMENU
7787
7788 * platform/qt/PlatformMouseEventQt.cpp:
7789 (WebCore::PlatformMouseEvent::PlatformMouseEvent):
7790 * platform/qt/PlatformScrollBarQt.cpp:
7791 (WebCore::PlatformScrollbar::handleMouseMoveEvent):
7792 (WebCore::PlatformScrollbar::handleContextMenuEvent):
7793
77942008-08-15 HÃ¥vard Wall <hwall@trolltech.com>
7795
7796 Reviewed by Simon.
7797
hausmann@webkit.orgbb4b9142008-08-15 18:11:34 +00007798 Fixes: compile with QT_NO_WHEELEVENT
7799
7800 * platform/qt/WheelEventQt.cpp:
7801 (WebCore::PlatformWheelEvent::PlatformWheelEvent):
7802
timothy@apple.com4889e612008-08-15 17:06:14 +000078032008-08-15 Keishi Hattori <casey.hattori@gmail.com>
7804
timothy@apple.comd64639c2008-08-15 17:48:36 +00007805 Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector
7806
7807 https://bugs.webkit.org/show_bug.cgi?id=20210
7808
7809 Reviewed by Tim Hatcher.
7810
7811 * page/Console.cpp:
7812 (WebCore::Console::group):
7813 (WebCore::Console::groupEnd):
7814 * page/Console.h:
7815 (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
7816 * page/InspectorController.cpp:
7817 (WebCore::InspectorController::startGroup): Increments group level by
7818 one and adds console message with StartGroupMessaageLevel.
7819 (WebCore::InspectorController::endGroup): Decrements group level by one
7820 and adds console message with EndGroupMessaageLevel.
7821 * page/InspectorController.h:
7822 * page/inspector/Console.js:
7823 (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup
7824 if the message is StartGroupMessaageLevel.
7825 (WebInspector.ConsoleMessage.prototype.toMessageElement):
7826 (WebInspector.ConsoleGroup.prototype.addMessage):
7827 * page/inspector/inspector.js:
7828
78292008-08-15 Keishi Hattori <casey.hattori@gmail.com>
7830
timothy@apple.com7310b6a2008-08-15 17:35:22 +00007831 Adds support for console.dir to the Inspector
7832
7833 https://bugs.webkit.org/show_bug.cgi?id=19155
7834
7835 Reviewed by Tim Hatcher.
7836
7837 * bindings/js/JSConsoleCustom.cpp:
7838 (WebCore::JSConsole::dir):
7839 * page/Console.cpp:
7840 (WebCore::Console::dir):
7841 * page/Console.h: Added ObjectMessageLevel.
7842 * page/Console.idl: Added console.dir.
7843 * page/inspector/Console.js:
7844 (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an
7845 ObjectPropertiesSection if the MessageLevel is Object.
7846 * page/inspector/ObjectPropertiesSection.js: "in" operator can't be
7847 used on primitive data types.
7848 * page/inspector/inspector.css:
7849
78502008-08-15 Keishi Hattori <casey.hattori@gmail.com>
7851
timothy@apple.com4889e612008-08-15 17:06:14 +00007852 Adds support for clear() in the Inspector console.
7853
7854 https://bugs.webkit.org/show_bug.cgi?id=19873
7855
7856 Reviewed by Tim Hatcher.
7857
7858 * page/inspector/Console.js:
7859
timothy@apple.com12c5b5d2008-08-15 17:02:44 +000078602008-08-15 Anthony Ricaud <rik24d@gmail.com>
7861
7862 Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
7863
7864 Platform distinction and modifier key matching adjusted
7865 by Daniel Jalkut <jalkut@red-sweater.com>
7866
7867 Bug 16313: text search (find) keybindings should work in the Web Inspector
7868 https://bugs.webkit.org/show_bug.cgi?id=16313
7869
7870 Reviewed by Tim Hatcher.
7871
7872 * page/inspector/inspector.js: Added a case for the F key
7873
timothy@apple.coma5ba4392008-08-15 16:50:26 +000078742008-08-15 Keishi Hattori <casey.hattori@gmail.com>
7875
7876 Fix for error when the string doesn't contain a webkit-profile link.
7877
7878 https://bugs.webkit.org/show_bug.cgi?id=20399
7879
7880 Reviewed by Tim Hatcher.
7881
7882 * page/inspector/inspector.js:
7883
timothy@apple.com895b2652008-08-15 16:33:27 +000078842008-08-15 Timothy Hatcher <timothy@apple.com>
7885
7886 Fixes two bugs where JavaScript could be executed from the page
7887 while the debugger is paused.
7888
7889 The first issue was JSLazyEventListener not checking the paused
7890 state before parsing the code.
7891
7892 The second issue was with the PageGroup version of
7893 JavaScriptDebugServer::setJavaScriptPaused always passing false
7894 to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
7895 and not the paused argument.
7896
7897 https://bugs.webkit.org/show_bug.cgi?id=20284
7898
7899 Reviewed by Adam Roben.
7900
7901 * bindings/js/JSEventListener.cpp:
7902 (WebCore::JSLazyEventListener::parseCode): Check the paused
7903 state of the ScriptController. Return early if paused.
7904 * manual-tests/inspector/debugger-execution-while-paused.html: Added.
7905 * page/JavaScriptDebugServer.cpp:
7906 (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
7907 Pass the paused argument to the Page version of setJavaScriptPaused.
7908
ap@webkit.orgbe495d32008-08-15 07:43:48 +000079092008-08-15 Alexey Proskuryakov <ap@webkit.org>
7910
7911 Reviewed by Geoff Garen.
7912
7913 JSStringRef is created context-free, but can get linked to one via an identifier table,
7914 breaking an implicit API contract.
7915
7916 * page/InspectorController.cpp:
7917 (WebCore::jsStringRef):
7918 (WebCore::InspectorController::didParseSource):
7919 (WebCore::InspectorController::failedToParseSource):
7920 * page/JavaScriptProfile.cpp:
7921 (WebCore::getTitleCallback):
7922 Updated for JavaScriptCore changes.
7923
kevino@webkit.org8fe09ff2008-08-15 05:10:57 +000079242008-08-14 Kevin Ollivier <kevino@theolliviers.com>
7925
7926 wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with
7927 an alternative that performs reasonably well. (GDI+ is too slow in many cases.)
7928
7929 * platform/graphics/AffineTransform.h:
7930
adele@apple.com2b2e2f82008-08-15 00:53:36 +000079312008-08-14 Eric Carlson <eric.carlson@apple.com>
7932
7933 Reviewed by Adele.
7934
7935 Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
7936 <video> elements on Windows never becomes visible when a page is restored from the cache
7937
7938 Always pass "set" calls down to MediaPlayerPrivate instead of only when the
7939 value is different from the cached value. Let the implementation decide when
7940 to avoid work because nothing has changed.
7941
7942 * platform/graphics/MediaPlayer.cpp:
7943 (WebCore::MediaPlayer::setVolume):
7944 (WebCore::MediaPlayer::setRate):
7945 (WebCore::MediaPlayer::setRect):
7946 (WebCore::MediaPlayer::setVisible):
7947
timothy@apple.comda810f42008-08-14 23:57:14 +000079482008-08-14 Keishi Hattori <casey.hattori@gmail.com>
7949
7950 Make Firebug command line API respect predefined variables.
7951
timothy@apple.com90751f02008-08-14 23:58:19 +00007952 https://bugs.webkit.org/show_bug.cgi?id=20385
7953
timothy@apple.comda810f42008-08-14 23:57:14 +00007954 Reviewed by Tim Hatcher.
7955
7956 * page/inspector/Console.js:
7957
weinig@apple.com4b51d002008-08-14 23:33:22 +000079582008-08-14 Sam Weinig <sam@webkit.org>
7959
7960 Reviewed by Geoffrey Garen and Timothy Hatcher.
7961
7962 Allow programatically setting the HTMLTokenizers time delay and chunk size
7963 which are used for determining how aggressively we yield.
7964
7965 * WebCore.base.exp:
7966 * html/HTMLTokenizer.cpp:
7967 (WebCore::HTMLTokenizer::begin):
7968 (WebCore::HTMLTokenizer::continueProcessing):
7969 * html/HTMLTokenizer.h:
7970 * page/Page.cpp:
7971 (WebCore::Page::Page):
7972 (WebCore::Page::setCustomHTMLTokenizerTimeDelay):
7973 (WebCore::Page::setCustomHTMLTokenizerChunkSize):
7974 * page/Page.h:
7975 (WebCore::Page::hasCustomHTMLTokenizerTimeDelay):
7976 (WebCore::Page::customHTMLTokenizerTimeDelay):
7977 (WebCore::Page::hasCustomHTMLTokenizerChunkSize):
7978 (WebCore::Page::customHTMLTokenizerChunkSize):
7979
eric@webkit.org89613d22008-08-14 23:19:17 +000079802008-08-14 Eric Seidel <eric@webkit.org>
7981
eric@webkit.org7e897c32008-08-14 23:20:00 +00007982 Reviewed by Beth.
7983
7984 Move us one step closer to cross-platform svg/graphics code
7985
7986 * WebCore.xcodeproj/project.pbxproj:
7987 * html/CanvasStyle.cpp:
7988 * platform/graphics/Color.cpp:
7989 (WebCore::colorWithOverrideAlpha):
7990 * platform/graphics/Color.h:
7991 * svg/graphics/cg/CgSupport.cpp:
7992 (WebCore::applyStrokeStyleToContext):
7993 (WebCore::strokeBoundingBox):
7994 * svg/graphics/cg/SVGPaintServerSolidCg.cpp:
7995 (WebCore::SVGPaintServerSolid::setup):
7996
79972008-08-14 Eric Seidel <eric@webkit.org>
7998
eric@webkit.org4f490652008-08-14 23:19:31 +00007999 Reviewed by Alexey.
8000
eric@webkit.org73fa9d12008-08-14 23:19:44 +00008001 Remove un-need includes from HTMLCanvas and use the
8002 Gradient platform abstraction in one place in CanvasStyle
8003
8004 * html/CanvasRenderingContext2D.cpp:
8005 (WebCore::CanvasRenderingContext2D::fillRect):
8006 * html/CanvasStyle.cpp:
8007 * html/HTMLCanvasElement.cpp:
8008
80092008-08-14 Eric Seidel <eric@webkit.org>
8010
8011 Reviewed by Alexey.
8012
eric@webkit.org4f490652008-08-14 23:19:31 +00008013 Clean up GlyphBuffer.h, removing more #ifdefs
8014
8015 * platform/graphics/GlyphBuffer.h:
8016 (WebCore::GlyphBuffer::glyphAt):
8017 (WebCore::GlyphBuffer::advanceAt):
8018 (WebCore::GlyphBuffer::add):
8019
80202008-08-14 Eric Seidel <eric@webkit.org>
8021
eric@webkit.org89613d22008-08-14 23:19:17 +00008022 Reviewed by Sam.
8023
8024 Clean up AffineTransform.h, removing #ifdefs
8025
8026 * platform/graphics/AffineTransform.h:
8027 * platform/graphics/cairo/AffineTransformCairo.cpp:
8028 * platform/graphics/cg/AffineTransformCG.cpp:
8029 * platform/graphics/qt/AffineTransformQt.cpp:
8030 * platform/graphics/wx/AffineTransformWx.cpp:
8031
mitz@apple.com551d6252008-08-14 23:08:09 +000080322008-08-14 Dan Bernstein <mitz@apple.com>
8033
mitz@apple.com94c1a7d2008-08-14 23:12:34 +00008034 - fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
8035
8036 * platform/graphics/cairo/ImageSourceCairo.cpp:
8037 (WebCore::ImageSource::frameSizeAtIndex):
8038 * platform/graphics/qt/ImageSourceQt.cpp:
8039 (WebCore::ImageSource::frameSizeAtIndex):
8040 * platform/graphics/wx/ImageSourceWx.cpp:
8041 (WebCore::ImageSource::frameSizeAtIndex):
8042
80432008-08-14 Dan Bernstein <mitz@apple.com>
8044
mitz@apple.com551d6252008-08-14 23:08:09 +00008045 Reviewed by Brady Eidson.
8046
8047 - fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
8048
8049 * platform/graphics/BitmapImage.cpp:
8050 (WebCore::BitmapImage::BitmapImage): Added initialization of
8051 m_hasUniformFrameSize.
8052 (WebCore::BitmapImage::cacheFrame): Added code to get the size of the
8053 cached frame for use in decoded size computation and for setting
8054 m_hasUniformFrameSize.
8055 (WebCore::BitmapImage::currentFrameSize): Added.
8056 (WebCore::BitmapImage::dataChanged): Added code to reset
8057 m_hasUniformFrameSize.
8058 * platform/graphics/BitmapImage.h: Added currentFrameSize() and
8059 m_hasUniformFrameSize.
8060 * platform/graphics/ImageSource.h: Added frameSizeAtIndex().
8061 * platform/graphics/cg/ImageCG.cpp:
8062 (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This
8063 fixes the bug, which resulted from assuming that the frame being drawn
8064 was the same size as the first frame.
8065 * platform/graphics/cg/ImageSourceCG.cpp:
8066 (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and
8067 changed to get the size of the frame at the given index.
8068 (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
8069
simon.fraser@apple.com50954e52008-08-14 23:04:41 +000080702008-08-13 Simon Fraser <simon.fraser@apple.com>
8071
8072 Reviewed by Eric Seidel
8073
8074 Fix @font-face inside @media rule crash.
8075 https://bugs.webkit.org/show_bug.cgi?id=20367
8076
8077 Test: fast/css/font-face-in-media-rule.html
8078
8079 * css/CSSStyleSelector.cpp:
8080 (WebCore::CSSRuleSet::addRulesFromSheet):
8081
kevino@webkit.org141c4602008-08-14 22:52:55 +000080822008-08-14 Kevin Ollivier <kevino@theolliviers.com>
8083
8084 wx build fixes after recent changes to Canvas and Image classes.
8085
8086 * platform/graphics/Pattern.h:
8087 * platform/graphics/wx/GradientWx.cpp:
8088 (WebCore::Gradient::fill):
8089 * platform/graphics/wx/GraphicsContextWx.cpp:
8090 (WebCore::GraphicsContext::applyFillPattern):
8091 (WebCore::GraphicsContext::applyStrokePattern):
8092 * platform/graphics/wx/ImageBufferWx.cpp:
8093 (WebCore::ImageBuffer::image):
8094 * platform/graphics/wx/ImageWx.cpp:
8095 (WebCore::Image::loadPlatformResource):
8096
britto@apple.comd7008662008-08-14 19:26:02 +000080972008-08-14 Maxime Britto <britto@apple.com>
8098
8099 Reviewed by Sam Weinig.
8100
8101 rdar://6102511
8102 When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
8103 IE and FF are both preventing the keyboard event to interact with the page while scrolling.
8104 Some differences exist between them concerning the kind of key which is pressed :
8105 IE7 : every key leads to a stop of the panning
8106 FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
8107 For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.
8108
8109 * page/EventHandler.cpp:
8110 (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
8111
christian@webkit.org0e20f322008-08-14 19:14:47 +000081122008-08-14 Christian Dywan <christian@twotoasts.de>
8113
8114 Gtk+/ Cairo build fix, patch by Dirk Schulze.
8115
8116 * html/CanvasStyle.cpp:
8117 * platform/graphics/cairo/PatternCairo.cpp:
8118 (WebCore::Pattern::createPlatformPattern):
8119 * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
8120
kmccullough@apple.comd2b50f12008-08-14 18:11:20 +000081212008-08-14 Kevin McCullough <kmccullough@apple.com>
8122
8123 Reviewed by Tim.
8124
8125 <rdar://problem/6115819> Notify of profile in console
8126
8127 * page/InspectorController.cpp:
8128 (WebCore::InspectorController::addProfile):
8129 (WebCore::InspectorController::addProfileMessageToConsole): Called by
8130 addProfile this is the function that adds a message to the console that
8131 a profile finished.
8132 * page/InspectorController.h:
8133 * page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match
8134 the console log to the profile in the web inspector.
8135 (WebCore::getUniqueIdCallback):
8136 (WebCore::ProfileClass):
8137 * page/inspector/ProfilesPanel.js: Created a map of all the profiles by
8138 Id to bring up the requested profile. Also select and reveal the
8139 profile in the profile panel. And created displayTitleForProfileLink()
8140 which formats a title taking into account if it's user initiated or if
8141 there are multiples. Lasty, I put the user initiated profile in a
8142 variable.
8143 * page/inspector/inspector.js: Make the profile title be a clickable
8144 link that will take the user to the identified profile. Also expose
8145 the count of user initiated profiles so they can be displayed in the
8146 console with the correct count.
8147
timothy@apple.comcd7f0f32008-08-14 17:41:05 +000081482008-08-14 Timothy Hatcher <timothy@apple.com>
8149
8150 Avoid formating ConsoleMessages twice unless the message will be
8151 displayed in bubbles of a SourceFrame.
8152
8153 Reviewed by Kevin McCullough.
8154
8155 * page/inspector/Console.js:
8156 (WebInspector.ConsoleMessage): Only format the plain text message
8157 if the URL and line are valid and the level is error or warning.
8158 (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added.
8159 Helper to test for error or warning level.
8160 * page/inspector/SourceFrame.js:
8161 (WebInspector.SourceFrame.prototype.addMessage): Don't add the
8162 message if there is no message or valid line or if the msg
8163 isn't an error or warning.
8164
jmalonzo@webkit.orgb469bb72008-08-14 15:07:41 +000081652008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
8166
8167 partial Gtk build fix, not reviewed
8168
8169 * platform/graphics/cairo/PatternCairo.cpp:
8170
weinig@apple.com45e83142008-08-14 04:49:30 +000081712008-08-13 Sam Weinig <sam@webkit.org>
8172
8173 Reviewed by Anders Carlson.
8174
8175 Fix style issue.
8176
8177 * html/HTMLMediaElement.cpp:
8178 (WebCore::HTMLMediaElement::pickMedia):
8179
zimmermann@webkit.org9ae47e92008-08-14 02:22:35 +000081802008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
8181
zimmermann@webkit.org7a2f53d2008-08-14 03:06:01 +00008182 Build fix for Cairo, not reviewed. (exposed by gtk build slave)
8183 Continue Erics build fixes, after the Image cleanup.
8184
8185 * platform/graphics/cairo/ImageBufferCairo.cpp:
8186 (WebCore::ImageBuffer::image):
8187
81882008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
8189
zimmermann@webkit.org1ef52132008-08-14 02:38:16 +00008190 Build fix for Qt, not reviewed.
8191 Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.
8192
8193 * dom/XMLTokenizer.cpp:
8194 (WebCore::eventuallyMarkAsParserCreated): Was erre
8195
81962008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
8197
zimmermann@webkit.org3e560562008-08-14 02:26:00 +00008198 Build fix, not reviewed.
8199 Add ScriptElement.cpp to Gtk build.
8200
8201 * GNUmakefile.am:
8202
82032008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
8204
zimmermann@webkit.org9ae47e92008-08-14 02:22:35 +00008205 Reviewed by Eric.
8206
8207 Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
8208
8209 Refactor HTMLScriptElement's code into a common base class: ScriptElement.
8210 SVGScriptElement will be converted to use ScriptElement in a follow-up patch.
8211
8212 This resolves code duplications and allows us to completly replace the old
8213 SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)
8214
8215 As ScriptElement, doesn't actually inherit from Element, we may want to rename
8216 it, though StyleElement uses the same naming convention, so I left it as is for now.
8217 Eventually we'll rename both files in future.
8218
8219 No functional changes yet, as SVGScriptElement doesn't yet use the new base class.
8220
8221 * WebCore.pro: Add new ScriptElement.cpp to build.
8222 * WebCore.vcproj/WebCore.vcproj: Ditto.
8223 * WebCore.xcodeproj/project.pbxproj: Ditto.
8224 * WebCoreSources.bkl: Dutto.
8225 * dom/ScriptElement.cpp: Added. 1:1 based on HTMLScriptElement
8226 (WebCore::ScriptElement::insertedIntoDocument):
8227 (WebCore::ScriptElement::removedFromDocument):
8228 (WebCore::ScriptElement::childrenChanged):
8229 (WebCore::ScriptElement::finishParsingChildren):
8230 (WebCore::ScriptElement::handleSourceAttribute):
8231 (WebCore::isSupportedJavaScriptLanguage):
8232 (WebCore::ScriptElementData::ScriptElementData):
8233 (WebCore::ScriptElementData::~ScriptElementData):
8234 (WebCore::ScriptElementData::requestScript):
8235 (WebCore::ScriptElementData::evaluateScript):
8236 (WebCore::ScriptElementData::stopLoadRequest):
8237 (WebCore::ScriptElementData::notifyFinished):
8238 (WebCore::ScriptElementData::ignoresLoadRequest):
8239 (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
8240 (WebCore::ScriptElementData::scriptCharset):
8241 (WebCore::ScriptElementData::scriptContent):
8242 * dom/ScriptElement.h: Added.
8243 (WebCore::ScriptElement::ScriptElement):
8244 (WebCore::ScriptElement::~ScriptElement):
8245 (WebCore::ScriptElementData::element):
8246 (WebCore::ScriptElementData::createdByParser):
8247 (WebCore::ScriptElementData::setCreatedByParser):
8248 * dom/XMLTokenizer.cpp:
8249 (WebCore::isScriptElement):
8250 (WebCore::castToScriptElement):
8251 (WebCore::eventuallyMarkAsParserCreated):
8252 (WebCore::XMLTokenizer::startElementNs):
8253 (WebCore::XMLTokenizer::endElementNs):
8254 (WebCore::createXHTMLParserErrorHeader):
8255 (WebCore::XMLTokenizer::insertErrorMessageBlock):
8256 * html/HTMLScriptElement.cpp: Refactored code, pushed most code down to ScriptElement.
8257 (WebCore::HTMLScriptElement::HTMLScriptElement):
8258 (WebCore::HTMLScriptElement::~HTMLScriptElement):
8259 (WebCore::HTMLScriptElement::isURLAttribute):
8260 (WebCore::HTMLScriptElement::setCreatedByParser):
8261 (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
8262 (WebCore::HTMLScriptElement::childrenChanged):
8263 (WebCore::HTMLScriptElement::parseMappedAttribute):
8264 (WebCore::HTMLScriptElement::finishParsingChildren):
8265 (WebCore::HTMLScriptElement::insertedIntoDocument):
8266 (WebCore::HTMLScriptElement::removedFromDocument):
8267 (WebCore::HTMLScriptElement::text):
8268 (WebCore::HTMLScriptElement::setText):
8269 (WebCore::HTMLScriptElement::setHtmlFor):
8270 (WebCore::HTMLScriptElement::setEvent):
8271 (WebCore::HTMLScriptElement::charset):
8272 (WebCore::HTMLScriptElement::src):
8273 (WebCore::HTMLScriptElement::type):
8274 (WebCore::HTMLScriptElement::scriptCharset):
8275 (WebCore::HTMLScriptElement::scriptContent):
8276 (WebCore::HTMLScriptElement::sourceAttributeValue):
8277 (WebCore::HTMLScriptElement::charsetAttributeValue):
8278 (WebCore::HTMLScriptElement::typeAttributeValue):
8279 (WebCore::HTMLScriptElement::languageAttributeValue):
8280 (WebCore::HTMLScriptElement::dispatchLoadEvent):
8281 (WebCore::HTMLScriptElement::dispatchErrorEvent):
8282 * html/HTMLScriptElement.h:
8283 * svg/SVGScriptElement.cpp: Inherit from ScriptElement, don't actually use it yet.
8284 * svg/SVGScriptElement.cpp:
8285 (WebCore::SVGScriptElement::SVGScriptElement):
8286 (WebCore::SVGScriptElement::scriptContent):
8287 (WebCore::SVGScriptElement::sourceAttributeValue):
8288 (WebCore::SVGScriptElement::charsetAttributeValue):
8289 (WebCore::SVGScriptElement::typeAttributeValue):
8290 (WebCore::SVGScriptElement::languageAttributeValue):
8291 (WebCore::SVGScriptElement::dispatchLoadEvent):
8292 (WebCore::SVGScriptElement::dispatchErrorEvent):
8293 * svg/SVGScriptElement.h:
8294 (WebCore::SVGScriptElement::setCreatedByParser):
8295
eric@webkit.org7811ef02008-08-14 00:28:51 +000082962008-08-13 Eric Seidel <eric@webkit.org>
8297
eric@webkit.org3562c592008-08-14 02:17:29 +00008298 Attempt to fix the Gtk build, no review.
8299
8300 I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.
8301
8302 * platform/graphics/GraphicsContext.h:
8303 * platform/graphics/cairo/GraphicsContextCairo.cpp:
8304 * platform/graphics/qt/GradientQt.cpp:
8305 * platform/graphics/qt/GraphicsContextQt.cpp:
8306 * platform/gtk/RenderThemeGtk.cpp:
8307 (WebCore::paintMozWidget):
8308
83092008-08-13 Eric Seidel <eric@webkit.org>
8310
eric@webkit.org2ec42072008-08-14 02:03:09 +00008311 Yet another attempt to fix the Qt build, no review.
8312
8313 * platform/graphics/qt/GradientQt.cpp:
8314 * platform/graphics/qt/GraphicsContextQt.cpp:
8315 (WebCore::GraphicsContext::applyStrokePattern):
8316 (WebCore::GraphicsContext::applyFillPattern):
8317
83182008-08-13 Eric Seidel <eric@webkit.org>
8319
8320 Attempt to fix the Windows build, no review.
8321
8322 * platform/win/CursorWin.cpp:
8323 (WebCore::loadCursorByName):
8324 * platform/win/ScrollViewWin.cpp:
8325 (WebCore::ScrollView::paint):
8326
83272008-08-13 Eric Seidel <eric@webkit.org>
8328
eric@webkit.org508c0282008-08-14 01:29:34 +00008329 Attempt to fix the Windows build, no review.
8330
8331 * platform/win/CursorWin.cpp:
8332 (WebCore::loadCursorByName):
8333 * platform/win/ScrollViewWin.cpp:
8334 (WebCore::ScrollView::paint):
8335
83362008-08-13 Eric Seidel <eric@webkit.org>
8337
eric@webkit.org1bf70ab2008-08-14 01:24:15 +00008338 Attempt to fix the Qt build, no review.
8339
8340 * platform/graphics/qt/ImageBufferQt.cpp:
8341 (WebCore::ImageBuffer::image):
8342
83432008-08-13 Eric Seidel <eric@webkit.org>
8344
eric@webkit.orgf2d7c212008-08-14 01:21:34 +00008345 Attempt to fix the Windows build, no review.
8346
8347 * platform/graphics/win/ImageWin.cpp:
8348 (WebCore::Image::loadPlatformResource):
8349 * plugins/win/PluginViewWin.cpp:
8350 (WebCore::PluginView::paintMissingPluginIcon):
8351
83522008-08-13 Eric Seidel <eric@webkit.org>
8353
eric@webkit.orgac3f6662008-08-14 01:15:50 +00008354 Another attempt to fix the Qt build, no review.
8355
8356 * platform/graphics/qt/ImageQt.cpp:
8357 * platform/graphics/qt/StillImageQt.h:
8358
83592008-08-13 Eric Seidel <eric@webkit.org>
8360
eric@webkit.org31e0d812008-08-14 01:05:42 +00008361 No review, build fix only.
8362
8363 Fix mac build, due to change in new code since my patch was written.
8364
8365 * svg/graphics/cg/SVGResourceMaskerCg.mm:
8366 (WebCore::SVGResourceMasker::applyMask):
8367
83682008-08-13 Eric Seidel <eric@webkit.org>
8369
eric@webkit.orga20a0032008-08-14 00:42:54 +00008370 Build fix only, no review.
8371
8372 Attempt to fix the Qt build.
8373
eric@webkit.org923255c2008-08-14 00:59:20 +00008374 * platform/graphics/qt/ImageBufferQt.cpp:
8375 * platform/graphics/qt/StillImageQt.h:
8376 (WebCore::StillImage::create):
8377 (WebCore::StillImage::destroyDecodedData):
8378 (WebCore::StillImage::decodedSize):
8379
83802008-08-13 Eric Seidel <eric@webkit.org>
8381
8382 Build fix only, no review.
8383
8384 Attempt to fix the Qt build.
8385
eric@webkit.orga20a0032008-08-14 00:42:54 +00008386 * html/CanvasStyle.cpp:
8387 (WebCore::CanvasStyle::applyStrokeColor):
8388 (WebCore::CanvasStyle::applyFillColor):
8389
83902008-08-13 Eric Seidel <eric@webkit.org>
8391
eric@webkit.org4aca3be2008-08-14 00:30:04 +00008392 Reviewed by Sam.
8393
8394 Match HTML5 spec by throwing INVALID_STATE_ERR when
8395 createPattern is called and the HTMLImageElement is not
8396 yet done loading the image (!isComplete)
8397 https://bugs.webkit.org/show_bug.cgi?id=20351
8398
8399 Test: http/misc/canvas-pattern-from-incremental-image.html
8400
8401 * html/CanvasRenderingContext2D.cpp:
8402 (WebCore::CanvasRenderingContext2D::createPattern):
8403
84042008-08-13 Eric Seidel <eric@webkit.org>
8405
eric@webkit.org5b265602008-08-14 00:29:26 +00008406 Reviewed by Niko.
8407
eric@webkit.orgf0124f62008-08-14 00:29:50 +00008408 Split out a Pattern class from CanvasPattern
8409 and remove all the Pattern-related #ifdefs
8410 (This will break non-mac platforms! I will fix them.)
8411 https://bugs.webkit.org/show_bug.cgi?id=20351
8412
8413 * GNUmakefile.am:
8414 * WebCore.pro:
8415 * WebCore.vcproj/WebCore.vcproj:
8416 * WebCore.xcodeproj/project.pbxproj:
8417 * WebCoreSources.bkl:
8418 * html/CanvasPattern.cpp:
8419 (WebCore::CanvasPattern::parseRepetitionType):
8420 (WebCore::CanvasPattern::CanvasPattern):
8421 * html/CanvasPattern.h:
8422 (WebCore::CanvasPattern::create):
8423 (WebCore::CanvasPattern::pattern):
8424 (WebCore::CanvasPattern::originClean):
8425 * html/CanvasRenderingContext2D.cpp:
8426 (WebCore::CanvasRenderingContext2D::createPattern):
8427 (WebCore::CanvasRenderingContext2D::applyStrokePattern):
8428 (WebCore::CanvasRenderingContext2D::applyFillPattern):
8429 * html/CanvasRenderingContext2D.h:
8430 * html/HTMLCanvasElement.cpp:
8431 * html/HTMLCanvasElement.h:
8432 * loader/FrameLoader.cpp:
8433 (WebCore::FrameLoader::createHistoryItem):
8434 * platform/graphics/GraphicsContext.h:
8435 * platform/graphics/cairo/GraphicsContextCairo.cpp:
8436 (WebCore::GraphicsContext::applyStrokePattern):
8437 (WebCore::GraphicsContext::applyFillPattern):
8438 * platform/graphics/cg/GraphicsContextCG.cpp:
8439 (WebCore::GraphicsContext::clipToImageBuffer):
8440 (WebCore::GraphicsContext::applyStrokePattern):
8441 (WebCore::GraphicsContext::applyFillPattern):
8442
84432008-08-13 Eric Seidel <eric@webkit.org>
8444
8445 Reviewed by Niko.
8446
eric@webkit.org5b265602008-08-14 00:29:26 +00008447 Make Images RefCounted (and clean up callers)
8448 https://bugs.webkit.org/show_bug.cgi?id=20351
8449
8450 * editing/DeleteButtonController.cpp:
8451 (WebCore::DeleteButtonController::createDeletionUI):
8452 * loader/CachedImage.cpp:
8453 (WebCore::CachedImage::CachedImage):
8454 (WebCore::brokenImage):
8455 (WebCore::nullImage):
8456 (WebCore::CachedImage::image):
8457 (WebCore::CachedImage::notifyObservers):
8458 (WebCore::CachedImage::createImage):
8459 * loader/CachedImage.h:
8460 * loader/icon/IconRecord.cpp:
8461 (WebCore::IconRecord::setImageData):
8462 (WebCore::IconRecord::loadImageFromResource):
8463 * loader/icon/IconRecord.h:
8464 * platform/graphics/BitmapImage.h:
8465 (WebCore::BitmapImage::create):
8466 * platform/graphics/GeneratedImage.h:
8467 * platform/graphics/Gradient.cpp:
8468 * platform/graphics/Gradient.h:
8469 * platform/graphics/Image.cpp:
8470 (WebCore::Image::nullImage):
8471 * platform/graphics/Image.h:
8472 * platform/graphics/ImageBuffer.h:
8473 * platform/graphics/cairo/ImageBufferCairo.cpp:
8474 (WebCore::ImageBuffer::image):
8475 * platform/graphics/cg/ImageBufferCG.cpp:
8476 (WebCore::ImageBuffer::image):
8477 (WebCore::ImageBuffer::getImageData):
8478 (WebCore::ImageBuffer::putImageData):
8479 * platform/graphics/cg/PDFDocumentImage.h:
8480 (WebCore::PDFDocumentImage::create):
8481 (WebCore::PDFDocumentImage::destroyDecodedData):
8482 (WebCore::PDFDocumentImage::decodedSize):
8483 * platform/graphics/gtk/ImageGtk.cpp:
8484 (WebCore::Image::loadPlatformResource):
8485 * platform/graphics/mac/ImageMac.mm:
8486 (WebCore::Image::loadPlatformResource):
8487 * rendering/RenderImage.cpp:
8488 * rendering/RenderLayer.cpp:
8489 (WebCore::RenderLayer::paintOverflowControls):
8490 * svg/graphics/SVGImage.cpp:
8491 (WebCore::SVGImage::nativeImageForCurrentFrame):
8492 * svg/graphics/SVGImage.h:
8493 (WebCore::SVGImage::create):
8494 (WebCore::SVGImage::destroyDecodedData):
8495 (WebCore::SVGImage::decodedSize):
8496 (WebCore::SVGImage::frameAtIndex):
8497 * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
8498 (WebCore::SVGPaintServerPattern::setup):
8499 * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
8500 (WebCore::SVGResourceMasker::applyMask):
8501 * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
8502 (WebCore::patternCallback):
8503 * svg/graphics/cg/SVGResourceMaskerCg.mm:
8504 (WebCore::SVGResourceMasker::applyMask):
8505
85062008-08-13 Eric Seidel <eric@webkit.org>
8507
8508 Reviewed by Niko.
eric@webkit.org7811ef02008-08-14 00:28:51 +00008509
8510 Remove #ifdefs from CanvasStyle by using platform/Color.h
eric@webkit.org5b265602008-08-14 00:29:26 +00008511 https://bugs.webkit.org/show_bug.cgi?id=20351
eric@webkit.org7811ef02008-08-14 00:28:51 +00008512
8513 There are some down-sides to this commit.
8514 This commit limits us to 255 levels of grey for calls like:
8515 context.setStrokeStyle(.37, 1.0)
8516 previously CG might have used up to 32bits to store the grey level
8517 Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.
8518
8519 Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
8520 to RGBA32 (like all the rest of colors in WebCore), thus:
8521 context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
8522 context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32
8523
8524 If this is a problem for Dashboard, we can either roll out this commit
8525 or add a beefier Color abstraction, which can be used internally by GraphicsContext
8526 when keeping state, and then GraphicsContext can grow some additional set* routines
8527 for setting the a grey/float/whatever fill and stroke.
8528
8529 * html/CanvasRenderingContext2D.cpp:
8530 (WebCore::CanvasRenderingContext2D::setFillStyle):
8531 * html/CanvasStyle.cpp:
8532 (WebCore::CanvasStyle::CanvasStyle):
8533 (WebCore::colorWithOverrideAlpha):
8534 (WebCore::CanvasStyle::applyStrokeColor):
8535 (WebCore::CanvasStyle::applyFillColor):
8536 * html/CanvasStyle.h:
8537 * platform/graphics/Color.cpp:
8538 (WebCore::colorFloatToRGBAByte):
8539 (WebCore::makeRGBA32FromFloats):
8540 * platform/graphics/Color.h:
8541
adele@apple.com83e44822008-08-13 23:50:41 +000085422008-08-13 Eric Carlson <eric.carlson@apple.com>
8543
8544 Reviewed by Adele Peterson.
8545
8546 Fix for <rdar://problem/6137931>
8547 https://bugs.webkit.org/show_bug.cgi?id=20360
8548 Remove all parameters from the MIME type before checking with the MIME type registry
8549
8550 Tests: media/video-source-type-params.html
8551
8552 * html/HTMLMediaElement.cpp:
8553 (WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';'
8554 to isSupportedMediaMIMEType()
8555
bdakin@apple.com7bc81bf2008-08-13 21:36:15 +000085562008-08-13 Beth Dakin <bdakin@apple.com>
8557
8558 Reviewed by Sam Weinig.
8559
8560 Fix for <rdar://problem/6141345>
8561
8562 This patch refines findString and markAllMatchesForText functions'
8563 interactions with disconnected frames. They no longer rely on
8564 knowing where a range is relative to the visible region and work
8565 with disconnected frames that contain frames.
8566
8567 * editing/Editor.cpp:
8568 (WebCore::Editor::insideVisibleArea): Now returns a bool instead of
8569 the visiblity enum.
8570 (WebCore::Editor::firstVisibleRange): This now returns the very
8571 first visible range in the document. It's no longer dependent on
8572 searching forward.
8573 (WebCore::Editor::lastVisibleRange): This now returns the very last
8574 visible range in the document. It's no longer dependent on
8575 searching backwards.
8576 (WebCore::Editor::nextVisibleRange): This returns the next visible
8577 range in the appropriate direction from the current range.
8578 * editing/Editor.h:
8579 * page/Frame.cpp:
8580 (WebCore::Frame::findString):
8581 (WebCore::Frame::markAllMatchesForText):
8582
kevino@webkit.orgee5adc42008-08-13 20:07:16 +000085832008-08-13 Kevin Ollivier <kevino@theolliviers.com>
8584
8585 wx build fix for case-sensitive platforms, like Linux.
8586
8587 * WebCoreSources.bkl:
8588
jmalonzo@webkit.org210145b2008-08-13 19:56:20 +000085892008-08-13 Marco Barisione <marco.barisione@collabora.co.uk>
8590
8591 Reviewed by Holger Freyther.
8592
8593 http://bugs.webkit.org/show_bug.cgi?id=16881
8594 [GTK] PlatformScreenGtk is unimplemented
8595
8596 Original patch by Christian Dywan.
8597
8598 * platform/gtk/PlatformScreenGtk.cpp:
8599 (WebCore::screenDepth):
8600 (WebCore::screenDepthPerComponent):
8601 (WebCore::screenIsMonochrome):
8602 (WebCore::screenRect):
8603 (WebCore::screenAvailableRect):
8604
jmalonzo@webkit.orge4693932008-08-13 19:42:08 +000086052008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org>
8606
8607 Reviewed by Holger Freyther.
8608
8609 http://bugs.webkit.org/show_bug.cgi?id=20318
8610 SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add
8611
8612 g_idle_add is the same as g_idle_add_full with a priority of
8613 G_PRIORITY_DEFAULT_IDLE, so we can safely use that.
8614
8615 * platform/gtk/SharedTimerGtk.cpp:
8616 (WebCore::setSharedTimerFireTime):
8617
timothy@apple.comf0426602008-08-13 18:11:01 +000086182008-08-13 Timothy Hatcher <timothy@apple.com>
8619
8620 Changed the InspectorController so it can be notified when the
8621 attached state of the Inspector changes in WebKit.
8622
8623 Reviewed by Kevin McCullough.
8624
8625 * WebCore.base.exp: Updated the symbol for setWindowVisible.
8626 * page/InspectorController.cpp:
8627 (WebCore::InspectorController::setWindowVisible): Added an attached argument,
8628 that defaults to false.Call setAttachedWindow with the attached argument.
8629 (WebCore::InspectorController::setAttachedWindow): Call the script version
8630 of setAttachedWindow.
8631 * page/InspectorController.h:
8632 * page/inspector/inspector.js:
8633 (WebInspector.setAttachedWindow): Set the attached property.
8634
timothy@apple.com9ea832b2008-08-13 18:10:36 +000086352008-08-12 Timothy Hatcher <timothy@apple.com>
8636
timothy@apple.com72c92ae2008-08-13 18:10:45 +00008637 Added a close button to the Inspector's toolbar when docked.
8638
8639 https://bugs.webkit.org/show_bug.cgi?id=14270
8640
8641 Reviewed by Kevin McCullough.
8642
8643 * page/InspectorController.cpp:
8644 (WebCore::closeWindow): Call InspectorController::closeWindow.
8645 (WebCore::InspectorController::windowScriptObjectAvailable):
8646 Added closeWindow to the script class.
8647 * page/InspectorController.h:
8648 * page/inspector/Images/closeButtons.png: Added.
8649 * page/inspector/inspector.css: Added and changed styles.
8650 * page/inspector/inspector.html: Added the close button.
8651 * page/inspector/inspector.js:
8652 (WebInspector.loaded): Added click event listener to the close button.
8653 (WebInspector.close): Call InspectorController.closeWindow.
8654
86552008-08-12 Timothy Hatcher <timothy@apple.com>
8656
timothy@apple.com9ea832b2008-08-13 18:10:36 +00008657 Make the docked Web Inspector resizable. This is the cross platform
8658 portion of the code. Each InspectorClient needs to implement the
8659 real resize code.
8660
8661 https://bugs.webkit.org/show_bug.cgi?id=14282
8662
8663 Reviewed by Kevin McCullough.
8664
8665 * loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
8666 * page/InspectorClient.h: Added setAttachedWindowHeight.
8667 * page/InspectorController.cpp:
8668 (WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight
8669 on the InspectorController.
8670 (WebCore::InspectorController::setAttachedWindowHeight): Call
8671 setAttachedWindowHeight on the client.
8672 (WebCore::InspectorController::windowScriptObjectAvailable):
8673 Added setAttachedWindowHeight to the script class.
8674 * page/InspectorController.h:
8675 * page/inspector/inspector.css: Make the cursor on the toolbar be
8676 row-resize when docked.
8677 * page/inspector/inspector.js:
8678 (WebInspector.loaded): Always add the toolbarDragStart event listener.
8679 (WebInspector.toolbarDragStart): Return early if we are not attached
8680 and not on Leopard. Call WebInspector.elementDragStart.
8681 (WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd.
8682 (WebInspector.toolbarDrag): When attached call setAttachedWindowHeight,
8683 otherwise call moveByUnrestricted.
8684
hausmann@webkit.orgd34f1d22008-08-13 13:43:34 +000086852008-08-13 Simon Hausmann <hausmann@webkit.org>
8686
8687 Reviewed by Holger.
8688
8689 Initialize m_zoomsTextOnly in the Settings constructor.
8690
8691 * page/Settings.cpp:
8692 (WebCore::Settings::Settings):
8693
hausmann@webkit.org74586d62008-08-13 13:31:11 +000086942008-08-13 Brad Hughes <bhughes@trolltech.com>
8695
8696 Reviewed by Simon.
8697
8698 Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux
8699
8700 The latest upgrade of the intel compiler allows us to compile all of
8701 Qt with optimizations enabled (yay!).
8702
8703 * WebCore.pro:
8704
hausmann@webkit.org690b7fc2008-08-13 13:24:56 +000087052008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com>
8706
8707 Reviewed by Simon.
8708
8709 Fix QtWebKit not displaying content on 403 HTTP responses
8710
8711 Just like with 404 responses also display content with 403, as
8712 used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/
8713
8714 * platform/network/qt/QNetworkReplyHandler.cpp:
8715 (WebCore::QNetworkReplyHandler::finish):
8716
hausmann@webkit.org88c4dc92008-08-13 12:02:00 +000087172008-08-13 Simon Hausmann <hausmann@webkit.org>
8718
hausmann@webkit.orgd2315e32008-08-13 13:16:15 +00008719 Reviewed by Holger.
8720
8721 Qt part of https://bugs.webkit.org/show_bug.cgi?id=18994
8722
8723 Make the formatting of String::format() locale independent through the use of QString::vsprintf.
8724
8725 * platform/text/String.cpp:
8726 (WebCore::String::format):
8727
87282008-08-13 Simon Hausmann <hausmann@webkit.org>
8729
hausmann@webkit.org88c4dc92008-08-13 12:02:00 +00008730 Reviewed by Lars.
8731
8732 Fix QWebFrame::setHtml() not setting the new contents immediately.
8733
8734 Added a setter to the DocumentLoader to toggle the deferred loading of the main
8735 resource when it comes from substitute data.
8736
8737 Disable deferred loading of the main resource when we have valid substitute data,
8738 as used by QWebFrame::setHtml.
8739
8740 * loader/DocumentLoader.h:
8741
mrowe@apple.com6aa36d12008-08-13 09:58:32 +000087422008-08-13 Mark Rowe <mrowe@apple.com>
8743
8744 Speculative GTK build fix.
8745
8746 * GNUmakefile.am: Add dependency info for JSSVGElementWrapperFactory.cpp.
8747
hausmann@webkit.org298ce5f2008-08-13 09:11:23 +000087482008-08-13 Thiago Macieira <tjmaciei@trolltech.com>
8749
8750 Reviewed by Simon.
8751
8752 Fix encoding of [ and ] in the host part of the URL
8753
8754 Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to
8755 add this workaround to the QUrl <> WebCore::KURL conversion operator so that it
8756 doesn't encode [ and ] when they are found in the host part. That is, the
8757 following URL:
8758 http://[::1]/
8759 is valid and should not be reencoded to:
8760 http://%5b::1%5d/
8761
8762 * platform/qt/KURLQt.cpp:
8763 (WebCore::KURL::operator QUrl):
8764
mitz@apple.come198b012008-08-12 21:49:07 +000087652008-08-12 Mihnea Ovidenie <mihnea@adobe.com>
8766
8767 Fix for https://bugs.webkit.org/show_bug.cgi?id=19891
8768 Broken HTML object elements cause de-reference of pointer to freed memory.
8769 If we fail to load an image for an object tag and we no longer believe the object tag points at
8770 an image, then clear m_imageLoader in the HTMLObjectElement so that we attempt to render the
8771 fall back content.
8772
8773 Reviewed by Dave Hyatt and Alexey Proskuryakov.
8774
8775 Test: http/tests/misc/object-image-error-with-onload.html
8776
8777 * html/HTMLObjectElement.cpp:
8778 (WebCore::HTMLObjectElement::renderFallbackContent):
8779 * page/Frame.cpp:
8780 (WebCore::Frame::Frame):
8781
zimmermann@webkit.org36a02512008-08-12 21:11:17 +000087822008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
8783
8784 Reviewed by Dave.
8785
8786 Fixes: https://bugs.webkit.org/show_bug.cgi?id=19798
8787 Masks are translated, and the mask images are swapped on the y-axis.
8788
8789 Turned out that http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm
8790 is guilty. GraphicsContext::clipToImageBuffer() does some extra transformations that SVGResourcesMaskerCg does not want.
8791
8792 Long term goal is to remove the SVGResource*/SVGPaintServer* classes anyway, so it's okay to duplicate
8793 the "clip to image buffer" functionality, in the CG specific SVGResourceMaskerCg class - as it was before.
8794
8795 * svg/graphics/cg/SVGResourceMaskerCg.mm:
8796 (WebCore::SVGResourceMasker::applyMask): Changed back to use CG clipping again.
8797
mitz@apple.comf8a98692008-08-12 17:04:42 +000087982008-08-12 Dan Bernstein <mitz@apple.com>
8799
mitz@apple.com1b7e844f2008-08-12 20:54:12 +00008800 - WebCore part of <rdar://problem/6121636>
8801 Make fast*alloc() abort() on failure and add "try" variants that
8802 return NULL on failure.
8803
8804 Reviewed by Darin Adler.
8805
8806 * platform/Arena.cpp:
8807 (WebCore::ArenaAllocate): Removed null checking of fastMalloc()'s
8808 result.
8809 * platform/graphics/cg/ImageBufferCG.cpp:
8810 (WebCore::ImageBuffer::create): Changed to use tryFastCalloc().
8811
88122008-08-12 Dan Bernstein <mitz@apple.com>
8813
mitz@apple.com1e09cd72008-08-12 18:27:58 +00008814 Reviewed by Darin Adler.
8815
8816 - fix https://bugs.webkit.org/show_bug.cgi?id=19348
8817 <rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works
8818
8819 Test: fast/frames/frameset-style-recalc.html
8820
8821 * html/HTMLFrameSetElement.cpp:
8822 (WebCore::HTMLFrameSetElement::recalcStyle): Changed to call the base
8823 class implementation after marking for layout.
8824
88252008-08-12 Dan Bernstein <mitz@apple.com>
8826
mitz@apple.comf8a98692008-08-12 17:04:42 +00008827 Reviewed by John Sullivan.
8828
8829 - move shouldUpdateWhenOffscreen from Settings to FrameView and rename it shouldUpdateWhileHidden
8830
8831 * WebCore.base.exp:
8832 * page/FrameView.cpp:
8833 (WebCore::FrameViewPrivate::FrameViewPrivate):
8834 (WebCore::FrameView::shouldUpdateWhileHidden):
8835 (WebCore::FrameView::setShouldUpdateWhileHidden):
8836 * page/FrameView.h:
8837 * page/Settings.cpp:
8838 * page/Settings.h:
8839
aroben@apple.comeeb8ebb2008-08-12 14:58:51 +000088402008-08-12 Adam Roben <aroben@apple.com>
8841
8842 Windows build fix
8843
8844 * bindings/js/JSSVGPODTypeWrapper.h: Align
8845 JSSVGDynamicPODTypeWrapper's and JSSVGStaticPODTypeWrapperWithParent's
8846 members on 16-byte boundaries to avoid an alignment warning.
8847
zimmermann@webkit.orge1388112008-08-12 10:27:53 +000088482008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
8849
8850 Reviewed by Oliver.
8851
zimmermann@webkit.org504f2552008-08-12 10:35:09 +00008852 Add new dynamice-update layout tests covering SVGMarkerElement.
8853 Fix bug: SVGMarkerElement's SVG DOM function calls don't update rendering.
8854 Fix orientAngle/orientType confusion: "auto" orient should always return "0" as angle.
8855
8856 Tests: svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
8857 svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr.html
8858 svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr.html
8859 svg/dynamic-updates/SVGMarkerElement-dom-orient-attr.html
8860 svg/dynamic-updates/SVGMarkerElement-dom-refX-attr.html
8861 svg/dynamic-updates/SVGMarkerElement-dom-refY-attr.html
8862 svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop.html
8863 svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop.html
8864 svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop.html
8865 svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop.html
8866 svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop.html
8867 svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop.html
8868 svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop.html
8869 svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call.html
8870 svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call.html
8871
8872 * svg/SVGMarkerElement.cpp:
8873 (WebCore::SVGMarkerElement::SVGMarkerElement):
8874 (WebCore::SVGMarkerElement::parseMappedAttribute):
8875 (WebCore::SVGMarkerElement::svgAttributeChanged):
8876 (WebCore::SVGMarkerElement::childrenChanged):
8877 (WebCore::SVGMarkerElement::setOrientToAuto):
8878 (WebCore::SVGMarkerElement::setOrientToAngle):
8879 (WebCore::SVGMarkerElement::canvasResource):
8880
88812008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
8882
8883 Reviewed by Oliver.
8884
zimmermann@webkit.orge1388112008-08-12 10:27:53 +00008885 Add new dynamic-update layout tests covering SVGImageElement.
8886 Fix bug: SVGImageElement doesn't react on 'preserveAspectRatio' changes.
8887
8888 Tests: svg/dynamic-updates/SVGImageElement-dom-height-attr.html
8889 svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr.html
8890 svg/dynamic-updates/SVGImageElement-dom-width-attr.html
8891 svg/dynamic-updates/SVGImageElement-dom-x-attr.html
8892 svg/dynamic-updates/SVGImageElement-dom-y-attr.html
8893 svg/dynamic-updates/SVGImageElement-svgdom-height-prop.html
8894 svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html
8895 svg/dynamic-updates/SVGImageElement-svgdom-width-prop.html
8896 svg/dynamic-updates/SVGImageElement-svgdom-x-prop.html
8897 svg/dynamic-updates/SVGImageElement-svgdom-y-prop.html
8898
8899 * svg/SVGImageElement.cpp:
8900 (WebCore::SVGImageElement::svgAttributeChanged):
8901
timothy@apple.com93114722008-08-12 04:20:25 +000089022008-08-11 Anthony Ricaud <rik24d@gmail.com>
8903
timothy@apple.com2f2cde32008-08-12 04:28:16 +00008904 Changed Option/Alt-Up or Down in CSS editing when the value is
8905 near zero to jump to the next integer.
8906
8907 Reviewed by Tim Hatcher.
8908
8909 https://bugs.webkit.org/show_bug.cgi?id=20326
8910
8911 * page/inspector/StylesSidebarPane.js:
8912
89132008-08-11 Anthony Ricaud <rik24d@gmail.com>
8914
timothy@apple.com93114722008-08-12 04:20:25 +00008915 Changed the line highlight transition for an easier animation.
8916
8917 Reviewed by Tim Hatcher.
8918
8919 * page/inspector/SourceFrame.js:
8920
timothy@apple.com24a14852008-08-12 03:57:39 +000089212008-08-11 Keishi Hattori <casey.hattori@gmail.com>
8922
8923 Added support for some Firebug Command Line APIs.
8924
8925 Reviewed by Tim Hatcher.
8926
8927 https://bugs.webkit.org/show_bug.cgi?id=19867
8928 https://bugs.webkit.org/show_bug.cgi?id=19868
8929 https://bugs.webkit.org/show_bug.cgi?id=19869
8930 https://bugs.webkit.org/show_bug.cgi?id=19875
8931 https://bugs.webkit.org/show_bug.cgi?id=19876
8932 https://bugs.webkit.org/show_bug.cgi?id=19880
8933
8934 * page/inspector/Console.js:
8935 (WebInspector.Console.prototype._evalInInspectedWindow):
8936 Create an object on the inspected window that holds the console
8937 command line API functions. This object is used in a with statement
8938 around the typed expression.
8939
zimmermann@webkit.org0350b6d2008-08-12 02:22:26 +000089402008-08-11 Nikolas Zimmermann <zimmermann@kde.org>
8941
8942 Reviewed by Antti.
8943
8944 Fixes: http://bugs.webkit.org/show_bug.cgi?id=17736
8945
8946 JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties
8947 failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect)
8948
8949 Added tests: svg/custom/svg-modify-currentTranslate.html
8950 svg/custom/tearoffs-with-tearoffs.html
8951 svg/custom/immutable-properties.html
8952
8953 Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html
8954
8955 * bindings/js/JSSVGPODTypeWrapper.h:
8956 (WebCore::JSSVGDynamicPODTypeWrapper::commitChange):
8957 (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::create):
8958 (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::commitChange):
8959 (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::JSSVGStaticPODTypeWrapperWithPODTypeParent):
8960 (WebCore::JSSVGStaticPODTypeWrapperWithParent::create):
8961 (WebCore::JSSVGStaticPODTypeWrapperWithParent::operator PODType):
8962 (WebCore::JSSVGStaticPODTypeWrapperWithParent::commitChange):
8963 (WebCore::JSSVGStaticPODTypeWrapperWithParent::JSSVGStaticPODTypeWrapperWithParent):
8964 * bindings/scripts/CodeGenerator.pm:
8965 * bindings/scripts/CodeGeneratorJS.pm:
8966 * svg/SVGSVGElement.idl: Add [Immutable] markers to SVG POD attributes, that contain POD types with writable attributes.
8967 * svg/SVGZoomEvent.idl: SVG specification explicitely demands these attributes to be readonly, even its content.
8968
beidson@apple.com0e772f72008-08-12 00:34:46 +000089692008-08-11 Brady Eidson <beidson@apple.com>
8970
8971 Reviewed by John and Anders
8972
8973 Fix for <rdar://problem/6141797>
8974
8975 When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource
8976 would never have nil data.
8977
8978 When they were pushed down into WebCore, that guarantee was lost, subtly changing a few
8979 semantics with some WebKit applications.
8980
8981 The guarantee was a good one and should be restored.
8982
8983 Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already
8984 creates an empty data object in the case of null data for its own purposes.
8985
8986 * loader/SubstituteResource.h:
8987 (WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null. This
8988 well help any future subclassers not make this mistake.
8989
8990 * loader/archive/ArchiveResource.cpp:
8991 (WebCore::ArchiveResource::create): Return 0 if the data is null.
8992
simon.fraser@apple.come0d44792008-08-11 22:44:06 +000089932008-08-11 Simon Fraser <simon.fraser@apple.com>
8994
8995 Reviewed by Dave Hyatt
8996
8997 https://bugs.webkit.org/show_bug.cgi?id=20328
8998 Fix a problem when an 'all' transition transition with more than
8999 one property changing is interrupted, and did some AnimationController
9000 cleanup.
9001
9002 Test: transitions/interrupted-all-transition.html
9003
9004 * page/AnimationController.cpp:
9005 (WebCore::ImplicitAnimation::ImplicitAnimation):
9006 (WebCore::AnimationControllerPrivate::blendProperties):
9007 (WebCore::CompositeAnimation::updateTransitions):
9008 (WebCore::CompositeAnimation::cleanupFinishedAnimations):
9009 (WebCore::CompositeAnimation::setTransitionStartTime):
9010 (WebCore::CompositeAnimation::overrideImplicitAnimations):
9011 (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
9012 (WebCore::ImplicitAnimation::animate):
9013 (WebCore::ImplicitAnimation::onAnimationEnd):
9014 (WebCore::ImplicitAnimation::sendTransitionEvent):
9015 (WebCore::ImplicitAnimation::affectsProperty):
9016 (WebCore::KeyframeAnimation::endAnimation):
9017 (WebCore::KeyframeAnimation::onAnimationEnd):
9018
kmccullough@apple.com4a967c12008-08-11 20:45:19 +000090192008-08-11 Kevin McCullough <kmccullough@apple.com>
9020
9021 Reviewed by Tim.
9022
9023 - Because console messages have group levels now, newly created messages
9024 that do not specify the level lose their message since the number of
9025 arguments is wrong.
9026
9027 * page/inspector/Console.js:
9028 * page/inspector/Resource.js:
9029
alp@webkit.orgeeb55142008-08-11 19:52:14 +000090302008-08-11 Alp Toker <alp@nuanti.com>
9031
9032 Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take
9033 the opportunity to sort the sources lists.
9034
9035 * GNUmakefile.am:
9036
timothy@apple.com9fe09f82008-08-11 18:48:37 +000090372008-08-11 Timothy Hatcher <timothy@apple.com>
9038
9039 Speed up the the JavaScript syntax highlighter by generating
9040 the finders only once per script instead of per line.
9041
9042 https://bugs.webkit.org/show_bug.cgi?id=20346
9043
9044 Reviewed by Adam Roben.
9045
9046 * page/inspector/SourceFrame.js:
9047 (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
9048 Removed, factored into syntaxHighlightJavascript as an inline function.
9049 (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript):
9050 Pulled in the _syntaxHighlightJavascriptLine so it will create a closure.
9051 Generate the finders before iterating the lines.
9052
aroben@apple.com957d2d32008-08-11 18:31:37 +000090532008-08-11 Adam Roben <aroben@apple.com>
9054
9055 Windows build fix
9056
9057 * WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and
9058 JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file,
9059 too.
9060
mitz@apple.com3f0060f2008-08-11 18:04:46 +000090612008-08-11 Dan Bernstein <mitz@apple.com>
9062
9063 Reviewed by Darin Adler.
9064
9065 - fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
9066
9067 Test: fast/css/counters/invalidate-cached-counter-node.html
9068
9069 * rendering/RenderContainer.cpp:
9070 (WebCore::RenderContainer::invalidateCounters): Added. Invalidates all
9071 RenderCounters in :before and :after content.
9072 * rendering/RenderContainer.h:
9073 * rendering/RenderCounter.cpp:
9074 (WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this
9075 to match the RenderObject method.
9076 (WebCore::RenderCounter::invalidate): Added. Resets the cached
9077 CounterNode and invalidates the object's layout and preferred widths.
9078 (WebCore::destroyCounterNodeChildren): Added a call to
9079 invalidateCounters().
9080 * rendering/RenderCounter.h:
9081 * rendering/RenderObject.h:
9082 (WebCore::RenderObject::invalidateCounters):
9083
dino@apple.com2af8c3a2008-08-11 17:24:36 +000090842008-08-11 Dean Jackson <dino@apple.com>
9085
9086 Implement CSS Animation and Transition Events
9087 https://bugs.webkit.org/show_bug.cgi?id=20337
9088
9089 Implement the events defined in the CSS Animations
9090 and Transitions specifications so code can react
9091 to animations and transitions.
9092
9093 Reviewed by Tim Hatcher and Dave Hyatt.
9094
9095 * DerivedSources.make:
9096 * GNUmakefile.am:
9097 * WebCore.pro:
9098 * WebCore.vcproj/WebCore.vcproj:
9099 * WebCore.xcodeproj/project.pbxproj:
9100 * WebCoreSources.bkl:
9101 Build configs for new files
9102
9103 * bindings/js/JSDOMWindowBase.cpp:
9104 * bindings/js/JSDOMWindowBase.h:
9105 * bindings/js/JSEventCustom.cpp:
9106 * dom/Document.h:
9107 * dom/Event.cpp:
9108 * dom/Event.h:
9109 * dom/EventTarget.cpp:
9110 * dom/EventTargetNode.cpp:
9111 * dom/EventTargetNode.h:
9112 * html/HTMLElement.cpp:
9113 * page/AnimationController.cpp:
9114 do all the new event stuff
9115
9116 * html/HTMLAttributeNames.in:
9117 the onwebkitanimation* and onwebkittransitionend attrs
9118
9119 * dom/WebKitAnimationEvent.cpp: Added.
9120 * dom/WebKitAnimationEvent.h: Added.
9121 * dom/WebKitAnimationEvent.idl: Added.
9122 * dom/WebKitTransitionEvent.cpp: Added.
9123 * dom/WebKitTransitionEvent.h: Added.
9124 * dom/WebKitTransitionEvent.idl: Added.
9125 New files for the events
9126
9127 * manual-tests/transition-events.html: Added.
9128 New testfile
9129
aroben@apple.com3eae8622008-08-11 17:21:23 +000091302008-08-11 Adam Roben <aroben@apple.com>
9131
9132 Add a ForwardingHeader for wtf/NotFound.h
9133
9134 Rubberstamped by Darin Adler.
9135
9136 * ForwardingHeaders/wtf/NotFound.h: Added.
9137
timothy@apple.com2f5bdf02008-08-11 16:53:30 +000091382008-08-11 Timothy Hatcher <timothy@apple.com>
9139
9140 Fixes a bug where error bubbles in JavaScript resources would
9141 be clobbered by the syntax highlighter.
9142
9143 https://bugs.webkit.org/show_bug.cgi?id=20345
9144
9145 Reviewed by Adam Roben.
9146
9147 * manual-tests/inspector/resources/script-error.js: Added.
9148 * manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added.
9149 * page/inspector/SourceFrame.js:
9150 (WebInspector.SourceFrame.prototype._addMessageToSource):
9151 Check the nodeType and not the nodeName, this is less fragile.
9152 (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
9153 Check if the lastChild is an error bubble, if so remove it before
9154 getting the line's textContent. Add the error bubble back at the end.
9155
mrowe@apple.com4ec50d02008-08-11 05:07:42 +00009156== Rolled over to ChangeLog-2008-08-10 ==