blob: 826e68d0e2e9f92e6b884506bc8f648eb9f44f8e [file] [log] [blame]
hyatt@apple.com57b2d522008-09-19 23:39:26 +000012008-09-19 David Hyatt <hyatt@apple.com>
2
3 Add new scrollbar parts to be able to represent back and forward buttons
4 at either end of the scrollbar. The current scrollbar still just draws
5 a single button at either end, but the parts now exist.
6
7 Reviewed by Sam Weinig
8
9 * platform/ScrollTypes.h:
10 (WebCore::):
11 * platform/Scrollbar.cpp:
12 (WebCore::Scrollbar::autoscrollTimerFired):
13 (WebCore::Scrollbar::pressedPartScrollDirection):
14 (WebCore::Scrollbar::pressedPartScrollGranularity):
15 (WebCore::Scrollbar::handleMouseMoveEvent):
16 * platform/ScrollbarTheme.h:
17 (WebCore::ScrollbarTheme::buttonsPlacement):
18 (WebCore::ScrollbarTheme::invalidateParts):
19 * platform/ScrollbarThemeComposite.cpp:
20 (WebCore::ScrollbarThemeComposite::paint):
21 (WebCore::ScrollbarThemeComposite::hitTest):
22 (WebCore::ScrollbarThemeComposite::invalidatePart):
23 * platform/ScrollbarThemeComposite.h:
24
bdakin@apple.com5b0a3b22008-09-19 23:02:03 +0000252008-09-19 Beth Dakin <bdakin@apple.com>
26
27 Reviewed by Dave Hyatt.
28
29 Fix for <rdar://problem/6231308> crash in AutoTableLayout
30
31 The code assumes later on that a TableSection's grid's row vector
32 will never be empty. So make 1 the minimum number of columns.
33
34 * rendering/RenderTableSection.cpp:
35 (WebCore::RenderTableSection::ensureRows):
36
hyatt@apple.comaf711ec2008-09-19 22:55:56 +0000372008-09-19 David Hyatt <hyatt@apple.com>
38
39 Add a new ScrollbarButtonsPlacement type for specifying where
40 the button arrows are in a scrollbar.
41
42 Read in the placement settings for Mac. Nothing is done with the
43 setting yet.
44
45 Add a new buttonsPlacement() method to ScrollbarTheme composite
46 so that the arrow settings can be obtained.
47
48 Reviewed by Sam Weinig
49
50 * platform/ScrollTypes.h:
51 (WebCore::):
52 * platform/ScrollbarThemeComposite.h:
53 (WebCore::ScrollbarThemeComposite::buttonsPlacement):
54 * platform/mac/ScrollbarThemeMac.mm:
55 (WebCore::updateArrowPlacement):
56 (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
57
sfalken@apple.com64602042008-09-19 22:47:45 +0000582008-09-19 Steve Falkenburg <sfalken@apple.com>
59
60 Roll out r36626. It is causing variance in SunSpider numbers on XP.
61
62 Rubber stamped by Mark Rowe.
63
64 * platform/win/SharedTimerWin.cpp:
65 (WebCore::isRunningOnVistaOrLater):
66 (WebCore::setSharedTimerFireTime):
67
kmccullough@apple.comd203b242008-09-19 21:56:14 +0000682008-09-19 Kevin McCullough <kmccullough@apple.com>
69
70 Reviewed by Tim.
71
72 https://bugs.webkit.org/show_bug.cgi?id=20942
73 Bug 20942: Repeated messages in resources don't collapse
74 - Now repeated messages in a resource's view are collapsed and a message
75 says how many were repeated.
76
77 * English.lproj/localizedStrings.js:
78 * manual-tests/inspector/multiple-console-messages.html:
79 * page/inspector/Console.js: Send all the messages to the resource's
80 view before possibly returning early if the message is a repeat.
81 * page/inspector/SourceFrame.js: Add the text about the message being
82 repeated, if it is, and increment it when necessary.
83
cfleizach@apple.com0abaacc2008-09-19 21:39:21 +0000842008-09-19 Chris Fleizach <cfleizach@apple.com>
85
86 Removed unnecessary #if
87
88 * page/mac/AccessibilityObjectWrapper.mm:
89
hyatt@apple.comc9967ce92008-09-19 21:20:59 +0000902008-09-19 David Hyatt <hyatt@apple.com>
91
hyatt@apple.comf658e502008-09-19 22:12:07 +000092 Read in prefs for the scroll delay repeat values for buttons. Also
93 honor the option-click pref for jumping to the thumb when clicking in
94 the track.
95
96 Reviewed by Sam Weinig
97
98 * platform/mac/ScrollbarThemeMac.h:
99 * platform/mac/ScrollbarThemeMac.mm:
100 (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
101 (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay):
102 (WebCore::ScrollbarThemeMac::autoscrollTimerDelay):
103 (WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
104
1052008-09-19 David Hyatt <hyatt@apple.com>
106
hyatt@apple.comc9967ce92008-09-19 21:20:59 +0000107 Move ScrollbarThemeMac.cpp to ScrollbarThemeMac.mm so it can use Obj-C.
108 Set the initial button repeat delay to 0.5 for Mac.
109
110 Reviewed by Sam Weinig
111
112 * WebCore.xcodeproj/project.pbxproj:
113 * platform/mac/ScrollbarThemeMac.cpp: Removed.
114 * platform/mac/ScrollbarThemeMac.h:
115 (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay):
116 * platform/mac/ScrollbarThemeMac.mm: Copied from platform/mac/ScrollbarThemeMac.cpp.
117
darin@apple.com39a180f2008-09-19 21:15:14 +00001182008-09-19 Darin Adler <darin@apple.com>
119
120 Reviewed by Sam Weinig.
121
122 - part 2 of https://bugs.webkit.org/show_bug.cgi?id=20858
123 make each distinct C++ class get a distinct JSC::Structure
124
125 + Fixed all cases where we were using a shared structure for multiple
126 C++ classes in WebCore. This still has to be done in JavaScriptCore.
127
128 + Got rid of cacheGlobalObject.
129
130 + Improved use of PassRefPtr in bindings code.
131
132 + Removed a couple cases where we were potentially allocating prototypes
133 inside a JSObject's construction process -- this can lead to trouble if
134 we do a garbage collection while an object is only partly constructed.
135
136 * bindings/js/JSAudioConstructor.cpp:
137 (WebCore::JSAudioConstructor::JSAudioConstructor): Create a structure explicitly
138 so we don't implicitly share the structure with other objects that use the object
139 prototype.
140
141 * bindings/js/JSDOMBinding.cpp:
142 (WebCore::getCachedDOMConstructor): Added. To be used for constructors so we
143 don't need cacheGlobalObject any more.
144 (WebCore::cacheDOMConstructor): Ditto.
145
146 * bindings/js/JSDOMBinding.h: Removed DOMObject constructor that takes a prototype.
147 Added functions and a function template for getting cached DOM constructors.
148 Removed cacheGlobalObject function template.
149
150 * bindings/js/JSDOMWindowBase.cpp:
151 (WebCore::JSDOMWindowBase::JSDOMWindowBase): Take a PassRefPtr<DOMWindow> since
152 we're taking ownership.
153 * bindings/js/JSDOMWindowBase.h: Changed constructor to take PassRefPtr, since
154 we're taking ownership. Added constructor map.
155 * bindings/js/JSDOMWindowCustom.cpp:
156 (WebCore::JSDOMWindow::mark): Mark the constructors in the map.
157
158 * bindings/js/JSDOMWindowShell.cpp:
159 (WebCore::JSDOMWindowShell::JSDOMWindowShell): Take a PassRefPtr<DOMWindow> since
160 we're taking ownership. Use the new setWindow function to create the JSDOMWindow;
161 this is now done in only that one place.
162 (WebCore::JSDOMWindowShell::setWindow): Added. Creates the JSDOMWindow based on
163 the passed-in DOMWindow. Code was moved here and changed to allocate unique
164 structures for both the window prototype and the window.
165 * bindings/js/JSDOMWindowShell.h: Ditto.
166
167 * bindings/js/JSEventTargetBase.h: Changed class template argument so it doesn't
168 have the same name (JSEventTarget) as an actual class. Removed unhelpful use of
169 private/friend in JSEventTargetBase. Removed comments referring to defunct
170 macros. Changed JSEventTargetBasePrototype to get the prototype with the new
171 rather than its own copy of cacheGlobalObject (I missed this during pass 1).
172 Changed JSEventTargetBasePrototype so it doesn't have so many template arguments.
173
174 * bindings/js/JSEventTargetNode.cpp: Added s_info; needed for the new scheme
175 for caching structures and prototypes.
176 (WebCore::JSEventTargetNode::JSEventTargetNode): Use PassRefPtr.
177 (WebCore::JSEventTargetNode::createPrototype): Added.
178 * bindings/js/JSEventTargetNode.h: Updated for above changes.
179
180 * bindings/js/JSHTMLAllCollection.h:
181 (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Use PassRefPtr.
182 * bindings/js/JSHTMLCollectionCustom.cpp:
183 (WebCore::getNamedItems): Pass ExecState instead of prototype.
184 * bindings/js/JSHTMLFormElementCustom.cpp:
185 (WebCore::JSHTMLFormElement::nameGetter): Ditto.
186 * bindings/js/JSHTMLInputElementBase.cpp:
187 (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Use PassRefPtr.
188 * bindings/js/JSHTMLInputElementBase.h: Ditto.
189 * bindings/js/JSHTMLOptionElementConstructor.cpp:
190 (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
191 Create a unique structure instead of sharing.
192 * bindings/js/JSImageConstructor.cpp:
193 (WebCore::JSImageConstructor::JSImageConstructor): Ditto.
194
195 * bindings/js/JSInspectedObjectWrapper.cpp:
196 (WebCore::JSInspectedObjectWrapper::wrap): Removed overload that takes
197 a prototype rather than a structure. Made the use of inheritorID() here
198 explicit.
199 * bindings/js/JSInspectedObjectWrapper.h: Ditto.
200 * bindings/js/JSInspectorCallbackWrapper.cpp:
201 (WebCore::JSInspectorCallbackWrapper::wrap): Ditto.
202 * bindings/js/JSInspectorCallbackWrapper.h: Ditto.
203
204 * bindings/js/JSNamedNodesCollection.cpp:
205 (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Changed to
206 take an ExecState argument instead of a prototype. Create a unique
207 StructureID instead of sharing.
208 * bindings/js/JSNamedNodesCollection.h: Ditto.
209
210 * bindings/js/JSQuarantinedObjectWrapper.cpp: Removed overloaded
211 constructor that takes a prototype instead of a structure.
212 * bindings/js/JSQuarantinedObjectWrapper.h: Ditto.
213
214 * bindings/js/JSRGBColor.cpp:
215 (WebCore::JSRGBColor::JSRGBColor): Take ExecState instead of a
216 prototype; create a unique structure.
217 (WebCore::getJSRGBColor): Ditto.
218 * bindings/js/JSRGBColor.h: Ditto.
219
220 * bindings/js/JSSQLResultSetRowListCustom.cpp:
221 (WebCore::JSSQLResultSetRowList::item): Use constructEmptyObject instead
222 of explicit coding the idiom for making a new object.
223
224 * bindings/js/JSXMLHttpRequestConstructor.cpp:
225 (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
226 Create a unique structure instead of the shared one.
227 * bindings/js/JSXSLTProcessorConstructor.cpp:
228 (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
229 Ditto.
230
231 * bindings/js/ScriptController.cpp:
232 (WebCore::ScriptController::clearWindowShell): Let the window shell's
233 setWindow function create the JSDOMWindow instead of doing it here.
234
235 * bindings/scripts/CodeGeneratorJS.pm: Changed to use PassRefPtr for
236 the structure and the wrapped object when creating wrappers.
237 Simplified some of the special cases for DOMWindow so they are
238 different only in ways the need to be. Eliminated the
239 JSDOMWindow::createPrototype and JSDOMWindowPrototype::self
240 functions. Moved responsibility for creating the structure and
241 parent prototype out of the prototype constructor into the
242 createPrototype function. Removed the unused "DoNotCache" flag for
243 objects other than DOMWindow. Use getDOMConstructor instead of
244 cacheGlobalObject for constructors. Make each constructor have
245 a unique structure ID.
246
247 * bridge/objc/objc_runtime.h: Added createPrototype and changed the
248 name of the info member to s_info so we can use the standard DOM
249 binding macros to handl the prototype.
250 * bridge/objc/objc_runtime.mm: Fixed namespacing a bit.
251 (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
252 Create a unique structure using getDOMStructure.
253
254 * bridge/runtime_array.cpp: Fixed namespacing a bit.
255 (JSC::RuntimeArray::RuntimeArray): Create a unique structure using
256 getDOMStructure.
257 * bridge/runtime_array.h: Added createPrototype so getDOMStructure
258 will work.
259
260 * bridge/runtime_object.cpp:
261 (JSC::RuntimeObjectImp::RuntimeObjectImp): Create a unique structure using
262 getDOMStructure.
263 * bridge/runtime_object.h: Added createPrototype so getDOMStructure
264 will work.
265
266 * history/CachedPage.cpp:
267 (WebCore::CachedPage::restore): Let the window shell's
268 setWindow function create the JSDOMWindow instead of doing it here.
269
270 * page/DOMWindow.idl: Removed DoNotCache, which is no longer used.
271
mitz@apple.comd6b74252008-09-19 21:02:55 +00002722008-09-19 Dan Bernstein <mitz@apple.com>
273
274 Reviewed by Dave Hyatt.
275
276 This optimization was suggested by Daniel Fenwick
277
278 - speed up measuring text on the Core Text code path by not specifying a paragraph writing direction
279
280 Specifying LTR paragraph directionality when measuring runs of RTL text
mitz@apple.com308acec2008-09-19 21:10:48 +0000281 resulted in typically two CTRuns being generated for every run instead
mitz@apple.comd6b74252008-09-19 21:02:55 +0000282 of one, due to the leading space being reordered to the left.
283
284 * platform/graphics/SimpleFontData.h: Removed the ltr parameter to
285 getCFStringAttributes() and changed m_CFStringAttributes from an array
286 to a single value.
287 * platform/graphics/mac/CoreTextController.cpp:
288 (WebCore::CoreTextController::CoreTextController): Added a
289 mayUseNaturalWritingDirection parameter.
290 (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Changed
291 to force the bidi embedding level whenever
292 m_mayUseNaturalWritingDirectrion is false. Since this is now a common
293 case, made the typesetter options dictionaries static.
294 * platform/graphics/mac/CoreTextController.h:
295 * platform/graphics/mac/FontMacCoreText.cpp:
296 (WebCore::Font::selectionRectForComplexText): Renamed a local variable.
297 (WebCore::Font::floatWidthForComplexText): Changed to allow the
298 CoreTextController to not set the writing direction.
299 * platform/graphics/mac/SimpleFontDataMac.mm:
300 (WebCore::SimpleFontData::getCFStringAttributes): Removed the ltr
301 parameter and the paragraph style attribute.
302
hyatt@apple.com2d7bdf72008-09-19 20:54:33 +00003032008-09-19 David Hyatt <hyatt@apple.com>
304
305 Reviewed by Sam Weinig
306
307 https://bugs.webkit.org/show_bug.cgi?id=20941
308
309 Incorrect height calculation for replaced element inside nested
310 positioned elements (where the inner has a percentage height and
311 the outer implicitly has a fixed height because of explicit top/bottom
312 values).
313
314 Added fast/block/positioning/replaced-inside-top-bottom.html
315
316 * rendering/RenderBox.cpp:
317 (WebCore::RenderBox::availableHeightUsing):
318
cfleizach@apple.com37bd8d72008-09-19 20:48:57 +00003192008-09-19 Chris Fleizach <cfleizach@apple.com>
320
321 Fix Tiger bustage
322
323 * page/mac/AccessibilityObjectWrapper.mm:
324
cfleizach@apple.com63b88ab2008-09-19 20:24:48 +00003252008-09-18 Chris Fleizach <cfleizach@apple.com>
326
327 Reviewed by Darin Adler.
328
329 <rdar://problem/6211041> Expose legend tag in accessibility
330
331 Exposes the legend tag as the titleUIElement of a fieldset
332
333 Test: accessibility/legend.html
334
335 * page/AccessibilityObject.h:
336 (WebCore::AccessibilityObject::isFieldset):
337 * page/AccessibilityRenderObject.cpp:
338 (WebCore::AccessibilityRenderObject::isFieldset):
339 (WebCore::AccessibilityRenderObject::titleUIElement):
340 * page/AccessibilityRenderObject.h:
341 * rendering/RenderFieldset.h:
342
cfleizach@apple.comcff26212008-09-19 20:04:13 +00003432008-09-19 Chris Fleizach <cfleizach@apple.com>
344
345 Reviewed by Darin Adler.
346
347 <rdar://problem/6213171> WebKit should use new array-centric methods for AX performance
348
349 Implement a few AX API methods that will be called by AppKit, which will
350 speed up access to accessibility objects
351
352 * page/mac/AccessibilityObjectWrapper.mm:
353 (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
354 (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
355 (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
356
zecke@webkit.org7594eb62008-09-19 11:06:55 +00003572008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
358
359 Reviewed by Simon Hausmann.
360
zecke@webkit.org3df68032008-09-19 11:43:27 +0000361 [qtwebkit] Set the m_should* flags to their proper value on entry
362 With plugins it was possible that we finished a job twice. This was
363 some kind of reentrancy in QNetworkReplyHandler::sendQueuedItems. By
364 setting the flag to (m_loadMode == LoadDeferred) they will always have
365 the right value and we will not send responses twice.
366
367 * platform/network/qt/QNetworkReplyHandler.cpp:
368
3692008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
370
371 Reviewed by Simon Hausmann.
372
zecke@webkit.org7594eb62008-09-19 11:06:55 +0000373 [qtwebkit] Pass test 70 of acid3. Handle text decoding errors
374 Handle text decoding errors before instructing the parser to parse. We
375 have converted the text to QString and all encoding errors are gone and
376 the parser will not be able to detect them. So handle them before parsing.
377
378 * dom/XMLTokenizerQt.cpp:
379 (WebCore::XMLTokenizer::doWrite):
380
darin@apple.comc9aea832008-09-19 06:49:35 +00003812008-09-18 Darin Adler <darin@apple.com>
382
383 Reviewed by Maciej Stachowiak.
384
385 - part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858
386 make each distinct C++ class get a distinct JSC::Structure
387
388 * bindings/js/JSCSSStyleDeclarationCustom.cpp:
389 (WebCore::JSCSSStyleDeclaration::customPut): Use setDOMException
390 instead of DOMExceptionTranslator.
391
392 * bindings/js/JSDOMBinding.cpp:
393 (WebCore::getCachedDOMObjectWrapper): Updated function name.
394 (WebCore::cacheDOMObjectWrapper): Ditto.
395 (WebCore::forgetDOMObject): Ditto.
396 (WebCore::getCachedDOMNodeWrapper): Ditto.
397 (WebCore::forgetDOMNode): Ditto.
398 (WebCore::cacheDOMNodeWrapper): Ditto.
399 (WebCore::forgetAllDOMNodesForDocument): Ditto.
400 (WebCore::markDOMNodesForDocument): Ditto.
401 (WebCore::updateDOMNodeDocument): Ditto.
402 (WebCore::getCachedDOMStructure): Added.
403 (WebCore::createDOMStructure): Ditto.
404
405 * bindings/js/JSDOMBinding.h: Get rid of the ScriptInterpreter
406 class and replace the static member functions with non-member
407 functions. Added many other functions for getting at structures,
408 prototypes, wrappers, and creating them. Also moved the
409 cacheGlobalObject function here from JavaScriptCore; eventually
410 I'll remove that once I get rid of the remaining callers. Also
411 removed the DOMExceptionTranslator class.
412
413 * bindings/js/JSDOMWindowBase.h: Added JSDOMStructureMap type,
414 and put one of those maps in each window.
415
416 * bindings/js/JSDOMWindowCustom.cpp:
417 (WebCore::markDOMObjectWrapper): Updated for function name change.
418 (WebCore::JSDOMWindow::mark): Added code to mark all the structures
419 in the structure map.
420
421 * bindings/js/JSEventTargetNode.cpp:
422 (WebCore::JSEventTargetNode::JSEventTargetNode): Changed to take
423 a structure instead of a prototype.
424 * bindings/js/JSEventTargetNode.h: Ditto.
425 * bindings/js/JSHTMLAllCollection.h:
426 (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Ditto.
427
428 * bindings/js/JSHTMLInputElementBase.cpp:
429 (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Removed
430 use of the JSC_IMPLEMENT_PROTOTYPE macro, and changed to take a
431 structure instead of a prototype.
432 * bindings/js/JSHTMLInputElementBase.h: Removed use of the
433 JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro, and changed constructor
434 to take a structure instead of a prototype. Created a dummy prototype
435 class that causes the HTMLInputElement prototype to have the
436 HTMLElement prototype.
437
438 * bindings/scripts/CodeGeneratorJS.pm: Change constructors to take
439 structures instead of prototypes. Changed the prototype self function
440 to use the getDOMPrototype function -- later we can eliminate it and
441 have callers invoke getDOMPrototype directly instead. Updated other
442 functions that have name changes. Added code to generate the
443 createPrototype member function. Changed use of cacheGlobalObject to
444 get it from the WebCore namespace instead of the JSC namespace.
445 Changed cacheDOMObject calls to use getDOMObjectWrapper instead.
446
447 * dom/Document.cpp:
448 (WebCore::Document::~Document): Updated for name change and also
449 removed unnecessary JSLock use -- there's no need to lock around this.
450 * dom/Node.cpp:
451 (WebCore::Node::setDocument): Ditto.
452
453 * dom/make_names.pl: Changed to use CREATE_DOM_NODE_WRAPPER macro
454 instead of calling new directly.
455
456 * bindings/js/JSCSSRuleCustom.cpp:
457 (WebCore::toJS): Updated for function name changes and used the
458 CREATE_DOM_OBJECT_WRAPPER macro.
459 * bindings/js/JSCSSValueCustom.cpp:
460 (WebCore::toJS): Ditto.
461 * bindings/js/JSCanvasPixelArrayCustom.cpp:
462 (WebCore::toJS): Ditto.
463 * bindings/js/JSDocumentCustom.cpp:
464 (WebCore::JSDocument::mark): Ditto.
465 (WebCore::toJS): Ditto.
466 * bindings/js/JSElementCustom.cpp:
467 (WebCore::toJSNewlyCreated): Ditto.
468 * bindings/js/JSEventCustom.cpp:
469 (WebCore::toJS): Ditto.
470 * bindings/js/JSEventTargetBase.cpp:
471 (WebCore::jsEventTargetDispatchEvent): Use setDOMException instead
472 of DOMExceptionTranslator.
473 (WebCore::toJS): Updated for function name changes and used the
474 CREATE_DOM_OBJECT_WRAPPER macro.
475 * bindings/js/JSHTMLCollectionCustom.cpp:
476 (WebCore::toJS): Ditto.
477 * bindings/js/JSNodeCustom.cpp:
478 (WebCore::JSNode::mark): Ditto.
479 (WebCore::createWrapper): Ditto.
480 (WebCore::toJS): Ditto.
481 * bindings/js/JSSVGPathSegCustom.cpp:
482 (WebCore::toJS): Ditto.
483 * bindings/js/JSStyleSheetCustom.cpp:
484 (WebCore::toJS): Ditto.
485 (WebCore::JSStyleSheet::mark): Ditto.
486 * bindings/js/JSTextCustom.cpp:
487 (WebCore::toJSNewlyCreated): Ditto.
488 * bindings/js/JSXMLHttpRequestConstructor.cpp:
489 (WebCore::constructXMLHttpRequest): Ditto.
490 * bindings/js/JSXMLHttpRequestCustom.cpp:
491 (WebCore::JSXMLHttpRequest::mark): Ditto.
492 * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
493 (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
494 * bindings/js/JSXSLTProcessorConstructor.cpp:
495 (WebCore::constructXSLTProcessor): Ditto.
496 * bindings/js/ScriptController.cpp:
497 (WebCore::ScriptController::finishedWithEvent): Ditto.
498 * xml/XMLHttpRequest.cpp:
499 (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto.
500 (WebCore::XMLHttpRequest::dropProtection): Ditto.
501
hyatt@apple.com083539d2008-09-19 06:30:16 +00005022008-09-18 David Hyatt <hyatt@apple.com>
503
504 This patch gets a viewless scrollbar working on Mac. It is turned off
505 by default. Hit testing works. For now the scrollbar just paints ugly
506 debug rects in the place of the buttons, track and thumb. It does match
507 Aqua metrics though.
508
509 Reviewed by Sam Weinig
510
511 * WebCore.xcodeproj/project.pbxproj:
512 * page/mac/EventHandlerMac.mm:
513 (WebCore::EventHandler::passMousePressEventToScrollbar):
514 * platform/ScrollbarThemeComposite.cpp:
515 (WebCore::ScrollbarThemeComposite::paint):
516 (WebCore::ScrollbarThemeComposite::trackPosition):
517 * platform/ScrollbarThemeComposite.h:
518 * platform/mac/ScrollViewMac.mm:
519 (WebCore::ScrollView::addChild):
520 * platform/mac/ScrollbarThemeMac.cpp:
521 (WebCore::):
522 (WebCore::ScrollbarThemeMac::hasButtons):
523 (WebCore::ScrollbarThemeMac::hasThumb):
524 (WebCore::buttonRepaintRect):
525 (WebCore::ScrollbarThemeMac::backButtonRect):
526 (WebCore::ScrollbarThemeMac::forwardButtonRect):
527 (WebCore::trackRepaintRect):
528 (WebCore::ScrollbarThemeMac::trackRect):
529 (WebCore::ScrollbarThemeMac::minimumThumbLength):
530 (WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
531 (WebCore::ScrollbarThemeMac::paintTrack):
532 (WebCore::ScrollbarThemeMac::paintButton):
533 (WebCore::ScrollbarThemeMac::paintThumb):
534 * platform/mac/ScrollbarThemeMac.h:
535 (WebCore::ScrollbarThemeMac::supportsControlTints):
536 * platform/qt/ScrollbarThemeQt.cpp:
537 (WebCore::ScrollbarThemeQt::trackPosition):
538
collinj@webkit.org51261aa2008-09-19 06:13:22 +00005392008-09-18 Collin Jackson <collinj@webkit.org>
540
541 Build fix; added missing header file to GNUmakefile.am
542
543 * GNUmakefile.am:
544
weinig@apple.com39aecbe2008-09-19 04:56:21 +00005452008-09-18 Sam Weinig <sam@webkit.org>
546
547 Reviewed by David "the Hair" Hyatt.
548
549 Move DataRef, SVGRenderStyle and SVGRenderStyleDefs in render/style.
550
551 * GNUmakefile.am:
552 * WebCore.pro:
553 * WebCore.vcproj/WebCore.vcproj:
554 * WebCore.xcodeproj/project.pbxproj:
555 * rendering/DataRef.h: Removed.
556 * rendering/SVGRenderStyle.cpp: Removed.
557 * rendering/SVGRenderStyle.h: Removed.
558 * rendering/SVGRenderStyleDefs.cpp: Removed.
559 * rendering/SVGRenderStyleDefs.h: Removed.
560 * rendering/style/DataRef.h: Copied from rendering/DataRef.h.
561 * rendering/style/SVGRenderStyle.cpp: Copied from rendering/SVGRenderStyle.cpp.
562 * rendering/style/SVGRenderStyle.h: Copied from rendering/SVGRenderStyle.h.
563 * rendering/style/SVGRenderStyleDefs.cpp: Copied from rendering/SVGRenderStyleDefs.cpp.
564 * rendering/style/SVGRenderStyleDefs.h: Copied from rendering/SVGRenderStyleDefs.h.
565
mrowe@apple.coma5206592008-09-19 04:47:58 +00005662008-09-18 Mark Rowe <mrowe@apple.com>
567
568 Reviewed by Dan Bernstein.
569
570 Add a means of clearing a FrameTree's name.
571
572 * WebCore.base.exp:
573 * page/FrameTree.cpp:
574 (WebCore::FrameTree::clearName):
575 * page/FrameTree.h:
576
hyatt@apple.com6eeef382008-09-19 04:30:53 +00005772008-09-18 David Hyatt <hyatt@apple.com>
578
579 Eliminate addToSuperview from Widget, since it was only called
580 by ScrollViewMac's addChild method. Just shift the original body
581 of addToSuperView into addChild.
582
583 Reviewed by Sam Weinig
584
585 * platform/Widget.h:
586 * platform/mac/ScrollViewMac.mm:
587 (WebCore::ScrollView::addChild):
588 * platform/mac/WidgetMac.mm:
589
collinj@webkit.org9c672f62008-09-19 04:15:14 +00005902008-09-18 Collin Jackson <collinj@webkit.org>
591
592 Reviewed by Antti Koivisto and Mark Rowe.
593
594 Test: http/tests/misc/dns-prefetch-control.html
595
596 https://bugs.webkit.org/show_bug.cgi?id=20690
597
598 Invoke WebCore::prefetchDNS() on host names that appear in
599 in the href of hyperlinks and <link rel="dns-prefetch">. This
600 can be used to implement DNS prefetching.
601
602 * WebCore.vcproj/WebCore.vcproj:
603 * WebCore.xcodeproj/project.pbxproj:
604 * dom/Document.cpp:
605 (WebCore::Document::Document):
606 (WebCore::Document::processHttpEquiv):
607 (WebCore::Document::setSecurityOrigin):
608 (WebCore::Document::initDNSPrefetch):
609 (WebCore::Document::parseDNSPrefetchControlHeader):
610 * dom/Document.h:
611 (WebCore::Document::isDNSPrefetchEnabled):
612 * html/HTMLAnchorElement.cpp:
613 (WebCore::HTMLAnchorElement::parseMappedAttribute):
614 * html/HTMLLinkElement.cpp:
615 (WebCore::HTMLLinkElement::HTMLLinkElement):
616 (WebCore::HTMLLinkElement::parseMappedAttribute):
617 (WebCore::HTMLLinkElement::tokenizeRelAttribute):
618 (WebCore::HTMLLinkElement::process):
619 * html/HTMLLinkElement.h:
620 * html/PreloadScanner.cpp:
621 (WebCore::PreloadScanner::processAttribute):
622 * loader/FrameLoader.cpp:
623 (WebCore::FrameLoader::begin):
624 * platform/gtk/TemporaryLinkStubs.cpp:
625 (WebCore::prefetchDNS):
626 * platform/network/DNS.h: Added.
627 * platform/network/cf/DNSCFNet.cpp: Added.
628 (WebCore::prefetchDNS):
629 * platform/qt/TemporaryLinkStubs.cpp:
630 (WebCore::prefetchDNS):
631 * platform/wx/TemporaryLinkStubs.cpp:
632 (WebCore::prefetchDNS):
633
hyatt@apple.comc5b931a2008-09-19 00:39:51 +00006342008-09-18 David Hyatt <hyatt@apple.com>
635
hyatt@apple.comcf31c162008-09-19 04:01:56 +0000636 Eliminate the convertToScreenCoordinate method on Widget, since
637 ScrollView has redundant methods that already do the same thing.
638
639 Reviewed by Sam Weinig
640
641 * editing/mac/SelectionControllerMac.mm:
642 (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
643 * platform/Widget.h:
644 * platform/mac/WidgetMac.mm:
645 (WebCore::Widget::containingWindow):
646
6472008-09-18 David Hyatt <hyatt@apple.com>
648
hyatt@apple.com179629b3c2008-09-19 03:16:26 +0000649 Move to only one constructor for Widgets. Rename data to m_data and make
650 it have an #ifdef only for platforms that have platform-specific data (Mac
651 and Gtk).
652
653 Reviewed by Sam Weinig
654
655 * WebCore.base.exp:
656 * platform/Widget.cpp:
657 (WebCore::Widget::init):
658 * platform/Widget.h:
659 * platform/gtk/WidgetGtk.cpp:
660 (WebCore::Widget::Widget):
661 (WebCore::Widget::~Widget):
662 (WebCore::Widget::cursor):
663 (WebCore::Widget::setCursor):
664 * platform/mac/WidgetMac.mm:
665 (WebCore::Widget::Widget):
666 (WebCore::Widget::~Widget):
667 (WebCore::Widget::addToSuperview):
668 (WebCore::Widget::removeFromSuperview):
669 (WebCore::Widget::beforeMouseDown):
670 (WebCore::Widget::afterMouseDown):
671 * platform/qt/WidgetQt.cpp:
672 (WebCore::Widget::Widget):
673 * platform/win/WidgetWin.cpp:
674 (WebCore::Widget::Widget):
675 * platform/wx/WidgetWx.cpp:
676 (WebCore::Widget::Widget):
677
6782008-09-18 David Hyatt <hyatt@apple.com>
679
hyatt@apple.com470d7e72008-09-19 03:01:08 +0000680 Move Qt's isNPAPIPlugin boolean from Widget down to PluginView, since there
681 was no reason for it to be on Widget. This change eliminates Qt ifdefs
682 from Widget.
683
684 Reviewed by Sam Weinig
685
686 * bindings/js/ScriptControllerQt.cpp:
687 (WebCore::ScriptController::createScriptInstanceForWidget):
688 * platform/qt/WidgetQt.cpp:
689 (WebCore::WidgetPrivate::WidgetPrivate):
690 (WebCore::WidgetPrivate::~WidgetPrivate):
691 (WebCore::Widget::Widget):
692 (WebCore::Widget::~Widget):
693 * plugins/PluginView.cpp:
694 (WebCore::PluginView::PluginView):
695 * plugins/PluginView.h:
696 (WebCore::PluginView::isNPAPIPlugin):
697 (WebCore::PluginView::setIsNPAPIPlugin):
698
6992008-09-18 David Hyatt <hyatt@apple.com>
700
hyatt@apple.com557408b2008-09-19 02:36:08 +0000701 Make geometryChanged() cross-platform on Widget. GTK and WIN platform
702 ifdefs are now gone from Widget!
703
704 Reviewed by Sam Weinig
705
706 * platform/Widget.h:
707 (WebCore::Widget::geometryChanged):
708 * platform/gtk/WidgetGtk.cpp:
709 * platform/qt/WidgetQt.cpp:
710
7112008-09-18 David Hyatt <hyatt@apple.com>
712
hyatt@apple.com17e57432008-09-19 02:29:27 +0000713 Consolidate convertTo/FromContainingWindow methods so that all platforms
714 but Mac share the same code.
715
716 Move convertSelfToChild and convertChildToSelf to ScrollView, since
717 Widget should know nothing about children. Make the methods cross-platform
718 on ScrollView.
719
720 Reviewed by Sam Weinig
721
722 * platform/ScrollView.h:
723 (WebCore::ScrollView::convertChildToSelf):
724 (WebCore::ScrollView::convertSelfToChild):
725 * platform/Widget.cpp:
726 (WebCore::Widget::convertToContainingWindow):
727 (WebCore::Widget::convertFromContainingWindow):
728 * platform/Widget.h:
729 (WebCore::Widget::geometryChanged):
730 * platform/gtk/ScrollViewGtk.cpp:
731 (WebCore::ScrollView::isScrollViewScrollbar):
732 * platform/gtk/WidgetGtk.cpp:
733 * platform/mac/ScrollViewMac.mm:
734 (WebCore::ScrollView::isScrollViewScrollbar):
735 * platform/mac/WidgetMac.mm:
736 * platform/qt/ScrollViewQt.cpp:
737 (WebCore::ScrollView::isScrollViewScrollbar):
738 * platform/qt/WidgetQt.cpp:
739 * platform/win/ScrollViewWin.cpp:
740 (WebCore::ScrollView::isScrollViewScrollbar):
741 * platform/win/WidgetWin.cpp:
742
7432008-09-18 David Hyatt <hyatt@apple.com>
744
hyatt@apple.comc5b931a2008-09-19 00:39:51 +0000745 Make the conversion methods that go to and from some containingWindow
746 cross-platform. Implement them on Mac.
747
748 Reviewed by Sam Weinig
749
750 * platform/Widget.h:
751 (WebCore::Widget::setContainingWindow):
752 * platform/mac/WidgetMac.mm:
753 (WebCore::Widget::convertFromContainingWindow):
754 (WebCore::Widget::convertToContainingWindow):
755
weinig@apple.comd1ea02d2008-09-19 00:28:05 +00007562008-09-18 Sam Weinig <sam@webkit.org>
757
758 Rubber-stamped by David "Yeah-yeah" Hyatt.
759
760 Cleanup RenderStyle.
761
762 * WebCore.xcodeproj/project.pbxproj:
763 * rendering/style/CounterContent.h:
764 * rendering/style/RenderStyle.cpp:
765 * rendering/style/RenderStyle.h:
766
dino@apple.comef93f532008-09-19 00:01:07 +00007672008-09-18 Chris Marrin <cmarrin@apple.com>
768
769 Reviewed by Sam Weinig
770
771 Fixed https://bugs.webkit.org/show_bug.cgi?id=20908
772 Now TransformOperations and AnimationList no longer
773 inherit from Vector<> but rather have API to access.
774
775 * css/CSSComputedStyleDeclaration.cpp:
776 (WebCore::computedTransform):
777 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
778 * css/CSSStyleSelector.cpp:
779 (WebCore::CSSStyleSelector::createTransformOperations):
780 * page/animation/AnimationBase.cpp:
781 (WebCore::blendFunc):
782 * page/animation/CompositeAnimation.cpp:
783 (WebCore::CompositeAnimation::updateTransitions):
784 (WebCore::CompositeAnimation::updateKeyframeAnimations):
785 (WebCore::CompositeAnimation::animate):
786 * page/animation/ImplicitAnimation.cpp:
787 (WebCore::ImplicitAnimation::validateTransformFunctionList):
788 * page/animation/KeyframeAnimation.cpp:
789 (WebCore::KeyframeAnimation::validateTransformFunctionList):
790 * rendering/RenderLayer.cpp:
791 (WebCore::RenderLayer::updateReflectionStyle):
792 * rendering/style/AnimationList.cpp:
793 (WebCore::AnimationList::operator==):
794 * rendering/style/AnimationList.h:
795 (WebCore::AnimationList::operator!=):
796 (WebCore::AnimationList::size):
797 (WebCore::AnimationList::isEmpty):
798 (WebCore::AnimationList::resize):
799 (WebCore::AnimationList::remove):
800 (WebCore::AnimationList::append):
801 (WebCore::AnimationList::animation):
802 * rendering/style/RenderStyle.cpp:
803 (WebCore::StyleRareNonInheritedData::updateKeyframes):
804 (WebCore::RenderStyle::applyTransform):
805 (WebCore::RenderStyle::adjustAnimations):
806 (WebCore::RenderStyle::adjustTransitions):
807 (WebCore::RenderStyle::transitionForProperty):
808 * rendering/style/RenderStyle.h:
809 (WebCore::RenderStyle::hasTransform):
810 * rendering/style/TransformOperations.cpp:
811 (WebCore::TransformOperations::TransformOperations):
812 (WebCore::TransformOperations::operator==):
813 * rendering/style/TransformOperations.h:
814 (WebCore::TransformOperations::apply):
815 (WebCore::TransformOperations::operations):
816
zecke@webkit.org20690ef2008-09-18 23:28:34 +00008172008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
818
zecke@webkit.org30db7422008-09-19 01:00:18 +0000819 Build fix.
820
821 [qt] Build fixes after the Widget/ScrollView cleanup
822 topLevel() is now root()
823
824
825 * platform/qt/ScrollViewQt.cpp:
826 (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
827 (WebCore::ScrollView::addChild):
828 (WebCore::ScrollView::removeChild):
829
8302008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
831
zecke@webkit.org20690ef2008-09-18 23:28:34 +0000832 Reviewed by Mark Rowe.
833
834 https://bugs.webkit.org/show_bug.cgi?id=20437
835
836 XMLTokenizer.cpp used to contain two different implementations. One was using
837 libxml2 and the other was using the Qt XML StreamReader. Clean up the code by
838 separating the two implementations from each other.
839 Common code and some small bits are kept inside the XMLTokenizer.cpp, the Qt code
840 was moved to XMLTokenizerQt.cpp and the Libxml2 based code was moved to
841 XMLTokenizerLibxml2.cpp. There should be no functional changes.
842
843 Attempt to add XMLTokenizerLibxml2.cpp to every buildsystem so the build continues
844 to work.
845
846 * GNUmakefile.am:
847 * WebCore.pro:
848 * WebCore.vcproj/WebCore.vcproj:
849 * WebCore.xcodeproj/project.pbxproj:
850 * WebCoreSources.bkl:
851 * dom/XMLTokenizer.cpp:
852 (WebCore::isScriptElement):
853 (WebCore::castToScriptElement):
854 (WebCore::XMLTokenizer::setCurrentNode):
855 (WebCore::XMLTokenizer::write):
856 (WebCore::XMLTokenizer::eventuallyMarkAsParserCreated):
857 (WebCore::XMLTokenizer::enterText):
858 (WebCore::toString):
859 (WebCore::XMLTokenizer::exitText):
860 (WebCore::XMLTokenizer::end):
861 (WebCore::XMLTokenizer::insertErrorMessageBlock):
862 * dom/XMLTokenizer.h:
863 (WebCore::XMLTokenizer::wellFormed):
864 * dom/XMLTokenizerLibxml2.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
865 (WebCore::createMemoryParser):
866 (WebCore::XMLTokenizer::XMLTokenizer):
867 (WebCore::XMLTokenizer::~XMLTokenizer):
868 (WebCore::XMLTokenizer::doWrite):
869 (WebCore::ignorableWhitespaceHandler):
870 (WebCore::XMLTokenizer::initializeParserContext):
871 (WebCore::XMLTokenizer::doEnd):
872 (WebCore::XMLTokenizer::lineNumber):
873 (WebCore::XMLTokenizer::columnNumber):
874 (WebCore::XMLTokenizer::stopParsing):
875 (WebCore::XMLTokenizer::resumeParsing):
876 (WebCore::parseXMLDocumentFragment):
877 (WebCore::attributesStartElementNsHandler):
878 (WebCore::parseAttributes):
879 * dom/XMLTokenizerQt.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
880 (WebCore::EntityResolver::resolveUndeclaredEntity):
881 (WebCore::XMLTokenizer::XMLTokenizer):
882 (WebCore::XMLTokenizer::~XMLTokenizer):
883 (WebCore::XMLTokenizer::doWrite):
884 (WebCore::XMLTokenizer::initializeParserContext):
885 (WebCore::XMLTokenizer::doEnd):
886 (WebCore::XMLTokenizer::lineNumber):
887 (WebCore::XMLTokenizer::columnNumber):
888 (WebCore::XMLTokenizer::stopParsing):
889 (WebCore::XMLTokenizer::resumeParsing):
890 (WebCore::parseXMLDocumentFragment):
891 (WebCore::attributesStartElementNsHandler):
892 (WebCore::parseAttributes):
893 (WebCore::):
894
bdakin@apple.com4c244902008-09-18 23:08:35 +00008952008-09-18 Beth Dakin <bdakin@apple.com>
896
897 Reviewed by Geoff Garen.
898
899 Build fix for non-Mac builds.
900
901 * css/CSSPrimitiveValue.cpp:
902 (WebCore::CSSPrimitiveValue::cssText):
903
eric@webkit.org4ac94e62008-09-18 23:07:55 +00009042008-09-18 Peter Kasting <pkasting@google.com>
905
906 Reviewed by hyatt. Landed by eseidel.
907
908 https://bugs.webkit.org/show_bug.cgi?id=20745
909 Animated GIFs do not animate properly with (at least) CG.
910
911 * WebCore\platform\graphics\BitmapImage.cpp:
912 * WebCore\platform\graphics\BitmapImage.h:
913 * WebCore\platform\graphics\cairo\ImageCairo.cpp:
914 * WebCore\platform\graphics\cg\ImageCG.cpp:
915 * WebCore\platform\graphics\qt\ImageQt.cpp:
916 * WebCore\platform\graphics\wx\ImageWx.cpp:
917
cfleizach@apple.com2a72d8f2008-09-18 22:54:37 +00009182008-09-18 Chris Fleizach <cfleizach@apple.com>
919
920 Reviewed by Beth Dakin
921
922 <rdar://problem/6224222> AX: should not expose a <table> as an AXTable if ARIA
923 role specifies otherwise
924
925 If a <table> isn't an AXTable, the rows and cells should default to AccessibilityRenderObject
926
927 Test: accessibility/table-with-aria-role.html
928
929 * page/AccessibilityTable.cpp:
930 (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
931 (WebCore::AccessibilityTable::addChildren):
932 (WebCore::AccessibilityTable::roleValue):
933 (WebCore::AccessibilityTable::accessibilityIsIgnored):
934 (WebCore::AccessibilityTable::title):
935 * page/AccessibilityTableCell.cpp:
936 (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
937 (WebCore::AccessibilityTableCell::isTableCell):
938 (WebCore::AccessibilityTableCell::roleValue):
939 * page/AccessibilityTableCell.h:
940 * page/AccessibilityTableRow.cpp:
941 (WebCore::AccessibilityTableRow::roleValue):
942 (WebCore::AccessibilityTableRow::isTableRow):
943 (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
944 * page/AccessibilityTableRow.h:
945
sfalken@apple.coma96c5d32008-09-18 22:29:34 +00009462008-09-18 Steve Falkenburg <sfalken@apple.com>
947
948 Use higher-resolution timers on all variants of Windows.
949
950 Reviewed by Darin Adler.
951
952 * platform/win/SharedTimerWin.cpp:
953 (WebCore::setSharedTimerFireTime):
954
955
hyatt@apple.comb7d49b62008-09-18 22:21:25 +00009562008-09-18 David Hyatt <hyatt@apple.com>
957
958 Make containingWindow() and setContainingWindow() cross-platform.
959 Add a root() function cross-platform so Qt doesn't have to
960 define its own.
961
962 Reviewed by Darin Adler
963
964 * platform/Widget.cpp:
965 (WebCore::Widget::root):
966 * platform/Widget.h:
967 (WebCore::Widget::setContainingWindow):
968 * platform/gtk/WidgetGtk.cpp:
969 (WebCore::Widget::Widget):
970 (WebCore::Widget::containingWindow):
971 * platform/mac/ScrollViewMac.mm:
972 (WebCore::ScrollView::addChild):
973 (WebCore::ScrollView::removeChild):
974 * platform/mac/WidgetMac.mm:
975 (WebCore::Widget::containingWindow):
976 * platform/qt/WidgetQt.cpp:
977 (WebCore::Widget::invalidateRect):
978 (WebCore::Widget::containingWindow):
979 * platform/win/WidgetWin.cpp:
980 (WebCore::Widget::Widget):
981 (WebCore::Widget::~Widget):
982 (WebCore::Widget::containingWindow):
983
bdakin@apple.comfa1ce162008-09-18 22:18:01 +00009842008-09-18 Beth Dakin <bdakin@apple.com>
985
986 Reviewed by Dave Hyatt.
987
988 Fix for https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon
989 parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
990 dashboard-region=
991 and corresponding: <rdar://problem/6174100>
992
993 This patch makes CSSParserValue::createCSSValue handle unknown
994 identifiers.
995
996 * css/CSSParserValues.cpp:
997 (WebCore::CSSParserValue::createCSSValue): If we have an identifier
998 with no id (an unknown identifier) create a CSSPrimitiveValue of
999 type CSS_PARSER_IDENTIFIER
1000 * css/CSSPrimitiveValue.cpp:
1001 (WebCore::CSSPrimitiveValue::cssText):
1002 (WebCore::CSSPrimitiveValue::parserValue):
1003 * css/CSSPrimitiveValue.h:
1004 (WebCore::CSSPrimitiveValue::):
1005
weinig@apple.comfce49be2008-09-18 21:46:14 +000010062008-09-18 Sam Weinig <sam@webkit.org>
1007
1008 Rubber-stamped by David "I'd prefer not" Hyatt.
1009
1010 More the remaining class out of RenderStyle.h/cpp
1011
1012 * GNUmakefile.am:
1013 * WebCore.pro:
1014 * WebCore.vcproj/WebCore.vcproj:
1015 * WebCore.xcodeproj/project.pbxproj:
1016 * WebCoreSources.bkl:
1017 * rendering/style/CursorData.h: Copied from rendering/style/RenderStyle.h.
1018 (WebCore::CursorData::CursorData):
1019 (WebCore::CursorData::operator==):
1020 (WebCore::CursorData::operator!=):
1021 * rendering/style/CursorList.h: Copied from rendering/style/RenderStyle.h.
1022 (WebCore::CursorList::operator[]):
1023 (WebCore::CursorList::CursorList):
1024 * rendering/style/RenderStyle.cpp:
1025 * rendering/style/RenderStyle.h:
1026 (WebCore::RenderStyle::deref):
1027 (WebCore::RenderStyle::hasOneRef):
1028 (WebCore::RenderStyle::InheritedFlags::operator!=):
1029 (WebCore::RenderStyle::NonInheritedFlags::operator!=):
1030 (WebCore::RenderStyle::hasBackground):
1031 (WebCore::RenderStyle::outlineWidth):
1032 (WebCore::RenderStyle::autoWrap):
1033 (WebCore::RenderStyle::preserveNewline):
1034 (WebCore::RenderStyle::collapseWhiteSpace):
1035 (WebCore::RenderStyle::isCollapsibleWhiteSpace):
1036 (WebCore::RenderStyle::breakOnlyAfterWhiteSpace):
1037 (WebCore::RenderStyle::breakWords):
1038 (WebCore::RenderStyle::outlineOffset):
1039 (WebCore::RenderStyle::setLeft):
1040 (WebCore::RenderStyle::setRight):
1041 (WebCore::RenderStyle::setTop):
1042 (WebCore::RenderStyle::setBottom):
1043 (WebCore::RenderStyle::setDashboardRegion):
1044 (WebCore::RenderStyle::setBackgroundColor):
1045 (WebCore::RenderStyle::setBorderImage):
1046 (WebCore::RenderStyle::setBorderRadius):
1047 (WebCore::RenderStyle::setFontDescription):
1048 (WebCore::RenderStyle::adjustBackgroundLayers):
1049 (WebCore::RenderStyle::adjustMaskLayers):
1050 (WebCore::RenderStyle::deleteBindingURIs):
1051 (WebCore::RenderStyle::inheritBindingURIs):
1052 (WebCore::RenderStyle::isDisplayReplacedType):
1053 (WebCore::RenderStyle::isDisplayInlineType):
1054 (WebCore::RenderStyle::isOriginalDisplayInlineType):
1055 * rendering/style/StyleInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
1056 * rendering/style/StyleInheritedData.h: Copied from rendering/style/RenderStyle.h.
1057 (WebCore::StyleInheritedData::operator!=):
1058 * rendering/style/StyleRareInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
1059 * rendering/style/StyleRareInheritedData.h: Copied from rendering/style/RenderStyle.h.
1060 (WebCore::StyleRareInheritedData::operator!=):
1061 * rendering/style/StyleRareNonInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
1062 * rendering/style/StyleRareNonInheritedData.h: Copied from rendering/style/RenderStyle.h.
1063 * rendering/style/StyleReflection.h: Copied from rendering/style/RenderStyle.h.
1064
hyatt@apple.com643534d2008-09-18 20:09:41 +000010652008-09-18 David Hyatt <hyatt@apple.com>
1066
hyatt@apple.comd23089a2008-09-18 20:24:16 +00001067 Move the concept of suppression invalidation on Widgets to Scrollbar
1068 instead. Since this is only used by Scrollbars, there is no need for
1069 it to be on Widget.
1070
1071 Reviewed by Sam Weinig
1072
1073 * platform/Scrollbar.cpp:
1074 (WebCore::Scrollbar::Scrollbar):
1075 (WebCore::Scrollbar::invalidateRect):
1076 * platform/Scrollbar.h:
1077 (WebCore::Scrollbar::suppressInvalidation):
1078 (WebCore::Scrollbar::setSuppressInvalidation):
1079 * platform/Widget.h:
1080 * platform/gtk/WidgetGtk.cpp:
1081 (WebCore::Widget::Widget):
1082 (WebCore::Widget::invalidateRect):
1083 * platform/qt/WidgetQt.cpp:
1084 (WebCore::WidgetPrivate::WidgetPrivate):
1085 (WebCore::Widget::invalidateRect):
1086 * platform/win/WidgetWin.cpp:
1087 (WebCore::Widget::Widget):
1088 (WebCore::Widget::invalidateRect):
1089
10902008-09-18 David Hyatt <hyatt@apple.com>
1091
hyatt@apple.com643534d2008-09-18 20:09:41 +00001092 Make invalidate() on Widget non-virtual and make it just call
1093 invalidateRect() on the boundsGeometry() of the Widget.
1094
1095 Reviewed by Dan Bernstein
1096
1097 * platform/Widget.h:
1098 (WebCore::Widget::boundsGeometry):
1099 (WebCore::Widget::invalidate):
1100 * platform/gtk/WidgetGtk.cpp:
1101 * platform/mac/WidgetMac.mm:
1102 * platform/qt/WidgetQt.cpp:
1103 * platform/win/WidgetWin.cpp:
1104 * platform/wx/WidgetWx.cpp:
1105
weinig@apple.comcaf2df42008-09-18 19:40:24 +000011062008-09-18 Sam Weinig <sam@webkit.org>
1107
1108 Rubber-stamped in exile by David Hyatt.
1109
1110 Split Animation, AnimationList, BindingURI, ContentData, CounterContent,
1111 KeyframeList, ShadowData, StyleFlexibleBoxData and TimingFunction out of
1112 RenderStyle.h/cpp
1113
1114 * GNUmakefile.am:
1115 * WebCore.pro:
1116 * WebCore.vcproj/WebCore.vcproj:
1117 * WebCore.xcodeproj/project.pbxproj:
1118 * WebCoreSources.bkl:
1119 * css/CSSStyleSelector.cpp:
1120 * css/CSSStyleSelector.h:
1121 * page/animation/CompositeAnimation.cpp:
1122 * page/animation/KeyframeAnimation.cpp:
1123 * page/animation/KeyframeAnimation.h:
1124 * rendering/RenderCounter.h:
1125 * rendering/style/Animation.cpp: Copied from rendering/style/RenderStyle.cpp.
1126 (WebCore::Animation::~Animation):
1127 (WebCore::Animation::animationsMatch):
1128 (WebCore::Animation::keyframeList):
1129 (WebCore::Animation::setAnimationKeyframe):
1130 * rendering/style/Animation.h: Copied from rendering/style/RenderStyle.h.
1131 * rendering/style/AnimationList.cpp: Copied from rendering/style/RenderStyle.cpp.
1132 * rendering/style/AnimationList.h: Copied from rendering/style/RenderStyle.h.
1133 * rendering/style/BindingURI.cpp: Copied from rendering/style/RenderStyle.cpp.
1134 * rendering/style/BindingURI.h: Copied from rendering/style/RenderStyle.h.
1135 (WebCore::BindingURI::operator!=):
1136 * rendering/style/ContentData.cpp: Copied from rendering/style/RenderStyle.cpp.
1137 * rendering/style/ContentData.h: Copied from rendering/style/RenderStyle.h.
1138 (WebCore::ContentData::ContentData):
1139 (WebCore::ContentData::~ContentData):
1140 * rendering/style/CounterContent.h: Copied from rendering/style/RenderStyle.h.
1141 (WebCore::CounterContent::CounterContent):
1142 * rendering/style/CounterDirectives.cpp: Copied from rendering/style/RenderStyle.cpp.
1143 * rendering/style/CounterDirectives.h: Copied from rendering/style/RenderStyle.h.
1144 (WebCore::CounterDirectives::CounterDirectives):
1145 * rendering/style/KeyframeList.cpp: Copied from rendering/style/RenderStyle.cpp.
1146 (WebCore::KeyframeList::insert):
1147 * rendering/style/KeyframeList.h: Copied from rendering/style/RenderStyle.h.
1148 (WebCore::KeyframeValue::KeyframeValue):
1149 (WebCore::KeyframeList::create):
1150 (WebCore::KeyframeList::KeyframeList):
1151 * rendering/style/RenderStyle.cpp:
1152 * rendering/style/RenderStyle.h:
1153 * rendering/style/ShadowData.cpp: Copied from rendering/style/RenderStyle.cpp.
1154 * rendering/style/ShadowData.h: Copied from rendering/style/RenderStyle.h.
1155 (WebCore::ShadowData::ShadowData):
1156 (WebCore::ShadowData::~ShadowData):
1157 (WebCore::ShadowData::operator!=):
1158 * rendering/style/StyleFlexibleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
1159 * rendering/style/StyleFlexibleBoxData.h: Copied from rendering/style/RenderStyle.h.
1160 (WebCore::StyleFlexibleBoxData::operator!=):
1161 * rendering/style/TimingFunction.h: Copied from rendering/style/RenderStyle.h.
1162 (WebCore::TimingFunction::TimingFunction):
1163 (WebCore::TimingFunction::operator==):
1164
adele@apple.com5b2b5da2008-09-18 18:49:44 +000011652008-09-18 Adele Peterson <adele@apple.com>
1166
1167 Reviewed by Dan Bernstein.
1168
1169 Fix RenderStyle leaks.
1170
1171 * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
1172
kmccullough@apple.comd4089752008-09-18 17:21:49 +000011732008-09-18 Kevin McCullough <kmccullough@apple.com>
1174
kmccullough@apple.com76c708f2008-09-18 18:03:23 +00001175 Accidentally checked in code.
1176
1177 * html/HTMLElementFactory.cpp:
1178 (WebCore::frameConstructor):
1179 (WebCore::iframeConstructor):
1180
11812008-09-18 Kevin McCullough <kmccullough@apple.com>
1182
kmccullough@apple.comd4089752008-09-18 17:21:49 +00001183 Reviewed by Tim.
1184
1185 <rdar://problem/5722310> gracefully handle too many console messages
1186 (20904)
1187 - Keep track of the most previous message and then compare it to the
1188 subsequent messages as they come in. If there are multiple of the same
1189 message create a count that indicates the current number.
1190
1191 * manual-tests/inspector/multiple-console-messages.html: Added.
1192 * page/inspector/Console.js:
1193 * page/inspector/inspector.css:
1194
alp@webkit.org18a1fbc2008-09-18 11:50:26 +000011952008-09-18 Jonathon Jongsma <jonathon@quotidian.org>
1196
1197 Reviewed by Alp Toker
1198
1199 https://bugs.webkit.org/show_bug.cgi?id=20830
1200 [GTK] Don't use deprecated pango API
1201
1202 Replace deprecated pango functions with non-deprecated ones for newer
1203 versions of pango
1204
1205 * platform/graphics/gtk/FontGtk.cpp:
1206 (WebCore::getDefaultPangoLayout):
1207 * platform/graphics/gtk/FontPlatformDataPango.cpp:
1208 (WebCore::FontPlatformData::FontPlatformData):
1209
alp@webkit.org2154ef22008-09-18 08:10:49 +000012102008-09-18 Alp Toker <alp@nuanti.com>
1211
1212 Build fix for r36587. Add new sources (and sort the lists).
1213
1214 * GNUmakefile.am:
1215
weinig@apple.com3a98b2a2008-09-18 05:51:35 +000012162008-09-17 Sam Weinig <sam@webkit.org>
1217
1218 Fix Windows build.
1219
1220 * WebCore.vcproj/WebCore.vcproj:
1221
hyatt@apple.comb3699722008-09-18 05:10:03 +000012222008-09-17 David Hyatt <hyatt@apple.com>
1223
1224 Switch back to having frameGeometry be virtual in order to keep Mac
1225 the way it used to be.
1226
1227 Reviewed by Sam Weinig
1228
1229 * WebCore.base.exp:
1230 * platform/Widget.cpp:
1231 (WebCore::Widget::setParent):
1232 * platform/Widget.h:
1233 * platform/gtk/WidgetGtk.cpp:
1234 (WebCore::Widget::frameGeometry):
1235 (WebCore::Widget::setFrameGeometry):
1236 * platform/mac/WidgetMac.mm:
1237 (WebCore::Widget::frameGeometry):
1238 (WebCore::Widget::setFrameGeometry):
1239 * platform/qt/WidgetQt.cpp:
1240 (WebCore::Widget::frameGeometry):
1241 (WebCore::Widget::setFrameGeometry):
1242 * platform/win/WidgetWin.cpp:
1243 (WebCore::Widget::frameGeometry):
1244 (WebCore::Widget::setFrameGeometry):
1245 * platform/wx/WidgetWx.cpp:
1246 (WebCore::Widget::frameGeometry):
1247 (WebCore::Widget::setFrameGeometry):
1248 * plugins/PluginView.cpp:
1249 (WebCore::PluginView::setFrameGeometry):
1250 (WebCore::PluginView::geometryChanged):
1251 * plugins/PluginView.h:
1252 * plugins/gtk/PluginViewGtk.cpp:
1253 (WebCore::PluginView::updatePluginWidget):
1254 * plugins/qt/PluginViewQt.cpp:
1255 (WebCore::PluginView::updatePluginWidget):
1256 * plugins/win/PluginViewWin.cpp:
1257 (WebCore::PluginView::updatePluginWidget):
1258
weinig@apple.com00f4d5c2008-09-18 03:23:08 +000012592008-09-17 Sam Weinig <sam@webkit.org>
1260
weinig@apple.com4fd54cd2008-09-18 05:03:21 +00001261 Reviewed by Mark Rowe.
1262
1263 Fix assertion in DOMWindow::adjustWindowRect where we were passing
1264 in garbage values and were getting lucky that they were a not Nan.
1265
1266 * bindings/js/JSDOMWindowBase.cpp:
1267 (WebCore::windowProtoFuncOpen):
1268
12692008-09-17 Sam Weinig <sam@webkit.org>
1270
weinig@apple.com95b14762008-09-18 04:28:40 +00001271 Fix gtk build.
1272
1273 * rendering/style/MatrixTransformOperation.cpp:
1274
12752008-09-17 Sam Weinig <sam@webkit.org>
1276
weinig@apple.com00f4d5c2008-09-18 03:23:08 +00001277 Rubber-stamped with love by David Hyatt.
1278
1279 Split IdentityTransformOperation, MatrixTransformOperation, RotateTransformOperation,
1280 ScaleTransformOperation, SkewTransformOperation, StyleTransformData, TransformOperation,
1281 TransformOperations and TranslateTransformOperation out of RenderStyle.h/cpp
1282
1283 * GNUmakefile.am:
1284 * WebCore.pro:
1285 * WebCore.vcproj/WebCore.vcproj:
1286 * WebCore.xcodeproj/project.pbxproj:
1287 * WebCoreSources.bkl:
1288 * css/CSSStyleSelector.cpp:
1289 * page/animation/AnimationBase.cpp:
1290 (WebCore::solveEpsilon):
1291 * rendering/RenderLayer.cpp:
1292 * rendering/style/IdentityTransformOperation.h: Copied from rendering/style/RenderStyle.h.
1293 * rendering/style/MatrixTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
1294 * rendering/style/MatrixTransformOperation.h: Copied from rendering/style/RenderStyle.h.
1295 (WebCore::MatrixTransformOperation::MatrixTransformOperation):
1296 * rendering/style/RenderStyle.cpp:
1297 * rendering/style/RenderStyle.h:
1298 * rendering/style/RotateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
1299 * rendering/style/RotateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
1300 (WebCore::RotateTransformOperation::RotateTransformOperation):
1301 * rendering/style/ScaleTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
1302 * rendering/style/ScaleTransformOperation.h: Copied from rendering/style/RenderStyle.h.
1303 (WebCore::ScaleTransformOperation::ScaleTransformOperation):
1304 * rendering/style/SkewTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
1305 * rendering/style/SkewTransformOperation.h: Copied from rendering/style/RenderStyle.h.
1306 (WebCore::SkewTransformOperation::SkewTransformOperation):
1307 * rendering/style/StyleTransformData.cpp: Copied from rendering/style/RenderStyle.cpp.
1308 * rendering/style/StyleTransformData.h: Copied from rendering/style/RenderStyle.h.
1309 (WebCore::StyleTransformData::operator!=):
1310 * rendering/style/TransformOperation.h: Copied from rendering/style/RenderStyle.h.
1311 (WebCore::TransformOperation::):
1312 * rendering/style/TransformOperations.cpp: Copied from rendering/style/RenderStyle.cpp.
1313 (WebCore::TransformOperations::TransformOperations):
1314 * rendering/style/TransformOperations.h: Copied from rendering/style/RenderStyle.h.
1315 (WebCore::TransformOperations::operator!=):
1316 * rendering/style/TranslateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
1317 * rendering/style/TranslateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
1318 (WebCore::TranslateTransformOperation::TranslateTransformOperation):
1319
mrowe@apple.comdbfa8852008-09-18 02:59:20 +000013202008-09-17 Mark Rowe <mrowe@apple.com>
1321
1322 Build fix.
1323
1324 * rendering/style/StyleDashboardRegion.h: PlatformString.h rather than String.h.
1325
hyatt@apple.com76057b42008-09-18 02:48:46 +000013262008-09-17 David Hyatt <hyatt@apple.com>
1327
1328 (1) Inline a bunch of methods for accessing frame geometry.
1329 (2) Make sure frameGeometry() works even when you have no underlying
1330 native widget.
1331 (3) Cache a frame geometry rect cross-platform (even for widgets that
1332 have underlying native widgets.
1333 (4) PluginView's updateWindow call is now a virtual function on Widget.
1334
1335 Reviewed by Sam Weinig
1336
1337 * ChangeLog:
1338 * WebCore.base.exp:
1339 * platform/Widget.cpp:
1340 (WebCore::Widget::setFrameGeometry):
1341 * platform/Widget.h:
1342 (WebCore::Widget::x):
1343 (WebCore::Widget::y):
1344 (WebCore::Widget::width):
1345 (WebCore::Widget::height):
1346 (WebCore::Widget::size):
1347 (WebCore::Widget::pos):
1348 (WebCore::Widget::frameGeometry):
1349 (WebCore::Widget::resize):
1350 (WebCore::Widget::move):
1351 (WebCore::Widget::isFrameView):
1352 (WebCore::Widget::windowClipRect):
1353 * platform/mac/WidgetMac.mm:
1354 (WebCore::Widget::~Widget):
1355 (WebCore::Widget::updatePlatformWidgetFrameGeometry):
1356 * platform/win/WidgetWin.cpp:
1357 (WebCore::Widget::updatePlatformWidgetFrameGeometry):
1358 * plugins/PluginView.cpp:
1359 (WebCore::PluginView::setFrameGeometry):
1360 (WebCore::PluginView::geometryChanged):
1361 * plugins/PluginView.h:
1362 * plugins/gtk/PluginViewGtk.cpp:
1363 (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
1364 * plugins/qt/PluginViewQt.cpp:
1365 (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
1366 * plugins/win/PluginViewWin.cpp:
1367 (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
1368 * plugins/wx/PluginViewWx.cpp:
1369
weinig@apple.coma812a3ce2008-09-18 01:46:26 +000013702008-09-17 Sam Weinig <sam@webkit.org>
1371
weinig@apple.comb4b66742008-09-18 02:47:55 +00001372 Reviewed by David "Waterman" Hyatt.
1373
1374 Fix a leak of NSViews in WidgetMac.mm.
1375
1376 * platform/mac/WidgetMac.mm:
1377 (WebCore::Widget::~Widget):
1378
13792008-09-17 Sam Weinig <sam@webkit.org>
1380
weinig@apple.coma812a3ce2008-09-18 01:46:26 +00001381 Rubber-stamped by David Waterman Hyatt.
1382
1383 Split FillLayer, StyleBackgroundData, StyleBoxData, StyleDashboardRegion, StyleMarqueeData
1384 StyleMultiColData and StyleVisualData out of RenderStyle.h/cpp
1385
1386 * GNUmakefile.am:
1387 * WebCore.pro:
1388 * WebCore.vcproj/WebCore.vcproj:
1389 * WebCore.xcodeproj/project.pbxproj:
1390 * WebCoreSources.bkl:
1391 * rendering/style/FillLayer.cpp: Copied from rendering/style/RenderStyle.cpp.
1392 * rendering/style/FillLayer.h: Copied from rendering/style/RenderStyle.h.
1393 (WebCore::FillLayer::operator!=):
1394 (WebCore::FillLayer::hasImage):
1395 (WebCore::FillLayer::hasFixedImage):
1396 * rendering/style/RenderStyle.cpp:
1397 * rendering/style/RenderStyle.h:
1398 * rendering/style/StyleBackgroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
1399 (WebCore::StyleBackgroundData::StyleBackgroundData):
1400 * rendering/style/StyleBackgroundData.h: Copied from rendering/style/RenderStyle.h.
1401 (WebCore::StyleBackgroundData::~StyleBackgroundData):
1402 (WebCore::StyleBackgroundData::operator!=):
1403 * rendering/style/StyleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
1404 * rendering/style/StyleBoxData.h: Copied from rendering/style/RenderStyle.h.
1405 (WebCore::StyleBoxData::operator!=):
1406 * rendering/style/StyleDashboardRegion.h: Copied from rendering/style/RenderStyle.h.
1407 (WebCore::StyleDashboardRegion::operator!=):
1408 * rendering/style/StyleMarqueeData.cpp: Copied from rendering/style/RenderStyle.cpp.
1409 * rendering/style/StyleMarqueeData.h: Copied from rendering/style/RenderStyle.h.
1410 (WebCore::StyleMarqueeData::operator!=):
1411 * rendering/style/StyleMultiColData.cpp: Copied from rendering/style/RenderStyle.cpp.
1412 * rendering/style/StyleMultiColData.h: Copied from rendering/style/RenderStyle.h.
1413 (WebCore::StyleMultiColData::operator!=):
1414 (WebCore::StyleMultiColData::ruleWidth):
1415 * rendering/style/StyleVisualData.cpp: Copied from rendering/style/RenderStyle.cpp.
1416 * rendering/style/StyleVisualData.h: Copied from rendering/style/RenderStyle.h.
1417 (WebCore::StyleVisualData::operator==):
1418
hyatt@apple.comb4f28b32008-09-18 00:39:36 +000014192008-09-17 David Hyatt <hyatt@apple.com>
1420
hyatt@apple.com3f19eac2008-09-18 00:56:04 +00001421 Remove WidgetClient from Widget.
1422
1423 Reviewed by Sam Weinig
1424
1425 * WebCore.xcodeproj/project.pbxproj:
1426 * platform/Widget.h:
1427 (WebCore::Widget::setClient):
1428 (WebCore::Widget::client):
1429 * platform/WidgetClient.h: Removed.
1430 * platform/gtk/WidgetGtk.cpp:
1431 * platform/mac/WidgetMac.mm:
1432 (WebCore::Widget::Widget):
1433 (WebCore::Widget::show):
1434 (WebCore::Widget::hide):
1435 * platform/qt/WidgetQt.cpp:
1436 (WebCore::WidgetPrivate::WidgetPrivate):
1437 * platform/win/WidgetWin.cpp:
1438 (WebCore::Widget::Widget):
1439 * platform/wx/WidgetWx.cpp:
1440 (WebCore::Widget::Widget):
1441
14422008-09-17 David Hyatt <hyatt@apple.com>
1443
hyatt@apple.comb4f28b32008-09-18 00:39:36 +00001444 Remove isEnabled/setEnabled from Widget. The concept of being enabled now
1445 only applies to Scrollbars so the method has been moved there and made
1446 cross-platform. Scrollbar subclasses that have a corresponding native
1447 widget can subclass setEnabled to change the enabled state of the native
1448 widget.
1449
1450 Reviewed by Sam Weinig & Darin Adler
1451
1452 * WebCore.base.exp:
1453 * platform/Scrollbar.cpp:
1454 (WebCore::Scrollbar::Scrollbar):
1455 * platform/Scrollbar.h:
1456 (WebCore::Scrollbar::enabled):
1457 (WebCore::Scrollbar::setEnabled):
1458 * platform/Widget.h:
1459 * platform/gtk/ScrollbarGtk.cpp:
1460 (ScrollbarGtk::setEnabled):
1461 * platform/gtk/ScrollbarGtk.h:
1462 * platform/gtk/WidgetGtk.cpp:
1463 * platform/mac/ScrollbarMac.h:
1464 * platform/mac/ScrollbarMac.mm:
1465 (WebCore::ScrollbarMac::scrollbarHit):
1466 (WebCore::ScrollbarMac::setEnabled):
1467 * platform/mac/WidgetMac.mm:
1468 * platform/qt/WidgetQt.cpp:
1469 (WebCore::WidgetPrivate::WidgetPrivate):
1470 * platform/win/WidgetWin.cpp:
1471 (WebCore::Widget::Widget):
1472 * platform/wx/WidgetWx.cpp:
1473
weinig@apple.com1ea40602008-09-17 23:56:27 +000014742008-09-17 Sam Weinig <sam@webkit.org>
1475
1476 Rubber-stamped by David Hyatt.
1477
1478 Split all RenderStyle enums into their own file.
1479
1480 * GNUmakefile.am:
1481 * WebCore.vcproj/WebCore.vcproj:
1482 * WebCore.xcodeproj/project.pbxproj:
1483 * rendering/style/BorderValue.h:
1484 * rendering/style/CollapsedBorderValue.h:
1485 * rendering/style/RenderStyle.h:
1486 * rendering/style/RenderStyleConstants.h: Copied from rendering/style/RenderStyle.h.
1487 (WebCore::):
1488 * rendering/style/StyleCachedImage.h:
1489 * rendering/style/StyleGeneratedImage.h:
1490 * rendering/style/StyleImage.h:
1491
sfalken@apple.combf270912008-09-17 23:53:17 +000014922008-09-17 Steve Falkenburg <sfalken@apple.com>
1493
1494 Add back isFrameView check to fix failed assertion during scroll bar teardown.
1495
1496 Reviewed by Dave Hyatt.
1497
1498 * platform/Scrollbar.cpp:
1499 (WebCore::Scrollbar::setParent):
1500
beidson@apple.com4398e482008-09-17 23:30:00 +000015012008-09-17 Brady Eidson <beidson@apple.com>
1502
1503 Reviewed by Mac build fix
1504
1505 * WebCore.xcodeproj/project.pbxproj: Send appropriate headers to WebKit
1506
sfalken@apple.com85cc1392008-09-17 23:28:13 +000015072008-09-17 Steve Falkenburg <sfalken@apple.com>
1508
1509 Fix build.
1510
1511 * platform/win/ScrollViewWin.cpp:
1512 (WebCore::ScrollView::setParentVisible):
1513 * plugins/win/PluginViewWin.cpp:
1514 (WebCore::PluginView::init):
1515
zecke@webkit.org2ba9a4e2008-09-17 23:25:10 +000015162008-09-17 Holger Hans Peter Freyther <zecke@selfish.org>
1517
1518 Reviewed by Simon.
1519
1520 [QtWebKit] Implement error handling in TextCodecQt::decode
1521 Use the QTextCodec parsing state to set the sawError out variable. This
1522 is needed to pass Test 70 of acid3. The test case for this bug is
1523 fast/encoding/invalid-xml.html that is now partially passed. To pass
1524 it completely the Qt text codecs need to be adjusted to have proper
1525 error handling.
1526
1527 * platform/text/qt/TextCodecQt.cpp:
1528 (WebCore::TextCodecQt::decode):
1529
weinig@apple.comf6f0f112008-09-17 23:03:16 +000015302008-09-17 Sam Weinig <sam@webkit.org>
1531
1532 Rubber-stamped by Dave Hyatt.
1533
1534 Split BorderData, BorderValue, CollapsedBorderValue, OutlineValue and StyleSurroundData
1535 out of RenderStyle.h/cpp
1536
1537 * GNUmakefile.am:
1538 * WebCore.pro:
1539 * WebCore.vcproj/WebCore.vcproj:
1540 * WebCore.xcodeproj/project.pbxproj:
1541 * WebCoreSources.bkl:
1542 * rendering/style/BorderData.h: Copied from rendering/style/RenderStyle.h.
1543 (WebCore::BorderData::hasBorderRadius):
1544 (WebCore::BorderData::borderLeftWidth):
1545 (WebCore::BorderData::borderRightWidth):
1546 (WebCore::BorderData::borderTopWidth):
1547 (WebCore::BorderData::borderBottomWidth):
1548 (WebCore::BorderData::operator!=):
1549 * rendering/style/BorderValue.h: Copied from rendering/style/RenderStyle.h.
1550 (WebCore::):
1551 (WebCore::BorderValue::BorderValue):
1552 (WebCore::BorderValue::nonZero):
1553 (WebCore::BorderValue::isTransparent):
1554 (WebCore::BorderValue::isVisible):
1555 * rendering/style/CollapsedBorderValue.h: Copied from rendering/style/RenderStyle.h.
1556 (WebCore::):
1557 (WebCore::CollapsedBorderValue::CollapsedBorderValue):
1558 (WebCore::CollapsedBorderValue::operator==):
1559 * rendering/style/OutlineValue.h: Copied from rendering/style/RenderStyle.h.
1560 (WebCore::OutlineValue::OutlineValue):
1561 * rendering/style/RenderStyle.cpp:
1562 * rendering/style/RenderStyle.h:
1563 * rendering/style/StyleSurroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
1564 * rendering/style/StyleSurroundData.h: Copied from rendering/style/RenderStyle.h.
1565 (WebCore::StyleSurroundData::operator!=):
1566
bdakin@apple.com06b97182008-09-17 23:00:29 +000015672008-09-17 Beth Dakin <bdakin@apple.com>
1568
1569 Reviewed by Darin Adler.
1570
1571 This is a better fix for: Invalid CSS code crashes Safari
1572 https://bugs.webkit.org/show_bug.cgi?id=20512
1573
1574 The spec indicates that the only valid input for a counter is a
1575 number or an identifier. So that is exactly what we allow.
1576
1577 * css/CSSParser.cpp:
1578 (WebCore::CSSParser::parseCounterContent):
1579
alp@webkit.org97ba9222008-09-17 22:16:26 +000015802008-09-17 Alp Toker <alp@nuanti.com>
1581
1582 GTK+ build fix. Adapt to use PlatformWidget functions.
1583
1584 * platform/gtk/ScrollViewGtk.cpp:
1585 (WebCore::ScrollViewScrollbar::geometryChanged):
1586 (WebCore::ScrollView::addChild):
1587 (WebCore::ScrollView::removeChild):
1588 * platform/gtk/ScrollbarGtk.cpp:
1589 (ScrollbarGtk::ScrollbarGtk):
1590 (ScrollbarGtk::~ScrollbarGtk):
1591 (ScrollbarGtk::geometryChanged):
1592
weinig@apple.com930ed392008-09-17 22:00:45 +000015932008-09-17 Sam Weinig <sam@webkit.org>
1594
1595 Reviewed by Adele Peterson.
1596
1597 Patch for <rdar://problem/6133884>
1598 Calling window.resizeTo() on a subframe shouldn't change the window size
1599
1600 Test: fast/dom/Window/window-resize-and-move-sub-frame.html
1601
1602 * page/DOMWindow.cpp:
1603 (WebCore::DOMWindow::moveBy):
1604 (WebCore::DOMWindow::moveTo):
1605 (WebCore::DOMWindow::resizeBy):
1606 (WebCore::DOMWindow::resizeTo):
1607
bdakin@apple.com8f952d82008-09-17 21:35:02 +000016082008-09-17 Beth Dakin <bdakin@apple.com>
1609
1610 Reviewed by Adam Roben.
1611
1612 Fix for https://bugs.webkit.org/show_bug.cgi?id=20512 Invalid CSS
1613 code crashes Safari
1614 and corresponding: <rdar://problem/6173832>
1615
1616 Reading through the spec, it seems like a function is not valid
1617 input for a counter. So this patch checks for that and bails in the
1618 case of invalid input.
1619
1620 * css/CSSParser.cpp:
1621 (WebCore::CSSParser::parseCounterContent):
1622
antti@apple.comb37d4052008-09-17 21:14:13 +000016232008-09-17 Greg Bolsinga <bolsinga@apple.com>
1624
1625 Reviewed by Antti Koivisto.
1626
1627 Fix <rdar://problem/6227089>
1628 Crash in WebCore::Frame::setNeedsReapplyStyles()
1629
1630 View is null checked elsewhere too.
1631
1632 * page/Frame.cpp:
1633 (WebCore::Frame::setNeedsReapplyStyles):
1634
hyatt@apple.com8e340252008-09-17 20:59:45 +000016352008-09-17 David Hyatt <hyatt@apple.com>
1636
1637 Make the notion of having a native widget backing a Widget cross-platform.
1638 The PlatformWidget abstraction (which already existed) is used for this.
1639 Windows = HWND
1640 Qt = QWidget
1641 Mac = NSView
1642 wx = wxWindow
1643 Gtk = GtkWidget
1644
1645 There are new cross-platform methods that replace all of the unique
1646 platform-specific methods.
1647 platformWidget()
1648 setPlatformWidget()
1649
1650 For plugins, on every platform except Qt on Windows, the plugin's native
1651 widget is now stored in the Widget base class. Since Qt on Windows uses
1652 HWNDs for plugins instead of QWidget, it is the only platform to keep the
1653 m_window variable in PluginView.
1654
1655 Reviewed by Sam Weinig
1656
1657 * WebCore.base.exp:
1658 * bindings/js/ScriptControllerMac.mm:
1659 (WebCore::ScriptController::createScriptInstanceForWidget):
1660 * page/mac/AccessibilityObjectWrapper.mm:
1661 (-[AccessibilityObjectWrapper attachmentView]):
1662 (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1663 * page/mac/EventHandlerMac.mm:
1664 (WebCore::EventHandler::passMouseDownEventToWidget):
1665 (WebCore::EventHandler::mouseDownViewIfStillGood):
1666 (WebCore::EventHandler::passWheelEventToWidget):
1667 (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
1668 * platform/Widget.cpp:
1669 (WebCore::Widget::init):
1670 (WebCore::Widget::setParent):
1671 (WebCore::Widget::releasePlatformWidget):
1672 (WebCore::Widget::retainPlatformWidget):
1673 * platform/Widget.h:
1674 (WebCore::Widget::platformWidget):
1675 (WebCore::Widget::setPlatformWidget):
1676 * platform/gtk/WidgetGtk.cpp:
1677 (WebCore::Widget::Widget):
1678 (WebCore::Widget::setFocus):
1679 (WebCore::gdkDrawable):
1680 (WebCore::Widget::setCursor):
1681 (WebCore::Widget::show):
1682 (WebCore::Widget::hide):
1683 (WebCore::Widget::setEnabled):
1684 (WebCore::Widget::isEnabled):
1685 (WebCore::Widget::paint):
1686 * platform/mac/PlatformScreenMac.mm:
1687 (WebCore::screenRect):
1688 (WebCore::screenAvailableRect):
1689 * platform/mac/ScrollViewMac.mm:
1690 (WebCore::ScrollView::scrollView):
1691 (WebCore::ScrollView::update):
1692 (WebCore::ScrollView::inWindow):
1693 * platform/mac/ScrollbarMac.mm:
1694 (WebCore::ScrollbarMac::ScrollbarMac):
1695 (WebCore::ScrollbarMac::~ScrollbarMac):
1696 (WebCore::ScrollbarMac::updateThumbPosition):
1697 (WebCore::ScrollbarMac::updateThumbProportion):
1698 (WebCore::ScrollbarMac::scrollbarHit):
1699 * platform/mac/WidgetMac.mm:
1700 (WebCore::Widget::Widget):
1701 (WebCore::Widget::setEnabled):
1702 (WebCore::Widget::isEnabled):
1703 (WebCore::Widget::setFocus):
1704 (WebCore::Widget::getOuterView):
1705 (WebCore::Widget::paint):
1706 (WebCore::Widget::invalidate):
1707 (WebCore::Widget::invalidateRect):
1708 (WebCore::Widget::setIsSelected):
1709 (WebCore::Widget::releasePlatformWidget):
1710 (WebCore::Widget::retainPlatformWidget):
1711 * platform/qt/WidgetQt.cpp:
1712 (WebCore::WidgetPrivate::WidgetPrivate):
1713 (WebCore::Widget::Widget):
1714 (WebCore::Widget::setFrameGeometry):
1715 (WebCore::Widget::show):
1716 (WebCore::Widget::hide):
1717 (WebCore::Widget::isEnabled):
1718 (WebCore::Widget::setEnabled):
1719 (WebCore::Widget::invalidateRect):
1720 (WebCore::Widget::containingWindow):
1721 * platform/win/WidgetWin.cpp:
1722 (WebCore::Widget::Widget):
1723 * platform/wx/WidgetWx.cpp:
1724 (WebCore::Widget::Widget):
1725 (WebCore::Widget::frameGeometry):
1726 (WebCore::Widget::setFocus):
1727 (WebCore::Widget::setCursor):
1728 (WebCore::Widget::show):
1729 (WebCore::Widget::hide):
1730 (WebCore::Widget::setFrameGeometry):
1731 (WebCore::Widget::setEnabled):
1732 (WebCore::Widget::isEnabled):
1733 (WebCore::Widget::invalidate):
1734 (WebCore::Widget::invalidateRect):
1735 (WebCore::Widget::paint):
1736 * plugins/PluginView.cpp:
1737 (WebCore::PluginView::PluginView):
1738 * plugins/PluginView.h:
1739 (WebCore::PluginView::platformPluginWidget):
1740 * plugins/gtk/PluginViewGtk.cpp:
1741 (WebCore::PluginView::updateWindow):
1742 (WebCore::PluginView::setFocus):
1743 (WebCore::PluginView::show):
1744 (WebCore::PluginView::hide):
1745 (WebCore::PluginView::setParent):
1746 (WebCore::PluginView::setNPWindowRect):
1747 (WebCore::PluginView::setParentVisible):
1748 (WebCore::PluginView::getValue):
1749 (WebCore::PluginView::forceRedraw):
1750 (WebCore::PluginView::init):
1751 * plugins/qt/PluginViewQt.cpp:
1752 (WebCore::PluginView::updateWindow):
1753 (WebCore::PluginView::setFocus):
1754 (WebCore::PluginView::show):
1755 (WebCore::PluginView::hide):
1756 (WebCore::PluginView::setParent):
1757 (WebCore::PluginView::setNPWindowRect):
1758 (WebCore::PluginView::setParentVisible):
1759 (WebCore::PluginView::getValue):
1760 (WebCore::PluginView::~PluginView):
1761 (WebCore::PluginView::init):
1762 * plugins/win/PluginViewWin.cpp:
1763 (WebCore::PluginView::updateWindow):
1764 (WebCore::PluginView::setFocus):
1765 (WebCore::PluginView::show):
1766 (WebCore::PluginView::hide):
1767 (WebCore::PluginView::paint):
1768 (WebCore::PluginView::setParent):
1769 (WebCore::PluginView::setParentVisible):
1770 (WebCore::PluginView::setNPWindowRect):
1771 (WebCore::PluginView::stop):
1772 (WebCore::PluginView::invalidateRect):
1773 (WebCore::PluginView::forceRedraw):
1774 (WebCore::PluginView::~PluginView):
1775 (WebCore::PluginView::init):
1776
weinig@apple.comf713d132008-09-17 20:16:48 +000017772008-09-17 Sam Weinig <sam@webkit.org>
1778
1779 Fix assert.
1780
1781 * platform/Widget.cpp:
1782 (WebCore::Widget::setParent):
1783
hyatt@apple.comd9242e32008-09-17 18:46:31 +000017842008-09-17 David Hyatt <hyatt@apple.com>
1785
1786 Beginnings of Widget refactoring (in order to make the mixing of
1787 widgets with and without corresponding native widgets more cross-platform).
1788
1789 This first patch makes the concept of a parent ScrollView cross-platform.
1790
1791 Note the similarity of the show/hide methods on the three PluginViews. This
1792 will be refactored better in a later patch so that they can all share
1793 a base class Widget show/hide method. For now the changes were made
1794 simply to be able to bring WidgetWin's setParent method up into Widget.
1795
1796 Reviewed by Sam Weinig
1797
1798 * WebCore.base.exp:
1799 * platform/ScrollView.h:
1800 * platform/Widget.cpp:
1801 (WebCore::Widget::init):
1802 (WebCore::Widget::setParent):
1803 * platform/Widget.h:
1804 (WebCore::Widget::isSelfVisible):
1805 (WebCore::Widget::isParentVisible):
1806 (WebCore::Widget::isVisible):
1807 (WebCore::Widget::setParentVisible):
1808 (WebCore::Widget::isPluginView):
1809 (WebCore::Widget::parent):
1810 (WebCore::Widget::handleEvent):
1811 (WebCore::Widget::geometryChanged):
1812 * platform/gtk/WidgetGtk.cpp:
1813 (WebCore::Widget::Widget):
1814 * platform/mac/ScrollViewMac.mm:
1815 (WebCore::ScrollView::addChild):
1816 (WebCore::ScrollView::removeChild):
1817 * platform/mac/ScrollbarMac.mm:
1818 (WebCore::ScrollbarMac::~ScrollbarMac):
1819 * platform/mac/WidgetMac.mm:
1820 (WebCore::Widget::Widget):
1821 (WebCore::Widget::~Widget):
1822 * platform/qt/WidgetQt.cpp:
1823 (WebCore::WidgetPrivate::WidgetPrivate):
1824 (WebCore::Widget::Widget):
1825 (WebCore::Widget::topLevel):
1826 * platform/win/ScrollViewWin.cpp:
1827 (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
1828 (WebCore::ScrollView::setAncestorVisible):
1829 (WebCore::ScrollView::show):
1830 (WebCore::ScrollView::hide):
1831 * platform/win/WidgetWin.cpp:
1832 (WebCore::Widget::Widget):
1833 (WebCore::Widget::setParent):
1834 * platform/wx/WidgetWx.cpp:
1835 (WebCore::Widget::Widget):
1836 * plugins/PluginView.cpp:
1837 (WebCore::PluginView::PluginView):
1838 * plugins/PluginView.h:
1839 * plugins/gtk/PluginViewGtk.cpp:
1840 (WebCore::PluginView::show):
1841 (WebCore::PluginView::hide):
1842 (WebCore::PluginView::setParentVisible):
1843 * plugins/qt/PluginViewQt.cpp:
1844 (WebCore::PluginView::show):
1845 (WebCore::PluginView::hide):
1846 (WebCore::PluginView::setParentVisible):
1847 * plugins/win/PluginViewWin.cpp:
1848 (WebCore::PluginView::show):
1849 (WebCore::PluginView::hide):
1850 (WebCore::PluginView::setParentVisible):
1851
ap@webkit.org18da1a32008-09-17 16:50:22 +000018522008-09-17 Alexey Proskuryakov <ap@webkit.org>
1853
1854 Reviewed by Adam Roben.
1855
1856 <rdar://problem/6219577> Spew in console at launch about encoding mappings when running with ICU 4.0
1857
1858 * platform/text/TextCodecICU.cpp:
1859 (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated for new encoding names.
1860
vestbo@webkit.orge48e6362008-09-17 13:29:42 +000018612008-09-17 Tor Arne Vestbø <tavestbo@trolltech.com>
1862
1863 Fix the QtWebKit/Mac build
1864
1865 * platform/qt/ScrollViewQt.cpp: add include
1866
ap@webkit.org18da1a32008-09-17 16:50:22 +000018672008-09-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com0f37fb52008-09-17 08:17:26 +00001868
1869 Add a #define to control whether or not to use an NSScroller on Mac.
1870 This ifdef will allow the new NSView-less NSScroller on Mac to be
1871 developed side by side with the current one.
1872
1873 The new scroller paints a debug red if turned on (although due to
1874 Widget issues you won't see anything paint yet).
1875
1876 Reviewed by olliej
1877
1878 * platform/Scrollbar.cpp:
1879 * platform/Scrollbar.h:
1880 * platform/mac/ScrollbarMac.h:
1881 * platform/mac/ScrollbarMac.mm:
1882 * platform/mac/ScrollbarThemeMac.cpp:
1883 (WebCore::ScrollbarThemeMac::paint):
1884 * platform/mac/ScrollbarThemeMac.h:
1885
alp@webkit.orgf06bac02008-09-17 04:30:12 +000018862008-09-16 Marco Barisione <marco.barisione@collabora.co.uk>
1887
1888 Reviewed by Alp Toker.
1889
1890 http://bugs.webkit.org/show_bug.cgi?id=20854
1891 [GTK] Windows can be not realized in ScrollView::update
1892
1893 Do not call gdk_window_invalidate_rect on a non-realized GtkWidget.
1894
1895 * platform/gtk/ScrollViewGtk.cpp:
1896 (WebCore::ScrollView::update):
1897
alp@webkit.org226f72a2008-09-17 04:22:02 +000018982008-09-16 Alp Toker <alp@nuanti.com>
1899
1900 Suggested by Dave Hyatt.
1901
1902 Build fix and cleanup. Rename ScrollBar to Scrollbar.
1903
1904 * GNUmakefile.am:
1905 * WebCore.pro:
1906 * WebCore.vcproj/WebCore.vcproj:
1907 * WebCore.xcodeproj/project.pbxproj:
1908 * WebCoreSources.bkl:
1909 * editing/EditorCommand.cpp:
1910 * page/EventHandler.cpp:
1911 * page/gtk/EventHandlerGtk.cpp:
1912 * page/mac/EventHandlerMac.mm:
1913 * page/mac/FrameMac.mm:
1914 * page/qt/EventHandlerQt.cpp:
1915 * page/wx/EventHandlerWx.cpp:
1916 * platform/PopupMenu.h:
1917 * platform/ScrollBar.cpp: Removed.
1918 * platform/ScrollBar.h: Removed.
1919 * platform/Scrollbar.cpp: Copied from WebCore/platform/ScrollBar.cpp.
1920 * platform/Scrollbar.h: Copied from WebCore/platform/ScrollBar.h.
1921 * platform/gtk/ScrollbarGtk.cpp:
1922 (ScrollbarGtk::ScrollbarGtk):
1923 * platform/gtk/ScrollbarGtk.h:
1924 * platform/mac/ScrollbarMac.h:
1925 * platform/qt/ScrollViewQt.cpp:
1926 * platform/qt/ScrollbarQt.cpp:
1927 * platform/qt/ScrollbarThemeQt.cpp:
1928 * platform/win/PlatformScrollBar.h:
1929 * platform/win/PopupMenuWin.cpp:
1930 * platform/win/ScrollViewWin.cpp:
1931 * platform/win/ScrollbarThemeWin.cpp:
1932 * platform/wx/ScrollViewWx.cpp:
1933 * platform/wx/TemporaryLinkStubs.cpp:
1934 * rendering/HitTestResult.cpp:
1935 * rendering/RenderLayer.cpp:
1936 * rendering/RenderTextControl.cpp:
1937
hyatt@apple.com7597c172008-09-17 02:15:08 +000019382008-09-16 David Hyatt <hyatt@apple.com>
1939
hyatt@apple.comfde412d2008-09-17 03:49:48 +00001940 Fix Qt build bustage by making moveThumb a member of Scrollbar so that
1941 it can be called from ScrollbarQt.
1942
1943 * platform/ScrollBar.cpp:
1944 (WebCore::Scrollbar::moveThumb):
1945 (WebCore::Scrollbar::handleMouseMoveEvent):
1946 (WebCore::Scrollbar::handleMousePressEvent):
1947 * platform/ScrollBar.h:
1948 * platform/qt/ScrollViewQt.cpp:
1949 * platform/qt/ScrollbarQt.cpp:
1950 (WebCore::Scrollbar::handleContextMenuEvent):
1951
19522008-09-16 David Hyatt <hyatt@apple.com>
1953
hyatt@apple.com4e3b8602008-09-17 03:17:11 +00001954 Eliminate PlatformScrollbar. Mac and Gtk now have subclasses for their
1955 native-widget scrollbars (ScrollbarMac and ScrollbarGtk). Other platforms
1956 now just use Scrollbar.
1957
1958 Reviewed by Sam Weinig
1959
1960 * GNUmakefile.am:
1961 * WebCore.pro:
1962 * WebCore.vcproj/WebCore.vcproj:
1963 * WebCore.xcodeproj/project.pbxproj:
1964 * page/mac/FrameMac.mm:
1965 * platform/PopupMenu.h:
1966 (WebCore::PopupMenu::scrollbar):
1967 * platform/ScrollBar.cpp:
1968 (WebCore::createNativeScrollbar):
1969 * platform/ScrollBar.h:
1970 * platform/gtk/PlatformScrollBar.h: Removed.
1971 * platform/gtk/PlatformScrollBarGtk.cpp: Removed.
1972 * platform/gtk/ScrollbarGtk.cpp: Copied from platform/gtk/PlatformScrollBarGtk.cpp.
1973 (gtkScrollEventCallback):
1974 (ScrollbarGtk::ScrollbarGtk):
1975 (ScrollbarGtk::~ScrollbarGtk):
1976 (ScrollbarGtk::updateThumbPosition):
1977 (ScrollbarGtk::updateThumbProportion):
1978 (ScrollbarGtk::setFrameGeometry):
1979 (ScrollbarGtk::geometryChanged):
1980 (ScrollbarGtk::gtkValueChanged):
1981 * platform/gtk/ScrollbarGtk.h: Copied from platform/gtk/PlatformScrollBar.h.
1982 * platform/mac/PlatformScrollBar.h: Removed.
1983 * platform/mac/PlatformScrollBarMac.mm: Removed.
1984 * platform/mac/ScrollbarMac.h: Copied from platform/mac/PlatformScrollBar.h.
1985 * platform/mac/ScrollbarMac.mm: Copied from platform/mac/PlatformScrollBarMac.mm.
1986 (-[WebCoreScrollBar initWithScrollbarMac:]):
1987 (-[WebCoreScrollBar detachScrollbarMac]):
1988 (WebCore::Scrollbar::createNativeScrollbar):
1989 (WebCore::ScrollbarMac::ScrollbarMac):
1990 (WebCore::ScrollbarMac::~ScrollbarMac):
1991 (WebCore::ScrollbarMac::updateThumbPosition):
1992 (WebCore::ScrollbarMac::updateThumbProportion):
1993 (WebCore::ScrollbarMac::scrollbarHit):
1994 * platform/qt/PlatformScrollBar.h: Removed.
1995 * platform/qt/PlatformScrollBarQt.cpp: Removed.
1996 * platform/qt/ScrollbarQt.cpp: Copied from platform/qt/PlatformScrollBarQt.cpp.
1997 (WebCore::Scrollbar::handleContextMenuEvent):
1998 * rendering/HitTestResult.cpp:
1999 * rendering/RenderLayer.cpp:
2000 (WebCore::RenderLayer::createScrollbar):
2001 (WebCore::RenderLayer::destroyScrollbar):
2002 * rendering/RenderLayer.h:
2003 * rendering/RenderListBox.cpp:
2004 (WebCore::RenderListBox::~RenderListBox):
2005 (WebCore::RenderListBox::updateFromElement):
2006 (WebCore::RenderListBox::isPointInOverflowControl):
2007 * rendering/RenderObject.h:
2008 * rendering/RenderTextControl.cpp:
2009
20102008-09-16 David Hyatt <hyatt@apple.com>
2011
hyatt@apple.com7597c172008-09-17 02:15:08 +00002012 Make the scrollbar resizer-dodging logic cross-platform in the
2013 Scrollbar class.
2014
2015 Reviewed by Sam Weinig
2016
2017 * platform/ScrollBar.cpp:
2018 (WebCore::Scrollbar::setFrameGeometry):
2019 (WebCore::Scrollbar::setParent):
2020 (WebCore::Scrollbar::windowClipRect):
2021 * platform/ScrollBar.h:
2022 * platform/ScrollView.h:
2023 (WebCore::ScrollView::windowResizerRect):
2024 (WebCore::ScrollView::resizerOverlapsContent):
2025 (WebCore::ScrollView::adjustOverlappingScrollbarCount):
2026 * platform/Widget.h:
2027 (WebCore::Widget::setParent):
2028 * platform/mac/WidgetMac.mm:
2029 (WebCore::Widget::convertToContainingWindow):
2030 * platform/win/PlatformScrollBar.h:
2031 * platform/win/PlatformScrollBarWin.cpp:
2032
mitz@apple.com6d925202008-09-16 17:34:10 +000020332008-09-16 Dan Bernstein <mitz@apple.com>
2034
mitz@apple.comd9462a52008-09-16 17:40:20 +00002035 Reviewed by Darin Adler.
2036
2037 - fix https://bugs.webkit.org/show_bug.cgi?id=15129
2038 <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
2039
2040 Covered by fast/repaint/4776765.html
2041
2042 * rendering/RenderBlock.cpp:
2043 (WebCore::RenderBlock::layoutBlock): Avoid repainting this object if it
2044 did not have layout in the beginning.
2045 (WebCore::RenderBlock::layoutBlockChildren): If a child did not have
2046 layout in the beginning, repaint it in its new position, to compensate
2047 for the above (regardless of whether it "moved").
2048 * rendering/RenderObject.cpp:
2049 (WebCore::RenderObject::checkForRepaintDuringLayout): Added a comment
2050 about generalizing this fix in the future.
2051
20522008-09-16 Dan Bernstein <mitz@apple.com>
2053
mitz@apple.com6d925202008-09-16 17:34:10 +00002054 Reviewed by Dave Hyatt.
2055
2056 - fix https://bugs.webkit.org/show_bug.cgi?id=15384
2057 Div does not notice when grandparent changes height
2058
2059 Test: fast/block/basic/quirk-percent-height-grandchild.html
2060
2061 - fix https://bugs.webkit.org/show_bug.cgi?id=20714
2062 Resizing Gmail inbox vertically results in whitespace at the bottom of the window
2063
2064 Test: fast/replaced/percent-height-in-anonymous-block.html
2065
2066 Added a two-way mapping between boxes with percentage heights and
2067 their non-parent ancestors up to the one the height is computed relative
2068 to. In quirks mode (the first bug), this can be any number of containing
2069 block with auto height. In strict mode (the second bug) this can be
2070 the containing block of an anonymous block containing a replaced
2071 element.
2072
2073 * rendering/RenderBlock.cpp:
2074 (WebCore::RenderBlock::~RenderBlock): Added code to remove the all the
2075 mapping to/from this block to percentage-height descendants.
2076 (WebCore::RenderBlock::layoutBlockChildren): Added code to mark
2077 percentage-height descendants (and their containing block ancestry chain
2078 up to this block) for layout. This ensures that those descendants whose
2079 height depends on the height of this block (or an ancestor) are updated.
2080 (WebCore::RenderBlock::addPercentHeightDescendant): Added. Establishes
2081 a two-way mapping between this block and the given box.
2082 (WebCore::RenderBlock::removePercentHeightDescendant): Added. Removes
2083 all the mapping to/from this box.
2084 * rendering/RenderBlock.h:
2085 * rendering/RenderBox.cpp:
2086 (WebCore::RenderBox::setStyle): Added calls to
2087 removePercentHeightDescendant() when style changes and the box
2088 previously had a percentage height. An exception is when the style
2089 change does not require layout, in which case the box still has
2090 a percentage height and the mappings are valid. In all other cases,
2091 any required mappings will be (re-)established during layout.
2092 (WebCore::RenderBox::destroy): Added a call to
2093 removePercentHeightDescendant.
2094 (WebCore::RenderBox::calcPercentageHeight): Added code that, in quirks
2095 mode, if a higher-than-parent containing block is affecting the box's
2096 height, creates a mapping between the box and that block.
2097 (WebCore::RenderBox::calcReplacedHeightUsing): Changed to skip over
2098 anonymous containing blocks, if any, and when that happens, use
2099 addPercentHeightDescendant() to ensure that the non-anonymous block
2100 is aware of the dependent percent-height box.
2101
alp@webkit.org1dbd9a92008-09-16 16:59:18 +000021022008-09-16 Dirk Schulze <vbs85@gmx.de>
2103
2104 Reviewed by Oliver Hunt and Alp Toker.
2105
2106 Implemented toDataURL in Cairo. Only PNG support
2107 at the moment.
2108
2109 Qt, Cairo and wx require toDataURL implementations
2110 https://bugs.webkit.org/show_bug.cgi?id=17719
2111
2112 * platform/MIMETypeRegistry.cpp:
2113 (WebCore::initializeSupportedImageMIMETypesForEncoding):
2114 * platform/graphics/cairo/ImageBufferCairo.cpp:
2115 (WebCore::ImageBuffer::ImageBuffer):
2116 (WebCore::writeFunction):
2117 (WebCore::ImageBuffer::toDataURL):
2118
vestbo@webkit.org8963b3c2008-09-16 16:45:20 +000021192008-09-16 Tor Arne Vestbø <tavestbo@trolltech.com>
2120
2121 Reviewed by Simon.
2122
2123 Hide unused media element controls in the QtWebKit port
2124
2125 * platform/qt/html4-adjustments-qt.css
2126
hausmann@webkit.orgcd7a1292008-09-16 14:19:16 +000021272008-09-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
2128
2129 Reviewed by Simon.
2130
2131 Fix compilation of the Qt scrollbar code.
2132
2133 * platform/qt/PlatformScrollBarQt.cpp:
2134 (WebCore::scPart):
2135 (WebCore::styleOptionSlider):
2136 (WebCore::thumbLength):
2137 (WebCore::pixelPosToRangeValue):
2138 (WebCore::PlatformScrollbar::handleContextMenuEvent):
2139
treat@webkit.orga35f6b62008-09-16 14:15:29 +000021402008-09-16 Adam Treat <treat@kde.org>
2141
2142 Reviewed by Anders Carlsson.
2143
2144 Prevent accesses off of the end of the buffer introduced in r36450
2145 and when checking for descriptions of mime. Also, coding style fix.
2146
2147 * plugins/qt/PluginPackageQt.cpp:
2148 (WebCore::PluginPackage::fetchInfo):
2149
rwlbuis@webkit.org8f675dd2008-09-16 11:12:52 +000021502008-09-15 Rob Buis <buis@kde.org>
2151
2152 Reviewed by Eric.
2153
2154 https://bugs.webkit.org/show_bug.cgi?id=20634
2155 SVG transform attribute is ignored by <use> in <clipPath>
2156
2157 Transform the paths with the local transform when part
2158 of a clip path.
2159
2160 Test: svg/custom/use-clipped-transform.svg
2161
2162 * svg/SVGClipPathElement.cpp:
2163 (WebCore::SVGClipPathElement::canvasResource):
2164 * svg/SVGStyledTransformableElement.cpp:
2165 (WebCore::SVGStyledTransformableElement::toClipPath):
2166 * svg/SVGStyledTransformableElement.h:
2167
hyatt@apple.com1cd4bcc2008-09-16 06:53:34 +000021682008-09-15 Dave Hyatt <hyatt@apple.com>
2169
2170 Convert Qt over to its ScrollbarTheme. Add cross-platform support for jumping the thumb location directly
2171 to a pressed location on the track (this is done with the middle mouse on Qt and with Shift-Click on Windows).
2172
2173 Reviewed by Sam Weinig
2174
2175 * platform/ScrollBar.cpp:
2176 (WebCore::thumbUnderMouse):
2177 (WebCore::Scrollbar::autoscrollPressedPart):
2178 (WebCore::Scrollbar::startTimerIfNeeded):
2179 (WebCore::moveThumb):
2180 (WebCore::Scrollbar::handleMouseMoveEvent):
2181 (WebCore::Scrollbar::handleMousePressEvent):
2182 * platform/ScrollBar.h:
2183 (WebCore::Scrollbar::pressedPos):
2184 (WebCore::Scrollbar::pixelStep):
2185 (WebCore::Scrollbar::setPressedPos):
2186 * platform/ScrollbarTheme.h:
2187 (WebCore::ScrollbarTheme::thumbPosition):
2188 (WebCore::ScrollbarTheme::thumbLength):
2189 (WebCore::ScrollbarTheme::trackPosition):
2190 (WebCore::ScrollbarTheme::trackLength):
2191 * platform/ScrollbarThemeComposite.cpp:
2192 (WebCore::ScrollbarThemeComposite::trackPosition):
2193 * platform/ScrollbarThemeComposite.h:
2194 * platform/qt/PlatformScrollBarQt.cpp:
2195 (WebCore::PlatformScrollbar::PlatformScrollbar):
2196 (WebCore::):
2197 * platform/qt/ScrollbarThemeQt.cpp:
2198 (WebCore::styleOptionSlider):
2199 (WebCore::ScrollbarThemeQt::hitTest):
2200 (WebCore::ScrollbarThemeQt::shouldCenterOnThumb):
2201 (WebCore::ScrollbarThemeQt::invalidatePart):
2202 (WebCore::ScrollbarThemeQt::thumbPosition):
2203 (WebCore::):
2204 * platform/qt/ScrollbarThemeQt.h:
2205 * platform/win/ScrollbarThemeSafari.cpp:
2206 (WebCore::ScrollbarThemeSafari::shouldCenterOnThumb):
2207 * platform/win/ScrollbarThemeSafari.h:
2208 * platform/win/ScrollbarThemeWin.cpp:
2209 (WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
2210 * platform/win/ScrollbarThemeWin.h:
2211
dsmith@webkit.orgb3107b532008-09-16 06:14:22 +000022122008-09-15 David Smith <catfish.man@gmail.com>
2213
2214 Reviewed by Sam Weinig.
2215
2216 https://bugs.webkit.org/show_bug.cgi?id=20180
2217
2218 Cache the result of parsing the an+b expression in :nth-child(an+b). Roughly a 2x speedup for :nth-child on SlickSpeed.
2219
2220 * GNUmakefile.am: Add CSSNthSelector
2221 * WebCore.pro: Add CSSNthSelector
2222 * WebCore.vcproj/WebCore.vcproj: Add CSSNthSelector
2223 * WebCore.xcodeproj/project.pbxproj: Add CSSNthSelector
2224 * css/CSSGrammar.y: Create CSSNthSelectors instead of CSSSelectors for :nth-*
2225 * css/CSSNthSelector.cpp: Added.
2226 (WebCore::CSSNthSelector::parseNth): Moved from CSSStyleSelector and modified to cache
2227 (WebCore::CSSNthSelector::matchNth): Moved from CSSStyleSelector and modified to use the cache
2228 * css/CSSNthSelector.h: Added.
2229 (WebCore::CSSNthSelector::CSSNthSelector):
2230 (WebCore::CSSNthSelector::~CSSNthSelector):
2231 * css/CSSParser.cpp:
2232 (WebCore::CSSParser::createFloatingNthSelector):
2233 * css/CSSParser.h:
2234 * css/CSSSelector.h: Use the free bit here to store a flag for CSSNthSelector
2235 (WebCore::CSSSelector::CSSSelector):
2236 * css/CSSStyleSelector.cpp:
2237 (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Take advantage of knowing that all :nth-* selectors are CSSNthSelectors
2238
pewtermoose@webkit.orgfb4d3fb2008-09-16 02:46:39 +000022392008-09-15 Matt Lilek <webkit@mattlilek.com>
2240
2241 Reviewed by Tim Hatcher.
2242
2243 Clean up some inspector JS callbacks to remove an extra return.
2244
2245 * page/InspectorController.cpp:
2246 (WebCore::hideDOMNodeHighlight):
2247 (WebCore::loaded):
2248 (WebCore::unloading):
2249 (WebCore::attach):
2250 (WebCore::detach):
2251 (WebCore::startDebuggingAndReloadInspectedPage):
2252 (WebCore::stopDebugging):
2253 (WebCore::debuggerAttached):
2254 (WebCore::pauseOnExceptions):
2255 (WebCore::pauseInDebugger):
2256 (WebCore::resumeDebugger):
2257 (WebCore::stepOverStatementInDebugger):
2258 (WebCore::stepIntoStatementInDebugger):
2259 (WebCore::stepOutOfFunctionInDebugger):
2260 (WebCore::isWindowVisible):
2261 (WebCore::closeWindow):
2262
hyatt@apple.com8e809932008-09-16 02:29:09 +000022632008-09-15 Dave Hyatt <hyatt@apple.com>
2264
2265 Completely switch Windows scrollbars over to ScrollbarTheme. The Aqua windows scrollbar and native scrollbar
2266 now share most of their code.
2267
2268 Also removing mini size scrollbar support, since it would have crashed Windows had it ever been used, and it
2269 also is never used in our code anyway.
2270
2271 Reviewed by Sam Weinig
2272
2273 * WebCore.vcproj/WebCore.vcproj:
2274 * platform/ScrollTypes.h:
2275 (WebCore::):
2276 * platform/ScrollbarThemeComposite.cpp:
2277 (WebCore::ScrollbarThemeComposite::splitTrack):
2278 (WebCore::ScrollbarThemeComposite::thumbLength):
2279 (WebCore::ScrollbarThemeComposite::minimumThumbLength):
2280 * platform/ScrollbarThemeComposite.h:
2281 * platform/mac/PlatformScrollBarMac.mm:
2282 (NSControlSizeForScrollBarControlSize):
2283 * platform/win/PlatformScrollBar.h:
2284 * platform/win/PlatformScrollBarSafari.cpp: Removed.
2285 * platform/win/PlatformScrollBarWin.cpp:
2286 (WebCore::PlatformScrollbar::PlatformScrollbar):
2287 * platform/win/ScrollbarThemeSafari.cpp:
2288 (WebCore::ScrollbarTheme::nativeTheme):
2289 (WebCore::):
2290 (WebCore::scrollbarControlStateFromThemeState):
2291 (WebCore::ScrollbarThemeSafari::hasButtons):
2292 (WebCore::ScrollbarThemeSafari::hasThumb):
2293 (WebCore::buttonRepaintRect):
2294 (WebCore::ScrollbarThemeSafari::backButtonRect):
2295 (WebCore::ScrollbarThemeSafari::forwardButtonRect):
2296 (WebCore::trackRepaintRect):
2297 (WebCore::ScrollbarThemeSafari::trackRect):
2298 (WebCore::ScrollbarThemeSafari::minimumThumbLength):
2299 (WebCore::ScrollbarThemeSafari::paintTrack):
2300 (WebCore::ScrollbarThemeSafari::paintButton):
2301 (WebCore::ScrollbarThemeSafari::paintThumb):
2302 * platform/win/ScrollbarThemeSafari.h:
2303 * platform/win/ScrollbarThemeWin.cpp:
2304 * platform/win/ScrollbarThemeWin.h:
2305
cfleizach@apple.com0ce07032008-09-16 00:17:58 +000023062008-09-15 Chris Fleizach <cfleizach@apple.com>
2307
2308 Reviewed by Darin Adler, Beth Dakin
2309
2310 <rdar://problem/4003789> Expose lists as AXList
2311 <rdar://problem/5707399> VO: Definition lists not announced in Safari
2312
2313 Lists are now exposed through AX. On the mac (in SnowLeopard) they use two new subroles
2314 AXContentList for <ul>, <ol> and AXDefinitionList for <dl>
2315 Inside the definition list, each <dt> "term" has an accessibility description ("term"),
2316 as does each <dd> tag ("definition")
2317
2318 Test: accessibility/lists.html
2319
2320 * GNUmakefile.am:
2321 * WebCore.pro:
2322 * WebCore.vcproj/WebCore.vcproj:
2323 * WebCore.xcodeproj/project.pbxproj:
2324 * WebCoreSources.bkl:
2325 * page/AXObjectCache.cpp:
2326 * page/AccessibilityList.cpp: Added.
2327 * page/AccessibilityList.h: Added.
2328 * page/AccessibilityObject.h:
2329 * page/AccessibilityRenderObject.cpp:
2330 * page/AccessibilityTable.cpp:
2331 * page/mac/AccessibilityObjectWrapper.mm:
2332 * page/mac/WebCoreViewFactory.h:
2333 * platform/LocalizedStrings.h:
2334 * platform/mac/LocalizedStringsMac.mm:
2335 * platform/qt/Localizations.cpp:
2336
zimmermann@webkit.org8cc8ad02008-09-16 00:01:11 +000023372008-09-15 Nikolas Zimmermann <zimmermann@kde.org>
2338
2339 Reviewed by Eric.
2340
2341 Fixes: https://bugs.webkit.org/show_bug.cgi?id=20865
2342 Prepare HTMLScriptElement & SVGScriptElement unification, and unification of event handling.
2343
2344 Several renames:
2345 dispatchHTMLEvent -> dispatchEventForType
2346 setHTMLEventListener -> setEventListenerForType
2347 getHTMLEventListener -> eventListenerForType
2348 removeHTMLEventListener -> removeEventListenerForType
2349 isHTMLEventListener -> isAttachedToEventTargetNode
2350 ...
2351
2352 Similar renames for the dispatch/get/set/*Window*Event functions.
2353 Kill JSSVGLazyEventListener and merge with JSLazyEventListener.
2354
2355 Most important change: Rename setHTMLEventListener to setEventListenerForTypeAndAttribute,
2356 as there exists a generic createEventListener() method now, taking care of JSLazyEventListener creation.
2357
2358 setHTMLEventListener() used createHTMLEventListener() before and was HTML specific.
2359 SVG is able to use the code as well now. This affects most files in html/.
2360
2361 No functional changes.
2362
2363 * GNUmakefile.am:
2364 * WebCore.pro:
2365 * WebCore.vcproj/WebCore.vcproj:
2366 * WebCore.xcodeproj/project.pbxproj:
2367 * bindings/js/JSDOMWindowBase.cpp:
2368 (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
2369 (WebCore::JSDOMWindowBase::setListener):
2370 (WebCore::JSDOMWindowBase::getListener):
2371 (WebCore::JSDOMWindowBase::findJSEventListener):
2372 (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
2373 (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
2374 (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
2375 (WebCore::JSDOMWindowBase::jsEventListenersAttachedToEventTargetNodes):
2376 (WebCore::JSDOMWindowBase::jsUnprotectedEventListenersAttachedToEventTargetNodes):
2377 * bindings/js/JSDOMWindowBase.h:
2378 * bindings/js/JSEventListener.cpp:
2379 (WebCore::JSAbstractEventListener::handleEvent):
2380 (WebCore::JSAbstractEventListener::isAttachedToEventTargetNode):
2381 (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
2382 (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
2383 (WebCore::JSEventListener::JSEventListener):
2384 (WebCore::JSEventListener::~JSEventListener):
2385 (WebCore::JSLazyEventListener::JSLazyEventListener):
2386 (WebCore::eventParameterName):
2387 (WebCore::JSLazyEventListener::parseCode):
2388 (WebCore::getNodeEventListener):
2389 * bindings/js/JSEventListener.h:
2390 (WebCore::JSAbstractEventListener::JSAbstractEventListener):
2391 (WebCore::JSUnprotectedEventListener::create):
2392 (WebCore::JSEventListener::create):
2393 (WebCore::JSLazyEventListener::):
2394 (WebCore::JSLazyEventListener::create):
2395 * bindings/js/JSEventTargetNode.cpp:
2396 (WebCore::JSEventTargetNode::setListener):
2397 (WebCore::JSEventTargetNode::getListener):
2398 * bindings/js/JSSVGLazyEventListener.cpp: Removed.
2399 * bindings/js/JSSVGLazyEventListener.h: Removed.
2400 * bindings/js/ScriptController.cpp:
2401 (WebCore::ScriptController::createHTMLEventHandler):
2402 (WebCore::ScriptController::createSVGEventHandler):
2403 * dom/Document.cpp:
2404 (WebCore::Document::setFocusedNode):
2405 (WebCore::Document::handleWindowEvent):
2406 (WebCore::Document::setWindowEventListenerForType):
2407 (WebCore::Document::windowEventListenerForType):
2408 (WebCore::Document::removeWindowEventListenerForType):
2409 (WebCore::Document::addWindowEventListener):
2410 (WebCore::Document::hasWindowEventListener):
2411 (WebCore::Document::removePendingFrameBeforeUnloadEventCount):
2412 (WebCore::Document::createEventListener):
2413 (WebCore::Document::setWindowEventListenerForTypeAndAttribute):
2414 * dom/Document.h:
2415 * dom/EventListener.h:
2416 (WebCore::EventListener::isAttachedToEventTargetNode):
2417 * dom/EventTargetNode.cpp:
2418 (WebCore::EventTargetNode::dispatchFocusEvent):
2419 (WebCore::EventTargetNode::dispatchBlurEvent):
2420 (WebCore::EventTargetNode::dispatchEventForType):
2421 (WebCore::EventTargetNode::removeEventListenerForType):
2422 (WebCore::EventTargetNode::setEventListenerForType):
2423 (WebCore::EventTargetNode::setEventListenerForTypeAndAttribute):
2424 (WebCore::EventTargetNode::eventListenerForType):
2425 * dom/EventTargetNode.h:
2426 * dom/XMLTokenizer.cpp:
2427 (WebCore::XMLTokenizer::notifyFinished):
2428 * editing/ReplaceSelectionCommand.cpp:
2429 (WebCore::ReplacementFragment::ReplacementFragment):
2430 * html/HTMLBodyElement.cpp:
2431 (WebCore::HTMLBodyElement::parseMappedAttribute):
2432 * html/HTMLButtonElement.cpp:
2433 (WebCore::HTMLButtonElement::parseMappedAttribute):
2434 * html/HTMLElement.cpp:
2435 (WebCore::HTMLElement::parseMappedAttribute):
2436 (WebCore::HTMLElement::checkDTD):
2437 * html/HTMLElement.h:
2438 * html/HTMLFormControlElement.cpp:
2439 (WebCore::HTMLFormControlElement::onChange):
2440 * html/HTMLFormElement.cpp:
2441 (WebCore::HTMLFormElement::prepareSubmit):
2442 (WebCore::HTMLFormElement::reset):
2443 (WebCore::HTMLFormElement::parseMappedAttribute):
2444 * html/HTMLFrameElementBase.cpp:
2445 (WebCore::HTMLFrameElementBase::parseMappedAttribute):
2446 * html/HTMLFrameSetElement.cpp:
2447 (WebCore::HTMLFrameSetElement::parseMappedAttribute):
2448 * html/HTMLImageElement.cpp:
2449 (WebCore::HTMLImageElement::parseMappedAttribute):
2450 * html/HTMLImageLoader.cpp:
2451 (WebCore::HTMLImageLoader::dispatchLoadEvent):
2452 * html/HTMLInputElement.cpp:
2453 (WebCore::HTMLInputElement::parseMappedAttribute):
2454 (WebCore::HTMLInputElement::setValueFromRenderer):
2455 (WebCore::HTMLInputElement::onSearch):
2456 * html/HTMLMediaElement.cpp:
2457 (WebCore::HTMLMediaElement::asyncEventTimerFired):
2458 (WebCore::HTMLMediaElement::load):
2459 (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
2460 (WebCore::HTMLMediaElement::setReadyState):
2461 (WebCore::HTMLMediaElement::seek):
2462 (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
2463 (WebCore::HTMLMediaElement::willSaveToCache):
2464 * html/HTMLObjectElement.cpp:
2465 (WebCore::HTMLObjectElement::parseMappedAttribute):
2466 * html/HTMLScriptElement.cpp:
2467 (WebCore::HTMLScriptElement::parseMappedAttribute):
2468 (WebCore::HTMLScriptElement::dispatchLoadEvent):
2469 (WebCore::HTMLScriptElement::dispatchErrorEvent):
2470 * html/HTMLSelectElement.cpp:
2471 (WebCore::HTMLSelectElement::parseMappedAttribute):
2472 * html/HTMLTextAreaElement.cpp:
2473 (WebCore::HTMLTextAreaElement::parseMappedAttribute):
2474 * html/HTMLTokenizer.cpp:
2475 (WebCore::HTMLTokenizer::notifyFinished):
2476 * page/AccessibilityRenderObject.cpp:
2477 (WebCore::AccessibilityRenderObject::mouseButtonListener):
2478 * page/EventHandler.cpp:
2479 (WebCore::EventHandler::canMouseDownStartSelect):
2480 (WebCore::EventHandler::canMouseDragExtendSelect):
2481 * page/Frame.cpp:
2482 (WebCore::Frame::sendScrollEvent):
2483 * page/Page.cpp:
2484 (WebCore::networkStateChanged):
2485 * rendering/RenderListBox.cpp:
2486 (WebCore::RenderListBox::valueChanged):
2487 * rendering/RenderTextControl.cpp:
2488 (WebCore::RenderTextControl::selectionChanged):
2489 * svg/SVGDocumentExtensions.cpp:
2490 * svg/SVGDocumentExtensions.h:
2491 * svg/SVGElement.cpp:
2492 (WebCore::SVGElement::parseMappedAttribute):
2493 (WebCore::SVGElement::finishParsingChildren):
2494 * svg/SVGElement.h:
2495 * svg/SVGSVGElement.cpp:
2496 (WebCore::SVGSVGElement::parseMappedAttribute):
2497 * svg/SVGSVGElement.h:
2498
hyatt@apple.com63739ce2008-09-15 23:44:10 +000024992008-09-15 Dave Hyatt <hyatt@apple.com>
2500
2501 Convert PlatformScrollbarWin to use ScrollbarTheme for hit testing. PlatformScrollbarQt/Gtk still
2502 need to be converted.
2503
2504 Reviewed by Sam Weinig
2505
2506 * platform/ScrollBar.cpp:
2507 (WebCore::Scrollbar::Scrollbar):
2508 (WebCore::Scrollbar::updateThumbPosition):
2509 (WebCore::Scrollbar::updateThumbProportion):
2510 (WebCore::Scrollbar::autoscrollPressedPart):
2511 (WebCore::Scrollbar::startTimerIfNeeded):
2512 * platform/ScrollBar.h:
2513 * platform/ScrollbarTheme.h:
2514 (WebCore::ScrollbarTheme::invalidateParts):
2515 * platform/ScrollbarThemeComposite.cpp:
2516 (WebCore::ScrollbarThemeComposite::hitTest):
2517 (WebCore::ScrollbarThemeComposite::invalidatePart):
2518 (WebCore::ScrollbarThemeComposite::thumbPosition):
2519 (WebCore::ScrollbarThemeComposite::thumbLength):
2520 (WebCore::ScrollbarThemeComposite::trackLength):
2521 * platform/ScrollbarThemeComposite.h:
2522 * platform/win/PlatformScrollBarSafari.cpp:
2523 (WebCore::PlatformScrollbar::PlatformScrollbar):
2524 * platform/win/PlatformScrollBarWin.cpp:
2525 (WebCore::PlatformScrollbar::PlatformScrollbar):
2526
dsmith@webkit.orgaa780ed2008-09-15 23:08:07 +000025272008-09-15 David Smith <catfish.man@gmail.com>
2528
2529 "Just do it"'d by Mark Rowe
2530
2531 https://bugs.webkit.org/show_bug.cgi?id=20856
2532 Add missing license header
2533
2534 * dom/NodeRenderStyle.h:
2535
dino@apple.combf52b682008-09-15 21:31:43 +000025362008-09-15 Dean Jackson <dino@apple.com>
2537
2538 Reviewed by Tim Hatcher.
2539
dino@apple.com3db0b8f2008-09-15 21:52:23 +00002540 Add default constructor for ShadowData
2541 https://bugs.webkit.org/show_bug.cgi?id=20757
2542
2543 Test: transitions/shadow.html
2544
2545 * rendering/style/RenderStyle.h:
2546
25472008-09-15 Dean Jackson <dino@apple.com>
2548
2549 Reviewed by Tim Hatcher.
2550
dino@apple.com03abdce2008-09-15 21:40:52 +00002551 RenderStyle should update keyframes.
2552 http://bugs.webkit.org/show_bug.cgi?id=20756
2553
2554 * rendering/style/RenderStyle.cpp:
2555 (WebCore::StyleRareNonInheritedData::updateKeyframes):
2556
25572008-09-15 Dean Jackson <dino@apple.com>
2558
2559 Reviewed by Tim Hatcher.
2560
dino@apple.combf52b682008-09-15 21:31:43 +00002561 Unnecessary ASSERT in ImplicitAnimation destructor.
2562 https://bugs.webkit.org/show_bug.cgi?id=20817
2563
2564 * page/animation/ImplicitAnimation.cpp:
2565 (WebCore::ImplicitAnimation::~ImplicitAnimation):
2566
treat@webkit.org7e5abc22008-09-15 20:53:49 +000025672008-09-15 Adam Treat <treat@kde.org>
2568
2569 Reviewed by Simon.
2570
2571 Fix plugin extension info. It was returning the mimetype where the
2572 extension was given.
2573
2574 * plugins/qt/PluginPackageQt.cpp:
2575 (WebCore::PluginPackage::fetchInfo):
2576
dino@apple.comecc18dc2008-09-15 20:40:28 +000025772008-09-15 Dean Jackson <dino@apple.com>
2578
2579 Reviewed by Tim Hatcher
2580
2581 Coding style violation!!!! Cleanup AnimationBase.cpp
2582
2583 * page/animation/AnimationBase.cpp:
2584 (WebCore::blendFunc):
2585
hyatt@apple.comf4a9d932008-09-15 20:03:25 +000025862008-09-15 David Hyatt <hyatt@apple.com>
2587
2588 Move all hit testing code for scrollbars into the base class. Refactor
2589 it to accommodate all platform-specific behaviors using virtual ScrollbarTheme
2590 functions.
2591
2592 No platform is using this code yet. Although it has been moved and compiles
2593 (even on Mac), it is not being used on any platform.
2594
2595 Reviewed by Sam Weinig
2596
2597 * platform/ScrollBar.cpp:
2598 (WebCore::Scrollbar::autoscrollPressedPart):
2599 (WebCore::Scrollbar::startTimerIfNeeded):
2600 (WebCore::Scrollbar::handleMouseMoveEvent):
2601 (WebCore::Scrollbar::handleMouseOutEvent):
2602 (WebCore::Scrollbar::handleMouseReleaseEvent):
2603 (WebCore::Scrollbar::handleMousePressEvent):
2604 * platform/ScrollBar.h:
2605 (WebCore::Scrollbar::handleContextMenuEvent):
2606 * platform/ScrollbarTheme.h:
2607 (WebCore::ScrollbarTheme::hitTest):
2608 (WebCore::ScrollbarTheme::invalidateOnMouseEnterExit):
2609 (WebCore::ScrollbarTheme::invalidatePart):
2610 (WebCore::ScrollbarTheme::shouldCenterOnThumb):
2611 (WebCore::ScrollbarTheme::centerOnThumb):
2612 (WebCore::ScrollbarTheme::thumbPosition):
2613 (WebCore::ScrollbarTheme::thumbLength):
2614 (WebCore::ScrollbarTheme::trackLength):
2615 (WebCore::ScrollbarTheme::initialAutoscrollTimerDelay):
2616 (WebCore::ScrollbarTheme::autoscrollTimerDelay):
2617 * platform/Widget.h:
2618 (WebCore::Widget::parent):
2619 * platform/mac/PlatformScrollBar.h:
2620 (WebCore::PlatformScrollbar::handleMouseMoveEvent):
2621 (WebCore::PlatformScrollbar::handleMouseOutEvent):
2622 (WebCore::PlatformScrollbar::handleMousePressEvent):
2623 (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
2624 * platform/mac/WidgetMac.mm:
2625 (WebCore::Widget::convertFromContainingWindow):
2626 * platform/win/ScrollbarThemeWin.cpp:
2627 (WebCore::ScrollbarThemeWin::invalidateOnMouseEnterExit):
2628 * platform/win/ScrollbarThemeWin.h:
2629
mitz@apple.comd17dc392008-09-15 18:48:20 +000026302008-09-15 Dan Bernstein <mitz@apple.com>
2631
2632 Reviewed by Sam Weinig.
2633
2634 - fix <rdar://problem/5842247> Single long breakable word takes O(n^2) to lay out
2635
2636 Cache the next breakable position for text nodes in InlineIterator.
2637
2638 * rendering/bidi.cpp:
2639 (WebCore::InlineIterator::InlineIterator):
2640 (WebCore::InlineIterator::increment):
2641 (WebCore::RenderBlock::findNextLineBreak):
2642
simon.fraser@apple.comda604642008-09-15 17:10:48 +000026432008-09-15 Simon Fraser <simon.fraser@apple.com>
2644
2645 Reviewed by Dan Bernstein
2646
2647 Fix assertion and integral pixel issue when creating subimages.
2648 https://bugs.webkit.org/show_bug.cgi?id=20786
2649
2650 * platform/graphics/cg/ImageCG.cpp:
2651 (WebCore::BitmapImage::draw):
2652
vestbo@webkit.orge7eda302008-09-15 12:43:37 +000026532008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
2654
2655 Reviewed by Simon.
2656
2657 Implment seek() and clean up and improve debugging output
2658
2659 * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
2660 (debugMediaObject):
2661 (WebCore::MediaPlayerPrivate::seek):
2662 (WebCore::MediaPlayerPrivate::setVolume):
2663 (WebCore::MediaPlayerPrivate::setMuted):
2664 (WebCore::MediaPlayerPrivate::updateStates):
2665 (WebCore::MediaPlayerPrivate::naturalSize):
2666 (WebCore::MediaPlayerPrivate::paint):
2667 (WebCore::MediaPlayerPrivate::stateChanged):
2668 (WebCore::MediaPlayerPrivate::tick):
2669
vestbo@webkit.orgaba01e62008-09-15 11:40:22 +000026702008-09-15 Holger Hans Peter Freyther <zecke@selfish.org>
2671
2672 Reviewed by Simon.
2673
2674 Remove bogus Q_ASSERTs from the MediaPlayer Phonon implementation
2675
2676 m_mediaObject, m_audioOutput, m_videoWidget get created in the
2677 c'tor and will only be deleted in the c'tor. The Q_ASSERTs would
2678 only check if we use the MediaPlayerPrivate after it has been deleted.
2679
2680 Acked-by: Tor Arne Vestbø <tavestbo@trolltech.com>
2681
2682 * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
2683 (WebCore::MediaPlayerPrivate::play):
2684 (WebCore::MediaPlayerPrivate::setVolume):
2685 (WebCore::MediaPlayerPrivate::updateStates):
2686
andersca@apple.com18d62682008-09-15 11:35:22 +000026872008-09-15 Anders Carlsson <andersca@apple.com>
2688
2689 Reviewed by Maciej.
2690
2691 <rdar://problem/6163988>
2692 https://bugs.webkit.org/show_bug.cgi?id=20457
2693 Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
2694
2695 Check the width and height and throw an exception if any of them are 0.
2696
2697 * html/CanvasRenderingContext2D.cpp:
2698 (WebCore::CanvasRenderingContext2D::createPattern):
2699
vestbo@webkit.org3a27e182008-09-15 11:28:59 +000027002008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
2701
2702 Reviewed by Simon.
2703
2704 Render media element controls with antialiasing enabled
2705
2706 * platform/qt/RenderThemeQt.cpp:
2707 (WebCore::RenderThemeQt::paintMediaMuteButton):
2708 (WebCore::RenderThemeQt::paintMediaPlayButton):
2709 (WebCore::RenderThemeQt::paintMediaSliderTrack):
2710 (WebCore::RenderThemeQt::paintMediaSliderThumb):
2711
vestbo@webkit.org17e4bfc2008-09-15 11:27:25 +000027122008-09-15 Ariya Hidayat <ariya.hidayat@trolltech.com>
2713
2714 Reviewed by Simon.
2715
2716 Upon non fatal error, switch to the pause state (so that playback can continue)
2717
2718 * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
2719 (WebCore::MediaPlayerPrivate::updateStates):
2720
vestbo@webkit.org12a59572008-09-15 11:16:13 +000027212008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
2722
2723 Reviewed by Simon.
2724
vestbo@webkit.org1d1f05e2008-09-15 11:22:05 +00002725 Don't set WTF_USE_JSC in WebCore.pro now that it's set in config.h
2726
2727 * WebCore.pro:
2728
27292008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
2730
2731 Reviewed by Simon.
2732
vestbo@webkit.org12a59572008-09-15 11:16:13 +00002733 Make QtInstance::create() private and fix caching
2734
2735 * bindings/js/ScriptControllerQt.cpp:
2736 (WebCore::ScriptController::createScriptInstanceForWidget):
2737 * bridge/qt/qt_instance.cpp:
2738 (JSC::Bindings::QtInstance::getQtInstance):
2739 (JSC::Bindings::QtInstance::getRuntimeObject):
2740 * bridge/qt/qt_instance.h:
2741 (JSC::Bindings::QtInstance::create):
2742 * bridge/qt/qt_runtime.cpp:
2743 (JSC::Bindings::convertQVariantToValue):
2744 (JSC::Bindings::QtConnectionObject::execute):
2745
dsmith@webkit.orgaba15862008-09-15 08:45:35 +000027462008-09-15 David Smith <catfish.man@gmail.com>
2747
2748 Reviewed by Dave Hyatt.
2749
2750 https://bugs.webkit.org/show_bug.cgi?id=20180
2751
2752 >2x speedup on querySelector[All] with :nth-child by removing the collectRulesOnly argument on SelectorChecker.
2753 With collectRulesOnly set to true (the default) an optimization is turned off, and no callers were intentionally leaving it true.
2754 querySelector[All] assumed that the default was probably the right way to go, and so ended up being slow.
2755
2756 * css/CSSStyleSelector.cpp:
2757 (WebCore::CSSStyleSelector::CSSStyleSelector):
2758 (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
2759 * css/CSSStyleSelector.h:
2760
hyatt@apple.com065494e2008-09-15 06:33:40 +000027612008-09-14 Dave Hyatt <hyatt@apple.com>
2762
2763 Refactor PlatformScrollbarWin's painting so that it is now done by ScrollbarThemeWin. PlatformScrollbarSafari
2764 is still painting itself (a subsequent patch will move its painting into ScrollbarThemeSafari).
2765
2766 Reviewed by Sam Weinig
2767
2768 * platform/ScrollBar.h:
2769 (WebCore::Scrollbar::client):
2770 (WebCore::Scrollbar::currentPos):
2771 (WebCore::Scrollbar::totalSize):
2772 * platform/ScrollbarTheme.h:
2773 * platform/ScrollbarThemeComposite.cpp:
2774 (WebCore::pageForScrollView):
2775 (WebCore::ScrollbarThemeComposite::paint):
2776 * platform/ScrollbarThemeComposite.h:
2777 (WebCore::ScrollbarThemeComposite::trackIsSinglePiece):
2778 * platform/win/PlatformScrollBar.h:
2779 * platform/win/PlatformScrollBarSafari.cpp:
2780 * platform/win/PlatformScrollBarWin.cpp:
2781 * platform/win/ScrollbarThemeSafari.h:
2782 (WebCore::ScrollbarThemeSafari::hasButtons):
2783 (WebCore::ScrollbarThemeSafari::hasThumb):
2784 (WebCore::ScrollbarThemeSafari::backButtonRect):
2785 (WebCore::ScrollbarThemeSafari::forwardButtonRect):
2786 (WebCore::ScrollbarThemeSafari::trackRect):
2787 (WebCore::ScrollbarThemeSafari::splitTrack):
2788 (WebCore::ScrollbarThemeSafari::paintTrack):
2789 (WebCore::ScrollbarThemeSafari::paintButton):
2790 (WebCore::ScrollbarThemeSafari::paintThumb):
2791 * platform/win/ScrollbarThemeWin.cpp:
2792 (WebCore::isRunningOnVistaOrLater):
2793 (WebCore::checkAndInitScrollbarTheme):
2794 (WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
2795 (WebCore::ScrollbarThemeWin::themeChanged):
2796 (WebCore::ScrollbarThemeWin::hasThumb):
2797 (WebCore::ScrollbarThemeWin::backButtonRect):
2798 (WebCore::ScrollbarThemeWin::forwardButtonRect):
2799 (WebCore::ScrollbarThemeWin::trackRect):
2800 (WebCore::ScrollbarThemeWin::splitTrack):
2801 (WebCore::ScrollbarThemeWin::paintTrack):
2802 (WebCore::ScrollbarThemeWin::paintButton):
2803 (WebCore::gripperRect):
2804 (WebCore::paintGripper):
2805 (WebCore::ScrollbarThemeWin::paintThumb):
2806 (WebCore::ScrollbarThemeWin::thumbPosition):
2807 (WebCore::ScrollbarThemeWin::thumbLength):
2808 (WebCore::ScrollbarThemeWin::trackLength):
2809 * platform/win/ScrollbarThemeWin.h:
2810 (WebCore::ScrollbarThemeWin::hasButtons):
2811 (WebCore::ScrollbarThemeWin::trackIsSinglePiece):
2812
timothy@apple.comd91172c2008-09-15 05:38:00 +000028132008-09-14 Anthony Ricaud <rik24d@gmail.com>
2814
2815 Moving all resource graphs under the same container for future scalable feature.
2816 This is a speedup on resize but maybe a loss on changing the sorting function.
2817
2818 https://bugs.webkit.org/show_bug.cgi?id=20555
2819
2820 Reviewed by Timothy Hatcher.
2821
2822 * page/inspector/ResourcesPanel.js: Added a container for all resource graphs.
2823 Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
2824 * page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.
2825
ap@webkit.orga14074b2008-09-15 04:52:44 +000028262008-09-14 Alexey Proskuryakov <ap@webkit.org>
2827
2828 Reviewed by Maciej Stachowiak.
2829
2830 https://bugs.webkit.org/show_bug.cgi?id=20738
2831 compareBoundaryPoints gives incorrect results
2832
2833 Test: fast/dom/Range/compareBoundaryPoints-2.html
2834
2835 * dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END
2836 and END_TO_START.
2837 * page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.
2838
mjs@apple.com285bdcf2008-09-15 02:55:16 +000028392008-09-14 Maciej Stachowiak <mjs@apple.com>
2840
2841 Unreviewed build fix.
2842
mjs@apple.comcbb31e52008-09-15 03:10:35 +00002843 Trying again.
2844
2845 * bindings/js/JSQuarantinedObjectWrapper.cpp:
2846 (WebCore::JSQuarantinedObjectWrapper::hasInstance):
2847
28482008-09-14 Maciej Stachowiak <mjs@apple.com>
2849
2850 Unreviewed build fix.
2851
mjs@apple.com285bdcf2008-09-15 02:55:16 +00002852 Blind attempt to fix build. Correct parameters for hasInstance.
2853
2854 * bindings/js/JSQuarantinedObjectWrapper.cpp:
2855 (WebCore::JSQuarantinedObjectWrapper::hasInstance):
2856 * bindings/js/JSQuarantinedObjectWrapper.h:
2857
mitz@apple.come85f7362008-09-15 02:23:24 +000028582008-09-14 Dan Bernstein <mitz@apple.com>
2859
2860 Rubber-stamped by Sam Weinig.
2861
2862 - revert <http://trac.webkit.org/changeset/36382> because it exposed
2863 <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes
2864 on Tiger.
2865
2866 * platform/graphics/mac/FontCacheMac.mm:
2867 (WebCore::FontCache::getFontDataForCharacters):
2868 (WebCore::FontCache::getLastResortFallbackFont):
2869
hyatt@apple.comf18feec2008-09-15 00:56:11 +000028702008-09-14 Dave Hyatt <hyatt@apple.com>
2871
2872 Add a new ScrollbarThemeComposite base class that is shared by ScrollbarThemeSafari and
2873 ScrollbarThemeWin. Any scrollbar that wants to render by ScrollbarPart can subclass from this
2874 theme.
2875
2876 Reviewed by Sam Weinig
2877
2878 * WebCore.vcproj/WebCore.vcproj:
2879 * platform/win/ScrollbarThemeSafari.h:
2880 * platform/win/ScrollbarThemeWin.h:
2881
alp@webkit.orgd694e942008-09-15 00:20:15 +000028822008-09-14 Alp Toker <alp@nuanti.com>
2883
2884 https://bugs.webkit.org/show_bug.cgi?id=20320
2885 [GTK] A white rectangle is visible behind widgets with rounded corners
2886
2887 Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
2888 style exempt).
2889
2890 Requested by Michael Monreal.
2891
2892 * platform/gtk/RenderThemeGtk.cpp:
2893 (WebCore::RenderThemeGtk::RenderThemeGtk):
2894 * platform/gtk/gtk2drawing.c:
2895 (moz_gtk_set_widget_name):
2896 (ensure_window_widget):
2897 (setup_widget_prototype):
2898 (ensure_button_arrow_widget):
2899 (moz_gtk_get_combo_box_inner_button):
2900 (moz_gtk_get_combo_box_button_inner_widgets):
2901 (ensure_combo_box_widgets):
2902 (moz_gtk_get_combo_box_entry_inner_widgets):
2903 (moz_gtk_get_combo_box_entry_arrow):
2904 (ensure_combo_box_entry_widgets):
2905 (ensure_toolbar_widget):
2906 (ensure_tooltip_widget):
2907 (ensure_menu_bar_widget):
2908 (ensure_menu_bar_item_widget):
2909 (ensure_menu_popup_widget):
2910 (ensure_menu_item_widget):
2911 (ensure_image_menu_item_widget):
2912 (ensure_menu_separator_widget):
2913 (ensure_check_menu_item_widget):
2914 (ensure_tree_header_cell_widget):
2915 (ensure_scrolled_window_widget):
2916 (moz_gtk_button_paint):
2917 (moz_gtk_init):
2918 (moz_gtk_button_get_inner_border):
2919 (moz_gtk_toggle_paint):
2920 (calculate_button_inner_rect):
2921 (calculate_arrow_rect):
2922 (moz_gtk_scrollbar_button_paint):
2923 (moz_gtk_scrollbar_thumb_paint):
2924 (moz_gtk_caret_paint):
2925 (moz_gtk_entry_paint):
2926 (moz_gtk_treeview_paint):
2927 (moz_gtk_tree_header_cell_paint):
2928 (moz_gtk_combo_box_paint):
2929 (moz_gtk_downarrow_paint):
2930 (moz_gtk_combo_box_entry_button_paint):
2931 (moz_gtk_toolbar_paint):
2932 (moz_gtk_tab_scroll_arrow_paint):
2933 (moz_gtk_menu_bar_paint):
2934 (moz_gtk_menu_item_paint):
2935 (moz_gtk_get_widget_border):
2936 (moz_gtk_get_combo_box_entry_button_size):
2937 (moz_gtk_get_tab_scroll_arrow_size):
2938 (moz_gtk_get_downarrow_size):
2939 (moz_gtk_images_in_menus):
2940 (moz_gtk_widget_paint):
2941 (moz_gtk_shutdown):
2942 * platform/gtk/gtkdrawing.h:
2943
hyatt@apple.com3ab48302008-09-14 23:55:16 +000029442008-09-14 David Hyatt <hyatt@apple.com>
2945
2946 Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
2947 painting. Mac and Gtk themes don't do anything and just let the
2948 underlying widget paint. Qt now uses the theme to paint. wx doesn't
2949 do anything yet.
2950
2951 Reviewed by Sam Weinig
2952
2953 * platform/ScrollBar.cpp:
2954 (WebCore::Scrollbar::paint):
2955 * platform/ScrollBar.h:
2956 (WebCore::Scrollbar::value):
2957 (WebCore::Scrollbar::visibleSize):
2958 (WebCore::Scrollbar::maximum):
2959 (WebCore::Scrollbar::lineStep):
2960 (WebCore::Scrollbar::pageStep):
2961 (WebCore::Scrollbar::pixelStep):
2962 (WebCore::Scrollbar::pressedPart):
2963 (WebCore::Scrollbar::hoveredPart):
2964 (WebCore::Scrollbar::theme):
2965 * platform/ScrollbarTheme.h:
2966 (WebCore::ScrollbarTheme::paint):
2967 (WebCore::ScrollbarTheme::scrollbarThickness):
2968 (WebCore::ScrollbarTheme::supportsControlTints):
2969 (WebCore::ScrollbarTheme::themeChanged):
2970 * platform/gtk/PlatformScrollBar.h:
2971 * platform/gtk/PlatformScrollBarGtk.cpp:
2972 * platform/mac/PlatformScrollBar.h:
2973 * platform/mac/PlatformScrollBarMac.mm:
2974 * platform/qt/PlatformScrollBar.h:
2975 * platform/qt/PlatformScrollBarQt.cpp:
2976 * platform/qt/ScrollbarThemeQt.cpp:
2977 (WebCore::styleOptionSlider):
2978 * platform/qt/ScrollbarThemeQt.h:
2979 (WebCore::ScrollbarThemeQt::paint):
2980 * platform/win/PlatformScrollBarSafari.cpp:
2981 (WebCore::PlatformScrollbar::paint):
2982 * platform/win/ScrollbarThemeSafari.h:
2983 (WebCore::ScrollbarThemeSafari::supportsControlTints):
2984 * platform/wx/PlatformScrollBar.h:
2985 * platform/wx/TemporaryLinkStubs.cpp:
2986 (PlatformScrollbar::~PlatformScrollbar):
2987
weinig@apple.comcb93e262008-09-14 21:36:11 +000029882008-09-14 Sam Weinig <sam@webkit.org>
2989
weinig@apple.com6ef2b872008-09-14 22:15:28 +00002990 Qt build fix.
2991
2992 * platform/qt/PlatformScrollBarQt.cpp:
2993
29942008-09-14 Sam Weinig <sam@webkit.org>
2995
weinig@apple.com064861a2008-09-14 22:12:49 +00002996 Reviewed by Mark Rowe.
2997
2998 Remove extraneous semicolons.
2999
3000 * bindings/scripts/CodeGeneratorObjC.pm:
3001 * html/HTMLLinkElement.cpp:
3002 (WebCore::HTMLLinkElement::tokenizeRelAttribute):
3003 * html/HTMLScriptElement.cpp:
3004 (WebCore::HTMLScriptElement::charsetAttributeValue):
3005 (WebCore::HTMLScriptElement::typeAttributeValue):
3006 * platform/graphics/qt/GradientQt.cpp:
3007 (WebCore::Gradient::platformGradient):
3008 * platform/qt/ScrollViewQt.cpp:
3009 (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
3010 * platform/win/ScrollViewWin.cpp:
3011 (WebCore::ScrollView::updateScrollbars):
3012 * rendering/RenderBlock.cpp:
3013 (WebCore::RenderBlock::paintEllipsisBoxes):
3014 * svg/SVGPathSegList.cpp:
3015 (WebCore::SVGPathSegList::toPathData):
3016
30172008-09-14 Sam Weinig <sam@webkit.org>
3018
weinig@apple.comcb93e262008-09-14 21:36:11 +00003019 Qt build fix.
3020
weinig@apple.com31311a62008-09-14 22:00:15 +00003021 * platform/qt/ScrollViewQt.cpp:
3022 (WebCore::ScrollView::updateScrollbars):
3023
30242008-09-14 Sam Weinig <sam@webkit.org>
3025
3026 Qt build fix.
3027
weinig@apple.comcb93e262008-09-14 21:36:11 +00003028 * platform/qt/PlatformScrollBarQt.cpp:
3029 (WebCore::PlatformScrollbar::PlatformScrollbar):
3030 (WebCore::PlatformScrollbar::paint):
3031
jmalonzo@webkit.org65e836c2008-09-14 01:57:13 +000030322008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>
3033
3034 Gtk build fix, not reviewed.
3035
3036 * platform/gtk/PlatformScrollBarGtk.cpp:
3037 (PlatformScrollbar::PlatformScrollbar):
3038 * platform/gtk/ScrollViewGtk.cpp:
3039 (WebCore::ScrollView::updateScrollbars):
3040
hyatt@apple.comd62f5bf2008-09-14 00:32:19 +000030412008-09-13 Dave Hyatt <hyatt@apple.com>
3042
hyatt@apple.com21ab7c62008-09-14 01:26:22 +00003043 Remove scrollbar's setRect method. Clients can now just call setFrameGeometry (the corresponding Widget) method
3044 to set the dimensions of a scrollbar.
3045
3046 Reviewed by Sam Weinig
3047
3048 * platform/ScrollBar.h:
3049 * platform/gtk/PlatformScrollBar.h:
3050 * platform/gtk/PlatformScrollBarGtk.cpp:
3051 (PlatformScrollbar::setFrameGeometry):
3052 * platform/gtk/ScrollViewGtk.cpp:
3053 (WebCore::ScrollView::updateScrollbars):
3054 * platform/mac/PlatformScrollBarMac.mm:
3055 * platform/qt/PlatformScrollBarQt.cpp:
3056 * platform/qt/ScrollViewQt.cpp:
3057 (WebCore::ScrollView::updateScrollbars):
3058 * platform/win/PlatformScrollBar.h:
3059 * platform/win/PlatformScrollBarSafari.cpp:
3060 (WebCore::PlatformScrollbar::PlatformScrollbar):
3061 (WebCore::PlatformScrollbar::setFrameGeometry):
3062 * platform/win/PlatformScrollBarWin.cpp:
3063 (WebCore::PlatformScrollbar::PlatformScrollbar):
3064 (WebCore::PlatformScrollbar::setFrameGeometry):
3065 * platform/win/PopupMenuWin.cpp:
3066 (WebCore::PopupWndProc):
3067 * platform/win/ScrollViewWin.cpp:
3068 (WebCore::ScrollView::updateScrollbars):
3069 * platform/wx/PlatformScrollBar.h:
3070 * platform/wx/TemporaryLinkStubs.cpp:
3071 (PlatformScrollbar::updateThumbProportion):
3072 * rendering/RenderLayer.cpp:
3073 (WebCore::RenderLayer::positionOverflowControls):
3074 * rendering/RenderListBox.cpp:
3075 (WebCore::RenderListBox::paintScrollbar):
3076
30772008-09-13 Dave Hyatt <hyatt@apple.com>
3078
hyatt@apple.comed9485a2008-09-14 01:06:57 +00003079 Remove setEnabled() from all Scrollbar classes that were just using their Widget base class methods.
3080
3081 Reviewed by Sam Weinig
3082
3083 * platform/ScrollBar.h:
3084 * platform/gtk/PlatformScrollBar.h:
3085 * platform/gtk/PlatformScrollBarGtk.cpp:
3086 * platform/mac/PlatformScrollBar.h:
3087 * platform/mac/PlatformScrollBarMac.mm:
3088 * platform/win/PlatformScrollBar.h:
3089 * platform/win/PlatformScrollBarSafari.cpp:
3090 * platform/win/PlatformScrollBarWin.cpp:
3091 * platform/wx/PlatformScrollBar.h:
3092 * platform/wx/TemporaryLinkStubs.cpp:
3093 (PlatformScrollbar::~PlatformScrollbar):
3094
30952008-09-13 Dave Hyatt <hyatt@apple.com>
3096
hyatt@apple.com64d98032008-09-14 00:58:29 +00003097 Remove width()/height() from Scrollbar now that it derives from Widget. Remove width()/height() from
3098 all PlatformScrollbar subclasses that just called the Widget base class versions of those methods.
3099
3100 Reviewed by Sam Weinig
3101
3102 * platform/ScrollBar.h:
3103 * platform/gtk/PlatformScrollBar.h:
3104 * platform/gtk/PlatformScrollBarGtk.cpp:
3105 * platform/mac/PlatformScrollBar.h:
3106 * platform/mac/PlatformScrollBarMac.mm:
3107 * platform/win/PlatformScrollBarSafari.cpp:
3108 * platform/win/PlatformScrollBarWin.cpp:
3109 * platform/wx/PlatformScrollBar.h:
3110 * platform/wx/TemporaryLinkStubs.cpp:
3111 (PlatformScrollbar::~PlatformScrollbar):
3112
31132008-09-13 Dave Hyatt <hyatt@apple.com>
3114
hyatt@apple.comd62f5bf2008-09-14 00:32:19 +00003115 Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar.
3116
3117 Reviewed by Sam Weinig
3118
3119 * platform/ScrollBar.cpp:
3120 (WebCore::Scrollbar::~Scrollbar):
3121 * platform/ScrollBar.h:
3122 * platform/qt/PlatformScrollBarQt.cpp:
3123 (WebCore::PlatformScrollbar::~PlatformScrollbar):
3124 * platform/win/PlatformScrollBarSafari.cpp:
3125 (WebCore::PlatformScrollbar::~PlatformScrollbar):
3126 * platform/win/PlatformScrollBarWin.cpp:
3127 (WebCore::PlatformScrollbar::~PlatformScrollbar):
3128
hyatt@apple.coma3c52492008-09-13 23:57:08 +000031292008-09-13 David Hyatt <hyatt@apple.com>
3130
3131 Move maximum() from Qt's PlatformScrollbar to be a cross-platform
3132 function on Scrollbar. Fixes Qt build bustage.
3133
3134 Reviewed by Sam Weinig
3135
3136 * platform/ScrollBar.h:
3137 (WebCore::Scrollbar::orientation):
3138 (WebCore::Scrollbar::value):
3139 (WebCore::Scrollbar::maximum):
3140 * platform/qt/PlatformScrollBar.h:
3141
mitz@apple.comb3d22882008-09-13 23:06:59 +000031422008-09-13 Dan Bernstein <mitz@apple.com>
3143
3144 Reviewed by Sam Weinig.
3145
3146 - use the LastResort font for missing glyphs instead of showing the
3147 primary font's missing glyph
3148
3149 Test: platform/mac/fast/text/last-resort-font.html
3150
3151 * platform/graphics/mac/FontCacheMac.mm:
3152 (WebCore::FontCache::getFontDataForCharacters): Changed to return the
3153 last resort font if a substitute font cannot be found.
3154 (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated
3155 comment (the user's preferred standard font is included in the search
3156 thanks to code in FontCache::getFontData()) and changed to return the
3157 LastResort font.
3158
hyatt@apple.com0c378c72008-09-13 22:59:05 +000031592008-09-13 Dave Hyatt <hyatt@apple.com>
3160
3161 This patch adds ScrollbarTheme to the build. ScrollbarTheme is similar to RenderTheme (but for
3162 scrollbars only). For now ScrollbarTheme just handles returning the size of scrollbars. Subsequent
3163 patches will move rendering and hit testing functionality into this class.
3164
3165 Implemented ScrollbarTheme subclasses for four ports (Mac, Win, Gtk, Qt). The wxWidgets port does not
3166 implement scrollbars yet, so I added a temporary link stub to keep things compiling on wx.
3167
3168 Reviewed by Sam Weinig
3169
3170 * GNUmakefile.am:
3171 * WebCore.pro:
3172 * WebCore.vcproj/WebCore.vcproj:
3173 * platform/ScrollBar.cpp:
3174 (WebCore::Scrollbar::Scrollbar):
3175 * platform/ScrollBar.h:
3176 * platform/ScrollbarTheme.h: Added.
3177 (WebCore::ScrollbarTheme::~ScrollbarTheme):
3178 (WebCore::ScrollbarTheme::scrollbarThickness):
3179 (WebCore::ScrollbarTheme::themeChanged):
3180 * platform/gtk/ScrollbarThemeGtk.cpp: Added.
3181 (WebCore::ScrollbarTheme::nativeTheme):
3182 (WebCore::ScrollbarThemeGtk::~ScrollbarThemeGtk):
3183 (WebCore::ScrollbarThemeGtk::scrollbarThickness):
3184 * platform/gtk/ScrollbarThemeGtk.h: Added.
3185 * platform/mac/PlatformScrollBar.h:
3186 * platform/mac/ScrollbarThemeMac.cpp: Added.
3187 (WebCore::ScrollbarTheme::nativeTheme):
3188 (WebCore::):
3189 (WebCore::ScrollbarThemeMac::~ScrollbarThemeMac):
3190 (WebCore::ScrollbarThemeMac::scrollbarThickness):
3191 * platform/mac/ScrollbarThemeMac.h: Added.
3192 * platform/qt/PlatformScrollBarQt.cpp:
3193 * platform/qt/ScrollbarThemeQt.cpp: Added.
3194 (WebCore::ScrollbarTheme::nativeTheme):
3195 (WebCore::ScrollbarThemeQt::~ScrollbarThemeQt):
3196 (WebCore::ScrollbarThemeQt::scrollbarThickness):
3197 * platform/qt/ScrollbarThemeQt.h: Added.
3198 * platform/win/PlatformScrollBar.h:
3199 * platform/win/PlatformScrollBarSafari.cpp:
3200 * platform/win/PlatformScrollBarWin.cpp:
3201 * platform/win/PopupMenuWin.cpp:
3202 (WebCore::PopupMenu::calculatePositionAndSize):
3203 * platform/win/ScrollViewWin.cpp:
3204 (WebCore::ScrollView::updateScrollbars):
3205 (WebCore::ScrollView::themeChanged):
3206 * platform/win/ScrollbarThemeSafari.cpp: Added.
3207 (WebCore::ScrollbarTheme::nativeTheme):
3208 (WebCore::):
3209 (WebCore::ScrollbarThemeSafari::~ScrollbarThemeSafari):
3210 (WebCore::ScrollbarThemeSafari::scrollbarThickness):
3211 * platform/win/ScrollbarThemeSafari.h: Added.
3212 * platform/win/ScrollbarThemeWin.cpp: Added.
3213 (WebCore::ScrollbarTheme::nativeTheme):
3214 (WebCore::ScrollbarThemeWin::~ScrollbarThemeWin):
3215 (WebCore::ScrollbarThemeWin::scrollbarThickness):
3216 (WebCore::ScrollbarThemeWin::themeChanged):
3217 * platform/win/ScrollbarThemeWin.h: Added.
3218 * platform/wx/TemporaryLinkStubs.cpp:
3219 (ScrollbarTheme::nativeTheme):
3220 * rendering/RenderLayer.cpp:
3221 (WebCore::scrollCornerRect):
3222 * rendering/RenderTextControl.cpp:
3223 (WebCore::RenderTextControl::calcHeight):
3224 (WebCore::RenderTextControl::calcPrefWidths):
3225
cfleizach@apple.comd26c2762008-09-13 21:05:18 +000032262008-09-13 Chris Fleizach <cfleizach@apple.com>
3227
3228 Reviewed by Timothy Hatcher.
3229
3230 <rdar://problem/5060439> Web elements should have an AXTopLevelUIElement
3231
3232 * page/mac/AccessibilityObjectWrapper.mm:
3233 (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
3234
mitz@apple.com6307c9f2008-09-13 20:27:37 +000032352008-09-13 Dan Bernstein <mitz@apple.com>
3236
3237 Reviewed by Timothy Hatcher.
3238
3239 - fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache
3240
3241 No regression test because the back/forward cache is disabled in DumpRenderTree
3242
3243 * rendering/RenderContainer.cpp:
3244 (WebCore::RenderContainer::invalidateCounters): Bail out if the document
3245 is being destroyed.
3246
kevino@webkit.org1e178ee2008-09-13 18:48:39 +000032472008-09-13 Kevin Ollivier <kevino@theolliviers.com>
3248
3249 wx build fixes for new methods recently introduced.
3250
3251 * platform/graphics/wx/AffineTransformWx.cpp:
3252 (WebCore::AffineTransform::AffineTransform):
3253 (WebCore::AffineTransform::setMatrix):
3254 (WebCore::AffineTransform::setA):
3255 (WebCore::AffineTransform::setB):
3256 (WebCore::AffineTransform::setC):
3257 (WebCore::AffineTransform::setD):
3258 (WebCore::AffineTransform::setE):
3259 (WebCore::AffineTransform::setF):
3260 * platform/wx/LocalizedStringsWx.cpp:
3261 (WebCore::AXDefinitionListTermText):
3262 (WebCore::AXDefinitionListDefinitionText):
3263
hyatt@apple.com30ed5442008-09-13 18:39:58 +000032642008-09-12 Dave Hyatt <hyatt@apple.com>
3265
3266 Move the member variables of PlatformScrollbar up into Scrollbar. Move autoscroll timer handling
3267 up into scrollbar. Make sure a bunch of cross-platform code now just uses "Scrollbar" instead of
3268 "PlatformScrollbar."
3269
3270 Reviewed by Sam Weinig
3271
3272 * WebCore.vcproj/WebCore.vcproj:
3273 * editing/EditorCommand.cpp:
3274 * page/EventHandler.cpp:
3275 (WebCore::EventHandler::selectCursor):
3276 (WebCore::EventHandler::handleMousePressEvent):
3277 (WebCore::EventHandler::handleMouseMoveEvent):
3278 * page/EventHandler.h:
3279 * page/MouseEventWithHitTestResults.cpp:
3280 (WebCore::MouseEventWithHitTestResults::scrollbar):
3281 * page/MouseEventWithHitTestResults.h:
3282 * page/gtk/EventHandlerGtk.cpp:
3283 (WebCore::EventHandler::passMousePressEventToScrollbar):
3284 * page/mac/EventHandlerMac.mm:
3285 (WebCore::EventHandler::passMousePressEventToScrollbar):
3286 * page/qt/EventHandlerQt.cpp:
3287 (WebCore::EventHandler::passMousePressEventToScrollbar):
3288 * page/win/EventHandlerWin.cpp:
3289 (WebCore::EventHandler::passMousePressEventToScrollbar):
3290 * page/wx/EventHandlerWx.cpp:
3291 (WebCore::EventHandler::passMousePressEventToScrollbar):
3292 * platform/PopupMenu.h:
3293 * platform/ScrollBar.cpp:
3294 (WebCore::Scrollbar::Scrollbar):
3295 (WebCore::Scrollbar::autoscrollTimerFired):
3296 (WebCore::Scrollbar::autoscrollPressedPart):
3297 (WebCore::Scrollbar::startTimerIfNeeded):
3298 (WebCore::Scrollbar::stopTimerIfNeeded):
3299 (WebCore::Scrollbar::pressedPartScrollDirection):
3300 (WebCore::Scrollbar::pressedPartScrollGranularity):
3301 * platform/ScrollBar.h:
3302 (WebCore::Scrollbar::handleMousePressEvent):
3303 (WebCore::Scrollbar::invalidatePart):
3304 (WebCore::Scrollbar::thumbUnderMouse):
3305 * platform/ScrollView.h:
3306 * platform/ScrollbarClient.h: Added.
3307 (WebCore::ScrollbarClient::~ScrollbarClient):
3308 * platform/gtk/ScrollViewGtk.cpp:
3309 (WebCore::ScrollView::scrollbarUnderMouse):
3310 * platform/qt/PlatformScrollBar.h:
3311 * platform/qt/PlatformScrollBarQt.cpp:
3312 (WebCore::PlatformScrollbar::PlatformScrollbar):
3313 (WebCore::scrollbarPart):
3314 (WebCore::PlatformScrollbar::handleMouseMoveEvent):
3315 (WebCore::PlatformScrollbar::handleMouseOutEvent):
3316 (WebCore::PlatformScrollbar::handleMousePressEvent):
3317 (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
3318 * platform/qt/ScrollViewQt.cpp:
3319 (WebCore::ScrollView::scrollbarUnderMouse):
3320 (WebCore::ScrollView::wheelEvent):
3321 * platform/win/PlatformScrollBar.h:
3322 * platform/win/PlatformScrollBarSafari.cpp:
3323 (WebCore::PlatformScrollbar::PlatformScrollbar):
3324 * platform/win/PlatformScrollBarWin.cpp:
3325 (WebCore::PlatformScrollbar::PlatformScrollbar):
3326 * platform/win/ScrollViewWin.cpp:
3327 (WebCore::ScrollView::scrollbarUnderMouse):
3328 * rendering/HitTestResult.cpp:
3329 (WebCore::HitTestResult::setScrollbar):
3330 * rendering/HitTestResult.h:
3331 (WebCore::HitTestResult::scrollbar):
3332 * rendering/RenderLayer.cpp:
3333 (WebCore::RenderLayer::hitTestOverflowControls):
3334 * rendering/RenderLayer.h:
3335 * rendering/RenderListBox.h:
3336
sfalken@apple.comb4e407e2008-09-13 02:59:00 +000033372008-09-12 Steve Falkenburg <sfalken@apple.com>
3338
3339 Fix Mac build.
3340
3341 * css/CSSStyleSelector.cpp:
3342 (WebCore::getTransformOperationType):
3343
dino@apple.comf937dc62008-09-13 00:45:39 +000033442008-09-12 Chris Marrin <cmarrin@apple.com>
3345
3346 Reviewed by Dave Hyatt.
3347
3348 Make transform animation behavior match spec
3349 https://bugs.webkit.org/show_bug.cgi?id=20770
3350
3351 Tests: transitions/transform-op-list-match.html
3352 transitions/transform-op-list-no-match.html
3353
3354 * css/CSSStyleSelector.cpp:
3355 * css/CSSStyleSelector.h:
3356 * page/animation/AnimationBase.cpp:
3357 * page/animation/AnimationBase.h:
3358 * page/animation/ImplicitAnimation.cpp:
3359 * page/animation/ImplicitAnimation.h:
3360 * page/animation/KeyframeAnimation.cpp:
3361 * page/animation/KeyframeAnimation.h:
3362 * rendering/RenderLayer.cpp:
3363 * rendering/style/RenderStyle.cpp:
3364 * rendering/style/RenderStyle.h:
3365
timothy@apple.comab374dd2008-09-12 22:43:38 +000033662008-09-12 Ojan Vafai <ojan@chromium.org>
3367
3368 Properly escape contents of links added to the inspector.
3369 For now, just build the link with the DOM and get the
3370 outerHTML. Eventually, we probably just want to do
3371 this entirely with the DOM.
3372
3373 Reviewed by Timothy Hatcher.
3374
3375 https://bugs.webkit.org/show_bug.cgi?id=20684
3376
3377 * manual-tests/inspector/escape-links.html: Added.
3378 * page/inspector/StylesSidebarPane.js:
3379 * page/inspector/inspector.js:
3380 * page/inspector/utilities.js:
3381
adele@apple.com87fb3c72008-09-12 22:14:13 +000033822008-09-12 Adele Peterson <adele@apple.com>
3383
3384 Reviewed by John Sullivan and Kevin McCullough.
3385
3386 Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames
3387
3388 * page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
3389 Hit testing again on the main frame will only work if we aren't already on the main frame. If we are already on the main frame, that will
3390 cause infinite recursion. This change checks that we're not already on the main frame before hit testing again.
3391
kmccullough@apple.combdba2e32008-09-12 22:08:56 +000033922008-09-12 Kevin McCullough <kmccullough@apple.com>
3393
3394 RS by Tim .
3395
3396 Re-introducing the code since it was not the cause of the crash.
3397 See r36343.
3398
3399 * rendering/RenderObject.cpp:
3400 (WebCore::RenderObject::canBeProgramaticallyScrolled):
3401 * rendering/RenderObject.h:
3402
dino@apple.comf712ed02008-09-12 21:54:57 +000034032008-09-12 Chris Marrin <cmarrin@apple.com>
3404
3405 Reviewed by Dave Hyatt.
3406
3407 When changing one animation in a list, don't reset other animations
3408 https://bugs.webkit.org/show_bug.cgi?id=20675
3409
3410 Test: animations/change-one-anim.html
3411
3412 * page/animation/AnimationBase.cpp:
3413 (WebCore::AnimationBase::getNumProperties):
3414 * page/animation/AnimationBase.h:
3415 * page/animation/AnimationController.cpp:
3416 * page/animation/CompositeAnimation.cpp:
3417 (WebCore::CompositeAnimation::updateKeyframeAnimations):
3418 * page/animation/CompositeAnimation.h:
3419 * page/animation/ImplicitAnimation.cpp:
3420 * page/animation/KeyframeAnimation.cpp:
3421 * page/animation/KeyframeAnimation.h:
3422 (WebCore::KeyframeAnimation::setIndex):
3423
beidson@apple.com521e2b52008-09-12 18:40:03 +000034242008-09-12 Brady Eidson <beidson@apple.com>
3425
3426 Reviewed by Mitz Pettel
3427
3428 Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html
3429
3430 * loader/DocumentLoader.cpp:
3431 (WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior.
3432 Subresources can never be created from nil data, but there is always a MainResource, whether
3433 or not there's any data. So in the case where the main resource has no data, fake it for the
3434 sake of creating the ArchiveResource.
3435
hyatt@apple.com818ffe92008-09-12 18:37:23 +000034362008-09-12 Dave Hyatt <hyatt@apple.com>
3437
3438 Preparation for major scrollbar rearchitecture. Eliminate the concept of non-widget based
3439 scrollbars (which we never supported anyway). Make Scrollbar derive from Widget directly.
3440 Remove all the isWidget and hasPlatformScrollbars guards.
3441
3442 Reviewed by Tim Hatcher
3443
3444 * platform/ScrollBar.h:
3445 * platform/gtk/PlatformScrollBar.h:
3446 * platform/mac/PlatformScrollBar.h:
3447 * platform/qt/PlatformScrollBar.h:
3448 * platform/win/PlatformScrollBar.h:
3449 * platform/win/ScrollViewWin.cpp:
3450 (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
3451 (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
3452 * platform/wx/PlatformScrollBar.h:
3453 * rendering/RenderLayer.cpp:
3454 (WebCore::RenderLayer::horizontalScrollbarWidget):
3455 (WebCore::RenderLayer::verticalScrollbarWidget):
3456 (WebCore::RenderLayer::createScrollbar):
3457 (WebCore::RenderLayer::destroyScrollbar):
3458 * rendering/RenderListBox.cpp:
3459 (WebCore::RenderListBox::~RenderListBox):
3460 (WebCore::RenderListBox::updateFromElement):
3461 (WebCore::RenderListBox::isPointInOverflowControl):
3462
mitz@apple.com0bef1302008-09-12 18:22:07 +000034632008-09-12 Dan Bernstein <mitz@apple.com>
3464
3465 Reviewed by Sam Weinig.
3466
3467 - https://bugs.webkit.org/show_bug.cgi?id=20793 clean up page/animation
3468
3469 * page/animation/AnimationController.cpp:
3470 * page/animation/AnimationController.h:
3471 * page/animation/CompositeAnimation.cpp:
3472 * page/animation/CompositeAnimation.h:
3473 * page/animation/ImplicitAnimation.cpp:
3474 * page/animation/ImplicitAnimation.h:
3475 * page/animation/KeyframeAnimation.cpp:
3476 * page/animation/KeyframeAnimation.h:
3477
timothy@apple.com43203432008-09-12 04:44:40 +000034782008-09-11 Timothy Hatcher <timothy@apple.com>
3479
3480 Add a renderedImage method to DOMNode to get an image
3481 of the rendering for the node and it's descendants.
3482
3483 <rdar://problem/5849349> Would like API to create
3484 an image for a DOM node
3485
3486 Reviewed by Oliver Hunt.
3487
3488 * bindings/objc/DOM.mm:
3489 (-[DOMNode renderedImage]): Call Frame::nodeImage.
3490 * bindings/objc/DOMPrivate.h:
3491 * page/Frame.h:
3492 * page/mac/FrameMac.mm:
3493 (WebCore::Frame::nodeImage):
3494
dino@apple.com9300a0b2008-09-12 00:36:31 +000034952008-09-08 Chris Marrin <cmarrin@apple.com>
3496
3497 Reviewed by Dave Hyatt
3498
3499 Need to support comma separated list of key times in keyframes selectors
3500 https://bugs.webkit.org/show_bug.cgi?id=20680
3501
3502 Test: animations/keyframes-comma-separated.html
3503
3504 * css/CSSGrammar.y:
3505 * css/CSSParser.cpp:
3506 (WebCore::CSSParser::createKeyframeRule):
3507 * css/CSSParser.h:
3508 * css/CSSStyleSelector.cpp:
3509 (WebCore::CSSStyleSelector::addKeyframeStyle):
3510 * css/WebKitCSSKeyframeRule.cpp:
3511 (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
3512 (WebCore::WebKitCSSKeyframeRule::cssText):
3513 (WebCore::WebKitCSSKeyframeRule::parseKeyString):
3514 * css/WebKitCSSKeyframeRule.h:
3515 (WebCore::WebKitCSSKeyframeRule::keyText):
3516 (WebCore::WebKitCSSKeyframeRule::setKeyText):
3517 (WebCore::WebKitCSSKeyframeRule::getKeys):
3518 * css/WebKitCSSKeyframesRule.cpp:
3519 (WebCore::WebKitCSSKeyframesRule::append):
3520 (WebCore::WebKitCSSKeyframesRule::insertRule):
3521 (WebCore::WebKitCSSKeyframesRule::deleteRule):
3522 (WebCore::WebKitCSSKeyframesRule::findRule):
3523 (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
3524 * css/WebKitCSSKeyframesRule.h:
3525 * page/animation/AnimationBase.cpp:
3526 (WebCore::AnimationBase::blendProperties):
3527
kmccullough@apple.com0f9f23a2008-09-11 22:57:09 +000035282008-09-11 Kevin McCullough <kmccullough@apple.com>
3529
3530 RS by Tim.
3531
3532 Reverting because this caused a crash.
3533
3534 * rendering/RenderObject.cpp:
3535 (WebCore::RenderObject::canBeProgramaticallyScrolled):
3536 (WebCore::RenderObject::hasScrollableView):
3537 * rendering/RenderObject.h:
3538
dino@apple.com19853b32008-09-11 21:59:08 +000035392008-09-11 Dean Jackson <dino@apple.com>
3540
3541 Reviewed by Dan Bernstein.
3542
3543 Fix assertion on transition property "none"
3544 https://bugs.webkit.org/show_bug.cgi?id=20751
3545
3546 Test: transitions/transition-end-event-set-none.html
3547
3548 * page/animation/CompositeAnimation.cpp:
3549 (WebCore::CompositeAnimation::updateTransitions):
3550
dsmith@webkit.orge6ea48f2008-09-11 21:41:33 +000035512008-09-11 David Smith <catfish.man@gmail.com>
3552
dsmith@webkit.org08103d92008-09-11 21:54:30 +00003553 Rubber-stamped by mitzpettel.
3554
3555 Remove an accidentally added extra file.
3556
3557 * WebCore: Removed.
3558
35592008-09-11 David Smith <catfish.man@gmail.com>
3560
dsmith@webkit.orge6ea48f2008-09-11 21:41:33 +00003561 Reviewed by Darin
3562
3563 https://bugs.webkit.org/show_bug.cgi?id=20180
3564
3565 This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.
3566
3567 * WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
3568 * css/CSSStyleSelector.cpp: include NodeRenderStyle.h
3569 * dom/Element.cpp: include NodeRenderStyle.h
3570 * dom/Node.cpp: Remove the definition of renderStyle()
3571 (WebCore::Node::nonRendererRenderStyle):
3572 * dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
3573 * dom/NodeRenderStyle.h: Added.
3574 (WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
3575 * html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
3576 * html/HTMLOptGroupElement.h:
3577 (WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
3578 * html/HTMLOptionElement.cpp: include NodeRenderStyle.h
3579 * html/HTMLOptionElement.h:
3580 (WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
3581 * rendering/RenderListBox.cpp: include NodeRenderStyle.h
3582 * rendering/RenderMenuList.cpp: include NodeRenderStyle.h
3583 * svg/SVGUseElement.cpp: include NodeRenderStyle.h
3584
kmccullough@apple.com38d3b0f2008-09-11 17:39:12 +000035852008-09-11 Kevin McCullough <kmccullough@apple.com>
3586
3587 Reviewed by Adele and Tim.
3588
3589 <rdar://problem/6100597> REGRESSION: clicking on search results in Web
3590 Inspector does not scroll to the line of the results (20167)
3591 - This was put in by Max to fix auto scrolling but is not correct for
3592 the whole web: rdar://problem/6213098
3593
3594 * rendering/RenderObject.cpp:
3595 (WebCore::RenderObject::canBeProgramaticallyScrolled):
3596 * rendering/RenderObject.h:
3597
cfleizach@apple.com6a3b1452008-09-11 16:24:09 +000035982008-09-11 Chris Fleizach <cfleizach@apple.com>
3599
3600 Reviewed by Beth Dakin
3601
3602 <rdar://problem/6210511> AX: if a frame has a title, that should be reported as the AXWebArea's title
3603
3604 Test: accessibility/frame-with-title.html
3605
3606 * page/AccessibilityRenderObject.cpp:
3607 (WebCore::AccessibilityRenderObject::accessibilityDescription):
3608
hausmann@webkit.orge8f8ffd2008-09-11 07:34:42 +000036092008-09-11 Dirk Schulze <vbs85@gmx.de>
3610
3611 Reviewed by Simon.
3612
hausmann@webkit.orgea57c432008-09-11 08:03:07 +00003613 Fixed stroke() and strokeRect() to support gradients
3614 and patterns on Qt.
3615
3616 [Qt] Canvas stroke don't work for gradients and patterns
3617 [https://bugs.webkit.org/show_bug.cgi?id=20749]
3618
3619 * platform/graphics/qt/GraphicsContextQt.cpp:
3620 (WebCore::GraphicsContext::strokePath):
3621 (WebCore::GraphicsContext::strokeRect):
3622
36232008-09-11 Dirk Schulze <vbs85@gmx.de>
3624
3625 Reviewed by Simon.
3626
hausmann@webkit.orgc11e3b72008-09-11 07:37:42 +00003627 https://bugs.webkit.org/show_bug.cgi?id=20729
3628
3629 Fixed canvas gradients for Qt
3630
3631 [Qt] Canvas gradients don't work as expected
3632 [https://bugs.webkit.org/show_bug.cgi?id=20729]
3633
3634 * platform/graphics/qt/GradientQt.cpp:
3635 (WebCore::Gradient::platformGradient):
3636
36372008-09-11 Dirk Schulze <vbs85@gmx.de>
3638
3639 Reviewed by Simon.
3640
hausmann@webkit.orge8f8ffd2008-09-11 07:34:42 +00003641 https://bugs.webkit.org/show_bug.cgi?id=20568
3642
3643 Add support for patterns to Qt.
3644
3645 * platform/graphics/qt/PatternQt.cpp:
3646 (WebCore::Pattern::createPlatformPattern):
3647
mitz@apple.com442c5892008-09-10 18:21:14 +000036482008-09-10 Dan Bernstein <mitz@apple.com>
3649
3650 Reviewed by Sam Weinig.
3651
3652 - clean up AnimationBase
3653
3654 * page/animation/AnimationBase.cpp:
3655 * page/animation/AnimationBase.h:
3656 * page/animation/CompositeAnimation.cpp:
3657 * page/animation/ImplicitAnimation.cpp:
3658 * page/animation/ImplicitAnimation.h:
3659 * page/animation/KeyframeAnimation.cpp:
3660 * page/animation/KeyframeAnimation.h:
3661
ap@webkit.orgbaf12872008-09-10 16:42:10 +000036622008-09-10 Alexey Proskuryakov <ap@webkit.org>
3663
3664 Reviewed by Darin Adler.
3665
3666 https://bugs.webkit.org/show_bug.cgi?id=20741
3667 REGRESSION: ISO-8859-8-I encoding is registered incorrectly
3668
3669 Turns out that there were no real behavior changes for 8859-8, as it was only a debug-only
3670 check to ignore this specific registration that was failing. Yet, I decided to add a bunch of
3671 tests for ISO-8859-8 encoding aliases, as we handle them in a quite complicated manner.
3672
3673 I also found and fixed a potential crasher for non-Mac ports.
3674
3675 Tests: fast/encoding/hebrew/8859-8-e.html
3676 fast/encoding/hebrew/8859-8-i.html
3677 fast/encoding/hebrew/8859-8.html
3678 fast/encoding/hebrew/csISO88598I.html
3679 fast/encoding/hebrew/hebrew.html
3680 fast/encoding/hebrew/iso-ir-138.html
3681 fast/encoding/hebrew/logical.html
3682
3683 * platform/text/TextEncodingRegistry.cpp: (WebCore::checkExistingName): Check for iso-8859-8
3684 (case-insensitively, because different versions of ICU report this MIME name in different
3685 case).
3686
3687 * platform/text/TextCodecICU.cpp:
3688 (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated some comments.
3689 (WebCore::TextCodecICU::registerExtendedCodecs): Try both MIME and IANA names here, too.
3690 There are four names in ICU that only have MIME names (x-mac-* ones), so we could end up
3691 with an encoding map entry, but no codec for these. This was not an issue on the Mac, as
3692 we also support these via TEC (which we should stop doing), but on Windows, this would
3693 likely crash.
3694
hyatt@apple.com0197e6b2008-09-10 05:29:46 +000036952008-09-09 Dave Hyatt <hyatt@apple.com
3696
3697 Resurrect PlatformScrollbarWin.
3698
3699 Reviewed by Adam Roben
3700
3701 * WebCore.vcproj/WebCore.vcproj:
3702 * platform/win/PlatformScrollBarWin.cpp:
3703 (WebCore::isRunningOnVistaOrLater):
3704 (WebCore::checkAndInitScrollbarTheme):
3705 (WebCore::PlatformScrollbar::PlatformScrollbar):
3706 (WebCore::PlatformScrollbar::invalidateTrack):
3707 (WebCore::PlatformScrollbar::invalidatePart):
3708 (WebCore::PlatformScrollbar::paint):
3709 (WebCore::PlatformScrollbar::hasButtons):
3710 (WebCore::PlatformScrollbar::hasThumb):
3711 (WebCore::PlatformScrollbar::backButtonRect):
3712 (WebCore::PlatformScrollbar::forwardButtonRect):
3713 (WebCore::PlatformScrollbar::trackRect):
3714 (WebCore::PlatformScrollbar::gripperRect):
3715 (WebCore::PlatformScrollbar::thumbLength):
3716 (WebCore::PlatformScrollbar::paintButton):
3717 (WebCore::PlatformScrollbar::paintTrack):
3718 (WebCore::PlatformScrollbar::paintThumb):
3719 (WebCore::PlatformScrollbar::paintGripper):
3720 (WebCore::PlatformScrollbar::hitTest):
3721 (WebCore::PlatformScrollbar::handleMouseMoveEvent):
3722 (WebCore::PlatformScrollbar::handleMouseOutEvent):
3723 (WebCore::PlatformScrollbar::themeChanged):
3724
cwzwarich@webkit.org8a334572008-09-10 03:22:04 +000037252008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
3726
3727 Reviewed by Maciej Stachowiak.
3728
3729 Bug 20759: Remove MacroAssembler
3730 <https://bugs.webkit.org/show_bug.cgi?id=20759>
3731
3732 Make the necessary changes to ForwardingHeaders to remove
3733 MacroAssembler.
3734
3735 * ForwardingHeaders/masm/IA32MacroAsm.h: Removed.
3736 * ForwardingHeaders/masm/MacroAssembler.h: Removed.
3737 * ForwardingHeaders/masm/X86Assembler.h: Added.
3738
alp@webkit.org509e3d42008-09-10 01:26:20 +000037392008-09-09 Alp Toker <alp@nuanti.com>
3740
3741 Reviewed by Dave Hyatt.
3742
3743 https://bugs.webkit.org/show_bug.cgi?id=16792
3744 [GTK] Fails to render Japanese/Chinese text with simple path
3745
3746 https://bugs.webkit.org/show_bug.cgi?id=16942
3747 [GTK] Oddities in font selection and fall back
3748
3749 https://bugs.webkit.org/show_bug.cgi?id=16862
3750 [GTK] Custom fonts hard-coded to use grayscale antialiasing and no hinting
3751
3752 GTK+ font fixes and enhancements.
3753
3754 Implement font fallback for the simple FontConfig-based text path and
3755 improve the Pango-based complex text path to make use of requested
3756 font properties and available font selection.
3757
3758 Add text shadow support to the complex path.
3759
3760 * platform/graphics/gtk/FontCacheGtk.cpp:
3761 (WebCore::FontCache::getFontDataForCharacters):
3762 (WebCore::FontCache::getSimilarFontPlatformData):
3763 * platform/graphics/gtk/FontGtk.cpp:
3764 (WebCore::setPangoAttributes):
3765 (WebCore::Font::drawComplexText):
3766 (WebCore::getDefaultPangoLayout):
3767 (WebCore::Font::floatWidthForComplexText):
3768 (WebCore::Font::offsetForPositionForComplexText):
3769 (WebCore::Font::selectionRectForComplexText):
3770 * platform/graphics/gtk/FontPlatformData.h:
3771 (WebCore::FontPlatformData::FontPlatformData):
3772 (WebCore::FontPlatformData::hash):
3773 * platform/graphics/gtk/FontPlatformDataGtk.cpp:
3774 (WebCore::FontPlatformData::FontPlatformData):
3775 * platform/graphics/gtk/SimpleFontDataGtk.cpp:
3776 (WebCore::SimpleFontData::platformDestroy):
3777
hyatt@apple.com33f37f62008-09-09 23:51:46 +000037782008-09-09 Dave Hyatt <hyatt@apple.com>
3779
3780 Make the Windows classic case work again. Overlap in slider constants and other constants broke
3781 the push state for buttons and checkboxes. Make sure to check the RenderObject's appearance
3782 value to make sure it's really a slider thumb to resolve this conflict.
3783
3784 Reviewed by Adam Roben
3785
3786 * rendering/RenderThemeWin.cpp:
3787 (WebCore::drawControl):
3788
dino@apple.com442d0652008-09-09 23:36:56 +000037892008-09-05 Chris Marrin <cmarrin@apple.com>
3790
3791 Reviewed by Sam Weinig.
3792
3793 Need to handle the case when 0% or 100% keyframe is omitted
3794 https://bugs.webkit.org/show_bug.cgi?id=20679
3795
3796 Tests: animations/keyframes-from-missing.html
3797 animations/keyframes-to-missing.html
3798
3799 * css/CSSStyleSelector.cpp:
3800 (WebCore::CSSStyleSelector::addKeyframeStyle):
3801
hyatt@apple.com419d0ad2008-09-09 23:11:14 +000038022008-09-09 Dave Hyatt <hyatt@apple.com>
3803
3804 Resurrect Safari's original RenderThemeWin and bring it up to date with ToT. Having a current
3805 RenderThemeWin that does not have any Skia dependencies should provide a good basis for a potential
3806 merge of Google Chrome's RenderThemeWin (to help us see where the Skia stuff can be cut and to see
3807 what changes have been made as compared with the old RenderThemeWin).
3808
3809 Fix CSS2 system fonts to properly set both the rendering mode (so that they properly pick up GDI vs. CG
3810 text rendering modes) and the printer font setting (so that OS X system fonts properly pick up screen
3811 vs. printer advancement rounding).
3812
3813 Reviewed by Adam/Sam
3814
3815 * css/CSSStyleSelector.cpp:
3816 (WebCore::CSSStyleSelector::applyProperty):
3817 * platform/graphics/Icon.h:
3818 (WebCore::Icon::create):
3819 * rendering/RenderThemeWin.cpp:
3820 (WebCore::RenderThemeWin::RenderThemeWin):
3821 (WebCore::RenderThemeWin::~RenderThemeWin):
3822 (WebCore::RenderThemeWin::buttonTheme):
3823 (WebCore::RenderThemeWin::textFieldTheme):
3824 (WebCore::RenderThemeWin::menuListTheme):
3825 (WebCore::RenderThemeWin::sliderTheme):
3826 (WebCore::RenderThemeWin::close):
3827 (WebCore::RenderThemeWin::themeChanged):
3828 (WebCore::RenderThemeWin::supportsHover):
3829 (WebCore::fillFontDescription):
3830 (WebCore::RenderThemeWin::systemFont):
3831 (WebCore::RenderThemeWin::supportsFocus):
3832 (WebCore::RenderThemeWin::determineClassicState):
3833 (WebCore::RenderThemeWin::determineState):
3834 (WebCore::RenderThemeWin::determineSliderThumbState):
3835 (WebCore::RenderThemeWin::getClassicThemeData):
3836 (WebCore::RenderThemeWin::getThemeData):
3837 (WebCore::drawControl):
3838 (WebCore::RenderThemeWin::paintButton):
3839 (WebCore::RenderThemeWin::paintTextField):
3840 (WebCore::RenderThemeWin::paintMenuList):
3841 (WebCore::RenderThemeWin::adjustMenuListStyle):
3842 (WebCore::RenderThemeWin::adjustMenuListButtonStyle):
3843 (WebCore::RenderThemeWin::paintMenuListButton):
3844 (WebCore::RenderThemeWin::paintSliderTrack):
3845 (WebCore::RenderThemeWin::paintSliderThumb):
3846 (WebCore::RenderThemeWin::adjustSliderThumbSize):
3847 (WebCore::RenderThemeWin::paintSearchField):
3848 (WebCore::RenderThemeWin::adjustSearchFieldStyle):
3849 (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
3850 (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
3851 (WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
3852 (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
3853 (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
3854 (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
3855 (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
3856 * rendering/RenderThemeWin.h:
3857 (WebCore::ThemeData::ThemeData):
3858 (WebCore::RenderThemeWin::paintSearchFieldDecoration):
3859 (WebCore::RenderThemeWin::adjustButtonStyle):
3860 (WebCore::RenderThemeWin::adjustTextFieldStyle):
3861 (WebCore::RenderThemeWin::adjustTextAreaStyle):
3862
dino@apple.comd511ce52008-09-09 19:50:25 +000038632008-09-09 Dean Jackson <dino@apple.com>
3864
3865 Reviewed by Sam Weinig.
3866
3867 Document::createEvent missing cases for animation and
3868 transition events.
3869 https://bugs.webkit.org/show_bug.cgi?id=20734
3870
3871 Test: transitions/transition-end-event-create.html
3872 Test: animations/animation-events-create.html
3873
3874 * dom/Document.cpp:
3875 (WebCore::Document::createEvent):
3876 - add the two cases
3877
mitz@apple.com1da7b882008-09-09 18:12:06 +000038782008-09-09 Dan Bernstein <mitz@apple.com>
3879
mitz@apple.com54921562008-09-09 18:48:34 +00003880 - Tiger build fix
3881
3882 * WebCore.Tiger.exp:
3883 * WebCore.base.exp:
3884 * platform/mac/WebCoreSystemInterface.h:
3885 * platform/mac/WebCoreSystemInterface.mm:
3886
38872008-09-09 Dan Bernstein <mitz@apple.com>
3888
mitz@apple.com1da7b882008-09-09 18:12:06 +00003889 Reviewed by Darin Adler.
3890
3891 - WebCore part of <rdar://problem/6206244> Use alternate character-to-glyph interface on Leopard
3892
3893 * WebCore.Tiger.exp:
3894 * WebCore.base.exp:
3895 * platform/graphics/SimpleFontData.h:
3896 * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
3897 (WebCore::GlyphPage::fill):
3898 * platform/graphics/mac/SimpleFontDataMac.mm:
3899 (WebCore::initFontData):
3900 (WebCore::SimpleFontData::platformInit):
3901 (WebCore::SimpleFontData::platformDestroy):
3902 * platform/mac/WebCoreSystemInterface.h:
3903 * platform/mac/WebCoreSystemInterface.mm:
3904
kmccullough@apple.com5ba965b2008-09-09 16:40:31 +000039052008-09-09 Kevin McCullough <kmccullough@apple.com>
3906
3907 Reviewed by Tim.
3908
3909 <rdar://problem/6198545> REGRESSION: Inspector debugger barfs on
3910 breakpoints inside eval.
3911
3912 * page/inspector/inspector.js:
3913
hausmann@webkit.orgdab0e872008-09-09 14:17:21 +000039142008-09-09 Joerg Bornemann <joerg.bornemann@trolltech.com>
3915
3916 Reviewed by Simon.
3917
3918 Fix compilation of the Qt port with disabled plugins on Windows
3919
3920 * WebCore.pro:
3921 * plugins/PluginView.cpp:
3922 (WebCore::PluginView::PluginView):
3923 * plugins/PluginView.h:
3924
ap@webkit.org2ba74d32008-09-09 08:11:01 +000039252008-09-09 Jungshik Shin <jungshik.shin@gmail.com>
3926
3927 Reviewed by Alexey Proskuryakov.
3928
3929 Try MIME charset names before trying IANA names
3930 ( https://bugs.webkit.org/show_bug.cgi?id=17537 )
3931
3932 With this change, shorter and more widely used names (preferred MIME
3933 names) are returned by document.charset, document.characterSet,
3934 document.inputEncoding rather than IANA names. This helps
3935 fixing bug 18085 in addition to web developers who are more familiar
3936 with MIME names. For instance, EUC-JP, ISO-8859-X and US-ASCII will be
3937 returned instead of Extended_UNIX_Code_Packed_Format_for_Japanese,
3938 ISO-8859-X:19xx, and ANSI_X3.4-1968. It also replaces IBM8xx with cp8xx.
3939 Note that cp/IBM 8xx are extremly rare in today's web. Even if they're
3940 used, the former is still recognized as aliases to the latter so that
3941 there's very little, if any, to worry about.
3942
3943 * platform/text/TextCodecICU.cpp:
3944 (WebCore::TextCodecICU::registerExtendedEncodingNames):
3945
weinig@apple.com22294302008-09-09 06:55:39 +000039462008-09-08 Sam Weinig <sam@webkit.org>
3947
3948 Reviewed by Maciej Stachowiak and Oliver Hunt.
3949
3950 Add forwarding headers.
3951
3952 * ForwardingHeaders/wtf/HashFunctions.h: Added.
3953
dino@apple.comd9962af2008-09-09 01:02:00 +000039542008-09-05 Dean Jackson <dino@apple.com>
3955
3956 Reviewed by Dan Bernstein.
3957
3958 Update grammar so that we can add a keyframe rule via the DOM.
3959 https://bugs.webkit.org/show_bug.cgi?id=20613
3960
3961 * css/CSSGrammar.y:
3962 * css/tokenizer.flex:
3963
antti@apple.com4b17a932008-09-09 00:40:45 +000039642008-09-08 Antti Koivisto <antti@apple.com>
3965
3966 Reviewed by Dan Bernstein.
3967
3968 Allow <br> for simple UA stylesheet. Editing code generates them. It does not
3969 actually show up in any of the default stylesheets.
3970
3971 * css/CSSStyleSelector.cpp:
3972 (WebCore::elementCanUseSimpleDefaultStyle):
3973
mitz@apple.com66fa91a2008-09-09 00:35:22 +000039742008-09-08 Dimitri Glazkov <dglazkov@google.com>
3975
3976 Reviewed by Dan Bernstein.
3977
3978 - fix https://bugs.webkit.org/show_bug.cgi?id=20237
3979 Zero width and space characters are displayed incorrectly if not contained in a fallback font
3980
3981 Adds an extra check for Object Replacement Character (U+FFFC) to address
3982 the issue with fast/text/zero-width-characters.html test when run
3983 with Windows system default fonts.
3984
3985 * platform/graphics/Font.h:
3986 (WebCore::Font::treatAsZeroWidthSpace):
3987
dino@apple.comf0a4b212008-09-08 22:51:49 +000039882008-09-08 Dean Jackson <dino@apple.com>
3989
3990 Reviewed by Sam Weinig.
3991
3992 Code style issue I forgot to fix from previous commit.
3993
3994 * platform/graphics/AffineTransform.cpp:
3995 (WebCore::AffineTransform::blend):
3996
dino@apple.com26625122008-09-08 22:46:41 +000039972008-09-08 Chris Marrin <cmarrin@apple.com>
3998
3999 Reviewed by Sam Weinig
4000
4001 - Animation of -webkit-transform matrix() function should not do linear interpolation
4002 https://bugs.webkit.org/show_bug.cgi?id=20667
4003
4004 Test: animations/matrix-anim.html
4005
4006 * ChangeLog:
4007 * platform/graphics/AffineTransform.cpp:
4008 (WebCore::affineTransformDecompose):
4009 (WebCore::affineTransformCompose):
4010 (WebCore::AffineTransform::blend):
4011 * platform/graphics/AffineTransform.h:
4012 * rendering/style/RenderStyle.cpp:
4013 (WebCore::MatrixTransformOperation::blend):
4014
ap@webkit.org243a9752008-09-08 16:21:16 +000040152008-09-08 Alexey Proskuryakov <ap@webkit.org>
4016
4017 Reviewed by Darin Adler.
4018
4019 https://bugs.webkit.org/show_bug.cgi?id=20668
4020 multipart/form-data does not always include Content-type for submitted files
4021
4022 Cannot be tested with DRT or manual tests.
4023
4024 * platform/MIMETypeRegistry.cpp:
4025 (WebCore::initializeSupportedNonImageMimeTypes): Fix spacing.
4026 (WebCore::MIMETypeRegistry::getMIMETypeForPath): Default to application/octet-stream for
4027 unknown extensions, not just missing ones.
4028
hausmann@webkit.orgaf796ea2008-09-08 13:00:19 +000040292008-09-08 Simon Hausmann <hausmann@webkit.org>
4030
4031 Build fix for the Qt/Windows build, define USE_JSC to
4032 enable the WebCore::String -> JSC::UString operator that
4033 MSVC insists on seeing
4034
4035 * WebCore.pro:
4036
andersca@apple.com3ac4f552008-09-08 11:39:34 +000040372008-09-08 Anders Carlsson <andersca@apple.com>
4038
4039 Reviewed by Maciej.
4040
4041 <rdar://problem/5850387> Showing bookmarks reloads Google Reader instead.
4042
4043 In some cases, timeouts scheduled by a page in the onunload handler could fire even when the
4044 page had been unloaded and replaced by a non-HTML representation based view (such as the bookmarks view).
4045
4046 Fix this by clearing timeouts for pages that aren't cached when the provisional load is committed.
4047
4048 * bindings/js/JSDOMWindowBase.h:
4049 * loader/FrameLoader.cpp:
4050 (WebCore::FrameLoader::commitProvisionalLoad):
4051
antti@apple.com57b3a102008-09-08 07:01:36 +000040522008-09-07 Antti Koivisto <antti@apple.com>
4053
4054 Reviewed by Dave Hyatt.
4055
4056 Don't leak the simple stylesheet.
4057 Also call RenderTheme::adjustDefaultStyleSheet() in right place.
4058
4059 * css/CSSStyleSelector.cpp:
4060 (WebCore::loadFullDefaultStyle):
4061 (WebCore::loadSimpleDefaultStyle):
4062 (WebCore::CSSStyleSelector::styleForElement):
4063
cwzwarich@webkit.org3f782f62008-09-08 01:28:33 +000040642008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
4065
cwzwarich@webkit.org951b1452008-09-08 04:25:32 +00004066 Reviewed by Oliver Hunt.
4067
4068 Bug 20711: Change KJS prefix on preprocessor macros to JSC
4069 <https://bugs.webkit.org/show_bug.cgi?id=20711>
4070
4071 * bindings/js/JSEventTargetBase.h:
4072 * bindings/js/JSHTMLInputElementBase.cpp:
4073 * bindings/js/JSHTMLInputElementBase.h:
4074 * bindings/scripts/CodeGeneratorJS.pm:
4075
40762008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
4077
cwzwarich@webkit.org3f782f62008-09-08 01:28:33 +00004078 Reviewed by Maciej Stachowiak.
4079
4080 Bug 20704: Replace the KJS namespace
4081 <https://bugs.webkit.org/show_bug.cgi?id=20704>
4082
4083 Rename the KJS namespace to JSC. There are still some uses of KJS in the
4084 names of JNI functions, and I will check if these are safe to change
4085 as well.
4086
4087 * WebCore.base.exp:
4088 * bindings/js/GCController.cpp:
4089 * bindings/js/JSAttrCustom.cpp:
4090 * bindings/js/JSAudioConstructor.cpp:
4091 * bindings/js/JSAudioConstructor.h:
4092 (WebCore::JSAudioConstructor::classInfo):
4093 * bindings/js/JSCSSRuleCustom.cpp:
4094 * bindings/js/JSCSSStyleDeclarationCustom.cpp:
4095 * bindings/js/JSCSSValueCustom.cpp:
4096 * bindings/js/JSCanvasPixelArrayCustom.cpp:
4097 * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
4098 * bindings/js/JSClipboardCustom.cpp:
4099 * bindings/js/JSConsoleCustom.cpp:
4100 * bindings/js/JSCustomSQLStatementCallback.cpp:
4101 (WebCore::JSCustomSQLStatementCallback::handleEvent):
4102 * bindings/js/JSCustomSQLStatementCallback.h:
4103 (WebCore::JSCustomSQLStatementCallback::create):
4104 * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
4105 (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
4106 * bindings/js/JSCustomSQLStatementErrorCallback.h:
4107 (WebCore::JSCustomSQLStatementErrorCallback::create):
4108 * bindings/js/JSCustomSQLTransactionCallback.cpp:
4109 (WebCore::JSCustomSQLTransactionCallback::handleEvent):
4110 * bindings/js/JSCustomSQLTransactionCallback.h:
4111 (WebCore::JSCustomSQLTransactionCallback::create):
4112 * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
4113 (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
4114 * bindings/js/JSCustomSQLTransactionErrorCallback.h:
4115 (WebCore::JSCustomSQLTransactionErrorCallback::create):
4116 * bindings/js/JSCustomVoidCallback.cpp:
4117 (WebCore::JSCustomVoidCallback::handleEvent):
4118 * bindings/js/JSCustomVoidCallback.h:
4119 (WebCore::JSCustomVoidCallback::create):
4120 * bindings/js/JSCustomXPathNSResolver.cpp:
4121 (WebCore::JSCustomXPathNSResolver::create):
4122 * bindings/js/JSCustomXPathNSResolver.h:
4123 * bindings/js/JSDOMApplicationCacheCustom.cpp:
4124 (WebCore::JSDOMApplicationCache::dispatchEvent):
4125 * bindings/js/JSDOMBinding.cpp:
4126 (WebCore::jsOwnedStringOrNull):
4127 * bindings/js/JSDOMBinding.h:
4128 (WebCore::DOMObject::DOMObject):
4129 (WebCore::cacheDOMObject):
4130 (WebCore::cacheSVGDOMObject):
4131 (WebCore::DOMExceptionTranslator::DOMExceptionTranslator):
4132 (WebCore::toJS):
4133 * bindings/js/JSDOMWindowBase.cpp:
4134 * bindings/js/JSDOMWindowBase.h:
4135 (WebCore::JSDOMWindowBase::classInfo):
4136 (WebCore::JSDOMWindowBase::d):
4137 * bindings/js/JSDOMWindowCustom.cpp:
4138 (WebCore::JSDOMWindow::getPropertyAttributes):
4139 * bindings/js/JSDOMWindowCustom.h:
4140 (WebCore::asJSDOMWindow):
4141 (WebCore::JSDOMWindow::customGetOwnPropertySlot):
4142 (WebCore::JSDOMWindow::customPut):
4143 (WebCore::JSDOMWindowBase::allowsAccessFrom):
4144 (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
4145 * bindings/js/JSDOMWindowShell.cpp:
4146 (WebCore::JSDOMWindowShell::getPropertyAttributes):
4147 * bindings/js/JSDOMWindowShell.h:
4148 (WebCore::JSDOMWindowShell::classInfo):
4149 * bindings/js/JSDatabaseCustom.cpp:
4150 * bindings/js/JSDocumentCustom.cpp:
4151 * bindings/js/JSDocumentFragmentCustom.cpp:
4152 * bindings/js/JSElementCustom.cpp:
4153 * bindings/js/JSEventCustom.cpp:
4154 * bindings/js/JSEventListener.cpp:
4155 * bindings/js/JSEventListener.h:
4156 (WebCore::JSUnprotectedEventListener::create):
4157 (WebCore::JSEventListener::create):
4158 * bindings/js/JSEventTargetBase.cpp:
4159 * bindings/js/JSEventTargetBase.h:
4160 (WebCore::JSEventTargetBase::getValueProperty):
4161 (WebCore::JSEventTargetBase::putValueProperty):
4162 (WebCore::JSEventTargetBase::getOwnPropertySlot):
4163 (WebCore::JSEventTargetBase::put):
4164 (WebCore::JSEventTargetPrototype::JSEventTargetPrototype):
4165 (WebCore::JSEventTargetPrototype::self):
4166 (WebCore::JSEventTargetPrototype::getOwnPropertySlot):
4167 (WebCore::JSEventTargetPrototype::classInfo):
4168 * bindings/js/JSEventTargetNode.cpp:
4169 * bindings/js/JSEventTargetNode.h:
4170 (WebCore::JSEventTargetNode::getOwnPropertySlot):
4171 (WebCore::JSEventTargetNode::getValueProperty):
4172 (WebCore::JSEventTargetNode::put):
4173 (WebCore::JSEventTargetNode::putValueProperty):
4174 * bindings/js/JSHTMLAllCollection.h:
4175 (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
4176 (WebCore::JSHTMLAllCollection::toBoolean):
4177 * bindings/js/JSHTMLAppletElementCustom.cpp:
4178 * bindings/js/JSHTMLCollectionCustom.cpp:
4179 * bindings/js/JSHTMLDocumentCustom.cpp:
4180 * bindings/js/JSHTMLElementCustom.cpp:
4181 * bindings/js/JSHTMLEmbedElementCustom.cpp:
4182 * bindings/js/JSHTMLFormElementCustom.cpp:
4183 * bindings/js/JSHTMLFrameElementCustom.cpp:
4184 * bindings/js/JSHTMLFrameSetElementCustom.cpp:
4185 * bindings/js/JSHTMLIFrameElementCustom.cpp:
4186 * bindings/js/JSHTMLInputElementBase.cpp:
4187 (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
4188 (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
4189 * bindings/js/JSHTMLInputElementBase.h:
4190 (WebCore::JSHTMLInputElementBase::classInfo):
4191 * bindings/js/JSHTMLObjectElementCustom.cpp:
4192 * bindings/js/JSHTMLOptionElementConstructor.cpp:
4193 * bindings/js/JSHTMLOptionElementConstructor.h:
4194 (WebCore::JSHTMLOptionElementConstructor::classInfo):
4195 * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
4196 * bindings/js/JSHTMLSelectElementCustom.cpp:
4197 (WebCore::selectIndexSetter):
4198 (WebCore::JSHTMLSelectElement::indexSetter):
4199 * bindings/js/JSHTMLSelectElementCustom.h:
4200 * bindings/js/JSHistoryCustom.cpp:
4201 * bindings/js/JSImageConstructor.cpp:
4202 * bindings/js/JSImageConstructor.h:
4203 (WebCore::JSImageConstructor::classInfo):
4204 * bindings/js/JSInspectedObjectWrapper.cpp:
4205 * bindings/js/JSInspectedObjectWrapper.h:
4206 (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
4207 (WebCore::JSInspectedObjectWrapper::classInfo):
4208 * bindings/js/JSInspectorCallbackWrapper.cpp:
4209 * bindings/js/JSInspectorCallbackWrapper.h:
4210 (WebCore::JSInspectorCallbackWrapper::classInfo):
4211 (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
4212 * bindings/js/JSJavaScriptCallFrameCustom.cpp:
4213 * bindings/js/JSLocationCustom.cpp:
4214 * bindings/js/JSMimeTypeArrayCustom.cpp:
4215 * bindings/js/JSNSResolver.cpp:
4216 * bindings/js/JSNSResolver.h:
4217 (WebCore::JSNSResolver::create):
4218 * bindings/js/JSNamedNodeMapCustom.cpp:
4219 * bindings/js/JSNamedNodesCollection.cpp:
4220 (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
4221 * bindings/js/JSNamedNodesCollection.h:
4222 (WebCore::JSNamedNodesCollection::classInfo):
4223 * bindings/js/JSNavigatorCustom.cpp:
4224 * bindings/js/JSNodeCustom.cpp:
4225 * bindings/js/JSNodeFilterCondition.cpp:
4226 (WebCore::JSNodeFilterCondition::acceptNode):
4227 * bindings/js/JSNodeFilterCondition.h:
4228 (WebCore::JSNodeFilterCondition::create):
4229 * bindings/js/JSNodeFilterCustom.cpp:
4230 * bindings/js/JSNodeIteratorCustom.cpp:
4231 * bindings/js/JSNodeListCustom.cpp:
4232 * bindings/js/JSPluginArrayCustom.cpp:
4233 * bindings/js/JSPluginCustom.cpp:
4234 * bindings/js/JSPluginElementFunctions.cpp:
4235 (WebCore::getRuntimeObject):
4236 * bindings/js/JSPluginElementFunctions.h:
4237 * bindings/js/JSQuarantinedObjectWrapper.cpp:
4238 (WebCore::JSQuarantinedObjectWrapper::construct):
4239 (WebCore::JSQuarantinedObjectWrapper::call):
4240 * bindings/js/JSQuarantinedObjectWrapper.h:
4241 (WebCore::JSQuarantinedObjectWrapper::unwrappedObject):
4242 (WebCore::JSQuarantinedObjectWrapper::unwrappedGlobalObject):
4243 (WebCore::JSQuarantinedObjectWrapper::className):
4244 * bindings/js/JSRGBColor.cpp:
4245 * bindings/js/JSRGBColor.h:
4246 (WebCore::JSRGBColor::classInfo):
4247 * bindings/js/JSSQLResultSetRowListCustom.cpp:
4248 * bindings/js/JSSQLTransactionCustom.cpp:
4249 * bindings/js/JSSVGLazyEventListener.cpp:
4250 * bindings/js/JSSVGLazyEventListener.h:
4251 * bindings/js/JSSVGLengthCustom.cpp:
4252 * bindings/js/JSSVGMatrixCustom.cpp:
4253 (WebCore::JSSVGMatrix::inverse):
4254 (WebCore::JSSVGMatrix::rotateFromVector):
4255 * bindings/js/JSSVGPathSegCustom.cpp:
4256 * bindings/js/JSSVGPathSegListCustom.cpp:
4257 (WebCore::JSSVGPathSegList::initialize):
4258 (WebCore::JSSVGPathSegList::getItem):
4259 (WebCore::JSSVGPathSegList::insertItemBefore):
4260 (WebCore::JSSVGPathSegList::replaceItem):
4261 (WebCore::JSSVGPathSegList::removeItem):
4262 (WebCore::JSSVGPathSegList::appendItem):
4263 * bindings/js/JSSVGPointListCustom.cpp:
4264 * bindings/js/JSSVGTransformListCustom.cpp:
4265 * bindings/js/JSStorageCustom.cpp:
4266 * bindings/js/JSStyleSheetCustom.cpp:
4267 * bindings/js/JSStyleSheetListCustom.cpp:
4268 * bindings/js/JSTextCustom.cpp:
4269 * bindings/js/JSTreeWalkerCustom.cpp:
4270 * bindings/js/JSXMLHttpRequestConstructor.cpp:
4271 * bindings/js/JSXMLHttpRequestConstructor.h:
4272 (WebCore::JSXMLHttpRequestConstructor::classInfo):
4273 * bindings/js/JSXMLHttpRequestCustom.cpp:
4274 * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
4275 * bindings/js/JSXSLTProcessorConstructor.cpp:
4276 * bindings/js/JSXSLTProcessorConstructor.h:
4277 (WebCore::JSXSLTProcessorConstructor::classInfo):
4278 * bindings/js/JSXSLTProcessorCustom.cpp:
4279 * bindings/js/ScheduledAction.cpp:
4280 * bindings/js/ScheduledAction.h:
4281 * bindings/js/ScriptController.cpp:
4282 (WebCore::ScriptController::attachDebugger):
4283 (WebCore::ScriptController::windowScriptNPObject):
4284 * bindings/js/ScriptController.h:
4285 * bindings/js/ScriptControllerGtk.cpp:
4286 (WebCore::ScriptController::createScriptInstanceForWidget):
4287 * bindings/js/ScriptControllerMac.mm:
4288 (WebCore::ScriptController::createScriptInstanceForWidget):
4289 (WebCore::ScriptController::windowScriptObject):
4290 (WebCore::ScriptController::clearPlatformScriptObjects):
4291 (WebCore::updateRenderingForBindings):
4292 (WebCore::ScriptController::initJavaJSBindings):
4293 * bindings/js/ScriptControllerQt.cpp:
4294 (WebCore::ScriptController::createScriptInstanceForWidget):
4295 * bindings/js/ScriptControllerWin.cpp:
4296 (WebCore::ScriptController::createScriptInstanceForWidget):
4297 * bindings/js/ScriptControllerWx.cpp:
4298 (WebCore::ScriptController::createScriptInstanceForWidget):
4299 * bindings/js/StringSourceProvider.h:
4300 (WebCore::StringSourceProvider::getRange):
4301 * bindings/objc/DOM.mm:
4302 (-[DOMNode JSC::Bindings::]):
4303 * bindings/objc/DOMInternal.h:
4304 * bindings/objc/DOMInternal.mm:
4305 (-[WebScriptObject _initializeScriptDOMNodeImp]):
4306 * bindings/objc/DOMUtility.mm:
4307 (JSC::createDOMWrapper):
4308 (WebCore::createDOMWrapper):
4309 * bindings/objc/WebScriptObject.mm:
4310 (WebCore::createJSWrapper):
4311 (-[WebScriptObject _initWithJSObject:JSC::originRootObject:JSC::Bindings::rootObject:JSC::Bindings::]):
4312 * bindings/objc/WebScriptObjectPrivate.h:
4313 * bindings/scripts/CodeGeneratorJS.pm:
4314 * bridge/NP_jsobject.cpp:
4315 * bridge/NP_jsobject.h:
4316 * bridge/c/c_class.cpp:
4317 * bridge/c/c_class.h:
4318 * bridge/c/c_instance.cpp:
4319 * bridge/c/c_instance.h:
4320 * bridge/c/c_runtime.cpp:
4321 * bridge/c/c_runtime.h:
4322 * bridge/c/c_utility.cpp:
4323 * bridge/c/c_utility.h:
4324 * bridge/jni/jni_class.cpp:
4325 * bridge/jni/jni_class.h:
4326 * bridge/jni/jni_instance.cpp:
4327 * bridge/jni/jni_instance.h:
4328 * bridge/jni/jni_jsobject.h:
4329 * bridge/jni/jni_jsobject.mm:
4330 (JavaJSObject::call):
4331 (JavaJSObject::convertJObjectToValue):
4332 * bridge/jni/jni_objc.mm:
4333 (JSC::Bindings::dispatchJNICall):
4334 * bridge/jni/jni_runtime.cpp:
4335 * bridge/jni/jni_runtime.h:
4336 * bridge/jni/jni_utility.cpp:
4337 * bridge/jni/jni_utility.h:
4338 * bridge/npruntime.cpp:
4339 (_NPN_GetStringIdentifier):
4340 * bridge/objc/WebScriptObject.h:
4341 * bridge/objc/objc_class.h:
4342 * bridge/objc/objc_class.mm:
4343 * bridge/objc/objc_instance.h:
4344 * bridge/objc/objc_instance.mm:
4345 * bridge/objc/objc_runtime.h:
4346 * bridge/objc/objc_runtime.mm:
4347 * bridge/objc/objc_utility.h:
4348 * bridge/objc/objc_utility.mm:
4349 * bridge/qt/qt_class.cpp:
4350 * bridge/qt/qt_class.h:
4351 * bridge/qt/qt_instance.cpp:
4352 * bridge/qt/qt_instance.h:
4353 * bridge/qt/qt_runtime.cpp:
4354 (JSC::Bindings::convertQVariantToValue):
4355 (JSC::Bindings::):
4356 * bridge/qt/qt_runtime.h:
4357 * bridge/runtime.cpp:
4358 * bridge/runtime.h:
4359 * bridge/runtime_array.cpp:
4360 * bridge/runtime_array.h:
4361 * bridge/runtime_method.cpp:
4362 * bridge/runtime_method.h:
4363 * bridge/runtime_object.cpp:
4364 * bridge/runtime_object.h:
4365 * bridge/runtime_root.cpp:
4366 (JSC::Bindings::RootObject::invalidate):
4367 (JSC::Bindings::RootObject::gcProtect):
4368 (JSC::Bindings::RootObject::gcUnprotect):
4369 * bridge/runtime_root.h:
4370 * bridge/testbindings.cpp:
4371 * bridge/testbindings.mm:
4372 * bridge/testqtbindings.cpp:
4373 * dom/Document.cpp:
4374 (WebCore::Document::~Document):
4375 * dom/NSResolver.h:
4376 * dom/Node.cpp:
4377 (WebCore::Node::setDocument):
4378 (WebCore::ResolveNamespaceFunctor::ResolveNamespaceFunctor):
4379 (WebCore::resolveNamespacesForSelector):
4380 (WebCore::Node::querySelector):
4381 (WebCore::Node::querySelectorAll):
4382 * dom/Node.h:
4383 * dom/NodeFilter.cpp:
4384 * dom/NodeFilter.h:
4385 * dom/NodeFilterCondition.cpp:
4386 * dom/NodeFilterCondition.h:
4387 * dom/NodeIterator.cpp:
4388 * dom/NodeIterator.h:
4389 * dom/Traversal.cpp:
4390 * dom/Traversal.h:
4391 * dom/TreeWalker.cpp:
4392 * dom/TreeWalker.h:
4393 * dom/make_names.pl:
4394 * history/CachedPage.cpp:
4395 * history/CachedPage.h:
4396 * html/HTMLPlugInElement.cpp:
4397 (WebCore::HTMLPlugInElement::getInstance):
4398 * html/HTMLPlugInElement.h:
4399 * loader/FrameLoader.cpp:
4400 * loader/FrameLoader.h:
4401 * loader/icon/IconDatabase.cpp:
4402 (WebCore::iconDatabase):
4403 * page/Console.cpp:
4404 * page/Console.h:
4405 * page/InspectorController.cpp:
4406 (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
4407 (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
4408 (WebCore::InspectorResource::setXMLHttpRequestProperties):
4409 (WebCore::InspectorResource::sourceString):
4410 (WebCore::getResourceDocumentNode):
4411 (WebCore::search):
4412 (WebCore::InspectorController::focusNode):
4413 (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
4414 (WebCore::InspectorController::addDatabaseScriptResource):
4415 (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
4416 * page/InspectorController.h:
4417 (WebCore::InspectorController::profiles):
4418 * page/JavaScriptCallFrame.cpp:
4419 (WebCore::JavaScriptCallFrame::scopeChain):
4420 * page/JavaScriptCallFrame.h:
4421 (WebCore::JavaScriptCallFrame::create):
4422 (WebCore::JavaScriptCallFrame::update):
4423 * page/JavaScriptDebugListener.h:
4424 * page/JavaScriptDebugServer.cpp:
4425 (WebCore::dispatchDidParseSource):
4426 * page/JavaScriptDebugServer.h:
4427 * page/JavaScriptProfile.cpp:
4428 * page/JavaScriptProfile.h:
4429 * page/JavaScriptProfileNode.cpp:
4430 (WebCore::getTotalTime):
4431 (WebCore::getSelfTime):
4432 (WebCore::getTotalPercent):
4433 (WebCore::getSelfPercent):
4434 (WebCore::getNumberOfCalls):
4435 (WebCore::getChildren):
4436 (WebCore::getVisible):
4437 * page/JavaScriptProfileNode.h:
4438 * page/Page.cpp:
4439 (WebCore::Page::setDebuggerForAllPages):
4440 (WebCore::Page::setDebugger):
4441 * page/Page.h:
4442 (WebCore::Page::debugger):
4443 * page/mac/FrameMac.mm:
4444 * platform/KURL.h:
4445 (WebCore::KURL::operator JSC::UString):
4446 * platform/text/AtomicString.cpp:
4447 (WebCore::AtomicString::add):
4448 (WebCore::AtomicString::find):
4449 * platform/text/AtomicString.h:
4450 (WebCore::AtomicString::AtomicString):
4451 * platform/text/PlatformString.h:
4452 * platform/text/String.cpp:
4453 (WebCore::charactersToDouble):
4454 * platform/win/BString.cpp:
4455 * platform/win/BString.h:
4456 * plugins/MimeTypeArray.h:
4457 * plugins/Plugin.h:
4458 * plugins/PluginArray.h:
4459 * plugins/PluginView.cpp:
4460 (WebCore::PluginView::start):
4461 (WebCore::PluginView::performRequest):
4462 (WebCore::PluginView::bindingInstance):
4463 * plugins/PluginView.h:
4464 * plugins/gtk/PluginViewGtk.cpp:
4465 (WebCore::PluginView::paint):
4466 (WebCore::PluginView::handleKeyboardEvent):
4467 (WebCore::PluginView::handleMouseEvent):
4468 (WebCore::PluginView::setNPWindowRect):
4469 (WebCore::PluginView::stop):
4470 (WebCore::PluginView::init):
4471 * plugins/qt/PluginViewQt.cpp:
4472 (WebCore::PluginView::setNPWindowRect):
4473 (WebCore::PluginView::stop):
4474 (WebCore::PluginView::init):
4475 * plugins/win/PluginViewWin.cpp:
4476 (WebCore::PluginView::dispatchNPEvent):
4477 (WebCore::PluginView::handleKeyboardEvent):
4478 (WebCore::PluginView::handleMouseEvent):
4479 (WebCore::PluginView::setNPWindowRect):
4480 (WebCore::PluginView::stop):
4481 * storage/Database.cpp:
4482 (WebCore::Database::Database):
4483 * xml/XMLHttpRequest.cpp:
4484 (WebCore::XMLHttpRequest::responseText):
4485 (WebCore::XMLHttpRequest::loadRequestAsynchronously):
4486 (WebCore::XMLHttpRequest::clearResponse):
4487 (WebCore::XMLHttpRequest::dropProtection):
4488 (WebCore::XMLHttpRequest::didFinishLoading):
4489 (WebCore::XMLHttpRequest::didReceiveData):
4490 * xml/XMLHttpRequest.h:
4491
abarth@webkit.orge17b6052008-09-08 00:03:30 +000044922008-09-07 Adam Barth <abarth@webkit.org>
4493
4494 Reviewed by Sam Weinig.
4495
4496 Adopt opener restriction on frame navigation.
4497 https://bugs.webkit.org/show_bug.cgi?id=20642
4498
4499 This restriction helps prevent an attacker from navigating top-level
4500 windows that were created by another web site.
4501
4502 Tests: http/tests/security/frameNavigation/not-opener.html
4503 http/tests/security/frameNavigation/opener.html
4504
4505 * loader/FrameLoader.cpp:
4506 (WebCore::canAccessAncestor):
4507 (WebCore::FrameLoader::shouldAllowNavigation):
4508
mitz@apple.com83469af2008-09-07 22:29:56 +000045092008-09-07 Dan Bernstein <mitz@apple.com>
4510
mitz@apple.com08ff58c2008-09-07 23:19:11 +00004511 Reviewed by Maciej Stachowiak.
4512
4513 - use the correct sign for vertical offsets of combining marks
4514
4515 * platform/graphics/win/UniscribeController.cpp:
4516 (WebCore::UniscribeController::shapeAndPlaceItem):
4517
45182008-09-07 Dan Bernstein <mitz@apple.com>
4519
mitz@apple.com83469af2008-09-07 22:29:56 +00004520 Reviewed by Dave Hyatt.
4521
mitz@apple.com78685b22008-09-07 22:30:29 +00004522 - add the combining mark offsets in two places where I forgot them
4523
4524 * platform/graphics/win/FontCGWin.cpp:
4525 (WebCore::Font::drawGlyphs):
4526
45272008-09-07 Dan Bernstein <mitz@apple.com>
4528
4529 Reviewed by Dave Hyatt.
4530
mitz@apple.com83469af2008-09-07 22:29:56 +00004531 - correct glyph advances in complex text using web fonts rendered with
4532 Core Graphics
4533
4534 * platform/graphics/win/FontCustomPlatformData.cpp:
4535 (WebCore::FontCustomPlatformData::fontPlatformData):
4536
timothy@apple.com968ebc92008-09-07 16:48:41 +000045372008-09-07 Keishi Hattori <casey.hattori@gmail.com>
4538
4539 Adds console.dirxml support to the Web Inspector.
4540
4541 https://bugs.webkit.org/show_bug.cgi?id=19156
4542
4543 Reviewed by Timothy Hatcher.
4544
4545 * WebCore.vcproj/WebCore.vcproj: Added ElementsTreeOutline.js.
4546 * bindings/js/JSConsoleCustom.cpp:
4547 (WebCore::JSConsole::dirxml):
4548 * page/Console.cpp:
4549 (WebCore::Console::dirxml): Adds a ConsoleMessage with NodeMessageLevel.
4550 * page/Console.h:
4551 (WebCore::): Added NodeMessageLevel.
4552 * page/Console.idl: Added console.dirxml.
4553 * page/inspector/Console.js: A NodeMessage creates a ElementsTreeOutline.
4554 * page/inspector/ElementsPanel.js: Modified to use ElementsTreeOutline. The ElementsTreeOutline
4555 in the ElementsPanel has includeRootDOMNode and selectEnabled set to true.
4556 * page/inspector/ElementsTreeOutline.js: Added.
4557 (WebInspector.ElementsTreeOutline): A subclass of TreeOutline for displaying a DOM node tree.
4558 (WebInspector.ElementsTreeElement): A subclass of TreeElement for ElementsTreeOutline.
4559 * page/inspector/WebKit.qrc: Added ElementsTreeOutline.js.
4560 * page/inspector/inspector.css:
4561 * page/inspector/inspector.html: Added ElementsTreeOutline.js.
4562 * page/inspector/inspector.js: Moved hover related methods to WebInspector.
4563 (WebInspector.altKeyDown):
4564 (WebInspector.forceHoverHighlight):
4565 (WebInspector.hoveredDOMNode):
4566 (WebInspector._updateHoverHighlightSoon):
4567 (WebInspector._updateHoverHighlight):
4568 (WebInspector.documentKeyDown): Updates WebInspector.altKeyDown
4569 (WebInspector.documentKeyUp): Updates WebInspector.altKeyDown
4570 * page/inspector/utilities.js: Added getDocumentForNode, parentNodeOrFrameElement,
4571 isAncestorIncludingParentFrames.
4572
mrowe@apple.com61ba5f52008-09-07 06:08:56 +000045732008-09-06 Mark Rowe <mrowe@apple.com>
4574
4575 Qt build fix.
4576
4577 * bridge/qt/qt_runtime.cpp:
4578 (KJS::Bindings::convertQVariantToValue):
4579
mrowe@apple.comf88a4632008-09-07 05:44:58 +00004580=== End merge of squirrelfish-extreme ===
4581
45822008-09-05 Oliver Hunt <oliver@apple.com>
4583
4584 Start bringing up SFX on windows.
4585
4586 Reviewed by Mark Rowe and Sam Weinig
4587
4588 Start doing the work to bring up SFX on windows. Initially
4589 just working on WREC, as it does not make any calls so reduces
4590 the amount of code that needs to be corrected.
4591
4592 Add forwarding headers
4593
4594 * ChangeLog:
4595 * ForwardingHeaders/masm/MacroAssembler.h: Added.
4596 * WebCore.vcproj/WebCore.vcproj:
4597
45982008-08-27 Mark Rowe <mrowe@apple.com>
4599
4600 Reviewed by Oliver Hunt.
4601
4602 Fix the build of the full WebKit stack.
4603
4604 Add forwarding headers.
4605
4606 * ForwardingHeaders/masm/IA32MacroAsm.h: Added.
4607 * ForwardingHeaders/wrec/WREC.h: Added.
4608
4609=== Start merge of squirrelfish-extreme ===
4610
antti@apple.com13c24932008-09-07 03:54:21 +000046112008-09-06 Antti Koivisto <antti@apple.com>
4612
4613 Reviewed by Dave Hyatt.
4614
4615 <rdar://problem/6187043>
4616 Don't parse full HTML user agent style sheet unless it is actually needed
4617 <rdar://problem/6131889>
4618 WebView is significantly more expensive to create recently
4619
4620 Parsing the html4.css takes significant amount of time and memory (~50kb) on application
4621 startup. Some clients may never use most of the rules.
4622
4623 With this patch we use simplified UA stylesheet until we hit something it can't handle.
4624 This avoids full stylesheet parsing on application startup (due to empty document construction)
4625 and also makes it possible for clients with very simple demands (divs and spans only) never to load
4626 the full style.
4627
4628 It also delays view source style parsing until it is used.
4629
4630 * css/CSSStyleSelector.cpp:
4631 (WebCore::elementCanUseSimpleDefaultStyle):
4632 (WebCore::CSSStyleSelector::CSSStyleSelector):
4633 (WebCore::loadFullDefaultStyle):
4634 (WebCore::loadSimpleDefaultStyle):
4635 (WebCore::loadViewSourceStyle):
4636 (WebCore::CSSStyleSelector::matchUARules):
4637 (WebCore::CSSStyleSelector::styleForElement):
4638
kevino@webkit.orgd15b50f2008-09-07 03:46:50 +000046392008-09-06 Kevin Ollivier <kevino@theolliviers.com>
4640
4641 wx build fix.
4642
4643 * WebCoreSources.bkl:
4644
antti@apple.come953f862008-09-06 23:27:09 +000046452008-09-06 Antti Koivisto <antti@apple.com>
4646
antti@apple.com00dfa532008-09-06 23:32:26 +00004647 Reverting r35953 which was causing problems on Windows which relies on
4648 WebCore timers in nested event loops. r36132 did alternative fix.
4649
4650 * page/Chrome.cpp:
4651 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
4652 (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
4653
46542008-09-06 Antti Koivisto <antti@apple.com>
4655
antti@apple.come953f862008-09-06 23:27:09 +00004656 Reviewed by Dan Bernstein.
4657
4658 Fix <rdar://problem/6201644>
4659 https://bugs.webkit.org/show_bug.cgi?id=20493
4660 Crash after OK in dialog box and reloading page in secure mode
4661
4662 Limited loader only fix since the general timer fix is causing problems on Windows.
4663
4664 * loader/loader.cpp:
4665 (WebCore::Loader::servePendingRequests):
4666 (WebCore::Loader::Host::Host):
4667 (WebCore::Loader::Host::didFinishLoading):
4668 (WebCore::Loader::Host::didFail):
4669 (WebCore::Loader::Host::didReceiveData):
4670 * loader/loader.h:
4671 (WebCore::Loader::Host::processingResource):
4672
mitz@apple.com046bf642008-09-06 08:31:02 +000046732008-09-06 Dan Bernstein <mitz@apple.com>
4674
4675 Reviewed by Dave Hyatt.
4676
mitz@apple.comc0b050b2008-09-06 22:39:34 +00004677 The initial Core Text adoption prototype was made by Daniel Fenwick.
4678
4679 - <rdar://problem/5158514> Add a Core Text-based complex text code path
4680
4681 Currently the Core Text code path is not used in any configuration.
4682
4683 * WebCore.xcodeproj/project.pbxproj: Added files.
4684 * config.h: Defined WTF_USE_ATSUI and WTF_USE_CORE_TEXT.
4685 * platform/graphics/Font.cpp:
4686 (WebCore::WidthIterator::advance): Moved the spacingDisabled() test out
4687 of the loop.
4688 * platform/graphics/GlyphBuffer.h:
4689 (WebCore::GlyphBuffer::add): Added this version that takes an advance.
4690 * platform/graphics/SimpleFontData.h: Added ATSUI and CORE_TEXT #ifdefs.
4691 Added getCTFont() and getCFStringAttributes() and corresponding data
4692 members for Core Text.
4693 * platform/graphics/mac/CoreTextController.cpp: Added.
4694 (WebCore::roundCGFloat): Helper function.
4695 (WebCore::ceilCGFloat): Helper function.
4696 (WebCore::CoreTextController::CoreTextRun::CoreTextRun):
4697 (WebCore::CoreTextController::CoreTextController):
4698 (WebCore::CoreTextController::offsetForPosition):
4699 (WebCore::CoreTextController::collectCoreTextRuns): Added. Segments the
4700 run into subruns as necessary such that each subrun can be rendered with
4701 a single font. Also separates out soft hyphens and replaces them with
4702 real hyphens, because Core Text does not emit a glyph for soft hyphens.
4703 Then calls collectCoreTextRunsForCharacters() on each subrun.
4704 (WebCore::CoreTextController::advance):
4705 (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Creates
4706 a CTLine from the given subrun and collects its CoreTextRuns.
4707 (WebCore::CoreTextController::adjustGlyphsAndAdvances): Applies the
4708 rounding hacks, letter- and word-spacing and glyph substitutions and
4709 stores the resulting adjusted glyphs and advances.
4710 * platform/graphics/mac/CoreTextController.h: Copied from WebCore/platform/graphics/win/UniscribeController.h.
4711 (WebCore::CoreTextController::totalWidth):
4712 (WebCore::CoreTextController::finalRoundingWidth):
4713 (WebCore::CoreTextController::CoreTextRun::ctRun):
4714 (WebCore::CoreTextController::CoreTextRun::glyphCount):
4715 (WebCore::CoreTextController::CoreTextRun::fontData):
4716 (WebCore::CoreTextController::CoreTextRun::characters):
4717 (WebCore::CoreTextController::CoreTextRun::stringLocation):
4718 (WebCore::CoreTextController::CoreTextRun::stringLength):
4719 (WebCore::CoreTextController::CoreTextRun::indexAt):
4720 * platform/graphics/mac/FontMac.mm: Moved the ATSUI-specific parts to
4721 FontMacATSUI.mm.
4722 * platform/graphics/mac/FontMacATSUI.mm: Copied from WebCore/platform/graphics/mac/FontMac.mm.
4723 (WebCore::disableLigatures): Changed to call
4724 FontPlatformData::allowsLigatures().
4725 (WebCore::overrideLayoutOperation): Changed to call
4726 FontPlatformData::roundsGlyphAdvances().
4727 * platform/graphics/mac/FontMacCoreText.cpp: Copied from WebCore/platform/graphics/win/FontWin.cpp.
4728 (WebCore::Font::selectionRectForComplexText): Changed to use
4729 totalWidth() instead of advancing to the end and using runWidthSoFar().
4730 (WebCore::Font::drawComplexText):
4731 (WebCore::Font::floatWidthForComplexText): Ditto.
4732 (WebCore::Font::offsetForPositionForComplexText):
4733 * platform/graphics/mac/FontPlatformData.h:
4734 * platform/graphics/mac/FontPlatformDataMac.mm:
4735 (WebCore::FontPlatformData::setFont):
4736 (WebCore::FontPlatformData::roundsGlyphAdvances): Added. Checks the
4737 AppKit rendering mode.
4738 (WebCore::FontPlatformData::allowsLigatures): Added. Implements the
4739 heuristic that allows ligatures in fonts that do not have a glyph for
4740 'a', based on the assumption that such fonts are only used in complex
4741 text.
4742 * platform/graphics/mac/SimpleFontDataMac.mm:
4743 (WebCore::SimpleFontData::platformInit):
4744 (WebCore::SimpleFontData::platformDestroy):
4745 (WebCore::SimpleFontData::getCTFont): Added.
4746 (WebCore::SimpleFontData::getCFStringAttributes): Added. Caches and
4747 returns an attributes dictionary.
4748 * platform/text/mac/ShapeArabic.c: Added ATSUI #ifdefs.
4749 * platform/text/mac/ShapeArabic.h: Ditto.
4750
47512008-09-06 Dan Bernstein <mitz@apple.com>
4752
4753 Reviewed by Dave Hyatt.
4754
mitz@apple.com046bf642008-09-06 08:31:02 +00004755 - make combining mark offsets work in CG text on Windows
4756
4757 * platform/graphics/win/FontCGWin.cpp:
4758 (WebCore::Font::drawGlyphs): The old code tried to translate the text
4759 matrix, but failed for two reasons: it did not actually change the
4760 matrix, and even if it did, CGContextSetTextPosition overwrites the
4761 translation values in the text matrix. Instead, just added the
4762 translation to the anchor point.
4763
alp@webkit.org369cdca2008-09-06 04:08:30 +000047642008-09-05 Gustavo Noronha Silva <gns@gnome.org>
4765
4766 Reviewed by Alp Toker.
4767
4768 https://bugs.webkit.org/show_bug.cgi?id=18346
4769 [GTK] Remove build warnings
4770
4771 Applied some casts, and removed an unused typedef to make the
4772 compiler happy, printing less warnings when building.
4773
4774 * page/gtk/AccessibilityObjectWrapperAtk.cpp:
4775 * platform/graphics/gtk/SimpleFontDataPango.cpp:
4776 (WebCore::SimpleFontData::containsCharacters):
4777 * platform/graphics/gtk/VideoSinkGStreamer.cpp:
4778 (webkit_video_sink_set_caps):
4779 * platform/network/soup/ResourceHandleSoup.cpp:
4780
eric@webkit.org3cb292c2008-09-05 22:17:56 +000047812008-09-05 Eric Seidel <eric@webkit.org>
4782
eric@webkit.org5ac37902008-09-06 00:21:58 +00004783 Reviewed by Adam Roben.
4784
4785 Build fix for WebKitWin and Chromium
4786
4787 * platform/FileSystem.h:
4788
47892008-09-05 Eric Seidel <eric@webkit.org>
4790
eric@webkit.org3cb292c2008-09-05 22:17:56 +00004791 Reviewed by Darin Adler.
4792
4793 Try to make Chromium compile with ToT:
4794 - Wrap a few places which depend on KJS:: in #if USE(JSC)
4795 - Include some windows forward declarations
4796
4797 * dom/Node.h:
4798 * page/Console.h:
4799 * page/animation/CompositeAnimation.h:
4800 * platform/FileSystem.h:
4801 * platform/graphics/Image.h:
4802 * platform/text/AtomicString.h:
4803 * platform/text/String.cpp:
4804 * rendering/style/RenderStyle.h:
4805
hyatt@apple.comff85d5e2008-09-05 21:52:08 +000048062008-09-05 Dave Hyatt <hyatt@apple.com>
4807
4808 Add support for runtime switchability of the Aqua look and the native look on Windows.
4809 Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set.
4810
4811 Reviewed by Adam Roben
4812
4813 * WebCore.vcproj/WebCore.vcproj:
4814 * page/Settings.cpp:
4815 (WebCore::Settings::setShouldPaintNativeControls):
4816 * page/Settings.h:
4817 (WebCore::Settings::shouldPaintNativeControls):
4818 * rendering/RenderThemeSafari.cpp:
4819 (WebCore::theme):
4820 * rendering/RenderThemeWin.cpp:
4821
antti@apple.combced97f2008-09-05 18:52:05 +000048222008-09-05 Antti Koivisto <antti@apple.com>
4823
4824 Qt build fix.
4825
4826 * svg/SVGFEImageElement.cpp:
4827 (WebCore::SVGFEImageElement::build):
4828
aroben@apple.comca0c3362008-09-05 15:33:28 +000048292008-09-05 Dirk Schulze <vbs85@gmx.de>
4830
4831 Gtk build fix
4832
4833 * GNUmakefile.am:
4834
antti@apple.com72e4a842008-09-05 09:28:11 +000048352008-09-05 Antti Koivisto <antti@apple.com>
4836
antti@apple.com49e46662008-09-05 10:36:59 +00004837 Another build fix.
4838
4839 * svg/SVGFEImageElement.cpp:
4840 (WebCore::SVGFEImageElement::notifyFinished):
4841
48422008-09-05 Antti Koivisto <antti@apple.com>
4843
antti@apple.comfeec2582008-09-05 10:03:39 +00004844 Build fixes.
4845
4846 * WebCore.xcodeproj/project.pbxproj:
4847 * svg/graphics/filters/SVGFEImage.cpp:
4848 (WebCore::FEImage::cachedImage):
4849
48502008-09-05 Antti Koivisto <antti@apple.com>
4851
darin@apple.com07c80c62008-09-05 18:15:43 +00004852 Reviewed by Darin Adler.
antti@apple.com72e4a842008-09-05 09:28:11 +00004853
4854 Most of the implementation for https://bugs.webkit.org/show_bug.cgi?id=17998
4855 When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation"
4856
4857 Implement HTTP 1.1 "Specific end-to-end revalidation" for WebCore memory cache. This patch does
4858 not yet enable it for the biggest use case, reloading. However it is good for general browsing as
4859 well. Doing this in WebCore level as opposed to relying on disk cache has big benefit that
4860 we avoid re-decoding resources, especially images.
4861
4862 To be exact the enabled case is not actually the "Specific end-to-end revalidation" since it does not include
4863 CacheControl: max-age=0 header. That would be added in reload case.
4864
4865 The approach for revalidation is to kick the original resource out from the memory cache
4866 and create a new CachedResource that represents the revalidation request. In case
4867 we get 304 back for the request we put the original resource back to the cache, update
4868 its expiration date and switch the clients registered to revalidation resource to be
4869 clients of the original resource.
4870
4871 All heap allocated CachedImage pointers now use CachedResourceHandle<CachedImage> (and so on) instead.
4872 This allows updating the handles to point to the original resource when the revalidation succeeds. It
4873 also acts as refcounting smart pointer.
4874
4875 * WebCore.pro:
4876 * WebCore.vcproj/WebCore.vcproj:
4877 * WebCore.xcodeproj/project.pbxproj:
4878 * css/CSSFontFaceSource.h:
4879 * css/CSSImportRule.h:
4880 * dom/Clipboard.h:
4881 (WebCore::Clipboard::dragImage):
4882 * dom/ProcessingInstruction.h:
4883 * dom/ScriptElement.h:
4884 * dom/XMLTokenizer.cpp:
4885 (WebCore::XMLTokenizer::isWaitingForScripts):
4886 * dom/XMLTokenizer.h:
4887 * html/HTMLImageLoader.cpp:
4888 (WebCore::HTMLImageLoader::setImage):
4889 (WebCore::HTMLImageLoader::updateFromElement):
4890 (WebCore::HTMLImageLoader::notifyFinished):
4891 * html/HTMLImageLoader.h:
4892 (WebCore::HTMLImageLoader::image):
4893 * html/HTMLLinkElement.h:
4894 * html/HTMLTokenizer.cpp:
4895 (WebCore::HTMLTokenizer::reset):
4896 (WebCore::HTMLTokenizer::scriptHandler):
4897 (WebCore::HTMLTokenizer::notifyFinished):
4898 * html/HTMLTokenizer.h:
4899 * loader/Cache.cpp:
4900 (WebCore::Cache::revalidateResource):
4901 (WebCore::Cache::revalidationSucceeded):
4902 (WebCore::Cache::revalidationFailed):
4903 * loader/Cache.h:
4904 * loader/CachedResource.cpp:
4905 (WebCore::CachedResource::CachedResource):
4906 (WebCore::CachedResource::~CachedResource):
4907 (WebCore::CachedResource::isExpired):
4908 (WebCore::CachedResource::setResponse):
4909 (WebCore::CachedResource::deleteIfPossible):
4910 (WebCore::CachedResource::setResourceToRevalidate):
4911 (WebCore::CachedResource::clearResourceToRevalidate):
4912 (WebCore::CachedResource::switchClientsToRevalidatedResource):
4913 (WebCore::CachedResource::canUseCacheValidator):
4914 (WebCore::CachedResource::mustRevalidate):
4915 * loader/CachedResource.h:
4916 (WebCore::CachedResource::canDelete):
4917 (WebCore::CachedResource::registerHandle):
4918 (WebCore::CachedResource::unregisterHandle):
4919 (WebCore::CachedResource::isCacheValidator):
4920 (WebCore::CachedResource::resourceToRevalidate):
4921 (WebCore::CachedResource::setExpirationDate):
4922 * loader/CachedResourceHandle.cpp: Added.
4923 (WebCore::CachedResourceHandleBase::setResource):
4924 * loader/CachedResourceHandle.h: Added.
4925 (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
4926 (WebCore::CachedResourceHandleBase::get):
4927 (WebCore::CachedResourceHandleBase::operator!):
4928 (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
4929 (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
4930 (WebCore::CachedResourceHandleBase::operator=):
4931 (WebCore::CachedResourceHandle::CachedResourceHandle):
4932 (WebCore::CachedResourceHandle::get):
4933 (WebCore::CachedResourceHandle::operator->):
4934 (WebCore::CachedResourceHandle::operator=):
4935 (WebCore::CachedResourceHandle::operator==):
4936 (WebCore::CachedResourceHandle::operator!=):
4937 (WebCore::operator==):
4938 (WebCore::operator!=):
4939 * loader/DocLoader.cpp:
4940 (WebCore::DocLoader::checkForReload):
4941 * loader/UserStyleSheetLoader.h:
4942 * loader/loader.cpp:
4943 (WebCore::Loader::Host::servePendingRequests):
4944 (WebCore::Loader::Host::didFinishLoading):
4945 (WebCore::Loader::Host::didFail):
4946 (WebCore::Loader::Host::didReceiveResponse):
4947 (WebCore::Loader::Host::didReceiveData):
4948 * page/EventHandler.cpp:
4949 (WebCore::EventHandler::selectCursor):
4950 * rendering/RenderImage.cpp:
4951 (WebCore::RenderImage::setCachedImage):
4952 (WebCore::RenderImage::imageChanged):
4953 * rendering/RenderImage.h:
4954 (WebCore::RenderImage::cachedImage):
4955 (WebCore::RenderImage::imagePtr):
4956 * rendering/style/RenderStyle.h:
4957 * rendering/style/StyleCachedImage.h:
4958 (WebCore::StyleCachedImage::data):
4959 (WebCore::StyleCachedImage::cachedImage):
4960 * svg/SVGFEImageElement.h:
4961 * svg/graphics/filters/SVGFEImage.h:
4962 * xml/XSLImportRule.h:
4963
beidson@apple.comab60d982008-09-05 04:58:12 +000049642008-09-04 Brady Eidson <beidson@apple.com>
4965
4966 Reviewed by Mitz
4967
4968 <rdar://problem/6180236> - Safari times out connections after 1 or 2 minutes
4969
4970 A 60-second default timeout was added in http://trac.webkit.org/changeset/17144 in an attempt
4971 to model default NSURLRequest behavior in a cross-platform manner.
4972
4973 Sadly by always enforcing this 60 second timeout, WebCore was stomping over the wishes of any Webkit
4974 client that wished to enforce a much larger default timeout using NSURLRequest API.
4975
4976 Additionally, upon reviewing what all other browsers do, it seems apparent that "no limit" is desirable
4977 behavior on the web and this restores previous Safari/WebKit behavior.
4978
4979 It would be easy to write a layout test for this, but to be effective it would have
4980 to run for at least 61 seconds, which seems insane until will can parallelize run-webkit-tests
4981
4982 * manual-tests/timeout-test.html: Added.
4983 * manual-tests/timeout-test.php: Added.
4984
4985 * platform/network/ResourceRequestBase.h:
4986 (WebCore::ResourceRequestBase::ResourceRequestBase): Rename the constant to "unspecifiedTimeoutInterval"
4987 and make it UINT_MAX so platforms that do set it have an effective "no timeout." (Windows, for example)
4988 * platform/network/mac/ResourceRequestMac.mm:
4989 (WebCore::ResourceRequest::doUpdatePlatformRequest): If the timeout for this request is
4990 "unspecifiedTimeoutInterval", then don't bother setting the timeout using NSURLRequest API, allowing
4991 WebKit applications to enforce their own default timeout.
4992
mitz@apple.com20268542008-09-05 04:26:32 +000049932008-09-04 Dan Bernstein <mitz@apple.com>
4994
4995 Reviewed by Beth Dakin.
4996
4997 - fix <rdar://problem/6198514> Changing a button's opacity triggers relayout
4998
4999 Test: fast/repaint/button-spurious-layout-hint.html
5000
5001 * rendering/RenderButton.cpp:
5002 (WebCore::RenderButton::setStyle): Reset the inner block's style box
5003 flex to 0 to avoid getting a spurious layout hint.
5004
kevino@webkit.org3e8c4072008-09-04 23:53:04 +000050052008-09-04 Kevin Ollivier <kevino@theolliviers.com>
5006
5007 wx build fixes.
5008
5009 * WebCoreSources.bkl:
5010 * bindings/js/ScriptControllerWx.cpp: Added.
5011 (WebCore::ScriptController::createScriptInstanceForWidget):
5012 * page/wx/AccessibilityObjectWx.cpp: Added.
5013 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
5014 * platform/graphics/wx/GraphicsContextWx.cpp:
5015 * webcore-base.bkl:
5016 * webcore-wx.bkl:
5017
mitz@apple.com95a87502008-09-04 23:27:19 +000050182008-09-04 Dan Bernstein <mitz@apple.com>
5019
5020 Reviewed by Mark Rowe.
5021
5022 - roll out r36050 because it made svg/custom/invalid-fill-hex.svg fail,
5023 and fixing https://bugs.webkit.org/show_bug.cgi?id=15360 appears to
5024 require a different approach
5025
5026 * css/CSSGrammar.y:
5027
mrowe@apple.com12b7c2d2008-09-04 21:00:02 +000050282008-09-04 Mark Rowe <mrowe@apple.com>
5029
mrowe@apple.com5bc4ea82008-09-04 21:44:28 +00005030 Reviewed by Eric Seidel.
5031
5032 Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
5033 Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
5034
5035 * Configurations/WebCore.xcconfig: Remove ENABLE_DASHBOARD_SUPPORT from FEATURE_DEFINES.
5036 * DerivedSources.make: Revert to checking for ENABLE_DASHBOARD_SUPPORT rather than looking
5037 for ENABLE_DASHBOARD_SUPPORT in FEATURE_DEFINES.
5038
50392008-09-04 Mark Rowe <mrowe@apple.com>
5040
mrowe@apple.com12b7c2d2008-09-04 21:00:02 +00005041 Mac build fix.
5042
5043 * config.h: Only check the value of HAVE_CONFIG_H if it is defined.
5044
eric@webkit.org0716a542008-09-04 20:44:12 +000050452008-09-04 Eric Seidel <eric@webkit.org>
5046
5047 Build fix only, no review.
5048
5049 * dom/XMLTokenizer.cpp: Fix the Chromium merge build by adding a missing header (the Mac files must include it somewhere).
5050
jmalonzo@webkit.org6afc5d42008-09-04 20:26:16 +000050512008-09-04 Marco Barisione <marco.barisione@collabora.co.uk>
5052
5053 Reviewed by Eric Seidel.
5054
5055 http://bugs.webkit.org/show_bug.cgi?id=20380
5056 [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h
5057
5058 * config.h: Include the configuration header generated by autotools if
5059 available.
5060
mitz@apple.com9d7e4262008-09-04 18:15:25 +000050612008-09-04 Dan Bernstein <mitz@apple.com>
5062
5063 Rubber-stamped by Dave Hyatt.
5064
5065 - rename CachedResource::allReferencesRemoved() to allClientsRemoved()
5066
5067 * loader/CachedFont.cpp:
5068 (WebCore::CachedFont::allClientsRemoved):
5069 * loader/CachedFont.h:
5070 * loader/CachedImage.cpp:
5071 (WebCore::CachedImage::allClientsRemoved):
5072 * loader/CachedImage.h:
5073 * loader/CachedResource.cpp:
5074 (WebCore::CachedResource::removeClient):
5075 * loader/CachedResource.h:
5076 (WebCore::CachedResource::allClientsRemoved):
5077
aroben@apple.com0da404d2008-09-04 16:09:33 +000050782008-09-04 Adam Roben <aroben@apple.com>
5079
aroben@apple.comdd3861a2008-09-04 16:09:53 +00005080 Windows build fix after r36071
5081
5082 We were getting these errors:
5083
5084 error C2356: initialization segment must not change during translation
5085 unit
5086
5087 This was happening because multiple files #included by
5088 DerivedSources.cpp were themselves #including StaticConstructors.h. I
5089 fixed the error by adding header guards to StaticConstructors.h so its
5090 contents will only be included once.
5091
5092 But it's also not a good idea for StaticConstructors.h to end up in
5093 DerivedSources.cpp, since it ends up "polluting" all the source files
5094 we have in there. So I removed all the files that include
5095 StaticConstructors.h and added some preprocessor directives to
5096 DerivedSources.cpp to catch this error in the future.
5097
5098 * DerivedSources.cpp: Removed the *Names.cpp files, which include
5099 StaticConstructors.h, and added some preprocessor directives to make
5100 sure we don't end up accidentally including StaticConstructors.h in
5101 the future.
5102 * WebCore.vcproj/WebCore.vcproj: Added the *Names.cpp files.
5103 * platform/StaticConstructors.h: Added header guards.
5104
51052008-09-04 Adam Roben <aroben@apple.com>
5106
aroben@apple.com0da404d2008-09-04 16:09:33 +00005107 Windows build fix
5108
5109 * platform/graphics/win/FontPlatformData.h: Added a missing #include
5110 of PassRefPtr.h, and corrected the capitalization of RefCounted.h.
5111 * platform/text/PlatformString.h: Added a missing #include of
5112 PassRefPtr.h.
5113
vestbo@webkit.orgc0aeddf2008-09-04 11:44:17 +000051142008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
5115
5116 Reviewed by Simon.
5117
vestbo@webkit.orgb82da912008-09-04 14:24:58 +00005118 Fix the QtWebKit build to match changes in r36016
5119
5120 * WebCore.pro:
5121 * bridge/qt/qt_instance.cpp:
5122 (KJS::Bindings::QtInstance::getRuntimeObject):
5123 * bridge/qt/qt_runtime.cpp:
5124 (KJS::Bindings::convertQVariantToValue):
5125 (KJS::Bindings::QtConnectionObject::execute):
5126
51272008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
5128
5129 Reviewed by Simon.
5130
vestbo@webkit.orgc0aeddf2008-09-04 11:44:17 +00005131 Re-enable support for user stylesheets in QtWebKit
5132
5133 QtWebKit now follows the FRAME_LOADS_USER_STYLESHEET
5134 code path, which allows us to keep API support for
5135 loading user style sheets from remote URLs.
5136
5137 As part of the change UserStyleSheetLoader.cpp/h was
5138 moved from WebCore/loader/mac to WebCore/loader.
5139
5140 * WebCore.pro:
5141 * WebCore.xcodeproj/project.pbxproj:
5142 * dom/Document.h:
5143 * loader/UserStyleSheetLoader.cpp: Renamed from WebCore/loader/mac/UserStyleSheetLoader.cpp.
5144 (UserStyleSheetLoader::UserStyleSheetLoader):
5145 (UserStyleSheetLoader::~UserStyleSheetLoader):
5146 * loader/UserStyleSheetLoader.h: Renamed from WebCore/loader/mac/UserStyleSheetLoader.h.
5147 * page/qt/FrameQt.cpp:
5148 (WebCore::Frame::setUserStyleSheetLocation):
5149 (WebCore::Frame::setUserStyleSheet):
5150
alp@webkit.org539ff852008-09-04 09:14:42 +000051512008-09-04 Alp Toker <alp@nuanti.com>
5152
5153 Reviewed by Eric.
5154
5155 Remove left-over QT and CAIRO platform checks.
5156
5157 * html/CanvasRenderingContext2D.cpp:
5158
eric@webkit.orgbc0aab82008-09-04 08:39:51 +000051592008-09-04 Eric Seidel <eric@webkit.org>
5160
5161 Reviewed by Mark Rowe.
5162
mitz@apple.com9388d252008-09-04 08:58:58 +00005163 Fix leak of TextMetrics due to over-ref as see on buildbot.
eric@webkit.orgbc0aab82008-09-04 08:39:51 +00005164
5165 * html/TextMetrics.h: use adoptRef since RefCounted starts @ refcount 1 instead of 0 now.
5166
mitz@apple.com89557c52008-09-04 07:26:53 +000051672008-09-04 Dan Bernstein <mitz@apple.com>
5168
5169 Reviewed by Dave Hyatt.
5170
5171 - fix https://bugs.webkit.org/show_bug.cgi?id=19717
5172 <rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist
5173
5174 * rendering/RenderBlock.cpp:
5175 (WebCore::RenderBlock::layoutOnlyPositionedObjects): In the
5176 positioned movement only case, call
5177 tryLayoutDoingPositionedMovementOnly() and fall back on doing a full
5178 layout if that fails.
5179 (WebCore::RenderBlock::layoutPositionedObjects): Ditto.
5180 * rendering/RenderBox.h:
5181 (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): Renamed
5182 layoutDoingPositionedMovementOnly to this, and made this function
5183 check if the width changed. If it did, return, leaving the object
5184 dirty. The caller can then call layout(). The width can change even
5185 in the "positioned movement only" case if the object is shrink-to-fit
5186 and the available width constraint is met. (This was the case in the
5187 bug).
5188 * rendering/RenderObject.h:
5189 (WebCore::RenderObject::tryLayoutDoingPositionedMovementOnly):
5190 Renamed layoutDoingPositionedMovementOnly() to this.
5191
eric@webkit.org8883b4a2008-09-04 06:31:37 +000051922008-09-03 Eric Seidel <eric@webkit.org>
5193
5194 No review, build fix only.
5195
5196 Attempt to fix the Qt build.
5197
5198 * WebCore.pro: add page/animation to include path
5199
mrowe@apple.comaa4bb8d2008-09-04 03:20:30 +000052002008-09-03 Mark Rowe <mrowe@apple.com>
5201
5202 Mac build fix. Correctly detect whether dashboard support is enabled.
5203
5204 * DerivedSources.make:
5205
eric@webkit.org3eefe672008-09-04 01:32:26 +000052062008-09-03 Eric Seidel <eric@webkit.org>
5207
5208 Reviewed by Sam.
5209
eric@webkit.org5e069092008-09-04 01:32:51 +00005210 Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)
5211
5212 * Configurations/WebCore.xcconfig: add missing ENABLE_*
5213 * config.h: add rules for V8_BINDINGS
5214
52152008-09-03 Eric Seidel <eric@webkit.org>
5216
5217 Reviewed by Sam.
5218
eric@webkit.org3eefe672008-09-04 01:32:26 +00005219 https://bugs.webkit.org/show_bug.cgi?id=20620
5220
5221 Add #if USE(JSC) around KJS dependencies
5222 Remove !USE(JAVASCRIPTCORE_BINDINGS) support for 3 reasons:
5223 1. Most platforms have it on anyway
5224 2. V8 is going to want to share some of that code
5225 3. Those platforms which want it off, should have a separate file instead of an #ifdef in our .cpp
5226
5227 * bindings/js/JSPluginElementFunctions.cpp: remove !USE(JAVASCRIPTCORE_BINDINGS) support
5228 * config.h: change JAVASCRIPTCORE_BINDINGS to JSC and add USE(V8)
5229 * html/HTMLAppletElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
5230 * html/HTMLAppletElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
5231 * html/HTMLEmbedElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
5232 * html/HTMLEmbedElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
5233 * html/HTMLObjectElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
5234 * html/HTMLObjectElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
5235 * html/HTMLPlugInElement.cpp: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
5236 * html/HTMLPlugInElement.h: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
5237 * platform/text/AtomicString.cpp: add USE(JSC)
5238 * platform/text/AtomicString.h: add USE(JSC)
5239 * platform/text/PlatformString.h: add USE(JSC)
5240 * platform/text/String.cpp: add USE(JSC)
5241 * platform/text/StringImpl.cpp: add USE(JSC)
5242 * platform/text/StringImpl.h: add USE(JSC)
5243
mrowe@apple.comfbe724c2008-09-03 23:46:54 +000052442008-09-03 Dean McNamee <deanm@chromium.org>
5245
5246 Reviewed by Darin Adler.
5247
5248 Fix https://bugs.webkit.org/show_bug.cgi?id=20511
5249 Bug 20511: Remove static initializers on Windows
5250
5251 Avoid static initializers on Windows by forcing Visual C++ to put
5252 all static initializers in a code segment that is never executed.
5253
5254 * config.h:
5255 * css/MediaFeatureNames.cpp:
5256 * dom/EventNames.cpp:
5257 * dom/QualifiedName.cpp:
5258 * dom/make_names.pl:
5259 * platform/StaticConstructors.h:
5260 * platform/text/AtomicString.cpp:
5261
mrowe@apple.com3aa63182008-09-03 23:40:49 +000052622008-09-03 Dirk Schulze <vbs85@gmx.de>
5263
5264 Reviewed by Dave Hyatt.
5265
5266 Make FontCairo draw TextStroke and TextFill separately.
5267
5268 [CAIRO] draw TextFill and TextStroke separately.
5269 [https://bugs.webkit.org/show_bug.cgi?id=20631]
5270
5271 * platform/graphics/cairo/FontCairo.cpp:
5272 (WebCore::Font::drawGlyphs):
5273
eric@webkit.org4ac94e62008-09-18 23:07:55 +000052742008-09-03 Peter Kasting <pkasting@google.com>
mrowe@apple.comdcd72b72008-09-03 23:34:40 +00005275
5276 Reviewed by Dave Hyatt.
5277
5278 https://bugs.webkit.org/show_bug.cgi?id=19663
5279 Account for paint and timer lag when animating images. Also pretend
5280 that images whose animations were paused (by becoming invisible)
5281 continued to animate, by "catching up" to the correct frame when they're
5282 shown again.
5283
5284 * platform/graphics/BitmapImage.cpp:
5285 (WebCore::BitmapImage::BitmapImage):
5286 (WebCore::BitmapImage::startAnimation):
5287 (WebCore::BitmapImage::advanceAnimation):
5288 (WebCore::BitmapImage::internalAdvanceAnimation):
5289 (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
5290 * platform/graphics/BitmapImage.h:
5291 * platform/graphics/cairo/ImageCairo.cpp:
5292 (WebCore::BitmapImage::draw):
5293 * platform/graphics/cg/ImageCG.cpp:
5294 (WebCore::BitmapImage::draw):
5295 * platform/graphics/qt/ImageQt.cpp:
5296 (WebCore::BitmapImage::draw):
5297 * platform/graphics/wx/ImageWx.cpp:
5298 (WebCore::BitmapImage::draw):
5299
kmccullough@apple.comb0f4c622008-09-03 21:53:17 +000053002008-09-03 Kevin McCullough <kmccullough@apple.com>
5301
5302 Reviewed by Tim.
5303
5304 Remove the rest of the "zombie" code from the profiler.
5305 - There is no longer a need for the ProfilerClient callback mechanism.
5306
5307 * page/Console.cpp:
5308 (WebCore::Console::Console):
5309 (WebCore::Console::profile):
5310 (WebCore::Console::profileEnd): Move the variables from the header to
5311 here since we don't have to wait for a callback to use them.
5312 * page/Console.h:
5313 * page/InspectorController.cpp:
5314 (WebCore::InspectorController::startUserInitiatedProfiling):
5315 (WebCore::InspectorController::stopUserInitiatedProfiling):
5316 * page/InspectorController.h:
5317
adachan@apple.com38c66182008-09-03 21:43:44 +000053182008-09-03 Ada Chan <adachan@apple.com>
5319
5320 Windows build fix.
5321
5322 * WebCore.vcproj/WebCore.vcproj: Added JSWebKitCSSKeyframeRule.cpp and JSWebKitCSSKeyframesRule.cpp to the project.
5323
dino@apple.com5c917622008-09-03 21:15:53 +000053242008-09-01 Dean Jackson <dino@apple.com>
5325
5326 Reviewed by Dave Hyatt.
5327
5328 https://bugs.webkit.org/show_bug.cgi?id=20594
5329 Add DOM interfaces for WebKitCSSKeyframeRule
5330 and WebKitCSSKeyframesRule.
5331
5332 TEST: LayoutTests/css3/keyframes-rule.html
5333
5334 * css/WebKitCSSKeyframeRule.idl: Added
5335 * css/WebKitCSSKeyframesRule.idl: Added
5336
5337 * bindings/js/JSCSSRuleCustom.cpp:
5338 (WebCore::toJS):
5339 Add return of new JS Keyframe rules
5340 * bindings/objc/DOMInternal.h:
5341 Include new internal header
5342
5343 * DerivedSources.make:
5344 * GNUmakefile.am:
5345 * WebCore.pro:
5346 * WebCore.vcproj/WebCore.vcproj:
5347 * WebCore.xcodeproj/project.pbxproj:
5348 * WebCoreSources.bkl:
5349 Build configs for new files
5350
aroben@apple.com1f51bfa2008-09-03 20:30:59 +000053512008-09-03 Adam Roben <aroben@apple.com>
5352
5353 Windows build fix
5354
5355 * DerivedSources.cpp: Add JSTextMetrics.cpp to fix the build.
5356 * WebCore.vcproj/WebCore.vcproj: Add JSTextMetrics.h for
5357 convenience/consistency.
5358
adele@apple.com27713582008-09-03 20:13:41 +000053592008-09-03 Adele Peterson <adele@apple.com>
5360
5361 Build fix.
5362
5363 * WebCore.vcproj/WebCore.vcproj:
5364
hyatt@apple.com4b38ed82008-09-03 18:32:05 +000053652008-09-03 David Hyatt <hyatt@apple.com>
5366
5367 Fix for bug 18203, right floats should be allowed to overflow past the left border edge.
5368
5369 Reviewed by Darin (ages ago)
5370
5371 Added fast/block/float/clamped-right-float.html
5372
5373 * rendering/RenderBlock.cpp:
5374 (WebCore::RenderBlock::positionNewFloats):
5375
hyatt@apple.comafe62052008-09-03 18:13:39 +000053762008-09-02 David Hyatt <hyatt@apple.com>
5377
5378 Add support for canvas text drawing APIs.
5379
5380 Reviewed by olliej
5381
5382 Tests added as fast/canvas/canvas-text-*.html
5383
5384 * DerivedSources.make:
5385 * WebCore.xcodeproj/project.pbxproj:
5386 * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
5387 (WebCore::JSCanvasRenderingContext2D::fillText):
5388 (WebCore::JSCanvasRenderingContext2D::strokeText):
5389 * css/CSSStyleSelector.cpp:
5390 (WebCore::CSSStyleSelector::initForStyleResolve):
5391 (WebCore::CSSStyleSelector::applyPropertyToStyle):
5392 * css/CSSStyleSelector.h:
5393 * html/CanvasRenderingContext2D.cpp:
5394 (WebCore::CanvasRenderingContext2D::State::State):
5395 (WebCore::CanvasRenderingContext2D::font):
5396 (WebCore::CanvasRenderingContext2D::setFont):
5397 (WebCore::CanvasRenderingContext2D::textAlign):
5398 (WebCore::CanvasRenderingContext2D::setTextAlign):
5399 (WebCore::CanvasRenderingContext2D::textBaseline):
5400 (WebCore::CanvasRenderingContext2D::setTextBaseline):
5401 (WebCore::CanvasRenderingContext2D::fillText):
5402 (WebCore::CanvasRenderingContext2D::strokeText):
5403 (WebCore::CanvasRenderingContext2D::measureText):
5404 (WebCore::CanvasRenderingContext2D::drawTextInternal):
5405 (WebCore::CanvasRenderingContext2D::accessFont):
5406 * html/CanvasRenderingContext2D.h:
5407 * html/CanvasRenderingContext2D.idl:
5408 * html/TextMetrics.h: Added.
5409 (WebCore::TextMetrics::create):
5410 (WebCore::TextMetrics::width):
5411 (WebCore::TextMetrics::setWidth):
5412 (WebCore::TextMetrics::TextMetrics):
5413 * html/TextMetrics.idl: Added.
5414 * platform/graphics/Font.cpp:
5415 (WebCore::Font::lineGap):
5416 * platform/graphics/Font.h:
5417 * platform/graphics/GraphicsContext.cpp:
5418 (WebCore::GraphicsContext::drawBidiText):
5419 * platform/graphics/GraphicsContext.h:
5420 * platform/graphics/GraphicsTypes.cpp:
5421 (WebCore::textAlignName):
5422 (WebCore::parseTextAlign):
5423 (WebCore::textBaselineName):
5424 (WebCore::parseTextBaseline):
5425 * platform/graphics/GraphicsTypes.h:
5426 (WebCore::):
5427
sullivan@apple.combc066af2008-09-03 17:37:24 +000054282008-09-03 John Sullivan <sullivan@apple.com>
5429
5430 Fixed <rdar://problem/6193022> <rdar://problem/6193022> Crash occurs at WebCore::AnimationBase::propertiesEqual () after certain steps
5431
5432 Fixed by Darin, reviewed by me
5433
5434 * page/animation/AnimationBase.cpp:
5435 (WebCore::AnimationBase::propertiesEqual):
5436 added ensurePropertyMap() to this static function
5437 (WebCore::AnimationBase::getPropertyAtIndex):
5438 ditto
5439 (WebCore::AnimationBase::getNumProperties):
5440 ditto
5441
kmccullough@apple.com70168ee2008-09-03 17:35:42 +000054422008-09-03 Kevin McCullough <kmccullough@apple.com>
5443
5444 Reviewed by Darin and Tim.
5445
5446 Remove most of the "zombie" mode from the profiler. Next we will need
5447 to remove the client callback mechanism in profiles.
5448 - These changes are a result of changes to JSCore.
5449
5450 * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html:
5451 * page/Console.cpp:
5452 (WebCore::retrieveLastCaller):
5453 (WebCore::Console::profileEnd):
5454 * page/InspectorController.cpp:
5455 (WebCore::InspectorController::stopUserInitiatedProfiling):
5456
adele@apple.com643616b2008-09-03 16:57:58 +000054572008-09-03 Adele Peterson <adele@apple.com>
5458
5459 Reviewed by Darin Adler.
5460
5461 Test: fast/forms/search-display-none-cancel-button.html
5462
5463 Allow display:none to work on a search field's cancel button. Prepare for adding more style-ability for the results button too.
5464
5465 * css/html4.css: Set display:inline-block for these buttons. Now they can be overridden by a web author.
5466
5467 * rendering/RenderTextControl.cpp:
5468 (WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers.
5469 (WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly. This is now done in html4.css.
5470 (WebCore::RenderTextControl::createCancelButtonStyle): ditto.
5471 (WebCore::RenderTextControl::createSubtreeIfNeeded):
5472 Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class.
5473 (WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers.
5474 (WebCore::RenderTextControl::subtreeHasChanged): ditto.
5475 (WebCore::RenderTextControl::calcHeight): ditto.
5476 (WebCore::RenderTextControl::nodeAtPoint): ditto.
5477 (WebCore::RenderTextControl::layout): ditto.
5478 (WebCore::RenderTextControl::calcPrefWidths): ditto.
5479 (WebCore::RenderTextControl::clientPaddingLeft): ditto.
5480 (WebCore::RenderTextControl::clientPaddingRight): ditto.
5481
5482 * rendering/TextControlInnerElements.cpp:
5483 (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp.
5484 (WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto.
5485 (WebCore::TextControlInnerElement::attachInnerElement): Added.
5486 This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element.
5487 (WebCore::TextControlInnerTextElement::createRenderer): Added. Creates a RenderTextControlInnerBlock.
5488 * rendering/TextControlInnerElements.h:
5489
ap@webkit.orgacd84142008-09-03 08:08:19 +000054902008-08-28 Alexey Proskuryakov <ap@webkit.org>
5491
5492 Reviewed by Maciej.
5493
5494 Elminate SQLiteAuthorizer class.
5495
5496 * WebCore.xcodeproj/project.pbxproj:
5497 * WebCore.vcproj/WebCore.vcproj:
5498 * GNUmakefile.am
5499 Removed SQLiteAuthorizer.h.
5500
5501 * platform/sql/SQLiteAuthorizer.cpp:
5502 * platform/sql/SQLiteAuthorizer.h: Removed.
5503 * platform/sql/SQLiteDatabase.cpp:
5504 (WebCore::SQLiteDatabase::authorizerFunction):
5505 (WebCore::SQLiteDatabase::setAuthorizer):
5506 * platform/sql/SQLiteDatabase.h:
5507 * storage/DatabaseAuthorizer.h:
5508 (WebCore::DatabaseAuthorizer::create):
5509 (WebCore::DatabaseAuthorizer::createView):
5510 (WebCore::DatabaseAuthorizer::createTempView):
5511 (WebCore::DatabaseAuthorizer::dropView):
5512 (WebCore::DatabaseAuthorizer::dropTempView):
5513 (WebCore::DatabaseAuthorizer::allowSelect):
5514 (WebCore::DatabaseAuthorizer::allowReindex):
5515 Merge SQLiteAuthorizer and DatabaseAuthorizer, as keeping them separate serves no purpose.
5516
mrowe@apple.com2ecd4862008-09-03 07:05:48 +000055172008-09-03 Dirk Schulze <vbs85@gmx.de>
5518
5519 Reviewed by Mark Rowe.
5520
5521 WebKitGtk build fix.
5522
5523 * GNUmakefile.am:
5524 * page/animation/AnimationController.h:
5525
mrowe@apple.come344ad02008-09-03 06:59:03 +000055262008-09-02 Robert Blaut <webkit@blaut.biz>
5527
5528 Reviewed by Geoff Garen.
5529
5530 Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913>
5531 Misplaced elements should not close DL lists.
5532
5533 Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html
5534
5535 * html/HTMLParser.cpp:
5536 (WebCore::HTMLParser::handleError):
5537
mrowe@apple.com7a909462008-09-03 06:51:31 +000055382008-09-02 Glenn Wilson <wilsong@gmail.com>
5539
5540 Reviewed by Darin Adler.
5541
5542 Fix for <https://bugs.webkit.org/show_bug.cgi?id=15360>
5543 Bug 15360: color:#{predefined colorName} is treated as colorName in Safari
5544
5545 We would inappropriately interpret and apply an invalid CSS "color" property
5546 when the value is a predefined color preceded by a '#' symbol. For example,
5547 style="color:#gray;" would apply the color gray when it should not.
5548
5549 In the bison template, "hexcolor" was defined as both "HEX maybe_space" OR "IDENT maybe_space".
5550 This caused identifiers not fitting the appropriate hex format but preceded by a '#' to be
5551 interpreted as a valid color (CSSPrimitiveValue::CSS_PARSER_HEXCOLOR), when it was really just
5552 an ignorable token.
5553
5554 To correct this, "IDENT maybe_space" was removed from "hexcolor" and added under "term" as
5555 '#' IDENT maybe_space, which is then processed as a CSSPrimitiveValue::CSS_STRING instead of
5556 CSSPrimitiveValue::CSS_PARSER_HEXCOLOR.
5557
5558 Test: css1/color_and_background/invalid_color.html
5559
5560 * css/CSSGrammar.y:
5561
mrowe@apple.comda9a1442008-09-03 06:22:12 +000055622008-09-02 Mihnea Ovidenie <mihnea@adobe.com>
5563
5564 Reviewed by Darin Adler.
5565
5566 Fix for https://bugs.webkit.org/show_bug.cgi?id=19964
5567 Bug 19964: Divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image
5568
5569 Add a check to RenderBox::repaintLayerRectsForImage to make sure the current layer image can be rendered.
5570
5571 Test: css3/khtml-background-size-0x0-bmp.html
5572
5573 * rendering/RenderBox.cpp:
5574 (WebCore::RenderBox::repaintLayerRectsForImage):
5575
mrowe@apple.com6625ae52008-09-03 06:12:30 +000055762008-09-02 Glenn Wilson <wilsong@gmail.com>
5577
5578 Reviewed by Eric Seidel.
5579
5580 Fix https://bugs.webkit.org/show_bug.cgi?id=20397
5581 Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash
5582
5583 The function checkForOrphanedUnits() would change the length of a list whose size was
5584 was already determined before the call to checkForOrphanedUnits was made. Later in
5585 the caller, the old size was being used for boundary management.
5586
5587 This has been fixed by moving the call to checkForOrphanedUnits() earlier in the
5588 calling function, before the size of the list is determined.
5589
5590 Test: fast/css/orphaned_units_crash.html
5591
5592 * css/CSSParser.cpp:
5593 (WebCore::CSSParser::parseValue): Moved call to checkForOrphanedUnits() earlier in the function.
5594
mrowe@apple.com170bd522008-09-03 05:49:51 +000055952008-09-02 Dirk Schulze <vbs85@gmx.de>
5596
5597 Reviewed by Darin Adler.
5598
mrowe@apple.comeb877a52008-09-03 06:01:15 +00005599 Fallback on invalid fill or stroke styles in Canvas was
5600 transparent black. Changed it to last valid style.
5601
5602 Canvas fillStyle() and strokeStyle() needs fallback
5603 https://bugs.webkit.org/show_bug.cgi?id=20474
5604
5605 Tests: fast/canvas/canvas-invalid-fillstyle.html
5606 fast/canvas/canvas-invalid-strokestyle.html
5607
5608 * html/CanvasStyle.cpp:
5609 (WebCore::CanvasStyle::applyStrokeColor):
5610 (WebCore::CanvasStyle::applyFillColor):
5611
56122008-09-02 Dirk Schulze <vbs85@gmx.de>
5613
5614 Reviewed by Darin Adler.
5615
mrowe@apple.com170bd522008-09-03 05:49:51 +00005616 Fix https://bugs.webkit.org/show_bug.cgi?id=20468
5617 Updated drawImage() in canvas to match the current specification.
5618
5619 Test: fast/canvas/drawImage-with-negative-source-destination.html
5620
5621 * html/CanvasRenderingContext2D.cpp:
5622 (WebCore::normalizeRect):
5623 (WebCore::CanvasRenderingContext2D::drawImage):
5624
mrowe@apple.com96916d12008-09-03 05:41:44 +000056252008-08-26 Mark Rowe <mrowe@apple.com>
5626
5627 Reviewed by Darin Adler.
5628
5629 <rdar://problem/5768210> Switch back to the system version of SQLite
5630
5631 Use the system version of SQLite when it is new enough to provide the functionality
5632 that WebCore requires.
5633
5634 * Configurations/Base.xcconfig:
5635 * Configurations/DebugRelease.xcconfig:
5636 * Configurations/WebCore.xcconfig:
5637
mitz@apple.comce268c12008-09-03 02:59:00 +000056382008-09-02 Dan Bernstein <mitz@apple.com>
5639
5640 - build fix
5641
5642 * page/animation/AnimationBase.h:
5643
dino@apple.com7e49a7a2008-09-03 01:32:14 +000056442008-09-02 Chris Marrin <cmarrin@apple.com>
5645
5646 Reviewed by Dave Hyatt.
5647
5648 AnimationController.cpp should be split into separate files
5649 https://bugs.webkit.org/show_bug.cgi?id=20604
5650
5651 Note: All makefiles, except WebCore.xcodeproj have been changed without testing, upon
5652 recommendation of Dave Hyatt.
5653
5654 * GNUmakefile.am:
5655 * WebCore.pro:
5656 * WebCore.vcproj/WebCore.vcproj:
5657 * WebCore.xcodeproj/project.pbxproj:
5658 * WebCoreSources.bkl:
5659 Build files.
5660
5661 * page/AnimationController.cpp: Removed.
5662 * page/AnimationController.h: Removed.
5663 * page/animation: Added.
5664 * page/animation/AnimationBase.cpp: Added.
5665 * page/animation/AnimationBase.h: Added.
5666 * page/animation/AnimationController.cpp: Copied from WebCore/page/AnimationController.cpp.
5667 * page/animation/AnimationController.h: Copied from WebCore/page/AnimationController.h.
5668 * page/animation/CompositeAnimation.cpp: Added.
5669 * page/animation/CompositeAnimation.h: Added.
5670 * page/animation/ImplicitAnimation.cpp: Added.
5671 * page/animation/ImplicitAnimation.h: Added.
5672 * page/animation/KeyframeAnimation.cpp: Added.
5673 * page/animation/KeyframeAnimation.h: Added.
5674
mitz@apple.comcb917a22008-09-03 00:57:37 +000056752008-09-02 Dan Bernstein <mitz@apple.com>
5676
5677 - release build fix
5678
5679 * platform/graphics/cg/GraphicsContextCG.cpp:
5680 (WebCore::calculateDrawingMode):
5681
timothy@apple.comf3aa7342008-09-02 21:30:26 +000056822008-09-02 Timothy Hatcher <timothy@apple.com>
5683
timothy@apple.comc33ff3c2008-09-02 21:35:02 +00005684 Make console functions log the correct resource URL and
5685 line number for where the call originated.
5686
5687 https://bugs.webkit.org/show_bug.cgi?id=17234
5688 <rdar://problem/5732837>
5689
5690 Reviewed by Kevin McCullough.
5691
5692 Test: manual-tests/inspector/console-call-line-numbers.html
5693
5694 * bindings/js/JSConsoleCustom.cpp:
5695 (WebCore::JSConsole::count): Call the impl.
5696 (WebCore::JSConsole::timeEnd): Ditto.
5697 * manual-tests/inspector/console-call-line-numbers.html: Added.
5698 * manual-tests/inspector/resources/script-console-calls.js: Added.
5699 * page/Console.cpp:
5700 (WebCore::retrieveLastCaller): Helper to get the URL and line.
5701 (WebCore::Console::error): Call retrieveLastCaller to get the URL and
5702 line number to pass to addMessageToConsole.
5703 (WebCore::Console::info): Ditto.
5704 (WebCore::Console::log): Ditto.
5705 (WebCore::Console::assertCondition): Ditto.
5706 (WebCore::Console::count): Ditto.
5707 (WebCore::Console::timeEnd): Ditto.
5708 (WebCore::Console::warn): Ditto.
5709 * page/Console.h:
5710 * page/Console.idl: Make count and timeEnd custom.
5711
57122008-09-02 Timothy Hatcher <timothy@apple.com>
5713
timothy@apple.comf3aa7342008-09-02 21:30:26 +00005714 Removed IDL files from WebCore's framework resources.
5715
5716 * WebCore.xcodeproj/project.pbxproj:
5717
mitz@apple.comfb6ad392008-09-02 20:39:29 +000057182008-09-02 Dan Bernstein <mitz@apple.com>
5719
5720 Reviewed by Dave Hyatt.
5721
5722 - <rdar://problem/5681647> pages at http://www.stendmarsofa.com/ are so slow to calculate style it seems like a hang
5723
5724 * html/HTMLParser.cpp:
5725 (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added a
5726 cap on the number of consecutive identical residual style tags to
5727 reopen.
5728 (WebCore::HTMLParser::popBlock): Ditto.
5729
ap@webkit.org879328b2008-09-02 16:16:06 +000057302008-09-02 Alexey Proskuryakov <ap@webkit.org>
5731
5732 Reviewed by Adam Roben.
5733
5734 A little database quota management cleanup.
5735
5736 * storage/OriginQuotaManager.cpp:
5737 (WebCore::OriginQuotaManager::OriginQuotaManager):
5738 (WebCore::OriginQuotaManager::lock):
5739 (WebCore::OriginQuotaManager::unlock):
5740 (WebCore::OriginQuotaManager::trackOrigin):
5741 (WebCore::OriginQuotaManager::tracksOrigin):
5742 (WebCore::OriginQuotaManager::addDatabase):
5743 (WebCore::OriginQuotaManager::removeDatabase):
5744 (WebCore::OriginQuotaManager::removeOrigin):
5745 (WebCore::OriginQuotaManager::markDatabase):
5746 (WebCore::OriginQuotaManager::diskUsage):
5747 * storage/OriginQuotaManager.h:
5748 Changed to assert that a lock is taken more directly and reliably. Removed comments about
5749 main/background threads, as this is likely to stop being true with synchronous Database calls
5750 being made on worker threads.
5751
5752 * storage/OriginUsageRecord.cpp:
5753 (WebCore::OriginUsageRecord::OriginUsageRecord):
5754 (WebCore::OriginUsageRecord::addDatabase):
5755 (WebCore::OriginUsageRecord::removeDatabase):
5756 (WebCore::OriginUsageRecord::markDatabase):
5757 (WebCore::OriginUsageRecord::diskUsage):
5758 * storage/OriginUsageRecord.h:
5759 (WebCore::OriginUsageRecord::DatabaseEntry::DatabaseEntry):
5760 Don't use a magic value for unknown. It is totally unnecessary for DatabaseEntry, and
5761 can be replaced with a single boolean for OriginUsageRecord.
5762 Added assertions for string parameters being unshared.
5763
5764
abarth@webkit.orgaea97a02008-09-02 04:26:15 +000057652008-09-01 Adam Barth <abarth@webkit.org>
5766
5767 Reviewed by Sam Weinig.
5768
5769 https://bugs.webkit.org/show_bug.cgi?id=19760
5770
5771 Make granting LoadLocalResources conditional on a policy.
5772
5773 * WebCore.base.exp:
5774 * dom/Document.cpp:
5775 (WebCore::Document::initSecurityContext):
5776 * loader/FrameLoader.cpp:
5777 (WebCore::FrameLoader::setLocalLoadPolicy):
5778 (WebCore::FrameLoader::restrictAccessToLocal):
5779 * loader/FrameLoader.h:
5780 (WebCore::FrameLoader::):
5781 * platform/SecurityOrigin.cpp:
5782 (WebCore::SecurityOrigin::grantLoadLocalResources):
5783 * platform/SecurityOrigin.h:
5784
dino@apple.com6e2db502008-09-01 23:05:28 +000057852008-09-01 Dean Jackson <dino@apple.com>
5786
dino@apple.com59ca9f52008-09-01 23:34:13 +00005787 Reviewed by Sam Weinig.
5788
5789 https://bugs.webkit.org/show_bug.cgi?id=20571
5790 Make sure Window object can assign Animation/Transition event
5791 listeners via attributes.
5792
5793 Also added a bunch of transition event tests, although
5794 only transition-end-event-window is directly relevant to this patch.
5795
5796 (WebCore::JSDOMWindowBase::put):
5797
5798 Tests: transitions/transition-end-event-all-properties.html
5799 transitions/transition-end-event-attributes.html
5800 transitions/transition-end-event-container.html
5801 transitions/transition-end-event-left.html
5802 transitions/transition-end-event-multiple-01.html
5803 transitions/transition-end-event-multiple-02.html
5804 transitions/transition-end-event-multiple-03.html
5805 transitions/transition-end-event-multiple-04.html
5806 transitions/transition-end-event-nested.html
5807 transitions/transition-end-event-transform.html
5808 transitions/transition-end-event-window.html
5809
58102008-09-01 Dean Jackson <dino@apple.com>
5811
dino@apple.com6e2db502008-09-01 23:05:28 +00005812 Reviewed by Sam Weinig
5813
5814 Code styling cleanup.
5815
5816 * bindings/js/JSDOMWindowBase.cpp:
5817 (WebCore::JSDOMWindowBase::getValueProperty):
5818 (WebCore::JSDOMWindowBase::put):
5819
weinig@apple.com3412bb42008-09-01 21:22:54 +000058202008-09-01 Geoffrey Garen <ggaren@apple.com>
5821
5822 Reviewed by Darin Adler.
5823
5824 First cut at inline caching for access to vanilla JavaScript properties.
5825
5826 Updated for JavaScriptCore changes. Mostly mechanical addition of StructureIDs
5827 to WebCore classes, and PutPropertySlot& arguments to put functions.
5828
5829 (WebCore::JSCSSStyleDeclaration::customPut): Be sure to play nice with
5830 inline caching for global properties, so global assignment can be optimized.
5831
5832 * ForwardingHeaders/kjs/StructureID.h: Added.
5833 * bindings/js/JSDOMBinding.h:
5834 (WebCore::DOMObject::DOMObject):
5835 * bindings/js/JSDOMWindowBase.cpp:
5836 (WebCore::JSDOMWindowBase::put):
5837 * bindings/js/JSDOMWindowBase.h:
5838 * bindings/js/JSDOMWindowCustom.h:
5839 (WebCore::JSDOMWindow::customPut):
5840 * bindings/js/JSDOMWindowShell.cpp:
5841 (WebCore::JSDOMWindowShell::JSDOMWindowShell):
5842 (WebCore::JSDOMWindowShell::put):
5843 * bindings/js/JSDOMWindowShell.h:
5844 * bindings/js/JSEventTargetBase.h:
5845 (WebCore::JSEventTargetBase::put):
5846 * bindings/js/JSEventTargetNode.h:
5847 (WebCore::JSEventTargetNode::put):
5848 * bindings/js/JSHTMLAppletElementCustom.cpp:
5849 (WebCore::JSHTMLAppletElement::customPut):
5850 * bindings/js/JSHTMLEmbedElementCustom.cpp:
5851 (WebCore::JSHTMLEmbedElement::customPut):
5852 * bindings/js/JSHTMLInputElementBase.cpp:
5853 (WebCore::JSHTMLInputElementBase::put):
5854 * bindings/js/JSHTMLInputElementBase.h:
5855 * bindings/js/JSHTMLObjectElementCustom.cpp:
5856 (WebCore::JSHTMLObjectElement::customPut):
5857 * bindings/js/JSHistoryCustom.cpp:
5858 (WebCore::JSHistory::customPut):
5859 * bindings/js/JSInspectedObjectWrapper.cpp:
5860 (WebCore::JSInspectedObjectWrapper::wrap):
5861 (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
5862 * bindings/js/JSInspectedObjectWrapper.h:
5863 * bindings/js/JSInspectorCallbackWrapper.cpp:
5864 (WebCore::JSInspectorCallbackWrapper::wrap):
5865 (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
5866 * bindings/js/JSInspectorCallbackWrapper.h:
5867 * bindings/js/JSLocationCustom.cpp:
5868 (WebCore::JSLocation::customPut):
5869 * bindings/js/JSPluginElementFunctions.cpp:
5870 (WebCore::runtimeObjectCustomPut):
5871 * bindings/js/JSPluginElementFunctions.h:
5872 * bindings/js/JSQuarantinedObjectWrapper.cpp:
5873 (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
5874 (WebCore::JSQuarantinedObjectWrapper::put):
5875 * bindings/js/JSQuarantinedObjectWrapper.h:
5876 * bindings/js/JSStorageCustom.cpp:
5877 (WebCore::JSStorage::customPut):
5878 * bindings/objc/WebScriptObject.mm:
5879 (-[WebScriptObject setValue:forKey:]):
5880 * bindings/scripts/CodeGeneratorJS.pm:
5881 * bridge/NP_jsobject.cpp:
5882 (_NPN_SetProperty):
5883 * bridge/jni/jni_jsobject.mm:
5884 (JavaJSObject::setMember):
5885 * bridge/objc/objc_class.mm:
5886 (KJS::Bindings::ObjcClass::fallbackObject):
5887 * bridge/objc/objc_runtime.h:
5888 * bridge/objc/objc_runtime.mm:
5889 (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
5890 (ObjcFallbackObjectImp::put):
5891 * bridge/runtime.cpp:
5892 (KJS::Bindings::Instance::createRuntimeObject):
5893 * bridge/runtime_array.cpp:
5894 (RuntimeArray::put):
5895 * bridge/runtime_array.h:
5896 * bridge/runtime_object.cpp:
5897 (RuntimeObjectImp::RuntimeObjectImp):
5898 (RuntimeObjectImp::put):
5899 * bridge/runtime_object.h:
5900
jmalonzo@webkit.org1f770ba2008-09-01 12:43:34 +000059012008-09-01 Dirk Schulze <vbs85@gmx.de>
5902
5903 Reviewed by Eric Seidel.
5904
jmalonzo@webkit.org37f07882008-09-01 12:43:48 +00005905 Fixed border-radius for Cairo.
5906
5907 * platform/graphics/cairo/GraphicsContextCairo.cpp:
5908 (WebCore::GraphicsContext::strokeArc):
5909
59102008-09-01 Dirk Schulze <vbs85@gmx.de>
5911
5912 Reviewed by Eric Seidel.
5913
jmalonzo@webkit.org1f770ba2008-09-01 12:43:34 +00005914 Added canvas's globalAlpha to cairo.
5915
5916 * platform/graphics/GraphicsContext.h:
5917 * platform/graphics/cairo/GraphicsContextCairo.cpp:
5918 (WebCore::GraphicsContext::fillPath):
5919 (WebCore::GraphicsContext::strokePath):
5920 (WebCore::GraphicsContext::setAlpha):
5921 (WebCore::GraphicsContext::getAlpha):
5922 * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
5923 (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
5924 * platform/graphics/cairo/ImageCairo.cpp:
5925 (WebCore::BitmapImage::draw):
5926
hausmann@webkit.orgecd099d2008-08-31 13:13:28 +000059272008-08-31 Simon Hausmann <hausmann@webkit.org>
5928
5929 Unreviewed Qt build fix.
5930
5931 * WebCore.pro: Add TextControlInnerElements.cpp to SOURCES instead of
5932 the .h file
5933
darin@apple.come7945852008-08-31 06:58:07 +000059342008-08-30 Darin Adler <darin@apple.com>
5935
5936 Reviewed by Maciej.
5937
5938 - adopt some new JavaScriptCore functions where appropriate
5939
5940 * bindings/js/JSDOMWindowBase.cpp:
5941 (WebCore::windowProtoFuncAToB): Adopted jsEmptyString.
5942 (WebCore::windowProtoFuncBToA): Ditto.
5943 * bindings/js/JSEventListener.cpp:
5944 (WebCore::JSLazyEventListener::eventParameterName): Adopted
5945 jsNontrivialString.
5946 * bindings/js/JSSVGLazyEventListener.cpp:
5947 (WebCore::JSSVGLazyEventListener::eventParameterName): Ditto.
5948
beidson@apple.com21c821f2008-08-30 00:26:01 +000059492008-08-29 Brady Eidson <beidson@apple.com>
5950
beidson@apple.come1bd6032008-08-30 00:30:11 +00005951 Reviewed by Anders' rubberstamp
5952
5953 Style cleanup to match MediaTokenizer::writeRawData()
5954
5955 * loader/PluginDocument.cpp:
5956 (WebCore::PluginTokenizer::writeRawData):
5957
59582008-08-29 Brady Eidson <beidson@apple.com>
5959
beidson@apple.com21c821f2008-08-30 00:26:01 +00005960 Reviewed by Anders
5961
5962 Fix regression I introducted in 35946
5963 Already covered by media/video-click-dlbclick-standalone.html
5964
5965 * loader/MediaDocument.cpp:
5966 (WebCore::MediaTokenizer::createDocumentStructure): Don't cancel the load here - too early!
5967 (WebCore::MediaTokenizer::writeRawData): Call finish() here so onload() can be called. Also add
5968 an ASSERT signifying that this method should only be called once, to more closely follow the
5969 PluginDocument case.
5970
bdakin@apple.com7ee298c2008-08-30 00:00:30 +000059712008-08-29 Beth Dakin <bdakin@apple.com>
5972
5973 Reviewed by Sam Weinig.
5974
5975 Fix for <rdar://problem/6181588>
5976
5977 This patch makes hit testing take into account the new concept of a
5978 disconnected frame, in which some of the content may not be
5979 visible. The current hit testing mechanism starts at a target frame
5980 and drills down for a HitTestResult. In some cases, drilling down
5981 will find a non-visible result. When this happens, we need to try
5982 again, starting at a higher level -- namely, starting at the main
5983 frame.
5984
5985 * editing/Editor.cpp:
5986 (WebCore::Editor::insideVisibleArea): New function that tests if a
5987 point is inside the visible area for a disconnected frame.
5988 * editing/Editor.h:
5989 * page/EventHandler.cpp:
5990 (WebCore::EventHandler::hitTestResultAtPoint):
5991
adele@apple.comfb903062008-08-29 22:30:18 +000059922008-08-29 Adele Peterson <adele@apple.com>
5993
5994 Reviewed by Adam Roben.
5995
5996 Rename HTMLTextFieldInnerElement.h/.cpp to TextControlInnerElements.h/.cpp
5997
5998 * GNUmakefile.am:
5999 * WebCore.pro:
6000 * WebCore.vcproj/WebCore.vcproj:
6001 * WebCore.xcodeproj/project.pbxproj:
6002 * WebCoreSources.bkl:
6003 * html/HTMLTextFieldInnerElement.cpp: Removed.
6004 * html/HTMLTextFieldInnerElement.h: Removed.
6005 * rendering/RenderTextControl.cpp:
6006 (WebCore::RenderTextControl::createSubtreeIfNeeded):
6007 * rendering/RenderTextControl.h:
6008 * rendering/TextControlInnerElements.cpp: Copied from html/HTMLTextFieldInnerElement.cpp.
6009 (WebCore::TextControlInnerElement::TextControlInnerElement):
6010 (WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
6011 (WebCore::TextControlInnerTextElement::defaultEventHandler):
6012 (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
6013 (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
6014 (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
6015 (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
6016 * rendering/TextControlInnerElements.h: Copied from html/HTMLTextFieldInnerElement.h.
6017
eric@webkit.org298c65b2008-08-29 21:39:32 +000060182008-08-29 Eric Seidel <eric@webkit.org>
6019
eric@webkit.org77837ce2008-08-29 21:40:07 +00006020 Rubber-stamped by aroben.
6021
6022 Add GraphicsContext.h include to GraphcisContextPrivate.h
6023
6024 GraphicsContextPrivate uses StrokeStyle which is defined
6025 in GraphicsContext.h but it doesn't include that header.
6026 CoreGraphics build doesn't fail here due to the order
6027 it happens to include files.
6028
6029 * platform/graphics/GraphicsContextPrivate.h:
6030
60312008-08-29 Eric Seidel <eric@webkit.org>
6032
eric@webkit.org298c65b2008-08-29 21:39:32 +00006033 Reviewed by hyatt.
6034
6035 Fix GeneratedImage to respect Image's refcounting
6036 Fixing potential crashers (future if not current)
6037 https://bugs.webkit.org/show_bug.cgi?id=20567
6038
6039 I don't know if it's possible to make the current code
6040 crash, thus I've not made a test.
6041
6042 * css/CSSGradientValue.cpp:
6043 (WebCore::CSSGradientValue::image):
6044 * css/CSSImageGeneratorValue.cpp:
6045 (WebCore::CSSImageGeneratorValue::removeClient):
6046 (WebCore::CSSImageGeneratorValue::getImage):
6047 * css/CSSImageGeneratorValue.h:
6048 * platform/graphics/GeneratedImage.h:
6049 (WebCore::GeneratedImage::GeneratedImage):
6050 * rendering/style/RenderStyle.cpp:
6051 (WebCore::RenderStyle::setContent):
6052 * rendering/style/RenderStyle.h:
6053
eric.carlson@apple.comddeafd42008-08-29 20:07:19 +000060542008-08-29 Eric Carlson <eric.carlson@apple.com>
6055
6056 Reviewed by Adele.
6057
eric.carlson@apple.com850c77c2008-08-29 20:24:50 +00006058 Fix for <rdar://problem/6093767>
6059 https://bugs.webkit.org/show_bug.cgi?id=20526
6060
6061 Don't allow video to render until unsupported track types have been disabled.
6062
6063 * platform/graphics/win/QTMovieWin.cpp:
6064 (QTMovieWinPrivate::task):
6065 (QTMovieWinPrivate::drawingComplete):
6066 (QTMovieWinPrivate::clearGWorld):
6067
60682008-08-29 Eric Carlson <eric.carlson@apple.com>
6069
6070 Reviewed by Adele.
6071
eric.carlson@apple.comddeafd42008-08-29 20:07:19 +00006072 Fix for https://bugs.webkit.org/show_bug.cgi?id=20525
6073 <rdar://problem/6169301>
6074
6075 Return the size of the movie data instead of 1000.
6076
6077 Test: media/progress-event-total.html
6078
6079 * platform/graphics/win/QTMovieWin.cpp:
6080 (QTMovieWin::dataSize):
6081
hausmann@webkit.org0367b582008-08-29 15:56:02 +000060822008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
6083
hausmann@webkit.orgfe7f2ac2008-08-29 15:57:44 +00006084 Reviewed by Eric Seidel.
6085
6086 [janitor/qt] Start replacing port specific getters with the generic native getter
6087 To get the native presentation of an image we currently have platform
6088 specific #ifdef's and a generic getter using NativeImagePtr. This patch
6089 extends this to the ImageBuffer and updates the Qt platform to get rid
6090 of the special #ifdefs.
6091
6092 https://bugs.webkit.org/attachment.cgi?id=22861
6093
6094 * platform/graphics/BitmapImage.h:
6095 * platform/graphics/Image.h:
6096 * platform/graphics/qt/ImageQt.cpp:
6097 * platform/graphics/qt/StillImageQt.cpp:
6098 * platform/graphics/qt/StillImageQt.h:
6099 * platform/qt/ClipboardQt.cpp:
6100 (WebCore::ClipboardQt::createDragImage):
6101 (WebCore::ClipboardQt::declareAndWriteDragImage):
6102 * platform/qt/CursorQt.cpp:
6103 * platform/qt/PasteboardQt.cpp:
6104 (WebCore::Pasteboard::writeImage):
6105
61062008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
6107
hausmann@webkit.org0367b582008-08-29 15:56:02 +00006108 Reviewed by Simon.
6109
hausmann@webkit.orgb99266e2008-08-29 15:56:59 +00006110 [svg/qt] Stop crashing... when no RenderPath/RenderObject is given...
6111
6112 * svg/graphics/qt/SVGPaintServerQt.cpp:
6113 (WebCore::SVGPaintServer::renderPath):
6114 * svg/graphics/qt/SVGPaintServerSolidQt.cpp:
6115 (WebCore::SVGPaintServerSolid::setup):
6116
61172008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
6118
6119 Reviewed by Simon.
6120
hausmann@webkit.org0367b582008-08-29 15:56:02 +00006121 [network/qt] Implement defering of loading ResourceHandle's
6122 This is needed otherwise we end in an ASSERT in the MainResourceLoader. The
6123 implementation is simply not forwarding anything to the
6124 ResourceHandleClient until we are allowed to. This might lead to a deadlock
6125 in Qt as we do not empty the QNetworkReply input buffer and wait until we
6126 are allowed to read. If that happens we are forced to buffer the data
6127 within QNetworkReplyHandler, for now this is not done.
6128
6129 Manual test:
6130 - Open http://acid3.acidtests.org
6131 - Wait for the test to complete
6132 - Click on the Reference Rendering link
6133 - Be fast and see the results of acid3
6134 => assert
6135
6136 * platform/network/qt/QNetworkReplyHandler.cpp:
6137 (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
6138 (WebCore::QNetworkReplyHandler::setLoadMode):
6139 (WebCore::QNetworkReplyHandler::finish):
6140 (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
6141 (WebCore::QNetworkReplyHandler::forwardData):
6142 (WebCore::QNetworkReplyHandler::start):
6143 (WebCore::QNetworkReplyHandler::resetState):
6144 (WebCore::QNetworkReplyHandler::sendQueuedItems):
6145 * platform/network/qt/QNetworkReplyHandler.h:
6146 (WebCore::QNetworkReplyHandler::):
6147 * platform/network/qt/ResourceHandleQt.cpp:
6148 (WebCore::ResourceHandle::start):
6149 (WebCore::ResourceHandle::loadResourceSynchronously):
6150 (WebCore::ResourceHandle::setDefersLoading):
6151
hausmann@webkit.org2f2621f2008-08-29 10:21:38 +000061522008-08-29 Simon Hausmann <hausmann@webkit.org>
6153
hausmann@webkit.orgf5864402008-08-29 12:35:59 +00006154 Reviewed by Holger.
6155
6156 Don't crash when drawing patterns with the HTML canvas. Patterns
6157 remain unimplemented but at least they don't crash anymore. This is
6158 done by changing the PlatformPatternPtr to be a brush for the Qt
6159 platform.
6160
6161 * platform/graphics/Pattern.h:
6162 * platform/graphics/qt/GraphicsContextQt.cpp:
6163 (WebCore::GraphicsContext::fillPath):
6164 (WebCore::GraphicsContext::strokePath):
6165 (WebCore::GraphicsContext::fillRect):
6166 * platform/graphics/qt/PatternQt.cpp:
6167 (WebCore::Pattern::createPlatformPattern):
6168
61692008-08-29 Simon Hausmann <hausmann@webkit.org>
6170
hausmann@webkit.org2f2621f2008-08-29 10:21:38 +00006171 Fix the Qt build, fontSelector() is not used by the Qt port yet
6172 and we just return 0 in Font::fontSelector().
6173
6174 * platform/graphics/Font.h:
6175
alp@webkit.org97d8c102008-08-29 05:09:39 +000061762008-08-28 Alp Toker <alp@nuanti.com>
6177
6178 GTK+ dist/build fix. List newly added header files.
6179
6180 * GNUmakefile.am:
6181
simon.fraser@apple.com8f30d022008-08-28 23:04:18 +000061822008-08-28 Simon Fraser <simon.fraser@apple.com>
6183
6184 Reviewed by Dave Hyatt
6185
6186 Various WebKitCSSTransformValue-related fixes
6187 https://bugs.webkit.org/show_bug.cgi?id=20562
6188
6189 Test: css3/transform-value-types.html
6190
6191 * bindings/js/JSCSSValueCustom.cpp:
6192 (WebCore::toJS):
6193 * css/CSSValue.h:
6194 * css/WebKitCSSTransformValue.cpp:
6195 (WebCore::WebKitCSSTransformValue::cssText):
6196 * css/WebKitCSSTransformValue.h:
6197 (WebCore::WebKitCSSTransformValue::):
6198 * css/WebKitCSSTransformValue.idl:
6199
mitz@apple.comd7222352008-08-28 22:53:31 +000062002008-08-28 Dan Bernstein <mitz@apple.com>
6201
6202 Reviewed by Steve Falkenburg.
6203
6204 - do not let the "last chance" WM_TIMER trigger WebCore timers when they should be deferred
6205
6206 * platform/win/SharedTimerWin.cpp:
6207 (WebCore::TimerWindowWndProc):
6208
hyatt@apple.com7d335232008-08-28 21:38:45 +000062092008-08-28 David Hyatt <hyatt@apple.com>
6210
6211 RenderStyle cleanup.
6212
6213 Break out StyleImage, StyleGeneratedImage, StyleCachedImage and NinePieceImage into separate files.
6214
6215 Reviewed by Adam
6216
6217 * css/CSSImageGeneratorValue.cpp:
6218 * css/CSSImageValue.cpp:
6219 * css/CSSStyleSelector.cpp:
6220 * rendering/RenderImageGeneratedContent.cpp:
6221 * rendering/style/NinePieceImage.cpp: Added.
6222 * rendering/style/NinePieceImage.h: Added.
6223 * rendering/style/RenderStyle.cpp:
6224 (WebCore::FillLayer::operator==):
6225 (WebCore::FillLayer::containsImage):
6226 (WebCore::StyleInheritedData::operator==):
6227 (WebCore::RenderStyle::contentDataEquivalent):
6228 * rendering/style/RenderStyle.h:
6229 * rendering/style/StyleCachedImage.cpp: Added.
6230 * rendering/style/StyleCachedImage.h: Added.
6231 * rendering/style/StyleGeneratedImage.cpp: Added.
6232 * rendering/style/StyleGeneratedImage.h: Added.
6233 * rendering/style/StyleImage.h: Added.
6234
simon.fraser@apple.com28bad1a2008-08-28 21:29:21 +000062352008-08-28 Simon Fraser <simon.fraser@apple.com>
6236
6237 Reviewed by Dave Hyatt
6238
6239 Make all the 'isFoo()' methods on CSSValue const,
6240 and fix the subclasses.
6241
6242 https://bugs.webkit.org/show_bug.cgi?id=20561
6243
6244 * css/CSSTimingFunctionValue.h:
6245 * css/CSSValue.h:
6246 (WebCore::CSSValue::isFontValue):
6247 (WebCore::CSSValue::isImageGeneratorValue):
6248 (WebCore::CSSValue::isImageValue):
6249 (WebCore::CSSValue::isImplicitInitialValue):
6250 * css/CSSValueList.h:
6251 * css/FontValue.h:
6252
hyatt@apple.com550a95c2008-08-28 19:53:56 +000062532008-08-28 David Hyatt <hyatt@apple.com>
6254
hyatt@apple.comcb3eb812008-08-28 20:08:03 +00006255 The great RenderStyle cleanup begins!
6256
6257 Move LengthBox and LengthSize out of RenderStyle and into Length.
6258
6259 Reviewed by Adam
6260
6261 * rendering/Length.h:
6262 (WebCore::):
6263 (WebCore::Length::Length):
6264 (WebCore::Length::operator==):
6265 (WebCore::Length::operator!=):
6266 (WebCore::Length::value):
6267 (WebCore::Length::rawValue):
6268 (WebCore::Length::percent):
6269 (WebCore::Length::type):
6270 (WebCore::Length::quirk):
6271 (WebCore::Length::setValue):
6272 (WebCore::Length::setRawValue):
6273 (WebCore::Length::calcValue):
6274 (WebCore::Length::calcMinValue):
6275 (WebCore::Length::calcFloatValue):
6276 (WebCore::Length::isUndefined):
6277 (WebCore::Length::isZero):
6278 (WebCore::Length::isPositive):
6279 (WebCore::Length::isNegative):
6280 (WebCore::Length::isAuto):
6281 (WebCore::Length::isRelative):
6282 (WebCore::Length::isPercent):
6283 (WebCore::Length::isFixed):
6284 (WebCore::Length::isStatic):
6285 (WebCore::Length::isIntrinsicOrAuto):
6286 (WebCore::Length::blend):
6287 (WebCore::LengthBox::LengthBox):
6288 (WebCore::LengthBox::operator=):
6289 (WebCore::LengthBox::operator==):
6290 (WebCore::LengthBox::operator!=):
6291 (WebCore::LengthBox::nonZero):
6292 (WebCore::LengthSize::LengthSize):
6293 * rendering/style/RenderStyle.h:
6294
62952008-08-28 David Hyatt <hyatt@apple.com>
6296
hyatt@apple.com550a95c2008-08-28 19:53:56 +00006297 Reviewed by Darin
6298
6299 https://bugs.webkit.org/show_bug.cgi?id=18091
6300
6301 font-size should be animatable using -webkit-transition.
6302
6303 * page/AnimationController.cpp:
6304 (WebCore::AnimationControllerPrivate::ensurePropertyMap):
6305 * rendering/style/RenderStyle.h:
6306 (WebCore::RenderStyle::setFontSize):
6307
mitz@apple.com30923ad2008-08-28 17:45:47 +000063082008-08-28 Brad Garcia <bgarcia@google.com>
6309
6310 Reviewed by Dan Bernstein.
6311
6312 https://bugs.webkit.org/show_bug.cgi?id=20549
6313 Correctly determine when cursor is over a resizable border within
6314 a nested frameset.
6315
6316 * rendering/RenderFrameSet.cpp:
6317 (WebCore::RenderFrameSet::canResizeRow):
6318 (WebCore::RenderFrameSet::canResizeColumn):
6319
simon.fraser@apple.comae77c412008-08-28 17:30:07 +000063202008-08-28 Simon Fraser <simon.fraser@apple.com>
6321
6322 Reviewed by Eric Seidel
6323
6324 Add RuleTypes to CSSRule.idl for keyframes and keyframe rules.
6325 https://bugs.webkit.org/show_bug.cgi?id=20552
6326
6327 Test: animations/animation-css-rule-types.html
6328
6329 * css/CSSRule.idl:
6330
andersca@apple.com12399c32008-08-28 17:26:46 +000063312008-08-28 Anders Carlsson <andersca@apple.com>
6332
6333 Reviewed by Kevin and Darin.
6334
6335 <rdar://problem/6182541>
6336 https://bugs.webkit.org/show_bug.cgi?id=20202
6337 Missing http status line from the http headers.
6338
6339 Add a status line to the header string.
6340
6341 * plugins/PluginStream.cpp:
6342 (WebCore::PluginStream::startStream):
6343
zecke@webkit.orgf1daa422008-08-28 15:56:01 +000063442008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
6345
6346 Rubber-stamped by Darin Adler.
6347
6348 https://bugs.webkit.org/show_bug.cgi?id=17261
6349
6350 Make it possible to theme the default Url icon and enable this for
6351 the Qt port. To have a minimal usage of #ifdef in the code the setting
6352 of the icon was moved to a new method which comes in two flavors.
6353
6354 * loader/icon/IconDatabase.cpp:
6355 (WebCore::loadDefaultIconRecord): Load or set the default icon
6356 (WebCore::IconDatabase::defaultIcon):
6357
zecke@webkit.org1887dc82008-08-28 15:03:21 +000063582008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
6359
6360 Unreviewed compile fix
6361
6362 * platform/graphics/qt/GraphicsContextQt.cpp: Remove redefinitions
6363
aroben@apple.comfacf5032008-08-28 13:34:01 +000063642008-08-28 Adam Roben <aroben@apple.com>
6365
6366 Windows (and others?) build fix
6367
6368 * page/Chrome.cpp: Added a missing #include.
6369 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Fixed typo.
6370
eric@webkit.org22794fd2008-08-28 12:04:40 +000063712008-08-27 Eric Seidel <eric@webkit.org>
6372
6373 Reviewed by Oliver Hunt.
6374
eric@webkit.org5f874e92008-08-28 12:04:55 +00006375 Qt and Cairo support from krit (and blind stab @ wx compile support)
6376 https://bugs.webkit.org/show_bug.cgi?id=20373
6377
6378 * platform/graphics/cairo/GraphicsContextCairo.cpp:
6379 (WebCore::GraphicsContext::fillPath):
6380 (WebCore::GraphicsContext::strokePath):
6381 (WebCore::GraphicsContext::drawPath):
6382 (WebCore::GraphicsContext::fillRect):
6383 (WebCore::GraphicsContext::setPlatformFillColor):
6384 (WebCore::GraphicsContext::setPlatformStrokeColor):
6385 (WebCore::GraphicsContext::setPlatformStrokeStyle):
6386 (WebCore::GraphicsContext::strokeRect):
6387 (WebCore::GraphicsContext::setImageInterpolationQuality):
6388 (WebCore::GraphicsContext::imageInterpolationQuality):
6389 (WebCore::GraphicsContext::setPlatformFillPattern):
6390 (WebCore::GraphicsContext::setPlatformStrokePattern):
6391 (WebCore::GraphicsContext::setPlatformFillGradient):
6392 (WebCore::GraphicsContext::setPlatformStrokeGradient):
6393 * platform/graphics/qt/GraphicsContextQt.cpp:
6394 (WebCore::GraphicsContext::fillPath):
6395 (WebCore::GraphicsContext::strokePath):
6396 (WebCore::GraphicsContext::fillRect):
6397 (WebCore::GraphicsContext::strokeRect):
6398 (WebCore::GraphicsContext::clipToImageBuffer):
6399 (WebCore::GraphicsContext::setPlatformFillPattern):
6400 (WebCore::GraphicsContext::setPlatformStrokePattern):
6401 (WebCore::GraphicsContext::setPlatformFillGradient):
6402 (WebCore::GraphicsContext::setPlatformStrokeGradient):
6403 (WebCore::GraphicsContext::setImageInterpolationQuality):
6404 (WebCore::GraphicsContext::imageInterpolationQuality):
6405 * platform/graphics/wx/GraphicsContextWx.cpp:
6406 (WebCore::GraphicsContext::clipToImageBuffer):
6407 (WebCore::GraphicsContext::setImageInterpolationQuality):
6408 (WebCore::GraphicsContext::imageInterpolationQuality):
6409 (WebCore::GraphicsContext::fillPath):
6410 (WebCore::GraphicsContext::strokePath):
6411 (WebCore::GraphicsContext::drawPath):
6412 (WebCore::GraphicsContext::fillRect):
6413 (WebCore::GraphicsContext::setPlatformFillPattern):
6414 (WebCore::GraphicsContext::setPlatformStrokePattern):
6415 (WebCore::GraphicsContext::setPlatformFillGradient):
6416
64172008-08-27 Eric Seidel <eric@webkit.org>
6418
6419 Reviewed by Oliver Hunt.
6420
eric@webkit.org22794fd2008-08-28 12:04:40 +00006421 Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it.
6422 https://bugs.webkit.org/show_bug.cgi?id=20373
6423
6424 Changed pattern() to canvasPattern() on CanvasStyle to match canvasGradient()
6425
6426 Made Generator (aka Gradient) RefCounted so that GraphicsContext didn't
6427 have to store large Gradient objects in the GraphicsContextState
6428
6429 Made Pattern RefCounted for the same reason.
6430
6431 Many updates to GraphicsContext to support easier drawing with
6432 Patterns and Gradients.
6433
6434 * WebCore.xcodeproj/project.pbxproj: Add pre-existing GraphicsContextPrivate.h
6435 * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
6436 (WebCore::toJS):
6437 * css/CSSGradientValue.cpp:
6438 (WebCore::CSSGradientValue::createGradient):
6439 * css/CSSGradientValue.h:
6440 * html/CanvasGradient.cpp:
6441 (WebCore::CanvasGradient::CanvasGradient):
6442 * html/CanvasGradient.h:
6443 (WebCore::CanvasGradient::gradient):
6444 (WebCore::CanvasGradient::addColorStop):
6445 (WebCore::CanvasGradient::getColor):
6446 * html/CanvasPattern.cpp:
6447 * html/CanvasPattern.h:
6448 (WebCore::CanvasPattern::pattern):
6449 (WebCore::CanvasPattern::originClean):
6450 * html/CanvasRenderingContext2D.cpp:
6451 (WebCore::CanvasRenderingContext2D::State::State):
6452 (WebCore::CanvasRenderingContext2D::setStrokeStyle):
6453 (WebCore::CanvasRenderingContext2D::setFillStyle):
6454 (WebCore::CanvasRenderingContext2D::fill):
6455 (WebCore::CanvasRenderingContext2D::stroke):
6456 (WebCore::CanvasRenderingContext2D::fillRect):
6457 (WebCore::CanvasRenderingContext2D::strokeRect):
6458 * html/CanvasRenderingContext2D.h:
6459 * html/CanvasStyle.cpp:
6460 (WebCore::CanvasStyle::applyStrokeColor):
6461 (WebCore::CanvasStyle::applyFillColor):
6462 * html/CanvasStyle.h:
6463 * platform/graphics/GeneratedImage.h:
6464 (WebCore::GeneratedImage::GeneratedImage):
6465 * platform/graphics/Generator.h:
6466 * platform/graphics/Gradient.h:
6467 (WebCore::Gradient::create):
6468 * platform/graphics/GraphicsContext.cpp:
6469 (WebCore::GraphicsContext::fillRule):
6470 (WebCore::GraphicsContext::setFillRule):
6471 (WebCore::GraphicsContext::setStrokePattern):
6472 (WebCore::GraphicsContext::setFillPattern):
6473 (WebCore::GraphicsContext::setStrokeGradient):
6474 (WebCore::GraphicsContext::setFillGradient):
6475 * platform/graphics/GraphicsContext.h:
6476 * platform/graphics/GraphicsContextPrivate.h:
6477 (WebCore::):
6478 (WebCore::GraphicsContextState::GraphicsContextState):
6479 * platform/graphics/GraphicsTypes.h:
6480 * platform/graphics/Path.h:
6481 * platform/graphics/Pattern.h:
6482 (WebCore::Pattern::create):
6483 (WebCore::Pattern::tileImage):
6484 * platform/graphics/cg/GraphicsContextCG.cpp:
6485 (WebCore::GraphicsContext::drawRect):
6486 (WebCore::GraphicsContext::drawEllipse):
6487 (WebCore::GraphicsContext::drawConvexPolygon):
6488 (WebCore::calculateDrawingMode):
6489 (WebCore::GraphicsContext::drawPath):
6490 (WebCore::fillPathWithFillRule):
6491 (WebCore::GraphicsContext::fillPath):
6492 (WebCore::GraphicsContext::strokePath):
6493 (WebCore::GraphicsContext::fillRect):
6494 (WebCore::GraphicsContext::fillRoundedRect):
6495 (WebCore::GraphicsContext::setPlatformStrokePattern):
6496 (WebCore::GraphicsContext::setPlatformFillPattern):
6497 (WebCore::GraphicsContext::setPlatformStrokeGradient):
6498 (WebCore::GraphicsContext::setPlatformFillGradient):
6499
eric@webkit.org70b099f2008-08-28 11:42:26 +000065002008-08-20 Eric Seidel <eric@webkit.org>
6501
6502 Reviewed by Darin and Alexey.
6503
6504 Close a leak of PausedTimeouts if the JavaScriptDebugServer was destroyed
6505 with timeouts paused.
6506 https://bugs.webkit.org/show_bug.cgi?id=20469
6507
6508 I attempted to clean up the memory management of PausedTimeouts, I'm not
6509 sure the solution I came up with is "cleaner", but it's in some ways
6510 "safer", since it no longer uses raw pointers and manual new/delete.
6511
6512 This also now prevents CachedPage from needlessly creating Window
6513 objects when caching pages which didn't already have one. :)
6514
6515 I also made Chrome.cpp no longer depend on the JavaScript bindings
6516 (aka JSDOMWindowBase.h), since there was no real reason for it to.
6517
6518 * bindings/js/JSDOMWindowBase.cpp:
6519 (WebCore::JSDOMWindowBase::pauseTimeouts):
6520 (WebCore::JSDOMWindowBase::resumeTimeouts):
6521 * bindings/js/JSDOMWindowBase.h:
6522 * bindings/js/ScriptController.cpp:
6523 (WebCore::ScriptController::pauseTimeouts):
6524 (WebCore::ScriptController::resumeTimeouts):
6525 * bindings/js/ScriptController.h:
6526 * history/CachedPage.cpp:
6527 (WebCore::CachedPage::CachedPage):
6528 (WebCore::CachedPage::restore):
6529 * page/Chrome.cpp:
6530 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
6531 (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
6532 * page/JavaScriptDebugServer.cpp:
6533 (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
6534 (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
6535
zecke@webkit.org7d0df9e2008-08-28 03:36:31 +000065362008-08-27 Holger Hans Peter Freyther <zecke@selfish.org>
6537
6538 Unreviewed compile fix
6539
6540 Add the stub for the Qt port.
6541
6542 * WebCore.pro:
6543 * page/qt/AccessibilityObjectQt.cpp: Added.
6544 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
6545
zecke@webkit.orged5c2fe2008-08-28 02:15:20 +000065462008-08-27 Alp Toker <alp@nuanti.com>
6547
6548 Reviewed by Eric.
6549
6550 https://bugs.webkit.org/show_bug.cgi?id=20551
zecke@webkit.org81540882008-08-28 02:18:20 +00006551 [GTK] search popup crash
6552
6553 * platform/gtk/SearchPopupMenuGtk.cpp:
6554 (WebCore::SearchPopupMenu::enabled):
6555 Fix a search popup crasher by disabling the history popup since we
6556 don't support this feature yet in the GTK+ port.
6557
65582008-08-27 Alp Toker <alp@nuanti.com>
6559
6560 Reviewed by Eric.
6561
6562 https://bugs.webkit.org/show_bug.cgi?id=20551
zecke@webkit.orged5c2fe2008-08-28 02:15:20 +00006563 [GTK] curl crashers
6564
6565 * platform/network/curl/ResourceHandleManager.cpp:
6566 (WebCore::ResourceHandleManager::startScheduledJobs):
6567 Remove the resource handle from the pending list before starting the
6568 job, not afterwards. Fixes crashers in the test suite.
6569
6570 Test: fast/dom/clientWidthAfterDocumentIsRemoved.html
6571 Test: fast/encoding/char-encoding.html
6572
eric@webkit.org712cb892008-08-28 00:26:15 +000065732008-08-27 Dirk Schulze <vbs85@gmx.de>
6574
6575 Reviewed by eseidel.
6576
6577 Fix canvas drawImage to support composite operations.
6578 Composite had no effect on canvas elements like these:
6579 http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html
6580
6581 [CAIRO] Canvas composite don't work on canvas-elements.
6582 https://bugs.webkit.org/show_bug.cgi?id=20548
6583
6584 * html/CanvasRenderingContext2D.cpp:
6585 (WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call
6586
eric@webkit.org75c83a02008-08-28 00:04:59 +000065872008-08-27 Mario Bensi <mbensi@pleyo.com>
6588
6589 Reviewed by Eric Seidel.
6590
6591 Fix the data content of an image with a base64.
6592
6593 * platform/network/curl/ResourceHandleManager.cpp:
6594 (WebCore::parseDataUrl): Remove the String and use only the data
6595 Vector because the data.latin1().data() convert the data content and
6596 the image test ( https://bugs.webkit.org/attachment.cgi?id=21726 ) is
6597 not drawn correctly.
6598
antti@apple.comf66a86b2008-08-27 23:59:50 +000065992008-08-27 Antti Koivisto <antti@apple.com>
6600
6601 Reviewed by Eric Seidel.
6602
6603 Crash after OK in dialog box and reloading page in secure mode
6604 https://bugs.webkit.org/show_bug.cgi?id=20493
6605
6606 The new run loop spawned by a modal dialog causes a timer in the loader to run
6607 synchronously inside didFinishLoading() deleting "this" object.
6608
6609 Defer all WebCore timers when a modal dialog is up. They are not
6610 safe to execute.
6611
6612 * page/Chrome.cpp:
6613 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
6614 (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
6615
simon.fraser@apple.com7dbde252008-08-27 23:16:36 +000066162008-08-27 Chris Marrin <cmarrin@apple.com>
6617
6618 Reviewed by Dave Hyatt
6619
6620 Memory leaks when animating transforms
6621 https://bugs.webkit.org/show_bug.cgi?id=20532
6622
6623 * rendering/style/RenderStyle.cpp:
6624 (WebCore::ScaleTransformOperation::blend):
6625 (WebCore::RotateTransformOperation::blend):
6626 (WebCore::SkewTransformOperation::blend):
6627 (WebCore::TranslateTransformOperation::blend):
6628 (WebCore::MatrixTransformOperation::blend):
6629 * rendering/style/RenderStyle.h:
6630
timothy@apple.com79cb13a2008-08-27 22:03:24 +000066312008-08-27 Timothy Hatcher <timothy@apple.com>
6632
6633 Add support for support for -webkit-appearance: default-button on the Mac platform.
6634
6635 <rdar://problem/6173530>
6636
6637 Reviewed by Dave Hyatt.
6638
6639 * WebCore.base.exp: Export new symbols.
6640 * platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation.
6641 * platform/mac/WebCoreSystemInterface.mm: Ditto.
6642 * rendering/RenderButton.cpp:
6643 (WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN).
6644 (WebCore::RenderButton::setStyle): Ditto.
6645 * rendering/RenderButton.h: Ditto.
6646 * rendering/RenderThemeMac.mm:
6647 (WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance.
6648 (WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return
6649 key if the button is default, otherwise reset the key equivalent.
6650 (WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell:
6651 on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore
6652 the window's previous default button cell when finished.
6653
hyatt@apple.comf0ec84d2008-08-27 21:18:15 +000066542008-08-26 David Hyatt <hyatt@apple.com>
6655
6656 First cut at making form controls on OS X respect full page zoom. There are lots of bugs.
6657
6658 Reviewed by weinig
6659
6660 Added fast/forms/zoomed-controls.html
6661
6662 * css/CSSStyleSelector.cpp:
6663 (WebCore::addIntrinsicMargins):
6664 * rendering/RenderSlider.cpp:
6665 (WebCore::RenderSlider::calcPrefWidths):
6666 * rendering/RenderThemeMac.h:
6667 * rendering/RenderThemeMac.mm:
6668 (WebCore::RenderThemeMac::adjustRepaintRect):
6669 (WebCore::RenderThemeMac::inflateRect):
6670 (WebCore::RenderThemeMac::baselinePosition):
6671 (WebCore::RenderThemeMac::setControlSize):
6672 (WebCore::RenderThemeMac::sizeForFont):
6673 (WebCore::RenderThemeMac::sizeForSystemFont):
6674 (WebCore::RenderThemeMac::setFontFromControlSize):
6675 (WebCore::RenderThemeMac::paintCheckbox):
6676 (WebCore::RenderThemeMac::setCheckboxCellState):
6677 (WebCore::RenderThemeMac::paintRadio):
6678 (WebCore::RenderThemeMac::setRadioCellState):
6679 (WebCore::RenderThemeMac::setButtonPaddingFromControlSize):
6680 (WebCore::RenderThemeMac::adjustButtonStyle):
6681 (WebCore::RenderThemeMac::setButtonCellState):
6682 (WebCore::RenderThemeMac::paintButton):
6683 (WebCore::RenderThemeMac::paintMenuList):
6684 (WebCore::RenderThemeMac::paintMenuListButton):
6685 (WebCore::RenderThemeMac::popupInternalPaddingLeft):
6686 (WebCore::RenderThemeMac::popupInternalPaddingRight):
6687 (WebCore::RenderThemeMac::popupInternalPaddingTop):
6688 (WebCore::RenderThemeMac::popupInternalPaddingBottom):
6689 (WebCore::RenderThemeMac::setPopupButtonCellState):
6690 (WebCore::RenderThemeMac::paintSliderTrack):
6691 (WebCore::RenderThemeMac::paintSliderThumb):
6692 (WebCore::RenderThemeMac::adjustSliderThumbSize):
6693 (WebCore::RenderThemeMac::paintSearchField):
6694 (WebCore::RenderThemeMac::adjustSearchFieldStyle):
6695 (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
6696 (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
6697
beidson@apple.comd0793872008-08-27 19:59:55 +000066982008-08-27 Brady Eidson <beidson@apple.com>
6699
6700 Reviewed by Anders
6701
6702 <rdar://problem/6134133> - Crash when loading large movie as a standalone document
6703
6704 We hand off these loads to Quicktime which manages and spools the data itself, but we also continued
6705 to load and buffer the data for the movie in WebCore. With large media files, this results in blowing
6706 away the virtual address space and a crash.
6707
6708 * loader/EmptyClients.h:
6709 (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
6710 * loader/FrameLoaderClient.h: Added client method to get platform specific error for
6711 "plugin will handle load"
6712
6713 * loader/MediaDocument.cpp:
6714 (WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data,
6715 and cancel the WebCore-managed load
6716 (WebCore::MediaTokenizer::writeRawData):
6717 (WebCore::MediaTokenizer::finish):
6718
simon.fraser@apple.come74d6712008-08-27 18:19:55 +000067192008-08-26 Simon Fraser <simon.fraser@apple.com>
6720
6721 Reviewed by Eric Seidel
6722
6723 Linear timing functions should have control points 0, 0, 1, 1.
6724 https://bugs.webkit.org/show_bug.cgi?id=20535
6725
6726 * css/CSSStyleSelector.cpp:
6727 (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
6728 * rendering/style/RenderStyle.h:
6729
aroben@apple.com8cfb6c62008-08-27 14:52:17 +000067302008-08-27 Adam Roben <aroben@apple.com>
6731
6732 Windows build fix
6733
6734 * WebCore.vcproj/WebCore.vcproj: Fix file extension.
6735
mrowe@apple.com37686d42008-09-04 00:10:39 +000067362008-08-26 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com33a556b2008-08-26 22:29:14 +00006737
cfleizach@apple.comc6ebe3d2008-08-26 22:43:22 +00006738 Reviewed by Beth Dakin.
6739
cfleizach@apple.com2a505f42008-08-26 22:56:03 +00006740 <rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown
6741
6742 Added platform-specific accessibilityIgnoreAttachment, which allows the platform
6743 to determine if an attachment is ignored through accessibility. Added equivalent
6744 methods in Gtk, Win and Mac
6745
6746 Test: accessibility/plugin.html
6747
6748 * GNUmakefile.am:
6749 * WebCore.vcproj/WebCore.vcproj:
6750 * WebCore.xcodeproj/project.pbxproj:
6751 * page/AccessibilityObject.h:
6752 * page/AccessibilityRenderObject.cpp:
6753 (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
6754 * page/gtk/AccessibilityObjectAtk.cpp: Added.
6755 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
6756 * page/mac/AccessibilityObjectMac.mm: Added.
6757 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
6758 * page/mac/AccessibilityObjectWrapper.h:
6759 * page/win/AccessibilityObjectWin.cpp: Added.
6760 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
6761
mrowe@apple.com37686d42008-09-04 00:10:39 +000067622008-08-26 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com2a505f42008-08-26 22:56:03 +00006763
6764 Reviewed by Beth Dakin.
6765
cfleizach@apple.comc6ebe3d2008-08-26 22:43:22 +00006766 <rdar://problem/5817770> can't bring up contextual menu for embedded objects in WebText
6767
6768 * page/mac/AccessibilityObjectWrapper.mm:
6769 (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
6770 (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
6771
mrowe@apple.com37686d42008-09-04 00:10:39 +000067722008-08-26 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.comc6ebe3d2008-08-26 22:43:22 +00006773
cfleizach@apple.com33a556b2008-08-26 22:29:14 +00006774 Reviewed by Darin Adler.
6775
6776 <rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns
6777
6778 Tests: accessibility/table-notbody.html
6779
6780 * page/AccessibilityTable.cpp:
6781 (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
6782
weinig@apple.com33705852008-08-26 19:51:28 +000067832008-08-26 Sam Weinig <sam@webkit.org>
6784
weinig@apple.comf6f553a2008-08-26 21:21:26 +00006785 Reviewed by Beth Dakin.
6786
6787 Fix typo.
6788
6789 * dom/DOMCoreException.h:
6790
67912008-08-26 Sam Weinig <sam@webkit.org>
6792
weinig@apple.com0f34f002008-08-26 19:56:54 +00006793 Reviewed by Oliver Hunt.
6794
6795 Fix https://bugs.webkit.org/show_bug.cgi?id=20479
6796 <rdar://problem/6167660>
6797 Take image redirects into account when tainting the canvas.
6798
6799 Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html
6800
6801 * html/CanvasRenderingContext2D.cpp:
6802 (WebCore::CanvasRenderingContext2D::drawImage):
6803 (WebCore::CanvasRenderingContext2D::drawImageFromRect):
6804
68052008-08-26 Sam Weinig <sam@webkit.org>
6806
weinig@apple.com33705852008-08-26 19:51:28 +00006807 Reviewed by Darin Adler.
6808
6809 Change canvas tainting logic to ask the image if it contains
6810 any resources outside of its own origin. Since there is no
6811 way to determine if SVG images contain any resources outside its
6812 origin, we always assume it does.
6813
6814 * html/CanvasRenderingContext2D.cpp:
6815 (WebCore::CanvasRenderingContext2D::drawImage):
6816 (WebCore::CanvasRenderingContext2D::drawImageFromRect):
6817 * platform/graphics/BitmapImage.h:
6818 (WebCore::BitmapImage::hasSingleSecurityOrigin):
6819 * platform/graphics/GeneratedImage.h:
6820 (WebCore::GeneratedImage::hasSingleSecurityOrigin):
6821 * platform/graphics/Image.h:
6822 (WebCore::Image::hasSingleSecurityOrigin):
6823 * platform/graphics/cg/PDFDocumentImage.h:
6824 (WebCore::PDFDocumentImage::hasSingleSecurityOrigin):
6825 * svg/graphics/SVGImage.h:
6826
britto@apple.com616ef6d2008-08-26 17:51:03 +000068272008-08-26 Maxime Britto <britto@apple.com>
6828
6829 Reviewed by Adele.
6830
6831 <rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com)
6832 This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area.
6833 This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls.
6834
6835 * page/EventHandler.cpp:
6836 (WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning
6837 * page/EventHandler.h:
6838 * rendering/RenderLayer.cpp:
6839 (WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta
6840 (WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so.
6841 * rendering/RenderLayer.h:
6842 * rendering/RenderObject.cpp:
6843 (WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled
6844 (WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method
6845 (WebCore::RenderObject::panScroll): No need to check for the layer anymore too.
6846
jchaffraix@webkit.orge6915392008-08-26 10:27:33 +000068472008-08-25 Julien Chaffraix <jchaffraix@webkit.org>
6848
darin@apple.com07c80c62008-09-05 18:15:43 +00006849 Reviewed by Darin Adler.
jchaffraix@webkit.orge6915392008-08-26 10:27:33 +00006850
6851 Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it
6852 https://bugs.webkit.org/show_bug.cgi?id=20247
6853
6854 <rdar://problem/6118218>
6855
6856 Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive
6857 check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute
6858 (case insensitive for HTML elements).
6859
6860 Test: fast/dom/Element/getAttribute-check-case-sensitivity.html
6861
6862 * dom/Element.cpp:
6863 (WebCore::Element::getAttribute):
6864 * dom/NamedAttrMap.cpp:
6865 (WebCore::NamedAttrMap::getNamedItem):
6866 (WebCore::NamedAttrMap::getAttributeItem):
6867 * dom/NamedAttrMap.h:
6868
weinig@apple.comb4ce06e2008-08-26 01:52:51 +000068692008-08-25 Sam Weinig <sam@webkit.org>
6870
weinig@apple.com8d3ea722008-08-26 04:19:07 +00006871 Reviewed by Oliver Hunt.
6872
6873 Fix for https://bugs.webkit.org/show_bug.cgi?id=20514
6874 <rdar://problem/6174096>
6875 Treat SVG images as dirty when drawing to a canvas.
6876
6877 Test: http/tests/security/canvas-remote-read-svg-image.html
6878
6879 * html/CanvasRenderingContext2D.cpp:
6880 (WebCore::CanvasRenderingContext2D::drawImage):
6881 (WebCore::CanvasRenderingContext2D::drawImageFromRect):
6882 * platform/graphics/Image.h:
6883 (WebCore::Image::isSVGImage):
6884 * svg/graphics/SVGImage.h:
6885 (WebCore::SVGImage::isSVGImage):
6886
68872008-08-25 Sam Weinig <sam@webkit.org>
6888
weinig@apple.comb4ce06e2008-08-26 01:52:51 +00006889 Reviewed by Mark Rowe.
6890
6891 Fix https://bugs.webkit.org/show_bug.cgi?id=20377
6892 Leak in XMLHttpRequest.
6893
6894 * xml/XMLHttpRequest.cpp:
6895 (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
6896
beidson@apple.com46421212008-08-25 21:48:56 +000068972008-08-25 Brady Eidson <beidson@apple.com>
6898
6899 Reviewed by Anders
6900
6901 Speculative fix for <rdar://problem/6173217>
6902
6903 Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
6904 Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
6905 the first null check invalid.
6906
6907 * loader/FrameLoader.cpp:
6908 (WebCore::FrameLoader::stopAllLoaders):
6909
6910
kmccullough@apple.com7b85fbb2008-08-25 21:28:40 +000069112008-08-25 Kevin McCullough <kmccullough@apple.com>
6912
6913 Reviewed by Tim.
6914
6915 <rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
6916 there is no profile, can cause crash
6917
6918 * page/inspector/ProfilesPanel.js:
6919
dino@apple.com1baeea62008-08-25 21:06:21 +000069202008-08-25 Dean Jackson <dino@apple.com>
6921
6922 Reviewed by Dave Hyatt
6923
6924 Make sure 'inherit' is handled by transition property.
6925 https://bugs.webkit.org/show_bug.cgi?id=20513
6926
6927 Test: transitions/inherit.html
6928 Test: transitions/inherit-other-props.html
6929
6930 * css/CSSStyleSelector.cpp:
6931 fix macro to check existence of list before getting size
6932
andersca@apple.com2866b8302008-08-25 20:56:21 +000069332008-08-25 Anders Carlsson <andersca@apple.com>
6934
6935 Reviewed by Mark.
6936
6937 <rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.
6938
6939 Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume
6940 (safely) that any class that needs finalization on the main thread will also need to be deallocated
6941 on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
6942 calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.
6943
6944 * platform/mac/WebCoreObjCExtras.c:
6945 (WebCoreObjCFinalizeOnMainThread):
6946
antti@apple.com60381cb2008-08-25 20:41:11 +000069472008-08-25 Antti Koivisto <antti@apple.com>
6948
6949 Reviewed by Dan Bernstein.
6950
6951 Rename CachedResource::referenced() to CachedResource::hasClients() to
6952 match previous ref() -> addClient() rename.
6953
6954 * loader/Cache.cpp:
6955 (WebCore::Cache::pruneLiveResources):
6956 (WebCore::Cache::pruneDeadResources):
6957 (WebCore::Cache::remove):
6958 (WebCore::Cache::getStatistics):
6959 (WebCore::Cache::dumpLRULists):
6960 * loader/CachedResource.cpp:
6961 (WebCore::CachedResource::addClient):
6962 (WebCore::CachedResource::removeClient):
6963 (WebCore::CachedResource::setDecodedSize):
6964 (WebCore::CachedResource::setEncodedSize):
6965 * loader/CachedResource.h:
6966 (WebCore::CachedResource::hasClients):
6967 (WebCore::CachedResource::canDelete):
6968
timothy@apple.com7d809242008-08-25 18:33:05 +000069692008-08-25 Anthony Ricaud <rik24d@gmail.com>
6970
6971 Add a missing Inspector localized string for "other".
6972
6973 https://bugs.webkit.org/show_bug.cgi?id=20509
6974
6975 Reviewed by Tim Hatcher.
6976
6977 * English.lproj/localizedStrings.js:
6978
kmccullough@apple.com560f5fe2008-08-25 18:18:01 +000069792008-08-22 Kevin McCullough <kmccullough@apple.com>
6980
6981 Reviewed by Geoff, Mark and Tim.
6982
6983 <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
6984 in the console said what file and line number they came from
6985 - Lay the foundation for getting line numbers and other data from the
6986 JavaScript engine.
6987
6988 * ForwardingHeaders/VM: Added.
6989 * ForwardingHeaders/VM/Machine.h: Added.
6990 * page/Console.cpp: Gather the line number and file information when
6991 profileEnd has been called, but don't use it until didFinishProfiling is
6992 called. We won't need to wait once we remove the profiler "zombie" mode
6993 which this patch helps pave the foundation for.
6994 (WebCore::Console::Console):
6995 (WebCore::Console::profileEnd):
6996 (WebCore::Console::finishedProfiling):
6997 * page/Console.h:
6998 * page/InspectorController.cpp: Modify calls to
6999 addProfileMessageToConsole to satisfy the new arguments it takes.
7000 (WebCore::InspectorController::finishedProfiling):
7001 (WebCore::InspectorController::addProfile):
7002 (WebCore::InspectorController::addProfileMessageToConsole):
7003 (WebCore::InspectorController::finishedProfiling):
7004 * page/InspectorController.h:
7005
hausmann@webkit.orgf305df42008-08-25 10:06:53 +000070062008-08-25 Holger Hans Peter Freyther <zecke@selfish.org>
7007
7008 Reviewed by Simon.
7009
7010 [inspector] Update the WebKit.qrc Qt resources file
7011 Catchup with the changes in the directory.
7012
7013 * page/inspector/WebKit.qrc:
7014
hausmann@webkit.org5f13af32008-08-25 07:10:22 +000070152008-08-25 Dirk Schulze <vbs85@gmx.de>
7016
7017 Reviewed by Simon.
7018
7019 Transformed the radian to degree, to get rotate()
7020 in canvas work as expected.
7021
7022 [Qt] Canvas.rotate() doesn't work
7023 https://bugs.webkit.org/show_bug.cgi?id=20496
7024
7025 * platform/graphics/qt/GraphicsContextQt.cpp:
7026 (WebCore::GraphicsContext::rotate):
7027
sfalken@apple.com9d442862008-08-25 05:43:33 +000070282008-08-24 Steve Falkenburg <sfalken@apple.com>
7029
7030 Add a "last chance" WM_TIMER to the Windows shared timer.
7031
7032 The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
7033 Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
7034 timers if a timer with an earlier expiration is already pending. This results in no timers
7035 firing from that point on.
7036
7037 We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
7038 buggy window message hook.
7039
7040 This timer will start when the first WM_TIMER is scheduled, and will
7041 fire every 5 seconds thereafter, causing any lost timers to be fired.
7042
7043 Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
7044 and prevents the WebFrame leak.
7045
7046 Reviewed by Darin Adler, Geoff Garen.
7047
7048 * platform/win/SharedTimerWin.cpp:
7049 (WebCore::):
7050 (WebCore::TimerWindowWndProc):
7051 (WebCore::setSharedTimerFireTime):
7052
mitz@apple.com771fb752008-08-25 03:22:44 +000070532008-08-24 Dan Bernstein <mitz@apple.com>
7054
7055 Reviewed by Darin Adler.
7056
7057 - fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
7058
7059 Test: fast/css/font-property-priority.html
7060
7061 * css/CSSParser.cpp:
7062 (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag
7063 to the font-property-parsing functions.
7064 (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and
7065 changed to use it rather than the m_important member.
7066 (WebCore::CSSParser::parseFontVariant): Ditto.
7067 (WebCore::CSSParser::parseFontWeight): Ditto.
7068 * css/CSSParser.h:
7069
timothy@apple.com4cea2632008-08-24 22:28:44 +000070702008-08-24 Timothy Hatcher <timothy@apple.com>
7071
7072 Fixes a bug where the Inspector's UI would not animate or
7073 fully function because JavaScript timeouts, intervals and
7074 CSS animation timers where not firing while paused at a
7075 a breakpoint in the inspected page.
7076
7077 https://bugs.webkit.org/show_bug.cgi?id=20042
7078
7079 Reviewed by Darin Adler.
7080
7081 Test: manual-tests/inspector/forzen-ui-while-paused.html
7082
7083 * page/JavaScriptDebugServer.cpp:
7084 (WebCore::JavaScriptDebugServer::pauseIfNeeded):
7085 Add a call to TimerBase::fireTimersInNestedEventLoop before
7086 spinning the EventLoop.
7087
rwlbuis@webkit.org8a772442008-08-24 18:07:32 +000070882008-08-24 Rob Buis <buis@kde.org>
7089
7090 Reviewed by Sam Weinig.
7091
7092 https://bugs.webkit.org/show_bug.cgi?id=20324
7093 A change in SVG Glyph wont show up
7094
7095 Invalidate the glyph cache when the d attribute is set.
7096
7097 Test: svg/custom/glyph-setting-d-attribute.svg
7098
7099 * svg/SVGGlyphElement.cpp:
7100 (WebCore::SVGGlyphElement::invalidateGlyphCache):
7101 (WebCore::SVGGlyphElement::parseMappedAttribute):
7102 (WebCore::SVGGlyphElement::insertedIntoDocument):
7103 (WebCore::SVGGlyphElement::removedFromDocument):
7104 * svg/SVGGlyphElement.h:
7105
mitz@apple.com5b2c3cc2008-08-24 09:18:39 +000071062008-08-24 Dan Bernstein <mitz@apple.com>
7107
7108 Reviewed by Sam Weinig.
7109
7110 - fix https://bugs.webkit.org/show_bug.cgi?id=13864
7111 <rdar://problem/5451470> REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths()
7112
7113 * rendering/RenderText.cpp:
7114 (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to
7115 beginWS and endWS before the early return to ensure that they are
7116 initialized in that case.
7117
cwzwarich@webkit.org53ddf172008-08-23 08:16:54 +000071182008-08-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
7119
7120 Rubber-stamped by Mark Rowe.
7121
7122 Remove modelines.
7123
7124 * WebCore.pro:
7125 * bridge/testbindings.cpp:
7126 * dom/DocPtr.h:
7127 * loader/SubstituteData.h:
7128 * page/Chrome.cpp:
7129 * page/Chrome.h:
7130 * page/ChromeClient.h:
7131 * page/Frame.h:
7132 * page/FrameLoadRequest.h:
7133 * page/FrameTree.cpp:
7134 * page/FrameTree.h:
7135 * page/Page.h:
7136 * page/mac/ChromeMac.mm:
7137 * platform/network/HTTPHeaderMap.h:
7138 * platform/network/ResourceErrorBase.cpp:
7139 * platform/network/ResourceErrorBase.h:
7140 * platform/network/ResourceHandleInternal.h:
7141 * platform/network/ResourceRequestBase.cpp:
7142 * platform/network/ResourceRequestBase.h:
7143 * platform/network/ResourceResponseBase.cpp:
7144 * platform/network/ResourceResponseBase.h:
7145 * platform/network/cf/ResourceError.h:
7146 * platform/network/cf/ResourceRequest.h:
7147 * platform/network/cf/ResourceRequestCFNet.h:
7148 * platform/network/cf/ResourceResponse.h:
7149 * platform/network/cf/ResourceResponseCFNet.h:
7150 * platform/network/curl/ResourceError.h:
7151 * platform/network/curl/ResourceRequest.h:
7152 * platform/network/curl/ResourceResponse.h:
7153 * platform/network/mac/ResourceError.h:
7154 * platform/network/mac/ResourceErrorMac.mm:
7155 * platform/network/mac/ResourceRequest.h:
7156 * platform/network/mac/ResourceRequestMac.mm:
7157 * platform/network/mac/ResourceResponse.h:
7158 * platform/network/mac/ResourceResponseMac.mm:
7159 * platform/network/qt/ResourceError.h:
7160 * platform/network/qt/ResourceRequest.h:
7161 * platform/network/qt/ResourceResponse.h:
7162 * platform/network/soup/CookieJarSoup.cpp:
7163 * platform/network/soup/ResourceError.h:
7164 * platform/network/soup/ResourceRequest.h:
7165 * platform/network/soup/ResourceResponse.h:
7166
mitz@apple.com57a2f482008-08-23 07:16:41 +000071672008-08-23 Dan Bernstein <mitz@apple.com>
7168
7169 Reviewed by Dave Hyatt.
7170
7171 - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
7172
7173 Test: fast/table/vertical-align-baseline.html
7174
7175 * rendering/RenderTable.cpp:
7176 (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
7177 baseline of the first table row, if there is one, -1 otherwise.
7178 * rendering/RenderTable.h:
7179 * rendering/RenderTableCell.cpp:
7180 (WebCore::RenderTableCell::baselinePosition): Changed to follow the
7181 CSS2.1 definition of the baseline of a table cell.
7182 * rendering/RenderTableSection.cpp:
7183 (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
7184 the baseline of the first row in the section.
7185 * rendering/RenderTableSection.h:
7186
jhoneycutt@apple.com88af18d2008-08-22 23:44:32 +000071872008-08-18 Jon Honeycutt <jhoneycutt@apple.com>
7188
7189 Add SPI to make a Windows WebView transparent.
7190
7191 Reviewed by Dan Bernstein.
7192
7193 * platform/graphics/GraphicsContext.h: Add a parameter, hasAlpha, that
7194 determines whether the created context has an alpha channel.
7195 * platform/graphics/win/GraphicsContextCGWin.cpp:
7196 (WebCore::CGContextWithHDC):
7197
timothy@apple.comb63d1172008-08-22 18:39:42 +000071982008-08-22 Timothy Hatcher <timothy@apple.com>
7199
timothy@apple.com964022d2008-08-22 20:35:20 +00007200 Rolls out r35834 because it caused a regression in the Inspector's
7201 Console where some expressions always threw a syntax error.
7202
7203 https://bugs.webkit.org/show_bug.cgi?id=20487
7204
7205 * page/inspector/Console.js:
7206 (Console.prototype._evalInInspectedWindow): Removes parenthesis
7207 around the expression.
7208
72092008-08-22 Timothy Hatcher <timothy@apple.com>
7210
timothy@apple.com056d4782008-08-22 18:39:52 +00007211 Makes getStyleProperty return a value for the overflow property
7212 when overflow-x and overflow-y are equal.
7213
7214 https://bugs.webkit.org/show_bug.cgi?id=20485
7215
7216 Reviewed by Dan Bernstein.
7217
7218 Test: fast/css/overflow-property.html
7219
7220 * css/CSSMutableStyleDeclaration.cpp:
7221 (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
7222
72232008-08-22 Timothy Hatcher <timothy@apple.com>
7224
timothy@apple.comb63d1172008-08-22 18:39:42 +00007225 Fixes a bug where while editing in the Inspector the
7226 sidebar scroll position would jump to the top.
7227
7228 https://bugs.webkit.org/show_bug.cgi?id=20484
7229
7230 Reviewed by Darin Adler.
7231
7232 * page/inspector/treeoutline.js:
7233 (TreeOutline._removeChildren): Remove the offsetTop call that
7234 was forcing a layout, since layout causes scroll positions
7235 to be clamped to the new scrollHeight/Width. Layout will happen
7236 normally when needed.
7237
kevino@webkit.org8271c842008-08-22 16:25:52 +000072382008-08-22 Kevin Ollivier <kevino@theolliviers.com>
7239
7240 wx build fix. Add AccessibilityTable sources.
7241
7242 * WebCoreSources.bkl:
7243
mitz@apple.com9befc872008-08-22 06:29:33 +000072442008-08-21 Dan Bernstein <mitz@apple.com>
7245
7246 Reviewed by Jon Honeycutt and Alexey Proskuryakov.
7247
7248 - fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
7249
7250 Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
7251
7252 * platform/graphics/mac/SimpleFontDataMac.mm:
7253 (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
7254 ascent and 100% to its reported descent.
7255
mrowe@apple.comac9b6a52008-08-22 02:07:54 +000072562008-08-21 Kalle Vahlman <kalle.vahlman@movial.com>
7257
7258 Reviewed by Darin Adler.
7259
mrowe@apple.com22eaa172008-08-22 02:10:15 +00007260 https://bugs.webkit.org/show_bug.cgi?id=20267
mrowe@apple.comac9b6a52008-08-22 02:07:54 +00007261 [GTK] Crash on some pages due to a plugin
7262
7263 Fix handling of badly formatted and empty plugin mime descriptions
7264
7265 * plugins/gtk/PluginPackageGtk.cpp:
7266 (WebCore::PluginPackage::fetchInfo):
7267
mrowe@apple.com798b3432008-08-22 02:07:48 +000072682008-08-21 Kevin Watters <kevinwatters@gmail.com>
7269
7270 Reviewed by Darin Adler.
7271
7272 Follow other ports (and IE) in ImageSourceWx.cpp never to return an
7273 animated GIF frame duration of less than 50ms.
7274
7275 * platform/graphics/wx/ImageSourceWx.cpp:
7276 (WebCore::ImageSource::frameDurationAtIndex):
7277
britto@apple.com8ed72772008-08-22 00:39:39 +000072782008-08-21 Maxime Britto <britto@apple.com>
7279
7280 Reviewed by Kevin McCullough.
7281
7282 Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
7283 https://bugs.webkit.org/show_bug.cgi?id=20451
7284
7285 rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
7286 When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
7287 This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.
7288
7289 * page/EventHandler.cpp:
7290 (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.
7291
7292 (WebCore::EventHandler::handleMousePressEvent): ditto
7293
timothy@apple.com5d492192008-08-21 23:54:01 +000072942008-08-21 Anthony Ricaud <rik24d@gmail.com>
7295
7296 Small optimization for when the dividers in the Inspector's
7297 Resources panel are updated.
7298
7299 Reviewed by Tim Hatcher.
7300
7301 * page/inspector/ResourcesPanel.js:
7302 (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
7303 Combind a for loop and clone the divider element.
7304
dino@apple.comaa75e4c2008-08-21 23:35:23 +000073052008-08-21 Chris Marrin <cmarrin@apple.com>
7306
7307 Allow 0 (without units) for Time eg. duration
7308 Fix for https://bugs.webkit.org/show_bug.cgi?id=20467
7309
7310 Reviewed by Dave Hyatt.
7311
7312 Test: css1/units/zero-duration-without-units.html
7313
7314 * css/CSSParser.cpp:
7315 (WebCore::CSSParser::validUnit):
7316
timothy@apple.com29c12d02008-08-21 20:12:47 +000073172008-08-21 Timothy Hatcher <timothy@apple.com>
7318
timothy@apple.comca11cd82008-08-21 20:13:12 +00007319 Make deleting all text while editing a DOM attribute in
7320 the Inspector delete the attribute. This also fixes
7321 an exception that would happen before.
7322
7323 https://bugs.webkit.org/show_bug.cgi?id=20472
7324
7325 Reviewed by Kevin McCullough.
7326
7327 * page/inspector/ElementsPanel.js:
7328 (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted):
7329 Don't check for hasAttributes on the parseElement, continuing
7330 through the function will correctly remove the attribute.
7331 If the parseElement is null, call _editingCancelled not
7332 editingCancelled, this fixes an exception.
7333
73342008-08-21 Timothy Hatcher <timothy@apple.com>
7335
timothy@apple.comde831cf2008-08-21 20:12:59 +00007336 Update the Inspector's Metrics pane when editing in
7337 the Styles pane. This makes sure the metrics shown
7338 always match what the Styles pane shows.
7339
7340 https://bugs.webkit.org/show_bug.cgi?id=20470
7341
7342 Reviewed by Kevin McCullough.
7343
7344 * page/inspector/ElementsPanel.js:
7345 (WebInspector.ElementsPanel): Add event listeners for
7346 the "style edited" and "style property toggled" events,
7347 so the Metrics pane is updated.
7348 (WebInspector.ElementsPanel.prototype._stylesPaneEdited):
7349 Update the Metrics pane.
7350 * page/inspector/StylesSidebarPane.js:
7351 (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
7352 Dispatch the "style property toggled" event.
7353 (WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
7354 Dispatch the "style edited" event when the CSS text is restored.
7355 (WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
7356 Dispatch the "style edited" event.
7357
73582008-08-21 Timothy Hatcher <timothy@apple.com>
7359
timothy@apple.com29c12d02008-08-21 20:12:47 +00007360 Make the Inspector's Metrics sidebar pane editable.
7361
7362 https://bugs.webkit.org/show_bug.cgi?id=17218
7363 rdar://problem/5732818
7364
7365 Reviewed by Kevin McCullough.
7366
7367 * page/inspector/ElementsPanel.js:
7368 (WebInspector.ElementsPanel): Add an event listener for
7369 the "metrics edited" event, so the Styles pane is updated.
7370 * page/inspector/MetricsSidebarPane.js:
7371 (WebInspector.MetricsSidebarPane.prototype.update): Remember the node
7372 so future updates work. Add a double click event listener for the
7373 metric values to start editing.
7374 (WebInspector.MetricsSidebarPane.prototype.startEditing):
7375 Call WebInspector.startEditing with some context.
7376 (WebInspector.MetricsSidebarPane.prototype.editingCancelled):
7377 (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
7378 Set the user input on the elements inline style. Fire the
7379 "metrics edited" event.
7380
sfalken@apple.com7e6e5392008-08-21 18:42:44 +000073812008-08-21 Steve Falkenburg <sfalken@apple.com>
7382
7383 Fix a race condition in Windows timer code.
7384 Timer function could end up being called with a 0 timer, leading to a Windows exception.
7385
7386 Don't post a timer message if one is already pending.
7387
7388 Reviewed by Ada Chan.
7389
7390 * platform/win/SharedTimerWin.cpp:
7391 (WebCore::TimerWindowWndProc):
7392 (WebCore::clearTimer):
7393 (WebCore::queueTimerProc):
7394 (WebCore::setSharedTimerFireTime):
7395
timothy@apple.com8d15bcf2008-08-21 16:33:17 +000073962008-08-21 Anthony Ricaud <rik24d@gmail.com>
7397
timothy@apple.com493212c72008-08-21 16:36:06 +00007398 After trying to add the expression, try again with quotes for
7399 easier edition.
7400
7401 https://bugs.webkit.org/show_bug.cgi?id=20466
7402
7403 Reviewed by Tim Hatcher.
7404
7405 * page/inspector/ObjectPropertiesSection.js: Added an
7406 evaluateExpression function.
7407
74082008-08-21 Anthony Ricaud <rik24d@gmail.com>
7409
timothy@apple.com8d15bcf2008-08-21 16:33:17 +00007410 Perform Inspector searches on search event to clear results when
7411 clicking the cross to empty it. Delete the lastQuery when the field
7412 is emptied in order to perform the search if exactly the same query
7413 is entered next.
7414
7415 https://bugs.webkit.org/show_bug.cgi?id=20462
7416
7417 Reviewed by Tim Hatcher.
7418
7419 * page/inspector/inspector.js:
7420
jmalonzo@webkit.orgdd470402008-08-21 11:22:51 +000074212008-08-21 Marco Barisione <marco.barisione@collabora.co.uk>
7422
7423 Reviewed by Mark Rowe.
7424
7425 http://bugs.webkit.org/show_bug.cgi?id=19656
7426 [SOUP] The gio code should call didFail() instead of
7427 didFinishLoading() in case of error
7428
7429 In case of error call didFail() instead of didReceiveResponse() and
7430 didFinishLoading().
7431
7432 * platform/network/soup/ResourceHandleSoup.cpp:
7433 (WebCore::networkErrorForFile):
7434 (WebCore::readCallback):
7435 (WebCore::openCallback):
7436 (WebCore::queryInfoCallback):
7437
mrowe@apple.com72a95b12008-08-21 04:01:51 +000074382008-08-20 Mark Rowe <mrowe@apple.com>
7439
mrowe@apple.com4e593f42008-08-21 06:52:42 +00007440 Reviewed by Jon Honeycutt.
7441
7442 Fix build failure.
7443
7444 * bridge/c/c_instance.cpp:
7445 (KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
7446 as that is what NPEnumerationFunctionPtr is declared as accepting.
7447
74482008-08-20 Mark Rowe <mrowe@apple.com>
7449
mrowe@apple.com72a95b12008-08-21 04:01:51 +00007450 Reviewed by Dan Bernstein.
7451
7452 Build fix. Handle kCGInterpolationMedium in switch statements if it is available.
7453
7454 * platform/graphics/GraphicsContext.h:
7455 (WebCore::):
7456 * platform/graphics/cg/GraphicsContextCG.cpp:
7457 (WebCore::GraphicsContext::setImageInterpolationQuality):
7458 (WebCore::GraphicsContext::imageInterpolationQuality):
7459
mitz@apple.comaa938792008-08-21 00:33:29 +000074602008-08-20 Dan Bernstein <mitz@apple.com>
7461
7462 Rubber-stamped by John Sullivan.
7463
7464 - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and
7465 rename related methods and variables accordingly.
7466
7467 * WebCore.base.exp:
7468 * page/FrameView.cpp:
7469 (WebCore::FrameViewPrivate::FrameViewPrivate):
7470 (WebCore::FrameView::shouldUpdateWhileOffscreen):
7471 (WebCore::FrameView::setShouldUpdateWhileOffscreen):
7472 * page/FrameView.h:
7473 * platform/ScrollView.h:
7474 * platform/mac/ScrollViewMac.mm:
7475 (WebCore::ScrollView::updateContents):
7476
beidson@apple.com2ace6b12008-08-21 00:13:12 +000074772008-08-20 Brady Eidson <beidson@apple.com>
7478
7479 Reviewed by Mitzpettel
7480
7481 <rdar://problem/6163636> - Many images broken in Mail
7482
7483 This can be traced back to the preload scanner. With that change, CachedResources are created a lot
7484 sooner than before and confuse the WebArchive machinery.
7485
7486 When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
7487 such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
7488 machinery and nothing is known about where the data will eventually come from.
7489
7490 * loader/DocumentLoader.cpp:
7491 (WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is
7492 CachedResource::PreloadReferenced.
7493
zecke@webkit.orga8fa0e12008-08-20 22:50:39 +000074942008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>
7495
7496 Unreviewed compile fix
7497
7498 Catch up with the JSValue::type elimination.
7499
7500 * bridge/qt/qt_instance.cpp:
7501 (KJS::Bindings::QtRuntimeObjectImp::construct):
7502 (KJS::Bindings::QtInstance::defaultValue):
7503 * bridge/qt/qt_runtime.cpp:
7504 (KJS::Bindings::QtRuntimeConnectionMethod::call):
7505
mrowe@apple.com2d74ec92008-08-20 22:15:53 +000075062008-08-20 Chris Teague <chris.teague@gmail.com>
7507
7508 Reviewed by Mark Rowe.
7509
7510 Fix https://bugs.webkit.org/show_bug.cgi?id=20449
7511 Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined
7512
7513 * ChangeLog:
7514 * loader/FrameLoader.cpp:
7515 (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
7516
simon.fraser@apple.combe1d24c2008-08-20 21:57:22 +000075172008-08-20 Simon Fraser <simon.fraser@apple.com>
7518
7519 Reviewed by Dave Hyatt
7520
7521 getComputedStyle() for webkitTransform should return a transform
7522 that does not have the transform origin baked into it.
7523 https://bugs.webkit.org/show_bug.cgi?id=20464
7524
7525 Test: fast/css/getComputedStyle-transform.html
7526
7527 * css/CSSComputedStyleDeclaration.cpp:
7528 (WebCore::computedTransform):
7529 * rendering/style/RenderStyle.cpp:
7530 (WebCore::RenderStyle::applyTransform):
7531 * rendering/style/RenderStyle.h:
7532
andersca@apple.com021ce772008-08-20 21:04:12 +000075332008-08-20 Josh Aas <joshmoz@gmail.com>
7534
7535 Reviewed and landed by Anders.
7536
7537 <rdar://problem/6163636>
7538 rename NPCocoaEvent's "event" struct to "data" (20446)
7539
7540 * bridge/npapi.h:
7541 (_NPCocoaEvent::):
7542
bdakin@apple.com699d13d2008-08-20 20:46:28 +000075432008-08-20 Beth Dakin <bdakin@apple.com>
7544
darin@apple.com07c80c62008-09-05 18:15:43 +00007545 Reviewed by Darin Adler.
bdakin@apple.com699d13d2008-08-20 20:46:28 +00007546
7547 Fix for <rdar://problem/6145626>
7548 This patch fixes a number of remaining problems getting
7549 disconnected frames to work correctly with markAllMatchesForText()
7550 and findString(). Details inline.
7551
7552 This was a static helper function in Frame, but this patch requires
7553 the same functionality in Editor, so I just added it as a function
7554 on Node.
7555 * dom/Node.cpp:
7556 (WebCore::Node::isInShadowTree):
7557 * dom/Node.h:
7558
7559 * editing/Editor.cpp:
7560 (WebCore::Editor::insideVisibleArea): Returns false if
7561 excludeFromTextSearch() is true.
7562
7563 In a normal (non-disconnected) frame, findString returns a range of
7564 the document node if the text is not found in the frame. I changed
7565 firstVisibleRange and lastVisibleRange to match that behavior when
7566 the text is not found
7567 (WebCore::Editor::firstVisibleRange):
7568 (WebCore::Editor::lastVisibleRange):
7569
7570 Here are the bulk of the changes in the patch. A lot of text was
7571 not being found in disconnected frames because I failed to account
7572 for all of the possible problems associated with shadow trees. That
7573 is fixed here.
7574 (WebCore::Editor::nextVisibleRange):
7575 * editing/Editor.h:
7576
7577 excludeFromTextSearch() is new. It allows a WebKit client to mark a
7578 frame as not-text-searchable through SPI.
7579 * WebCore.base.exp:
7580 * page/Frame.cpp:
7581 (WebCore::Frame::excludeFromTextSearch):
7582 (WebCore::Frame::setExcludeFromTextSearch):
7583 (WebCore::FramePrivate::FramePrivate):
7584 * page/Frame.h:
7585 * page/FramePrivate.h:
7586
7587 (WebCore::Frame::findString):
7588 (WebCore::Frame::markAllMatchesForText): I kept running into an
7589 assertion failure in paining code because of the forced paint on
7590 empty visible rects.
7591
timothy@apple.com301befc2008-08-20 19:10:54 +000075922008-08-20 Timothy Hatcher <timothy@apple.com>
7593
7594 Adds a positon box to the Inspector's Metrics sidebar
7595 pane. When an element is not statically positioned, there
7596 is now a position box that show top, right, bottom and
7597 left computed values.
7598
7599 Reviewed by Kevin McCullough.
7600
7601 * English.lproj/localizedStrings.js: Updated the strings.
7602 * page/inspector/MetricsSidebarPane.js:
7603 (WebInspector.MetricsSidebarPane.prototype.update):
7604 Renamed the boxPartValue function to createBoxPartElement
7605 and made it create the entire element. Made it understand
7606 how to get position style properties. Don't use the figure dash
7607 when 0px is used for positions, since the 0 is meaningful there.
7608 Instead use the figure dash when a position is auto.
7609 * page/inspector/inspector.css: Added a new rule for position.
7610
mrowe@apple.com37686d42008-09-04 00:10:39 +000076112008-08-20 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com2a5ecc02008-08-20 18:34:56 +00007612
7613 Reviewed by Beth Dakin
7614
7615 Qt build fix
7616
7617 * WebCore.pro:
7618
mitz@apple.comedaa9042008-08-20 18:28:07 +000076192008-08-20 Dan Bernstein <mitz@apple.com>
7620
7621 Reviewed by Anders Carlsson.
7622
7623 - avoid using a deprecated NSScroller method on Leopard
7624
7625 * platform/mac/PlatformScrollBarMac.mm:
7626 (WebCore::PlatformScrollbar::updateThumbPosition):
7627 (WebCore::PlatformScrollbar::updateThumbProportion):
7628
jmalonzo@webkit.org6e0a3082008-08-20 11:40:31 +000076292008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
7630
7631 Reviewed by Oliver Hunt.
7632
7633 Gtk build fix
7634
7635 * GNUmakefile.am:
7636 * page/AccessibilityTable.cpp: Change nil to 0
7637 (WebCore::AccessibilityTable::cellForColumnAndRow):
7638
ap@webkit.org01aff702008-08-20 07:23:06 +000076392008-08-19 Alexey Proskuryakov <ap@webkit.org>
7640
7641 Reviewed by Geoff Garen.
7642
7643 Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
7644
7645 * ForwardingHeaders/kjs/JSLock.h: Added.
7646 * WebCore.vcproj/WebCore.vcproj:
7647 * bindings/js/GCController.cpp:
7648 (WebCore::collect):
7649 (WebCore::GCController::gcTimerFired):
7650 (WebCore::GCController::garbageCollectNow):
7651 * bindings/js/JSCustomSQLStatementCallback.cpp:
7652 (WebCore::JSCustomSQLStatementCallback::handleEvent):
7653 * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
7654 (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
7655 * bindings/js/JSCustomSQLTransactionCallback.cpp:
7656 (WebCore::JSCustomSQLTransactionCallback::handleEvent):
7657 * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
7658 (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
7659 * bindings/js/JSCustomVoidCallback.cpp:
7660 (WebCore::JSCustomVoidCallback::handleEvent):
7661 * bindings/js/JSCustomXPathNSResolver.cpp:
7662 (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
7663 * bindings/js/JSDOMWindowBase.cpp:
7664 (WebCore::DOMWindowTimer::~DOMWindowTimer):
7665 (WebCore::JSDOMWindowBase::clear):
7666 (WebCore::JSDOMWindowBase::timerFired):
7667 * bindings/js/JSEventCustom.cpp:
7668 (WebCore::toJS):
7669 * bindings/js/JSEventListener.cpp:
7670 (WebCore::JSAbstractEventListener::handleEvent):
7671 * bindings/js/JSNSResolver.cpp:
7672 (WebCore::JSNSResolver::lookupNamespaceURI):
7673 * bindings/js/JSNodeFilterCondition.cpp:
7674 (WebCore::JSNodeFilterCondition::acceptNode):
7675 * bindings/js/ScheduledAction.cpp:
7676 (WebCore::ScheduledAction::execute):
7677 * bindings/js/ScriptController.cpp:
7678 (WebCore::ScriptController::evaluate):
7679 (WebCore::ScriptController::clearWindowShell):
7680 (WebCore::ScriptController::createHTMLEventHandler):
7681 (WebCore::ScriptController::createSVGEventHandler):
7682 (WebCore::ScriptController::initScript):
7683 (WebCore::ScriptController::updateDocument):
7684 (WebCore::ScriptController::bindingRootObject):
7685 (WebCore::ScriptController::windowScriptNPObject):
7686 (WebCore::ScriptController::createScriptObjectForPluginElement):
7687 (WebCore::ScriptController::clearScriptObjects):
7688 * bindings/js/ScriptControllerMac.mm:
7689 (WebCore::ScriptController::windowScriptObject):
7690 * bindings/objc/WebScriptObject.mm:
7691 (_didExecute):
7692 (-[WebScriptObject callWebScriptMethod:withArguments:]):
7693 (-[WebScriptObject evaluateWebScript:]):
7694 (-[WebScriptObject setValue:forKey:]):
7695 (-[WebScriptObject valueForKey:]):
7696 (-[WebScriptObject removeWebScriptKey:]):
7697 (-[WebScriptObject stringRepresentation]):
7698 (-[WebScriptObject webScriptValueAtIndex:]):
7699 (-[WebScriptObject setWebScriptValueAtIndex:value:]):
7700 (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
7701 * bridge/NP_jsobject.cpp:
7702 (_NPN_InvokeDefault):
7703 (_NPN_Invoke):
7704 (_NPN_Evaluate):
7705 (_NPN_GetProperty):
7706 (_NPN_SetProperty):
7707 (_NPN_RemoveProperty):
7708 (_NPN_HasProperty):
7709 (_NPN_HasMethod):
7710 (_NPN_Enumerate):
7711 * bridge/c/c_class.cpp:
7712 (KJS::Bindings::CClass::~CClass):
7713 (KJS::Bindings::CClass::methodsNamed):
7714 (KJS::Bindings::CClass::fieldNamed):
7715 * bridge/c/c_instance.cpp:
7716 (KJS::Bindings::CInstance::invokeMethod):
7717 (KJS::Bindings::CInstance::invokeDefaultMethod):
7718 (KJS::Bindings::CInstance::getPropertyNames):
7719 * bridge/c/c_runtime.cpp:
7720 (KJS::Bindings::CField::valueFromInstance):
7721 (KJS::Bindings::CField::setValueToInstance):
7722 * bridge/c/c_utility.cpp:
7723 (KJS::Bindings::convertValueToNPVariant):
7724 (KJS::Bindings::convertNPVariantToValue):
7725 * bridge/jni/jni_class.cpp:
7726 (JavaClass::JavaClass):
7727 (JavaClass::~JavaClass):
7728 * bridge/jni/jni_instance.cpp:
7729 (JavaInstance::stringValue):
7730 * bridge/jni/jni_jsobject.mm:
7731 (JavaJSObject::call):
7732 (JavaJSObject::eval):
7733 (JavaJSObject::getMember):
7734 (JavaJSObject::setMember):
7735 (JavaJSObject::removeMember):
7736 (JavaJSObject::getSlot):
7737 (JavaJSObject::setSlot):
7738 (JavaJSObject::toString):
7739 (JavaJSObject::convertValueToJObject):
7740 (JavaJSObject::convertJObjectToValue):
7741 * bridge/jni/jni_objc.mm:
7742 (KJS::Bindings::dispatchJNICall):
7743 * bridge/jni/jni_runtime.cpp:
7744 (appendClassName):
7745 (JavaMethod::signature):
7746 * bridge/jni/jni_runtime.h:
7747 (KJS::Bindings::JavaString::JavaString):
7748 (KJS::Bindings::JavaString::_commonInit):
7749 (KJS::Bindings::JavaString::~JavaString):
7750 (KJS::Bindings::JavaString::UTF8String):
7751 * bridge/jni/jni_utility.cpp:
7752 (KJS::Bindings::convertValueToJValue):
7753 * bridge/npruntime.cpp:
7754 (_NPN_GetStringIdentifier):
7755 * bridge/objc/objc_instance.mm:
7756 (ObjcInstance::moveGlobalExceptionToExecState):
7757 (ObjcInstance::invokeMethod):
7758 (ObjcInstance::invokeDefaultMethod):
7759 (ObjcInstance::setValueOfUndefinedField):
7760 (ObjcInstance::getValueOfUndefinedField):
7761 * bridge/objc/objc_runtime.mm:
7762 (ObjcField::valueFromInstance):
7763 (ObjcField::setValueToInstance):
7764 * bridge/objc/objc_utility.mm:
7765 (KJS::Bindings::convertValueToObjcValue):
7766 (KJS::Bindings::convertNSStringToString):
7767 (KJS::Bindings::convertObjcValueToValue):
7768 * bridge/qt/qt_instance.cpp:
7769 (KJS::Bindings::QtRuntimeObjectImp::removeFromCache):
7770 (KJS::Bindings::QtInstance::~QtInstance):
7771 (KJS::Bindings::QtInstance::getQtInstance):
7772 (KJS::Bindings::QtInstance::getRuntimeObject):
7773 * bridge/qt/qt_runtime.cpp:
7774 (KJS::Bindings::convertValueToQVariant):
7775 (KJS::Bindings::convertQVariantToValue):
7776 (KJS::Bindings::QtRuntimeMetaMethod::call):
7777 (KJS::Bindings::QtRuntimeConnectionMethod::call):
7778 (KJS::Bindings::QtConnectionObject::QtConnectionObject):
7779 (KJS::Bindings::QtConnectionObject::execute):
7780 * bridge/runtime.cpp:
7781 (KJS::Bindings::Instance::createRuntimeObject):
7782 * bridge/testbindings.cpp:
7783 (main):
7784 * bridge/testbindings.mm:
7785 (main):
7786 * bridge/testqtbindings.cpp:
7787 (main):
7788 * dom/Document.cpp:
7789 (WebCore::Document::~Document):
7790 * dom/Node.cpp:
7791 (WebCore::Node::setDocument):
7792 * history/CachedPage.cpp:
7793 (WebCore::CachedPage::CachedPage):
7794 (WebCore::CachedPage::restore):
7795 (WebCore::CachedPage::clear):
7796 * loader/FrameLoader.cpp:
7797 (WebCore::getString):
7798 * page/InspectorController.cpp:
7799 (WebCore::ConsoleMessage::ConsoleMessage):
7800 (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
7801 (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
7802 (WebCore::getResourceDocumentNode):
7803 (WebCore::search):
7804 (WebCore::inspectedWindow):
7805 (WebCore::wrapCallback):
7806 (WebCore::currentCallFrame):
7807 (WebCore::profiles):
7808 (WebCore::InspectorController::focusNode):
7809 (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
7810 (WebCore::InspectorController::addDatabaseScriptResource):
7811 (WebCore::InspectorController::addScriptProfile):
7812 * page/JavaScriptCallFrame.cpp:
7813 (WebCore::JavaScriptCallFrame::evaluate):
7814 * page/JavaScriptProfileNode.cpp:
7815 (WebCore::getTotalTime):
7816 (WebCore::getSelfTime):
7817 (WebCore::getTotalPercent):
7818 (WebCore::getSelfPercent):
7819 (WebCore::getNumberOfCalls):
7820 (WebCore::getChildren):
7821 (WebCore::getVisible):
7822 * page/Page.cpp:
7823 * page/mac/FrameMac.mm:
7824 * plugins/PluginView.cpp:
7825 (WebCore::PluginView::start):
7826 (WebCore::getString):
7827 (WebCore::PluginView::performRequest):
7828 (WebCore::PluginView::bindingInstance):
7829 * plugins/gtk/PluginViewGtk.cpp:
7830 (WebCore::PluginView::paint):
7831 (WebCore::PluginView::handleKeyboardEvent):
7832 (WebCore::PluginView::handleMouseEvent):
7833 (WebCore::PluginView::setNPWindowRect):
7834 (WebCore::PluginView::stop):
7835 (WebCore::PluginView::init):
7836 * plugins/qt/PluginViewQt.cpp:
7837 (WebCore::PluginView::setNPWindowRect):
7838 (WebCore::PluginView::stop):
7839 (WebCore::PluginView::init):
7840 * plugins/win/PluginViewWin.cpp:
7841 (WebCore::PluginView::dispatchNPEvent):
7842 (WebCore::PluginView::handleKeyboardEvent):
7843 (WebCore::PluginView::handleMouseEvent):
7844 (WebCore::PluginView::setNPWindowRect):
7845 (WebCore::PluginView::stop):
7846 * xml/XMLHttpRequest.cpp:
7847 (WebCore::XMLHttpRequest::clearResponse):
7848 (WebCore::XMLHttpRequest::didFinishLoading):
7849 (WebCore::XMLHttpRequest::didReceiveData):
7850
eric@webkit.orgbac93762008-08-19 23:33:07 +000078512008-08-19 Eric Seidel <eric@webkit.org>
7852
7853 Reviewed by Geoff Garen.
7854
7855 Add the beginnings of Skia graphics support to WebCore
7856 as I try to begin the long process of un-forking the changes
7857 needed to WebCore to make Andriod's WebCore build.
7858
7859 I'll follow this up with actual *Skia.cpp files in a separate patch.
7860
7861 * platform/graphics/AffineTransform.h:
7862 * platform/graphics/FloatPoint.h:
7863 * platform/graphics/FloatRect.h:
7864 * platform/graphics/Gradient.h:
7865 * platform/graphics/GraphicsContext.h:
7866 * platform/graphics/Image.h:
7867 * platform/graphics/ImageBuffer.h:
7868 * platform/graphics/ImageSource.h:
7869 * platform/graphics/IntPoint.h:
7870 * platform/graphics/IntRect.h:
7871 * platform/graphics/Path.h:
7872 * platform/graphics/Pattern.h:
7873 * svg/graphics/SVGPaintServerPattern.h:
7874 * svg/graphics/SVGPaintServerSolid.h:
7875
sfalken@apple.com3f69b332008-08-19 22:34:37 +000078762008-08-19 Steve Falkenburg <sfalken@apple.com>
7877
sfalken@apple.com45d22802008-08-19 22:46:31 +00007878 Fix Windows build more.
7879
7880 * WebCore.vcproj/WebCore.vcproj:
7881
78822008-08-19 Steve Falkenburg <sfalken@apple.com>
7883
sfalken@apple.com3f69b332008-08-19 22:34:37 +00007884 Fix Windows build.
7885
7886 * page/AccessibilityRenderObject.cpp:
7887 (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
7888
mrowe@apple.com37686d42008-09-04 00:10:39 +000078892008-08-19 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com7c7b5f32008-08-19 22:05:37 +00007890
7891 Reviewed by Beth Dakin.
7892
7893 <rdar://problem/4003764> Expose tables as AXTables
7894
7895 Tests: accessibility/table-attributes.html
7896 accessibility/table-cell-spans.html
7897 accessibility/table-cells.html
7898 accessibility/table-detection.html
7899 accessibility/table-sections.html
7900 accessibility/table-with-rules.html
7901
7902 * WebCore.xcodeproj/project.pbxproj:
7903 * page/AXObjectCache.cpp:
7904 (WebCore::AXObjectCache::get):
7905 * page/AccessibilityObject.h:
7906 (WebCore::):
7907 (WebCore::AccessibilityObject::isDataTable):
7908 (WebCore::AccessibilityObject::isTableRow):
7909 (WebCore::AccessibilityObject::isTableColumn):
7910 (WebCore::AccessibilityObject::isTableCell):
7911 * page/AccessibilityRenderObject.cpp:
7912 (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
7913 * page/AccessibilityTable.cpp: Added.
7914 (WebCore::AccessibilityTable::AccessibilityTable):
7915 (WebCore::AccessibilityTable::~AccessibilityTable):
7916 (WebCore::AccessibilityTable::create):
7917 (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
7918 (WebCore::AccessibilityTable::clearChildren):
7919 (WebCore::AccessibilityTable::addChildren):
7920 (WebCore::AccessibilityTable::headerContainer):
7921 (WebCore::AccessibilityTable::columns):
7922 (WebCore::AccessibilityTable::rows):
7923 (WebCore::AccessibilityTable::rowHeaders):
7924 (WebCore::AccessibilityTable::columnHeaders):
7925 (WebCore::AccessibilityTable::cells):
7926 (WebCore::AccessibilityTable::columnCount):
7927 (WebCore::AccessibilityTable::rowCount):
7928 (WebCore::AccessibilityTable::cellForColumnAndRow):
7929 (WebCore::AccessibilityTable::roleValue):
7930 (WebCore::AccessibilityTable::accessibilityIsIgnored):
7931 (WebCore::AccessibilityTable::title):
7932 (WebCore::AccessibilityTable::isDataTable):
7933 * page/AccessibilityTable.h: Added.
7934 * page/AccessibilityTableCell.cpp: Added.
7935 (WebCore::AccessibilityTableCell::AccessibilityTableCell):
7936 (WebCore::AccessibilityTableCell::~AccessibilityTableCell):
7937 (WebCore::AccessibilityTableCell::create):
7938 (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
7939 (WebCore::AccessibilityTableCell::rowIndexRange):
7940 (WebCore::AccessibilityTableCell::columnIndexRange):
7941 * page/AccessibilityTableCell.h: Added.
7942 (WebCore::AccessibilityTableCell::isTableCell):
7943 (WebCore::AccessibilityTableCell::roleValue):
7944 * page/AccessibilityTableColumn.cpp: Added.
7945 (WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
7946 (WebCore::AccessibilityTableColumn::~AccessibilityTableColumn):
7947 (WebCore::AccessibilityTableColumn::create):
7948 (WebCore::AccessibilityTableColumn::setParentTable):
7949 (WebCore::AccessibilityTableColumn::elementRect):
7950 (WebCore::AccessibilityTableColumn::size):
7951 (WebCore::AccessibilityTableColumn::children):
7952 (WebCore::AccessibilityTableColumn::headerObject):
7953 (WebCore::AccessibilityTableColumn::headerObjectForSection):
7954 (WebCore::AccessibilityTableColumn::addChildren):
7955 * page/AccessibilityTableColumn.h: Added.
7956 (WebCore::AccessibilityTableColumn::parentObject):
7957 (WebCore::AccessibilityTableColumn::roleValue):
7958 (WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
7959 (WebCore::AccessibilityTableColumn::isTableColumn):
7960 (WebCore::AccessibilityTableColumn::setColumnIndex):
7961 (WebCore::AccessibilityTableColumn::columnIndex):
7962 * page/AccessibilityTableHeaderContainer.cpp: Added.
7963 (WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
7964 (WebCore::AccessibilityTableHeaderContainer::~AccessibilityTableHeaderContainer):
7965 (WebCore::AccessibilityTableHeaderContainer::create):
7966 (WebCore::AccessibilityTableHeaderContainer::children):
7967 (WebCore::AccessibilityTableHeaderContainer::elementRect):
7968 (WebCore::AccessibilityTableHeaderContainer::size):
7969 (WebCore::AccessibilityTableHeaderContainer::addChildren):
7970 * page/AccessibilityTableHeaderContainer.h: Added.
7971 (WebCore::AccessibilityTableHeaderContainer::roleValue):
7972 (WebCore::AccessibilityTableHeaderContainer::setParentTable):
7973 (WebCore::AccessibilityTableHeaderContainer::parentObject):
7974 (WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
7975 * page/AccessibilityTableRow.cpp: Added.
7976 (WebCore::AccessibilityTableRow::AccessibilityTableRow):
7977 (WebCore::AccessibilityTableRow::~AccessibilityTableRow):
7978 (WebCore::AccessibilityTableRow::create):
7979 (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
7980 (WebCore::AccessibilityTableRow::headerObject):
7981 * page/AccessibilityTableRow.h: Added.
7982 (WebCore::AccessibilityTableRow::isTableRow):
7983 (WebCore::AccessibilityTableRow::roleValue):
7984 (WebCore::AccessibilityTableRow::setRowIndex):
7985 (WebCore::AccessibilityTableRow::rowIndex):
7986 * page/mac/AccessibilityObjectWrapper.mm:
7987 (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
7988 (RoleEntry::):
7989 (-[AccessibilityObjectWrapper roleDescription]):
7990 (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
7991 (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
7992 (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
7993
sfalken@apple.comb83d4692008-08-19 18:39:44 +000079942008-08-19 Steve Falkenburg <sfalken@apple.com>
7995
7996 Build fix.
7997 Add buildfailed support to stop builds early (preventing inaccurate error messages).
7998 Add missing post-build rule to Release.
7999
8000 * WebCore.vcproj/QTMovieWin.vcproj:
8001
timothy@apple.comda3aa632008-08-19 18:33:02 +000080022008-08-19 Keishi Hattori <casey.hattori@gmail.com>
8003
timothy@apple.com7d08c322008-08-19 18:33:27 +00008004 Added support for console.count in the inspector.
8005
8006 Reviewed by Geoff Garen.
8007
8008 * page/Console.cpp:
8009 (WebCore::Console::count):
8010 * page/Console.h:
8011 * page/Console.idl: Added console.count.
8012 * page/InspectorController.cpp:
8013 (WebCore::InspectorController::didCommitLoad): Clears m_counts.
8014 (WebCore::InspectorController::count): Updates the count number
8015 sing "title@source:line" as the identifier, and adds a
8016 message to the console.
8017 * page/InspectorController.h: Added m_counts.
8018
80192008-08-19 Keishi Hattori <casey.hattori@gmail.com>
8020
timothy@apple.comda3aa632008-08-19 18:33:02 +00008021 Clear console.time timers when changing page.
8022
8023 Reviewed by Geoff Garen.
8024
8025 * page/InspectorController.cpp:
8026 (WebCore::InspectorController::didCommitLoad):
8027
adele@apple.com1f2d7e02008-08-19 17:55:58 +000080282008-08-19 Eric Carlson <eric.carlson@apple.com>
8029
8030 Reviewed by Adele.
8031
8032 Fix for <rdar://problem/6154695> Full-page movies flicker while playing
8033 https://bugs.webkit.org/show_bug.cgi?id=20404
8034
8035 Ignore setVisible() when visibility doesn't change.
8036
8037 * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
8038 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
8039 (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
8040 (WebCore::MediaPlayerPrivate::setVisible):
8041
timothy@apple.com9d9821a2008-08-19 17:00:26 +000080422008-08-19 Timothy Hatcher <timothy@apple.com>
8043
timothy@apple.come058a792008-08-19 17:01:12 +00008044 Fixes a bug in the Profile view where switching sort order, then
8045 switching from heavy to tree mode would show the tree in the
8046 previous sort order.
8047
8048 https://bugs.webkit.org/show_bug.cgi?id=20441
8049
8050 Reviewed by Kevin McCullough.
8051
8052 * page/inspector/ProfileView.js:
8053 (WebInspector.ProfileView.prototype._changeView): Call _sortProfile
8054 on the next profile before assigning it to this.profile.
8055 (WebInspector.ProfileView.prototype._sortData): Call _sortProfile.
8056 (WebInspector.ProfileView.prototype._sortProfile): Moves from
8057 _sortData and takes a profile argument. If the profile passed in
8058 matches the this.profile, then call refresh.
8059
80602008-08-18 Timothy Hatcher <timothy@apple.com>
8061
timothy@apple.come525e402008-08-19 17:01:00 +00008062 Changed the default sort order now that heavy view is the default.
8063 Also fixes a bug where the heavy profile was not sorted at first.
8064
8065 https://bugs.webkit.org/show_bug.cgi?id=20440
8066
8067 Reviewed by Kevin McCullough.
8068
8069 * page/inspector/ProfileView.js:
8070 (WebInspector.ProfileView): Changed the default sort column. Also assign
8071 heavyProfile to profile, so the sortSelfTimeDescending call happens
8072 on the heavy profile before assigning to this.profile.
8073
80742008-08-18 Timothy Hatcher <timothy@apple.com>
8075
timothy@apple.comc9287f32008-08-19 17:00:36 +00008076 Add support for editing DOM properties and scope variables by double
8077 clicking a property to enter edit mode.
8078
8079 https://bugs.webkit.org/show_bug.cgi?id=20415
8080
8081 Reviewed by Kevin McCullough.
8082
8083 * page/inspector/ObjectPropertiesSection.js:
8084 (WebInspector.ObjectPropertiesSection): Set editable to true by default.
8085 (WebInspector.ObjectPropertiesSection.prototype.onpopulate):
8086 Factored out code into update, and calls update.
8087 (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate.
8088 Call removeChildren since this method can be called multiple times now.
8089 (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title
8090 gets made later in onattach.
8091 (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early
8092 if shouldRefreshChildren is true. Call removeChildren since this method can be
8093 called multiple times now.
8094 (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing.
8095 (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update.
8096 (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for
8097 this element (code moved from the constructor.)
8098 (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all
8099 sibling property elements.
8100 (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call
8101 WebInspector.startEditing after rememebring some context.
8102 (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft
8103 for the list element, since it might have scrolled during editing.
8104 (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded
8105 then restore the state from the context. Then call update to restore the title.
8106 (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled
8107 if the user input and the previous input are the same. Call editingEnded, then call applyExpression
8108 to commit the user input.
8109 (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression
8110 and stores the result on the object for the property name of this element. If the expression is
8111 empty, delete the property and remove the tree element.
8112 * page/inspector/ScopeChainSidebarPane.js:
8113 (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused
8114 property on each ObjectPropertiesSection.
8115 (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach
8116 since it is now implemented.
8117 * page/inspector/ScriptsPanel.js:
8118 (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument
8119 that defaults to true if omitted. It specifies whether to call update on the scope chain.
8120 * page/inspector/inspector.css: New styles.
8121 * page/inspector/treeoutline.js:
8122 (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren
8123 change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
8124
81252008-08-18 Timothy Hatcher <timothy@apple.com>
8126
timothy@apple.com9d9821a2008-08-19 17:00:26 +00008127 Surround the expression to be evaluated in parenthesis so the
8128 result of the eval is the result of the whole expression not
8129 the last potential sub-expression. So evaluating {x: 123}
8130 will show the Object not 123.
8131
8132 https://bugs.webkit.org/show_bug.cgi?id=20428
8133
8134 Reviewed by Kevin McCullough.
8135
8136 * page/inspector/Console.js:
8137 (Console.prototype._evalInInspectedWindow): Add parenthesis
8138 around the expression. And add couple comments.
8139
kmccullough@apple.come8ac2f32008-08-19 16:38:06 +000081402008-08-19 Kevin McCullough <kmccullough@apple.com>
8141
8142 Reviewed by Geoff.
8143
8144 -Implement a page() function to extract a common code pattern.
8145
8146 * WebCore.xcodeproj/project.pbxproj:
8147 * page/Console.cpp:
8148 (WebCore::Console::addMessage):
8149 (WebCore::Console::error):
8150 (WebCore::Console::info):
8151 (WebCore::Console::log):
8152 (WebCore::Console::dir):
8153 (WebCore::Console::assertCondition):
8154 (WebCore::Console::time):
8155 (WebCore::Console::timeEnd):
8156 (WebCore::Console::group):
8157 (WebCore::Console::groupEnd):
8158 (WebCore::Console::finishedProfiling):
8159 (WebCore::Console::warn):
8160 (WebCore::Console::framePage):
8161 * page/Console.h:
8162
darin@apple.com349e1eb2008-08-19 04:39:04 +000081632008-08-12 Darin Adler <darin@apple.com>
8164
8165 Reviewed by Geoff.
8166
8167 - eliminate JSValue::type()
8168
8169 * bridge/c/c_instance.cpp:
8170 (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType
8171 argument instead of JSType argument. Removed unneeded code to handle
8172 boolean, since that's never passed.
8173 * bridge/c/c_instance.h: Ditto.
8174
8175 * bridge/c/c_utility.cpp:
8176 (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions
8177 instead of JSValue::type(). Removed unneeded code to handle
8178 "unspecified".
8179
8180 * bridge/jni/jni_instance.cpp:
8181 (JavaInstance::defaultValue): Take PreferredPrimitiveType argument
8182 instead of JSType argument. Removed unneeded code to handle boolean.
8183 * bridge/jni/jni_instance.h: Ditto.
8184
8185 * bridge/jni/jni_jsobject.mm:
8186 (JavaJSObject::convertValueToJObject): Use JSValue::is functions
8187 instead of JSValue::type().
8188
8189 * bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument
8190 instead of JSType argument. Removed unused argument.
8191 * bridge/objc/objc_instance.mm:
8192 (ObjcInstance::getValueOfUndefinedField): Removed unused argument.
8193 (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument
8194 instead of JSType argument. Removed unneeded code to handle boolean
8195 and another dead code path for unknown types.
8196
8197 * bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument
8198 instead of JSType argument. Removed override of type() that caused
8199 the fallback object to return "UndefinedType" when there is no
8200 invokeUndefinedMethodFromWebScript:withArguments: method defined.
8201 That didn't accomplish much, since most checks for undefined don't
8202 ever call type().
8203 * bridge/objc/objc_runtime.mm:
8204 (ObjcFallbackObjectImp::defaultValue): Ditto.
8205
8206 * bridge/qt/qt_instance.cpp:
8207 (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType
8208 argument instead of JSType argument. Removed unneeded code to handle
8209 boolean.
8210 * bridge/qt/qt_instance.h: Ditto.
8211
8212 * bridge/runtime.h:
8213 (KJS::Bindings::Instance::getValueOfUndefinedField): Removed
8214 unsed argument.
8215 * bridge/runtime_object.cpp:
8216 (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType
8217 argument instead of JSType argument.
8218 * bridge/runtime_object.h: Ditto.
8219
britto@apple.comaf7f8382008-08-19 00:42:13 +000082202008-08-18 Maxime Britto <britto@apple.com>
8221
8222 Reviewed by Adele.
8223
8224 <rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
8225 Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
8226 We shouldn't be able to create another window while we are in pan scrolling.
8227 Other browsers behaviors :
8228 FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
8229 IE7 : Keys are not disabled but stops immediately the panning.
8230 This patch matches FF3 behavior by disabling every key but the esc key.
8231
8232 * page/EventHandler.cpp:
8233 (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped.
8234 (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
8235
mitz@apple.com12404d82008-08-19 00:20:38 +000082362008-08-18 Dan Bernstein <mitz@apple.com>
8237
8238 Reviewed by Dave Hyatt.
8239
8240 - fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
8241
8242 Test: fast/replaced/max-width-percent.html
8243
8244 Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
8245 When false, max-width is not factored into the
8246 calculation.
8247 Changed RenderReplaced and subclasses' calcPrefWidths() to call
8248 calcReplacedWidth(false) and then apply max-width only if it has a
8249 fixed, positive value.
8250
8251 * rendering/RenderBox.cpp:
8252 (WebCore::RenderBox::calcReplacedWidth):
8253 * rendering/RenderBox.h:
8254 * rendering/RenderImage.cpp:
8255 (WebCore::RenderImage::calcReplacedWidth):
8256 (WebCore::RenderImage::calcPrefWidths):
8257 * rendering/RenderImage.h:
8258 * rendering/RenderReplaced.cpp:
8259 (WebCore::RenderReplaced::calcPrefWidths):
8260 * rendering/RenderSVGRoot.cpp:
8261 (WebCore::RenderSVGRoot::calcPrefWidths):
8262 * rendering/RenderVideo.cpp:
8263 (WebCore::RenderVideo::calcReplacedWidth):
8264 (WebCore::RenderVideo::calcPrefWidths):
8265 * rendering/RenderVideo.h:
8266
mrowe@apple.comced88732008-08-18 22:47:28 +000082672008-08-18 Daniel Macks <dmacks@netspace.org>
8268
8269 Reviewed by Mark Rowe.
8270
8271 https://bugs.webkit.org/show_bug.cgi?id=20410
8272 More portable/self-documenting replacement for SIZE_MAX.
8273
8274 * platform/network/curl/FormDataStreamCurl.cpp:
8275 (WebCore::FormDataStream::read):
8276
82772008-08-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com6040db32008-08-18 22:11:10 +00008278
8279 Reviewed by Dave Hyatt
8280
8281 Need to make sure we have an Animation in the AnimationList
8282 before setting the initial value.
8283 https://bugs.webkit.org/show_bug.cgi?id=20408
8284
8285 Test: fast/css/transition_shorthand_parsing.html
8286
8287 * css/CSSStyleSelector.cpp:
8288
kmccullough@apple.com64cb2fd2008-08-18 19:55:35 +000082892008-08-18 Kevin McCullough <kmccullough@apple.com>
8290
kmccullough@apple.com707bd362008-08-18 20:21:57 +00008291 Reviewed by Tim.
8292
8293 <rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
8294 is another profile.
8295
8296 * page/inspector/ProfilesPanel.js:
8297
82982008-08-18 Kevin McCullough <kmccullough@apple.com>
8299
kmccullough@apple.com64cb2fd2008-08-18 19:55:35 +00008300 Reviewed by Geoff.
8301
8302 <rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
8303 all console messages
8304
8305 * page/inspector/Console.js:
8306
jmalonzo@webkit.org5d1e0482008-08-18 11:20:11 +000083072008-08-18 Dirk Schulze <vbs85@gmx.de>
8308
8309 Reviewed by Eric Seidel.
8310
8311 Fixed Canvas for Cairo. Stroke and fill colors didn't work after
8312 the canvas clean up.
8313
8314 https://bugs.webkit.org/show_bug.cgi?id=20405
8315
8316 * html/CanvasRenderingContext2D.cpp:
8317 (WebCore::CanvasRenderingContext2D::fill):
8318 (WebCore::CanvasRenderingContext2D::stroke):
8319 (WebCore::CanvasRenderingContext2D::fillRect):
8320
timothy@apple.comc5e1f8d2008-08-18 03:21:46 +000083212008-08-17 Timothy Hatcher <timothy@apple.com>
8322
8323 Complete in scope variables in the Console when paused.
8324
8325 https://bugs.webkit.org/show_bug.cgi?id=19115
8326
8327 Reviewed by Geoffrey Garen.
8328
8329 * page/inspector/Console.js:
8330 (WebInspector.Console.prototype.completions): If the expressionString
8331 is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame
8332 to get an object that declares all the in scope variables. That way
8333 "top level" expressions are completed.
8334 * page/inspector/ScriptsPanel.js:
8335 (WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame):
8336 Return an object that has all the variables that are in scope for the
8337 selected call frame. The value of each property is just true.
8338 The return object is useful for quick lookups or auto completion.
8339
cwzwarich@webkit.orgac715282008-08-17 21:34:46 +000083402008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
8341
8342 Not reviewed.
8343
8344 Speculative Qt build fix.
8345
8346 * bridge/qt/qt_runtime.cpp:
8347 (KJS::Bindings::convertValueToQVariant):
8348 (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
8349
ggaren@apple.comfea43532008-08-17 20:23:49 +000083502008-08-17 Geoffrey Garen <ggaren@apple.com>
8351
8352 Reviewed by Cameron Zwarich.
ggaren@apple.com6e53d0a2008-08-17 20:28:37 +00008353
8354 Updated project files to XCode 3.1.
8355
8356 * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
8357
83582008-08-17 Geoffrey Garen <ggaren@apple.com>
8359
8360 Reviewed by Cameron Zwarich.
ggaren@apple.comfea43532008-08-17 20:23:49 +00008361
8362 Made room for a free word in JSCell.
8363
8364 Changed JSDOMWindowBase to store its auxiliary data in a subclass of
8365 JSGlobalData, so the two could share a pointer.
8366
8367 Added a bunch of ASSERTs, to help catch over-sized objects.
8368
mrowe@apple.com13570292008-08-16 06:48:10 +000083692008-08-15 Mark Rowe <mrowe@apple.com>
8370
mitz@apple.comb96c1b92008-08-17 03:28:52 +00008371 Reviewed by Dan Bernstein.
8372
8373 Disable dead code stripping in debug builds.
8374
8375 * Configurations/Base.xcconfig:
8376 * WebCore.xcodeproj/project.pbxproj:
8377
83782008-08-15 Mark Rowe <mrowe@apple.com>
8379
mrowe@apple.com13570292008-08-16 06:48:10 +00008380 Rubber-stamped by Geoff Garen.
8381
8382 <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
8383
8384 * Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared
8385 between the Debug configuration and debug Production variant.
8386 * WebCore.xcodeproj/project.pbxproj: Enable the debug variant.
8387
antti@apple.coma05e8b02008-08-15 22:58:06 +000083882008-08-15 Antti Koivisto <antti@apple.com>
8389
8390 Reviewed by Anders.
8391
8392 Don't start preloading body resources before the head is complete. This prevents
8393 body preloads from slowing down initial display when there is limited amount
8394 of bandwidth available.
8395
8396 Works by queuing up found body preloads to DocLoader and only issuing them
8397 after document has rendering.
8398
8399 With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
8400 without affecting complete load time.
8401
8402 * html/PreloadScanner.cpp:
8403 (WebCore::PreloadScanner::PreloadScanner):
8404 (WebCore::PreloadScanner::scanningBody):
8405 (WebCore::PreloadScanner::emitTag):
8406 (WebCore::PreloadScanner::emitCSSRule):
8407 * html/PreloadScanner.h:
8408 * loader/DocLoader.cpp:
8409 (WebCore::DocLoader::preload):
8410 (WebCore::DocLoader::checkForPendingPreloads):
8411 (WebCore::DocLoader::requestPreload):
8412 * loader/DocLoader.h:
8413 * loader/loader.cpp:
8414 (WebCore::Loader::Host::didFinishLoading):
8415 (WebCore::Loader::Host::didFail):
8416
adachan@apple.com94ac38d2008-08-15 21:08:40 +000084172008-08-15 Ada Chan <adachan@apple.com>
8418
8419 Use item's computed style if the render style is 0 before falling back to the <select>'s style.
8420 This way style set on an <hr> within a <select> will be honored.
8421
8422 Reviewed by Dave Hyatt and Dan Bernstein.
8423
8424 * rendering/RenderMenuList.cpp:
8425 (WebCore::RenderMenuList::itemStyle):
8426
antti@apple.com9f7911472008-08-15 20:48:06 +000084272008-08-15 Antti Koivisto <antti@apple.com>
8428
8429 Reviewed by Oliver.
8430
8431 Some loader performance tweaks:
8432 - Make stylesheets highest priority instead of scripts. We block script execution on stylesheets.
8433 Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue
8434 to not delay rendering.
8435 - Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup
8436 can take long time when latency is high so it is good to get started early.
8437 - When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the
8438 load queues. Issue remaining loads to the network layer.
8439
8440 * loader/loader.cpp:
8441 (WebCore::Loader::determinePriority):
8442 (WebCore::Loader::load):
8443 (WebCore::Loader::Host::servePendingRequests):
8444 * loader/loader.h:
8445
timothy@apple.com2d974c32008-08-15 18:35:39 +000084462008-08-15 Timothy Hatcher <timothy@apple.com>
8447
8448 Detach the script debugger when the Web Inspector's window closes.
8449 This has always been the intended design, but never fully implemented.
8450
8451 https://bugs.webkit.org/show_bug.cgi?id=20402
8452
8453 Reviewed by Adam Roben.
8454
8455 * page/InspectorController.cpp:
8456 (WebCore::InspectorController::setWindowVisible): Call stopDebugging()
8457 if the window is no longer visible.
8458
hausmann@webkit.orgbb4b9142008-08-15 18:11:34 +000084592008-08-15 HÃ¥vard Wall <hwall@trolltech.com>
8460
8461 Reviewed by Simon.
8462
hausmann@webkit.org58144a72008-08-15 18:12:08 +00008463 Fixes: compile with QT_NO_CONTEXTMENU
8464
8465 * platform/qt/PlatformMouseEventQt.cpp:
8466 (WebCore::PlatformMouseEvent::PlatformMouseEvent):
8467 * platform/qt/PlatformScrollBarQt.cpp:
8468 (WebCore::PlatformScrollbar::handleMouseMoveEvent):
8469 (WebCore::PlatformScrollbar::handleContextMenuEvent):
8470
84712008-08-15 HÃ¥vard Wall <hwall@trolltech.com>
8472
8473 Reviewed by Simon.
8474
hausmann@webkit.orgbb4b9142008-08-15 18:11:34 +00008475 Fixes: compile with QT_NO_WHEELEVENT
8476
8477 * platform/qt/WheelEventQt.cpp:
8478 (WebCore::PlatformWheelEvent::PlatformWheelEvent):
8479
timothy@apple.com4889e612008-08-15 17:06:14 +000084802008-08-15 Keishi Hattori <casey.hattori@gmail.com>
8481
timothy@apple.comd64639c2008-08-15 17:48:36 +00008482 Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector
8483
8484 https://bugs.webkit.org/show_bug.cgi?id=20210
8485
8486 Reviewed by Tim Hatcher.
8487
8488 * page/Console.cpp:
8489 (WebCore::Console::group):
8490 (WebCore::Console::groupEnd):
8491 * page/Console.h:
8492 (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
8493 * page/InspectorController.cpp:
8494 (WebCore::InspectorController::startGroup): Increments group level by
8495 one and adds console message with StartGroupMessaageLevel.
8496 (WebCore::InspectorController::endGroup): Decrements group level by one
8497 and adds console message with EndGroupMessaageLevel.
8498 * page/InspectorController.h:
8499 * page/inspector/Console.js:
8500 (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup
8501 if the message is StartGroupMessaageLevel.
8502 (WebInspector.ConsoleMessage.prototype.toMessageElement):
8503 (WebInspector.ConsoleGroup.prototype.addMessage):
8504 * page/inspector/inspector.js:
8505
85062008-08-15 Keishi Hattori <casey.hattori@gmail.com>
8507
timothy@apple.com7310b6a2008-08-15 17:35:22 +00008508 Adds support for console.dir to the Inspector
8509
8510 https://bugs.webkit.org/show_bug.cgi?id=19155
8511
8512 Reviewed by Tim Hatcher.
8513
8514 * bindings/js/JSConsoleCustom.cpp:
8515 (WebCore::JSConsole::dir):
8516 * page/Console.cpp:
8517 (WebCore::Console::dir):
8518 * page/Console.h: Added ObjectMessageLevel.
8519 * page/Console.idl: Added console.dir.
8520 * page/inspector/Console.js:
8521 (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an
8522 ObjectPropertiesSection if the MessageLevel is Object.
8523 * page/inspector/ObjectPropertiesSection.js: "in" operator can't be
8524 used on primitive data types.
8525 * page/inspector/inspector.css:
8526
85272008-08-15 Keishi Hattori <casey.hattori@gmail.com>
8528
timothy@apple.com4889e612008-08-15 17:06:14 +00008529 Adds support for clear() in the Inspector console.
8530
8531 https://bugs.webkit.org/show_bug.cgi?id=19873
8532
8533 Reviewed by Tim Hatcher.
8534
8535 * page/inspector/Console.js:
8536
timothy@apple.com12c5b5d2008-08-15 17:02:44 +000085372008-08-15 Anthony Ricaud <rik24d@gmail.com>
8538
8539 Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
8540
8541 Platform distinction and modifier key matching adjusted
8542 by Daniel Jalkut <jalkut@red-sweater.com>
8543
8544 Bug 16313: text search (find) keybindings should work in the Web Inspector
8545 https://bugs.webkit.org/show_bug.cgi?id=16313
8546
8547 Reviewed by Tim Hatcher.
8548
8549 * page/inspector/inspector.js: Added a case for the F key
8550
timothy@apple.coma5ba4392008-08-15 16:50:26 +000085512008-08-15 Keishi Hattori <casey.hattori@gmail.com>
8552
8553 Fix for error when the string doesn't contain a webkit-profile link.
8554
8555 https://bugs.webkit.org/show_bug.cgi?id=20399
8556
8557 Reviewed by Tim Hatcher.
8558
8559 * page/inspector/inspector.js:
8560
timothy@apple.com895b2652008-08-15 16:33:27 +000085612008-08-15 Timothy Hatcher <timothy@apple.com>
8562
8563 Fixes two bugs where JavaScript could be executed from the page
8564 while the debugger is paused.
8565
8566 The first issue was JSLazyEventListener not checking the paused
8567 state before parsing the code.
8568
8569 The second issue was with the PageGroup version of
8570 JavaScriptDebugServer::setJavaScriptPaused always passing false
8571 to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
8572 and not the paused argument.
8573
8574 https://bugs.webkit.org/show_bug.cgi?id=20284
8575
8576 Reviewed by Adam Roben.
8577
8578 * bindings/js/JSEventListener.cpp:
8579 (WebCore::JSLazyEventListener::parseCode): Check the paused
8580 state of the ScriptController. Return early if paused.
8581 * manual-tests/inspector/debugger-execution-while-paused.html: Added.
8582 * page/JavaScriptDebugServer.cpp:
8583 (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
8584 Pass the paused argument to the Page version of setJavaScriptPaused.
8585
ap@webkit.orgbe495d32008-08-15 07:43:48 +000085862008-08-15 Alexey Proskuryakov <ap@webkit.org>
8587
8588 Reviewed by Geoff Garen.
8589
8590 JSStringRef is created context-free, but can get linked to one via an identifier table,
8591 breaking an implicit API contract.
8592
8593 * page/InspectorController.cpp:
8594 (WebCore::jsStringRef):
8595 (WebCore::InspectorController::didParseSource):
8596 (WebCore::InspectorController::failedToParseSource):
8597 * page/JavaScriptProfile.cpp:
8598 (WebCore::getTitleCallback):
8599 Updated for JavaScriptCore changes.
8600
kevino@webkit.org8fe09ff2008-08-15 05:10:57 +000086012008-08-14 Kevin Ollivier <kevino@theolliviers.com>
8602
8603 wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with
8604 an alternative that performs reasonably well. (GDI+ is too slow in many cases.)
8605
8606 * platform/graphics/AffineTransform.h:
8607
adele@apple.com2b2e2f82008-08-15 00:53:36 +000086082008-08-14 Eric Carlson <eric.carlson@apple.com>
8609
8610 Reviewed by Adele.
8611
8612 Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
8613 <video> elements on Windows never becomes visible when a page is restored from the cache
8614
8615 Always pass "set" calls down to MediaPlayerPrivate instead of only when the
8616 value is different from the cached value. Let the implementation decide when
8617 to avoid work because nothing has changed.
8618
8619 * platform/graphics/MediaPlayer.cpp:
8620 (WebCore::MediaPlayer::setVolume):
8621 (WebCore::MediaPlayer::setRate):
8622 (WebCore::MediaPlayer::setRect):
8623 (WebCore::MediaPlayer::setVisible):
8624
timothy@apple.comda810f42008-08-14 23:57:14 +000086252008-08-14 Keishi Hattori <casey.hattori@gmail.com>
8626
8627 Make Firebug command line API respect predefined variables.
8628
timothy@apple.com90751f02008-08-14 23:58:19 +00008629 https://bugs.webkit.org/show_bug.cgi?id=20385
8630
timothy@apple.comda810f42008-08-14 23:57:14 +00008631 Reviewed by Tim Hatcher.
8632
8633 * page/inspector/Console.js:
8634
weinig@apple.com4b51d002008-08-14 23:33:22 +000086352008-08-14 Sam Weinig <sam@webkit.org>
8636
8637 Reviewed by Geoffrey Garen and Timothy Hatcher.
8638
8639 Allow programatically setting the HTMLTokenizers time delay and chunk size
8640 which are used for determining how aggressively we yield.
8641
8642 * WebCore.base.exp:
8643 * html/HTMLTokenizer.cpp:
8644 (WebCore::HTMLTokenizer::begin):
8645 (WebCore::HTMLTokenizer::continueProcessing):
8646 * html/HTMLTokenizer.h:
8647 * page/Page.cpp:
8648 (WebCore::Page::Page):
8649 (WebCore::Page::setCustomHTMLTokenizerTimeDelay):
8650 (WebCore::Page::setCustomHTMLTokenizerChunkSize):
8651 * page/Page.h:
8652 (WebCore::Page::hasCustomHTMLTokenizerTimeDelay):
8653 (WebCore::Page::customHTMLTokenizerTimeDelay):
8654 (WebCore::Page::hasCustomHTMLTokenizerChunkSize):
8655 (WebCore::Page::customHTMLTokenizerChunkSize):
8656
eric@webkit.org89613d22008-08-14 23:19:17 +000086572008-08-14 Eric Seidel <eric@webkit.org>
8658
eric@webkit.org7e897c32008-08-14 23:20:00 +00008659 Reviewed by Beth.
8660
8661 Move us one step closer to cross-platform svg/graphics code
8662
8663 * WebCore.xcodeproj/project.pbxproj:
8664 * html/CanvasStyle.cpp:
8665 * platform/graphics/Color.cpp:
8666 (WebCore::colorWithOverrideAlpha):
8667 * platform/graphics/Color.h:
8668 * svg/graphics/cg/CgSupport.cpp:
8669 (WebCore::applyStrokeStyleToContext):
8670 (WebCore::strokeBoundingBox):
8671 * svg/graphics/cg/SVGPaintServerSolidCg.cpp:
8672 (WebCore::SVGPaintServerSolid::setup):
8673
86742008-08-14 Eric Seidel <eric@webkit.org>
8675
eric@webkit.org4f490652008-08-14 23:19:31 +00008676 Reviewed by Alexey.
8677
eric@webkit.org73fa9d12008-08-14 23:19:44 +00008678 Remove un-need includes from HTMLCanvas and use the
8679 Gradient platform abstraction in one place in CanvasStyle
8680
8681 * html/CanvasRenderingContext2D.cpp:
8682 (WebCore::CanvasRenderingContext2D::fillRect):
8683 * html/CanvasStyle.cpp:
8684 * html/HTMLCanvasElement.cpp:
8685
86862008-08-14 Eric Seidel <eric@webkit.org>
8687
8688 Reviewed by Alexey.
8689
eric@webkit.org4f490652008-08-14 23:19:31 +00008690 Clean up GlyphBuffer.h, removing more #ifdefs
8691
8692 * platform/graphics/GlyphBuffer.h:
8693 (WebCore::GlyphBuffer::glyphAt):
8694 (WebCore::GlyphBuffer::advanceAt):
8695 (WebCore::GlyphBuffer::add):
8696
86972008-08-14 Eric Seidel <eric@webkit.org>
8698
eric@webkit.org89613d22008-08-14 23:19:17 +00008699 Reviewed by Sam.
8700
8701 Clean up AffineTransform.h, removing #ifdefs
8702
8703 * platform/graphics/AffineTransform.h:
8704 * platform/graphics/cairo/AffineTransformCairo.cpp:
8705 * platform/graphics/cg/AffineTransformCG.cpp:
8706 * platform/graphics/qt/AffineTransformQt.cpp:
8707 * platform/graphics/wx/AffineTransformWx.cpp:
8708
mitz@apple.com551d6252008-08-14 23:08:09 +000087092008-08-14 Dan Bernstein <mitz@apple.com>
8710
mitz@apple.com94c1a7d2008-08-14 23:12:34 +00008711 - fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
8712
8713 * platform/graphics/cairo/ImageSourceCairo.cpp:
8714 (WebCore::ImageSource::frameSizeAtIndex):
8715 * platform/graphics/qt/ImageSourceQt.cpp:
8716 (WebCore::ImageSource::frameSizeAtIndex):
8717 * platform/graphics/wx/ImageSourceWx.cpp:
8718 (WebCore::ImageSource::frameSizeAtIndex):
8719
87202008-08-14 Dan Bernstein <mitz@apple.com>
8721
mitz@apple.com551d6252008-08-14 23:08:09 +00008722 Reviewed by Brady Eidson.
8723
8724 - fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
8725
8726 * platform/graphics/BitmapImage.cpp:
8727 (WebCore::BitmapImage::BitmapImage): Added initialization of
8728 m_hasUniformFrameSize.
8729 (WebCore::BitmapImage::cacheFrame): Added code to get the size of the
8730 cached frame for use in decoded size computation and for setting
8731 m_hasUniformFrameSize.
8732 (WebCore::BitmapImage::currentFrameSize): Added.
8733 (WebCore::BitmapImage::dataChanged): Added code to reset
8734 m_hasUniformFrameSize.
8735 * platform/graphics/BitmapImage.h: Added currentFrameSize() and
8736 m_hasUniformFrameSize.
8737 * platform/graphics/ImageSource.h: Added frameSizeAtIndex().
8738 * platform/graphics/cg/ImageCG.cpp:
8739 (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This
8740 fixes the bug, which resulted from assuming that the frame being drawn
8741 was the same size as the first frame.
8742 * platform/graphics/cg/ImageSourceCG.cpp:
8743 (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and
8744 changed to get the size of the frame at the given index.
8745 (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
8746
simon.fraser@apple.com50954e52008-08-14 23:04:41 +000087472008-08-13 Simon Fraser <simon.fraser@apple.com>
8748
8749 Reviewed by Eric Seidel
8750
8751 Fix @font-face inside @media rule crash.
8752 https://bugs.webkit.org/show_bug.cgi?id=20367
8753
8754 Test: fast/css/font-face-in-media-rule.html
8755
8756 * css/CSSStyleSelector.cpp:
8757 (WebCore::CSSRuleSet::addRulesFromSheet):
8758
kevino@webkit.org141c4602008-08-14 22:52:55 +000087592008-08-14 Kevin Ollivier <kevino@theolliviers.com>
8760
8761 wx build fixes after recent changes to Canvas and Image classes.
8762
8763 * platform/graphics/Pattern.h:
8764 * platform/graphics/wx/GradientWx.cpp:
8765 (WebCore::Gradient::fill):
8766 * platform/graphics/wx/GraphicsContextWx.cpp:
8767 (WebCore::GraphicsContext::applyFillPattern):
8768 (WebCore::GraphicsContext::applyStrokePattern):
8769 * platform/graphics/wx/ImageBufferWx.cpp:
8770 (WebCore::ImageBuffer::image):
8771 * platform/graphics/wx/ImageWx.cpp:
8772 (WebCore::Image::loadPlatformResource):
8773
britto@apple.comd7008662008-08-14 19:26:02 +000087742008-08-14 Maxime Britto <britto@apple.com>
8775
8776 Reviewed by Sam Weinig.
8777
8778 rdar://6102511
8779 When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
8780 IE and FF are both preventing the keyboard event to interact with the page while scrolling.
8781 Some differences exist between them concerning the kind of key which is pressed :
8782 IE7 : every key leads to a stop of the panning
8783 FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
8784 For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.
8785
8786 * page/EventHandler.cpp:
8787 (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
8788
christian@webkit.org0e20f322008-08-14 19:14:47 +000087892008-08-14 Christian Dywan <christian@twotoasts.de>
8790
8791 Gtk+/ Cairo build fix, patch by Dirk Schulze.
8792
8793 * html/CanvasStyle.cpp:
8794 * platform/graphics/cairo/PatternCairo.cpp:
8795 (WebCore::Pattern::createPlatformPattern):
8796 * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
8797
kmccullough@apple.comd2b50f12008-08-14 18:11:20 +000087982008-08-14 Kevin McCullough <kmccullough@apple.com>
8799
8800 Reviewed by Tim.
8801
8802 <rdar://problem/6115819> Notify of profile in console
8803
8804 * page/InspectorController.cpp:
8805 (WebCore::InspectorController::addProfile):
8806 (WebCore::InspectorController::addProfileMessageToConsole): Called by
8807 addProfile this is the function that adds a message to the console that
8808 a profile finished.
8809 * page/InspectorController.h:
8810 * page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match
8811 the console log to the profile in the web inspector.
8812 (WebCore::getUniqueIdCallback):
8813 (WebCore::ProfileClass):
8814 * page/inspector/ProfilesPanel.js: Created a map of all the profiles by
8815 Id to bring up the requested profile. Also select and reveal the
8816 profile in the profile panel. And created displayTitleForProfileLink()
8817 which formats a title taking into account if it's user initiated or if
8818 there are multiples. Lasty, I put the user initiated profile in a
8819 variable.
8820 * page/inspector/inspector.js: Make the profile title be a clickable
8821 link that will take the user to the identified profile. Also expose
8822 the count of user initiated profiles so they can be displayed in the
8823 console with the correct count.
8824
timothy@apple.comcd7f0f32008-08-14 17:41:05 +000088252008-08-14 Timothy Hatcher <timothy@apple.com>
8826
8827 Avoid formating ConsoleMessages twice unless the message will be
8828 displayed in bubbles of a SourceFrame.
8829
8830 Reviewed by Kevin McCullough.
8831
8832 * page/inspector/Console.js:
8833 (WebInspector.ConsoleMessage): Only format the plain text message
8834 if the URL and line are valid and the level is error or warning.
8835 (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added.
8836 Helper to test for error or warning level.
8837 * page/inspector/SourceFrame.js:
8838 (WebInspector.SourceFrame.prototype.addMessage): Don't add the
8839 message if there is no message or valid line or if the msg
8840 isn't an error or warning.
8841
jmalonzo@webkit.orgb469bb72008-08-14 15:07:41 +000088422008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
8843
8844 partial Gtk build fix, not reviewed
8845
8846 * platform/graphics/cairo/PatternCairo.cpp:
8847
weinig@apple.com45e83142008-08-14 04:49:30 +000088482008-08-13 Sam Weinig <sam@webkit.org>
8849
8850 Reviewed by Anders Carlson.
8851
8852 Fix style issue.
8853
8854 * html/HTMLMediaElement.cpp:
8855 (WebCore::HTMLMediaElement::pickMedia):
8856
zimmermann@webkit.org9ae47e92008-08-14 02:22:35 +000088572008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
8858
zimmermann@webkit.org7a2f53d2008-08-14 03:06:01 +00008859 Build fix for Cairo, not reviewed. (exposed by gtk build slave)
8860 Continue Erics build fixes, after the Image cleanup.
8861
8862 * platform/graphics/cairo/ImageBufferCairo.cpp:
8863 (WebCore::ImageBuffer::image):
8864
88652008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
8866
zimmermann@webkit.org1ef52132008-08-14 02:38:16 +00008867 Build fix for Qt, not reviewed.
8868 Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.
8869
8870 * dom/XMLTokenizer.cpp:
8871 (WebCore::eventuallyMarkAsParserCreated): Was erre
8872
88732008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
8874
zimmermann@webkit.org3e560562008-08-14 02:26:00 +00008875 Build fix, not reviewed.
8876 Add ScriptElement.cpp to Gtk build.
8877
8878 * GNUmakefile.am:
8879
88802008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
8881
zimmermann@webkit.org9ae47e92008-08-14 02:22:35 +00008882 Reviewed by Eric.
8883
8884 Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
8885
8886 Refactor HTMLScriptElement's code into a common base class: ScriptElement.
8887 SVGScriptElement will be converted to use ScriptElement in a follow-up patch.
8888
8889 This resolves code duplications and allows us to completly replace the old
8890 SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)
8891
8892 As ScriptElement, doesn't actually inherit from Element, we may want to rename
8893 it, though StyleElement uses the same naming convention, so I left it as is for now.
8894 Eventually we'll rename both files in future.
8895
8896 No functional changes yet, as SVGScriptElement doesn't yet use the new base class.
8897
8898 * WebCore.pro: Add new ScriptElement.cpp to build.
8899 * WebCore.vcproj/WebCore.vcproj: Ditto.
8900 * WebCore.xcodeproj/project.pbxproj: Ditto.
8901 * WebCoreSources.bkl: Dutto.
8902 * dom/ScriptElement.cpp: Added. 1:1 based on HTMLScriptElement
8903 (WebCore::ScriptElement::insertedIntoDocument):
8904 (WebCore::ScriptElement::removedFromDocument):
8905 (WebCore::ScriptElement::childrenChanged):
8906 (WebCore::ScriptElement::finishParsingChildren):
8907 (WebCore::ScriptElement::handleSourceAttribute):
8908 (WebCore::isSupportedJavaScriptLanguage):
8909 (WebCore::ScriptElementData::ScriptElementData):
8910 (WebCore::ScriptElementData::~ScriptElementData):
8911 (WebCore::ScriptElementData::requestScript):
8912 (WebCore::ScriptElementData::evaluateScript):
8913 (WebCore::ScriptElementData::stopLoadRequest):
8914 (WebCore::ScriptElementData::notifyFinished):
8915 (WebCore::ScriptElementData::ignoresLoadRequest):
8916 (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
8917 (WebCore::ScriptElementData::scriptCharset):
8918 (WebCore::ScriptElementData::scriptContent):
8919 * dom/ScriptElement.h: Added.
8920 (WebCore::ScriptElement::ScriptElement):
8921 (WebCore::ScriptElement::~ScriptElement):
8922 (WebCore::ScriptElementData::element):
8923 (WebCore::ScriptElementData::createdByParser):
8924 (WebCore::ScriptElementData::setCreatedByParser):
8925 * dom/XMLTokenizer.cpp:
8926 (WebCore::isScriptElement):
8927 (WebCore::castToScriptElement):
8928 (WebCore::eventuallyMarkAsParserCreated):
8929 (WebCore::XMLTokenizer::startElementNs):
8930 (WebCore::XMLTokenizer::endElementNs):
8931 (WebCore::createXHTMLParserErrorHeader):
8932 (WebCore::XMLTokenizer::insertErrorMessageBlock):
8933 * html/HTMLScriptElement.cpp: Refactored code, pushed most code down to ScriptElement.
8934 (WebCore::HTMLScriptElement::HTMLScriptElement):
8935 (WebCore::HTMLScriptElement::~HTMLScriptElement):
8936 (WebCore::HTMLScriptElement::isURLAttribute):
8937 (WebCore::HTMLScriptElement::setCreatedByParser):
8938 (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
8939 (WebCore::HTMLScriptElement::childrenChanged):
8940 (WebCore::HTMLScriptElement::parseMappedAttribute):
8941 (WebCore::HTMLScriptElement::finishParsingChildren):
8942 (WebCore::HTMLScriptElement::insertedIntoDocument):
8943 (WebCore::HTMLScriptElement::removedFromDocument):
8944 (WebCore::HTMLScriptElement::text):
8945 (WebCore::HTMLScriptElement::setText):
8946 (WebCore::HTMLScriptElement::setHtmlFor):
8947 (WebCore::HTMLScriptElement::setEvent):
8948 (WebCore::HTMLScriptElement::charset):
8949 (WebCore::HTMLScriptElement::src):
8950 (WebCore::HTMLScriptElement::type):
8951 (WebCore::HTMLScriptElement::scriptCharset):
8952 (WebCore::HTMLScriptElement::scriptContent):
8953 (WebCore::HTMLScriptElement::sourceAttributeValue):
8954 (WebCore::HTMLScriptElement::charsetAttributeValue):
8955 (WebCore::HTMLScriptElement::typeAttributeValue):
8956 (WebCore::HTMLScriptElement::languageAttributeValue):
8957 (WebCore::HTMLScriptElement::dispatchLoadEvent):
8958 (WebCore::HTMLScriptElement::dispatchErrorEvent):
8959 * html/HTMLScriptElement.h:
8960 * svg/SVGScriptElement.cpp: Inherit from ScriptElement, don't actually use it yet.
8961 * svg/SVGScriptElement.cpp:
8962 (WebCore::SVGScriptElement::SVGScriptElement):
8963 (WebCore::SVGScriptElement::scriptContent):
8964 (WebCore::SVGScriptElement::sourceAttributeValue):
8965 (WebCore::SVGScriptElement::charsetAttributeValue):
8966 (WebCore::SVGScriptElement::typeAttributeValue):
8967 (WebCore::SVGScriptElement::languageAttributeValue):
8968 (WebCore::SVGScriptElement::dispatchLoadEvent):
8969 (WebCore::SVGScriptElement::dispatchErrorEvent):
8970 * svg/SVGScriptElement.h:
8971 (WebCore::SVGScriptElement::setCreatedByParser):
8972
eric@webkit.org7811ef02008-08-14 00:28:51 +000089732008-08-13 Eric Seidel <eric@webkit.org>
8974
eric@webkit.org3562c592008-08-14 02:17:29 +00008975 Attempt to fix the Gtk build, no review.
8976
8977 I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.
8978
8979 * platform/graphics/GraphicsContext.h:
8980 * platform/graphics/cairo/GraphicsContextCairo.cpp:
8981 * platform/graphics/qt/GradientQt.cpp:
8982 * platform/graphics/qt/GraphicsContextQt.cpp:
8983 * platform/gtk/RenderThemeGtk.cpp:
8984 (WebCore::paintMozWidget):
8985
89862008-08-13 Eric Seidel <eric@webkit.org>
8987
eric@webkit.org2ec42072008-08-14 02:03:09 +00008988 Yet another attempt to fix the Qt build, no review.
8989
8990 * platform/graphics/qt/GradientQt.cpp:
8991 * platform/graphics/qt/GraphicsContextQt.cpp:
8992 (WebCore::GraphicsContext::applyStrokePattern):
8993 (WebCore::GraphicsContext::applyFillPattern):
8994
89952008-08-13 Eric Seidel <eric@webkit.org>
8996
8997 Attempt to fix the Windows build, no review.
8998
8999 * platform/win/CursorWin.cpp:
9000 (WebCore::loadCursorByName):
9001 * platform/win/ScrollViewWin.cpp:
9002 (WebCore::ScrollView::paint):
9003
90042008-08-13 Eric Seidel <eric@webkit.org>
9005
eric@webkit.org508c0282008-08-14 01:29:34 +00009006 Attempt to fix the Windows build, no review.
9007
9008 * platform/win/CursorWin.cpp:
9009 (WebCore::loadCursorByName):
9010 * platform/win/ScrollViewWin.cpp:
9011 (WebCore::ScrollView::paint):
9012
90132008-08-13 Eric Seidel <eric@webkit.org>
9014
eric@webkit.org1bf70ab2008-08-14 01:24:15 +00009015 Attempt to fix the Qt build, no review.
9016
9017 * platform/graphics/qt/ImageBufferQt.cpp:
9018 (WebCore::ImageBuffer::image):
9019
90202008-08-13 Eric Seidel <eric@webkit.org>
9021
eric@webkit.orgf2d7c212008-08-14 01:21:34 +00009022 Attempt to fix the Windows build, no review.
9023
9024 * platform/graphics/win/ImageWin.cpp:
9025 (WebCore::Image::loadPlatformResource):
9026 * plugins/win/PluginViewWin.cpp:
9027 (WebCore::PluginView::paintMissingPluginIcon):
9028
90292008-08-13 Eric Seidel <eric@webkit.org>
9030
eric@webkit.orgac3f6662008-08-14 01:15:50 +00009031 Another attempt to fix the Qt build, no review.
9032
9033 * platform/graphics/qt/ImageQt.cpp:
9034 * platform/graphics/qt/StillImageQt.h:
9035
90362008-08-13 Eric Seidel <eric@webkit.org>
9037
eric@webkit.org31e0d812008-08-14 01:05:42 +00009038 No review, build fix only.
9039
9040 Fix mac build, due to change in new code since my patch was written.
9041
9042 * svg/graphics/cg/SVGResourceMaskerCg.mm:
9043 (WebCore::SVGResourceMasker::applyMask):
9044
90452008-08-13 Eric Seidel <eric@webkit.org>
9046
eric@webkit.orga20a0032008-08-14 00:42:54 +00009047 Build fix only, no review.
9048
9049 Attempt to fix the Qt build.
9050
eric@webkit.org923255c2008-08-14 00:59:20 +00009051 * platform/graphics/qt/ImageBufferQt.cpp:
9052 * platform/graphics/qt/StillImageQt.h:
9053 (WebCore::StillImage::create):
9054 (WebCore::StillImage::destroyDecodedData):
9055 (WebCore::StillImage::decodedSize):
9056
90572008-08-13 Eric Seidel <eric@webkit.org>
9058
9059 Build fix only, no review.
9060
9061 Attempt to fix the Qt build.
9062
eric@webkit.orga20a0032008-08-14 00:42:54 +00009063 * html/CanvasStyle.cpp:
9064 (WebCore::CanvasStyle::applyStrokeColor):
9065 (WebCore::CanvasStyle::applyFillColor):
9066
90672008-08-13 Eric Seidel <eric@webkit.org>
9068
eric@webkit.org4aca3be2008-08-14 00:30:04 +00009069 Reviewed by Sam.
9070
9071 Match HTML5 spec by throwing INVALID_STATE_ERR when
9072 createPattern is called and the HTMLImageElement is not
9073 yet done loading the image (!isComplete)
9074 https://bugs.webkit.org/show_bug.cgi?id=20351
9075
9076 Test: http/misc/canvas-pattern-from-incremental-image.html
9077
9078 * html/CanvasRenderingContext2D.cpp:
9079 (WebCore::CanvasRenderingContext2D::createPattern):
9080
90812008-08-13 Eric Seidel <eric@webkit.org>
9082
eric@webkit.org5b265602008-08-14 00:29:26 +00009083 Reviewed by Niko.
9084
eric@webkit.orgf0124f62008-08-14 00:29:50 +00009085 Split out a Pattern class from CanvasPattern
9086 and remove all the Pattern-related #ifdefs
9087 (This will break non-mac platforms! I will fix them.)
9088 https://bugs.webkit.org/show_bug.cgi?id=20351
9089
9090 * GNUmakefile.am:
9091 * WebCore.pro:
9092 * WebCore.vcproj/WebCore.vcproj:
9093 * WebCore.xcodeproj/project.pbxproj:
9094 * WebCoreSources.bkl:
9095 * html/CanvasPattern.cpp:
9096 (WebCore::CanvasPattern::parseRepetitionType):
9097 (WebCore::CanvasPattern::CanvasPattern):
9098 * html/CanvasPattern.h:
9099 (WebCore::CanvasPattern::create):
9100 (WebCore::CanvasPattern::pattern):
9101 (WebCore::CanvasPattern::originClean):
9102 * html/CanvasRenderingContext2D.cpp:
9103 (WebCore::CanvasRenderingContext2D::createPattern):
9104 (WebCore::CanvasRenderingContext2D::applyStrokePattern):
9105 (WebCore::CanvasRenderingContext2D::applyFillPattern):
9106 * html/CanvasRenderingContext2D.h:
9107 * html/HTMLCanvasElement.cpp:
9108 * html/HTMLCanvasElement.h:
9109 * loader/FrameLoader.cpp:
9110 (WebCore::FrameLoader::createHistoryItem):
9111 * platform/graphics/GraphicsContext.h:
9112 * platform/graphics/cairo/GraphicsContextCairo.cpp:
9113 (WebCore::GraphicsContext::applyStrokePattern):
9114 (WebCore::GraphicsContext::applyFillPattern):
9115 * platform/graphics/cg/GraphicsContextCG.cpp:
9116 (WebCore::GraphicsContext::clipToImageBuffer):
9117 (WebCore::GraphicsContext::applyStrokePattern):
9118 (WebCore::GraphicsContext::applyFillPattern):
9119
91202008-08-13 Eric Seidel <eric@webkit.org>
9121
9122 Reviewed by Niko.
9123
eric@webkit.org5b265602008-08-14 00:29:26 +00009124 Make Images RefCounted (and clean up callers)
9125 https://bugs.webkit.org/show_bug.cgi?id=20351
9126
9127 * editing/DeleteButtonController.cpp:
9128 (WebCore::DeleteButtonController::createDeletionUI):
9129 * loader/CachedImage.cpp:
9130 (WebCore::CachedImage::CachedImage):
9131 (WebCore::brokenImage):
9132 (WebCore::nullImage):
9133 (WebCore::CachedImage::image):
9134 (WebCore::CachedImage::notifyObservers):
9135 (WebCore::CachedImage::createImage):
9136 * loader/CachedImage.h:
9137 * loader/icon/IconRecord.cpp:
9138 (WebCore::IconRecord::setImageData):
9139 (WebCore::IconRecord::loadImageFromResource):
9140 * loader/icon/IconRecord.h:
9141 * platform/graphics/BitmapImage.h:
9142 (WebCore::BitmapImage::create):
9143 * platform/graphics/GeneratedImage.h:
9144 * platform/graphics/Gradient.cpp:
9145 * platform/graphics/Gradient.h:
9146 * platform/graphics/Image.cpp:
9147 (WebCore::Image::nullImage):
9148 * platform/graphics/Image.h:
9149 * platform/graphics/ImageBuffer.h:
9150 * platform/graphics/cairo/ImageBufferCairo.cpp:
9151 (WebCore::ImageBuffer::image):
9152 * platform/graphics/cg/ImageBufferCG.cpp:
9153 (WebCore::ImageBuffer::image):
9154 (WebCore::ImageBuffer::getImageData):
9155 (WebCore::ImageBuffer::putImageData):
9156 * platform/graphics/cg/PDFDocumentImage.h:
9157 (WebCore::PDFDocumentImage::create):
9158 (WebCore::PDFDocumentImage::destroyDecodedData):
9159 (WebCore::PDFDocumentImage::decodedSize):
9160 * platform/graphics/gtk/ImageGtk.cpp:
9161 (WebCore::Image::loadPlatformResource):
9162 * platform/graphics/mac/ImageMac.mm:
9163 (WebCore::Image::loadPlatformResource):
9164 * rendering/RenderImage.cpp:
9165 * rendering/RenderLayer.cpp:
9166 (WebCore::RenderLayer::paintOverflowControls):
9167 * svg/graphics/SVGImage.cpp:
9168 (WebCore::SVGImage::nativeImageForCurrentFrame):
9169 * svg/graphics/SVGImage.h:
9170 (WebCore::SVGImage::create):
9171 (WebCore::SVGImage::destroyDecodedData):
9172 (WebCore::SVGImage::decodedSize):
9173 (WebCore::SVGImage::frameAtIndex):
9174 * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
9175 (WebCore::SVGPaintServerPattern::setup):
9176 * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
9177 (WebCore::SVGResourceMasker::applyMask):
9178 * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
9179 (WebCore::patternCallback):
9180 * svg/graphics/cg/SVGResourceMaskerCg.mm:
9181 (WebCore::SVGResourceMasker::applyMask):
9182
91832008-08-13 Eric Seidel <eric@webkit.org>
9184
9185 Reviewed by Niko.
eric@webkit.org7811ef02008-08-14 00:28:51 +00009186
9187 Remove #ifdefs from CanvasStyle by using platform/Color.h
eric@webkit.org5b265602008-08-14 00:29:26 +00009188 https://bugs.webkit.org/show_bug.cgi?id=20351
eric@webkit.org7811ef02008-08-14 00:28:51 +00009189
9190 There are some down-sides to this commit.
9191 This commit limits us to 255 levels of grey for calls like:
9192 context.setStrokeStyle(.37, 1.0)
9193 previously CG might have used up to 32bits to store the grey level
9194 Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.
9195
9196 Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
9197 to RGBA32 (like all the rest of colors in WebCore), thus:
9198 context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
9199 context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32
9200
9201 If this is a problem for Dashboard, we can either roll out this commit
9202 or add a beefier Color abstraction, which can be used internally by GraphicsContext
9203 when keeping state, and then GraphicsContext can grow some additional set* routines
9204 for setting the a grey/float/whatever fill and stroke.
9205
9206 * html/CanvasRenderingContext2D.cpp:
9207 (WebCore::CanvasRenderingContext2D::setFillStyle):
9208 * html/CanvasStyle.cpp:
9209 (WebCore::CanvasStyle::CanvasStyle):
9210 (WebCore::colorWithOverrideAlpha):
9211 (WebCore::CanvasStyle::applyStrokeColor):
9212 (WebCore::CanvasStyle::applyFillColor):
9213 * html/CanvasStyle.h:
9214 * platform/graphics/Color.cpp:
9215 (WebCore::colorFloatToRGBAByte):
9216 (WebCore::makeRGBA32FromFloats):
9217 * platform/graphics/Color.h:
9218
adele@apple.com83e44822008-08-13 23:50:41 +000092192008-08-13 Eric Carlson <eric.carlson@apple.com>
9220
9221 Reviewed by Adele Peterson.
9222
9223 Fix for <rdar://problem/6137931>
9224 https://bugs.webkit.org/show_bug.cgi?id=20360
9225 Remove all parameters from the MIME type before checking with the MIME type registry
9226
9227 Tests: media/video-source-type-params.html
9228
9229 * html/HTMLMediaElement.cpp:
9230 (WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';'
9231 to isSupportedMediaMIMEType()
9232
bdakin@apple.com7bc81bf2008-08-13 21:36:15 +000092332008-08-13 Beth Dakin <bdakin@apple.com>
9234
9235 Reviewed by Sam Weinig.
9236
9237 Fix for <rdar://problem/6141345>
9238
9239 This patch refines findString and markAllMatchesForText functions'
9240 interactions with disconnected frames. They no longer rely on
9241 knowing where a range is relative to the visible region and work
9242 with disconnected frames that contain frames.
9243
9244 * editing/Editor.cpp:
9245 (WebCore::Editor::insideVisibleArea): Now returns a bool instead of
9246 the visiblity enum.
9247 (WebCore::Editor::firstVisibleRange): This now returns the very
9248 first visible range in the document. It's no longer dependent on
9249 searching forward.
9250 (WebCore::Editor::lastVisibleRange): This now returns the very last
9251 visible range in the document. It's no longer dependent on
9252 searching backwards.
9253 (WebCore::Editor::nextVisibleRange): This returns the next visible
9254 range in the appropriate direction from the current range.
9255 * editing/Editor.h:
9256 * page/Frame.cpp:
9257 (WebCore::Frame::findString):
9258 (WebCore::Frame::markAllMatchesForText):
9259
kevino@webkit.orgee5adc42008-08-13 20:07:16 +000092602008-08-13 Kevin Ollivier <kevino@theolliviers.com>
9261
9262 wx build fix for case-sensitive platforms, like Linux.
9263
9264 * WebCoreSources.bkl:
9265
jmalonzo@webkit.org210145b2008-08-13 19:56:20 +000092662008-08-13 Marco Barisione <marco.barisione@collabora.co.uk>
9267
9268 Reviewed by Holger Freyther.
9269
9270 http://bugs.webkit.org/show_bug.cgi?id=16881
9271 [GTK] PlatformScreenGtk is unimplemented
9272
9273 Original patch by Christian Dywan.
9274
9275 * platform/gtk/PlatformScreenGtk.cpp:
9276 (WebCore::screenDepth):
9277 (WebCore::screenDepthPerComponent):
9278 (WebCore::screenIsMonochrome):
9279 (WebCore::screenRect):
9280 (WebCore::screenAvailableRect):
9281
jmalonzo@webkit.orge4693932008-08-13 19:42:08 +000092822008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org>
9283
9284 Reviewed by Holger Freyther.
9285
9286 http://bugs.webkit.org/show_bug.cgi?id=20318
9287 SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add
9288
9289 g_idle_add is the same as g_idle_add_full with a priority of
9290 G_PRIORITY_DEFAULT_IDLE, so we can safely use that.
9291
9292 * platform/gtk/SharedTimerGtk.cpp:
9293 (WebCore::setSharedTimerFireTime):
9294
timothy@apple.comf0426602008-08-13 18:11:01 +000092952008-08-13 Timothy Hatcher <timothy@apple.com>
9296
9297 Changed the InspectorController so it can be notified when the
9298 attached state of the Inspector changes in WebKit.
9299
9300 Reviewed by Kevin McCullough.
9301
9302 * WebCore.base.exp: Updated the symbol for setWindowVisible.
9303 * page/InspectorController.cpp:
9304 (WebCore::InspectorController::setWindowVisible): Added an attached argument,
9305 that defaults to false.Call setAttachedWindow with the attached argument.
9306 (WebCore::InspectorController::setAttachedWindow): Call the script version
9307 of setAttachedWindow.
9308 * page/InspectorController.h:
9309 * page/inspector/inspector.js:
9310 (WebInspector.setAttachedWindow): Set the attached property.
9311
timothy@apple.com9ea832b2008-08-13 18:10:36 +000093122008-08-12 Timothy Hatcher <timothy@apple.com>
9313
timothy@apple.com72c92ae2008-08-13 18:10:45 +00009314 Added a close button to the Inspector's toolbar when docked.
9315
9316 https://bugs.webkit.org/show_bug.cgi?id=14270
9317
9318 Reviewed by Kevin McCullough.
9319
9320 * page/InspectorController.cpp:
9321 (WebCore::closeWindow): Call InspectorController::closeWindow.
9322 (WebCore::InspectorController::windowScriptObjectAvailable):
9323 Added closeWindow to the script class.
9324 * page/InspectorController.h:
9325 * page/inspector/Images/closeButtons.png: Added.
9326 * page/inspector/inspector.css: Added and changed styles.
9327 * page/inspector/inspector.html: Added the close button.
9328 * page/inspector/inspector.js:
9329 (WebInspector.loaded): Added click event listener to the close button.
9330 (WebInspector.close): Call InspectorController.closeWindow.
9331
93322008-08-12 Timothy Hatcher <timothy@apple.com>
9333
timothy@apple.com9ea832b2008-08-13 18:10:36 +00009334 Make the docked Web Inspector resizable. This is the cross platform
9335 portion of the code. Each InspectorClient needs to implement the
9336 real resize code.
9337
9338 https://bugs.webkit.org/show_bug.cgi?id=14282
9339
9340 Reviewed by Kevin McCullough.
9341
9342 * loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
9343 * page/InspectorClient.h: Added setAttachedWindowHeight.
9344 * page/InspectorController.cpp:
9345 (WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight
9346 on the InspectorController.
9347 (WebCore::InspectorController::setAttachedWindowHeight): Call
9348 setAttachedWindowHeight on the client.
9349 (WebCore::InspectorController::windowScriptObjectAvailable):
9350 Added setAttachedWindowHeight to the script class.
9351 * page/InspectorController.h:
9352 * page/inspector/inspector.css: Make the cursor on the toolbar be
9353 row-resize when docked.
9354 * page/inspector/inspector.js:
9355 (WebInspector.loaded): Always add the toolbarDragStart event listener.
9356 (WebInspector.toolbarDragStart): Return early if we are not attached
9357 and not on Leopard. Call WebInspector.elementDragStart.
9358 (WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd.
9359 (WebInspector.toolbarDrag): When attached call setAttachedWindowHeight,
9360 otherwise call moveByUnrestricted.
9361
hausmann@webkit.orgd34f1d22008-08-13 13:43:34 +000093622008-08-13 Simon Hausmann <hausmann@webkit.org>
9363
9364 Reviewed by Holger.
9365
9366 Initialize m_zoomsTextOnly in the Settings constructor.
9367
9368 * page/Settings.cpp:
9369 (WebCore::Settings::Settings):
9370
hausmann@webkit.org74586d62008-08-13 13:31:11 +000093712008-08-13 Brad Hughes <bhughes@trolltech.com>
9372
9373 Reviewed by Simon.
9374
9375 Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux
9376
9377 The latest upgrade of the intel compiler allows us to compile all of
9378 Qt with optimizations enabled (yay!).
9379
9380 * WebCore.pro:
9381
hausmann@webkit.org690b7fc2008-08-13 13:24:56 +000093822008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com>
9383
9384 Reviewed by Simon.
9385
9386 Fix QtWebKit not displaying content on 403 HTTP responses
9387
9388 Just like with 404 responses also display content with 403, as
9389 used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/
9390
9391 * platform/network/qt/QNetworkReplyHandler.cpp:
9392 (WebCore::QNetworkReplyHandler::finish):
9393
hausmann@webkit.org88c4dc92008-08-13 12:02:00 +000093942008-08-13 Simon Hausmann <hausmann@webkit.org>
9395
hausmann@webkit.orgd2315e32008-08-13 13:16:15 +00009396 Reviewed by Holger.
9397
9398 Qt part of https://bugs.webkit.org/show_bug.cgi?id=18994
9399
9400 Make the formatting of String::format() locale independent through the use of QString::vsprintf.
9401
9402 * platform/text/String.cpp:
9403 (WebCore::String::format):
9404
94052008-08-13 Simon Hausmann <hausmann@webkit.org>
9406
hausmann@webkit.org88c4dc92008-08-13 12:02:00 +00009407 Reviewed by Lars.
9408
9409 Fix QWebFrame::setHtml() not setting the new contents immediately.
9410
9411 Added a setter to the DocumentLoader to toggle the deferred loading of the main
9412 resource when it comes from substitute data.
9413
9414 Disable deferred loading of the main resource when we have valid substitute data,
9415 as used by QWebFrame::setHtml.
9416
9417 * loader/DocumentLoader.h:
9418
mrowe@apple.com6aa36d12008-08-13 09:58:32 +000094192008-08-13 Mark Rowe <mrowe@apple.com>
9420
9421 Speculative GTK build fix.
9422
9423 * GNUmakefile.am: Add dependency info for JSSVGElementWrapperFactory.cpp.
9424
hausmann@webkit.org298ce5f2008-08-13 09:11:23 +000094252008-08-13 Thiago Macieira <tjmaciei@trolltech.com>
9426
9427 Reviewed by Simon.
9428
9429 Fix encoding of [ and ] in the host part of the URL
9430
9431 Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to
9432 add this workaround to the QUrl <> WebCore::KURL conversion operator so that it
9433 doesn't encode [ and ] when they are found in the host part. That is, the
9434 following URL:
9435 http://[::1]/
9436 is valid and should not be reencoded to:
9437 http://%5b::1%5d/
9438
9439 * platform/qt/KURLQt.cpp:
9440 (WebCore::KURL::operator QUrl):
9441
mitz@apple.come198b012008-08-12 21:49:07 +000094422008-08-12 Mihnea Ovidenie <mihnea@adobe.com>
9443
9444 Fix for https://bugs.webkit.org/show_bug.cgi?id=19891
9445 Broken HTML object elements cause de-reference of pointer to freed memory.
9446 If we fail to load an image for an object tag and we no longer believe the object tag points at
9447 an image, then clear m_imageLoader in the HTMLObjectElement so that we attempt to render the
9448 fall back content.
9449
9450 Reviewed by Dave Hyatt and Alexey Proskuryakov.
9451
9452 Test: http/tests/misc/object-image-error-with-onload.html
9453
9454 * html/HTMLObjectElement.cpp:
9455 (WebCore::HTMLObjectElement::renderFallbackContent):
9456 * page/Frame.cpp:
9457 (WebCore::Frame::Frame):
9458
zimmermann@webkit.org36a02512008-08-12 21:11:17 +000094592008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
9460
9461 Reviewed by Dave.
9462
9463 Fixes: https://bugs.webkit.org/show_bug.cgi?id=19798
9464 Masks are translated, and the mask images are swapped on the y-axis.
9465
9466 Turned out that http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm
9467 is guilty. GraphicsContext::clipToImageBuffer() does some extra transformations that SVGResourcesMaskerCg does not want.
9468
9469 Long term goal is to remove the SVGResource*/SVGPaintServer* classes anyway, so it's okay to duplicate
9470 the "clip to image buffer" functionality, in the CG specific SVGResourceMaskerCg class - as it was before.
9471
9472 * svg/graphics/cg/SVGResourceMaskerCg.mm:
9473 (WebCore::SVGResourceMasker::applyMask): Changed back to use CG clipping again.
9474
mitz@apple.comf8a98692008-08-12 17:04:42 +000094752008-08-12 Dan Bernstein <mitz@apple.com>
9476
mitz@apple.com1b7e844f2008-08-12 20:54:12 +00009477 - WebCore part of <rdar://problem/6121636>
9478 Make fast*alloc() abort() on failure and add "try" variants that
9479 return NULL on failure.
9480
9481 Reviewed by Darin Adler.
9482
9483 * platform/Arena.cpp:
9484 (WebCore::ArenaAllocate): Removed null checking of fastMalloc()'s
9485 result.
9486 * platform/graphics/cg/ImageBufferCG.cpp:
9487 (WebCore::ImageBuffer::create): Changed to use tryFastCalloc().
9488
94892008-08-12 Dan Bernstein <mitz@apple.com>
9490
mitz@apple.com1e09cd72008-08-12 18:27:58 +00009491 Reviewed by Darin Adler.
9492
9493 - fix https://bugs.webkit.org/show_bug.cgi?id=19348
9494 <rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works
9495
9496 Test: fast/frames/frameset-style-recalc.html
9497
9498 * html/HTMLFrameSetElement.cpp:
9499 (WebCore::HTMLFrameSetElement::recalcStyle): Changed to call the base
9500 class implementation after marking for layout.
9501
95022008-08-12 Dan Bernstein <mitz@apple.com>
9503
mitz@apple.comf8a98692008-08-12 17:04:42 +00009504 Reviewed by John Sullivan.
9505
9506 - move shouldUpdateWhenOffscreen from Settings to FrameView and rename it shouldUpdateWhileHidden
9507
9508 * WebCore.base.exp:
9509 * page/FrameView.cpp:
9510 (WebCore::FrameViewPrivate::FrameViewPrivate):
9511 (WebCore::FrameView::shouldUpdateWhileHidden):
9512 (WebCore::FrameView::setShouldUpdateWhileHidden):
9513 * page/FrameView.h:
9514 * page/Settings.cpp:
9515 * page/Settings.h:
9516
aroben@apple.comeeb8ebb2008-08-12 14:58:51 +000095172008-08-12 Adam Roben <aroben@apple.com>
9518
9519 Windows build fix
9520
9521 * bindings/js/JSSVGPODTypeWrapper.h: Align
9522 JSSVGDynamicPODTypeWrapper's and JSSVGStaticPODTypeWrapperWithParent's
9523 members on 16-byte boundaries to avoid an alignment warning.
9524
zimmermann@webkit.orge1388112008-08-12 10:27:53 +000095252008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
9526
9527 Reviewed by Oliver.
9528
zimmermann@webkit.org504f2552008-08-12 10:35:09 +00009529 Add new dynamice-update layout tests covering SVGMarkerElement.
9530 Fix bug: SVGMarkerElement's SVG DOM function calls don't update rendering.
9531 Fix orientAngle/orientType confusion: "auto" orient should always return "0" as angle.
9532
9533 Tests: svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
9534 svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr.html
9535 svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr.html
9536 svg/dynamic-updates/SVGMarkerElement-dom-orient-attr.html
9537 svg/dynamic-updates/SVGMarkerElement-dom-refX-attr.html
9538 svg/dynamic-updates/SVGMarkerElement-dom-refY-attr.html
9539 svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop.html
9540 svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop.html
9541 svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop.html
9542 svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop.html
9543 svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop.html
9544 svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop.html
9545 svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop.html
9546 svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call.html
9547 svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call.html
9548
9549 * svg/SVGMarkerElement.cpp:
9550 (WebCore::SVGMarkerElement::SVGMarkerElement):
9551 (WebCore::SVGMarkerElement::parseMappedAttribute):
9552 (WebCore::SVGMarkerElement::svgAttributeChanged):
9553 (WebCore::SVGMarkerElement::childrenChanged):
9554 (WebCore::SVGMarkerElement::setOrientToAuto):
9555 (WebCore::SVGMarkerElement::setOrientToAngle):
9556 (WebCore::SVGMarkerElement::canvasResource):
9557
95582008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
9559
9560 Reviewed by Oliver.
9561
zimmermann@webkit.orge1388112008-08-12 10:27:53 +00009562 Add new dynamic-update layout tests covering SVGImageElement.
9563 Fix bug: SVGImageElement doesn't react on 'preserveAspectRatio' changes.
9564
9565 Tests: svg/dynamic-updates/SVGImageElement-dom-height-attr.html
9566 svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr.html
9567 svg/dynamic-updates/SVGImageElement-dom-width-attr.html
9568 svg/dynamic-updates/SVGImageElement-dom-x-attr.html
9569 svg/dynamic-updates/SVGImageElement-dom-y-attr.html
9570 svg/dynamic-updates/SVGImageElement-svgdom-height-prop.html
9571 svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html
9572 svg/dynamic-updates/SVGImageElement-svgdom-width-prop.html
9573 svg/dynamic-updates/SVGImageElement-svgdom-x-prop.html
9574 svg/dynamic-updates/SVGImageElement-svgdom-y-prop.html
9575
9576 * svg/SVGImageElement.cpp:
9577 (WebCore::SVGImageElement::svgAttributeChanged):
9578
timothy@apple.com93114722008-08-12 04:20:25 +000095792008-08-11 Anthony Ricaud <rik24d@gmail.com>
9580
timothy@apple.com2f2cde32008-08-12 04:28:16 +00009581 Changed Option/Alt-Up or Down in CSS editing when the value is
9582 near zero to jump to the next integer.
9583
9584 Reviewed by Tim Hatcher.
9585
9586 https://bugs.webkit.org/show_bug.cgi?id=20326
9587
9588 * page/inspector/StylesSidebarPane.js:
9589
95902008-08-11 Anthony Ricaud <rik24d@gmail.com>
9591
timothy@apple.com93114722008-08-12 04:20:25 +00009592 Changed the line highlight transition for an easier animation.
9593
9594 Reviewed by Tim Hatcher.
9595
9596 * page/inspector/SourceFrame.js:
9597
timothy@apple.com24a14852008-08-12 03:57:39 +000095982008-08-11 Keishi Hattori <casey.hattori@gmail.com>
9599
9600 Added support for some Firebug Command Line APIs.
9601
9602 Reviewed by Tim Hatcher.
9603
9604 https://bugs.webkit.org/show_bug.cgi?id=19867
9605 https://bugs.webkit.org/show_bug.cgi?id=19868
9606 https://bugs.webkit.org/show_bug.cgi?id=19869
9607 https://bugs.webkit.org/show_bug.cgi?id=19875
9608 https://bugs.webkit.org/show_bug.cgi?id=19876
9609 https://bugs.webkit.org/show_bug.cgi?id=19880
9610
9611 * page/inspector/Console.js:
9612 (WebInspector.Console.prototype._evalInInspectedWindow):
9613 Create an object on the inspected window that holds the console
9614 command line API functions. This object is used in a with statement
9615 around the typed expression.
9616
zimmermann@webkit.org0350b6d2008-08-12 02:22:26 +000096172008-08-11 Nikolas Zimmermann <zimmermann@kde.org>
9618
9619 Reviewed by Antti.
9620
9621 Fixes: http://bugs.webkit.org/show_bug.cgi?id=17736
9622
9623 JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties
9624 failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect)
9625
9626 Added tests: svg/custom/svg-modify-currentTranslate.html
9627 svg/custom/tearoffs-with-tearoffs.html
9628 svg/custom/immutable-properties.html
9629
9630 Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html
9631
9632 * bindings/js/JSSVGPODTypeWrapper.h:
9633 (WebCore::JSSVGDynamicPODTypeWrapper::commitChange):
9634 (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::create):
9635 (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::commitChange):
9636 (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::JSSVGStaticPODTypeWrapperWithPODTypeParent):
9637 (WebCore::JSSVGStaticPODTypeWrapperWithParent::create):
9638 (WebCore::JSSVGStaticPODTypeWrapperWithParent::operator PODType):
9639 (WebCore::JSSVGStaticPODTypeWrapperWithParent::commitChange):
9640 (WebCore::JSSVGStaticPODTypeWrapperWithParent::JSSVGStaticPODTypeWrapperWithParent):
9641 * bindings/scripts/CodeGenerator.pm:
9642 * bindings/scripts/CodeGeneratorJS.pm:
9643 * svg/SVGSVGElement.idl: Add [Immutable] markers to SVG POD attributes, that contain POD types with writable attributes.
9644 * svg/SVGZoomEvent.idl: SVG specification explicitely demands these attributes to be readonly, even its content.
9645
beidson@apple.com0e772f72008-08-12 00:34:46 +000096462008-08-11 Brady Eidson <beidson@apple.com>
9647
9648 Reviewed by John and Anders
9649
9650 Fix for <rdar://problem/6141797>
9651
9652 When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource
9653 would never have nil data.
9654
9655 When they were pushed down into WebCore, that guarantee was lost, subtly changing a few
9656 semantics with some WebKit applications.
9657
9658 The guarantee was a good one and should be restored.
9659
9660 Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already
9661 creates an empty data object in the case of null data for its own purposes.
9662
9663 * loader/SubstituteResource.h:
9664 (WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null. This
9665 well help any future subclassers not make this mistake.
9666
9667 * loader/archive/ArchiveResource.cpp:
9668 (WebCore::ArchiveResource::create): Return 0 if the data is null.
9669
simon.fraser@apple.come0d44792008-08-11 22:44:06 +000096702008-08-11 Simon Fraser <simon.fraser@apple.com>
9671
9672 Reviewed by Dave Hyatt
9673
9674 https://bugs.webkit.org/show_bug.cgi?id=20328
9675 Fix a problem when an 'all' transition transition with more than
9676 one property changing is interrupted, and did some AnimationController
9677 cleanup.
9678
9679 Test: transitions/interrupted-all-transition.html
9680
9681 * page/AnimationController.cpp:
9682 (WebCore::ImplicitAnimation::ImplicitAnimation):
9683 (WebCore::AnimationControllerPrivate::blendProperties):
9684 (WebCore::CompositeAnimation::updateTransitions):
9685 (WebCore::CompositeAnimation::cleanupFinishedAnimations):
9686 (WebCore::CompositeAnimation::setTransitionStartTime):
9687 (WebCore::CompositeAnimation::overrideImplicitAnimations):
9688 (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
9689 (WebCore::ImplicitAnimation::animate):
9690 (WebCore::ImplicitAnimation::onAnimationEnd):
9691 (WebCore::ImplicitAnimation::sendTransitionEvent):
9692 (WebCore::ImplicitAnimation::affectsProperty):
9693 (WebCore::KeyframeAnimation::endAnimation):
9694 (WebCore::KeyframeAnimation::onAnimationEnd):
9695
kmccullough@apple.com4a967c12008-08-11 20:45:19 +000096962008-08-11 Kevin McCullough <kmccullough@apple.com>
9697
9698 Reviewed by Tim.
9699
9700 - Because console messages have group levels now, newly created messages
9701 that do not specify the level lose their message since the number of
9702 arguments is wrong.
9703
9704 * page/inspector/Console.js:
9705 * page/inspector/Resource.js:
9706
alp@webkit.orgeeb55142008-08-11 19:52:14 +000097072008-08-11 Alp Toker <alp@nuanti.com>
9708
9709 Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take
9710 the opportunity to sort the sources lists.
9711
9712 * GNUmakefile.am:
9713
timothy@apple.com9fe09f82008-08-11 18:48:37 +000097142008-08-11 Timothy Hatcher <timothy@apple.com>
9715
9716 Speed up the the JavaScript syntax highlighter by generating
9717 the finders only once per script instead of per line.
9718
9719 https://bugs.webkit.org/show_bug.cgi?id=20346
9720
9721 Reviewed by Adam Roben.
9722
9723 * page/inspector/SourceFrame.js:
9724 (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
9725 Removed, factored into syntaxHighlightJavascript as an inline function.
9726 (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript):
9727 Pulled in the _syntaxHighlightJavascriptLine so it will create a closure.
9728 Generate the finders before iterating the lines.
9729
aroben@apple.com957d2d32008-08-11 18:31:37 +000097302008-08-11 Adam Roben <aroben@apple.com>
9731
9732 Windows build fix
9733
9734 * WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and
9735 JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file,
9736 too.
9737
mitz@apple.com3f0060f2008-08-11 18:04:46 +000097382008-08-11 Dan Bernstein <mitz@apple.com>
9739
9740 Reviewed by Darin Adler.
9741
9742 - fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
9743
9744 Test: fast/css/counters/invalidate-cached-counter-node.html
9745
9746 * rendering/RenderContainer.cpp:
9747 (WebCore::RenderContainer::invalidateCounters): Added. Invalidates all
9748 RenderCounters in :before and :after content.
9749 * rendering/RenderContainer.h:
9750 * rendering/RenderCounter.cpp:
9751 (WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this
9752 to match the RenderObject method.
9753 (WebCore::RenderCounter::invalidate): Added. Resets the cached
9754 CounterNode and invalidates the object's layout and preferred widths.
9755 (WebCore::destroyCounterNodeChildren): Added a call to
9756 invalidateCounters().
9757 * rendering/RenderCounter.h:
9758 * rendering/RenderObject.h:
9759 (WebCore::RenderObject::invalidateCounters):
9760
dino@apple.com2af8c3a2008-08-11 17:24:36 +000097612008-08-11 Dean Jackson <dino@apple.com>
9762
9763 Implement CSS Animation and Transition Events
9764 https://bugs.webkit.org/show_bug.cgi?id=20337
9765
9766 Implement the events defined in the CSS Animations
9767 and Transitions specifications so code can react
9768 to animations and transitions.
9769
9770 Reviewed by Tim Hatcher and Dave Hyatt.
9771
9772 * DerivedSources.make:
9773 * GNUmakefile.am:
9774 * WebCore.pro:
9775 * WebCore.vcproj/WebCore.vcproj:
9776 * WebCore.xcodeproj/project.pbxproj:
9777 * WebCoreSources.bkl:
9778 Build configs for new files
9779
9780 * bindings/js/JSDOMWindowBase.cpp:
9781 * bindings/js/JSDOMWindowBase.h:
9782 * bindings/js/JSEventCustom.cpp:
9783 * dom/Document.h:
9784 * dom/Event.cpp:
9785 * dom/Event.h:
9786 * dom/EventTarget.cpp:
9787 * dom/EventTargetNode.cpp:
9788 * dom/EventTargetNode.h:
9789 * html/HTMLElement.cpp:
9790 * page/AnimationController.cpp:
9791 do all the new event stuff
9792
9793 * html/HTMLAttributeNames.in:
9794 the onwebkitanimation* and onwebkittransitionend attrs
9795
9796 * dom/WebKitAnimationEvent.cpp: Added.
9797 * dom/WebKitAnimationEvent.h: Added.
9798 * dom/WebKitAnimationEvent.idl: Added.
9799 * dom/WebKitTransitionEvent.cpp: Added.
9800 * dom/WebKitTransitionEvent.h: Added.
9801 * dom/WebKitTransitionEvent.idl: Added.
9802 New files for the events
9803
9804 * manual-tests/transition-events.html: Added.
9805 New testfile
9806
aroben@apple.com3eae8622008-08-11 17:21:23 +000098072008-08-11 Adam Roben <aroben@apple.com>
9808
9809 Add a ForwardingHeader for wtf/NotFound.h
9810
9811 Rubberstamped by Darin Adler.
9812
9813 * ForwardingHeaders/wtf/NotFound.h: Added.
9814
timothy@apple.com2f5bdf02008-08-11 16:53:30 +000098152008-08-11 Timothy Hatcher <timothy@apple.com>
9816
9817 Fixes a bug where error bubbles in JavaScript resources would
9818 be clobbered by the syntax highlighter.
9819
9820 https://bugs.webkit.org/show_bug.cgi?id=20345
9821
9822 Reviewed by Adam Roben.
9823
9824 * manual-tests/inspector/resources/script-error.js: Added.
9825 * manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added.
9826 * page/inspector/SourceFrame.js:
9827 (WebInspector.SourceFrame.prototype._addMessageToSource):
9828 Check the nodeType and not the nodeName, this is less fragile.
9829 (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
9830 Check if the lastChild is an error bubble, if so remove it before
9831 getting the line's textContent. Add the error bubble back at the end.
9832
mrowe@apple.com4ec50d02008-08-11 05:07:42 +00009833== Rolled over to ChangeLog-2008-08-10 ==