| #!/usr/bin/env perl -wT |
| # -*- Mode: perl; indent-tabs-mode: nil -*- |
| # |
| # The contents of this file are subject to the Mozilla Public |
| # License Version 1.1 (the "License"); you may not use this file |
| # except in compliance with the License. You may obtain a copy of |
| # the License at http://www.mozilla.org/MPL/ |
| # |
| # Software distributed under the License is distributed on an "AS |
| # IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or |
| # implied. See the License for the specific language governing |
| # rights and limitations under the License. |
| # |
| # The Original Code is the Bugzilla Bug Tracking System. |
| # |
| # The Initial Developer of the Original Code is Netscape Communications |
| # Corporation. Portions created by Netscape are |
| # Copyright (C) 1998 Netscape Communications Corporation. All |
| # Rights Reserved. |
| # |
| # Contributor(s): Dave Miller <justdave@syndicomm.com> |
| # Joel Peshkin <bugreport@peshkin.net> |
| # Jacob Steenhagen <jake@bugzilla.org> |
| # Vlad Dascalu <jocuri@softhome.net> |
| # Frédéric Buclin <LpSolit@gmail.com> |
| |
| use strict; |
| use lib qw(. lib); |
| |
| use Bugzilla; |
| use Bugzilla::Constants; |
| use Bugzilla::Config qw(:admin); |
| use Bugzilla::Util; |
| use Bugzilla::Error; |
| use Bugzilla::Group; |
| use Bugzilla::Product; |
| use Bugzilla::User; |
| use Bugzilla::Token; |
| |
| use constant SPECIAL_GROUPS => ('chartgroup', 'insidergroup', |
| 'timetrackinggroup', 'querysharegroup'); |
| |
| my $cgi = Bugzilla->cgi; |
| my $dbh = Bugzilla->dbh; |
| my $template = Bugzilla->template; |
| my $vars = {}; |
| |
| my $user = Bugzilla->login(LOGIN_REQUIRED); |
| |
| print $cgi->header(); |
| |
| $user->in_group('creategroups') |
| || ThrowUserError("auth_failure", {group => "creategroups", |
| action => "edit", |
| object => "groups"}); |
| |
| my $action = trim($cgi->param('action') || ''); |
| my $token = $cgi->param('token'); |
| |
| # CheckGroupID checks that a positive integer is given and is |
| # actually a valid group ID. If all tests are successful, the |
| # trimmed group ID is returned. |
| |
| sub CheckGroupID { |
| my ($group_id) = @_; |
| $group_id = trim($group_id || 0); |
| ThrowUserError("group_not_specified") unless $group_id; |
| (detaint_natural($group_id) |
| && Bugzilla->dbh->selectrow_array("SELECT id FROM groups WHERE id = ?", |
| undef, $group_id)) |
| || ThrowUserError("invalid_group_ID"); |
| return $group_id; |
| } |
| |
| # This subroutine is called when: |
| # - a new group is created. CheckGroupName checks that its name |
| # is not empty and is not already used by any existing group. |
| # - an existing group is edited. CheckGroupName checks that its |
| # name has not been deleted or renamed to another existing |
| # group name (whose group ID is different from $group_id). |
| # In both cases, an error message is returned to the user if any |
| # test fails! Else, the trimmed group name is returned. |
| |
| sub CheckGroupName { |
| my ($name, $group_id) = @_; |
| $name = trim($name || ''); |
| trick_taint($name); |
| ThrowUserError("empty_group_name") unless $name; |
| my $excludeself = (defined $group_id) ? " AND id != $group_id" : ""; |
| my $name_exists = Bugzilla->dbh->selectrow_array("SELECT name FROM groups " . |
| "WHERE name = ? $excludeself", |
| undef, $name); |
| if ($name_exists) { |
| ThrowUserError("group_exists", { name => $name }); |
| } |
| return $name; |
| } |
| |
| # CheckGroupDesc checks that a non empty description is given. The |
| # trimmed description is returned. |
| |
| sub CheckGroupDesc { |
| my ($desc) = @_; |
| $desc = trim($desc || ''); |
| trick_taint($desc); |
| ThrowUserError("empty_group_description") unless $desc; |
| return $desc; |
| } |
| |
| # CheckGroupRegexp checks that the regular expression is valid |
| # (the regular expression being optional, the test is successful |
| # if none is given, as expected). The trimmed regular expression |
| # is returned. |
| |
| sub CheckGroupRegexp { |
| my ($regexp) = @_; |
| $regexp = trim($regexp || ''); |
| trick_taint($regexp); |
| ThrowUserError("invalid_regexp") unless (eval {qr/$regexp/}); |
| return $regexp; |
| } |
| |
| # A helper for displaying the edit.html.tmpl template. |
| sub get_current_and_available { |
| my ($group, $vars) = @_; |
| |
| my @all_groups = Bugzilla::Group->get_all; |
| my @members_current = @{$group->grant_direct(GROUP_MEMBERSHIP)}; |
| my @member_of_current = @{$group->granted_by_direct(GROUP_MEMBERSHIP)}; |
| my @bless_from_current = @{$group->grant_direct(GROUP_BLESS)}; |
| my @bless_to_current = @{$group->granted_by_direct(GROUP_BLESS)}; |
| my (@visible_from_current, @visible_to_me_current); |
| if (Bugzilla->params->{'usevisibilitygroups'}) { |
| @visible_from_current = @{$group->grant_direct(GROUP_VISIBLE)}; |
| @visible_to_me_current = @{$group->granted_by_direct(GROUP_VISIBLE)}; |
| } |
| |
| # Figure out what groups are not currently a member of this group, |
| # and what groups this group is not currently a member of. |
| my (@members_available, @member_of_available, |
| @bless_from_available, @bless_to_available, |
| @visible_from_available, @visible_to_me_available); |
| foreach my $group_option (@all_groups) { |
| if (Bugzilla->params->{'usevisibilitygroups'}) { |
| push(@visible_from_available, $group_option) |
| if !grep($_->id == $group_option->id, @visible_from_current); |
| push(@visible_to_me_available, $group_option) |
| if !grep($_->id == $group_option->id, @visible_to_me_current); |
| } |
| |
| # The group itself should never show up in the bless or |
| # membership lists. |
| next if $group_option->id == $group->id; |
| |
| push(@members_available, $group_option) |
| if !grep($_->id == $group_option->id, @members_current); |
| push(@member_of_available, $group_option) |
| if !grep($_->id == $group_option->id, @member_of_current); |
| push(@bless_from_available, $group_option) |
| if !grep($_->id == $group_option->id, @bless_from_current); |
| push(@bless_to_available, $group_option) |
| if !grep($_->id == $group_option->id, @bless_to_current); |
| } |
| |
| $vars->{'members_current'} = \@members_current; |
| $vars->{'members_available'} = \@members_available; |
| $vars->{'member_of_current'} = \@member_of_current; |
| $vars->{'member_of_available'} = \@member_of_available; |
| |
| $vars->{'bless_from_current'} = \@bless_from_current; |
| $vars->{'bless_from_available'} = \@bless_from_available; |
| $vars->{'bless_to_current'} = \@bless_to_current; |
| $vars->{'bless_to_available'} = \@bless_to_available; |
| |
| if (Bugzilla->params->{'usevisibilitygroups'}) { |
| $vars->{'visible_from_current'} = \@visible_from_current; |
| $vars->{'visible_from_available'} = \@visible_from_available; |
| $vars->{'visible_to_me_current'} = \@visible_to_me_current; |
| $vars->{'visible_to_me_available'} = \@visible_to_me_available; |
| } |
| } |
| |
| # If no action is specified, get a list of all groups available. |
| |
| unless ($action) { |
| my @groups = Bugzilla::Group->get_all; |
| $vars->{'groups'} = \@groups; |
| |
| print $cgi->header(); |
| $template->process("admin/groups/list.html.tmpl", $vars) |
| || ThrowTemplateError($template->error()); |
| exit; |
| } |
| |
| # |
| # action='changeform' -> present form for altering an existing group |
| # |
| # (next action will be 'postchanges') |
| # |
| |
| if ($action eq 'changeform') { |
| # Check that an existing group ID is given |
| my $group_id = CheckGroupID($cgi->param('group')); |
| my $group = new Bugzilla::Group($group_id); |
| |
| get_current_and_available($group, $vars); |
| $vars->{'group'} = $group; |
| $vars->{'token'} = issue_session_token('edit_group'); |
| |
| print $cgi->header(); |
| $template->process("admin/groups/edit.html.tmpl", $vars) |
| || ThrowTemplateError($template->error()); |
| |
| exit; |
| } |
| |
| # |
| # action='add' -> present form for parameters for new group |
| # |
| # (next action will be 'new') |
| # |
| |
| if ($action eq 'add') { |
| $vars->{'token'} = issue_session_token('add_group'); |
| print $cgi->header(); |
| $template->process("admin/groups/create.html.tmpl", $vars) |
| || ThrowTemplateError($template->error()); |
| |
| exit; |
| } |
| |
| |
| |
| # |
| # action='new' -> add group entered in the 'action=add' screen |
| # |
| |
| if ($action eq 'new') { |
| check_token_data($token, 'add_group'); |
| # Check that a not already used group name is given, that |
| # a description is also given and check if the regular |
| # expression is valid (if any). |
| my $name = CheckGroupName($cgi->param('name')); |
| my $desc = CheckGroupDesc($cgi->param('desc')); |
| my $regexp = CheckGroupRegexp($cgi->param('regexp')); |
| my $isactive = $cgi->param('isactive') ? 1 : 0; |
| # This is an admin page. The URL is considered safe. |
| my $icon_url; |
| if ($cgi->param('icon_url')) { |
| $icon_url = clean_text($cgi->param('icon_url')); |
| trick_taint($icon_url); |
| } |
| |
| # Add the new group |
| $dbh->do('INSERT INTO groups |
| (name, description, isbuggroup, userregexp, isactive, icon_url) |
| VALUES (?, ?, 1, ?, ?, ?)', |
| undef, ($name, $desc, $regexp, $isactive, $icon_url)); |
| |
| my $group = new Bugzilla::Group({name => $name}); |
| my $admin = Bugzilla::Group->new({name => 'admin'})->id(); |
| # Since we created a new group, give the "admin" group all privileges |
| # initially. |
| my $sth = $dbh->prepare('INSERT INTO group_group_map |
| (member_id, grantor_id, grant_type) |
| VALUES (?, ?, ?)'); |
| |
| $sth->execute($admin, $group->id, GROUP_MEMBERSHIP); |
| $sth->execute($admin, $group->id, GROUP_BLESS); |
| $sth->execute($admin, $group->id, GROUP_VISIBLE); |
| |
| # Permit all existing products to use the new group if makeproductgroups. |
| if ($cgi->param('insertnew')) { |
| $dbh->do('INSERT INTO group_control_map |
| (group_id, product_id, entry, membercontrol, |
| othercontrol, canedit) |
| SELECT ?, products.id, 0, ?, ?, 0 FROM products', |
| undef, ($group->id, CONTROLMAPSHOWN, CONTROLMAPNA)); |
| } |
| Bugzilla::Group::RederiveRegexp($regexp, $group->id); |
| delete_token($token); |
| |
| $vars->{'message'} = 'group_created'; |
| $vars->{'group'} = $group; |
| get_current_and_available($group, $vars); |
| $vars->{'token'} = issue_session_token('edit_group'); |
| |
| print $cgi->header(); |
| $template->process("admin/groups/edit.html.tmpl", $vars) |
| || ThrowTemplateError($template->error()); |
| exit; |
| } |
| |
| # |
| # action='del' -> ask if user really wants to delete |
| # |
| # (next action would be 'delete') |
| # |
| |
| if ($action eq 'del') { |
| # Check that an existing group ID is given |
| my $gid = CheckGroupID($cgi->param('group')); |
| my ($name, $desc, $isbuggroup) = |
| $dbh->selectrow_array("SELECT name, description, isbuggroup " . |
| "FROM groups WHERE id = ?", undef, $gid); |
| |
| # System groups cannot be deleted! |
| if (!$isbuggroup) { |
| ThrowUserError("system_group_not_deletable", { name => $name }); |
| } |
| # Groups having a special role cannot be deleted. |
| my @special_groups; |
| foreach my $special_group (SPECIAL_GROUPS) { |
| if ($name eq Bugzilla->params->{$special_group}) { |
| push(@special_groups, $special_group); |
| } |
| } |
| if (scalar(@special_groups)) { |
| ThrowUserError('group_has_special_role', {'name' => $name, |
| 'groups' => \@special_groups}); |
| } |
| |
| # Group inheritance no longer appears in user_group_map. |
| my $grouplist = join(',', @{Bugzilla::User->flatten_group_membership($gid)}); |
| my $hasusers = |
| $dbh->selectrow_array("SELECT 1 FROM user_group_map |
| WHERE group_id IN ($grouplist) AND isbless = 0 " . |
| $dbh->sql_limit(1)) || 0; |
| |
| my ($shared_queries) = |
| $dbh->selectrow_array('SELECT COUNT(*) |
| FROM namedquery_group_map |
| WHERE group_id = ?', |
| undef, $gid); |
| |
| my $bug_ids = $dbh->selectcol_arrayref('SELECT bug_id FROM bug_group_map |
| WHERE group_id = ?', undef, $gid); |
| |
| my $hasbugs = scalar(@$bug_ids) ? 1 : 0; |
| my $buglist = join(',', @$bug_ids); |
| |
| my $hasproduct = Bugzilla::Product->new({'name' => $name}) ? 1 : 0; |
| |
| my $hasflags = $dbh->selectrow_array('SELECT 1 FROM flagtypes |
| WHERE grant_group_id = ? |
| OR request_group_id = ? ' . |
| $dbh->sql_limit(1), |
| undef, ($gid, $gid)) || 0; |
| |
| $vars->{'gid'} = $gid; |
| $vars->{'name'} = $name; |
| $vars->{'description'} = $desc; |
| $vars->{'hasusers'} = $hasusers; |
| $vars->{'hasbugs'} = $hasbugs; |
| $vars->{'hasproduct'} = $hasproduct; |
| $vars->{'hasflags'} = $hasflags; |
| $vars->{'shared_queries'} = $shared_queries; |
| $vars->{'buglist'} = $buglist; |
| $vars->{'token'} = issue_session_token('delete_group'); |
| |
| print $cgi->header(); |
| $template->process("admin/groups/delete.html.tmpl", $vars) |
| || ThrowTemplateError($template->error()); |
| |
| exit; |
| } |
| |
| # |
| # action='delete' -> really delete the group |
| # |
| |
| if ($action eq 'delete') { |
| check_token_data($token, 'delete_group'); |
| # Check that an existing group ID is given |
| my $gid = CheckGroupID($cgi->param('group')); |
| my ($name, $isbuggroup) = |
| $dbh->selectrow_array("SELECT name, isbuggroup FROM groups " . |
| "WHERE id = ?", undef, $gid); |
| |
| # System groups cannot be deleted! |
| if (!$isbuggroup) { |
| ThrowUserError("system_group_not_deletable", { name => $name }); |
| } |
| # Groups having a special role cannot be deleted. |
| my @special_groups; |
| foreach my $special_group (SPECIAL_GROUPS) { |
| if ($name eq Bugzilla->params->{$special_group}) { |
| push(@special_groups, $special_group); |
| } |
| } |
| if (scalar(@special_groups)) { |
| ThrowUserError('group_has_special_role', {'name' => $name, |
| 'groups' => \@special_groups}); |
| } |
| |
| my $cantdelete = 0; |
| |
| # Group inheritance no longer appears in user_group_map. |
| my $grouplist = join(',', @{Bugzilla::User->flatten_group_membership($gid)}); |
| my $hasusers = |
| $dbh->selectrow_array("SELECT 1 FROM user_group_map |
| WHERE group_id IN ($grouplist) AND isbless = 0 " . |
| $dbh->sql_limit(1)) || 0; |
| |
| if ($hasusers && !defined $cgi->param('removeusers')) { |
| $cantdelete = 1; |
| } |
| |
| my $hasbugs = $dbh->selectrow_array('SELECT 1 FROM bug_group_map |
| WHERE group_id = ? ' . |
| $dbh->sql_limit(1), |
| undef, $gid) || 0; |
| if ($hasbugs && !defined $cgi->param('removebugs')) { |
| $cantdelete = 1; |
| } |
| |
| if (Bugzilla::Product->new({'name' => $name}) |
| && !defined $cgi->param('unbind')) |
| { |
| $cantdelete = 1; |
| } |
| |
| my $hasflags = $dbh->selectrow_array('SELECT 1 FROM flagtypes |
| WHERE grant_group_id = ? |
| OR request_group_id = ? ' . |
| $dbh->sql_limit(1), |
| undef, ($gid, $gid)) || 0; |
| if ($hasflags && !defined $cgi->param('removeflags')) { |
| $cantdelete = 1; |
| } |
| |
| $vars->{'gid'} = $gid; |
| $vars->{'name'} = $name; |
| |
| ThrowUserError('group_cannot_delete', $vars) if $cantdelete; |
| |
| $dbh->do('UPDATE flagtypes SET grant_group_id = ? |
| WHERE grant_group_id = ?', |
| undef, (undef, $gid)); |
| $dbh->do('UPDATE flagtypes SET request_group_id = ? |
| WHERE request_group_id = ?', |
| undef, (undef, $gid)); |
| $dbh->do('DELETE FROM namedquery_group_map WHERE group_id = ?', |
| undef, $gid); |
| $dbh->do('DELETE FROM user_group_map WHERE group_id = ?', |
| undef, $gid); |
| $dbh->do('DELETE FROM group_group_map |
| WHERE grantor_id = ? OR member_id = ?', |
| undef, ($gid, $gid)); |
| $dbh->do('DELETE FROM bug_group_map WHERE group_id = ?', |
| undef, $gid); |
| $dbh->do('DELETE FROM group_control_map WHERE group_id = ?', |
| undef, $gid); |
| $dbh->do('DELETE FROM whine_schedules |
| WHERE mailto_type = ? AND mailto = ?', |
| undef, (MAILTO_GROUP, $gid)); |
| $dbh->do('DELETE FROM groups WHERE id = ?', |
| undef, $gid); |
| |
| delete_token($token); |
| |
| $vars->{'message'} = 'group_deleted'; |
| $vars->{'groups'} = [Bugzilla::Group->get_all]; |
| |
| print $cgi->header(); |
| $template->process("admin/groups/list.html.tmpl", $vars) |
| || ThrowTemplateError($template->error()); |
| exit; |
| } |
| |
| # |
| # action='postchanges' -> update the groups |
| # |
| |
| if ($action eq 'postchanges') { |
| check_token_data($token, 'edit_group'); |
| my $changes = doGroupChanges(); |
| delete_token($token); |
| |
| my $group = new Bugzilla::Group($cgi->param('group_id')); |
| get_current_and_available($group, $vars); |
| $vars->{'message'} = 'group_updated'; |
| $vars->{'group'} = $group; |
| $vars->{'changes'} = $changes; |
| $vars->{'token'} = issue_session_token('edit_group'); |
| |
| print $cgi->header(); |
| $template->process("admin/groups/edit.html.tmpl", $vars) |
| || ThrowTemplateError($template->error()); |
| exit; |
| } |
| |
| if ($action eq 'confirm_remove') { |
| my $group = new Bugzilla::Group(CheckGroupID($cgi->param('group_id'))); |
| $vars->{'group'} = $group; |
| $vars->{'regexp'} = CheckGroupRegexp($cgi->param('regexp')); |
| $vars->{'token'} = issue_session_token('remove_group_members'); |
| $template->process('admin/groups/confirm-remove.html.tmpl', $vars) |
| || ThrowTemplateError($template->error()); |
| exit; |
| } |
| |
| if ($action eq 'remove_regexp') { |
| check_token_data($token, 'remove_group_members'); |
| # remove all explicit users from the group with |
| # gid = $cgi->param('group') that match the regular expression |
| # stored in the DB for that group or all of them period |
| |
| my $group = new Bugzilla::Group(CheckGroupID($cgi->param('group_id'))); |
| my $regexp = CheckGroupRegexp($cgi->param('regexp')); |
| |
| $dbh->bz_start_transaction(); |
| |
| my $users = $group->members_direct(); |
| my $sth_delete = $dbh->prepare( |
| "DELETE FROM user_group_map |
| WHERE user_id = ? AND isbless = 0 AND group_id = ?"); |
| |
| my @deleted; |
| foreach my $member (@$users) { |
| if ($regexp eq '' || $member->login =~ m/$regexp/i) { |
| $sth_delete->execute($member->id, $group->id); |
| push(@deleted, $member); |
| } |
| } |
| $dbh->bz_commit_transaction(); |
| |
| $vars->{'users'} = \@deleted; |
| $vars->{'regexp'} = $regexp; |
| delete_token($token); |
| |
| $vars->{'message'} = 'group_membership_removed'; |
| $vars->{'group'} = $group->name; |
| $vars->{'groups'} = [Bugzilla::Group->get_all]; |
| |
| print $cgi->header(); |
| $template->process("admin/groups/list.html.tmpl", $vars) |
| || ThrowTemplateError($template->error()); |
| |
| exit; |
| } |
| |
| |
| # |
| # No valid action found |
| # |
| |
| ThrowCodeError("action_unrecognized", $vars); |
| |
| |
| # Helper sub to handle the making of changes to a group |
| sub doGroupChanges { |
| my $cgi = Bugzilla->cgi; |
| my $dbh = Bugzilla->dbh; |
| |
| $dbh->bz_start_transaction(); |
| |
| # Check that the given group ID is valid and make a Group. |
| my $group = new Bugzilla::Group(CheckGroupID($cgi->param('group_id'))); |
| |
| if (defined $cgi->param('regexp')) { |
| $group->set_user_regexp($cgi->param('regexp')); |
| } |
| |
| if ($group->is_bug_group) { |
| if (defined $cgi->param('name')) { |
| $group->set_name($cgi->param('name')); |
| } |
| if (defined $cgi->param('desc')) { |
| $group->set_description($cgi->param('desc')); |
| } |
| # Only set isactive if we came from the right form. |
| if (defined $cgi->param('regexp')) { |
| $group->set_is_active($cgi->param('isactive')); |
| } |
| } |
| |
| if (defined $cgi->param('icon_url')) { |
| $group->set_icon_url($cgi->param('icon_url')); |
| } |
| |
| my $changes = $group->update(); |
| |
| my $sth_insert = $dbh->prepare('INSERT INTO group_group_map |
| (member_id, grantor_id, grant_type) |
| VALUES (?, ?, ?)'); |
| |
| my $sth_delete = $dbh->prepare('DELETE FROM group_group_map |
| WHERE member_id = ? |
| AND grantor_id = ? |
| AND grant_type = ?'); |
| |
| # First item is the type, second is whether or not it's "reverse" |
| # (granted_by) (see _do_add for more explanation). |
| my %fields = ( |
| members => [GROUP_MEMBERSHIP, 0], |
| bless_from => [GROUP_BLESS, 0], |
| visible_from => [GROUP_VISIBLE, 0], |
| member_of => [GROUP_MEMBERSHIP, 1], |
| bless_to => [GROUP_BLESS, 1], |
| visible_to_me => [GROUP_VISIBLE, 1] |
| ); |
| while (my ($field, $data) = each %fields) { |
| _do_add($group, $changes, $sth_insert, "${field}_add", |
| $data->[0], $data->[1]); |
| _do_remove($group, $changes, $sth_delete, "${field}_remove", |
| $data->[0], $data->[1]); |
| } |
| |
| $dbh->bz_commit_transaction(); |
| return $changes; |
| } |
| |
| sub _do_add { |
| my ($group, $changes, $sth_insert, $field, $type, $reverse) = @_; |
| my $cgi = Bugzilla->cgi; |
| |
| my $current; |
| # $reverse means we're doing a granted_by--that is, somebody else |
| # is granting us something. |
| if ($reverse) { |
| $current = $group->granted_by_direct($type); |
| } |
| else { |
| $current = $group->grant_direct($type); |
| } |
| |
| my $add_items = Bugzilla::Group->new_from_list([$cgi->param($field)]); |
| |
| foreach my $add (@$add_items) { |
| next if grep($_->id == $add->id, @$current); |
| |
| $changes->{$field} ||= []; |
| push(@{$changes->{$field}}, $add->name); |
| # They go this direction for a normal "This group is granting |
| # $add something." |
| my @ids = ($add->id, $group->id); |
| # But they get reversed for "This group is being granted something |
| # by $add." |
| @ids = reverse @ids if $reverse; |
| $sth_insert->execute(@ids, $type); |
| } |
| } |
| |
| sub _do_remove { |
| my ($group, $changes, $sth_delete, $field, $type, $reverse) = @_; |
| my $cgi = Bugzilla->cgi; |
| my $remove_items = Bugzilla::Group->new_from_list([$cgi->param($field)]); |
| |
| foreach my $remove (@$remove_items) { |
| my @ids = ($remove->id, $group->id); |
| # See _do_add for an explanation of $reverse |
| @ids = reverse @ids if $reverse; |
| # Deletions always succeed and are harmless if they fail, so we |
| # don't need to do any checks. |
| $sth_delete->execute(@ids, $type); |
| $changes->{$field} ||= []; |
| push(@{$changes->{$field}}, $remove->name); |
| } |
| } |