AX: Unship some ARIA string reflectors that are to-be-replaced by element reflection
https://bugs.webkit.org/show_bug.cgi?id=197764
<rdar://problem/50649689>
Patch by Greg Doolittle <gr3g@apple.com> on 2019-05-16
Reviewed by Chris Fleizach.
Specifically these:
- ariaActiveDescendant
- ariaControls
- ariaDescribedBy
- ariaDetails
- ariaErrorMessage
- ariaFlowTo
- ariaLabelledBy
- ariaOwns
Source/WebCore:
Test: LayoutTests/accessibility/ARIA-reflections.html (updated)
* accessibility/AriaAttributes.idl:
LayoutTests:
* accessibility/ARIA-reflection-expected.txt: Updated.
* accessibility/ARIA-reflection.html: Updated.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@245429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 776cb3f..9aa7bd1 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,24 @@
+2019-05-16 Greg Doolittle <gr3g@apple.com>
+
+ AX: Unship some ARIA string reflectors that are to-be-replaced by element reflection
+ https://bugs.webkit.org/show_bug.cgi?id=197764
+ <rdar://problem/50649689>
+
+ Reviewed by Chris Fleizach.
+
+ Specifically these:
+ - ariaActiveDescendant
+ - ariaControls
+ - ariaDescribedBy
+ - ariaDetails
+ - ariaErrorMessage
+ - ariaFlowTo
+ - ariaLabelledBy
+ - ariaOwns
+
+ * accessibility/ARIA-reflection-expected.txt: Updated.
+ * accessibility/ARIA-reflection.html: Updated.
+
2019-05-16 John Wilander <wilander@apple.com>
Storage Access API: Call completion handlers in NetworkConnectionToWebProcess::hasStorageAccess() and NetworkConnectionToWebProcess::requestStorageAccess() when feature is off
diff --git a/LayoutTests/accessibility/ARIA-reflection-expected.txt b/LayoutTests/accessibility/ARIA-reflection-expected.txt
index cbf356b..9504b69 100644
--- a/LayoutTests/accessibility/ARIA-reflection-expected.txt
+++ b/LayoutTests/accessibility/ARIA-reflection-expected.txt
@@ -12,14 +12,6 @@
element.setAttribute("role", otherData);
PASS element[currentProperty] is otherData
-Test ariaActiveDescendant < - > aria-activedescendant
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaActiveDescendant"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-activedescendant", otherData);
-PASS element[currentProperty] is otherData
-
Test ariaAtomic < - > aria-atomic
PASS element[currentProperty] is null
PASS element.getAttribute(currentAttribute) is null
@@ -76,14 +68,6 @@
element.setAttribute("aria-colspan", otherData);
PASS element[currentProperty] is otherData
-Test ariaControls < - > aria-controls
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaControls"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-controls", otherData);
-PASS element[currentProperty] is otherData
-
Test ariaCurrent < - > aria-current
PASS element[currentProperty] is null
PASS element.getAttribute(currentAttribute) is null
@@ -92,22 +76,6 @@
element.setAttribute("aria-current", otherData);
PASS element[currentProperty] is otherData
-Test ariaDescribedBy < - > aria-describedby
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaDescribedBy"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-describedby", otherData);
-PASS element[currentProperty] is otherData
-
-Test ariaDetails < - > aria-details
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaDetails"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-details", otherData);
-PASS element[currentProperty] is otherData
-
Test ariaDisabled < - > aria-disabled
PASS element[currentProperty] is null
PASS element.getAttribute(currentAttribute) is null
@@ -116,14 +84,6 @@
element.setAttribute("aria-disabled", otherData);
PASS element[currentProperty] is otherData
-Test ariaErrorMessage < - > aria-errormessage
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaErrorMessage"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-errormessage", otherData);
-PASS element[currentProperty] is otherData
-
Test ariaExpanded < - > aria-expanded
PASS element[currentProperty] is null
PASS element.getAttribute(currentAttribute) is null
@@ -132,14 +92,6 @@
element.setAttribute("aria-expanded", otherData);
PASS element[currentProperty] is otherData
-Test ariaFlowTo < - > aria-flowto
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaFlowTo"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-flowto", otherData);
-PASS element[currentProperty] is otherData
-
Test ariaHasPopup < - > aria-haspopup
PASS element[currentProperty] is null
PASS element.getAttribute(currentAttribute) is null
@@ -180,14 +132,6 @@
element.setAttribute("aria-label", otherData);
PASS element[currentProperty] is otherData
-Test ariaLabelledBy < - > aria-labelledby
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaLabelledBy"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-labelledby", otherData);
-PASS element[currentProperty] is otherData
-
Test ariaLevel < - > aria-level
PASS element[currentProperty] is null
PASS element.getAttribute(currentAttribute) is null
@@ -236,14 +180,6 @@
element.setAttribute("aria-orientation", otherData);
PASS element[currentProperty] is otherData
-Test ariaOwns < - > aria-owns
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaOwns"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-owns", otherData);
-PASS element[currentProperty] is otherData
-
Test ariaPlaceholder < - > aria-placeholder
PASS element[currentProperty] is null
PASS element.getAttribute(currentAttribute) is null
@@ -381,7 +317,7 @@
PASS element[currentProperty] is otherData
-PASS count is 46
+PASS count is 38
PASS successfullyParsed is true
TEST COMPLETE
diff --git a/LayoutTests/accessibility/ARIA-reflection.html b/LayoutTests/accessibility/ARIA-reflection.html
index 0b639c1..323b189 100644
--- a/LayoutTests/accessibility/ARIA-reflection.html
+++ b/LayoutTests/accessibility/ARIA-reflection.html
@@ -59,7 +59,7 @@
}
debug("\n");
- shouldBe("count", "46");
+ shouldBe("count", "38");
} else {
testFailed("Could not load accessibility controller");
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 38f453d..6e0da59 100644
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,25 @@
+2019-05-16 Greg Doolittle <gr3g@apple.com>
+
+ AX: Unship some ARIA string reflectors that are to-be-replaced by element reflection
+ https://bugs.webkit.org/show_bug.cgi?id=197764
+ <rdar://problem/50649689>
+
+ Reviewed by Chris Fleizach.
+
+ Specifically these:
+ - ariaActiveDescendant
+ - ariaControls
+ - ariaDescribedBy
+ - ariaDetails
+ - ariaErrorMessage
+ - ariaFlowTo
+ - ariaLabelledBy
+ - ariaOwns
+
+ Test: LayoutTests/accessibility/ARIA-reflections.html (updated)
+
+ * accessibility/AriaAttributes.idl:
+
2019-05-16 Youenn Fablet <youenn@apple.com>
CoreAudioCaptureSource should be marked as an audio capture track
diff --git a/Source/WebCore/accessibility/AriaAttributes.idl b/Source/WebCore/accessibility/AriaAttributes.idl
index 8422b53..d2874a7 100644
--- a/Source/WebCore/accessibility/AriaAttributes.idl
+++ b/Source/WebCore/accessibility/AriaAttributes.idl
@@ -27,7 +27,6 @@
EnabledAtRuntime=AriaReflection,
NoInterfaceObject,
] interface AriaAttributes {
- [Reflect=aria_activedescendant] attribute DOMString? ariaActiveDescendant;
[Reflect=aria_atomic] attribute DOMString? ariaAtomic;
[Reflect=aria_autocomplete] attribute DOMString? ariaAutoComplete;
[Reflect=aria_busy] attribute DOMString? ariaBusy;
@@ -35,27 +34,20 @@
[Reflect=aria_colcount] attribute DOMString? ariaColCount;
[Reflect=aria_colindex] attribute DOMString? ariaColIndex;
[Reflect=aria_colspan] attribute DOMString? ariaColSpan;
- [Reflect=aria_controls] attribute DOMString? ariaControls;
[Reflect=aria_current] attribute DOMString? ariaCurrent;
- [Reflect=aria_describedby] attribute DOMString? ariaDescribedBy;
- [Reflect=aria_details] attribute DOMString? ariaDetails;
[Reflect=aria_disabled] attribute DOMString? ariaDisabled;
- [Reflect=aria_errormessage] attribute DOMString? ariaErrorMessage;
[Reflect=aria_expanded] attribute DOMString? ariaExpanded;
- [Reflect=aria_flowto] attribute DOMString? ariaFlowTo;
[Reflect=aria_haspopup] attribute DOMString? ariaHasPopup;
[Reflect=aria_hidden] attribute DOMString? ariaHidden;
[Reflect=aria_invalid] attribute DOMString? ariaInvalid;
[Reflect=aria_keyshortcuts] attribute DOMString? ariaKeyShortcuts;
[Reflect=aria_label] attribute DOMString? ariaLabel;
- [Reflect=aria_labelledby] attribute DOMString? ariaLabelledBy;
[Reflect=aria_level] attribute DOMString? ariaLevel;
[Reflect=aria_live] attribute DOMString? ariaLive;
[Reflect=aria_modal] attribute DOMString? ariaModal;
[Reflect=aria_multiline] attribute DOMString? ariaMultiLine;
[Reflect=aria_multiselectable] attribute DOMString? ariaMultiSelectable;
[Reflect=aria_orientation] attribute DOMString? ariaOrientation;
- [Reflect=aria_owns] attribute DOMString? ariaOwns;
[Reflect=aria_placeholder] attribute DOMString? ariaPlaceholder;
[Reflect=aria_posinset] attribute DOMString? ariaPosInSet;
[Reflect=aria_pressed] attribute DOMString? ariaPressed;
