commit f1095492798604e06f5352119d809a23fbfb4219
author youenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Mon Oct 14 15:37:03 2019 +0000
committer youenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Mon Oct 14 15:37:03 2019 +0000
tree 27c1ed74ff8f4e7186693f959d015d40be29cc02
parent 6ada3cd2e0d9b9e450b5e021e0e5526f55f59df8

Reuse existing web processes for running service workers
https://bugs.webkit.org/show_bug.cgi?id=202195

Unreviewed.


* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disableServiceWorkers):
(WebKit::WebProcessProxy::enableServiceWorkers):
Fix case where ENABLE_SERVICE_WORKER is not defined.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@251073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog

diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
index 75aaac4..142a709 100644
--- a/Source/WebKit/ChangeLog
+++ b/Source/WebKit/ChangeLog
@@ -1,3 +1,15 @@
+2019-10-14  youenn fablet  <youenn@apple.com>
+
+        Reuse existing web processes for running service workers
+        https://bugs.webkit.org/show_bug.cgi?id=202195
+
+        Unreviewed.
+
+        * UIProcess/WebProcessProxy.cpp:
+        (WebKit::WebProcessProxy::disableServiceWorkers):
+        (WebKit::WebProcessProxy::enableServiceWorkers):
+        Fix case where ENABLE_SERVICE_WORKER is not defined.
+
 2019-10-14  Philippe Normand  <pnormand@igalia.com>
 
         [GTK][WebInspector] Support for saving data

Source/WebKit/UIProcess/WebProcessProxy.cpp

diff --git a/Source/WebKit/UIProcess/WebProcessProxy.cpp b/Source/WebKit/UIProcess/WebProcessProxy.cpp
index 6988654..e00c8df 100644
--- a/Source/WebKit/UIProcess/WebProcessProxy.cpp
+++ b/Source/WebKit/UIProcess/WebProcessProxy.cpp
@@ -1568,6 +1568,7 @@
     ASSERT(m_serviceWorkerInformation);
     send(Messages::WebSWContextManagerConnection::UpdatePreferencesStore { store }, 0);
 }
+#endif
 
 void WebProcessProxy::disableServiceWorkers()
 {
@@ -1575,9 +1576,11 @@
         return;
 
     m_serviceWorkerInformation = { };
-    processPool().removeFromServiceWorkerProcesses(*this);
 
+#if ENABLE(SERVICE_WORKER)
+    processPool().removeFromServiceWorkerProcesses(*this);
     send(Messages::WebSWContextManagerConnection::Close { }, 0);
+#endif
 
     maybeShutDown();
 }
@@ -1588,7 +1591,6 @@
     ASSERT(!m_serviceWorkerInformation);
     m_serviceWorkerInformation = ServiceWorkerInformation { WebPageProxyIdentifier::generate(), PageIdentifier::generate() };
 }
-#endif
 
 } // namespace WebKit