Context menu for local storage puts quotes around key and value
https://bugs.webkit.org/show_bug.cgi?id=209868
Reviewed by Joseph Pecoraro.
There are only two `WI.DataGrid` that support editing right now. Both of them use obvious
names for their columns (e.g. "Key", "Name", "Value", etc.), so rather than quote the column
name in the context menu, just display it as is.
* UserInterface/Views/DataGrid.js:
(WI.DataGrid.prototype._contextMenuInDataTable):
* Localizations/en.lproj/localizedStrings.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@259437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
index 58fb4d0..d47b403 100644
--- a/Source/WebInspectorUI/ChangeLog
+++ b/Source/WebInspectorUI/ChangeLog
@@ -1,3 +1,19 @@
+2020-04-02 Devin Rousso <drousso@apple.com>
+
+ Context menu for local storage puts quotes around key and value
+ https://bugs.webkit.org/show_bug.cgi?id=209868
+
+ Reviewed by Joseph Pecoraro.
+
+ There are only two `WI.DataGrid` that support editing right now. Both of them use obvious
+ names for their columns (e.g. "Key", "Name", "Value", etc.), so rather than quote the column
+ name in the context menu, just display it as is.
+
+ * UserInterface/Views/DataGrid.js:
+ (WI.DataGrid.prototype._contextMenuInDataTable):
+
+ * Localizations/en.lproj/localizedStrings.js:
+
2020-04-02 Nikita Vasilyev <nvasilyev@apple.com>
Web Inspector: Network tab summary bar jiggles
diff --git a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
index ba0ee62..ae23a9c 100644
--- a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
+++ b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
@@ -448,9 +448,9 @@
/* Label for a guide within the color picker */
localizedStrings["Edge of sRGB color space"] = "Edge of sRGB color space";
localizedStrings["Edit"] = "Edit";
+localizedStrings["Edit %s"] = "Edit %s";
localizedStrings["Edit Breakpoint\u2026"] = "Edit Breakpoint\u2026";
localizedStrings["Edit Local Override\u2026"] = "Edit Local Override\u2026";
-localizedStrings["Edit \u201C%s\u201D"] = "Edit \u201C%s\u201D";
localizedStrings["Edit \u201Cbox-shadow\u201D"] = "Edit \u201Cbox-shadow\u201D";
localizedStrings["Edit \u201Ccubic-bezier\u201D function"] = "Edit \u201Ccubic-bezier\u201D function";
localizedStrings["Edit \u201Cspring\u201D function"] = "Edit \u201Cspring\u201D function";
diff --git a/Source/WebInspectorUI/UserInterface/Views/DataGrid.js b/Source/WebInspectorUI/UserInterface/Views/DataGrid.js
index 0d71595..8f60e7e 100644
--- a/Source/WebInspectorUI/UserInterface/Views/DataGrid.js
+++ b/Source/WebInspectorUI/UserInterface/Views/DataGrid.js
@@ -1670,7 +1670,7 @@
let element = event.target.closest("td");
let columnIdentifier = element.__columnIdentifier;
let columnTitle = this.dataGrid.columns.get(columnIdentifier)["title"];
- contextMenu.appendItem(WI.UIString("Edit \u201C%s\u201D").format(columnTitle), this._startEditing.bind(this, event.target));
+ contextMenu.appendItem(WI.UIString("Edit %s").format(columnTitle), this._startEditing.bind(this, event.target));
}
}
