Google Git
Sign in
webkit / WebKit / e953f867e4516f7624b0abb4fcc5cb74d1bf3f50 / . / WebCore / ChangeLog
blob: 88c6d59c01f03255b6f5251aaf4649492feea1a2 [file] [log] [blame]
2008-09-06 Antti Koivisto <antti@apple.com>
Reviewed by Dan Bernstein.
Fix <rdar://problem/6201644>
https://bugs.webkit.org/show_bug.cgi?id=20493
Crash after OK in dialog box and reloading page in secure mode
Limited loader only fix since the general timer fix is causing problems on Windows.
* loader/loader.cpp:
(WebCore::Loader::servePendingRequests):
(WebCore::Loader::Host::Host):
(WebCore::Loader::Host::didFinishLoading):
(WebCore::Loader::Host::didFail):
(WebCore::Loader::Host::didReceiveData):
* loader/loader.h:
(WebCore::Loader::Host::processingResource):
2008-09-06 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
The initial Core Text adoption prototype was made by Daniel Fenwick.
- <rdar://problem/5158514> Add a Core Text-based complex text code path
Currently the Core Text code path is not used in any configuration.
* WebCore.xcodeproj/project.pbxproj: Added files.
* config.h: Defined WTF_USE_ATSUI and WTF_USE_CORE_TEXT.
* platform/graphics/Font.cpp:
(WebCore::WidthIterator::advance): Moved the spacingDisabled() test out
of the loop.
* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::add): Added this version that takes an advance.
* platform/graphics/SimpleFontData.h: Added ATSUI and CORE_TEXT #ifdefs.
Added getCTFont() and getCFStringAttributes() and corresponding data
members for Core Text.
* platform/graphics/mac/CoreTextController.cpp: Added.
(WebCore::roundCGFloat): Helper function.
(WebCore::ceilCGFloat): Helper function.
(WebCore::CoreTextController::CoreTextRun::CoreTextRun):
(WebCore::CoreTextController::CoreTextController):
(WebCore::CoreTextController::offsetForPosition):
(WebCore::CoreTextController::collectCoreTextRuns): Added. Segments the
run into subruns as necessary such that each subrun can be rendered with
a single font. Also separates out soft hyphens and replaces them with
real hyphens, because Core Text does not emit a glyph for soft hyphens.
Then calls collectCoreTextRunsForCharacters() on each subrun.
(WebCore::CoreTextController::advance):
(WebCore::CoreTextController::collectCoreTextRunsForCharacters): Creates
a CTLine from the given subrun and collects its CoreTextRuns.
(WebCore::CoreTextController::adjustGlyphsAndAdvances): Applies the
rounding hacks, letter- and word-spacing and glyph substitutions and
stores the resulting adjusted glyphs and advances.
* platform/graphics/mac/CoreTextController.h: Copied from WebCore/platform/graphics/win/UniscribeController.h.
(WebCore::CoreTextController::totalWidth):
(WebCore::CoreTextController::finalRoundingWidth):
(WebCore::CoreTextController::CoreTextRun::ctRun):
(WebCore::CoreTextController::CoreTextRun::glyphCount):
(WebCore::CoreTextController::CoreTextRun::fontData):
(WebCore::CoreTextController::CoreTextRun::characters):
(WebCore::CoreTextController::CoreTextRun::stringLocation):
(WebCore::CoreTextController::CoreTextRun::stringLength):
(WebCore::CoreTextController::CoreTextRun::indexAt):
* platform/graphics/mac/FontMac.mm: Moved the ATSUI-specific parts to
FontMacATSUI.mm.
* platform/graphics/mac/FontMacATSUI.mm: Copied from WebCore/platform/graphics/mac/FontMac.mm.
(WebCore::disableLigatures): Changed to call
FontPlatformData::allowsLigatures().
(WebCore::overrideLayoutOperation): Changed to call
FontPlatformData::roundsGlyphAdvances().
* platform/graphics/mac/FontMacCoreText.cpp: Copied from WebCore/platform/graphics/win/FontWin.cpp.
(WebCore::Font::selectionRectForComplexText): Changed to use
totalWidth() instead of advancing to the end and using runWidthSoFar().
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/mac/FontPlatformData.h:
* platform/graphics/mac/FontPlatformDataMac.mm:
(WebCore::FontPlatformData::setFont):
(WebCore::FontPlatformData::roundsGlyphAdvances): Added. Checks the
AppKit rendering mode.
(WebCore::FontPlatformData::allowsLigatures): Added. Implements the
heuristic that allows ligatures in fonts that do not have a glyph for
'a', based on the assumption that such fonts are only used in complex
text.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::getCTFont): Added.
(WebCore::SimpleFontData::getCFStringAttributes): Added. Caches and
returns an attributes dictionary.
* platform/text/mac/ShapeArabic.c: Added ATSUI #ifdefs.
* platform/text/mac/ShapeArabic.h: Ditto.
2008-09-06 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- make combining mark offsets work in CG text on Windows
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs): The old code tried to translate the text
matrix, but failed for two reasons: it did not actually change the
matrix, and even if it did, CGContextSetTextPosition overwrites the
translation values in the text matrix. Instead, just added the
translation to the anchor point.
2008-09-05 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Alp Toker.
https://bugs.webkit.org/show_bug.cgi?id=18346
[GTK] Remove build warnings
Applied some casts, and removed an unused typedef to make the
compiler happy, printing less warnings when building.
* page/gtk/AccessibilityObjectWrapperAtk.cpp:
* platform/graphics/gtk/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::containsCharacters):
* platform/graphics/gtk/VideoSinkGStreamer.cpp:
(webkit_video_sink_set_caps):
* platform/network/soup/ResourceHandleSoup.cpp:
2008-09-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Roben.
Build fix for WebKitWin and Chromium
* platform/FileSystem.h:
2008-09-05 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Try to make Chromium compile with ToT:
- Wrap a few places which depend on KJS:: in #if USE(JSC)
- Include some windows forward declarations
* dom/Node.h:
* page/Console.h:
* page/animation/CompositeAnimation.h:
* platform/FileSystem.h:
* platform/graphics/Image.h:
* platform/text/AtomicString.h:
* platform/text/String.cpp:
* rendering/style/RenderStyle.h:
2008-09-05 Dave Hyatt <hyatt@apple.com>
Add support for runtime switchability of the Aqua look and the native look on Windows.
Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set.
Reviewed by Adam Roben
* WebCore.vcproj/WebCore.vcproj:
* page/Settings.cpp:
(WebCore::Settings::setShouldPaintNativeControls):
* page/Settings.h:
(WebCore::Settings::shouldPaintNativeControls):
* rendering/RenderThemeSafari.cpp:
(WebCore::theme):
* rendering/RenderThemeWin.cpp:
2008-09-05 Antti Koivisto <antti@apple.com>
Qt build fix.
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::build):
2008-09-05 Dirk Schulze <vbs85@gmx.de>
Gtk build fix
* GNUmakefile.am:
2008-09-05 Antti Koivisto <antti@apple.com>
Another build fix.
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::notifyFinished):
2008-09-05 Antti Koivisto <antti@apple.com>
Build fixes.
* WebCore.xcodeproj/project.pbxproj:
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::cachedImage):
2008-09-05 Antti Koivisto <antti@apple.com>
Reviewed by Darin Adler.
Most of the implementation for https://bugs.webkit.org/show_bug.cgi?id=17998
When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation"
Implement HTTP 1.1 "Specific end-to-end revalidation" for WebCore memory cache. This patch does
not yet enable it for the biggest use case, reloading. However it is good for general browsing as
well. Doing this in WebCore level as opposed to relying on disk cache has big benefit that
we avoid re-decoding resources, especially images.
To be exact the enabled case is not actually the "Specific end-to-end revalidation" since it does not include
CacheControl: max-age=0 header. That would be added in reload case.
The approach for revalidation is to kick the original resource out from the memory cache
and create a new CachedResource that represents the revalidation request. In case
we get 304 back for the request we put the original resource back to the cache, update
its expiration date and switch the clients registered to revalidation resource to be
clients of the original resource.
All heap allocated CachedImage pointers now use CachedResourceHandle<CachedImage> (and so on) instead.
This allows updating the handles to point to the original resource when the revalidation succeeds. It
also acts as refcounting smart pointer.
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSFontFaceSource.h:
* css/CSSImportRule.h:
* dom/Clipboard.h:
(WebCore::Clipboard::dragImage):
* dom/ProcessingInstruction.h:
* dom/ScriptElement.h:
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::isWaitingForScripts):
* dom/XMLTokenizer.h:
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::setImage):
(WebCore::HTMLImageLoader::updateFromElement):
(WebCore::HTMLImageLoader::notifyFinished):
* html/HTMLImageLoader.h:
(WebCore::HTMLImageLoader::image):
* html/HTMLLinkElement.h:
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::scriptHandler):
(WebCore::HTMLTokenizer::notifyFinished):
* html/HTMLTokenizer.h:
* loader/Cache.cpp:
(WebCore::Cache::revalidateResource):
(WebCore::Cache::revalidationSucceeded):
(WebCore::Cache::revalidationFailed):
* loader/Cache.h:
* loader/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::isExpired):
(WebCore::CachedResource::setResponse):
(WebCore::CachedResource::deleteIfPossible):
(WebCore::CachedResource::setResourceToRevalidate):
(WebCore::CachedResource::clearResourceToRevalidate):
(WebCore::CachedResource::switchClientsToRevalidatedResource):
(WebCore::CachedResource::canUseCacheValidator):
(WebCore::CachedResource::mustRevalidate):
* loader/CachedResource.h:
(WebCore::CachedResource::canDelete):
(WebCore::CachedResource::registerHandle):
(WebCore::CachedResource::unregisterHandle):
(WebCore::CachedResource::isCacheValidator):
(WebCore::CachedResource::resourceToRevalidate):
(WebCore::CachedResource::setExpirationDate):
* loader/CachedResourceHandle.cpp: Added.
(WebCore::CachedResourceHandleBase::setResource):
* loader/CachedResourceHandle.h: Added.
(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::get):
(WebCore::CachedResourceHandleBase::operator!):
(WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::operator=):
(WebCore::CachedResourceHandle::CachedResourceHandle):
(WebCore::CachedResourceHandle::get):
(WebCore::CachedResourceHandle::operator->):
(WebCore::CachedResourceHandle::operator=):
(WebCore::CachedResourceHandle::operator==):
(WebCore::CachedResourceHandle::operator!=):
(WebCore::operator==):
(WebCore::operator!=):
* loader/DocLoader.cpp:
(WebCore::DocLoader::checkForReload):
* loader/UserStyleSheetLoader.h:
* loader/loader.cpp:
(WebCore::Loader::Host::servePendingRequests):
(WebCore::Loader::Host::didFinishLoading):
(WebCore::Loader::Host::didFail):
(WebCore::Loader::Host::didReceiveResponse):
(WebCore::Loader::Host::didReceiveData):
* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::setCachedImage):
(WebCore::RenderImage::imageChanged):
* rendering/RenderImage.h:
(WebCore::RenderImage::cachedImage):
(WebCore::RenderImage::imagePtr):
* rendering/style/RenderStyle.h:
* rendering/style/StyleCachedImage.h:
(WebCore::StyleCachedImage::data):
(WebCore::StyleCachedImage::cachedImage):
* svg/SVGFEImageElement.h:
* svg/graphics/filters/SVGFEImage.h:
* xml/XSLImportRule.h:
2008-09-04 Brady Eidson <beidson@apple.com>
Reviewed by Mitz
<rdar://problem/6180236> - Safari times out connections after 1 or 2 minutes
A 60-second default timeout was added in http://trac.webkit.org/changeset/17144 in an attempt
to model default NSURLRequest behavior in a cross-platform manner.
Sadly by always enforcing this 60 second timeout, WebCore was stomping over the wishes of any Webkit
client that wished to enforce a much larger default timeout using NSURLRequest API.
Additionally, upon reviewing what all other browsers do, it seems apparent that "no limit" is desirable
behavior on the web and this restores previous Safari/WebKit behavior.
It would be easy to write a layout test for this, but to be effective it would have
to run for at least 61 seconds, which seems insane until will can parallelize run-webkit-tests
* manual-tests/timeout-test.html: Added.
* manual-tests/timeout-test.php: Added.
* platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::ResourceRequestBase): Rename the constant to "unspecifiedTimeoutInterval"
and make it UINT_MAX so platforms that do set it have an effective "no timeout." (Windows, for example)
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest): If the timeout for this request is
"unspecifiedTimeoutInterval", then don't bother setting the timeout using NSURLRequest API, allowing
WebKit applications to enforce their own default timeout.
2008-09-04 Dan Bernstein <mitz@apple.com>
Reviewed by Beth Dakin.
- fix <rdar://problem/6198514> Changing a button's opacity triggers relayout
Test: fast/repaint/button-spurious-layout-hint.html
* rendering/RenderButton.cpp:
(WebCore::RenderButton::setStyle): Reset the inner block's style box
flex to 0 to avoid getting a spurious layout hint.
2008-09-04 Kevin Ollivier <kevino@theolliviers.com>
wx build fixes.
* WebCoreSources.bkl:
* bindings/js/ScriptControllerWx.cpp: Added.
(WebCore::ScriptController::createScriptInstanceForWidget):
* page/wx/AccessibilityObjectWx.cpp: Added.
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
* platform/graphics/wx/GraphicsContextWx.cpp:
* webcore-base.bkl:
* webcore-wx.bkl:
2008-09-04 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
- roll out r36050 because it made svg/custom/invalid-fill-hex.svg fail,
and fixing https://bugs.webkit.org/show_bug.cgi?id=15360 appears to
require a different approach
* css/CSSGrammar.y:
2008-09-04 Mark Rowe <mrowe@apple.com>
Reviewed by Eric Seidel.
Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
* Configurations/WebCore.xcconfig: Remove ENABLE_DASHBOARD_SUPPORT from FEATURE_DEFINES.
* DerivedSources.make: Revert to checking for ENABLE_DASHBOARD_SUPPORT rather than looking
for ENABLE_DASHBOARD_SUPPORT in FEATURE_DEFINES.
2008-09-04 Mark Rowe <mrowe@apple.com>
Mac build fix.
* config.h: Only check the value of HAVE_CONFIG_H if it is defined.
2008-09-04 Eric Seidel <eric@webkit.org>
Build fix only, no review.
* dom/XMLTokenizer.cpp: Fix the Chromium merge build by adding a missing header (the Mac files must include it somewhere).
2008-09-04 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=20380
[GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h
* config.h: Include the configuration header generated by autotools if
available.
2008-09-04 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Dave Hyatt.
- rename CachedResource::allReferencesRemoved() to allClientsRemoved()
* loader/CachedFont.cpp:
(WebCore::CachedFont::allClientsRemoved):
* loader/CachedFont.h:
* loader/CachedImage.cpp:
(WebCore::CachedImage::allClientsRemoved):
* loader/CachedImage.h:
* loader/CachedResource.cpp:
(WebCore::CachedResource::removeClient):
* loader/CachedResource.h:
(WebCore::CachedResource::allClientsRemoved):
2008-09-04 Adam Roben <aroben@apple.com>
Windows build fix after r36071
We were getting these errors:
error C2356: initialization segment must not change during translation
unit
This was happening because multiple files #included by
DerivedSources.cpp were themselves #including StaticConstructors.h. I
fixed the error by adding header guards to StaticConstructors.h so its
contents will only be included once.
But it's also not a good idea for StaticConstructors.h to end up in
DerivedSources.cpp, since it ends up "polluting" all the source files
we have in there. So I removed all the files that include
StaticConstructors.h and added some preprocessor directives to
DerivedSources.cpp to catch this error in the future.
* DerivedSources.cpp: Removed the *Names.cpp files, which include
StaticConstructors.h, and added some preprocessor directives to make
sure we don't end up accidentally including StaticConstructors.h in
the future.
* WebCore.vcproj/WebCore.vcproj: Added the *Names.cpp files.
* platform/StaticConstructors.h: Added header guards.
2008-09-04 Adam Roben <aroben@apple.com>
Windows build fix
* platform/graphics/win/FontPlatformData.h: Added a missing #include
of PassRefPtr.h, and corrected the capitalization of RefCounted.h.
* platform/text/PlatformString.h: Added a missing #include of
PassRefPtr.h.
2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Fix the QtWebKit build to match changes in r36016
* WebCore.pro:
* bridge/qt/qt_instance.cpp:
(KJS::Bindings::QtInstance::getRuntimeObject):
* bridge/qt/qt_runtime.cpp:
(KJS::Bindings::convertQVariantToValue):
(KJS::Bindings::QtConnectionObject::execute):
2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Re-enable support for user stylesheets in QtWebKit
QtWebKit now follows the FRAME_LOADS_USER_STYLESHEET
code path, which allows us to keep API support for
loading user style sheets from remote URLs.
As part of the change UserStyleSheetLoader.cpp/h was
moved from WebCore/loader/mac to WebCore/loader.
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.h:
* loader/UserStyleSheetLoader.cpp: Renamed from WebCore/loader/mac/UserStyleSheetLoader.cpp.
(UserStyleSheetLoader::UserStyleSheetLoader):
(UserStyleSheetLoader::~UserStyleSheetLoader):
* loader/UserStyleSheetLoader.h: Renamed from WebCore/loader/mac/UserStyleSheetLoader.h.
* page/qt/FrameQt.cpp:
(WebCore::Frame::setUserStyleSheetLocation):
(WebCore::Frame::setUserStyleSheet):
2008-09-04 Alp Toker <alp@nuanti.com>
Reviewed by Eric.
Remove left-over QT and CAIRO platform checks.
* html/CanvasRenderingContext2D.cpp:
2008-09-04 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Fix leak of TextMetrics due to over-ref as see on buildbot.
* html/TextMetrics.h: use adoptRef since RefCounted starts @ refcount 1 instead of 0 now.
2008-09-04 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=19717
<rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutOnlyPositionedObjects): In the
positioned movement only case, call
tryLayoutDoingPositionedMovementOnly() and fall back on doing a full
layout if that fails.
(WebCore::RenderBlock::layoutPositionedObjects): Ditto.
* rendering/RenderBox.h:
(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): Renamed
layoutDoingPositionedMovementOnly to this, and made this function
check if the width changed. If it did, return, leaving the object
dirty. The caller can then call layout(). The width can change even
in the "positioned movement only" case if the object is shrink-to-fit
and the available width constraint is met. (This was the case in the
bug).
* rendering/RenderObject.h:
(WebCore::RenderObject::tryLayoutDoingPositionedMovementOnly):
Renamed layoutDoingPositionedMovementOnly() to this.
2008-09-03 Eric Seidel <eric@webkit.org>
No review, build fix only.
Attempt to fix the Qt build.
* WebCore.pro: add page/animation to include path
2008-09-03 Mark Rowe <mrowe@apple.com>
Mac build fix. Correctly detect whether dashboard support is enabled.
* DerivedSources.make:
2008-09-03 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)
* Configurations/WebCore.xcconfig: add missing ENABLE_*
* config.h: add rules for V8_BINDINGS
2008-09-03 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
https://bugs.webkit.org/show_bug.cgi?id=20620
Add #if USE(JSC) around KJS dependencies
Remove !USE(JAVASCRIPTCORE_BINDINGS) support for 3 reasons:
1. Most platforms have it on anyway
2. V8 is going to want to share some of that code
3. Those platforms which want it off, should have a separate file instead of an #ifdef in our .cpp
* bindings/js/JSPluginElementFunctions.cpp: remove !USE(JAVASCRIPTCORE_BINDINGS) support
* config.h: change JAVASCRIPTCORE_BINDINGS to JSC and add USE(V8)
* html/HTMLAppletElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
* html/HTMLAppletElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
* html/HTMLEmbedElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
* html/HTMLEmbedElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
* html/HTMLObjectElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
* html/HTMLObjectElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
* html/HTMLPlugInElement.cpp: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
* html/HTMLPlugInElement.h: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
* platform/text/AtomicString.cpp: add USE(JSC)
* platform/text/AtomicString.h: add USE(JSC)
* platform/text/PlatformString.h: add USE(JSC)
* platform/text/String.cpp: add USE(JSC)
* platform/text/StringImpl.cpp: add USE(JSC)
* platform/text/StringImpl.h: add USE(JSC)
2008-09-03 Dean McNamee <deanm@chromium.org>
Reviewed by Darin Adler.
Fix https://bugs.webkit.org/show_bug.cgi?id=20511
Bug 20511: Remove static initializers on Windows
Avoid static initializers on Windows by forcing Visual C++ to put
all static initializers in a code segment that is never executed.
* config.h:
* css/MediaFeatureNames.cpp:
* dom/EventNames.cpp:
* dom/QualifiedName.cpp:
* dom/make_names.pl:
* platform/StaticConstructors.h:
* platform/text/AtomicString.cpp:
2008-09-03 Dirk Schulze <vbs85@gmx.de>
Reviewed by Dave Hyatt.
Make FontCairo draw TextStroke and TextFill separately.
[CAIRO] draw TextFill and TextStroke separately.
[https://bugs.webkit.org/show_bug.cgi?id=20631]
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
2008-09-03 Peter Kasting <zerodpx@gmail.com>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=19663
Account for paint and timer lag when animating images. Also pretend
that images whose animations were paused (by becoming invisible)
continued to animate, by "catching up" to the correct frame when they're
shown again.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::startAnimation):
(WebCore::BitmapImage::advanceAnimation):
(WebCore::BitmapImage::internalAdvanceAnimation):
(WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
* platform/graphics/BitmapImage.h:
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/wx/ImageWx.cpp:
(WebCore::BitmapImage::draw):
2008-09-03 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
Remove the rest of the "zombie" code from the profiler.
- There is no longer a need for the ProfilerClient callback mechanism.
* page/Console.cpp:
(WebCore::Console::Console):
(WebCore::Console::profile):
(WebCore::Console::profileEnd): Move the variables from the header to
here since we don't have to wait for a callback to use them.
* page/Console.h:
* page/InspectorController.cpp:
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
* page/InspectorController.h:
2008-09-03 Ada Chan <adachan@apple.com>
Windows build fix.
* WebCore.vcproj/WebCore.vcproj: Added JSWebKitCSSKeyframeRule.cpp and JSWebKitCSSKeyframesRule.cpp to the project.
2008-09-01 Dean Jackson <dino@apple.com>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=20594
Add DOM interfaces for WebKitCSSKeyframeRule
and WebKitCSSKeyframesRule.
TEST: LayoutTests/css3/keyframes-rule.html
* css/WebKitCSSKeyframeRule.idl: Added
* css/WebKitCSSKeyframesRule.idl: Added
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
Add return of new JS Keyframe rules
* bindings/objc/DOMInternal.h:
Include new internal header
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
Build configs for new files
2008-09-03 Adam Roben <aroben@apple.com>
Windows build fix
* DerivedSources.cpp: Add JSTextMetrics.cpp to fix the build.
* WebCore.vcproj/WebCore.vcproj: Add JSTextMetrics.h for
convenience/consistency.
2008-09-03 Adele Peterson <adele@apple.com>
Build fix.
* WebCore.vcproj/WebCore.vcproj:
2008-09-03 David Hyatt <hyatt@apple.com>
Fix for bug 18203, right floats should be allowed to overflow past the left border edge.
Reviewed by Darin (ages ago)
Added fast/block/float/clamped-right-float.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionNewFloats):
2008-09-02 David Hyatt <hyatt@apple.com>
Add support for canvas text drawing APIs.
Reviewed by olliej
Tests added as fast/canvas/canvas-text-*.html
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2D::fillText):
(WebCore::JSCanvasRenderingContext2D::strokeText):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::applyPropertyToStyle):
* css/CSSStyleSelector.h:
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::font):
(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::textAlign):
(WebCore::CanvasRenderingContext2D::setTextAlign):
(WebCore::CanvasRenderingContext2D::textBaseline):
(WebCore::CanvasRenderingContext2D::setTextBaseline):
(WebCore::CanvasRenderingContext2D::fillText):
(WebCore::CanvasRenderingContext2D::strokeText):
(WebCore::CanvasRenderingContext2D::measureText):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
(WebCore::CanvasRenderingContext2D::accessFont):
* html/CanvasRenderingContext2D.h:
* html/CanvasRenderingContext2D.idl:
* html/TextMetrics.h: Added.
(WebCore::TextMetrics::create):
(WebCore::TextMetrics::width):
(WebCore::TextMetrics::setWidth):
(WebCore::TextMetrics::TextMetrics):
* html/TextMetrics.idl: Added.
* platform/graphics/Font.cpp:
(WebCore::Font::lineGap):
* platform/graphics/Font.h:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawBidiText):
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsTypes.cpp:
(WebCore::textAlignName):
(WebCore::parseTextAlign):
(WebCore::textBaselineName):
(WebCore::parseTextBaseline):
* platform/graphics/GraphicsTypes.h:
(WebCore::):
2008-09-03 John Sullivan <sullivan@apple.com>
Fixed <rdar://problem/6193022> <rdar://problem/6193022> Crash occurs at WebCore::AnimationBase::propertiesEqual () after certain steps
Fixed by Darin, reviewed by me
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::propertiesEqual):
added ensurePropertyMap() to this static function
(WebCore::AnimationBase::getPropertyAtIndex):
ditto
(WebCore::AnimationBase::getNumProperties):
ditto
2008-09-03 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin and Tim.
Remove most of the "zombie" mode from the profiler. Next we will need
to remove the client callback mechanism in profiles.
- These changes are a result of changes to JSCore.
* manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html:
* page/Console.cpp:
(WebCore::retrieveLastCaller):
(WebCore::Console::profileEnd):
* page/InspectorController.cpp:
(WebCore::InspectorController::stopUserInitiatedProfiling):
2008-09-03 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Test: fast/forms/search-display-none-cancel-button.html
Allow display:none to work on a search field's cancel button. Prepare for adding more style-ability for the results button too.
* css/html4.css: Set display:inline-block for these buttons. Now they can be overridden by a web author.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers.
(WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly. This is now done in html4.css.
(WebCore::RenderTextControl::createCancelButtonStyle): ditto.
(WebCore::RenderTextControl::createSubtreeIfNeeded):
Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class.
(WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers.
(WebCore::RenderTextControl::subtreeHasChanged): ditto.
(WebCore::RenderTextControl::calcHeight): ditto.
(WebCore::RenderTextControl::nodeAtPoint): ditto.
(WebCore::RenderTextControl::layout): ditto.
(WebCore::RenderTextControl::calcPrefWidths): ditto.
(WebCore::RenderTextControl::clientPaddingLeft): ditto.
(WebCore::RenderTextControl::clientPaddingRight): ditto.
* rendering/TextControlInnerElements.cpp:
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp.
(WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto.
(WebCore::TextControlInnerElement::attachInnerElement): Added.
This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element.
(WebCore::TextControlInnerTextElement::createRenderer): Added. Creates a RenderTextControlInnerBlock.
* rendering/TextControlInnerElements.h:
2008-08-28 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Maciej.
Elminate SQLiteAuthorizer class.
* WebCore.xcodeproj/project.pbxproj:
* WebCore.vcproj/WebCore.vcproj:
* GNUmakefile.am
Removed SQLiteAuthorizer.h.
* platform/sql/SQLiteAuthorizer.cpp:
* platform/sql/SQLiteAuthorizer.h: Removed.
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::authorizerFunction):
(WebCore::SQLiteDatabase::setAuthorizer):
* platform/sql/SQLiteDatabase.h:
* storage/DatabaseAuthorizer.h:
(WebCore::DatabaseAuthorizer::create):
(WebCore::DatabaseAuthorizer::createView):
(WebCore::DatabaseAuthorizer::createTempView):
(WebCore::DatabaseAuthorizer::dropView):
(WebCore::DatabaseAuthorizer::dropTempView):
(WebCore::DatabaseAuthorizer::allowSelect):
(WebCore::DatabaseAuthorizer::allowReindex):
Merge SQLiteAuthorizer and DatabaseAuthorizer, as keeping them separate serves no purpose.
2008-09-03 Dirk Schulze <vbs85@gmx.de>
Reviewed by Mark Rowe.
WebKitGtk build fix.
* GNUmakefile.am:
* page/animation/AnimationController.h:
2008-09-02 Robert Blaut <webkit@blaut.biz>
Reviewed by Geoff Garen.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913>
Misplaced elements should not close DL lists.
Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleError):
2008-09-02 Glenn Wilson <wilsong@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=15360>
Bug 15360: color:#{predefined colorName} is treated as colorName in Safari
We would inappropriately interpret and apply an invalid CSS "color" property
when the value is a predefined color preceded by a '#' symbol. For example,
style="color:#gray;" would apply the color gray when it should not.
In the bison template, "hexcolor" was defined as both "HEX maybe_space" OR "IDENT maybe_space".
This caused identifiers not fitting the appropriate hex format but preceded by a '#' to be
interpreted as a valid color (CSSPrimitiveValue::CSS_PARSER_HEXCOLOR), when it was really just
an ignorable token.
To correct this, "IDENT maybe_space" was removed from "hexcolor" and added under "term" as
'#' IDENT maybe_space, which is then processed as a CSSPrimitiveValue::CSS_STRING instead of
CSSPrimitiveValue::CSS_PARSER_HEXCOLOR.
Test: css1/color_and_background/invalid_color.html
* css/CSSGrammar.y:
2008-09-02 Mihnea Ovidenie <mihnea@adobe.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=19964
Bug 19964: Divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image
Add a check to RenderBox::repaintLayerRectsForImage to make sure the current layer image can be rendered.
Test: css3/khtml-background-size-0x0-bmp.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::repaintLayerRectsForImage):
2008-09-02 Glenn Wilson <wilsong@gmail.com>
Reviewed by Eric Seidel.
Fix https://bugs.webkit.org/show_bug.cgi?id=20397
Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash
The function checkForOrphanedUnits() would change the length of a list whose size was
was already determined before the call to checkForOrphanedUnits was made. Later in
the caller, the old size was being used for boundary management.
This has been fixed by moving the call to checkForOrphanedUnits() earlier in the
calling function, before the size of the list is determined.
Test: fast/css/orphaned_units_crash.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Moved call to checkForOrphanedUnits() earlier in the function.
2008-09-02 Dirk Schulze <vbs85@gmx.de>
Reviewed by Darin Adler.
Fallback on invalid fill or stroke styles in Canvas was
transparent black. Changed it to last valid style.
Canvas fillStyle() and strokeStyle() needs fallback
https://bugs.webkit.org/show_bug.cgi?id=20474
Tests: fast/canvas/canvas-invalid-fillstyle.html
fast/canvas/canvas-invalid-strokestyle.html
* html/CanvasStyle.cpp:
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
2008-09-02 Dirk Schulze <vbs85@gmx.de>
Reviewed by Darin Adler.
Fix https://bugs.webkit.org/show_bug.cgi?id=20468
Updated drawImage() in canvas to match the current specification.
Test: fast/canvas/drawImage-with-negative-source-destination.html
* html/CanvasRenderingContext2D.cpp:
(WebCore::normalizeRect):
(WebCore::CanvasRenderingContext2D::drawImage):
2008-08-26 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
<rdar://problem/5768210> Switch back to the system version of SQLite
Use the system version of SQLite when it is new enough to provide the functionality
that WebCore requires.
* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/WebCore.xcconfig:
2008-09-02 Dan Bernstein <mitz@apple.com>
- build fix
* page/animation/AnimationBase.h:
2008-09-02 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
AnimationController.cpp should be split into separate files
https://bugs.webkit.org/show_bug.cgi?id=20604
Note: All makefiles, except WebCore.xcodeproj have been changed without testing, upon
recommendation of Dave Hyatt.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
Build files.
* page/AnimationController.cpp: Removed.
* page/AnimationController.h: Removed.
* page/animation: Added.
* page/animation/AnimationBase.cpp: Added.
* page/animation/AnimationBase.h: Added.
* page/animation/AnimationController.cpp: Copied from WebCore/page/AnimationController.cpp.
* page/animation/AnimationController.h: Copied from WebCore/page/AnimationController.h.
* page/animation/CompositeAnimation.cpp: Added.
* page/animation/CompositeAnimation.h: Added.
* page/animation/ImplicitAnimation.cpp: Added.
* page/animation/ImplicitAnimation.h: Added.
* page/animation/KeyframeAnimation.cpp: Added.
* page/animation/KeyframeAnimation.h: Added.
2008-09-02 Dan Bernstein <mitz@apple.com>
- release build fix
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::calculateDrawingMode):
2008-09-02 Timothy Hatcher <timothy@apple.com>
Make console functions log the correct resource URL and
line number for where the call originated.
https://bugs.webkit.org/show_bug.cgi?id=17234
<rdar://problem/5732837>
Reviewed by Kevin McCullough.
Test: manual-tests/inspector/console-call-line-numbers.html
* bindings/js/JSConsoleCustom.cpp:
(WebCore::JSConsole::count): Call the impl.
(WebCore::JSConsole::timeEnd): Ditto.
* manual-tests/inspector/console-call-line-numbers.html: Added.
* manual-tests/inspector/resources/script-console-calls.js: Added.
* page/Console.cpp:
(WebCore::retrieveLastCaller): Helper to get the URL and line.
(WebCore::Console::error): Call retrieveLastCaller to get the URL and
line number to pass to addMessageToConsole.
(WebCore::Console::info): Ditto.
(WebCore::Console::log): Ditto.
(WebCore::Console::assertCondition): Ditto.
(WebCore::Console::count): Ditto.
(WebCore::Console::timeEnd): Ditto.
(WebCore::Console::warn): Ditto.
* page/Console.h:
* page/Console.idl: Make count and timeEnd custom.
2008-09-02 Timothy Hatcher <timothy@apple.com>
Removed IDL files from WebCore's framework resources.
* WebCore.xcodeproj/project.pbxproj:
2008-09-02 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- <rdar://problem/5681647> pages at http://www.stendmarsofa.com/ are so slow to calculate style it seems like a hang
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added a
cap on the number of consecutive identical residual style tags to
reopen.
(WebCore::HTMLParser::popBlock): Ditto.
2008-09-02 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Adam Roben.
A little database quota management cleanup.
* storage/OriginQuotaManager.cpp:
(WebCore::OriginQuotaManager::OriginQuotaManager):
(WebCore::OriginQuotaManager::lock):
(WebCore::OriginQuotaManager::unlock):
(WebCore::OriginQuotaManager::trackOrigin):
(WebCore::OriginQuotaManager::tracksOrigin):
(WebCore::OriginQuotaManager::addDatabase):
(WebCore::OriginQuotaManager::removeDatabase):
(WebCore::OriginQuotaManager::removeOrigin):
(WebCore::OriginQuotaManager::markDatabase):
(WebCore::OriginQuotaManager::diskUsage):
* storage/OriginQuotaManager.h:
Changed to assert that a lock is taken more directly and reliably. Removed comments about
main/background threads, as this is likely to stop being true with synchronous Database calls
being made on worker threads.
* storage/OriginUsageRecord.cpp:
(WebCore::OriginUsageRecord::OriginUsageRecord):
(WebCore::OriginUsageRecord::addDatabase):
(WebCore::OriginUsageRecord::removeDatabase):
(WebCore::OriginUsageRecord::markDatabase):
(WebCore::OriginUsageRecord::diskUsage):
* storage/OriginUsageRecord.h:
(WebCore::OriginUsageRecord::DatabaseEntry::DatabaseEntry):
Don't use a magic value for unknown. It is totally unnecessary for DatabaseEntry, and
can be replaced with a single boolean for OriginUsageRecord.
Added assertions for string parameters being unshared.
2008-09-01 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=19760
Make granting LoadLocalResources conditional on a policy.
* WebCore.base.exp:
* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setLocalLoadPolicy):
(WebCore::FrameLoader::restrictAccessToLocal):
* loader/FrameLoader.h:
(WebCore::FrameLoader::):
* platform/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::grantLoadLocalResources):
* platform/SecurityOrigin.h:
2008-09-01 Dean Jackson <dino@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=20571
Make sure Window object can assign Animation/Transition event
listeners via attributes.
Also added a bunch of transition event tests, although
only transition-end-event-window is directly relevant to this patch.
(WebCore::JSDOMWindowBase::put):
Tests: transitions/transition-end-event-all-properties.html
transitions/transition-end-event-attributes.html
transitions/transition-end-event-container.html
transitions/transition-end-event-left.html
transitions/transition-end-event-multiple-01.html
transitions/transition-end-event-multiple-02.html
transitions/transition-end-event-multiple-03.html
transitions/transition-end-event-multiple-04.html
transitions/transition-end-event-nested.html
transitions/transition-end-event-transform.html
transitions/transition-end-event-window.html
2008-09-01 Dean Jackson <dino@apple.com>
Reviewed by Sam Weinig
Code styling cleanup.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::getValueProperty):
(WebCore::JSDOMWindowBase::put):
2008-09-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
First cut at inline caching for access to vanilla JavaScript properties.
Updated for JavaScriptCore changes. Mostly mechanical addition of StructureIDs
to WebCore classes, and PutPropertySlot& arguments to put functions.
(WebCore::JSCSSStyleDeclaration::customPut): Be sure to play nice with
inline caching for global properties, so global assignment can be optimized.
* ForwardingHeaders/kjs/StructureID.h: Added.
* bindings/js/JSDOMBinding.h:
(WebCore::DOMObject::DOMObject):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::put):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.h:
(WebCore::JSDOMWindow::customPut):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::put):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSEventTargetBase.h:
(WebCore::JSEventTargetBase::put):
* bindings/js/JSEventTargetNode.h:
(WebCore::JSEventTargetNode::put):
* bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::customPut):
* bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::customPut):
* bindings/js/JSHTMLInputElementBase.cpp:
(WebCore::JSHTMLInputElementBase::put):
* bindings/js/JSHTMLInputElementBase.h:
* bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::customPut):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::customPut):
* bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::wrap):
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
* bindings/js/JSInspectedObjectWrapper.h:
* bindings/js/JSInspectorCallbackWrapper.cpp:
(WebCore::JSInspectorCallbackWrapper::wrap):
(WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
* bindings/js/JSInspectorCallbackWrapper.h:
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::customPut):
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::runtimeObjectCustomPut):
* bindings/js/JSPluginElementFunctions.h:
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
(WebCore::JSQuarantinedObjectWrapper::put):
* bindings/js/JSQuarantinedObjectWrapper.h:
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::customPut):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject setValue:forKey:]):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/NP_jsobject.cpp:
(_NPN_SetProperty):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::setMember):
* bridge/objc/objc_class.mm:
(KJS::Bindings::ObjcClass::fallbackObject):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(ObjcFallbackObjectImp::put):
* bridge/runtime.cpp:
(KJS::Bindings::Instance::createRuntimeObject):
* bridge/runtime_array.cpp:
(RuntimeArray::put):
* bridge/runtime_array.h:
* bridge/runtime_object.cpp:
(RuntimeObjectImp::RuntimeObjectImp):
(RuntimeObjectImp::put):
* bridge/runtime_object.h:
2008-09-01 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
Fixed border-radius for Cairo.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::strokeArc):
2008-09-01 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
Added canvas's globalAlpha to cairo.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::getAlpha):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::draw):
2008-08-31 Simon Hausmann <hausmann@webkit.org>
Unreviewed Qt build fix.
* WebCore.pro: Add TextControlInnerElements.cpp to SOURCES instead of
the .h file
2008-08-30 Darin Adler <darin@apple.com>
Reviewed by Maciej.
- adopt some new JavaScriptCore functions where appropriate
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::windowProtoFuncAToB): Adopted jsEmptyString.
(WebCore::windowProtoFuncBToA): Ditto.
* bindings/js/JSEventListener.cpp:
(WebCore::JSLazyEventListener::eventParameterName): Adopted
jsNontrivialString.
* bindings/js/JSSVGLazyEventListener.cpp:
(WebCore::JSSVGLazyEventListener::eventParameterName): Ditto.
2008-08-29 Brady Eidson <beidson@apple.com>
Reviewed by Anders' rubberstamp
Style cleanup to match MediaTokenizer::writeRawData()
* loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::writeRawData):
2008-08-29 Brady Eidson <beidson@apple.com>
Reviewed by Anders
Fix regression I introducted in 35946
Already covered by media/video-click-dlbclick-standalone.html
* loader/MediaDocument.cpp:
(WebCore::MediaTokenizer::createDocumentStructure): Don't cancel the load here - too early!
(WebCore::MediaTokenizer::writeRawData): Call finish() here so onload() can be called. Also add
an ASSERT signifying that this method should only be called once, to more closely follow the
PluginDocument case.
2008-08-29 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for <rdar://problem/6181588>
This patch makes hit testing take into account the new concept of a
disconnected frame, in which some of the content may not be
visible. The current hit testing mechanism starts at a target frame
and drills down for a HitTestResult. In some cases, drilling down
will find a non-visible result. When this happens, we need to try
again, starting at a higher level -- namely, starting at the main
frame.
* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea): New function that tests if a
point is inside the visible area for a disconnected frame.
* editing/Editor.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
2008-08-29 Adele Peterson <adele@apple.com>
Reviewed by Adam Roben.
Rename HTMLTextFieldInnerElement.h/.cpp to TextControlInnerElements.h/.cpp
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* html/HTMLTextFieldInnerElement.cpp: Removed.
* html/HTMLTextFieldInnerElement.h: Removed.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::createSubtreeIfNeeded):
* rendering/RenderTextControl.h:
* rendering/TextControlInnerElements.cpp: Copied from html/HTMLTextFieldInnerElement.cpp.
(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
(WebCore::TextControlInnerTextElement::defaultEventHandler):
(WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
* rendering/TextControlInnerElements.h: Copied from html/HTMLTextFieldInnerElement.h.
2008-08-29 Eric Seidel <eric@webkit.org>
Rubber-stamped by aroben.
Add GraphicsContext.h include to GraphcisContextPrivate.h
GraphicsContextPrivate uses StrokeStyle which is defined
in GraphicsContext.h but it doesn't include that header.
CoreGraphics build doesn't fail here due to the order
it happens to include files.
* platform/graphics/GraphicsContextPrivate.h:
2008-08-29 Eric Seidel <eric@webkit.org>
Reviewed by hyatt.
Fix GeneratedImage to respect Image's refcounting
Fixing potential crashers (future if not current)
https://bugs.webkit.org/show_bug.cgi?id=20567
I don't know if it's possible to make the current code
crash, thus I've not made a test.
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::getImage):
* css/CSSImageGeneratorValue.h:
* platform/graphics/GeneratedImage.h:
(WebCore::GeneratedImage::GeneratedImage):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setContent):
* rendering/style/RenderStyle.h:
2008-08-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/6093767>
https://bugs.webkit.org/show_bug.cgi?id=20526
Don't allow video to render until unsupported track types have been disabled.
* platform/graphics/win/QTMovieWin.cpp:
(QTMovieWinPrivate::task):
(QTMovieWinPrivate::drawingComplete):
(QTMovieWinPrivate::clearGWorld):
2008-08-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20525
<rdar://problem/6169301>
Return the size of the movie data instead of 1000.
Test: media/progress-event-total.html
* platform/graphics/win/QTMovieWin.cpp:
(QTMovieWin::dataSize):
2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Eric Seidel.
[janitor/qt] Start replacing port specific getters with the generic native getter
To get the native presentation of an image we currently have platform
specific #ifdef's and a generic getter using NativeImagePtr. This patch
extends this to the ImageBuffer and updates the Qt platform to get rid
of the special #ifdefs.
https://bugs.webkit.org/attachment.cgi?id=22861
* platform/graphics/BitmapImage.h:
* platform/graphics/Image.h:
* platform/graphics/qt/ImageQt.cpp:
* platform/graphics/qt/StillImageQt.cpp:
* platform/graphics/qt/StillImageQt.h:
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::createDragImage):
(WebCore::ClipboardQt::declareAndWriteDragImage):
* platform/qt/CursorQt.cpp:
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeImage):
2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon.
[svg/qt] Stop crashing... when no RenderPath/RenderObject is given...
* svg/graphics/qt/SVGPaintServerQt.cpp:
(WebCore::SVGPaintServer::renderPath):
* svg/graphics/qt/SVGPaintServerSolidQt.cpp:
(WebCore::SVGPaintServerSolid::setup):
2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon.
[network/qt] Implement defering of loading ResourceHandle's
This is needed otherwise we end in an ASSERT in the MainResourceLoader. The
implementation is simply not forwarding anything to the
ResourceHandleClient until we are allowed to. This might lead to a deadlock
in Qt as we do not empty the QNetworkReply input buffer and wait until we
are allowed to read. If that happens we are forced to buffer the data
within QNetworkReplyHandler, for now this is not done.
Manual test:
- Open http://acid3.acidtests.org
- Wait for the test to complete
- Click on the Reference Rendering link
- Be fast and see the results of acid3
=> assert
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::setLoadMode):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::sendQueuedItems):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyHandler::):
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
(WebCore::ResourceHandle::setDefersLoading):
2008-08-29 Simon Hausmann <hausmann@webkit.org>
Reviewed by Holger.
Don't crash when drawing patterns with the HTML canvas. Patterns
remain unimplemented but at least they don't crash anymore. This is
done by changing the PlatformPatternPtr to be a brush for the Qt
platform.
* platform/graphics/Pattern.h:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
* platform/graphics/qt/PatternQt.cpp:
(WebCore::Pattern::createPlatformPattern):
2008-08-29 Simon Hausmann <hausmann@webkit.org>
Fix the Qt build, fontSelector() is not used by the Qt port yet
and we just return 0 in Font::fontSelector().
* platform/graphics/Font.h:
2008-08-28 Alp Toker <alp@nuanti.com>
GTK+ dist/build fix. List newly added header files.
* GNUmakefile.am:
2008-08-28 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
Various WebKitCSSTransformValue-related fixes
https://bugs.webkit.org/show_bug.cgi?id=20562
Test: css3/transform-value-types.html
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* css/CSSValue.h:
* css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::cssText):
* css/WebKitCSSTransformValue.h:
(WebCore::WebKitCSSTransformValue::):
* css/WebKitCSSTransformValue.idl:
2008-08-28 Dan Bernstein <mitz@apple.com>
Reviewed by Steve Falkenburg.
- do not let the "last chance" WM_TIMER trigger WebCore timers when they should be deferred
* platform/win/SharedTimerWin.cpp:
(WebCore::TimerWindowWndProc):
2008-08-28 David Hyatt <hyatt@apple.com>
RenderStyle cleanup.
Break out StyleImage, StyleGeneratedImage, StyleCachedImage and NinePieceImage into separate files.
Reviewed by Adam
* css/CSSImageGeneratorValue.cpp:
* css/CSSImageValue.cpp:
* css/CSSStyleSelector.cpp:
* rendering/RenderImageGeneratedContent.cpp:
* rendering/style/NinePieceImage.cpp: Added.
* rendering/style/NinePieceImage.h: Added.
* rendering/style/RenderStyle.cpp:
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::containsImage):
(WebCore::StyleInheritedData::operator==):
(WebCore::RenderStyle::contentDataEquivalent):
* rendering/style/RenderStyle.h:
* rendering/style/StyleCachedImage.cpp: Added.
* rendering/style/StyleCachedImage.h: Added.
* rendering/style/StyleGeneratedImage.cpp: Added.
* rendering/style/StyleGeneratedImage.h: Added.
* rendering/style/StyleImage.h: Added.
2008-08-28 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
Make all the 'isFoo()' methods on CSSValue const,
and fix the subclasses.
https://bugs.webkit.org/show_bug.cgi?id=20561
* css/CSSTimingFunctionValue.h:
* css/CSSValue.h:
(WebCore::CSSValue::isFontValue):
(WebCore::CSSValue::isImageGeneratorValue):
(WebCore::CSSValue::isImageValue):
(WebCore::CSSValue::isImplicitInitialValue):
* css/CSSValueList.h:
* css/FontValue.h:
2008-08-28 David Hyatt <hyatt@apple.com>
The great RenderStyle cleanup begins!
Move LengthBox and LengthSize out of RenderStyle and into Length.
Reviewed by Adam
* rendering/Length.h:
(WebCore::):
(WebCore::Length::Length):
(WebCore::Length::operator==):
(WebCore::Length::operator!=):
(WebCore::Length::value):
(WebCore::Length::rawValue):
(WebCore::Length::percent):
(WebCore::Length::type):
(WebCore::Length::quirk):
(WebCore::Length::setValue):
(WebCore::Length::setRawValue):
(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::isUndefined):
(WebCore::Length::isZero):
(WebCore::Length::isPositive):
(WebCore::Length::isNegative):
(WebCore::Length::isAuto):
(WebCore::Length::isRelative):
(WebCore::Length::isPercent):
(WebCore::Length::isFixed):
(WebCore::Length::isStatic):
(WebCore::Length::isIntrinsicOrAuto):
(WebCore::Length::blend):
(WebCore::LengthBox::LengthBox):
(WebCore::LengthBox::operator=):
(WebCore::LengthBox::operator==):
(WebCore::LengthBox::operator!=):
(WebCore::LengthBox::nonZero):
(WebCore::LengthSize::LengthSize):
* rendering/style/RenderStyle.h:
2008-08-28 David Hyatt <hyatt@apple.com>
Reviewed by Darin
https://bugs.webkit.org/show_bug.cgi?id=18091
font-size should be animatable using -webkit-transition.
* page/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::ensurePropertyMap):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setFontSize):
2008-08-28 Brad Garcia <bgarcia@google.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=20549
Correctly determine when cursor is over a resizable border within
a nested frameset.
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::canResizeRow):
(WebCore::RenderFrameSet::canResizeColumn):
2008-08-28 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel
Add RuleTypes to CSSRule.idl for keyframes and keyframe rules.
https://bugs.webkit.org/show_bug.cgi?id=20552
Test: animations/animation-css-rule-types.html
* css/CSSRule.idl:
2008-08-28 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin and Darin.
<rdar://problem/6182541>
https://bugs.webkit.org/show_bug.cgi?id=20202
Missing http status line from the http headers.
Add a status line to the header string.
* plugins/PluginStream.cpp:
(WebCore::PluginStream::startStream):
2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber-stamped by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=17261
Make it possible to theme the default Url icon and enable this for
the Qt port. To have a minimal usage of #ifdef in the code the setting
of the icon was moved to a new method which comes in two flavors.
* loader/icon/IconDatabase.cpp:
(WebCore::loadDefaultIconRecord): Load or set the default icon
(WebCore::IconDatabase::defaultIcon):
2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
Unreviewed compile fix
* platform/graphics/qt/GraphicsContextQt.cpp: Remove redefinitions
2008-08-28 Adam Roben <aroben@apple.com>
Windows (and others?) build fix
* page/Chrome.cpp: Added a missing #include.
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Fixed typo.
2008-08-27 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
Qt and Cairo support from krit (and blind stab @ wx compile support)
https://bugs.webkit.org/show_bug.cgi?id=20373
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformStrokeStyle):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
(WebCore::GraphicsContext::setPlatformFillPattern):
(WebCore::GraphicsContext::setPlatformStrokePattern):
(WebCore::GraphicsContext::setPlatformFillGradient):
(WebCore::GraphicsContext::setPlatformStrokeGradient):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::setPlatformFillPattern):
(WebCore::GraphicsContext::setPlatformStrokePattern):
(WebCore::GraphicsContext::setPlatformFillGradient):
(WebCore::GraphicsContext::setPlatformStrokeGradient):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformFillPattern):
(WebCore::GraphicsContext::setPlatformStrokePattern):
(WebCore::GraphicsContext::setPlatformFillGradient):
2008-08-27 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it.
https://bugs.webkit.org/show_bug.cgi?id=20373
Changed pattern() to canvasPattern() on CanvasStyle to match canvasGradient()
Made Generator (aka Gradient) RefCounted so that GraphicsContext didn't
have to store large Gradient objects in the GraphicsContextState
Made Pattern RefCounted for the same reason.
Many updates to GraphicsContext to support easier drawing with
Patterns and Gradients.
* WebCore.xcodeproj/project.pbxproj: Add pre-existing GraphicsContextPrivate.h
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::toJS):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::createGradient):
* css/CSSGradientValue.h:
* html/CanvasGradient.cpp:
(WebCore::CanvasGradient::CanvasGradient):
* html/CanvasGradient.h:
(WebCore::CanvasGradient::gradient):
(WebCore::CanvasGradient::addColorStop):
(WebCore::CanvasGradient::getColor):
* html/CanvasPattern.cpp:
* html/CanvasPattern.h:
(WebCore::CanvasPattern::pattern):
(WebCore::CanvasPattern::originClean):
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::setStrokeStyle):
(WebCore::CanvasRenderingContext2D::setFillStyle):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::strokeRect):
* html/CanvasRenderingContext2D.h:
* html/CanvasStyle.cpp:
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
* html/CanvasStyle.h:
* platform/graphics/GeneratedImage.h:
(WebCore::GeneratedImage::GeneratedImage):
* platform/graphics/Generator.h:
* platform/graphics/Gradient.h:
(WebCore::Gradient::create):
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::fillRule):
(WebCore::GraphicsContext::setFillRule):
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsContextPrivate.h:
(WebCore::):
(WebCore::GraphicsContextState::GraphicsContextState):
* platform/graphics/GraphicsTypes.h:
* platform/graphics/Path.h:
* platform/graphics/Pattern.h:
(WebCore::Pattern::create):
(WebCore::Pattern::tileImage):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::calculateDrawingMode):
(WebCore::GraphicsContext::drawPath):
(WebCore::fillPathWithFillRule):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformStrokePattern):
(WebCore::GraphicsContext::setPlatformFillPattern):
(WebCore::GraphicsContext::setPlatformStrokeGradient):
(WebCore::GraphicsContext::setPlatformFillGradient):
2008-08-20 Eric Seidel <eric@webkit.org>
Reviewed by Darin and Alexey.
Close a leak of PausedTimeouts if the JavaScriptDebugServer was destroyed
with timeouts paused.
https://bugs.webkit.org/show_bug.cgi?id=20469
I attempted to clean up the memory management of PausedTimeouts, I'm not
sure the solution I came up with is "cleaner", but it's in some ways
"safer", since it no longer uses raw pointers and manual new/delete.
This also now prevents CachedPage from needlessly creating Window
objects when caching pages which didn't already have one. :)
I also made Chrome.cpp no longer depend on the JavaScript bindings
(aka JSDOMWindowBase.h), since there was no real reason for it to.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::pauseTimeouts):
(WebCore::JSDOMWindowBase::resumeTimeouts):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::pauseTimeouts):
(WebCore::ScriptController::resumeTimeouts):
* bindings/js/ScriptController.h:
* history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
* page/Chrome.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
* page/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
(WebCore::JavaScriptDebugServer::setJavaScriptPaused):
2008-08-27 Holger Hans Peter Freyther <zecke@selfish.org>
Unreviewed compile fix
Add the stub for the Qt port.
* WebCore.pro:
* page/qt/AccessibilityObjectQt.cpp: Added.
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
2008-08-27 Alp Toker <alp@nuanti.com>
Reviewed by Eric.
https://bugs.webkit.org/show_bug.cgi?id=20551
[GTK] search popup crash
* platform/gtk/SearchPopupMenuGtk.cpp:
(WebCore::SearchPopupMenu::enabled):
Fix a search popup crasher by disabling the history popup since we
don't support this feature yet in the GTK+ port.
2008-08-27 Alp Toker <alp@nuanti.com>
Reviewed by Eric.
https://bugs.webkit.org/show_bug.cgi?id=20551
[GTK] curl crashers
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::startScheduledJobs):
Remove the resource handle from the pending list before starting the
job, not afterwards. Fixes crashers in the test suite.
Test: fast/dom/clientWidthAfterDocumentIsRemoved.html
Test: fast/encoding/char-encoding.html
2008-08-27 Dirk Schulze <vbs85@gmx.de>
Reviewed by eseidel.
Fix canvas drawImage to support composite operations.
Composite had no effect on canvas elements like these:
http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html
[CAIRO] Canvas composite don't work on canvas-elements.
https://bugs.webkit.org/show_bug.cgi?id=20548
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call
2008-08-27 Mario Bensi <mbensi@pleyo.com>
Reviewed by Eric Seidel.
Fix the data content of an image with a base64.
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::parseDataUrl): Remove the String and use only the data
Vector because the data.latin1().data() convert the data content and
the image test ( https://bugs.webkit.org/attachment.cgi?id=21726 ) is
not drawn correctly.
2008-08-27 Antti Koivisto <antti@apple.com>
Reviewed by Eric Seidel.
Crash after OK in dialog box and reloading page in secure mode
https://bugs.webkit.org/show_bug.cgi?id=20493
The new run loop spawned by a modal dialog causes a timer in the loader to run
synchronously inside didFinishLoading() deleting "this" object.
Defer all WebCore timers when a modal dialog is up. They are not
safe to execute.
* page/Chrome.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2008-08-27 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt
Memory leaks when animating transforms
https://bugs.webkit.org/show_bug.cgi?id=20532
* rendering/style/RenderStyle.cpp:
(WebCore::ScaleTransformOperation::blend):
(WebCore::RotateTransformOperation::blend):
(WebCore::SkewTransformOperation::blend):
(WebCore::TranslateTransformOperation::blend):
(WebCore::MatrixTransformOperation::blend):
* rendering/style/RenderStyle.h:
2008-08-27 Timothy Hatcher <timothy@apple.com>
Add support for support for -webkit-appearance: default-button on the Mac platform.
<rdar://problem/6173530>
Reviewed by Dave Hyatt.
* WebCore.base.exp: Export new symbols.
* platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation.
* platform/mac/WebCoreSystemInterface.mm: Ditto.
* rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN).
(WebCore::RenderButton::setStyle): Ditto.
* rendering/RenderButton.h: Ditto.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance.
(WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return
key if the button is default, otherwise reset the key equivalent.
(WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell:
on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore
the window's previous default button cell when finished.
2008-08-26 David Hyatt <hyatt@apple.com>
First cut at making form controls on OS X respect full page zoom. There are lots of bugs.
Reviewed by weinig
Added fast/forms/zoomed-controls.html
* css/CSSStyleSelector.cpp:
(WebCore::addIntrinsicMargins):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::calcPrefWidths):
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::baselinePosition):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::sizeForFont):
(WebCore::RenderThemeMac::sizeForSystemFont):
(WebCore::RenderThemeMac::setFontFromControlSize):
(WebCore::RenderThemeMac::paintCheckbox):
(WebCore::RenderThemeMac::setCheckboxCellState):
(WebCore::RenderThemeMac::paintRadio):
(WebCore::RenderThemeMac::setRadioCellState):
(WebCore::RenderThemeMac::setButtonPaddingFromControlSize):
(WebCore::RenderThemeMac::adjustButtonStyle):
(WebCore::RenderThemeMac::setButtonCellState):
(WebCore::RenderThemeMac::paintButton):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::RenderThemeMac::popupInternalPaddingLeft):
(WebCore::RenderThemeMac::popupInternalPaddingRight):
(WebCore::RenderThemeMac::popupInternalPaddingTop):
(WebCore::RenderThemeMac::popupInternalPaddingBottom):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::adjustSliderThumbSize):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
2008-08-27 Brady Eidson <beidson@apple.com>
Reviewed by Anders
<rdar://problem/6134133> - Crash when loading large movie as a standalone document
We hand off these loads to Quicktime which manages and spools the data itself, but we also continued
to load and buffer the data for the movie in WebCore. With large media files, this results in blowing
away the virtual address space and a crash.
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
* loader/FrameLoaderClient.h: Added client method to get platform specific error for
"plugin will handle load"
* loader/MediaDocument.cpp:
(WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data,
and cancel the WebCore-managed load
(WebCore::MediaTokenizer::writeRawData):
(WebCore::MediaTokenizer::finish):
2008-08-26 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel
Linear timing functions should have control points 0, 0, 1, 1.
https://bugs.webkit.org/show_bug.cgi?id=20535
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapAnimationTimingFunction):
* rendering/style/RenderStyle.h:
2008-08-27 Adam Roben <aroben@apple.com>
Windows build fix
* WebCore.vcproj/WebCore.vcproj: Fix file extension.
2008-08-26 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown
Added platform-specific accessibilityIgnoreAttachment, which allows the platform
to determine if an attachment is ignored through accessibility. Added equivalent
methods in Gtk, Win and Mac
Test: accessibility/plugin.html
* GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/AccessibilityObject.h:
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
* page/gtk/AccessibilityObjectAtk.cpp: Added.
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
* page/mac/AccessibilityObjectMac.mm: Added.
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
* page/mac/AccessibilityObjectWrapper.h:
* page/win/AccessibilityObjectWin.cpp: Added.
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
2008-08-26 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/5817770> can't bring up contextual menu for embedded objects in WebText
* page/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
(-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
2008-08-26 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns
Tests: accessibility/table-notbody.html
* page/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
2008-08-26 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Fix typo.
* dom/DOMCoreException.h:
2008-08-26 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix https://bugs.webkit.org/show_bug.cgi?id=20479
<rdar://problem/6167660>
Take image redirects into account when tainting the canvas.
Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
2008-08-26 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Change canvas tainting logic to ask the image if it contains
any resources outside of its own origin. Since there is no
way to determine if SVG images contain any resources outside its
origin, we always assume it does.
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
* platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::hasSingleSecurityOrigin):
* platform/graphics/GeneratedImage.h:
(WebCore::GeneratedImage::hasSingleSecurityOrigin):
* platform/graphics/Image.h:
(WebCore::Image::hasSingleSecurityOrigin):
* platform/graphics/cg/PDFDocumentImage.h:
(WebCore::PDFDocumentImage::hasSingleSecurityOrigin):
* svg/graphics/SVGImage.h:
2008-08-26 Maxime Britto <britto@apple.com>
Reviewed by Adele.
<rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com)
This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area.
This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls.
* page/EventHandler.cpp:
(WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning
* page/EventHandler.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta
(WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so.
* rendering/RenderLayer.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled
(WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method
(WebCore::RenderObject::panScroll): No need to check for the layer anymore too.
2008-08-25 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it
https://bugs.webkit.org/show_bug.cgi?id=20247
<rdar://problem/6118218>
Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive
check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute
(case insensitive for HTML elements).
Test: fast/dom/Element/getAttribute-check-case-sensitivity.html
* dom/Element.cpp:
(WebCore::Element::getAttribute):
* dom/NamedAttrMap.cpp:
(WebCore::NamedAttrMap::getNamedItem):
(WebCore::NamedAttrMap::getAttributeItem):
* dom/NamedAttrMap.h:
2008-08-25 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20514
<rdar://problem/6174096>
Treat SVG images as dirty when drawing to a canvas.
Test: http/tests/security/canvas-remote-read-svg-image.html
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
* platform/graphics/Image.h:
(WebCore::Image::isSVGImage):
* svg/graphics/SVGImage.h:
(WebCore::SVGImage::isSVGImage):
2008-08-25 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix https://bugs.webkit.org/show_bug.cgi?id=20377
Leak in XMLHttpRequest.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
2008-08-25 Brady Eidson <beidson@apple.com>
Reviewed by Anders
Speculative fix for <rdar://problem/6173217>
Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
the first null check invalid.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopAllLoaders):
2008-08-25 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
there is no profile, can cause crash
* page/inspector/ProfilesPanel.js:
2008-08-25 Dean Jackson <dino@apple.com>
Reviewed by Dave Hyatt
Make sure 'inherit' is handled by transition property.
https://bugs.webkit.org/show_bug.cgi?id=20513
Test: transitions/inherit.html
Test: transitions/inherit-other-props.html
* css/CSSStyleSelector.cpp:
fix macro to check existence of list before getting size
2008-08-25 Anders Carlsson <andersca@apple.com>
Reviewed by Mark.
<rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.
Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume
(safely) that any class that needs finalization on the main thread will also need to be deallocated
on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.
* platform/mac/WebCoreObjCExtras.c:
(WebCoreObjCFinalizeOnMainThread):
2008-08-25 Antti Koivisto <antti@apple.com>
Reviewed by Dan Bernstein.
Rename CachedResource::referenced() to CachedResource::hasClients() to
match previous ref() -> addClient() rename.
* loader/Cache.cpp:
(WebCore::Cache::pruneLiveResources):
(WebCore::Cache::pruneDeadResources):
(WebCore::Cache::remove):
(WebCore::Cache::getStatistics):
(WebCore::Cache::dumpLRULists):
* loader/CachedResource.cpp:
(WebCore::CachedResource::addClient):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::setDecodedSize):
(WebCore::CachedResource::setEncodedSize):
* loader/CachedResource.h:
(WebCore::CachedResource::hasClients):
(WebCore::CachedResource::canDelete):
2008-08-25 Anthony Ricaud <rik24d@gmail.com>
Add a missing Inspector localized string for "other".
https://bugs.webkit.org/show_bug.cgi?id=20509
Reviewed by Tim Hatcher.
* English.lproj/localizedStrings.js:
2008-08-22 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff, Mark and Tim.
<rdar://problem/6150623> JSProfiler: It would be nice if the profiles
in the console said what file and line number they came from
- Lay the foundation for getting line numbers and other data from the
JavaScript engine.
* ForwardingHeaders/VM: Added.
* ForwardingHeaders/VM/Machine.h: Added.
* page/Console.cpp: Gather the line number and file information when
profileEnd has been called, but don't use it until didFinishProfiling is
called. We won't need to wait once we remove the profiler "zombie" mode
which this patch helps pave the foundation for.
(WebCore::Console::Console):
(WebCore::Console::profileEnd):
(WebCore::Console::finishedProfiling):
* page/Console.h:
* page/InspectorController.cpp: Modify calls to
addProfileMessageToConsole to satisfy the new arguments it takes.
(WebCore::InspectorController::finishedProfiling):
(WebCore::InspectorController::addProfile):
(WebCore::InspectorController::addProfileMessageToConsole):
(WebCore::InspectorController::finishedProfiling):
* page/InspectorController.h:
2008-08-25 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon.
[inspector] Update the WebKit.qrc Qt resources file
Catchup with the changes in the directory.
* page/inspector/WebKit.qrc:
2008-08-25 Dirk Schulze <vbs85@gmx.de>
Reviewed by Simon.
Transformed the radian to degree, to get rotate()
in canvas work as expected.
[Qt] Canvas.rotate() doesn't work
https://bugs.webkit.org/show_bug.cgi?id=20496
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::rotate):
2008-08-24 Steve Falkenburg <sfalken@apple.com>
Add a "last chance" WM_TIMER to the Windows shared timer.
The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
timers if a timer with an earlier expiration is already pending. This results in no timers
firing from that point on.
We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
buggy window message hook.
This timer will start when the first WM_TIMER is scheduled, and will
fire every 5 seconds thereafter, causing any lost timers to be fired.
Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
and prevents the WebFrame leak.
Reviewed by Darin Adler, Geoff Garen.
* platform/win/SharedTimerWin.cpp:
(WebCore::):
(WebCore::TimerWindowWndProc):
(WebCore::setSharedTimerFireTime):
2008-08-24 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
Test: fast/css/font-property-priority.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Changed to pass the 'important' flag
to the font-property-parsing functions.
(WebCore::CSSParser::parseFontStyle): Added an 'important' argument and
changed to use it rather than the m_important member.
(WebCore::CSSParser::parseFontVariant): Ditto.
(WebCore::CSSParser::parseFontWeight): Ditto.
* css/CSSParser.h:
2008-08-24 Timothy Hatcher <timothy@apple.com>
Fixes a bug where the Inspector's UI would not animate or
fully function because JavaScript timeouts, intervals and
CSS animation timers where not firing while paused at a
a breakpoint in the inspected page.
https://bugs.webkit.org/show_bug.cgi?id=20042
Reviewed by Darin Adler.
Test: manual-tests/inspector/forzen-ui-while-paused.html
* page/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::pauseIfNeeded):
Add a call to TimerBase::fireTimersInNestedEventLoop before
spinning the EventLoop.
2008-08-24 Rob Buis <buis@kde.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=20324
A change in SVG Glyph wont show up
Invalidate the glyph cache when the d attribute is set.
Test: svg/custom/glyph-setting-d-attribute.svg
* svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::invalidateGlyphCache):
(WebCore::SVGGlyphElement::parseMappedAttribute):
(WebCore::SVGGlyphElement::insertedIntoDocument):
(WebCore::SVGGlyphElement::removedFromDocument):
* svg/SVGGlyphElement.h:
2008-08-24 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=13864
<rdar://problem/5451470> REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths()
* rendering/RenderText.cpp:
(WebCore::RenderText::trimmedPrefWidths): Moved the assignment to
beginWS and endWS before the early return to ensure that they are
initialized in that case.
2008-08-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Rubber-stamped by Mark Rowe.
Remove modelines.
* WebCore.pro:
* bridge/testbindings.cpp:
* dom/DocPtr.h:
* loader/SubstituteData.h:
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
* page/Frame.h:
* page/FrameLoadRequest.h:
* page/FrameTree.cpp:
* page/FrameTree.h:
* page/Page.h:
* page/mac/ChromeMac.mm:
* platform/network/HTTPHeaderMap.h:
* platform/network/ResourceErrorBase.cpp:
* platform/network/ResourceErrorBase.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/ResourceRequestBase.cpp:
* platform/network/ResourceRequestBase.h:
* platform/network/ResourceResponseBase.cpp:
* platform/network/ResourceResponseBase.h:
* platform/network/cf/ResourceError.h:
* platform/network/cf/ResourceRequest.h:
* platform/network/cf/ResourceRequestCFNet.h:
* platform/network/cf/ResourceResponse.h:
* platform/network/cf/ResourceResponseCFNet.h:
* platform/network/curl/ResourceError.h:
* platform/network/curl/ResourceRequest.h:
* platform/network/curl/ResourceResponse.h:
* platform/network/mac/ResourceError.h:
* platform/network/mac/ResourceErrorMac.mm:
* platform/network/mac/ResourceRequest.h:
* platform/network/mac/ResourceRequestMac.mm:
* platform/network/mac/ResourceResponse.h:
* platform/network/mac/ResourceResponseMac.mm:
* platform/network/qt/ResourceError.h:
* platform/network/qt/ResourceRequest.h:
* platform/network/qt/ResourceResponse.h:
* platform/network/soup/CookieJarSoup.cpp:
* platform/network/soup/ResourceError.h:
* platform/network/soup/ResourceRequest.h:
* platform/network/soup/ResourceResponse.h:
2008-08-23 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
Test: fast/table/vertical-align-baseline.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
baseline of the first table row, if there is one, -1 otherwise.
* rendering/RenderTable.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::baselinePosition): Changed to follow the
CSS2.1 definition of the baseline of a table cell.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
the baseline of the first row in the section.
* rendering/RenderTableSection.h:
2008-08-18 Jon Honeycutt <jhoneycutt@apple.com>
Add SPI to make a Windows WebView transparent.
Reviewed by Dan Bernstein.
* platform/graphics/GraphicsContext.h: Add a parameter, hasAlpha, that
determines whether the created context has an alpha channel.
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::CGContextWithHDC):
2008-08-22 Timothy Hatcher <timothy@apple.com>
Rolls out r35834 because it caused a regression in the Inspector's
Console where some expressions always threw a syntax error.
https://bugs.webkit.org/show_bug.cgi?id=20487
* page/inspector/Console.js:
(Console.prototype._evalInInspectedWindow): Removes parenthesis
around the expression.
2008-08-22 Timothy Hatcher <timothy@apple.com>
Makes getStyleProperty return a value for the overflow property
when overflow-x and overflow-y are equal.
https://bugs.webkit.org/show_bug.cgi?id=20485
Reviewed by Dan Bernstein.
Test: fast/css/overflow-property.html
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::getPropertyValue):
2008-08-22 Timothy Hatcher <timothy@apple.com>
Fixes a bug where while editing in the Inspector the
sidebar scroll position would jump to the top.
https://bugs.webkit.org/show_bug.cgi?id=20484
Reviewed by Darin Adler.
* page/inspector/treeoutline.js:
(TreeOutline._removeChildren): Remove the offsetTop call that
was forcing a layout, since layout causes scroll positions
to be clamped to the new scrollHeight/Width. Layout will happen
normally when needed.
2008-08-22 Kevin Ollivier <kevino@theolliviers.com>
wx build fix. Add AccessibilityTable sources.
* WebCoreSources.bkl:
2008-08-21 Dan Bernstein <mitz@apple.com>
Reviewed by Jon Honeycutt and Alexey Proskuryakov.
- fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
ascent and 100% to its reported descent.
2008-08-21 Kalle Vahlman <kalle.vahlman@movial.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=20267
[GTK] Crash on some pages due to a plugin
Fix handling of badly formatted and empty plugin mime descriptions
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::PluginPackage::fetchInfo):
2008-08-21 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Darin Adler.
Follow other ports (and IE) in ImageSourceWx.cpp never to return an
animated GIF frame duration of less than 50ms.
* platform/graphics/wx/ImageSourceWx.cpp:
(WebCore::ImageSource::frameDurationAtIndex):
2008-08-21 Maxime Britto <britto@apple.com>
Reviewed by Kevin McCullough.
Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
https://bugs.webkit.org/show_bug.cgi?id=20451
rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.
(WebCore::EventHandler::handleMousePressEvent): ditto
2008-08-21 Anthony Ricaud <rik24d@gmail.com>
Small optimization for when the dividers in the Inspector's
Resources panel are updated.
Reviewed by Tim Hatcher.
* page/inspector/ResourcesPanel.js:
(WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
Combind a for loop and clone the divider element.
2008-08-21 Chris Marrin <cmarrin@apple.com>
Allow 0 (without units) for Time eg. duration
Fix for https://bugs.webkit.org/show_bug.cgi?id=20467
Reviewed by Dave Hyatt.
Test: css1/units/zero-duration-without-units.html
* css/CSSParser.cpp:
(WebCore::CSSParser::validUnit):
2008-08-21 Timothy Hatcher <timothy@apple.com>
Make deleting all text while editing a DOM attribute in
the Inspector delete the attribute. This also fixes
an exception that would happen before.
https://bugs.webkit.org/show_bug.cgi?id=20472
Reviewed by Kevin McCullough.
* page/inspector/ElementsPanel.js:
(WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted):
Don't check for hasAttributes on the parseElement, continuing
through the function will correctly remove the attribute.
If the parseElement is null, call _editingCancelled not
editingCancelled, this fixes an exception.
2008-08-21 Timothy Hatcher <timothy@apple.com>
Update the Inspector's Metrics pane when editing in
the Styles pane. This makes sure the metrics shown
always match what the Styles pane shows.
https://bugs.webkit.org/show_bug.cgi?id=20470
Reviewed by Kevin McCullough.
* page/inspector/ElementsPanel.js:
(WebInspector.ElementsPanel): Add event listeners for
the "style edited" and "style property toggled" events,
so the Metrics pane is updated.
(WebInspector.ElementsPanel.prototype._stylesPaneEdited):
Update the Metrics pane.
* page/inspector/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
Dispatch the "style property toggled" event.
(WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
Dispatch the "style edited" event when the CSS text is restored.
(WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
Dispatch the "style edited" event.
2008-08-21 Timothy Hatcher <timothy@apple.com>
Make the Inspector's Metrics sidebar pane editable.
https://bugs.webkit.org/show_bug.cgi?id=17218
rdar://problem/5732818
Reviewed by Kevin McCullough.
* page/inspector/ElementsPanel.js:
(WebInspector.ElementsPanel): Add an event listener for
the "metrics edited" event, so the Styles pane is updated.
* page/inspector/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype.update): Remember the node
so future updates work. Add a double click event listener for the
metric values to start editing.
(WebInspector.MetricsSidebarPane.prototype.startEditing):
Call WebInspector.startEditing with some context.
(WebInspector.MetricsSidebarPane.prototype.editingCancelled):
(WebInspector.MetricsSidebarPane.prototype.editingCommitted):
Set the user input on the elements inline style. Fire the
"metrics edited" event.
2008-08-21 Steve Falkenburg <sfalken@apple.com>
Fix a race condition in Windows timer code.
Timer function could end up being called with a 0 timer, leading to a Windows exception.
Don't post a timer message if one is already pending.
Reviewed by Ada Chan.
* platform/win/SharedTimerWin.cpp:
(WebCore::TimerWindowWndProc):
(WebCore::clearTimer):
(WebCore::queueTimerProc):
(WebCore::setSharedTimerFireTime):
2008-08-21 Anthony Ricaud <rik24d@gmail.com>
After trying to add the expression, try again with quotes for
easier edition.
https://bugs.webkit.org/show_bug.cgi?id=20466
Reviewed by Tim Hatcher.
* page/inspector/ObjectPropertiesSection.js: Added an
evaluateExpression function.
2008-08-21 Anthony Ricaud <rik24d@gmail.com>
Perform Inspector searches on search event to clear results when
clicking the cross to empty it. Delete the lastQuery when the field
is emptied in order to perform the search if exactly the same query
is entered next.
https://bugs.webkit.org/show_bug.cgi?id=20462
Reviewed by Tim Hatcher.
* page/inspector/inspector.js:
2008-08-21 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=19656
[SOUP] The gio code should call didFail() instead of
didFinishLoading() in case of error
In case of error call didFail() instead of didReceiveResponse() and
didFinishLoading().
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::networkErrorForFile):
(WebCore::readCallback):
(WebCore::openCallback):
(WebCore::queryInfoCallback):
2008-08-20 Mark Rowe <mrowe@apple.com>
Reviewed by Jon Honeycutt.
Fix build failure.
* bridge/c/c_instance.cpp:
(KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
as that is what NPEnumerationFunctionPtr is declared as accepting.
2008-08-20 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Build fix. Handle kCGInterpolationMedium in switch statements if it is available.
* platform/graphics/GraphicsContext.h:
(WebCore::):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
2008-08-20 Dan Bernstein <mitz@apple.com>
Rubber-stamped by John Sullivan.
- rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and
rename related methods and variables accordingly.
* WebCore.base.exp:
* page/FrameView.cpp:
(WebCore::FrameViewPrivate::FrameViewPrivate):
(WebCore::FrameView::shouldUpdateWhileOffscreen):
(WebCore::FrameView::setShouldUpdateWhileOffscreen):
* page/FrameView.h:
* platform/ScrollView.h:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::updateContents):
2008-08-20 Brady Eidson <beidson@apple.com>
Reviewed by Mitzpettel
<rdar://problem/6163636> - Many images broken in Mail
This can be traced back to the preload scanner. With that change, CachedResources are created a lot
sooner than before and confuse the WebArchive machinery.
When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
machinery and nothing is known about where the data will eventually come from.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is
CachedResource::PreloadReferenced.
2008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>
Unreviewed compile fix
Catch up with the JSValue::type elimination.
* bridge/qt/qt_instance.cpp:
(KJS::Bindings::QtRuntimeObjectImp::construct):
(KJS::Bindings::QtInstance::defaultValue):
* bridge/qt/qt_runtime.cpp:
(KJS::Bindings::QtRuntimeConnectionMethod::call):
2008-08-20 Chris Teague <chris.teague@gmail.com>
Reviewed by Mark Rowe.
Fix https://bugs.webkit.org/show_bug.cgi?id=20449
Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined
* ChangeLog:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
2008-08-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
getComputedStyle() for webkitTransform should return a transform
that does not have the transform origin baked into it.
https://bugs.webkit.org/show_bug.cgi?id=20464
Test: fast/css/getComputedStyle-transform.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::computedTransform):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::applyTransform):
* rendering/style/RenderStyle.h:
2008-08-20 Josh Aas <joshmoz@gmail.com>
Reviewed and landed by Anders.
<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)
* bridge/npapi.h:
(_NPCocoaEvent::):
2008-08-20 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/6145626>
This patch fixes a number of remaining problems getting
disconnected frames to work correctly with markAllMatchesForText()
and findString(). Details inline.
This was a static helper function in Frame, but this patch requires
the same functionality in Editor, so I just added it as a function
on Node.
* dom/Node.cpp:
(WebCore::Node::isInShadowTree):
* dom/Node.h:
* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea): Returns false if
excludeFromTextSearch() is true.
In a normal (non-disconnected) frame, findString returns a range of
the document node if the text is not found in the frame. I changed
firstVisibleRange and lastVisibleRange to match that behavior when
the text is not found
(WebCore::Editor::firstVisibleRange):
(WebCore::Editor::lastVisibleRange):
Here are the bulk of the changes in the patch. A lot of text was
not being found in disconnected frames because I failed to account
for all of the possible problems associated with shadow trees. That
is fixed here.
(WebCore::Editor::nextVisibleRange):
* editing/Editor.h:
excludeFromTextSearch() is new. It allows a WebKit client to mark a
frame as not-text-searchable through SPI.
* WebCore.base.exp:
* page/Frame.cpp:
(WebCore::Frame::excludeFromTextSearch):
(WebCore::Frame::setExcludeFromTextSearch):
(WebCore::FramePrivate::FramePrivate):
* page/Frame.h:
* page/FramePrivate.h:
(WebCore::Frame::findString):
(WebCore::Frame::markAllMatchesForText): I kept running into an
assertion failure in paining code because of the forced paint on
empty visible rects.
2008-08-20 Timothy Hatcher <timothy@apple.com>
Adds a positon box to the Inspector's Metrics sidebar
pane. When an element is not statically positioned, there
is now a position box that show top, right, bottom and
left computed values.
Reviewed by Kevin McCullough.
* English.lproj/localizedStrings.js: Updated the strings.
* page/inspector/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype.update):
Renamed the boxPartValue function to createBoxPartElement
and made it create the entire element. Made it understand
how to get position style properties. Don't use the figure dash
when 0px is used for positions, since the 0 is meaningful there.
Instead use the figure dash when a position is auto.
* page/inspector/inspector.css: Added a new rule for position.
2008-08-20 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin
Qt build fix
* WebCore.pro:
2008-08-20 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
- avoid using a deprecated NSScroller method on Leopard
* platform/mac/PlatformScrollBarMac.mm:
(WebCore::PlatformScrollbar::updateThumbPosition):
(WebCore::PlatformScrollbar::updateThumbProportion):
2008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Oliver Hunt.
Gtk build fix
* GNUmakefile.am:
* page/AccessibilityTable.cpp: Change nil to 0
(WebCore::AccessibilityTable::cellForColumnAndRow):
2008-08-19 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Geoff Garen.
Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
* ForwardingHeaders/kjs/JSLock.h: Added.
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/GCController.cpp:
(WebCore::collect):
(WebCore::GCController::gcTimerFired):
(WebCore::GCController::garbageCollectNow):
* bindings/js/JSCustomSQLStatementCallback.cpp:
(WebCore::JSCustomSQLStatementCallback::handleEvent):
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
* bindings/js/JSCustomSQLTransactionCallback.cpp:
(WebCore::JSCustomSQLTransactionCallback::handleEvent):
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
* bindings/js/JSCustomVoidCallback.cpp:
(WebCore::JSCustomVoidCallback::handleEvent):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::DOMWindowTimer::~DOMWindowTimer):
(WebCore::JSDOMWindowBase::clear):
(WebCore::JSDOMWindowBase::timerFired):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSEventListener.cpp:
(WebCore::JSAbstractEventListener::handleEvent):
* bindings/js/JSNSResolver.cpp:
(WebCore::JSNSResolver::lookupNamespaceURI):
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::createHTMLEventHandler):
(WebCore::ScriptController::createSVGEventHandler):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
(WebCore::ScriptController::clearScriptObjects):
* bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::windowScriptObject):
* bindings/objc/WebScriptObject.mm:
(_didExecute):
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):
(-[WebScriptObject stringRepresentation]):
(-[WebScriptObject webScriptValueAtIndex:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
* bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_Enumerate):
* bridge/c/c_class.cpp:
(KJS::Bindings::CClass::~CClass):
(KJS::Bindings::CClass::methodsNamed):
(KJS::Bindings::CClass::fieldNamed):
* bridge/c/c_instance.cpp:
(KJS::Bindings::CInstance::invokeMethod):
(KJS::Bindings::CInstance::invokeDefaultMethod):
(KJS::Bindings::CInstance::getPropertyNames):
* bridge/c/c_runtime.cpp:
(KJS::Bindings::CField::valueFromInstance):
(KJS::Bindings::CField::setValueToInstance):
* bridge/c/c_utility.cpp:
(KJS::Bindings::convertValueToNPVariant):
(KJS::Bindings::convertNPVariantToValue):
* bridge/jni/jni_class.cpp:
(JavaClass::JavaClass):
(JavaClass::~JavaClass):
* bridge/jni/jni_instance.cpp:
(JavaInstance::stringValue):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
(JavaJSObject::getSlot):
(JavaJSObject::setSlot):
(JavaJSObject::toString):
(JavaJSObject::convertValueToJObject):
(JavaJSObject::convertJObjectToValue):
* bridge/jni/jni_objc.mm:
(KJS::Bindings::dispatchJNICall):
* bridge/jni/jni_runtime.cpp:
(appendClassName):
(JavaMethod::signature):
* bridge/jni/jni_runtime.h:
(KJS::Bindings::JavaString::JavaString):
(KJS::Bindings::JavaString::_commonInit):
(KJS::Bindings::JavaString::~JavaString):
(KJS::Bindings::JavaString::UTF8String):
* bridge/jni/jni_utility.cpp:
(KJS::Bindings::convertValueToJValue):
* bridge/npruntime.cpp:
(_NPN_GetStringIdentifier):
* bridge/objc/objc_instance.mm:
(ObjcInstance::moveGlobalExceptionToExecState):
(ObjcInstance::invokeMethod):
(ObjcInstance::invokeDefaultMethod):
(ObjcInstance::setValueOfUndefinedField):
(ObjcInstance::getValueOfUndefinedField):
* bridge/objc/objc_runtime.mm:
(ObjcField::valueFromInstance):
(ObjcField::setValueToInstance):
* bridge/objc/objc_utility.mm:
(KJS::Bindings::convertValueToObjcValue):
(KJS::Bindings::convertNSStringToString):
(KJS::Bindings::convertObjcValueToValue):
* bridge/qt/qt_instance.cpp:
(KJS::Bindings::QtRuntimeObjectImp::removeFromCache):
(KJS::Bindings::QtInstance::~QtInstance):
(KJS::Bindings::QtInstance::getQtInstance):
(KJS::Bindings::QtInstance::getRuntimeObject):
* bridge/qt/qt_runtime.cpp:
(KJS::Bindings::convertValueToQVariant):
(KJS::Bindings::convertQVariantToValue):
(KJS::Bindings::QtRuntimeMetaMethod::call):
(KJS::Bindings::QtRuntimeConnectionMethod::call):
(KJS::Bindings::QtConnectionObject::QtConnectionObject):
(KJS::Bindings::QtConnectionObject::execute):
* bridge/runtime.cpp:
(KJS::Bindings::Instance::createRuntimeObject):
* bridge/testbindings.cpp:
(main):
* bridge/testbindings.mm:
(main):
* bridge/testqtbindings.cpp:
(main):
* dom/Document.cpp:
(WebCore::Document::~Document):
* dom/Node.cpp:
(WebCore::Node::setDocument):
* history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):
* loader/FrameLoader.cpp:
(WebCore::getString):
* page/InspectorController.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
(WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
(WebCore::getResourceDocumentNode):
(WebCore::search):
(WebCore::inspectedWindow):
(WebCore::wrapCallback):
(WebCore::currentCallFrame):
(WebCore::profiles):
(WebCore::InspectorController::focusNode):
(WebCore::InspectorController::inspectedWindowScriptObjectCleared):
(WebCore::InspectorController::addDatabaseScriptResource):
(WebCore::InspectorController::addScriptProfile):
* page/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):
* page/JavaScriptProfileNode.cpp:
(WebCore::getTotalTime):
(WebCore::getSelfTime):
(WebCore::getTotalPercent):
(WebCore::getSelfPercent):
(WebCore::getNumberOfCalls):
(WebCore::getChildren):
(WebCore::getVisible):
* page/Page.cpp:
* page/mac/FrameMac.mm:
* plugins/PluginView.cpp:
(WebCore::PluginView::start):
(WebCore::getString):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::bindingInstance):
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::paint):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::stop):
(WebCore::PluginView::init):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::stop):
(WebCore::PluginView::init):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::stop):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::clearResponse):
(WebCore::XMLHttpRequest::didFinishLoading):
(WebCore::XMLHttpRequest::didReceiveData):
2008-08-19 Eric Seidel <eric@webkit.org>
Reviewed by Geoff Garen.
Add the beginnings of Skia graphics support to WebCore
as I try to begin the long process of un-forking the changes
needed to WebCore to make Andriod's WebCore build.
I'll follow this up with actual *Skia.cpp files in a separate patch.
* platform/graphics/AffineTransform.h:
* platform/graphics/FloatPoint.h:
* platform/graphics/FloatRect.h:
* platform/graphics/Gradient.h:
* platform/graphics/GraphicsContext.h:
* platform/graphics/Image.h:
* platform/graphics/ImageBuffer.h:
* platform/graphics/ImageSource.h:
* platform/graphics/IntPoint.h:
* platform/graphics/IntRect.h:
* platform/graphics/Path.h:
* platform/graphics/Pattern.h:
* svg/graphics/SVGPaintServerPattern.h:
* svg/graphics/SVGPaintServerSolid.h:
2008-08-19 Steve Falkenburg <sfalken@apple.com>
Fix Windows build more.
* WebCore.vcproj/WebCore.vcproj:
2008-08-19 Steve Falkenburg <sfalken@apple.com>
Fix Windows build.
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
2008-08-19 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/4003764> Expose tables as AXTables
Tests: accessibility/table-attributes.html
accessibility/table-cell-spans.html
accessibility/table-cells.html
accessibility/table-detection.html
accessibility/table-sections.html
accessibility/table-with-rules.html
* WebCore.xcodeproj/project.pbxproj:
* page/AXObjectCache.cpp:
(WebCore::AXObjectCache::get):
* page/AccessibilityObject.h:
(WebCore::):
(WebCore::AccessibilityObject::isDataTable):
(WebCore::AccessibilityObject::isTableRow):
(WebCore::AccessibilityObject::isTableColumn):
(WebCore::AccessibilityObject::isTableCell):
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
* page/AccessibilityTable.cpp: Added.
(WebCore::AccessibilityTable::AccessibilityTable):
(WebCore::AccessibilityTable::~AccessibilityTable):
(WebCore::AccessibilityTable::create):
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::clearChildren):
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::headerContainer):
(WebCore::AccessibilityTable::columns):
(WebCore::AccessibilityTable::rows):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::cells):
(WebCore::AccessibilityTable::columnCount):
(WebCore::AccessibilityTable::rowCount):
(WebCore::AccessibilityTable::cellForColumnAndRow):
(WebCore::AccessibilityTable::roleValue):
(WebCore::AccessibilityTable::accessibilityIsIgnored):
(WebCore::AccessibilityTable::title):
(WebCore::AccessibilityTable::isDataTable):
* page/AccessibilityTable.h: Added.
* page/AccessibilityTableCell.cpp: Added.
(WebCore::AccessibilityTableCell::AccessibilityTableCell):
(WebCore::AccessibilityTableCell::~AccessibilityTableCell):
(WebCore::AccessibilityTableCell::create):
(WebCore::AccessibilityTableCell::accessibilityIsIgnored):
(WebCore::AccessibilityTableCell::rowIndexRange):
(WebCore::AccessibilityTableCell::columnIndexRange):
* page/AccessibilityTableCell.h: Added.
(WebCore::AccessibilityTableCell::isTableCell):
(WebCore::AccessibilityTableCell::roleValue):
* page/AccessibilityTableColumn.cpp: Added.
(WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
(WebCore::AccessibilityTableColumn::~AccessibilityTableColumn):
(WebCore::AccessibilityTableColumn::create):
(WebCore::AccessibilityTableColumn::setParentTable):
(WebCore::AccessibilityTableColumn::elementRect):
(WebCore::AccessibilityTableColumn::size):
(WebCore::AccessibilityTableColumn::children):
(WebCore::AccessibilityTableColumn::headerObject):
(WebCore::AccessibilityTableColumn::headerObjectForSection):
(WebCore::AccessibilityTableColumn::addChildren):
* page/AccessibilityTableColumn.h: Added.
(WebCore::AccessibilityTableColumn::parentObject):
(WebCore::AccessibilityTableColumn::roleValue):
(WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
(WebCore::AccessibilityTableColumn::isTableColumn):
(WebCore::AccessibilityTableColumn::setColumnIndex):
(WebCore::AccessibilityTableColumn::columnIndex):
* page/AccessibilityTableHeaderContainer.cpp: Added.
(WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
(WebCore::AccessibilityTableHeaderContainer::~AccessibilityTableHeaderContainer):
(WebCore::AccessibilityTableHeaderContainer::create):
(WebCore::AccessibilityTableHeaderContainer::children):
(WebCore::AccessibilityTableHeaderContainer::elementRect):
(WebCore::AccessibilityTableHeaderContainer::size):
(WebCore::AccessibilityTableHeaderContainer::addChildren):
* page/AccessibilityTableHeaderContainer.h: Added.
(WebCore::AccessibilityTableHeaderContainer::roleValue):
(WebCore::AccessibilityTableHeaderContainer::setParentTable):
(WebCore::AccessibilityTableHeaderContainer::parentObject):
(WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
* page/AccessibilityTableRow.cpp: Added.
(WebCore::AccessibilityTableRow::AccessibilityTableRow):
(WebCore::AccessibilityTableRow::~AccessibilityTableRow):
(WebCore::AccessibilityTableRow::create):
(WebCore::AccessibilityTableRow::accessibilityIsIgnored):
(WebCore::AccessibilityTableRow::headerObject):
* page/AccessibilityTableRow.h: Added.
(WebCore::AccessibilityTableRow::isTableRow):
(WebCore::AccessibilityTableRow::roleValue):
(WebCore::AccessibilityTableRow::setRowIndex):
(WebCore::AccessibilityTableRow::rowIndex):
* page/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(RoleEntry::):
(-[AccessibilityObjectWrapper roleDescription]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
2008-08-19 Steve Falkenburg <sfalken@apple.com>
Build fix.
Add buildfailed support to stop builds early (preventing inaccurate error messages).
Add missing post-build rule to Release.
* WebCore.vcproj/QTMovieWin.vcproj:
2008-08-19 Keishi Hattori <casey.hattori@gmail.com>
Added support for console.count in the inspector.
Reviewed by Geoff Garen.
* page/Console.cpp:
(WebCore::Console::count):
* page/Console.h:
* page/Console.idl: Added console.count.
* page/InspectorController.cpp:
(WebCore::InspectorController::didCommitLoad): Clears m_counts.
(WebCore::InspectorController::count): Updates the count number
sing "title@source:line" as the identifier, and adds a
message to the console.
* page/InspectorController.h: Added m_counts.
2008-08-19 Keishi Hattori <casey.hattori@gmail.com>
Clear console.time timers when changing page.
Reviewed by Geoff Garen.
* page/InspectorController.cpp:
(WebCore::InspectorController::didCommitLoad):
2008-08-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/6154695> Full-page movies flicker while playing
https://bugs.webkit.org/show_bug.cgi?id=20404
Ignore setVisible() when visibility doesn't change.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::setVisible):
2008-08-19 Timothy Hatcher <timothy@apple.com>
Fixes a bug in the Profile view where switching sort order, then
switching from heavy to tree mode would show the tree in the
previous sort order.
https://bugs.webkit.org/show_bug.cgi?id=20441
Reviewed by Kevin McCullough.
* page/inspector/ProfileView.js:
(WebInspector.ProfileView.prototype._changeView): Call _sortProfile
on the next profile before assigning it to this.profile.
(WebInspector.ProfileView.prototype._sortData): Call _sortProfile.
(WebInspector.ProfileView.prototype._sortProfile): Moves from
_sortData and takes a profile argument. If the profile passed in
matches the this.profile, then call refresh.
2008-08-18 Timothy Hatcher <timothy@apple.com>
Changed the default sort order now that heavy view is the default.
Also fixes a bug where the heavy profile was not sorted at first.
https://bugs.webkit.org/show_bug.cgi?id=20440
Reviewed by Kevin McCullough.
* page/inspector/ProfileView.js:
(WebInspector.ProfileView): Changed the default sort column. Also assign
heavyProfile to profile, so the sortSelfTimeDescending call happens
on the heavy profile before assigning to this.profile.
2008-08-18 Timothy Hatcher <timothy@apple.com>
Add support for editing DOM properties and scope variables by double
clicking a property to enter edit mode.
https://bugs.webkit.org/show_bug.cgi?id=20415
Reviewed by Kevin McCullough.
* page/inspector/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection): Set editable to true by default.
(WebInspector.ObjectPropertiesSection.prototype.onpopulate):
Factored out code into update, and calls update.
(WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate.
Call removeChildren since this method can be called multiple times now.
(WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title
gets made later in onattach.
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early
if shouldRefreshChildren is true. Call removeChildren since this method can be
called multiple times now.
(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing.
(WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update.
(WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for
this element (code moved from the constructor.)
(WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all
sibling property elements.
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call
WebInspector.startEditing after rememebring some context.
(WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft
for the list element, since it might have scrolled during editing.
(WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded
then restore the state from the context. Then call update to restore the title.
(WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled
if the user input and the previous input are the same. Call editingEnded, then call applyExpression
to commit the user input.
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression
and stores the result on the object for the property name of this element. If the expression is
empty, delete the property and remove the tree element.
* page/inspector/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused
property on each ObjectPropertiesSection.
(WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach
since it is now implemented.
* page/inspector/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument
that defaults to true if omitted. It specifies whether to call update on the scope chain.
* page/inspector/inspector.css: New styles.
* page/inspector/treeoutline.js:
(TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren
change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
2008-08-18 Timothy Hatcher <timothy@apple.com>
Surround the expression to be evaluated in parenthesis so the
result of the eval is the result of the whole expression not
the last potential sub-expression. So evaluating {x: 123}
will show the Object not 123.
https://bugs.webkit.org/show_bug.cgi?id=20428
Reviewed by Kevin McCullough.
* page/inspector/Console.js:
(Console.prototype._evalInInspectedWindow): Add parenthesis
around the expression. And add couple comments.
2008-08-19 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff.
-Implement a page() function to extract a common code pattern.
* WebCore.xcodeproj/project.pbxproj:
* page/Console.cpp:
(WebCore::Console::addMessage):
(WebCore::Console::error):
(WebCore::Console::info):
(WebCore::Console::log):
(WebCore::Console::dir):
(WebCore::Console::assertCondition):
(WebCore::Console::time):
(WebCore::Console::timeEnd):
(WebCore::Console::group):
(WebCore::Console::groupEnd):
(WebCore::Console::finishedProfiling):
(WebCore::Console::warn):
(WebCore::Console::framePage):
* page/Console.h:
2008-08-12 Darin Adler <darin@apple.com>
Reviewed by Geoff.
- eliminate JSValue::type()
* bridge/c/c_instance.cpp:
(KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType
argument instead of JSType argument. Removed unneeded code to handle
boolean, since that's never passed.
* bridge/c/c_instance.h: Ditto.
* bridge/c/c_utility.cpp:
(KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions
instead of JSValue::type(). Removed unneeded code to handle
"unspecified".
* bridge/jni/jni_instance.cpp:
(JavaInstance::defaultValue): Take PreferredPrimitiveType argument
instead of JSType argument. Removed unneeded code to handle boolean.
* bridge/jni/jni_instance.h: Ditto.
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::convertValueToJObject): Use JSValue::is functions
instead of JSValue::type().
* bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument
instead of JSType argument. Removed unused argument.
* bridge/objc/objc_instance.mm:
(ObjcInstance::getValueOfUndefinedField): Removed unused argument.
(ObjcInstance::defaultValue): Take PreferredPrimitiveType argument
instead of JSType argument. Removed unneeded code to handle boolean
and another dead code path for unknown types.
* bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument
instead of JSType argument. Removed override of type() that caused
the fallback object to return "UndefinedType" when there is no
invokeUndefinedMethodFromWebScript:withArguments: method defined.
That didn't accomplish much, since most checks for undefined don't
ever call type().
* bridge/objc/objc_runtime.mm:
(ObjcFallbackObjectImp::defaultValue): Ditto.
* bridge/qt/qt_instance.cpp:
(KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType
argument instead of JSType argument. Removed unneeded code to handle
boolean.
* bridge/qt/qt_instance.h: Ditto.
* bridge/runtime.h:
(KJS::Bindings::Instance::getValueOfUndefinedField): Removed
unsed argument.
* bridge/runtime_object.cpp:
(RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType
argument instead of JSType argument.
* bridge/runtime_object.h: Ditto.
2008-08-18 Maxime Britto <britto@apple.com>
Reviewed by Adele.
<rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
We shouldn't be able to create another window while we are in pan scrolling.
Other browsers behaviors :
FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
IE7 : Keys are not disabled but stops immediately the panning.
This patch matches FF3 behavior by disabling every key but the esc key.
* page/EventHandler.cpp:
(WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped.
(WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
2008-08-18 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
Test: fast/replaced/max-width-percent.html
Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
When false, max-width is not factored into the
calculation.
Changed RenderReplaced and subclasses' calcPrefWidths() to call
calcReplacedWidth(false) and then apply max-width only if it has a
fixed, positive value.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcReplacedWidth):
* rendering/RenderBox.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::calcReplacedWidth):
(WebCore::RenderImage::calcPrefWidths):
* rendering/RenderImage.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::calcPrefWidths):
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::calcPrefWidths):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::calcReplacedWidth):
(WebCore::RenderVideo::calcPrefWidths):
* rendering/RenderVideo.h:
2008-08-18 Daniel Macks <dmacks@netspace.org>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=20410
More portable/self-documenting replacement for SIZE_MAX.
* platform/network/curl/FormDataStreamCurl.cpp:
(WebCore::FormDataStream::read):
2008-08-18 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
Need to make sure we have an Animation in the AnimationList
before setting the initial value.
https://bugs.webkit.org/show_bug.cgi?id=20408
Test: fast/css/transition_shorthand_parsing.html
* css/CSSStyleSelector.cpp:
2008-08-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
is another profile.
* page/inspector/ProfilesPanel.js:
2008-08-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff.
<rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
all console messages
* page/inspector/Console.js:
2008-08-18 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
Fixed Canvas for Cairo. Stroke and fill colors didn't work after
the canvas clean up.
https://bugs.webkit.org/show_bug.cgi?id=20405
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::fillRect):
2008-08-17 Timothy Hatcher <timothy@apple.com>
Complete in scope variables in the Console when paused.
https://bugs.webkit.org/show_bug.cgi?id=19115
Reviewed by Geoffrey Garen.
* page/inspector/Console.js:
(WebInspector.Console.prototype.completions): If the expressionString
is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame
to get an object that declares all the in scope variables. That way
"top level" expressions are completed.
* page/inspector/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame):
Return an object that has all the variables that are in scope for the
selected call frame. The value of each property is just true.
The return object is useful for quick lookups or auto completion.
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Not reviewed.
Speculative Qt build fix.
* bridge/qt/qt_runtime.cpp:
(KJS::Bindings::convertValueToQVariant):
(KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
* manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Made room for a free word in JSCell.
Changed JSDOMWindowBase to store its auxiliary data in a subclass of
JSGlobalData, so the two could share a pointer.
Added a bunch of ASSERTs, to help catch over-sized objects.
2008-08-15 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Disable dead code stripping in debug builds.
* Configurations/Base.xcconfig:
* WebCore.xcodeproj/project.pbxproj:
2008-08-15 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Geoff Garen.
<rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
* Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared
between the Debug configuration and debug Production variant.
* WebCore.xcodeproj/project.pbxproj: Enable the debug variant.
2008-08-15 Antti Koivisto <antti@apple.com>
Reviewed by Anders.
Don't start preloading body resources before the head is complete. This prevents
body preloads from slowing down initial display when there is limited amount
of bandwidth available.
Works by queuing up found body preloads to DocLoader and only issuing them
after document has rendering.
With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
without affecting complete load time.
* html/PreloadScanner.cpp:
(WebCore::PreloadScanner::PreloadScanner):
(WebCore::PreloadScanner::scanningBody):
(WebCore::PreloadScanner::emitTag):
(WebCore::PreloadScanner::emitCSSRule):
* html/PreloadScanner.h:
* loader/DocLoader.cpp:
(WebCore::DocLoader::preload):
(WebCore::DocLoader::checkForPendingPreloads):
(WebCore::DocLoader::requestPreload):
* loader/DocLoader.h:
* loader/loader.cpp:
(WebCore::Loader::Host::didFinishLoading):
(WebCore::Loader::Host::didFail):
2008-08-15 Ada Chan <adachan@apple.com>
Use item's computed style if the render style is 0 before falling back to the <select>'s style.
This way style set on an <hr> within a <select> will be honored.
Reviewed by Dave Hyatt and Dan Bernstein.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemStyle):
2008-08-15 Antti Koivisto <antti@apple.com>
Reviewed by Oliver.
Some loader performance tweaks:
- Make stylesheets highest priority instead of scripts. We block script execution on stylesheets.
Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue
to not delay rendering.
- Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup
can take long time when latency is high so it is good to get started early.
- When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the
load queues. Issue remaining loads to the network layer.
* loader/loader.cpp:
(WebCore::Loader::determinePriority):
(WebCore::Loader::load):
(WebCore::Loader::Host::servePendingRequests):
* loader/loader.h:
2008-08-15 Timothy Hatcher <timothy@apple.com>
Detach the script debugger when the Web Inspector's window closes.
This has always been the intended design, but never fully implemented.
https://bugs.webkit.org/show_bug.cgi?id=20402
Reviewed by Adam Roben.
* page/InspectorController.cpp:
(WebCore::InspectorController::setWindowVisible): Call stopDebugging()
if the window is no longer visible.
2008-08-15 HÃ¥vard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_CONTEXTMENU
* platform/qt/PlatformMouseEventQt.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
* platform/qt/PlatformScrollBarQt.cpp:
(WebCore::PlatformScrollbar::handleMouseMoveEvent):
(WebCore::PlatformScrollbar::handleContextMenuEvent):
2008-08-15 HÃ¥vard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_WHEELEVENT
* platform/qt/WheelEventQt.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector
https://bugs.webkit.org/show_bug.cgi?id=20210
Reviewed by Tim Hatcher.
* page/Console.cpp:
(WebCore::Console::group):
(WebCore::Console::groupEnd):
* page/Console.h:
(WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
* page/InspectorController.cpp:
(WebCore::InspectorController::startGroup): Increments group level by
one and adds console message with StartGroupMessaageLevel.
(WebCore::InspectorController::endGroup): Decrements group level by one
and adds console message with EndGroupMessaageLevel.
* page/InspectorController.h:
* page/inspector/Console.js:
(WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup
if the message is StartGroupMessaageLevel.
(WebInspector.ConsoleMessage.prototype.toMessageElement):
(WebInspector.ConsoleGroup.prototype.addMessage):
* page/inspector/inspector.js:
2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
Adds support for console.dir to the Inspector
https://bugs.webkit.org/show_bug.cgi?id=19155
Reviewed by Tim Hatcher.
* bindings/js/JSConsoleCustom.cpp:
(WebCore::JSConsole::dir):
* page/Console.cpp:
(WebCore::Console::dir):
* page/Console.h: Added ObjectMessageLevel.
* page/Console.idl: Added console.dir.
* page/inspector/Console.js:
(WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an
ObjectPropertiesSection if the MessageLevel is Object.
* page/inspector/ObjectPropertiesSection.js: "in" operator can't be
used on primitive data types.
* page/inspector/inspector.css:
2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
Adds support for clear() in the Inspector console.
https://bugs.webkit.org/show_bug.cgi?id=19873
Reviewed by Tim Hatcher.
* page/inspector/Console.js:
2008-08-15 Anthony Ricaud <rik24d@gmail.com>
Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
Platform distinction and modifier key matching adjusted
by Daniel Jalkut <jalkut@red-sweater.com>
Bug 16313: text search (find) keybindings should work in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=16313
Reviewed by Tim Hatcher.
* page/inspector/inspector.js: Added a case for the F key
2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
Fix for error when the string doesn't contain a webkit-profile link.
https://bugs.webkit.org/show_bug.cgi?id=20399
Reviewed by Tim Hatcher.
* page/inspector/inspector.js:
2008-08-15 Timothy Hatcher <timothy@apple.com>
Fixes two bugs where JavaScript could be executed from the page
while the debugger is paused.
The first issue was JSLazyEventListener not checking the paused
state before parsing the code.
The second issue was with the PageGroup version of
JavaScriptDebugServer::setJavaScriptPaused always passing false
to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
and not the paused argument.
https://bugs.webkit.org/show_bug.cgi?id=20284
Reviewed by Adam Roben.
* bindings/js/JSEventListener.cpp:
(WebCore::JSLazyEventListener::parseCode): Check the paused
state of the ScriptController. Return early if paused.
* manual-tests/inspector/debugger-execution-while-paused.html: Added.
* page/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::setJavaScriptPaused):
Pass the paused argument to the Page version of setJavaScriptPaused.
2008-08-15 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Geoff Garen.
JSStringRef is created context-free, but can get linked to one via an identifier table,
breaking an implicit API contract.
* page/InspectorController.cpp:
(WebCore::jsStringRef):
(WebCore::InspectorController::didParseSource):
(WebCore::InspectorController::failedToParseSource):
* page/JavaScriptProfile.cpp:
(WebCore::getTitleCallback):
Updated for JavaScriptCore changes.
2008-08-14 Kevin Ollivier <kevino@theolliviers.com>
wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with
an alternative that performs reasonably well. (GDI+ is too slow in many cases.)
* platform/graphics/AffineTransform.h:
2008-08-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
<video> elements on Windows never becomes visible when a page is restored from the cache
Always pass "set" calls down to MediaPlayerPrivate instead of only when the
value is different from the cached value. Let the implementation decide when
to avoid work because nothing has changed.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::setVolume):
(WebCore::MediaPlayer::setRate):
(WebCore::MediaPlayer::setRect):
(WebCore::MediaPlayer::setVisible):
2008-08-14 Keishi Hattori <casey.hattori@gmail.com>
Make Firebug command line API respect predefined variables.
https://bugs.webkit.org/show_bug.cgi?id=20385
Reviewed by Tim Hatcher.
* page/inspector/Console.js:
2008-08-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen and Timothy Hatcher.
Allow programatically setting the HTMLTokenizers time delay and chunk size
which are used for determining how aggressively we yield.
* WebCore.base.exp:
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::begin):
(WebCore::HTMLTokenizer::continueProcessing):
* html/HTMLTokenizer.h:
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::setCustomHTMLTokenizerTimeDelay):
(WebCore::Page::setCustomHTMLTokenizerChunkSize):
* page/Page.h:
(WebCore::Page::hasCustomHTMLTokenizerTimeDelay):
(WebCore::Page::customHTMLTokenizerTimeDelay):
(WebCore::Page::hasCustomHTMLTokenizerChunkSize):
(WebCore::Page::customHTMLTokenizerChunkSize):
2008-08-14 Eric Seidel <eric@webkit.org>
Reviewed by Beth.
Move us one step closer to cross-platform svg/graphics code
* WebCore.xcodeproj/project.pbxproj:
* html/CanvasStyle.cpp:
* platform/graphics/Color.cpp:
(WebCore::colorWithOverrideAlpha):
* platform/graphics/Color.h:
* svg/graphics/cg/CgSupport.cpp:
(WebCore::applyStrokeStyleToContext):
(WebCore::strokeBoundingBox):
* svg/graphics/cg/SVGPaintServerSolidCg.cpp:
(WebCore::SVGPaintServerSolid::setup):
2008-08-14 Eric Seidel <eric@webkit.org>
Reviewed by Alexey.
Remove un-need includes from HTMLCanvas and use the
Gradient platform abstraction in one place in CanvasStyle
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fillRect):
* html/CanvasStyle.cpp:
* html/HTMLCanvasElement.cpp:
2008-08-14 Eric Seidel <eric@webkit.org>
Reviewed by Alexey.
Clean up GlyphBuffer.h, removing more #ifdefs
* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::glyphAt):
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::add):
2008-08-14 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Clean up AffineTransform.h, removing #ifdefs
* platform/graphics/AffineTransform.h:
* platform/graphics/cairo/AffineTransformCairo.cpp:
* platform/graphics/cg/AffineTransformCG.cpp:
* platform/graphics/qt/AffineTransformQt.cpp:
* platform/graphics/wx/AffineTransformWx.cpp:
2008-08-14 Dan Bernstein <mitz@apple.com>
- fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
* platform/graphics/cairo/ImageSourceCairo.cpp:
(WebCore::ImageSource::frameSizeAtIndex):
* platform/graphics/qt/ImageSourceQt.cpp:
(WebCore::ImageSource::frameSizeAtIndex):
* platform/graphics/wx/ImageSourceWx.cpp:
(WebCore::ImageSource::frameSizeAtIndex):
2008-08-14 Dan Bernstein <mitz@apple.com>
Reviewed by Brady Eidson.
- fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage): Added initialization of
m_hasUniformFrameSize.
(WebCore::BitmapImage::cacheFrame): Added code to get the size of the
cached frame for use in decoded size computation and for setting
m_hasUniformFrameSize.
(WebCore::BitmapImage::currentFrameSize): Added.
(WebCore::BitmapImage::dataChanged): Added code to reset
m_hasUniformFrameSize.
* platform/graphics/BitmapImage.h: Added currentFrameSize() and
m_hasUniformFrameSize.
* platform/graphics/ImageSource.h: Added frameSizeAtIndex().
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This
fixes the bug, which resulted from assuming that the frame being drawn
was the same size as the first frame.
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and
changed to get the size of the frame at the given index.
(WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
2008-08-13 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel
Fix @font-face inside @media rule crash.
https://bugs.webkit.org/show_bug.cgi?id=20367
Test: fast/css/font-face-in-media-rule.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSRuleSet::addRulesFromSheet):
2008-08-14 Kevin Ollivier <kevino@theolliviers.com>
wx build fixes after recent changes to Canvas and Image classes.
* platform/graphics/Pattern.h:
* platform/graphics/wx/GradientWx.cpp:
(WebCore::Gradient::fill):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::applyStrokePattern):
* platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::image):
* platform/graphics/wx/ImageWx.cpp:
(WebCore::Image::loadPlatformResource):
2008-08-14 Maxime Britto <britto@apple.com>
Reviewed by Sam Weinig.
rdar://6102511
When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
IE and FF are both preventing the keyboard event to interact with the page while scrolling.
Some differences exist between them concerning the kind of key which is pressed :
IE7 : every key leads to a stop of the panning
FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.
* page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
2008-08-14 Christian Dywan <christian@twotoasts.de>
Gtk+/ Cairo build fix, patch by Dirk Schulze.
* html/CanvasStyle.cpp:
* platform/graphics/cairo/PatternCairo.cpp:
(WebCore::Pattern::createPlatformPattern):
* svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
2008-08-14 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6115819> Notify of profile in console
* page/InspectorController.cpp:
(WebCore::InspectorController::addProfile):
(WebCore::InspectorController::addProfileMessageToConsole): Called by
addProfile this is the function that adds a message to the console that
a profile finished.
* page/InspectorController.h:
* page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match
the console log to the profile in the web inspector.
(WebCore::getUniqueIdCallback):
(WebCore::ProfileClass):
* page/inspector/ProfilesPanel.js: Created a map of all the profiles by
Id to bring up the requested profile. Also select and reveal the
profile in the profile panel. And created displayTitleForProfileLink()
which formats a title taking into account if it's user initiated or if
there are multiples. Lasty, I put the user initiated profile in a
variable.
* page/inspector/inspector.js: Make the profile title be a clickable
link that will take the user to the identified profile. Also expose
the count of user initiated profiles so they can be displayed in the
console with the correct count.
2008-08-14 Timothy Hatcher <timothy@apple.com>
Avoid formating ConsoleMessages twice unless the message will be
displayed in bubbles of a SourceFrame.
Reviewed by Kevin McCullough.
* page/inspector/Console.js:
(WebInspector.ConsoleMessage): Only format the plain text message
if the URL and line are valid and the level is error or warning.
(WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added.
Helper to test for error or warning level.
* page/inspector/SourceFrame.js:
(WebInspector.SourceFrame.prototype.addMessage): Don't add the
message if there is no message or valid line or if the msg
isn't an error or warning.
2008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
partial Gtk build fix, not reviewed
* platform/graphics/cairo/PatternCairo.cpp:
2008-08-13 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlson.
Fix style issue.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::pickMedia):
2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
Build fix for Cairo, not reviewed. (exposed by gtk build slave)
Continue Erics build fixes, after the Image cleanup.
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::image):
2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
Build fix for Qt, not reviewed.
Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.
* dom/XMLTokenizer.cpp:
(WebCore::eventuallyMarkAsParserCreated): Was erre
2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
Build fix, not reviewed.
Add ScriptElement.cpp to Gtk build.
* GNUmakefile.am:
2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
Refactor HTMLScriptElement's code into a common base class: ScriptElement.
SVGScriptElement will be converted to use ScriptElement in a follow-up patch.
This resolves code duplications and allows us to completly replace the old
SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)
As ScriptElement, doesn't actually inherit from Element, we may want to rename
it, though StyleElement uses the same naming convention, so I left it as is for now.
Eventually we'll rename both files in future.
No functional changes yet, as SVGScriptElement doesn't yet use the new base class.
* WebCore.pro: Add new ScriptElement.cpp to build.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* WebCoreSources.bkl: Dutto.
* dom/ScriptElement.cpp: Added. 1:1 based on HTMLScriptElement
(WebCore::ScriptElement::insertedIntoDocument):
(WebCore::ScriptElement::removedFromDocument):
(WebCore::ScriptElement::childrenChanged):
(WebCore::ScriptElement::finishParsingChildren):
(WebCore::ScriptElement::handleSourceAttribute):
(WebCore::isSupportedJavaScriptLanguage):
(WebCore::ScriptElementData::ScriptElementData):
(WebCore::ScriptElementData::~ScriptElementData):
(WebCore::ScriptElementData::requestScript):
(WebCore::ScriptElementData::evaluateScript):
(WebCore::ScriptElementData::stopLoadRequest):
(WebCore::ScriptElementData::notifyFinished):
(WebCore::ScriptElementData::ignoresLoadRequest):
(WebCore::ScriptElementData::shouldExecuteAsJavaScript):
(WebCore::ScriptElementData::scriptCharset):
(WebCore::ScriptElementData::scriptContent):
* dom/ScriptElement.h: Added.
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::~ScriptElement):
(WebCore::ScriptElementData::element):
(WebCore::ScriptElementData::createdByParser):
(WebCore::ScriptElementData::setCreatedByParser):
* dom/XMLTokenizer.cpp:
(WebCore::isScriptElement):
(WebCore::castToScriptElement):
(WebCore::eventuallyMarkAsParserCreated):
(WebCore::XMLTokenizer::startElementNs):
(WebCore::XMLTokenizer::endElementNs):
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLTokenizer::insertErrorMessageBlock):
* html/HTMLScriptElement.cpp: Refactored code, pushed most code down to ScriptElement.
(WebCore::HTMLScriptElement::HTMLScriptElement):
(WebCore::HTMLScriptElement::~HTMLScriptElement):
(WebCore::HTMLScriptElement::isURLAttribute):
(WebCore::HTMLScriptElement::setCreatedByParser):
(WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
(WebCore::HTMLScriptElement::childrenChanged):
(WebCore::HTMLScriptElement::parseMappedAttribute):
(WebCore::HTMLScriptElement::finishParsingChildren):
(WebCore::HTMLScriptElement::insertedIntoDocument):
(WebCore::HTMLScriptElement::removedFromDocument):
(WebCore::HTMLScriptElement::text):
(WebCore::HTMLScriptElement::setText):
(WebCore::HTMLScriptElement::setHtmlFor):
(WebCore::HTMLScriptElement::setEvent):
(WebCore::HTMLScriptElement::charset):
(WebCore::HTMLScriptElement::src):
(WebCore::HTMLScriptElement::type):
(WebCore::HTMLScriptElement::scriptCharset):
(WebCore::HTMLScriptElement::scriptContent):
(WebCore::HTMLScriptElement::sourceAttributeValue):
(WebCore::HTMLScriptElement::charsetAttributeValue):
(WebCore::HTMLScriptElement::typeAttributeValue):
(WebCore::HTMLScriptElement::languageAttributeValue):
(WebCore::HTMLScriptElement::dispatchLoadEvent):
(WebCore::HTMLScriptElement::dispatchErrorEvent):
* html/HTMLScriptElement.h:
* svg/SVGScriptElement.cpp: Inherit from ScriptElement, don't actually use it yet.
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::SVGScriptElement):
(WebCore::SVGScriptElement::scriptContent):
(WebCore::SVGScriptElement::sourceAttributeValue):
(WebCore::SVGScriptElement::charsetAttributeValue):
(WebCore::SVGScriptElement::typeAttributeValue):
(WebCore::SVGScriptElement::languageAttributeValue):
(WebCore::SVGScriptElement::dispatchLoadEvent):
(WebCore::SVGScriptElement::dispatchErrorEvent):
* svg/SVGScriptElement.h:
(WebCore::SVGScriptElement::setCreatedByParser):
2008-08-13 Eric Seidel <eric@webkit.org>
Attempt to fix the Gtk build, no review.
I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
* platform/graphics/qt/GradientQt.cpp:
* platform/graphics/qt/GraphicsContextQt.cpp:
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::paintMozWidget):
2008-08-13 Eric Seidel <eric@webkit.org>
Yet another attempt to fix the Qt build, no review.
* platform/graphics/qt/GradientQt.cpp:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
2008-08-13 Eric Seidel <eric@webkit.org>
Attempt to fix the Windows build, no review.
* platform/win/CursorWin.cpp:
(WebCore::loadCursorByName):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::paint):
2008-08-13 Eric Seidel <eric@webkit.org>
Attempt to fix the Windows build, no review.
* platform/win/CursorWin.cpp:
(WebCore::loadCursorByName):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::paint):
2008-08-13 Eric Seidel <eric@webkit.org>
Attempt to fix the Qt build, no review.
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::image):
2008-08-13 Eric Seidel <eric@webkit.org>
Attempt to fix the Windows build, no review.
* platform/graphics/win/ImageWin.cpp:
(WebCore::Image::loadPlatformResource):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintMissingPluginIcon):
2008-08-13 Eric Seidel <eric@webkit.org>
Another attempt to fix the Qt build, no review.
* platform/graphics/qt/ImageQt.cpp:
* platform/graphics/qt/StillImageQt.h:
2008-08-13 Eric Seidel <eric@webkit.org>
No review, build fix only.
Fix mac build, due to change in new code since my patch was written.
* svg/graphics/cg/SVGResourceMaskerCg.mm:
(WebCore::SVGResourceMasker::applyMask):
2008-08-13 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Attempt to fix the Qt build.
* platform/graphics/qt/ImageBufferQt.cpp:
* platform/graphics/qt/StillImageQt.h:
(WebCore::StillImage::create):
(WebCore::StillImage::destroyDecodedData):
(WebCore::StillImage::decodedSize):
2008-08-13 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Attempt to fix the Qt build.
* html/CanvasStyle.cpp:
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
2008-08-13 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Match HTML5 spec by throwing INVALID_STATE_ERR when
createPattern is called and the HTMLImageElement is not
yet done loading the image (!isComplete)
https://bugs.webkit.org/show_bug.cgi?id=20351
Test: http/misc/canvas-pattern-from-incremental-image.html
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):
2008-08-13 Eric Seidel <eric@webkit.org>
Reviewed by Niko.
Split out a Pattern class from CanvasPattern
and remove all the Pattern-related #ifdefs
(This will break non-mac platforms! I will fix them.)
https://bugs.webkit.org/show_bug.cgi?id=20351
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* html/CanvasPattern.cpp:
(WebCore::CanvasPattern::parseRepetitionType):
(WebCore::CanvasPattern::CanvasPattern):
* html/CanvasPattern.h:
(WebCore::CanvasPattern::create):
(WebCore::CanvasPattern::pattern):
(WebCore::CanvasPattern::originClean):
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::applyStrokePattern):
(WebCore::CanvasRenderingContext2D::applyFillPattern):
* html/CanvasRenderingContext2D.h:
* html/HTMLCanvasElement.cpp:
* html/HTMLCanvasElement.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::createHistoryItem):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
2008-08-13 Eric Seidel <eric@webkit.org>
Reviewed by Niko.
Make Images RefCounted (and clean up callers)
https://bugs.webkit.org/show_bug.cgi?id=20351
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
* loader/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
(WebCore::brokenImage):
(WebCore::nullImage):
(WebCore::CachedImage::image):
(WebCore::CachedImage::notifyObservers):
(WebCore::CachedImage::createImage):
* loader/CachedImage.h:
* loader/icon/IconRecord.cpp:
(WebCore::IconRecord::setImageData):
(WebCore::IconRecord::loadImageFromResource):
* loader/icon/IconRecord.h:
* platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::create):
* platform/graphics/GeneratedImage.h:
* platform/graphics/Gradient.cpp:
* platform/graphics/Gradient.h:
* platform/graphics/Image.cpp:
(WebCore::Image::nullImage):
* platform/graphics/Image.h:
* platform/graphics/ImageBuffer.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::image):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::image):
(WebCore::ImageBuffer::getImageData):
(WebCore::ImageBuffer::putImageData):
* platform/graphics/cg/PDFDocumentImage.h:
(WebCore::PDFDocumentImage::create):
(WebCore::PDFDocumentImage::destroyDecodedData):
(WebCore::PDFDocumentImage::decodedSize):
* platform/graphics/gtk/ImageGtk.cpp:
(WebCore::Image::loadPlatformResource):
* platform/graphics/mac/ImageMac.mm:
(WebCore::Image::loadPlatformResource):
* rendering/RenderImage.cpp:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintOverflowControls):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::nativeImageForCurrentFrame):
* svg/graphics/SVGImage.h:
(WebCore::SVGImage::create):
(WebCore::SVGImage::destroyDecodedData):
(WebCore::SVGImage::decodedSize):
(WebCore::SVGImage::frameAtIndex):
* svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
(WebCore::SVGPaintServerPattern::setup):
* svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
(WebCore::SVGResourceMasker::applyMask):
* svg/graphics/cg/SVGPaintServerPatternCg.cpp:
(WebCore::patternCallback):
* svg/graphics/cg/SVGResourceMaskerCg.mm:
(WebCore::SVGResourceMasker::applyMask):
2008-08-13 Eric Seidel <eric@webkit.org>
Reviewed by Niko.
Remove #ifdefs from CanvasStyle by using platform/Color.h
https://bugs.webkit.org/show_bug.cgi?id=20351
There are some down-sides to this commit.
This commit limits us to 255 levels of grey for calls like:
context.setStrokeStyle(.37, 1.0)
previously CG might have used up to 32bits to store the grey level
Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.
Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
to RGBA32 (like all the rest of colors in WebCore), thus:
context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32
If this is a problem for Dashboard, we can either roll out this commit
or add a beefier Color abstraction, which can be used internally by GraphicsContext
when keeping state, and then GraphicsContext can grow some additional set* routines
for setting the a grey/float/whatever fill and stroke.
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFillStyle):
* html/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
(WebCore::colorWithOverrideAlpha):
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
* html/CanvasStyle.h:
* platform/graphics/Color.cpp:
(WebCore::colorFloatToRGBAByte):
(WebCore::makeRGBA32FromFloats):
* platform/graphics/Color.h:
2008-08-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Fix for <rdar://problem/6137931>
https://bugs.webkit.org/show_bug.cgi?id=20360
Remove all parameters from the MIME type before checking with the MIME type registry
Tests: media/video-source-type-params.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';'
to isSupportedMediaMIMEType()
2008-08-13 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for <rdar://problem/6141345>
This patch refines findString and markAllMatchesForText functions'
interactions with disconnected frames. They no longer rely on
knowing where a range is relative to the visible region and work
with disconnected frames that contain frames.
* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea): Now returns a bool instead of
the visiblity enum.
(WebCore::Editor::firstVisibleRange): This now returns the very
first visible range in the document. It's no longer dependent on
searching forward.
(WebCore::Editor::lastVisibleRange): This now returns the very last
visible range in the document. It's no longer dependent on
searching backwards.
(WebCore::Editor::nextVisibleRange): This returns the next visible
range in the appropriate direction from the current range.
* editing/Editor.h:
* page/Frame.cpp:
(WebCore::Frame::findString):
(WebCore::Frame::markAllMatchesForText):
2008-08-13 Kevin Ollivier <kevino@theolliviers.com>
wx build fix for case-sensitive platforms, like Linux.
* WebCoreSources.bkl:
2008-08-13 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=16881
[GTK] PlatformScreenGtk is unimplemented
Original patch by Christian Dywan.
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
2008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=20318
SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add
g_idle_add is the same as g_idle_add_full with a priority of
G_PRIORITY_DEFAULT_IDLE, so we can safely use that.
* platform/gtk/SharedTimerGtk.cpp:
(WebCore::setSharedTimerFireTime):
2008-08-13 Timothy Hatcher <timothy@apple.com>
Changed the InspectorController so it can be notified when the
attached state of the Inspector changes in WebKit.
Reviewed by Kevin McCullough.
* WebCore.base.exp: Updated the symbol for setWindowVisible.
* page/InspectorController.cpp:
(WebCore::InspectorController::setWindowVisible): Added an attached argument,
that defaults to false.Call setAttachedWindow with the attached argument.
(WebCore::InspectorController::setAttachedWindow): Call the script version
of setAttachedWindow.
* page/InspectorController.h:
* page/inspector/inspector.js:
(WebInspector.setAttachedWindow): Set the attached property.
2008-08-12 Timothy Hatcher <timothy@apple.com>
Added a close button to the Inspector's toolbar when docked.
https://bugs.webkit.org/show_bug.cgi?id=14270
Reviewed by Kevin McCullough.
* page/InspectorController.cpp:
(WebCore::closeWindow): Call InspectorController::closeWindow.
(WebCore::InspectorController::windowScriptObjectAvailable):
Added closeWindow to the script class.
* page/InspectorController.h:
* page/inspector/Images/closeButtons.png: Added.
* page/inspector/inspector.css: Added and changed styles.
* page/inspector/inspector.html: Added the close button.
* page/inspector/inspector.js:
(WebInspector.loaded): Added click event listener to the close button.
(WebInspector.close): Call InspectorController.closeWindow.
2008-08-12 Timothy Hatcher <timothy@apple.com>
Make the docked Web Inspector resizable. This is the cross platform
portion of the code. Each InspectorClient needs to implement the
real resize code.
https://bugs.webkit.org/show_bug.cgi?id=14282
Reviewed by Kevin McCullough.
* loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
* page/InspectorClient.h: Added setAttachedWindowHeight.
* page/InspectorController.cpp:
(WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight
on the InspectorController.
(WebCore::InspectorController::setAttachedWindowHeight): Call
setAttachedWindowHeight on the client.
(WebCore::InspectorController::windowScriptObjectAvailable):
Added setAttachedWindowHeight to the script class.
* page/InspectorController.h:
* page/inspector/inspector.css: Make the cursor on the toolbar be
row-resize when docked.
* page/inspector/inspector.js:
(WebInspector.loaded): Always add the toolbarDragStart event listener.
(WebInspector.toolbarDragStart): Return early if we are not attached
and not on Leopard. Call WebInspector.elementDragStart.
(WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd.
(WebInspector.toolbarDrag): When attached call setAttachedWindowHeight,
otherwise call moveByUnrestricted.
2008-08-13 Simon Hausmann <hausmann@webkit.org>
Reviewed by Holger.
Initialize m_zoomsTextOnly in the Settings constructor.
* page/Settings.cpp:
(WebCore::Settings::Settings):
2008-08-13 Brad Hughes <bhughes@trolltech.com>
Reviewed by Simon.
Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux
The latest upgrade of the intel compiler allows us to compile all of
Qt with optimizations enabled (yay!).
* WebCore.pro:
2008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com>
Reviewed by Simon.
Fix QtWebKit not displaying content on 403 HTTP responses
Just like with 404 responses also display content with 403, as
used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
2008-08-13 Simon Hausmann <hausmann@webkit.org>
Reviewed by Holger.
Qt part of https://bugs.webkit.org/show_bug.cgi?id=18994
Make the formatting of String::format() locale independent through the use of QString::vsprintf.
* platform/text/String.cpp:
(WebCore::String::format):
2008-08-13 Simon Hausmann <hausmann@webkit.org>
Reviewed by Lars.
Fix QWebFrame::setHtml() not setting the new contents immediately.
Added a setter to the DocumentLoader to toggle the deferred loading of the main
resource when it comes from substitute data.
Disable deferred loading of the main resource when we have valid substitute data,
as used by QWebFrame::setHtml.
* loader/DocumentLoader.h:
2008-08-13 Mark Rowe <mrowe@apple.com>
Speculative GTK build fix.
* GNUmakefile.am: Add dependency info for JSSVGElementWrapperFactory.cpp.
2008-08-13 Thiago Macieira <tjmaciei@trolltech.com>
Reviewed by Simon.
Fix encoding of [ and ] in the host part of the URL
Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to
add this workaround to the QUrl <> WebCore::KURL conversion operator so that it
doesn't encode [ and ] when they are found in the host part. That is, the
following URL:
http://[::1]/
is valid and should not be reencoded to:
http://%5b::1%5d/
* platform/qt/KURLQt.cpp:
(WebCore::KURL::operator QUrl):
2008-08-12 Mihnea Ovidenie <mihnea@adobe.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=19891
Broken HTML object elements cause de-reference of pointer to freed memory.
If we fail to load an image for an object tag and we no longer believe the object tag points at
an image, then clear m_imageLoader in the HTMLObjectElement so that we attempt to render the
fall back content.
Reviewed by Dave Hyatt and Alexey Proskuryakov.
Test: http/tests/misc/object-image-error-with-onload.html
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderFallbackContent):
* page/Frame.cpp:
(WebCore::Frame::Frame):
2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Dave.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=19798
Masks are translated, and the mask images are swapped on the y-axis.
Turned out that http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm
is guilty. GraphicsContext::clipToImageBuffer() does some extra transformations that SVGResourcesMaskerCg does not want.
Long term goal is to remove the SVGResource*/SVGPaintServer* classes anyway, so it's okay to duplicate
the "clip to image buffer" functionality, in the CG specific SVGResourceMaskerCg class - as it was before.
* svg/graphics/cg/SVGResourceMaskerCg.mm:
(WebCore::SVGResourceMasker::applyMask): Changed back to use CG clipping again.
2008-08-12 Dan Bernstein <mitz@apple.com>
- WebCore part of <rdar://problem/6121636>
Make fast*alloc() abort() on failure and add "try" variants that
return NULL on failure.
Reviewed by Darin Adler.
* platform/Arena.cpp:
(WebCore::ArenaAllocate): Removed null checking of fastMalloc()'s
result.
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::create): Changed to use tryFastCalloc().
2008-08-12 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=19348
<rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works
Test: fast/frames/frameset-style-recalc.html
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::recalcStyle): Changed to call the base
class implementation after marking for layout.
2008-08-12 Dan Bernstein <mitz@apple.com>
Reviewed by John Sullivan.
- move shouldUpdateWhenOffscreen from Settings to FrameView and rename it shouldUpdateWhileHidden
* WebCore.base.exp:
* page/FrameView.cpp:
(WebCore::FrameViewPrivate::FrameViewPrivate):
(WebCore::FrameView::shouldUpdateWhileHidden):
(WebCore::FrameView::setShouldUpdateWhileHidden):
* page/FrameView.h:
* page/Settings.cpp:
* page/Settings.h:
2008-08-12 Adam Roben <aroben@apple.com>
Windows build fix
* bindings/js/JSSVGPODTypeWrapper.h: Align
JSSVGDynamicPODTypeWrapper's and JSSVGStaticPODTypeWrapperWithParent's
members on 16-byte boundaries to avoid an alignment warning.
2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Add new dynamice-update layout tests covering SVGMarkerElement.
Fix bug: SVGMarkerElement's SVG DOM function calls don't update rendering.
Fix orientAngle/orientType confusion: "auto" orient should always return "0" as angle.
Tests: svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr.html
svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr.html
svg/dynamic-updates/SVGMarkerElement-dom-orient-attr.html
svg/dynamic-updates/SVGMarkerElement-dom-refX-attr.html
svg/dynamic-updates/SVGMarkerElement-dom-refY-attr.html
svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call.html
svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call.html
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::SVGMarkerElement):
(WebCore::SVGMarkerElement::parseMappedAttribute):
(WebCore::SVGMarkerElement::svgAttributeChanged):
(WebCore::SVGMarkerElement::childrenChanged):
(WebCore::SVGMarkerElement::setOrientToAuto):
(WebCore::SVGMarkerElement::setOrientToAngle):
(WebCore::SVGMarkerElement::canvasResource):
2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Add new dynamic-update layout tests covering SVGImageElement.
Fix bug: SVGImageElement doesn't react on 'preserveAspectRatio' changes.
Tests: svg/dynamic-updates/SVGImageElement-dom-height-attr.html
svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr.html
svg/dynamic-updates/SVGImageElement-dom-width-attr.html
svg/dynamic-updates/SVGImageElement-dom-x-attr.html
svg/dynamic-updates/SVGImageElement-dom-y-attr.html
svg/dynamic-updates/SVGImageElement-svgdom-height-prop.html
svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html
svg/dynamic-updates/SVGImageElement-svgdom-width-prop.html
svg/dynamic-updates/SVGImageElement-svgdom-x-prop.html
svg/dynamic-updates/SVGImageElement-svgdom-y-prop.html
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::svgAttributeChanged):
2008-08-11 Anthony Ricaud <rik24d@gmail.com>
Changed Option/Alt-Up or Down in CSS editing when the value is
near zero to jump to the next integer.
Reviewed by Tim Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=20326
* page/inspector/StylesSidebarPane.js:
2008-08-11 Anthony Ricaud <rik24d@gmail.com>
Changed the line highlight transition for an easier animation.
Reviewed by Tim Hatcher.
* page/inspector/SourceFrame.js:
2008-08-11 Keishi Hattori <casey.hattori@gmail.com>
Added support for some Firebug Command Line APIs.
Reviewed by Tim Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=19867
https://bugs.webkit.org/show_bug.cgi?id=19868
https://bugs.webkit.org/show_bug.cgi?id=19869
https://bugs.webkit.org/show_bug.cgi?id=19875
https://bugs.webkit.org/show_bug.cgi?id=19876
https://bugs.webkit.org/show_bug.cgi?id=19880
* page/inspector/Console.js:
(WebInspector.Console.prototype._evalInInspectedWindow):
Create an object on the inspected window that holds the console
command line API functions. This object is used in a with statement
around the typed expression.
2008-08-11 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Antti.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=17736
JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties
failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect)
Added tests: svg/custom/svg-modify-currentTranslate.html
svg/custom/tearoffs-with-tearoffs.html
svg/custom/immutable-properties.html
Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html
* bindings/js/JSSVGPODTypeWrapper.h:
(WebCore::JSSVGDynamicPODTypeWrapper::commitChange):
(WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::create):
(WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::commitChange):
(WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::JSSVGStaticPODTypeWrapperWithPODTypeParent):
(WebCore::JSSVGStaticPODTypeWrapperWithParent::create):
(WebCore::JSSVGStaticPODTypeWrapperWithParent::operator PODType):
(WebCore::JSSVGStaticPODTypeWrapperWithParent::commitChange):
(WebCore::JSSVGStaticPODTypeWrapperWithParent::JSSVGStaticPODTypeWrapperWithParent):
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* svg/SVGSVGElement.idl: Add [Immutable] markers to SVG POD attributes, that contain POD types with writable attributes.
* svg/SVGZoomEvent.idl: SVG specification explicitely demands these attributes to be readonly, even its content.
2008-08-11 Brady Eidson <beidson@apple.com>
Reviewed by John and Anders
Fix for <rdar://problem/6141797>
When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource
would never have nil data.
When they were pushed down into WebCore, that guarantee was lost, subtly changing a few
semantics with some WebKit applications.
The guarantee was a good one and should be restored.
Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already
creates an empty data object in the case of null data for its own purposes.
* loader/SubstituteResource.h:
(WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null. This
well help any future subclassers not make this mistake.
* loader/archive/ArchiveResource.cpp:
(WebCore::ArchiveResource::create): Return 0 if the data is null.
2008-08-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
https://bugs.webkit.org/show_bug.cgi?id=20328
Fix a problem when an 'all' transition transition with more than
one property changing is interrupted, and did some AnimationController
cleanup.
Test: transitions/interrupted-all-transition.html
* page/AnimationController.cpp:
(WebCore::ImplicitAnimation::ImplicitAnimation):
(WebCore::AnimationControllerPrivate::blendProperties):
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::cleanupFinishedAnimations):
(WebCore::CompositeAnimation::setTransitionStartTime):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
(WebCore::ImplicitAnimation::animate):
(WebCore::ImplicitAnimation::onAnimationEnd):
(WebCore::ImplicitAnimation::sendTransitionEvent):
(WebCore::ImplicitAnimation::affectsProperty):
(WebCore::KeyframeAnimation::endAnimation):
(WebCore::KeyframeAnimation::onAnimationEnd):
2008-08-11 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
- Because console messages have group levels now, newly created messages
that do not specify the level lose their message since the number of
arguments is wrong.
* page/inspector/Console.js:
* page/inspector/Resource.js:
2008-08-11 Alp Toker <alp@nuanti.com>
Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take
the opportunity to sort the sources lists.
* GNUmakefile.am:
2008-08-11 Timothy Hatcher <timothy@apple.com>
Speed up the the JavaScript syntax highlighter by generating
the finders only once per script instead of per line.
https://bugs.webkit.org/show_bug.cgi?id=20346
Reviewed by Adam Roben.
* page/inspector/SourceFrame.js:
(WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
Removed, factored into syntaxHighlightJavascript as an inline function.
(WebInspector.SourceFrame.prototype.syntaxHighlightJavascript):
Pulled in the _syntaxHighlightJavascriptLine so it will create a closure.
Generate the finders before iterating the lines.
2008-08-11 Adam Roben <aroben@apple.com>
Windows build fix
* WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and
JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file,
too.
2008-08-11 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
Test: fast/css/counters/invalidate-cached-counter-node.html
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::invalidateCounters): Added. Invalidates all
RenderCounters in :before and :after content.
* rendering/RenderContainer.h:
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this
to match the RenderObject method.
(WebCore::RenderCounter::invalidate): Added. Resets the cached
CounterNode and invalidates the object's layout and preferred widths.
(WebCore::destroyCounterNodeChildren): Added a call to
invalidateCounters().
* rendering/RenderCounter.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::invalidateCounters):
2008-08-11 Dean Jackson <dino@apple.com>
Implement CSS Animation and Transition Events
https://bugs.webkit.org/show_bug.cgi?id=20337
Implement the events defined in the CSS Animations
and Transitions specifications so code can react
to animations and transitions.
Reviewed by Tim Hatcher and Dave Hyatt.
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
Build configs for new files
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSEventCustom.cpp:
* dom/Document.h:
* dom/Event.cpp:
* dom/Event.h:
* dom/EventTarget.cpp:
* dom/EventTargetNode.cpp:
* dom/EventTargetNode.h:
* html/HTMLElement.cpp:
* page/AnimationController.cpp:
do all the new event stuff
* html/HTMLAttributeNames.in:
the onwebkitanimation* and onwebkittransitionend attrs
* dom/WebKitAnimationEvent.cpp: Added.
* dom/WebKitAnimationEvent.h: Added.
* dom/WebKitAnimationEvent.idl: Added.
* dom/WebKitTransitionEvent.cpp: Added.
* dom/WebKitTransitionEvent.h: Added.
* dom/WebKitTransitionEvent.idl: Added.
New files for the events
* manual-tests/transition-events.html: Added.
New testfile
2008-08-11 Adam Roben <aroben@apple.com>
Add a ForwardingHeader for wtf/NotFound.h
Rubberstamped by Darin Adler.
* ForwardingHeaders/wtf/NotFound.h: Added.
2008-08-11 Timothy Hatcher <timothy@apple.com>
Fixes a bug where error bubbles in JavaScript resources would
be clobbered by the syntax highlighter.
https://bugs.webkit.org/show_bug.cgi?id=20345
Reviewed by Adam Roben.
* manual-tests/inspector/resources/script-error.js: Added.
* manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added.
* page/inspector/SourceFrame.js:
(WebInspector.SourceFrame.prototype._addMessageToSource):
Check the nodeType and not the nodeName, this is less fragile.
(WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
Check if the lastChild is an error bubble, if so remove it before
getting the line's textContent. Add the error bubble back at the end.
== Rolled over to ChangeLog-2008-08-10 ==