blob: 826c327a3758381cec199134645e46822cc5abf8 [file] [log] [blame]
2013-09-06 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Download Archive button incorrectly styled when disabled and tree element is not-selected
https://bugs.webkit.org/show_bug.cgi?id=120866
Reviewed by Timothy Hatcher.
* UserInterface/TreeElementStatusButton.css:
(.item > .status > .status-button.disabled > svg *):
2013-09-06 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Lint JavaScript and CSS for minor issues
https://bugs.webkit.org/show_bug.cgi?id=120884
Reviewed by Timothy Hatcher.
JS, caught a bunch of missing semicolons but at least one possible
issue with duplicate object literal keys in CSSKeywordCompletions.
CSS, cause some duplicate properties, an invalid property value,
and some "0px" => "0" cleanup.
2013-09-05 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Breakpoint Action JS Editor has line wrapping issues with long no-space lines
https://bugs.webkit.org/show_bug.cgi?id=120822
Reviewed by Timothy Hatcher.
* UserInterface/BreakpointActionView.css:
(.breakpoint-action-eval-editor > .CodeMirror):
(.breakpoint-action-eval-editor > .CodeMirror-scroll):
2013-09-05 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Edit Breakpoint popover sometimes appears misplaced in top left
https://bugs.webkit.org/show_bug.cgi?id=120804
Reviewed by Timothy Hatcher.
Grab the bounding rect immediately, instead of grabbing it from the element
after the user has selected the "Edit Breakpoint" context menu item. When
the popover was misplaced it was when using an element had been removed or
replaced in the DOM, and caused a bogus bounding client rect.
* UserInterface/Breakpoint.js:
(WebInspector.Breakpoint.prototype.editBreakpoint):
(WebInspector.Breakpoint.prototype._showEditBreakpointPopover):
2013-09-05 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Remove harmless assert, triggered hitting breakpoint in auto prettyprinted code on reload
https://bugs.webkit.org/show_bug.cgi?id=120332
Reviewed by Timothy Hatcher.
* UserInterface/TextEditor.js:
2013-09-05 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Breakpoint Actions
https://bugs.webkit.org/show_bug.cgi?id=120576
Reviewed by Timothy Hatcher.
Give the CodeMirror editor for JavaScript Breakpoint Actions JS Runtime
completions (like window, document, etc.).
The logic was inside of JavaScriptLogViewController but was already
entirely independent. Factor it out into its own class and plug it into
CodeMirrorCompletionController as a "CompletionsProvider".
Because the class hooks into a global event to reset some state, make
it a singleton, so new instances are not leaked.
* UserInterface/Main.html:
* UserInterface/Main.js:
(WebInspector.loaded):
* UserInterface/RuntimeManager.js: Added.
(WebInspector.RuntimeManager):
(WebInspector.RuntimeManager.prototype.evalCallback):
(WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
Move eval in window to new RuntimeManager. A slightly cleaner place to this
since it is used both by the console and JS completions provider.
* UserInterface/CodeMirrorCompletionController.js:
(WebInspector.CodeMirrorCompletionController):
(WebInspector.CodeMirrorCompletionController.prototype.setExtendedCompletionProvider):
(WebInspector.CodeMirrorCompletionController.prototype._completeAtCurrentPosition):
Allow a completions provider plugin to completions controller. If one
is available, this supercedes the delegate extend completions path.
* UserInterface/BreakpointActionView.js:
* UserInterface/ConsolePrompt.js:
(WebInspector.ConsolePrompt):
Use the new JS completions provider to get runtime JS completions.
NOTE: ConsolePrompt still needs the delegate path for SQL completions.
* UserInterface/JavaScriptLogViewController.js:
(WebInspector.JavaScriptLogViewController):
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):
* UserInterface/JavaScriptRuntimeCompletionProvider.js: Added.
(WebInspector.JavaScriptRuntimeCompletionProvider):
(get WebInspector.JavaScriptRuntimeCompletionProvider.prototype.):
(get WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded):
Move the JS completions code to a new class. No changes needed.
2013-09-05 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Breakpoint Actions
https://bugs.webkit.org/show_bug.cgi?id=120576
Reviewed by Timothy Hatcher.
* UserInterface/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.get actions):
(WebInspector.Breakpoint.prototype.get options):
(WebInspector.Breakpoint.prototype.get info):
(WebInspector.Breakpoint.prototype._serializableActions):
Saving, restoring, and serialization.
(WebInspector.Breakpoint.prototype.createAction):
(WebInspector.Breakpoint.prototype.recreateAction):
(WebInspector.Breakpoint.prototype.removeAction):
(WebInspector.Breakpoint.prototype.breakpointActionDidChange):
Modifying _actions ivar.
(WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
(WebInspector.Breakpoint.prototype._popoverActionsCreateAddActionButton):
(WebInspector.Breakpoint.prototype._popoverActionsAddActionButtonClicked):
(WebInspector.Breakpoint.prototype._popoverActionsInsertBreakpointActionView):
(WebInspector.Breakpoint.prototype.breakpointActionViewAppendActionView):
(WebInspector.Breakpoint.prototype.breakpointActionViewRemoveActionView):
(WebInspector.Breakpoint.prototype.breakpointActionViewResized):
Popover UI containing breakpoint action views and converting to and from
having no actions.
(WebInspector.Breakpoint.prototype.willDismissPopover):
Cleanup some ivars when the popover dismisses.
* UserInterface/Breakpoint.css:
(.popover .edit-breakpoint-popover-content.wide):
Wider setting when there are actions in the popover.
(.popover .edit-breakpoint-popover-content > table > tr > th):
Keep the title labels at the top of their section.
* UserInterface/BreakpointAction.js:
(WebInspector.BreakpointAction):
(WebInspector.BreakpointAction.prototype.get breakpoint):
(WebInspector.BreakpointAction.prototype.get type):
(WebInspector.BreakpointAction.prototype.get data):
(WebInspector.BreakpointAction.prototype.set data):
(WebInspector.BreakpointAction.prototype.get info):
Very basic BreakpointAction class. Notifies Breakpoint on data changes.
Type changes are not allowed, instead just create a new BreakpointAction.
* UserInterface/BreakpointActionView.css: Added.
(.breakpoint-action-block-header):
(.breakpoint-action-remove-button):
(.breakpoint-action-remove-button:active):
(.breakpoint-action-append-button):
(.breakpoint-action-block-body):
(.breakpoint-action-block-body > input):
(.breakpoint-action-eval-editor):
(.breakpoint-action-eval-editor > .CodeMirror):
(.breakpoint-action-eval-editor > .CodeMirror-scroll):
* UserInterface/BreakpointActionView.js: Added.
(WebInspector.BreakpointActionView):
(WebInspector.BreakpointActionView.displayStringForType):
(WebInspector.BreakpointActionView.prototype.get action):
(WebInspector.BreakpointActionView.prototype.get element):
(WebInspector.BreakpointActionView.prototype._pickerChanged):
(WebInspector.BreakpointActionView.prototype._appendActionButtonClicked):
(WebInspector.BreakpointActionView.prototype._removeActionButtonClicked):
(WebInspector.BreakpointActionView.prototype._updateBody.switch.break):
(WebInspector.BreakpointActionView.prototype._logInputChanged):
(WebInspector.BreakpointActionView.prototype._codeMirrorBlurred):
(WebInspector.BreakpointActionView.prototype._codeMirrorViewportChanged):
UI and form controls for individual breakpoint actions. The view
wraps a single BreakpointAction, and for any actions that could affect
other views the delegate is notified.
* UserInterface/DebuggerManager.js:
(WebInspector.DebuggerManager):
(WebInspector.DebuggerManager.prototype._debuggerBreakpointActionType):
When sending to the backend, make sure to send protocol enums.
* UserInterface/Popover.js:
(WebInspector.Popover.prototype.update):
Update the popover when content changes.
* UserInterface/Images/BreakpointActionAdd.svg: Added.
* UserInterface/Images/BreakpointActionRemove.svg: Added.
* UserInterface/InspectorBackendCommands.js:
* UserInterface/Main.html:
* Localizations/en.lproj/localizedStrings.js:
Misc. New strings, images, includes.
2013-09-03 Antoine Quint <graouts@apple.com>
Web Inspector: exceptions triggered from console evaluation do not pause the debugger
https://bugs.webkit.org/show_bug.cgi?id=120460
We used to preclude any debugging from errors stemming from code evaluated in the console
as we would always set the doNotPauseOnExceptionsAndMuteConsole parameter to "false" when
calling JavaScriptLogViewController._evaluateInInspectedWindow(). However, it is desirable
to allow debugging code ran from the console.
We now allow debugging in such a scenario and we filter out call frames coming from the
Web Inspector injected script as well as the call frame for the console prompt such that
we only pause in the debugger in case the exception is in code under the console prompt
and not the console code prompt itself.
Additionally, to prevent stepping out to call frames we may have filtered out, we disable
the "step out" button in cases where there are no further frames in the frontend to go out to.
Reviewed by Timothy Hatcher.
* UserInterface/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.debuggerDidPause):
Filter out call frames that have a URL coming from Web Inspector injected script by looking
for a URL starting with the "__WebInspector" prefix. If we determine that there are no call
frames left after filtering, we resume code evaluation such that we only pause in the debugger
when the exception is in code evluated under the console prompt.
* UserInterface/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._debuggerDidPause):
(WebInspector.DebuggerSidebarPanel.prototype._debuggerActiveCallFrameDidChange):
Monitor any change to the active call frame such that we may tie the state of the
"step out" button to the availability of a call frame to step out to in the filtered
list set on the DebuggerManager.
* UserInterface/JavaScriptLogViewController.js:
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):
Set the doNotPauseOnExceptionsAndMuteConsole to "false" when calling _evaluateInInspectedWindow()
in order to allow pausing on exceptions coming from code evalued in the console. Also, explicitly
set a sourceURL for the script to evaluate such that we may identify its origin when filtering
call frames stemming from inspector code.
* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):
Filter out any script resource starting with the Web Inspector-specific "__WebInspector" prefix
so that injected script does not show up.
2013-08-30 Brent Fulgham <bfulgham@apple.com>
[Windows] Correct windows build. Get rid of unnecessary pre-build step. We don't build anything
in this project, just copy some files into the WebKit resource folder. This was fooling the
build system into thinking something failed, resulting in a build error.
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Remove reference to WebInspectorUIPreBuild.cmd
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
* WebInspectorUI.vcxproj/WebInspectorUIPreBuild.cmd: Removed.
2013-08-30 Brent Fulgham <bfulgham@apple.com>
[Windows] Build correction after dependency change.
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Remove circular dependency on
WebKit, and control this at the solution level. The prior change broke external
builders.
2013-08-30 Brent Fulgham <bfulgham@apple.com>
[Windows] Unreviewed build gardening.
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Adjust build dependencies so
that WebInspectorUI 'builds' after WebKit so that the expected resource directory
structure is always in place.
2013-08-30 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Breakpoints should have Automatically Continue Option
https://bugs.webkit.org/show_bug.cgi?id=120187
Reviewed by Timothy Hatcher.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Breakpoint.css:
(#edit-breakpoint-popoover-auto-continue):
Misc. changes for UI.
* UserInterface/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.get autoContinue):
(WebInspector.Breakpoint.prototype.set autoContinue):
(WebInspector.Breakpoint.prototype.get options):
(WebInspector.Breakpoint.prototype.get info):
General maintenance of the autoContinue state.
(WebInspector.Breakpoint.prototype._popoverToggleEnabledCheckboxChanged):
(WebInspector.Breakpoint.prototype._popoverToggleAutoContinueCheckboxChanged):
(WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
Edit Breakpoint UI for setting autoContinue state.
* UserInterface/InspectorBackend.js:
(InspectorBackendClass.prototype.registerCommand):
(InspectorBackendClass.prototype._supports):
Extension to check if a BackendCommands method supports a particular param.
* UserInterface/DebuggerManager.js:
(WebInspector.DebuggerManager):
(WebInspector.DebuggerManager.prototype._setBreakpoint):
* UserInterface/InspectorBackendCommands.js:
Change to backend agent calls for the new protocol API.
2013-08-29 Timothy Hatcher <timothy@apple.com>
Make incrementing and decrementing numbers by 0.1 require the control key, and not near zero numbers.
https://bugs.webkit.org/show_bug.cgi?id=120492
<rdar://problem/13738935> Incrementing and decrementing numbers near zero is annoying compared to earlier releases
Reviewed by Joseph Pecoraro.
* UserInterface/CodeMirrorAdditions.js:
(alterNumber): Remove near zero check.
2013-08-29 Timothy Hatcher <timothy@apple.com>
Only modify numbers if they are identified by CodeMirror as a number.
https://bugs.webkit.org/show_bug.cgi?id=120484
<rdar://problem/13877085> REGRESSION: Alt-up and Alt-down don't work when cursor is in unit
<rdar://problem/13058697> PARITY: Option-Up arrow in "translate3d" should not modify number to make" translate4d"
Reviewed by Joseph Pecoraro.
* UserInterface/CodeMirrorAdditions.js:
(CodeMirror.prototype.alterNumberInRange): Correctly preserve the selection, even if it differs from
the range passed in.
(alterNumber): Find number tokens and pass those to alterNumberInRange.
(alterNumber.findNumberToken): Added. Helper.
2013-08-29 Timothy Hatcher <timothy@apple.com>
Make incrementing and decrementing numbers by 0.1 require the control key, and not near zero numbers.
https://bugs.webkit.org/show_bug.cgi?id=120492
<rdar://problem/13738935> Incrementing and decrementing numbers near zero is annoying compared to earlier releases
Reviewed by Joseph Pecoraro.
* UserInterface/CodeMirrorAdditions.js:
(alterNumber): Remove near zero check.
2013-08-29 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Download Web Archive of Inspected Page
https://bugs.webkit.org/show_bug.cgi?id=119774
Reviewed by Timothy Hatcher.
* UserInterface/ContentBrowser.js:
(WebInspector.ContentBrowser.prototype._saveDataToFile):
Allow a custom save handler which will do all the work.
* UserInterface/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView):
(WebInspector.DOMTreeContentView.prototype.get supportsSave):
(WebInspector.DOMTreeContentView.prototype.get saveData.saveHandler):
(WebInspector.DOMTreeContentView.prototype.get saveData):
Allow Save keyboard shortcut to download an archive viewing the DOM Tree.
* UserInterface/ResourceTreeElement.js:
(WebInspector.ResourceTreeElement.prototype._updateStatus):
* UserInterface/FrameTreeElement.js:
(WebInspector.FrameTreeElement):
(WebInspector.FrameTreeElement.prototype.updateStatusForMainFrame):
(WebInspector.FrameTreeElement.prototype._mainResourceDidChange):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders):
(WebInspector.FrameTreeElement.prototype._reloadPageClicked):
(WebInspector.FrameTreeElement.prototype._downloadButtonClicked):
(WebInspector.FrameTreeElement.prototype._updateDownloadButton):
(WebInspector.FrameTreeElement.prototype._pageArchiveStarted):
(WebInspector.FrameTreeElement.prototype._pageArchiveEnded):
Move handling of main frame TreeElement buttons to FrameTreeElement.
Add a Download button, and enable/disable it appropriately.
* UserInterface/ResourceTreeElement.css:
* UserInterface/TreeElementStatusButton.css: Copied from Source/WebInspectorUI/UserInterface/ResourceTreeElement.css.
(.item > .status > .status-button):
(.item > .status > .status-button > svg *):
(.item.selected > .status > .status-button > svg *):
(.item.selected > .status > .status-button:active > svg *):
(.item > .status > .status-button.disabled > svg *):
(.item.selected > .status > .status-button.disabled > svg *):
* UserInterface/TreeElementStatusButton.js: Added.
(WebInspector.TreeElementStatusButton):
(WebInspector.TreeElementStatusButton.prototype.get element):
(WebInspector.TreeElementStatusButton.prototype.get hidden):
(WebInspector.TreeElementStatusButton.prototype.set hidden):
(WebInspector.TreeElementStatusButton.prototype.get enabled):
(WebInspector.TreeElementStatusButton.prototype.set enabled):
(WebInspector.TreeElementStatusButton.prototype._clicked):
Make buttons in the TreeElement status a generic class to share styling
and handling of the buttons. New "disabled" state with even more
transparent is used when the page is downloading.
* UserInterface/Main.html:
* UserInterface/Main.js:
(WebInspector.archiveMainFrame):
(WebInspector.canArchiveMainFrame):
Generic API for archiving the page and determining if you can archive it.
* UserInterface/InspectorBackendCommands.js:
* UserInterface/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.save):
* UserInterface/Images/DownloadArrow.svg: Added.
* Localizations/en.lproj/localizedStrings.js:
Misc. updates and new files.
2013-08-28 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Give reload icon an :active state and allow CSS to style some SVG images
https://bugs.webkit.org/show_bug.cgi?id=120384
Reviewed by Timothy Hatcher.
The Reload icon is duplicated just to provide different fill colors.
Convert from using <img> to an <svg> document for this image, and style
it with CSS. This also makes it trivial to add an :active state.
* UserInterface/ImageUtilities.js:
(.invokeCallbackWithDocument):
(.imageLoad):
(.imageError):
(wrappedSVGDocument):
Helpers for downloading and in memory caching SVG images.
* UserInterface/Images/Reload.svg:
* UserInterface/Images/ReloadSelected.svg: Removed.
Updated Reload image better matches the original design (slightly
larger). And the duplicate image can be removed.
* UserInterface/ResourceTreeElement.css:
(.item.resource > .status > .reload-button):
(.item.resource > .status > .reload-button > svg *):
(.item.resource.selected > .status > .reload-button > svg *):
(.item.resource.selected > .status > .reload-button:active > svg *):
Different styles, including a new :active style.
* UserInterface/ResourceTreeElement.js:
(WebInspector.ResourceTreeElement.prototype._updateStatusWithMainFrameButtons):
(WebInspector.ResourceTreeElement.prototype._updateStatus):
Handle updating the main frame's state asynchronously since loading the SVG
image document is asynchronous.
2013-08-27 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Debugger should have Continue to Here Context Menu
https://bugs.webkit.org/show_bug.cgi?id=120189
Reviewed by Timothy Hatcher.
When paused in the debugger and presenting a Context Menu in the
gutter, include a "Continue to Here" option. This requires a
script/line/column location combination.
* UserInterface/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.continueToLocation):
* UserInterface/Resource.js:
(WebInspector.Resource.prototype.scriptForLocation):
* UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype.continueToLocation):
(WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):
2013-08-26 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: We should regenerate InspectorBackendCommands.js for Legacy Inspector.json versions
https://bugs.webkit.org/show_bug.cgi?id=120242
Reviewed by Timothy Hatcher.
- Include the iOS 6.0 Inspector.json which maps to Legacy/6.0/InspectorBackendCommands.js.
- Provide a helper script to regenerate the backend commands file for trunk and Versions.
- Regenerated file now includes enums and other minor changes.
* Scripts/update-InspectorBackendCommands.rb: Added.
* UserInterface/InspectorBackendCommands.js:
* UserInterface/Legacy/6.0/InspectorBackendCommands.js:
* Versions/Inspector-iOS-6.0.json: Added.
2013-08-24 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Breakpoints in the editors gutter should have a contextmenu
https://bugs.webkit.org/show_bug.cgi?id=120169
Reviewed by Timothy Hatcher.
Updated CodeMirror now has a gutterContextMenu event. Use that to give
breakpoint related context menus. Add, Edit, Enable/Disable, Delete, and
Reveal in Debugger Navigation Sidebar.
* Localizations/en.lproj/localizedStrings.js:
"Add Breakpoint", and "Reveal in Debugger Navigation Sidebar".
* UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu.addBreakpoint):
(WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu.revealInSidebar):
(WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu.removeBreakpoints):
(WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu.toggleBreakpoints):
(WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):
Show a context menu when clicking on the gutter for 0 breakpoints,
1 breakpoint, or >1 breakpoints. The only tricky handler is addBreakpoint,
since that must update the TextEditor for the new breakpoint info.
* UserInterface/TextEditor.js:
(WebInspector.TextEditor):
(WebInspector.TextEditor.prototype._gutterContextMenu):
Send to delegate if the delegate implements textEditorGutterContextMenu.
2013-08-23 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Fix js minification of updated CodeMirror
https://bugs.webkit.org/show_bug.cgi?id=120231
Reviewed by Andy Estes.
Workaround a jsmin issue with "return //.test();" lines when
minifying JavaScript in production builds.
* Scripts/copy-user-interface-resources.sh:
* UserInterface/External/CodeMirror/codemirror.js:
(window.CodeMirror):
2013-08-22 Joseph Pecoraro <pecoraro@apple.com>
<https://webkit.org/b/120165> Web Inspector: Update CodeMirror to 3.16.1
Reviewed by Andy Estes.
* Tools/PrettyPrinting/codemirror.css:
* Tools/PrettyPrinting/codemirror.js:
* Tools/PrettyPrinting/css.js:
* Tools/PrettyPrinting/javascript.js:
* UserInterface/External/CodeMirror/codemirror.css:
* UserInterface/External/CodeMirror/codemirror.js:
* UserInterface/External/CodeMirror/css.js:
* UserInterface/External/CodeMirror/javascript.js:
* UserInterface/External/CodeMirror/xml.js:
2013-08-21 Brent Fulgham <bfulgham@apple.com>
[Windows] Clean up project file after %PlatformArchitecture% change landed.
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Remove hard-coded settings covered
by our configuration files.
* WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: Use the %PlatformArchitecture%
macro to support 32- and 64-bit builds.
2013-08-20 Brent Fulgham <bfulgham@apple.com>
<http://webkit.org/b/120098> [Windows] Enable the New Web Inspector
Reviewed by Brian Weinstein.
Add a new project to copy files to the appropriate spots in the
Windows port.
* WebInspectorUI.vcxproj: Added.
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Added.
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters: Added.
* WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: Added.
* WebInspectorUI.vcxproj/WebInspectorUIPreBuild.cmd: Added.
2013-08-19 James Craig <james@cookiecrook.com>
<https://webkit.org/b/118106> Web Inspector: AX: Add additional contextual labels for Error/Warnings/Logs that will be spoken for screen readers
Reviewed by Joseph Pecoraro.
Changed general console "Output" string to more specific "Error", "Warning", etc for accessibility.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/ConsoleCommandResult.js:
* UserInterface/ConsoleMessageImpl.js:
2013-08-16 James Craig <james@cookiecrook.com>
<https://webkit.org/b/118105> Web Inspector: AX: Add support for ARIA tablists/tabs to inspector tabs
Reviewed by Joseph Pecoraro.
Updating accessibility roles and attributes for single-select toolbar item sets.
* UserInterface/ActivateButtonNavigationItem.js:
(WebInspector.ActivateButtonNavigationItem):
(WebInspector.ActivateButtonNavigationItem.prototype.set activated):
* UserInterface/ActivateButtonToolbarItem.js:
(WebInspector.ActivateButtonToolbarItem):
* UserInterface/ButtonToolbarItem.js:
(WebInspector.ButtonToolbarItem):
* UserInterface/SidebarPanel.js:
(WebInspector.SidebarPanel):
* UserInterface/Toolbar.js:
(WebInspector.Toolbar):
2013-08-13 Dean Jackson <dino@apple.com>
<https://webkit.org/b/119778> Add Canvas protocol observer
Reviewed by Joseph Pecoraro.
In preparation for listening to backend events about canvas profiling,
add a canvas observer.
* UserInterface/CanvasObserver.js: New empty CanvasObserver object.
(WebInspector.CanvasObserver):
(WebInspector.CanvasObserver.prototype.contextCreated):
(WebInspector.CanvasObserver.prototype.traceLogsRemoved):
* UserInterface/Main.html:
* UserInterface/Main.js:
(WebInspector.loaded):
2013-08-11 Dean Jackson <dino@apple.com>
Update localizedStrings - I think I checked in an unmerged version
in the previous commit.
* Localizations/en.lproj/localizedStrings.js:
2013-08-11 Dean Jackson <dino@apple.com>
Bootstrap canvas profiler
https://bugs.webkit.org/show_bug.cgi?id=119652
<rdar://problem/14703665>
Reviewed by Joseph Pecoraro.
Add enough to get an empty Canvas profile recording
and displayed.
* Localizations/en.lproj/localizedStrings.js: Add canvas strings.
* UserInterface/CanvasProfileObject.js: Added. Mostly copied from CSS Selector Profiles.
* UserInterface/CanvasProfileType.js: Added. Ditto.
* UserInterface/CanvasDataGridNode.js: Added. Ditto.
* UserInterface/CanvasProfileView.js: Added. Ditto.
* UserInterface/ContentView.js:
(WebInspector.ContentView): Add support for the new View type.
(WebInspector.ContentView.isViewable):
* UserInterface/InstrumentSidebarPanel.js:
(WebInspector.InstrumentSidebarPanel): Add support for canvas profiles.
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedOver):
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedDown):
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphClicked):
(WebInspector.InstrumentSidebarPanel.prototype._profileTypeWasSelected):
(WebInspector.InstrumentSidebarPanel.prototype._profilesCleared):
* UserInterface/Main.html: Load the new files.
* UserInterface/ProfileManager.js: New methods and support for canvas profiles.
(WebInspector.ProfileManager):
(WebInspector.ProfileManager.prototype.initialize):
(WebInspector.ProfileManager.prototype.isProfilingCanvas):
(WebInspector.ProfileManager.prototype.startProfilingCanvas):
(WebInspector.ProfileManager.prototype.stopProfilingCanvas):
(WebInspector.ProfileManager.prototype._checkForInterruptions):
(WebInspector.ProfileManager.prototype._attemptToResumeProfiling):
2013-08-07 Timothy Hatcher <timothy@apple.com>
Switch the generated images off of PDFs and onto SVGs now that bug 119492 is fixed.
https://bugs.webkit.org/show_bug.cgi?id=118677
Reviewed by Joseph Pecoraro.
* UserInterface/ApplicationCacheDetailsSidebarPanel.js:
(WebInspector.ApplicationCacheDetailsSidebarPanel):
* UserInterface/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection):
* UserInterface/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel):
* UserInterface/ContentBrowser.js:
(WebInspector.ContentBrowser):
* UserInterface/DOMNodeDetailsSidebarPanel.js:
(WebInspector.DOMNodeDetailsSidebarPanel):
* UserInterface/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView):
* UserInterface/DataGrid.js:
(WebInspector.DataGrid.prototype._generateSortIndicatorImagesIfNeeded):
* UserInterface/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
* UserInterface/DetailsSection.js:
(WebInspector.DetailsSection.prototype._generateDisclosureTrianglesIfNeeded):
* UserInterface/FindBanner.js:
(WebInspector.FindBanner.prototype._generateButtonsGlyphsIfNeeded):
* UserInterface/Images/BackArrow.pdf: Removed.
* UserInterface/Images/BottomUpTree.pdf: Removed.
* UserInterface/Images/Breakpoints.pdf: Removed.
* UserInterface/Images/Close.pdf: Removed.
* UserInterface/Images/Crosshair.pdf: Removed.
* UserInterface/Images/DisclosureTriangleSmallClosed.pdf: Removed.
* UserInterface/Images/DisclosureTriangleSmallOpen.pdf: Removed.
* UserInterface/Images/DisclosureTriangleTinyClosed.pdf: Removed.
* UserInterface/Images/DisclosureTriangleTinyOpen.pdf: Removed.
* UserInterface/Images/DockBottom.pdf: Removed.
* UserInterface/Images/DockRight.pdf: Removed.
* UserInterface/Images/ForwardArrow.pdf: Removed.
* UserInterface/Images/GoToArrow.pdf: Removed.
* UserInterface/Images/LayerBorders.pdf: Removed.
* UserInterface/Images/LessColumns.pdf: Removed.
* UserInterface/Images/Locked.pdf: Removed.
* UserInterface/Images/MoreColumns.pdf: Removed.
* UserInterface/Images/NavigationItemAngleBrackets.pdf: Removed.
* UserInterface/Images/NavigationItemBrushAndRuler.pdf: Removed.
* UserInterface/Images/NavigationItemBug.pdf: Removed.
* UserInterface/Images/NavigationItemCurleyBraces.pdf: Removed.
* UserInterface/Images/NavigationItemFile.pdf: Removed.
* UserInterface/Images/NavigationItemLayers.pdf: Removed.
* UserInterface/Images/NavigationItemLog.pdf: Removed.
* UserInterface/Images/NavigationItemMagnifyingGlass.pdf: Removed.
* UserInterface/Images/NavigationItemStopwatch.pdf: Removed.
* UserInterface/Images/NavigationItemStorage.pdf: Removed.
* UserInterface/Images/NavigationItemTrash.pdf: Removed.
* UserInterface/Images/NavigationItemVariable.pdf: Removed.
* UserInterface/Images/Pause.pdf: Removed.
* UserInterface/Images/Percent.pdf: Removed.
* UserInterface/Images/Plus.pdf: Removed.
* UserInterface/Images/Resume.pdf: Removed.
* UserInterface/Images/ShadowDOM.pdf: Removed.
* UserInterface/Images/SortIndicatorDownArrow.pdf: Removed.
* UserInterface/Images/SortIndicatorUpArrow.pdf: Removed.
* UserInterface/Images/SplitToggleDown.pdf: Removed.
* UserInterface/Images/SplitToggleUp.pdf: Removed.
* UserInterface/Images/StepInto.pdf: Removed.
* UserInterface/Images/StepOut.pdf: Removed.
* UserInterface/Images/StepOver.pdf: Removed.
* UserInterface/Images/Undock.pdf: Removed.
* UserInterface/InstrumentSidebarPanel.js:
(WebInspector.InstrumentSidebarPanel):
* UserInterface/JavaScriptProfileView.js:
(WebInspector.JavaScriptProfileView):
* UserInterface/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel):
* UserInterface/LogContentView.js:
(WebInspector.LogContentView):
* UserInterface/Main.js:
(WebInspector.contentLoaded):
(WebInspector._updateDockNavigationItems):
(WebInspector._generateDisclosureTriangleImages):
* UserInterface/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype._generateDisclosureTrianglesIfNeeded):
* UserInterface/ProfileView.js:
(WebInspector.ProfileView):
* UserInterface/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel):
* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
* UserInterface/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel):
* UserInterface/ScriptContentView.js:
(WebInspector.ScriptContentView):
* UserInterface/TextContentView.js:
(WebInspector.TextContentView):
* UserInterface/TextResourceContentView.js:
(WebInspector.TextResourceContentView):
* UserInterface/TimelinesContentView.js:
2013-08-08 Dean Jackson <dino@apple.com>
Remove use of prefixed transition event
https://bugs.webkit.org/show_bug.cgi?id=119598
Reviewed by Joseph Pecoraro.
"webkitTransitionEnd" -> "transitionend".
* UserInterface/Popover.js:
(WebInspector.Popover):
(WebInspector.Popover.prototype.handleEvent):
2013-08-08 Dean Jackson <dino@apple.com>
Unprefix use of transitions in Web Inspector code
https://bugs.webkit.org/show_bug.cgi?id=119588
Reviewed by Tim Hatcher.
Replace "-webkit-transition" with "transition".
* UserInterface/CSSCompletions.js:
(WebInspector.CSSCompletions.requestCSSNameCompletions.collectPropertyNameForCodeMirror):
* UserInterface/FindBanner.css:
(.find-banner):
(.find-banner.showing):
(.supports-find-banner.no-find-banner-transition):
(.supports-find-banner):
(.supports-find-banner.showing-find-banner):
* UserInterface/NetworkTimeline.css:
(.network-graph-side:hover .network-graph-label):
* UserInterface/Popover.css:
(.popover.fade-out):
2013-08-08 Vivek Galatage <vivek.vg@samsung.com>
Web Inspector: Use granular DOMStorage modification events to avoid complete DataGrid update.
https://bugs.webkit.org/show_bug.cgi?id=119541
Reviewed by Joseph Pecoraro.
InspectorDOMStorageAgent sends more granular events about the storage modifications.
Using these would avoid the complete rebuilding of the DataGrid.
* UserInterface/DOMStorageContentView.js:
(WebInspector.DOMStorageContentView.prototype.itemsCleared):
(WebInspector.DOMStorageContentView.prototype.itemRemoved):
(WebInspector.DOMStorageContentView.prototype.itemAdded):
(WebInspector.DOMStorageContentView.prototype.itemUpdated):
* UserInterface/DOMStorageObserver.js:
(WebInspector.DOMStorageObserver.prototype.domStorageItemsCleared):
(WebInspector.DOMStorageObserver.prototype.domStorageItemRemoved):
(WebInspector.DOMStorageObserver.prototype.domStorageItemAdded):
(WebInspector.DOMStorageObserver.prototype.domStorageItemUpdated):
* UserInterface/StorageManager.js:
(WebInspector.StorageManager.prototype.domStorageItemsCleared):
(WebInspector.StorageManager.prototype.domStorageItemRemoved):
(WebInspector.StorageManager.prototype.domStorageItemAdded):
(WebInspector.StorageManager.prototype.domStorageItemUpdated):
2013-08-06 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Remove stale code in ResourceContentView
https://bugs.webkit.org/show_bug.cgi?id=119527
The handling of Resource Type changes moved to ResourceClusterContentView,
this removeEventListener is stale and doesn't do anything anymore.
Reviewed by Timothy Hatcher.
* UserInterface/ResourceContentView.js:
(WebInspector.ResourceContentView.prototype.closed):
2013-08-06 Timothy Hatcher <timothy@apple.com>
Convert all Web Inspector PDFs to SVGs.
Some PDFs need to stay around until bug 119492 is fixed. But the SVGs are there for when they are needed.
Updated some of the existing SVGs to be consistent with the format of the new SVGs.
https://bugs.webkit.org/show_bug.cgi?id=118677
Rubber-stamped by Joseph Pecoraro.
* UserInterface/BreakpointIcons.css:
* UserInterface/BreakpointTreeElement.css:
* UserInterface/CallFrameIcons.css:
* UserInterface/DatabaseContentView.css:
* UserInterface/FilterBar.css:
* UserInterface/HierarchicalPathComponent.css:
* UserInterface/Images/BackArrow.svg: Added.
* UserInterface/Images/BottomUpTree.svg: Added.
* UserInterface/Images/BreakpointButton.pdf: Removed.
* UserInterface/Images/BreakpointButton.svg: Added.
* UserInterface/Images/BreakpointInactiveButton.pdf: Removed.
* UserInterface/Images/BreakpointInactiveButton.svg: Added.
* UserInterface/Images/Breakpoints.svg: Added.
* UserInterface/Images/Close.svg: Added.
* UserInterface/Images/Crosshair.svg: Added.
* UserInterface/Images/DOMCharacterData.pdf: Removed.
* UserInterface/Images/DOMCharacterData.svg: Added.
* UserInterface/Images/DOMComment.pdf: Removed.
* UserInterface/Images/DOMComment.svg: Added.
* UserInterface/Images/DOMDocument.pdf: Removed.
* UserInterface/Images/DOMDocument.svg: Added.
* UserInterface/Images/DOMDocumentType.pdf: Removed.
* UserInterface/Images/DOMDocumentType.svg: Added.
* UserInterface/Images/DOMElement.pdf: Removed.
* UserInterface/Images/DOMElement.svg: Added.
* UserInterface/Images/DOMNode.pdf: Removed.
* UserInterface/Images/DOMNode.svg: Added.
* UserInterface/Images/DOMTextNode.pdf: Removed.
* UserInterface/Images/DOMTextNode.svg: Added.
* UserInterface/Images/DOMTree.pdf: Removed.
* UserInterface/Images/DOMTree.svg: Added.
* UserInterface/Images/DisclosureTriangleSmallClosed.svg: Added.
* UserInterface/Images/DisclosureTriangleSmallOpen.svg: Added.
* UserInterface/Images/DisclosureTriangleTinyClosed.svg: Added.
* UserInterface/Images/DisclosureTriangleTinyOpen.svg: Added.
* UserInterface/Images/DockBottom.svg: Added.
* UserInterface/Images/DockRight.svg: Added.
* UserInterface/Images/Error.pdf: Removed.
* UserInterface/Images/Error.svg: Added.
* UserInterface/Images/ErrorSmall.pdf: Removed.
* UserInterface/Images/Errors.svg:
* UserInterface/Images/ErrorsEnabled.svg:
* UserInterface/Images/EventListener.pdf: Removed.
* UserInterface/Images/EventListener.svg: Added.
* UserInterface/Images/Exception.pdf: Removed.
* UserInterface/Images/Exception.svg: Added.
* UserInterface/Images/FilterFieldGlyph.pdf: Removed.
* UserInterface/Images/FilterFieldGlyph.svg: Added.
* UserInterface/Images/ForwardArrow.svg: Added.
* UserInterface/Images/Function.pdf: Removed.
* UserInterface/Images/Function.svg: Added.
* UserInterface/Images/GoToArrow.svg: Added.
* UserInterface/Images/HierarchicalNavigationItemChevron.pdf: Removed.
* UserInterface/Images/HierarchicalNavigationItemChevron.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner1.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner1.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner10.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner10.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner11.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner11.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner12.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner12.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner2.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner2.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner3.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner3.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner4.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner4.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner5.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner5.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner6.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner6.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner7.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner7.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner8.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner8.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner9.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner9.svg: Added.
* UserInterface/Images/Issues.svg:
* UserInterface/Images/IssuesEnabled.svg:
* UserInterface/Images/LayerBorders.svg: Added.
* UserInterface/Images/LessColumns.svg: Added.
* UserInterface/Images/Locked.svg: Added.
* UserInterface/Images/Logs.svg:
* UserInterface/Images/Memory.svg:
* UserInterface/Images/MoreColumns.svg: Added.
* UserInterface/Images/Native.pdf: Removed.
* UserInterface/Images/Native.svg: Added.
* UserInterface/Images/NavigationItemAngleBrackets.svg: Added.
* UserInterface/Images/NavigationItemBrushAndRuler.svg: Added.
* UserInterface/Images/NavigationItemBug.svg: Added.
* UserInterface/Images/NavigationItemCurleyBraces.svg: Added.
* UserInterface/Images/NavigationItemFile.svg: Added.
* UserInterface/Images/NavigationItemLayers.svg: Added.
* UserInterface/Images/NavigationItemLog.svg: Added.
* UserInterface/Images/NavigationItemMagnifyingGlass.svg: Added.
* UserInterface/Images/NavigationItemStopwatch.svg: Added.
* UserInterface/Images/NavigationItemStorage.svg: Added.
* UserInterface/Images/NavigationItemTrash.svg: Added.
* UserInterface/Images/NavigationItemVariable.svg: Added.
* UserInterface/Images/NetworkBarLabelCalloutLeft.pdf: Removed.
* UserInterface/Images/NetworkBarLabelCalloutLeft.svg: Added.
* UserInterface/Images/NetworkBarLabelCalloutRight.pdf: Removed.
* UserInterface/Images/NetworkBarLabelCalloutRight.svg: Added.
* UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.pdf: Removed.
* UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.svg: Added.
* UserInterface/Images/NetworkBarLabelCalloutWhiteRight.pdf: Removed.
* UserInterface/Images/NetworkBarLabelCalloutWhiteRight.svg: Added.
* UserInterface/Images/Pause.svg: Added.
* UserInterface/Images/Percent.svg: Added.
* UserInterface/Images/Plus.svg: Added.
* UserInterface/Images/PseudoElement.pdf: Removed.
* UserInterface/Images/PseudoElement.svg: Added.
* UserInterface/Images/Reflection.pdf: Removed.
* UserInterface/Images/Reflection.svg: Added.
* UserInterface/Images/Reload.svg:
* UserInterface/Images/ReloadSelected.svg:
* UserInterface/Images/Request.pdf: Removed.
* UserInterface/Images/Request.svg: Added.
* UserInterface/Images/Resources.svg:
* UserInterface/Images/Response.pdf: Removed.
* UserInterface/Images/Response.svg: Added.
* UserInterface/Images/ResultLine.pdf: Removed.
* UserInterface/Images/ResultLine.svg: Added.
* UserInterface/Images/Resume.svg: Added.
* UserInterface/Images/ShadowDOM.svg: Added.
* UserInterface/Images/SortIndicatorDownArrow.svg: Added.
* UserInterface/Images/SortIndicatorUpArrow.svg: Added.
* UserInterface/Images/SourceCode.pdf: Removed.
* UserInterface/Images/SourceCode.svg: Added.
* UserInterface/Images/SplitToggleDown.svg: Added.
* UserInterface/Images/SplitToggleUp.svg: Added.
* UserInterface/Images/StepInto.svg: Added.
* UserInterface/Images/StepOut.svg: Added.
* UserInterface/Images/StepOver.svg: Added.
* UserInterface/Images/StyleRuleAuthor.pdf: Removed.
* UserInterface/Images/StyleRuleAuthor.svg: Added.
* UserInterface/Images/StyleRuleInherited.pdf: Removed.
* UserInterface/Images/StyleRuleInherited.svg: Added.
* UserInterface/Images/StyleRuleInheritedElement.pdf: Removed.
* UserInterface/Images/StyleRuleInheritedElement.svg: Added.
* UserInterface/Images/StyleRuleInspector.pdf: Removed.
* UserInterface/Images/StyleRuleInspector.svg: Added.
* UserInterface/Images/StyleRuleUser.pdf: Removed.
* UserInterface/Images/StyleRuleUser.svg: Added.
* UserInterface/Images/StyleRuleUserAgent.pdf: Removed.
* UserInterface/Images/StyleRuleUserAgent.svg: Added.
* UserInterface/Images/Time.svg:
* UserInterface/Images/Undock.svg: Added.
* UserInterface/Images/UpDownArrows.svg:
* UserInterface/Images/UserInputPrompt.pdf: Removed.
* UserInterface/Images/UserInputPrompt.svg: Added.
* UserInterface/Images/UserInputPromptPrevious.pdf: Removed.
* UserInterface/Images/UserInputPromptPrevious.svg: Added.
* UserInterface/Images/UserInputPromptPreviousSelected.pdf: Removed.
* UserInterface/Images/UserInputPromptPreviousSelected.svg: Added.
* UserInterface/Images/UserInputResult.pdf: Removed.
* UserInterface/Images/UserInputResult.svg: Added.
* UserInterface/Images/UserInputResultSelected.pdf: Removed.
* UserInterface/Images/UserInputResultSelected.svg: Added.
* UserInterface/Images/Warning.pdf: Removed.
* UserInterface/Images/Warning.svg: Added.
* UserInterface/Images/WarningSmall.pdf: Removed.
* UserInterface/Images/Weight.svg:
* UserInterface/IndeterminateProgressSpinner.css:
* UserInterface/LayerTreeSidebarPanel.css:
* UserInterface/LogContentView.css:
* UserInterface/Main.css:
* UserInterface/NetworkTimeline.css:
* UserInterface/PathComponentIcons.css:
* UserInterface/QuickConsole.css:
* UserInterface/RulesStyleDetailsPanel.css:
* UserInterface/SearchIcons.css:
* UserInterface/StyleRuleIcons.css:
2013-07-23 David Farler <dfarler@apple.com>
Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
https://bugs.webkit.org/show_bug.cgi?id=117762
Reviewed by Mark Rowe.
* Configurations/DebugRelease.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
2013-07-30 Roland Takács <rtakacs@inf.u-szeged.hu>
Web Inspector: doesn't use localized user interface at remote inspector
https://bugs.webkit.org/show_bug.cgi?id=119252
Reviewed by Timothy Hatcher.
Added a flag in order to not use localizedStrings in remote inspector.
* UserInterface/InspectorFrontendHostStub.js:
* UserInterface/LoadLocalizedStrings.js:
* UserInterface/Main.js:
(WebInspector.UIString):
2013-07-24 Antoine Quint <graouts@apple.com>
Web Inspector: control+clicking on a numeric token should not show the context menu
https://bugs.webkit.org/show_bug.cgi?id=119048
Reviewed by Timothy Hatcher.
Track "contextmenu" events when we're hovering a token containing a numeric value
and call preventDefault() in the event handler to ensure that the context menu does
not appear.
* UserInterface/CodeMirrorDragToAlterNumberController.js:
(WebInspector.CodeMirrorDragToAlterNumberController.prototype.handleEvent):
(WebInspector.CodeMirrorDragToAlterNumberController.prototype._setTracksMouseClickAndDrag):
2013-07-24 Antoine Quint <graouts@apple.com>
Web Inspector: support click-and-drag editing of CSS numeric values
https://bugs.webkit.org/show_bug.cgi?id=118896
Reviewed by Timothy Hatcher.
Add support for adjustment of numeric values in the various CodeMirror editors
by holding the option key and dragging the mouse. By default, dragging one pixel
changes the value by 1, but key modifiers allow to customize that behavior by using
the control key to change the value to 0.1 and the shift key to change the value to 10.
* UserInterface/CodeMirrorAdditions.js:
Split adjustNumber() into two methods such that we may use its logic from the
CodeMirrorDragToAlterNumberController. The new method, CodeMirror.prototype.alterNumberInRange()
allow to set begin and end CodeMirror positions such that the existing alterNumber()
can use information based on the current cursor position, and CodeMirrorDragToAlterNumberController
can use information based on the hovered token.
* UserInterface/CodeMirrorDragToAlterNumberController.css: Added.
(.CodeMirror.drag-to-adjust .CodeMirror-lines):
Set the cursor to "col-resize" when a number token is hovered and the option key
modifier is pressed.
* UserInterface/CodeMirrorDragToAlterNumberController.js: Added.
(WebInspector.CodeMirrorDragToAlterNumberController):
We define the new "dragToAdjustNumbers" CodeMirror option.
(WebInspector.CodeMirrorDragToAlterNumberController.prototype.set enabled):
The "enabled" property controls whether the associated CodeMirror instance
may act upon hovering numeric values to adjust them via a drag interaction.
(WebInspector.CodeMirrorDragToAlterNumberController.prototype.handleEvent):
Proxy for various event-specific methods to deal with mouse events. We also bind
the value of the "active" property to the "mouseenter" and "mouseleave" events
if we're not currently dragging-to-adjust.
(WebInspector.CodeMirrorDragToAlterNumberController.prototype._setActive):
The "active" property is set when the mouse is over the associated CodeMirror
editor and when it's on we track all "mousemove" events such that we may
identify tokens containing numeric values. We also start tracking changes to the
option modifier key press state such that we may change the cursor accordingly.
We ensure that the CodeMirror instance is not read-only such that we don't
allow adjustment of numeric values in places where they couldn't be committed.
(WebInspector.CodeMirrorDragToAlterNumberController.prototype._setDragging):
The "dragging" property reflects whether a dragging-to-adjust interaction
is underway. We call into WebInspector.elementDragStart() and WebInspector.elementDragEnd()
to set the cursor to "col-resize" for the whole document while tracking mousemove
and mouseup events at the window level such that we can drag-to-adjust even outside
of the inspector window.
(WebInspector.CodeMirrorDragToAlterNumberController.prototype._setTracksMouseClickAndDrag):
The "tracksMouseClickAndDrag" property is set to true whenever the controller
has detected that a token containing a numeric value is being hovered and the
option modifier key is pressed. This property controls the cursor value for the
hovered token to reflect that a drag-to-adjust interaction is allowed and tracks
"mousedown" events for when a dragging interaction may be initiated.
(WebInspector.CodeMirrorDragToAlterNumberController.prototype._modifiersDidChange):
Sets the "tracksMouseClickAndDrag" property depending on the availability of a hovered
token containing a numeric value and the pressed state of the option modified key.
(WebInspector.CodeMirrorDragToAlterNumberController.prototype._mouseMoved):
Handles "mousemove" events when we're not in the "dragging" state such that we
check the currently hovered token, if any, to see if it contains a number that
we may drag-to-adjust. Subsequently, we may enter the "tracksMouseClickAndDrag"
state.
(WebInspector.CodeMirrorDragToAlterNumberController.prototype._mouseWasPressed):
Handles "mousedown" events during a drag-to-adjust interaction. We simply track
the current mouse position in the x-axis and enter the "dragging" state.
(WebInspector.CodeMirrorDragToAlterNumberController.prototype._mouseWasDragged):
Handles "mousemove" events when we are in the "dragging" state. We compare the
current mouse position in the x-axis with the last recoreded value and determine
the amount by which we should adjust the value, taking into account the shift and
control modifier keys. We then call into WebInspector.alterNumberInRange() to
apply the change amount to the associated CodeMirror editor.
(WebInspector.CodeMirrorDragToAlterNumberController.prototype._mouseWasReleased):
Handles "mouseup" events, simply exiting the "dragging" state and resetting other
parameters we would have customized as a result of the drag-to-adjust interaction.
(WebInspector.CodeMirrorDragToAlterNumberController.prototype._reset):
Resetting some parameters we would have customized as a result of the drag-to-adjust
interaction.
* UserInterface/Main.html:
Include the new CodeMirrorDragToAlterNumberController.{js|css} files.
* UserInterface/Main.js:
(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):
Add an extra parameter to elementDragStart() such that the caller may specify the event
target for the "mousemove" and "mouseup" events.
2013-07-23 Roland Takacs <rtakacs@inf.u-szeged.hu>
WebSocket initialization to use remote inspector
https://bugs.webkit.org/show_bug.cgi?id=118678
Reviewed by Timothy Hatcher.
Add WebSocket initialization and define a 'connect-src' directive in the
Content-Security-Policy HTTP header to enable the connection.
* UserInterface/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend):
* UserInterface/Main.html:
* UserInterface/Main.js:
(WebInspector.loaded):
(WebInspector._initializeWebSocketIfNeeded.createSocket.WebInspector):
(WebInspector._initializeWebSocketIfNeeded.createSocket):
(WebInspector._initializeWebSocketIfNeeded):
2013-07-22 Diego Pino Garcia <dpino@igalia.com>
Web Inspector: When right-clicking on a DataGrid column, show editing
menu option as "Edit <columnName>" instead of just "Edit"
https://bugs.webkit.org/show_bug.cgi?id=118970
Reviewed by Timothy Hatcher.
* Localizations/en.lproj/localizedStrings.js: Add literal "Edit '%s'"
* UserInterface/DataGrid.js: Change "Edit" for "Edit <columnTitle>"
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
2013-07-21 Seokju Kwon <seokju.kwon@gmail.com>
Web Inspector: Cleanup InspectorFrontendHostStub.js
https://bugs.webkit.org/show_bug.cgi?id=118959
Reviewed by Timothy Hatcher.
Remove some functions because we dont use on New Inspector.
* UserInterface/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub):
(.WebInspector.InspectorFrontendHostStub.prototype.save):
2013-07-17 Seokju Kwon <seokju.kwon@gmail.com>
Web Inspector: Fix a typo in WebInspector.loaded
https://bugs.webkit.org/show_bug.cgi?id=118834
Reviewed by Timothy Hatcher.
* UserInterface/Main.js:
(WebInspector.loaded):
2013-07-16 Seokju Kwon <seokju.kwon@gmail.com>
Web Inspector: InspectorFrontendHost is undefined
https://bugs.webkit.org/show_bug.cgi?id=118715
Reviewed by Timothy Hatcher.
Add InspectorFrontendHostStub.js to New Inspector because of the InspectorFrontendHost initialization.
* UserInterface/InspectorFrontendHostStub.js: Added.
(.WebInspector.InspectorFrontendHostStub):
(.WebInspector.InspectorFrontendHostStub.prototype.platform):
(.WebInspector.InspectorFrontendHostStub.prototype.port):
(.WebInspector.InspectorFrontendHostStub.prototype.bringToFront):
(.WebInspector.InspectorFrontendHostStub.prototype.closeWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):
(.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowHeight):
(.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowWidth):
(.WebInspector.InspectorFrontendHostStub.prototype.setToolbarHeight):
(.WebInspector.InspectorFrontendHostStub.prototype.moveWindowBy):
(.WebInspector.InspectorFrontendHostStub.prototype.loaded):
(.WebInspector.InspectorFrontendHostStub.prototype.localizedStringsURL):
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
(.WebInspector.InspectorFrontendHostStub.prototype.copyText):
(.WebInspector.InspectorFrontendHostStub.prototype.openInNewTab):
(.WebInspector.InspectorFrontendHostStub.prototype.canSave):
(.WebInspector.InspectorFrontendHostStub.prototype.save):
(.WebInspector.InspectorFrontendHostStub.prototype.append):
(.WebInspector.InspectorFrontendHostStub.prototype.close.cleanup):
(.WebInspector.InspectorFrontendHostStub.prototype.close):
(.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend):
(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
* UserInterface/Main.html:
2013-07-15 Seokju Kwon <seokju.kwon@gmail.com>
Web Inspector: Remove unused columns from select query in ImageUtilities.js
https://bugs.webkit.org/show_bug.cgi?id=118694
Reviewed by Timothy Hatcher.
* UserInterface/ImageUtilities.js: Remove pixelRatio and formatVersion from select query.
2013-07-15 Timothy Hatcher <timothy@apple.com>
Update CodeMirror to 3.14.1.
https://bugs.webkit.org/show_bug.cgi?id=118605
Reviewed by Joseph Pecoraro.
* Scripts/update-codemirror-resources.rb: Updated the list to add closebrackets.js and sorted the files.
* Tools/PrettyPrinting/CodeMirrorFormatters.js:
* Tools/PrettyPrinting/Formatter.js:
* Tools/PrettyPrinting/FormatterContentBuilder.js:
* Tools/PrettyPrinting/codemirror.css:
* Tools/PrettyPrinting/codemirror.js:
* Tools/PrettyPrinting/css.js:
* Tools/PrettyPrinting/javascript.js:
* UserInterface/External/CodeMirror/closebrackets.js:
* UserInterface/External/CodeMirror/codemirror.css:
* UserInterface/External/CodeMirror/codemirror.js:
* UserInterface/External/CodeMirror/coffeescript.js:
* UserInterface/External/CodeMirror/comment.js:
* UserInterface/External/CodeMirror/css.js:
* UserInterface/External/CodeMirror/javascript.js:
* UserInterface/External/CodeMirror/matchbrackets.js:
* UserInterface/External/CodeMirror/sql.js:
* UserInterface/External/CodeMirror/xml.js:
2013-07-15 Timothy Hatcher <timothy@apple.com>
Make sure to add main resources for sub-frames to the Network Timeline.
https://bugs.webkit.org/show_bug.cgi?id=118649
Reviewed by Joseph Pecoraro.
* UserInterface/TimelineManager.js:
(WebInspector.TimelineManager.prototype._mainResourceDidChange): Remove the
call to _clear() and early return for event.target.isMainFrame(). The _clear()
is already handled if needed by the call to _startAutoRecording(), so it was
redundant here and caused the erroneous addition of isMainFrame() early return.
2013-07-15 Timothy Hatcher <timothy@apple.com>
Properly handle style text changes while the color popover is open.
https://bugs.webkit.org/show_bug.cgi?id=118575
Reviewed by Joseph Pecoraro.
* UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._colorSwatchClicked.updateCodeMirror):
The original text marker might have been cleared by a style update, in this case we need to
find the new color text marker so we know the right range for the new style color text.
2013-07-14 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r152598.
http://trac.webkit.org/changeset/152598
https://bugs.webkit.org/show_bug.cgi?id=118658
totally broke the web inspector (JS ERROR: SyntaxError:
Expected token '}') (Requested by thorton on #webkit).
* Tools/PrettyPrinting/CodeMirrorFormatters.js:
* Tools/PrettyPrinting/Formatter.js:
* Tools/PrettyPrinting/FormatterContentBuilder.js:
* Tools/PrettyPrinting/codemirror.css:
(.CodeMirror-scrollbar-filler):
(.CodeMirror-gutters):
(.CodeMirror-vscrollbar, .CodeMirror-hscrollbar, .CodeMirror-scrollbar-filler):
(.CodeMirror-widget):
* Tools/PrettyPrinting/codemirror.js:
(window.CodeMirror):
(window.CodeMirror.):
(.do):
(moveVisually):
* Tools/PrettyPrinting/css.js:
(.):
(CodeMirror):
* Tools/PrettyPrinting/javascript.js:
(.):
* UserInterface/External/CodeMirror/codemirror.css:
(.CodeMirror-widget):
* UserInterface/External/CodeMirror/codemirror.js:
(window.CodeMirror):
(window.CodeMirror.):
* UserInterface/External/CodeMirror/coffeescript.js:
* UserInterface/External/CodeMirror/comment.js:
(.):
* UserInterface/External/CodeMirror/css.js:
(.):
(CodeMirror):
* UserInterface/External/CodeMirror/javascript.js:
(.):
* UserInterface/External/CodeMirror/matchbrackets.js:
(.):
* UserInterface/External/CodeMirror/sql.js:
* UserInterface/External/CodeMirror/xml.js:
2013-07-12 Timothy Hatcher <timothy@apple.com>
Update CodeMirror to 7f560afa1c (3.14+).
https://bugs.webkit.org/show_bug.cgi?id=118605
Reviewed by Sam Weinig.
* Tools/PrettyPrinting/CodeMirrorFormatters.js:
* Tools/PrettyPrinting/Formatter.js:
* Tools/PrettyPrinting/FormatterContentBuilder.js:
* Tools/PrettyPrinting/codemirror.css:
* Tools/PrettyPrinting/codemirror.js:
* Tools/PrettyPrinting/css.js:
* Tools/PrettyPrinting/javascript.js:
* UserInterface/External/CodeMirror/codemirror.css:
* UserInterface/External/CodeMirror/codemirror.js:
* UserInterface/External/CodeMirror/coffeescript.js:
* UserInterface/External/CodeMirror/comment.js:
* UserInterface/External/CodeMirror/css.js:
* UserInterface/External/CodeMirror/javascript.js:
* UserInterface/External/CodeMirror/matchbrackets.js:
* UserInterface/External/CodeMirror/sql.js:
* UserInterface/External/CodeMirror/xml.js:
2013-07-12 Seokju Kwon <seokju.kwon@gmail.com>
Web Inspector: Pass null for sidebarPanels and role in WebInspector.Sidebar()
https://bugs.webkit.org/show_bug.cgi?id=118589
Reviewed by Timothy Hatcher.
sidebarPanels : It is necessary to get correct argument after r152141.
Without this, error messages can be displayed.
role : Could pass null for it since default value is "group".
* UserInterface/Main.js:
(WebInspector.contentLoaded):
2013-07-03 Timothy Hatcher <timothy@apple.com>
Guard remaining calls to decodeURIComponent with a try/catch.
https://bugs.webkit.org/show_bug.cgi?id=118371
Reviewed by Joseph Pecoraro.
* UserInterface/Main.js:
(WebInspector.displayNameForURL):
(WebInspector.updateWindowTitle):
* UserInterface/Utilities.js:
(arrayResult):
(queryString):
2013-07-03 Jessie Berlin <jberlin@apple.com>
Ran update-webkit-localizable-strings.
Rubber-stamped by Joseph Pecoraro.
* Localizations/en.lproj/localizedStrings.js:
2013-06-28 Dean Jackson <dino@apple.com>
Update Apple System fonts in auto-complete
https://bugs.webkit.org/show_bug.cgi?id=118205
<rdar://problem/14308488>
Reviewed by Joseph Pecoraro.
Update for the new Apple System font names, and remove some invalid entries.
* UserInterface/CSSKeywordCompletions.js: General cleanup. Note that
"apple-system-short-caption2" looks like it was accidentally omitted. It wasn't :)
2013-06-28 James Craig <james@cookiecrook.com>
Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
https://bugs.webkit.org/show_bug.cgi?id=118122
Reviewed by Timothy Hatcher.
Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
so that screen readers will not indicate a bogus :required/:invalid state to the user.
Minor cosmetic difference blocked by http://webkit.org/b/118162
* UserInterface/FilterBar.css:
(.filter-bar > input[type="search"]:focus):
(.filter-bar > input[type="search"]:not(:placeholder-shown)):
* UserInterface/FilterBar.js:
(WebInspector.FilterBar):
* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
* UserInterface/SearchBar.css:
(.search-bar > input[type="search"]:focus):
(.search-bar > input[type="search"]:not(:placeholder-shown)):
* UserInterface/SearchBar.js:
(WebInspector.SearchBar):
2013-06-27 James Craig <james@cookiecrook.com>
Web Inspector: AX: Add container ARIA roles (toolbar, main, labeled regions, etc.)
so the layout is more discoverable to screen reader users
https://bugs.webkit.org/show_bug.cgi?id=118104
Reviewed by Timothy Hatcher.
Made the basic layout (toolbar, sidebars, main) of the Web Inspector understandable
and navigable with VoiceOver.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/ButtonNavigationItem.js:
* UserInterface/CSSStyleDetailsSidebarPanel.js:
* UserInterface/DashboardManager.js:
* UserInterface/Main.js:
* UserInterface/NavigationBar.js:
* UserInterface/NavigationItem.js:
* UserInterface/NavigationSidebarPanel.js:
* UserInterface/RadioButtonNavigationItem.js:
* UserInterface/Sidebar.js:
* UserInterface/SidebarPanel.js:
* UserInterface/Toolbar.js:
2013-06-27 James Craig <james@cookiecrook.com>
Web Inspector: AX: Console log of the Inspector does not announce output for screen readers
https://bugs.webkit.org/show_bug.cgi?id=115976
Reviewed by Timothy Hatcher.
Main console log area (div.console-messages) is now an ARIA live region (role="log")
so screen readers speak plain text updates.
Also added contextual labels (e.g. input/output) but speech output verification of
those is currently blocked by http://webkit.org/b/118096
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/ConsoleCommand.js:
(WebInspector.ConsoleCommand.prototype.toMessageElement):
* UserInterface/ConsoleCommandResult.js:
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):
* UserInterface/LogContentView.css:
(@media reader):
* UserInterface/LogContentView.js:
(WebInspector.LogContentView):
2013-06-27 Matthew Holden <jftholden@yahoo.com>
Web Inspector: Display color picker in popover on color swatch click
https://bugs.webkit.org/show_bug.cgi?id=117919
Reviewed by Timothy Hatcher.
Includes fixes from second code review.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/CSSColorPicker.css: Added.
(.colorpicker-container):
(.colorpicker-fill-parent):
(.colorpicker-top):
(.colorpicker-color):
(.colorpicker-bottom span):
(.colorpicker-text):
(.colorpicker-color-text-value):
(.colorpicker-hue):
(.colorpicker-fill):
(.colorpicker-range-container):
(.colorpicker-range-container *):
(.colorpicker-range-container label):
(.colorpicker-range-container input):
(.colorpicker-saturation):
(.colorpicker-value):
(.colorpicker-dragger):
(.colorpicker-slider):
(.colorpicker-container .swatch):
(.colorpicker-container .swatch-inner):
* UserInterface/CSSColorPicker.js: Added.
(WebInspector.CSSColorPicker.consume):
(WebInspector.CSSColorPicker.move):
(WebInspector.CSSColorPicker.start):
(WebInspector.CSSColorPicker.stop):
(WebInspector.CSSColorPicker.makeDraggable):
(WebInspector.CSSColorPicker.hueDrag):
(WebInspector.CSSColorPicker.colorDragStart):
(WebInspector.CSSColorPicker.colorDrag):
(WebInspector.CSSColorPicker.alphaDrag):
(WebInspector.CSSColorPicker.colorSwatchClicked):
(WebInspector.CSSColorPicker):
(WebInspector.CSSColorPicker.prototype.get element):
(WebInspector.CSSColorPicker.prototype.set color):
(WebInspector.CSSColorPicker.prototype.get color):
(WebInspector.CSSColorPicker.prototype.get outputColorFormat):
(WebInspector.CSSColorPicker.prototype.get colorHueOnly):
(WebInspector.CSSColorPicker.prototype.set displayText):
(WebInspector.CSSColorPicker.prototype.shown):
(WebInspector.CSSColorPicker.prototype._updateHelperLocations):
(WebInspector.CSSColorPicker.prototype._updateDisplay):
(WebInspector.CSSColorPicker.hsvaToRGBA):
(WebInspector.CSSColorPicker.rgbaToHSVA):
* UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype.didDismissPopover):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText.colorTextMarker):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText):
* UserInterface/Main.html:
2013-06-26 Antoine Quint <graouts@apple.com>
Web Inspector: stepping through while paused in debugger makes a popover appear
https://bugs.webkit.org/show_bug.cgi?id=117994
There is no obvious need to call tokenTrackingControllerNewHighlightCandidate when the
active call frame changes and it leads to an extraneous display of the popover.
Reviewed by Timothy Hatcher.
* UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._activeCallFrameDidChange):
2013-06-24 Antoine Quint <graouts@apple.com>
Web Inspector: WebInspector.displayNameForURL() failure prevents DOM inspection
https://bugs.webkit.org/show_bug.cgi?id=117927
Handle possible mis-encoded URI fragments passed to decodeURIComponent() which
could prevent inspection of the DOM.
Reviewed by Timothy Hatcher.
* UserInterface/Main.js:
(WebInspector.displayNameForURL):
2013-06-17 Darin Adler <darin@apple.com>
Sort all the Xcode project files
https://bugs.webkit.org/show_bug.cgi?id=117696
Reviewed by Anders Carlsson.
* WebInspectorUI.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
2013-06-21 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Uncaught exception when pretty printing WebInspector.Script
https://bugs.webkit.org/show_bug.cgi?id=117893
This was an issue with an earlier refactoring. The sourceCode is a Script,
so replace the non-existent local variable "script" with "this._sourceCode".
Reviewed by Timothy Hatcher.
* UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype.textEditorUpdatedFormatting):
2013-06-21 Timothy Hatcher <timothy@apple.com>
Stop removing and re-adding breakpoints from the backend on reload.
On reload the sourceCode for breakpoints are nulled out, which fires DisplayLocationDidChange.
Then the sourceCode is reassociated, firing DisplayLocationDidChange again. In these cases we
don't need to update the backend, since nothing really changed.
https://bugs.webkit.org/show_bug.cgi?id=117877
Reviewed by Joseph Pecoraro.
* UserInterface/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype._breakpointDisplayLocationDidChange): Return early when
_ignoreBreakpointDisplayLocationDidChangeEvent is true.
(WebInspector.DebuggerManager.prototype.reset): Set _ignoreBreakpointDisplayLocationDidChangeEvent.
(WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode): Ditto.
2013-06-19 Antoine Quint <graouts@apple.com>
Web Inspector: Copying array or object output does not contain values
https://bugs.webkit.org/show_bug.cgi?id=117669
ConsoleCommandResult was overriding toClipboardString() but wasn't using the complex code
in ConsoleMessageImpl's toClipboardString() to provide a nicely formatted output for objects.
We now use a "clipboarPrefixString" property to customize the prefix used in the clipboard
and, additionally, only use that prefix if we're copying more than a single message since it's
the only situation where it's useful to have the ">" or "<" prefix shown. Console messages with
a log level always print the level and when saving the console log using Cmd+S, all messages
contain their prefix as well.
Reviewed by Timothy Hatcher.
* UserInterface/ConsoleCommand.js:
(WebInspector.ConsoleCommand.prototype.toClipboardString):
Handle the new isPrefixOptional argument.
* UserInterface/ConsoleCommandResult.js:
(WebInspector.ConsoleCommandResult.prototype.get clipboarPrefixString):
Provide a custom "< " prefix and set "enforcesClipboardPrefixString" to false such that
the prefix isn't printed out in situations when it may not.
* UserInterface/ConsoleMessageImpl.js:
Set "enforcesClipboardPrefixString" to true since we always want to log the log level
prefix in all situations.
(WebInspector.ConsoleMessageImpl.prototype.get clipboarPrefixString):
Implement this new getter to return our clipboard string such that subclasses may
customize it.
(WebInspector.ConsoleMessageImpl.prototype.toClipboardString):
Take into account both isPrefixOptional and the "enforcesClipboardPrefixString" property
to only log the prefix if necessary.
* UserInterface/LogContentView.js:
(WebInspector.LogContentView.prototype._formatMessagesAsData):
Make the logging of prefix optional when we have a single message selected and we're
not saving via Cmd+S.
2013-06-18 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Infrequent uncaught exception with debugger popovers breaks inspector
https://bugs.webkit.org/show_bug.cgi?id=117755
Create the ZERO_SIZE and ZERO_RECT objects after we've setup the Size
and Rect prototypes, so they get the expected methods. We then need to
handle the ZERO_RECT case better, and not attempt to draw a background
in a canvas with a 0 size, which would produce an exception.
Reviewed by Timothy Hatcher.
* UserInterface/Geometry.js:
* UserInterface/Popover.js:
(WebInspector.Popover.prototype._update):
2013-06-18 Timothy Hatcher <timothy@apple.com>
If the tree outline is processing a selection currently, then don't change the selection.
This is needed to allow breakpoints tree elements to be selected without jumping back to
selecting the resource tree element.
https://bugs.webkit.org/show_bug.cgi?id=117746
Reviewed by Joseph Pecoraro.
* UserInterface/Main.js:
(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
* UserInterface/TreeOutline.js:
(TreeElement.prototype.select):
2013-06-18 Timothy Hatcher <timothy@apple.com>
Update breakpoints to match Xcode 5.
This updates the breakpoint images, line colors, and moves breakpoints toggle button
to the Debugger sidebar navigation bar.
https://bugs.webkit.org/show_bug.cgi?id=117723
Reviewed by Joseph Pecoraro.
* Localizations/en.lproj/localizedStrings.js: Updated.
* UserInterface/DebuggerSidebarPanel.css: Removed custom toggle button rules.
* UserInterface/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._breakpointsToggleButtonClicked):
* UserInterface/Images/Breakpoint.png: Updated.
* UserInterface/Images/Breakpoints.pdf: Added.
* UserInterface/Images/Breakpoint@2x.png: Updated.
* UserInterface/Images/BreakpointButton.pdf: Updated.
* UserInterface/Images/BreakpointInactive.png: Updated.
* UserInterface/Images/BreakpointInactive@2x.png: Updated.
* UserInterface/Images/BreakpointInactiveButton.pdf: Updated.
* UserInterface/Images/InstructionPointer.png: Updated.
* UserInterface/Images/InstructionPointer@2x.png: Updated.
* UserInterface/SourceCodeTextEditor.css:
(.source-code.text-editor > .CodeMirror .error): Updated background-color and removed box-shadow.
(.source-code.text-editor > .CodeMirror .warning): Ditto.
* UserInterface/TextEditor.css:
(.text-editor > .CodeMirror .has-breakpoint .CodeMirror-linenumber::before): Changed left position to 0.
(.text-editor > .CodeMirror .execution-line .CodeMirror-linenumber::after): Updated position.
(.text-editor > .CodeMirror .execution-line): Updated background-color and removed box-shadow.
2013-06-13 Joseph Pecoraro <pecoraro@apple.com>
<http://webkit.org/b/117615> Web Inspector: JS PrettyPrinting Should have space between "do" and "{"
Reviewed by Timothy Hatcher.
* UserInterface/CodeMirrorFormatters.js:
2013-06-13 Joseph Pecoraro <pecoraro@apple.com>
<http://webkit.org/b/117612> Web Inspector: "Search Resource Content" should cancel when I remove all text search text
Reviewed by Timothy Hatcher.
* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype._searchFieldInput):
== Rolled over to ChangeLog-2013-06-11 ==