| 2011-02-08 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| fix toolbar anchoring in the code review tool |
| https://bugs.webkit.org/show_bug.cgi?id=54058 |
| |
| Avoid the anchoring cycle of doom when on the cusp |
| of whether the toolbar needs to be anchored and |
| speculatively avoid the Firefox crash when resizing. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2011-02-07 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| bring back diff context lines into the review tool |
| https://bugs.webkit.org/show_bug.cgi?id=53974 |
| |
| * code-review.js: |
| |
| 2011-02-01 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Roben. |
| |
| include svn revisions in git diffs for the code review tool to use |
| https://bugs.webkit.org/show_bug.cgi?id=53569 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2011-02-01 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| make draft comments focusable |
| https://bugs.webkit.org/show_bug.cgi?id=53554 |
| |
| Makes frozen draft comments focusable. The ones that are currently being edited are not. |
| I'm on the fence whether they should be, but this seems good enough for now. |
| |
| * code-review.js: |
| |
| 2011-02-01 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| avoid jitter when loading the comments to a patch |
| https://bugs.webkit.org/show_bug.cgi?id=53570 |
| |
| * code-review.js: |
| |
| 2011-02-01 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Mihai Parparita. |
| |
| [codereviewtool] extra space at the beginning of lines in side-by-side view |
| https://bugs.webkit.org/show_bug.cgi?id=53550 |
| |
| The newline between the spans turns into user-visible space in side-by-side mode. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2011-02-01 Ojan Vafai <ojan@chromium.org> |
| |
| Increment version number to cache-bust code-review.js. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2011-01-31 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| Store draft comments in localStorage |
| https://bugs.webkit.org/show_bug.cgi?id=52866 |
| |
| * code-review.js: |
| * code-review-test.html |
| |
| 2011-01-20 Ojan Vafai <ojan@chromium.org> |
| |
| Fix the review tool for image diffs. We would get a javascript error |
| because image diffs don't have line numbers. |
| |
| * code-review.js: |
| |
| 2011-01-20 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Oliver Hunt. |
| |
| Could review tool include style failure info? |
| https://bugs.webkit.org/show_bug.cgi?id=49049 |
| |
| This does not handle patches that have old paths (e.g. without the Source prefix). |
| Although that would be fairly straightforward to workaround. |
| |
| * code-review.js: |
| |
| 2011-01-20 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| handle cases where PrettyPatch.rb doesn't linkify filenames |
| https://bugs.webkit.org/show_bug.cgi?id=52834 |
| |
| * code-review.js: |
| |
| 2011-01-20 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| fix goofup in http://trac.webkit.org/changeset/76082 |
| https://bugs.webkit.org/show_bug.cgi?id=52830 |
| |
| We were showing the revision number of the patch at the bottom |
| of the diff and expanding from the bottom of the diff would fail. |
| |
| Also, removed an unused variable and scoped queries appropriatly |
| to the file_diff they should have been operating on. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2011-01-19 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| [reviewtool] Add a link for annotated trac page on review page |
| https://bugs.webkit.org/show_bug.cgi?id=52747 |
| |
| -add line numbers to all trac links to the first line in the file diff |
| -add annotate/review log links |
| -make file-diff links other than the file name only show when you mouseover the filediff |
| -fix white-space to only wrap the .text element and it's childen, any of it's siblings/parents |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2011-01-14 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| make line selection have a extend only from where you start the selection in the code review tool |
| https://bugs.webkit.org/show_bug.cgi?id=52485 |
| |
| * code-review.js: |
| |
| 2011-01-18 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Eric Seidel. |
| |
| make file expansion use the file at the svn revision the diff was created at |
| https://bugs.webkit.org/show_bug.cgi?id=52650 |
| |
| This only works for patches created with SVN for now since the git |
| diff does not include SVN revision numbers in it. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2011-01-15 Adam Barth <abarth@webkit.org> |
| |
| Rubber-stamped by Eric Seidel. |
| |
| Move WebKit2 into Source |
| https://bugs.webkit.org/show_bug.cgi?id=52438 |
| |
| Remove WebKit2 from the list of top-level source directories. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2011-01-14 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| fix expanded lines in the code review tool |
| https://bugs.webkit.org/show_bug.cgi?id=52498 |
| |
| Fixes them to work now that we have wrapper divs. |
| Also fixes the long-standing bug that the line numbers |
| were incorrect sometimes. |
| |
| * code-review.js: |
| |
| 2011-01-14 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| put remove lines to the left of add lines in sidebyside view |
| https://bugs.webkit.org/show_bug.cgi?id=52458 |
| |
| Also, sneaking in a fix to make long lines with no whitespace wrap. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2011-01-14 Ojan Vafai <ojan@chromium.org> |
| |
| Fix bad merge in r75816. |
| |
| * code-review.js: |
| |
| 2011-01-14 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| improve line selection with fast drags |
| https://bugs.webkit.org/show_bug.cgi?id=52477 |
| |
| * code-review.js: |
| |
| 2011-01-14 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| tweak line selection in code review tool |
| https://bugs.webkit.org/show_bug.cgi?id=52462 |
| |
| -Improve handling of data-comment-base-line code to deal with |
| lines that have multiple values. |
| -Make it so that if you click on the line immediately above |
| a line that has a comment it will add a new comment instead of |
| adding lines to the following comment. If the last selected line |
| overlaps existing comment lines though they will still get |
| added to the existing comment. |
| |
| * code-review.js: |
| |
| 2011-01-14 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Roben. |
| |
| fix bugs going back and forth between unified and sidebyside |
| https://bugs.webkit.org/show_bug.cgi?id=52470 |
| |
| Now that we're appending DOM nodes directly, we only want to |
| get the first ".text" element in the subtree. In the cases |
| where there are multiple, their contents are the same. |
| |
| Also, when making side-by-side expansion lines, we need to |
| clone the contents so we have a second copy to append to the DOM. |
| |
| * code-review.js: |
| |
| 2011-01-13 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| simplify keyboard handling in code review tool |
| https://bugs.webkit.org/show_bug.cgi?id=52407 |
| |
| Now that we have DiffBlock containers, the only things that are |
| focusable are previousComment nodes and DiffBlock containers |
| that contain add/remove lines. |
| |
| Also, this means we show the focus border around the entire diff |
| instead of just the first line. |
| |
| * code-review.js: |
| |
| 2011-01-13 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| add container divs for diff blocks |
| https://bugs.webkit.org/show_bug.cgi?id=52400 |
| |
| This will help simplify a lot of code in code-review.js |
| and make side-by-side diffs better (i.e. put removed lines |
| to the left of corresponding added lines). |
| |
| Also, allow for running the JS from a local file. Now you can modify code-review.js |
| to point to a local file and then run: |
| ruby prettify.rb < foo.diff > foo.html |
| |
| foo.html will load a dummy code review matching foo.diff. |
| |
| Before structure: |
| Line |
| Line remove |
| Line add |
| Line add |
| Line |
| |
| After structure: |
| DiffBlock |
| DiffBlockPart shared |
| Line shared |
| DiffBlock |
| DiffBlockPart remove |
| Line remove |
| DiffBlockPart add |
| Line add |
| Line add |
| DiffBlock |
| DiffBlockPart shared |
| Line shared |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2011-01-12 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Mihai Parparita. |
| |
| fix assorted bugs with expansion lines |
| https://bugs.webkit.org/show_bug.cgi?id=52326 |
| |
| -Clicking "all" would collapse whitespace in the expanded lines. |
| -Converted the remaining line creation code to using the DOM. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2011-01-12 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| review tool formatted diff doesn't match the uploaded diff |
| https://bugs.webkit.org/show_bug.cgi?id=51960 |
| |
| PrettyPatch works just fine if there is no newline at the end of the file. |
| |
| * attachment.cgi: |
| |
| 2011-01-12 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| Bugzilla: Add keyboard shortcuts to jump to next change |
| https://bugs.webkit.org/show_bug.cgi?id=52305 |
| |
| Comments and diff blocks go in the same queue. If you have a |
| comment focused, then j/k will focus the next/prev diff block |
| with respect to that comment. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2011-01-12 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| show shared lines on both sides in code review tool |
| https://bugs.webkit.org/show_bug.cgi?id=52308 |
| |
| We were appending the same DOM node twice. Instead, make |
| the from column a clone of the original node. |
| |
| * code-review.js: |
| |
| 2011-01-12 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| fix wrapping bug in expansion lines in the code review tool |
| https://bugs.webkit.org/show_bug.cgi?id=52270 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2011-01-11 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| fix difflink centering to be vertical, not horizontal |
| https://bugs.webkit.org/show_bug.cgi?id=52263 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2011-01-11 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| remember diffstate for review tool |
| https://bugs.webkit.org/show_bug.cgi?id=52253 |
| |
| If you use the global sidebyside/unified links, store the diff type |
| in localstorage. Then, onload, use that diff type. That way, people |
| who prefer one diff type or the other can always get that by default. |
| |
| * code-review.js: |
| |
| 2011-01-11 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| allow sidebysideifying individual files in the code review tool |
| https://bugs.webkit.org/show_bug.cgi?id=52226 |
| |
| * code-review.js: |
| |
| 2011-01-11 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Mihai Parparita. |
| |
| fix exception when adding a comment to a side-by-side diff |
| https://bugs.webkit.org/show_bug.cgi?id=52240 |
| |
| prev() and next() won't get the previous and next lines in |
| side-by-side mode. Instead do a query to find them. |
| |
| * code-review.js: |
| |
| 2011-01-11 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Mihai Parparita. |
| |
| maintain word diffs when converting to side-by-side and back |
| https://bugs.webkit.org/show_bug.cgi?id=52244 |
| |
| Using textContent would lose the spans use to make the word-diff highlighting. |
| Just move the span element itself. |
| |
| * code-review.js: |
| |
| 2011-01-11 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| fix layout error with comments in code review tool |
| https://bugs.webkit.org/show_bug.cgi?id=52230 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2011-01-10 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| convert back to unified from sidebyside diff |
| https://bugs.webkit.org/show_bug.cgi?id=52180 |
| |
| Remove url fragment stuff. Having it be per-filediff is too complicated. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2011-01-07 Adam Barth <abarth@webkit.org> |
| |
| Rubber-stamped by Eric Seidel. |
| |
| Move WebCore to Source |
| https://bugs.webkit.org/show_bug.cgi?id=52050 |
| |
| Remove reference to old directory. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2011-01-06 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| side-by-side diffs in the code review tool |
| https://bugs.webkit.org/show_bug.cgi?id=52019 |
| |
| Support for conversion from the formatted diff to a side-by-side diff. |
| Maintains comments and new comments can be added. |
| |
| The main architectural change is that Line elements are no longer necessarily |
| siblings. Each physical line is now in a LineContainer and LineContainers are |
| siblings. Each Line corresponds to a Line in the unified diff and has an id (e.g. line12). |
| A Line can be a LineContainer or a child of a LineContainer. |
| |
| In this way, converting to side-by-side and, in the future, back to unified is non-lossy. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2011-01-06 Ojan Vafai <ojan@chromium.org> |
| |
| Fix line context when replying to comments. |
| |
| * code-review.js: |
| |
| 2011-01-05 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| change the way we do comment highlighting in the code review tool |
| https://bugs.webkit.org/show_bug.cgi?id=51971 |
| |
| Store a space-separated list of base line IDs on each line that has |
| comments associated with that line. This allows for overlapping comments, |
| but more importantly, makes adding side-by-side diff support easier. |
| |
| * code-review.js: |
| |
| 2011-01-05 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| minor code cleanup for code review tool |
| https://bugs.webkit.org/show_bug.cgi?id=51962 |
| |
| Consolidates some queries to using shared functions. |
| |
| * code-review.js: |
| |
| 2011-01-05 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| assorted cleanups to prepare for side-by-side diffing |
| https://bugs.webkit.org/show_bug.cgi?id=51961 |
| |
| Mostly, use selector queries instead of assuming comments are next siblings. |
| |
| * code-review.js: |
| |
| 2011-01-05 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| fix message container selector for code review tool |
| https://bugs.webkit.org/show_bug.cgi?id=51959 |
| |
| * code-review.js: |
| |
| 2011-01-04 Ojan Vafai <ojan@chromium.org> |
| |
| Increment version number to avoid getting the cached JS file. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-12-15 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| anchor the toolbar to the bottom of the diff if the diff doesn't take a full screen of height |
| https://bugs.webkit.org/show_bug.cgi?id=51162 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2011-01-01 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| Move JavaScriptCore to Source |
| https://bugs.webkit.org/show_bug.cgi?id=51604 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| - Remove reference to JavaScriptCore as a source directory. |
| |
| 2011-01-01 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| Move Sources to Source |
| https://bugs.webkit.org/show_bug.cgi?id=51794 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-12-31 Adam Barth <abarth@webkit.org> |
| |
| Rubber-stamped by Eric Seidel. |
| |
| Move PageLoadTests to PerformanceTests/PageLoad |
| https://bugs.webkit.org/show_bug.cgi?id=51771 |
| |
| Update list of top-level open-source directories. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-12-31 Adam Barth <abarth@webkit.org> |
| |
| Rubber-stamped by Eric Seidel. |
| |
| Move SunSpider into PerformanceTests |
| https://bugs.webkit.org/show_bug.cgi?id=51769 |
| |
| Update list of top-level open-source directories. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-12-26 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| Move autotools into Sources |
| https://bugs.webkit.org/show_bug.cgi?id=51630 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| - Remove reference to non-existant autotools directory. |
| |
| 2010-12-26 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| Move cmake into Sources |
| https://bugs.webkit.org/show_bug.cgi?id=51631 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-12-23 Adam Barth <abarth@webkit.org> |
| |
| Rubber-stamped by Eric Seidel. |
| |
| Move JavaScriptGlue into Sources |
| https://bugs.webkit.org/show_bug.cgi?id=51583 |
| |
| PrettyPatch keeps a list of the top-level directories that exist in |
| trac. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-12-20 Adam Barth <abarth@webkit.org> |
| |
| One more tweak caused by moving the web sites around. I had this |
| change in my patch originally, but I missed it because I had to use |
| server-side svn move commands to move the bulk of the web site files. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-12-18 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Sam Weinig. |
| |
| Move WebKitExamplePlugins to Examples |
| https://bugs.webkit.org/show_bug.cgi?id=51291 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-12-17 Dan Bernstein <mitz@apple.com> |
| |
| Reviewed by Simon Fraser. |
| |
| Rename WebKitTools to Tools |
| https://bugs.webkit.org/show_bug.cgi?id=49861 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * committers-autocomplete.js: |
| |
| 2010-12-17 Ojan Vafai <ojan@chromium.org> |
| |
| Increment psuedo-version number to avoid pulling cached version. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-12-17 Ojan Vafai <ojan@chromium.org> |
| |
| Speculative fix for the code review tool in Firefox. |
| Fixes a JS error and makes the status bubble mostly work |
| if postMessage is not supported. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2010-12-15 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| size status bubble to it's contents on the code review page |
| https://bugs.webkit.org/show_bug.cgi?id=51142 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2010-12-15 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| fix goofups from r74142 and r74130 |
| https://bugs.webkit.org/show_bug.cgi?id=51146 |
| |
| Accidentally shrank the inline comment boxes and made |
| the toolbar not show up when there were image diffs. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2010-12-14 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| add ability to view for file context to the review tool |
| https://bugs.webkit.org/show_bug.cgi?id=51057 |
| |
| At the beginning/end of each file diff and between each |
| hunk add links to expand the context. For now it grabs the |
| tip of tree version of the file and tries to apply the diff |
| to that file. If it can't apply, then it gives up as we |
| wouldn't want to show the wrong lines of context. |
| |
| In the future, we can consider adding the upload svn revision |
| to the diff itself, then we could fallback to the file at that |
| revision if tip of tree doesn't apply. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2010-12-08 Ojan Vafai <ojan@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| [reviewtool] should always show overall comments text box |
| https://bugs.webkit.org/show_bug.cgi?id=45870 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2010-12-04 Patrick Gansterer <paroga@webkit.org> |
| |
| Reviewed by Adam Barth. |
| |
| Increase size of status bubbles |
| https://bugs.webkit.org/show_bug.cgi?id=50496 |
| |
| The current available space isn't enough to display all |
| pending results including position in the queue. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-12-04 Patrick Gansterer <paroga@webkit.org> |
| |
| Reviewed by Adam Barth. |
| |
| Increase size of status bubbles |
| https://bugs.webkit.org/show_bug.cgi?id=50496 |
| |
| The current available space isn't enough to display all |
| pending results including position in the queue. |
| |
| * template/en/custom/attachment/edit.html.tmpl: |
| * template/en/custom/attachment/list.html.tmpl: |
| * template/en/custom/attachment/reviewform.html.tmpl: |
| |
| 2010-11-08 Adam Barth <abarth@webkit.org> |
| |
| Update help text to match behavior change. |
| |
| * code-review.js: |
| |
| 2010-11-08 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| Restore normal meaning of double-click on patch review page? |
| https://bugs.webkit.org/show_bug.cgi?id=47641 |
| |
| After this patch, you need to click on the line numbers to add a |
| comment. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2010-10-09 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Alexey Proskuryakov. |
| |
| Exception in committers-autocomplete in Firefox |
| https://bugs.webkit.org/show_bug.cgi?id=47456 |
| |
| Remove dependency on a WebKit-only quirk. IMHO, this quirk is bad for |
| the long-term health of the web, but that's a discussion for another |
| patch. |
| |
| * committers-autocomplete.js: |
| |
| 2010-10-08 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Oliver Hunt. |
| |
| Bugmail for new attachments should link to the reviewtool |
| https://bugs.webkit.org/show_bug.cgi?id=47440 |
| |
| As requested by olliej himself. This patch was constructed by pure |
| reason. I have no way to actually run this code. |
| |
| * Bugzilla/BugMail.pm: |
| |
| 2010-09-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> |
| |
| Reviewed by Csaba Osztrogonác. |
| |
| Convert verbatim unicode values in comitter names to characters |
| |
| * committers-autocomplete.js: |
| |
| 2010-09-24 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> |
| |
| Reviewed by Csaba Osztrogonác. |
| |
| Support Unicode-strings in committers-autocomplete script |
| |
| * committers-autocomplete.js: |
| |
| 2010-09-22 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by John Sullivan. |
| |
| New review-page design doesn't include name of reviewer |
| https://bugs.webkit.org/show_bug.cgi?id=46271 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2010-09-22 Adam Barth <abarth@webkit.org> |
| |
| Fix typo in CSS. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-09-22 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| Add link to bug to review page |
| https://bugs.webkit.org/show_bug.cgi?id=46192 |
| |
| To make room for the link, I moved the help text to the top of the page |
| and tweaked the language to help folks discover that you can select |
| context using the line numbers. |
| |
| Also, move more text to sans-serif since that fits in better with the |
| pretty-patch fonts. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2010-09-21 Adam Barth <abarth@webkit.org> |
| |
| Unreviewed. |
| |
| [reviewtool] Publish button doesn't work |
| https://bugs.webkit.org/show_bug.cgi?id=46168 |
| |
| Darin's recent patch had a runtime error. Sadly, we don't have any |
| testing for this code. |
| |
| * code-review.js: |
| |
| 2010-09-20 Darin Adler <darin@apple.com> |
| |
| Reviewed by Adam Barth. |
| |
| Add Preview button and link to bug to patch review bar |
| https://bugs.webkit.org/show_bug.cgi?id=46153 |
| |
| * PrettyPatch/PrettyPatch.rb: Bump version number to make caches happy. |
| * code-review.js: Added Preview button and link to bug. |
| |
| 2010-09-19 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| [reviewtool] Publish button should actually publish the review comments |
| https://bugs.webkit.org/show_bug.cgi?id=46074 |
| |
| Instead of showing the confirmation lightbox, the Publish button now |
| publishes the comments directly. If there's demand for a "Preview" |
| button, we can find a way to add that feature. |
| |
| * code-review.js: |
| |
| 2010-09-19 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| Move reviewtool to action=review |
| https://bugs.webkit.org/show_bug.cgi?id=46071 |
| |
| This patch removes the old Review Patch screen and moves the new |
| reviewtool from Pretty Diff to Review Patch. |
| |
| * attachment.cgi: |
| * code-review.js: |
| |
| 2010-09-19 Adam Barth <abarth@webkit.org> |
| |
| Review tool UI tweak. This patch lengthens the status bubbles so all |
| the bubble fit (even when they have numbers inside). |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-09-19 Dan Bernstein <mitz@apple.com> |
| |
| Reviewed by Anders Carlsson. |
| |
| Fixed a typo. |
| |
| * code-review.js: Changed the label of the OK button from Ok to OK. |
| |
| 2010-09-15 Adam Barth <abarth@webkit.org> |
| |
| Unreviewed. |
| |
| Only show the review-in-context link if there are contextual comments. |
| |
| * code-review.js: |
| |
| 2010-09-15 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| [reviewtool] Show the status bubbles on the toolbar |
| https://bugs.webkit.org/show_bug.cgi?id=45861 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2010-09-15 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| [reviewtool] Allow setting review and commit-queue flags from main review screen |
| https://bugs.webkit.org/show_bug.cgi?id=45860 |
| |
| This patch adds drop down menus for adjusting the review and |
| commit-queue flags from the main review screen. These controls don't |
| appear immediately because we need to read the state of the flags off |
| the details page. |
| |
| It's a slight sadness that bugzilla doesn't have a clean way of |
| identifying which select control is associated with a given flag. The |
| flags seem to have some sort of id, but it's unclear to me how to map |
| that id back to a notion of "review" or "commit-queue". Instead, we |
| look for some magic strings in the title. I'm sure this will come back |
| to bit us at some point, but I'm not sure what to do that's better. |
| (The webkitpy solution to this problem is to assume that the flags are |
| in a given order, but this seems better.) |
| |
| * PrettyPatch/PrettyPatch.rb: |
| - Bump version number to bust throuh caches. |
| * code-review.js: |
| |
| 2010-09-15 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| [reviewtool] Comments should quote previous comments on the same line |
| https://bugs.webkit.org/show_bug.cgi?id=45847 |
| |
| Now when you reply to a previous comment, the tool will quote the |
| previous comment in the bugs.webkit.org post. This makes it eaiser for |
| folks following along in email to understand the discussion. |
| |
| While I was editing this code, I also cleaned up some of the whitespace |
| handling in comments. |
| |
| * code-review.js: |
| |
| 2010-09-15 Adam Barth <abarth@webkit.org> |
| |
| Minor UI tweak to the review tool. We want to display newlines in |
| previous and frozen comments instead of collapsing them. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-09-14 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| bugs.webkit.org should autocomplete WebKit Committers and Reviewers |
| https://bugs.webkit.org/show_bug.cgi?id=45799 |
| |
| This patch implements an autocomplete dropdown that helps users type |
| the names of WebKit committers and reviewers. The script grabs the |
| data from SVN now that wms set up CORS for http://svn.webkit.org. |
| Security technology for the win. |
| |
| This script is based on (well, essentially copied from) the popular |
| autocomplete extension: |
| |
| https://chrome.google.com/extensions/detail/olaabhcgdogcbcoiolomlcodkngnemfb |
| |
| I asked Ojan, and said he was fine licensing the code under the BSD |
| license. I'm not sure how the patch interacts with the extension, but |
| we can retire the extension if they interact poorly. |
| |
| * committers-autocomplete.js: Added. |
| * template/en/default/global/footer.html.tmpl: |
| - Add the script to every page on bugs.webkit.org |
| |
| 2010-09-14 Adam Barth <abarth@webkit.org> |
| |
| Add a license block to the reviewtool. I should have added this from |
| the start. According to the SVN log, I'm the only one to have ever |
| touched this file. |
| |
| * code-review.js: |
| |
| 2010-09-07 Adam Barth <abarth@webkit.org> |
| |
| Minor tweaks to the reviewtool UI. |
| |
| Rename Cancel to Discard to make it more clear what the button does. |
| Also, move the style declaration for the focus ring later in the sheet |
| so it works. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2010-09-06 Adam Barth <abarth@webkit.org> |
| |
| Small UI tweak to the reviewtool. Make the Ok/Cancel buttons a bit |
| bigger. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-09-06 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| [reviewtool] Add a quick animation for opening/closing comment boxes |
| https://bugs.webkit.org/show_bug.cgi?id=45278 |
| |
| The 200ms animation slides in and out the line-by-line comment box. |
| |
| * code-review.js: |
| |
| 2010-09-06 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| [reviewtool] Add a field for overall comments |
| https://bugs.webkit.org/show_bug.cgi?id=45273 |
| |
| This patch does a couple logically separate things that could be |
| separated into smaller patches: |
| |
| 1) This patch adds an "overall comments" field where you can enter |
| overall comments about the patch. These comments appear at the top |
| of the bugzilla posting. Currently, these aren't redisplayed when |
| viewing the patch, but I plan to add that in a future patch. |
| |
| 2) This patch renames some of the CSS classes to more consistently |
| follow the camelCase style that PrettyPatch uses. |
| |
| 3) This patch moves the "prepare comments" button to the left of the |
| toolbar and renames is to "publish comments". This makes more sense |
| when you scroll to the bottom of the page and enter in some overall |
| comments. |
| |
| 4) When you attempt to add a comment to a line that already has a |
| "frozen" comment, we now unfreeze the comment instead of doing |
| nothing. The old behavior was kind of frustrating if you didn't |
| know that you could unfreeze a comment by clicking on it. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| - Update CSS. |
| * code-review.js: |
| |
| 2010-09-06 Adam Barth <abarth@webkit.org> |
| |
| [reviewtool] Tweak the ok button to cancel the comment if the comment |
| is empty. Previously we would get into a bad state where a line had a |
| comment but there was no longer any way to access it. |
| |
| * code-review.js: |
| |
| 2010-09-06 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| [reviewtool] Add an "ok" button that collapses review comments |
| https://bugs.webkit.org/show_bug.cgi?id=45255 |
| |
| Many folks (including myself) are too trigger-happy with the "delete" |
| button that we end up deleting perfectly good review comments. This |
| patch adds an "ok" button to absorb these clicks (and renames "delete" |
| to "cancel"). When you click the ok button, the comment becomes |
| non-editable and the box shrinks to fit the text. You can click the |
| text to get back to the editable version. |
| |
| * code-review.js: |
| |
| 2010-08-31 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| [reviewtool] Make it easy to scroll through review comments |
| https://bugs.webkit.org/show_bug.cgi?id=45002 |
| |
| This patch lets you scroll through review comments using "n" (for next) |
| and "p" (for previous). It also attributes comments to their authors. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2010-08-31 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| [reviewtool] Show previous comments inline in diff |
| https://bugs.webkit.org/show_bug.cgi?id=44977 |
| |
| This patch adds basic support for showing previous comments inline in |
| the diff. We crawl the bugs.webkit.org comments about this attachment |
| and extract comments related to specific lines. We then show the |
| comments inline in the diff. |
| |
| This part of the tool needs a bunch of polish, but this at least is a |
| starting point for further work. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2010-08-31 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| [reviewtool] Allow reviewer to select lines of context by dragging over the line numbers |
| https://bugs.webkit.org/show_bug.cgi?id=44936 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| - Add a version number to bust through bugs.webkit.org's aggressive |
| cacheing. |
| * code-review.js: |
| |
| 2010-08-30 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| [review tool] Let reviewer select how much context to show in snippet |
| https://bugs.webkit.org/show_bug.cgi?id=44905 |
| |
| We now highlight the context for a comment in yellow on the left (where |
| the line numbers are). Clicking a line number expands or contracts the |
| amount of context, as appropriate. Informal user testing indicates |
| that we might want to support drag as well. |
| |
| This patch also changes the "open a comment box here" action to |
| double-click to avoid issues with mis-clicks. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: |
| |
| 2010-08-29 Adam Barth <abarth@webkit.org> |
| |
| Attempt to make Sam's life easier by not opening a comment text field |
| if there's a selection. This should make it easier to copy/paste text |
| out of the diff without accidentally opening comment boxes. |
| |
| * code-review.js: |
| |
| 2010-08-29 Adam Barth <abarth@webkit.org> |
| |
| Turns out we're supposed to use find instead of children here. |
| |
| * code-review.js: |
| |
| 2010-08-29 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Eric Seidel. |
| |
| Awesomify pretty-diff based review tool |
| https://bugs.webkit.org/show_bug.cgi?id=44835 |
| |
| This patch replaces the existing inline comment feature with a new |
| implementation. Hopefully the new implementation is more awesome. |
| It's not 100% done yet, but I'd like to get this version out there to |
| see how it works. |
| |
| Unlike the previous version this version works with the "Formatted |
| Diff" link instead of the "Review Patch" link. Hopefully that will |
| avoid interfering with folks who like the old style review. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * code-review.js: Added. |
| * prototype.js: Removed. |
| |
| 2010-08-19 Tony Chang <tony@chromium.org> |
| |
| Reviewed by Adam Barth. |
| |
| webkit-patch barfed on upload with a new image test result |
| https://bugs.webkit.org/show_bug.cgi?id=39097 |
| |
| * PrettyPatch/PrettyPatch.rb: don't use full path to git |
| |
| 2010-08-19 Tony Chang <tony@chromium.org> |
| |
| Unreviewed, setting svn:eol-style native on ChangeLog. |
| |
| 2010-08-19 Tony Chang <tony@chromium.org> |
| |
| Unreviewed. Just removing \r's from ChangeLog. |
| |
| 2010-08-02 Adam Roben <aroben@apple.com> |
| |
| Tell the patch prettifier about some (not so) new directories |
| |
| * PrettyPatch/PrettyPatch.rb: Added WebKit2, autotools, and cmake |
| directories. |
| |
| 2010-07-27 Joseph Pecoraro <joepeck@webkit.org> |
| |
| Reviewed by David Kilzer. |
| |
| Provide a Helpful Link for Web Inspector Bugs in Bugzilla |
| https://bugs.webkit.org/show_bug.cgi?id=43065 |
| |
| * template/en/custom/global/choose-product.html.tmpl: Added. Explicitly added a link for the Web Inspector. |
| |
| 2010-06-09 Julie Parent <jparent@chromium.org> |
| |
| Reviewed by David Kilzer. |
| |
| Bugzilla: Don't send mail for cancel/deny/granted for in-rietveld. |
| |
| https://bugs.webkit.org/show_bug.cgi?id=40345 |
| |
| * Bugzilla/Flag.pm: |
| |
| 2010-05-17 Julie Parent <jparent@chromium.org> |
| |
| Reviewed by Ojan Vafai. |
| |
| Rietveld review page should dedicate more space to Rietveld, less to high level comments form. |
| |
| https://bugs.webkit.org/show_bug.cgi?id=39244 |
| |
| * template/en/custom/attachment/reviewform.html.tmpl: |
| Delete a random BR amongst the hidden elements that was causing extra whitespace. |
| * template/en/custom/attachment/rietveldreview.html.tmpl: |
| Increase size of Rietveld frame to 80%, from 60%. |
| |
| 2010-05-14 Julie Parent <jparent@chromium.org> |
| |
| Reviewed by Ojan Vafai. |
| |
| Bugzilla: Only show "Rietveld Review" link when in-rietveld is set to +. |
| |
| https://bugs.webkit.org/show_bug.cgi?id=39141 |
| |
| * template/en/custom/attachment/list.html.tmpl: |
| |
| 2010-05-13 Julie Parent <jparent@chromium.org> |
| |
| Reviewed by David Kilzer. |
| |
| Bugzilla: Don't send mail if the only change is to the in-rietveld flag. |
| |
| https://bugs.webkit.org/show_bug.cgi?id=39090 |
| |
| * Bugzilla/BugMail.pm: |
| |
| 2010-05-12 Julie Parent <jparent@chromium.org> |
| |
| Reviewed by Ojan Vafai. |
| |
| Hide the in-rietveld flag in the UI. It is only used only by tooling and shouldn't clutter the UI. |
| https://bugs.webkit.org/show_bug.cgi?id=39024 |
| |
| * template/en/custom/attachment/list.html.tmpl: |
| Removes this flag entirely from the UI, not needed on this page. |
| * template/en/custom/flag/list.html.tmpl: Added. |
| Copied from template/en/default/flag/list.html.tmpl with only changes inside the if WEBKIT_CHANGES section. |
| Hides the flag rather than removing it completely, so tools can still interact with it. |
| |
| 2010-05-12 Julie Parent <jparent@chromium.org> |
| |
| Reviewed by David Kilzer. |
| |
| Adds support for Rietveld reviews. When there is an associated |
| Rietveld id for a patch, adds a link to do a Rietveld review instead. |
| |
| https://bugs.webkit.org/show_bug.cgi?id=38143 |
| |
| * attachment.cgi: |
| Added support for handling action=rietveldreview. |
| * template/en/custom/attachment/list.html.tmpl: |
| Adds a link to use rietveld review iff the in_rietveld flag is set. |
| * template/en/custom/attachment/reviewform.html.tmpl: |
| Detects if we are in rietveld review mode due to query string paramter, |
| and customizes the review form slightly: |
| - Changes text describing comment field. |
| - Comment field does not include quoted patch. |
| - Submit button fetches from Rietveld instead of just submitting. |
| * template/en/custom/attachment/rietveldreview.html.tmpl: Added. |
| New template for rietveldreview mode. Hosts the rietveld frame in the |
| top and the regular comments form in the bottom. |
| Uses postMessage to communicate with Rietveld frame. |
| |
| 2010-05-08 Chris Jerdonek <cjerdonek@webkit.org> |
| |
| Reviewed by Maciej Stachowiak. |
| |
| Allow long comment lines to wrap to the window width instead |
| of to 80 characters. |
| |
| https://bugs.webkit.org/show_bug.cgi?id=37792 |
| |
| * Bugzilla/Constants.pm: |
| - Introduced a new constant COMMENT_COLS_WRAP to replace COMMENT_COLS |
| inside the wrap_comment() subroutine. The new constant effectively |
| disables text wrapping by increasing the value used in wrap_comment() |
| from 80 characters to a very large value (8000). |
| * Bugzilla/Util.pm: |
| - Replaced COMMENT_COLS with COMMENT_COLS_WRAP inside wrap_comment(). |
| * skins/custom/global.css: |
| (.bz_comment_text): |
| - Eliminate the width styling on comments to allow long lines |
| to wrap at the window width. |
| (.bz_comment_text > span.quote): |
| - Inherit the "white-space" property. This prevents long quoted |
| lines in comments from causing non-quoted lines to extend beyond |
| the window width. |
| |
| 2010-04-22 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Darin Adler. |
| |
| The new review tools shouldn't clear the comment box automatically |
| https://bugs.webkit.org/show_bug.cgi?id=38004 |
| |
| Instead, we now have a button for doing that explicitly. If people |
| like this tool, we can look at fancier solutions. |
| |
| Also, tried to make the tool work on the edit page as well as the review page. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-04-22 Adam Barth <abarth@webkit.org> |
| |
| Unreviewed. Turns out we need to do more escaping because Ruby was |
| explanding our newlines, creating a syntax error. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-04-22 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Darin Adler. |
| |
| Hack up PrettyDiff to allow line-by-line comments |
| https://bugs.webkit.org/show_bug.cgi?id=37886 |
| |
| Admittedly a bit of a hack, this is a basic line-by-line editor we can |
| play with thanks to Andrew Scherkus. It's meant to integrate with the |
| "review" page at bugs.webkit.org. |
| |
| I changed a few things from Andrew's original version: |
| 1) Trigger text boxes on single click to make iPhone/iPad reviewing |
| easier. |
| 2) Clear the main text box on load. |
| 3) Reference a version of prototype.js on bugs.webkit.org. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| * prototype.js: Added. |
| |
| 2010-02-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> |
| |
| Reviewed by Maciej Stachowiak. |
| |
| Don't reset the assignee back to default on component change |
| |
| https://bugs.webkit.org/show_bug.cgi?id=35236 |
| |
| There's a risk of reseting a valid assignee for example when |
| triaging a bug. All components in WebKit have the default |
| assignee set to webkit-unassigned@webkit.org so this should |
| not cause problems for people relying on this functionality. |
| |
| * template/en/custom/bug/edit.html.tmpl: |
| |
| 2010-01-22 Janusz Lewandowski <lew21@xtreeme.org> |
| |
| Reviewed by Maciej Stachowiak. |
| |
| run-webkit-tests fails on Ruby 1.9 |
| https://bugs.webkit.org/show_bug.cgi?id=33554 |
| inject does not work with strings any more, so BugsSite/PrettyPatch/PrettyPatch.rb prints lots of errors. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2010-01-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> |
| |
| Reviewed by Adam Barth. |
| |
| Adjust height of status-bubbles to prevent them being cut. |
| |
| * template/en/custom/attachment/edit.html.tmpl: |
| * template/en/custom/attachment/list.html.tmpl: |
| * template/en/custom/attachment/reviewform.html.tmpl: |
| |
| 2010-01-08 David Kilzer <ddkilzer@apple.com> |
| |
| <http://webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button |
| |
| Reviewed by Adam Barth. |
| |
| This button was broken during a previous Bugzilla upgrade after |
| changes were made to the names of objects exposed on templates. |
| |
| * template/en/custom/attachment/reviewform.html.tmpl: Changed |
| attachid to attachment.id and ispatch to attachment.ispatch. |
| Also tweaked the format to use 4 table columns instead of 5. |
| |
| 2010-01-08 David Kilzer <ddkilzer@apple.com> |
| |
| Included UNCONFIRMED bugs by default in advanced search query |
| |
| Rubber-stamped by Alexey Proskuryakov. |
| |
| * data/params: Prepended 'bug_status=UNCONFIRMED&' to |
| 'defaultquery' parameter. |
| |
| 2010-01-08 David Kilzer <ddkilzer@apple.com> |
| |
| FIX: Make patch status appear on reviewform.html.tmpl |
| |
| * template/en/custom/attachment/reviewform.html.tmpl: Check |
| attachment.ispatch (not just ispatch) when deciding whether |
| to display patch status. Also update layout a bit. |
| |
| 2010-01-08 David Kilzer <ddkilzer@apple.com> |
| |
| Update data/params parameters |
| |
| * data/params: Updated 'timezone' to turn off DST. Updated |
| 'usebugaliases' and 'usevotes' to turn them off. |
| |
| 2010-01-08 Adam Barth <abarth@webkit.org> |
| |
| Reviewed by Darin Adler. |
| |
| Show patch status in bugs.webkit.org |
| https://bugs.webkit.org/show_bug.cgi?id=33368 |
| |
| This patch adds an iframe to the show_bug page and the edit attachment |
| page that displays whether the attachment passed the various bots. |
| |
| * template/en/custom/attachment/edit.html.tmpl: |
| * template/en/custom/attachment/list.html.tmpl: |
| * template/en/custom/attachment/reviewform.html.tmpl: |
| |
| 2009-12-07 Shinichiro Hamaji <hamaji@chromium.org> |
| |
| Reviewed by David Kilzer. |
| |
| Bugzilla should show images in git patches |
| https://bugs.webkit.org/show_bug.cgi?id=31395 |
| |
| Attempt to go r51748 again using --directory option of git-apply. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2009-12-06 Shinichiro Hamaji <hamaji@chromium.org> |
| |
| Unreviewed. Revert r51748. |
| |
| Bugzilla should show images in git patches |
| https://bugs.webkit.org/show_bug.cgi?id=31395 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2009-12-06 Shinichiro Hamaji <hamaji@chromium.org> |
| |
| Reviewed by David Kilzer. |
| |
| Bugzilla should show images in git patches |
| https://bugs.webkit.org/show_bug.cgi?id=31395 |
| |
| Show images in git patches using git-apply. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2009-10-23 Eric Seidel <eric@webkit.org> |
| |
| Reviewed by Adam Roben. |
| |
| PrettyPatch should show images even when they have the wrong mime type |
| https://bugs.webkit.org/show_bug.cgi?id=29506 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2009-10-17 Alexey Proskuryakov <ap@apple.com> |
| |
| Reviewed by Eric Carlson. |
| |
| https://bugs.webkit.org/show_bug.cgi?id=30470 |
| Make marking a bug as duplicate easier |
| |
| * js/field.js: (setResolutionToDuplicate): Focus the edit field, too. |
| |
| 2009-10-16 Alexey Proskuryakov <ap@apple.com> |
| |
| Reviewed by Mark Rowe. |
| |
| https://bugs.webkit.org/show_bug.cgi?id=30470 |
| Make marking a bug as duplicate easier |
| |
| * js/field.js: (setResolutionToDuplicate): Show edit field right away, don't make the user |
| click again. |
| |
| 2009-09-09 David Kilzer <ddkilzer@apple.com> |
| |
| Update data/params parameters |
| |
| * data/params: Updated 'attachment_base' parameter for secure |
| attachments. Updated 'mybugstemplate' parameter to search for |
| bugs in UNCONFIRMED, ASSIGNED and REOPENED status in addition to |
| NEW status. |
| |
| 2009-08-11 David Kilzer <ddkilzer@apple.com> |
| |
| Updated data/params parameter |
| |
| * data/params: Updated 'loginnetmask' parameter to allow users |
| to choose whether their cookies are restricted to a single IP |
| address or not. |
| |
| 2009-07-07 David Kilzer <ddkilzer@apple.com> |
| |
| Updated BugsSite with local changes on server |
| |
| The new files were created by checksetup.pl during the upgrade |
| to Bugzilla 3.2.3. The rest are self-explanatory. |
| |
| * data: Added "bugzilla-update.xml" to svn:ignore. |
| * data/attachments: Added "groups.*" to svn:ignore. |
| * data/params: Updated for a few changed parameters. |
| |
| * lib/.htaccess: Added. |
| * skins/contrib/Dusk/IE-fixes.css: Added. |
| * skins/contrib/Dusk/admin.css: Added. |
| * skins/contrib/Dusk/create_attachment.css: Added. |
| * skins/contrib/Dusk/dependency-tree.css: Added. |
| * skins/contrib/Dusk/duplicates.css: Added. |
| * skins/contrib/Dusk/editusers.css: Added. |
| * skins/contrib/Dusk/help.css: Added. |
| * skins/contrib/Dusk/index.css: Added. |
| * skins/contrib/Dusk/panel.css: Added. |
| * skins/contrib/Dusk/params.css: Added. |
| * skins/contrib/Dusk/release-notes.css: Added. |
| * skins/contrib/Dusk/show_bug.css: Added. |
| * skins/contrib/Dusk/show_multiple.css: Added. |
| * skins/contrib/Dusk/summarize-time.css: Added. |
| * skins/contrib/Dusk/voting.css: Added. |
| * skins/contrib/Dusk/yui: Added. |
| * skins/contrib/Dusk/yui/calendar.css: Added. |
| * skins/custom/IE-fixes.css: Added. |
| * skins/custom/admin.css: Added. |
| * skins/custom/buglist.css: Added. |
| * skins/custom/create_attachment.css: Added. |
| * skins/custom/dependency-tree.css: Added. |
| * skins/custom/duplicates.css: Added. |
| * skins/custom/editusers.css: Added. |
| * skins/custom/help.css: Added. |
| * skins/custom/panel.css: Added. |
| * skins/custom/params.css: Added. |
| * skins/custom/release-notes.css: Added. |
| * skins/custom/show_bug.css: Added. |
| * skins/custom/show_multiple.css: Added. |
| * skins/custom/summarize-time.css: Added. |
| * skins/custom/voting.css: Added. |
| * skins/custom/yui: Added. |
| * skins/custom/yui/calendar.css: Added. |
| |
| 2009-07-03 David Kilzer <ddkilzer@apple.com> |
| |
| Bug 26958: Change edit link to review link in request messages |
| |
| <https://bugs.webkit.org/show_bug.cgi?id=26958> |
| |
| Reviewed by Dan Bernstein. |
| |
| * template/en/custom/request/email.txt.tmpl: Copied from BugsSite/template/en/default/request/email.txt.tmpl. |
| Changed link from "action=edit" to "action=review". |
| |
| 2009-07-03 David Kilzer <ddkilzer@apple.com> |
| |
| Bug 26950: Make the summary and alias fields support click-to-edit |
| <https://bugs.webkit.org/show_bug.cgi?id=26950> |
| |
| Reviewed by Maciej Stachowiak. |
| |
| Original patch by Maciej Stachowiak. |
| |
| * js/field.js: |
| (hideEditableField): Updated to add click event listeners to the |
| alias and short description elements to make them easier to |
| edit. Renamed field_id parameter to field2_id (short |
| description id) and added a field1_id parameter (alias id). |
| (showEditableField): If a third parameter is passed in the |
| ContainerInputArray parameter, use it to find the element to |
| focus. Otherwise, fall back to the original behavior of |
| focusing the first input field. |
| (hideAliasAndSummary): Changed to pass the id for the alias |
| element to hideEditableField(). |
| |
| 2009-07-02 David D. Kilzer <ddkilzer@apple.com> |
| |
| Config file for contrib/recode.pl when upgrading bugs.webkit.org |
| |
| Current as of midday on Wednesday, July 1, 2009. |
| |
| * contrib/recode-overrides.txt: Added. |
| |
| 2009-07-02 David D. Kilzer <ddkilzer@apple.com> |
| |
| Workaround for WebKit Bug 9630 when running contrib/recode.pl |
| |
| A number of WebKit nightly builds included Bug 9630 which caused |
| non-breaking space characters (0xA0) to be submitted within the |
| content of textarea elements. |
| |
| * contrib/recode.pl: To work around these 0xA0 characters, try |
| an encoding of cp1252 and use it if it works. |
| |
| 2009-07-02 David D. Kilzer <ddkilzer@apple.com> |
| |
| Don't print "Failed to guess" warning if an override is available |
| |
| * contrib/recode.pl: Check that %overrides does NOT contain a |
| key matching the current digest before printing out the warning |
| about a failed charset guess. |
| |
| 2009-07-02 David D. Kilzer <ddkilzer@apple.com> |
| |
| Added --[no-]truncate switch to contrib/recode.pl |
| |
| * contrib/recode.pl: Added --[no-]truncate switch to make |
| debugging of failed charset guessing easier. Often times the |
| illegal character was truncated in the output. |
| |
| 2009-07-02 David D. Kilzer <ddkilzer@apple.com> |
| |
| Changed Perl scripts to use #!/usr/bin/env perl |
| |
| perl -pi -e 's@#\!/usr/bin/perl@#\!/usr/bin/env perl@' *.cgi *.pl */*.pl |
| |
| 2009-07-02 David D. Kilzer <ddkilzer@apple.com> |
| |
| Replace Bugzilla favicon with webkit.org favicon |
| |
| * favicon.ico: Removed. |
| * images/favicon.ico: Replaced. Copied from favicon.ico. |
| |
| 2009-07-02 David Kilzer <ddkilzer@webkit.org> |
| |
| Merged BugsSite to Bugzilla-3.2.3 |
| |
| Updated to the latest-and-greatest stable version. |
| |
| 2009-07-02 David Kilzer <ddkilzer@webkit.org> |
| |
| Merged BugsSite to Bugzilla-3.0.3 |
| |
| Nothing to see here. Move along. |
| |
| 2009-06-09 Eric Seidel <eric@webkit.org> |
| |
| Reviewed by Adam Roben. |
| |
| Add support for displaying added png files in PrettyPatch diffs |
| https://bugs.webkit.org/show_bug.cgi?id=26210 |
| |
| Currently this is SVN only (git-send-bugzilla patches exclude binary data) |
| and only works for PNG files but could easily be made to work for other images as needed. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2009-05-19 Eric Seidel <eric@webkit.org> |
| |
| Reviewed by Adam Roben. |
| |
| Make PrettyPatch understand quoted filenames in git diffs. |
| https://bugs.webkit.org/show_bug.cgi?id=25881 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2009-05-15 Simon Fraser <simon.fraser@apple.com> |
| |
| Carrying forwards Darin Adler's rubber stamp |
| |
| Make the comment field wider too. |
| |
| * skins/custom/global.css: |
| |
| 2009-05-14 Simon Fraser <simon.fraser@apple.com> |
| |
| Reviewed by Darin Adler |
| |
| Make the URL, Summary and Keyword fields wider to mitigate the |
| effects of https://bugs.webkit.org/show_bug.cgi?id=25566 and make |
| things generally better. |
| |
| * skins/custom/global.css: |
| * template/en/custom/bug/edit.html.tmpl: |
| |
| 2008-11-10 Darin Adler <darin@apple.com> |
| |
| - fix more of https://bugs.webkit.org/show_bug.cgi?id=21400 |
| "Edit" links for patches in comments, review queue, review emails |
| should be replaced by "Review Patch" links |
| |
| * globals.pl: Fix cases that are automatically generated, such as links |
| in comments in bugs. |
| |
| * template/en/custom/attachment/created.html.tmpl: Fix the link on the |
| "I just created an attachment" page. |
| |
| * template/en/custom/request/queue.html.tmpl: Fix the link in the queue |
| page. |
| |
| 2008-11-10 Darin Adler <darin@apple.com> |
| |
| * template/en/default/request/queue.html.tmpl: Use review links instead |
| of edit links in the review queue. |
| |
| 2008-11-10 Darin Adler <darin@apple.com> |
| |
| * template/en/custom/request/email.txt.tmpl: Send review links instead |
| of edit links when flags are set on a bug. |
| |
| 2008-10-27 Darin Adler <darin@apple.com> |
| |
| * template/en/custom/attachment/reviewform.html.tmpl: Leave out the |
| comment if it's untouched. |
| |
| 2008-10-23 Adam Roben <aroben@apple.com> |
| |
| Fix Bug 21401: Comments field on "Review Patch" page should be |
| initially filled with quoted patch |
| |
| <https://bugs.webkit.org/show_bug.cgi?id=21401> |
| |
| Reviewed by Dave Hyatt. |
| |
| * attachment.cgi: |
| (edit): Retrieve the attachment data from the database instead of just |
| its length. When the attachment is a patch, create a quotedpatch |
| template variable that contains the patch data with each line |
| prepended with "> ". |
| * template/en/custom/attachment/reviewform.html.tmpl: |
| - Changed the comments field to have a monospace font |
| - Added an "Enter comments below:" caption above the comments field |
| to make it clearer that this is where comments should go, now that |
| the comments field is not initially empty |
| - Fill the comments field with the quoted patch |
| |
| 2008-10-14 Adam Roben <aroben@apple.com> |
| |
| Fix Bug 21602: Bugzilla times out trying to display formatted diff for |
| attachment 24345 |
| |
| https://bugs.webkit.org/show_bug.cgi?id=21602 |
| |
| Reviewed by Dave Kilzer. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| (PrettyPatch.BINARY_FILE_MARKER_FORMAT): Added. |
| (PrettyPatch.FileDiff.initialize): If any of the lines in the diff |
| are a binary file marker, mark this FileDiff as binary and stop trying |
| to process the lines. |
| (PrettyDiff.FileDiff.to_html): If we're binary, just print a string |
| saying so. |
| |
| 2008-10-02 Adam Roben <aroben@apple.com> |
| |
| * template/en/custom/attachment/reviewform.html.tmpl: Fix typo. |
| |
| 2008-10-02 Adam Roben <aroben@apple.com> |
| |
| * template/en/custom/attachment/review.html.tmpl: Fix URLs |
| |
| 2008-10-02 Adam Roben <aroben@apple.com> |
| |
| Fix Bug 21315: bugs.webkit.org should have a nicer patch review |
| interface |
| |
| https://bugs.webkit.org/show_bug.cgi?id=21315 |
| |
| Reviewed by Tim Hatcher. |
| |
| * attachment.cgi: |
| (top level): Added support for the "review" and "reviewform" actions. |
| (sub edit): Accept the template name as a parameter. If no name is |
| give, use "edit" as before. |
| * template/en/custom/attachment/list.html.tmpl: Added a "Review Patch" |
| link for all patch attachments. |
| * template/en/custom/attachment/review.html.tmpl: Added. Simple |
| <frameset> page to show the patch on the top and a comment form on the |
| bottom. |
| * template/en/custom/attachment/reviewform.html.tmpl: Added. Simple |
| comment form for reviewing patches. |
| |
| 2008-10-02 Adam Roben <aroben@apple.com> |
| |
| Remove references to some backup files I created when implementing |
| PrettyPatch in Bugzilla |
| |
| Reviewed by Tim Hatcher. |
| |
| * attachment-aroben.cgi: Removed. |
| * template/en/default/attachment/edit-aroben.html.tmpl: Removed. |
| |
| * template/en/custom/attachment/edit.html.tmpl: Removed an erroneous |
| reference to attachment-aroben.cgi. attachment.cgi will work just |
| fine. |
| |
| 2008-06-25 David Kilzer <ddkilzer@apple.com> |
| |
| Make PrettyPatch handle diffs with no Index or diff headers |
| |
| Part of Bug 19290: More patches not handled by PrettyPatch.rb |
| <https://bugs.webkit.org/show_bug.cgi?id=19290> |
| |
| Reviewed by Adam. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| (PrettyPatch.DIFF_HEADER_FORMATS): Added regular expression to |
| match on "+++ " lines for patches with no "Index" or "diff" header. |
| (PrettyPatch.FileDiff.initialize): Look for filename on "+++ " line |
| when the first line of a patch has no "Index" or "diff" header. |
| (PrettyPatch.FileDiff.parse): Added haveSeenDiffHeader state |
| variable to determine when no "Index" or "diff" header has been |
| found, but a new patch has started with a "--- " line. |
| |
| 2008-06-08 Dan Bernstein <mitz@apple.com> |
| |
| Reviewed by Adam Roben. |
| |
| - update trac URL in PrettyPatch |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2008-05-29 Adam Roben <aroben@apple.com> |
| |
| Update PrettyPatch directory list |
| |
| * PrettyPatch/PrettyPatch.rb: |
| |
| 2008-05-28 Adam Roben <aroben@apple.com> |
| |
| Make PrettyPatch able to handle diffs taken from outside the WebKit |
| source tree |
| |
| Part of Bug 19290: More patches not handled by PrettyPatch.rb |
| <https://bugs.webkit.org/show_bug.cgi?id=19290> |
| |
| Reviewed by David Kilzer. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| (PrettyPatch.find_url_and_path): Added. Searches the file path from |
| the bottom up looking for a directory that exists in the source tree. |
| (PrettyPatch.linkifyFilename): Changed to call find_url_and_path. |
| |
| 2008-05-28 Adam Roben <aroben@apple.com> |
| |
| Print exceptions from PrettyPatch to stdout |
| |
| This will make it much easier to debug problems with PrettyPatch, |
| since we'll be able to see the exceptions in the browser. |
| |
| Reviewed by Sam Weinig. |
| |
| * PrettyPatch/prettify.rb: Added a --html-exceptions option, which |
| will print exceptions to stdout as HTML. |
| * attachment.cgi: Changed to pass --html-exceptions to prettify.rb. |
| |
| 2008-04-26 David Kilzer <ddkilzer@apple.com> |
| |
| Removed temp files and added appropriate svn:ignore properties. |
| |
| Rubber-stamped by Mark Rowe. |
| |
| * data: Added svn:ignore property for "versioncache" and "versioncache.*" files. |
| |
| * data/template: Added svn:ignore property for "template" subdirectory. |
| * data/template/template: Removed precompiled template subdirectory. |
| |
| * data/versioncache: Removed. |
| * data/versioncache.*: Removed backup versioncache files. |
| |
| * data/webdot: Added svn:ignore property for "*.dot" files. |
| * data/webdot/*.dot: Removed cached webdot files. |
| |
| 2008-04-08 Adam Roben <aroben@apple.com> |
| |
| Combine :equal operations with the following operation if they are |
| fewer than 3 characters long |
| |
| This keeps us from showing lots of small changes on long lines, just |
| because some letters happened to be the same. |
| |
| Inspired by |
| http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/diffviewer/diffutils.py?r=1264#147 |
| |
| * PrettyPatch/PrettyPatch.rb: |
| (PrettyPatch::DiffSection.initialize): Remove :equal operations fewer |
| than 3 characters long. The characters from the removed operations |
| become part of the subsequent operation. |
| (PrettyPatch::CodeLine.text_as_html): Don't wrap 0-length strings in |
| <ins>/<del> tags. Also removed the @fromLineNumber.nil? and |
| @toLineNumber.nil? checks as they are no longer reliable now that |
| we're removing operations. |
| |
| 2008-04-08 Adam Roben <aroben@apple.com> |
| |
| Change PrettyPatch to use DiffBuilder for intra-line diffs |
| |
| This gives us much prettier intra-line diffs, largely because it can |
| distinguish multiple changes on the same line. e.g., if a line changes |
| from: |
| |
| const int myConstant = 0; |
| |
| to |
| |
| static const unsigned myConstant; |
| |
| You will see that "static " was inserted, "int" changed to "unsigned", |
| and " = 0" was deleted. |
| |
| This seems to have also gotten rid of some spurious instances of |
| "<ins></ins>" and "<del></del>" at the end of a line. |
| |
| * PrettyPatch/PrettyPatch.rb: |
| (PrettyPatch::DiffSection.initialize): Use DiffBuilder instead of |
| setChangeExtentFromLine (which had been copied from Trac's diffing |
| code). |
| (PrettyPatch::CodeLine): |
| - Removed the changeExtent attribute |
| - Added the operations attribute |
| - Removed the setChangeExtentFromLine method |
| (PrettyPatch::CodeLine.text_as_html): Uses @operations to determine |
| what text to wrap in <ins> and <del> tags. |
| * PrettyPatch/diff.rb: Deleted a bunch of code we don't use. |
| (HTMLDiff::DiffBuilder.initialize): Moved code here from the old build |
| method, but left out the calls to perform_operation, since we build |
| the diff HTML outside of this class. |
| (HTMLDiff::DiffBuilder.split_inputs_to_words): Removed calls to |
| convert_html_to_list_of_words, since we're not diffing HTML. |
| |
| 2008-04-08 Adam Roben <aroben@apple.com> |
| |
| Check in diff.rb |
| |
| This came from |
| http://instiki.rubyforge.org/svn/instiki/trunk/lib/diff.rb |
| revision 28521 |
| |
| * PrettyPatch/diff.rb: Added. |
| |
| 2008-03-04 Adam Roben <aroben@apple.com> |
| |
| * PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to |
| be omitted from the hunk header. |
| |
