results.webkit.org: Increase default limit for test results
https://bugs.webkit.org/show_bug.cgi?id=202757
Rubber-stamped by Aakash Jain.
* resultsdbpy/resultsdbpy/controller/suite_controller.py:
(SuiteController): Increase DEFAULT_LIMIT.
* resultsdbpy/resultsdbpy/controller/test_controller.py:
(TestController): Ditto.
* resultsdbpy/resultsdbpy/view/static/js/commit.js:
(_CommitBank.prototype._load): Make commit shards larger.
* resultsdbpy/resultsdbpy/view/static/js/drawer.js: Increase default slider size.
* resultsdbpy/resultsdbpy/view/templates/commits.html: Keep smaller slider size.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@250924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index ce9322a..fef2576 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,19 @@
+2019-10-09 Jonathan Bedard <jbedard@apple.com>
+
+ results.webkit.org: Increase default limit for test results
+ https://bugs.webkit.org/show_bug.cgi?id=202757
+
+ Rubber-stamped by Aakash Jain.
+
+ * resultsdbpy/resultsdbpy/controller/suite_controller.py:
+ (SuiteController): Increase DEFAULT_LIMIT.
+ * resultsdbpy/resultsdbpy/controller/test_controller.py:
+ (TestController): Ditto.
+ * resultsdbpy/resultsdbpy/view/static/js/commit.js:
+ (_CommitBank.prototype._load): Make commit shards larger.
+ * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Increase default slider size.
+ * resultsdbpy/resultsdbpy/view/templates/commits.html: Keep smaller slider size.
+
2019-10-09 Dean Jackson <dino@apple.com>
Provide an alternate command-line flag for timeout in run-webkit-tests
diff --git a/Tools/resultsdbpy/resultsdbpy/controller/suite_controller.py b/Tools/resultsdbpy/resultsdbpy/controller/suite_controller.py
index 68e16e1..ac575b7 100644
--- a/Tools/resultsdbpy/resultsdbpy/controller/suite_controller.py
+++ b/Tools/resultsdbpy/resultsdbpy/controller/suite_controller.py
@@ -50,7 +50,7 @@
class SuiteController(HasCommitContext):
- DEFAULT_LIMIT = 100
+ DEFAULT_LIMIT = 5000
def __init__(self, suite_context):
super(SuiteController, self).__init__(suite_context.commit_context)
diff --git a/Tools/resultsdbpy/resultsdbpy/controller/test_controller.py b/Tools/resultsdbpy/resultsdbpy/controller/test_controller.py
index 1196a7e..a3b5b88 100644
--- a/Tools/resultsdbpy/resultsdbpy/controller/test_controller.py
+++ b/Tools/resultsdbpy/resultsdbpy/controller/test_controller.py
@@ -29,7 +29,7 @@
class TestController(HasCommitContext):
- DEFAULT_LIMIT = 100
+ DEFAULT_LIMIT = 5000
def __init__(self, test_context):
super(TestController, self).__init__(test_context.commit_context)
diff --git a/Tools/resultsdbpy/resultsdbpy/view/static/js/commit.js b/Tools/resultsdbpy/resultsdbpy/view/static/js/commit.js
index 3d1d1d2..480dc94 100644
--- a/Tools/resultsdbpy/resultsdbpy/view/static/js/commit.js
+++ b/Tools/resultsdbpy/resultsdbpy/view/static/js/commit.js
@@ -248,7 +248,7 @@
if (endUuid <= beginUuid)
return;
- const limit = 250;
+ const limit = 2500;
const query = paramsToQuery({
branch: [...this._branches],
limit: [limit],
diff --git a/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js b/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js
index f7ba0c9..8cfff79 100644
--- a/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js
+++ b/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js
@@ -191,7 +191,7 @@
</div>`;
}
-function LimitSlider(callback, max = 10000, defaultValue = 1000) {
+function LimitSlider(callback, max = 50000, defaultValue = 5000) {
const limitModifier = new QueryModifier('limit');
const startingValue = limitModifier.current().length ? limitModifier.current()[limitModifier.current().length -1]:defaultValue;
diff --git a/Tools/resultsdbpy/resultsdbpy/view/templates/commits.html b/Tools/resultsdbpy/resultsdbpy/view/templates/commits.html
index 6099f81..f74fc52 100644
--- a/Tools/resultsdbpy/resultsdbpy/view/templates/commits.html
+++ b/Tools/resultsdbpy/resultsdbpy/view/templates/commits.html
@@ -100,7 +100,7 @@
var table = new Table();
DOM.inject(document.getElementById('app'), `${Drawer([
- LimitSlider(() => {table.reload()}),
+ LimitSlider(() => {table.reload()}, 1000, 10000),
OneLineSwitch(),
BranchSelector(() => {table.reload()}),
])}
