Web Inspector: REGRESSION(r251227): Uncaught Exception: undefined is not an object (evaluating 'agent.enable')
https://bugs.webkit.org/show_bug.cgi?id=203208
Reviewed by Joseph Pecoraro.
* UserInterface/Controllers/AppController.js:
(WI.AppController.prototype.activateExtraDomains):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@251386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
index 50c8ba6..c03c401 100644
--- a/Source/WebInspectorUI/ChangeLog
+++ b/Source/WebInspectorUI/ChangeLog
@@ -1,3 +1,13 @@
+2019-10-21 Devin Rousso <drousso@apple.com>
+
+ Web Inspector: REGRESSION(r251227): Uncaught Exception: undefined is not an object (evaluating 'agent.enable')
+ https://bugs.webkit.org/show_bug.cgi?id=203208
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Controllers/AppController.js:
+ (WI.AppController.prototype.activateExtraDomains):
+
2019-10-21 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: Provide a flag for technology preview builds
diff --git a/Source/WebInspectorUI/UserInterface/Controllers/AppController.js b/Source/WebInspectorUI/UserInterface/Controllers/AppController.js
index b0f1250..26ea305 100644
--- a/Source/WebInspectorUI/UserInterface/Controllers/AppController.js
+++ b/Source/WebInspectorUI/UserInterface/Controllers/AppController.js
@@ -72,17 +72,18 @@
console.assert(WI.sharedApp.debuggableType === WI.DebuggableType.JavaScript);
console.assert(WI.targets.length === 1);
- for (let domain of domains) {
- let agent = InspectorBackend.activateDomain(domain);
+ let target = WI.mainTarget;
- for (let target of WI.targets)
- target.activateExtraDomain(domain);
+ for (let domain of domains) {
+ InspectorBackend.activateDomain(domain);
+
+ target.activateExtraDomain(domain);
let manager = WI.managers.find((manager) => manager.domains && manager.domains.includes(domain));
if (manager)
manager.activateExtraDomain(domain);
- else if (agent.enable)
- agent.enable();
+ else if (target.hasCommand(domain + ".enable"))
+ target._agents[domain].enable();
}
// FIXME: all code within WI.activateExtraDomains should be distributed elsewhere.
