Drop support for NSURLCache callbacks in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=203344
Patch by Benjamin Nham <nham@apple.com> on 2019-12-06
Reviewed by Alex Christensen.
Remove the NSURLSession caching policy callback in NetworkProcess. It's no longer necessary since
we don't use NSURLCache in NetworkProcess (https://bugs.webkit.org/show_bug.cgi?id=185990).
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:dataTask:willCacheResponse:completionHandler:]): Deleted.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@253212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
index 282ed1b..0d858cd 100644
--- a/Source/WebKit/ChangeLog
+++ b/Source/WebKit/ChangeLog
@@ -1,3 +1,16 @@
+2019-12-06 Benjamin Nham <nham@apple.com>
+
+ Drop support for NSURLCache callbacks in NetworkProcess
+ https://bugs.webkit.org/show_bug.cgi?id=203344
+
+ Reviewed by Alex Christensen.
+
+ Remove the NSURLSession caching policy callback in NetworkProcess. It's no longer necessary since
+ we don't use NSURLCache in NetworkProcess (https://bugs.webkit.org/show_bug.cgi?id=185990).
+
+ * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+ (-[WKNetworkSessionDelegate URLSession:dataTask:willCacheResponse:completionHandler:]): Deleted.
+
2019-12-05 Chris Dumez <cdumez@apple.com>
Stop using reserveCapacity() / reserveInitialCapacity() in IPC decoders
diff --git a/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm b/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
index 3a5bd20..c2aa6f0 100644
--- a/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
+++ b/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
@@ -594,16 +594,6 @@
}
}
-- (void)URLSession:(NSURLSession *)session dataTask:(NSURLSessionDataTask *)dataTask willCacheResponse:(NSCachedURLResponse *)proposedResponse completionHandler:(void (^)(NSCachedURLResponse *cachedResponse))completionHandler
-{
- // FIXME: remove if <rdar://problem/20001985> is ever resolved.
- if ([proposedResponse.response respondsToSelector:@selector(allHeaderFields)]
- && [[(id)proposedResponse.response allHeaderFields] objectForKey:@"Content-Range"])
- completionHandler(nil);
- else
- completionHandler(proposedResponse);
-}
-
#if HAVE(CFNETWORK_NSURLSESSION_STRICTRUSTEVALUATE)
static inline void processServerTrustEvaluation(NetworkSessionCocoa *session, SessionWrapper& sessionWrapper, NSURLAuthenticationChallenge *challenge, NetworkDataTaskCocoa::TaskIdentifier taskIdentifier, NetworkDataTaskCocoa* networkDataTask, CompletionHandler<void(NSURLSessionAuthChallengeDisposition disposition, NSURLCredential *credential)>&& completionHandler)
{
