| 2013-10-14 Samuel White <samuel_white@apple.com> |
| |
| AX: fieldset should have GroupRole and legend should be description. |
| https://bugs.webkit.org/show_bug.cgi?id=122534 |
| |
| Reviewed by Chris Fleizach. |
| |
| Changes fieldset to derive AXDescription from legend if one is available. Added |
| convenience method to AccessibilityObject to fetch element if available. |
| |
| Test: accessibility/fieldset-element.html |
| |
| * accessibility/AccessibilityNodeObject.cpp: |
| (WebCore::AccessibilityNodeObject::canHaveChildren): |
| (WebCore::AccessibilityNodeObject::alternativeText): |
| * accessibility/AccessibilityObject.cpp: |
| (WebCore::AccessibilityObject::element): |
| (WebCore::AccessibilityObject::isARIAHidden): |
| (WebCore::AccessibilityObject::isDOMHidden): |
| (WebCore::AccessibilityObject::defaultObjectInclusion): |
| * accessibility/AccessibilityObject.h: |
| (WebCore::AccessibilityObject::isHidden): |
| * accessibility/AccessibilitySlider.cpp: |
| (WebCore::AccessibilitySlider::getAttribute): |
| (WebCore::AccessibilitySlider::valueForRange): |
| (WebCore::AccessibilitySlider::maxValueForRange): |
| (WebCore::AccessibilitySlider::minValueForRange): |
| (WebCore::AccessibilitySlider::setValue): |
| (WebCore::AccessibilitySlider::inputElement): |
| * accessibility/AccessibilitySlider.h: |
| * accessibility/mac/AccessibilityObjectMac.mm: |
| (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): |
| * html/HTMLFieldSetElement.cpp: |
| (WebCore::HTMLFieldSetElement::legend): |
| * html/HTMLFieldSetElement.h: |
| |
| 2013-10-14 Roger Fong <roger_fong@apple.com> |
| |
| [Windows] Unreviewed build fix. |
| |
| * WebCore.vcxproj/WebCoreCommon.props: |
| |
| 2013-10-14 Ryosuke Niwa <rniwa@webkit.org> |
| |
| Crash in WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>::createBidiRunsForLine |
| https://bugs.webkit.org/show_bug.cgi?id=122776 |
| |
| Reviewed by Darin Adler. |
| |
| Merge https://chromium.googlesource.com/chromium/blink/+/aca89bc4d984705a1f94b623dae0ab03e239a248 |
| |
| Fix modification of whitespace endpoints to not assume it's operating on RenderTexts |
| |
| During line layout, we use midpoints to identify RenderObjects, or parts of |
| RenderObjects, that don't need InlineBoxes, usually because of collapsed whitespace. |
| |
| Prior to actually creating BidiRuns (the precursor to InlineBoxes), we use |
| checkMidpoints to fix up our lineMidpointState to handle the case where we start |
| ignoring spaces in our line, but don't stop until somewhere on the following line. |
| Previously, this function assumed that the final midpoint (called an endpoint) |
| was a RenderText, but this assumption is wrong if we have a beginning midpoint |
| created by shouldSkipWhitespaceAfterStartObject (which handles inlines and list |
| markers) and no endpoint on that line. In that case, we'd instead adjust the |
| position backwards on the beginning midpoint, which would cause us to fail to |
| create an InlineBox for the inline or list marker. In the new test added, this |
| would actually trigger a crash due to an assumption when visually re-ordering |
| BidiRuns that a non-empty line would actually contain at least one such run. |
| |
| Test: fast/text/whitespace/whitespace-and-margin-wrap-after-list-marker-crash.html |
| |
| * rendering/RenderBlockLineLayout.cpp: |
| (WebCore::checkMidpoints): |
| |
| 2013-10-14 Ryosuke Niwa <rniwa@webkit.org> |
| |
| Assertion failure in Range::processContentsBetweenOffsets |
| https://bugs.webkit.org/show_bug.cgi?id=122777 |
| |
| Reviewed by Darin Adler. |
| |
| Merge https://chromium.googlesource.com/chromium/blink/+/c15de182774c7859c20d97126eb844ae97b792a4 |
| |
| This patch changes ASSERT statements for checking |endOffset| inbound in Range::processContentsBetweenOffsets() |
| to limit |endOffset|. This is necessary when DOMNodeRemovedFromDocument event handler splits text nodes, |
| Range::insertNode() on text node, in the range calling Range::deleteContents(). |
| |
| Test: fast/dom/Range/range-delete-contents-mutation-event-crash.html |
| |
| * dom/Range.cpp: |
| (WebCore::Range::processContentsBetweenOffsets): |
| |
| 2013-10-14 Alexey Proskuryakov <ap@apple.com> |
| |
| Add an empty window.crypto.webkitSubtle |
| https://bugs.webkit.org/show_bug.cgi?id=122778 |
| |
| Reviewed by Mark Hahnenberg. |
| |
| Tests: security/crypto-subtle-gc-2.html |
| security/crypto-subtle-gc-3.html |
| security/crypto-subtle-gc.html |
| |
| * DerivedSources.make: Process SubtleCrypto.idl. |
| |
| * crypto: Added. |
| * WebCore.xcodeproj/project.pbxproj: |
| * CMakeLists.txt: |
| * DerivedSources.make: |
| * GNUmakefile.am: |
| * GNUmakefile.list.am: |
| * WebCore.vcxproj/WebCore.vcxproj.filters: |
| |
| * bindings/js/JSSubtleCryptoCustom.cpp: Added. Empty for now, but we'll certainly |
| need custom bindings code here. |
| |
| * crypto/SubtleCrypto.cpp: Added. |
| (WebCore::SubtleCrypto::SubtleCrypto): |
| (WebCore::SubtleCrypto::document): |
| * crypto/SubtleCrypto.h: Added. |
| * crypto/SubtleCrypto.idl: Added. |
| * page/Crypto.cpp: |
| (WebCore::Crypto::subtle): |
| * page/Crypto.h: |
| * page/Crypto.idl: |
| |
| 2013-10-14 Nick Diego Yamane <nick.yamane@openbossa.org> |
| |
| Remove GestureEvent leftovers from WebCore |
| <https://webkit.org/b/122780> |
| |
| Reviewed by Anders Carlsson. |
| |
| - Removed some remaining references to PlatformGestureEvent, supposed to |
| be removed by r157316 |
| - TOUCH_ADJUSTMENT should be reworked after GestureEvent feature |
| removal |
| |
| * page/EventHandler.cpp: |
| (WebCore::EventHandler::bestZoomableAreaForTouchPoint): |
| * page/EventHandler.h: |
| * platform/PlatformEvent.h: |
| * platform/ScrollAnimatorNone.cpp: |
| * platform/ScrollableArea.h: |
| |
| 2013-10-14 Nick Diego Yamane <nick.yamane@openbossa.org> |
| |
| Build fix after r157366 |
| http://bugs.webkit.org/show_bug.cgi?id=122783 |
| |
| When TOUCH_AJUSTMENT is enabled build fails due to some |
| refactors in TextRender functions. |
| |
| Reviewed by Anders Carlsson. |
| |
| * page/TouchAdjustment.cpp: |
| (WebCore::TouchAdjustment::appendContextSubtargetsForNode): |
| |
| 2013-10-14 Alexandru Chiculita <achicu@adobe.com> |
| |
| The content of the DOM panel for iframes is not updated until the "onload" event |
| https://bugs.webkit.org/show_bug.cgi?id=122653 |
| |
| Reviewed by Darin Adler. |
| |
| Test: http/tests/inspector-protocol/loading-iframe-document-node.html |
| |
| Renamed InspectorDOMAgent::loadEventFired to InspectorDOMAgent::didCommitLoad and moved the call site |
| from InspectorInstrumentation::loadEventFiredImpl to InspectorInstrumentation::didCommitLoadImpl. |
| This is to make sure that it will invalidate the content of the iframe as soon as the frame navigates |
| to a different page. This way the new node can be retrieved as soon as the page has some content, and |
| not just when the page is fully loaded. |
| |
| * inspector/InspectorDOMAgent.cpp: |
| (WebCore::InspectorDOMAgent::didCommitLoad): Renamed from loadEventFired, as it is now called from |
| didCommitLoadImpl instead. |
| (WebCore::InspectorDOMAgent::frameDocumentUpdated): Updated comment to point to the new function name. |
| * inspector/InspectorDOMAgent.h: |
| * inspector/InspectorInstrumentation.cpp: |
| (WebCore::InspectorInstrumentation::loadEventFiredImpl): Removed call do InspectorDOMAgent.loadEventFired. |
| (WebCore::InspectorInstrumentation::didCommitLoadImpl): Added call to InspectorDOMAgent.didCommitLoad. |
| |
| 2013-10-14 Roger Fong <roger_fong@apple.com> |
| |
| https://bugs.webkit.org/show_bug.cgi?id=122774. |
| <rdar://problem/6138855>. |
| |
| Reviewed by Brent Fulgham. |
| |
| Add a field to keep track of hovered over index. |
| Use index to determine whether or not to use the existing selected index on the mouse down event. |
| |
| * platform/win/PopupMenuWin.cpp: |
| (WebCore::PopupMenuWin::PopupMenuWin): |
| (WebCore::PopupMenuWin::show): |
| (WebCore::PopupMenuWin::wndProc): |
| * platform/win/PopupMenuWin.h: |
| |
| 2013-10-14 Tim Horton <timothy_horton@apple.com> |
| |
| Virtualize PlatformCALayer |
| https://bugs.webkit.org/show_bug.cgi?id=122672 |
| |
| Reviewed by Anders Carlsson. |
| |
| No new tests, just a refactoring. |
| |
| * WebCore.exp.in: |
| setGeometryFlipped is on PlatformCALayerMac now. |
| |
| * WebCore.vcxproj/WebCore.vcxproj: |
| * WebCore.vcxproj/WebCore.vcxproj.filters: |
| Add PlatformCALayer.cpp, PlatformCALayerWin.h, and let VS do its |
| thing with some other files. |
| |
| * WebCore.xcodeproj/project.pbxproj: |
| Add PlatformCALayer.cpp and PlatformCALayerMac.h. |
| |
| * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: |
| (WebCore::AVFWrapper::platformLayer): |
| Make a PlatformCALayerWin explicitly. |
| |
| * platform/graphics/ca/GraphicsLayerCA.cpp: |
| (WebCore::GraphicsLayerCA::createPlatformCALayer): |
| Added. Decide whether to make a PlatformCALayer{Mac, Win} based on the platform. |
| Later, we will decide between other subclasses based on other things. |
| |
| (WebCore::GraphicsLayerCA::filtersCanBeComposited): |
| Do the same thing for filtersCanBeComposited. |
| |
| (WebCore::GraphicsLayerCA::GraphicsLayerCA): |
| (WebCore::GraphicsLayerCA::setContentsToSolidColor): |
| (WebCore::GraphicsLayerCA::setContentsToMedia): |
| (WebCore::GraphicsLayerCA::setContentsToCanvas): |
| (WebCore::GraphicsLayerCA::recursiveCommitChanges): |
| (WebCore::GraphicsLayerCA::ensureStructuralLayer): |
| (WebCore::GraphicsLayerCA::updateContentsImage): |
| (WebCore::GraphicsLayerCA::updateContentsRects): |
| (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): |
| Use createPlatformCALayer instead of PlatformCALayer::create. |
| |
| * platform/graphics/ca/mac/PlatformCAFiltersMac.mm: |
| For now, use the PlatformCALayerMac version of filtersCanBeComposited, |
| since this code is heavily tied to having CALayers in the Web process. |
| |
| * platform/graphics/ca/GraphicsLayerCA.h: |
| Include PlatformCALayer.h here so we can get the LayerType enum. |
| (NOTE-to-be-removed: if there's a better way to do this, I'm open to |
| suggestions; I couldn't puzzle out nested 'enum class' stuff). |
| |
| Add the createPlatformCALayers. |
| |
| * platform/graphics/ca/PlatformCAAnimation.h: |
| Friend the subclasses too. |
| |
| * platform/graphics/ca/PlatformCALayer.cpp: Added. |
| (WebCore::PlatformCALayer::~PlatformCALayer): |
| Pull the shared part of the PlatformCALayer destructor out. |
| |
| * platform/graphics/ca/PlatformCALayer.h: |
| (WebCore::PlatformCALayer::platformLayer): |
| (WebCore::PlatformCALayer::setOwner): |
| (WebCore::PlatformCALayer::PlatformCALayer): |
| Virtualize all the things. Move platform specific members to their new subclasses. |
| |
| * platform/graphics/ca/mac/PlatformCALayerMac.h: Added. |
| * platform/graphics/ca/mac/PlatformCALayerMac.mm: |
| Move the PLATFORM(MAC) implementations from PlatformCALayer to PlatformCALayerMac. |
| |
| (PlatformCALayer::platformCALayer): |
| The platformCALayer lookup function is static on PlatformCALayer, so it can't |
| be moved to the subclasses. It might be a good idea in the future to move towards |
| a platform-independent mechanism for looking up PlatformCALayers from PlatformLayers, |
| and to avoid needing to do this as often as we do now. |
| |
| * platform/graphics/ca/win/CACFLayerTreeHost.cpp: |
| (WebCore::CACFLayerTreeHost::CACFLayerTreeHost): |
| * platform/graphics/ca/win/PlatformCALayerWin.cpp: |
| Move the PLATFORM(WIN) implementations from PlatformCALayer to PlatformCALayerWin. |
| |
| (PlatformCALayerWin::create): |
| (PlatformCALayer::platformCALayer): |
| |
| * platform/graphics/ca/win/PlatformCALayerWin.h: Added. |
| |
| * platform/graphics/win/GraphicsContext3DWin.cpp: |
| (WebCore::GraphicsContext3D::GraphicsContext3D): |
| * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: |
| (WebCore::MediaPlayerPrivateQuickTimeVisualContext::createLayerForMovie): |
| Include PlatformCALayerWin.h and explicitly make PlatformCALayerWins here. |
| |
| 2013-10-14 Hugo Parente Lima <hugo.lima@openbossa.org> |
| |
| [cmake] MediaControlsApple is used only by Efl port and is on CMakeLists.txt |
| https://bugs.webkit.org/show_bug.cgi?id=122772 |
| |
| Reviewed by Anders Carlsson. |
| |
| * CMakeLists.txt: Removed MediaControlsApple.cpp |
| * PlatformEfl.cmake: Added MediaControlsApple.cpp |
| |
| 2013-10-14 Alexey Proskuryakov <ap@apple.com> |
| |
| window.crypto doesn't preserve custom properties |
| https://bugs.webkit.org/show_bug.cgi?id=122770 |
| |
| Reviewed by Mark Hahnenberg. |
| |
| Test: security/crypto-gc.html |
| |
| Generate isReachableFromOpaqueRoots that makes Crypto live as long as the document |
| lives (because that's when it's observable through window object). |
| |
| * page/Crypto.cpp: |
| (WebCore::Crypto::Crypto): |
| (WebCore::Crypto::~Crypto): |
| (WebCore::Crypto::document): |
| * page/Crypto.h: |
| (WebCore::Crypto::create): |
| Made Crypto a ContextDestructionObserver, so that it can report its document to bindings. |
| Removed ScriptWrappable, because it seems to have served no purpose in this class. |
| |
| * page/Crypto.idl: Added GenerateIsReachable. Removed ImplementationLacksVTable, |
| because the class now has a vtable, and can be checked for bindings integrity. |
| |
| * page/DOMWindow.cpp: (WebCore::DOMWindow::crypto): Pass a document when creating |
| crypto. |
| |
| 2013-10-14 Andreas Kling <akling@apple.com> |
| |
| CTTE: NamedNodeMap always has a corresponding Element. |
| <https://webkit.org/b/122769> |
| |
| Reviewed by Anders Carlsson. |
| |
| Made NamedNodeMap::m_element a reference and remove an assertion |
| that it's never null. |
| |
| 2013-10-14 Andreas Kling <akling@apple.com> |
| |
| REGRESSION(r157408): Crashes in RenderFullScreen::wrapRenderer(). |
| |
| Unreviewed crash fix for these two tests: |
| |
| - fullscreen/full-screen-restrictions.html |
| - fullscreen/empty-anonymous-block-continuation-crash.html |
| |
| * rendering/RenderFullScreen.cpp: |
| (RenderFullScreen::wrapRenderer): |
| |
| Get the RenderArena from Document like we did before this patch. |
| |
| 2013-10-14 Hans Muller <hmuller@adobe.com> |
| |
| [CSS Shapes] Image valued shape-outside shapes should update the layout after the image has been loaded |
| https://bugs.webkit.org/show_bug.cgi?id=122340 |
| |
| Reviewed by Simon Fraser. |
| |
| Ensure that the an image-valued shape-outside layout is updated after the image has |
| been loaded. |
| |
| Test: http/tests/css/css-image-valued-shape.html |
| |
| * rendering/RenderBlock.cpp: |
| (WebCore::RenderBlock::imageChanged): Added code for the shape-outside case. |
| (WebCore::RenderBlock::updateShapeInsideInfoAfterStyleChange): Ditto. |
| * rendering/RenderElement.cpp: |
| (WebCore::RenderElement::~RenderElement): Ditto. |
| (WebCore::RenderElement::setStyle): Ditto. |
| |
| 2013-10-14 Andreas Kling <akling@apple.com> |
| |
| Remove some silly null checks in Element/NamedNodeMap. |
| <https://webkit.org/b/122767> |
| |
| Reviewed by Darin Adler. |
| |
| Make shouldIgnoreAttributeCase() take a const Element&, exposing |
| some unnecessary null checks. |
| |
| 2013-10-14 Brent Fulgham <bfulgham@apple.com> |
| |
| [Win] Build fix after r122737. |
| |
| * dom/Node.h: Add explicit WebCore namespace to macro definition to work around |
| Visual Studio bug. |
| |
| 2013-10-14 Andreas Kling <akling@apple.com> |
| |
| Pass Document directly to anonymous renderer constructors. |
| <https://webkit.org/b/122752> |
| |
| Reviewed by Antti Koivisto. |
| |
| Added separate constructors for creating anonymous renderers that |
| take a Document& instead of a null Element*/Text*. |
| |
| Removed setDocumentForAnonymous() and all createAnonymous() helpers. |
| ...and RenderObject::m_node is now a Node&, wohoo! |
| |
| 2013-10-13 Sam Weinig <sam@webkit.org> |
| |
| CTTE: Add more node conversion helpers |
| https://bugs.webkit.org/show_bug.cgi?id=122737 |
| |
| Reviewed by Darin Adler. |
| |
| - Factor NODE_TYPE_CASTS into TYPE_CASTS_BASE(ToClassName, FromClassName) |
| to allow for DOCUMENT_TYPE_CASTS. |
| - Replace more static_casts<>. |
| |
| 2013-10-14 Zan Dobersek <zdobersek@igalia.com> |
| |
| Reintroduce PassRefPtr<Event> copy in ScopedEventQueue::dispatchEvent |
| https://bugs.webkit.org/show_bug.cgi?id=122742 |
| |
| Reviewed by Alexey Proskuryakov. |
| |
| This is a follow-up to r157219 which introduced a workaround for the GCC's quirky behavior that |
| was resulting in crashes due to the PassRefPtr<Event> object passed to EventDispatcher::dispatchEvent |
| being copied and nullified first before retrieving the EventTarget of the Event object wrapped in that |
| PassRefPtr. |
| |
| The implementation is now adjusted to first retrieve the pointer to the Event's EventTarget and store |
| it in a local variable. That variable is then passed as the first parameter to EventDispatcher::dispatchEvent, |
| and the PassRefPtr<Event> passed directly as the second parameter. Previously the pointer of that PassRefPtr |
| object was passed in, with a new PassRefPtr being created which would increase the reference count of the |
| ref-counted object. Passing in the original PassRefPtr avoids the unnecessary reference count increase by creating |
| a copy. That still nullifies the original PassRefPtr, but that's not a problem anymore. |
| |
| * dom/ScopedEventQueue.cpp: |
| (WebCore::ScopedEventQueue::dispatchEvent): |
| |
| 2013-10-14 Bear Travis <betravis@adobe.com> |
| |
| [CSS Shapes] Shape-Margin should be animatable |
| https://bugs.webkit.org/show_bug.cgi?id=122524 |
| |
| Reviewed by Darin Adler. |
| |
| Mark content for relayout after shape-margin changes, and add shape-margin |
| to the list of animatable properties. |
| |
| Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin.html |
| fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation.html |
| |
| * page/animation/CSSPropertyAnimation.cpp: |
| (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Add |
| shape-margin to the map of animatable CSS properties. |
| * rendering/RenderBox.cpp: |
| (WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Compare shape-margins, |
| and mark dependent content for relayout if they have changed. |
| |
| 2013-10-14 Arvid Nilsson <anilsson@blackberry.com> |
| |
| Don't crash after OpenGL robustness reset |
| https://bugs.webkit.org/show_bug.cgi?id=122750 |
| |
| Reviewed by George Staikos. |
| |
| JIRA 517132. |
| Just log the incident and pretend like nothing happened. |
| |
| No new tests, we don't have repeatable steps to reproduce a robustness |
| reset. |
| |
| * platform/graphics/blackberry/LayerRenderer.cpp: |
| (WebCore::LayerRenderer::makeContextCurrent): |
| |
| 2013-10-14 Krzysztof Czech <k.czech@samsung.com> |
| |
| [EFL] Buildfix after r157393 |
| https://bugs.webkit.org/show_bug.cgi?id=122749 |
| |
| Reviewed by Andreas Kling. |
| |
| Buildfix with error enumeration value 'CSS_FR' not handled in switch. |
| |
| * css/CSSCalculationValue.cpp: |
| (WebCore::hasDoubleValue): |
| |
| 2013-10-14 Krzysztof Czech <k.czech@samsung.com> |
| |
| [EFL] Present replaced objects with 0xFFFC character |
| https://bugs.webkit.org/show_bug.cgi?id=122744 |
| |
| Reviewed by Mario Sanchez Prada. |
| |
| Replaced elements should be emitted in GTK/EFL and |
| marked their presence with the replacement character. |
| |
| * accessibility/AccessibilityObject.cpp: |
| (WebCore::AccessibilityObject::textIteratorBehaviorForTextRange): |
| |
| 2013-09-16 Sergio Villar Senin <svillar@igalia.com> |
| |
| [CSS Grid Layout] Implement support for <flex> |
| https://bugs.webkit.org/show_bug.cgi?id=115362 |
| |
| Reviewed by Andreas Kling. |
| |
| From Blink r149134, r149480, r149532, r150287 and r156127 by <jchaffraix@chromium.org> |
| From Blink r157820 by <svillar@igalia.com> |
| |
| Added support for flexible lengths ('fr' unit) in CSS Grid Layout |
| code. This requires the addition of GridLength class to |
| encapsulate the knowledge of <flex> to the grid layout code. |
| |
| Also updated the algorithm that computes the layout. It increases |
| the value of 1fr based on the grid tracks' usedBreath to fraction |
| ratio (called normalizedFractionValue). This enables increasing |
| the fraction value while updating the available space to account |
| for processed grid tracks. The algorithm stops when we run out of |
| grid tracks or available space (one grid item has an intrinsic |
| size too big). This matches the specs to the letter for the known |
| available space case (both the unknown case and the interaction |
| with 'span' are left out of this patch). |
| |
| Tests: fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html |
| fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html |
| fast/css-grid-layout/flex-content-resolution-columns.html |
| fast/css-grid-layout/flex-content-resolution-rows.html |
| |
| * GNUmakefile.list.am: Added GridLength.h to the build system. |
| * Target.pri: Ditto. |
| * WebCore.vcxproj/WebCore.vcxproj: Ditto. |
| * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto. |
| * WebCore.xcodeproj/project.pbxproj: Ditto. |
| * css/CSSComputedStyleDeclaration.cpp: |
| (WebCore::valueForGridTrackBreadth): Replace Length by GridLength. |
| * css/CSSGrammar.y.in: Added FR support. |
| * css/CSSParser.cpp: Ditto. |
| (WebCore::CSSParser::parseGridBreadth): |
| (WebCore::CSSParser::detectNumberToken): |
| * css/CSSParserValues.cpp: Added FR support. |
| (WebCore::CSSParserValue::createCSSValue): |
| * css/CSSParserValues.h: |
| (WebCore::CSSParserString::operator[]): |
| (WebCore::CSSParserString::equalIgnoringCase): |
| * css/CSSPrimitiveValue.cpp: Added FR support. |
| (WebCore::isValidCSSUnitTypeForDoubleConversion): |
| (WebCore::CSSPrimitiveValue::cleanup): |
| (WebCore::CSSPrimitiveValue::customCSSText): |
| (WebCore::CSSPrimitiveValue::cloneForCSSOM): |
| (WebCore::CSSPrimitiveValue::equals): |
| * css/CSSPrimitiveValue.h: Added a couple of missing const. |
| (WebCore::CSSPrimitiveValue::isFlex): |
| * css/StyleResolver.cpp: Added FR support. |
| (WebCore::createGridTrackBreadth): |
| (WebCore::createGridTrackSize): |
| * rendering/RenderGrid.cpp: |
| (WebCore::GridTrackForNormalization::GridTrackForNormalization): |
| New helper struct to ease the computation of track breadths with |
| flexible lengths. |
| (WebCore::GridTrackForNormalization::operator=): |
| (WebCore::RenderGrid::computePreferredTrackWidth): Replaced Length by GridLength. |
| (WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Grow grid lines |
| having a fraction as the MaxTrackSizingFunction. |
| (WebCore::RenderGrid::computeUsedBreadthOfMinLength): Replaced Length by GridLength. |
| (WebCore::RenderGrid::computeUsedBreadthOfMaxLength): Ditto. |
| (WebCore::sortByGridNormalizedFlexValue): |
| (WebCore::RenderGrid::computeNormalizedFractionBreadth): Increase |
| the fraction value while updating the available space to account |
| for processed grid tracks. |
| (WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions): |
| (WebCore::RenderGrid::distributeSpaceToTracks): Never shrink track sizes. |
| (WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth): |
| * rendering/RenderGrid.h: |
| * rendering/style/GridLength.h: Added. |
| (WebCore::GridLength::GridLength): |
| (WebCore::GridLength::isLength): |
| (WebCore::GridLength::isFlex): |
| (WebCore::GridLength::length): |
| (WebCore::GridLength::flex): |
| (WebCore::GridLength::setFlex): |
| (WebCore::GridLength::operator==): |
| * rendering/style/GridTrackSize.h: Replaced Length by GridLength. |
| (WebCore::GridTrackSize::length): |
| (WebCore::GridTrackSize::setLength): |
| (WebCore::GridTrackSize::minTrackBreadth): |
| (WebCore::GridTrackSize::maxTrackBreadth): |
| (WebCore::GridTrackSize::setMinMax): |
| (WebCore::GridTrackSize::hasMinOrMaxContentMinTrackBreadth): |
| (WebCore::GridTrackSize::hasMaxContentMinTrackBreadth): |
| (WebCore::GridTrackSize::hasMinOrMaxContentMaxTrackBreadth): |
| (WebCore::GridTrackSize::hasMaxContentMaxTrackBreadth): |
| |
| 2013-10-14 peavo@outlook.com <peavo@outlook.com> |
| |
| Broken text rendering when input field has selection. |
| https://bugs.webkit.org/show_bug.cgi?id=122716 |
| |
| Reviewed by Antti Koivisto. |
| |
| Tests: fast/text/text-rendering-with-input-selection.html. |
| fast/text/text-rendering-with-input-selection-expected.html. |
| |
| * rendering/InlineTextBox.cpp: |
| (WebCore::InlineTextBox::paint): Check that text has selection. |
| |
| 2013-10-14 Zalan Bujtas <zalan@apple.com> |
| |
| Unexpected word wrapping for wrapped content then raw content. |
| https://bugs.webkit.org/show_bug.cgi?id=121130 |
| |
| Reviewed by Antti Koivisto. |
| |
| When deciding whether a line is considered empty, we need to check if the current |
| object is fully responsible for the currently uncommitted width. It helps differentiating |
| <span></span><span>abcd</span> from <span>a</span><span>bcd</span>, where in the first |
| case when we hit the second <span> the line is still considered empty, as opposed to the |
| second example. |
| |
| Test: fast/css/unexpected-word-wrapping-with-non-empty-spans.html |
| |
| * rendering/RenderBlockLineLayout.cpp: |
| (WebCore::LineBreaker::nextSegmentBreak): |
| |
| 2013-10-14 Andreas Kling <akling@apple.com> |
| |
| Be more efficient about passing RenderStyle to attachRenderTree(). |
| <https://webkit.org/b/122743> |
| |
| Reviewed by Antti Koivisto. |
| |
| Have attachRenderTree() and createRendererTreeIfNeeded() pass the |
| RenderStyle in a PassRefPtr to avoid churning the ref count. |
| |
| 2013-10-14 Sergio Villar Senin <svillar@igalia.com> |
| |
| [CSS Grid Layout] 2 span positions are not resolved correctly |
| https://bugs.webkit.org/show_bug.cgi?id=119717 |
| |
| Reviewed by Andreas Kling. |
| |
| From Blink r155397 by <jchaffraix@chromium.org> |
| |
| Test: fast/css-grid-layout/grid-item-bad-resolution-double-span.html |
| |
| Two opposite 'span' or 'auto' positions should be resolved using |
| the auto placement algorithm. We were only checking for the 'auto' |
| case. This also covers the case of other positions that, according |
| to the spec, should be treated as 'auto'. |
| |
| * rendering/RenderGrid.cpp: |
| (WebCore::RenderGrid::resolveGridPositionsFromStyle): |
| |
| 2013-10-13 Andreas Kling <akling@apple.com> |
| |
| Use RenderElement instead of RenderObject in more places. |
| <https://webkit.org/b/122734> |
| |
| Reviewed by Antti Koivisto. |
| |
| Convert some sites to use RenderElement (or type inference) instead |
| of RenderObject for less branchy code. |
| |
| 2013-10-13 Darin Adler <darin@apple.com> |
| |
| Deprecate or remove deleteAllValues functions; there are only a few call sites left |
| https://bugs.webkit.org/show_bug.cgi?id=122738 |
| |
| Reviewed by Anders Carlsson. |
| |
| * platform/blackberry/CookieMap.cpp: |
| (WebCore::CookieMap::deleteAllCookiesAndDomains): |
| * platform/network/blackberry/rss/RSSParserBase.cpp: |
| (WebCore::RSSFeed::clear): |
| * platform/win/WCDataObject.cpp: |
| (WebCore::WCDataObject::~WCDataObject): |
| Renamed deleteAllValues to deprecatedDeleteAllValues. |
| |
| 2013-10-13 Sam Weinig <sam@webkit.org> |
| |
| Merge NODE_TYPE_CASTS and ELEMENT_TYPE_CASTS |
| https://bugs.webkit.org/show_bug.cgi?id=122735 |
| |
| Reviewed by Antti Koivisto. |
| |
| NODE_TYPE_CASTS and ELEMENT_TYPE_CASTS are identical. Let them become one |
| with one another. |
| |
| 2013-10-13 Andreas Kling <akling@apple.com> |
| |
| Uncrashify Document::head() too. (Why am I even awake?) |
| |
| 2013-10-13 Andreas Kling <akling@apple.com> |
| |
| REGRESSION(r157381): Make Document::body() crash less when there is no documentElement. |
| |
| Unreviewed. |
| |
| 2013-10-13 Darin Adler <darin@apple.com> |
| |
| Rewrite Document::body and Document::head in modern style, way clearer and shorter |
| https://bugs.webkit.org/show_bug.cgi?id=122717 |
| |
| Reviewed by Andreas Kling. |
| |
| * dom/Document.cpp: |
| (WebCore::Document::body): Use iterator to make this way easier to read. |
| (WebCore::Document::head): Ditto. |
| |
| * html/HTMLTagNames.in: Added generateTypeHelpers for body and head. |
| |
| == Rolled over to ChangeLog-2013-10-13 == |
