[ews] Status bubble should show previous failures if any in case patch is skipped
https://bugs.webkit.org/show_bug.cgi?id=203261
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble): Display build information from previous builds for skipped patch in
case there are multiple builds.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@251453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py b/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
index e7fd957..e65e069 100644
--- a/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
+++ b/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
@@ -129,6 +129,10 @@
elif re.search(r'Patch .* is obsolete', build.state_string):
bubble['details_message'] += ' Patch was obsolete when EWS attempted to process it.'
+ if len(builds) > 1:
+ bubble['details_message'] += '\nSome messages were logged while the patch was still eligible:'
+ bubble['details_message'] += self._steps_messages_from_multiple_builds(builds)
+
elif build.result == Buildbot.EXCEPTION:
bubble['state'] = 'error'
bubble['details_message'] = 'An unexpected error occured. Recent messages:' + self._steps_messages_from_multiple_builds(builds)
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index c7878a1..ffe8880 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,14 @@
+2019-10-22 Aakash Jain <aakash_jain@apple.com>
+
+ [ews] Status bubble should show previous failures if any in case patch is skipped
+ https://bugs.webkit.org/show_bug.cgi?id=203261
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+ (StatusBubble._build_bubble): Display build information from previous builds for skipped patch in
+ case there are multiple builds.
+
2019-10-22 Alex Christensen <achristensen@webkit.org>
Re-enable legacy TLS by default, keep runtime switch
