commit 828cdc69b424119b0ff265b02b170b4013c9471f
author commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Wed Jan 26 12:18:57 2022 +0000
committer commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Wed Jan 26 12:18:57 2022 +0000
tree de7e5492192a33380852d126edaec2d9cecedd1b
parent 18eafb7225658eb078fb4b435c7e6f4bc55edf7a

[GTK] C++20 warnings in TestConsoleMessage
https://bugs.webkit.org/show_bug.cgi?id=235634

Patch by Philippe Normand <pnormand@igalia.com> on 2022-01-26
Reviewed by Adrian Perez de Castro.

Fix ambiguous-reversed-operator warnings. In C++20 comparison operators (like a == b) need
to be declared const, so that reverse comparisons (like b == a) also work as intended.

* TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
(ConsoleMessageTest::ConsoleMessage::operator== const):
(ConsoleMessageTest::ConsoleMessage::operator==): Deleted.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@288613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index d1cd49d..a245941 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,17 @@
+2022-01-26  Philippe Normand  <pnormand@igalia.com>
+
+        [GTK] C++20 warnings in TestConsoleMessage
+        https://bugs.webkit.org/show_bug.cgi?id=235634
+
+        Reviewed by Adrian Perez de Castro.
+
+        Fix ambiguous-reversed-operator warnings. In C++20 comparison operators (like a == b) need
+        to be declared const, so that reverse comparisons (like b == a) also work as intended.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
+        (ConsoleMessageTest::ConsoleMessage::operator== const):
+        (ConsoleMessageTest::ConsoleMessage::operator==): Deleted.
+
 2022-01-26  Alexander Mikhaylenko  <alexm@gnome.org>
 
         [GTK] REGRESSION: Touch scrolling is broken

Tools/TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp

diff --git a/Tools/TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp b/Tools/TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp
index 878a1c6..b7a1c3b 100644
--- a/Tools/TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp
+++ b/Tools/TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp
@@ -29,7 +29,7 @@
     enum class MessageSource { JavaScript, Network, ConsoleAPI, Security, Other };
     enum class MessageLevel { Info, Log, Warning, Error, Debug };
     struct ConsoleMessage {
-        bool operator==(const ConsoleMessage& other)
+        bool operator==(const ConsoleMessage& other) const
         {
             return source == other.source
                 && level == other.level