Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/BufferVk.cpp - WebKit - Git at Google

 //
 // Copyright 2016 The ANGLE Project Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // BufferVk.cpp:
 //    Implements the class methods for BufferVk.
 //

 #include "libANGLE/renderer/vulkan/BufferVk.h"

 #include "common/debug.h"
 #include "common/utilities.h"
 #include "libANGLE/Context.h"
 #include "libANGLE/renderer/vulkan/ContextVk.h"
 #include "libANGLE/renderer/vulkan/RendererVk.h"
 #include "libANGLE/trace.h"

 namespace rx
 {

 namespace
 {
 // Vertex attribute buffers are used as storage buffers for conversion in compute, where access to
 // the buffer is made in 4-byte chunks.  Assume the size of the buffer is 4k+n where n is in [0, 3).
 // On some hardware, reading 4 bytes from address 4k returns 0, making it impossible to read the
 // last n bytes.  By rounding up the buffer sizes to a multiple of 4, the problem is alleviated.
 constexpr size_t kBufferSizeGranularity = 4;
 static_assert(gl::isPow2(kBufferSizeGranularity), "use as alignment, must be power of two");

 // Start with a fairly small buffer size. We can increase this dynamically as we convert more data.
 constexpr size_t kConvertedArrayBufferInitialSize = 1024 * 8;
 }  // namespace

 // ConversionBuffer implementation.
 ConversionBuffer::ConversionBuffer(RendererVk *renderer,
                                    VkBufferUsageFlags usageFlags,
                                    size_t initialSize,
                                    size_t alignment)
     : dirty(true), lastAllocationOffset(0)
 {
     data.init(renderer, usageFlags, alignment, initialSize, true);
 }

 ConversionBuffer::~ConversionBuffer() = default;

 ConversionBuffer::ConversionBuffer(ConversionBuffer &&other) = default;

 // BufferVk::VertexConversionBuffer implementation.
 BufferVk::VertexConversionBuffer::VertexConversionBuffer(RendererVk *renderer,
                                                          angle::FormatID formatIDIn,
                                                          GLuint strideIn,
                                                          size_t offsetIn)
     : ConversionBuffer(renderer,
                        vk::kVertexBufferUsageFlags,
                        kConvertedArrayBufferInitialSize,
                        vk::kVertexBufferAlignment),
       formatID(formatIDIn),
       stride(strideIn),
       offset(offsetIn)
 {}

 BufferVk::VertexConversionBuffer::VertexConversionBuffer(VertexConversionBuffer &&other) = default;

 BufferVk::VertexConversionBuffer::~VertexConversionBuffer() = default;

 // BufferVk implementation.
 BufferVk::BufferVk(const gl::BufferState &state) : BufferImpl(state) {}

 BufferVk::~BufferVk() {}

 void BufferVk::destroy(const gl::Context *context)
 {
     ContextVk *contextVk = vk::GetImpl(context);

     release(contextVk);
 }

 void BufferVk::release(ContextVk *contextVk)
 {
     mBuffer.release(contextVk);

     for (ConversionBuffer &buffer : mVertexConversionBuffers)
     {
         buffer.data.release(contextVk);
     }
 }

 angle::Result BufferVk::setData(const gl::Context *context,
                                 gl::BufferBinding target,
                                 const void *data,
                                 size_t size,
                                 gl::BufferUsage usage)
 {
     ContextVk *contextVk = vk::GetImpl(context);

     if (size > static_cast<size_t>(mState.getSize()))
     {
         // Release and re-create the memory and buffer.
         release(contextVk);

         // We could potentially use multiple backing buffers for different usages.
         // For now keep a single buffer with all relevant usage flags.
         const VkImageUsageFlags usageFlags =
             VK_BUFFER_USAGE_VERTEX_BUFFER_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT |
             VK_BUFFER_USAGE_INDEX_BUFFER_BIT | VK_BUFFER_USAGE_TRANSFER_SRC_BIT |
             VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_BUFFER_BIT |
             VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_INDIRECT_BUFFER_BIT;

         VkBufferCreateInfo createInfo    = {};
         createInfo.sType                 = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO;
         createInfo.flags                 = 0;
         createInfo.size                  = roundUpPow2(size, kBufferSizeGranularity);
         createInfo.usage                 = usageFlags;
         createInfo.sharingMode           = VK_SHARING_MODE_EXCLUSIVE;
         createInfo.queueFamilyIndexCount = 0;
         createInfo.pQueueFamilyIndices   = nullptr;

         // Assume host visible/coherent memory available.
         const VkMemoryPropertyFlags memoryPropertyFlags =
             (VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT);

         ANGLE_TRY(mBuffer.init(contextVk, createInfo, memoryPropertyFlags));
     }

     if (data && size > 0)
     {
         ANGLE_TRY(setDataImpl(contextVk, static_cast<const uint8_t *>(data), size, 0));
     }

     return angle::Result::Continue;
 }

 angle::Result BufferVk::setSubData(const gl::Context *context,
                                    gl::BufferBinding target,
                                    const void *data,
                                    size_t size,
                                    size_t offset)
 {
     ASSERT(mBuffer.valid());

     ContextVk *contextVk = vk::GetImpl(context);
     ANGLE_TRY(setDataImpl(contextVk, static_cast<const uint8_t *>(data), size, offset));

     return angle::Result::Continue;
 }

 angle::Result BufferVk::copySubData(const gl::Context *context,
                                     BufferImpl *source,
                                     GLintptr sourceOffset,
                                     GLintptr destOffset,
                                     GLsizeiptr size)
 {
     ASSERT(mBuffer.valid());

     ContextVk *contextVk = vk::GetImpl(context);
     auto *sourceBuffer   = GetAs<BufferVk>(source);

     vk::CommandBuffer *commandBuffer = nullptr;

     // Handle self-dependency especially.
     if (sourceBuffer->mBuffer.getBuffer().getHandle() == mBuffer.getBuffer().getHandle())
     {
         mBuffer.onSelfReadWrite(contextVk, VK_ACCESS_TRANSFER_READ_BIT,
                                 VK_ACCESS_TRANSFER_WRITE_BIT);

         ANGLE_TRY(mBuffer.recordCommands(contextVk, &commandBuffer));
     }
     else
     {
         ANGLE_TRY(mBuffer.recordCommands(contextVk, &commandBuffer));

         sourceBuffer->mBuffer.onReadByBuffer(contextVk, &mBuffer, VK_ACCESS_TRANSFER_READ_BIT,
                                              VK_ACCESS_TRANSFER_WRITE_BIT);
     }

     // Enqueue a copy command on the GPU.
     VkBufferCopy copyRegion = {static_cast<VkDeviceSize>(sourceOffset),
                                static_cast<VkDeviceSize>(destOffset),
                                static_cast<VkDeviceSize>(size)};

     commandBuffer->copyBuffer(sourceBuffer->getBuffer().getBuffer(), mBuffer.getBuffer(), 1,
                               &copyRegion);

     return angle::Result::Continue;
 }

 angle::Result BufferVk::map(const gl::Context *context, GLenum access, void **mapPtr)
 {
     ASSERT(mBuffer.valid());

     return mapImpl(vk::GetImpl(context), mapPtr);
 }

 angle::Result BufferVk::mapRange(const gl::Context *context,
                                  size_t offset,
                                  size_t length,
                                  GLbitfield access,
                                  void **mapPtr)
 {
     return mapRangeImpl(vk::GetImpl(context), offset, length, access, mapPtr);
 }

 angle::Result BufferVk::mapImpl(ContextVk *contextVk, void **mapPtr)
 {
     return mapRangeImpl(contextVk, 0, static_cast<VkDeviceSize>(mState.getSize()), 0, mapPtr);
 }

 angle::Result BufferVk::mapRangeImpl(ContextVk *contextVk,
                                      VkDeviceSize offset,
                                      VkDeviceSize length,
                                      GLbitfield access,
                                      void **mapPtr)
 {
     ASSERT(mBuffer.valid());

     if ((access & GL_MAP_UNSYNCHRONIZED_BIT) == 0)
     {
         // If there are pending commands for the buffer, flush them.
         if (mBuffer.isResourceInUse(contextVk))
         {
             ANGLE_TRY(contextVk->flushImpl(nullptr));
         }
         // Make sure the GPU is done with the buffer.
         ANGLE_TRY(contextVk->finishToSerial(mBuffer.getStoredQueueSerial()));
     }

     ANGLE_VK_TRY(contextVk, mBuffer.getDeviceMemory().map(contextVk->getDevice(), offset, length, 0,
                                                           reinterpret_cast<uint8_t **>(mapPtr)));
     return angle::Result::Continue;
 }

 angle::Result BufferVk::unmap(const gl::Context *context, GLboolean *result)
 {
     unmapImpl(vk::GetImpl(context));

     // This should be false if the contents have been corrupted through external means.  Vulkan
     // doesn't provide such information.
     *result = true;

     return angle::Result::Continue;
 }

 void BufferVk::unmapImpl(ContextVk *contextVk)
 {
     ASSERT(mBuffer.valid());

     mBuffer.getDeviceMemory().unmap(contextVk->getDevice());
     mBuffer.onExternalWrite(VK_ACCESS_HOST_WRITE_BIT);

     markConversionBuffersDirty();
 }

 angle::Result BufferVk::getIndexRange(const gl::Context *context,
                                       gl::DrawElementsType type,
                                       size_t offset,
                                       size_t count,
                                       bool primitiveRestartEnabled,
                                       gl::IndexRange *outRange)
 {
     ContextVk *contextVk = vk::GetImpl(context);
     RendererVk *renderer = contextVk->getRenderer();

     // This is a workaround for the mock ICD not implementing buffer memory state.
     // Could be removed if https://github.com/KhronosGroup/Vulkan-Tools/issues/84 is fixed.
     if (renderer->isMockICDEnabled())
     {
         outRange->start = 0;
         outRange->end   = 0;
         return angle::Result::Continue;
     }

     ANGLE_TRACE_EVENT0("gpu.angle", "BufferVk::getIndexRange");
     // Needed before reading buffer or we could get stale data.
     ANGLE_TRY(contextVk->finishImpl());

     // TODO(jmadill): Consider keeping a shadow system memory copy in some cases.
     ASSERT(mBuffer.valid());

     const GLuint &typeBytes = gl::GetDrawElementsTypeSize(type);

     uint8_t *mapPointer = nullptr;
     ANGLE_VK_TRY(contextVk, mBuffer.getDeviceMemory().map(contextVk->getDevice(), offset,
                                                           typeBytes * count, 0, &mapPointer));

     *outRange = gl::ComputeIndexRange(type, mapPointer, count, primitiveRestartEnabled);

     mBuffer.getDeviceMemory().unmap(contextVk->getDevice());
     return angle::Result::Continue;
 }

 angle::Result BufferVk::setDataImpl(ContextVk *contextVk,
                                     const uint8_t *data,
                                     size_t size,
                                     size_t offset)
 {
     VkDevice device = contextVk->getDevice();

     // Use map when available.
     if (mBuffer.isResourceInUse(contextVk))
     {
         vk::StagingBuffer stagingBuffer;
         ANGLE_TRY(stagingBuffer.init(contextVk, static_cast<VkDeviceSize>(size),
                                      vk::StagingUsage::Write));

         uint8_t *mapPointer = nullptr;
         ANGLE_VK_TRY(contextVk,
                      stagingBuffer.getDeviceMemory().map(device, 0, size, 0, &mapPointer));
         ASSERT(mapPointer);

         memcpy(mapPointer, data, size);
         stagingBuffer.getDeviceMemory().unmap(device);

         // Enqueue a copy command on the GPU.
         VkBufferCopy copyRegion = {0, offset, size};
         ANGLE_TRY(mBuffer.copyFromBuffer(contextVk, stagingBuffer.getBuffer(),
                                          VK_ACCESS_HOST_WRITE_BIT, copyRegion));

         // Immediately release staging buffer. We should probably be using a DynamicBuffer here.
         contextVk->releaseObject(contextVk->getCurrentQueueSerial(), &stagingBuffer);
     }
     else
     {
         uint8_t *mapPointer = nullptr;
         ANGLE_VK_TRY(contextVk,
                      mBuffer.getDeviceMemory().map(device, offset, size, 0, &mapPointer));
         ASSERT(mapPointer);

         memcpy(mapPointer, data, size);

         mBuffer.getDeviceMemory().unmap(device);
         mBuffer.onExternalWrite(VK_ACCESS_HOST_WRITE_BIT);
     }

     // Update conversions
     markConversionBuffersDirty();

     return angle::Result::Continue;
 }

 angle::Result BufferVk::copyToBuffer(ContextVk *contextVk,
                                      vk::BufferHelper *destBuffer,
                                      uint32_t copyCount,
                                      const VkBufferCopy *copies)
 {
     vk::CommandBuffer *commandBuffer;
     ANGLE_TRY(destBuffer->recordCommands(contextVk, &commandBuffer));
     commandBuffer->copyBuffer(mBuffer.getBuffer(), destBuffer->getBuffer(), copyCount, copies);

     mBuffer.onReadByBuffer(contextVk, destBuffer, VK_ACCESS_TRANSFER_READ_BIT,
                            VK_ACCESS_TRANSFER_WRITE_BIT);

     return angle::Result::Continue;
 }

 ConversionBuffer *BufferVk::getVertexConversionBuffer(RendererVk *renderer,
                                                       angle::FormatID formatID,
                                                       GLuint stride,
                                                       size_t offset)
 {
     for (VertexConversionBuffer &buffer : mVertexConversionBuffers)
     {
         if (buffer.formatID == formatID && buffer.stride == stride && buffer.offset == offset)
         {
             return &buffer;
         }
     }

     mVertexConversionBuffers.emplace_back(renderer, formatID, stride, offset);
     return &mVertexConversionBuffers.back();
 }

 void BufferVk::markConversionBuffersDirty()
 {
     for (VertexConversionBuffer &buffer : mVertexConversionBuffers)
     {
         buffer.dirty = true;
     }
 }

 void BufferVk::onDataChanged()
 {
     markConversionBuffersDirty();
 }

 }  // namespace rx
	//
	// Copyright 2016 The ANGLE Project Authors. All rights reserved.
	// Use of this source code is governed by a BSD-style license that can be
	// found in the LICENSE file.
	//
	// BufferVk.cpp:
	// Implements the class methods for BufferVk.
	//

	#include "libANGLE/renderer/vulkan/BufferVk.h"

	#include "common/debug.h"
	#include "common/utilities.h"
	#include "libANGLE/Context.h"
	#include "libANGLE/renderer/vulkan/ContextVk.h"
	#include "libANGLE/renderer/vulkan/RendererVk.h"
	#include "libANGLE/trace.h"

	namespace rx
	{

	namespace
	{
	// Vertex attribute buffers are used as storage buffers for conversion in compute, where access to
	// the buffer is made in 4-byte chunks. Assume the size of the buffer is 4k+n where n is in [0, 3).
	// On some hardware, reading 4 bytes from address 4k returns 0, making it impossible to read the
	// last n bytes. By rounding up the buffer sizes to a multiple of 4, the problem is alleviated.
	constexpr size_t kBufferSizeGranularity = 4;
	static_assert(gl::isPow2(kBufferSizeGranularity), "use as alignment, must be power of two");

	// Start with a fairly small buffer size. We can increase this dynamically as we convert more data.
	constexpr size_t kConvertedArrayBufferInitialSize = 1024 * 8;
	} // namespace

	// ConversionBuffer implementation.
	ConversionBuffer::ConversionBuffer(RendererVk *renderer,
	VkBufferUsageFlags usageFlags,
	size_t initialSize,
	size_t alignment)
	: dirty(true), lastAllocationOffset(0)
	{
	data.init(renderer, usageFlags, alignment, initialSize, true);
	}

	ConversionBuffer::~ConversionBuffer() = default;

	ConversionBuffer::ConversionBuffer(ConversionBuffer &&other) = default;

	// BufferVk::VertexConversionBuffer implementation.
	BufferVk::VertexConversionBuffer::VertexConversionBuffer(RendererVk *renderer,
	angle::FormatID formatIDIn,
	GLuint strideIn,
	size_t offsetIn)
	: ConversionBuffer(renderer,
	vk::kVertexBufferUsageFlags,
	kConvertedArrayBufferInitialSize,
	vk::kVertexBufferAlignment),
	formatID(formatIDIn),
	stride(strideIn),
	offset(offsetIn)
	{}

	BufferVk::VertexConversionBuffer::VertexConversionBuffer(VertexConversionBuffer &&other) = default;

	BufferVk::VertexConversionBuffer::~VertexConversionBuffer() = default;

	// BufferVk implementation.
	BufferVk::BufferVk(const gl::BufferState &state) : BufferImpl(state) {}

	BufferVk::~BufferVk() {}

	void BufferVk::destroy(const gl::Context *context)
	{
	ContextVk *contextVk = vk::GetImpl(context);

	release(contextVk);
	}

	void BufferVk::release(ContextVk *contextVk)
	{
	mBuffer.release(contextVk);

	for (ConversionBuffer &buffer : mVertexConversionBuffers)
	{
	buffer.data.release(contextVk);
	}
	}

	angle::Result BufferVk::setData(const gl::Context *context,
	gl::BufferBinding target,
	const void *data,
	size_t size,
	gl::BufferUsage usage)
	{
	ContextVk *contextVk = vk::GetImpl(context);

	if (size > static_cast<size_t>(mState.getSize()))
	{
	// Release and re-create the memory and buffer.
	release(contextVk);

	// We could potentially use multiple backing buffers for different usages.
	// For now keep a single buffer with all relevant usage flags.
	const VkImageUsageFlags usageFlags =
	VK_BUFFER_USAGE_VERTEX_BUFFER_BIT \| VK_BUFFER_USAGE_TRANSFER_DST_BIT \|
	VK_BUFFER_USAGE_INDEX_BUFFER_BIT \| VK_BUFFER_USAGE_TRANSFER_SRC_BIT \|
	VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT \| VK_BUFFER_USAGE_STORAGE_BUFFER_BIT \|
	VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT \| VK_BUFFER_USAGE_INDIRECT_BUFFER_BIT;

	VkBufferCreateInfo createInfo = {};
	createInfo.sType = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO;
	createInfo.flags = 0;
	createInfo.size = roundUpPow2(size, kBufferSizeGranularity);
	createInfo.usage = usageFlags;
	createInfo.sharingMode = VK_SHARING_MODE_EXCLUSIVE;
	createInfo.queueFamilyIndexCount = 0;
	createInfo.pQueueFamilyIndices = nullptr;

	// Assume host visible/coherent memory available.
	const VkMemoryPropertyFlags memoryPropertyFlags =
	(VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT \| VK_MEMORY_PROPERTY_HOST_COHERENT_BIT);

	ANGLE_TRY(mBuffer.init(contextVk, createInfo, memoryPropertyFlags));
	}

	if (data && size > 0)
	{
	ANGLE_TRY(setDataImpl(contextVk, static_cast<const uint8_t *>(data), size, 0));
	}

	return angle::Result::Continue;
	}

	angle::Result BufferVk::setSubData(const gl::Context *context,
	gl::BufferBinding target,
	const void *data,
	size_t size,
	size_t offset)
	{
	ASSERT(mBuffer.valid());

	ContextVk *contextVk = vk::GetImpl(context);
	ANGLE_TRY(setDataImpl(contextVk, static_cast<const uint8_t *>(data), size, offset));

	return angle::Result::Continue;
	}

	angle::Result BufferVk::copySubData(const gl::Context *context,
	BufferImpl *source,
	GLintptr sourceOffset,
	GLintptr destOffset,
	GLsizeiptr size)
	{
	ASSERT(mBuffer.valid());

	ContextVk *contextVk = vk::GetImpl(context);
	auto *sourceBuffer = GetAs<BufferVk>(source);

	vk::CommandBuffer *commandBuffer = nullptr;

	// Handle self-dependency especially.
	if (sourceBuffer->mBuffer.getBuffer().getHandle() == mBuffer.getBuffer().getHandle())
	{
	mBuffer.onSelfReadWrite(contextVk, VK_ACCESS_TRANSFER_READ_BIT,
	VK_ACCESS_TRANSFER_WRITE_BIT);

	ANGLE_TRY(mBuffer.recordCommands(contextVk, &commandBuffer));
	}
	else
	{
	ANGLE_TRY(mBuffer.recordCommands(contextVk, &commandBuffer));

	sourceBuffer->mBuffer.onReadByBuffer(contextVk, &mBuffer, VK_ACCESS_TRANSFER_READ_BIT,
	VK_ACCESS_TRANSFER_WRITE_BIT);
	}

	// Enqueue a copy command on the GPU.
	VkBufferCopy copyRegion = {static_cast<VkDeviceSize>(sourceOffset),
	static_cast<VkDeviceSize>(destOffset),
	static_cast<VkDeviceSize>(size)};

	commandBuffer->copyBuffer(sourceBuffer->getBuffer().getBuffer(), mBuffer.getBuffer(), 1,
	&copyRegion);

	return angle::Result::Continue;
	}

	angle::Result BufferVk::map(const gl::Context context, GLenum access, void *mapPtr)
	{
	ASSERT(mBuffer.valid());

	return mapImpl(vk::GetImpl(context), mapPtr);
	}

	angle::Result BufferVk::mapRange(const gl::Context *context,
	size_t offset,
	size_t length,
	GLbitfield access,
	void **mapPtr)
	{
	return mapRangeImpl(vk::GetImpl(context), offset, length, access, mapPtr);
	}

	angle::Result BufferVk::mapImpl(ContextVk contextVk, void *mapPtr)
	{
	return mapRangeImpl(contextVk, 0, static_cast<VkDeviceSize>(mState.getSize()), 0, mapPtr);
	}

	angle::Result BufferVk::mapRangeImpl(ContextVk *contextVk,
	VkDeviceSize offset,
	VkDeviceSize length,
	GLbitfield access,
	void **mapPtr)
	{
	ASSERT(mBuffer.valid());

	if ((access & GL_MAP_UNSYNCHRONIZED_BIT) == 0)
	{
	// If there are pending commands for the buffer, flush them.
	if (mBuffer.isResourceInUse(contextVk))
	{
	ANGLE_TRY(contextVk->flushImpl(nullptr));
	}
	// Make sure the GPU is done with the buffer.
	ANGLE_TRY(contextVk->finishToSerial(mBuffer.getStoredQueueSerial()));
	}

	ANGLE_VK_TRY(contextVk, mBuffer.getDeviceMemory().map(contextVk->getDevice(), offset, length, 0,
	reinterpret_cast<uint8_t **>(mapPtr)));
	return angle::Result::Continue;
	}

	angle::Result BufferVk::unmap(const gl::Context context, GLboolean result)
	{
	unmapImpl(vk::GetImpl(context));

	// This should be false if the contents have been corrupted through external means. Vulkan
	// doesn't provide such information.
	*result = true;

	return angle::Result::Continue;
	}

	void BufferVk::unmapImpl(ContextVk *contextVk)
	{
	ASSERT(mBuffer.valid());

	mBuffer.getDeviceMemory().unmap(contextVk->getDevice());
	mBuffer.onExternalWrite(VK_ACCESS_HOST_WRITE_BIT);

	markConversionBuffersDirty();
	}

	angle::Result BufferVk::getIndexRange(const gl::Context *context,
	gl::DrawElementsType type,
	size_t offset,
	size_t count,
	bool primitiveRestartEnabled,
	gl::IndexRange *outRange)
	{
	ContextVk *contextVk = vk::GetImpl(context);
	RendererVk *renderer = contextVk->getRenderer();

	// This is a workaround for the mock ICD not implementing buffer memory state.
	// Could be removed if https://github.com/KhronosGroup/Vulkan-Tools/issues/84 is fixed.
	if (renderer->isMockICDEnabled())
	{
	outRange->start = 0;
	outRange->end = 0;
	return angle::Result::Continue;
	}

	ANGLE_TRACE_EVENT0("gpu.angle", "BufferVk::getIndexRange");
	// Needed before reading buffer or we could get stale data.
	ANGLE_TRY(contextVk->finishImpl());

	// TODO(jmadill): Consider keeping a shadow system memory copy in some cases.
	ASSERT(mBuffer.valid());

	const GLuint &typeBytes = gl::GetDrawElementsTypeSize(type);

	uint8_t *mapPointer = nullptr;
	ANGLE_VK_TRY(contextVk, mBuffer.getDeviceMemory().map(contextVk->getDevice(), offset,
	typeBytes * count, 0, &mapPointer));

	*outRange = gl::ComputeIndexRange(type, mapPointer, count, primitiveRestartEnabled);

	mBuffer.getDeviceMemory().unmap(contextVk->getDevice());
	return angle::Result::Continue;
	}

	angle::Result BufferVk::setDataImpl(ContextVk *contextVk,
	const uint8_t *data,
	size_t size,
	size_t offset)
	{
	VkDevice device = contextVk->getDevice();

	// Use map when available.
	if (mBuffer.isResourceInUse(contextVk))
	{
	vk::StagingBuffer stagingBuffer;
	ANGLE_TRY(stagingBuffer.init(contextVk, static_cast<VkDeviceSize>(size),
	vk::StagingUsage::Write));

	uint8_t *mapPointer = nullptr;
	ANGLE_VK_TRY(contextVk,
	stagingBuffer.getDeviceMemory().map(device, 0, size, 0, &mapPointer));
	ASSERT(mapPointer);

	memcpy(mapPointer, data, size);
	stagingBuffer.getDeviceMemory().unmap(device);

	// Enqueue a copy command on the GPU.
	VkBufferCopy copyRegion = {0, offset, size};
	ANGLE_TRY(mBuffer.copyFromBuffer(contextVk, stagingBuffer.getBuffer(),
	VK_ACCESS_HOST_WRITE_BIT, copyRegion));

	// Immediately release staging buffer. We should probably be using a DynamicBuffer here.
	contextVk->releaseObject(contextVk->getCurrentQueueSerial(), &stagingBuffer);
	}
	else
	{
	uint8_t *mapPointer = nullptr;
	ANGLE_VK_TRY(contextVk,
	mBuffer.getDeviceMemory().map(device, offset, size, 0, &mapPointer));
	ASSERT(mapPointer);

	memcpy(mapPointer, data, size);

	mBuffer.getDeviceMemory().unmap(device);
	mBuffer.onExternalWrite(VK_ACCESS_HOST_WRITE_BIT);
	}

	// Update conversions
	markConversionBuffersDirty();

	return angle::Result::Continue;
	}

	angle::Result BufferVk::copyToBuffer(ContextVk *contextVk,
	vk::BufferHelper *destBuffer,
	uint32_t copyCount,
	const VkBufferCopy *copies)
	{
	vk::CommandBuffer *commandBuffer;
	ANGLE_TRY(destBuffer->recordCommands(contextVk, &commandBuffer));
	commandBuffer->copyBuffer(mBuffer.getBuffer(), destBuffer->getBuffer(), copyCount, copies);

	mBuffer.onReadByBuffer(contextVk, destBuffer, VK_ACCESS_TRANSFER_READ_BIT,
	VK_ACCESS_TRANSFER_WRITE_BIT);

	return angle::Result::Continue;
	}

	ConversionBuffer BufferVk::getVertexConversionBuffer(RendererVk renderer,
	angle::FormatID formatID,
	GLuint stride,
	size_t offset)
	{
	for (VertexConversionBuffer &buffer : mVertexConversionBuffers)
	{
	if (buffer.formatID == formatID && buffer.stride == stride && buffer.offset == offset)
	{
	return &buffer;
	}
	}

	mVertexConversionBuffers.emplace_back(renderer, formatID, stride, offset);
	return &mVertexConversionBuffers.back();
	}

	void BufferVk::markConversionBuffersDirty()
	{
	for (VertexConversionBuffer &buffer : mVertexConversionBuffers)
	{
	buffer.dirty = true;
	}
	}

	void BufferVk::onDataChanged()
	{
	markConversionBuffersDirty();
	}

	} // namespace rx