commit 7602bc36d4d07d8b8526d50ac38fa30a37d6108a
author simon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Dec 05 23:28:37 2019 +0000
committer simon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Dec 05 23:28:37 2019 +0000
tree 10dbeab024accb137ed9f6d7cd40abaec8947928
parent 310734eea315c89c3222626953a39b70d0fa9699

Fix inspector/css test assertions after r253158
https://bugs.webkit.org/show_bug.cgi?id=204924

Reviewed by Devin Rousso.
Source/JavaScriptCore:

Teach the inspector protocol about the ::highlight pseudoelement.

* inspector/protocol/CSS.json:

Source/WebCore:

* inspector/agents/InspectorCSSAgent.cpp:
(WebCore::protocolValueForPseudoId):

Source/WebInspectorUI:

* UserInterface/Controllers/CSSManager.js:
(WI.CSSManager.displayNameForPseudoId):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@253176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog

diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
index 90b986d..e346f0f 100644
--- a/Source/JavaScriptCore/ChangeLog
+++ b/Source/JavaScriptCore/ChangeLog
@@ -45,6 +45,17 @@
         * runtime/VM.cpp:
         (JSC::VM::VM):
 
+2019-12-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Fix inspector/css test assertions after r253158 
+        https://bugs.webkit.org/show_bug.cgi?id=204924
+
+        Reviewed by Devin Rousso.
+        
+        Teach the inspector protocol about the ::highlight pseudoelement.
+
+        * inspector/protocol/CSS.json:
+
 2019-12-04  Yusuke Suzuki  <ysuzuki@apple.com>
 
         [JSC] AI should convert IsCellWithType to constant when Structure set is finite

Source/JavaScriptCore/inspector/protocol/CSS.json

diff --git a/Source/JavaScriptCore/inspector/protocol/CSS.json b/Source/JavaScriptCore/inspector/protocol/CSS.json
index fd12116..f847021 100644
--- a/Source/JavaScriptCore/inspector/protocol/CSS.json
+++ b/Source/JavaScriptCore/inspector/protocol/CSS.json
@@ -38,6 +38,7 @@
             "enum": [
                 "first-line",
                 "first-letter",
+                "highlight",
                 "marker",
                 "before",
                 "after",

Source/WebCore/ChangeLog

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index ea286fe..24257d7 100644
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -117,6 +117,16 @@
         * history/BackForwardItemIdentifier.h:
         (WebCore::operator!=):
 
+2019-12-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Fix inspector/css test assertions after r253158 
+        https://bugs.webkit.org/show_bug.cgi?id=204924
+
+        Reviewed by Devin Rousso.
+
+        * inspector/agents/InspectorCSSAgent.cpp:
+        (WebCore::protocolValueForPseudoId):
+
 2019-12-05  Zalan Bujtas  <zalan@apple.com>
 
         [LFC][IFC] Trim trailing letter-spacing at inline container boundary

Source/WebCore/inspector/agents/InspectorCSSAgent.cpp

diff --git a/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp b/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp
index 47d5933..4fda224 100644
--- a/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp
+++ b/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp
@@ -442,6 +442,8 @@
         return Inspector::Protocol::CSS::PseudoId::After;
     case PseudoId::Selection:
         return Inspector::Protocol::CSS::PseudoId::Selection;
+    case PseudoId::Highlight:
+        return Inspector::Protocol::CSS::PseudoId::Highlight;
     case PseudoId::Scrollbar:
         return Inspector::Protocol::CSS::PseudoId::Scrollbar;
     case PseudoId::ScrollbarThumb:

Source/WebInspectorUI/ChangeLog

diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
index cac8e4d..e88906f 100644
--- a/Source/WebInspectorUI/ChangeLog
+++ b/Source/WebInspectorUI/ChangeLog
@@ -226,6 +226,16 @@
         * UserInterface/Views/LogContentView.js:
         (WI.LogContentView.prototype.get supportsCustomFindBanner):
 
+2019-12-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Fix inspector/css test assertions after r253158 
+        https://bugs.webkit.org/show_bug.cgi?id=204924
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Controllers/CSSManager.js:
+        (WI.CSSManager.displayNameForPseudoId):
+
 2019-12-04  Yury Semikhatsky  <yurys@chromium.org>
 
         Web Inspector: allow inspector to pause provisional page load and restore its state

Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js

diff --git a/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js b/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js
index c049508..6086f81 100644
--- a/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js
+++ b/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js
@@ -142,6 +142,8 @@
             return WI.unlocalizedString("::first-line");
         case CSSManager.PseudoSelectorNames.FirstLetter:
             return WI.unlocalizedString("::first-letter");
+        case CSSManager.PseudoSelectorNames.Highlight:
+            return WI.unlocalizedString("::highlight");
         case CSSManager.PseudoSelectorNames.Marker:
             return WI.unlocalizedString("::marker");
         case CSSManager.PseudoSelectorNames.Before:
@@ -751,6 +753,7 @@
     Before: "before",
     FirstLetter: "first-letter",
     FirstLine: "first-line",
+    Highlight: "highlight",
     Marker: "marker",
     Resizer: "resizer",
     Scrollbar: "scrollbar",