| # Copyright (C) 2010 Google Inc. All rights reserved. |
| # Copyright (C) 2010 Chris Jerdonek (chris.jerdonek@gmail.com) |
| # Copyright (C) 2010 ProFUSION embedded systems |
| # |
| # Redistribution and use in source and binary forms, with or without |
| # modification, are permitted provided that the following conditions are |
| # met: |
| # |
| # * Redistributions of source code must retain the above copyright |
| # notice, this list of conditions and the following disclaimer. |
| # * Redistributions in binary form must reproduce the above |
| # copyright notice, this list of conditions and the following disclaimer |
| # in the documentation and/or other materials provided with the |
| # distribution. |
| # * Neither the name of Google Inc. nor the names of its |
| # contributors may be used to endorse or promote products derived from |
| # this software without specific prior written permission. |
| # |
| # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS |
| # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT |
| # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR |
| # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT |
| # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, |
| # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT |
| # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, |
| # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY |
| # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
| # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
| # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
| |
| import logging |
| import re |
| |
| from webkitpy.common.checkout.diff_parser import DiffParser |
| from webkitpy.common.system.executive import Executive |
| from webkitpy.common.system.filesystem import FileSystem |
| from webkitpy.common.checkout.scm.detection import SCMDetector |
| from webkitpy.common.unicode_compatibility import decode_for |
| |
| |
| _log = logging.getLogger(__name__) |
| |
| |
| class PatchReader(object): |
| """Supports checking style in patches.""" |
| |
| def __init__(self, text_file_reader): |
| """Create a PatchReader instance. |
| |
| Args: |
| text_file_reader: A TextFileReader instance. |
| |
| """ |
| self._text_file_reader = text_file_reader |
| |
| def check(self, patch_string, fs=None): |
| """Check style in the given patch.""" |
| fs = fs or FileSystem() |
| patch_string = decode_for(patch_string, str) |
| patch_files = DiffParser(patch_string.splitlines()).files |
| |
| # If the user uses git, checking subversion config file only once is enough. |
| call_only_once = True |
| |
| for path, diff_file in patch_files.items(): |
| line_numbers = diff_file.added_or_modified_line_numbers() |
| _log.debug('Found %s new or modified lines in: %s' % (len(line_numbers), path)) |
| |
| if not line_numbers: |
| match = re.search("\s*png$", path) |
| if match and fs.exists(path): |
| if call_only_once: |
| self._text_file_reader.process_file(file_path=path, line_numbers=None) |
| cwd = FileSystem().getcwd() |
| detection = SCMDetector(fs, Executive()).detect_scm_system(cwd) |
| if detection.display_name() == "git": |
| call_only_once = False |
| continue |
| # Don't check files which contain only deleted lines |
| # as they can never add style errors. However, mark them as |
| # processed so that we count up number of such files. |
| self._text_file_reader.delete_file(path) |
| continue |
| |
| self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers) |
| self._text_file_reader.do_association_check(fs.getcwd()) |