commit 5c872d712e827c7a871568bf12c0ca04f5ad2899
author Hironori.Fujii@sony.com <Hironori.Fujii@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Dec 05 05:02:51 2019 +0000
committer Hironori.Fujii@sony.com <Hironori.Fujii@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Dec 05 05:02:51 2019 +0000
tree fc09366554f024308ffac2925756c1100cf062bf
parent 238989b5878a3f91a479e0d39be05be08bf7f68d

run-javascriptcore-tests is failing to run testmasm of 64bit AppleWin on Buildbot
https://bugs.webkit.org/show_bug.cgi?id=204869

Reviewed by Per Arne Vollan.

testmasm is compiled only when DEVELOPER_MODE.
Enable DEVELOPER_MODE for all 64bit Windows builds.

* Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject): Replaced "isFTW() || isWinCairo()" with isWin64()
in the condition of enabling DEVELOPER_MODE.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@253142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index b9f775d..a6b6c10 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,17 @@
+2019-12-04  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        run-javascriptcore-tests is failing to run testmasm of 64bit AppleWin on Buildbot
+        https://bugs.webkit.org/show_bug.cgi?id=204869
+
+        Reviewed by Per Arne Vollan.
+
+        testmasm is compiled only when DEVELOPER_MODE.
+        Enable DEVELOPER_MODE for all 64bit Windows builds.
+
+        * Scripts/webkitdirs.pm:
+        (generateBuildSystemFromCMakeProject): Replaced "isFTW() || isWinCairo()" with isWin64()
+        in the condition of enabling DEVELOPER_MODE.
+
 2019-12-04  Jonathan Bedard  <jbedard@apple.com>
 
         results.webkit.org: Decrease ttl for archives

Tools/Scripts/webkitdirs.pm

diff --git a/Tools/Scripts/webkitdirs.pm b/Tools/Scripts/webkitdirs.pm
index 0653970..6408593 100755
--- a/Tools/Scripts/webkitdirs.pm
+++ b/Tools/Scripts/webkitdirs.pm
@@ -2273,7 +2273,7 @@
     push @args, '-DSHOW_BINDINGS_GENERATION_PROGRESS=1' unless ($willUseNinja && -t STDOUT);
 
     # Some ports have production mode, but build-webkit should always use developer mode.
-    push @args, "-DDEVELOPER_MODE=ON" if isFTW() || isGtk() || isJSCOnly() || isWPE() || isWinCairo();
+    push @args, "-DDEVELOPER_MODE=ON" if isGtk() || isJSCOnly() || isWPE() || isWin64();
 
     if (architecture() eq "x86_64" && shouldBuild32Bit()) {
         # CMAKE_LIBRARY_ARCHITECTURE is needed to get the right .pc