| 2009-06-16 Antti Koivisto <antti@apple.com> |
| |
| Reviewed by Brady Eidson. |
| |
| <rdar://problem/6660037> CrashTracer: [USER] 46 crashes in Safari at com.apple.WebCore • WebCore::CachedCSSStyleSheet::addClient + 53 |
| |
| When revalidating a resource, calling addClient() on one client might cause another to get removed. |
| |
| - made CachedResource::addClient() non-virtual and added virtual didAddClient() |
| - in CachedResource::switchClientsToRevalidatedResource() add all clients to the client set of the revalidated resource first |
| - check if the client is still in the set before invoking didAddClient() for it |
| |
| No test case, I didn't manage to construct one. You need some combination of 304 revalidation, stylesheets that |
| reference each other via @imports and reloading. |
| |
| * WebCore.base.exp: |
| * loader/CachedCSSStyleSheet.cpp: |
| (WebCore::CachedCSSStyleSheet::didAddClient): |
| * loader/CachedCSSStyleSheet.h: |
| * loader/CachedFont.cpp: |
| (WebCore::CachedFont::didAddClient): |
| * loader/CachedFont.h: |
| * loader/CachedImage.cpp: |
| (WebCore::CachedImage::didAddClient): |
| * loader/CachedImage.h: |
| * loader/CachedResource.cpp: |
| (WebCore::CachedResource::addClient): |
| (WebCore::CachedResource::addClientToSet): |
| (WebCore::CachedResource::switchClientsToRevalidatedResource): |
| * loader/CachedResource.h: |
| * loader/CachedScript.cpp: |
| (WebCore::CachedScript::didAddClient): |
| * loader/CachedScript.h: |
| * loader/CachedXSLStyleSheet.cpp: |
| (WebCore::CachedXSLStyleSheet::didAddClient): |
| * loader/CachedXSLStyleSheet.h: |
| |
| 2009-06-16 Simon Fraser <simon.fraser@apple.com> |
| |
| No Review |
| |
| Fix code inside an #ifdef that draws the video framerate. |
| |
| * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: |
| (WebCore::MediaPlayerPrivate::paint): |
| |
| 2009-06-16 Jian Li <jianli@chromium.org> |
| |
| Reviewed by Dimitri Glazkov. |
| |
| Bug 26456: Hook up V8 bindings for Worker's importScripts functionality. |
| https://bugs.webkit.org/show_bug.cgi?id=26456 |
| |
| * bindings/v8/custom/V8WorkerContextCustom.cpp: |
| (WebCore::CALLBACK_FUNC_DECL): |
| * bindings/v8/custom/V8WorkerCustom.cpp: Fixed missing exception code |
| handling in Worker constructor for V8 bindings. |
| (WebCore::CALLBACK_FUNC_DECL): |
| |
| 2009-06-16 Brent Fulgham <bfulgham@webkit.org> |
| |
| Reviewed by Maciej Stachowiak. |
| |
| Update of https://bugs.webkit.org/show_bug.cgi?id=26353. |
| Provide an assignment operator to avoid improper reference |
| counts on the Cairo font objects. This brings the Windows |
| Cairo port in line with the GTK+ port. |
| |
| * platform/graphics/win/FontPlatformData.h: |
| * platform/graphics/win/FontPlatformDataCairoWin.cpp: |
| (WebCore::FontPlatformData::FontPlatformData): |
| (WebCore::FontPlatformData::operator=): |
| |
| 2009-06-16 Eric Carlson <eric.carlson@apple.com> |
| |
| Reviewed by Simon Fraser. |
| |
| Fix for <rdar://problem/6890126> Theme code should fetch the MediaControlElementType from |
| the MediaControlInputElement, rather than computing it again |
| |
| * html/HTMLMediaElement.cpp: |
| (WebCore::HTMLMediaElement::percentLoaded): New, utility function for controller implementation. |
| * html/HTMLMediaElement.h: |
| |
| * rendering/MediaControlElements.h: |
| (WebCore::MediaControlInputElement::displayType): New, return m_displayType. |
| |
| * rendering/RenderMediaControls.cpp: |
| (WebCore::RenderMediaControls::paintMediaControlsPart): Stop using MediaPlayer object, get button |
| state from the button itself and get movie state from HTMLMediaElement. |
| |
| * rendering/RenderThemeMac.mm: |
| (WebCore::RenderThemeMac::paintMediaMuteButton): Get state from button instead of MediaPlayer. |
| (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto. |
| |
| 2009-06-16 Jian Li <jianli@chromium.org> |
| |
| Reviewed by David Levin. |
| |
| Bug 26450: Rename values of enum RedirectOriginCheck to make them |
| clearer. |
| https://bugs.webkit.org/show_bug.cgi?id=26450 |
| |
| * loader/DocumentThreadableLoader.cpp: |
| (WebCore::DocumentThreadableLoader::create): |
| (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): |
| (WebCore::DocumentThreadableLoader::willSendRequest): |
| * loader/DocumentThreadableLoader.h: |
| * loader/ThreadableLoader.cpp: |
| (WebCore::ThreadableLoader::create): |
| (WebCore::ThreadableLoader::loadResourceSynchronously): |
| * loader/ThreadableLoader.h: |
| * workers/Worker.cpp: |
| (WebCore::Worker::Worker): |
| * workers/WorkerContext.cpp: |
| (WebCore::WorkerContext::importScripts): |
| * loader/WorkerThreadableLoader.cpp: |
| (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): |
| (WebCore::WorkerThreadableLoader::loadResourceSynchronously): |
| (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): |
| (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): |
| * loader/WorkerThreadableLoader.h: |
| (WebCore::WorkerThreadableLoader::create): |
| * workers/WorkerScriptLoader.cpp: |
| (WebCore::WorkerScriptLoader::loadSynchronously): |
| (WebCore::WorkerScriptLoader::loadAsynchronously): |
| * workers/WorkerScriptLoader.h: |
| (WebCore::WorkerContext::importScripts): |
| * xml/XMLHttpRequest.cpp: |
| (WebCore::XMLHttpRequest::loadRequestAsynchronously): |
| |
| 2009-06-16 Tony Chang <tony@chromium.org> |
| |
| Reviewed by Darin Fisher. |
| |
| Fix a UMR in WebCore::BitStack by initializing new memory to 0. |
| https://bugs.webkit.org/show_bug.cgi?id=26449 |
| No new tests, covered by purify. |
| |
| * editing/TextIterator.cpp: |
| (WebCore::BitStack::push): |
| |
| 2009-06-16 Brent Fulgham <bfulgham@webkit.org> |
| |
| Reviewed by Xan Lopez. |
| |
| Test: fast/multicol/columns-shorthand-parsing.html |
| |
| Fixes https://bugs.webkit.org/show_bug.cgi?id=26453. |
| Null Cairo contextwill crash Windows Cairo build. |
| |
| * platform/graphics/win/GraphicsContextCairoWin.cpp: |
| (WebCore::GraphicsContextPlatformPrivate::syncContext): |
| Add a check for null context before attempting to |
| retrieve the Cairo surface. |
| |
| 2009-06-16 Peter Kasting <pkasting@google.com> |
| |
| Reviewed by Xan Lopez. |
| |
| https://bugs.webkit.org/show_bug.cgi?id=26447 |
| Fix animated GIF breakage in Cairo/wx ports. |
| |
| * platform/image-decoders/cairo/ImageDecoderCairo.cpp: |
| (WebCore::RGBA32Buffer::copyBitmapData): |
| (WebCore::RGBA32Buffer::operator=): |
| * platform/image-decoders/wx/ImageDecoderWx.cpp: |
| (WebCore::RGBA32Buffer::copyBitmapData): |
| (WebCore::RGBA32Buffer::operator=): |
| |
| 2009-06-16 Pierre d'Herbemont <pdherbemont@apple.com> |
| |
| Reviewed by John Sullivan |
| |
| <rdar://problem/6937882> |
| |
| Tweak "time remaining" and "time elapsed" fields in the overlay video controller. |
| |
| * css/mediaControlsQT.css: |
| |
| 2009-06-16 Jian Li <jianli@chromium.org> |
| |
| Reviewed by Adam Barth and David Levin. |
| |
| Bug 26146: Change to use ThreadableLoader to load the worker script |
| in order to check URL origin for redirection. |
| https://bugs.webkit.org/show_bug.cgi?id=26146 |
| |
| Test: http/tests/workers/worker-redirect.html |
| |
| * GNUmakefile.am: |
| * WebCore.pro: |
| * WebCore.vcproj/WebCore.vcproj: |
| * WebCore.xcodeproj/project.pbxproj: |
| * workers/Worker.cpp: |
| (WebCore::Worker::Worker): |
| (WebCore::Worker::notifyFinished): |
| * workers/Worker.h: |
| * workers/WorkerContext.cpp: |
| (WebCore::WorkerContext::importScripts): |
| * workers/WorkerImportScriptsClient.cpp: Removed. |
| * workers/WorkerImportScriptsClient.h: Removed. |
| * workers/WorkerScriptLoader.cpp: Renamed from workers/WorkerImportScriptsClient.cpp. |
| This to make it more generic so worker script loading could use it. |
| (WebCore::WorkerScriptLoader::loadSynchronously): |
| (WebCore::WorkerScriptLoader::loadAsynchronously): |
| (WebCore::WorkerScriptLoader::didFinishLoading): |
| (WebCore::WorkerScriptLoader::didFail): |
| (WebCore::WorkerScriptLoader::didFailRedirectCheck): |
| (WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation): |
| (WebCore::WorkerScriptLoader::notifyFinished): |
| * workers/WorkerScriptLoader.h: Renamed from workers/WorkerImportScriptsClient.h. |
| This to make it more generic so worker script loading could use it. |
| * workers/WorkerScriptLoaderClient.h: Added. |
| |
| 2009-06-16 Brent Fulgham <bfulgham@gmail.com> |
| |
| Reviewed by Darin Adler. |
| |
| Use consistent GUID comparison functions. |
| https://bugs.webkit.org/show_bug.cgi?id=26427 |
| |
| * platform/win/WCDataObject.cpp: |
| (WebCore::WCDataObject::QueryInterface): |
| |
| 2009-06-16 Xan Lopez <xlopez@igalia.com> |
| |
| Reviewed by Gustavo Noronha. |
| |
| Fix compiler warning. |
| |
| * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: |
| (webkit_accessible_class_init): |
| |
| 2009-06-16 Xan Lopez <xlopez@igalia.com> |
| |
| Reviewed by Gustavo Noronha. |
| |
| Remove dummy AtkStreamableContent implementation. |
| |
| It's completely empty, we'll add it back (and conditionally |
| instead of unconditionally) when it does something. |
| |
| * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: |
| (GetAtkInterfaceTypeFromWAIType): |
| (getInterfaceMaskFromObject): |
| |
| == Rolled over to ChangeLog-2009-06-16 == |
