commit 2e508a9e9c22cbbaf3d93774d4098f24b3c2c0a4
author commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Oct 10 16:37:13 2019 +0000
committer commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Oct 10 16:37:13 2019 +0000
tree 67be378605a65033e84ec37f8ddc9aa516a5e0ee
parent fdc942c5052133d9f3534312553b7ba8c309c092

SpeculativeLoad should use CompletionHandler
https://bugs.webkit.org/show_bug.cgi?id=202795

Patch by Rob Buis <rbuis@igalia.com> on 2019-10-10
Reviewed by Chris Dumez.

SpeculativeLoad should use CompletionHandler, as remarked in
Bug 201641 review.

* NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@250974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog

diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
index 8c636f9..5e1a11b 100644
--- a/Source/WebKit/ChangeLog
+++ b/Source/WebKit/ChangeLog
@@ -1,3 +1,15 @@
+2019-10-10  Rob Buis  <rbuis@igalia.com>
+
+        SpeculativeLoad should use CompletionHandler
+        https://bugs.webkit.org/show_bug.cgi?id=202795
+
+        Reviewed by Chris Dumez.
+
+        SpeculativeLoad should use CompletionHandler, as remarked in
+        Bug 201641 review.
+
+        * NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
+
 2019-10-10  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         Support programmatic paste requests on macOS

Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h

diff --git a/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h b/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h
index 6ce77f9..5406d9f 100644
--- a/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h
+++ b/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h
@@ -33,6 +33,7 @@
 #include <WebCore/ResourceRequest.h>
 #include <WebCore/ResourceResponse.h>
 #include <WebCore/SharedBuffer.h>
+#include <wtf/CompletionHandler.h>
 
 namespace WebKit {
 
@@ -43,7 +44,7 @@
 class SpeculativeLoad final : public NetworkLoadClient {
     WTF_MAKE_FAST_ALLOCATED;
 public:
-    typedef Function<void (std::unique_ptr<NetworkCache::Entry>)> RevalidationCompletionHandler;
+    using RevalidationCompletionHandler = CompletionHandler<void(std::unique_ptr<NetworkCache::Entry>)>;
     SpeculativeLoad(Cache&, const GlobalFrameID&, const WebCore::ResourceRequest&, std::unique_ptr<NetworkCache::Entry>, RevalidationCompletionHandler&&);
 
     virtual ~SpeculativeLoad();