commit 2e2cb00ac8a118644a070f63a7b5ac6a2db0e0aa
author yurys@chromium.org <yurys@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Tue Oct 22 17:04:42 2019 +0000
committer yurys@chromium.org <yurys@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Tue Oct 22 17:04:42 2019 +0000
tree 9ee2291442a1f051e81d43c2585f61d6f8c11dbf
parent 3704311e908f8073a585c6aa68e502a35b075578

[GTK] Web Inspector: add an option for disabling minification and concatenation of inspector UI in release build
https://bugs.webkit.org/show_bug.cgi?id=203201

Reviewed by Carlos Garcia Campos.

Allow passing COMBINE_INSPECTOR_RESOURCES and COMBINE_TEST_RESOURCES as cmake arguments. This
enables to avoid minification of Web Inspector scripts in release binaries which is very
convenient during inspector UI development.

* InspectorGResources.cmake:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@251438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog

diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
index ca950b2..eb90436 100644
--- a/Source/WebKit/ChangeLog
+++ b/Source/WebKit/ChangeLog
@@ -1,3 +1,16 @@
+2019-10-22  Yury Semikhatsky  <yurys@chromium.org>
+
+        [GTK] Web Inspector: add an option for disabling minification and concatenation of inspector UI in release build
+        https://bugs.webkit.org/show_bug.cgi?id=203201
+
+        Reviewed by Carlos Garcia Campos.
+
+        Allow passing COMBINE_INSPECTOR_RESOURCES and COMBINE_TEST_RESOURCES as cmake arguments. This
+        enables to avoid minification of Web Inspector scripts in release binaries which is very
+        convenient during inspector UI development.
+
+        * InspectorGResources.cmake:
+
 2019-10-22  Adrian Perez de Castro  <aperez@igalia.com>
 
         [GTK][WPE] Fix non-unified builds after r251326

Source/WebKit/InspectorGResources.cmake

diff --git a/Source/WebKit/InspectorGResources.cmake b/Source/WebKit/InspectorGResources.cmake
index f46f40e..674b5ef 100644
--- a/Source/WebKit/InspectorGResources.cmake
+++ b/Source/WebKit/InspectorGResources.cmake
@@ -45,15 +45,19 @@
         VERBATIM
     )
 
-    if (CMAKE_BUILD_TYPE STREQUAL "Debug")
-        set(COMBINE_INSPECTOR_RESOURCES NO)
-        set(COMBINE_TEST_RESOURCES YES)
-    elseif (DEVELOPER_MODE)
-        set(COMBINE_INSPECTOR_RESOURCES YES)
-        set(COMBINE_TEST_RESOURCES YES)
-    else ()
-        set(COMBINE_INSPECTOR_RESOURCES YES)
-        set(COMBINE_TEST_RESOURCES NO)
+    if (NOT DEFINED COMBINE_INSPECTOR_RESOURCES)
+        if (CMAKE_BUILD_TYPE STREQUAL "Debug")
+            set(COMBINE_INSPECTOR_RESOURCES NO)
+        else ()
+            set(COMBINE_INSPECTOR_RESOURCES YES)
+        endif ()
+    endif ()
+    if (NOT DEFINED COMBINE_TEST_RESOURCES)
+        if (CMAKE_BUILD_TYPE STREQUAL "Debug" OR DEVELOPER_MODE)
+            set(COMBINE_TEST_RESOURCES YES)
+        else ()
+            set(COMBINE_TEST_RESOURCES NO)
+        endif ()
     endif ()
 
     add_custom_command(