Improve summary for WebKitPerl Tests build step
https://bugs.webkit.org/show_bug.cgi?id=203006
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(RunWebKitPerlTests.getResultSummary): Override method to customize summary.
* BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@251167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Tools/BuildSlaveSupport/ews-build/steps.py b/Tools/BuildSlaveSupport/ews-build/steps.py
index c59aaed..ab1ce4d 100644
--- a/Tools/BuildSlaveSupport/ews-build/steps.py
+++ b/Tools/BuildSlaveSupport/ews-build/steps.py
@@ -603,6 +603,13 @@
def __init__(self, **kwargs):
super(RunWebKitPerlTests, self).__init__(timeout=2 * 60, logEnviron=False, **kwargs)
+ def getResultSummary(self):
+ if self.results == SUCCESS:
+ message = 'Passed webkitperl tests'
+ self.build.buildFinished([message], SUCCESS)
+ return {u'step': unicode(message)}
+ return {u'step': u'Failed webkitperl tests'}
+
class RunBuildWebKitOrgUnitTests(shell.ShellCommand):
name = 'build-webkit-org-unit-tests'
diff --git a/Tools/BuildSlaveSupport/ews-build/steps_unittest.py b/Tools/BuildSlaveSupport/ews-build/steps_unittest.py
index 5b13641..ecf5d0a 100644
--- a/Tools/BuildSlaveSupport/ews-build/steps_unittest.py
+++ b/Tools/BuildSlaveSupport/ews-build/steps_unittest.py
@@ -390,7 +390,7 @@
)
+ 0,
)
- self.expectOutcome(result=SUCCESS, state_string='webkitperl-tests')
+ self.expectOutcome(result=SUCCESS, state_string='Passed webkitperl tests')
return self.runStep()
def test_failure(self):
@@ -407,7 +407,7 @@
Failed 1/40 test programs. 10/630 subtests failed.''')
+ 2,
)
- self.expectOutcome(result=FAILURE, state_string='webkitperl-tests (failure)')
+ self.expectOutcome(result=FAILURE, state_string='Failed webkitperl tests')
return self.runStep()
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index ea397bc..8930b31 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,14 @@
+2019-10-15 Aakash Jain <aakash_jain@apple.com>
+
+ Improve summary for WebKitPerl Tests build step
+ https://bugs.webkit.org/show_bug.cgi?id=203006
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (RunWebKitPerlTests.getResultSummary): Override method to customize summary.
+ * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
+
2019-10-15 Zhifei Fang <zhifei_fang@apple.com>
Tool to mark jsc test skip/enable
