commit 10c4dd89439348ca57e60e642910d80ed6dabfb1
author commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Fri Jul 12 22:51:47 2019 +0000
committer commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Fri Jul 12 22:51:47 2019 +0000
tree c92fc3012a1b524005b3092486237b19d1860c85
parent 8c3835b79338c4dc6e61fad4a61f64f59488c82e

Enable client certificate authentication unit test
https://bugs.webkit.org/show_bug.cgi?id=199735

Patch by Alex Christensen <achristensen@webkit.org> on 2019-07-12
Reviewed by Chris Dumez.

* TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
(TEST):
I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@247404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 72eb8d5..4bd4682 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,5 +1,17 @@
 2019-07-12  Alex Christensen  <achristensen@webkit.org>
 
+        Enable client certificate authentication unit test
+        https://bugs.webkit.org/show_bug.cgi?id=199735
+
+        Reviewed by Chris Dumez.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
+        (TEST):
+        I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
+        I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
+
+2019-07-12  Alex Christensen  <achristensen@webkit.org>
+
         Begin unifying TestWebKitAPI build
         https://bugs.webkit.org/show_bug.cgi?id=199728
 

Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm

diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm
index 99835df..4248f34 100644
--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm
+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm
@@ -145,7 +145,7 @@
 @end
 
 #if HAVE(SEC_KEY_PROXY)
-TEST(Challenge, DISABLED_ClientCertificate)
+TEST(Challenge, ClientCertificate)
 {
     using namespace TestWebKitAPI;
     TCPServer server(TCPServer::Protocol::HTTPSWithClientCertificateRequest, TCPServer::respondWithOK);
@@ -159,7 +159,7 @@
     auto& methods = [delegate authenticationMethods];
     EXPECT_EQ(methods.size(), 2ull);
     EXPECT_TRUE([methods[0] isEqualToString:NSURLAuthenticationMethodServerTrust]);
-    EXPECT_TRUE([methods[2] isEqualToString:NSURLAuthenticationMethodClientCertificate]);
+    EXPECT_TRUE([methods[1] isEqualToString:NSURLAuthenticationMethodClientCertificate]);
 }
 #endif