| 2021-03-24 Jonathan Bedard <jbedard@apple.com> |
| |
| Autoinstalling keyring-7.3.1 is failing with Python 2 |
| https://bugs.webkit.org/show_bug.cgi?id=223677 |
| <rdar://problem/75800504> |
| |
| Reviewed by Dewei Zhu. |
| |
| * Scripts/libraries/webkitcorepy/setup.py: Bump version. |
| * Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version, add setuptools_scm. |
| * Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py: |
| (Package.install): Always install setuptools_scm. |
| |
| 2021-03-24 Chris Fleizach <cfleizach@apple.com> |
| |
| AX: Add functions rectsForTextMarkerRange for testing |
| https://bugs.webkit.org/show_bug.cgi?id=223705 |
| <rdar://problem/75797361> |
| |
| Reviewed by Zalan Bujtas. |
| |
| * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: |
| * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: |
| * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: |
| (WTR::AccessibilityUIElement::rectsForTextMarkerRange): |
| * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: |
| (WTR::AccessibilityUIElement::rectsForTextMarkerRange): |
| * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: |
| (WTR::AccessibilityUIElement::rectsForTextMarkerRange): |
| * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: |
| (WTR::AccessibilityUIElement::rectsForTextMarkerRange): |
| |
| 2021-03-24 Chris Dumez <cdumez@apple.com> |
| |
| Address undefined behavior found by UBSan in StringToIntegerConversion.h |
| https://bugs.webkit.org/show_bug.cgi?id=223694 |
| |
| Reviewed by Geoffrey Garen. |
| |
| Add API test coverage. |
| |
| * TestWebKitAPI/Tests/WTF/StringView.cpp: |
| (TestWebKitAPI::TEST): |
| |
| 2021-03-24 Kate Cheney <katherine_cheney@apple.com> |
| |
| Followup to https://trac.webkit.org/changeset/274928/webkit |
| |
| Unreviewed build fix. |
| |
| * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: |
| |
| 2021-03-24 Brent Fulgham <bfulgham@apple.com> |
| |
| [Cocoa] Revise loadSimulatedRequest API with final review comments (223657) |
| https://bugs.webkit.org/show_bug.cgi?id=223657 |
| <rdar://75757727> |
| |
| Reviewed by Alex Christensen. |
| |
| Update tests to use the final API, while still exercising the existing API. |
| |
| * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm: |
| (TEST): |
| |
| 2021-03-23 Kate Cheney <katherine_cheney@apple.com> |
| |
| Service worker loads are not marked as app-bound |
| https://bugs.webkit.org/show_bug.cgi?id=222635 |
| <rdar://problem/74395950> |
| |
| API test coverage for fetched and synthetic responses to make sure |
| they are marked as app-bound or not based on the main request. |
| |
| Reviewed by Youenn Fablet. |
| |
| * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: |
| |
| 2021-03-23 Chris Dumez <cdumez@apple.com> |
| |
| DerivedSources/WebKitTestRunner/JSAccessibilityUIElement.cpp:802:72: runtime error: -1 is outside the range of representable values of type 'unsigned int' |
| https://bugs.webkit.org/show_bug.cgi?id=223650 |
| |
| Reviewed by Darin Adler. |
| |
| The bindings generator used by WebKitTestRunner was converting all numbers into double and |
| passing that to the implementation, no matter the IDL type (e.g. unsigned long). As a result, |
| there may be a type mismatch between the value the bindings are passing and the implementation |
| function getting called. This implicit conversion has undefined behavior in some cases and it |
| triggers UBSan errors. To address the issue, we now call clampTo<NativeNumberType>() on the |
| double before passing it to the implementation. This makes sure we pass the implementation |
| the type it expects and that the conversion is well-defined. |
| |
| * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: |
| (_generateImplementationFile): |
| (_nativeNumericType): |
| (_platformType): |
| (_platformTypeConstructor): |
| (_platformTypeVariableDeclaration): |
| |
| 2021-03-23 Jiewen Tan <jiewen_tan@apple.com> |
| |
| Provide a way to specify platform vs security key when requesting an assertion in the SPI |
| https://bugs.webkit.org/show_bug.cgi?id=223547 |
| <rdar://74034746> |
| |
| Reviewed by Brent Fulgham. |
| |
| * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: |
| (TestWebKitAPI::TEST): |
| * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm: |
| (TestWebKitAPI::TEST): |
| Adds the test case. |
| |
| 2021-03-23 Chris Dumez <cdumez@apple.com> |
| |
| wtf/text/IntegerToStringConversion.h:54:104: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself |
| https://bugs.webkit.org/show_bug.cgi?id=223614 |
| |
| Reviewed by Darin Adler. |
| |
| Add API test coverage. |
| |
| * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: |
| (TestWebKitAPI::TEST): |
| |
| 2021-03-23 Jonathan Bedard <jbedard@apple.com> |
| |
| [webkitcorepy] Print output of setup.py when install fails |
| https://bugs.webkit.org/show_bug.cgi?id=223589 |
| <rdar://problem/75700606> |
| |
| Reviewed by Aakash Jain. |
| |
| * Scripts/libraries/webkitcorepy/setup.py: Bump version. |
| * Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto. |
| * Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py: |
| (Package.install): Print stdout and stderr of setup.py when install fails. |
| |
| 2021-03-22 Cameron McCormack <heycam@apple.com> |
| |
| Fix ordering of my email addresses in contributors.json |
| https://bugs.webkit.org/show_bug.cgi?id=223622 |
| |
| The first must be the email used for scm access. |
| |
| Reviewed by Ryosuke Niwa. |
| |
| * Scripts/webkitpy/common/config/contributors.json: |
| |
| 2021-03-22 Jonathan Bedard <jbedard@apple.com> |
| |
| [webkitscmpy] Base GitHub mock links on provided remote |
| https://bugs.webkit.org/show_bug.cgi?id=223611 |
| <rdar://problem/75713760> |
| |
| Reviewed by Dewei Zhu. |
| |
| * Scripts/libraries/webkitscmpy/setup.py: Bump version. |
| * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. |
| * Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py: |
| (GitHub.__init__): Standardize mock GitHub path. |
| (GitHub._parents_of_request): Base link path on GitHub remote. |
| * Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py: |
| (TestGitHub): |
| |
| 2021-03-22 Devin Rousso <drousso@apple.com> |
| |
| Remove unused JS and CSS files of media controls |
| https://bugs.webkit.org/show_bug.cgi?id=214955 |
| <rdar://problem/66604040> |
| |
| Reviewed by Eric Carlson. |
| |
| Cocoa platforms are already using modern media controls so there's no reason to keep the old |
| media controls resources/logic around any longer. It just wastes space. |
| |
| The non-iOS Apple controls must be kept though as they are still used on Windows. |
| |
| * WebKitTestRunner/gtk/TestControllerGtk.cpp: |
| (WTR::TestController::platformSpecificFeatureDefaultsForTest const): |
| * WebKitTestRunner/wpe/TestControllerWPE.cpp: |
| (WTR::TestController::platformSpecificFeatureDefaultsForTest const): |
| Replace `ModernMediaControlsEnabled` setting with `ENABLE_MODERN_MEDIA_CONTROLS` build flag. |
| |
| 2021-03-22 Cameron McCormack <heycam@apple.com> |
| |
| Restore my committer status. |
| https://bugs.webkit.org/show_bug.cgi?id=223600 |
| |
| Per email sent to webkit-committers@. |
| |
| Reviewed by Alexey Proskuryakov. |
| |
| * Scripts/webkitpy/common/config/contributors.json: |
| |
| 2021-03-22 Rob Buis <rbuis@igalia.com> |
| |
| [css-contain] Parse CSS contain property |
| https://bugs.webkit.org/show_bug.cgi?id=223252 |
| |
| Reviewed by Darin Adler. |
| |
| Add support for disabling aspect-ratio in win wk1. |
| |
| * DumpRenderTree/TestOptions.cpp: |
| (WTR::TestOptions::defaults): |
| |
| 2021-03-22 Jonathan Bedard <jbedard@apple.com> |
| |
| [webkitscmpy] Allow user to force canonicalization for a specific set of commits |
| https://bugs.webkit.org/show_bug.cgi?id=223579 |
| <rdar://problem/75693154> |
| |
| Reviewed by Aakash Jain. |
| |
| * Scripts/libraries/webkitscmpy/setup.py: Bump version. |
| * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. |
| * Scripts/libraries/webkitscmpy/webkitscmpy/program/canonicalize/__init__.py: |
| (Canonicalize.parser): Add --number argument. |
| (Canonicalize.main): Use --number to set the number of commits to be canonicalized. |
| * Scripts/libraries/webkitscmpy/webkitscmpy/test/canonicalize_unittest.py: |
| (TestCanonicalize.test_number): |
| |
| 2021-03-22 Tyler Wilcock <twilco.o@protonmail.com> |
| |
| AppleWin can't start due to "Failed to determine path to AAS directory." because iTunes changed the registry key |
| https://bugs.webkit.org/show_bug.cgi?id=219015 |
| |
| Reviewed by Alex Christensen. |
| |
| It appears that iTunes no longer sets the Apple Application Support |
| registry entry. Fallback to trying to find the iTunes installation |
| directory if the AAS directory is not present. |
| |
| * win/DLLLauncher/DLLLauncherMain.cpp: |
| (iTunesDirectory): Added. |
| (modifyPath): |
| |
| 2021-03-19 Darin Adler <darin@apple.com> |
| |
| [Cocoa] Make it possible to release a WKWebView on a non-main thread without a crash due to WKScriptMessage race |
| https://bugs.webkit.org/show_bug.cgi?id=222336 |
| |
| Reviewed by Chris Dumez. |
| |
| * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: |
| Use _close instead of WKWebView deallocation to trigger a call to stopURLSchemeTask, |
| since such delegate methods will intentionally no longer be delivered if triggered by deallocation. |
| |
| 2021-03-22 Youenn Fablet <youenn@apple.com> |
| |
| Implement RTCDataChannel transfer out of process |
| https://bugs.webkit.org/show_bug.cgi?id=223443 |
| |
| Reviewed by Eric Carlson. |
| |
| * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| |
| 2021-03-22 Youenn Fablet <youenn@apple.com> |
| |
| Remove some spurious logging lines appearing in WebRTC tests |
| https://bugs.webkit.org/show_bug.cgi?id=223502 |
| |
| Reviewed by Alex Christensen. |
| |
| * Scripts/webkitpy/port/mac.py: |
| (MacPort.logging_patterns_to_strip): |
| |
| 2021-03-22 Jean-Yves Avenard <jya@apple.com> |
| |
| Add Jean-Yves Avenard to contributors.json |
| https://bugs.webkit.org/show_bug.cgi?id=223555 |
| |
| Reviewed by Eric Carlson. |
| |
| * Scripts/webkitpy/common/config/contributors.json: |
| |
| 2021-03-19 BJ Burg <bburg@apple.com> |
| |
| Update filter-build-webkit |
| https://bugs.webkit.org/show_bug.cgi?id=223528 |
| |
| Reviewed by Simon Fraser. |
| |
| - Remove a bunch of informational messages that clog up output. |
| - Remove some linker/loader warnings that are non-actionable. |
| - Generalize a few existing filters to work with more targets. |
| - Remove super-noisy and meaningless device preparation warnings. |
| |
| * Scripts/filter-build-webkit: |
| (shouldIgnoreLine): |
| |
| 2021-03-19 Kimmo Kinnunen <kkinnunen@apple.com> |
| |
| update-webgl-conformance-tests script should use webgl/1.0.x and webgl/2.0.y directories |
| https://bugs.webkit.org/show_bug.cgi?id=223516 |
| |
| Reviewed by Kenneth Russell. |
| |
| Import the tests to 1.0.x/2.0.y instead of 1.0.4/2.0.1 since we track the development |
| versions, not the upcoming snapshots. |
| |
| * Scripts/webkitpy/update_webgl_conformance_tests_lib/main.py: |
| (_generate_webkit_webgl_tests): |
| (main): |
| |
| 2021-03-19 Youenn Fablet <youenn@apple.com> |
| |
| Custom scheme handled origins should be considered secure |
| https://bugs.webkit.org/show_bug.cgi?id=223423 |
| |
| Reviewed by Alex Christensen. |
| |
| * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: |
| * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: |
| (-[URLSchemeHandlerMessageHandler userContentController:didReceiveScriptMessage:]): |
| |
| 2021-03-19 Aakash Jain <aakash_jain@apple.com> |
| |
| Fix broken contributors.json after r274720 |
| |
| Unreviewed infrastructure fix. |
| |
| * Scripts/webkitpy/common/config/contributors.json: |
| |
| 2021-03-19 Angelos Oikonomopoulos <angelos@igalia.com> |
| |
| Add myself as to contributors.json as a committer. |
| |
| Unreviewed. |
| |
| * Scripts/webkitpy/common/config/contributors.json: |
| |
| 2021-03-19 Caio Lima <ticaiolima@gmail.com> |
| |
| Update Caio's status to reviewer |
| https://bugs.webkit.org/show_bug.cgi?id=223509 |
| |
| Unreviewed. |
| |
| * Scripts/webkitpy/common/config/contributors.json: |
| |
| 2021-03-19 Youenn Fablet <youenn@apple.com> |
| |
| Disable SFrame compatibility mode for audio senders and receivers |
| https://bugs.webkit.org/show_bug.cgi?id=223391 |
| <rdar://problem/75538500> |
| |
| Reviewed by Eric Carlson. |
| |
| * TestWebKitAPI/Tests/WebCore/RTCRtpSFrameTransformerTests.cpp: |
| (TestWebKitAPI::createVideoTransformer): |
| (TestWebKitAPI::createAudioTransformer): |
| (TestWebKitAPI::TEST): |
| |
| == Rolled over to ChangeLog-2021-03-18 == |
