[CSS Parser] Enable the new sizes parser by default
https://bugs.webkit.org/show_bug.cgi?id=161931
Reviewed by Zalan Bujtas.
Source/WebCore:
Added new tests in fast/dom/HTMLImageElement/sizes.
* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSGrammar.y.in:
Remove the old code that parsed source size lists.
* css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::MediaQueryEvaluator):
* css/MediaQueryEvaluator.h:
Change to take a const Document&, since the Document is not modified.
* css/SourceSizeList.cpp: Removed.
* css/SourceSizeList.h: Removed.
* css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseSizesAttribute): Deleted.
(WebCore::CSSParser::SourceSize::SourceSize): Deleted.
(WebCore::CSSParser::sourceSize): Deleted.
* css/parser/CSSParser.h:
Remove the old sizes processing code.
* css/parser/MediaQueryParser.cpp:
(WebCore::MediaQueryParser::skipUntilComma):
(WebCore::MediaQueryParser::parseInternal):
Fix a bug I introduced when modifying this code from Blink. The Nones should have been Nots.
* css/parser/SizesAttributeParser.cpp:
(WebCore::SizesAttributeParser::computeLength):
(WebCore::SizesAttributeParser::SizesAttributeParser):
(WebCore::SizesAttributeParser::calculateLengthInPixels):
(WebCore::SizesAttributeParser::mediaConditionMatches):
(WebCore::SizesAttributeParser::effectiveSizeDefaultValue):
* css/parser/SizesAttributeParser.h:
* css/parser/SizesCalcParser.cpp:
(WebCore::SizesCalcParser::SizesCalcParser):
(WebCore::SizesCalcParser::appendLength):
* css/parser/SizesCalcParser.h:
Make the sizes parsers take a Document, since having separate style and view arguments made
no sense, given that the style used is always the view's.
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
(WebCore::HTMLImageElement::selectImageSource):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
Switch image elements and the preload scanner over to the new code.
LayoutTests:
* fast/dom/HTMLImageElement/resources/green-16x16.png: Added.
* fast/dom/HTMLImageElement/resources/green-1x1.png: Added.
* fast/dom/HTMLImageElement/sizes/image-sizes-invalids-expected.txt:
* fast/dom/HTMLImageElement/sizes/image-sizes-invalids.html:
* fast/dom/HTMLImageElement/sizes/image-sizes-w3c-1-expected.txt: Added.
* fast/dom/HTMLImageElement/sizes/image-sizes-w3c-1.html: Added.
* fast/dom/HTMLImageElement/sizes/image-sizes-w3c-2-expected.txt: Added.
* fast/dom/HTMLImageElement/sizes/image-sizes-w3c-2.html: Added.
* fast/dom/HTMLImageElement/sizes/image-sizes-w3c-3-expected.txt: Added.
* fast/dom/HTMLImageElement/sizes/image-sizes-w3c-3.html: Added.
* fast/dom/HTMLImageElement/sizes/image-sizes-w3c-4-expected.txt: Added.
* fast/dom/HTMLImageElement/sizes/image-sizes-w3c-4.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@205905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebCore/css/MediaQueryEvaluator.h b/Source/WebCore/css/MediaQueryEvaluator.h
index 5fa8c27..140acff 100644
--- a/Source/WebCore/css/MediaQueryEvaluator.h
+++ b/Source/WebCore/css/MediaQueryEvaluator.h
@@ -56,7 +56,7 @@
MediaQueryEvaluator(const String& acceptedMediaType, bool mediaFeatureResult = false);
// Creates evaluator which evaluates full media queries.
- WEBCORE_EXPORT MediaQueryEvaluator(const String& acceptedMediaType, Document&, const RenderStyle*);
+ WEBCORE_EXPORT MediaQueryEvaluator(const String& acceptedMediaType, const Document&, const RenderStyle*);
bool mediaTypeMatch(const String& mediaTypeToMatch) const;
bool mediaTypeMatchSpecific(const char* mediaTypeToMatch) const;
