tree 70cb7652f87f7f6610650ddffa5a7ad25dfe4694
parent 5dd35cf5a371f5723c7a5bb049efba3586631d0d
author zalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1408545896 +0000
committer zalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1408545896 +0000

Dashed/dotted borders do not paint.
https://bugs.webkit.org/show_bug.cgi?id=135898

Reviewed by Simon Fraser.

Source/WebCore:

Remove the empty line checks for drawLines. There's no need to protect the graphics
context from empty lines.

Tests: fast/borders/border-painting-dashed-at-all.html
       fast/borders/border-painting-dashed.html
       fast/borders/border-painting-dotted-at-all.html
       fast/borders/border-painting-dotted.html
       fast/borders/border-painting-double-at-all.html
       fast/borders/border-painting-double.html
       fast/borders/border-painting-groove-at-all.html
       fast/borders/border-painting-inset-at-all.html
       fast/borders/border-painting-inset.html
       fast/borders/border-painting-outset-at-all.html
       fast/borders/border-painting-outset.html
       fast/borders/border-painting-ridge-at-all.html
       fast/borders/border-painting-solid-at-all.html
       fast/borders/border-painting-solid.html
       fast/borders/hidpi-border-painting-groove.html
       fast/borders/hidpi-border-painting-ridge.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::drawBorderLineRect): Deleted.
(WebCore::drawBorderLine): Deleted.

LayoutTests:

*-at-all files test that we always paint borders.
The other set of files test that borders are painted properly. They take
advantage of the fact that borders with radius use a different painting code path.

* TestExpectations:
* fast/borders/border-painting-dashed-at-all-expected.html: Added.
* fast/borders/border-painting-dashed-at-all.html: Added.
* fast/borders/border-painting-dashed-expected.html: Added.
* fast/borders/border-painting-dashed.html: Added.
* fast/borders/border-painting-dotted-at-all-expected.html: Added.
* fast/borders/border-painting-dotted-at-all.html: Added.
* fast/borders/border-painting-dotted-expected.html: Added.
* fast/borders/border-painting-dotted.html: Added.
* fast/borders/border-painting-double-at-all-expected.html: Added.
* fast/borders/border-painting-double-at-all.html: Added.
* fast/borders/border-painting-double-expected.html: Added.
* fast/borders/border-painting-double.html: Added.
* fast/borders/border-painting-groove-at-all-expected.html: Added.
* fast/borders/border-painting-groove-at-all.html: Added.
* fast/borders/border-painting-inset-at-all-expected.html: Added.
* fast/borders/border-painting-inset-at-all.html: Added.
* fast/borders/border-painting-inset-expected.html: Added.
* fast/borders/border-painting-inset.html: Added.
* fast/borders/border-painting-outset-at-all-expected.html: Added.
* fast/borders/border-painting-outset-at-all.html: Added.
* fast/borders/border-painting-outset-expected.html: Added.
* fast/borders/border-painting-outset.html: Added.
* fast/borders/border-painting-ridge-at-all-expected.html: Added.
* fast/borders/border-painting-ridge-at-all.html: Added.
* fast/borders/border-painting-solid-at-all-expected.html: Added.
* fast/borders/border-painting-solid-at-all.html: Added.
* fast/borders/border-painting-solid-expected.html: Added.
* fast/borders/border-painting-solid.html: Added.
* fast/borders/hidpi-border-painting-groove-expected.html: Added.
* fast/borders/hidpi-border-painting-groove.html: Added.
* fast/borders/hidpi-border-painting-ridge-expected.html: Added.
* fast/borders/hidpi-border-painting-ridge.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@172797 268f45cc-cd09-0410-ab3c-d52691b4dbfc