Remove useless isConnected() check from HTMLDialogElement::close()
https://bugs.webkit.org/show_bug.cgi?id=231722
Reviewed by Antti Koivisto.
No behavior change.
Element::focus() already early returns if the element is disconnected, so it is redundant.
* html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::close):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@284149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 6c2c66d..a889d58 100644
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2021-10-14 Tim Nguyen <ntim@apple.com>
+
+ Remove useless isConnected() check from HTMLDialogElement::close()
+ https://bugs.webkit.org/show_bug.cgi?id=231722
+
+ Reviewed by Antti Koivisto.
+
+ No behavior change.
+
+ Element::focus() already early returns if the element is disconnected, so it is redundant.
+
+ * html/HTMLDialogElement.cpp:
+ (WebCore::HTMLDialogElement::close):
+
2021-10-13 Rob Buis <rbuis@igalia.com>
Determine viewport distances for lazy image loading
diff --git a/Source/WebCore/html/HTMLDialogElement.cpp b/Source/WebCore/html/HTMLDialogElement.cpp
index 76d6a1d..2f98298 100644
--- a/Source/WebCore/html/HTMLDialogElement.cpp
+++ b/Source/WebCore/html/HTMLDialogElement.cpp
@@ -95,7 +95,7 @@
if (isInTopLayer())
removeFromTopLayer();
- if (RefPtr element = std::exchange(m_previouslyFocusedElement, nullptr).get(); element && element->isConnected()) {
+ if (RefPtr element = std::exchange(m_previouslyFocusedElement, nullptr).get()) {
FocusOptions options;
options.preventScroll = true;
element->focus(options);
