commit | f80908babbb375ca7d63f86822c412ecd63331db | [log] [tgz] |
---|---|---|
author | achristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Fri Oct 27 00:37:06 2017 +0000 |
committer | achristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Fri Oct 27 00:37:06 2017 +0000 |
tree | f072bc8879460426c563b10ac8d6b97a65a4f110 | |
parent | 9124e37845ba842a237ef99005f71507dec1ca32 [diff] |
Modernize AccessibilityObject.h https://bugs.webkit.org/show_bug.cgi?id=178892 Reviewed by Tim Horton. The enums in AccessibilityObject.h are causing naming collisions with unified builds. This is what enum classes are for. HashMaps of enum classes still need a few casts to/from int. I also made some RefPtr's Ref's, use some initializer lists instead of values in the constructor implementation, and indentation fixing. No change in behavior. * accessibility/AXObjectCache.cpp: (WebCore::AXComputedObjectAttributeCache::getIgnored const): (WebCore::AXObjectCache::~AXObjectCache): (WebCore::AXObjectCache::getOrCreate): (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::notificationPostTimerFired): * accessibility/AXObjectCache.h: (WebCore::AXComputedObjectAttributeCache::CachedAXObjectAttributes::CachedAXObjectAttributes): (WebCore::AXComputedObjectAttributeCache::getIgnored const): * accessibility/AccessibilityARIAGrid.cpp: (WebCore::AccessibilityARIAGrid::addChildren): * accessibility/AccessibilityARIAGridCell.cpp: (WebCore::AccessibilityARIAGridCell::parentRowGroup const): * accessibility/AccessibilityARIAGridRow.cpp: (WebCore::AccessibilityARIAGridRow::headerObject): * accessibility/AccessibilityAttachment.cpp: (WebCore::AccessibilityAttachment::accessibilityText): * accessibility/AccessibilityAttachment.h: * accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::roleValue const): (WebCore::AccessibilityImageMapLink::accessibilityText): * accessibility/AccessibilityLabel.cpp: (WebCore::childrenContainOnlyStaticText): * accessibility/AccessibilityLabel.h: * accessibility/AccessibilityList.cpp: (WebCore::AccessibilityList::isUnorderedList const): (WebCore::AccessibilityList::isOrderedList const): (WebCore::AccessibilityList::determineAccessibilityRole): (WebCore::AccessibilityList::roleValue const): * accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::setSelectedChildren): (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject const): * accessibility/AccessibilityListBox.h: * accessibility/AccessibilityListBoxOption.h: * accessibility/AccessibilityMathMLElement.cpp: (WebCore::AccessibilityMathMLElement::determineAccessibilityRole): (WebCore::AccessibilityMathMLElement::isMathScriptObject const): (WebCore::AccessibilityMathMLElement::isMathMultiscriptObject const): * accessibility/AccessibilityMediaControls.cpp: (WebCore::AccessibilityMediaControl::accessibilityText): (WebCore::AccessibilityMediaControl::roleValue const): * accessibility/AccessibilityMediaControls.h: * accessibility/AccessibilityMenuList.cpp: (WebCore::AccessibilityMenuList::addChildren): * accessibility/AccessibilityMenuList.h: * accessibility/AccessibilityMenuListOption.h: * accessibility/AccessibilityMenuListPopup.cpp: (WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject const): * accessibility/AccessibilityMenuListPopup.h: * accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::AccessibilityNodeObject): (WebCore::AccessibilityNodeObject::determineAccessibilityRole): (WebCore::AccessibilityNodeObject::canHaveChildren const): (WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored const): (WebCore::AccessibilityNodeObject::isSearchField const): (WebCore::AccessibilityNodeObject::isImage const): (WebCore::AccessibilityNodeObject::isPasswordField const): (WebCore::AccessibilityNodeObject::isInputImage const): (WebCore::AccessibilityNodeObject::isProgressIndicator const): (WebCore::AccessibilityNodeObject::isSlider const): (WebCore::AccessibilityNodeObject::isMenuRelated const): (WebCore::AccessibilityNodeObject::isMenu const): (WebCore::AccessibilityNodeObject::isMenuBar const): (WebCore::AccessibilityNodeObject::isMenuButton const): (WebCore::AccessibilityNodeObject::isMenuItem const): (WebCore::AccessibilityNodeObject::isEnabled const): (WebCore::AccessibilityNodeObject::isChecked const): (WebCore::AccessibilityNodeObject::supportsRequiredAttribute const): (WebCore::AccessibilityNodeObject::headingLevel const): (WebCore::AccessibilityNodeObject::isHeading const): (WebCore::AccessibilityNodeObject::isLink const): (WebCore::AccessibilityNodeObject::isGroup const): (WebCore::AccessibilityNodeObject::selectedRadioButton): (WebCore::AccessibilityNodeObject::checkboxOrRadioValue const): (WebCore::AccessibilityNodeObject::actionElement const): (WebCore::AccessibilityNodeObject::alterSliderValue): (WebCore::AccessibilityNodeObject::isGenericFocusableElement const): (WebCore::AccessibilityNodeObject::menuElementForMenuButton const): (WebCore::AccessibilityNodeObject::menuItemElementForMenu const): (WebCore::AccessibilityNodeObject::titleElementText const): (WebCore::AccessibilityNodeObject::alternativeText const): (WebCore::AccessibilityNodeObject::visibleText const): (WebCore::AccessibilityNodeObject::helpText const): (WebCore::AccessibilityNodeObject::accessibilityText): (WebCore::AccessibilityNodeObject::ariaLabeledByText const): (WebCore::AccessibilityNodeObject::accessibilityDescription const): (WebCore::AccessibilityNodeObject::roleIgnoresTitle const): (WebCore::AccessibilityNodeObject::hierarchicalLevel const): (WebCore::AccessibilityNodeObject::title const): (WebCore::AccessibilityNodeObject::text const): (WebCore::AccessibilityNodeObject::stringValue const): (WebCore::AccessibilityNodeObject::determineAriaRoleAttribute const): (WebCore::AccessibilityNodeObject::remapAriaRoleDueToParent const): (WebCore::AccessibilityNodeObject::canSetSelectedAttribute const): * accessibility/AccessibilityNodeObject.h: * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::detach): (WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex): (WebCore::AccessibilityObject::accessibleNameDerivesFromContent const): (WebCore::AccessibilityObject::isBlockquote const): (WebCore::AccessibilityObject::isTextControl const): (WebCore::AccessibilityObject::isARIATextControl const): (WebCore::AccessibilityObject::isLandmark const): (WebCore::AccessibilityObject::findMatchingObjects): (WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection const): (WebCore::AccessibilityObject::selectText): (WebCore::AccessibilityObject::isARIAInput): (WebCore::AccessibilityObject::isARIAControl): (WebCore::AccessibilityObject::isRangeControl const): (WebCore::AccessibilityObject::visiblePositionForBounds const): (WebCore::AccessibilityObject::supportsARIAReadOnly const): (WebCore::AccessibilityObject::ariaReadOnlyValue const): (WebCore::AccessibilityObject::headingElementForNode): (WebCore::AccessibilityObject::ariaTreeRows): (WebCore::AccessibilityObject::ariaTreeItemContent): (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows): (WebCore::AccessibilityObject::defaultLiveRegionStatusForRole): (WebCore::AccessibilityObject::actionVerb const): (WebCore::AccessibilityObject::ariaCurrentState const): (WebCore::AccessibilityObject::ariaCurrentValue const): (WebCore::AccessibilityObject::orientation const): (WebCore::initializeRoleMap): (WebCore::AccessibilityObject::ariaRoleToWebCoreRole): (WebCore::AccessibilityObject::computedRoleString const): (WebCore::AccessibilityObject::supportsPressAction const): (WebCore::AccessibilityObject::sortDirection const): (WebCore::AccessibilityObject::supportsExpanded const): (WebCore::AccessibilityObject::isExpanded const): (WebCore::AccessibilityObject::supportsChecked const): (WebCore::AccessibilityObject::checkboxOrRadioValue const): (WebCore::AccessibilityObject::scrollByPage const): (WebCore::AccessibilityObject::lastKnownIsIgnoredValue): (WebCore::AccessibilityObject::setLastKnownIsIgnoredValue): (WebCore::AccessibilityObject::buttonRoleType const): (WebCore::AccessibilityObject::isButton const): (WebCore::AccessibilityObject::accessibilityIsIgnoredByDefault const): (WebCore::AccessibilityObject::defaultObjectInclusion const): (WebCore::AccessibilityObject::accessibilityIsIgnored const): (WebCore::AccessibilityObject::isContainedByPasswordField const): (WebCore::AccessibilityObject::AccessibilityObject): Deleted. * accessibility/AccessibilityObject.h: (WebCore::AccessibilityText::AccessibilityText): (WebCore::AccessibilityIsIgnoredFromParentData::AccessibilityIsIgnoredFromParentData): (WebCore::AccessibilityObject::isImageMap const): (WebCore::AccessibilityObject::isWebArea const): (WebCore::AccessibilityObject::isCheckbox const): (WebCore::AccessibilityObject::isRadioButton const): (WebCore::AccessibilityObject::isListBox const): (WebCore::AccessibilityObject::isSpinButton const): (WebCore::AccessibilityObject::isSwitch const): (WebCore::AccessibilityObject::isToggleButton const): (WebCore::AccessibilityObject::isTabList const): (WebCore::AccessibilityObject::isTabItem const): (WebCore::AccessibilityObject::isRadioGroup const): (WebCore::AccessibilityObject::isComboBox const): (WebCore::AccessibilityObject::isTree const): (WebCore::AccessibilityObject::isTreeGrid const): (WebCore::AccessibilityObject::isTreeItem const): (WebCore::AccessibilityObject::isScrollbar const): (WebCore::AccessibilityObject::isListItem const): (WebCore::AccessibilityObject::isScrollView const): (WebCore::AccessibilityObject::isCanvas const): (WebCore::AccessibilityObject::isPopUpButton const): (WebCore::AccessibilityObject::isColorWell const): (WebCore::AccessibilityObject::isSplitter const): (WebCore::AccessibilityObject::isToolbar const): (WebCore::AccessibilityObject::isSummary const): (WebCore::AccessibilityObject::isStaticText const): (WebCore::AccessibilityObject::ariaRoleAttribute const): (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const): * accessibility/AccessibilityProgressIndicator.h: * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::parentObject const): (WebCore::AccessibilityRenderObject::isAttachment const): (WebCore::AccessibilityRenderObject::helpText const): (WebCore::AccessibilityRenderObject::stringValue const): (WebCore::AccessibilityRenderObject::addRadioButtonGroupChildren const): (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers const): (WebCore::AccessibilityRenderObject::linkedUIElements const): (WebCore::AccessibilityRenderObject::isAllowedChildOfTree const): (WebCore::objectInclusionFromAltText): (WebCore::AccessibilityRenderObject::defaultObjectInclusion const): (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const): (WebCore::AccessibilityRenderObject::selectedTextRange const): (WebCore::AccessibilityRenderObject::isTabItemSelected const): (WebCore::AccessibilityRenderObject::isFocused const): (WebCore::AccessibilityRenderObject::setSelectedRows): (WebCore::AccessibilityRenderObject::getDocumentLinks): (WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant const): (WebCore::AccessibilityRenderObject::handleAriaExpandedChanged): (WebCore::AccessibilityRenderObject::supportsExpandedTextValue const): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): (WebCore::AccessibilityRenderObject::orientation const): (WebCore::AccessibilityRenderObject::inheritsPresentationalRole const): (WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren const): (WebCore::AccessibilityRenderObject::canSetExpandedAttribute const): (WebCore::AccessibilityRenderObject::addImageMapChildren): (WebCore::AccessibilityRenderObject::addTextFieldChildren): (WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation): (WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic const): (WebCore::AccessibilityRenderObject::canHaveSelectedChildren const): (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren): (WebCore::AccessibilityRenderObject::selectedChildren): (WebCore::AccessibilityRenderObject::visibleChildren): (WebCore::AccessibilityRenderObject::tabChildren): (WebCore::AccessibilityRenderObject::actionVerb const): (WebCore::msaaRoleForRenderer): (WebCore::AccessibilityRenderObject::roleValueForMSAA const): * accessibility/AccessibilitySVGElement.cpp: (WebCore::AccessibilitySVGElement::accessibilityText): (WebCore::AccessibilitySVGElement::computeAccessibilityIsIgnored const): (WebCore::AccessibilitySVGElement::inheritsPresentationalRole const): (WebCore::AccessibilitySVGElement::determineAriaRoleAttribute const): (WebCore::AccessibilitySVGElement::determineAccessibilityRole): * accessibility/AccessibilitySVGRoot.h: * accessibility/AccessibilityScrollView.cpp: (WebCore::AccessibilityScrollView::scrollBar): * accessibility/AccessibilityScrollView.h: * accessibility/AccessibilityScrollbar.cpp: (WebCore::AccessibilityScrollbar::orientation const): * accessibility/AccessibilityScrollbar.h: * accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation const): (WebCore::AccessibilitySlider::addChildren): * accessibility/AccessibilitySlider.h: * accessibility/AccessibilitySpinButton.cpp: (WebCore::AccessibilitySpinButton::addChildren): * accessibility/AccessibilitySpinButton.h: * accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::hasARIARole const): (WebCore::AccessibilityTable::addChildren): (WebCore::AccessibilityTable::headerContainer): (WebCore::AccessibilityTable::roleValue const): (WebCore::AccessibilityTable::computeAccessibilityIsIgnored const): (WebCore::AccessibilityTable::titleElementText const): * accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored const): (WebCore::AccessibilityTableCell::determineAccessibilityRole): * accessibility/AccessibilityTableColumn.cpp: (WebCore::AccessibilityTableColumn::headerObject): * accessibility/AccessibilityTableColumn.h: * accessibility/AccessibilityTableHeaderContainer.h: * accessibility/AccessibilityTableRow.cpp: (WebCore::AccessibilityTableRow::determineAccessibilityRole): (WebCore::AccessibilityTableRow::computeAccessibilityIsIgnored const): * accessibility/AccessibilityTree.cpp: (WebCore::AccessibilityTree::determineAccessibilityRole): * accessibility/ios/AccessibilityObjectIOS.mm: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const): (WebCore::AccessibilityObject::isInputTypePopupButton const): * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]): (-[WebAccessibilityObjectWrapper _accessibilityIsLandmarkRole:]): (-[WebAccessibilityObjectWrapper _accessibilityTreeAncestor]): (-[WebAccessibilityObjectWrapper _accessibilityListAncestor]): (-[WebAccessibilityObjectWrapper _accessibilityArticleAncestor]): (-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]): (-[WebAccessibilityObjectWrapper _accessibilityTextEntryTraits]): (-[WebAccessibilityObjectWrapper accessibilityTraits]): (-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]): (-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]): (-[WebAccessibilityObjectWrapper accessibilityLabel]): (-[WebAccessibilityObjectWrapper accessibilityValue]): (-[WebAccessibilityObjectWrapper accessibilityIsComboBox]): (-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]): (-[WebAccessibilityObjectWrapper accessibilityLinkedElement]): (-[WebAccessibilityObjectWrapper treeItemParentForObject:]): (-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]): (-[WebAccessibilityObjectWrapper accessibilitySortDirection]): * accessibility/mac/AccessibilityObjectMac.mm: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const): * accessibility/mac/WebAccessibilityObjectWrapperBase.mm: (-[WebAccessibilityObjectWrapperBase baseAccessibilityTitle]): (-[WebAccessibilityObjectWrapperBase baseAccessibilityDescription]): (-[WebAccessibilityObjectWrapperBase baseAccessibilityHelpText]): (-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]): (createAccessibilitySearchKeyMap): (accessibilitySearchKeyForString): (accessibilitySearchCriteriaForSearchPredicateParameterizedAttribute): * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute): (-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]): (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]): (createAccessibilityRoleMap): (roleValueToNSString): (-[WebAccessibilityObjectWrapper role]): (-[WebAccessibilityObjectWrapper subrole]): (-[WebAccessibilityObjectWrapper roleDescription]): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): (-[WebAccessibilityObjectWrapper accessibilityPerformShowMenuAction]): (-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]): * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@224074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
Downloading Safari Technology Preview to test the latest version of WebKit.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
Run the following command to check out WebKit's subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within WebKit.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator.
Install the dependencies by running the following command:
Tools/gtk/install-dependencies
Then run the following command to build additional dependencies:
Tools/Scripts/update-webkitgtk-libs
Run the following command to build WebKit with debugging symbols for GTK+ port:
Tools/Scripts/build-webkit --debug --gtk
Note that the procedure for building a release tarball is different. For more information, see the wiki page.
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.