commit | f766b117556313ef31badda0819d1a9ee2872d8f | [log] [tgz] |
---|---|---|
author | commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Tue Jun 21 23:28:41 2022 +0000 |
committer | commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Tue Jun 21 23:28:41 2022 +0000 |
tree | 7ca93f9da5d4c3d9b9273c62ab9b60cce7c263c5 | |
parent | fb864a74a80c97f88a5a2c602ebd0f9f9422041e [diff] |
getComputedStyle(img).height returns string of a rounded int not a float https://bugs.webkit.org/show_bug.cgi?id=206161 <rdar://93860607> Patch by Sammy Gill <sgill26@apple.com> on 2022-06-21 Reviewed by Alan Bujtas. When computing the logical height/width for a replaced element, we may need to calculate it using (used width) / (intrinsic ratio) or (used height) / (intrinsic ratio). In either case, these are the used values according to the spec, which means they may be floats. Currently, WebKit performs these computations, but it also rounds them leading to an incorrect value. By removing these calls to round, the computed value should line up with what is specified in the spec. As a result of this change, several tests needed to be rebaselined since the generated content was slightly different. In the test cases, there were certain elements that computed a slightly different width/height value, which resulted in different dimensions that were used in the rendering as well as in the output of the tests. Depending on how the dimensions of an element changed, this could have in turn caused a nearby element to get rendered slightly differetly as well. For example, if an element had a slight increase in its height, this could have caused a neighboring element to have a slightly different position in the y dimension. The more of these interactions/differences there are would mean we would see a greater difference in the expected vs actual output (e.g. css1/text_properties/vertical_align.html). However, this change should be seen as a progression when comparing the tests with the results of other browsers. By loading up the tests in other browsers, you can see that the dimensions that are calculated are more in line with the new values generated with this patch. Referenced spec: https://www.w3.org/TR/CSS21/visudet.html#propdef-height * Source/WebCore/rendering/RenderReplaced.cpp: (WebCore::resolveWidthForRatio): (WebCore::RenderReplaced::computeReplacedLogicalWidth const): (WebCore::resolveHeightForRatio): (WebCore::RenderReplaced::computeReplacedLogicalHeight const): * LayoutTests/imported/w3c/web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio-expected.txt: * LayoutTests/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: * LayoutTests/fast/writing-mode/block-level-images-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/replaced-fractional-height-from-aspect-ratio-expected.txt: * LayoutTests/platform/mac/css1/box_properties/width-expected.txt: * LayoutTests/platform/mac/css1/formatting_model/replaced_elements-expected.txt: * LayoutTests/platform/mac/css1/text_properties/vertical_align-expected.txt: * LayoutTests/platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: * LayoutTests/platform/mac/fast/replaced/width100percent-image-expected.txt: * LayoutTests/platform/mac/svg/wicd/test-rightsizing-b-expected.txt: * LayoutTests/platform/mac/tables/mozilla/bugs/bug14929-expected.txt: * LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: * LayoutTests/svg/css/max-width-2-expected.html: * LayoutTests/platform/glib/css2.1/t090501-c414-flt-03-b-g-expected.txt: * LayoutTests/platform/glib/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: * LayoutTests/platform/glib/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: * LayoutTests/platform/gtk/css1/box_properties/width-expected.txt: * LayoutTests/platform/gtk/css1/formatting_model/replaced_elements-expected.txt: * LayoutTests/platform/gtk/css1/text_properties/vertical_align-expected.txt: * LayoutTests/platform/gtk/css2.1/t090501-c414-flt-03-b-g-expected.png: * LayoutTests/platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.png: * LayoutTests/platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt: * LayoutTests/platform/gtk/fast/replaced/width100percent-image-expected.txt: * LayoutTests/platform/gtk/tables/mozilla/bugs/bug14929-expected.txt: * LayoutTests/platform/ios/css1/text_properties/vertical_align-expected.txt: * LayoutTests/platform/ios/fast/replaced/width100percent-image-expected.txt: * LayoutTests/platform/ios/tables/mozilla/bugs/bug14929-expected.txt: * LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: Canonical link: https://commits.webkit.org/251706@main git-svn-id: http://svn.webkit.org/repository/webkit/trunk@295701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone https://github.com/WebKit/WebKit.git WebKit
If you want to be able to track Subversion revision from your git checkout, you can run the following command to do so:
Tools/Scripts/git-webkit setup-git-svn
For information about this, and other aspects of using Git with WebKit, read the wiki page.
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
iOS, tvOS and watchOS are all considered embedded builds. The first time after you install a new Xcode, you will need to run:
sudo Tools/Scripts/configure-xcode-for-embedded-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for embedded simulators:
Tools/Scripts/build-webkit --debug --<platform>-simulator
or embedded devices:
Tools/Scripts/build-webkit --debug --<platform>-device
where platform
is ios
, tvos
or watchos
.
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.