commit f5e6ef275acbaca907e686716ff96c7568ea7068
author commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Oct 14 05:29:16 2021 +0000
committer commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Oct 14 05:29:16 2021 +0000
tree 8385112668f858fa52af2224466063283b198d6d
parent 8de65360573ba9348f2e13e7062a9286d5fb08e8

Determine viewport distances for lazy image loading
https://bugs.webkit.org/show_bug.cgi?id=203557

Patch by Rob Buis <rbuis@igalia.com> on 2021-10-13
Reviewed by Simon Fraser.

Determine appropriate lazy image loading viewport distances
for desktop and mobile devices by using a lazy load distance
of one viewport in all directions.

* html/LazyLoadImageObserver.cpp:
(WebCore::LazyLoadImageObserver::intersectionObserver):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@284148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index e5d2029..6c2c66d 100644
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2021-10-13  Rob Buis  <rbuis@igalia.com>
+
+        Determine viewport distances for lazy image loading
+        https://bugs.webkit.org/show_bug.cgi?id=203557
+
+        Reviewed by Simon Fraser.
+
+        Determine appropriate lazy image loading viewport distances
+        for desktop and mobile devices by using a lazy load distance
+        of one viewport in all directions.
+
+        * html/LazyLoadImageObserver.cpp:
+        (WebCore::LazyLoadImageObserver::intersectionObserver):
+
 2021-10-13  Jean-Yves Avenard  <jya@apple.com>
 
         Compilation error: error: definition of implicit copy assignment operator in AppHighlightRangeData.h

Source/WebCore/html/LazyLoadImageObserver.cpp

diff --git a/Source/WebCore/html/LazyLoadImageObserver.cpp b/Source/WebCore/html/LazyLoadImageObserver.cpp
index 836dc82..176a6ef 100644
--- a/Source/WebCore/html/LazyLoadImageObserver.cpp
+++ b/Source/WebCore/html/LazyLoadImageObserver.cpp
@@ -29,7 +29,6 @@
 #include "Frame.h"
 #include "HTMLImageElement.h"
 #include "IntersectionObserverCallback.h"
-#include "RenderStyle.h"
 
 #include <limits>
 
@@ -86,7 +85,8 @@
 {
     if (!m_observer) {
         auto callback = LazyImageLoadIntersectionObserverCallback::create(document);
-        IntersectionObserver::Init options { std::nullopt, emptyString(), { } };
+        static NeverDestroyed<const String> lazyLoadingRootMarginFallback(MAKE_STATIC_STRING_IMPL("100%"));
+        IntersectionObserver::Init options { std::nullopt, lazyLoadingRootMarginFallback, { } };
         auto observer = IntersectionObserver::create(document, WTFMove(callback), WTFMove(options));
         if (observer.hasException())
             return nullptr;