tree b6daf8c92c0b65913423747a82b42d605d491d13
parent fdb0433fcdb3eb8ab32f014920674462138bb5c0
author cathiechen@igalia.com <cathiechen@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1579326564 +0000
committer cathiechen@igalia.com <cathiechen@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1579326564 +0000

Add support for scroll behavior parsing
https://bugs.webkit.org/show_bug.cgi?id=205009

Reviewed by Frédéric Wang.

Based on the patch by Frédéric Wang.

LayoutTests/imported/w3c:

* web-platform-tests/css/cssom-view/inheritance-expected.txt:
* web-platform-tests/css/cssom-view/inheritance.html:
* web-platform-tests/css/cssom-view/parsing/scroll-behavior-computed-expected.txt:
* web-platform-tests/css/cssom-view/parsing/scroll-behavior-computed.html:
* web-platform-tests/css/cssom-view/parsing/scroll-behavior-valid-expected.txt:
* web-platform-tests/css/cssom-view/parsing/scroll-behavior-valid.html:

Source/WebCore:

Add support for parsing scroll-behavior css property and ScrollOptions.

Tests: LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/inheritance.html
       LayoutTests/web-platform-tests/css/cssom-view/parsing/scroll-behavior-computed.html
       LayoutTests/web-platform-tests/css/cssom-view/parsing/scroll-behavior-valid.html

* CMakeLists.txt: Add IDL files for ScrollOptions and ScrollBehavior.
* DerivedSources.make:
* Headers.cmake: Add headers for ScrollBehavor and ScrollOptions.
* Sources.txt: Add ScrollBehavor and ScrollOptions implementation.
* WebCore.xcodeproj/project.pbxproj: Add files to the build system.
* css/CSSComputedStyleDeclaration.cpp: Handle scroll-behavior.
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* css/CSSProperties.json: Add scroll-behavior.
* css/CSSValueKeywords.in: Add keywords for scroll-behavior.
* css/parser/CSSParserContext.cpp: Add runtime config for scroll-behavior.
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
* css/parser/CSSParserContext.h: Ditto.
(WebCore::CSSParserContextHash::hash):
* css/parser/CSSParserFastPaths.cpp: Remove scroll-behavior templates. It is handled in the slow path since property can be disabled.
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeScrollBehavior):
(WebCore::CSSPropertyParser::parseSingleValue): Parse scroll-behavior (only if enabled).
* page/ScrollBehavior.cpp: Added.
(WebCore::useSmoothScrolling): Helper funciton to determine the scroll behavior to apply to an element from the CSS and DOM behavior.
* page/ScrollBehavior.h: Added.
* page/ScrollBehavior.idl: Added.
* page/ScrollIntoViewOptions.h: Make this class inherits from ScrollOption. Also remove unnecessary forward declaration.
* page/ScrollIntoViewOptions.idl: Make this class inherits from ScrollOption.
* page/ScrollOptions.h: Added.
* page/ScrollOptions.idl: Added.
* page/ScrollToOptions.h: Make this struct inherits from ScrollOptions.
(WebCore::ScrollToOptions::ScrollToOptions):
(WebCore::normalizeNonFiniteCoordinatesOrFallBackTo): Copy the current ScrollToOptions so that the scroll behavior is preserved.
* page/ScrollToOptions.idl: Make this class inherit from ScrollOptions.
* page/Settings.yaml: New setting for CSSOM View smooth scrolling.
* rendering/style/RenderStyle.h: Handle 'smooth scrolling' boolean data.
(WebCore::RenderStyle::useSmoothScrolling const):
(WebCore::RenderStyle::setUseSmoothScrolling):
(WebCore::RenderStyle::initialUseSmoothScrolling):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
* rendering/style/StyleRareNonInheritedData.h:
* style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertSmoothScrolling):

Source/WebKit:

Add CSSOM smooth scrolling as an experimental feature.

* Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

Add run time flag for CSSOMViewSmoothScrolling.

* WebView/WebPreferenceKeysPrivate.h: Handle CSSOMViewSmoothScrolling by.
* WebView/WebPreferences.mm:
([WebPreferences initialize]): Disable CSSOMViewSmoothScrolling by default.
(-[WebPreferences CSSOMViewSmoothScrollingEnabled]): Getter.
(-[WebPreferences setCSSOMViewSmoothScrollingEnabled:]): Setter.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

* Interfaces/IWebPreferencesPrivate.idl: Handle smooth scrolling option.
* WebPreferenceKeysPrivate.h: Ditto.
* WebPreferences.cpp: Ditto.
(WebPreferences::initializeDefaultSettings):
(WebPreferences::CSSOMViewSmoothScrollingEnabled):
(WebPreferences::setCSSOMViewSmoothScrollingEnabled):
* WebPreferences.h: Ditto.
* WebView.cpp: Ditto.
(WebView::notifyPreferencesChanged):

Tools:

* DumpRenderTree/TestOptions.cpp:
(TestOptions::TestOptions): Parse CSSOMViewSmoothScrollingEnabled.
* DumpRenderTree/TestOptions.h: Add CSSOMViewSmoothScrollingEnabled, disabled by default.
* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
(setWebPreferencesForTestOptions): Set CSSOMViewSmoothScrollingEnabled from the test options.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@254790 268f45cc-cd09-0410-ab3c-d52691b4dbfc