Drop confusing Event::dispatched() method
https://bugs.webkit.org/show_bug.cgi?id=178670
Reviewed by Youenn Fablet.
Source/WebCore:
Drop confusing Event::dispatched() method. What the call sites want to do is check
that the Event's "dispatch" flag is set:
- https://dom.spec.whatwg.org/#dispatch-flag
This flag gets set at the beginning of dispatchEvent() and unset at the end of
dispatchEvent():
- https://dom.spec.whatwg.org/#ref-for-dispatch-flag③
See as an example event.initEvent():
- https://dom.spec.whatwg.org/#dom-event-initevent
The right way to check the Event's "dispatch" flag is the Event::isBeingDispatched()
method, so use this instead. One side effect of this change is that it is now
possible to call the init*Event() method on events that have already been dispatched
in order to dispatch them again, as per the specification.
Test: fast/events/initEvent-after-dispatching.html
* dom/CompositionEvent.cpp:
(WebCore::CompositionEvent::initCompositionEvent):
* dom/DeviceMotionEvent.cpp:
(WebCore::DeviceMotionEvent::initDeviceMotionEvent):
* dom/DeviceOrientationEvent.cpp:
(WebCore::DeviceOrientationEvent::initDeviceOrientationEvent):
* dom/Event.h:
* dom/HashChangeEvent.h:
* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::initKeyboardEvent):
* dom/MessageEvent.cpp:
(WebCore::MessageEvent::initMessageEvent):
* dom/MouseEvent.cpp:
(WebCore::MouseEvent::initMouseEvent):
* dom/OverflowEvent.cpp:
(WebCore::OverflowEvent::initOverflowEvent):
* dom/TextEvent.cpp:
(WebCore::TextEvent::initTextEvent):
* dom/TouchEvent.cpp:
(WebCore::TouchEvent::initTouchEvent):
* dom/UIEvent.cpp:
(WebCore::UIEvent::initUIEvent):
* dom/WheelEvent.cpp:
(WebCore::WheelEvent::initWheelEvent):
* storage/StorageEvent.cpp:
(WebCore::StorageEvent::initStorageEvent):
LayoutTests:
Add layout test coverage.
* fast/events/initEvent-after-dispatching-expected.txt: Added.
* fast/events/initEvent-after-dispatching.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@223849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebCore/dom/Event.h b/Source/WebCore/dom/Event.h
index 79fdf91..5885c3a 100644
--- a/Source/WebCore/dom/Event.h
+++ b/Source/WebCore/dom/Event.h
@@ -165,6 +165,8 @@
Event* underlyingEvent() const { return m_underlyingEvent.get(); }
void setUnderlyingEvent(Event*);
+ // Returns true if the dispatch flag is set.
+ // https://dom.spec.whatwg.org/#dispatch-flag
bool isBeingDispatched() const { return eventPhase(); }
virtual EventTarget* relatedTarget() const { return nullptr; }
@@ -177,7 +179,6 @@
Event(const AtomicString& type, const EventInit&, IsTrusted);
virtual void receivedTarget();
- bool dispatched() const { return m_target; }
private:
AtomicString m_type;
