commit | de658ff7e3f779e49cd0675171c366babec80a49 | [log] [tgz] |
---|---|---|
author | yurys@chromium.org <yurys@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Wed Oct 23 20:16:00 2019 +0000 |
committer | yurys@chromium.org <yurys@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Wed Oct 23 20:16:00 2019 +0000 |
tree | 367312d0379441704900bc15499eb8e2ce280c5f | |
parent | 81a0d964f248170ecfa16a9223365571e8b30d1b [diff] |
Web Inspector: notify inspector when provisional page is created, committed and destroyed https://bugs.webkit.org/show_bug.cgi?id=202704 Reviewed by Devin Rousso. Source/JavaScriptCore: * inspector/InspectorTarget.h: changed InspectorTarget to not require FrontendChannel as all messages are routed by means of the owning InspectorTargetAgent. * inspector/agents/InspectorTargetAgent.cpp: (Inspector::InspectorTargetAgent::InspectorTargetAgent): (Inspector::buildTargetInfoObject): (Inspector::InspectorTargetAgent::targetCreated): (Inspector::InspectorTargetAgent::targetDestroyed): (Inspector::InspectorTargetAgent::didCommitProvisionalTarget): this method is used to notify frontend that corresponding provisional target has committed and replaced previous target. (Inspector::InspectorTargetAgent::connectionType const): (Inspector::InspectorTargetAgent::connectToTargets): (Inspector::InspectorTargetAgent::disconnectFromTargets): * inspector/agents/InspectorTargetAgent.h: * inspector/protocol/Target.json: extended TargetInfo with provisional page details and added event which is fired when provisional page gets committed. If provisional load fails there will be targetDestroyed event without corresponding commit. Source/WebCore: Test: http/tests/inspector/target/target-events-for-proisional-page.html * inspector/InspectorController.cpp: (WebCore::InspectorController::setIsUnderTest): This method may be called several times when reloading inspected page with opened frontend so the assumption that there are no connected frontends when this method is called from tests doesn't hold anymore. Source/WebInspectorUI: Updated frontend code to understand provisional targets. For now there are no changes frontend behavior, it will wait for the provisional target to commit and will not send any commands to it before that. * UserInterface/Base/Main.js: Moved a bunch of methods shared between Main.js and Test.js to TargetManager.js to keep them in sync. * UserInterface/Controllers/TargetManager.js: (WI.TargetManager): (WI.TargetManager.prototype.removeTarget): (WI.TargetManager.prototype.createMultiplexingBackendTarget): (WI.TargetManager.prototype.createDirectBackendTarget): (WI.TargetManager.prototype.targetCreated): (WI.TargetManager.prototype.didCommitProvisionalTarget): (WI.TargetManager.prototype.targetDestroyed): (WI.TargetManager.prototype.dispatchMessageFromTarget): (WI.TargetManager.prototype._checkAndHandlePageTargetTransition): (WI.TargetManager.prototype._checkAndHandlePageTargetTermination): (WI.TargetManager.prototype._initializeBackendTarget): (WI.TargetManager.prototype._initializePageTarget): (WI.TargetManager.prototype._transitionPageTarget): (WI.TargetManager.prototype._terminatePageTarget): (WI.TargetManager.prototype._resetMainExecutionContext): (WI.TargetManager.prototype._redirectGlobalAgentsToConnection): * UserInterface/Protocol/Connection.js: (InspectorBackend.WorkerConnection.sendMessageToBackend): (InspectorBackend.WorkerConnection): (InspectorBackend.TargetConnection.sendMessageToBackend): (InspectorBackend.TargetConnection): * UserInterface/Protocol/Target.js: (WI.Target.prototype.destroy): Mark target as destroyed to distinguish expected command errors from genuine failures. (WI.Target.prototype.isDestroyed): * UserInterface/Protocol/TargetObserver.js: Since the front-end doesn't send commands to the provisional targets yet, it has to ignore all activities related to provisional pages. For that reason we need two sets to keep track of - provisional pages that were destroyed and never committed - old pages which were replaced by committed page and for which following targetDestroyed event should be ignored Better support for provisional targets will be added to frontend in a separate change. (WI.TargetObserver): (WI.TargetObserver.prototype.targetCreated): (WI.TargetObserver.prototype.didCommitProvisionalTarget): For now convert the event into a subsequence of targetDestroyed/targetCreated events which matches previous behavior. (WI.TargetObserver.prototype.targetDestroyed): (WI.TargetObserver.prototype.dispatchMessageFromTarget): * UserInterface/Test/Test.js: (WI.transitionPageTarget): (WI.terminatePageTarget): Source/WebKit: Target.targetCreated event is now generated for provisional pages as well as for regular ones. This is the first step toward reattaching inspector earlier during PSON. In the future if debugging is in progress the provisional target (page) will be paused until a signal from inspector frontend. This will enable the frontend configure all agents before navigation starts. * Sources.txt: * UIProcess/API/APIWebAuthenticationPanel.cpp: (API::WebAuthenticationPanel::WebAuthenticationPanel): Added explicit namespace specifier to the constructor's argument as otherwise compilation fails due to conflict between API::String and WTF::String. * UIProcess/InspectorTargetProxy.cpp: (WebKit::InspectorTargetProxy::create): (WebKit::InspectorTargetProxy::connect): (WebKit::InspectorTargetProxy::disconnect): (WebKit::InspectorTargetProxy::sendMessageToTargetBackend): (WebKit::InspectorTargetProxy::didCommitProvisionalTarget): (WebKit::InspectorTargetProxy::isProvisional const): (WebKit::InspectorTargetProxy::previousTargetID const): * UIProcess/InspectorTargetProxy.h: Target proxy can start as a provisional target (with a pointer to ProvisionalPageProxy) and later either be committed or destroyed. * UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::ProvisionalPageProxy): (WebKit::ProvisionalPageProxy::~ProvisionalPageProxy): (WebKit::ProvisionalPageProxy::didReceiveMessage): Forward inspector messages to parent page's WebPageInspectorController. Since each WebPage has a unique identifier the target ids will be globally unique and there is no risk of collisions. * UIProcess/ProvisionalPageProxy.h: (WebKit::ProvisionalPageProxy::page const): * UIProcess/WebPageInspectorController.cpp: (WebKit::getTargetID): (WebKit::WebPageInspectorController::WebPageInspectorController): (WebKit::WebPageInspectorController::clearTargets): (WebKit::WebPageInspectorController::createInspectorTarget): (WebKit::WebPageInspectorController::destroyInspectorTarget): (WebKit::WebPageInspectorController::didCreateProvisionalPage): (WebKit::WebPageInspectorController::didDestroyProvisionalPage): (WebKit::WebPageInspectorController::didCommitProvisionalPage): (WebKit::WebPageInspectorController::addTarget): * UIProcess/WebPageInspectorController.h: * UIProcess/WebPageInspectorTargetAgent.cpp: Removed. Merged this agent into InspectorTargetAgent. * UIProcess/WebPageInspectorTargetAgent.h: Removed. * UIProcess/WebPageProxy.cpp: (WebKit::m_resetRecentCrashCountTimer): (WebKit::WebPageProxy::finishAttachingToWebProcess): (WebKit::WebPageProxy::commitProvisionalPage): * UIProcess/WebPageProxy.h: Moved the target management logic into WebPageInspectorController. WebPageProxy/ProvisionalPageProxy are expected to notifiy it about key lifecycle events and also forward to it messages from inspector in the inspected WebProcess. How it translates to Target events is inspector's business. * WebKit.xcodeproj/project.pbxproj: * WebProcess/WebPage/WebPageInspectorTarget.cpp: (WebKit::WebPageInspectorTarget::identifier const): (WebKit::WebPageInspectorTarget::connect): (WebKit::WebPageInspectorTarget::disconnect): (WebKit::WebPageInspectorTarget::toTargetID): * WebProcess/WebPage/WebPageInspectorTarget.h: Made the target own frontend channel instance as it's the only place where the page specific channel is used. * WebProcess/WebPage/WebPageInspectorTargetController.cpp: (WebKit::WebPageInspectorTargetController::removeTarget): (WebKit::WebPageInspectorTargetController::connectInspector): (WebKit::WebPageInspectorTargetController::disconnectInspector): * WebProcess/WebPage/WebPageInspectorTargetController.h: * WebProcess/WebPage/WebPageInspectorTargetFrontendChannel.cpp: (WebKit::WebPageInspectorTargetFrontendChannel::WebPageInspectorTargetFrontendChannel): (WebKit::WebPageInspectorTargetFrontendChannel::sendMessageToFrontend): * WebProcess/WebPage/WebPageInspectorTargetFrontendChannel.h: The channel's lifetime is managed by owning target. No need to reference count it. LayoutTests: Added new test for Target events during PSON. It is only enabled on WebKit2 as there is no Target agent in WebKit1. * TestExpectations: * http/tests/inspector/target/target-events-for-provisional-page-expected.txt: Added. * http/tests/inspector/target/target-events-for-provisional-page.html: Added. * platform/wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@251494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
or
git clone https://git.webkit.org/git/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.