commit | dcb6496f1579b8036b441cff06aa05721fafbb6c | [log] [tgz] |
---|---|---|
author | wenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Fri Apr 27 15:35:50 2018 +0000 |
committer | wenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Fri Apr 27 15:35:50 2018 +0000 |
tree | 22dca3347503d9930e39b3df7772f21de8814955 | |
parent | f28af6abf402c7237519f43012cc180ecbf69bc8 [diff] |
[Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode https://bugs.webkit.org/show_bug.cgi?id=185050 <rdar://problem/39624038> Reviewed by Tim Horton. Source/WebCore: Currently, in extra zoom mode, there's no way for web pages to opt out of the default viewport behaviors (namely, laying out at a larger width and shrinking to fit) when the web view is very tall and narrow. This patch adds a new experimental viewport attribute, "min-device-width", that can be used to prevent WebKit from automatically clamping the web view width to a greater value for the device width in this scenario. Note that after this patch, logic that plumbs a minimumLayoutSize from WKWebView to the viewport configuration will need to be renamed to reflect that this size is no longer the minimum layout size, but rather, the view size that is used for viewport device dimensions by default. This refactoring will be done in a followup part. See per-method comments below for more detail. Test: fast/viewport/extrazoom/viewport-change-min-device-width.html * dom/ViewportArguments.cpp: (WebCore::setViewportFeature): (WebCore::operator<<): * dom/ViewportArguments.h: Removes `m_forceHorizontalShrinkToFit` (more detail below). * page/ViewportConfiguration.cpp: (WebCore::computedMinDeviceWidth): (WebCore::ViewportConfiguration::ViewportConfiguration): (WebCore::ViewportConfiguration::setMinimumLayoutSize): Instead of directly setting the minimum layout size, setMinimumLayoutSize now first sets the view size (i.e. the size we use for `device-width` in the viewport meta tag), and then updates the minimum layout size. (WebCore::ViewportConfiguration::shouldOverrideDeviceWidthWithMinDeviceWidth const): Replaces `m_forceHorizontalShrinkToFit`. Whether or not we shrink to fit is now determined by whether the min-device-width attribute is actively clamping the width of the view. (WebCore::ViewportConfiguration::shouldIgnoreHorizontalScalingConstraints const): (WebCore::ViewportConfiguration::shouldIgnoreScalingConstraintsRegardlessOfContentSize const): (WebCore::ViewportConfiguration::updateMinimumLayoutSize): Computes and sets the minimum layout size using the view size, taking the minimum device width into account if needed. (WebCore::ViewportConfiguration::description const): (WebCore::ViewportConfiguration::setForceHorizontalShrinkToFit): Deleted. * page/ViewportConfiguration.h: Source/WebKit: Remove the forceHorizontalViewportShrinkToFit and minimumAllowedLayoutWidth SPI hooks from WebKit, and additionally remove all logic for plumbing viewSize to WebCore. See WebCore/ChangeLog for more information. * Shared/VisibleContentRectUpdateInfo.cpp: (WebKit::VisibleContentRectUpdateInfo::encode const): (WebKit::VisibleContentRectUpdateInfo::decode): (WebKit::operator<<): * Shared/VisibleContentRectUpdateInfo.h: (WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo): (WebKit::VisibleContentRectUpdateInfo::allowShrinkToFit const): (WebKit::operator==): (WebKit::VisibleContentRectUpdateInfo::forceHorizontalShrinkToFit const): Deleted. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _initializeWithConfiguration:]): (-[WKWebView activeMinimumLayoutSize:]): (-[WKWebView _dispatchSetMinimumLayoutSize:]): (-[WKWebView _frameOrBoundsChanged]): (-[WKWebView _setMinimumLayoutSizeOverride:]): (-[WKWebView _beginAnimatedResizeWithUpdates:]): (-[WKWebView _endAnimatedResize]): (-[WKWebView _minimumAllowedLayoutWidth]): Deleted. (-[WKWebView _setMinimumAllowedLayoutWidth:]): Deleted. (-[WKWebView activeMinimumLayoutSizes:]): Deleted. (-[WKWebView _dispatchSetMinimumLayoutSize:viewSize:]): Deleted. (-[WKWebView _setForceHorizontalViewportShrinkToFit:]): Deleted. (-[WKWebView _forceHorizontalViewportShrinkToFit]): Deleted. * UIProcess/API/Cocoa/WKWebViewPrivate.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): * UIProcess/WebPageProxy.h: * UIProcess/ios/WKContentView.mm: (-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:obscuredInsets:unobscuredSafeAreaInsets:inputViewBounds:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:enclosedInScrollableAncestorView:]): * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::dynamicViewportSizeUpdate): (WebKit::WebPageProxy::setViewportConfigurationMinimumLayoutSize): * WebProcess/WebPage/WebPage.cpp: (WebKit::m_credentialsMessenger): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::setViewportConfigurationMinimumLayoutSize): (WebKit::WebPage::dynamicViewportSizeUpdate): (WebKit::WebPage::updateVisibleContentRects): Tools: Remove a test that's no longer useful, now that the SPI it was testing is gone. This functionality is now tested by the layout test added in this patch. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Removed. LayoutTests: Add a new layout test to check that: • By default (with no `min-device-width` override), shrink-to-fit and expanded minimum layout sizes takes effect. • `min-device-width` can be used to bail out of shrink-to-fit and viewport behaviors. • A large `min-device-width` can be used to make extra zoom mode viewport heuristics even more aggressive. * TestExpectations: * fast/viewport/extrazoom/viewport-change-min-device-width.html: Added. * resources/ui-helper.js: (window.UIHelper.zoomScale): (window.UIHelper): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@231095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within WebKit.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator.
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.