commit | ce715b2200840301c7c831cf986a0bbf5768fb9c | [log] [tgz] |
---|---|---|
author | caitp@igalia.com <caitp@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Thu Jan 16 00:09:50 2020 +0000 |
committer | caitp@igalia.com <caitp@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Thu Jan 16 00:09:50 2020 +0000 |
tree | f63f9b440689483b6f4d03c84e5544dacd40ccb9 | |
parent | 3ed7764fd9c7e51f7f5fc8a5df163e9cb8d6b0ea [diff] |
[JSC] Add support for public class fields https://bugs.webkit.org/show_bug.cgi?id=174212 Reviewed by Yusuke Suzuki. JSTests: New syntax invalidates some test expectations: "async <linefeed> MethodDefinition" is no longer an unexpected "async" token. It is now an instance field named "async" with no initializer, and an automatic semicolon, followed by MethodDefinition. "get|set GeneratorMethodDefinition"'s error message has changed, due to "get" being valid class field names. Many class-syntax tests relating to automatic semicolon insertion are no longer valid, as a line containing nothing but an identifier is now a valid class element. * stress/async-await-syntax.js: * stress/class-fields-bytecode-cache.js: Added. * stress/class-fields-computed-to-property-key.js: Added. * stress/class-fields-function-name.js: Added. * stress/class-fields-harmony.js: Added. * stress/class-fields-proxy-define-property.js: Added. * stress/class-fields-stress-instance.js: Added. * stress/generator-syntax.js: * stress/method-name.js: * test262/config.yaml: Source/JavaScriptCore: Implements the instance class fields proposal (https://tc39.es/proposal-class-fields/), minus support for private fields (split into a separate patch). In summary, class fields are initialized by a synthetic JSFunction. In its unlinked state, the UnlinkedFunctionExecutable for the function includes an ordered list of JSTokenLocations pointing to the start of each class field in the class. Each of these fields are parsed and included as DefineFieldNodes, which implement the appropriate DefineField behaviour in the proposal. This synthetic function is only created, and only loaded, if there are class fields present. The decision to use a synthetic function was for simplicity. There are a number of factors which make inlining the initialization complicated, though we may opt to do this in the future. For reference, the complexities are: instance fields and constructor in different currently in different parsing arenas, distinct scopes between the 2 which require work to manage, and complexity in doing to this work for child classes, where the location of initialization can depend, and in some cases occur more than once. Computed property fields require a new bytecode, op_to_property_key, as an implementation detail. It is necessary in the proposal to convert computed properties to property keys during class evaluation, rather than during field initialization. Additionally, we allocate the class lexical scope when computed class fields are used (previously, only when there was a class name), as a location to keep the computed property keys. They can be loaded from the scope via indexed keys. To illustrate computed field names in action, consider the following pseudocode: <during class evaluation> 1) fieldName = emitNode({expr}) 2) fieldName = emitToPropertyKey(fieldName) 3) classScope[numComputedNames++] = fieldName <during class field initialization> 1) fieldName = emitGetFromScope(classScope, computedFieldNameIndex++) 2) value = emitNode({initializer}) 3) instance[fieldName] = value The feature is currently hidden behind the feature flag JSC::Options::useClassFields. LayoutTests: New syntax invalidates some test expectations: "async <linefeed> MethodDefinition" is no longer an unexpected "async" token. It is now an instance field named "async" with no initializer, and an automatic semicolon, followed by MethodDefinition. "get|set GeneratorMethodDefinition"'s error message has changed, due to "get" being valid class field names. Many class-syntax tests relating to automatic semicolon insertion are no longer valid, as a line containing nothing but an identifier is now a valid class element. * js/class-syntax-semicolon-expected.txt: * js/script-tests/class-syntax-semicolon.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@254653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
or
git clone https://git.webkit.org/git/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.