commit ccfa60a1fdff176e2aa0e300f2aabd11ad2a033a
author ap@webkit.org <ap@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Tue Sep 23 20:39:22 2008 +0000
committer ap@webkit.org <ap@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Tue Sep 23 20:39:22 2008 +0000
tree f1cc4271f225db5a865fb054421a88bb88ca535a
parent 4a1f8625283922e1c8698ac980adff0d35e26698

        Reviewed by Oliver Hunt, okayed by Darin Adler.

        <rdar://problem/5575547> REGRESSION: ATOK has no phrase boundary on Safari/Mail.app

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintCompositionUnderline): Add 2 pixel spacing between clauses.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 1068ba2..4c6d526 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,5 +1,14 @@
 2008-09-23  Alexey Proskuryakov  <ap@webkit.org>
 
+        Reviewed by Oliver Hunt, okayed by Darin Adler.
+
+        <rdar://problem/5575547> REGRESSION: ATOK has no phrase boundary on Safari/Mail.app
+
+        * rendering/InlineTextBox.cpp:
+        (WebCore::InlineTextBox::paintCompositionUnderline): Add 2 pixel spacing between clauses.
+
+2008-09-23  Alexey Proskuryakov  <ap@webkit.org>
+
         Reviewed by Darin Adler.
 
         https://bugs.webkit.org/show_bug.cgi?id=21023

WebCore/rendering/InlineTextBox.cpp

diff --git a/WebCore/rendering/InlineTextBox.cpp b/WebCore/rendering/InlineTextBox.cpp
index 8f52e89..53bac41 100644
--- a/WebCore/rendering/InlineTextBox.cpp
+++ b/WebCore/rendering/InlineTextBox.cpp
@@ -821,6 +821,11 @@
     if (underline.thick && m_height - m_baseline >= 2)
         lineThickness = 2;
 
+    // We need to have some space between underlines of subsequent clauses, because some input methods do not use different underline styles for those.
+    // We make each line shorter, which has a harmless side effect of shortening the first and last clauses, too.
+    start += 1;
+    width -= 2;
+
     ctx->setStrokeColor(underline.color);
     ctx->setStrokeThickness(lineThickness);
     ctx->drawLineForText(IntPoint(tx + start, ty + m_height - lineThickness), width, textObject()->document()->printing());