Fast path for jsStringWithCache() when asked for the same string repeatedly.
<https://webkit.org/b/134635>
Source/JavaScriptCore:
Also moved the whole thing from WebCore to JavaScriptCore since it
makes more sense here, and inline the lightweight checks, leaving only
the hashmap stuff out of line.
Reviewed by Darin Adler.
* runtime/JSString.cpp:
(JSC::jsStringWithCacheSlowCase):
* runtime/JSString.h:
(JSC::jsStringWithCache):
* runtime/VM.h:
Source/WebCore:
Reviewed by Darin Adler.
* WebCore.exp.in:
* bindings/js/JSDOMBinding.cpp:
(WebCore::jsStringWithCache): Deleted.
* bindings/js/JSDOMBinding.h:
(WebCore::JSValueTraits<String>::arrayJSValue):
(WebCore::jsStringWithCache): Deleted.
* bridge/c/c_utility.cpp:
(JSC::Bindings::convertNPVariantToValue):
* loader/cache/CachedResourceHandle.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@170818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/JavaScriptCore/runtime/JSString.cpp b/Source/JavaScriptCore/runtime/JSString.cpp
index 1937e3f6..641d8b6 100644
--- a/Source/JavaScriptCore/runtime/JSString.cpp
+++ b/Source/JavaScriptCore/runtime/JSString.cpp
@@ -374,4 +374,13 @@
return false;
}
+JSString* jsStringWithCacheSlowCase(VM& vm, StringImpl& stringImpl)
+{
+ auto addResult = vm.stringCache.add(&stringImpl, nullptr);
+ if (addResult.isNewEntry)
+ addResult.iterator->value = jsString(&vm, String(stringImpl));
+ vm.lastCachedString = addResult.iterator->value.get();
+ return vm.lastCachedString.get();
+}
+
} // namespace JSC
