Tables with vertical-lr writing-mode doesn't apply correctly vertical-align: baseline
https://bugs.webkit.org/show_bug.cgi?id=191881
Reviewed by Manuel Rego Casasnovas.
Source/WebCore:
We should use the font's descent value when wriring-mode flips line flow (vertical-lr).
This change also fixes bug 170175, since Flexbox use the same code to determine the first
line baseline of a flex item.
Test: fast/writing-mode/vertical-align-table-baseline-latin.html
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::firstLineBaseline const):
LayoutTests:
Tests to verify that columns of a vertical-lr table vertically aligned by baseline work like
in the case of horizontal tables.
Also added tests to verify flexbox baseline alignment works as expected in vertical-lr mode.
The vertical-align-table-baseline.html test has been rebaselined due to the new behavior.
* fast/writing-mode/vertical-align-table-baseline-latin-expected.html: Added.
* fast/writing-mode/vertical-align-table-baseline-latin.html: Added.
* fast/writing-mode/vertical-align-flex-baseline-expected.html: Added.
* fast/writing-mode/vertical-align-flex-baseline-html: Added.
* platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt: Rebaseline.
* platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.png: Rebaseline.
* platform/win/fast/writing-mode/vertical-align-table-baseline-expected.txt: Rebaseline.
* platform/win/fast/writing-mode/vertical-align-table-baseline-expected.png: Rebaseline.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@238441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebCore/rendering/RenderBlockFlow.cpp b/Source/WebCore/rendering/RenderBlockFlow.cpp
index 8e3730e..32ddace 100644
--- a/Source/WebCore/rendering/RenderBlockFlow.cpp
+++ b/Source/WebCore/rendering/RenderBlockFlow.cpp
@@ -3013,6 +3013,8 @@
return std::optional<int>(SimpleLineLayout::computeFlowFirstLineBaseline(*this, *simpleLineLayout));
ASSERT(firstRootBox());
+ if (style().isFlippedLinesWritingMode())
+ return firstRootBox()->logicalTop() + firstLineStyle().fontMetrics().descent(firstRootBox()->baselineType());
return firstRootBox()->logicalTop() + firstLineStyle().fontMetrics().ascent(firstRootBox()->baselineType());
}
