Web Inspector: Record actions performed on WebGL2RenderingContext
https://bugs.webkit.org/show_bug.cgi?id=176008
<rdar://problem/34213884>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
* inspector/protocol/Recording.json:
* inspector/scripts/codegen/generator.py:
Add `canvas-webgl2` as a `Type`.
Source/WebCore:
Tests: inspector/canvas/recording-webgl2.html
inspector/canvas/recording-webgl2-snapshots.html
* html/canvas/WebGL2RenderingContext.idl:
* bindings/js/CallTracerTypes.h:
* inspector/RecordingSwizzleTypes.h:
* inspector/InspectorCanvas.h:
* inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::canvasChanged): Added.
(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::shouldSnapshotWebGL2Action): Added.
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::releaseObjectForRecording):
(WebCore::InspectorCanvas::appendActionSnapshotIfNeeded):
(WebCore::InspectorCanvas::buildAction):
* inspector/agents/InspectorCanvasAgent.h:
* inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::canvasChanged): Added.
(WebCore::InspectorCanvasAgent::startRecording):
Provide an actual implementation of `CanvasObserver::canvasChanged` since it can be used to
determine whether or not an action needs a snapshot.
* page/PageConsoleClient.cpp:
(WebCore::canvasRenderingContext):
Source/WebInspectorUI:
* UserInterface/Models/Recording.js:
(WI.Recording.fromPayload):
(WI.Recording.displayNameForSwizzleType):
(WI.Recording.prototype.async swizzle):
(WI.Recording.prototype.createContext):
* UserInterface/Models/RecordingAction.js:
(WI.RecordingAction.constantNameForParameter):
(WI.RecordingAction._prototypeForType):
(WI.RecordingAction.prototype.async swizzle):
Treat all actions with a snapshot as being a "visible" action.
* UserInterface/Views/CanvasTabContentView.css:
(.content-view.tab.canvas .navigation-bar > .item .canvas:matches(.webgl, .webgl2, .webgpu, .webmetal) .icon): Added.
(.content-view.tab.canvas .navigation-bar > .item .canvas.webgl): Deleted.
* UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView.prototype.initialLayout):
* UserInterface/Views/CanvasSidebarPanel.js:
(WI.CanvasSidebarPanel.prototype.shown):
(WI.CanvasSidebarPanel.prototype._canvasChanged):
(WI.CanvasSidebarPanel.prototype._updateRecordNavigationItem):
* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView):
(WI.RecordingContentView.prototype.get navigationItems):
(WI.RecordingContentView.prototype.shown):
(WI.RecordingContentView.prototype.initialLayout):
* UserInterface/Views/RecordingActionTreeElement.js:
(WI.RecordingActionTreeElement._generateDOM.createParameterElement):
LayoutTests:
* inspector/canvas/recording-webgl2.html: Added.
* inspector/canvas/recording-webgl2-expected.txt: Added.
* inspector/canvas/recording-webgl2-snapshots.html: Added.
* inspector/canvas/recording-webgl2-snapshots-expected.txt: Added.
* TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@244908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index 2c26f88..1014468 100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -534,6 +534,7 @@
[ Debug ] inspector/debugger/debugger-stack-overflow.html [ Skip ]
[ Debug ] inspector/canvas/recording-2d.html [ Slow ]
[ Debug ] inspector/canvas/recording-webgl.html [ Slow ]
+[ Debug ] inspector/canvas/recording-webgl2.html [ Slow ]
# Debugger stepping tests can timeout if they run slowly due to a short timer scheduled in the frontend.
webkit.org/b/161951 [ Debug ] inspector/debugger/paused-scopes.html [ Skip ]
