commit | b4d1c08751d6262c6b099d39e4a06ee65f97bb77 | [log] [tgz] |
---|---|---|
author | mmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Wed Jun 22 17:13:56 2022 +0000 |
committer | mmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Wed Jun 22 17:13:56 2022 +0000 |
tree | 5f69d0dde2eef721cb874969be9a96afee06867f | |
parent | 464baf7a3675ecc8d6376bb3add0e0bd1cabdd1a [diff] |
[GPUP] Avoid race in GPUP teardown https://bugs.webkit.org/show_bug.cgi?id=241770 Reviewed by Simon Fraser. When there's a low memory warning, the GPU process runs GPUProcess::tryExitIfUnused(), which sends a message to the UI process to kill the GPU process. The Web process notices this, and runs RemoteRenderingBackendProxy::disconnectGPUProcess(), which doesn't destroy the RemoteRenderingBackendProxy, but does set it's internal m_gpuProcessConnection to nullptr. However, we may be in the middle of a rendering update in the web process. If there's a rendering update pending, WebPage::finalizeRenderingUpdate() runs, which calls finalizeRenderingUpdate() on the RemoteRenderingBackendProxy if it exists, which then immediately tries to send a stream message to the GPU process. Sending a message to the GPU process of course runs ensureGPUProcessConnection() to lazily create the GPU process. Therefore, if the low memory warning happens in the middle of a rendering update, the GPU process is killed, but then it is immediately respawned, just to do 0 work and live forever. This is contrary to the point of killing the GPU process under memory pressure. This patch changes the logic of RemoteRenderingBackendProxy::finalizeRenderingUpdate() to avoid restarting the GPU Process if the connection to it is destroyed. Philosophically, it doesn't make much sense for the _finalization_ routine of a rendering update to start up the whole GPU process. If we're in the middle of an animation or something, the GPU process probably won't get killed (because it isn't idle), but even if it does, the next frame of the animation will start up the GPU process again. This patch just modifies the behavior of the finalization routine. I hit this when working on https://github.com/WebKit/WebKit/pull/1464. With this patch applied, the failure rate of GPUProcess.ExitsUnderMemoryPressureCanvasCase goes from 60% to 0%. Test: GPUProcess.ExitsUnderMemoryPressureCanvasCase * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::finalizeRenderingUpdate): Canonical link: https://commits.webkit.org/251740@main git-svn-id: http://svn.webkit.org/repository/webkit/trunk@295735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone https://github.com/WebKit/WebKit.git WebKit
If you want to be able to track Subversion revision from your git checkout, you can run the following command to do so:
Tools/Scripts/git-webkit setup-git-svn
For information about this, and other aspects of using Git with WebKit, read the wiki page.
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
iOS, tvOS and watchOS are all considered embedded builds. The first time after you install a new Xcode, you will need to run:
sudo Tools/Scripts/configure-xcode-for-embedded-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for embedded simulators:
Tools/Scripts/build-webkit --debug --<platform>-simulator
or embedded devices:
Tools/Scripts/build-webkit --debug --<platform>-device
where platform
is ios
, tvos
or watchos
.
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.