commit | b387ed984cfa86e07321d6d915fc6d801afbcecc | [log] [tgz] |
---|---|---|
author | commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Mon Oct 07 23:17:28 2019 +0000 |
committer | commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Mon Oct 07 23:17:28 2019 +0000 |
tree | 935123d4c41efb99e7946a06789dbb7e5667c2cb | |
parent | 622e869db55d9e78435fe55ea11007d0639ff44e [diff] |
Domain relationships in the ITP Database should be inserted in a single query and ignore repeat insert attempts. (202604) https://bugs.webkit.org/show_bug.cgi?id=202604 <rdar://problem/55995831> Patch by Kate Cheney <katherine_cheney@apple.com> on 2019-10-07 Source/WebKit: Reviewed by Chris Dumez. This patch addresses two clean-ups for the ITP SQLite Database Store. First, by using INSERT OR IGNORE as opposed to INSERT, it eliminates the need to check if a relationship already exists in the database before inserting it. Second, instead of looping through domain lists and inserting each relationship as a separate query, this patch now converts lists to a string which SQLite can use to insert multiple rows into a database using a single query. Some Exists queries could not be deleted because they were being used for testing. * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp: (WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore): (WebKit::ResourceLoadStatisticsDatabaseStore::prepareStatements): Removed old insert queries and replaced them with queries able to insert string-lists of domains in a single query. Also reorganized the queries by functionality to make them easier to find and edit. (WebKit::ResourceLoadStatisticsDatabaseStore::createUniqueIndices): (WebKit::ResourceLoadStatisticsDatabaseStore::createSchema): In order to properly take advantage of the INSERT OR IGNORE functionality, unique indices must be established so the SQLite table is aware of what patterns to look for when ignoring a new insert. (WebKit::ResourceLoadStatisticsDatabaseStore::ensureAndmakeDomainList): (WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationshipList): (WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationships): Looping through the domain list is no longer needed with the new query changes. Additionally, ensuring a domain is in the Observed Domains table of the database must be done before utilizing any inserting of relationships because the relationship queries rely on fetching the topFrame domainID from the ObservedDomains table. (WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccess): (WebKit::ResourceLoadStatisticsDatabaseStore::logFrameNavigation): (WebKit::ResourceLoadStatisticsDatabaseStore::logCrossSiteLoadWithLinkDecoration): (WebKit::ResourceLoadStatisticsDatabaseStore::setSubframeUnderTopFrameDomain): (WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUnderTopFrameDomain): (WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUniqueRedirectTo): (WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUniqueRedirectFrom): (WebKit::ResourceLoadStatisticsDatabaseStore::setTopFrameUniqueRedirectTo): (WebKit::ResourceLoadStatisticsDatabaseStore::setTopFrameUniqueRedirectFrom): With the ensure check being done once in the ensureAndmakeDomainList function, these functions no longer have to make that check before inserting. * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h: * NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::mergeStatisticForTesting): (WebKit::WebResourceLoadStatisticsStore::isRelationshipOnlyInDatabaseOnce): * NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h: Changes in WeResourceLoadStatisticsStore were for testing only. This patch updated the merge statistic testing to also test this change by having a topFrameDomain list with more than one domain. * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::mergeStatisticForTesting): (WebKit::NetworkProcess::isRelationshipOnlyInDatabaseOnce): * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkProcess.messages.in: * UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreSetStatisticsMergeStatistic): (WKWebsiteDataStoreIsStatisticsOnlyInDatabaseOnce): * UIProcess/API/C/WKWebsiteDataStoreRef.h: * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::mergeStatisticForTesting): (WebKit::NetworkProcessProxy::isRelationshipOnlyInDatabaseOnce): * UIProcess/Network/NetworkProcessProxy.h: * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::mergeStatisticForTesting): (WebKit::WebsiteDataStore::isRelationshipOnlyInDatabaseOnce): * UIProcess/WebsiteData/WebsiteDataStore.h: Added a new function for testing that there are no repeat inserts into the database. Updated mergeStatistics to test the list-insert functionality. Tools: Reviewed by Chris Dumez. Updates to testing infrastructure to test successful list-merging of top domains into the ITP SQLite database and test against repeat inserts. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setStatisticsMergeStatistic): (WTR::TestRunner::isStatisticsHasHadUserInteraction): (WTR::TestRunner::isStatisticsOnlyInDatabaseOnce): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::setStatisticsMergeStatistic): (WTR::TestController::isStatisticsOnlyInDatabaseOnce): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): LayoutTests: Reviewed by Chris Dumez. Edited the merge-statistics tests to also test the list-insertion change made in this patch. Also added a new test to ensure repeat inserts only result in one entry in the database. * http/tests/resourceLoadStatistics/many-inserts-only-insert-once-expected.txt: Added. * http/tests/resourceLoadStatistics/many-inserts-only-insert-once.html: Added. * http/tests/resourceLoadStatistics/merge-statistic-does-not-overwrite-database.html: * http/tests/resourceLoadStatistics/merge-statistic-does-overwrite-database-expected.txt: * http/tests/resourceLoadStatistics/merge-statistic-does-overwrite-database.html: * http/tests/resourceLoadStatistics/merge-statistic-does-partially-overwrite-database.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@250804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
or
git clone https://git.webkit.org/git/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.