commit b07fa911dd57b2cb4004ab510bfe2238cf799bc1
author commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Wed Dec 23 21:50:47 2015 +0000
committer commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Wed Dec 23 21:50:47 2015 +0000
tree b9297150d2589f9c97406d4ed8802cafef2723e4
parent 38343a7aecf218df1cd94d061271d827935f3e13

[INTL] Implement DateTime Format Functions
https://bugs.webkit.org/show_bug.cgi?id=147606

Patch by Andy VanWagoner <andy@instructure.com> on 2015-12-23
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Initialize a UDateFormat from the generated pattern. Use udat_format()
to format the value. Make sure that the UDateFormat is cleaned up when
the DateTimeFormat is deconstructed.

* runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::~IntlDateTimeFormat):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::format):
* runtime/IntlDateTimeFormat.h:

LayoutTests:

* js/intl-datetimeformat-expected.txt: Added format tests.
* js/intl-datetimeformat.html: Used utf-8.
* js/script-tests/intl-datetimeformat.js: Added format tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@194395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/runtime/IntlDateTimeFormat.h

diff --git a/Source/JavaScriptCore/runtime/IntlDateTimeFormat.h b/Source/JavaScriptCore/runtime/IntlDateTimeFormat.h
index f0198ef..7dc57d0 100644
--- a/Source/JavaScriptCore/runtime/IntlDateTimeFormat.h
+++ b/Source/JavaScriptCore/runtime/IntlDateTimeFormat.h
@@ -29,6 +29,7 @@
 #if ENABLE(INTL)
 
 #include "JSDestructibleObject.h"
+#include <unicode/udat.h>
 
 namespace JSC {
 
@@ -53,6 +54,7 @@
 
 protected:
     IntlDateTimeFormat(VM&, Structure*);
+    ~IntlDateTimeFormat();
     void finishCreation(VM&);
     static void destroy(JSCell*);
     static void visitChildren(JSCell*, SlotVisitor&);
@@ -81,6 +83,7 @@
     bool m_initializedDateTimeFormat { false };
     void setFormatsFromPattern(const StringView&);
     WriteBarrier<JSBoundFunction> m_boundFormat;
+    UDateFormat* m_dateFormat { nullptr };
 
     String m_locale { ASCIILiteral("en") };
     String m_calendar { ASCIILiteral("gregorian") };