commit aef3eed7c796331338aa25a54e01d08f661c37a6
author commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Dec 20 20:05:34 2018 +0000
committer commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Dec 20 20:05:34 2018 +0000
tree b434c3b1639a56dbb20f826a6852ab6cc5fffd41
parent 1407c35af33deb7a4e18ea69038324acba5bd304

ITMLKit Inspector: Computed Style Box Model section throws exceptions
https://bugs.webkit.org/show_bug.cgi?id=192911
<rdar://problem/46861112>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2018-12-20
Reviewed by Matt Baker.

* UserInterface/Views/BoxModelDetailsSectionRow.js:
(WI.BoxModelDetailsSectionRow.prototype._updateMetrics.createBoxPartElement):
(WI.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaElement):
(WI.BoxModelDetailsSectionRow.prototype._updateMetrics):
ITMLKit doesn't always provide a display/position/width/height etc properties.
Protect against this, and just show an empty message in the box model section
if those properties do not exist.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@239459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog

diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
index 6c0ae38..b4d500d 100644
--- a/Source/WebInspectorUI/ChangeLog
+++ b/Source/WebInspectorUI/ChangeLog
@@ -1,3 +1,19 @@
+2018-12-20  Joseph Pecoraro  <pecoraro@apple.com>
+
+        ITMLKit Inspector: Computed Style Box Model section throws exceptions
+        https://bugs.webkit.org/show_bug.cgi?id=192911
+        <rdar://problem/46861112>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/BoxModelDetailsSectionRow.js:
+        (WI.BoxModelDetailsSectionRow.prototype._updateMetrics.createBoxPartElement):
+        (WI.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaElement):
+        (WI.BoxModelDetailsSectionRow.prototype._updateMetrics):
+        ITMLKit doesn't always provide a display/position/width/height etc properties.
+        Protect against this, and just show an empty message in the box model section
+        if those properties do not exist.
+
 2018-12-20  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: UIString should take an optional key and description to aid localization