commit | a166574e40b1f7796f7753398341906252d109f9 | [log] [tgz] |
---|---|---|
author | graouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Sat Oct 16 10:16:32 2021 +0000 |
committer | graouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Sat Oct 16 10:16:32 2021 +0000 |
tree | 1b5b86ceac3b780d9f55abd961a762715ea4be99 | |
parent | a7cf0e702a30c1ac9edece163850bf91386874de [diff] |
CSS Animations creation and sorting is incorrect and may lead to crash https://bugs.webkit.org/show_bug.cgi?id=231812 <rdar://problem/82980774> Reviewed by Dean Jackson. LayoutTests/imported/w3c: Mark two progressions in a test that now passes entirely. * web-platform-tests/css/css-animations/Element-getAnimations-dynamic-changes.tentative-expected.txt: Source/WebCore: When we parse CSS properties related to CSS Animations, we create as many Animation objects as the maximum number of values in one of the CSS Animations properties. These Animation objects are stored in an AnimationList which is owned by RenderStyle and that we use to store all provided values such that they can be read back through the computed style. Upon finishing parsing those CSS properties, RenderStyle::adjustAnimations() is called and does two things that were not quite correct. First, it would attempt to remove animations that were in fact created for no good reason using the Animation::isEmpty() method. That method was not quite right as it was only checking if the animation name wasn't set but not whether the animation was explicitly marked as a "none" animation. This meant that "none" animations could be considered as bogus animations and any animations after that one would be mistakenly cleared. Second, it would finish process the list of remaning animations by making sure that mis-matched CSS properties, for instance three values for animation-duration and four values for animation-name, would be correctly represented throughout the Animation objects. However, the function performing this work, AnimationList::fillUnsetProperties(), used to reset the animation's name in case it wasn't explicitly set, which meant that Animation objects that did not have a matching animation-name would end up with a valid one. This meant that further down the line, in Styleable::updateCSSAnimations(), we couldn't distinguish Animation objects that were created without a matching animation-name and discard those. We've fixed those incorrect behaviors and we now have the expected number of animations created resulting in an additional WPT PASS result. Additionally, this also showed some issues around sorting CSS Animations in compareCSSAnimations() where we weren't making a pointer comparison. This is now fixed and we now pass another WPT PASS result. Test: webanimations/css-animation-sorting-crash.html * animation/WebAnimationUtilities.cpp: (WebCore::compareCSSAnimations): * platform/animation/Animation.h: (WebCore::Animation::isEmpty const): * platform/animation/AnimationList.cpp: (WebCore::AnimationList::fillUnsetProperties): LayoutTests: Add a new test that used to crash before the source change. * animations/animation-remove-element-crash.html: Remove a line that was now a failure since only a single animation should be created. * webanimations/css-animation-sorting-crash-expected.txt: Added. * webanimations/css-animation-sorting-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@284312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git@github.com:WebKit/WebKit.git WebKit
or
git clone https://github.com/WebKit/WebKit.git WebKit
If you want to be able to track Subversion revision from your git checkout, you can run the following command to do so:
Tools/Scripts/git-webkit setup-git-svn
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
iOS, tvOS and watchOS are all considered embedded builds. The first time after you install a new Xcode, you will need to run:
sudo Tools/Scripts/configure-xcode-for-embedded-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for embededded simulators:
Tools/Scripts/build-webkit --debug --<platform>-simulator
or embedded devices:
Tools/Scripts/build-webkit --debug --<platform>-device
where platform
is ios
, tvos
or watchos
.
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.