Adding few already supported features to the FeatureSet in DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=86482
Source/WebCore:
Text, Filter and View features are already implemented but they
are not added to the SVG11 feature set. This is corrected in this patch.
Reviewed by Nikolas Zimmermann.
No new testcase is needed because we already have one what checks the svg features via
DOMImplementation (svg/custom/svg-features.html).
* dom/DOMImplementation.cpp:
(WebCore::isSVG11Feature):
LayoutTests:
Reviewed by Nikolas Zimmermann.
* platform/qt-5.0/svg/custom/svg-features-expected.txt:
* platform/qt/svg/custom/svg-features-expected.txt:
* svg/custom/svg-features-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 53ca19e..4d07348 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
+2012-06-08 Renata Hodovan <reni@webkit.org>
+
+ Adding few already supported features to the FeatureSet in DOMImplementation
+ https://bugs.webkit.org/show_bug.cgi?id=86482
+
+ Reviewed by Nikolas Zimmermann.
+
+ * platform/qt-5.0/svg/custom/svg-features-expected.txt:
+ * platform/qt/svg/custom/svg-features-expected.txt:
+ * svg/custom/svg-features-expected.txt:
+
2012-06-07 Vincent Scheib <scheib@chromium.org>
Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
diff --git a/LayoutTests/platform/qt-5.0/svg/custom/svg-features-expected.txt b/LayoutTests/platform/qt-5.0/svg/custom/svg-features-expected.txt
index c9601e9..05db8b7 100644
--- a/LayoutTests/platform/qt-5.0/svg/custom/svg-features-expected.txt
+++ b/LayoutTests/platform/qt-5.0/svg/custom/svg-features-expected.txt
@@ -26,7 +26,7 @@
"http://www.w3.org/TR/SVG11/feature#Style", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#ViewportAttribute", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Shape", "1.1": true, true
-"http://www.w3.org/TR/SVG11/feature#Text", "1.1": false, false
+"http://www.w3.org/TR/SVG11/feature#Text", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#BasicText", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#PaintAttribute", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#BasicPaintAttribute", "1.1": true, true
@@ -40,7 +40,7 @@
"http://www.w3.org/TR/SVG11/feature#Clip", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#BasicClip", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Mask", "1.1": true, true
-"http://www.w3.org/TR/SVG11/feature#Filter", "1.1": false, false
+"http://www.w3.org/TR/SVG11/feature#Filter", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#BasicFilter", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#DocumentEventsAttribute", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#GraphicalEventsAttribute", "1.1": true, true
@@ -49,7 +49,7 @@
"http://www.w3.org/TR/SVG11/feature#Hyperlinking", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#XlinkAttribute", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#ExternalResourcesRequired", "1.1": true, true
-"http://www.w3.org/TR/SVG11/feature#View", "1.1": false, false
+"http://www.w3.org/TR/SVG11/feature#View", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Script", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Animation", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Font", "1.1": true, true
diff --git a/LayoutTests/platform/qt/svg/custom/svg-features-expected.txt b/LayoutTests/platform/qt/svg/custom/svg-features-expected.txt
index 4588da6..46949d4 100644
--- a/LayoutTests/platform/qt/svg/custom/svg-features-expected.txt
+++ b/LayoutTests/platform/qt/svg/custom/svg-features-expected.txt
@@ -26,7 +26,7 @@
"http://www.w3.org/TR/SVG11/feature#Style", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#ViewportAttribute", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Shape", "1.1": true, true
-"http://www.w3.org/TR/SVG11/feature#Text", "1.1": false, false
+"http://www.w3.org/TR/SVG11/feature#Text", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#BasicText", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#PaintAttribute", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#BasicPaintAttribute", "1.1": true, true
@@ -40,7 +40,7 @@
"http://www.w3.org/TR/SVG11/feature#Clip", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#BasicClip", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Mask", "1.1": true, true
-"http://www.w3.org/TR/SVG11/feature#Filter", "1.1": false, false
+"http://www.w3.org/TR/SVG11/feature#Filter", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#BasicFilter", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#DocumentEventsAttribute", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#GraphicalEventsAttribute", "1.1": true, true
@@ -49,7 +49,7 @@
"http://www.w3.org/TR/SVG11/feature#Hyperlinking", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#XlinkAttribute", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#ExternalResourcesRequired", "1.1": true, true
-"http://www.w3.org/TR/SVG11/feature#View", "1.1": false, false
+"http://www.w3.org/TR/SVG11/feature#View", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Script", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Animation", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Font", "1.1": false, false
diff --git a/LayoutTests/svg/custom/svg-features-expected.txt b/LayoutTests/svg/custom/svg-features-expected.txt
index c9601e9..05db8b7 100644
--- a/LayoutTests/svg/custom/svg-features-expected.txt
+++ b/LayoutTests/svg/custom/svg-features-expected.txt
@@ -26,7 +26,7 @@
"http://www.w3.org/TR/SVG11/feature#Style", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#ViewportAttribute", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Shape", "1.1": true, true
-"http://www.w3.org/TR/SVG11/feature#Text", "1.1": false, false
+"http://www.w3.org/TR/SVG11/feature#Text", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#BasicText", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#PaintAttribute", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#BasicPaintAttribute", "1.1": true, true
@@ -40,7 +40,7 @@
"http://www.w3.org/TR/SVG11/feature#Clip", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#BasicClip", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Mask", "1.1": true, true
-"http://www.w3.org/TR/SVG11/feature#Filter", "1.1": false, false
+"http://www.w3.org/TR/SVG11/feature#Filter", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#BasicFilter", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#DocumentEventsAttribute", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#GraphicalEventsAttribute", "1.1": true, true
@@ -49,7 +49,7 @@
"http://www.w3.org/TR/SVG11/feature#Hyperlinking", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#XlinkAttribute", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#ExternalResourcesRequired", "1.1": true, true
-"http://www.w3.org/TR/SVG11/feature#View", "1.1": false, false
+"http://www.w3.org/TR/SVG11/feature#View", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Script", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Animation", "1.1": true, true
"http://www.w3.org/TR/SVG11/feature#Font", "1.1": true, true
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 7347ffc..69f170d 100644
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,19 @@
+2012-06-08 Renata Hodovan <reni@webkit.org>
+
+ Adding few already supported features to the FeatureSet in DOMImplementation
+ https://bugs.webkit.org/show_bug.cgi?id=86482
+
+ Text, Filter and View features are already implemented but they
+ are not added to the SVG11 feature set. This is corrected in this patch.
+
+ Reviewed by Nikolas Zimmermann.
+
+ No new testcase is needed because we already have one what checks the svg features via
+ DOMImplementation (svg/custom/svg-features.html).
+
+ * dom/DOMImplementation.cpp:
+ (WebCore::isSVG11Feature):
+
2012-06-08 Stephen Chenney <schenney@chromium.org>
WebCore::ImageBuffer.cpp has broken color table code
diff --git a/Source/WebCore/dom/DOMImplementation.cpp b/Source/WebCore/dom/DOMImplementation.cpp
index dd197c6..4d3d853 100644
--- a/Source/WebCore/dom/DOMImplementation.cpp
+++ b/Source/WebCore/dom/DOMImplementation.cpp
@@ -147,7 +147,7 @@
addString(svgFeatures, "Style");
addString(svgFeatures, "ViewportAttribute");
addString(svgFeatures, "Shape");
-// addString(svgFeatures, "Text"); // requires altGlyph, bug 6426
+ addString(svgFeatures, "Text");
addString(svgFeatures, "BasicText");
addString(svgFeatures, "PaintAttribute");
addString(svgFeatures, "BasicPaintAttribute");
@@ -162,7 +162,7 @@
addString(svgFeatures, "BasicClip");
addString(svgFeatures, "Mask");
#if ENABLE(FILTERS)
-// addString(svgFeatures, "Filter");
+ addString(svgFeatures, "Filter");
addString(svgFeatures, "BasicFilter");
#endif
addString(svgFeatures, "DocumentEventsAttribute");
@@ -172,7 +172,7 @@
addString(svgFeatures, "Hyperlinking");
addString(svgFeatures, "XlinkAttribute");
addString(svgFeatures, "ExternalResourcesRequired");
-// addString(svgFeatures, "View"); // buggy <view> support, bug 16962
+ addString(svgFeatures, "View");
addString(svgFeatures, "Script");
addString(svgFeatures, "Animation");
#if ENABLE(SVG_FONTS)
