commit | 9ab0bd93f5687e5bea53f2c090f6e25539969bf0 | [log] [tgz] |
---|---|---|
author | tyler_w@apple.com <tyler_w@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Thu Jan 27 16:51:29 2022 +0000 |
committer | tyler_w@apple.com <tyler_w@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Thu Jan 27 16:51:29 2022 +0000 |
tree | 07343fbe5e16bdf435d56b7cf114e041922b064d | |
parent | ffe3159ed4fefc7a238a8cda7050410c7c93865a [diff] |
AX ITM: Defer to the tree when determining AX object loading progress https://bugs.webkit.org/show_bug.cgi?id=235646 Reviewed by Andres Gonzalez. Source/WebCore: Currently, we set AXPropertyName::IsLoaded and AXPropertyName::EstimatedLoadingProgress once in AXIsolatedObject::initializeAttributeData and never update it. This means that if an object is created while the page is at some non-100% load percentage, AX clients that request these attributes will always think the object isn't loaded. This patch removes these two properties and instead defers to the isolated tree associated with each object when determining the load percentage. Both of these properties were based on the entire page / document load progress anyways, so it doesn't make sense to set the same value for all of them. We track loading progress by changing ProgressTracker to also notify the page when progress changes, which in turn updates the associated AXObjectCache with the new progress value. Covered by accessibility/mac/document-attributes.html which verifies the AXLoad and AXLoadingProgress attributes. * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::AXObjectCache): (WebCore::AXObjectCache::updateLoadingProgress): Added. * accessibility/AXObjectCache.h: (WebCore::AXObjectCache::loadingFinished): (WebCore::AXObjectCache::loadingProgress const): Added. * accessibility/AccessibilityObject.h: * accessibility/AccessibilityObjectInterface.h: * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::loadingProgress const): (WebCore::AccessibilityRenderObject::estimatedLoadingProgress const): Rename estimatedLoadingProgress methods to loadingProgress. * accessibility/AccessibilityRenderObject.h: * accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::initializeAttributeData): * accessibility/isolatedtree/AXIsolatedObject.h: * accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::create): (WebCore::AXIsolatedTree::updateLoadingProgress): (WebCore::AXIsolatedTree::applyPendingChanges): Apply m_pendingEstimatedLoadingProgress. * accessibility/isolatedtree/AXIsolatedTree.h: (WebCore::AXIsolatedTree::loadingProgress): Added. * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): Handle rename of estimatedLoadingProgress methods to loadingProgress. * loader/ProgressTracker.cpp: (WebCore::ProgressTracker::ProgressTracker): Store a reference to the associated page in new m_page member. (WebCore::ProgressTracker::progressStarted): (WebCore::ProgressTracker::progressEstimateChanged): (WebCore::ProgressTracker::finalProgressComplete): (WebCore::ProgressTracker::incrementProgress): Notify the Page when progress changes or completes. * loader/ProgressTracker.h: * page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::progressEstimateChanged const): Added. (WebCore::Page::progressFinished const): Added. * page/Page.h: LayoutTests: * accessibility/mac/document-attributes-expected.txt: Associated test now uses js-test.js, so modify expectations to include js-test output (e.g. test description()). * accessibility/mac/document-attributes.html: Wait asynchronously for loading to complete ("AXLoaded: 1"). * accessibility/parent-delete.html: Don't output all attributes, since it's not necessary for the purpose of the test (which is to ensure calling allAttributes() in this scenario doesn't cause a crash). Previously, the test output contained loading AX attributes, so rather than making this test wait for loading to complete I decided to remove the output all together. * platform/mac/accessibility/parent-delete-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@288674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git@github.com:WebKit/WebKit.git WebKit
or
git clone https://github.com/WebKit/WebKit.git WebKit
If you want to be able to track Subversion revision from your git checkout, you can run the following command to do so:
Tools/Scripts/git-webkit setup-git-svn
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
iOS, tvOS and watchOS are all considered embedded builds. The first time after you install a new Xcode, you will need to run:
sudo Tools/Scripts/configure-xcode-for-embedded-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for embedded simulators:
Tools/Scripts/build-webkit --debug --<platform>-simulator
or embedded devices:
Tools/Scripts/build-webkit --debug --<platform>-device
where platform
is ios
, tvos
or watchos
.
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.